summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup private QWidget functions.Bjørn Erik Nilsen2009-05-126-114/+43
| | | | | | | | I actually found a few functions that were not even implemented, only declared. Those should obviously not be in the header file. I've also removed a few functions not in use / not belonging to QWidgetPrivate. Reviewed-by: Olivier
* Reduce QWidget footprint and do some cleanup.Bjørn Erik Nilsen2009-05-127-350/+332
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch cleans up several things, like bit fields that are interleaved with with other variables, resulting in bits not being packed properly. Example: "uint a : 8; int c; uint b: 8;" -> "uint a : 8; uint b : 8; int c;" In that case we'll use 12 bytes instead of 8 bytes. I've also changed the order we declare certain variables to avoid unnecessary gaps/padding on 64-bit architectures. Example: "char *a; int c; char *b;" -> "char *a; char *b; int c;" Pointers are 64-bit aligned, so padding appears between 'c' and 'b', resulting in a total use of 24 bytes instead of 20 bytes. ...and since I anyways was moving the code around, I took the opportunity to add some overall structure by first declaring cross-platform functions/variables followed by platform specific functions/variables. ...and it was kinda scary to actually be able to see all the QStrings, pointers and whatnot we put into QWidgetPrivate. I'm sure we can remove lots of stuff, but I'll do that in a separate commit. Quick numbers (X11/64 bit): sizeof(QWidgetPrivate) == before: 472, after: 456 sizeof(QTLWExtra) == before: 112, after: 104 sizeof(QWExtra) == before: 152, after: 144 Acked-by: Olivier
* Ensure that windows hidden by deletion affect closeOnLastWindowNorwegian Rock Cat2009-05-121-1/+1
| | | | | | | | Our destructor didn't call close, which meant that we never emitted lastWindowClosed. Task-number: 253333 Reviewed-by: Bradley T. Hughes
* The description cited MySQL and the code is for PostgreSQL.Benjamin Poulain2009-05-121-1/+1
| | | | | Task-number: 253427 Reviewed-by: TrustMe
* QListView was assuming that selected indexes were always children ofThierry Bastian2009-05-121-2/+6
| | | | | | | | | | their root. This can be different. ...especially if one manages the selection by program or if you share the selection model with a treeview. Task-number: 196118 Reviewed-by: ogoffart
* The editor geometry in item views is not correctly updated when 1stThierry Bastian2009-05-121-1/+1
| | | | | | | | | | shown The problem is that it gets the previous geometry of the cell whereas its own sizeHint might lead to change the geometry of the cell. Task-number: 253109 Reviewed-by: ogoffart
* Fixed dumping so that we dump both q_yy and q_xx instead of q_yy twice.Jan-Arve Sæther2009-05-121-1/+1
| | | | | That code is only executed if the environment varible QT_GRAPHICSLAYOUT_DEBUG is set to1
* QSsl: Renamed testConnection to startHandshakeMarkus Goetz2009-05-122-7/+7
|
* Small documentation fix for QSslSocketMarkus Goetz2009-05-121-2/+2
| | | | Reviewed-by: Kavindra
* Don't overwrite q_yy with q_xx when we are dumping the layout.Jan-Arve Sæther2009-05-121-9/+9
| | | | | Luckilly, that bug was only there if you had QT_GRAPHICSLAYOUT_DEBUG set as an environment variable.
* Work around a limitation in QFormLayout - 0 width content marginsTrond Kjernaasen2009-05-121-4/+9
| | | | | aren't really supported. Also set the default focus to be the preview widget itself.
* Make the QPrintPreviewDialog use a QMainWindow with a proper QToolBar forTrond Kjernaasen2009-05-121-79/+56
| | | | its buttons.
* Draw the shadow before the page background to avoid antialiasing overlapsTrond Kjernaasen2009-05-121-22/+22
| | | | when the paper is drawn.
* Add the chart utility from qtestlib-tools.Morten Sørvig2009-05-121-19/+10
| | | | | | | | | | It is now possible run the benchmarks with "-chart" to generate charts for benchmarks that produce chartable data. See examples/qtestlib/tutorial5 for an example. This patch has minimal inpact on QTestLib itself. Most of the functionality is implemented in a separate tool which QTestLIb calls after detecting the chart command line option.
* Add a AA_MacDontSwapCtrlAndMeta application attribute.Norwegian Rock Cat2009-05-116-83/+162
| | | | | | | | | | | | | | | | | | This is to help undo the some magic that is in the Qt/Mac port. Qt automatically flips the Meta and Control keys on Mac. This is a "feature" that makes porting older programs that don't use standard shortcuts easier as Ctrl and Command usually map to the same shortcuts in the application. The upshot of this is that I need to strip the text() out of key events if they contain the Control or Meta modifier. This causes much headache for anyone writing a terminal emulator. Though they would still have to write special code because the keys are swapped anyway. This allows people to write the terminal emulator where hitting the Control key will really send a Control key modifier. We've also done the extra work to ensure that standard shortcuts work correctly regardless of what the value of the attribute is. That is, if you specify QKeySequence::Cut for a shortcut you can always hit Command+X and things will work.
* Add QKeySequence::Quit and QKeySequence::Preferences for standard keys.Norwegian Rock Cat2009-05-111-1/+7
| | | | | | | | These are handy to have and make it possible for people to not have to remember the specific sequences on the different platforms, though some don't have any. Reviewed-by: Jens Bache-Wiig
* Merge branches 'master' and 'master' of git@scm.dev.nokia.troll.no:qt/qtNorwegian Rock Cat2009-05-1138-280/+258
|\
| * Remove a warning on gcc.Alexis Menard2009-05-111-1/+0
| | | | | | | | | | | | We don't need Q_D if we don't use the d pointer. Reviewed-by:TrustMe
| * Add support for CMYK colors for the native QColorDialog on Mac OS X.Benjamin Poulain2009-05-112-12/+29
| | | | | | | | | | | | | | The native color picker on Mac supports CMYK colors but this was not available with QColorDialog because the colors were systematically converted to RGB. The color are now initialized with QColor and the result from the color panel is converted to the right format. Task-number: 253272 Reviewed-by: nrc
| * compilation fix for LinuxThierry Bastian2009-05-111-1/+1
| |
| * compilation fix for LinuxThierry Bastian2009-05-111-2/+2
| |
| * Merge branch '4.5'Thiago Macieira2009-05-115-13/+22
| |\
| | * Clarifying docs for QTextTable::splitCell()Morten Engvoldsen2009-05-111-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | Clarifying details about QTextTable::splitCell() regarding splitting and merging over several rows and columns Task-number:193732 Rev-by: Geir Vattekar
| | * Don't crash at runtime with when relaying a signal.Thiago Macieira2009-05-111-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have this function called qDBusInterfaceFromMetaObject that calculates the interface name from a given meta object. There's no need to duplicate the code here (and not do it right). All tests still pss. Task-number: 236955 Reviewed-by: Trust Me
| | * Document that we don't support NTLM version 2.Thiago Macieira2009-05-111-0/+9
| | | | | | | | | | | | | | | Task-number: 236925 Reviewed-by: Tor Arne Vestbø
| | * Merge branch '4.5' of git@scm.dev.nokia.troll.no:qt/qt into 4.5Andy Shaw2009-05-111-2/+2
| | |\
| | | * Don't leak memory when assigning scriptvalue to iteratorKent Hansen2009-05-111-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | The d-pointer was not deleted as it should be. Reviewed-by: Harald Fernengel
| | * | Fixes a code snippet for QPainter::xFormDev()Andy Shaw2009-05-111-2/+2
| | |/ | | | | | | | | | Reviewed-by: TrustMe
| * | Almost 200 symbols that didn't need to be exported.Thierry Bastian2009-05-1113-16/+14
| | |
| * | Compilation for debug buildsOlivier Goffart2009-05-111-12/+11
| | |
| * | Merge branch '4.5'Thiago Macieira2009-05-1116-77/+98
| |\ \ | | |/
| | * Make sure syncqt creates the Phonon/Global file.Thiago Macieira2009-05-111-0/+5
| | | | | | | | | | | | | | | The standard Phonon package has this file and it points to phononnamespace.h
| | * Prevented asynchronous access to non-thread safe libfontconfig API.Samuel Rødal2009-05-081-11/+32
| | | | | | | | | | | | | | | | | | | | | | | | We need to protect calls to FcCharSetHasChar with the font database mutex. Task-number: 241361 Reviewed-by: Simon Hausmann
| | * QDataStream: Small doc errorMarkus Goetz2009-05-081-1/+1
| | | | | | | | | | | | | | | Task-number: 253179 Reviewed-by: TrustMe
| | * Fixes a crash in QPrinterDialog with relative filenamesJoão Abecasis2009-05-082-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's better to set the sourceModel in the constructor for QFSCompletor, as requiring that it be set separately is error prone. Surprisingly, the printer dialog crash only appears to happen when using relative filenames. Task-number: 253135 Reviewed-by: alexis
| | * Fix QCompleter with UnfilteredPopupCompletionJoão Abecasis2009-05-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes regression introduced in a794ded85f74516239a08cf848e6b4f8b6dcac6a. When using UnfilteredPopupCompletion the matchCount is always zero and completion was being skipped. By adding the check for showAll we still avoid the assert but retain correct behavior. Task-number: 253125 Reviewed-by: jasplin
| | * Fix leak of file descriptors in QTemporaryFileJoão Abecasis2009-05-081-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using setFileName in QFile::copy (introduced recently) has a nasty side-effect of leaking file descriptors in QTemporaryFile. This happens because the code assumes the file has been closed. In QTemporaryFile, we need to explicitly call native file engine close. Test case by Thiago. Bug report from Arora developers. Reviewed-by: thiago
| | * compile?Harald Fernengel2009-05-081-1/+1
| | |
| | * Added further explanation on the note about stdin and QTextsStream::atEnd()Morten Engvoldsen2009-05-081-2/+4
| | | | | | | | | | | | | | | | | | | | | Explained why you cannot use stdin and atEnd() together. Task-number:251171 Rev-by: Andreas Aardal Hanssen
| | * Fix reentrency of the QCSS engine.Olivier Goffart2009-05-081-10/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | QTextDocument which is suposed to be reentrant may use the CSS Parser in different threads. The way the indexOfId was computed is not thread safe. Insert the pre-computed value instead Reviewed-by: Thierry
| | * Fix reentrancy of QVector and QStringOlivier Goffart2009-05-082-2/+2
| | | | | | | | | | | | | | | | | | The d->capacity could be modified even if ref was more than 1 Reviewed-by: Marius Storm-Olsen
| | * Fixes QDir not reentrantOlivier Goffart2009-05-081-29/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | qt_cmp_si_sort_flags could be read and written from different threads. Use qStableSort with functor instead of libc's quicksort. Found with helgrind on kdevelop Reviewed-by: Marius Storm-Olsen
| | * Merge branch '4.5' of git@scm.dev.nokia.troll.no:qt/qt into 4.5Martin Smith2009-05-082-4/+3
| | |\
| | | * Revert "Added comment to QTextStream - clarification of the documentation"Morten Engvoldsen2009-05-081-2/+1
| | | | | | | | | | | | | | | | This reverts commit da1416cef6b1d24156739ded101df895ee4e80d9.
| | | * Fixed a problem with QPrinter::NativeFormat printers not being valid.Trond Kjernåsen2009-05-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It's obvious that not only PDF and PS printers are valid.. Task-number: related to 252873 Reviewed-by: Samuel
| | * | qdoc: Moved platform-specific qdoc comments to common .cpp file.Martin Smith2009-05-082-13/+14
| | |/ | | | | | | | | | | | | | | | | | | | | | | | | When building docs for the mac, qdoc comments for functions defined in the .h file were not found in any of the .cpp files in the mac package because they were in the x11 or windows .cpp file. So I moved them to a .cpp file that is in all the packages. Task-number: 252496 252492
| | * Fixes QIBASE driver crashes on multiple execution of a prepared queryBill King2009-05-071-3/+3
| | | | | | | | | | | | Task-number: 246808
| * | Fixed resetting error mode on Windows on error when stat'ing a file.Denis Dzyubenko2009-05-111-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | We shouldn't return since the SetErrorMode was called and we need to reset it back afterwards. Patch-by: ritt.k Reviewed-by: mauricek
| * | Faster slot disconnection while destroying of QObjectOlivier Goffart2009-05-112-150/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Destroying a QObject which is connected to many signals was slow. We had to loop over all the ConnectionsList of all the connected object to remove the connections. (in QObjectPrivate::removeReceiver) The idea is to now use lists of pointer to Connection both in the connection list, and in the list of senders. So clearing the connection should be faster. Task-number: 251097 Reviewed-by: Brad
* | | Remove a comment.Norwegian Rock Cat2009-05-111-1/+0
|/ /