| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|\ |
|
| |
| |
| |
| |
| |
| | |
This is a backport of commit 8ac7e81260
Reviewed-by: Peter Hartmann
|
| |
| |
| |
| |
| |
| |
| |
| | |
Simple misuse of QLatin1String. Use QString::fromLatin1 instead and
avoid the QByteArray temporary.
Reviewed-by: Andreas Aardal Hanssen
Tracking: CVE-2009-2700
|
| |
| |
| |
| |
| |
| | |
This function only returns the certificates bundled with Qt.
Reviewed-by: TrustMe
|
|/
|
|
|
|
|
|
|
|
|
|
| |
The text:
When the current size of the cache is greater then the
maximumCacheSize()
should read
When the current size of the cache is greater than the
maximumCacheSize()
Task-number: 260496
Reviewed-by: Zheng Liu (George)
|
|
|
|
|
|
|
|
|
| |
encoded JPEG
CMKY encoded JPEG code missing from scaled image JPEG loading
Task-number: 260192
Reviewed-by: Stian Sandvik Thomassen
|
|
|
|
|
|
|
|
| |
The subControlRect of the arrow and the listBoxPopup where assuming
the widget rect is at the origin.
Reviewed-by: Richard Moe Gustavsen
Reviewed-by: Pierre Rossi
|
|
|
|
|
|
|
|
| |
With line wrapping enabled and very large text blocks, painting errors
could occur.
Reviewed-by: hjk
(cherry picked from commit 82dba1d346a6f4a5d2602d930e0aed75c13bcafb)
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
Don't initialize the members of BasicNodeData. They don't need to be
initialized, and m_kind has no sane default value anyway.
Reviewed-by: Frans Englich <frans.englich@nokia.com>
|
| |
| |
| |
| |
| |
| | |
See commit ff86781b9b18ba376a8983fcb83847a09820ef79, where it becomes
clear that it was meant to say 7 bits, which explains the bit about the
padding bit.
|
| |
| |
| |
| |
| |
| |
| | |
Ensure that class members are initialized
Moved some value assignment from constructor body into the the constructor's intializer list
Reviewed-by: Jason McDonald
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The old code assumed viewBox value of the form "x y w h" or "x,y,w,h",
and would crash when parsing "x,y w,h" (when accessing the fourth list
item which would be out-of-bounds).
Reviewed-by: Trond
Reviewed-by: Kim
|
| |
| |
| |
| |
| |
| |
| |
| | |
The size of the text, computed in qreal, was rounded. If the decimal
part of the size was < 0.5, a pixel was missing in the size returned.
Reviewed-by: Samuel Rødal
Reviewed-by: Olivier Goffart
|
| |
| |
| |
| |
| |
| |
| | |
The edit area of the spinbox should take complete surface of the
widget when the button symbol is QAbstractSpinBox::NoButtons.
Reviewed-by: Richard Moe Gustavsen
|
| |
| |
| |
| |
| |
| |
| | |
The edit area of the spinbox should take complete surface of the
widget when the button symbol is QAbstractSpinBox::NoButtons.
Reviewed-by: Richard Moe Gustavsen
|
| |
| |
| |
| | |
Reviewed-by: Trond
|
| |
| |
| |
| |
| |
| |
| |
| | |
The server color layout test was a bit to harsh, since it excluded
16 bit X11 servers with RGB layout.
Task-number: 259846
Reviewed-by: Gunnar
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Problem introduced by 7661126bc86ed105c02fd9b084ac5a91f12f10c4, which
introduced always rounding up when converting the rectangle's
coordinates to integers. This would e.g. cause off-by-one errors for the
cursor in QTextDocument. Some code paths depended on the ceiling of the
coordinates, and these have been reverted.
Task-number: 257914
Reviewed-by: Samuel
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes a regression when computing the clip path for a
QGraphicsWidget that clip its children to its shape. The clip path cache
use the bounding rect which has a null width and height the very first
time on a QGraphicsWidget. This might happen as well for any item that
have a null width and height (e.g. QGraphicsRectItem before you set the
rect). We should do better in mainline by refactoring this clip path
cache and calling it in prepareGeometryChange which should be called
when you update the shape and the boundingRect of the item. Do we
really need also in 4.6/mainline the clip path as it is now? This should
be investigate also. The auto-test cover the problem so we can use it
after for refactoring the cached clip path.
Task-number: 257232
Reviewed-by: andreas
Reviewed-by: bnilsen
|
| |
| |
| |
| |
| |
| | |
Fixes https://bugs.webkit.org/show_bug.cgi?id=28016
Reviewed-by: andreas
|
| |
| |
| |
| |
| |
| | |
Whitespaces in identifiers now past autotests
Reviewed-by:Bill King
|
| |
| |
| |
| |
| |
| |
| | |
We must not retrieve the initial window geometry for
WA_DontShowOnScreen widgets with GetClientRect.
Reviewed-by: thartman
|
| |
| |
| |
| |
| |
| |
| | |
We could do it or we couldn't. It's simply a judgement call and I think
the comments in the task are a good argument for NOT doing it.
Task-number: 227875
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The style was assuming that the combo box is painted at (0,0). This is
not the case when the painting is done in the delegate of an item view.
The offset of the rect is now taken into account to paint the style.
HIRect has been replaced by QRect when it make sense.
Task-number: 00026815
Reviewed-by: Richard Moe Gustavsen
|
| |
| |
| |
| |
| |
| |
| |
| | |
The function hitTestComplexControl() of the mac style returned
SC_ComboBoxArrow when the point is not over an element of the widget.
Task-number: 252857
Reviewed-by: Richard Moe Gustavsen
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A QPushButton with a height if (say) three pixels would cause
HIThemeGetButtonContentBounds ot return a rect with dimentions
{int_min, int_min, 0, 0}. Detect that case and return the button
rect instead.
Reviewed-by: Trust Me
|
| |
| |
| |
| |
| |
| |
| |
| | |
The magic number 22 was based on windows sized icons, a size of 16
should be correct for mac
Task-number: 259289
Reviewed-by: NRC
|
| |
| |
| |
| |
| |
| |
| |
| | |
That should fix compilation on platforms that do not have xinput
headers installed.
Reviewed-by: Thiago Macieira
(cherry picked from commit 0a13188468997d6c3253db5b29f05a119945f131)
|
| |
| |
| |
| |
| |
| |
| | |
Code is adapted from QCommonStyle which handles this case for other
styles.
Reviewed-by: thartman
|
| |
| |
| |
| |
| |
| |
| |
| | |
This function was too strict. It returned 0 if the property wasn't of
type QVariant::Double. Now it tests for QMetaType::Float too.
Reviewed-by: kh1
Reviewed-by: mauricek
|
| |
| |
| |
| |
| |
| |
| |
| | |
Widgets with the WA_DontShowOnScreen attribute must not have a window
decoration.
Autotest: tst_QWidget::initialPosForDontShowOnScreenWidgets
Reviewed-by: thartman
|
| |
| |
| |
| |
| |
| | |
This reverts commit 6844dea0cb583a86bc72e7f008720ab76deef040.
added to wrong branch. should be in 4.6 but this was added to 4.5
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
calendar popup
A frame was always drawn around the QDateTimeEdit editor if a popup
calendar had been set. QStyleOptionsComboBox options are being set in
paintEvent and initialised from the properties of QStyleOptionsSpinBox but
were missing the frame bool property. Now, if the user sets a frame on the
QDateTimeEdit, this property will be consistent with setFrame() property
of the QDateTimeEdit widget.
|
| |
| |
| |
| | |
Task-number: 259482
|
| |
| |
| |
| | |
Reviewed-by: Trust Me
|
| |
| |
| |
| | |
Reviewed-by: Trust Me
|
| |
| |
| |
| | |
Reviewed-by: Trust Me
|
| |
| |
| |
| | |
Reviewed-by: Trust Me
|
| |
| |
| |
| | |
Reviewed-by: Trust Me
|
| |
| |
| |
| | |
Reviewed-by: Trust Me
|
| |
| |
| |
| | |
Reviewed-by: Trust Me
|
| |
| |
| |
| |
| | |
After the coverity fix, the proper code path executed, which failed to
enquote the date field properly, so this fix fixes that issue.
|
| |
| |
| |
| | |
Found by coverity.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When using streaming, it could happen that the last reference to the
MediaSource is in another thread. So the objects are destroyed from
another thread. In which case we would delete QObject (ioDevice) in
another thread. That is fixed by calling deleteLater which will ensure
that they are deleted in their own thread.
Note: there was a nother assert that could happen due to a race
condition in the worker thread. That is also fixed with this patch.
Reviewed-by: jbache
|
| |
| |
| |
| |
| |
| |
| | |
Also, the info() function was modified to use an assert rather than an
pointer check with an if to make it consistent with the rest of the file.
Reviewed-by: jesperht
|
| |
| |
| |
| | |
(cherry picked from commit cb64ac587249f5dc6563a035e2ef5a3ad2bc5d13)
|
| |
| |
| |
| |
| |
| |
| | |
Task-number: 259143
Merge-request: 1119
Reviewed-by: Denis Dzyubenko <denis.dzyubenko@nokia.com>
|