| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Seems like some old legacy code was left behind when sheets behaved as
application modal. This is not the case anymore, so this patch just
removes the special case code for enforcing the old behaviour, and let
carbon do the correct thing instead.
Task-number: 252379
Reviewed-by: Trenton Schulz
|
|
|
|
|
|
| |
Uses fb_interpret instead of isc_interprete if using firebird. Closes a potential security hole/buffer overrun.
Reviewed-by: Justin McPherson
|
|
|
|
|
|
|
| |
The WinCE build was failing due to a spelling error in an #ifdef
directive.
Reviewed-by: Trust Me
|
|
|
|
|
|
|
|
| |
responses to POST might be cacheable, but are not cacheable by default;
responses to PUT or DELETE are never cacheable.
Reviewed-by: Thiago Macieira
Task-number: 252281
|
|
|
|
|
|
|
|
| |
Highlight part of the general description in QTimeLine
Task-number: 218487
Rev-by: Geir Vattekar
|
|
|
|
|
|
|
|
| |
Adding note about requriements for converting QVariants
Task-number: 192607
Rev-by: David Boddie
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's no need for using QByteArrayMatcher for one single character,
so avoid the overhead.
Also validate the message header a bit more: we require the status
line to start with "HTTP/n.m " where n and m are positive integers
less than 10.
Task-number: 248838
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
|
|
|
| |
proper HTTP reply.
If the server's reply doesn't start with "HTTP/", then the reply is
not valid. This could happen if we connected via HTTP to an HTTPS
server. It could also happen with an Icecast server (reply ICY/x.y).
Task-number: 248838
Reviewed-by: Markus Goetz
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
In QGraphicsScene::_q_emitUpdated() the slot
QGrpahicsView::updateScene(QList<QRectF>) gets connected and a boolean
(connectedToScene) is set to prevent double connections. The problem is
that this boolean was not reset when the view gets a new scene.
Task-number: 253415
Reviewed-by: andreas
|
|
|
|
| |
Reviewed-by: thartman
|
|
|
|
|
|
|
| |
If a QSqlQuery survived the lifetime of removal of a mysql db connection (that failed), the cleanup code would cause a segfault because it was using an out of date pointer that was pointing at memory that'd been freed by the removeDatabase() call.
Revby: Justin McPherson
Task-number: 205701
|
|
|
|
| |
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
| |
addFile makes a QIcon not null, which may be a surprise if the path
given is bad.
Reviewed-by: Jens Bache-Wiig
|
|
|
|
|
|
|
| |
There was a qFree() call missing.
Task-number: related to 253367
Reviewed-by: jbache
|
|
|
|
|
| |
Task-number: 253427
Reviewed-by: TrustMe
|
|
|
|
| |
Q_ACCESSIBLE_OBJECT was missing
|
|
|
|
|
|
|
| |
Clearifying details about bit size of the wchar_t input and the way they are handled.
Task-number:227709
Rev-by: Marius Storm-Olsen
|
|
|
|
|
|
|
|
|
|
|
| |
The handling of gradients with object bounding mode on pens in the
emulation paint engine has been changed to agree with the SVG standard,
where pen widths are ignored when calculating bounding boxes. Instead
of converting strokes to fills and then transforming the gradients
based on the fills' bounding box, the gradients are now transformed
first based on the bounding box of the stroke path.
Reviewed-by: Trond
|
|
|
|
|
|
|
|
|
| |
For a QGraphicsWidget w, a shortcut with Qt::WidgetWithChildren context would
trigger even if w did not have focus (provided no other widgets in the view
had focus).
Reviewed-by: andreas
Task-number: 250119
|
|
|
|
|
|
| |
Since this is C there are no constructors.
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
| |
QDirecttFBPixmapData => QDirectFBPixmapData
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
| |
If an application calls QIcon::actualSize() for SVG based icons, before
the icon is drawn for the first time, the actualSize() call will
result in the SVG file being loaded and parsed for each call.
Instead of doing that, just render a pixmap of the queried size and
then the resulting actualSize() calls will used the size of the
cached pixmap.
Task-number: related to 251106
Reviewed-by: Kim
|
|
|
|
| |
Reviewed-by: Peter Hartmann
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
We use MIPS2 instructions in the inline assembler, so we need to make
sure that the assembler is informed of this.
Task-number: 253275
Reviewed-by: thiago
|
| |
| |
| |
| |
| |
| |
| | |
Explained the role of the key attribute.
Task-number:246839
Rev-by: Richard Moe Gustavsen
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In older Freetype headers FT_LCD_FILTER_DEFAULT is apparently defined to
be ((const FT_Byte*)(void*)(ft_ptrdiff_t)1), which leads to a compile
error due to precision loss when casting to int.
Task-number: 253186
Reviewed-by: Trond
|
| |
| |
| |
| |
| |
| |
| |
| | |
Clarifying details about QTextTable::splitCell() regarding
splitting and merging over several rows and columns
Task-number:193732
Rev-by: Geir Vattekar
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We have this function called qDBusInterfaceFromMetaObject that
calculates the interface name from a given meta object. There's no
need to duplicate the code here (and not do it right).
All tests still pss.
Task-number: 236955
Reviewed-by: Trust Me
|
| |
| |
| |
| |
| | |
Task-number: 236925
Reviewed-by: Tor Arne Vestbø
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
The d-pointer was not deleted as it should be.
Reviewed-by: Harald Fernengel
|
| |/
| |
| |
| | |
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| | |
The standard Phonon package has this file and it points to
phononnamespace.h
|
|/ |
|
|
|
|
|
|
|
|
| |
We need to protect calls to FcCharSetHasChar with the font database
mutex.
Task-number: 241361
Reviewed-by: Simon Hausmann
|
|
|
|
|
| |
Task-number: 253179
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
| |
It's better to set the sourceModel in the constructor for QFSCompletor,
as requiring that it be set separately is error prone.
Surprisingly, the printer dialog crash only appears to happen when using
relative filenames.
Task-number: 253135
Reviewed-by: alexis
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes regression introduced in a794ded85f74516239a08cf848e6b4f8b6dcac6a.
When using UnfilteredPopupCompletion the matchCount is always zero and
completion was being skipped. By adding the check for showAll we still
avoid the assert but retain correct behavior.
Task-number: 253125
Reviewed-by: jasplin
|
|
|
|
|
|
|
|
|
|
|
| |
Using setFileName in QFile::copy (introduced recently) has a nasty
side-effect of leaking file descriptors in QTemporaryFile. This happens
because the code assumes the file has been closed. In QTemporaryFile,
we need to explicitly call native file engine close.
Test case by Thiago. Bug report from Arora developers.
Reviewed-by: thiago
|
| |
|
|
|
|
|
|
|
| |
Explained why you cannot use stdin and atEnd() together.
Task-number:251171
Rev-by: Andreas Aardal Hanssen
|
|
|
|
|
|
|
|
|
| |
QTextDocument which is suposed to be reentrant may use the CSS Parser in
different threads.
The way the indexOfId was computed is not thread safe.
Insert the pre-computed value instead
Reviewed-by: Thierry
|
|
|
|
|
|
| |
The d->capacity could be modified even if ref was more than 1
Reviewed-by: Marius Storm-Olsen
|
|
|
|
|
|
|
|
|
|
| |
qt_cmp_si_sort_flags could be read and written from different threads.
Use qStableSort with functor instead of libc's quicksort.
Found with helgrind on kdevelop
Reviewed-by: Marius Storm-Olsen
|
|\ |
|
| |
| |
| |
| | |
This reverts commit da1416cef6b1d24156739ded101df895ee4e80d9.
|