| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
We don't need Q_D if we don't use the d pointer.
Reviewed-by:TrustMe
|
|
|
|
|
|
|
| |
The native color picker on Mac supports CMYK colors but this was not available with QColorDialog because the colors were systematically converted to RGB. The color are now initialized with QColor and the result from the color panel is converted to the right format.
Task-number: 253272
Reviewed-by: nrc
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Clarifying details about QTextTable::splitCell() regarding
splitting and merging over several rows and columns
Task-number:193732
Rev-by: Geir Vattekar
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We have this function called qDBusInterfaceFromMetaObject that
calculates the interface name from a given meta object. There's no
need to duplicate the code here (and not do it right).
All tests still pss.
Task-number: 236955
Reviewed-by: Trust Me
|
| |
| |
| |
| |
| | |
Task-number: 236925
Reviewed-by: Tor Arne Vestbø
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
The d-pointer was not deleted as it should be.
Reviewed-by: Harald Fernengel
|
| |/
| |
| |
| | |
Reviewed-by: TrustMe
|
| | |
|
| | |
|
|\ \
| |/ |
|
| |
| |
| |
| |
| | |
The standard Phonon package has this file and it points to
phononnamespace.h
|
| |
| |
| |
| |
| |
| |
| |
| | |
We need to protect calls to FcCharSetHasChar with the font database
mutex.
Task-number: 241361
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| | |
Task-number: 253179
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It's better to set the sourceModel in the constructor for QFSCompletor,
as requiring that it be set separately is error prone.
Surprisingly, the printer dialog crash only appears to happen when using
relative filenames.
Task-number: 253135
Reviewed-by: alexis
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes regression introduced in a794ded85f74516239a08cf848e6b4f8b6dcac6a.
When using UnfilteredPopupCompletion the matchCount is always zero and
completion was being skipped. By adding the check for showAll we still
avoid the assert but retain correct behavior.
Task-number: 253125
Reviewed-by: jasplin
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Using setFileName in QFile::copy (introduced recently) has a nasty
side-effect of leaking file descriptors in QTemporaryFile. This happens
because the code assumes the file has been closed. In QTemporaryFile,
we need to explicitly call native file engine close.
Test case by Thiago. Bug report from Arora developers.
Reviewed-by: thiago
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Explained why you cannot use stdin and atEnd() together.
Task-number:251171
Rev-by: Andreas Aardal Hanssen
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QTextDocument which is suposed to be reentrant may use the CSS Parser in
different threads.
The way the indexOfId was computed is not thread safe.
Insert the pre-computed value instead
Reviewed-by: Thierry
|
| |
| |
| |
| |
| |
| | |
The d->capacity could be modified even if ref was more than 1
Reviewed-by: Marius Storm-Olsen
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
qt_cmp_si_sort_flags could be read and written from different threads.
Use qStableSort with functor instead of libc's quicksort.
Found with helgrind on kdevelop
Reviewed-by: Marius Storm-Olsen
|
| |\ |
|
| | |
| | |
| | |
| | | |
This reverts commit da1416cef6b1d24156739ded101df895ee4e80d9.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It's obvious that not only PDF and PS printers are valid..
Task-number: related to 252873
Reviewed-by: Samuel
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
When building docs for the mac, qdoc comments for functions defined
in the .h file were not found in any of the .cpp files in the mac
package because they were in the x11 or windows .cpp file. So I
moved them to a .cpp file that is in all the packages.
Task-number: 252496 252492
|
| |
| |
| |
| | |
Task-number: 246808
|
| |
| |
| |
| |
| |
| |
| |
| | |
We shouldn't return since the SetErrorMode was called and we need to
reset it back afterwards.
Patch-by: ritt.k
Reviewed-by: mauricek
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Destroying a QObject which is connected to many signals was slow.
We had to loop over all the ConnectionsList of all the connected object
to remove the connections. (in QObjectPrivate::removeReceiver)
The idea is to now use lists of pointer to Connection both in the
connection list, and in the list of senders. So clearing the connection
should be faster.
Task-number: 251097
Reviewed-by: Brad
|
| | |
|
| |
| |
| |
| |
| |
| | |
- partly revert f0243e70e05a3368582fd0478d840096d6b60c3f as it broke the build due to widgets accessible plugins using QDockWidgetLayout
Reviewed-by: Rhys Weatherley
|
| | |
|
| |
| |
| |
| | |
Reviewed-by: ogoffart
|
| |
| |
| |
| | |
Reviewed-by: ogoffart
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
no more exported
designer was using QToolBarLayout members. We fixed that by using
styles.
Reviewed-by: Friedemann Kleint
Reviewed-by: ogoffart
|
| |
| |
| |
| |
| |
| | |
In the past, we checked on the existence of the pointer, but now that
this is controlled by the property, we need to also check the pointer in
the action event.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With this patch, commands no longer merge across block bounderies.
In order to have merging still work for the normal insertion and deletion
case, the unnecessary beginEditBlock()/endEditBlock() calls where
cleaned up.
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It seems that plugins were never explicitly unloaded, resulting in leaks
of the instance object. Added a static deleter to ensure deletion on
exit. The QPointer (previously in place) ensures we don't do a
double-free nor try to access an invalid pointer.
Task-number: 253013
Reviewed-by: mariusSO
|
| |
| |
| |
| |
| |
| |
| | |
Static variable was dynamically allocated but never freed.
Task-number: 253013
Reviewed-by: Thiago
|
| |
| |
| |
| | |
Reviewed-by: Thorbjørn
|
| |
| |
| |
| |
| |
| | |
Qt itself was O2 from 4.2 and up, this changes it for applications as well.
Reviewed-by: nrc
|
| |
| |
| |
| | |
Reviewed-by: thartman
|
|\ \
| |/
| |
| |
| |
| | |
Conflicts:
src/gui/painting/qbackingstore.cpp
src/gui/painting/qwindowsurface_raster.cpp
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When passing a printer that is set up to print to a PDF file into
QPrintDialog, the print dialog could invalidate the printer and
not update the validity of it in a proper manner.
Task-number: 252873
Reviewed-by: Samuel
|
| |
| |
| |
| | |
Reviewed-by: TrustMe
|
| |
| |
| |
| | |
Reviewed-by: nrc
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We must tell the system that we want to intercept the back key on
Windows mobile. Each toplevel widget that needs correct back key
behaviour needs to have a menu bar. Why? Ask Microsoft...
Task-number: 248846
Reviewed-by: thartman
|