| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Vista PNG format icons
Merge-request: 431
Reviewed-by: Joerg Bornemann <joerg.bornemann@trolltech.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Function setupGtkFileChooser is modified to optionally build a
map of GtkFileFilters. File dialog methods then use
gtk_file_chooser_get_filename to get the current GtkFileFilter
and look it up in the map produced by setupGtkFileChooser.
This value is then saved in the selectedFilter pointer.
Merge-request: 846
Reviewed-by: Jens Bache-Wiig <jbache@trolltech.com>
|
| |
|
| |
|
| |
|
|
|
|
| |
Reviewed-by: trustme
|
|
|
|
| |
Reviewed-by: Joerg
|
|
|
|
| |
The base function was \internal pr private.
|
| |
|
|\ |
|
| |
| |
| |
| | |
The base function was \internal pr private.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Windows Vista (& above) allows users to search from file dialogs. If user selects
multiple files belonging to different folders from these search results, the
GetOpenFileName() will return only one folder name for all the files. To retrieve
the correct path for all selected files, we have to use Common Item Dialog interfaces.
Task-number: 258087
Reviewed-by: Jens Bache-Wiig
|
|\ \
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/3rdparty/webkit/VERSION
src/3rdparty/webkit/WebCore/ChangeLog
src/3rdparty/webkit/WebCore/generated/JSDOMWindow.cpp
src/3rdparty/webkit/WebCore/page/DOMWindow.idl
src/corelib/io/qdiriterator.cpp
src/plugins/gfxdrivers/directfb/qdirectfbpaintengine.cpp
src/plugins/gfxdrivers/directfb/qdirectfbpixmap.h
tests/auto/qxmlquery/tst_qxmlquery.cpp
tools/linguist/lconvert/main.cpp
|
| |
| |
| |
| |
| |
| |
| | |
In Turkish, lowercase('I') is 'ı', which means comparing "iso-8859-1"
to "ISO-8859-1" will fail.
Reviewed-by: Denis Dzyubenko
|
| |
| |
| |
| |
| |
| |
| | |
Trivial fix. Reported by Michael Brasser.
Task-number: 258337
Reviewed-By: Peter Hartmann
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If you start a hand scrolling and during moving, you press another button
of the mouse than the left one, the scrolling suddently stop working.
In mouseReleaseEvent we just stop the hand scrolling if the button is
left.
Task:258356
Reviewed-by:janarve
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
disabled.
Spend a lot of time looking at this and at the CoreFoundation source
code and it seems that we really do get a notification even after the
notifier is disabled. I suspect there's a race condition between when we
disable the socket notifier, but the kernel flags it as needing a read,
then CoreFoundation just sends the notification without checking if the
CFSocket has been disabled. No further notifications come of course.
Since this breaks the invariant that was set in the assert, I'm
replacing it with an if check.
Task-number: 258198
Reviewed-by: Bradley T. Hughes
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
during application desctruction globalEngineCache is deleted as part
of Q_GLOBAL_STATIC macro. Other instances of code that happen to use
QRegex after the cache destruction will subsequently crash. Most common
reason are other Q_GLOBAL_STATIC instances which happen to use QRegExp
as part of their destructor.
Reviewed-by: Rhys Weatherley
|
| |
| |
| |
| |
| |
| | |
There is no QDirIterator::isValid() function.
Reviewed-by: David Boddie
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
pushSubDirectory was operating on nextFileInfo when it should really be
using the path received as argument.
This fixes an issue introduced when currentFilePath variable was
removed, that was exposed in the auto-tests; fixes a regression
introduced in 4.5.0 -- test case a couple of commits back.
This also allows refactoring calling code and avoid repetition.
Task-number: 258230
Reviewed-by: Olivier Goffart
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The difference between a canonical and absolute paths is subtle, and not
what QDirIterator is about. With this change, we still avoid loops
generated by symbolic links but won't duplicate entries because of these
differences.
While at it, when avoiding loops with symbolic links, please don't mess
with the next path! That only added inconsistency.
Reviewed-by: Olivier Goffart
|
| |
| |
| |
| |
| |
| |
| | |
One less variable to maintain reduces the number of bugs and improves
consistency.
Reviewed-by: Olivier Goffart
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
First, don't call QWSWindowSurface::winId() in the destructor, as it
will actually request a new id if there isn't already one around - which
is a bit silly and highlighted the "real" bug.
Second, make sure QWSDisplay::Data::takeId() asks for 1 new id before
waiting for more ids to arrive. This is because waitForCreation() calls
QWSServer::processEventQueue(). If the events in the queue cause
takeId() to be called, QWSDisplay::Data::takeId() gets called
recursively. Even though there will be a create 15 ids command in the
queue, that will only allow 15 QWSDisplay::Data::takeId() calls to
return. The 16th call to QWSDisplay::Data::takeId() on the stack will
not be able to return because all the IDs have been taken and (because
it has been called recursively) no new create id commands have been
generated. So the 16th call to takeId() spins in waitForCreate().
Reviewed-by: Paul
|
| |
| |
| |
| |
| | |
Task-number: 236891
Reviewed-By: David Boddie
|
| |
| |
| |
| |
| |
| |
| | |
86ea4dbb5a748491656d9621ecd58238bc3e3d82 accidentally took out this
line.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| | |
Make the code easier to read.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| | |
drawColorSpan is never called from anywhere so we might as well get rid
of the code.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| | |
If DSCAPS_SYSTEMONLY is specified we shouldn't try to create the surface
in video memory.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
DirectFB declares variables that are bit fields as enums.
E.g.
DFBSurfaceCapabilities caps;
caps |= DSCAPS_LOCK; // doesn't compile in C++
Work around this problem by declaring operators for these operations.
This greatly improves the readability of the code.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If the widget under mouse is hidden, Qt can generate a synthetic mouse move
event which gets delivered to the already hidden widget. This can then result
in the wrong item being selected.
Workaround: in QListView, ignore mouse move events when the widget is hidden.
Reviewed-by: Denis
|
| |
| |
| |
| | |
Reviewed-by: TrustMe
|
| |
| |
| |
| | |
Reviewed-by: Volker Hilsheimer
|
| |
| |
| |
| |
| |
| |
| | |
PorterDuff should only be enabled if the raster engine says it is. E.g.
if we're painting on a format with alpha.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| | |
Regression from Qt 4.4.
Task-number: 257990
Reviewed-by: Tom
|
| |
| |
| |
| |
| |
| |
| | |
If you had deleted a VideoWidget, it could not free the memory taken
because we still had a reference on it.
Task-number: 258202
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It turns out that we weren't doing any caching of icons provided by the
file system. We now use the similar trick that's used on Windows which
does some caching on the file extension. We do fill up the cache
needlessly with extra information (16, 32, 64, and 128) icons. We
probably could be better with a iconRef engine that generates these
sizes on demand. Still performance is 100% better with this which means
using it in itemviews works.
Reviewed-by: Jens Bache-Wiig
|
| |
| |
| |
| |
| |
| |
| |
| | |
- Move implementation of debug functions to the bottom of the file.
- Move ImageCache stuff to under QDirectFBPaintEnginePrivate
- Move SurfaceCache stuff to under QDirectFBPaintEnginePrivate
Reviewed-by: Shane McLaughlin <Shane.McLaughlin@trolltech.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Pretty much every paint operation on DirectFB surfaces starts with
a clipping operations which until now would always cause a
IDirectFBSurface->Lock(). This was to make sure QRasterBuffer::prepare
had been called so QClipData::initialize() would allocate a big enough
array for its spans. We can safely not make
QDirectFBPaintDevice::memory() return 0 until we actually fall back.
Reviewed-By: Donald <qt-info@nokia.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Slight optimization by using the pluralized functions when possible.
Also make templatized helper functions to avoid near-duplication of code
for the float/int cases.
Reviewed-by: Donald <qt-info@nokia.com>
|
| |
| |
| |
| |
| |
| |
| | |
The drawTiledPixmap code iterated while x < right and y < bottom. This
should be x <= right and y <= bottom.
Reviewed-by: Donald <qt-info@nokia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Apparently some proxy servers can be configured to deny requests based
on User-Agent, even for CONNECT connections. See
https://bugs.kde.org/show_bug.cgi?id=155707#c155 for an example (packet
dump in #c157, analysis in #c158).
So send a User-Agent header with value "Mozilla/5.0", hoping that this
will be enough to allow the connection. I hope it will, because other
tools like libtool send something completely different:
User-Agent: curl/7.19.5 (i586-mandriva-linux-gnu) libcurl/7.19.5
GnuTLS/2.8.1 zlib/1.2.3 c-ares/1.6.0 libidn/1.15 libssh2/1.0
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| | |
Just add a check before calling hooks.
Task-number:258084
Reviewed-by:jbache
|
| |
| |
| |
| |
| |
| | |
native"
This reverts commit a4c4f994fa51ff216f0d43098824617e14b8a284.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Preallocated surfaces can currently be copied to video memory behind our
back. This means that we can not use this mechanism for toImage()
In later versions of DirectFB this might be possible to toggle with a
flag so I'll leave the code in there #if 0'ed
Reviewed-by: Donald <qt-info@nokia.com>
|
| |
| |
| |
| |
| |
| |
| | |
It's only used once and I want to unclutter the top of
qdirectfbpaintengine.cpp
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| | |
The function only sets a variable anyway. Replace with:
d->opacity = state()->opacity * 255
Reviewed-by: Donald <qt-info@nokia.com>
|
| |
| |
| |
| |
| |
| | |
fbWidth/fbHeight were never used for anything
Reviewed-by: Donald <qt-info@nokia.com>
|
| |
| |
| |
| |
| |
| | |
Take out the QPen member.
Reviewed-by: Donald <qt-info@nokia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Remove unnecessary copy of QTransform
- Fold matrixRotShear and scale into transformationFlags. Note that
transformationFlags is not a proper bitset of the types of transform
but rather set to the most complex operation (from QTransform::type())
and having NegativeScale added if
qMin(transform.m11(), transform.m22()) < 0
- Fix a bug whereby setState didn't call setRenderHints
- Make everything more readable
- Don't initialize state in QDirectFBPaintEngine::begin()
QDirectFBPaintEngine::setState will be called from QPainter::begin
just before QDirectFBPaintEngine::begin
Reviewed-by: Donald <qt-info@nokia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Calling OpenThemeData directly causes a leak when
changing the style as we do not call the corresponding CloseThemeData.
Task-number:257916
Reviewed-by:prasanth
|