| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
Reviewed-by: Trust Me
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QGraphicsEffect::sourceBoundingRect().
Context:
QGraphicsEffect::sourceBoundingRect() returns:
item->boundingRect() | item->childrenBoundingRect();
Problem was that item->childrenBoundingRect() adjusted the children's
bounding rect with the children's ancestor effects (child -> root item),
which means the source bounding rect was bigger than needed. We should
only account for effects downwards in the hierarchy.
root (has effect)
|
item (has effect)
|
child
|
grandChild
Auto test included.
Task-number: QT-3633, QT-3828
Reviewed-by: samuel
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Regression after: f5c5e20a
Problem was that the cached bounding rect was never invalidated. We can
also remove the cached bounding rect in QGraphicsEffectSource because
QGraphicsItem::childrenBoundingRect now clips by default. This basically
means partially reverting above commit and invalidate whenever
ItemClipsChildrenToShape flag changes.
Auto test included.
Task-number: Discovered while investigating QT-3633
Reviewed-by: samuel
|
| |
|
|
|
|
|
|
|
|
|
| |
Items with the ItemHasNoContents flag set are never drawn so the
'paintedViewBoundingRect' is never cached/updated resulting in
updates wrongly being discarded. The solution is to always invalidate
the children for such items.
Auto test included.
Task-number: QT-3803
|
| |
|
|
| |
Task-number: QTBUG-12991
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem was that the item's cache was not invalidated from
prepareGeometryChange(). We did invalidate the cache for all the
ancestors, but not for the item itself. To avoid looping through the
whole parent chain twice, we invalidate the item's cache before
walking the parent chain. It would be nice to centralize the cache
invalidating mechanism, but for now it's OK to solve it like this.
Auto test included.
Task-number: QTBUG-9551
Reviewed-by: samuel
|
| |
|
|
| |
Reviewed-by: rohan mcgovern
|
| | |
|
| |
|
|
|
|
|
|
| |
The effect might rely on a child to draw itself. So we need to redraw if
a child become visible or invisible.
Task-number:QTBUG-7843
Reviewed-by:janarve
|
| |
|
|
|
|
|
|
| |
We can't clip source pixmaps to the device rect, as there's no way of
knowing which parts of the source pixmap are needed for the part of the
graphics effect that's unclipped.
Reviewed-by: Bjørn Erik Nilsen
|
| |
|
|
|
|
|
| |
We need to invalidate the graphics source pixmap cache for both child
items and parent items when changing the opacity of a graphics item.
Reviewed-by: Bjørn Erik Nilsen
|
| |
|
|
|
|
|
|
| |
Don't invalidate the cache if we're only translating and the effect rect
is fully contained within the device rect of the painter.
Task-number: QTBUG-6901
Reviewed-by: Bjørn Erik Nilsen
|
| |
|
|
| |
Reviewed-by: Trust Me
|
| |
|
|
|
|
|
| |
Even for DeviceCoordinate mode we can return the raw pixmap if the
graphics item size is untransformed.
Reviewed-by: Bjørn Erik Nilsen
|
| |
|
|
|
|
| |
This broke after commit: fb78a402b512b017c850e7410745c4d20da04a7c
Effects and auto-tests are now in line with the documentation.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
* Get rid of QGraphicsEffectSource from the public API, instead add
convenience functions in QGraphicsEffect. This way we commit to less
API, and are free to introduce a customizable QGraphicsEffectSource
in a future release.
* Move PixmapPadMode into QGraphicsEffect and tweak the names of the
enum values.
* Make QGraphicsBlurEffect::BlurHint into a bit flag, for extensibility.
Reviewed-by: Bjørn Erik Nilsen
|
| |
|
|
|
|
| |
There's no grayscale effect anymore, use colorize effect.
Reviewed-by: Gunnar Sletta
|
| | |
|
| |
|
|
| |
Reviewed-by: Paul Olav Tvete
|
| |
|
|
|
| |
Autotest: included
Reviewed-by: Bjørn Erik Nilsen
|
| |
|
|
| |
Reviewed-by: Bjørn Erik Nilsen
|
| |
|
|
| |
Reviewed-by: Bjørn Erik Nilsen
|
| |
|
|
|
|
|
|
| |
We have to initialize the painter with the 'effected' item's
opacity before calling QGraphicsEffect::draw; otherwise we'll
use the previous rendered item's opacity (which is wrong).
Reviewed-by: Michael Brasser
|
| |
|
|
| |
Reviewed-by: Trust Me
|
| |
|
|
| |
Reviewed-by: Trust Me
|
| |
|
|
| |
Reviewed-by: Trust Me
|
| |
|
|
|
|
|
| |
In case of caching, the effect must be notified whenever the source has
been invalidated; otherwise the cached pixmap will not be up-to-date.
Auto-test included.
|
| |
|
|
|
|
|
|
| |
This is way more flexible as it allows for extension in the future.
Instead of having several virtual functions, which in most cases when
re-implemented have to do exactly the same, we now have one virtual
function which takes a ChangedFlags parameter do describe what kind of
changes that occurred to the source.
|
| |
|
