| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
If we made calls on a QDBusConnection that isn't connected, the d
pointer is 0. Ensure we don't crash.
Task-number: QTBUG-6571
Reviewed-by: Bradley T. Hughes
|
|
|
|
|
|
|
| |
Also, issue a warning if a type is not known to the meta-type system.
Backport of 508c9cd681244a5ad566c12733aa70f5bd522b57
Task-number: QTBUG-5060
|
|
|
|
|
| |
this is a windows-only test, so it never failed for the "usual suspects"
...
|
|
|
|
| |
consistently use QIODevice::Text
|
|
|
|
|
|
|
|
| |
PostgreSQL can store/retieve the millisecond part of type "TIME" , so
allow it in the API level.
Task-number: QTBUG-5251
Reviewed-by: Bill King
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the stringToCMap() fails, it can be because it did not have enough
space in the layout, or it can because of other errors. In order to
implement "try-again" processing in a simple way, we had an infinite
loop which assumed that stringToCMap() would always succeed in the
second run (which would be the case if the only possible error was
"not enough space".)
Since there are other possible failures not related to the number of
glyphs, you could easily get into an infinite loop here, e.g. when
laying out text that contains the Byte Order Mark.
The fix changes the implementation to explictly try stringToCMap()
twice at max, and is also how it's implemented in the default
qtextengine.cpp.
Task-number: QTBUG-4680
Reviewed-by: Trond
Conflicts:
src/gui/text/qtextengine_mac.cpp
tests/auto/qtextlayout/tst_qtextlayout.cpp
|
|
|
|
|
|
|
|
|
|
| |
This new test is to find out if the BIO size of OpenSSL is limited
or not. The test passes on my Linux, however the OpenSSL docu suggests
that the BIO size is limited.
From http://www.openssl.org/docs/crypto/BIO_s_bio.html
"This is currently 17K".
Reviewed-by: Peter Hartmann
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
geometry() is in parent coordinate. We want the coordinate in viewport
coordinate.
There is an offset (the header geometry) between the two.
So the first item was not refreshed.
(Regression because of e5b32fbe0efc8 and a54c18e27bbb)
Reviewed-by: Gabriel
Reviewed-by: Alexis
Task-number: QTBUG-4849
|
| |
|
|
|
|
|
|
| |
firewall issue
Also check if we're not timing out instead of being able to fail.
|
|
|
|
|
|
| |
We need some more time on Windows mobile to receive all events.
Reviewed-by: thartman
|
|
|
|
|
|
|
|
| |
We must make sure that the graphics view scene is centered to make
this test work. On Windows mobile, the widget was too wide and the
scene wasn't centered.
Reviewed-by: thartman
|
|
|
|
|
|
|
| |
This test depends on a layout spacing set to 6.
The Windows mobile style has layout spacing 8.
Reviewed-by: mauricek
|
|
|
|
|
| |
We are not going to fix this in 4.5. I doubt we'll fix it in 4.6
either, so I'll reenable it for 4.7 only.
|
|
|
|
|
|
|
| |
On Windows mobile we usually don't have the "Times New Roman" font.
Thus we must deploy and register it, if its not available.
Reviewed-by: mauricek
|
|
|
|
|
|
|
| |
We need to give Windows mobile some more time to handle all internal
timer events. Otherwise QTreeView::updateScrollBars doesn't get called.
Reviewed-by: mauricek
|
|
|
|
| |
Reviewed-by: Joerg Bornemann
|
|
|
|
|
|
|
| |
Changed the absolute size values for the combobox to desktop
dependent sizes.
Reviewed-by: Joerg
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you set the flag itemClipsChildrenToShape to true on a parent, an
optimization was made in 4.5.0 to not add children of this parent in
the index. But when you set the flag back to false all the sub-tree
of the parent should be re-added to the index otherwise the index will
never find all children. This code is not relevant for 4.6 since
the index part of QGraphicsView has been refactored and handle this case
with itemChange in QGraphicsSceneIndex.
Reviewed-by:andreas
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the editor had been created inside the QtPropertyEditorView (inheriting
QTreeWidget), the subsequent show sent a synthetic mouse move event down to
the QLineEdit, and a new selection was made on the text because the mouse
button was marked as pressed in the event.
QApplicationPrivate::sendSyntheticEnterLeave() now sends a mouse move event
without any button pressed. Auto-test included in tst_QWidget.
Task-number: QTBUG-4055
Task-number: 253159
Task-number: QT-659
Task-number: 245398
Reviewed-by: bnilsen
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
updated
When calling QGraphicsItem::update() on a cached item, the cache is
meant to be invalidated.
In the reported bug, the user had a fixed scene rect
set for his scene, and removing an item caused the entire scene to be
updated (marked as "all needs to be updated"). In this case, calling
update() on the cached item did not cause the item's cache to be
invalidated. The item's new appearance didn't show up until the next
invalidation, which was the same call to update(), but this time without
a preceeding full scene update.
The fix is to always invalidate the cache, regardless. But only
schedule a repaint of the item in some cases (e.g., in this case the
whole scene was marked for update, in which case it's unnessary for this
one item to schedule a repaint of itself).
It's worth noting that in 4.6, removing an item be delete does not cause
the whole scene to be updated, and because of that this error was not
exposed. It's there nevertheless.
Reviewed-by: bnilsen
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When building Qt static on Mac, the test included actually stops
the build process, prompting the user for 'Promteroo?'
The reason is that configure runs qmake on all the tests inside
the test/auto directory, including the one that is meant for
testing qmake itself. In other words, this test should not
be qmake'ed when running configure, only when running the
qmake auto test. However, the qmake auto test does not run
the prompt test anymore either. So the solution for now
is to just comment out the test project as well.
Reviewed-by: alexis
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Regression against Qt 4.4. Children of items with ItemClipsChildrenToShape
would only be discovered if the view's expose region contained the outer
bounding rect of all items, _if_ there was at least one item in the
scene that enabled ItemIgnoresTransformations.
The reason for this bug is that the presence of an untransformable item
causes the item lookups to go through a different path
(QGraphicsViewPrivate::itemsInArea()). This function had the bug that it
didn't correctly discover children of clip-items. Because of this, in
the provided test case you could "work around" the bug by either removing
the clip flag, or the transformation flag.
Task-number: QTBUG-4151
Reviewed-by: Alexis
|
| |
|
|
|
|
|
|
|
| |
QDomDocument::toString() should not cause an assertion if the document
specifies an encoding that is not supported by QTextCodec.
Task-number: QTBUG-4595
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removing dubious intermediate detection code that also had a buffer
overflow. The results were inconsistent and not dependable on.
Processing was inefficient and end value to user experience dubious.
Test cases that abused the former behaviour were changed to consider
input in an Intermediate where it was previously considered Invalid.
With this change, user input will mostly be considered in an
intermediate state, until it is effectively validated.
Task-number: 255019
Reviewed-by: Anders Bakken
|
|
|
|
|
|
|
| |
This reverts commit df47e0d40290f5e40054a9612f75177d9ef8537a.
There is no "private_build" in Qt 4.5
Reviewed-By: thiago
|
|
|
|
| |
Reviewed-By: TrustMe
|
|
|
|
|
|
|
|
| |
QMenu actually doesn't use QFontMetrics::width to calculate its bounding
rect but QFontMetrics::boundingRect. That's why this test failed on
Windows CE.
Reviewed-by: thierry
|
|
|
|
|
|
|
|
|
| |
Fix QGraphicsItem to clear clip path for items with an ancestor that
clips to shape. Added autotest to demonstrate clipping path problem.
Merge-request: 810
Reviewed-by: Alexis
Reviewed-by: Andreas
|
|
|
|
| |
Reviewed-by: TrustMe
|
| |
|
|
|
|
|
|
| |
This reverts commit e7042dea2431b8f64574d4e97eb896285b328c8b.
Alexis : This should never have been here. E-mail is invalid.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the width is multiplied into the dash, it needs to be divided out,
otherwise you can get a dashOffset which is greater than the pattern at
the index, and the dash can become negative. This will in turn lead to
passing a negative width to the rasterizer, which at some point will
get cast to an unsigned int and overflow. Depending on the position of
the line and size of the buffer, this will either crash or produce
garbled output.
Task-number: QT-4444
Reviewed-by: Samuel
|
|
|
|
|
|
|
|
|
| |
Previously you had to set forward only on non-scrollable datasets
explicitly. This queries ODBC, to determine if it's a scrollable
dataset, and sets forwardOnly to false if it isn't.
Task-number: QT-353
Reviewed-by: Justin McPherson
|
|
|
|
|
|
|
|
| |
The test failed because it tried to open a .qm file which didn't exist
in Qt's translations directory. Fixed by running lrelease on the .ts
file and copying the resulting .qm into the test directory.
Reviewed-by: Trond
|
|
|
|
| |
Reviewed-by: Jesper
|
|
|
|
|
| |
Backported d04d67e146bce3d407f992c283d7ab3d0c25d428 and
08b54f274d57e4735d0042e295237f176506433d from 4.6.
|
|
|
|
| |
Reviewed-by: Kim
|
| |
|
|
|
|
|
|
|
| |
Uses the primary key from the index in the query, not the resulting
location in the modified dataset.
Task-number: 222678
|
|
|
|
|
|
| |
test was not building
Reviewed-by: Trust Me
|
| |
|
|
|
|
| |
Merging fix back into 4.5 tree
|
|
|
|
|
|
|
| |
Ported this fix backwards from 4.6 to 4.5
Adds some cleanups (using QVarLengthArray), and reverting to the
initial and correct calculation (when the driver doesn't deem fit to
return SQL_NO_DATA).
|
|
|
|
| |
Reviewed-by: Marius Bugge Monsen
|
| |
|
|
|
|
|
|
| |
test was not building
Reviewed-by: Trust Me
|