| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Last QVERIFY still failing.
Reviewed-by: olivier
|
|
|
|
|
|
|
| |
Instead of ignoring _NET_WORKAREA, merge it with each screen geometry
to give a meaningful availableGeometry() for all screens.
Reviewed-by: denis
|
|
|
|
|
|
|
| |
To make sure we don't receive same signals several times from a
QDesktopWidget, added the debug output whenever the signal is emitted.
Reviewed-by: trustme
|
| |
|
|
|
|
| |
Reviewed-by: paul
|
|
|
|
|
| |
view doesn't exist anymore and the qWait should be enough to make the
x11 call useless
|
| |
|
|
|
|
| |
Reviewed-by: paul
|
|
|
|
|
|
|
| |
- We need to process events in order to leave time to mac to update
the widget.
- When in undefined case, the progressbar is animated, so the number
of paintevents might be bigger than 1.
|
|
|
|
|
| |
Reviewed-by: thierry
Reviewed-by: olivier
|
| |
|
|
|
|
|
|
| |
We already trimmed away any \r from the expected line, but we did not
trim away \r from the actual line. That caused some false negatives on
windows.
|
|
|
|
| |
That machine has no 'Times New Roman' the test was reliying in
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/gui/dialogs/qfiledialog.cpp
src/gui/dialogs/qfiledialog_win.cpp
tests/auto/qicoimageformat/tst_qicoimageformat.cpp
tests/auto/qscriptqobject/qscriptqobject.pro
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When an autotest fails to compile, there's no way to determine which
testcase(s) have been prevented from running.
Our results parsing tools have been guessing, under the assumption that
a directory called `qdogwalker' always contains a testcase named
`tst_qdogwalker'. That wasn't true for all our tests, so let's make it
true.
Also changed the platform-specific tests so that qmake will simply skip
those tests on unsupported platforms, instead of wasting time compiling
a useless QTEST_NOOP_MAIN test.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If there is severals matching items but all of them are disabled, it
would have produced an infinite loop.
Block the loop once we reach an already matched item.
Task-number: 258949
Reviewed-by: Thierry
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We never told Cocoa that it needed to redraw the window view
when a window was shown. This is implicit if the window is
shown for the first time, but needs to be done explicit
if you hide and show it again.
Task-number: 254672
Reviewed-by: bnilsen
|
| |
| |
| |
| |
| |
| | |
Also removed tabs from auto.pro
Reviewed-by: trustme
|
| |
| |
| |
| |
| |
| |
| |
| | |
I don't want to link the tst_qsharedpointer test to QtGui, so I
created a new test.
This is testing only the basic manipulations. In special, it's not
testing invalid constructs.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With the previous commit, you could create a QWeakPointer from any
QObject-derived object. It's possible because QObject now has a
pointer to the QWeakPointer's d-pointer.
However, if you did:
QSharedPointer<QObject> obj(new QObject);
QWeakPointer<QObject> weak1(obj);
QWeakPointer<QObject> weak2(obj.data());
Then weak1 would shared d-pointers with QSharedPointer, but weak2
wouldn't. Also, weak1.toStrongRef() would work, but
weak2.toStrongRef() wouldn't.
This change makes QObject know where the d-pointer created by
QSharedPointer is, so weak2 would get the same d-pointer.
As a nice side-effect, you can check if a given QObject is shared by
trying to promote its QWeakPointer to QSharedPointer.
Reviewed-by: Bradley T. Hughes
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The problem with QPointer is that it's a simple QObject*. So the only
way for QPointer to do what it's supposed to do is if the object it's
pointing to clears all QPointers when getting deleted. That means the
QObject must know each and every QPointer pointing to it. To make
matters worse, QPointers can be deleted while the object they're
pointing to also gets deleted. So deleting QObjects must do locking.
The solution to the QPointer problem is that both QObject and the
"QPointer" reference something outside the QObject. This way,
QObject doesn't have to lock anything to destroy itself: it's simply
setting a volatile integer to zero when it gets deleted. Since the
integer is outside the QObject, the integer is also refcounted. It's also
O(1), so there's no problem having as many "QPointer".
The two-atomic-ints structure is exactly what QSharedPointer and
QWeakPointer use internally. We just abuse this structure for QObject
needs, setting the strong reference count to -1 to indicate that it's
a QObject that cannot be managed by a QSharedPointer. But QWeakPointer
can still work and replace QPointer neatly.
Reviewed-by: Bradley T. Hughes
Reviewed-by: Jarek Kobus
|
| |
| |
| |
| |
| |
| | |
QPlainText edit does lazy line wrapping only for the visible blocks.
Resizing the editor in the auto test thus has to make it wide enough
that at least some characters are visible for the block to be laid out.
|
| |
| |
| |
| |
| |
| |
| | |
If you only set the position, of the button without setting a geometry,
it did not work.
Task-number: 259226
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The commit 31edb4d5a63b9b3c28cce1c4ca6eb99f62a09759 introduced
regressions in filters which breaks the mac native dialog, the non
native dialog with HideNameFilterDetails activated.
Task-number:259105
Reviewed-by:olivier
Reviewed-by:prasanth
|
| | |
|
| |
| |
| |
| |
| | |
Task-number: 229124
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Ensure we test simple and deep constructs of setParentItem(). These
benchmarks don't cover slowness in ancestor flag updating.
QVariant is already identified as a contributor to this slowness, as is
updating of the depth value (a deep tree crawl).
Reviewed-by: Aaron Kennedy
|
| |
| |
| |
| |
| |
| |
| | |
a6ea9ce6990003856ecadcca8ce9ddf37949363d removed this function; the
benchmark was not updated.
Reviewed-by: TrustMe
|
| | |
|
|\ \
| |/
| |
| |
| |
| | |
Conflicts:
src/gui/graphicsview/qgraphicsitem.cpp
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
updateAncestorFlags was not reseting the flags if you change the parent
that have for instance itemsClipChildrenToShape to a new one that
doesn't have that flag.
Task-number:258956
Reviewed-by:bnilsen
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
the item lost focus to an unrelated dialog.
The tests against the active modal window was unnecessary.
Task-number: 257859
Reviewed-by: olivier
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This patch allows for input hints to be set on a QGraphicsItem.
Input methods use such hints to define its appearance/behavior
(e.g. to allow for numerical input only).
Reviewed-by: ahanssen
Task-number: 254493
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If you resumed a parallel animation group, it would always restart
(ie. stop and start) the animation which would reset its current time
to 0 and trigger flickering.
autotest included.
Task-Number: 259102
|
| |
| |
| |
| |
| |
| |
| | |
The action now try to take advantage of the space given by a minimum
width. Patch proposed initially by Aron Seigo and improved later on.
Reviewed-by: Trustme
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After resetting the model, the selectionModel::hasSelection()
of the view should return false.
Fixed the corresponding autotest, which was wrong.
Task-number: 256502
Reviewed-by: thierry
|
| |
| |
| |
| |
| |
| |
| |
| | |
Menu paintEvent was not called when the mouse cursor lied
between the menu item area and the menu frame border.
Task-number: 258920
Reviewed-by: olivier
|
| |
| |
| |
| |
| |
| | |
Also add some thread stress tests to try and detect doing it wrong.
Reviewed-By: Bradley T. Hughes
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently, if you create a QSharedPointer in code with
pointer-tracking, you must ensure it gets deleted in code with
pointer-tracking, otherwise the internal safety tracker will be
"leaking" objects. The pointers would never get removed.
And if any new pointer happened to have the same pointer address
(which happens quite often), the tracker code would promptly abort the
application.
With this change, the untracking of the pointer is scheduled by the
same code that creates the tracking. This is done by "abusing" the
custom deleter code:
- for the QSharedPointer that used ExternalRefCountWithDestroyFn
already, we intercept the call to the destroy function and call the
untracking function
- for a normal QSharedPointer, we use the "normalDeleter" function as
custom deleter and chain up above
Note: the autotest only *really* works in release mode. Otherwise
functions don't get inlined and do get merged by the linker.
Reviewed-By: Bradley T. Hughes
|
| |
| |
| |
| |
| |
| | |
Destructors have to be run for the subobjects we initialise.
Reviewed-By: Bradley T. Hughes
|
| |
| |
| |
| |
| |
| |
| | |
That way, this code can be compiled with an earlier version of Qt and
should still work in new ones.
Reviewed-by: Trust Me
|
| |
| |
| |
| |
| | |
In the future, it would be nice to split the autotest in multiple
functions at every check().
|
|\ \
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/corelib/tools/qsharedpointer.cpp
src/corelib/tools/qsharedpointer_impl.h
src/gui/dialogs/qcolordialog.cpp
src/gui/painting/qwindowsurface_raster.cpp
src/network/access/qnetworkaccessmanager.cpp
tests/auto/qsharedpointer/externaltests.cpp
|
| |
| |
| |
| |
| |
| |
| | |
The functionality these tests tested was broken in 4.5 and has been
disabled. Therefore, these tests simply cannot pass.
It's fixed in 4.6.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
If the user forgot to end their headers with a newline, the
compilation would fail because the next line is #include
<QtCore/QtCore>.
Reviewed-by: Jesper Thomschütz
|
| |
| |
| |
| |
| |
| |
| | |
This test depends on some low-level features of the CPU and the OS
scheduler which seem impractical to automatically verify
independently of the test. So turn it off to stop its intermittent
failures in our test farm.
|
| |
| |
| |
| | |
Test needs a placeholder file to make sure its build directory exists.
|