| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
That state used not to be set for drawing the content of the items.
Also, it could be wrong for branches if there was hidden items.
Reviewed-by: Thierry
Task-number: related to 234930
|
|
|
|
|
|
|
|
|
|
|
| |
the ::item pseudo-class
The State_Children was not set on the QStyleOption.
Refactorized a little bit the way it was computed.
Reviewed-by: Thierry
Task-number: 234930
Task-number: QTBUG-3129
|
|
|
|
|
|
|
|
| |
The problem was that we didn't call ensurePolished when getting the
size of the sections.
Task-number: QTBUG-1002
Reviewed-by: ogoffart
|
|\ |
|
| |
| |
| |
| | |
Reviewed-by: thierry
|
| |
| |
| |
| |
| |
| |
| |
| | |
This could happen when adding actions in response to the aboutToShow
signal.
Task-number: QT-2596
Reviewed-by: ogoffart
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The crash (Q_ASSERT_X failure) happened when a proxy model was being attached
to the QSqlQueryModel, and no query was set yet. The headerDataChanged()
signal was being received by the proxy model who wouldn't check its
"proxyfied" data bounds.
The patch introduces a behaviour change. However, this change makes the usage
of QSqlQueryModel::setHeaderData() to be more in accordance with the current
documentation, and to behave in the same way as for QStandardItemModel,
QTreeModel, and QTableModel.
Task-number: QTBUG-4963
Reviewed-by: Olivier
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Now, when dropping items, these will remain selected, and in the same visual
order as when dragged.
Auto-test included for the items moving part. For the rest, it's a
drag-and-drop thing.
Reviewed-by: Olivier
|
|/
|
|
|
|
|
|
|
|
| |
We move the QLayoutStyleInfo class out of the gridlayout engine to a
common header file so that anchor layout also can utilize it.
Due to that we now can have a per-item spacing we have to change the
'effectiveSpacing' argument of refreshSizeHints to just take a
QLayoutStyleInfo pointer that we will later query for the actual
spacing used.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reported by Alan. The stackBefore() implementation did not alter the
insertion order if the two items' current Z values were different. The
fix is to ensure it is updated, so that the stackBefore() operation
takes effect should the Z values become equal in the future. Example:
Current order: A-B-C-D
A->setZValue(1);
Current order: B-C-D-A (A moves to the end)
D->stackBefore(A);
Current order: B-C-D-A (unchanged, D is already before A)
A->setZValue(0);
Current order: D-A-B-C (now A moves back, and D moves in front)
Reviewed-by: Aaron Kennedy
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The painter's worldTransform() is updated for each item we draw, and
when the DontSavePainterState optimization flag is set, this change is
not protected by save() and restore(). After all the items are drawn, it
means the painter is left with the last drawn item's transform. We
therefore have to make sure it is reset back to whatever it was before
the items were drawn.
Auto-test included.
Task-number: QTBUG-4973
Reviewed-by: alexis
Reviewed-by: andreas
|
|
|
|
| |
Reviewed-by: thierry
|
|
|
|
|
|
| |
This could be prevented by a pause animation currently running.
Reviewed-by: Leo
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was that QGraphicsLineItem's bounding rect is an empty rect
(either width is 0 or height is 0), and when updating the item's old
occupied area, we explicitly checked whether the rect was empty() or
not. In case of being empty (rect.isEmpty()) we did nothing, which was
the root of the problem.
We can safely remove the rect.isEmpty() check without any significant
loss of performance since the common case is that the rect is non-empty.
And in the case of being empty, we'll bail out from
QGraphicsViewPrivate::updateRect's highly optimized rect intersection.
Auto test included.
Task: QTBUG-4877
Reviewed-by: alexis
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically some items were not properly remove in the BSP which means
that if you delete one of items, the BSP tree may contain dangling pointers.
The problem was in removeItemHelper in QGraphicsScene were the child
were removed after reparenting to 0 the topmost parent. The
sceneBoundingRect for children was invalid which means that we were removing
them in the wrong position inside the BSP. Reparenting to 0 means that the
sceneBoundingRect will be the boundingRect but wasn't the case before
(for the topmost parent).
Reviewed-by:bnilsen
|
|
|
|
|
| |
On macos (as on symbian), we need to leave some time for the
application to become responsive.
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
We must register the same type as they were registered in Qt 4.5
Reported on qt4-preview-feedback mailing list.
Reviewed-by: Kent Hansen
|
| |
| |
| |
| | |
Reviewed-by: alexis
|
| | |
|
| |
| |
| |
| | |
unfinished messages
|
| |
| |
| |
| |
| |
| | |
introduce a QFAIL for now until problem is fixed
Reviewed-by: Carlos Duclos
|
| |
| |
| |
| |
| |
| |
| | |
The projection to 2D needs to be done when the rotation is applied,
not after all transformations have been applied.
Reviewed-by: trustme
|
| |\
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/gui/widgets/qmenu_mac.mm
tests/benchmarks/benchmarks.pro
tests/benchmarks/qnetworkreply/tst_qnetworkreply.cpp
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This new test is to find out if the BIO size of OpenSSL is limited
or not. The test passes on my Linux, however the OpenSSL docu suggests
that the BIO size is limited.
From http://www.openssl.org/docs/crypto/BIO_s_bio.html
"This is currently 17K".
Reviewed-by: Peter Hartmann
|
| | |
| | |
| | |
| | | |
Reviewed-by: Peter Hartmann
|
| | |
| | |
| | |
| | | |
Reviewed-by: TrustMe
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The test (see 02fbfdbd) previously asserted that changing the parent
of a native widget caused a WinIdChange event on Symbian, but not on
other platforms. The test now asserts that:
1. Changing the parent of a native widget causes a WinIdChange
event on all platforms.
2. Changing the grandparent of a native widget causes a WinIdChange
event only on Symbian.
Reviewed-by: Paul Olav Tvete
|
|\ \ \
| |/ / |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Just the default font size will not work for this case. We set it to smaller one. Notice: we should make sure view->length() is different between view->setStretchLastSection(true) and view->setStretchLastSection(false).
RevBy: Aleksandar Babic
|
| | |
| | |
| | |
| | | |
Reviewed-by: Joerg
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Accounting for double resolution devices on Windows Mobile in the test
data sets (tst_qgraphicsview_2.cpp).
Skipped a test involving mouse tracking (tst_qgraphicsview.cpp).
Reviewed-by: Joerg
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Gives better performance in the raster paint engine.
For Symbian 9.3 onwards, this can also be used as the native pixmap
format. For 9.2, conversion is required.
Reviewed-by: Sami Merila
Reviewed-by: Jani Hautakangas
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This function is moved to graphicsitem private because it is needed by
multi-touch event handling and is not specific to bsptreeindex.
Reviewed-by: bnilsen
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Auto-test updated.
As a bonus, stabilized tst_QListView::task262152_setModelColumnNavigate.
Reviewed-by: Thierry
|
|\ \ \ \
| |/ / /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The original report was that the customer did resize(main.sizeHint())
instead of the main.adjustSize(); Note that resize(main.sizeHint() still does
not work. However, calling main.adjustSize() should now do what the original
reporter wanted.
The problem was that the resize did not work, because at the point of the resize
the minimumHeight of main was still 22 (8+6+8), and we tried to resize it with
a new height of 10. The resize would bound the height up to 22, and the main
widget would then get a size of (200x22).
The reason why it still had a minimumHeight of 22 was that it was the
minimumSize of the previous layout configuration. Unfortunately the new
minimumSize of the widget hadn't been updated yet because there was a
LayoutRequest event in the queue that hadn't been processed yet. (This
LayoutRequest was triggered by that we called invalidate() from hide()).
Thus, processing the event queue immediately after the hide() could also have
been a workaround for this issue.
There is no really good fix for this issue (and it does not seem to be a
common problem) without introducing a risk for regressions.
Due to that we therefore decided to provide a fix in QWidget::adjustSize().
Reviewed-by: paul
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We now check that the item has children before animating.
Reviewed-by: Alexis
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
On embedded dialog pressing tab stop changing the focus when the focus
was given to QFontComboBox. It's because QFontComboBox embed a
QLineEdit in order to allow editing. But this QLineEdit is a focus proxy
so we need to special case that. The logic is the same in QApplication.
Be careful when changing one of them.
Task-number:QTBUG-4818
Reviewed-by:jan-arve
Reviewed-by:ogoffart
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The flow positions in ScrollPerItem mode did not take the hidden rows into
account when configuring the vertical scroll bar.
A mapping between the scroll bar value and the flow position has been
added. Auto-test included.
Task-number: QTBUG-2233
Reviewed-by: Thierry
|
|\ \ \ |
|
| |/ /
| | |
| | |
| | | |
sha1 of the fix: 2633931653757decd93dd3939c09f5e07203da1c
|
| | |
| | |
| | |
| | | |
Reviewed-by: alexis
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
After this commit, when you modify the spacing of an anchor you are
effectively modifying the preferred size of the anchor, since all
anchors (except internal ones) have their minimumSizeHint to 0 and
maximumSizeHint to QWIDGETSIZE_MAX.
I also changed the sizeHintsFromItem to be more generic so that I could
use it for anchors. (Thus, it was renamed to "internalSizeHints"). It
now only takes care of setting the min/pref/exp/maxSize of AnchorData
based on the anchor/item size hint and their size policies.
As a consequence of all of this, setFixedSize changed behaviour and
became setPreferredSize (since setSpacing is basically setPreferredSize).
The implementation of that now only sets the prefSize.
The patch also has an unrelated fix for IgnoreFlag, where it will
(again) return the minimumSize for sizeHint(Qt::PreferredSize) instead
of the maximumSize. This was to be more consistent with
qgridlayoutengine.cpp. The docs are not very clear on this behaviour
unfortunately.
This API change has been discussed.
Reviewed-by: alexis
|