| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
The submenu would always appear to the side of the menu instead of its
right.
Task-number: 250673
Reviewed-by: ogoffart
|
| |
|
|
|
|
|
|
|
|
| |
QSortFilterProxyModel::hasChildren need to construct the mapping. And when it
tries to construct the mapping, it needs to fetch the childs, so there is none.
Task-number: 250023
Reviewed-by: Marius Bugge Monsen
|
|
|
|
|
|
|
|
|
|
| |
When QString::replace was optimized, this specific overload missed out
on sanity checking of the arguments.
Task-number: 249517
Reviewed-by: Joao
Reviewed-by: hjk
BT: yes
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Regression caused by optimizations in QGraphicsItem and QGraphicsScene.
The changes in QGraphicsItem fix bugs in QGraphicsItem::mapToParent
functions, which did the translation before applying the transformation,
instead of the other way (transform, then translate). This bug caused
almost all mapToParent and mapRectToParent functions to behave wrongly.
Unfortunately the new helper functions in QGraphicsScene for discovering
items made use of these functions, which introduced a regression. Fixing
these functions also fixes item discovery.
The other part of this change fixes a regression caused by c1909321,
which luckily happened after 4.5.0 and never saw the light of day. The
fix is to also invalidate the cached clip path even if there is no scene,
which is necessary if you build your scene graph outside the scene, and
finish off by adding the root item to the scene.
Task-number: 250680
Reviewed-by: Alexis
|
|
|
|
|
|
|
|
| |
qt_accHotKey() was pretty buggy; it could both crash or spin forever
in some cases.
Task-number: 221731
Reviewed-by: alexis
|
|
|
|
|
|
|
|
|
|
|
| |
If no quotes around identifiers are provided by the programmer,
identifiers are treated identically to how the underlying engine
would behave. i.e. some engines uppercase the identifiers
others lowercase them. If the programmer wants case sensitivty
and/or use whitespaces they will need to quote their identifiers.
The previous (incorrect) behaviour always quoted the identifiers.
Reviewed-by: Bill King
|
|
|
|
| |
Reviewed-by: ogoffart
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem here is that we are filling the sceneEventFilters map
when we install evenfilter but we never remove the references of an
item if it has been removed from the scene or deleted. The deletion can
keep stale pointers into the map and a crash can happen.
BT:yes
Task-number:250272
Reviewed-by: bnilsen
Reviewed-by: andreas
|
|
|
|
| |
slower platforms (like WinCE) need some more time to actually update.
|
|
|
|
| |
add additional file to deployment.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The way font propagation work has changed since 4.4: When there is a
stylesheet enabled, font does not propagate.
So when settings a font to the QAbstractItemView, the viewport font will
not change, and hence no QEvent::FontChange on it.
So catch the QEvent::FontChange in QAbstractItemView::event in addition
to QAbstractItemView::viewportEvent. (we seems to use the view's font
everywhere anyway)
Task-number: 250754
Reviewed-by: Jens Bache-Wiig
|
|
|
|
|
|
|
| |
Discovered in Kopete trunk
BT: yes
Reviewed-by: Thierry
|
|
|
|
|
|
|
|
|
|
|
|
| |
Zero timers on Windows would continue to fire even after being stopped
as long as a new timer was started that reused the pointer address of
the zero timer. Fix this by only re-firing zero timers if the zero
timer hadn't been stopped (we can check this by looking at the
inTimerEvent flag, which is set to false by registerTimer()).
Task-number: 247401
Reviewed-by: Denis Dzyubenko
Reviewed-by: Prasanth Ullattil
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
| |
Reviewed-by: thartman
- in case we explicitly use double as testdata, one cannot push float to
it.
- fuzzyCompare is not fuzzy enough, thus adopt the epsilon check of
other testfunctions.
|
|
|
|
|
|
|
|
|
|
| |
Reviewed-by: joerg
Some of the testfunctions use key/mouse events, which doesn't work
on Windows Mobile due to native menubar integration. Basically the
same situation like on Mac.
In addition there are still two test functions failing, waiting for
input on those.
|
| |
|
|
|
|
| |
While we integrate into native menubar on Windows Mobile, we can still test WinCE itself.
|
|
|
|
|
|
|
| |
RevBy: Joerg
AutoTest: mediaobject
Details: Since our wave files on Windows CE are very short (memory) we actually land up in the PausedState
when playback is finished
|
| |
|
|
|
|
|
|
| |
a NULL value
Task-number: 189093
|
|
|
|
|
|
|
|
|
| |
Font propagation changed slightly in some cases due to change
22d472c17167c4ca8df5678842768ab63b7baadd. However, the change is sane -
its just the autotest that is not optimal.
Task-number: 246215
Reviewed-by: andreas
|
|
|
|
| |
Reviewed-by: joerg
|
|
|
|
|
|
| |
Reviewed-by: thartman
function declaration was missing arguments as done in the other testcases in 831d2742b7c41924f052acd81620e8bfc58afde7
|
|
|
|
| |
Reviewed-by: jbache
|
|
|
|
|
|
| |
Reviewed-by: joerg
QTest::newRow only accepts char* and without Qt3Support there is no implicit cast available.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change shows a limitation in Graphics View caused by QPen's
default width being 0 (cosmetic), while Graphics View actually
does not support cosmetic pens at all. Because items are at risk of
drawing lines that poke 1 pixel outside their bounding rect,
QGraphicsView must look for items that are up to one pixel
larger than their bounding rect mapped to viewport coordinates.
Furthermore, mapToScene(QRect) forces us to adjust the
input rectangle by (0, 0, 1, 1), because it uses QRect::bottomRight()
(etc) when mapping the rectangle to a polygon (which is _wrong_). Since
this behavior has been there since 4.2, we don't want to fix it in
a 4.5 patch release...
The only _proper_ fix to this problem is for the view to know the item's
"adjust" in device coordinates, allowing items to use cosmetic pens
freely. Fex, we could introduce QGraphicsItem::viewportMargins() or so.
Added an autotest to ensure this doesn't break again.
Reviewed-by: bnilsen
|
|
|
|
|
| |
RevBy: Andreas
AutoTest: included
|
|
|
|
|
|
|
|
| |
RevBy: bnilsen
AutoTest: Bench
Details : if we come from setPosHelper (so itemChange) we don't need to do all the stuff regarding the size in setGeometry because the size doesn't change.
I remove two calls to fullUpdateHelper and update() because prepareGeometryChange already call updateHelper and setPosHelper call fullUpdaterHelper too so we don't need to call them inside setGeometry.
We can only call prepareGeometryChange only if we don't come from setPos.
|
|
|
|
|
|
|
| |
Use qmake -query QT_INSTALL_HEADERS at test startup time instead of
relying on the dead QTDIR environment variable.
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
|
|
|
|
|
|
| |
Remove unused QTDIR tests.
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have to pass the correct include paths when testing the multiple
inheritance warning, because we want moc to find the QtGui and QObject
headers.
In addition we have to adjust the line numbers and include QObject in
the qobject test to avoid a warning about the unknown QObject
superclass.
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The main problem is that enterDirectory received a QModelIndex that can
be a proxy index and not a source index if there is a proxy set on the
QFileDialog. This fix basically discover some other crashes in the
completer. The problem was that we didn't apply the proxy to the
completer too. So we basically messed up source and proxy indexes.
Both have a proxy set now and convert the model indexes if needed.
Task-number:250194
Reviewed-by:jasplin
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since there is no way to find out if gradient stops have been added to a
gradient, a gradient stop at NaN was earlier used in the SVG module to
mark the gradient as empty. This could cause floating point exceptions.
The usage of NaN has now been replaced by a boolean in
QSvgGradientStyle.
Duplicate entry "qxmlpatterns" was removed from auto.pro in the auto
test directory.
Task-number: 250146
Reviewed-by: Samuel
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 4a00810cc394b7da99ddb2d13eb045352ede25d3 ensures
that setting the focus policy of a widget applies to its
proxy (if any) as well. This propagation effect is however
unfortunate for a QCompleter in PopupCompletion mode.
The client widget (typically a QLineEdit or a QTextEdit)
acts as the focus proxy to the popup menu. Internally,
the completer sets the focus policy of the popup menu to
NoFocus, but this should not affect the focus policy of
the editor.
Reviewed-by: janarve
Task-number: 250064
|
|
|
|
|
|
|
| |
Task-number: 244500
Task-number: 244485
Reviewed-by: ossi
Reviewed-by: thiago
|
|
|
|
|
|
| |
... without having to change the parent process's environment.
Reviewed-by: mariusSO
|
|
|
|
|
|
|
|
|
|
| |
And some indentation fixes in qmake itself.
Fixes indentation; TRUE => true; FALSE => false; #includes and #defines
cleanup; removes dead code; comments... and somewhere along the way
marked a function static.
Reviewed-by: mariusSO
|
|
|
|
|
|
|
|
|
| |
Qt3 support prevented the tests from running on Mac Cocoa.
Also started some Spring cleaning (it's just around the corner!) and
applied some YAGNI :-)
Reviewed-by: NRC
Reviewed-by: mariusSO
|
| |
|
|
|
|
|
|
| |
... but test against the test server.
Reviewed-by: ogoffart
|
|
|
|
|
|
| |
Make db autotest data set generation more consistent, slightly faster.
Also, add ability to easily generate a set of a single databases
entries worth of criteria to test.
|
|
|
|
|
|
|
|
| |
Handle cases where QProcess::start() and startDetached() are passed a
null, empty, or "invalid" program string instead of crashing.
Task-number: 247865
Reviewed-by: Andreas Aardal Hanssen
|
|
|
|
|
|
|
|
|
| |
offsets not handled correctly
Now also removes negative timestamps.
Task-number: 249059
Reviewed-by: Justin McPherson
|
|
|
|
| |
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
|
|
|
|
|
| |
Signoff-by: Thiago Macieira <thiago.macieira@nokia.com>
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test if we're not past the end of the array before we attempt to read it.
Dates without timezone information are taken to be UTC, so merge the code.
If the date parsing failed, don't add a malformed cookie. Better to
have no cookie than to have it for past its expiration date.
Also update the autotests, since we now can cope with some of the
invalid cookies seen on the net.
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to our documentation we should ignore leading and trailing
whitespaces when converting a string to number with QLocale::toInt and
similar functions. However that didn't work for some locales - for
those ones that declare groupseparator as 0xa0 (which looks similar to
space) since we provide a workaround to accept space as a group
separator for those locales. And since the workaround was there for a
long time it doesn't make sense to change the behavior and the fix is
to explicitely remove leading and trailing whitespaces before doing
any conversion.
Reviewed-by: mariusSO
|
|
|
|
|
|
|
| |
Call isEmpty() on the normalized rect instead of the original rect.
Task-number: 247505
Reviewed-by:
|