| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
RevBy: Andreas
AutoTest: included
|
| |
|
|
|
|
|
|
| |
RevBy: bnilsen
AutoTest: Bench
Details : if we come from setPosHelper (so itemChange) we don't need to do all the stuff regarding the size in setGeometry because the size doesn't change.
I remove two calls to fullUpdateHelper and update() because prepareGeometryChange already call updateHelper and setPosHelper call fullUpdaterHelper too so we don't need to call them inside setGeometry.
We can only call prepareGeometryChange only if we don't come from setPos.
|
| |
|
|
|
|
|
| |
Use qmake -query QT_INSTALL_HEADERS at test startup time instead of
relying on the dead QTDIR environment variable.
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
|
| |
|
|
|
|
| |
Remove unused QTDIR tests.
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
We have to pass the correct include paths when testing the multiple
inheritance warning, because we want moc to find the QtGui and QObject
headers.
In addition we have to adjust the line numbers and include QObject in
the qobject test to avoid a warning about the unknown QObject
superclass.
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The main problem is that enterDirectory received a QModelIndex that can
be a proxy index and not a source index if there is a proxy set on the
QFileDialog. This fix basically discover some other crashes in the
completer. The problem was that we didn't apply the proxy to the
completer too. So we basically messed up source and proxy indexes.
Both have a proxy set now and convert the model indexes if needed.
Task-number:250194
Reviewed-by:jasplin
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since there is no way to find out if gradient stops have been added to a
gradient, a gradient stop at NaN was earlier used in the SVG module to
mark the gradient as empty. This could cause floating point exceptions.
The usage of NaN has now been replaced by a boolean in
QSvgGradientStyle.
Duplicate entry "qxmlpatterns" was removed from auto.pro in the auto
test directory.
Task-number: 250146
Reviewed-by: Samuel
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 4a00810cc394b7da99ddb2d13eb045352ede25d3 ensures
that setting the focus policy of a widget applies to its
proxy (if any) as well. This propagation effect is however
unfortunate for a QCompleter in PopupCompletion mode.
The client widget (typically a QLineEdit or a QTextEdit)
acts as the focus proxy to the popup menu. Internally,
the completer sets the focus policy of the popup menu to
NoFocus, but this should not affect the focus policy of
the editor.
Reviewed-by: janarve
Task-number: 250064
|
| |
|
|
|
|
|
| |
Task-number: 244500
Task-number: 244485
Reviewed-by: ossi
Reviewed-by: thiago
|
| |
|
|
|
|
| |
... without having to change the parent process's environment.
Reviewed-by: mariusSO
|
| |
|
|
|
|
|
|
|
|
| |
And some indentation fixes in qmake itself.
Fixes indentation; TRUE => true; FALSE => false; #includes and #defines
cleanup; removes dead code; comments... and somewhere along the way
marked a function static.
Reviewed-by: mariusSO
|
| |
|
|
|
|
|
|
|
| |
Qt3 support prevented the tests from running on Mac Cocoa.
Also started some Spring cleaning (it's just around the corner!) and
applied some YAGNI :-)
Reviewed-by: NRC
Reviewed-by: mariusSO
|
| | |
|
| |
|
|
|
|
| |
... but test against the test server.
Reviewed-by: ogoffart
|
| |
|
|
|
|
| |
Make db autotest data set generation more consistent, slightly faster.
Also, add ability to easily generate a set of a single databases
entries worth of criteria to test.
|
| |
|
|
|
|
|
|
| |
Handle cases where QProcess::start() and startDetached() are passed a
null, empty, or "invalid" program string instead of crashing.
Task-number: 247865
Reviewed-by: Andreas Aardal Hanssen
|
| |
|
|
|
|
|
|
|
| |
offsets not handled correctly
Now also removes negative timestamps.
Task-number: 249059
Reviewed-by: Justin McPherson
|
| |
|
|
| |
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
| |
|
|
|
|
| |
Signoff-by: Thiago Macieira <thiago.macieira@nokia.com>
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test if we're not past the end of the array before we attempt to read it.
Dates without timezone information are taken to be UTC, so merge the code.
If the date parsing failed, don't add a malformed cookie. Better to
have no cookie than to have it for past its expiration date.
Also update the autotests, since we now can cope with some of the
invalid cookies seen on the net.
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to our documentation we should ignore leading and trailing
whitespaces when converting a string to number with QLocale::toInt and
similar functions. However that didn't work for some locales - for
those ones that declare groupseparator as 0xa0 (which looks similar to
space) since we provide a workaround to accept space as a group
separator for those locales. And since the workaround was there for a
long time it doesn't make sense to change the behavior and the fix is
to explicitely remove leading and trailing whitespaces before doing
any conversion.
Reviewed-by: mariusSO
|
| |
|
|
|
|
|
| |
Call isEmpty() on the normalized rect instead of the original rect.
Task-number: 247505
Reviewed-by:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This may happen if you only have something like
QAbstractScrollArea:focus { background: foo; }
and you do not have a background set for the general case
and the viewport has a different background role (such as QTextEdit,
QAbstractItemView, ....)
This is a regression from 4.4 since in 4.4 the :focus has no effect if
you didn't have a background for the general case.
Reviewed-by: bnilsen
Task-number: 188195
|
| |
|
|
|
|
|
|
|
|
| |
When drawing ellipse without stroke we need to use the same width/height
for the fill as we would use for the stroke for the stroke and fill to
match. Filling first and then stroking should produce the same result as
filling and stroking in one go.
Task-number: 249490
Reviewed-by: Trond
|
| |
|
|
|
|
|
|
|
|
|
| |
qscriptvalue_cast implementation was changed from 4.4 to 4.5 because
of the introduction of QScriptValue constructors that don't take an
engine pointer. However, when the old constructors are used, the
behavior of qscriptvalue_cast should be as before, which this patch
ensures. In short: If we have an engine pointer, use it.
Task-number: 248802
Reviewed-by: Ariya Hidayat
|
| |
|
|
|
|
|
|
|
| |
The pieceTable member was only initialized by QTextDocumentPrivate
_after_ the call to createObject. This patch initializes it at
construction time.
Task-number: 246138
Reviewed-by: Simon Hausmann
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The testlib subtests are conceptually not standalone unit tests, rather
they are helper programs for the real unit test, tst_selftests.
So, as is done for other similar tests (e.g. qprocess), don't name them
with `tst_'.
This makes it easier for automated tools to figure out that they
shouldn't directly run these tests.
Reviewed-by: Shane Bradley
|
| |
|
|
| |
perforce.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Calling setCompletionPrefix() on a QCompleter from a slot connected
to the editingFinished() signal of the corresponding QLineEdit
could in some cases alter the internal state of the completer in
such a way that an assertion would fail. The fix prevents the
asserting code from being called in this particular state.
Reviewed-by: janarve
Task-number: 246056
|
| |
|
|
| |
Reviewed-by: Thierry
|
| |
|
|
|
|
|
| |
aefadefae655972287b196e6c0f0563c4fb4666c was not good enough
Task-number: 248094
Reviewed-by: Jens Bache-Wiig <jbache@trolltech.com>
|
| |
|
|
|
|
|
|
|
|
| |
When a toplevel window is the widget that can accept keyboard input,
it doesn't get focus when shown. The fix is to check if the toplevel
is activated and noone has focus, then give focus to the toplevel
itself.
Reviewed-by: Brad
Task-number: 244607
|
| |
|
|
|
|
|
| |
model is reset
Task-number: 248868 (part 2)
Reviewed-by: Thierry
|
| |
|
|
|
| |
Task-number: 248868 (part 1)
Reviewed-by: Thierry
|
| |
|
|
|
|
|
|
|
| |
Do not send a QFontChange event before the item has been polished. This
is because we cannot call a virtual function while we're in the ctor.
This is basically the same as how we do it in QWidget.
Task-number: 246215
Reviewed-by: alexis
|
| |
|
|
|
|
|
| |
Missing increments in the blend function's tail code.
Task-number: 247492
Reviewed-by: Paul
|
| |
|
|
|
|
|
|
|
| |
Task: 246446
RevBy: Olivier
AutoTest: tst_qpixmap::test_246446()
Details: The new QX11PixmapData object wasn't referenced (e.g. the ref
count would be 0) after calling setMask() on a 32 bit QPixmap
when Xrender was used.
|
| |
|
