| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| | |
Conflicts:
src/corelib/kernel/qsharedmemory_unix.cpp
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
newline
Do the same special case as for QTextEdit
(yes, this is a pitty that we have special cases like that
Reviewed-by: Thierry
Task-number: 252532
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Although QTemporaryFile hides QFile::open(OpenMode), this function is
still available when accessing instance methods through the base class.
Unconditionally setting ReadWrite allows the temporary file to be
re-opened with different flags.
Task-number: 248223
Reviewed-by: Thiago
|
| |
| |
| |
| |
| |
| |
| | |
Note: this showed even if the file descriptor was kept open.
Reviewed-by: Peter Hartmann
Reviewed-by: Thiago
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When copying a resource file to the native file system the (read-only)
permissions also get copied. On Windows platforms, this was preventing a
test file from being deleted.
Reviewed-by: Peter Hartmann
Reviewed-by: Thiago
|
| |
| |
| |
| |
| |
| |
| | |
Also added check in test case for rename fallback.
Task-number: 165920
Reviewed-by: Thiago
|
| |
| |
| |
| | |
Trying to get coverage up to 100%
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
When the signal or senderObject is changed while the state is active,
the transition needs to be unregistered _before_ either property is
changed, only _then_ can it be re-registered.
|
| |
| |
| |
| |
| |
| | |
When the eventType or eventObject is changed while the state is active,
the transition needs to be unregistered _before_ either property is
changed, only _then_ can it be re-registered.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Easing curve autotests was converting the easing(qreal) to int before,
but this is a very rough comparison and was failing due to different
conversions to int, so now we do a qFuzzyCompare.
Reviewed-by: Thierry
|
|\ \
| |/ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This test verifies that the network test server is behaving as
expected. I think I caught all the services we need testing in the
server, but there's still some work to be done:
1) verify that the FTP files are there where they're supposed to be
2) verify that FTP writable areas are writable
3) verify that the HTTP server has the correct files too
4) verify that the HTTP server requests credentials for the protected area
5) attempt to do NTLM authentication to verify the password (probably
can't be done with netChat)
6) add Windows SMB tests (//qt-test-server/etc.)
7) add SQL tests (connecting to the SQL server ports)
It would be good as well if we could not use QtNetwork. If you break
QtNetwork, this test breaks too, so we don't know where the fault
is. However, rewriting networking code will add another source of bugs
(same for the NTLM authentication).
Reviewed-By: João Abecasis
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
ignorance.
If both pointers are out of 4-byte alignment, doing the first load
will align them so we can do 32-bit comparisons. Lars's code had this
before, but I misunderstood it and removed, thinking it was doing
misaligned accesses.
I experimented with moving the tail comparison above the 32-bit
comparison to save a register, but it made things worse.
Reviewed-By: Bradley T. Hughes
|
| |
| |
| |
| | |
Reviewed-By: Bradley T. Hughes
|
| | |
|
| |
| |
| |
| |
| |
| | |
QGraphicsItem
Acknowledged-by: Thierry
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With the new properties it is possible to easily animate.
Setting a transform using setTransform is incompatible with thoses
properties. Accessing thoses propeties if you set previously a
transform will give you the default values.
Acknowledged-by: Code made with Andreas. Documentation written with Thierry.
This still need a more in depth code review and documentation review.
But it is urgent to commit now because the Animation API integration depends on it.
|
|\ \
| |/ |
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
header + file. Now test check only size of the real file content,
assuming that it is rather boring (9,5MB of '\0'). It simply skip
header.
Reviewed by Peter Hartmann
|
| | |
| | |
| | |
| | | |
Reviewed-by: Peter Hartmann
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
That way we prevent the current possible race condition that may appears
while touching signals slot while object are moved to different threads.
For exemple, when we do sender->threadData->mutex->lock(); the sender
can possibly be moved to another thread between the moment we get the
pointer to the threadData and the moment we aquire the lock. We could
check if we locked the right mutex and retry otherwise, but that would
break if the threadData (and hence the mutex) get destroyed in between.
The per object mutex is implemented with a thread pool.
I'm not using the global QThreadPool because we might ends up locking
two of their mutex, and that would be dangerous if something else holds
a lock on the same mutex (possible deadlock)
Putting the mutex pool in a Q_GLOBAL_STATIC doesn't work as it might
result of the ppol being deleted before some other object in others
Q_GLOBAL_STATIC structures
There is no need to lock this mutex in moveToThread as this is safe.
When emiting a signal, we do not need to lock the thread data, as the
user must ensure that the object is not moved to a thread while emiting
a AutoConnection signal.
Reviewed-by: Brad
|
|\ \ \
| | |/
| |/| |
|
| |/
| |
| |
| |
| |
| |
| | |
... by being able to load the certificates also in a shadow build
directory
Reviewed-by: Thiago
|
| |
| |
| |
| | |
Reviewed-by: Trust Me
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Refactor the test of QImageReader to work with shadow build.
Add two tests for the TIFF format
Fix an error of the test of QImageWriter that prevented the cleaning
of the created files after the test.
Reviewed-by: Olivier
|
|\ \
| |/ |
|
| |
| |
| |
| |
| |
| |
| | |
translucentWidget: On Windows mobile the ColorRedWidget is initially
moved to the taskbar position where it cannot be grabbed.
Reviewed-by: mauricek
|
| |
| |
| |
| |
| |
| |
| | |
On some platforms (e.g. Mac) it's not sufficient to call
processEvents() only once.
Reviewed-by: Andreas Aardal Hanssen
|
| |
| |
| |
| | |
Reviewed-By: Peter Hartmann
|
| |
| |
| |
| | |
Reviewed-by: Peter Hartmann
|
| |
| |
| |
| | |
failures in Berlin.
|
| |
| |
| |
| |
| |
| | |
... but use the test server instead
Reviewed-by: Frans Englich
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
While downloadProgress and uploadProgress both work on local files.
There still may be a delay before the connection is actually picked up.
This usually is caught by the processEvents(), but could be missed.
Therefore, do a wait if we don't have any pending connections and work
in ALL cases.
Reviewed-by: Markus Goetz
|
| |
| |
| |
| |
| |
| |
| | |
I think grabWindow was borken and we were compensating for it in the
auto test. Now that it works as documented our workaround broke.
Reviewed-by: Morten Sørvig
|
| |
| |
| |
| | |
Reviewed-by: jbache
|
| |
| |
| |
| | |
It's not enough to call processEvents() just once on all platforms.
|
| |
| |
| |
| |
| |
| | |
Not always is "." in the includes path...
Reviewed-by: mauricek
|
| |
| |
| |
| | |
Reviewed-by: mauricek
|
| |
| |
| |
| |
| |
| | |
Fixed a broken include
Reviewed-by: Thomas Zander
|
| |
| |
| |
| |
| | |
QApplication::activeWindow() returns null for native dialogs, so null
cannot be passed as the target widget when calling QTest::keyClick().
|
| |
| |
| |
| | |
Reviewed-by: Thomas Zander
|
| |
| |
| |
| |
| |
| |
| | |
Some optimized smooth scaling functions were introduced in 4.5, so
increase the tolerance level a small bit.
Reviewed-by: Trond
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It's wrong to assume that static_cast<> is allowed everywhere where
dynamic_cast<> is allowed. For example, if class C derives from both A
and B, then you can dynamic_cast<B *>(ptr_to_A), but you can't
static_cast.
So introduce a helper for dynamic casts that doesn't do
static_cast.
Reviewed-by: Olivier Goffart
|