From 244f5ee9c2c34ddee200e4d5cdc1345762a5901b Mon Sep 17 00:00:00 2001
From: Olivier Goffart <ogoffart@trolltech.com>
Date: Wed, 29 Apr 2009 17:01:04 +0200
Subject: Fix QFormLayout which allowed fields to be smaller that their minimum
 size

If the label's sizeHint is bigger than its minimumSizeHint, the field
may be resized smaller than its minimum size.

This also fix another problem where the field would 'jump' from one
sizehint to the others.

(This can happen if labels can word-wrap for example)

Reviewed-by: Michael Goddard
---
 src/gui/kernel/qformlayout.cpp             |  6 +++++-
 tests/auto/qformlayout/tst_qformlayout.cpp | 30 ++++++++++++++++++++++++++++++
 2 files changed, 35 insertions(+), 1 deletion(-)

diff --git a/src/gui/kernel/qformlayout.cpp b/src/gui/kernel/qformlayout.cpp
index e2d6108..a665c89 100644
--- a/src/gui/kernel/qformlayout.cpp
+++ b/src/gui/kernel/qformlayout.cpp
@@ -689,12 +689,16 @@ void QFormLayoutPrivate::setupVerticalLayoutData(int width)
     // are split.
     maxLabelWidth = 0;
     if (!wrapAllRows) {
+        int maxFieldMinWidth = 0; //the maximum minimum size of the field
         for (int i = 0; i < rr; ++i) {
             const QFormLayoutItem *label = m_matrix(i, 0);
             const QFormLayoutItem *field = m_matrix(i, 1);
-            if (label && (label->sizeHint.width() + (field ? field->minSize.width() : 0) <= width))
+            if (label && field && label->sideBySide)
                 maxLabelWidth = qMax(maxLabelWidth, label->sizeHint.width());
+            if (field)
+                maxFieldMinWidth = qMax(maxFieldMinWidth, field->minSize.width() + field->sbsHSpace);
         }
+        maxLabelWidth = qMin(maxLabelWidth, width - maxFieldMinWidth);
     } else {
         maxLabelWidth = width;
     }
diff --git a/tests/auto/qformlayout/tst_qformlayout.cpp b/tests/auto/qformlayout/tst_qformlayout.cpp
index c4c6f70..242974d 100644
--- a/tests/auto/qformlayout/tst_qformlayout.cpp
+++ b/tests/auto/qformlayout/tst_qformlayout.cpp
@@ -125,6 +125,7 @@ private slots:
     Qt::Orientations expandingDirections() const;
 */
 
+    void fieldMinimumSize();
 };
 
 tst_QFormLayout::tst_QFormLayout()
@@ -905,6 +906,35 @@ void tst_QFormLayout::layoutAlone()
     QTest::qWait(500);
 }
 
+
+void tst_QFormLayout::fieldMinimumSize()
+{
+    //check that the field with is bigger than its minimumSizeHint for any size of the widget
+    // even if the label with is not fixed
+    QWidget w;
+    QFormLayout layout;
+    layout.setFieldGrowthPolicy(QFormLayout::AllNonFixedFieldsGrow);
+    w.setLayout(&layout);
+    QLabel label1("Here is a strange test case");
+    label1.setWordWrap(true);
+    QLabel label2("Here is another label");
+    label2.setWordWrap(true);
+    QLabel shortLabel("short");
+    QLabel longLabel("Quite long label");
+    layout.addRow(&label1, &shortLabel);
+    layout.addRow(&label2, &longLabel);
+    w.show();
+    int width = w.size().width() + 9;
+
+    do {
+        w.resize(width, w.size().height());
+        layout.activate();
+        QVERIFY(shortLabel.size().width() >= shortLabel.minimumSizeHint().width());
+        QVERIFY(longLabel.size().width() >= longLabel.minimumSizeHint().width());
+        width -= 3;
+    } while(width >= w.minimumSizeHint().width());
+}
+
 QTEST_MAIN(tst_QFormLayout)
 
 #include "tst_qformlayout.moc"
-- 
cgit v0.12