From 3f314cb73b9404ac899d503c1ec16aeafe33ea4b Mon Sep 17 00:00:00 2001 From: Konstantin Ritt Date: Mon, 29 Nov 2010 18:45:00 +0100 Subject: add reminders for Qt 5.0 * QChar::NoCategory is a `fake` category since there is no relevant equivalence for it in the Unicode specs; the default category for invalid/unassigned codepoints is QChar::Other_NotAssigned. QChar::NoCategory already caused some troubles in the past, so let's remember that lesson and do not repeat this mistake anymore; * QChar::Unicode_Unassigned == 0 and thus it is less than any other QChar::UnicodeVersion value that makes test for unassigned (in some Unicode version) codepoints a bit more complex (eg `if (v == QChar::Unicode_Unassigned || v > QChar::Unicode_3_1)` to check if some codepoint is unassigned for Unicode 3.1); * QChar::Punctuation_Dask was just a typo. Merge-request: 947 Reviewed-by: Thiago Macieira --- src/corelib/tools/qchar.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/corelib/tools/qchar.h b/src/corelib/tools/qchar.h index ecc6603..8991d07 100644 --- a/src/corelib/tools/qchar.h +++ b/src/corelib/tools/qchar.h @@ -105,7 +105,7 @@ public: enum Category { - NoCategory, + NoCategory, // ### Qt 5: replace with Other_NotAssigned Mark_NonSpacing, // Mn Mark_SpacingCombining, // Mc @@ -144,7 +144,7 @@ public: Symbol_Modifier, // Sk Symbol_Other, // So - Punctuation_Dask = Punctuation_Dash // oops + Punctuation_Dask = Punctuation_Dash // ### Qt 5: remove }; enum Direction @@ -210,7 +210,7 @@ public: }; enum UnicodeVersion { - Unicode_Unassigned, + Unicode_Unassigned, // ### Qt 5: assign with some constantly big value Unicode_1_1, Unicode_2_0, Unicode_2_1_2, -- cgit v0.12