From 04510ff7b065b27f2a80f2cbf42cb097c98923b0 Mon Sep 17 00:00:00 2001 From: mread Date: Thu, 17 Feb 2011 11:43:54 +0000 Subject: Improving init_symbian_thread_handle From review comments on QThread_Symbian.cpp. init_symbian_thread_handle now opens the thread with process wide ownership directly, rather than going through an intermediate Duplicate. Retested QTBUG-13612 test case, which originally caused that function to be written. tst_qthread passes. Task-number: QTBUG-13990 Reviewed-by: Shane Kearns --- src/corelib/thread/qthread_symbian.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/corelib/thread/qthread_symbian.cpp b/src/corelib/thread/qthread_symbian.cpp index bb1a4a7..4bbf5e3 100644 --- a/src/corelib/thread/qthread_symbian.cpp +++ b/src/corelib/thread/qthread_symbian.cpp @@ -78,12 +78,7 @@ static void init_symbian_thread_handle(RThread &thread) { thread = RThread(); TThreadId threadId = thread.Id(); - thread.Open(threadId); - - // Make thread handle accessible process wide - RThread originalCloser = thread; - thread.Duplicate(thread, EOwnerProcess); - originalCloser.Close(); + qt_symbian_throwIfError(thread.Open(threadId, EOwnerProcess)); } QThreadData *QThreadData::current() -- cgit v0.12