From 32815bd71b08f1a8bbec04e60a973a1fa2d9febe Mon Sep 17 00:00:00 2001 From: Shane Kearns Date: Mon, 26 Oct 2009 15:43:55 +0100 Subject: Make network self test fail instead of crashing in case of DNS error Reviewed-by: Liang QI Reviewed-by: Aleksandar Sasha Babic --- tests/auto/networkselftest/tst_networkselftest.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/auto/networkselftest/tst_networkselftest.cpp b/tests/auto/networkselftest/tst_networkselftest.cpp index d58402b..a09d998 100644 --- a/tests/auto/networkselftest/tst_networkselftest.cpp +++ b/tests/auto/networkselftest/tst_networkselftest.cpp @@ -333,6 +333,11 @@ QHostAddress tst_NetworkSelfTest::serverIpAddress() if (cachedIpAddress.protocol() == QAbstractSocket::UnknownNetworkLayerProtocol) { // need resolving QHostInfo resolved = QHostInfo::fromName(QtNetworkSettings::serverName()); + if(resolved.error() != QHostInfo::NoError || + !resolved.addresses().isEmpty()) { + qWarning("QHostInfo::fromName failed (%d).", resolved.error()); + return QHostAddress(QHostAddress::Null); + } cachedIpAddress = resolved.addresses().first(); } return cachedIpAddress; -- cgit v0.12