From 3dd9e6a40bc4131ebc35d367af69fd9197e19344 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Tue, 15 Mar 2011 14:42:03 +0100 Subject: Option::fixString: Avoid double hash lookups for cache hits. Reviewed-by: Oswald Buddenhagen --- qmake/option.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/qmake/option.cpp b/qmake/option.cpp index fcbf5fa..28b764a 100644 --- a/qmake/option.cpp +++ b/qmake/option.cpp @@ -624,10 +624,12 @@ Option::fixString(QString string, uchar flags) qmakeAddCacheClear(qmakeDeleteCacheClear >, (void**)&cache); } FixStringCacheKey cacheKey(string, flags); - if(cache->contains(cacheKey)) { - const QString ret = cache->value(cacheKey); - //qDebug() << "Fix (cached) " << orig_string << "->" << ret; - return ret; + + QHash::const_iterator it = cache->constFind(cacheKey); + + if (it != cache->constEnd()) { + //qDebug() << "Fix (cached) " << orig_string << "->" << it.value(); + return it.value(); } //fix the environment variables -- cgit v0.12