From 562adecf4f938f593674f03b425a79b89e238518 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Abecasis?= <joao@abecasis.name>
Date: Wed, 15 Apr 2009 14:17:20 +0200
Subject: Don't block copy sequential files in QFile::rename

Block copying a sequential file is potentially a destructive operation,
because there is no guarantee copy+remove will succeed. In these cases
the fallback should not be tried.

The user is better equipped to decide how to handle such failures and to
ensure no data losses occur, e.g., copy without removing the original
file.

Reviewed-by: MariusSO
Reviewed-by: Peter Hartmann
Reviewed-by: Thiago
---
 src/corelib/io/qfile.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/corelib/io/qfile.cpp b/src/corelib/io/qfile.cpp
index d7da800..4110494 100644
--- a/src/corelib/io/qfile.cpp
+++ b/src/corelib/io/qfile.cpp
@@ -718,6 +718,11 @@ QFile::rename(const QString &newName)
             return true;
         }
 
+        if (isSequential()) {
+            d->setError(QFile::RenameError, tr("Will not rename sequential file using block copy"));
+            return false;
+        }
+
         QFile in(fileName());
         QFile out(newName);
         if (in.open(QIODevice::ReadOnly)) {
-- 
cgit v0.12