From 3de5c8c3c3a1d22a565b2fefd0c11cd71df2bbf1 Mon Sep 17 00:00:00 2001 From: Peter Hartmann Date: Tue, 23 Oct 2012 12:42:20 +0200 Subject: Blackberry bearer plugin: Only Report working interfaces as active Some interfaces might be connected but not working (e.g. no IP address, no gateway etc.) In practice, this prevents the USB interface (among others) from being reported as active and thus the QNetworkConfigurationManager as being reported as online. We only want Wifi and 3G etc. connections to be reported as online when they are up. (cherry picked from commit b9551c1b47277d58d86a82ce15501663257ed9a1) Change-Id: Ia175d701280db44a08b9535803a94806a5d6f30f Reviewed-by: Sean Harmer Reviewed-by: Rafael Roquetto --- src/plugins/bearer/blackberry/qbbengine.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/plugins/bearer/blackberry/qbbengine.cpp b/src/plugins/bearer/blackberry/qbbengine.cpp index 2de69f4..908fecc 100644 --- a/src/plugins/bearer/blackberry/qbbengine.cpp +++ b/src/plugins/bearer/blackberry/qbbengine.cpp @@ -330,15 +330,14 @@ void QBBEngine::updateConfiguration(const char *interface) const QString id = idForName(name); - const int numberOfIpAddresses = netstatus_interface_get_num_ip_addresses(details); - const bool isConnected = netstatus_interface_is_connected(details); const netstatus_interface_type_t type = netstatus_interface_get_type(details); + const netstatus_ip_status_t ipStatus = netstatus_interface_get_ip_status(details); netstatus_free_interface_details(&details); QNetworkConfiguration::StateFlags state = QNetworkConfiguration::Defined; - if (isConnected && (numberOfIpAddresses > 0)) + if (ipStatus == NETSTATUS_IP_STATUS_OK) state |= QNetworkConfiguration::Active; QMutexLocker locker(&mutex); -- cgit v0.12