From 32da94f1e58cf8591610bd3676ba448b5d7e55c0 Mon Sep 17 00:00:00 2001 From: Markus Goetz Date: Tue, 19 Oct 2010 17:25:38 +0200 Subject: QNAM HTTP: Pause connection when emitting proxy auth signal Pause the socket notifiers because the user could be displaying a dialog which makes the event loop run and could make our socket notifiers fire. Reviewed-by: Prasanth Task-Number: QTBUG-13234 --- src/network/access/qhttpnetworkconnection.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/network/access/qhttpnetworkconnection.cpp b/src/network/access/qhttpnetworkconnection.cpp index 8e8c34d..d861cc1 100644 --- a/src/network/access/qhttpnetworkconnection.cpp +++ b/src/network/access/qhttpnetworkconnection.cpp @@ -969,7 +969,11 @@ void QHttpNetworkConnection::ignoreSslErrors(const QList &errors, int void QHttpNetworkConnectionPrivate::emitProxyAuthenticationRequired(const QHttpNetworkConnectionChannel *chan, const QNetworkProxy &proxy, QAuthenticator* auth) { Q_Q(QHttpNetworkConnection); + // Also pause the connection because socket notifiers may fire while an user + // dialog is displaying + pauseConnection(); emit q->proxyAuthenticationRequired(proxy, auth, q); + resumeConnection(); int i = indexOf(chan->socket); copyCredentials(i, auth, true); } -- cgit v0.12