From e5b83ec3dc4e2f4c18b67d45a5699da5a3f05f10 Mon Sep 17 00:00:00 2001
From: Lars Knoll <lars.knoll@nokia.com>
Date: Tue, 2 Jun 2009 22:05:01 +0200
Subject: optimise isFullyTransparent()

This cuts down quite some intructions in some use cases,
making esp. discardUpdateRequest() a bit cheaper.
---
 src/gui/graphicsview/qgraphicsitem_p.h | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)

diff --git a/src/gui/graphicsview/qgraphicsitem_p.h b/src/gui/graphicsview/qgraphicsitem_p.h
index d92d76e..d007f03 100644
--- a/src/gui/graphicsview/qgraphicsitem_p.h
+++ b/src/gui/graphicsview/qgraphicsitem_p.h
@@ -276,13 +276,8 @@ public:
     void invalidateCachedClipPathRecursively(bool childrenOnly = false, const QRectF &emptyIfOutsideThisRect = QRectF());
     void updateCachedClipPathFromSetPosHelper(const QPointF &newPos);
 
-    inline bool isFullyTransparent() const
-    { return effectiveOpacity() < .001; }
-
-    inline qreal effectiveOpacity() const {
-        if (!parent)
-            return opacity;
-
+    inline qreal calcEffectiveOpacity() const
+    {
         qreal o = opacity;
         QGraphicsItem *p = parent;
         int myFlags = flags;
@@ -303,6 +298,23 @@ public:
         return o;
     }
 
+    inline bool isFullyTransparent() const
+    {
+        if (opacity < 0.001)
+            return true;
+        if (!parent)
+            return false;
+
+        return calcEffectiveOpacity() < 0.001;
+    }
+
+    inline qreal effectiveOpacity() const {
+        if (!parent || !opacity)
+            return opacity;
+
+        return calcEffectiveOpacity();
+    }
+
     inline bool childrenCombineOpacity() const
     {
         if (!children.size())
-- 
cgit v0.12