1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2887
2888
2889
2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906
2907
2908
2909
2910
2911
2912
2913
2914
2915
2916
2917
2918
2919
2920
2921
2922
2923
2924
2925
2926
2927
2928
2929
2930
2931
2932
2933
2934
2935
2936
2937
2938
2939
2940
2941
2942
2943
2944
2945
2946
2947
2948
2949
2950
2951
2952
2953
2954
2955
2956
2957
2958
2959
2960
2961
2962
2963
2964
2965
2966
2967
2968
2969
2970
2971
2972
2973
2974
2975
2976
2977
2978
2979
2980
2981
2982
2983
2984
2985
2986
2987
2988
2989
2990
2991
2992
2993
2994
2995
2996
2997
2998
2999
3000
3001
3002
3003
3004
3005
3006
3007
3008
3009
3010
3011
3012
3013
3014
3015
3016
3017
3018
3019
3020
3021
3022
3023
3024
3025
3026
3027
3028
3029
3030
3031
3032
3033
3034
3035
3036
3037
3038
3039
3040
3041
3042
3043
3044
3045
3046
3047
3048
3049
3050
3051
3052
3053
3054
3055
3056
3057
3058
3059
3060
3061
3062
3063
3064
3065
3066
3067
3068
3069
3070
3071
3072
3073
3074
3075
3076
3077
3078
3079
3080
3081
3082
3083
3084
3085
3086
3087
3088
3089
3090
3091
3092
3093
3094
3095
3096
3097
3098
3099
3100
3101
3102
3103
3104
3105
3106
3107
3108
3109
3110
3111
3112
3113
3114
3115
3116
3117
3118
3119
3120
3121
3122
3123
3124
3125
3126
3127
3128
3129
3130
3131
3132
3133
3134
3135
3136
3137
3138
3139
3140
3141
3142
3143
3144
3145
3146
3147
3148
3149
3150
3151
3152
3153
3154
3155
3156
3157
3158
3159
3160
3161
3162
3163
3164
3165
3166
3167
3168
3169
3170
3171
3172
3173
3174
3175
3176
3177
3178
3179
3180
3181
3182
3183
3184
3185
3186
3187
3188
3189
3190
3191
3192
3193
3194
3195
3196
3197
3198
3199
3200
3201
3202
3203
3204
3205
3206
3207
3208
3209
3210
3211
3212
3213
3214
3215
3216
3217
3218
3219
3220
3221
3222
3223
3224
3225
3226
3227
3228
3229
3230
3231
3232
3233
3234
3235
3236
3237
3238
3239
3240
3241
3242
3243
3244
3245
3246
3247
3248
3249
3250
3251
3252
3253
3254
3255
3256
3257
3258
3259
3260
3261
3262
3263
3264
3265
3266
3267
3268
3269
3270
3271
3272
3273
3274
3275
3276
3277
3278
3279
3280
3281
3282
3283
3284
3285
3286
3287
3288
3289
3290
3291
3292
3293
3294
3295
3296
3297
3298
3299
3300
3301
3302
3303
3304
3305
3306
3307
3308
3309
3310
3311
3312
3313
3314
3315
3316
3317
3318
3319
3320
3321
3322
3323
3324
3325
3326
3327
3328
3329
3330
3331
3332
3333
3334
3335
3336
3337
3338
3339
3340
3341
3342
3343
3344
3345
3346
3347
3348
3349
3350
3351
3352
3353
3354
3355
3356
3357
3358
3359
3360
3361
3362
3363
3364
3365
3366
3367
3368
3369
3370
3371
3372
3373
3374
3375
3376
3377
3378
3379
3380
3381
3382
3383
3384
3385
3386
3387
3388
3389
3390
3391
3392
3393
3394
3395
3396
3397
3398
3399
3400
3401
3402
3403
3404
3405
3406
3407
3408
3409
3410
3411
3412
3413
3414
3415
3416
3417
3418
3419
3420
3421
3422
3423
3424
3425
3426
3427
3428
3429
3430
3431
3432
3433
3434
3435
3436
3437
3438
3439
3440
3441
3442
3443
3444
3445
3446
3447
3448
3449
3450
3451
3452
3453
3454
3455
3456
3457
3458
3459
3460
3461
3462
3463
3464
3465
3466
3467
3468
3469
3470
3471
3472
3473
3474
3475
3476
3477
3478
3479
3480
3481
3482
3483
3484
3485
3486
3487
3488
3489
3490
3491
3492
3493
3494
3495
3496
3497
3498
3499
3500
3501
3502
3503
3504
3505
3506
3507
3508
3509
3510
3511
3512
3513
3514
3515
3516
3517
3518
3519
3520
3521
3522
3523
3524
3525
3526
3527
3528
3529
3530
3531
3532
3533
3534
3535
3536
3537
3538
3539
3540
3541
3542
3543
3544
3545
3546
3547
3548
3549
3550
3551
3552
3553
3554
3555
3556
3557
3558
3559
3560
3561
3562
3563
3564
3565
3566
3567
3568
3569
3570
3571
3572
3573
3574
3575
3576
3577
3578
3579
3580
3581
3582
3583
3584
3585
3586
3587
3588
3589
3590
3591
3592
3593
3594
3595
3596
3597
3598
3599
3600
3601
3602
3603
3604
3605
3606
3607
3608
3609
3610
3611
3612
3613
3614
3615
3616
3617
3618
3619
3620
3621
3622
3623
3624
3625
3626
3627
3628
3629
3630
3631
3632
3633
3634
3635
3636
3637
3638
3639
3640
3641
3642
3643
3644
3645
3646
3647
3648
3649
3650
3651
3652
3653
3654
3655
3656
3657
3658
3659
3660
3661
3662
3663
3664
3665
3666
3667
3668
3669
3670
3671
3672
3673
3674
3675
3676
3677
3678
3679
3680
3681
3682
3683
3684
3685
3686
3687
3688
3689
3690
3691
3692
3693
3694
3695
3696
3697
3698
3699
3700
3701
3702
3703
3704
3705
3706
3707
3708
3709
3710
3711
3712
3713
3714
3715
3716
3717
3718
3719
3720
3721
3722
3723
3724
3725
3726
3727
3728
3729
3730
3731
3732
3733
3734
3735
3736
3737
3738
3739
3740
3741
3742
3743
3744
3745
3746
3747
3748
3749
3750
3751
3752
3753
3754
3755
3756
3757
3758
3759
3760
3761
3762
3763
3764
3765
3766
3767
3768
3769
3770
3771
3772
3773
3774
3775
3776
3777
3778
3779
3780
3781
3782
3783
3784
3785
3786
3787
3788
3789
3790
3791
3792
3793
3794
3795
3796
3797
3798
3799
3800
3801
3802
3803
3804
3805
3806
3807
3808
3809
3810
3811
3812
3813
3814
3815
3816
3817
3818
3819
3820
3821
3822
3823
3824
3825
3826
3827
3828
3829
3830
3831
3832
3833
3834
3835
3836
3837
3838
3839
3840
3841
3842
3843
3844
3845
3846
3847
3848
3849
3850
3851
3852
3853
3854
3855
3856
3857
3858
3859
3860
3861
3862
3863
3864
3865
3866
3867
3868
3869
3870
3871
3872
3873
3874
3875
3876
3877
3878
3879
3880
3881
3882
3883
3884
3885
3886
3887
3888
3889
3890
3891
3892
3893
3894
3895
3896
3897
3898
3899
3900
3901
3902
3903
3904
3905
3906
3907
3908
3909
3910
3911
3912
3913
3914
3915
3916
3917
3918
3919
3920
3921
3922
3923
3924
3925
3926
3927
3928
3929
3930
3931
3932
3933
3934
3935
3936
3937
3938
3939
3940
3941
3942
3943
3944
3945
3946
3947
3948
3949
3950
3951
3952
3953
3954
3955
3956
3957
3958
3959
3960
3961
3962
3963
3964
3965
3966
3967
3968
3969
3970
3971
3972
3973
3974
3975
3976
3977
3978
3979
3980
3981
3982
3983
3984
3985
3986
3987
3988
3989
3990
3991
3992
3993
3994
3995
3996
3997
3998
3999
4000
4001
4002
4003
4004
4005
4006
4007
4008
4009
4010
4011
4012
4013
4014
4015
4016
4017
4018
4019
4020
4021
4022
4023
4024
4025
4026
4027
4028
4029
4030
4031
4032
4033
4034
4035
4036
4037
4038
4039
4040
4041
4042
4043
4044
4045
4046
4047
4048
4049
4050
4051
4052
4053
4054
4055
4056
4057
4058
4059
4060
4061
4062
4063
4064
4065
4066
4067
4068
4069
4070
4071
4072
4073
4074
4075
4076
4077
4078
4079
4080
4081
4082
4083
4084
4085
4086
4087
4088
4089
4090
4091
4092
4093
4094
4095
4096
4097
4098
4099
4100
4101
4102
4103
4104
4105
4106
4107
4108
4109
4110
4111
4112
4113
4114
4115
4116
4117
4118
4119
4120
4121
4122
4123
4124
4125
4126
4127
4128
4129
4130
4131
4132
4133
4134
4135
4136
4137
4138
4139
4140
4141
4142
4143
4144
4145
4146
4147
4148
4149
4150
4151
4152
4153
4154
4155
4156
4157
4158
4159
4160
4161
4162
4163
4164
4165
4166
4167
4168
4169
4170
4171
4172
4173
4174
4175
4176
4177
4178
4179
4180
4181
4182
4183
4184
4185
4186
4187
4188
4189
4190
4191
4192
4193
4194
4195
4196
4197
4198
4199
4200
4201
4202
4203
4204
4205
4206
4207
4208
4209
4210
4211
4212
4213
4214
4215
4216
4217
4218
4219
4220
4221
4222
4223
4224
4225
4226
4227
4228
4229
4230
4231
4232
4233
4234
4235
4236
4237
4238
4239
4240
4241
4242
4243
4244
4245
4246
4247
4248
4249
4250
4251
4252
4253
4254
4255
4256
4257
4258
4259
4260
4261
4262
4263
4264
4265
4266
4267
4268
4269
4270
4271
4272
4273
4274
4275
4276
4277
4278
4279
4280
4281
4282
4283
4284
4285
4286
4287
4288
4289
4290
4291
4292
4293
4294
4295
4296
4297
4298
4299
4300
4301
4302
4303
4304
4305
4306
4307
4308
4309
4310
4311
4312
4313
4314
4315
4316
4317
4318
4319
4320
4321
4322
4323
4324
4325
4326
4327
4328
4329
4330
4331
4332
4333
4334
4335
4336
4337
4338
4339
4340
4341
4342
4343
4344
4345
4346
4347
4348
4349
4350
4351
4352
4353
4354
4355
4356
4357
4358
4359
4360
4361
4362
4363
4364
4365
4366
4367
4368
4369
4370
4371
4372
4373
4374
4375
4376
4377
4378
4379
4380
4381
4382
4383
4384
4385
4386
4387
4388
4389
4390
4391
4392
4393
4394
4395
4396
4397
4398
4399
4400
4401
4402
4403
4404
4405
4406
4407
4408
4409
4410
4411
4412
4413
4414
4415
4416
4417
4418
4419
4420
4421
4422
4423
4424
4425
4426
4427
4428
4429
4430
4431
4432
4433
4434
4435
4436
4437
4438
4439
4440
4441
4442
4443
4444
4445
4446
4447
4448
4449
4450
4451
4452
4453
4454
4455
4456
4457
4458
4459
4460
4461
4462
4463
4464
4465
4466
4467
4468
4469
4470
4471
4472
4473
4474
4475
4476
4477
4478
4479
4480
4481
4482
4483
4484
4485
4486
4487
4488
4489
4490
4491
4492
4493
4494
4495
4496
4497
4498
4499
4500
4501
4502
4503
4504
4505
4506
4507
4508
4509
4510
4511
4512
4513
4514
4515
4516
4517
4518
4519
4520
4521
4522
4523
4524
4525
4526
4527
4528
4529
4530
4531
4532
4533
4534
4535
4536
4537
4538
4539
4540
4541
4542
4543
4544
4545
4546
4547
4548
4549
4550
4551
4552
4553
4554
4555
4556
4557
4558
4559
4560
4561
4562
4563
4564
4565
4566
4567
4568
4569
4570
4571
4572
4573
4574
4575
4576
4577
4578
4579
4580
4581
4582
4583
4584
4585
4586
4587
4588
4589
4590
4591
4592
4593
4594
4595
4596
4597
4598
4599
4600
4601
4602
4603
4604
4605
4606
4607
4608
4609
4610
4611
4612
4613
4614
4615
4616
4617
4618
4619
4620
4621
4622
4623
4624
4625
4626
4627
4628
4629
4630
4631
4632
4633
4634
4635
4636
4637
4638
4639
4640
4641
4642
4643
4644
4645
4646
4647
4648
4649
4650
4651
4652
4653
4654
4655
4656
4657
4658
4659
4660
4661
4662
4663
4664
4665
4666
4667
4668
4669
4670
4671
4672
4673
4674
4675
4676
4677
4678
4679
4680
4681
4682
4683
4684
4685
4686
4687
4688
4689
4690
4691
4692
4693
4694
4695
4696
4697
4698
4699
4700
4701
4702
4703
4704
4705
4706
4707
4708
4709
4710
4711
4712
4713
4714
4715
4716
4717
4718
4719
4720
4721
4722
4723
4724
4725
4726
4727
4728
4729
4730
4731
4732
4733
4734
4735
4736
4737
4738
4739
4740
4741
4742
4743
4744
4745
4746
4747
4748
4749
4750
4751
4752
4753
4754
4755
4756
4757
4758
4759
4760
4761
4762
4763
4764
4765
4766
4767
4768
4769
4770
4771
4772
4773
4774
4775
4776
4777
4778
4779
4780
4781
4782
4783
4784
4785
4786
4787
4788
4789
4790
4791
4792
4793
4794
4795
4796
4797
4798
4799
4800
4801
4802
4803
4804
4805
4806
4807
4808
4809
4810
4811
4812
4813
4814
4815
4816
4817
4818
4819
4820
4821
4822
4823
4824
4825
4826
4827
4828
4829
4830
4831
4832
4833
4834
4835
4836
4837
4838
4839
4840
4841
4842
4843
4844
4845
4846
4847
4848
4849
4850
4851
4852
4853
4854
4855
4856
4857
4858
4859
4860
4861
4862
4863
4864
4865
4866
4867
4868
4869
4870
4871
4872
4873
4874
4875
4876
4877
4878
4879
4880
4881
4882
4883
4884
4885
4886
4887
4888
4889
4890
4891
4892
4893
4894
4895
4896
4897
4898
4899
4900
4901
4902
4903
4904
4905
4906
4907
4908
4909
4910
4911
4912
4913
4914
4915
4916
4917
4918
4919
4920
4921
4922
4923
4924
4925
4926
4927
4928
4929
4930
4931
4932
4933
4934
4935
4936
4937
4938
4939
4940
4941
4942
4943
4944
4945
4946
4947
4948
4949
4950
4951
4952
4953
4954
4955
4956
4957
4958
4959
4960
4961
4962
4963
4964
4965
4966
4967
4968
4969
4970
4971
4972
4973
4974
4975
4976
4977
4978
4979
4980
4981
4982
4983
4984
4985
4986
4987
4988
4989
4990
4991
4992
4993
4994
4995
4996
4997
4998
4999
5000
5001
5002
5003
5004
5005
5006
5007
5008
5009
5010
5011
5012
5013
5014
5015
5016
5017
5018
5019
5020
5021
5022
5023
5024
5025
5026
5027
5028
5029
5030
5031
5032
5033
5034
5035
5036
5037
5038
5039
5040
5041
5042
5043
5044
5045
5046
5047
5048
5049
5050
5051
5052
5053
5054
5055
5056
5057
5058
5059
5060
5061
5062
5063
5064
5065
5066
5067
5068
5069
5070
5071
5072
5073
5074
5075
5076
5077
5078
5079
5080
5081
5082
5083
5084
5085
5086
5087
5088
5089
5090
5091
5092
5093
5094
5095
5096
5097
5098
5099
5100
5101
5102
5103
5104
5105
5106
5107
5108
5109
5110
5111
5112
5113
5114
5115
5116
5117
5118
5119
5120
5121
5122
5123
5124
5125
5126
5127
5128
5129
5130
5131
5132
5133
5134
5135
5136
5137
5138
5139
5140
5141
5142
5143
5144
5145
5146
5147
5148
5149
5150
5151
5152
5153
5154
5155
5156
5157
5158
5159
5160
5161
5162
5163
5164
5165
5166
5167
5168
5169
5170
5171
5172
5173
5174
5175
5176
5177
5178
5179
5180
5181
5182
5183
5184
5185
5186
5187
5188
5189
5190
5191
5192
5193
5194
5195
5196
5197
5198
5199
5200
5201
5202
5203
5204
5205
5206
5207
5208
5209
5210
5211
5212
5213
5214
5215
5216
5217
5218
5219
5220
5221
5222
5223
5224
5225
5226
5227
5228
5229
5230
5231
5232
5233
5234
5235
5236
5237
5238
5239
5240
5241
5242
5243
5244
5245
5246
5247
5248
5249
5250
5251
5252
5253
5254
5255
5256
5257
5258
5259
5260
5261
5262
5263
5264
5265
5266
5267
5268
5269
5270
5271
5272
5273
5274
5275
5276
5277
5278
5279
5280
5281
5282
5283
5284
5285
5286
5287
5288
5289
5290
5291
5292
5293
5294
5295
5296
5297
5298
5299
5300
5301
5302
5303
5304
5305
5306
5307
5308
5309
5310
5311
5312
5313
5314
5315
5316
5317
5318
5319
5320
5321
5322
5323
5324
5325
5326
5327
5328
5329
5330
5331
5332
5333
5334
5335
5336
5337
5338
5339
5340
5341
5342
5343
5344
5345
5346
5347
5348
5349
5350
5351
5352
5353
5354
5355
5356
5357
5358
5359
5360
5361
5362
5363
5364
5365
5366
5367
5368
5369
5370
5371
5372
5373
5374
5375
5376
5377
5378
5379
5380
5381
5382
5383
5384
5385
5386
5387
5388
5389
5390
5391
5392
5393
5394
5395
5396
5397
5398
5399
5400
5401
5402
5403
5404
5405
5406
5407
5408
5409
5410
5411
5412
5413
5414
5415
5416
5417
5418
5419
5420
5421
5422
5423
5424
5425
5426
5427
5428
5429
5430
5431
5432
5433
5434
5435
5436
5437
5438
5439
5440
5441
5442
5443
5444
5445
5446
5447
5448
5449
5450
5451
5452
5453
5454
5455
5456
5457
5458
5459
5460
5461
5462
5463
5464
5465
5466
5467
5468
5469
5470
5471
5472
5473
5474
5475
5476
5477
5478
5479
5480
5481
5482
5483
5484
5485
5486
5487
5488
5489
5490
5491
5492
5493
5494
5495
5496
5497
5498
5499
5500
5501
5502
5503
5504
5505
5506
5507
5508
5509
5510
5511
5512
5513
5514
5515
5516
5517
5518
5519
5520
5521
5522
5523
5524
5525
5526
5527
5528
5529
5530
5531
5532
5533
5534
5535
5536
5537
5538
5539
5540
5541
5542
5543
5544
5545
5546
5547
5548
5549
5550
5551
5552
5553
5554
5555
5556
5557
5558
5559
5560
5561
5562
5563
5564
5565
5566
5567
5568
5569
5570
5571
5572
5573
5574
5575
5576
5577
5578
5579
5580
5581
5582
5583
5584
5585
5586
5587
5588
5589
5590
5591
5592
5593
5594
5595
5596
5597
5598
5599
5600
5601
5602
5603
5604
5605
5606
5607
5608
5609
5610
5611
5612
5613
5614
5615
5616
5617
5618
5619
5620
5621
5622
5623
5624
5625
5626
5627
5628
5629
5630
5631
5632
5633
5634
5635
5636
5637
5638
5639
5640
5641
5642
5643
5644
5645
5646
5647
5648
5649
5650
5651
5652
5653
5654
5655
5656
5657
5658
5659
5660
5661
5662
5663
5664
5665
5666
5667
5668
5669
5670
5671
5672
5673
5674
5675
5676
5677
5678
5679
5680
5681
5682
5683
5684
5685
5686
5687
5688
5689
5690
5691
5692
5693
5694
5695
5696
5697
5698
5699
5700
5701
5702
5703
5704
5705
5706
5707
5708
5709
5710
5711
5712
5713
5714
5715
5716
5717
5718
5719
5720
5721
5722
5723
5724
5725
5726
5727
5728
5729
5730
5731
5732
5733
5734
5735
5736
5737
5738
5739
5740
5741
5742
5743
5744
5745
5746
5747
5748
5749
5750
5751
5752
5753
5754
5755
5756
5757
5758
5759
5760
5761
5762
5763
5764
5765
5766
5767
5768
5769
5770
5771
5772
5773
5774
5775
5776
5777
5778
5779
5780
5781
5782
5783
5784
5785
5786
5787
5788
5789
5790
5791
5792
5793
5794
5795
5796
5797
5798
5799
5800
5801
5802
5803
5804
5805
5806
5807
5808
5809
5810
5811
5812
5813
5814
5815
5816
5817
5818
5819
5820
5821
5822
5823
5824
5825
5826
5827
5828
5829
5830
5831
5832
5833
5834
5835
5836
5837
5838
5839
5840
5841
5842
5843
5844
5845
5846
5847
5848
5849
5850
5851
5852
5853
5854
5855
5856
5857
5858
5859
5860
5861
5862
5863
5864
5865
5866
5867
5868
5869
5870
5871
5872
5873
5874
5875
5876
5877
5878
5879
5880
5881
5882
5883
5884
5885
5886
5887
5888
5889
5890
5891
5892
5893
5894
5895
5896
5897
5898
5899
5900
5901
5902
5903
5904
5905
5906
5907
5908
5909
5910
5911
5912
5913
5914
5915
5916
5917
5918
5919
5920
5921
5922
5923
5924
5925
5926
5927
5928
5929
5930
5931
5932
5933
5934
5935
5936
5937
5938
5939
5940
5941
5942
5943
5944
5945
5946
5947
5948
5949
5950
5951
5952
5953
5954
5955
5956
5957
5958
5959
5960
5961
5962
5963
5964
5965
5966
5967
5968
5969
5970
5971
5972
5973
5974
5975
5976
5977
5978
5979
5980
5981
5982
5983
5984
5985
5986
5987
5988
5989
5990
5991
5992
5993
5994
5995
5996
5997
5998
5999
6000
6001
6002
6003
6004
6005
6006
6007
6008
6009
6010
6011
6012
6013
6014
6015
6016
6017
6018
6019
6020
6021
6022
6023
6024
6025
6026
6027
6028
6029
6030
6031
6032
6033
6034
6035
6036
6037
6038
6039
6040
6041
6042
6043
6044
6045
6046
6047
6048
6049
6050
6051
6052
6053
6054
6055
6056
6057
6058
6059
6060
6061
6062
6063
6064
6065
6066
6067
6068
6069
6070
6071
6072
6073
6074
6075
6076
6077
6078
6079
6080
6081
6082
6083
6084
6085
6086
6087
6088
6089
6090
6091
6092
6093
6094
6095
6096
6097
6098
6099
6100
6101
6102
6103
6104
6105
6106
6107
6108
6109
6110
6111
6112
6113
6114
6115
6116
6117
6118
6119
6120
6121
6122
6123
6124
6125
6126
6127
6128
6129
6130
6131
6132
6133
6134
6135
6136
6137
6138
6139
6140
6141
6142
6143
6144
6145
6146
6147
6148
6149
6150
6151
6152
6153
6154
6155
6156
6157
6158
6159
6160
6161
6162
6163
6164
6165
6166
6167
6168
6169
6170
6171
6172
6173
6174
6175
6176
6177
6178
6179
6180
6181
6182
6183
6184
6185
6186
6187
6188
6189
6190
6191
6192
6193
6194
6195
6196
6197
6198
6199
6200
6201
6202
6203
6204
6205
6206
6207
6208
6209
6210
6211
6212
6213
6214
6215
6216
6217
6218
6219
6220
6221
6222
6223
6224
6225
6226
6227
6228
6229
6230
6231
6232
6233
6234
6235
6236
6237
6238
6239
6240
6241
6242
6243
6244
6245
6246
6247
6248
6249
6250
6251
6252
6253
6254
6255
6256
6257
6258
6259
6260
6261
6262
6263
6264
6265
6266
6267
6268
6269
6270
6271
6272
6273
6274
6275
6276
6277
6278
6279
6280
6281
6282
6283
6284
6285
6286
6287
6288
6289
6290
6291
6292
6293
6294
6295
6296
6297
6298
6299
6300
6301
6302
6303
6304
6305
6306
6307
6308
6309
6310
6311
6312
6313
6314
6315
6316
6317
6318
6319
6320
6321
6322
6323
6324
6325
6326
6327
6328
6329
6330
6331
6332
6333
6334
6335
6336
6337
6338
6339
6340
6341
6342
6343
6344
6345
6346
6347
6348
6349
6350
6351
6352
6353
6354
6355
6356
6357
6358
6359
6360
6361
6362
6363
6364
6365
6366
6367
6368
6369
6370
6371
6372
6373
6374
6375
6376
6377
6378
6379
6380
6381
6382
6383
6384
6385
6386
6387
6388
6389
6390
6391
6392
6393
6394
6395
6396
6397
6398
6399
6400
6401
6402
6403
6404
6405
6406
6407
6408
6409
6410
6411
6412
6413
6414
6415
6416
6417
6418
6419
6420
6421
6422
6423
6424
6425
6426
6427
6428
6429
6430
6431
6432
6433
6434
6435
6436
6437
6438
6439
6440
6441
6442
6443
6444
6445
6446
6447
6448
6449
6450
6451
6452
6453
6454
6455
6456
6457
6458
6459
6460
6461
6462
6463
6464
6465
6466
6467
6468
6469
6470
6471
6472
6473
6474
6475
6476
6477
6478
6479
6480
6481
6482
6483
6484
6485
6486
6487
6488
6489
6490
6491
6492
6493
6494
6495
6496
6497
6498
6499
6500
6501
6502
6503
6504
6505
6506
6507
6508
6509
6510
6511
6512
6513
6514
6515
6516
6517
6518
6519
6520
6521
6522
6523
6524
6525
6526
6527
6528
6529
6530
6531
6532
6533
6534
6535
6536
6537
6538
6539
6540
6541
6542
6543
6544
6545
6546
6547
6548
6549
6550
6551
6552
6553
6554
6555
6556
6557
6558
6559
6560
6561
6562
6563
6564
6565
6566
6567
6568
6569
6570
6571
6572
6573
6574
6575
6576
6577
6578
6579
6580
6581
6582
6583
6584
6585
6586
6587
6588
6589
6590
6591
6592
6593
6594
6595
6596
6597
6598
6599
6600
6601
6602
6603
6604
6605
6606
6607
6608
6609
6610
6611
6612
6613
6614
6615
6616
6617
6618
6619
6620
6621
6622
6623
6624
6625
6626
6627
6628
6629
6630
6631
6632
6633
6634
6635
6636
6637
6638
6639
6640
6641
6642
6643
6644
6645
6646
6647
6648
6649
6650
6651
6652
6653
6654
6655
6656
6657
6658
6659
6660
6661
6662
6663
6664
6665
6666
6667
6668
6669
6670
6671
6672
6673
6674
6675
6676
6677
6678
6679
6680
6681
6682
6683
6684
6685
6686
6687
6688
6689
6690
6691
6692
6693
6694
6695
6696
6697
6698
6699
6700
6701
6702
6703
6704
6705
6706
6707
6708
6709
6710
6711
6712
6713
6714
6715
6716
6717
6718
6719
6720
6721
6722
6723
6724
6725
6726
6727
6728
6729
6730
6731
6732
6733
6734
6735
6736
6737
6738
6739
6740
6741
6742
6743
6744
6745
6746
6747
6748
6749
6750
6751
6752
6753
6754
6755
6756
6757
6758
6759
6760
6761
6762
6763
6764
6765
6766
6767
6768
6769
6770
6771
6772
6773
6774
6775
6776
6777
6778
6779
6780
6781
6782
6783
6784
6785
6786
6787
6788
6789
6790
6791
6792
6793
6794
6795
6796
6797
6798
6799
6800
6801
6802
6803
6804
6805
6806
6807
6808
6809
6810
6811
6812
6813
6814
6815
6816
6817
6818
6819
6820
6821
6822
6823
6824
6825
6826
6827
6828
6829
6830
6831
6832
6833
6834
6835
6836
6837
6838
6839
6840
6841
6842
6843
6844
6845
6846
6847
6848
6849
6850
6851
6852
6853
6854
6855
6856
6857
6858
6859
6860
6861
6862
6863
6864
6865
6866
6867
6868
6869
6870
6871
6872
6873
6874
6875
6876
6877
6878
6879
6880
6881
6882
6883
6884
6885
6886
6887
6888
6889
6890
6891
6892
6893
6894
6895
6896
6897
6898
6899
6900
6901
6902
6903
6904
6905
6906
6907
6908
6909
6910
6911
6912
6913
6914
6915
6916
6917
6918
6919
6920
6921
6922
6923
6924
6925
6926
6927
6928
6929
6930
6931
6932
6933
6934
6935
6936
6937
6938
6939
6940
6941
6942
6943
6944
6945
6946
6947
6948
6949
6950
6951
6952
6953
6954
6955
6956
6957
6958
6959
6960
6961
6962
6963
6964
6965
6966
6967
6968
6969
6970
6971
6972
6973
6974
6975
6976
6977
6978
6979
6980
6981
6982
6983
6984
6985
6986
6987
6988
6989
6990
6991
6992
6993
6994
6995
6996
6997
6998
6999
7000
7001
7002
7003
7004
7005
7006
7007
7008
7009
7010
7011
7012
7013
7014
7015
7016
7017
7018
7019
7020
7021
7022
7023
7024
7025
7026
7027
7028
7029
7030
7031
7032
7033
7034
7035
7036
7037
7038
7039
7040
7041
7042
7043
7044
7045
7046
7047
7048
7049
7050
7051
7052
7053
7054
7055
7056
7057
7058
7059
7060
7061
7062
7063
7064
7065
7066
7067
7068
7069
7070
7071
7072
7073
7074
7075
7076
7077
7078
7079
7080
7081
7082
7083
7084
7085
7086
7087
7088
7089
7090
7091
7092
7093
7094
7095
7096
7097
7098
7099
7100
7101
7102
7103
7104
7105
7106
7107
7108
7109
7110
7111
7112
7113
7114
7115
7116
7117
7118
7119
7120
7121
7122
7123
7124
7125
7126
7127
7128
7129
7130
7131
7132
7133
7134
7135
7136
7137
7138
7139
7140
7141
7142
7143
7144
7145
7146
7147
7148
7149
7150
7151
7152
7153
7154
7155
7156
7157
7158
7159
7160
7161
7162
7163
7164
7165
7166
7167
7168
7169
7170
7171
7172
7173
7174
7175
7176
7177
7178
7179
7180
7181
7182
7183
7184
7185
7186
7187
7188
7189
7190
7191
7192
7193
7194
7195
7196
7197
7198
7199
7200
7201
7202
7203
7204
7205
7206
7207
7208
7209
7210
7211
7212
7213
7214
7215
7216
7217
7218
7219
7220
7221
7222
7223
7224
7225
7226
7227
7228
7229
7230
7231
7232
7233
7234
7235
7236
7237
7238
7239
7240
7241
7242
7243
7244
7245
7246
7247
7248
7249
7250
7251
7252
7253
7254
7255
7256
7257
7258
7259
7260
7261
7262
7263
7264
7265
7266
7267
7268
7269
7270
7271
7272
7273
7274
7275
7276
7277
7278
7279
7280
7281
7282
7283
7284
7285
7286
7287
7288
7289
7290
7291
7292
7293
7294
7295
7296
7297
7298
7299
7300
7301
7302
7303
7304
7305
7306
7307
7308
7309
7310
7311
7312
7313
7314
7315
7316
7317
7318
7319
7320
7321
7322
7323
7324
7325
7326
7327
7328
7329
7330
7331
7332
7333
7334
7335
7336
7337
7338
7339
7340
7341
7342
7343
7344
7345
7346
7347
7348
7349
7350
7351
7352
7353
7354
7355
7356
7357
7358
7359
7360
7361
7362
7363
7364
7365
7366
7367
7368
7369
7370
7371
7372
7373
7374
7375
7376
7377
7378
7379
7380
7381
7382
7383
7384
7385
7386
7387
7388
7389
7390
7391
7392
7393
7394
7395
7396
7397
7398
7399
7400
7401
7402
7403
7404
7405
7406
7407
7408
7409
7410
7411
7412
7413
7414
7415
7416
7417
7418
7419
7420
7421
7422
7423
7424
7425
7426
7427
7428
7429
7430
7431
7432
7433
7434
7435
7436
7437
7438
7439
7440
7441
7442
7443
7444
7445
7446
7447
7448
7449
7450
7451
7452
7453
7454
7455
7456
7457
7458
7459
7460
7461
7462
7463
7464
7465
7466
7467
7468
7469
7470
7471
7472
7473
7474
7475
7476
7477
7478
7479
7480
7481
7482
7483
7484
7485
7486
7487
7488
7489
7490
7491
7492
7493
7494
7495
7496
7497
7498
7499
7500
7501
7502
7503
7504
7505
7506
7507
7508
7509
7510
7511
7512
7513
7514
7515
7516
7517
7518
7519
7520
7521
7522
7523
7524
7525
7526
7527
7528
7529
7530
7531
7532
7533
7534
7535
7536
7537
7538
7539
7540
7541
7542
7543
7544
7545
7546
7547
7548
7549
7550
7551
7552
7553
7554
7555
7556
7557
7558
7559
7560
7561
7562
7563
7564
7565
7566
7567
7568
7569
7570
7571
7572
7573
7574
7575
7576
7577
7578
7579
7580
7581
7582
7583
7584
7585
7586
7587
7588
7589
7590
7591
7592
7593
7594
7595
7596
7597
7598
7599
7600
7601
7602
7603
7604
7605
7606
7607
7608
7609
7610
7611
7612
7613
7614
7615
7616
7617
7618
7619
7620
7621
7622
7623
7624
7625
7626
7627
7628
7629
7630
7631
7632
7633
7634
7635
7636
7637
7638
7639
7640
7641
7642
7643
7644
7645
7646
7647
7648
7649
7650
7651
7652
7653
7654
7655
7656
7657
7658
7659
7660
7661
7662
7663
7664
7665
7666
7667
7668
7669
7670
7671
7672
7673
7674
7675
7676
7677
7678
7679
7680
7681
7682
7683
7684
7685
7686
7687
7688
7689
7690
7691
7692
7693
7694
7695
7696
7697
7698
7699
7700
7701
7702
7703
7704
7705
7706
7707
7708
7709
7710
7711
7712
7713
7714
7715
7716
7717
7718
7719
7720
7721
7722
7723
7724
7725
7726
7727
7728
7729
7730
7731
7732
7733
7734
7735
7736
7737
7738
7739
7740
7741
7742
7743
7744
7745
7746
7747
7748
7749
7750
7751
7752
7753
7754
7755
7756
7757
7758
7759
7760
7761
7762
7763
7764
7765
7766
7767
7768
7769
7770
7771
7772
7773
7774
7775
7776
7777
7778
7779
7780
7781
7782
7783
7784
7785
7786
7787
7788
7789
7790
7791
7792
7793
7794
7795
7796
7797
7798
7799
7800
7801
7802
7803
7804
7805
7806
7807
7808
7809
7810
7811
7812
7813
7814
7815
7816
7817
7818
7819
7820
7821
7822
7823
7824
7825
7826
7827
7828
7829
7830
7831
7832
7833
7834
7835
7836
7837
7838
7839
7840
7841
7842
7843
7844
7845
7846
7847
7848
7849
7850
7851
7852
7853
7854
7855
7856
7857
7858
7859
7860
7861
7862
7863
7864
7865
7866
7867
7868
7869
7870
7871
7872
7873
7874
7875
7876
7877
7878
7879
7880
7881
7882
7883
7884
7885
7886
7887
7888
7889
7890
7891
7892
7893
7894
7895
7896
7897
7898
7899
7900
7901
7902
7903
7904
7905
7906
7907
7908
7909
7910
7911
7912
7913
7914
7915
7916
7917
7918
7919
7920
7921
7922
7923
7924
7925
7926
7927
7928
7929
7930
7931
7932
7933
7934
7935
7936
7937
7938
7939
7940
7941
7942
7943
7944
7945
7946
7947
7948
7949
7950
7951
7952
7953
7954
7955
7956
7957
7958
7959
7960
7961
7962
7963
7964
7965
7966
7967
7968
7969
7970
7971
7972
7973
7974
7975
7976
7977
7978
7979
7980
7981
7982
7983
7984
7985
7986
7987
7988
7989
7990
7991
7992
7993
7994
7995
7996
7997
7998
7999
8000
8001
8002
8003
8004
8005
8006
8007
8008
8009
8010
8011
8012
8013
8014
8015
8016
8017
8018
8019
8020
8021
8022
8023
8024
8025
8026
8027
8028
8029
8030
8031
8032
8033
8034
8035
8036
8037
8038
8039
8040
8041
8042
8043
8044
8045
8046
8047
8048
8049
8050
8051
8052
8053
8054
8055
8056
8057
8058
8059
8060
8061
8062
8063
8064
8065
8066
8067
8068
8069
8070
8071
8072
8073
8074
8075
8076
8077
8078
8079
8080
8081
8082
8083
8084
8085
8086
8087
8088
8089
8090
8091
8092
8093
8094
8095
8096
8097
8098
8099
8100
8101
8102
8103
8104
8105
8106
8107
8108
8109
8110
8111
8112
8113
8114
8115
8116
8117
8118
8119
8120
8121
8122
8123
8124
8125
8126
8127
8128
8129
8130
8131
8132
8133
8134
8135
8136
8137
8138
8139
8140
8141
8142
8143
8144
8145
8146
8147
8148
8149
8150
8151
8152
8153
8154
8155
8156
8157
8158
8159
8160
8161
8162
8163
8164
8165
8166
8167
8168
8169
8170
8171
8172
8173
8174
8175
8176
8177
8178
8179
8180
8181
8182
8183
8184
8185
8186
8187
8188
8189
8190
8191
8192
8193
8194
8195
8196
8197
8198
8199
8200
8201
8202
8203
8204
8205
8206
8207
8208
8209
8210
8211
8212
8213
8214
8215
8216
8217
8218
8219
8220
8221
8222
8223
8224
8225
8226
8227
8228
8229
8230
8231
8232
8233
8234
8235
8236
8237
8238
8239
8240
8241
8242
8243
8244
8245
8246
8247
8248
8249
8250
8251
8252
8253
8254
8255
8256
8257
8258
8259
8260
8261
8262
8263
8264
8265
8266
8267
8268
8269
8270
8271
8272
8273
8274
8275
8276
8277
8278
8279
8280
8281
8282
8283
8284
8285
8286
8287
8288
8289
8290
8291
8292
8293
8294
8295
8296
8297
8298
8299
8300
8301
8302
8303
8304
8305
8306
8307
8308
8309
8310
8311
8312
8313
8314
8315
8316
8317
8318
8319
8320
8321
8322
8323
8324
8325
8326
8327
8328
8329
8330
8331
8332
8333
8334
8335
8336
8337
8338
8339
8340
8341
8342
8343
8344
8345
8346
8347
8348
8349
8350
8351
8352
8353
8354
8355
8356
8357
8358
8359
8360
8361
8362
8363
8364
8365
8366
8367
8368
8369
8370
8371
8372
8373
8374
8375
8376
8377
8378
8379
8380
8381
8382
8383
8384
8385
8386
8387
8388
8389
8390
8391
8392
8393
8394
8395
8396
8397
8398
8399
8400
8401
8402
8403
8404
8405
8406
8407
8408
8409
8410
8411
8412
8413
8414
8415
8416
8417
8418
8419
8420
8421
8422
8423
8424
8425
8426
8427
8428
8429
8430
8431
8432
8433
8434
8435
8436
8437
8438
8439
8440
8441
8442
8443
8444
8445
8446
8447
8448
8449
8450
8451
8452
8453
8454
8455
8456
8457
8458
8459
8460
8461
8462
8463
8464
8465
8466
8467
8468
8469
8470
8471
8472
8473
8474
8475
8476
8477
8478
8479
8480
8481
8482
8483
8484
8485
8486
8487
8488
8489
8490
8491
8492
8493
8494
8495
8496
8497
8498
8499
8500
8501
8502
8503
8504
8505
8506
8507
8508
8509
8510
8511
8512
8513
8514
8515
8516
8517
8518
8519
8520
8521
8522
8523
8524
8525
8526
8527
8528
8529
8530
8531
8532
8533
8534
8535
8536
8537
8538
8539
8540
8541
8542
8543
8544
8545
8546
8547
8548
8549
8550
8551
8552
8553
8554
8555
8556
8557
8558
8559
8560
8561
8562
8563
8564
8565
8566
8567
8568
8569
8570
8571
8572
8573
8574
8575
8576
8577
8578
8579
8580
8581
8582
8583
8584
8585
8586
8587
8588
8589
8590
8591
8592
8593
8594
8595
8596
8597
8598
8599
8600
8601
8602
8603
8604
8605
8606
8607
8608
8609
8610
8611
8612
8613
8614
8615
8616
8617
8618
8619
8620
8621
8622
8623
8624
8625
8626
8627
8628
8629
8630
8631
8632
8633
8634
8635
8636
8637
8638
8639
8640
8641
8642
8643
8644
8645
8646
8647
8648
8649
8650
8651
8652
8653
8654
8655
8656
8657
8658
8659
8660
8661
8662
8663
8664
8665
8666
8667
8668
8669
8670
8671
8672
8673
8674
8675
8676
8677
8678
8679
8680
8681
8682
8683
8684
8685
8686
8687
8688
8689
8690
8691
8692
8693
8694
8695
8696
8697
8698
8699
8700
8701
8702
8703
8704
8705
8706
8707
8708
8709
8710
8711
8712
8713
8714
8715
8716
8717
8718
8719
8720
8721
8722
8723
8724
8725
8726
8727
8728
8729
8730
8731
8732
8733
8734
8735
8736
8737
8738
8739
8740
8741
8742
8743
8744
8745
8746
8747
8748
8749
8750
8751
8752
8753
8754
8755
8756
8757
8758
8759
8760
8761
8762
8763
8764
8765
8766
8767
8768
8769
8770
8771
8772
8773
8774
8775
8776
8777
8778
8779
8780
8781
8782
8783
8784
8785
8786
8787
8788
8789
8790
8791
8792
8793
8794
8795
8796
8797
8798
8799
8800
8801
8802
8803
8804
8805
8806
8807
8808
8809
8810
8811
8812
8813
8814
8815
8816
8817
8818
8819
8820
8821
8822
8823
8824
8825
8826
8827
8828
8829
8830
8831
8832
8833
8834
8835
8836
8837
8838
8839
8840
8841
8842
8843
8844
8845
8846
8847
8848
8849
8850
8851
8852
8853
8854
8855
8856
8857
8858
8859
8860
8861
8862
8863
8864
8865
8866
8867
8868
8869
8870
8871
8872
8873
8874
8875
8876
8877
8878
8879
8880
8881
8882
8883
8884
8885
8886
8887
8888
8889
8890
8891
8892
8893
8894
8895
8896
8897
8898
8899
8900
8901
8902
8903
8904
8905
8906
8907
8908
8909
8910
8911
8912
8913
8914
8915
8916
8917
8918
8919
8920
8921
8922
8923
8924
8925
8926
8927
8928
8929
8930
8931
8932
8933
8934
8935
8936
8937
8938
8939
8940
8941
8942
8943
8944
8945
8946
8947
8948
8949
8950
8951
8952
8953
8954
8955
8956
8957
8958
8959
8960
8961
8962
8963
8964
8965
8966
8967
8968
8969
8970
8971
8972
8973
8974
8975
8976
8977
8978
8979
8980
8981
8982
8983
8984
8985
8986
8987
8988
8989
8990
8991
8992
8993
8994
8995
8996
8997
8998
8999
9000
9001
9002
9003
9004
9005
9006
9007
9008
9009
9010
9011
9012
9013
9014
9015
9016
9017
9018
9019
9020
9021
9022
9023
9024
9025
9026
9027
9028
9029
9030
9031
9032
9033
9034
9035
9036
9037
9038
9039
9040
9041
9042
9043
9044
9045
9046
9047
9048
9049
9050
9051
9052
9053
9054
9055
9056
9057
9058
9059
9060
9061
9062
9063
9064
9065
9066
9067
9068
9069
9070
9071
9072
9073
9074
9075
9076
9077
9078
9079
9080
9081
9082
9083
9084
9085
9086
9087
9088
9089
9090
9091
9092
9093
9094
9095
9096
9097
9098
9099
9100
9101
9102
9103
9104
9105
9106
9107
9108
9109
9110
9111
9112
9113
9114
9115
9116
9117
9118
9119
9120
9121
9122
9123
9124
9125
9126
9127
9128
9129
9130
9131
9132
9133
9134
9135
9136
9137
9138
9139
9140
9141
9142
9143
9144
9145
9146
9147
9148
9149
9150
9151
9152
9153
9154
9155
9156
9157
9158
9159
9160
9161
9162
9163
9164
9165
9166
9167
9168
9169
9170
9171
9172
9173
9174
9175
9176
9177
9178
9179
9180
9181
9182
9183
9184
9185
9186
9187
9188
9189
9190
9191
9192
9193
9194
9195
9196
9197
9198
9199
9200
9201
9202
9203
9204
9205
9206
9207
9208
9209
9210
9211
9212
9213
9214
9215
9216
9217
9218
9219
9220
9221
9222
9223
9224
9225
9226
9227
9228
9229
9230
9231
9232
9233
9234
9235
9236
9237
9238
9239
9240
9241
9242
9243
9244
9245
9246
9247
9248
9249
9250
9251
9252
9253
9254
9255
9256
9257
9258
9259
9260
9261
9262
9263
9264
9265
9266
9267
9268
9269
9270
9271
9272
9273
9274
9275
9276
9277
9278
9279
9280
9281
9282
9283
9284
9285
9286
9287
9288
9289
9290
9291
9292
9293
9294
9295
9296
9297
9298
9299
9300
9301
9302
9303
9304
9305
9306
9307
9308
9309
9310
9311
9312
9313
9314
9315
9316
9317
9318
9319
9320
9321
9322
9323
9324
9325
9326
9327
9328
9329
9330
9331
9332
9333
9334
9335
9336
9337
9338
9339
9340
9341
9342
9343
9344
9345
9346
9347
9348
9349
9350
9351
9352
9353
9354
9355
9356
9357
9358
9359
9360
9361
9362
9363
9364
9365
9366
9367
9368
9369
9370
9371
9372
9373
9374
9375
9376
9377
9378
9379
9380
9381
9382
9383
9384
9385
9386
9387
9388
9389
9390
9391
9392
9393
9394
9395
9396
9397
9398
9399
9400
9401
9402
9403
9404
9405
9406
9407
9408
9409
9410
9411
9412
9413
9414
9415
9416
9417
9418
9419
9420
9421
9422
9423
9424
9425
9426
9427
9428
9429
9430
9431
9432
9433
9434
9435
9436
9437
9438
9439
9440
9441
9442
9443
9444
9445
9446
9447
9448
9449
9450
9451
9452
9453
9454
9455
9456
9457
9458
9459
9460
9461
9462
9463
9464
9465
9466
9467
9468
9469
9470
9471
9472
9473
9474
9475
9476
9477
9478
9479
9480
9481
9482
9483
9484
9485
9486
9487
9488
9489
9490
9491
9492
9493
9494
9495
9496
9497
9498
9499
9500
9501
9502
9503
9504
9505
9506
9507
9508
9509
9510
9511
9512
9513
9514
9515
9516
9517
9518
9519
9520
9521
9522
9523
9524
9525
9526
9527
9528
9529
9530
9531
9532
9533
9534
9535
9536
9537
9538
9539
9540
9541
9542
9543
9544
9545
9546
9547
9548
9549
9550
9551
9552
9553
9554
9555
9556
9557
9558
9559
9560
9561
9562
9563
9564
9565
9566
9567
9568
9569
9570
9571
9572
9573
9574
9575
9576
9577
9578
9579
9580
9581
9582
9583
9584
9585
9586
9587
9588
9589
9590
9591
9592
9593
9594
9595
9596
9597
9598
9599
9600
9601
9602
9603
9604
9605
9606
9607
9608
9609
9610
9611
9612
9613
9614
9615
9616
9617
9618
9619
9620
9621
9622
9623
9624
9625
9626
9627
9628
9629
9630
9631
9632
9633
9634
9635
9636
9637
9638
9639
9640
9641
9642
9643
9644
9645
9646
9647
9648
9649
9650
9651
9652
9653
9654
9655
9656
9657
9658
9659
9660
9661
9662
9663
9664
9665
9666
9667
9668
9669
9670
9671
9672
9673
9674
9675
9676
9677
9678
9679
9680
9681
9682
9683
9684
9685
9686
9687
9688
9689
9690
9691
9692
9693
9694
9695
9696
9697
9698
9699
9700
9701
9702
9703
9704
9705
9706
9707
9708
9709
9710
9711
9712
9713
9714
9715
9716
9717
9718
9719
9720
9721
9722
9723
9724
9725
9726
9727
9728
9729
9730
9731
9732
9733
9734
9735
9736
9737
9738
9739
9740
9741
9742
9743
9744
9745
9746
9747
9748
9749
9750
9751
9752
9753
9754
9755
9756
9757
9758
9759
9760
9761
9762
9763
9764
9765
9766
9767
9768
9769
9770
9771
9772
9773
9774
9775
9776
9777
9778
9779
9780
9781
9782
9783
9784
9785
9786
9787
9788
9789
9790
9791
9792
9793
9794
9795
9796
9797
9798
9799
9800
9801
9802
9803
9804
9805
9806
9807
9808
9809
9810
9811
9812
9813
9814
9815
9816
9817
9818
9819
9820
9821
9822
9823
9824
9825
9826
9827
9828
9829
9830
9831
9832
9833
9834
9835
9836
9837
9838
9839
9840
9841
9842
9843
9844
9845
9846
9847
9848
9849
9850
9851
9852
9853
9854
9855
9856
9857
9858
9859
9860
9861
9862
9863
9864
9865
9866
9867
9868
9869
9870
9871
9872
9873
9874
9875
9876
9877
9878
9879
9880
9881
9882
9883
9884
9885
9886
9887
9888
9889
9890
9891
9892
9893
9894
9895
9896
9897
9898
9899
9900
9901
9902
9903
9904
9905
9906
9907
9908
9909
9910
9911
9912
9913
9914
9915
9916
9917
9918
9919
9920
9921
9922
9923
9924
9925
9926
9927
9928
9929
9930
9931
9932
9933
9934
9935
9936
9937
9938
9939
9940
9941
9942
9943
9944
9945
9946
9947
9948
9949
9950
9951
9952
9953
9954
9955
9956
9957
9958
9959
9960
9961
9962
9963
9964
9965
9966
9967
9968
9969
9970
9971
9972
9973
9974
9975
9976
9977
9978
9979
9980
9981
9982
9983
9984
9985
9986
9987
9988
9989
9990
9991
9992
9993
9994
9995
9996
9997
9998
9999
10000
10001
10002
10003
10004
10005
10006
10007
10008
10009
10010
10011
10012
10013
10014
10015
10016
10017
10018
10019
10020
10021
10022
10023
10024
10025
10026
10027
10028
10029
10030
10031
10032
10033
10034
10035
10036
10037
10038
10039
10040
10041
10042
10043
10044
10045
10046
10047
10048
10049
10050
10051
10052
10053
10054
10055
10056
10057
10058
10059
10060
10061
10062
10063
10064
10065
10066
10067
10068
10069
10070
10071
10072
10073
10074
10075
10076
10077
10078
10079
10080
10081
10082
10083
10084
10085
10086
10087
10088
10089
10090
10091
10092
10093
10094
10095
10096
10097
10098
10099
10100
10101
10102
10103
10104
10105
10106
10107
10108
10109
10110
10111
10112
10113
10114
10115
10116
10117
10118
10119
10120
10121
10122
10123
10124
10125
10126
10127
10128
10129
10130
10131
10132
10133
10134
10135
10136
10137
10138
10139
10140
10141
10142
10143
10144
10145
10146
10147
10148
10149
10150
10151
10152
10153
10154
10155
10156
10157
10158
10159
10160
10161
10162
10163
10164
10165
10166
10167
10168
10169
10170
10171
10172
10173
10174
10175
10176
10177
10178
10179
10180
10181
10182
10183
10184
10185
10186
10187
10188
10189
10190
10191
10192
10193
10194
10195
10196
10197
10198
10199
10200
10201
10202
10203
10204
10205
10206
10207
10208
10209
10210
10211
10212
10213
10214
10215
10216
10217
10218
10219
10220
10221
10222
10223
10224
10225
10226
10227
10228
10229
10230
10231
10232
10233
10234
10235
10236
10237
10238
10239
10240
10241
10242
10243
10244
10245
10246
10247
10248
10249
10250
10251
10252
10253
10254
10255
10256
10257
10258
10259
10260
10261
10262
10263
10264
10265
10266
10267
10268
10269
10270
10271
10272
10273
10274
10275
10276
10277
10278
10279
10280
10281
10282
10283
10284
10285
10286
10287
10288
10289
10290
10291
10292
10293
10294
10295
10296
10297
10298
10299
10300
10301
10302
10303
10304
10305
10306
10307
10308
10309
10310
10311
10312
10313
10314
10315
10316
10317
10318
10319
10320
10321
10322
10323
10324
10325
10326
10327
10328
10329
10330
10331
10332
10333
10334
10335
10336
10337
10338
10339
10340
10341
10342
10343
10344
10345
10346
10347
10348
10349
10350
10351
10352
10353
10354
10355
10356
10357
10358
10359
10360
10361
10362
10363
10364
10365
10366
10367
10368
10369
10370
10371
10372
10373
10374
10375
10376
10377
10378
10379
10380
10381
10382
10383
10384
10385
10386
10387
10388
10389
10390
10391
10392
10393
10394
10395
10396
10397
10398
10399
10400
10401
10402
10403
10404
10405
10406
10407
10408
10409
10410
10411
10412
10413
10414
10415
10416
10417
10418
10419
10420
10421
10422
10423
10424
10425
10426
10427
10428
10429
10430
10431
10432
10433
10434
10435
10436
10437
10438
10439
10440
10441
10442
10443
10444
10445
10446
10447
10448
10449
10450
10451
10452
10453
10454
10455
10456
10457
10458
10459
10460
10461
10462
10463
10464
10465
10466
10467
10468
10469
10470
10471
10472
10473
10474
10475
10476
10477
10478
10479
10480
10481
10482
10483
10484
10485
10486
10487
10488
10489
10490
10491
10492
10493
10494
10495
10496
10497
10498
10499
10500
10501
10502
10503
10504
10505
10506
10507
10508
10509
10510
10511
10512
10513
10514
10515
10516
10517
10518
10519
10520
10521
10522
10523
10524
10525
10526
10527
10528
10529
10530
10531
10532
10533
10534
10535
10536
10537
10538
10539
10540
10541
10542
10543
10544
10545
10546
10547
10548
10549
10550
10551
10552
10553
10554
10555
10556
10557
10558
10559
10560
10561
10562
10563
10564
10565
10566
10567
10568
10569
10570
10571
10572
10573
10574
10575
10576
10577
10578
10579
10580
10581
10582
10583
10584
10585
10586
10587
10588
10589
10590
10591
10592
10593
10594
10595
10596
10597
10598
10599
10600
10601
10602
10603
10604
10605
10606
10607
10608
10609
10610
10611
10612
10613
10614
10615
10616
10617
10618
10619
10620
10621
10622
10623
10624
10625
10626
10627
10628
10629
10630
10631
10632
10633
10634
10635
10636
10637
10638
10639
10640
10641
10642
10643
10644
10645
10646
10647
10648
10649
10650
10651
10652
10653
10654
10655
10656
10657
10658
10659
10660
10661
10662
10663
10664
10665
10666
10667
10668
10669
10670
10671
10672
10673
10674
10675
10676
10677
10678
10679
10680
10681
10682
10683
10684
10685
10686
10687
10688
10689
10690
10691
10692
10693
10694
10695
10696
10697
10698
10699
10700
10701
10702
10703
10704
10705
10706
10707
10708
10709
10710
10711
10712
10713
10714
10715
10716
10717
10718
10719
10720
10721
10722
10723
10724
10725
10726
10727
10728
10729
10730
10731
10732
10733
10734
10735
10736
10737
10738
10739
10740
10741
10742
10743
10744
10745
10746
10747
10748
10749
10750
10751
10752
10753
10754
10755
10756
10757
10758
10759
10760
10761
10762
10763
10764
10765
10766
10767
10768
10769
10770
10771
10772
10773
10774
10775
10776
10777
10778
10779
10780
10781
10782
10783
10784
10785
10786
10787
10788
10789
10790
10791
10792
10793
10794
10795
10796
10797
10798
10799
10800
10801
10802
10803
10804
10805
10806
10807
10808
10809
10810
10811
10812
10813
10814
10815
10816
10817
10818
10819
10820
10821
10822
10823
10824
10825
10826
10827
10828
10829
10830
10831
10832
10833
10834
10835
10836
10837
10838
10839
10840
10841
10842
10843
10844
10845
10846
10847
10848
10849
10850
10851
10852
10853
10854
10855
10856
10857
10858
10859
10860
10861
10862
10863
10864
10865
10866
10867
10868
10869
10870
10871
10872
10873
10874
10875
10876
10877
10878
10879
10880
10881
10882
10883
10884
10885
10886
10887
10888
10889
10890
10891
10892
10893
10894
10895
10896
10897
10898
10899
10900
10901
10902
10903
10904
10905
10906
10907
10908
10909
10910
10911
10912
10913
10914
10915
10916
10917
10918
10919
10920
10921
10922
10923
10924
10925
10926
10927
10928
10929
10930
10931
10932
10933
10934
10935
10936
10937
10938
10939
10940
10941
10942
10943
10944
10945
10946
10947
10948
10949
10950
10951
10952
10953
10954
10955
10956
10957
10958
10959
10960
10961
10962
10963
10964
10965
10966
10967
10968
10969
10970
10971
10972
10973
10974
10975
10976
10977
10978
10979
10980
10981
10982
10983
10984
10985
10986
10987
10988
10989
10990
10991
10992
10993
10994
10995
10996
10997
10998
10999
11000
11001
11002
11003
11004
11005
11006
11007
11008
11009
11010
11011
11012
11013
11014
11015
11016
11017
11018
11019
11020
11021
11022
11023
11024
11025
11026
11027
11028
11029
11030
11031
11032
11033
11034
11035
11036
11037
11038
11039
11040
11041
11042
11043
11044
11045
11046
11047
11048
11049
11050
11051
11052
11053
11054
11055
11056
11057
11058
11059
11060
11061
11062
11063
11064
11065
11066
11067
11068
11069
11070
11071
11072
11073
11074
11075
11076
11077
11078
11079
11080
11081
11082
11083
11084
11085
11086
11087
11088
11089
11090
11091
11092
11093
11094
11095
11096
11097
11098
11099
11100
11101
11102
11103
11104
11105
11106
11107
11108
11109
11110
11111
11112
11113
11114
11115
11116
11117
11118
11119
11120
11121
11122
11123
11124
11125
11126
11127
11128
11129
11130
11131
11132
11133
11134
11135
11136
11137
11138
11139
11140
11141
11142
11143
11144
11145
11146
11147
11148
11149
11150
11151
11152
11153
11154
11155
11156
11157
11158
11159
11160
11161
11162
11163
11164
11165
11166
11167
11168
11169
11170
11171
11172
11173
11174
11175
11176
11177
11178
11179
11180
11181
11182
11183
11184
11185
11186
11187
11188
11189
11190
11191
11192
11193
11194
11195
11196
11197
11198
11199
11200
11201
11202
11203
11204
11205
11206
11207
11208
11209
11210
11211
11212
11213
11214
11215
11216
11217
11218
11219
11220
11221
11222
11223
11224
11225
11226
11227
11228
11229
11230
11231
11232
11233
11234
11235
11236
11237
11238
11239
11240
11241
11242
11243
11244
11245
11246
11247
11248
11249
11250
11251
11252
11253
11254
11255
11256
11257
11258
11259
11260
11261
11262
11263
11264
11265
11266
11267
11268
11269
11270
11271
11272
11273
11274
11275
11276
11277
11278
11279
11280
11281
11282
11283
11284
11285
11286
11287
11288
11289
11290
11291
11292
11293
11294
11295
11296
11297
11298
11299
11300
11301
11302
11303
11304
11305
11306
11307
11308
11309
11310
11311
11312
11313
11314
11315
11316
11317
11318
11319
11320
11321
11322
11323
11324
11325
11326
11327
11328
11329
11330
11331
11332
11333
11334
11335
11336
11337
11338
11339
11340
11341
11342
11343
11344
11345
11346
11347
11348
11349
11350
11351
11352
11353
11354
11355
11356
11357
11358
11359
11360
11361
11362
11363
11364
11365
11366
11367
11368
11369
11370
11371
11372
11373
11374
11375
11376
11377
11378
11379
11380
11381
11382
11383
11384
11385
11386
11387
11388
11389
11390
11391
11392
11393
11394
11395
11396
11397
11398
11399
11400
11401
11402
11403
11404
11405
11406
11407
11408
11409
11410
11411
11412
11413
11414
11415
11416
11417
11418
11419
11420
11421
11422
11423
11424
11425
11426
11427
11428
11429
11430
11431
11432
11433
11434
11435
11436
11437
11438
11439
11440
11441
11442
11443
11444
11445
11446
11447
11448
11449
11450
11451
11452
11453
11454
11455
11456
11457
11458
11459
11460
11461
11462
11463
11464
11465
11466
11467
11468
11469
11470
11471
11472
11473
11474
11475
11476
11477
11478
11479
11480
11481
11482
11483
11484
11485
11486
11487
11488
11489
11490
11491
11492
11493
11494
11495
11496
11497
11498
11499
11500
11501
11502
11503
11504
11505
11506
11507
11508
11509
11510
11511
11512
11513
11514
11515
11516
11517
11518
11519
11520
11521
11522
11523
11524
11525
11526
11527
11528
11529
11530
11531
11532
11533
11534
11535
11536
11537
11538
11539
11540
11541
11542
11543
11544
11545
11546
11547
11548
11549
11550
11551
11552
11553
11554
11555
11556
11557
11558
11559
11560
11561
11562
11563
11564
11565
11566
11567
11568
11569
11570
11571
11572
11573
11574
11575
11576
11577
11578
11579
11580
11581
11582
11583
11584
11585
11586
11587
11588
11589
11590
11591
11592
11593
11594
11595
11596
11597
11598
11599
11600
11601
11602
11603
11604
11605
11606
11607
11608
11609
11610
11611
11612
11613
11614
11615
11616
11617
11618
11619
11620
11621
11622
11623
11624
11625
11626
11627
11628
11629
11630
11631
11632
11633
11634
11635
11636
11637
11638
11639
11640
11641
11642
11643
11644
11645
11646
11647
11648
11649
11650
11651
11652
11653
11654
11655
11656
11657
11658
11659
11660
11661
11662
11663
11664
11665
11666
11667
11668
11669
11670
11671
11672
11673
11674
11675
11676
11677
11678
11679
11680
11681
11682
11683
11684
11685
11686
11687
11688
11689
11690
11691
11692
11693
11694
11695
11696
11697
11698
11699
11700
11701
11702
11703
11704
11705
11706
11707
11708
11709
11710
11711
11712
11713
11714
11715
11716
11717
11718
11719
11720
11721
11722
11723
11724
11725
11726
11727
11728
11729
11730
11731
11732
11733
11734
11735
11736
11737
11738
11739
11740
11741
11742
11743
11744
11745
11746
11747
11748
11749
11750
11751
11752
11753
11754
11755
11756
11757
11758
11759
11760
11761
11762
11763
11764
11765
11766
11767
11768
11769
11770
11771
11772
11773
11774
11775
11776
11777
11778
11779
11780
11781
11782
11783
11784
11785
11786
11787
11788
11789
11790
11791
11792
11793
11794
11795
11796
11797
11798
11799
11800
11801
11802
11803
11804
11805
11806
11807
11808
11809
11810
11811
11812
11813
11814
11815
11816
11817
11818
11819
11820
11821
11822
11823
11824
11825
11826
11827
11828
11829
11830
11831
11832
11833
11834
11835
11836
11837
11838
11839
11840
11841
11842
11843
11844
11845
11846
11847
11848
11849
11850
11851
11852
11853
11854
11855
11856
11857
11858
11859
11860
11861
11862
11863
11864
11865
11866
11867
11868
11869
11870
11871
11872
11873
11874
11875
11876
11877
11878
11879
11880
11881
11882
11883
11884
11885
11886
11887
11888
11889
11890
11891
11892
11893
11894
11895
11896
11897
11898
11899
11900
11901
11902
11903
11904
11905
11906
11907
11908
11909
11910
11911
11912
11913
11914
11915
11916
11917
11918
11919
11920
11921
11922
11923
11924
11925
11926
11927
11928
11929
11930
11931
11932
11933
11934
11935
11936
11937
11938
11939
11940
11941
11942
11943
11944
11945
11946
11947
11948
11949
11950
11951
11952
11953
11954
11955
11956
11957
11958
11959
11960
11961
11962
11963
11964
11965
11966
11967
11968
11969
11970
11971
11972
11973
11974
11975
11976
11977
11978
11979
11980
11981
11982
11983
11984
11985
11986
11987
11988
11989
11990
11991
11992
11993
11994
11995
11996
11997
11998
11999
12000
12001
12002
12003
12004
12005
12006
12007
12008
12009
12010
12011
12012
12013
12014
12015
12016
12017
12018
12019
12020
12021
12022
12023
12024
12025
12026
12027
12028
12029
12030
12031
12032
12033
12034
12035
12036
12037
12038
12039
12040
12041
12042
12043
12044
12045
12046
12047
12048
12049
12050
12051
12052
12053
12054
12055
12056
12057
12058
12059
12060
12061
12062
12063
12064
12065
12066
12067
12068
12069
12070
12071
12072
12073
12074
12075
12076
12077
12078
12079
12080
12081
12082
12083
12084
12085
12086
12087
12088
12089
12090
12091
12092
12093
12094
12095
12096
12097
12098
12099
12100
12101
12102
12103
12104
12105
12106
12107
12108
12109
12110
12111
12112
12113
12114
12115
12116
12117
12118
12119
12120
12121
12122
12123
12124
12125
12126
12127
12128
12129
12130
12131
12132
12133
12134
12135
12136
12137
12138
12139
12140
12141
12142
12143
12144
12145
12146
12147
12148
12149
12150
12151
12152
12153
12154
12155
12156
12157
12158
12159
12160
12161
12162
12163
12164
12165
12166
12167
12168
12169
12170
12171
12172
12173
12174
12175
12176
12177
12178
12179
12180
12181
12182
12183
12184
12185
12186
12187
12188
12189
12190
12191
12192
12193
12194
12195
12196
12197
12198
12199
12200
12201
12202
12203
12204
12205
12206
12207
12208
12209
12210
12211
12212
12213
12214
12215
12216
12217
12218
12219
12220
12221
12222
12223
12224
12225
12226
12227
12228
12229
12230
12231
12232
12233
12234
12235
12236
12237
12238
12239
12240
12241
12242
12243
12244
12245
12246
12247
12248
12249
12250
12251
12252
12253
12254
12255
12256
12257
12258
12259
12260
12261
12262
12263
12264
12265
12266
12267
12268
12269
12270
12271
12272
12273
12274
12275
12276
12277
12278
12279
12280
12281
12282
12283
12284
12285
12286
12287
12288
12289
12290
12291
12292
12293
12294
12295
12296
12297
12298
12299
12300
12301
12302
12303
12304
12305
12306
12307
12308
12309
12310
12311
12312
12313
12314
12315
12316
12317
12318
12319
12320
12321
12322
12323
12324
12325
12326
12327
12328
12329
12330
12331
12332
12333
12334
12335
12336
12337
12338
12339
12340
12341
12342
12343
12344
12345
12346
12347
12348
12349
12350
12351
12352
12353
12354
12355
12356
12357
12358
12359
12360
12361
12362
12363
12364
12365
12366
12367
12368
12369
12370
12371
12372
12373
12374
12375
12376
12377
12378
12379
12380
12381
12382
12383
12384
12385
12386
12387
12388
12389
12390
12391
12392
12393
12394
12395
12396
12397
12398
12399
12400
12401
12402
12403
12404
12405
12406
12407
12408
12409
12410
12411
12412
12413
12414
12415
12416
12417
12418
12419
12420
12421
12422
12423
12424
12425
12426
12427
12428
12429
12430
12431
12432
12433
12434
12435
12436
12437
12438
12439
12440
12441
12442
12443
12444
12445
12446
12447
12448
12449
12450
12451
12452
12453
12454
12455
12456
12457
12458
12459
12460
12461
12462
12463
12464
12465
12466
12467
12468
12469
12470
12471
12472
12473
12474
12475
12476
12477
12478
12479
12480
12481
12482
12483
12484
12485
12486
12487
12488
12489
12490
12491
12492
12493
12494
12495
12496
12497
12498
12499
12500
12501
12502
12503
12504
12505
12506
12507
12508
12509
12510
12511
12512
12513
12514
12515
12516
12517
12518
12519
12520
12521
12522
12523
12524
12525
12526
12527
12528
12529
12530
12531
12532
12533
12534
12535
12536
12537
12538
12539
12540
12541
12542
12543
12544
12545
12546
12547
12548
12549
12550
12551
12552
12553
12554
12555
12556
12557
12558
12559
12560
12561
12562
12563
12564
12565
12566
12567
12568
12569
12570
12571
12572
12573
12574
12575
12576
12577
12578
12579
12580
12581
12582
12583
12584
12585
12586
12587
12588
12589
12590
12591
12592
12593
12594
12595
12596
12597
12598
12599
12600
12601
12602
12603
12604
12605
12606
12607
12608
12609
12610
12611
12612
12613
12614
12615
12616
12617
12618
12619
12620
12621
12622
12623
12624
12625
12626
12627
12628
12629
12630
12631
12632
12633
12634
12635
12636
12637
12638
12639
12640
12641
12642
12643
12644
12645
12646
12647
12648
12649
12650
12651
12652
12653
12654
12655
12656
12657
12658
12659
12660
12661
12662
12663
12664
12665
12666
12667
12668
12669
12670
12671
12672
12673
12674
12675
12676
12677
12678
12679
12680
12681
12682
12683
12684
12685
12686
12687
12688
12689
12690
12691
12692
12693
12694
12695
12696
12697
12698
12699
12700
12701
12702
12703
12704
12705
12706
12707
12708
12709
12710
12711
12712
12713
12714
12715
12716
12717
12718
12719
12720
12721
12722
12723
12724
12725
12726
12727
12728
12729
12730
12731
12732
12733
12734
12735
12736
12737
12738
12739
12740
12741
12742
12743
12744
12745
12746
12747
12748
12749
12750
12751
12752
12753
12754
12755
12756
12757
12758
12759
12760
12761
12762
12763
12764
12765
12766
12767
12768
12769
12770
12771
12772
12773
12774
12775
12776
12777
12778
12779
12780
12781
12782
12783
12784
12785
12786
12787
12788
12789
12790
12791
12792
12793
12794
12795
12796
12797
12798
12799
12800
12801
12802
12803
12804
12805
12806
12807
12808
12809
12810
12811
12812
12813
12814
12815
12816
12817
12818
12819
12820
12821
12822
12823
12824
12825
12826
12827
12828
12829
12830
12831
12832
12833
12834
12835
12836
12837
12838
12839
12840
12841
12842
12843
12844
12845
12846
12847
12848
12849
12850
12851
12852
12853
12854
12855
12856
12857
12858
12859
12860
12861
12862
12863
12864
12865
12866
12867
12868
12869
12870
12871
12872
12873
12874
12875
12876
12877
12878
12879
12880
12881
12882
12883
12884
12885
12886
12887
12888
12889
12890
12891
12892
12893
12894
12895
12896
12897
12898
12899
12900
12901
12902
12903
12904
12905
12906
12907
12908
12909
12910
12911
12912
12913
12914
12915
12916
12917
12918
12919
12920
12921
12922
12923
12924
12925
12926
12927
12928
12929
12930
12931
12932
12933
12934
12935
12936
12937
12938
12939
12940
12941
12942
12943
12944
12945
12946
12947
12948
12949
12950
12951
12952
12953
12954
12955
12956
12957
12958
12959
12960
12961
12962
12963
12964
12965
12966
12967
12968
12969
12970
12971
12972
12973
12974
12975
12976
12977
12978
12979
12980
12981
12982
12983
12984
12985
12986
12987
12988
12989
12990
12991
12992
12993
12994
12995
12996
12997
12998
12999
13000
13001
13002
13003
13004
13005
13006
13007
13008
13009
13010
13011
13012
13013
13014
13015
13016
13017
13018
13019
13020
13021
13022
13023
13024
13025
13026
13027
13028
13029
13030
13031
13032
13033
13034
13035
13036
13037
13038
13039
13040
13041
13042
13043
13044
13045
13046
13047
13048
13049
13050
13051
13052
13053
13054
13055
13056
13057
13058
13059
13060
13061
13062
13063
13064
13065
13066
13067
13068
13069
13070
13071
13072
13073
13074
13075
13076
13077
13078
13079
13080
13081
13082
13083
13084
13085
13086
13087
13088
13089
13090
13091
13092
13093
13094
13095
13096
13097
13098
13099
13100
13101
13102
13103
13104
13105
13106
13107
13108
13109
13110
13111
13112
13113
13114
13115
13116
13117
13118
13119
13120
13121
13122
13123
13124
13125
13126
13127
13128
13129
13130
13131
13132
13133
13134
13135
13136
13137
13138
13139
13140
13141
13142
13143
13144
13145
13146
13147
13148
13149
13150
13151
13152
13153
13154
13155
13156
13157
13158
13159
13160
13161
13162
13163
13164
13165
13166
13167
13168
13169
13170
13171
13172
13173
13174
13175
13176
13177
13178
13179
13180
13181
13182
13183
13184
13185
13186
13187
13188
13189
13190
13191
13192
13193
13194
13195
13196
13197
13198
13199
13200
13201
13202
13203
13204
13205
13206
13207
13208
13209
13210
13211
13212
13213
13214
13215
13216
13217
13218
13219
13220
13221
13222
13223
13224
13225
13226
13227
13228
13229
13230
13231
13232
13233
13234
13235
13236
13237
13238
13239
13240
13241
13242
13243
13244
13245
13246
13247
13248
13249
13250
13251
13252
13253
13254
13255
13256
13257
13258
13259
13260
13261
13262
13263
13264
13265
13266
13267
13268
13269
13270
13271
13272
13273
13274
13275
13276
13277
13278
13279
13280
13281
13282
13283
13284
13285
13286
13287
13288
13289
13290
13291
13292
13293
13294
13295
13296
13297
13298
13299
13300
13301
13302
13303
13304
13305
13306
13307
13308
13309
13310
13311
13312
13313
13314
13315
13316
13317
13318
13319
13320
13321
13322
13323
13324
13325
13326
13327
13328
13329
13330
13331
13332
13333
13334
13335
13336
13337
13338
13339
13340
13341
13342
13343
13344
13345
13346
13347
13348
13349
13350
13351
13352
13353
13354
13355
13356
13357
13358
13359
13360
13361
13362
13363
13364
13365
13366
13367
13368
13369
13370
13371
13372
13373
13374
13375
13376
13377
13378
13379
13380
13381
13382
13383
13384
13385
13386
13387
13388
13389
13390
13391
13392
13393
13394
13395
13396
13397
13398
13399
13400
13401
13402
13403
13404
13405
13406
13407
13408
13409
13410
13411
13412
13413
13414
13415
13416
13417
13418
13419
13420
13421
13422
13423
13424
13425
13426
13427
13428
13429
13430
13431
13432
13433
13434
13435
13436
13437
13438
13439
13440
13441
13442
13443
13444
13445
13446
13447
13448
13449
13450
13451
13452
13453
13454
13455
13456
13457
13458
13459
13460
13461
13462
13463
13464
13465
13466
13467
13468
13469
13470
13471
13472
13473
13474
13475
13476
13477
13478
13479
13480
13481
13482
13483
13484
13485
13486
13487
13488
13489
13490
13491
13492
13493
13494
13495
13496
13497
13498
13499
13500
13501
13502
13503
13504
13505
13506
13507
13508
13509
13510
13511
13512
13513
13514
13515
13516
13517
13518
13519
13520
13521
13522
13523
13524
13525
13526
13527
13528
13529
13530
13531
13532
13533
13534
13535
13536
13537
13538
13539
13540
13541
13542
13543
13544
13545
13546
13547
13548
13549
13550
13551
13552
13553
13554
13555
13556
13557
13558
13559
13560
13561
13562
13563
13564
13565
13566
13567
13568
13569
13570
13571
13572
13573
13574
13575
13576
13577
13578
13579
13580
13581
13582
13583
13584
13585
13586
13587
13588
13589
13590
13591
13592
13593
13594
13595
13596
13597
13598
13599
13600
13601
13602
13603
13604
13605
13606
13607
13608
13609
13610
13611
13612
13613
13614
13615
13616
13617
13618
13619
13620
13621
13622
13623
13624
13625
13626
13627
13628
13629
13630
13631
13632
13633
13634
13635
13636
13637
13638
13639
13640
13641
13642
13643
13644
13645
13646
13647
13648
13649
13650
13651
13652
13653
13654
13655
13656
13657
13658
13659
13660
13661
13662
13663
13664
13665
13666
13667
13668
13669
13670
13671
13672
13673
13674
13675
13676
13677
13678
13679
13680
13681
13682
13683
13684
13685
13686
13687
13688
13689
13690
13691
13692
13693
13694
13695
13696
13697
13698
13699
13700
13701
13702
13703
13704
13705
13706
13707
13708
13709
13710
13711
13712
13713
13714
13715
13716
13717
13718
13719
13720
13721
13722
13723
13724
13725
13726
13727
13728
13729
13730
13731
13732
13733
13734
13735
13736
13737
13738
13739
13740
13741
13742
13743
13744
13745
13746
13747
13748
13749
13750
13751
13752
13753
13754
13755
13756
13757
13758
13759
13760
13761
13762
13763
13764
13765
13766
13767
13768
13769
13770
13771
13772
13773
13774
13775
13776
13777
13778
13779
13780
13781
13782
13783
13784
13785
13786
13787
13788
13789
13790
13791
13792
13793
13794
13795
13796
13797
13798
13799
13800
13801
13802
13803
13804
13805
13806
13807
13808
13809
13810
13811
13812
13813
13814
13815
13816
13817
13818
13819
13820
13821
13822
13823
13824
13825
13826
13827
13828
13829
13830
13831
13832
13833
13834
13835
13836
13837
13838
13839
13840
13841
13842
13843
13844
13845
13846
13847
13848
13849
13850
13851
13852
13853
13854
13855
13856
13857
13858
13859
13860
13861
13862
13863
13864
13865
13866
13867
13868
13869
13870
13871
13872
13873
13874
13875
13876
13877
13878
13879
13880
13881
13882
13883
13884
13885
13886
13887
13888
13889
13890
13891
13892
13893
13894
13895
13896
13897
13898
13899
13900
13901
13902
13903
13904
13905
13906
13907
13908
13909
13910
13911
13912
13913
13914
13915
13916
13917
13918
13919
13920
13921
13922
13923
13924
13925
13926
13927
13928
13929
13930
13931
13932
13933
13934
13935
13936
13937
13938
13939
13940
13941
13942
13943
13944
13945
13946
13947
13948
13949
13950
13951
13952
13953
13954
13955
13956
13957
13958
13959
13960
13961
13962
13963
13964
13965
13966
13967
13968
13969
13970
13971
13972
13973
13974
13975
13976
13977
13978
13979
13980
13981
13982
13983
13984
13985
13986
13987
13988
13989
13990
13991
13992
13993
13994
13995
13996
13997
13998
13999
14000
14001
14002
14003
14004
14005
14006
14007
14008
14009
14010
14011
14012
14013
14014
14015
14016
14017
14018
14019
14020
14021
14022
14023
14024
14025
14026
14027
14028
14029
14030
14031
14032
14033
14034
14035
14036
14037
14038
14039
14040
14041
14042
14043
14044
14045
14046
14047
14048
14049
14050
14051
14052
14053
14054
14055
14056
14057
14058
14059
14060
14061
14062
14063
14064
14065
14066
14067
14068
14069
14070
14071
14072
14073
14074
14075
14076
14077
14078
14079
14080
14081
14082
14083
14084
14085
14086
14087
14088
14089
14090
14091
14092
14093
14094
14095
14096
14097
14098
14099
14100
14101
14102
14103
14104
14105
14106
14107
14108
14109
14110
14111
14112
14113
14114
14115
14116
14117
14118
14119
14120
14121
14122
14123
14124
14125
14126
14127
14128
14129
14130
14131
14132
14133
14134
14135
14136
14137
14138
14139
14140
14141
14142
14143
14144
14145
14146
14147
14148
14149
14150
14151
14152
14153
14154
14155
14156
14157
14158
14159
14160
14161
14162
14163
14164
14165
14166
14167
14168
14169
14170
14171
14172
14173
14174
14175
14176
14177
14178
14179
14180
14181
14182
14183
14184
14185
14186
14187
14188
14189
14190
14191
14192
14193
14194
14195
14196
14197
14198
14199
14200
14201
14202
14203
14204
14205
14206
14207
14208
14209
14210
14211
14212
14213
14214
14215
14216
14217
14218
14219
14220
14221
14222
14223
14224
14225
14226
14227
14228
14229
14230
14231
14232
14233
14234
14235
14236
14237
14238
14239
14240
14241
14242
14243
14244
14245
14246
14247
14248
14249
14250
14251
14252
14253
14254
14255
14256
14257
14258
14259
14260
14261
14262
14263
14264
14265
14266
14267
14268
14269
14270
14271
14272
14273
14274
14275
14276
14277
14278
14279
14280
14281
14282
14283
14284
14285
14286
14287
14288
14289
14290
14291
14292
14293
14294
14295
14296
14297
14298
14299
14300
14301
14302
14303
14304
14305
14306
14307
14308
14309
14310
14311
14312
14313
14314
14315
14316
14317
14318
14319
14320
14321
14322
14323
14324
14325
14326
14327
14328
14329
14330
14331
14332
14333
14334
14335
14336
14337
14338
14339
14340
14341
14342
14343
14344
14345
14346
14347
14348
14349
14350
14351
14352
14353
14354
14355
14356
14357
14358
14359
14360
14361
14362
14363
14364
14365
14366
14367
14368
14369
14370
14371
14372
14373
14374
14375
14376
14377
14378
14379
14380
14381
14382
14383
14384
14385
14386
14387
14388
14389
14390
14391
14392
14393
14394
14395
14396
14397
14398
14399
14400
14401
14402
14403
14404
14405
14406
14407
14408
14409
14410
14411
14412
14413
14414
14415
14416
14417
14418
14419
14420
14421
14422
14423
14424
14425
14426
14427
14428
14429
14430
14431
14432
14433
14434
14435
14436
14437
14438
14439
14440
14441
14442
14443
14444
14445
14446
14447
14448
14449
14450
14451
14452
14453
14454
14455
14456
14457
14458
14459
14460
14461
14462
14463
14464
14465
14466
14467
14468
14469
14470
14471
14472
14473
14474
14475
14476
14477
14478
14479
14480
14481
14482
14483
14484
14485
14486
14487
14488
14489
14490
14491
14492
14493
14494
14495
14496
14497
14498
14499
14500
14501
14502
14503
14504
14505
14506
14507
14508
14509
14510
14511
14512
14513
14514
14515
14516
14517
14518
14519
14520
14521
14522
14523
14524
14525
14526
14527
14528
14529
14530
14531
14532
14533
14534
14535
14536
14537
14538
14539
14540
14541
14542
14543
14544
14545
14546
14547
14548
14549
14550
14551
14552
14553
14554
14555
14556
14557
14558
14559
14560
14561
14562
14563
14564
14565
14566
14567
14568
14569
14570
14571
14572
14573
14574
14575
14576
14577
14578
14579
14580
14581
14582
14583
14584
14585
14586
14587
14588
14589
14590
14591
14592
14593
14594
14595
14596
14597
14598
14599
14600
14601
14602
14603
14604
14605
14606
14607
14608
14609
14610
14611
14612
14613
14614
14615
14616
14617
14618
14619
14620
14621
14622
14623
14624
14625
14626
14627
14628
14629
14630
14631
14632
14633
14634
14635
14636
14637
14638
14639
14640
14641
14642
14643
14644
14645
14646
14647
14648
14649
14650
14651
14652
14653
14654
14655
14656
14657
14658
14659
14660
14661
14662
14663
14664
14665
14666
14667
14668
14669
14670
14671
14672
14673
14674
14675
14676
14677
14678
14679
14680
14681
14682
14683
14684
14685
14686
14687
14688
14689
14690
14691
14692
14693
14694
14695
14696
14697
14698
14699
14700
14701
14702
14703
14704
14705
14706
14707
14708
14709
14710
14711
14712
14713
14714
14715
14716
14717
14718
14719
14720
14721
14722
14723
14724
14725
14726
14727
14728
14729
14730
14731
14732
14733
14734
14735
14736
14737
14738
14739
14740
14741
14742
14743
14744
14745
14746
14747
14748
14749
14750
14751
14752
14753
14754
14755
14756
14757
14758
14759
14760
14761
14762
14763
14764
14765
14766
14767
14768
14769
14770
14771
14772
14773
14774
14775
14776
14777
14778
14779
14780
14781
14782
14783
14784
14785
14786
14787
14788
14789
14790
14791
14792
14793
14794
14795
14796
14797
14798
14799
14800
14801
14802
14803
14804
14805
14806
14807
14808
14809
14810
14811
14812
14813
14814
14815
14816
14817
14818
14819
14820
14821
14822
14823
14824
14825
14826
14827
14828
14829
14830
14831
14832
14833
14834
14835
14836
14837
14838
14839
14840
14841
14842
14843
14844
14845
14846
14847
14848
14849
14850
14851
14852
14853
14854
14855
14856
14857
14858
14859
14860
14861
14862
14863
14864
14865
14866
14867
14868
14869
14870
14871
14872
14873
14874
14875
14876
14877
14878
14879
14880
14881
14882
14883
14884
14885
14886
14887
14888
14889
14890
14891
14892
14893
14894
14895
14896
14897
14898
14899
14900
14901
14902
14903
14904
14905
14906
14907
14908
14909
14910
14911
14912
14913
14914
14915
14916
14917
14918
14919
14920
14921
14922
14923
14924
14925
14926
14927
14928
14929
14930
14931
14932
14933
14934
14935
14936
14937
14938
14939
14940
14941
14942
14943
14944
14945
14946
14947
14948
14949
14950
14951
14952
14953
14954
14955
14956
14957
14958
14959
14960
14961
14962
14963
14964
14965
14966
14967
14968
14969
14970
14971
14972
14973
14974
14975
14976
14977
14978
14979
14980
14981
14982
14983
14984
14985
14986
14987
14988
14989
14990
14991
14992
14993
14994
14995
14996
14997
14998
14999
15000
15001
15002
15003
15004
15005
15006
15007
15008
15009
15010
15011
15012
15013
15014
15015
15016
15017
15018
15019
15020
15021
15022
15023
15024
15025
15026
15027
15028
15029
15030
15031
15032
15033
15034
15035
15036
15037
15038
15039
15040
15041
15042
15043
15044
15045
15046
15047
15048
15049
15050
15051
15052
15053
15054
15055
15056
15057
15058
15059
15060
15061
15062
15063
15064
15065
15066
15067
15068
15069
15070
15071
15072
15073
15074
15075
15076
15077
15078
15079
15080
15081
15082
15083
15084
15085
15086
15087
15088
15089
15090
15091
15092
15093
15094
15095
15096
15097
15098
15099
15100
15101
15102
15103
15104
15105
15106
15107
15108
15109
15110
15111
15112
15113
15114
15115
15116
15117
15118
15119
15120
15121
15122
15123
15124
15125
15126
15127
15128
15129
15130
15131
15132
15133
15134
15135
15136
15137
15138
15139
15140
15141
15142
15143
15144
15145
15146
15147
15148
15149
15150
15151
15152
15153
15154
15155
15156
15157
15158
15159
15160
15161
15162
15163
15164
15165
15166
15167
15168
15169
15170
15171
15172
15173
15174
15175
15176
15177
15178
15179
15180
15181
15182
15183
15184
15185
15186
15187
15188
15189
15190
15191
15192
15193
15194
15195
15196
15197
15198
15199
15200
15201
15202
15203
15204
15205
15206
15207
15208
15209
15210
15211
15212
15213
15214
15215
15216
15217
15218
15219
15220
15221
15222
15223
15224
15225
15226
15227
15228
15229
15230
15231
15232
15233
15234
15235
15236
15237
15238
15239
15240
15241
15242
15243
15244
15245
15246
15247
15248
15249
15250
15251
15252
15253
15254
15255
15256
15257
15258
15259
15260
15261
15262
15263
15264
15265
15266
15267
15268
15269
15270
15271
15272
15273
15274
15275
15276
15277
15278
15279
15280
15281
15282
15283
15284
15285
15286
15287
15288
15289
15290
15291
15292
15293
15294
15295
15296
15297
15298
15299
15300
15301
15302
15303
15304
15305
15306
15307
15308
15309
15310
15311
15312
15313
15314
15315
15316
15317
15318
15319
15320
15321
15322
15323
15324
15325
15326
15327
15328
15329
15330
15331
15332
15333
15334
15335
15336
15337
15338
15339
15340
15341
15342
15343
15344
15345
15346
15347
15348
15349
15350
15351
15352
15353
15354
15355
15356
15357
15358
15359
15360
15361
15362
15363
15364
15365
15366
15367
15368
15369
15370
15371
15372
15373
15374
15375
15376
15377
15378
15379
15380
15381
15382
15383
15384
15385
15386
15387
15388
15389
15390
15391
15392
15393
15394
15395
15396
15397
15398
15399
15400
15401
15402
15403
15404
15405
15406
15407
15408
15409
15410
15411
15412
15413
15414
15415
15416
15417
15418
15419
15420
15421
15422
15423
15424
15425
15426
15427
15428
15429
15430
15431
15432
15433
15434
15435
15436
15437
15438
15439
15440
15441
15442
15443
15444
15445
15446
15447
15448
15449
15450
15451
15452
15453
15454
15455
15456
15457
15458
15459
15460
15461
15462
15463
15464
15465
15466
15467
15468
15469
15470
15471
15472
15473
15474
15475
15476
15477
15478
15479
15480
15481
15482
15483
15484
15485
15486
15487
15488
15489
15490
15491
15492
15493
15494
15495
15496
15497
15498
15499
15500
15501
15502
15503
15504
15505
15506
15507
15508
15509
15510
15511
15512
15513
15514
15515
15516
15517
15518
15519
15520
15521
15522
15523
15524
15525
15526
15527
15528
15529
15530
15531
15532
15533
15534
15535
15536
15537
15538
15539
15540
15541
15542
15543
15544
15545
15546
15547
15548
15549
15550
15551
15552
15553
15554
15555
15556
15557
15558
15559
15560
15561
15562
15563
15564
15565
15566
15567
15568
15569
15570
15571
15572
15573
15574
15575
15576
15577
15578
15579
15580
15581
15582
15583
15584
15585
15586
15587
15588
15589
15590
15591
15592
15593
15594
15595
15596
15597
15598
15599
15600
15601
15602
15603
15604
15605
15606
15607
15608
15609
15610
15611
15612
15613
15614
15615
15616
15617
15618
15619
15620
15621
15622
15623
15624
15625
15626
15627
15628
15629
15630
15631
15632
15633
15634
15635
15636
15637
15638
15639
15640
15641
15642
15643
15644
15645
15646
15647
15648
15649
15650
15651
15652
15653
15654
15655
15656
15657
15658
15659
15660
15661
15662
15663
15664
15665
15666
15667
15668
15669
15670
15671
15672
15673
15674
15675
15676
15677
15678
15679
15680
15681
15682
15683
15684
15685
15686
15687
15688
15689
15690
15691
15692
15693
15694
15695
15696
15697
15698
15699
15700
15701
15702
15703
15704
15705
15706
15707
15708
15709
15710
15711
15712
15713
15714
15715
15716
15717
15718
15719
15720
15721
15722
15723
15724
15725
15726
15727
15728
15729
15730
15731
15732
15733
15734
15735
15736
15737
15738
15739
15740
15741
15742
15743
15744
15745
15746
15747
15748
15749
15750
15751
15752
15753
15754
15755
15756
15757
15758
15759
15760
15761
15762
15763
15764
15765
15766
15767
15768
15769
15770
15771
15772
15773
15774
15775
15776
15777
15778
15779
15780
15781
15782
15783
15784
15785
15786
15787
15788
15789
15790
15791
15792
15793
15794
15795
15796
15797
15798
15799
15800
15801
15802
15803
15804
15805
15806
15807
15808
15809
15810
15811
15812
15813
15814
15815
15816
15817
15818
15819
15820
15821
15822
15823
15824
15825
15826
15827
15828
15829
15830
15831
15832
15833
15834
15835
15836
15837
15838
15839
15840
15841
15842
15843
15844
15845
15846
15847
15848
15849
15850
15851
15852
15853
15854
15855
15856
15857
15858
15859
15860
15861
15862
15863
15864
15865
15866
15867
15868
15869
15870
15871
15872
15873
15874
15875
15876
15877
15878
15879
15880
15881
15882
15883
15884
15885
15886
15887
15888
15889
15890
15891
15892
15893
15894
15895
15896
15897
15898
15899
15900
15901
15902
15903
15904
15905
15906
15907
15908
15909
15910
15911
15912
15913
15914
15915
15916
15917
15918
15919
15920
15921
15922
15923
15924
15925
15926
15927
15928
15929
15930
15931
15932
15933
15934
15935
15936
15937
15938
15939
15940
15941
15942
15943
15944
15945
15946
15947
15948
15949
15950
15951
15952
15953
15954
15955
15956
15957
15958
15959
15960
15961
15962
15963
15964
15965
15966
15967
15968
15969
15970
15971
15972
15973
15974
15975
15976
15977
15978
15979
15980
15981
15982
15983
15984
15985
15986
15987
15988
15989
15990
15991
15992
15993
15994
15995
15996
15997
15998
15999
16000
16001
16002
16003
16004
16005
16006
16007
16008
16009
16010
16011
16012
16013
16014
16015
16016
16017
16018
16019
16020
16021
16022
16023
16024
16025
16026
16027
16028
16029
16030
16031
16032
16033
16034
16035
16036
16037
16038
16039
16040
16041
16042
16043
16044
16045
16046
16047
16048
16049
16050
16051
16052
16053
16054
16055
16056
16057
16058
16059
16060
16061
16062
16063
16064
16065
16066
16067
16068
16069
16070
16071
16072
16073
16074
16075
16076
16077
16078
16079
16080
16081
16082
16083
16084
16085
16086
16087
16088
16089
16090
16091
16092
16093
16094
16095
16096
16097
16098
16099
16100
16101
16102
16103
16104
16105
16106
16107
16108
16109
16110
16111
16112
16113
16114
16115
16116
16117
16118
16119
16120
16121
16122
16123
16124
16125
16126
16127
16128
16129
16130
16131
16132
16133
16134
16135
16136
16137
16138
16139
16140
16141
16142
16143
16144
16145
16146
16147
16148
16149
16150
16151
16152
16153
16154
16155
16156
16157
16158
16159
16160
16161
16162
16163
16164
16165
16166
16167
16168
16169
16170
16171
16172
16173
16174
16175
16176
16177
16178
16179
16180
16181
16182
16183
16184
16185
16186
16187
16188
16189
16190
16191
16192
16193
16194
16195
16196
16197
16198
16199
16200
16201
16202
16203
16204
16205
16206
16207
16208
16209
16210
16211
16212
16213
16214
16215
16216
16217
16218
16219
16220
16221
16222
16223
16224
16225
16226
16227
16228
16229
16230
16231
16232
16233
16234
16235
16236
16237
16238
16239
16240
16241
16242
16243
16244
16245
16246
16247
16248
16249
16250
16251
16252
16253
16254
16255
16256
16257
16258
16259
16260
16261
16262
16263
16264
16265
16266
16267
16268
16269
16270
16271
16272
16273
16274
16275
16276
16277
16278
16279
16280
16281
16282
16283
16284
16285
16286
16287
16288
16289
16290
16291
16292
16293
16294
16295
16296
16297
16298
16299
16300
16301
16302
16303
16304
16305
16306
16307
16308
16309
16310
16311
16312
16313
16314
16315
16316
16317
16318
16319
16320
16321
16322
16323
16324
16325
16326
16327
16328
16329
16330
16331
16332
16333
16334
16335
16336
16337
16338
16339
16340
16341
16342
16343
16344
16345
16346
16347
16348
16349
16350
16351
16352
16353
16354
16355
16356
16357
16358
16359
16360
16361
16362
16363
16364
16365
16366
16367
16368
16369
16370
16371
16372
16373
16374
16375
16376
16377
16378
16379
16380
16381
16382
16383
16384
16385
16386
16387
16388
16389
16390
16391
16392
16393
16394
16395
16396
16397
16398
16399
16400
16401
16402
16403
16404
16405
16406
16407
16408
16409
16410
16411
16412
16413
16414
16415
16416
16417
16418
16419
16420
16421
16422
16423
16424
16425
16426
16427
16428
16429
16430
16431
16432
16433
16434
16435
16436
16437
16438
16439
16440
16441
16442
16443
16444
16445
16446
16447
16448
16449
16450
16451
16452
16453
16454
16455
16456
16457
16458
16459
16460
16461
16462
16463
16464
16465
16466
16467
16468
16469
16470
16471
16472
16473
16474
16475
16476
16477
16478
16479
16480
16481
16482
16483
16484
16485
16486
16487
16488
16489
16490
16491
16492
16493
16494
16495
16496
16497
16498
16499
16500
16501
16502
16503
16504
16505
16506
16507
16508
16509
16510
16511
16512
16513
16514
16515
16516
16517
16518
16519
16520
16521
16522
16523
16524
16525
16526
16527
16528
16529
16530
16531
16532
16533
16534
16535
16536
16537
16538
16539
16540
16541
16542
16543
16544
16545
16546
16547
16548
16549
16550
16551
16552
16553
16554
16555
16556
16557
16558
16559
16560
16561
16562
16563
16564
16565
16566
16567
16568
16569
16570
16571
16572
16573
16574
16575
16576
16577
16578
16579
16580
16581
16582
16583
16584
16585
16586
16587
16588
16589
16590
16591
16592
16593
16594
16595
16596
16597
16598
16599
16600
16601
16602
16603
16604
16605
16606
16607
16608
16609
16610
16611
16612
16613
16614
16615
16616
16617
16618
16619
16620
16621
16622
16623
16624
16625
16626
16627
16628
16629
16630
16631
16632
16633
16634
16635
16636
16637
16638
16639
16640
16641
16642
16643
16644
16645
16646
16647
16648
16649
16650
16651
16652
16653
16654
16655
16656
16657
16658
16659
16660
16661
16662
16663
16664
16665
16666
16667
16668
16669
16670
16671
16672
16673
16674
16675
16676
16677
16678
16679
16680
16681
16682
16683
16684
16685
16686
16687
16688
16689
16690
16691
16692
16693
16694
16695
16696
16697
16698
16699
16700
16701
16702
16703
16704
16705
16706
16707
16708
16709
16710
16711
16712
16713
16714
16715
16716
16717
16718
16719
16720
16721
16722
16723
16724
16725
16726
16727
16728
16729
16730
16731
16732
16733
16734
16735
16736
16737
16738
16739
16740
16741
16742
16743
16744
16745
16746
16747
16748
16749
16750
16751
16752
16753
16754
16755
16756
16757
16758
16759
16760
16761
16762
16763
16764
16765
16766
16767
16768
16769
16770
16771
16772
16773
16774
16775
16776
16777
16778
16779
16780
16781
16782
16783
16784
16785
16786
16787
16788
16789
16790
16791
16792
16793
16794
16795
16796
16797
16798
16799
16800
16801
16802
16803
16804
16805
16806
16807
16808
16809
16810
16811
16812
16813
16814
16815
16816
16817
16818
16819
16820
16821
16822
16823
16824
16825
16826
16827
16828
16829
16830
16831
16832
16833
16834
16835
16836
16837
16838
16839
16840
16841
16842
16843
16844
16845
16846
16847
16848
16849
16850
16851
16852
16853
16854
16855
16856
16857
16858
16859
16860
16861
16862
16863
16864
16865
16866
16867
16868
16869
16870
16871
16872
16873
16874
16875
16876
16877
16878
16879
16880
16881
16882
16883
16884
16885
16886
16887
16888
16889
16890
16891
16892
16893
16894
16895
16896
16897
16898
16899
16900
16901
16902
16903
16904
16905
16906
16907
16908
16909
16910
16911
16912
16913
16914
16915
16916
16917
16918
16919
16920
16921
16922
16923
16924
16925
16926
16927
16928
16929
16930
16931
16932
16933
16934
16935
16936
16937
16938
16939
16940
16941
16942
16943
16944
16945
16946
16947
16948
16949
16950
16951
16952
16953
16954
16955
16956
16957
16958
16959
16960
16961
16962
16963
16964
16965
16966
16967
16968
16969
16970
16971
16972
16973
16974
16975
16976
16977
16978
16979
16980
16981
16982
16983
16984
16985
16986
16987
16988
16989
16990
16991
16992
16993
16994
16995
16996
16997
16998
16999
17000
17001
17002
17003
17004
17005
17006
17007
17008
17009
17010
17011
17012
17013
17014
17015
17016
17017
17018
17019
17020
17021
17022
17023
17024
17025
17026
17027
17028
17029
17030
17031
17032
17033
17034
17035
17036
17037
17038
17039
17040
17041
17042
17043
17044
17045
17046
17047
17048
17049
17050
17051
17052
17053
17054
17055
17056
17057
17058
17059
17060
17061
17062
17063
17064
17065
17066
17067
17068
17069
17070
17071
17072
17073
17074
17075
17076
17077
17078
17079
17080
17081
17082
17083
17084
17085
17086
17087
17088
17089
17090
17091
17092
17093
17094
17095
17096
17097
17098
17099
17100
17101
17102
17103
17104
17105
17106
17107
17108
17109
17110
17111
17112
17113
17114
17115
17116
17117
17118
17119
17120
17121
17122
17123
17124
17125
17126
17127
17128
17129
17130
17131
17132
17133
17134
17135
17136
17137
17138
17139
17140
17141
17142
17143
17144
17145
17146
17147
17148
17149
17150
17151
17152
17153
17154
17155
17156
17157
17158
17159
17160
17161
17162
17163
17164
17165
17166
17167
17168
17169
17170
17171
17172
17173
17174
17175
17176
17177
17178
17179
17180
17181
17182
17183
17184
17185
17186
17187
17188
17189
17190
17191
17192
17193
17194
17195
17196
17197
17198
17199
17200
17201
17202
17203
17204
17205
17206
17207
17208
17209
17210
17211
17212
17213
17214
17215
17216
17217
17218
17219
17220
17221
17222
17223
17224
17225
17226
17227
17228
17229
17230
17231
17232
17233
17234
17235
17236
17237
17238
17239
17240
17241
17242
17243
17244
17245
17246
17247
17248
17249
17250
17251
17252
17253
17254
17255
17256
17257
17258
17259
17260
17261
17262
17263
17264
17265
17266
17267
17268
17269
17270
17271
17272
17273
17274
17275
17276
17277
17278
17279
17280
17281
17282
17283
17284
17285
17286
17287
17288
17289
17290
17291
17292
17293
17294
17295
17296
17297
17298
17299
17300
17301
17302
17303
17304
17305
17306
17307
17308
17309
17310
17311
17312
17313
17314
17315
17316
17317
17318
17319
17320
17321
17322
17323
17324
17325
17326
17327
17328
17329
17330
17331
17332
17333
17334
17335
17336
17337
17338
17339
17340
17341
17342
17343
17344
17345
17346
17347
17348
17349
17350
17351
17352
17353
17354
17355
17356
17357
17358
17359
17360
17361
17362
17363
17364
17365
17366
17367
17368
17369
17370
17371
17372
17373
17374
17375
17376
17377
17378
17379
17380
17381
17382
17383
17384
17385
17386
17387
17388
17389
17390
17391
17392
17393
17394
17395
17396
17397
17398
17399
17400
17401
17402
17403
17404
17405
17406
17407
17408
17409
17410
17411
17412
17413
17414
17415
17416
17417
17418
17419
17420
17421
17422
17423
17424
17425
17426
17427
17428
17429
17430
17431
17432
17433
17434
17435
17436
17437
17438
17439
17440
17441
17442
17443
17444
17445
17446
17447
17448
17449
17450
17451
17452
17453
17454
17455
17456
17457
17458
17459
17460
17461
17462
17463
17464
17465
17466
17467
17468
17469
17470
17471
17472
17473
17474
17475
17476
17477
17478
17479
17480
17481
17482
17483
17484
17485
17486
17487
17488
17489
17490
17491
17492
17493
17494
17495
17496
17497
17498
17499
17500
17501
17502
17503
17504
17505
17506
17507
17508
17509
17510
17511
17512
17513
17514
17515
17516
17517
17518
17519
17520
17521
17522
17523
17524
17525
17526
17527
17528
17529
17530
17531
17532
17533
17534
17535
17536
17537
17538
17539
17540
17541
17542
17543
17544
17545
17546
17547
17548
17549
17550
17551
17552
17553
17554
17555
17556
17557
17558
17559
17560
17561
17562
17563
17564
17565
17566
17567
17568
17569
17570
17571
17572
17573
17574
17575
17576
17577
17578
17579
17580
17581
17582
17583
17584
17585
17586
17587
17588
17589
17590
17591
17592
17593
17594
17595
17596
17597
17598
17599
17600
17601
17602
17603
17604
17605
17606
17607
17608
17609
17610
17611
17612
17613
17614
17615
17616
17617
17618
17619
17620
17621
17622
17623
17624
17625
17626
17627
17628
17629
17630
17631
17632
17633
17634
17635
17636
17637
17638
17639
17640
17641
17642
17643
17644
17645
17646
17647
17648
17649
17650
17651
17652
17653
17654
17655
17656
17657
17658
17659
17660
17661
17662
17663
17664
17665
17666
17667
17668
17669
17670
17671
17672
17673
17674
17675
17676
17677
17678
17679
17680
17681
17682
17683
17684
17685
17686
17687
17688
17689
17690
17691
17692
17693
17694
17695
17696
17697
17698
17699
17700
17701
17702
17703
17704
17705
17706
17707
17708
17709
17710
17711
17712
17713
17714
17715
17716
17717
17718
17719
17720
17721
17722
17723
17724
17725
17726
17727
17728
17729
17730
17731
17732
17733
17734
17735
17736
17737
17738
17739
17740
17741
17742
17743
17744
17745
17746
17747
17748
17749
17750
17751
17752
17753
17754
17755
17756
17757
17758
17759
17760
17761
17762
17763
17764
17765
17766
17767
17768
17769
17770
17771
17772
17773
17774
17775
17776
17777
17778
17779
17780
17781
17782
17783
17784
17785
17786
17787
17788
17789
17790
17791
17792
17793
17794
17795
17796
17797
17798
17799
17800
17801
17802
17803
17804
17805
17806
17807
17808
17809
17810
17811
17812
17813
17814
17815
17816
17817
17818
17819
17820
17821
17822
17823
17824
17825
17826
17827
17828
17829
17830
17831
17832
17833
17834
17835
17836
17837
17838
17839
17840
17841
17842
17843
17844
17845
17846
17847
17848
17849
17850
17851
17852
17853
17854
17855
17856
17857
17858
17859
17860
17861
17862
17863
17864
17865
17866
17867
17868
17869
17870
17871
17872
17873
17874
17875
17876
17877
17878
17879
17880
17881
17882
17883
17884
17885
17886
17887
17888
17889
17890
17891
17892
17893
17894
17895
17896
17897
17898
17899
17900
17901
17902
17903
17904
17905
17906
17907
17908
17909
17910
17911
17912
17913
17914
17915
17916
17917
17918
17919
17920
17921
17922
17923
17924
17925
17926
17927
17928
17929
17930
17931
17932
17933
17934
17935
17936
17937
17938
17939
17940
17941
17942
17943
17944
17945
17946
17947
17948
17949
17950
17951
17952
17953
17954
17955
17956
17957
17958
17959
17960
17961
17962
17963
17964
17965
17966
17967
17968
17969
17970
17971
17972
17973
17974
17975
17976
17977
17978
17979
17980
17981
17982
17983
17984
17985
17986
17987
17988
17989
17990
17991
17992
17993
17994
17995
17996
17997
17998
17999
18000
18001
18002
18003
18004
18005
18006
18007
18008
18009
18010
18011
18012
18013
18014
18015
18016
18017
18018
18019
18020
18021
18022
18023
18024
18025
18026
18027
18028
18029
18030
18031
18032
18033
18034
18035
18036
18037
18038
18039
18040
18041
18042
18043
18044
18045
18046
18047
18048
18049
18050
18051
18052
18053
18054
18055
18056
18057
18058
18059
18060
18061
18062
18063
18064
18065
18066
18067
18068
18069
18070
18071
18072
18073
18074
18075
18076
18077
18078
18079
18080
18081
18082
18083
18084
18085
18086
18087
18088
18089
18090
18091
18092
18093
18094
18095
18096
18097
18098
18099
18100
18101
18102
18103
18104
18105
18106
18107
18108
18109
18110
18111
18112
18113
18114
18115
18116
18117
18118
18119
18120
18121
18122
18123
18124
18125
18126
18127
18128
18129
18130
18131
18132
18133
18134
18135
18136
18137
18138
18139
18140
18141
18142
18143
18144
18145
18146
18147
18148
18149
18150
18151
18152
18153
18154
18155
18156
18157
18158
18159
18160
18161
18162
18163
18164
18165
18166
18167
18168
18169
18170
18171
18172
18173
18174
18175
18176
18177
18178
18179
18180
18181
18182
18183
18184
18185
18186
18187
18188
18189
18190
18191
18192
18193
18194
18195
18196
18197
18198
18199
18200
18201
18202
18203
18204
18205
18206
18207
18208
18209
18210
18211
18212
18213
18214
18215
18216
18217
18218
18219
18220
18221
18222
18223
18224
18225
18226
18227
18228
18229
18230
18231
18232
18233
18234
18235
18236
18237
18238
18239
18240
18241
18242
18243
18244
18245
18246
18247
18248
18249
18250
18251
18252
18253
18254
18255
18256
18257
18258
18259
18260
18261
18262
18263
18264
18265
18266
18267
18268
18269
18270
18271
18272
18273
18274
18275
18276
18277
18278
18279
18280
18281
18282
18283
18284
18285
18286
18287
18288
18289
18290
18291
18292
18293
18294
18295
18296
18297
18298
18299
18300
18301
18302
18303
18304
18305
18306
18307
18308
18309
18310
18311
18312
18313
18314
18315
18316
18317
18318
18319
18320
18321
18322
18323
18324
18325
18326
18327
18328
18329
18330
18331
18332
18333
18334
18335
18336
18337
18338
18339
18340
18341
18342
18343
18344
18345
18346
18347
18348
18349
18350
18351
18352
18353
18354
18355
18356
18357
18358
18359
18360
18361
18362
18363
18364
18365
18366
18367
18368
18369
18370
18371
18372
18373
18374
18375
18376
18377
18378
18379
18380
18381
18382
18383
18384
18385
18386
18387
18388
18389
18390
18391
18392
18393
18394
18395
18396
18397
18398
18399
18400
18401
18402
18403
18404
18405
18406
18407
18408
18409
18410
18411
18412
18413
18414
18415
18416
18417
18418
18419
18420
18421
18422
18423
18424
18425
18426
18427
18428
18429
18430
18431
18432
18433
18434
18435
18436
18437
18438
18439
18440
18441
18442
18443
18444
18445
18446
18447
18448
18449
18450
18451
18452
18453
18454
18455
18456
18457
18458
18459
18460
18461
18462
18463
18464
18465
18466
18467
18468
18469
18470
18471
18472
18473
18474
18475
18476
18477
18478
18479
18480
18481
18482
18483
18484
18485
18486
18487
18488
18489
18490
18491
18492
18493
18494
18495
18496
18497
18498
18499
18500
18501
18502
18503
18504
18505
18506
18507
18508
18509
18510
18511
18512
18513
18514
18515
18516
18517
18518
18519
18520
18521
18522
18523
18524
18525
18526
18527
18528
18529
18530
18531
18532
18533
18534
18535
18536
18537
18538
18539
18540
18541
18542
18543
18544
18545
18546
18547
18548
18549
18550
18551
18552
18553
18554
18555
18556
18557
18558
18559
18560
18561
18562
18563
18564
18565
18566
18567
18568
18569
18570
18571
18572
18573
18574
18575
18576
18577
18578
18579
18580
18581
18582
18583
18584
18585
18586
18587
18588
18589
18590
18591
18592
18593
18594
18595
18596
18597
18598
18599
18600
18601
18602
18603
18604
18605
18606
18607
18608
18609
18610
18611
18612
18613
18614
18615
18616
18617
18618
18619
18620
18621
18622
18623
18624
18625
18626
18627
18628
18629
18630
18631
18632
18633
18634
18635
18636
18637
18638
18639
18640
18641
18642
18643
18644
18645
18646
18647
18648
18649
18650
18651
18652
18653
18654
18655
18656
18657
18658
18659
18660
18661
18662
18663
18664
18665
18666
18667
18668
18669
18670
18671
18672
18673
18674
18675
18676
18677
18678
18679
18680
18681
18682
18683
18684
18685
18686
18687
18688
18689
18690
18691
18692
18693
18694
18695
18696
18697
18698
18699
18700
18701
18702
18703
18704
18705
18706
18707
18708
18709
18710
18711
18712
18713
18714
18715
18716
18717
18718
18719
18720
18721
18722
18723
18724
18725
18726
18727
18728
18729
18730
18731
18732
18733
18734
18735
18736
18737
18738
18739
18740
18741
18742
18743
18744
18745
18746
18747
18748
18749
18750
18751
18752
18753
18754
18755
18756
18757
18758
18759
18760
18761
18762
18763
18764
18765
18766
18767
18768
18769
18770
18771
18772
18773
18774
18775
18776
18777
18778
18779
18780
18781
18782
18783
18784
18785
18786
18787
18788
18789
18790
18791
18792
18793
18794
18795
18796
18797
18798
18799
18800
18801
18802
18803
18804
18805
18806
18807
18808
18809
18810
18811
18812
18813
18814
18815
18816
18817
18818
18819
18820
18821
18822
18823
18824
18825
18826
18827
18828
18829
18830
18831
18832
18833
18834
18835
18836
18837
18838
18839
18840
18841
18842
18843
18844
18845
18846
18847
18848
18849
18850
18851
18852
18853
18854
18855
18856
18857
18858
18859
18860
18861
18862
18863
18864
18865
18866
18867
18868
18869
18870
18871
18872
18873
18874
18875
18876
18877
18878
18879
18880
18881
18882
18883
18884
18885
18886
18887
18888
18889
18890
18891
18892
18893
18894
18895
18896
18897
18898
18899
18900
18901
18902
18903
18904
18905
18906
18907
18908
18909
18910
18911
18912
18913
18914
18915
18916
18917
18918
18919
18920
18921
18922
18923
18924
18925
18926
18927
18928
18929
18930
18931
18932
18933
18934
18935
18936
18937
18938
18939
18940
18941
18942
18943
18944
18945
18946
18947
18948
18949
18950
18951
18952
18953
18954
18955
18956
18957
18958
18959
18960
18961
18962
18963
18964
18965
18966
18967
18968
18969
18970
18971
18972
18973
18974
18975
18976
18977
18978
18979
18980
18981
18982
18983
18984
18985
18986
18987
18988
18989
18990
18991
18992
18993
18994
18995
18996
18997
18998
18999
19000
19001
19002
19003
19004
19005
19006
19007
19008
19009
19010
19011
19012
19013
19014
19015
19016
19017
19018
19019
19020
19021
19022
19023
19024
19025
19026
19027
19028
19029
19030
19031
19032
19033
19034
19035
19036
19037
19038
19039
19040
19041
19042
19043
19044
19045
19046
19047
19048
19049
19050
19051
19052
19053
19054
19055
19056
19057
19058
19059
19060
19061
19062
19063
19064
19065
19066
19067
19068
19069
19070
19071
19072
19073
19074
19075
19076
19077
19078
19079
19080
19081
19082
19083
19084
19085
19086
19087
19088
19089
19090
19091
19092
19093
19094
19095
19096
19097
19098
19099
19100
19101
19102
19103
19104
19105
19106
19107
19108
19109
19110
19111
19112
19113
19114
19115
19116
19117
19118
19119
19120
19121
19122
19123
19124
19125
19126
19127
19128
19129
19130
19131
19132
19133
19134
19135
19136
19137
19138
19139
19140
19141
19142
19143
19144
19145
19146
19147
19148
19149
19150
19151
19152
19153
19154
19155
19156
19157
19158
19159
19160
19161
19162
19163
19164
19165
19166
19167
19168
19169
19170
19171
19172
19173
19174
19175
19176
19177
19178
19179
19180
19181
19182
19183
19184
19185
19186
19187
19188
19189
19190
19191
19192
19193
19194
19195
19196
19197
19198
19199
19200
19201
19202
19203
19204
19205
19206
19207
19208
19209
19210
19211
19212
19213
19214
19215
19216
19217
19218
19219
19220
19221
19222
19223
19224
19225
19226
19227
19228
19229
19230
19231
19232
19233
19234
19235
19236
19237
19238
19239
19240
19241
19242
19243
19244
19245
19246
19247
19248
19249
19250
19251
19252
19253
19254
19255
19256
19257
19258
19259
19260
19261
19262
19263
19264
19265
19266
19267
19268
19269
19270
19271
19272
19273
19274
19275
19276
19277
19278
19279
19280
19281
19282
19283
19284
19285
19286
19287
19288
19289
19290
19291
19292
19293
19294
19295
19296
19297
19298
19299
19300
19301
19302
19303
19304
19305
19306
19307
19308
19309
19310
19311
19312
19313
19314
19315
19316
19317
19318
19319
19320
19321
19322
19323
19324
19325
19326
19327
19328
19329
19330
19331
19332
19333
19334
19335
19336
19337
19338
19339
19340
19341
19342
19343
19344
19345
19346
19347
19348
19349
19350
19351
19352
19353
19354
19355
19356
19357
19358
19359
19360
19361
19362
19363
19364
19365
19366
19367
19368
19369
19370
19371
19372
19373
19374
19375
19376
19377
19378
19379
19380
19381
19382
19383
19384
19385
19386
19387
19388
19389
19390
19391
19392
19393
19394
19395
19396
19397
19398
19399
19400
19401
19402
19403
19404
19405
19406
19407
19408
19409
19410
19411
19412
19413
19414
19415
19416
19417
19418
19419
19420
19421
19422
19423
19424
19425
19426
19427
19428
19429
19430
19431
19432
19433
19434
19435
19436
19437
19438
19439
19440
19441
19442
19443
19444
19445
19446
19447
19448
19449
19450
19451
19452
19453
19454
19455
19456
19457
19458
19459
19460
19461
19462
19463
19464
19465
19466
19467
19468
19469
19470
19471
19472
19473
19474
19475
19476
19477
19478
19479
19480
19481
19482
19483
19484
19485
19486
19487
19488
19489
19490
19491
19492
19493
19494
19495
19496
19497
19498
19499
19500
19501
19502
19503
19504
19505
19506
19507
19508
19509
19510
19511
19512
19513
19514
19515
19516
19517
19518
19519
19520
19521
19522
19523
19524
19525
19526
19527
19528
19529
19530
19531
19532
19533
19534
19535
19536
19537
19538
19539
19540
19541
19542
19543
19544
19545
19546
19547
19548
19549
19550
19551
19552
19553
19554
19555
19556
19557
19558
19559
19560
19561
19562
19563
19564
19565
19566
19567
19568
19569
19570
19571
19572
19573
19574
19575
19576
19577
19578
19579
19580
19581
19582
19583
19584
19585
19586
19587
19588
19589
19590
19591
19592
19593
19594
19595
19596
19597
19598
19599
19600
19601
19602
19603
19604
19605
19606
19607
19608
19609
19610
19611
19612
19613
19614
19615
19616
19617
19618
19619
19620
19621
19622
19623
19624
19625
19626
19627
19628
19629
19630
19631
19632
19633
19634
19635
19636
19637
19638
19639
19640
19641
19642
19643
19644
19645
19646
19647
19648
19649
19650
19651
19652
19653
19654
19655
19656
19657
19658
19659
19660
19661
19662
19663
19664
19665
19666
19667
19668
19669
19670
19671
19672
19673
19674
19675
19676
19677
19678
19679
19680
19681
19682
19683
19684
19685
19686
19687
19688
19689
19690
19691
19692
19693
19694
19695
19696
19697
19698
19699
19700
19701
19702
19703
19704
19705
19706
19707
19708
19709
19710
19711
19712
19713
19714
19715
19716
19717
19718
19719
19720
19721
19722
19723
19724
19725
19726
19727
19728
19729
19730
19731
19732
19733
19734
19735
19736
19737
19738
19739
19740
19741
19742
19743
19744
19745
19746
19747
19748
19749
19750
19751
19752
19753
19754
19755
19756
19757
19758
19759
19760
19761
19762
19763
19764
19765
19766
19767
19768
19769
19770
19771
19772
19773
19774
19775
19776
19777
19778
19779
19780
19781
19782
19783
19784
19785
19786
19787
19788
19789
19790
19791
19792
19793
19794
19795
19796
19797
19798
19799
19800
19801
19802
19803
19804
19805
19806
19807
19808
19809
19810
19811
19812
19813
19814
19815
19816
19817
19818
19819
19820
19821
19822
19823
19824
19825
19826
19827
19828
19829
19830
19831
19832
19833
19834
19835
19836
19837
19838
19839
19840
19841
19842
19843
19844
19845
19846
19847
19848
19849
19850
19851
19852
19853
19854
19855
19856
19857
19858
19859
19860
19861
19862
19863
19864
19865
19866
19867
19868
19869
19870
19871
19872
19873
19874
19875
19876
19877
19878
19879
19880
19881
19882
19883
19884
19885
19886
19887
19888
19889
19890
19891
19892
19893
19894
19895
19896
19897
19898
19899
19900
19901
19902
19903
19904
19905
19906
19907
19908
19909
19910
19911
19912
19913
19914
19915
19916
19917
19918
19919
19920
19921
19922
19923
19924
19925
19926
19927
19928
19929
19930
19931
19932
19933
19934
19935
19936
19937
19938
19939
19940
19941
19942
19943
19944
19945
19946
19947
19948
19949
19950
19951
19952
19953
19954
19955
19956
19957
19958
19959
19960
19961
19962
19963
19964
19965
19966
19967
19968
19969
19970
19971
19972
19973
19974
19975
19976
19977
19978
19979
19980
19981
19982
19983
19984
19985
19986
19987
19988
19989
19990
19991
19992
19993
19994
19995
19996
19997
19998
19999
20000
20001
20002
20003
20004
20005
20006
20007
20008
20009
20010
20011
20012
20013
20014
20015
20016
20017
20018
20019
20020
20021
20022
20023
20024
20025
20026
20027
20028
20029
20030
20031
20032
20033
20034
20035
20036
20037
20038
20039
20040
20041
20042
20043
20044
20045
20046
20047
20048
20049
20050
20051
20052
20053
20054
20055
20056
20057
20058
20059
20060
20061
20062
20063
20064
20065
20066
20067
20068
20069
20070
20071
20072
20073
20074
20075
20076
20077
20078
20079
20080
20081
20082
20083
20084
20085
20086
20087
20088
20089
20090
20091
20092
20093
20094
20095
20096
20097
20098
20099
20100
20101
20102
20103
20104
20105
20106
20107
20108
20109
20110
20111
20112
20113
20114
20115
20116
20117
20118
20119
20120
20121
20122
20123
20124
20125
20126
20127
20128
20129
20130
20131
20132
20133
20134
20135
20136
20137
20138
20139
20140
20141
20142
20143
20144
20145
20146
20147
20148
20149
20150
20151
20152
20153
20154
20155
20156
20157
20158
20159
20160
20161
20162
20163
20164
20165
20166
20167
20168
20169
20170
20171
20172
20173
20174
20175
20176
20177
20178
20179
20180
20181
20182
20183
20184
20185
20186
20187
20188
20189
20190
20191
20192
20193
20194
20195
20196
20197
20198
20199
20200
20201
20202
20203
20204
20205
20206
20207
20208
20209
20210
20211
20212
20213
20214
20215
20216
20217
20218
20219
20220
20221
20222
20223
20224
20225
20226
20227
20228
20229
20230
20231
20232
20233
20234
20235
20236
20237
20238
20239
20240
20241
20242
20243
20244
20245
20246
20247
20248
20249
20250
20251
20252
20253
20254
20255
20256
20257
20258
20259
20260
20261
20262
20263
20264
20265
20266
20267
20268
20269
20270
20271
20272
20273
20274
20275
20276
20277
20278
20279
20280
20281
20282
20283
20284
20285
20286
20287
20288
20289
20290
20291
20292
20293
20294
20295
20296
20297
20298
20299
20300
20301
20302
20303
20304
20305
20306
20307
20308
20309
20310
20311
20312
20313
20314
20315
20316
20317
20318
20319
20320
20321
20322
20323
20324
20325
20326
20327
20328
20329
20330
20331
20332
20333
20334
20335
20336
20337
20338
20339
20340
20341
20342
20343
20344
20345
20346
20347
20348
20349
20350
20351
20352
20353
20354
20355
20356
20357
20358
20359
20360
20361
20362
20363
20364
20365
20366
20367
20368
20369
20370
20371
20372
20373
20374
20375
20376
20377
20378
20379
20380
20381
20382
20383
20384
20385
20386
20387
20388
20389
20390
20391
20392
20393
20394
20395
20396
20397
20398
20399
20400
20401
20402
20403
20404
20405
20406
20407
20408
20409
20410
20411
20412
20413
20414
20415
20416
20417
20418
20419
20420
20421
20422
20423
20424
20425
20426
20427
20428
20429
20430
20431
20432
20433
20434
20435
20436
20437
20438
20439
20440
20441
20442
20443
20444
20445
20446
20447
20448
20449
20450
20451
20452
20453
20454
20455
20456
20457
20458
20459
20460
20461
20462
20463
20464
20465
20466
20467
20468
20469
20470
20471
20472
20473
20474
20475
20476
20477
20478
20479
20480
20481
20482
20483
20484
20485
20486
20487
20488
20489
20490
20491
20492
20493
20494
20495
20496
20497
20498
20499
20500
20501
20502
20503
20504
20505
20506
20507
20508
20509
20510
20511
20512
20513
20514
20515
20516
20517
20518
20519
20520
20521
20522
20523
20524
20525
20526
20527
20528
20529
20530
20531
20532
20533
20534
20535
20536
20537
20538
20539
20540
20541
20542
20543
20544
20545
20546
20547
20548
20549
20550
20551
20552
20553
20554
20555
20556
20557
20558
20559
20560
20561
20562
20563
20564
20565
20566
20567
20568
20569
20570
20571
20572
20573
20574
20575
20576
20577
20578
20579
20580
20581
20582
20583
20584
20585
20586
20587
20588
20589
20590
20591
20592
20593
20594
20595
20596
20597
20598
20599
20600
20601
20602
20603
20604
20605
20606
20607
20608
20609
20610
20611
20612
20613
20614
20615
20616
20617
20618
20619
20620
20621
20622
20623
20624
20625
20626
20627
20628
20629
20630
20631
20632
20633
20634
20635
20636
20637
20638
20639
20640
20641
20642
20643
20644
20645
20646
20647
20648
20649
20650
20651
20652
20653
20654
20655
20656
20657
20658
20659
20660
20661
20662
20663
20664
20665
20666
20667
20668
20669
20670
20671
20672
20673
20674
20675
20676
20677
20678
20679
20680
20681
20682
20683
20684
20685
20686
20687
20688
20689
20690
20691
20692
20693
20694
20695
20696
20697
20698
20699
20700
20701
20702
20703
20704
20705
20706
20707
20708
20709
20710
20711
20712
20713
20714
20715
20716
20717
20718
20719
20720
20721
20722
20723
20724
20725
20726
20727
20728
20729
20730
20731
20732
20733
20734
20735
20736
20737
20738
20739
20740
20741
20742
20743
20744
20745
20746
20747
20748
20749
20750
20751
20752
20753
20754
20755
20756
20757
20758
20759
20760
20761
20762
20763
20764
20765
20766
20767
20768
20769
20770
20771
20772
20773
20774
20775
20776
20777
20778
20779
20780
20781
20782
20783
20784
20785
20786
20787
20788
20789
20790
20791
20792
20793
20794
20795
20796
20797
20798
20799
20800
20801
20802
20803
20804
20805
20806
20807
20808
20809
20810
20811
20812
20813
20814
20815
20816
20817
20818
20819
20820
20821
20822
20823
20824
20825
20826
20827
20828
20829
20830
20831
20832
20833
20834
20835
20836
20837
20838
20839
20840
20841
20842
20843
20844
20845
20846
20847
20848
20849
20850
20851
20852
20853
20854
20855
20856
20857
20858
20859
20860
20861
20862
20863
20864
20865
20866
20867
20868
20869
20870
20871
20872
20873
20874
20875
20876
20877
20878
20879
20880
20881
20882
20883
20884
20885
20886
20887
20888
20889
20890
20891
20892
20893
20894
20895
20896
20897
20898
20899
20900
20901
20902
20903
20904
20905
20906
20907
20908
20909
20910
20911
20912
20913
20914
20915
20916
20917
20918
20919
20920
20921
20922
20923
20924
20925
20926
20927
20928
20929
20930
20931
20932
20933
20934
20935
20936
20937
20938
20939
20940
20941
20942
20943
20944
20945
20946
20947
20948
20949
20950
20951
20952
20953
20954
20955
20956
20957
20958
20959
20960
20961
20962
20963
20964
20965
20966
20967
20968
20969
20970
20971
20972
20973
20974
20975
20976
20977
20978
20979
20980
20981
20982
20983
20984
20985
20986
20987
20988
20989
20990
20991
20992
20993
20994
20995
20996
20997
20998
20999
21000
21001
21002
21003
21004
21005
21006
21007
21008
21009
21010
21011
21012
21013
21014
21015
21016
21017
21018
21019
21020
21021
21022
21023
21024
21025
21026
21027
21028
21029
21030
21031
21032
21033
21034
21035
21036
21037
21038
21039
21040
21041
21042
21043
21044
21045
21046
21047
21048
21049
21050
21051
21052
21053
21054
21055
21056
21057
21058
21059
21060
21061
21062
21063
21064
21065
21066
21067
21068
21069
21070
21071
21072
21073
21074
21075
21076
21077
21078
21079
21080
21081
21082
21083
21084
21085
21086
21087
21088
21089
21090
21091
21092
21093
21094
21095
21096
21097
21098
21099
21100
21101
21102
21103
21104
21105
21106
21107
21108
21109
21110
21111
21112
21113
21114
21115
21116
21117
21118
21119
21120
21121
21122
21123
21124
21125
21126
21127
21128
21129
21130
21131
21132
21133
21134
21135
21136
21137
21138
21139
21140
21141
21142
21143
21144
21145
21146
21147
21148
21149
21150
21151
21152
21153
21154
21155
21156
21157
21158
21159
21160
21161
21162
21163
21164
21165
21166
21167
21168
21169
21170
21171
21172
21173
21174
21175
21176
21177
21178
21179
21180
21181
21182
21183
21184
21185
21186
21187
21188
21189
21190
21191
21192
21193
21194
21195
21196
21197
21198
21199
21200
21201
21202
21203
21204
21205
21206
21207
21208
21209
21210
21211
21212
21213
21214
21215
21216
21217
21218
21219
21220
21221
21222
21223
21224
21225
21226
21227
21228
21229
21230
21231
21232
21233
21234
21235
21236
21237
21238
21239
21240
21241
21242
21243
21244
21245
21246
21247
21248
21249
21250
21251
21252
21253
21254
21255
21256
21257
21258
21259
21260
21261
21262
21263
21264
21265
21266
21267
21268
21269
21270
21271
21272
21273
21274
21275
21276
21277
21278
21279
21280
21281
21282
21283
21284
21285
21286
21287
21288
21289
21290
21291
21292
21293
21294
21295
21296
21297
21298
21299
21300
21301
21302
21303
21304
21305
21306
21307
21308
21309
21310
21311
21312
21313
21314
21315
21316
21317
21318
21319
21320
21321
21322
21323
21324
21325
21326
21327
21328
21329
21330
21331
21332
21333
21334
21335
21336
21337
21338
21339
21340
21341
21342
21343
21344
21345
21346
21347
21348
21349
21350
21351
21352
21353
21354
21355
21356
21357
21358
21359
21360
21361
21362
21363
21364
21365
21366
21367
21368
21369
21370
21371
21372
21373
21374
21375
21376
21377
21378
21379
21380
21381
21382
21383
21384
21385
21386
21387
21388
21389
21390
21391
21392
21393
21394
21395
21396
21397
21398
21399
21400
21401
21402
21403
21404
21405
21406
21407
21408
21409
21410
21411
21412
21413
21414
21415
21416
21417
21418
21419
21420
21421
21422
21423
21424
21425
21426
21427
21428
21429
21430
21431
21432
21433
21434
21435
21436
21437
21438
21439
21440
21441
21442
21443
21444
21445
21446
21447
21448
21449
21450
21451
21452
21453
21454
21455
21456
21457
21458
21459
21460
21461
21462
21463
21464
21465
21466
21467
21468
21469
21470
21471
21472
21473
21474
21475
21476
21477
21478
21479
21480
21481
21482
21483
21484
21485
21486
21487
21488
21489
21490
21491
21492
21493
21494
21495
21496
21497
21498
21499
21500
21501
21502
21503
21504
21505
21506
21507
21508
21509
21510
21511
21512
21513
21514
21515
21516
21517
21518
21519
21520
21521
21522
21523
21524
21525
21526
21527
21528
21529
21530
21531
21532
21533
21534
21535
21536
21537
21538
21539
21540
21541
21542
21543
21544
21545
21546
21547
21548
21549
21550
21551
21552
21553
21554
21555
21556
21557
21558
21559
21560
21561
21562
21563
21564
21565
21566
21567
21568
21569
21570
21571
21572
21573
21574
21575
21576
21577
21578
21579
21580
21581
21582
21583
21584
21585
21586
21587
21588
21589
21590
21591
21592
21593
21594
21595
21596
21597
21598
21599
21600
21601
21602
21603
21604
21605
21606
21607
21608
21609
21610
21611
21612
21613
21614
21615
21616
21617
21618
21619
21620
21621
21622
21623
21624
21625
21626
21627
21628
21629
21630
21631
21632
21633
21634
21635
21636
21637
21638
21639
21640
21641
21642
21643
21644
21645
21646
21647
21648
21649
21650
21651
21652
21653
21654
21655
21656
21657
21658
21659
21660
21661
21662
21663
21664
21665
21666
21667
21668
21669
21670
21671
21672
21673
21674
21675
21676
21677
21678
21679
21680
21681
21682
21683
21684
21685
21686
21687
21688
21689
21690
21691
21692
21693
21694
21695
21696
21697
21698
21699
21700
21701
21702
21703
21704
21705
21706
21707
21708
21709
21710
21711
21712
21713
21714
21715
21716
21717
21718
21719
21720
21721
21722
21723
21724
21725
21726
21727
21728
21729
21730
21731
21732
21733
21734
21735
21736
21737
21738
21739
21740
21741
21742
21743
21744
21745
21746
21747
21748
21749
21750
21751
21752
21753
21754
21755
21756
21757
21758
21759
21760
21761
21762
21763
21764
21765
21766
21767
21768
21769
21770
21771
21772
21773
21774
21775
21776
21777
21778
21779
21780
21781
21782
21783
21784
21785
21786
21787
21788
21789
21790
21791
21792
21793
21794
21795
21796
21797
21798
21799
21800
21801
21802
21803
21804
21805
21806
21807
21808
21809
21810
21811
21812
21813
21814
21815
21816
21817
21818
21819
21820
21821
21822
21823
21824
21825
21826
21827
21828
21829
21830
21831
21832
21833
21834
21835
21836
21837
21838
21839
21840
21841
21842
21843
21844
21845
21846
21847
21848
21849
21850
21851
21852
21853
21854
21855
21856
21857
21858
21859
21860
21861
21862
21863
21864
21865
21866
21867
21868
21869
21870
21871
21872
21873
21874
21875
21876
21877
21878
21879
21880
21881
21882
21883
21884
21885
21886
21887
21888
21889
21890
21891
21892
21893
21894
21895
21896
21897
21898
21899
21900
21901
21902
21903
21904
21905
21906
21907
21908
21909
21910
21911
21912
21913
21914
21915
21916
21917
21918
21919
21920
21921
21922
21923
21924
21925
21926
21927
21928
21929
21930
21931
21932
21933
21934
21935
21936
21937
21938
21939
21940
21941
21942
21943
21944
21945
21946
21947
21948
21949
21950
21951
21952
21953
21954
21955
21956
21957
21958
21959
21960
21961
21962
21963
21964
21965
21966
21967
21968
21969
21970
21971
21972
21973
21974
21975
21976
21977
21978
21979
21980
21981
21982
21983
21984
21985
21986
21987
21988
21989
21990
21991
21992
21993
21994
21995
21996
21997
21998
21999
22000
22001
22002
22003
22004
22005
22006
22007
22008
22009
22010
22011
22012
22013
22014
22015
22016
22017
22018
22019
22020
22021
22022
22023
22024
22025
22026
22027
22028
22029
22030
22031
22032
22033
22034
22035
22036
22037
22038
22039
22040
22041
22042
22043
22044
22045
22046
22047
22048
22049
22050
22051
22052
22053
22054
22055
22056
22057
22058
22059
22060
22061
22062
22063
22064
22065
22066
22067
22068
22069
22070
22071
22072
22073
22074
22075
22076
22077
22078
22079
22080
22081
22082
22083
22084
22085
22086
22087
22088
22089
22090
22091
22092
22093
22094
22095
22096
22097
22098
22099
22100
22101
22102
22103
22104
22105
22106
22107
22108
22109
22110
22111
22112
22113
22114
22115
22116
22117
22118
22119
22120
22121
22122
22123
22124
22125
22126
22127
22128
22129
22130
22131
22132
22133
22134
22135
22136
22137
22138
22139
22140
22141
22142
22143
22144
22145
22146
22147
22148
22149
22150
22151
22152
22153
22154
22155
22156
22157
22158
22159
22160
22161
22162
22163
22164
22165
22166
22167
22168
22169
22170
22171
22172
22173
22174
22175
22176
22177
22178
22179
22180
22181
22182
22183
22184
22185
22186
22187
22188
22189
22190
22191
22192
22193
22194
22195
22196
22197
22198
22199
22200
22201
22202
22203
22204
22205
22206
22207
22208
22209
22210
22211
22212
22213
22214
22215
22216
22217
22218
22219
22220
22221
22222
22223
22224
22225
22226
22227
22228
22229
22230
22231
22232
22233
22234
22235
22236
22237
22238
22239
22240
22241
22242
22243
22244
22245
22246
22247
22248
22249
22250
22251
22252
22253
22254
22255
22256
22257
22258
22259
22260
22261
22262
22263
22264
22265
22266
22267
22268
22269
22270
22271
22272
22273
22274
22275
22276
22277
22278
22279
22280
22281
22282
22283
22284
22285
22286
22287
22288
22289
22290
22291
22292
22293
22294
22295
22296
22297
22298
22299
22300
22301
22302
22303
22304
22305
22306
22307
22308
22309
22310
22311
22312
22313
22314
22315
22316
22317
22318
22319
22320
22321
22322
22323
22324
22325
22326
22327
22328
22329
22330
22331
22332
22333
22334
22335
22336
22337
22338
22339
22340
22341
22342
22343
22344
22345
22346
22347
22348
22349
22350
22351
22352
22353
22354
22355
22356
22357
22358
22359
22360
22361
22362
22363
22364
22365
22366
22367
22368
22369
22370
22371
22372
22373
22374
22375
22376
22377
22378
22379
22380
22381
22382
22383
22384
22385
22386
22387
22388
22389
22390
22391
22392
22393
22394
22395
22396
22397
22398
22399
22400
22401
22402
22403
22404
22405
22406
22407
22408
22409
22410
22411
22412
22413
22414
22415
22416
22417
22418
22419
22420
22421
22422
22423
22424
22425
22426
22427
22428
22429
22430
22431
22432
22433
22434
22435
22436
22437
22438
22439
22440
22441
22442
22443
22444
22445
22446
22447
22448
22449
22450
22451
22452
22453
22454
22455
22456
22457
22458
22459
22460
22461
22462
22463
22464
22465
22466
22467
22468
22469
22470
22471
22472
22473
22474
22475
22476
22477
22478
22479
22480
22481
22482
22483
22484
22485
22486
22487
22488
22489
22490
22491
22492
22493
22494
22495
22496
22497
22498
22499
22500
22501
22502
22503
22504
22505
22506
22507
22508
22509
22510
22511
22512
22513
22514
22515
22516
22517
22518
22519
22520
22521
22522
22523
22524
22525
22526
22527
22528
22529
22530
22531
22532
22533
22534
22535
22536
22537
22538
22539
22540
22541
22542
22543
22544
22545
22546
22547
22548
22549
22550
22551
22552
22553
22554
22555
22556
22557
22558
22559
22560
22561
22562
22563
22564
22565
22566
22567
22568
22569
22570
22571
22572
22573
22574
22575
22576
22577
22578
22579
22580
22581
22582
22583
22584
22585
22586
22587
22588
22589
22590
22591
22592
22593
22594
22595
22596
22597
22598
22599
22600
22601
22602
22603
22604
22605
22606
22607
22608
22609
22610
22611
22612
22613
22614
22615
22616
22617
22618
22619
22620
22621
22622
22623
22624
22625
22626
22627
22628
22629
22630
22631
22632
22633
22634
22635
22636
22637
22638
22639
22640
22641
22642
22643
22644
22645
22646
22647
22648
22649
22650
22651
22652
22653
22654
22655
22656
22657
22658
22659
22660
22661
22662
22663
22664
22665
22666
22667
22668
22669
22670
22671
22672
22673
22674
22675
22676
22677
22678
22679
22680
22681
22682
22683
22684
22685
22686
22687
22688
22689
22690
22691
22692
22693
22694
22695
22696
22697
22698
22699
22700
22701
22702
22703
22704
22705
22706
22707
22708
22709
22710
22711
22712
22713
22714
22715
22716
22717
22718
22719
22720
22721
22722
22723
22724
22725
22726
22727
22728
22729
22730
22731
22732
22733
22734
22735
22736
22737
22738
22739
22740
22741
22742
22743
22744
22745
22746
22747
22748
22749
22750
22751
22752
22753
22754
22755
22756
22757
22758
22759
22760
22761
22762
22763
22764
22765
22766
22767
22768
22769
22770
22771
22772
22773
22774
22775
22776
22777
22778
22779
22780
22781
22782
22783
22784
22785
22786
22787
22788
22789
22790
22791
22792
22793
22794
22795
22796
22797
22798
22799
22800
22801
22802
22803
22804
22805
22806
22807
22808
22809
22810
22811
22812
22813
22814
22815
22816
22817
22818
22819
22820
22821
22822
22823
22824
22825
22826
22827
22828
22829
22830
22831
22832
22833
22834
22835
22836
22837
22838
22839
22840
22841
22842
22843
22844
22845
22846
22847
22848
22849
22850
22851
22852
22853
22854
22855
22856
22857
22858
22859
22860
22861
22862
22863
22864
22865
22866
22867
22868
22869
22870
22871
22872
22873
22874
22875
22876
22877
22878
22879
22880
22881
22882
22883
22884
22885
22886
22887
22888
22889
22890
22891
22892
22893
22894
22895
22896
22897
22898
22899
22900
22901
22902
22903
22904
22905
22906
22907
22908
22909
22910
22911
22912
22913
22914
22915
22916
22917
22918
22919
22920
22921
22922
22923
22924
22925
22926
22927
22928
22929
22930
22931
22932
22933
22934
22935
22936
22937
22938
22939
22940
22941
22942
22943
22944
22945
22946
22947
22948
22949
22950
22951
22952
22953
22954
22955
22956
22957
22958
22959
22960
22961
22962
22963
22964
22965
22966
22967
22968
22969
22970
22971
22972
22973
22974
22975
22976
22977
22978
22979
22980
22981
22982
22983
22984
22985
22986
22987
22988
22989
22990
22991
22992
22993
22994
22995
22996
22997
22998
22999
23000
23001
23002
23003
23004
23005
23006
23007
23008
23009
23010
23011
23012
23013
23014
23015
23016
23017
23018
23019
23020
23021
23022
23023
23024
23025
23026
23027
23028
23029
23030
23031
23032
23033
23034
23035
23036
23037
23038
23039
23040
23041
23042
23043
23044
23045
23046
23047
23048
23049
23050
23051
23052
23053
23054
23055
23056
23057
23058
23059
23060
23061
23062
23063
23064
23065
23066
23067
23068
23069
23070
23071
23072
23073
23074
23075
23076
23077
23078
23079
23080
23081
23082
23083
23084
23085
23086
23087
23088
23089
23090
23091
23092
23093
23094
23095
23096
23097
23098
23099
23100
23101
23102
23103
23104
23105
23106
23107
23108
23109
23110
23111
23112
23113
23114
23115
23116
23117
23118
23119
23120
23121
23122
23123
23124
23125
23126
23127
23128
23129
23130
23131
23132
23133
23134
23135
23136
23137
23138
23139
23140
23141
23142
23143
23144
23145
23146
23147
23148
23149
23150
23151
23152
23153
23154
23155
23156
23157
23158
23159
23160
23161
23162
23163
23164
23165
23166
23167
23168
23169
23170
23171
23172
23173
23174
23175
23176
23177
23178
23179
23180
23181
23182
23183
23184
23185
23186
23187
23188
23189
23190
23191
23192
23193
23194
23195
23196
23197
23198
23199
23200
23201
23202
23203
23204
23205
23206
23207
23208
23209
23210
23211
23212
23213
23214
23215
23216
23217
23218
23219
23220
23221
23222
23223
23224
23225
23226
23227
23228
23229
23230
23231
23232
23233
23234
23235
23236
23237
23238
23239
23240
23241
23242
23243
23244
23245
23246
23247
23248
23249
23250
23251
23252
23253
23254
23255
23256
23257
23258
23259
23260
23261
23262
23263
23264
23265
23266
23267
23268
23269
23270
23271
23272
23273
23274
23275
23276
23277
23278
23279
23280
23281
23282
23283
23284
23285
23286
23287
23288
23289
23290
23291
23292
23293
23294
23295
23296
23297
23298
23299
23300
23301
23302
23303
23304
23305
23306
23307
23308
23309
23310
23311
23312
23313
23314
23315
23316
23317
23318
23319
23320
23321
23322
23323
23324
23325
23326
23327
23328
23329
23330
23331
23332
23333
23334
23335
23336
23337
23338
23339
23340
23341
23342
23343
23344
23345
23346
23347
23348
23349
23350
23351
23352
23353
23354
23355
23356
23357
23358
23359
23360
23361
23362
23363
23364
23365
23366
23367
23368
23369
23370
23371
23372
23373
23374
23375
23376
23377
23378
23379
23380
23381
23382
23383
23384
23385
23386
23387
23388
23389
23390
23391
23392
23393
23394
23395
23396
23397
23398
23399
23400
23401
23402
23403
23404
23405
23406
23407
23408
23409
23410
23411
23412
23413
23414
23415
23416
23417
23418
23419
23420
23421
23422
23423
23424
23425
23426
23427
23428
23429
23430
23431
23432
23433
23434
23435
23436
23437
23438
23439
23440
23441
23442
23443
23444
23445
23446
23447
23448
23449
23450
23451
23452
23453
23454
23455
23456
23457
23458
23459
23460
23461
23462
23463
23464
23465
23466
23467
23468
23469
23470
23471
23472
23473
23474
23475
23476
23477
23478
23479
23480
23481
23482
23483
23484
23485
23486
23487
23488
23489
23490
23491
23492
23493
23494
23495
23496
23497
23498
23499
23500
23501
23502
23503
23504
23505
23506
23507
23508
23509
23510
23511
23512
23513
23514
23515
23516
23517
23518
23519
23520
23521
23522
23523
23524
23525
23526
23527
23528
23529
23530
23531
23532
23533
23534
23535
23536
23537
23538
23539
23540
23541
23542
23543
23544
23545
23546
23547
23548
23549
23550
23551
23552
23553
23554
23555
23556
23557
23558
23559
23560
23561
23562
23563
23564
23565
23566
23567
23568
23569
23570
23571
23572
23573
23574
23575
23576
23577
23578
23579
23580
23581
23582
23583
23584
23585
23586
23587
23588
23589
23590
23591
23592
23593
23594
23595
23596
23597
23598
23599
23600
23601
23602
23603
23604
23605
23606
23607
23608
23609
23610
23611
23612
23613
23614
23615
23616
23617
23618
23619
23620
23621
23622
23623
23624
23625
23626
23627
23628
23629
23630
23631
23632
23633
23634
23635
23636
23637
23638
23639
23640
23641
23642
23643
23644
23645
23646
23647
23648
23649
23650
23651
23652
23653
23654
23655
23656
23657
23658
23659
23660
23661
23662
23663
23664
23665
23666
23667
23668
23669
23670
23671
23672
23673
23674
23675
23676
23677
23678
23679
23680
23681
23682
23683
23684
23685
23686
23687
23688
23689
23690
23691
23692
23693
23694
23695
23696
23697
23698
23699
23700
23701
23702
23703
23704
23705
23706
23707
23708
23709
23710
23711
23712
23713
23714
23715
23716
23717
23718
23719
23720
23721
23722
23723
23724
23725
23726
23727
23728
23729
23730
23731
23732
23733
23734
23735
23736
23737
23738
23739
23740
23741
23742
23743
23744
23745
23746
23747
23748
23749
23750
23751
23752
23753
23754
23755
23756
23757
23758
23759
23760
23761
23762
23763
23764
23765
23766
23767
23768
23769
23770
23771
23772
23773
23774
23775
23776
23777
23778
23779
23780
23781
23782
23783
23784
23785
23786
23787
23788
23789
23790
23791
23792
23793
23794
23795
23796
23797
23798
23799
23800
23801
23802
23803
23804
23805
23806
23807
23808
23809
23810
23811
23812
23813
23814
23815
23816
23817
23818
23819
23820
23821
23822
23823
23824
23825
23826
23827
23828
23829
23830
23831
23832
23833
23834
23835
23836
23837
23838
23839
23840
23841
23842
23843
23844
23845
23846
23847
23848
23849
23850
23851
23852
23853
23854
23855
23856
23857
23858
23859
23860
23861
23862
23863
23864
23865
23866
23867
23868
23869
23870
23871
23872
23873
23874
23875
23876
23877
23878
23879
23880
23881
23882
23883
23884
23885
23886
23887
23888
23889
23890
23891
23892
23893
23894
23895
23896
23897
23898
23899
23900
23901
23902
23903
23904
23905
23906
23907
23908
23909
23910
23911
23912
23913
23914
23915
23916
23917
23918
23919
23920
23921
23922
23923
23924
23925
23926
23927
23928
23929
23930
23931
23932
23933
23934
23935
23936
23937
23938
23939
23940
23941
23942
23943
23944
23945
23946
23947
23948
23949
23950
23951
23952
23953
23954
23955
23956
23957
23958
23959
23960
23961
23962
23963
23964
23965
23966
23967
23968
23969
23970
23971
23972
23973
23974
23975
23976
23977
23978
23979
23980
23981
23982
23983
23984
23985
23986
23987
23988
23989
23990
23991
23992
23993
23994
23995
23996
23997
23998
23999
24000
24001
24002
24003
24004
24005
24006
24007
24008
24009
24010
24011
24012
24013
24014
24015
24016
24017
24018
24019
24020
24021
24022
24023
24024
24025
24026
24027
24028
24029
24030
24031
24032
24033
24034
24035
24036
24037
24038
24039
24040
24041
24042
24043
24044
24045
24046
24047
24048
24049
24050
24051
24052
24053
24054
24055
24056
24057
24058
24059
24060
24061
24062
24063
24064
24065
24066
24067
24068
24069
24070
24071
24072
24073
24074
24075
24076
24077
24078
24079
24080
24081
24082
24083
24084
24085
24086
24087
24088
24089
24090
24091
24092
24093
24094
24095
24096
24097
24098
24099
24100
24101
24102
24103
24104
24105
24106
24107
24108
24109
24110
24111
24112
24113
24114
24115
24116
24117
24118
24119
24120
24121
24122
24123
24124
24125
24126
24127
24128
24129
24130
24131
24132
24133
24134
24135
24136
24137
24138
24139
24140
24141
24142
24143
24144
24145
24146
24147
24148
24149
24150
24151
24152
24153
24154
24155
24156
24157
24158
24159
24160
24161
24162
24163
24164
24165
24166
24167
24168
24169
24170
24171
24172
24173
24174
24175
24176
24177
24178
24179
24180
24181
24182
24183
24184
24185
24186
24187
24188
24189
24190
24191
24192
24193
24194
24195
24196
24197
24198
24199
24200
24201
24202
24203
24204
24205
24206
24207
24208
24209
24210
24211
24212
24213
24214
24215
24216
24217
24218
24219
24220
24221
24222
24223
24224
24225
24226
24227
24228
24229
24230
24231
24232
24233
24234
24235
24236
24237
24238
24239
24240
24241
24242
24243
24244
24245
24246
24247
24248
24249
24250
24251
24252
24253
24254
24255
24256
24257
24258
24259
24260
24261
24262
24263
24264
24265
24266
24267
24268
24269
24270
24271
24272
24273
24274
24275
24276
24277
24278
24279
24280
24281
24282
24283
24284
24285
24286
24287
24288
24289
24290
24291
24292
24293
24294
24295
24296
24297
24298
24299
24300
24301
24302
24303
24304
24305
24306
24307
24308
24309
24310
24311
24312
24313
24314
24315
24316
24317
24318
24319
24320
24321
24322
24323
24324
24325
24326
24327
24328
24329
24330
24331
24332
24333
24334
24335
24336
24337
24338
24339
24340
24341
24342
24343
24344
24345
24346
24347
24348
24349
24350
24351
24352
24353
24354
24355
24356
24357
24358
24359
24360
24361
24362
24363
24364
24365
24366
24367
24368
24369
24370
24371
24372
24373
24374
24375
24376
24377
24378
24379
24380
24381
24382
24383
24384
24385
24386
24387
24388
24389
24390
24391
24392
24393
24394
24395
24396
24397
24398
24399
24400
24401
24402
24403
24404
24405
24406
24407
24408
24409
24410
24411
24412
24413
24414
24415
24416
24417
24418
24419
24420
24421
24422
24423
24424
24425
24426
24427
24428
24429
24430
24431
24432
24433
24434
24435
24436
24437
24438
24439
24440
24441
24442
24443
24444
24445
24446
24447
24448
24449
24450
24451
24452
24453
24454
24455
24456
24457
24458
24459
24460
24461
24462
24463
24464
24465
24466
24467
24468
24469
24470
24471
24472
24473
24474
24475
24476
24477
24478
24479
24480
24481
24482
24483
24484
24485
24486
24487
24488
24489
24490
24491
24492
24493
24494
24495
24496
24497
24498
24499
24500
24501
24502
24503
24504
24505
24506
24507
24508
24509
24510
24511
24512
24513
24514
24515
24516
24517
24518
24519
24520
24521
24522
24523
24524
24525
24526
24527
24528
24529
24530
24531
24532
24533
24534
24535
24536
24537
24538
24539
24540
24541
24542
24543
24544
24545
24546
24547
24548
24549
24550
24551
24552
24553
24554
24555
24556
24557
24558
24559
24560
24561
24562
24563
24564
24565
24566
24567
24568
24569
24570
24571
24572
24573
24574
24575
24576
24577
24578
24579
24580
24581
24582
24583
24584
24585
24586
24587
24588
24589
24590
24591
24592
24593
24594
24595
24596
24597
24598
24599
24600
24601
24602
24603
24604
24605
24606
24607
24608
24609
24610
24611
24612
24613
24614
24615
24616
24617
24618
24619
24620
24621
24622
24623
24624
24625
24626
24627
24628
24629
24630
24631
24632
24633
24634
24635
24636
24637
24638
24639
24640
24641
24642
24643
24644
24645
24646
24647
24648
24649
24650
24651
24652
24653
24654
24655
24656
24657
24658
24659
24660
24661
24662
24663
24664
24665
24666
24667
24668
24669
24670
24671
24672
24673
24674
24675
24676
24677
24678
24679
24680
24681
24682
24683
24684
24685
24686
24687
24688
24689
24690
24691
24692
24693
24694
24695
24696
24697
24698
24699
24700
24701
24702
24703
24704
24705
24706
24707
24708
24709
24710
24711
24712
24713
24714
24715
24716
24717
24718
24719
24720
24721
24722
24723
24724
24725
24726
24727
24728
24729
24730
24731
24732
24733
24734
24735
24736
24737
24738
24739
24740
24741
24742
24743
24744
24745
24746
24747
24748
24749
24750
24751
24752
24753
24754
24755
24756
24757
24758
24759
24760
24761
24762
24763
24764
24765
24766
24767
24768
24769
24770
24771
24772
24773
24774
24775
24776
24777
24778
24779
24780
24781
24782
24783
24784
24785
24786
24787
24788
24789
24790
24791
24792
24793
24794
24795
24796
24797
24798
24799
24800
24801
24802
24803
24804
24805
24806
24807
24808
24809
24810
24811
24812
24813
24814
24815
24816
24817
24818
24819
24820
24821
24822
24823
24824
24825
24826
24827
24828
24829
24830
24831
24832
24833
24834
24835
24836
24837
24838
24839
24840
24841
24842
24843
24844
24845
24846
24847
24848
24849
24850
24851
24852
24853
24854
24855
24856
24857
24858
24859
24860
24861
24862
24863
24864
24865
24866
24867
24868
24869
24870
24871
24872
24873
24874
24875
24876
24877
24878
24879
24880
24881
24882
24883
24884
24885
24886
24887
24888
24889
24890
24891
24892
24893
24894
24895
24896
24897
24898
24899
24900
24901
24902
24903
24904
24905
24906
24907
24908
24909
24910
24911
24912
24913
24914
24915
24916
24917
24918
24919
24920
24921
24922
24923
24924
24925
24926
24927
24928
24929
24930
24931
24932
24933
24934
24935
24936
24937
24938
24939
24940
24941
24942
24943
24944
24945
24946
24947
24948
24949
24950
24951
24952
24953
24954
24955
24956
24957
24958
24959
24960
24961
24962
24963
24964
24965
24966
24967
24968
24969
24970
24971
24972
24973
24974
24975
24976
24977
24978
24979
24980
24981
24982
24983
24984
24985
24986
24987
24988
24989
24990
24991
24992
24993
24994
24995
24996
24997
24998
24999
25000
25001
25002
25003
25004
25005
25006
25007
25008
25009
25010
25011
25012
25013
25014
25015
25016
25017
25018
25019
25020
25021
25022
25023
25024
25025
25026
25027
25028
25029
25030
25031
25032
25033
25034
25035
25036
25037
25038
25039
25040
25041
25042
25043
25044
25045
25046
25047
25048
25049
25050
25051
25052
25053
25054
25055
25056
25057
25058
25059
25060
25061
25062
25063
25064
25065
25066
25067
25068
25069
25070
25071
25072
25073
25074
25075
25076
25077
25078
25079
25080
25081
25082
25083
25084
25085
25086
25087
25088
25089
25090
25091
25092
25093
25094
25095
25096
25097
25098
25099
25100
25101
25102
25103
25104
25105
25106
25107
25108
25109
25110
25111
25112
25113
25114
25115
25116
25117
25118
25119
25120
25121
25122
25123
25124
25125
25126
25127
25128
25129
25130
25131
25132
25133
25134
25135
25136
25137
25138
25139
25140
25141
25142
25143
25144
25145
25146
25147
25148
25149
25150
25151
25152
25153
25154
25155
25156
25157
25158
25159
25160
25161
25162
25163
25164
25165
25166
25167
25168
25169
25170
25171
25172
25173
25174
25175
25176
25177
25178
25179
25180
25181
25182
25183
25184
25185
25186
25187
25188
25189
25190
25191
25192
25193
25194
25195
25196
25197
25198
25199
25200
25201
25202
25203
25204
25205
25206
25207
25208
25209
25210
25211
25212
25213
25214
25215
25216
25217
25218
25219
25220
25221
25222
25223
25224
25225
25226
25227
25228
25229
25230
25231
25232
25233
25234
25235
25236
25237
25238
25239
25240
25241
25242
25243
25244
25245
25246
25247
25248
25249
25250
25251
25252
25253
25254
25255
25256
25257
25258
25259
25260
25261
25262
25263
25264
25265
25266
25267
25268
25269
25270
25271
25272
25273
25274
25275
25276
25277
25278
25279
25280
25281
25282
25283
25284
25285
25286
25287
25288
25289
25290
25291
25292
25293
25294
25295
25296
25297
25298
25299
25300
25301
25302
25303
25304
25305
25306
25307
25308
25309
25310
25311
25312
25313
25314
25315
25316
25317
25318
25319
25320
25321
25322
25323
25324
25325
25326
25327
25328
25329
25330
25331
25332
25333
25334
25335
25336
25337
25338
25339
25340
25341
25342
25343
25344
25345
25346
25347
25348
25349
25350
25351
25352
25353
25354
25355
25356
25357
25358
25359
25360
25361
25362
25363
25364
25365
25366
25367
25368
25369
25370
25371
25372
25373
25374
25375
25376
25377
25378
25379
25380
25381
25382
25383
25384
25385
25386
25387
25388
25389
25390
25391
25392
25393
25394
25395
25396
25397
25398
25399
25400
25401
25402
25403
25404
25405
25406
25407
25408
25409
25410
25411
25412
25413
25414
25415
25416
25417
25418
25419
25420
25421
25422
25423
25424
25425
25426
25427
25428
25429
25430
25431
25432
25433
25434
25435
25436
25437
25438
25439
25440
25441
25442
25443
25444
25445
25446
25447
25448
25449
25450
25451
25452
25453
25454
25455
25456
25457
25458
25459
25460
25461
25462
25463
25464
25465
25466
25467
25468
25469
25470
25471
25472
25473
25474
25475
25476
25477
25478
25479
25480
25481
25482
25483
25484
25485
25486
25487
25488
25489
25490
25491
25492
25493
25494
25495
25496
25497
25498
25499
25500
25501
25502
25503
25504
25505
25506
25507
25508
25509
25510
25511
25512
25513
25514
25515
25516
25517
25518
25519
25520
25521
25522
25523
25524
25525
25526
25527
25528
25529
25530
25531
25532
25533
25534
25535
25536
25537
25538
25539
25540
25541
25542
25543
25544
25545
25546
25547
25548
25549
25550
25551
25552
25553
25554
25555
25556
25557
25558
25559
25560
25561
25562
25563
25564
25565
25566
25567
25568
25569
25570
25571
25572
25573
25574
25575
25576
25577
25578
25579
25580
25581
25582
25583
25584
25585
25586
25587
25588
25589
25590
25591
25592
25593
25594
25595
25596
25597
25598
25599
25600
25601
25602
25603
25604
25605
25606
25607
25608
25609
25610
25611
25612
25613
25614
25615
25616
25617
25618
25619
25620
25621
25622
25623
25624
25625
25626
25627
25628
25629
25630
25631
25632
25633
25634
25635
25636
25637
25638
25639
25640
25641
25642
25643
25644
25645
25646
25647
25648
25649
25650
25651
25652
25653
25654
25655
25656
25657
25658
25659
25660
25661
25662
25663
25664
25665
25666
25667
25668
25669
25670
25671
25672
25673
25674
25675
25676
25677
25678
25679
25680
25681
25682
25683
25684
25685
25686
25687
25688
25689
25690
25691
25692
25693
25694
25695
25696
25697
25698
25699
25700
25701
25702
25703
25704
25705
25706
25707
25708
25709
25710
25711
25712
25713
25714
25715
25716
25717
25718
25719
25720
25721
25722
25723
25724
25725
25726
25727
25728
25729
25730
25731
25732
25733
25734
25735
25736
25737
25738
25739
25740
25741
25742
25743
25744
25745
25746
25747
25748
25749
25750
25751
25752
25753
25754
25755
25756
25757
25758
25759
25760
25761
25762
25763
25764
25765
25766
25767
25768
25769
25770
25771
25772
25773
25774
25775
25776
25777
25778
25779
25780
25781
25782
25783
25784
25785
25786
25787
25788
25789
25790
25791
25792
25793
25794
25795
25796
25797
25798
25799
25800
25801
25802
25803
25804
25805
25806
25807
25808
25809
25810
25811
25812
25813
25814
25815
25816
25817
25818
25819
25820
25821
25822
25823
25824
25825
25826
25827
25828
25829
25830
25831
25832
25833
25834
25835
25836
25837
25838
25839
25840
25841
25842
25843
25844
25845
25846
25847
25848
25849
25850
25851
25852
25853
25854
25855
25856
25857
25858
25859
25860
25861
25862
25863
25864
25865
25866
25867
25868
25869
25870
25871
25872
25873
25874
25875
25876
25877
25878
25879
25880
25881
25882
25883
25884
25885
25886
25887
25888
25889
25890
25891
25892
25893
25894
25895
25896
25897
25898
25899
25900
25901
25902
25903
25904
25905
25906
25907
25908
25909
25910
25911
25912
25913
25914
25915
25916
25917
25918
25919
25920
25921
25922
25923
25924
25925
25926
25927
25928
25929
25930
25931
25932
25933
25934
25935
25936
25937
25938
25939
25940
25941
25942
25943
25944
25945
25946
25947
25948
25949
25950
25951
25952
25953
25954
25955
25956
25957
25958
25959
25960
25961
25962
25963
25964
25965
25966
25967
25968
25969
25970
25971
25972
25973
25974
25975
25976
25977
25978
25979
25980
25981
25982
25983
25984
25985
25986
25987
25988
25989
25990
25991
25992
25993
25994
25995
25996
25997
25998
25999
26000
26001
26002
26003
26004
26005
26006
26007
26008
26009
26010
26011
26012
26013
26014
26015
26016
26017
26018
26019
26020
26021
26022
26023
26024
26025
26026
26027
26028
26029
26030
26031
26032
26033
26034
26035
26036
26037
26038
26039
26040
26041
26042
26043
26044
26045
26046
26047
26048
26049
26050
26051
26052
26053
26054
26055
26056
26057
26058
26059
26060
26061
26062
26063
26064
26065
26066
26067
26068
26069
26070
26071
26072
26073
26074
26075
26076
26077
26078
26079
26080
26081
26082
26083
26084
26085
26086
26087
26088
26089
26090
26091
26092
26093
26094
26095
26096
26097
26098
26099
26100
26101
26102
26103
26104
26105
26106
26107
26108
26109
26110
26111
26112
26113
26114
26115
26116
26117
26118
26119
26120
26121
26122
26123
26124
26125
26126
26127
26128
26129
26130
26131
26132
26133
26134
26135
26136
26137
26138
26139
26140
26141
26142
26143
26144
26145
26146
26147
26148
26149
26150
26151
26152
26153
26154
26155
26156
26157
26158
26159
26160
26161
26162
26163
26164
26165
26166
26167
26168
26169
26170
26171
26172
26173
26174
26175
26176
26177
26178
26179
26180
26181
26182
26183
26184
26185
26186
26187
26188
26189
26190
26191
26192
26193
26194
26195
26196
26197
26198
26199
26200
26201
26202
26203
26204
26205
26206
26207
26208
26209
26210
26211
26212
26213
26214
26215
26216
26217
26218
26219
26220
26221
26222
26223
26224
26225
26226
26227
26228
26229
26230
26231
26232
26233
26234
26235
26236
26237
26238
26239
26240
26241
26242
26243
26244
26245
26246
26247
26248
26249
26250
26251
26252
26253
26254
26255
26256
26257
26258
26259
26260
26261
26262
26263
26264
26265
26266
26267
26268
26269
26270
26271
26272
26273
26274
26275
26276
26277
26278
26279
26280
26281
26282
26283
26284
26285
26286
26287
26288
26289
26290
26291
26292
26293
26294
26295
26296
26297
26298
26299
26300
26301
26302
26303
26304
26305
26306
26307
26308
26309
26310
26311
26312
26313
26314
26315
26316
26317
26318
26319
26320
26321
26322
26323
26324
26325
26326
26327
26328
26329
26330
26331
26332
26333
26334
26335
26336
26337
26338
26339
26340
26341
26342
26343
26344
26345
26346
26347
26348
26349
26350
26351
26352
26353
26354
26355
26356
26357
26358
26359
26360
26361
26362
26363
26364
26365
26366
26367
26368
26369
26370
26371
26372
26373
26374
26375
26376
26377
26378
26379
26380
26381
26382
26383
26384
26385
26386
26387
26388
26389
26390
26391
26392
26393
26394
26395
26396
26397
26398
26399
26400
26401
26402
26403
26404
26405
26406
26407
26408
26409
26410
26411
26412
26413
26414
26415
26416
26417
26418
26419
26420
26421
26422
26423
26424
26425
26426
26427
26428
26429
26430
26431
26432
26433
26434
26435
26436
26437
26438
26439
26440
26441
26442
26443
26444
26445
26446
26447
26448
26449
26450
26451
26452
26453
26454
26455
26456
26457
26458
26459
26460
26461
26462
26463
26464
26465
26466
26467
26468
26469
26470
26471
26472
26473
26474
26475
26476
26477
26478
26479
26480
26481
26482
26483
26484
26485
26486
26487
26488
26489
26490
26491
26492
26493
26494
26495
26496
26497
26498
26499
26500
26501
26502
26503
26504
26505
26506
26507
26508
26509
26510
26511
26512
26513
26514
26515
26516
26517
26518
26519
26520
26521
26522
26523
26524
26525
26526
26527
26528
26529
26530
26531
26532
26533
26534
26535
26536
26537
26538
26539
26540
26541
26542
26543
26544
26545
26546
26547
26548
26549
26550
26551
26552
26553
26554
26555
26556
26557
26558
26559
26560
26561
26562
26563
26564
26565
26566
26567
26568
26569
26570
26571
26572
26573
26574
26575
26576
26577
26578
26579
26580
26581
26582
26583
26584
26585
26586
26587
26588
26589
26590
26591
26592
26593
26594
26595
26596
26597
26598
26599
26600
26601
26602
26603
26604
26605
26606
26607
26608
26609
26610
26611
26612
26613
26614
26615
26616
26617
26618
26619
26620
26621
26622
26623
26624
26625
26626
26627
26628
26629
26630
26631
26632
26633
26634
26635
26636
26637
26638
26639
26640
26641
26642
26643
26644
26645
26646
26647
26648
26649
26650
26651
26652
26653
26654
26655
26656
26657
26658
26659
26660
26661
26662
26663
26664
26665
26666
26667
26668
26669
26670
26671
26672
26673
26674
26675
26676
26677
26678
26679
26680
26681
26682
26683
26684
26685
26686
26687
26688
26689
26690
26691
26692
26693
26694
26695
26696
26697
26698
26699
26700
26701
26702
26703
26704
26705
26706
26707
26708
26709
26710
26711
26712
26713
26714
26715
26716
26717
26718
26719
26720
26721
26722
26723
26724
26725
26726
26727
26728
26729
26730
26731
26732
26733
26734
26735
26736
26737
26738
26739
26740
26741
26742
26743
26744
26745
26746
26747
26748
26749
26750
26751
26752
26753
26754
26755
26756
26757
26758
26759
26760
26761
26762
26763
26764
26765
26766
26767
26768
26769
26770
26771
26772
26773
26774
26775
26776
26777
26778
26779
26780
26781
26782
26783
26784
26785
26786
26787
26788
26789
26790
26791
26792
26793
26794
26795
26796
26797
26798
26799
26800
26801
26802
26803
26804
26805
26806
26807
26808
26809
26810
26811
26812
26813
26814
26815
26816
26817
26818
26819
26820
26821
26822
26823
26824
26825
26826
26827
26828
26829
26830
26831
26832
26833
26834
26835
26836
26837
26838
26839
26840
26841
26842
26843
26844
26845
26846
26847
26848
26849
26850
26851
26852
26853
26854
26855
26856
26857
26858
26859
26860
26861
26862
26863
26864
26865
26866
26867
26868
26869
26870
26871
26872
26873
26874
26875
26876
26877
26878
26879
26880
26881
26882
26883
26884
26885
26886
26887
26888
26889
26890
26891
26892
26893
26894
26895
26896
26897
26898
26899
26900
26901
26902
26903
26904
26905
26906
26907
26908
26909
26910
26911
26912
26913
26914
26915
26916
26917
26918
26919
26920
26921
26922
26923
26924
26925
26926
26927
26928
26929
26930
26931
26932
26933
26934
26935
26936
26937
26938
26939
26940
26941
26942
26943
26944
26945
26946
26947
26948
26949
26950
26951
26952
26953
26954
26955
26956
26957
26958
26959
26960
26961
26962
26963
26964
26965
26966
26967
26968
26969
26970
26971
26972
26973
26974
26975
26976
26977
26978
26979
26980
26981
26982
26983
26984
26985
26986
26987
26988
26989
26990
26991
26992
26993
26994
26995
26996
26997
26998
26999
27000
27001
27002
27003
27004
27005
27006
27007
27008
27009
27010
27011
27012
27013
27014
27015
27016
27017
27018
27019
27020
27021
27022
27023
27024
27025
27026
27027
27028
27029
27030
27031
27032
27033
27034
27035
27036
27037
27038
27039
27040
27041
27042
27043
27044
27045
27046
27047
27048
27049
27050
27051
27052
27053
27054
27055
27056
27057
27058
27059
27060
27061
27062
27063
27064
27065
27066
27067
27068
27069
27070
27071
27072
27073
27074
27075
27076
27077
27078
27079
27080
27081
27082
27083
27084
27085
27086
27087
27088
27089
27090
27091
27092
27093
27094
27095
27096
27097
27098
27099
27100
27101
27102
27103
27104
27105
27106
27107
27108
27109
27110
27111
27112
27113
27114
27115
27116
27117
27118
27119
27120
27121
27122
27123
27124
27125
27126
27127
27128
27129
27130
27131
27132
27133
27134
27135
27136
27137
27138
27139
27140
27141
27142
27143
27144
27145
27146
27147
27148
27149
27150
27151
27152
27153
27154
27155
27156
27157
27158
27159
27160
27161
27162
27163
27164
27165
27166
27167
27168
27169
27170
27171
27172
27173
27174
27175
27176
27177
27178
27179
27180
27181
27182
27183
27184
27185
27186
27187
27188
27189
27190
27191
27192
27193
27194
27195
27196
27197
27198
27199
27200
27201
27202
27203
27204
27205
27206
27207
27208
27209
27210
27211
27212
27213
27214
27215
27216
27217
27218
27219
27220
27221
27222
27223
27224
27225
27226
27227
27228
27229
27230
27231
27232
27233
27234
27235
27236
27237
27238
27239
27240
27241
27242
27243
27244
27245
27246
27247
27248
27249
27250
27251
27252
27253
27254
27255
27256
27257
27258
27259
27260
27261
27262
27263
27264
27265
27266
27267
27268
27269
27270
27271
27272
27273
27274
27275
27276
27277
27278
27279
27280
27281
27282
27283
27284
27285
27286
27287
27288
27289
27290
27291
27292
27293
27294
27295
27296
27297
27298
27299
27300
27301
27302
27303
27304
27305
27306
27307
27308
27309
27310
27311
27312
27313
27314
27315
27316
27317
27318
27319
27320
27321
27322
27323
27324
27325
27326
27327
27328
27329
27330
27331
27332
27333
27334
27335
27336
27337
27338
27339
27340
27341
27342
27343
27344
27345
27346
27347
27348
27349
27350
27351
27352
27353
27354
27355
27356
27357
27358
27359
27360
27361
27362
27363
27364
27365
27366
27367
27368
27369
27370
27371
27372
27373
27374
27375
27376
27377
27378
27379
27380
27381
27382
27383
27384
27385
27386
27387
27388
27389
27390
27391
27392
27393
27394
27395
27396
27397
27398
27399
27400
27401
27402
27403
27404
27405
27406
27407
27408
27409
27410
27411
27412
27413
27414
27415
27416
27417
27418
27419
27420
27421
27422
27423
27424
27425
27426
27427
27428
27429
27430
27431
27432
27433
27434
27435
27436
27437
27438
27439
27440
27441
27442
27443
27444
27445
27446
27447
27448
27449
27450
27451
27452
27453
27454
27455
27456
27457
27458
27459
27460
27461
27462
27463
27464
27465
27466
27467
27468
27469
27470
27471
27472
27473
27474
27475
27476
27477
27478
27479
27480
27481
27482
27483
27484
27485
27486
27487
27488
27489
27490
27491
27492
27493
27494
27495
27496
27497
27498
27499
27500
27501
27502
27503
27504
27505
27506
27507
27508
27509
27510
27511
27512
27513
27514
27515
27516
27517
27518
27519
27520
27521
27522
27523
27524
27525
27526
27527
27528
27529
27530
27531
27532
27533
27534
27535
27536
27537
27538
27539
27540
27541
27542
27543
27544
27545
27546
27547
27548
27549
27550
27551
27552
27553
27554
27555
27556
27557
27558
27559
27560
27561
27562
27563
27564
27565
27566
27567
27568
27569
27570
27571
27572
27573
27574
27575
27576
27577
27578
27579
27580
27581
27582
27583
27584
27585
27586
27587
27588
27589
27590
27591
27592
27593
27594
27595
27596
27597
27598
27599
27600
27601
27602
27603
27604
27605
27606
27607
27608
27609
27610
27611
27612
27613
27614
27615
27616
27617
27618
27619
27620
27621
27622
27623
27624
27625
27626
27627
27628
27629
27630
27631
27632
27633
27634
27635
27636
27637
27638
27639
27640
27641
27642
27643
27644
27645
27646
27647
27648
27649
27650
27651
27652
27653
27654
27655
27656
27657
27658
27659
27660
27661
27662
27663
27664
27665
27666
27667
27668
27669
27670
27671
27672
27673
27674
27675
27676
27677
27678
27679
27680
27681
27682
27683
27684
27685
27686
27687
27688
27689
27690
27691
27692
27693
27694
27695
27696
27697
27698
27699
27700
27701
27702
27703
27704
27705
27706
27707
27708
27709
27710
27711
27712
27713
27714
27715
27716
27717
27718
27719
27720
27721
27722
27723
27724
27725
27726
27727
27728
27729
27730
27731
27732
27733
27734
27735
27736
27737
27738
27739
27740
27741
27742
27743
27744
27745
27746
27747
27748
27749
27750
27751
27752
27753
27754
27755
27756
27757
27758
27759
27760
27761
27762
27763
27764
27765
27766
27767
27768
27769
27770
27771
27772
27773
27774
27775
27776
27777
27778
27779
27780
27781
27782
27783
27784
27785
27786
27787
27788
27789
27790
27791
27792
27793
27794
27795
27796
27797
27798
27799
27800
27801
27802
27803
27804
27805
27806
27807
27808
27809
27810
27811
27812
27813
27814
27815
27816
27817
27818
27819
27820
27821
27822
27823
27824
27825
27826
27827
27828
27829
27830
27831
27832
27833
27834
27835
27836
27837
27838
27839
27840
27841
27842
27843
27844
27845
27846
27847
27848
27849
27850
27851
27852
27853
27854
27855
27856
27857
27858
27859
27860
27861
27862
27863
27864
27865
27866
27867
27868
27869
27870
27871
27872
27873
27874
27875
27876
27877
27878
27879
27880
27881
27882
27883
27884
27885
27886
27887
27888
27889
27890
27891
27892
27893
27894
27895
27896
27897
27898
27899
27900
27901
27902
27903
27904
27905
27906
27907
27908
27909
27910
27911
27912
27913
27914
27915
27916
27917
27918
27919
27920
27921
27922
27923
27924
27925
27926
27927
27928
27929
27930
27931
27932
27933
27934
27935
27936
27937
27938
27939
27940
27941
27942
27943
27944
27945
27946
27947
27948
27949
27950
27951
27952
27953
27954
27955
27956
27957
27958
27959
27960
27961
27962
27963
27964
27965
27966
27967
27968
27969
27970
27971
27972
27973
27974
27975
27976
27977
27978
27979
27980
27981
27982
27983
27984
27985
27986
27987
27988
27989
27990
27991
27992
27993
27994
27995
27996
27997
27998
27999
28000
28001
28002
28003
28004
28005
28006
28007
28008
28009
28010
28011
28012
28013
28014
28015
28016
28017
28018
28019
28020
28021
28022
28023
28024
28025
28026
28027
28028
28029
28030
28031
28032
28033
28034
28035
28036
28037
28038
28039
28040
28041
28042
28043
28044
28045
28046
28047
28048
28049
28050
28051
28052
28053
28054
28055
28056
28057
28058
28059
28060
28061
28062
28063
28064
28065
28066
28067
28068
28069
28070
28071
28072
28073
28074
28075
28076
28077
28078
28079
28080
28081
28082
28083
28084
28085
28086
28087
28088
28089
28090
28091
28092
28093
28094
28095
28096
28097
28098
28099
28100
28101
28102
28103
28104
28105
28106
28107
28108
28109
28110
28111
28112
28113
28114
28115
28116
28117
28118
28119
28120
28121
28122
28123
28124
28125
28126
28127
28128
28129
28130
28131
28132
28133
28134
28135
28136
28137
28138
28139
28140
28141
28142
28143
28144
28145
28146
28147
28148
28149
28150
28151
28152
28153
28154
28155
28156
28157
28158
28159
28160
28161
28162
28163
28164
28165
28166
28167
28168
28169
28170
28171
28172
28173
28174
28175
28176
28177
28178
28179
28180
28181
28182
28183
28184
28185
28186
28187
28188
28189
28190
28191
28192
28193
28194
28195
28196
28197
28198
28199
28200
28201
28202
28203
28204
28205
28206
28207
28208
28209
28210
28211
28212
28213
28214
28215
28216
28217
28218
28219
28220
28221
28222
28223
28224
28225
28226
28227
28228
28229
28230
28231
28232
28233
28234
28235
28236
28237
28238
28239
28240
28241
28242
28243
28244
28245
28246
28247
28248
28249
28250
28251
28252
28253
28254
28255
28256
28257
28258
28259
28260
28261
28262
28263
28264
28265
28266
28267
28268
28269
28270
28271
28272
28273
28274
28275
28276
28277
28278
28279
28280
28281
28282
28283
28284
28285
28286
28287
28288
28289
28290
28291
28292
28293
28294
28295
28296
28297
28298
28299
28300
28301
28302
28303
28304
28305
28306
28307
28308
28309
28310
28311
28312
28313
28314
28315
28316
28317
28318
28319
28320
28321
28322
28323
28324
28325
28326
28327
28328
28329
28330
28331
28332
28333
28334
28335
28336
28337
28338
28339
28340
28341
28342
28343
28344
28345
28346
28347
28348
28349
28350
28351
28352
28353
28354
28355
28356
28357
28358
28359
28360
28361
28362
28363
28364
28365
28366
28367
28368
28369
28370
28371
28372
28373
28374
28375
28376
28377
28378
28379
28380
28381
28382
28383
28384
28385
28386
28387
28388
28389
28390
28391
28392
28393
28394
28395
28396
28397
28398
28399
28400
28401
28402
28403
28404
28405
28406
28407
28408
28409
28410
28411
28412
28413
28414
28415
28416
28417
28418
28419
28420
28421
28422
28423
28424
28425
28426
28427
28428
28429
28430
28431
28432
28433
28434
28435
28436
28437
28438
28439
28440
28441
28442
28443
28444
28445
28446
28447
28448
28449
28450
28451
28452
28453
28454
28455
28456
28457
28458
28459
28460
28461
28462
28463
28464
28465
28466
28467
28468
28469
28470
28471
28472
28473
28474
28475
28476
28477
28478
28479
28480
28481
28482
28483
28484
28485
28486
28487
28488
28489
28490
28491
28492
28493
28494
28495
28496
28497
28498
28499
28500
28501
28502
28503
28504
28505
28506
28507
28508
28509
28510
28511
28512
28513
28514
28515
28516
28517
28518
28519
28520
28521
28522
28523
28524
28525
28526
28527
28528
28529
28530
28531
28532
28533
28534
28535
28536
28537
28538
28539
28540
28541
28542
28543
28544
28545
28546
28547
28548
28549
28550
28551
28552
28553
28554
28555
28556
28557
28558
28559
28560
28561
28562
28563
28564
28565
28566
28567
28568
28569
28570
28571
28572
28573
28574
28575
28576
28577
28578
28579
28580
28581
28582
28583
28584
28585
28586
28587
28588
28589
28590
28591
28592
28593
28594
28595
28596
28597
28598
28599
28600
28601
28602
28603
28604
28605
28606
28607
28608
28609
28610
28611
28612
28613
28614
28615
28616
28617
28618
28619
28620
28621
28622
28623
28624
28625
28626
28627
28628
28629
28630
28631
28632
28633
28634
28635
28636
28637
28638
28639
28640
28641
28642
28643
28644
28645
28646
28647
28648
28649
28650
28651
28652
28653
28654
28655
28656
28657
28658
28659
28660
28661
28662
28663
28664
28665
28666
28667
28668
28669
28670
28671
28672
28673
28674
28675
28676
28677
28678
28679
28680
28681
28682
28683
28684
28685
28686
28687
28688
28689
28690
28691
28692
28693
28694
28695
28696
28697
28698
28699
28700
28701
28702
28703
28704
28705
28706
28707
28708
28709
28710
28711
28712
28713
28714
28715
28716
28717
28718
28719
28720
28721
28722
28723
28724
28725
28726
28727
28728
28729
28730
28731
28732
28733
28734
28735
28736
28737
28738
28739
28740
28741
28742
28743
28744
28745
28746
28747
28748
28749
28750
28751
28752
28753
28754
28755
28756
28757
28758
28759
28760
28761
28762
28763
28764
28765
28766
28767
28768
28769
28770
28771
28772
28773
28774
28775
28776
28777
28778
28779
28780
28781
28782
28783
28784
28785
28786
28787
28788
28789
28790
28791
28792
28793
28794
28795
28796
28797
28798
28799
28800
28801
28802
28803
28804
28805
28806
28807
28808
28809
28810
28811
28812
28813
28814
28815
28816
28817
28818
28819
28820
28821
28822
28823
28824
28825
28826
28827
28828
28829
28830
28831
28832
28833
28834
28835
28836
28837
28838
28839
28840
28841
28842
28843
28844
28845
28846
28847
28848
28849
28850
28851
28852
28853
28854
28855
28856
28857
28858
28859
28860
28861
28862
28863
28864
28865
28866
28867
28868
28869
28870
28871
28872
28873
28874
28875
28876
28877
28878
28879
28880
28881
28882
28883
28884
28885
28886
28887
28888
28889
28890
28891
28892
28893
28894
28895
28896
28897
28898
28899
28900
28901
28902
28903
28904
28905
28906
28907
28908
28909
28910
28911
28912
28913
28914
28915
28916
28917
28918
28919
28920
28921
28922
28923
28924
28925
28926
28927
28928
28929
28930
28931
28932
28933
28934
28935
28936
28937
28938
28939
28940
28941
28942
28943
28944
28945
28946
28947
28948
28949
28950
28951
28952
28953
28954
28955
28956
28957
28958
28959
28960
28961
28962
28963
28964
28965
28966
28967
28968
28969
28970
28971
28972
28973
28974
28975
28976
28977
28978
28979
28980
28981
28982
28983
28984
28985
28986
28987
28988
28989
28990
28991
28992
28993
28994
28995
28996
28997
28998
28999
29000
29001
29002
29003
29004
29005
29006
29007
29008
29009
29010
29011
29012
29013
29014
29015
29016
29017
29018
29019
29020
29021
29022
29023
29024
29025
29026
29027
29028
29029
29030
29031
29032
29033
29034
29035
29036
29037
29038
29039
29040
29041
29042
29043
29044
29045
29046
29047
29048
29049
29050
29051
29052
29053
29054
29055
29056
29057
29058
29059
29060
29061
29062
29063
29064
29065
29066
29067
29068
29069
29070
29071
29072
29073
29074
29075
29076
29077
29078
29079
29080
29081
29082
29083
29084
29085
29086
29087
29088
29089
29090
29091
29092
29093
29094
29095
29096
29097
29098
29099
29100
29101
29102
29103
29104
29105
29106
29107
29108
29109
29110
29111
29112
29113
29114
29115
29116
29117
29118
29119
29120
29121
29122
29123
29124
29125
29126
29127
29128
29129
29130
29131
29132
29133
29134
29135
29136
29137
29138
29139
29140
29141
29142
29143
29144
29145
29146
29147
29148
29149
29150
29151
29152
29153
29154
29155
29156
29157
29158
29159
29160
29161
29162
29163
29164
29165
29166
29167
29168
29169
29170
29171
29172
29173
29174
29175
29176
29177
29178
29179
29180
29181
29182
29183
29184
29185
29186
29187
29188
29189
29190
29191
29192
29193
29194
29195
29196
29197
29198
29199
29200
29201
29202
29203
29204
29205
29206
29207
29208
29209
29210
29211
29212
29213
29214
29215
29216
29217
29218
29219
29220
29221
29222
29223
29224
29225
29226
29227
29228
29229
29230
29231
29232
29233
29234
29235
29236
29237
29238
29239
29240
29241
29242
29243
29244
29245
29246
29247
29248
29249
29250
29251
29252
29253
29254
29255
29256
29257
29258
29259
29260
29261
29262
29263
29264
29265
29266
29267
29268
29269
29270
29271
29272
29273
29274
29275
29276
29277
29278
29279
29280
29281
29282
29283
29284
29285
29286
29287
29288
29289
29290
29291
29292
29293
29294
29295
29296
29297
29298
29299
29300
29301
29302
29303
29304
29305
29306
29307
29308
29309
29310
29311
29312
29313
29314
29315
29316
29317
29318
29319
29320
29321
29322
29323
29324
29325
29326
29327
29328
29329
29330
29331
29332
29333
29334
29335
29336
29337
29338
29339
29340
29341
29342
29343
29344
29345
29346
29347
29348
29349
29350
29351
29352
29353
29354
29355
29356
29357
29358
29359
29360
29361
29362
29363
29364
29365
29366
29367
29368
29369
29370
29371
29372
29373
29374
29375
29376
29377
29378
29379
29380
29381
29382
29383
29384
29385
29386
29387
29388
29389
29390
29391
29392
29393
29394
29395
29396
29397
29398
29399
29400
29401
29402
29403
29404
29405
29406
29407
29408
29409
29410
29411
29412
29413
29414
29415
29416
29417
29418
29419
29420
29421
29422
29423
29424
29425
29426
29427
29428
29429
29430
29431
29432
29433
29434
29435
29436
29437
29438
29439
29440
29441
29442
29443
29444
29445
29446
29447
29448
29449
29450
29451
29452
29453
29454
29455
29456
29457
29458
29459
29460
29461
29462
29463
29464
29465
29466
29467
29468
29469
29470
29471
29472
29473
29474
29475
29476
29477
29478
29479
29480
29481
29482
29483
29484
29485
29486
29487
29488
29489
29490
29491
29492
29493
29494
29495
29496
29497
29498
29499
29500
29501
29502
29503
29504
29505
29506
29507
29508
29509
29510
29511
29512
29513
29514
29515
29516
29517
29518
29519
29520
29521
29522
29523
29524
29525
29526
29527
29528
29529
29530
29531
29532
29533
29534
29535
29536
29537
29538
29539
29540
29541
29542
29543
29544
29545
29546
29547
29548
29549
29550
29551
29552
29553
29554
29555
29556
29557
29558
29559
29560
29561
29562
29563
29564
29565
29566
29567
29568
29569
29570
29571
29572
29573
29574
29575
29576
29577
29578
29579
29580
29581
29582
29583
29584
29585
29586
29587
29588
29589
29590
29591
29592
29593
29594
29595
29596
29597
29598
29599
29600
29601
29602
29603
29604
29605
29606
29607
29608
29609
29610
29611
29612
29613
29614
29615
29616
29617
29618
29619
29620
29621
29622
29623
29624
29625
29626
29627
29628
29629
29630
29631
29632
29633
29634
29635
29636
29637
29638
29639
29640
29641
29642
29643
29644
29645
29646
29647
29648
29649
29650
29651
29652
29653
29654
29655
29656
29657
29658
29659
29660
29661
29662
29663
29664
29665
29666
29667
29668
29669
29670
29671
29672
29673
29674
29675
29676
29677
29678
29679
29680
29681
29682
29683
29684
29685
29686
29687
29688
29689
29690
29691
29692
29693
29694
29695
29696
29697
29698
29699
29700
29701
29702
29703
29704
29705
29706
29707
29708
29709
29710
29711
29712
29713
29714
29715
29716
29717
29718
29719
29720
29721
29722
29723
29724
29725
29726
29727
29728
29729
29730
29731
29732
29733
29734
29735
29736
29737
29738
29739
29740
29741
29742
29743
29744
29745
29746
29747
29748
29749
29750
29751
29752
29753
29754
29755
29756
29757
29758
29759
29760
29761
29762
29763
29764
29765
29766
29767
29768
29769
29770
29771
29772
29773
29774
29775
29776
29777
29778
29779
29780
29781
29782
29783
29784
29785
29786
29787
29788
29789
29790
29791
29792
29793
29794
29795
29796
29797
29798
29799
29800
29801
29802
29803
29804
29805
29806
29807
29808
29809
29810
29811
29812
29813
29814
29815
29816
29817
29818
29819
29820
29821
29822
29823
29824
29825
29826
29827
29828
29829
29830
29831
29832
29833
29834
29835
29836
29837
29838
29839
29840
29841
29842
29843
29844
29845
29846
29847
29848
29849
29850
29851
29852
29853
29854
29855
29856
29857
29858
29859
29860
29861
29862
29863
29864
29865
29866
29867
29868
29869
29870
29871
29872
29873
29874
29875
29876
29877
29878
29879
29880
29881
29882
29883
29884
29885
29886
29887
29888
29889
29890
29891
29892
29893
29894
29895
29896
29897
29898
29899
29900
29901
29902
29903
29904
29905
29906
29907
29908
29909
29910
29911
29912
29913
29914
29915
29916
29917
29918
29919
29920
29921
29922
29923
29924
29925
29926
29927
29928
29929
29930
29931
29932
29933
29934
29935
29936
29937
29938
29939
29940
29941
29942
29943
29944
29945
29946
29947
29948
29949
29950
29951
29952
29953
29954
29955
29956
29957
29958
29959
29960
29961
29962
29963
29964
29965
29966
29967
29968
29969
29970
29971
29972
29973
29974
29975
29976
29977
29978
29979
29980
29981
29982
29983
29984
29985
29986
29987
29988
29989
29990
29991
29992
29993
29994
29995
29996
29997
29998
29999
30000
30001
30002
30003
30004
30005
30006
30007
30008
30009
30010
30011
30012
30013
30014
30015
30016
30017
30018
30019
30020
30021
30022
30023
30024
30025
30026
30027
30028
30029
30030
30031
30032
30033
30034
30035
30036
30037
30038
30039
30040
30041
30042
30043
30044
30045
30046
30047
30048
30049
30050
30051
30052
30053
30054
30055
30056
30057
30058
30059
30060
30061
30062
30063
30064
30065
30066
30067
30068
30069
30070
30071
30072
30073
30074
30075
30076
30077
30078
30079
30080
30081
30082
30083
30084
30085
30086
30087
30088
30089
30090
30091
30092
30093
30094
30095
30096
30097
30098
30099
30100
30101
30102
30103
30104
30105
30106
30107
30108
30109
30110
30111
30112
30113
30114
30115
30116
30117
30118
30119
30120
30121
30122
30123
30124
30125
30126
30127
30128
30129
30130
30131
30132
30133
30134
30135
30136
30137
30138
30139
30140
30141
30142
30143
30144
30145
30146
30147
30148
30149
30150
30151
30152
30153
30154
30155
30156
30157
30158
30159
30160
30161
30162
30163
30164
30165
30166
30167
30168
30169
30170
30171
30172
30173
30174
30175
30176
30177
30178
30179
30180
30181
30182
30183
30184
30185
30186
30187
30188
30189
30190
30191
30192
30193
30194
30195
30196
30197
30198
30199
30200
30201
30202
30203
30204
30205
30206
30207
30208
30209
30210
30211
30212
30213
30214
30215
30216
30217
30218
30219
30220
30221
30222
30223
30224
30225
30226
30227
30228
30229
30230
30231
30232
30233
30234
30235
30236
30237
30238
30239
30240
30241
30242
30243
30244
30245
30246
30247
30248
30249
30250
30251
30252
30253
30254
30255
30256
30257
30258
30259
30260
30261
30262
30263
30264
30265
30266
30267
30268
30269
30270
30271
30272
30273
30274
30275
30276
30277
30278
30279
30280
30281
30282
30283
30284
30285
30286
30287
30288
30289
30290
30291
30292
30293
30294
30295
30296
30297
30298
30299
30300
30301
30302
30303
30304
30305
30306
30307
30308
30309
30310
30311
30312
30313
30314
30315
30316
30317
30318
30319
30320
30321
30322
30323
30324
30325
30326
30327
30328
30329
30330
30331
30332
30333
30334
30335
30336
30337
30338
30339
30340
30341
30342
30343
30344
30345
30346
30347
30348
30349
30350
30351
30352
30353
30354
30355
30356
30357
30358
30359
30360
30361
30362
30363
30364
30365
30366
30367
30368
30369
30370
30371
30372
30373
30374
30375
30376
30377
30378
30379
30380
30381
30382
30383
30384
30385
30386
30387
30388
30389
30390
30391
30392
30393
30394
30395
30396
30397
30398
30399
30400
30401
30402
30403
30404
30405
30406
30407
30408
30409
30410
30411
30412
30413
30414
30415
30416
30417
30418
30419
30420
30421
30422
30423
30424
30425
30426
30427
30428
30429
30430
30431
30432
30433
30434
30435
30436
30437
30438
30439
30440
30441
30442
30443
30444
30445
30446
30447
30448
30449
30450
30451
30452
30453
30454
30455
30456
30457
30458
30459
30460
30461
30462
30463
30464
30465
30466
30467
30468
30469
30470
30471
30472
30473
30474
30475
30476
30477
30478
30479
30480
30481
30482
30483
30484
30485
30486
30487
30488
30489
30490
30491
30492
30493
30494
30495
30496
30497
30498
30499
30500
30501
30502
30503
30504
30505
30506
30507
30508
30509
30510
30511
30512
30513
30514
30515
30516
30517
30518
30519
30520
30521
30522
30523
30524
30525
30526
30527
30528
30529
30530
30531
30532
30533
30534
30535
30536
30537
30538
30539
30540
30541
30542
30543
30544
30545
30546
30547
30548
30549
30550
30551
30552
30553
30554
30555
30556
30557
30558
30559
30560
30561
30562
30563
30564
30565
30566
30567
30568
30569
30570
30571
30572
30573
30574
30575
30576
30577
30578
30579
30580
30581
30582
30583
30584
30585
30586
30587
30588
30589
30590
30591
30592
30593
30594
30595
30596
30597
30598
30599
30600
30601
30602
30603
30604
30605
30606
30607
30608
30609
30610
30611
30612
30613
30614
30615
30616
30617
30618
30619
30620
30621
30622
30623
30624
30625
30626
30627
30628
30629
30630
30631
30632
30633
30634
30635
30636
30637
30638
30639
30640
30641
30642
30643
30644
30645
30646
30647
30648
30649
30650
30651
30652
30653
30654
30655
30656
30657
30658
30659
30660
30661
30662
30663
30664
30665
30666
30667
30668
30669
30670
30671
30672
30673
30674
30675
30676
30677
30678
30679
30680
30681
30682
30683
30684
30685
30686
30687
30688
30689
30690
30691
30692
30693
30694
30695
30696
30697
30698
30699
30700
30701
30702
30703
30704
30705
30706
30707
30708
30709
30710
30711
30712
30713
30714
30715
30716
30717
30718
30719
30720
30721
30722
30723
30724
30725
30726
30727
30728
30729
30730
30731
30732
30733
30734
30735
30736
30737
30738
30739
30740
30741
30742
30743
30744
30745
30746
30747
30748
30749
30750
30751
30752
30753
30754
30755
30756
30757
30758
30759
30760
30761
30762
30763
30764
30765
30766
30767
30768
30769
30770
30771
30772
30773
30774
30775
30776
30777
30778
30779
30780
30781
30782
30783
30784
30785
30786
30787
30788
30789
30790
30791
30792
30793
30794
30795
30796
30797
30798
30799
30800
30801
30802
30803
30804
30805
30806
30807
30808
30809
30810
30811
30812
30813
30814
30815
30816
30817
30818
30819
30820
30821
30822
30823
30824
30825
30826
30827
30828
30829
30830
30831
30832
30833
30834
30835
30836
30837
30838
30839
30840
30841
30842
30843
30844
30845
30846
30847
30848
30849
30850
30851
30852
30853
30854
30855
30856
30857
30858
30859
30860
30861
30862
30863
30864
30865
30866
30867
30868
30869
30870
30871
30872
30873
30874
30875
30876
30877
30878
30879
30880
30881
30882
30883
30884
30885
30886
30887
30888
30889
30890
30891
30892
30893
30894
30895
30896
30897
30898
30899
30900
30901
30902
30903
30904
30905
30906
30907
30908
30909
30910
30911
30912
30913
30914
30915
30916
30917
30918
30919
30920
30921
30922
30923
30924
30925
30926
30927
30928
30929
30930
30931
30932
30933
30934
30935
30936
30937
30938
30939
30940
30941
30942
30943
30944
30945
30946
30947
30948
30949
30950
30951
30952
30953
30954
30955
30956
30957
30958
30959
30960
30961
30962
30963
30964
30965
30966
30967
30968
30969
30970
30971
30972
30973
30974
30975
30976
30977
30978
30979
30980
30981
30982
30983
30984
30985
30986
30987
30988
30989
30990
30991
30992
30993
30994
30995
30996
30997
30998
30999
31000
31001
31002
31003
31004
31005
31006
31007
31008
31009
31010
31011
31012
31013
31014
31015
31016
31017
31018
31019
31020
31021
31022
31023
31024
31025
31026
31027
31028
31029
31030
31031
31032
31033
31034
31035
31036
31037
31038
31039
31040
31041
31042
31043
31044
31045
31046
31047
31048
31049
31050
31051
31052
31053
31054
31055
31056
31057
31058
31059
31060
31061
31062
31063
31064
31065
31066
31067
31068
31069
31070
31071
31072
31073
31074
31075
31076
31077
31078
31079
31080
31081
31082
31083
31084
31085
31086
31087
31088
31089
31090
31091
31092
31093
31094
31095
31096
31097
31098
31099
31100
31101
31102
31103
31104
31105
31106
31107
31108
31109
31110
31111
31112
31113
31114
31115
31116
31117
31118
31119
31120
31121
31122
31123
31124
31125
31126
31127
31128
31129
31130
31131
31132
31133
31134
31135
31136
31137
31138
31139
31140
31141
31142
31143
31144
31145
31146
31147
31148
31149
31150
31151
31152
31153
31154
31155
31156
31157
31158
31159
31160
31161
31162
31163
31164
31165
31166
31167
31168
31169
31170
31171
31172
31173
31174
31175
31176
31177
31178
31179
31180
31181
31182
31183
31184
31185
31186
31187
31188
31189
31190
31191
31192
31193
31194
31195
31196
31197
31198
31199
31200
31201
31202
31203
31204
31205
31206
31207
31208
31209
31210
31211
31212
31213
31214
31215
31216
31217
31218
31219
31220
31221
31222
31223
31224
31225
31226
31227
31228
31229
31230
31231
31232
31233
31234
31235
31236
31237
31238
31239
31240
31241
31242
31243
31244
31245
31246
31247
31248
31249
31250
31251
31252
31253
31254
31255
31256
31257
31258
31259
31260
31261
31262
31263
31264
31265
31266
31267
31268
31269
31270
31271
31272
31273
31274
31275
31276
31277
31278
31279
31280
31281
31282
31283
31284
31285
31286
31287
31288
31289
31290
31291
31292
31293
31294
31295
31296
31297
31298
31299
31300
31301
31302
31303
31304
31305
31306
31307
31308
31309
31310
31311
31312
31313
31314
31315
31316
31317
31318
31319
31320
31321
31322
31323
31324
31325
31326
31327
31328
31329
31330
31331
31332
31333
31334
31335
31336
31337
31338
31339
31340
31341
31342
31343
31344
31345
31346
31347
31348
31349
31350
31351
31352
31353
31354
31355
31356
31357
31358
31359
31360
31361
31362
31363
31364
31365
31366
31367
31368
31369
31370
31371
31372
31373
31374
31375
31376
31377
31378
31379
31380
31381
31382
31383
31384
31385
31386
31387
31388
31389
31390
31391
31392
31393
31394
31395
31396
31397
31398
31399
31400
31401
31402
31403
31404
31405
31406
31407
31408
31409
31410
31411
31412
31413
31414
31415
31416
31417
31418
31419
31420
31421
31422
31423
31424
31425
31426
31427
31428
31429
31430
31431
31432
31433
31434
31435
31436
31437
31438
31439
31440
31441
31442
31443
31444
31445
31446
31447
31448
31449
31450
31451
31452
31453
31454
31455
31456
31457
31458
31459
31460
31461
31462
31463
31464
31465
31466
31467
31468
31469
31470
31471
31472
31473
31474
31475
31476
31477
31478
31479
31480
31481
31482
31483
31484
31485
31486
31487
31488
31489
31490
31491
31492
31493
31494
31495
31496
31497
31498
31499
31500
31501
31502
31503
31504
31505
31506
31507
31508
31509
31510
31511
31512
31513
31514
31515
31516
31517
31518
31519
31520
31521
31522
31523
31524
31525
31526
31527
31528
31529
31530
31531
31532
31533
31534
31535
31536
31537
31538
31539
31540
31541
31542
31543
31544
31545
31546
31547
31548
31549
31550
31551
31552
31553
31554
31555
31556
31557
31558
31559
31560
31561
31562
31563
31564
31565
31566
31567
31568
31569
31570
31571
31572
31573
31574
31575
31576
31577
31578
31579
31580
31581
31582
31583
31584
31585
31586
31587
31588
31589
31590
31591
31592
31593
31594
31595
31596
31597
31598
31599
31600
31601
31602
31603
31604
31605
31606
31607
31608
31609
31610
31611
31612
31613
31614
31615
31616
31617
31618
31619
31620
31621
31622
31623
31624
31625
31626
31627
31628
31629
31630
31631
31632
31633
31634
31635
31636
31637
31638
31639
31640
31641
31642
31643
31644
31645
31646
31647
31648
31649
31650
31651
31652
31653
31654
31655
31656
31657
31658
31659
31660
31661
31662
31663
31664
31665
31666
31667
31668
31669
31670
31671
31672
31673
31674
31675
31676
31677
31678
31679
31680
31681
31682
31683
31684
31685
31686
31687
31688
31689
31690
31691
31692
31693
31694
31695
31696
31697
31698
31699
31700
31701
31702
31703
31704
31705
31706
31707
31708
31709
31710
31711
31712
31713
31714
31715
31716
31717
31718
31719
31720
31721
31722
31723
31724
31725
31726
31727
31728
31729
31730
31731
31732
31733
31734
31735
31736
31737
31738
31739
31740
31741
31742
31743
31744
31745
31746
31747
31748
31749
31750
31751
31752
31753
31754
31755
31756
31757
31758
31759
31760
31761
31762
31763
31764
31765
31766
31767
31768
31769
31770
31771
31772
31773
31774
31775
31776
31777
31778
31779
31780
31781
31782
31783
31784
31785
31786
31787
31788
31789
31790
31791
31792
31793
31794
31795
31796
31797
31798
31799
31800
31801
31802
31803
31804
31805
31806
31807
31808
31809
31810
31811
31812
31813
31814
31815
31816
31817
31818
31819
31820
31821
31822
31823
31824
31825
31826
31827
31828
31829
31830
31831
31832
31833
31834
31835
31836
31837
31838
31839
31840
31841
31842
31843
31844
31845
31846
31847
31848
31849
31850
31851
31852
31853
31854
31855
31856
31857
31858
31859
31860
31861
31862
31863
31864
31865
31866
31867
31868
31869
31870
31871
31872
31873
31874
31875
31876
31877
31878
31879
31880
31881
31882
31883
31884
31885
31886
31887
31888
31889
31890
31891
31892
31893
31894
31895
31896
31897
31898
31899
31900
31901
31902
31903
31904
31905
31906
31907
31908
31909
31910
31911
31912
31913
31914
31915
31916
31917
31918
31919
31920
31921
31922
31923
31924
31925
31926
31927
31928
31929
31930
31931
31932
31933
31934
31935
31936
31937
31938
31939
31940
31941
31942
31943
31944
31945
31946
31947
31948
31949
31950
31951
31952
31953
31954
31955
31956
31957
31958
31959
31960
31961
31962
31963
31964
31965
31966
31967
31968
31969
31970
31971
31972
31973
31974
31975
31976
31977
31978
31979
31980
31981
31982
31983
31984
31985
31986
31987
31988
31989
31990
31991
31992
31993
31994
31995
31996
31997
31998
31999
32000
32001
32002
32003
32004
32005
32006
32007
32008
32009
32010
32011
32012
32013
32014
32015
32016
32017
32018
32019
32020
32021
32022
32023
32024
32025
32026
32027
32028
32029
32030
32031
32032
32033
32034
32035
32036
32037
32038
32039
32040
32041
32042
32043
32044
32045
32046
32047
32048
32049
32050
32051
32052
32053
32054
32055
32056
32057
32058
32059
32060
32061
32062
32063
32064
32065
32066
32067
32068
32069
32070
32071
32072
32073
32074
32075
32076
32077
32078
32079
32080
32081
32082
32083
32084
32085
32086
32087
32088
32089
32090
32091
32092
32093
32094
32095
32096
32097
32098
32099
32100
32101
32102
32103
32104
32105
32106
32107
32108
32109
32110
32111
32112
32113
32114
32115
32116
32117
32118
32119
32120
32121
32122
32123
32124
32125
32126
32127
32128
32129
32130
32131
32132
32133
32134
32135
32136
32137
32138
32139
32140
32141
32142
32143
32144
32145
32146
32147
32148
32149
32150
32151
32152
32153
32154
32155
32156
32157
32158
32159
32160
32161
32162
32163
32164
32165
32166
32167
32168
32169
32170
32171
32172
32173
32174
32175
32176
32177
32178
32179
32180
32181
32182
32183
32184
32185
32186
32187
32188
32189
32190
32191
32192
32193
32194
32195
32196
32197
32198
32199
32200
32201
32202
32203
32204
32205
32206
32207
32208
32209
32210
32211
32212
32213
32214
32215
32216
32217
32218
32219
32220
32221
32222
32223
32224
32225
32226
32227
32228
32229
32230
32231
32232
32233
32234
32235
32236
32237
32238
32239
32240
32241
32242
32243
32244
32245
32246
32247
32248
32249
32250
32251
32252
32253
32254
32255
32256
32257
32258
32259
32260
32261
32262
32263
32264
32265
32266
32267
32268
32269
32270
32271
32272
32273
32274
32275
32276
32277
32278
32279
32280
32281
32282
32283
32284
32285
32286
32287
32288
32289
32290
32291
32292
32293
32294
32295
32296
32297
32298
32299
32300
32301
32302
32303
32304
32305
32306
32307
32308
32309
32310
32311
32312
32313
32314
32315
32316
32317
32318
32319
32320
32321
32322
32323
32324
32325
32326
32327
32328
32329
32330
32331
32332
32333
32334
32335
32336
32337
32338
32339
32340
32341
32342
32343
32344
32345
32346
32347
32348
32349
32350
32351
32352
32353
32354
32355
32356
32357
32358
32359
32360
32361
32362
32363
32364
32365
32366
32367
32368
32369
32370
32371
32372
32373
32374
32375
32376
32377
32378
32379
32380
32381
32382
32383
32384
32385
32386
32387
32388
32389
32390
32391
32392
32393
32394
32395
32396
32397
32398
32399
32400
32401
32402
32403
32404
32405
32406
32407
32408
32409
32410
32411
32412
32413
32414
32415
32416
32417
32418
32419
32420
32421
32422
32423
32424
32425
32426
32427
32428
32429
32430
32431
32432
32433
32434
32435
32436
32437
32438
32439
32440
32441
32442
32443
32444
32445
32446
32447
32448
32449
32450
32451
32452
32453
32454
32455
32456
32457
32458
32459
32460
32461
32462
32463
32464
32465
32466
32467
32468
32469
32470
32471
32472
32473
32474
32475
32476
32477
32478
32479
32480
32481
32482
32483
32484
32485
32486
32487
32488
32489
32490
32491
32492
32493
32494
32495
32496
32497
32498
32499
32500
32501
32502
32503
32504
32505
32506
32507
32508
32509
32510
32511
32512
32513
32514
32515
32516
32517
32518
32519
32520
32521
32522
32523
32524
32525
32526
32527
32528
32529
32530
32531
32532
32533
32534
32535
32536
32537
32538
32539
32540
32541
32542
32543
32544
32545
32546
32547
32548
32549
32550
32551
32552
32553
32554
32555
32556
32557
32558
32559
32560
32561
32562
32563
32564
32565
32566
32567
32568
32569
32570
32571
32572
32573
32574
32575
32576
32577
32578
32579
32580
32581
32582
32583
32584
32585
32586
32587
32588
32589
32590
32591
32592
32593
32594
32595
32596
32597
32598
32599
32600
32601
32602
32603
32604
32605
32606
32607
32608
32609
32610
32611
32612
32613
32614
32615
32616
32617
32618
32619
32620
32621
32622
32623
32624
32625
32626
32627
32628
32629
32630
32631
32632
32633
32634
32635
32636
32637
32638
32639
32640
32641
32642
32643
32644
32645
32646
32647
32648
32649
32650
32651
32652
32653
32654
32655
32656
32657
32658
32659
32660
32661
32662
32663
32664
32665
32666
32667
32668
32669
32670
32671
32672
32673
32674
32675
32676
32677
32678
32679
32680
32681
32682
32683
32684
32685
32686
32687
32688
32689
32690
32691
32692
32693
32694
32695
32696
32697
32698
32699
32700
32701
32702
32703
32704
32705
32706
32707
32708
32709
32710
32711
32712
32713
32714
32715
32716
32717
32718
32719
32720
32721
32722
32723
32724
32725
32726
32727
32728
32729
32730
32731
32732
32733
32734
32735
32736
32737
32738
32739
32740
32741
32742
32743
32744
32745
32746
32747
32748
32749
32750
32751
32752
32753
32754
32755
32756
32757
32758
32759
32760
32761
32762
32763
32764
32765
32766
32767
32768
32769
32770
32771
32772
32773
32774
32775
32776
32777
32778
32779
32780
32781
32782
32783
32784
32785
32786
32787
32788
32789
32790
32791
32792
32793
32794
32795
32796
32797
32798
32799
32800
32801
32802
32803
32804
32805
32806
32807
32808
32809
32810
32811
32812
32813
32814
32815
32816
32817
32818
32819
32820
32821
32822
32823
32824
32825
32826
32827
32828
32829
32830
32831
32832
32833
32834
32835
32836
32837
32838
32839
32840
32841
32842
32843
32844
32845
32846
32847
32848
32849
32850
32851
32852
32853
32854
32855
32856
32857
32858
32859
32860
32861
32862
32863
32864
32865
32866
32867
32868
32869
32870
32871
32872
32873
32874
32875
32876
32877
32878
32879
32880
32881
32882
32883
32884
32885
32886
32887
32888
32889
32890
32891
32892
32893
32894
32895
32896
32897
32898
32899
32900
32901
32902
32903
32904
32905
32906
32907
32908
32909
32910
32911
32912
32913
32914
32915
32916
32917
32918
32919
32920
32921
32922
32923
32924
32925
32926
32927
32928
32929
32930
32931
32932
32933
32934
32935
32936
32937
32938
32939
32940
32941
32942
32943
32944
32945
32946
32947
32948
32949
32950
32951
32952
32953
32954
32955
32956
32957
32958
32959
32960
32961
32962
32963
32964
32965
32966
32967
32968
32969
32970
32971
32972
32973
32974
32975
32976
32977
32978
32979
32980
32981
32982
32983
32984
32985
32986
32987
32988
32989
32990
32991
32992
32993
32994
32995
32996
32997
32998
32999
33000
33001
33002
33003
33004
33005
33006
33007
33008
33009
33010
33011
33012
33013
33014
33015
33016
33017
33018
33019
33020
33021
33022
33023
33024
33025
33026
33027
33028
33029
33030
33031
33032
33033
33034
33035
33036
33037
33038
33039
33040
33041
33042
33043
33044
33045
33046
33047
33048
33049
33050
33051
33052
33053
33054
33055
33056
33057
33058
33059
33060
33061
33062
33063
33064
33065
33066
33067
33068
33069
33070
33071
33072
33073
33074
33075
33076
33077
33078
33079
33080
33081
33082
33083
33084
33085
33086
33087
33088
33089
33090
33091
33092
33093
33094
33095
33096
33097
33098
33099
33100
33101
33102
33103
33104
33105
33106
33107
33108
33109
33110
33111
33112
33113
33114
33115
33116
33117
33118
33119
33120
33121
33122
33123
33124
33125
33126
33127
33128
33129
33130
33131
33132
33133
33134
33135
33136
33137
33138
33139
33140
33141
33142
33143
33144
33145
33146
33147
33148
33149
33150
33151
33152
33153
33154
33155
33156
33157
33158
33159
33160
33161
33162
33163
33164
33165
33166
33167
33168
33169
33170
33171
33172
33173
33174
33175
33176
33177
33178
33179
33180
33181
33182
33183
33184
33185
33186
33187
33188
33189
33190
33191
33192
33193
33194
33195
33196
33197
33198
33199
33200
33201
33202
33203
33204
33205
33206
33207
33208
33209
33210
33211
33212
33213
33214
33215
33216
33217
33218
33219
33220
33221
33222
33223
33224
33225
33226
33227
33228
33229
33230
33231
33232
33233
33234
33235
33236
33237
33238
33239
33240
33241
33242
33243
33244
33245
33246
33247
33248
33249
33250
33251
33252
33253
33254
33255
33256
33257
33258
33259
33260
33261
33262
33263
33264
33265
33266
33267
33268
33269
33270
33271
33272
33273
33274
33275
33276
33277
33278
33279
33280
33281
33282
33283
33284
33285
33286
33287
33288
33289
33290
33291
33292
33293
33294
33295
33296
33297
33298
33299
33300
33301
33302
33303
33304
33305
33306
33307
33308
33309
33310
33311
33312
33313
33314
33315
33316
33317
33318
33319
33320
33321
33322
33323
33324
33325
33326
33327
33328
33329
33330
33331
33332
33333
33334
33335
33336
33337
33338
33339
33340
33341
33342
33343
33344
33345
33346
33347
33348
33349
33350
33351
33352
33353
33354
33355
33356
33357
33358
33359
33360
33361
33362
33363
33364
33365
33366
33367
33368
33369
33370
33371
33372
33373
33374
33375
33376
33377
33378
33379
33380
33381
33382
33383
33384
33385
33386
33387
33388
33389
33390
33391
33392
33393
33394
33395
33396
33397
33398
33399
33400
33401
33402
33403
33404
33405
33406
33407
33408
33409
33410
33411
33412
33413
33414
33415
33416
33417
33418
33419
33420
33421
33422
33423
33424
33425
33426
33427
33428
33429
33430
33431
33432
33433
33434
33435
33436
33437
33438
33439
33440
33441
33442
33443
33444
33445
33446
33447
33448
33449
33450
33451
33452
33453
33454
33455
33456
33457
33458
33459
33460
33461
33462
33463
33464
33465
33466
33467
33468
33469
33470
33471
33472
33473
33474
33475
33476
33477
33478
33479
33480
33481
33482
33483
33484
33485
33486
33487
33488
33489
33490
33491
33492
33493
33494
33495
33496
33497
33498
33499
33500
33501
33502
33503
33504
33505
33506
33507
33508
33509
33510
33511
33512
33513
33514
33515
33516
33517
33518
33519
33520
33521
33522
33523
33524
33525
33526
33527
33528
33529
33530
33531
33532
33533
33534
33535
33536
33537
33538
33539
33540
33541
33542
33543
33544
33545
33546
33547
33548
33549
33550
33551
33552
33553
33554
33555
33556
33557
33558
33559
33560
33561
33562
33563
33564
33565
33566
33567
33568
33569
33570
33571
33572
33573
33574
33575
33576
33577
33578
33579
33580
33581
33582
33583
33584
33585
33586
33587
33588
33589
33590
33591
33592
33593
33594
33595
33596
33597
33598
33599
33600
33601
33602
33603
33604
33605
33606
33607
33608
33609
33610
33611
33612
33613
33614
33615
33616
33617
33618
33619
33620
33621
33622
33623
33624
33625
33626
33627
33628
33629
33630
33631
33632
33633
33634
33635
33636
33637
33638
33639
33640
33641
33642
33643
33644
33645
33646
33647
33648
33649
33650
33651
33652
33653
33654
33655
33656
33657
33658
33659
33660
33661
33662
33663
33664
33665
33666
33667
33668
33669
33670
33671
33672
33673
33674
33675
33676
33677
33678
33679
33680
33681
33682
33683
33684
33685
33686
33687
33688
33689
33690
33691
33692
33693
33694
33695
33696
33697
33698
33699
33700
33701
33702
33703
33704
33705
33706
33707
33708
33709
33710
33711
33712
33713
33714
33715
33716
33717
33718
33719
33720
33721
33722
33723
33724
33725
33726
33727
33728
33729
33730
33731
33732
33733
33734
33735
33736
33737
33738
33739
33740
33741
33742
33743
33744
33745
33746
33747
33748
33749
33750
33751
33752
33753
33754
33755
33756
33757
33758
33759
33760
33761
33762
33763
33764
33765
33766
33767
33768
33769
33770
33771
33772
33773
33774
33775
33776
33777
33778
33779
33780
33781
33782
33783
33784
33785
33786
33787
33788
33789
33790
33791
33792
33793
33794
33795
33796
33797
33798
33799
33800
33801
33802
33803
33804
33805
33806
33807
33808
33809
33810
33811
33812
33813
33814
33815
33816
33817
33818
33819
33820
33821
33822
33823
33824
33825
33826
33827
33828
33829
33830
33831
33832
33833
33834
33835
33836
33837
33838
33839
33840
33841
33842
33843
33844
33845
33846
33847
33848
33849
33850
33851
33852
33853
33854
33855
33856
33857
33858
33859
33860
33861
33862
33863
33864
33865
33866
33867
33868
33869
33870
33871
33872
33873
33874
33875
33876
33877
33878
33879
33880
33881
33882
33883
33884
33885
33886
33887
33888
33889
33890
33891
33892
33893
33894
33895
33896
33897
33898
33899
33900
33901
33902
33903
33904
33905
33906
33907
33908
33909
33910
33911
33912
33913
33914
33915
33916
33917
33918
33919
33920
33921
33922
33923
33924
33925
33926
33927
33928
33929
33930
33931
33932
33933
33934
33935
33936
33937
33938
33939
33940
33941
33942
33943
33944
33945
33946
33947
33948
33949
33950
33951
33952
33953
33954
33955
33956
33957
33958
33959
33960
33961
33962
33963
33964
33965
33966
33967
33968
33969
33970
33971
33972
33973
33974
33975
33976
33977
33978
33979
33980
33981
33982
33983
33984
33985
33986
33987
33988
33989
33990
33991
33992
33993
33994
33995
33996
33997
33998
33999
34000
34001
34002
34003
34004
34005
34006
34007
34008
34009
34010
34011
34012
34013
34014
34015
34016
34017
34018
34019
34020
34021
34022
34023
34024
34025
34026
34027
34028
34029
34030
34031
34032
34033
34034
34035
34036
34037
34038
34039
34040
34041
34042
34043
34044
34045
34046
34047
34048
34049
34050
34051
34052
34053
34054
34055
34056
34057
34058
34059
34060
34061
34062
34063
34064
34065
34066
34067
34068
34069
34070
34071
34072
34073
34074
34075
34076
34077
34078
34079
34080
34081
34082
34083
34084
34085
34086
34087
34088
34089
34090
34091
34092
34093
34094
34095
34096
34097
34098
34099
34100
34101
34102
34103
34104
34105
34106
34107
34108
34109
34110
34111
34112
34113
34114
34115
34116
34117
34118
34119
34120
34121
34122
34123
34124
34125
34126
34127
34128
34129
34130
34131
34132
34133
34134
34135
34136
34137
34138
34139
34140
34141
34142
34143
34144
34145
34146
34147
34148
34149
34150
34151
34152
34153
34154
34155
34156
34157
34158
34159
34160
34161
34162
34163
34164
34165
34166
34167
34168
34169
34170
34171
34172
34173
34174
34175
34176
34177
34178
34179
34180
34181
34182
34183
34184
34185
34186
34187
34188
34189
34190
34191
34192
34193
34194
34195
34196
34197
34198
34199
34200
34201
34202
34203
34204
34205
34206
34207
34208
34209
34210
34211
34212
34213
34214
34215
34216
34217
34218
34219
34220
34221
34222
34223
34224
34225
34226
34227
34228
34229
34230
34231
34232
34233
34234
34235
34236
34237
34238
34239
34240
34241
34242
34243
34244
34245
34246
34247
34248
34249
34250
34251
34252
34253
34254
34255
34256
34257
34258
34259
34260
34261
34262
34263
34264
34265
34266
34267
34268
34269
34270
34271
34272
34273
34274
34275
34276
34277
34278
34279
34280
34281
34282
34283
34284
34285
34286
34287
34288
34289
34290
34291
34292
34293
34294
34295
34296
34297
34298
34299
34300
34301
34302
34303
34304
34305
34306
34307
34308
34309
34310
34311
34312
34313
34314
34315
34316
34317
34318
34319
34320
34321
34322
34323
34324
34325
34326
34327
34328
34329
34330
34331
34332
34333
34334
34335
34336
34337
34338
34339
34340
34341
34342
34343
34344
34345
34346
34347
34348
34349
34350
34351
34352
34353
34354
34355
34356
34357
34358
34359
34360
34361
34362
34363
34364
34365
34366
34367
34368
34369
34370
34371
34372
34373
34374
34375
34376
34377
34378
34379
34380
34381
34382
34383
34384
34385
34386
34387
34388
34389
34390
34391
34392
34393
34394
34395
34396
34397
34398
34399
34400
34401
34402
34403
34404
34405
34406
34407
34408
34409
34410
34411
34412
34413
34414
34415
34416
34417
34418
34419
34420
34421
34422
34423
34424
34425
34426
34427
34428
34429
34430
34431
34432
34433
34434
34435
34436
34437
34438
34439
34440
34441
34442
34443
34444
34445
34446
34447
34448
34449
34450
34451
34452
34453
34454
34455
34456
34457
34458
34459
34460
34461
34462
34463
34464
34465
34466
34467
34468
34469
34470
34471
34472
34473
34474
34475
34476
34477
34478
34479
34480
34481
34482
34483
34484
34485
34486
34487
34488
34489
34490
34491
34492
34493
34494
34495
34496
34497
34498
34499
34500
34501
34502
34503
34504
34505
34506
34507
34508
34509
34510
34511
34512
34513
34514
34515
34516
34517
34518
34519
34520
34521
34522
34523
34524
34525
34526
34527
34528
34529
34530
34531
34532
34533
34534
34535
34536
34537
34538
34539
34540
34541
34542
34543
34544
34545
34546
34547
34548
34549
34550
34551
34552
34553
34554
34555
34556
34557
34558
34559
34560
34561
34562
34563
34564
34565
34566
34567
34568
34569
34570
34571
34572
34573
34574
34575
34576
34577
34578
34579
34580
34581
34582
34583
34584
34585
34586
34587
34588
34589
34590
34591
34592
34593
34594
34595
34596
34597
34598
34599
34600
34601
34602
34603
34604
34605
34606
34607
34608
34609
34610
34611
34612
34613
34614
34615
34616
34617
34618
34619
34620
34621
34622
34623
34624
34625
34626
34627
34628
34629
34630
34631
34632
34633
34634
34635
34636
34637
34638
34639
34640
34641
34642
34643
34644
34645
34646
34647
34648
34649
34650
34651
34652
34653
34654
34655
34656
34657
34658
34659
34660
34661
34662
34663
34664
34665
34666
34667
34668
34669
34670
34671
34672
34673
34674
34675
34676
34677
34678
34679
34680
34681
34682
34683
34684
34685
34686
34687
34688
34689
34690
34691
34692
34693
34694
34695
34696
34697
34698
34699
34700
34701
34702
34703
34704
34705
34706
34707
34708
34709
34710
34711
34712
34713
34714
34715
34716
34717
34718
34719
34720
34721
34722
34723
34724
34725
34726
34727
34728
34729
34730
34731
34732
34733
34734
34735
34736
34737
34738
34739
34740
34741
34742
34743
34744
34745
34746
34747
34748
34749
34750
34751
34752
34753
34754
34755
34756
34757
34758
34759
34760
34761
34762
34763
34764
34765
34766
34767
34768
34769
34770
34771
34772
34773
34774
34775
34776
34777
34778
34779
34780
34781
34782
34783
34784
34785
34786
34787
34788
34789
34790
34791
34792
34793
34794
34795
34796
34797
34798
34799
34800
34801
34802
34803
34804
34805
34806
34807
34808
34809
34810
34811
34812
34813
34814
34815
34816
34817
34818
34819
34820
34821
34822
34823
34824
34825
34826
34827
34828
34829
34830
34831
34832
34833
34834
34835
34836
34837
34838
34839
34840
34841
34842
34843
34844
34845
34846
34847
34848
34849
34850
34851
34852
34853
34854
34855
34856
34857
34858
34859
34860
34861
34862
34863
34864
34865
34866
34867
34868
34869
34870
34871
34872
34873
34874
34875
34876
34877
34878
34879
34880
34881
34882
34883
34884
34885
34886
34887
34888
34889
34890
34891
34892
34893
34894
34895
34896
34897
34898
34899
34900
34901
34902
34903
34904
34905
34906
34907
34908
34909
34910
34911
34912
34913
34914
34915
34916
34917
34918
34919
34920
34921
34922
34923
34924
34925
34926
34927
34928
34929
34930
34931
34932
34933
34934
34935
34936
34937
34938
34939
34940
34941
34942
34943
34944
34945
34946
34947
34948
34949
34950
34951
34952
34953
34954
34955
34956
34957
34958
34959
34960
34961
34962
34963
34964
34965
34966
34967
34968
34969
34970
34971
34972
34973
34974
34975
34976
34977
34978
34979
34980
34981
34982
34983
34984
34985
34986
34987
34988
34989
34990
34991
34992
34993
34994
34995
34996
34997
34998
34999
35000
35001
35002
35003
35004
35005
35006
35007
35008
35009
35010
35011
35012
35013
35014
35015
35016
35017
35018
35019
35020
35021
35022
35023
35024
35025
35026
35027
35028
35029
35030
35031
35032
35033
35034
35035
35036
35037
35038
35039
35040
35041
35042
35043
35044
35045
35046
35047
35048
35049
35050
35051
35052
35053
35054
35055
35056
35057
35058
35059
35060
35061
35062
35063
35064
35065
35066
35067
35068
35069
35070
35071
35072
35073
35074
35075
35076
35077
35078
35079
35080
35081
35082
35083
35084
35085
35086
35087
35088
35089
35090
35091
35092
35093
35094
35095
35096
35097
35098
35099
35100
35101
35102
35103
35104
35105
35106
35107
35108
35109
35110
35111
35112
35113
35114
35115
35116
35117
35118
35119
35120
35121
35122
35123
35124
35125
35126
35127
35128
35129
35130
35131
35132
35133
35134
35135
35136
35137
35138
35139
35140
35141
35142
35143
35144
35145
35146
35147
35148
35149
35150
35151
35152
35153
35154
35155
35156
35157
35158
35159
35160
35161
35162
35163
35164
35165
35166
35167
35168
35169
35170
35171
35172
35173
35174
35175
35176
35177
35178
35179
35180
35181
35182
35183
35184
35185
35186
35187
35188
35189
35190
35191
35192
35193
35194
35195
35196
35197
35198
35199
35200
35201
35202
35203
35204
35205
35206
35207
35208
35209
35210
35211
35212
35213
35214
35215
35216
35217
35218
35219
35220
35221
35222
35223
35224
35225
35226
35227
35228
35229
35230
35231
35232
35233
35234
35235
35236
35237
35238
35239
35240
35241
35242
35243
35244
35245
35246
35247
35248
35249
35250
35251
35252
35253
35254
35255
35256
35257
35258
35259
35260
35261
35262
35263
35264
35265
35266
35267
35268
35269
35270
35271
35272
35273
35274
35275
35276
35277
35278
35279
35280
35281
35282
35283
35284
35285
35286
35287
35288
35289
35290
35291
35292
35293
35294
35295
35296
35297
35298
35299
35300
35301
35302
35303
35304
35305
35306
35307
35308
35309
35310
35311
35312
35313
35314
35315
35316
35317
35318
35319
35320
35321
35322
35323
35324
35325
35326
35327
35328
35329
35330
35331
35332
35333
35334
35335
35336
35337
35338
35339
35340
35341
35342
35343
35344
35345
35346
35347
35348
35349
35350
35351
35352
35353
35354
35355
35356
35357
35358
35359
35360
35361
35362
35363
35364
35365
35366
35367
35368
35369
35370
35371
35372
35373
35374
35375
35376
35377
35378
35379
35380
35381
35382
35383
35384
35385
35386
35387
35388
35389
35390
35391
35392
35393
35394
35395
35396
35397
35398
35399
35400
35401
35402
35403
35404
35405
35406
35407
35408
35409
35410
35411
35412
35413
35414
35415
35416
35417
35418
35419
35420
35421
35422
35423
35424
35425
35426
35427
35428
35429
35430
35431
35432
35433
35434
35435
35436
35437
35438
35439
35440
35441
35442
35443
35444
35445
35446
35447
35448
35449
35450
35451
35452
35453
35454
35455
35456
35457
35458
35459
35460
35461
35462
35463
35464
35465
35466
35467
35468
35469
35470
35471
35472
35473
35474
35475
35476
35477
35478
35479
35480
35481
35482
35483
35484
35485
35486
35487
35488
35489
35490
35491
35492
35493
35494
35495
35496
35497
35498
35499
35500
35501
35502
35503
35504
35505
35506
35507
35508
35509
35510
35511
35512
35513
35514
35515
35516
35517
35518
35519
35520
35521
35522
35523
35524
35525
35526
35527
35528
35529
35530
35531
35532
35533
35534
35535
35536
35537
35538
35539
35540
35541
35542
35543
35544
35545
35546
35547
35548
35549
35550
35551
35552
35553
35554
35555
35556
35557
35558
35559
35560
35561
35562
35563
35564
35565
35566
35567
35568
35569
35570
35571
35572
35573
35574
35575
35576
35577
35578
35579
35580
35581
35582
35583
35584
35585
35586
35587
35588
35589
35590
35591
35592
35593
35594
35595
35596
35597
35598
35599
35600
35601
35602
35603
35604
35605
35606
35607
35608
35609
35610
35611
35612
35613
35614
35615
35616
35617
35618
35619
35620
35621
35622
35623
35624
35625
35626
35627
35628
35629
35630
35631
35632
35633
35634
35635
35636
35637
35638
35639
35640
35641
35642
35643
35644
35645
35646
35647
35648
35649
35650
35651
35652
35653
35654
35655
35656
35657
35658
35659
35660
35661
35662
35663
35664
35665
35666
35667
35668
35669
35670
35671
35672
35673
35674
35675
35676
35677
35678
35679
35680
35681
35682
35683
35684
35685
35686
35687
35688
35689
35690
35691
35692
35693
35694
35695
35696
35697
35698
35699
35700
35701
35702
35703
35704
35705
35706
35707
35708
35709
35710
35711
35712
35713
35714
35715
35716
35717
35718
35719
35720
35721
35722
35723
35724
35725
35726
35727
35728
35729
35730
35731
35732
35733
35734
35735
35736
35737
35738
35739
35740
35741
35742
35743
35744
35745
35746
35747
35748
35749
35750
35751
35752
35753
35754
35755
35756
35757
35758
35759
35760
35761
35762
35763
35764
35765
35766
35767
35768
35769
35770
35771
35772
35773
35774
35775
35776
35777
35778
35779
35780
35781
35782
35783
35784
35785
35786
35787
35788
35789
35790
35791
35792
35793
35794
35795
35796
35797
35798
35799
35800
35801
35802
35803
35804
35805
35806
35807
35808
35809
35810
35811
35812
35813
35814
35815
35816
35817
35818
35819
35820
35821
35822
35823
35824
35825
35826
35827
35828
35829
35830
35831
35832
35833
35834
35835
35836
35837
35838
35839
35840
35841
35842
35843
35844
35845
35846
35847
35848
35849
35850
35851
35852
35853
35854
35855
35856
35857
35858
35859
35860
35861
35862
35863
35864
35865
35866
35867
35868
35869
35870
35871
35872
35873
35874
35875
35876
35877
35878
35879
35880
35881
35882
35883
35884
35885
35886
35887
35888
35889
35890
35891
35892
35893
35894
35895
35896
35897
35898
35899
35900
35901
35902
35903
35904
35905
35906
35907
35908
35909
35910
35911
35912
35913
35914
35915
35916
35917
35918
35919
35920
35921
35922
35923
35924
35925
35926
35927
35928
35929
35930
35931
35932
35933
35934
35935
35936
35937
35938
35939
35940
35941
35942
35943
35944
35945
35946
35947
35948
35949
35950
35951
35952
35953
35954
35955
35956
35957
35958
35959
35960
35961
35962
35963
35964
35965
35966
35967
35968
35969
35970
35971
35972
35973
35974
35975
35976
35977
35978
35979
35980
35981
35982
35983
35984
35985
35986
35987
35988
35989
35990
35991
35992
35993
35994
35995
35996
35997
35998
35999
36000
36001
36002
36003
36004
36005
36006
36007
36008
36009
36010
36011
36012
36013
36014
36015
36016
36017
36018
36019
36020
36021
36022
36023
36024
36025
36026
36027
36028
36029
36030
36031
36032
36033
36034
36035
36036
36037
36038
36039
36040
36041
36042
36043
36044
36045
36046
36047
36048
36049
36050
36051
36052
36053
36054
36055
36056
36057
36058
36059
36060
36061
36062
36063
36064
36065
36066
36067
36068
36069
36070
36071
36072
36073
36074
36075
36076
36077
36078
36079
36080
36081
36082
36083
36084
36085
36086
36087
36088
36089
36090
36091
36092
36093
36094
36095
36096
36097
36098
36099
36100
36101
36102
36103
36104
36105
36106
36107
36108
36109
36110
36111
36112
36113
36114
36115
36116
36117
36118
36119
36120
36121
36122
36123
36124
36125
36126
36127
36128
36129
36130
36131
36132
36133
36134
36135
36136
36137
36138
36139
36140
36141
36142
36143
36144
36145
36146
36147
36148
36149
36150
36151
36152
36153
36154
36155
36156
36157
36158
36159
36160
36161
36162
36163
36164
36165
36166
36167
36168
36169
36170
36171
36172
36173
36174
36175
36176
36177
36178
36179
36180
36181
36182
36183
36184
36185
36186
36187
36188
36189
36190
36191
36192
36193
36194
36195
36196
36197
36198
36199
36200
36201
36202
36203
36204
36205
36206
36207
36208
36209
36210
36211
36212
36213
36214
36215
36216
36217
36218
36219
36220
36221
36222
36223
36224
36225
36226
36227
36228
36229
36230
36231
36232
36233
36234
36235
36236
36237
36238
36239
36240
36241
36242
36243
36244
36245
36246
36247
36248
36249
36250
36251
36252
36253
36254
36255
36256
36257
36258
36259
36260
36261
36262
36263
36264
36265
36266
36267
36268
36269
36270
36271
36272
36273
36274
36275
36276
36277
36278
36279
36280
36281
36282
36283
36284
36285
36286
36287
36288
36289
36290
36291
36292
36293
36294
36295
36296
36297
36298
36299
36300
36301
36302
36303
36304
36305
36306
36307
36308
36309
36310
36311
36312
36313
36314
36315
36316
36317
36318
36319
36320
36321
36322
36323
36324
36325
36326
36327
36328
36329
36330
36331
36332
36333
36334
36335
36336
36337
36338
36339
36340
36341
36342
36343
36344
36345
36346
36347
36348
36349
36350
36351
36352
36353
36354
36355
36356
36357
36358
36359
36360
36361
36362
36363
36364
36365
36366
36367
36368
36369
36370
36371
36372
36373
36374
36375
36376
36377
36378
36379
36380
36381
36382
36383
36384
36385
36386
36387
36388
36389
36390
36391
36392
36393
36394
36395
36396
36397
36398
36399
36400
36401
36402
36403
36404
36405
36406
36407
36408
36409
36410
36411
36412
36413
36414
36415
36416
36417
36418
36419
36420
36421
36422
36423
36424
36425
36426
36427
36428
36429
36430
36431
36432
36433
36434
36435
36436
36437
36438
36439
36440
36441
36442
36443
36444
36445
36446
36447
36448
36449
36450
36451
36452
36453
36454
36455
36456
36457
36458
36459
36460
36461
36462
36463
36464
36465
36466
36467
36468
36469
36470
36471
36472
36473
36474
36475
36476
36477
36478
36479
36480
36481
36482
36483
36484
36485
36486
36487
36488
36489
36490
36491
36492
36493
36494
36495
36496
36497
36498
36499
36500
36501
36502
36503
36504
36505
36506
36507
36508
36509
36510
36511
36512
36513
36514
36515
36516
36517
36518
36519
36520
36521
36522
36523
36524
36525
36526
36527
36528
36529
36530
36531
36532
36533
36534
36535
36536
36537
36538
36539
36540
36541
36542
36543
36544
36545
36546
36547
36548
36549
36550
36551
36552
36553
36554
36555
36556
36557
36558
36559
36560
36561
36562
36563
36564
36565
36566
36567
36568
36569
36570
36571
36572
36573
36574
36575
36576
36577
36578
36579
36580
36581
36582
36583
36584
36585
36586
36587
36588
36589
36590
36591
36592
36593
36594
36595
36596
36597
36598
36599
36600
36601
36602
36603
36604
36605
36606
36607
36608
36609
36610
36611
36612
36613
36614
36615
36616
36617
36618
36619
36620
36621
36622
36623
36624
36625
36626
36627
36628
36629
36630
36631
36632
36633
36634
36635
36636
36637
36638
36639
36640
36641
36642
36643
36644
36645
36646
36647
36648
36649
36650
36651
36652
36653
36654
36655
36656
36657
36658
36659
36660
36661
36662
36663
36664
36665
36666
36667
36668
36669
36670
36671
36672
36673
36674
36675
36676
36677
36678
36679
36680
36681
36682
36683
36684
36685
36686
36687
36688
36689
36690
36691
36692
36693
36694
36695
36696
36697
36698
36699
36700
36701
36702
36703
36704
36705
36706
36707
36708
36709
36710
36711
36712
36713
36714
36715
36716
36717
36718
36719
36720
36721
36722
36723
36724
36725
36726
36727
36728
36729
36730
36731
36732
36733
36734
36735
36736
36737
36738
36739
36740
36741
36742
36743
36744
36745
36746
36747
36748
36749
36750
36751
36752
36753
36754
36755
36756
36757
36758
36759
36760
36761
36762
36763
36764
36765
36766
36767
36768
36769
36770
36771
36772
36773
36774
36775
36776
36777
36778
36779
36780
36781
36782
36783
36784
36785
36786
36787
36788
36789
36790
36791
36792
36793
36794
36795
36796
36797
36798
36799
36800
36801
36802
36803
36804
36805
36806
36807
36808
36809
36810
36811
36812
36813
36814
36815
36816
36817
36818
36819
36820
36821
36822
36823
36824
36825
36826
36827
36828
36829
36830
36831
36832
36833
36834
36835
36836
36837
36838
36839
36840
36841
36842
36843
36844
36845
36846
36847
36848
36849
36850
36851
36852
36853
36854
36855
36856
36857
36858
36859
36860
36861
36862
36863
36864
36865
36866
36867
36868
36869
36870
36871
36872
36873
36874
36875
36876
36877
36878
36879
36880
36881
36882
36883
36884
36885
36886
36887
36888
36889
36890
36891
36892
36893
36894
36895
36896
36897
36898
36899
36900
36901
36902
36903
36904
36905
36906
36907
36908
36909
36910
36911
36912
36913
36914
36915
36916
36917
36918
36919
36920
36921
36922
36923
36924
36925
36926
36927
36928
36929
36930
36931
36932
36933
36934
36935
36936
36937
36938
36939
36940
36941
36942
36943
36944
36945
36946
36947
36948
36949
36950
36951
36952
36953
36954
36955
36956
36957
36958
36959
36960
36961
36962
36963
36964
36965
36966
36967
36968
36969
36970
36971
36972
36973
36974
36975
36976
36977
36978
36979
36980
36981
36982
36983
36984
36985
36986
36987
36988
36989
36990
36991
36992
36993
36994
36995
36996
36997
36998
36999
37000
37001
37002
37003
37004
37005
37006
37007
37008
37009
37010
37011
37012
37013
37014
37015
37016
37017
37018
37019
37020
37021
37022
37023
37024
37025
37026
37027
37028
37029
37030
37031
37032
37033
37034
37035
37036
37037
37038
37039
37040
37041
37042
37043
37044
37045
37046
37047
37048
37049
37050
37051
37052
37053
37054
37055
37056
37057
37058
37059
37060
37061
37062
37063
37064
37065
37066
37067
37068
37069
37070
37071
37072
37073
37074
37075
37076
37077
37078
37079
37080
37081
37082
37083
37084
37085
37086
37087
37088
37089
37090
37091
37092
37093
37094
37095
37096
37097
37098
37099
37100
37101
37102
37103
37104
37105
37106
37107
37108
37109
37110
37111
37112
37113
37114
37115
37116
37117
37118
37119
37120
37121
37122
37123
37124
37125
37126
37127
37128
37129
37130
37131
37132
37133
37134
37135
37136
37137
37138
37139
37140
37141
37142
37143
37144
37145
37146
37147
37148
37149
37150
37151
37152
37153
37154
37155
37156
37157
37158
37159
37160
37161
37162
37163
37164
37165
37166
37167
37168
37169
37170
37171
37172
37173
37174
37175
37176
37177
37178
37179
37180
37181
37182
37183
37184
37185
37186
37187
37188
37189
37190
37191
37192
37193
37194
37195
37196
37197
37198
37199
37200
37201
37202
37203
37204
37205
37206
37207
37208
37209
37210
37211
37212
37213
37214
37215
37216
37217
37218
37219
37220
37221
37222
37223
37224
37225
37226
37227
37228
37229
37230
37231
37232
37233
37234
37235
37236
37237
37238
37239
37240
37241
37242
37243
37244
37245
37246
37247
37248
37249
37250
37251
37252
37253
37254
37255
37256
37257
37258
37259
37260
37261
37262
37263
37264
37265
37266
37267
37268
37269
37270
37271
37272
37273
37274
37275
37276
37277
37278
37279
37280
37281
37282
37283
37284
37285
37286
37287
37288
37289
37290
37291
37292
37293
37294
37295
37296
37297
37298
37299
37300
37301
37302
37303
37304
37305
37306
37307
37308
37309
37310
37311
37312
37313
37314
37315
37316
37317
37318
37319
37320
37321
37322
37323
37324
37325
37326
37327
37328
37329
37330
37331
37332
37333
37334
37335
37336
37337
37338
37339
37340
37341
37342
37343
37344
37345
37346
37347
37348
37349
37350
37351
37352
37353
37354
37355
37356
37357
37358
37359
37360
37361
37362
37363
37364
37365
37366
37367
37368
37369
37370
37371
37372
37373
37374
37375
37376
37377
37378
37379
37380
37381
37382
37383
37384
37385
37386
37387
37388
37389
37390
37391
37392
37393
37394
37395
37396
37397
37398
37399
37400
37401
37402
37403
37404
37405
37406
37407
37408
37409
37410
37411
37412
37413
37414
37415
37416
37417
37418
37419
37420
37421
37422
37423
37424
37425
37426
37427
37428
37429
37430
37431
37432
37433
37434
37435
37436
37437
37438
37439
37440
37441
37442
37443
37444
37445
37446
37447
37448
37449
37450
37451
37452
37453
37454
37455
37456
37457
37458
37459
37460
37461
37462
37463
37464
37465
37466
37467
37468
37469
37470
37471
37472
37473
37474
37475
37476
37477
37478
37479
37480
37481
37482
37483
37484
37485
37486
37487
37488
37489
37490
37491
37492
37493
37494
37495
37496
37497
37498
37499
37500
37501
37502
37503
37504
37505
37506
37507
37508
37509
37510
37511
37512
37513
37514
37515
37516
37517
37518
37519
37520
37521
37522
37523
37524
37525
37526
37527
37528
37529
37530
37531
37532
37533
37534
37535
37536
37537
37538
37539
37540
37541
37542
37543
37544
37545
37546
37547
37548
37549
37550
37551
37552
37553
37554
37555
37556
37557
37558
37559
37560
37561
37562
37563
37564
37565
37566
37567
37568
37569
37570
37571
37572
37573
37574
37575
37576
37577
37578
37579
37580
37581
37582
37583
37584
37585
37586
37587
37588
37589
37590
37591
37592
37593
37594
37595
37596
37597
37598
37599
37600
37601
37602
37603
37604
37605
37606
37607
37608
37609
37610
37611
37612
37613
37614
37615
37616
37617
37618
37619
37620
37621
37622
37623
37624
37625
37626
37627
37628
37629
37630
37631
37632
37633
37634
37635
37636
37637
37638
37639
37640
37641
37642
37643
37644
37645
37646
37647
37648
37649
37650
37651
37652
37653
37654
37655
37656
37657
37658
37659
37660
37661
37662
37663
37664
37665
37666
37667
37668
37669
37670
37671
37672
37673
37674
37675
37676
37677
37678
37679
37680
37681
37682
37683
37684
37685
37686
37687
37688
37689
37690
37691
37692
37693
37694
37695
37696
37697
37698
37699
37700
37701
37702
37703
37704
37705
37706
37707
37708
37709
37710
37711
37712
37713
37714
37715
37716
37717
37718
37719
37720
37721
37722
37723
37724
37725
37726
37727
37728
37729
37730
37731
37732
37733
37734
37735
37736
37737
37738
37739
37740
37741
37742
37743
37744
37745
37746
37747
37748
37749
37750
37751
37752
37753
37754
37755
37756
37757
37758
37759
37760
37761
37762
37763
37764
37765
37766
37767
37768
37769
37770
37771
37772
37773
37774
37775
37776
37777
37778
37779
37780
37781
37782
37783
37784
37785
37786
37787
37788
37789
37790
37791
37792
37793
37794
37795
37796
37797
37798
37799
37800
37801
37802
37803
37804
37805
37806
37807
37808
37809
37810
37811
37812
37813
37814
37815
37816
37817
37818
37819
37820
37821
37822
37823
37824
37825
37826
37827
37828
37829
37830
37831
37832
37833
37834
37835
37836
37837
37838
37839
37840
37841
37842
37843
37844
37845
37846
37847
37848
37849
37850
37851
37852
37853
37854
37855
37856
37857
37858
37859
37860
37861
37862
37863
37864
37865
37866
37867
37868
37869
37870
37871
37872
37873
37874
37875
37876
37877
37878
37879
37880
37881
37882
37883
37884
37885
37886
37887
37888
37889
37890
37891
37892
37893
37894
37895
37896
37897
37898
37899
37900
37901
37902
37903
37904
37905
37906
37907
37908
37909
37910
37911
37912
37913
37914
37915
37916
37917
37918
37919
37920
37921
37922
37923
37924
37925
37926
37927
37928
37929
37930
37931
37932
37933
37934
37935
37936
37937
37938
37939
37940
37941
37942
37943
37944
37945
37946
37947
37948
37949
37950
37951
37952
37953
37954
37955
37956
37957
37958
37959
37960
37961
37962
37963
37964
37965
37966
37967
37968
37969
37970
37971
37972
37973
37974
37975
37976
37977
37978
37979
37980
37981
37982
37983
37984
37985
37986
37987
37988
37989
37990
37991
37992
37993
37994
37995
37996
37997
37998
37999
38000
38001
38002
38003
38004
38005
38006
38007
38008
38009
38010
38011
38012
38013
38014
38015
38016
38017
38018
38019
38020
38021
38022
38023
38024
38025
38026
38027
38028
38029
38030
38031
38032
38033
38034
38035
38036
38037
38038
38039
38040
38041
38042
38043
38044
38045
38046
38047
38048
38049
38050
38051
38052
38053
38054
38055
38056
38057
38058
38059
38060
38061
38062
38063
38064
38065
38066
38067
38068
38069
38070
38071
38072
38073
38074
38075
38076
38077
38078
38079
38080
38081
38082
38083
38084
38085
38086
38087
38088
38089
38090
38091
38092
38093
38094
38095
38096
38097
38098
38099
38100
38101
38102
38103
38104
38105
38106
38107
38108
38109
38110
38111
38112
38113
38114
38115
38116
38117
38118
38119
38120
38121
38122
38123
38124
38125
38126
38127
38128
38129
38130
38131
38132
38133
38134
38135
38136
38137
38138
38139
38140
38141
38142
38143
38144
38145
38146
38147
38148
38149
38150
38151
38152
38153
38154
38155
38156
38157
38158
38159
38160
38161
38162
38163
38164
38165
38166
38167
38168
38169
38170
38171
38172
38173
38174
38175
38176
38177
38178
38179
38180
38181
38182
38183
38184
38185
38186
38187
38188
38189
38190
38191
38192
38193
38194
38195
38196
38197
38198
38199
38200
38201
38202
38203
38204
38205
38206
38207
38208
38209
38210
38211
38212
38213
38214
38215
38216
38217
38218
38219
38220
38221
38222
38223
38224
38225
38226
38227
38228
38229
38230
38231
38232
38233
38234
38235
38236
38237
38238
38239
38240
38241
38242
38243
38244
38245
38246
38247
38248
38249
38250
38251
38252
38253
38254
38255
38256
38257
38258
38259
38260
38261
38262
38263
38264
38265
38266
38267
38268
38269
38270
38271
38272
38273
38274
38275
38276
38277
38278
38279
38280
38281
38282
38283
38284
38285
38286
38287
38288
38289
38290
38291
38292
38293
38294
38295
38296
38297
38298
38299
38300
38301
38302
38303
38304
38305
38306
38307
38308
38309
38310
38311
38312
38313
38314
38315
38316
38317
38318
38319
38320
38321
38322
38323
38324
38325
38326
38327
38328
38329
38330
38331
38332
38333
38334
38335
38336
38337
38338
38339
38340
38341
38342
38343
38344
38345
38346
38347
38348
38349
38350
38351
38352
38353
38354
38355
38356
38357
38358
38359
38360
38361
38362
38363
38364
38365
38366
38367
38368
38369
38370
38371
38372
38373
38374
38375
38376
38377
38378
38379
38380
38381
38382
38383
38384
38385
38386
38387
38388
38389
38390
38391
38392
38393
38394
38395
38396
38397
38398
38399
38400
38401
38402
38403
38404
38405
38406
38407
38408
38409
38410
38411
38412
38413
38414
38415
38416
38417
38418
38419
38420
38421
38422
38423
38424
38425
38426
38427
38428
38429
38430
38431
38432
38433
38434
38435
38436
38437
38438
38439
38440
38441
38442
38443
38444
38445
38446
38447
38448
38449
38450
38451
38452
38453
38454
38455
38456
38457
38458
38459
38460
38461
38462
38463
38464
38465
38466
38467
38468
38469
38470
38471
38472
38473
38474
38475
38476
38477
38478
38479
38480
38481
38482
38483
38484
38485
38486
38487
38488
38489
38490
38491
38492
38493
38494
38495
38496
38497
38498
38499
38500
38501
38502
38503
38504
38505
38506
38507
38508
38509
38510
38511
38512
38513
38514
38515
38516
38517
38518
38519
38520
38521
38522
38523
38524
38525
38526
38527
38528
38529
38530
38531
38532
38533
38534
38535
38536
38537
38538
38539
38540
38541
38542
38543
38544
38545
38546
38547
38548
38549
38550
38551
38552
38553
38554
38555
38556
38557
38558
38559
38560
38561
38562
38563
38564
38565
38566
38567
38568
38569
38570
38571
38572
38573
38574
38575
38576
38577
38578
38579
38580
38581
38582
38583
38584
38585
38586
38587
38588
38589
38590
38591
38592
38593
38594
38595
38596
38597
38598
38599
38600
38601
38602
38603
38604
38605
38606
38607
38608
38609
38610
38611
38612
38613
38614
38615
38616
38617
38618
38619
38620
38621
38622
38623
38624
38625
38626
38627
38628
38629
38630
38631
38632
38633
38634
38635
38636
38637
38638
38639
38640
38641
38642
38643
38644
38645
38646
38647
38648
38649
38650
38651
38652
38653
38654
38655
38656
38657
38658
38659
38660
38661
38662
38663
38664
38665
38666
38667
38668
38669
38670
38671
38672
38673
38674
38675
38676
38677
38678
38679
38680
38681
38682
38683
38684
38685
38686
38687
38688
38689
38690
38691
38692
38693
38694
38695
38696
38697
38698
38699
38700
38701
38702
38703
38704
38705
38706
38707
38708
38709
38710
38711
38712
38713
38714
38715
38716
38717
38718
38719
38720
38721
38722
38723
38724
38725
38726
38727
38728
38729
38730
38731
38732
38733
38734
38735
38736
38737
38738
38739
38740
38741
38742
38743
38744
38745
38746
38747
38748
38749
38750
38751
38752
38753
38754
38755
38756
38757
38758
38759
38760
38761
38762
38763
38764
38765
38766
38767
38768
38769
38770
38771
38772
38773
38774
38775
38776
38777
38778
38779
38780
38781
38782
38783
38784
38785
38786
38787
38788
38789
38790
38791
38792
38793
38794
38795
38796
38797
38798
38799
38800
38801
38802
38803
38804
38805
38806
38807
38808
38809
38810
38811
38812
38813
38814
38815
38816
38817
38818
38819
38820
38821
38822
38823
38824
38825
38826
38827
38828
38829
38830
38831
38832
38833
38834
38835
38836
38837
38838
38839
38840
38841
38842
38843
38844
38845
38846
38847
38848
38849
38850
38851
38852
38853
38854
38855
38856
38857
38858
38859
38860
38861
38862
38863
38864
38865
38866
38867
38868
38869
38870
38871
38872
38873
38874
38875
38876
38877
38878
38879
38880
38881
38882
38883
38884
38885
38886
38887
38888
38889
38890
38891
38892
38893
38894
38895
38896
38897
38898
38899
38900
38901
38902
38903
38904
38905
38906
38907
38908
38909
38910
38911
38912
38913
38914
38915
38916
38917
38918
38919
38920
38921
38922
38923
38924
38925
38926
38927
38928
38929
38930
38931
38932
38933
38934
38935
38936
38937
38938
38939
38940
38941
38942
38943
38944
38945
38946
38947
38948
38949
38950
38951
38952
38953
38954
38955
38956
38957
38958
38959
38960
38961
38962
38963
38964
38965
38966
38967
38968
38969
38970
38971
38972
38973
38974
38975
38976
38977
38978
38979
38980
38981
38982
38983
38984
38985
38986
38987
38988
38989
38990
38991
38992
38993
38994
38995
38996
38997
38998
38999
39000
39001
39002
39003
39004
39005
39006
39007
39008
39009
39010
39011
39012
39013
39014
39015
39016
39017
39018
39019
39020
39021
39022
39023
39024
39025
39026
39027
39028
39029
39030
39031
39032
39033
39034
39035
39036
39037
39038
39039
39040
39041
39042
39043
39044
39045
39046
39047
39048
39049
39050
39051
39052
39053
39054
39055
39056
39057
39058
39059
39060
39061
39062
39063
39064
39065
39066
39067
39068
39069
39070
39071
39072
39073
39074
39075
39076
39077
39078
39079
39080
39081
39082
39083
39084
39085
39086
39087
39088
39089
39090
39091
39092
39093
39094
39095
39096
39097
39098
39099
39100
39101
39102
39103
39104
39105
39106
39107
39108
39109
39110
39111
39112
39113
39114
39115
39116
39117
39118
39119
39120
39121
39122
39123
39124
39125
39126
39127
39128
39129
39130
39131
39132
39133
39134
39135
39136
39137
39138
39139
39140
39141
39142
39143
39144
39145
39146
39147
39148
39149
39150
39151
39152
39153
39154
39155
39156
39157
39158
39159
39160
39161
39162
39163
39164
39165
39166
39167
39168
39169
39170
39171
39172
39173
39174
39175
39176
39177
39178
39179
39180
39181
39182
39183
39184
39185
39186
39187
39188
39189
39190
39191
39192
39193
39194
39195
39196
39197
39198
39199
39200
39201
39202
39203
39204
39205
39206
39207
39208
39209
39210
39211
39212
39213
39214
39215
39216
39217
39218
39219
39220
39221
39222
39223
39224
39225
39226
39227
39228
39229
39230
39231
39232
39233
39234
39235
39236
39237
39238
39239
39240
39241
39242
39243
39244
39245
39246
39247
39248
39249
39250
39251
39252
39253
39254
39255
39256
39257
39258
39259
39260
39261
39262
39263
39264
39265
39266
39267
39268
39269
39270
39271
39272
39273
39274
39275
39276
39277
39278
39279
39280
39281
39282
39283
39284
39285
39286
39287
39288
39289
39290
39291
39292
39293
39294
39295
39296
39297
39298
39299
39300
39301
39302
39303
39304
39305
39306
39307
39308
39309
39310
39311
39312
39313
39314
39315
39316
39317
39318
39319
39320
39321
39322
39323
39324
39325
39326
39327
39328
39329
39330
39331
39332
39333
39334
39335
39336
39337
39338
39339
39340
39341
39342
39343
39344
39345
39346
39347
39348
39349
39350
39351
39352
39353
39354
39355
39356
39357
39358
39359
39360
39361
39362
39363
39364
39365
39366
39367
39368
39369
39370
39371
39372
39373
39374
39375
39376
39377
39378
39379
39380
39381
39382
39383
39384
39385
39386
39387
39388
39389
39390
39391
39392
39393
39394
39395
39396
39397
39398
39399
39400
39401
39402
39403
39404
39405
39406
39407
39408
39409
39410
39411
39412
39413
39414
39415
39416
39417
39418
39419
39420
39421
39422
39423
39424
39425
39426
39427
39428
39429
39430
39431
39432
39433
39434
39435
39436
39437
39438
39439
39440
39441
39442
39443
39444
39445
39446
39447
39448
39449
39450
39451
39452
39453
39454
39455
39456
39457
39458
39459
39460
39461
39462
39463
39464
39465
39466
39467
39468
39469
39470
39471
39472
39473
39474
39475
39476
39477
39478
39479
39480
39481
39482
39483
39484
39485
39486
39487
39488
39489
39490
39491
39492
39493
39494
39495
39496
39497
39498
39499
39500
39501
39502
39503
39504
39505
39506
39507
39508
39509
39510
39511
39512
39513
39514
39515
39516
39517
39518
39519
39520
39521
39522
39523
39524
39525
39526
39527
39528
39529
39530
39531
39532
39533
39534
39535
39536
39537
39538
39539
39540
39541
39542
39543
39544
39545
39546
39547
39548
39549
39550
39551
39552
39553
39554
39555
39556
39557
39558
39559
39560
39561
39562
39563
39564
39565
39566
39567
39568
39569
39570
39571
39572
39573
39574
39575
39576
39577
39578
39579
39580
39581
39582
39583
39584
39585
39586
39587
39588
39589
39590
39591
39592
39593
39594
39595
39596
39597
39598
39599
39600
39601
39602
39603
39604
39605
39606
39607
39608
39609
39610
39611
39612
39613
39614
39615
39616
39617
39618
39619
39620
39621
39622
39623
39624
39625
39626
39627
39628
39629
39630
39631
39632
39633
39634
39635
39636
39637
39638
39639
39640
39641
39642
39643
39644
39645
39646
39647
39648
39649
39650
39651
39652
39653
39654
39655
39656
39657
39658
39659
39660
39661
39662
39663
39664
39665
39666
39667
39668
39669
39670
39671
39672
39673
39674
39675
39676
39677
39678
39679
39680
39681
39682
39683
39684
39685
39686
39687
39688
39689
39690
39691
39692
39693
39694
39695
39696
39697
39698
39699
39700
39701
39702
39703
39704
39705
39706
39707
39708
39709
39710
39711
39712
39713
39714
39715
39716
39717
39718
39719
39720
39721
39722
39723
39724
39725
39726
39727
39728
39729
39730
39731
39732
39733
39734
39735
39736
39737
39738
39739
39740
39741
39742
39743
39744
39745
39746
39747
39748
39749
39750
39751
39752
39753
39754
39755
39756
39757
39758
39759
39760
39761
39762
39763
39764
39765
39766
39767
39768
39769
39770
39771
39772
39773
39774
39775
39776
39777
39778
39779
39780
39781
39782
39783
39784
39785
39786
39787
39788
39789
39790
39791
39792
39793
39794
39795
39796
39797
39798
39799
39800
39801
39802
39803
39804
39805
39806
39807
39808
39809
39810
39811
39812
39813
39814
39815
39816
39817
39818
39819
39820
39821
39822
39823
39824
39825
39826
39827
39828
39829
39830
39831
39832
39833
39834
39835
39836
39837
39838
39839
39840
39841
39842
39843
39844
39845
39846
39847
39848
39849
39850
39851
39852
39853
39854
39855
39856
39857
39858
39859
39860
39861
39862
39863
39864
39865
39866
39867
39868
39869
39870
39871
39872
39873
39874
39875
39876
39877
39878
39879
39880
39881
39882
39883
39884
39885
39886
39887
39888
39889
39890
39891
39892
39893
39894
39895
39896
39897
39898
39899
39900
39901
39902
39903
39904
39905
39906
39907
39908
39909
39910
39911
39912
39913
39914
39915
39916
39917
39918
39919
39920
39921
39922
39923
39924
39925
39926
39927
39928
39929
39930
39931
39932
39933
39934
39935
39936
39937
39938
39939
39940
39941
39942
39943
39944
39945
39946
39947
39948
39949
39950
39951
39952
39953
39954
39955
39956
39957
39958
39959
39960
39961
39962
39963
39964
39965
39966
39967
39968
39969
39970
39971
39972
39973
39974
39975
39976
39977
39978
39979
39980
39981
39982
39983
39984
39985
39986
39987
39988
39989
39990
39991
39992
39993
39994
39995
39996
39997
39998
39999
40000
40001
40002
40003
40004
40005
40006
40007
40008
40009
40010
40011
40012
40013
40014
40015
40016
40017
40018
40019
40020
40021
40022
40023
40024
40025
40026
40027
40028
40029
40030
40031
40032
40033
40034
40035
40036
40037
40038
40039
40040
40041
40042
40043
40044
40045
40046
40047
40048
40049
40050
40051
40052
40053
40054
40055
40056
40057
40058
40059
40060
40061
40062
40063
40064
40065
40066
40067
40068
40069
40070
40071
40072
40073
40074
40075
40076
40077
40078
40079
40080
40081
40082
40083
40084
40085
40086
40087
40088
40089
40090
40091
40092
40093
40094
40095
40096
40097
40098
40099
40100
40101
40102
40103
40104
40105
40106
40107
40108
40109
40110
40111
40112
40113
40114
40115
40116
40117
40118
40119
40120
40121
40122
40123
40124
40125
40126
40127
40128
40129
40130
40131
40132
40133
40134
40135
40136
40137
40138
40139
40140
40141
40142
40143
40144
40145
40146
40147
40148
40149
40150
40151
40152
40153
40154
40155
40156
40157
40158
40159
40160
40161
40162
40163
40164
40165
40166
40167
40168
40169
40170
40171
40172
40173
40174
40175
40176
40177
40178
40179
40180
40181
40182
40183
40184
40185
40186
40187
40188
40189
40190
40191
40192
40193
40194
40195
40196
40197
40198
40199
40200
40201
40202
40203
40204
40205
40206
40207
40208
40209
40210
40211
40212
40213
40214
40215
40216
40217
40218
40219
40220
40221
40222
40223
40224
40225
40226
40227
40228
40229
40230
40231
40232
40233
40234
40235
40236
40237
40238
40239
40240
40241
40242
40243
40244
40245
40246
40247
40248
40249
40250
40251
40252
40253
40254
40255
40256
40257
40258
40259
40260
40261
40262
40263
40264
40265
40266
40267
40268
40269
40270
40271
40272
40273
40274
40275
40276
40277
40278
40279
40280
40281
40282
40283
40284
40285
40286
40287
40288
40289
40290
40291
40292
40293
40294
40295
40296
40297
40298
40299
40300
40301
40302
40303
40304
40305
40306
40307
40308
40309
40310
40311
40312
40313
40314
40315
40316
40317
40318
40319
40320
40321
40322
40323
40324
40325
40326
40327
40328
40329
40330
40331
40332
40333
40334
40335
40336
40337
40338
40339
40340
40341
40342
40343
40344
40345
40346
40347
40348
40349
40350
40351
40352
40353
40354
40355
40356
40357
40358
40359
40360
40361
40362
40363
40364
40365
40366
40367
40368
40369
40370
40371
40372
40373
40374
40375
40376
40377
40378
40379
40380
40381
40382
40383
40384
40385
40386
40387
40388
40389
40390
40391
40392
40393
40394
40395
40396
40397
40398
40399
40400
40401
40402
40403
40404
40405
40406
40407
40408
40409
40410
40411
40412
40413
40414
40415
40416
40417
40418
40419
40420
40421
40422
40423
40424
40425
40426
40427
40428
40429
40430
40431
40432
40433
40434
40435
40436
40437
40438
40439
40440
40441
40442
40443
40444
40445
40446
40447
40448
40449
40450
40451
40452
40453
40454
40455
40456
40457
40458
40459
40460
40461
40462
40463
40464
40465
40466
40467
40468
40469
40470
40471
40472
40473
40474
40475
40476
40477
40478
40479
40480
40481
40482
40483
40484
40485
40486
40487
40488
40489
40490
40491
40492
40493
40494
40495
40496
40497
40498
40499
40500
40501
40502
40503
40504
40505
40506
40507
40508
40509
40510
40511
40512
40513
40514
40515
40516
40517
40518
40519
40520
40521
40522
40523
40524
40525
40526
40527
40528
40529
40530
40531
40532
40533
40534
40535
40536
40537
40538
40539
40540
40541
40542
40543
40544
40545
40546
40547
40548
40549
40550
40551
40552
40553
40554
40555
40556
40557
40558
40559
40560
40561
40562
40563
40564
40565
40566
40567
40568
40569
40570
40571
40572
40573
40574
40575
40576
40577
40578
40579
40580
40581
40582
40583
40584
40585
40586
40587
40588
40589
40590
40591
40592
40593
40594
40595
40596
40597
40598
40599
40600
40601
40602
40603
40604
40605
40606
40607
40608
40609
40610
40611
40612
40613
40614
40615
40616
40617
40618
40619
40620
40621
40622
40623
40624
40625
40626
40627
40628
40629
40630
40631
40632
40633
40634
40635
40636
40637
40638
40639
40640
40641
40642
40643
40644
40645
40646
40647
40648
40649
40650
40651
40652
40653
40654
40655
40656
40657
40658
40659
40660
40661
40662
40663
40664
40665
40666
40667
40668
40669
40670
40671
40672
40673
40674
40675
40676
40677
40678
40679
40680
40681
40682
40683
40684
40685
40686
40687
40688
40689
40690
40691
40692
40693
40694
40695
40696
40697
40698
40699
40700
40701
40702
40703
40704
40705
40706
40707
40708
40709
40710
40711
40712
40713
40714
40715
40716
40717
40718
40719
40720
40721
40722
40723
40724
40725
40726
40727
40728
40729
40730
40731
40732
40733
40734
40735
40736
40737
40738
40739
40740
40741
40742
40743
40744
40745
40746
40747
40748
40749
40750
40751
40752
40753
40754
40755
40756
40757
40758
40759
40760
40761
40762
40763
40764
40765
40766
40767
40768
40769
40770
40771
40772
40773
40774
40775
40776
40777
40778
40779
40780
40781
40782
40783
40784
40785
40786
40787
40788
40789
40790
40791
40792
40793
40794
40795
40796
40797
40798
40799
40800
40801
40802
40803
40804
40805
40806
40807
40808
40809
40810
40811
40812
40813
40814
40815
40816
40817
40818
40819
40820
40821
40822
40823
40824
40825
40826
40827
40828
40829
40830
40831
40832
40833
40834
40835
40836
40837
40838
40839
40840
40841
40842
40843
40844
40845
40846
40847
40848
40849
40850
40851
40852
40853
40854
40855
40856
40857
40858
40859
40860
40861
40862
40863
40864
40865
40866
40867
40868
40869
40870
40871
40872
40873
40874
40875
40876
40877
40878
40879
40880
40881
40882
40883
40884
40885
40886
40887
40888
40889
40890
40891
40892
40893
40894
40895
40896
40897
40898
40899
40900
40901
40902
40903
40904
40905
40906
40907
40908
40909
40910
40911
40912
40913
40914
40915
40916
40917
40918
40919
40920
40921
40922
40923
40924
40925
40926
40927
40928
40929
40930
40931
40932
40933
40934
40935
40936
40937
40938
40939
40940
40941
40942
40943
40944
40945
40946
40947
40948
40949
40950
40951
40952
40953
40954
40955
40956
40957
40958
40959
40960
40961
40962
40963
40964
40965
40966
40967
40968
40969
40970
40971
40972
40973
40974
40975
40976
40977
40978
40979
40980
40981
40982
40983
40984
40985
40986
40987
40988
40989
40990
40991
40992
40993
40994
40995
40996
40997
40998
40999
41000
41001
41002
41003
41004
41005
41006
41007
41008
41009
41010
41011
41012
41013
41014
41015
41016
41017
41018
41019
41020
41021
41022
41023
41024
41025
41026
41027
41028
41029
41030
41031
41032
41033
41034
41035
41036
41037
41038
41039
41040
41041
41042
41043
41044
41045
41046
41047
41048
41049
41050
41051
41052
41053
41054
41055
41056
41057
41058
41059
41060
41061
41062
41063
41064
41065
41066
41067
41068
41069
41070
41071
41072
41073
41074
41075
41076
41077
41078
41079
41080
41081
41082
41083
41084
41085
41086
41087
41088
41089
41090
41091
41092
41093
41094
41095
41096
41097
41098
41099
41100
41101
41102
41103
41104
41105
41106
41107
41108
41109
41110
41111
41112
41113
41114
41115
41116
41117
41118
41119
41120
41121
41122
41123
41124
41125
41126
41127
41128
41129
41130
41131
41132
41133
41134
41135
41136
41137
41138
41139
41140
41141
41142
41143
41144
41145
41146
41147
41148
41149
41150
41151
41152
41153
41154
41155
41156
41157
41158
41159
41160
41161
41162
41163
41164
41165
41166
41167
41168
41169
41170
41171
41172
41173
41174
41175
41176
41177
41178
41179
41180
41181
41182
41183
41184
41185
41186
41187
41188
41189
41190
41191
41192
41193
41194
41195
41196
41197
41198
41199
41200
41201
41202
41203
41204
41205
41206
41207
41208
41209
41210
41211
41212
41213
41214
41215
41216
41217
41218
41219
41220
41221
41222
41223
41224
41225
41226
41227
41228
41229
41230
41231
41232
41233
41234
41235
41236
41237
41238
41239
41240
41241
41242
41243
41244
41245
41246
41247
41248
41249
41250
41251
41252
41253
41254
41255
41256
41257
41258
41259
41260
41261
41262
41263
41264
41265
41266
41267
41268
41269
41270
41271
41272
41273
41274
41275
41276
41277
41278
41279
41280
41281
41282
41283
41284
41285
41286
41287
41288
41289
41290
41291
41292
41293
41294
41295
41296
41297
41298
41299
41300
41301
41302
41303
41304
41305
41306
41307
41308
41309
41310
41311
41312
41313
41314
41315
41316
41317
41318
41319
41320
41321
41322
41323
41324
41325
41326
41327
41328
41329
41330
41331
41332
41333
41334
41335
41336
41337
41338
41339
41340
41341
41342
41343
41344
41345
41346
41347
41348
41349
41350
41351
41352
41353
41354
41355
41356
41357
41358
41359
41360
41361
41362
41363
41364
41365
41366
41367
41368
41369
41370
41371
41372
41373
41374
41375
41376
41377
41378
41379
41380
41381
41382
41383
41384
41385
41386
41387
41388
41389
41390
41391
41392
41393
41394
41395
41396
41397
41398
41399
41400
41401
41402
41403
41404
41405
41406
41407
41408
41409
41410
41411
41412
41413
41414
41415
41416
41417
41418
41419
41420
41421
41422
41423
41424
41425
41426
41427
41428
41429
41430
41431
41432
41433
41434
41435
41436
41437
41438
41439
41440
41441
41442
41443
41444
41445
41446
41447
41448
41449
41450
41451
41452
41453
41454
41455
41456
41457
41458
41459
41460
41461
41462
41463
41464
41465
41466
41467
41468
41469
41470
41471
41472
41473
41474
41475
41476
41477
41478
41479
41480
41481
41482
41483
41484
41485
41486
41487
41488
41489
41490
41491
41492
41493
41494
41495
41496
41497
41498
41499
41500
41501
41502
41503
41504
41505
41506
41507
41508
41509
41510
41511
41512
41513
41514
41515
41516
41517
41518
41519
41520
41521
41522
41523
41524
41525
41526
41527
41528
41529
41530
41531
41532
41533
41534
41535
41536
41537
41538
41539
41540
41541
41542
41543
41544
41545
41546
41547
41548
41549
41550
41551
41552
41553
41554
41555
41556
41557
41558
41559
41560
41561
41562
41563
41564
41565
41566
41567
41568
41569
41570
41571
41572
41573
41574
41575
41576
41577
41578
41579
41580
41581
41582
41583
41584
41585
41586
41587
41588
41589
41590
41591
41592
41593
41594
41595
41596
41597
41598
41599
41600
41601
41602
41603
41604
41605
41606
41607
41608
41609
41610
41611
41612
41613
41614
41615
41616
41617
41618
41619
41620
41621
41622
41623
41624
41625
41626
41627
41628
41629
41630
41631
41632
41633
41634
41635
41636
41637
41638
41639
41640
41641
41642
41643
41644
41645
41646
41647
41648
41649
41650
41651
41652
41653
41654
41655
41656
41657
41658
41659
41660
41661
41662
41663
41664
41665
41666
41667
41668
41669
41670
41671
41672
41673
41674
41675
41676
41677
41678
41679
41680
41681
41682
41683
41684
41685
41686
41687
41688
41689
41690
41691
41692
41693
41694
41695
41696
41697
41698
41699
41700
41701
41702
41703
41704
41705
41706
41707
41708
41709
41710
41711
41712
41713
41714
41715
41716
41717
41718
41719
41720
41721
41722
41723
41724
41725
41726
41727
41728
41729
41730
41731
41732
41733
41734
41735
41736
41737
41738
41739
41740
41741
41742
41743
41744
41745
41746
41747
41748
41749
41750
41751
41752
41753
41754
41755
41756
41757
41758
41759
41760
41761
41762
41763
41764
41765
41766
41767
41768
41769
41770
41771
41772
41773
41774
41775
41776
41777
41778
41779
41780
41781
41782
41783
41784
41785
41786
41787
41788
41789
41790
41791
41792
41793
41794
41795
41796
41797
41798
41799
41800
41801
41802
41803
41804
41805
41806
41807
41808
41809
41810
41811
41812
41813
41814
41815
41816
41817
41818
41819
41820
41821
41822
41823
41824
41825
41826
41827
41828
41829
41830
41831
41832
41833
41834
41835
41836
41837
41838
41839
41840
41841
41842
41843
41844
41845
41846
41847
41848
41849
41850
41851
41852
41853
41854
41855
41856
41857
41858
41859
41860
41861
41862
41863
41864
41865
41866
41867
41868
41869
41870
41871
41872
41873
41874
41875
41876
41877
41878
41879
41880
41881
41882
41883
41884
41885
41886
41887
41888
41889
41890
41891
41892
41893
41894
41895
41896
41897
41898
41899
41900
41901
41902
41903
41904
41905
41906
41907
41908
41909
41910
41911
41912
41913
41914
41915
41916
41917
41918
41919
41920
41921
41922
41923
41924
41925
41926
41927
41928
41929
41930
41931
41932
41933
41934
41935
41936
41937
41938
41939
41940
41941
41942
41943
41944
41945
41946
41947
41948
41949
41950
41951
41952
41953
41954
41955
41956
41957
41958
41959
41960
41961
41962
41963
41964
41965
41966
41967
41968
41969
41970
41971
41972
41973
41974
41975
41976
41977
41978
41979
41980
41981
41982
41983
41984
41985
41986
41987
41988
41989
41990
41991
41992
41993
41994
41995
41996
41997
41998
41999
42000
42001
42002
42003
42004
42005
42006
42007
42008
42009
42010
42011
42012
42013
42014
42015
42016
42017
42018
42019
42020
42021
42022
42023
42024
42025
42026
42027
42028
42029
42030
42031
42032
42033
42034
42035
42036
42037
42038
42039
42040
42041
42042
42043
42044
42045
42046
42047
42048
42049
42050
42051
42052
42053
42054
42055
42056
42057
42058
42059
42060
42061
42062
42063
42064
42065
42066
42067
42068
42069
42070
42071
42072
42073
42074
42075
42076
42077
42078
42079
42080
42081
42082
42083
42084
42085
42086
42087
42088
42089
42090
42091
42092
42093
42094
42095
42096
42097
42098
42099
42100
42101
42102
42103
42104
42105
42106
42107
42108
42109
42110
42111
42112
42113
42114
42115
42116
42117
42118
42119
42120
42121
42122
42123
42124
42125
42126
42127
42128
42129
42130
42131
42132
42133
42134
42135
42136
42137
42138
42139
42140
42141
42142
42143
42144
42145
42146
42147
42148
42149
42150
42151
42152
42153
42154
42155
42156
42157
42158
42159
42160
42161
42162
42163
42164
42165
42166
42167
42168
42169
42170
42171
42172
42173
42174
42175
42176
42177
42178
42179
42180
42181
42182
42183
42184
42185
42186
42187
42188
42189
42190
42191
42192
42193
42194
42195
42196
42197
42198
42199
42200
42201
42202
42203
42204
42205
42206
42207
42208
42209
42210
42211
42212
42213
42214
42215
42216
42217
42218
42219
42220
42221
42222
42223
42224
42225
42226
42227
42228
42229
42230
42231
42232
42233
42234
42235
42236
42237
42238
42239
42240
42241
42242
42243
42244
42245
42246
42247
42248
42249
42250
42251
42252
42253
42254
42255
42256
42257
42258
42259
42260
42261
42262
42263
42264
42265
42266
42267
42268
42269
42270
42271
42272
42273
42274
42275
42276
42277
42278
42279
42280
42281
42282
42283
42284
42285
42286
42287
42288
42289
42290
42291
42292
42293
42294
42295
42296
42297
42298
42299
42300
42301
42302
42303
42304
42305
42306
42307
42308
42309
42310
42311
42312
42313
42314
42315
42316
42317
42318
42319
42320
42321
42322
42323
42324
42325
42326
42327
42328
42329
42330
42331
42332
42333
42334
42335
42336
42337
42338
42339
42340
42341
42342
42343
42344
42345
42346
42347
42348
42349
42350
42351
42352
42353
42354
42355
42356
42357
42358
42359
42360
42361
42362
42363
42364
42365
42366
42367
42368
42369
42370
42371
42372
42373
42374
42375
42376
42377
42378
42379
42380
42381
42382
42383
42384
42385
42386
42387
42388
42389
42390
42391
42392
42393
42394
42395
42396
42397
42398
42399
42400
42401
42402
42403
42404
42405
42406
42407
42408
42409
42410
42411
42412
42413
42414
42415
42416
42417
42418
42419
42420
42421
42422
42423
42424
42425
42426
42427
42428
42429
42430
42431
42432
42433
42434
42435
42436
42437
42438
42439
42440
42441
42442
42443
42444
42445
42446
42447
42448
42449
42450
42451
42452
42453
42454
42455
42456
42457
42458
42459
42460
42461
42462
42463
42464
42465
42466
42467
42468
42469
42470
42471
42472
42473
42474
42475
42476
42477
42478
42479
42480
42481
42482
42483
42484
42485
42486
42487
42488
42489
42490
42491
42492
42493
42494
42495
42496
42497
42498
42499
42500
42501
42502
42503
42504
42505
42506
42507
42508
42509
42510
42511
42512
42513
42514
42515
42516
42517
42518
42519
42520
42521
42522
42523
42524
42525
42526
42527
42528
42529
42530
42531
42532
42533
42534
42535
42536
42537
42538
42539
42540
42541
42542
42543
42544
42545
42546
42547
42548
42549
42550
42551
42552
42553
42554
42555
42556
42557
42558
42559
42560
42561
42562
42563
42564
42565
42566
42567
42568
42569
42570
42571
42572
42573
42574
42575
42576
42577
42578
42579
42580
42581
42582
42583
42584
42585
42586
42587
42588
42589
42590
42591
42592
42593
42594
42595
42596
42597
42598
42599
42600
42601
42602
42603
42604
42605
42606
42607
42608
42609
42610
42611
42612
42613
42614
42615
42616
42617
42618
42619
42620
42621
42622
42623
42624
42625
42626
42627
42628
42629
42630
42631
42632
42633
42634
42635
42636
42637
42638
42639
42640
42641
42642
42643
42644
42645
42646
42647
42648
42649
42650
42651
42652
42653
42654
42655
42656
42657
42658
42659
42660
42661
42662
42663
42664
42665
42666
42667
42668
42669
42670
42671
42672
42673
42674
42675
42676
42677
42678
42679
42680
42681
42682
42683
42684
42685
42686
42687
42688
42689
42690
42691
42692
42693
42694
42695
42696
42697
42698
42699
42700
42701
42702
42703
42704
42705
42706
42707
42708
42709
42710
42711
42712
42713
42714
42715
42716
42717
42718
42719
42720
42721
42722
42723
42724
42725
42726
42727
42728
42729
42730
42731
42732
42733
42734
42735
42736
42737
42738
42739
42740
42741
42742
42743
42744
42745
42746
42747
42748
42749
42750
42751
42752
42753
42754
42755
42756
42757
42758
42759
42760
42761
42762
42763
42764
42765
42766
42767
42768
42769
42770
42771
42772
42773
42774
42775
42776
42777
42778
42779
42780
42781
42782
42783
42784
42785
42786
42787
42788
42789
42790
42791
42792
42793
42794
42795
42796
42797
42798
42799
42800
42801
42802
42803
42804
42805
42806
42807
42808
42809
42810
42811
42812
42813
42814
42815
42816
42817
42818
42819
42820
42821
42822
42823
42824
42825
42826
42827
42828
42829
42830
42831
42832
42833
42834
42835
42836
42837
42838
42839
42840
42841
42842
42843
42844
42845
42846
42847
42848
42849
42850
42851
42852
42853
42854
42855
42856
42857
42858
42859
42860
42861
42862
42863
42864
42865
42866
42867
42868
42869
42870
42871
42872
42873
42874
42875
42876
42877
42878
42879
42880
42881
42882
42883
42884
42885
42886
42887
42888
42889
42890
42891
42892
42893
42894
42895
42896
42897
42898
42899
42900
42901
42902
42903
42904
42905
42906
42907
42908
42909
42910
42911
42912
42913
42914
42915
42916
42917
42918
42919
42920
42921
42922
42923
42924
42925
42926
42927
42928
42929
42930
42931
42932
42933
42934
42935
42936
42937
42938
42939
42940
42941
42942
42943
42944
42945
42946
42947
42948
42949
42950
42951
42952
42953
42954
42955
42956
42957
42958
42959
42960
42961
42962
42963
42964
42965
42966
42967
42968
42969
42970
42971
42972
42973
42974
42975
42976
42977
42978
42979
42980
42981
42982
42983
42984
42985
42986
42987
42988
42989
42990
42991
42992
42993
42994
42995
42996
42997
42998
42999
43000
43001
43002
43003
43004
43005
43006
43007
43008
43009
43010
43011
43012
43013
43014
43015
43016
43017
43018
43019
43020
43021
43022
43023
43024
43025
43026
43027
43028
43029
43030
43031
43032
43033
43034
43035
43036
43037
43038
43039
43040
43041
43042
43043
43044
43045
43046
43047
43048
43049
43050
43051
43052
43053
43054
43055
43056
43057
43058
43059
43060
43061
43062
43063
43064
43065
43066
43067
43068
43069
43070
43071
43072
43073
43074
43075
43076
43077
43078
43079
43080
43081
43082
43083
43084
43085
43086
43087
43088
43089
43090
43091
43092
43093
43094
43095
43096
43097
43098
43099
43100
43101
43102
43103
43104
43105
43106
43107
43108
43109
43110
43111
43112
43113
43114
43115
43116
43117
43118
43119
43120
43121
43122
43123
43124
43125
43126
43127
43128
43129
43130
43131
43132
43133
43134
43135
43136
43137
43138
43139
43140
43141
43142
43143
43144
43145
43146
43147
43148
43149
43150
43151
43152
43153
43154
43155
43156
43157
43158
43159
43160
43161
43162
43163
43164
43165
43166
43167
43168
43169
43170
43171
43172
43173
43174
43175
43176
43177
43178
43179
43180
43181
43182
43183
43184
43185
43186
43187
43188
43189
43190
43191
43192
43193
43194
43195
43196
43197
43198
43199
43200
43201
43202
43203
43204
43205
43206
43207
43208
43209
43210
43211
43212
43213
43214
43215
43216
43217
43218
43219
43220
43221
43222
43223
43224
43225
43226
43227
43228
43229
43230
43231
43232
43233
43234
43235
43236
43237
43238
43239
43240
43241
43242
43243
43244
43245
43246
43247
43248
43249
43250
43251
43252
43253
43254
43255
43256
43257
43258
43259
43260
43261
43262
43263
43264
43265
43266
43267
43268
43269
43270
43271
43272
43273
43274
43275
43276
43277
43278
43279
43280
43281
43282
43283
43284
43285
43286
43287
43288
43289
43290
43291
43292
43293
43294
43295
43296
43297
43298
43299
43300
43301
43302
43303
43304
43305
43306
43307
43308
43309
43310
43311
43312
43313
43314
43315
43316
43317
43318
43319
43320
43321
43322
43323
43324
43325
43326
43327
43328
43329
43330
43331
43332
43333
43334
43335
43336
43337
43338
43339
43340
43341
43342
43343
43344
43345
43346
43347
43348
43349
43350
43351
43352
43353
43354
43355
43356
43357
43358
43359
43360
43361
43362
43363
43364
43365
43366
43367
43368
43369
43370
43371
43372
43373
43374
43375
43376
43377
43378
43379
43380
43381
43382
43383
43384
43385
43386
43387
43388
43389
43390
43391
43392
43393
43394
43395
43396
43397
43398
43399
43400
43401
43402
43403
43404
43405
43406
43407
43408
43409
43410
43411
43412
43413
43414
43415
43416
43417
43418
43419
43420
43421
43422
43423
43424
43425
43426
43427
43428
43429
43430
43431
43432
43433
43434
43435
43436
43437
43438
43439
43440
43441
43442
43443
43444
43445
43446
43447
43448
43449
43450
43451
43452
43453
43454
43455
43456
43457
43458
43459
43460
43461
43462
43463
43464
43465
43466
43467
43468
43469
43470
43471
43472
43473
43474
43475
43476
43477
43478
43479
43480
43481
43482
43483
43484
43485
43486
43487
43488
43489
43490
43491
43492
43493
43494
43495
43496
43497
43498
43499
43500
43501
43502
43503
43504
43505
43506
43507
43508
43509
43510
43511
43512
43513
43514
43515
43516
43517
43518
43519
43520
43521
43522
43523
43524
43525
43526
43527
43528
43529
43530
43531
43532
43533
43534
43535
43536
43537
43538
43539
43540
43541
43542
43543
43544
43545
43546
43547
43548
43549
43550
43551
43552
43553
43554
43555
43556
43557
43558
43559
43560
43561
43562
43563
43564
43565
43566
43567
43568
43569
43570
43571
43572
43573
43574
43575
43576
43577
43578
43579
43580
43581
43582
43583
43584
43585
43586
43587
43588
43589
43590
43591
43592
43593
43594
43595
43596
43597
43598
43599
43600
43601
43602
43603
43604
43605
43606
43607
43608
43609
43610
43611
43612
43613
43614
43615
43616
43617
43618
43619
43620
43621
43622
43623
43624
43625
43626
43627
43628
43629
43630
43631
43632
43633
43634
43635
43636
43637
43638
43639
43640
43641
43642
43643
43644
43645
43646
43647
43648
43649
43650
43651
43652
43653
43654
43655
43656
43657
43658
43659
43660
43661
43662
43663
43664
43665
43666
43667
43668
43669
43670
43671
43672
43673
43674
43675
43676
43677
43678
43679
43680
43681
43682
43683
43684
43685
43686
43687
43688
43689
43690
43691
43692
43693
43694
43695
43696
43697
43698
43699
43700
43701
43702
43703
43704
43705
43706
43707
43708
43709
43710
43711
43712
43713
43714
43715
43716
43717
43718
43719
43720
43721
43722
43723
43724
43725
43726
43727
43728
43729
43730
43731
43732
43733
43734
43735
43736
43737
43738
43739
43740
43741
43742
43743
43744
43745
43746
43747
43748
43749
43750
43751
43752
43753
43754
43755
43756
43757
43758
43759
43760
43761
43762
43763
43764
43765
43766
43767
43768
43769
43770
43771
43772
43773
43774
43775
43776
43777
43778
43779
43780
43781
43782
43783
43784
43785
43786
43787
43788
43789
43790
43791
43792
43793
43794
43795
43796
43797
43798
43799
43800
43801
43802
43803
43804
43805
43806
43807
43808
43809
43810
43811
43812
43813
43814
43815
43816
43817
43818
43819
43820
43821
43822
43823
43824
43825
43826
43827
43828
43829
43830
43831
43832
43833
43834
43835
43836
43837
43838
43839
43840
43841
43842
43843
43844
43845
43846
43847
43848
43849
43850
43851
43852
43853
43854
43855
43856
43857
43858
43859
43860
43861
43862
43863
43864
43865
43866
43867
43868
43869
43870
43871
43872
43873
43874
43875
43876
43877
43878
43879
43880
43881
43882
43883
43884
43885
43886
43887
43888
43889
43890
43891
43892
43893
43894
43895
43896
43897
43898
43899
43900
43901
43902
43903
43904
43905
43906
43907
43908
43909
43910
43911
43912
43913
43914
43915
43916
43917
43918
43919
43920
43921
43922
43923
43924
43925
43926
43927
43928
43929
43930
43931
43932
43933
43934
43935
43936
43937
43938
43939
43940
43941
43942
43943
43944
43945
43946
43947
43948
43949
43950
43951
43952
43953
43954
43955
43956
43957
43958
43959
43960
43961
43962
43963
43964
43965
43966
43967
43968
43969
43970
43971
43972
43973
43974
43975
43976
43977
43978
43979
43980
43981
43982
43983
43984
43985
43986
43987
43988
43989
43990
43991
43992
43993
43994
43995
43996
43997
43998
43999
44000
44001
44002
44003
44004
44005
44006
44007
44008
44009
44010
44011
44012
44013
44014
44015
44016
44017
44018
44019
44020
44021
44022
44023
44024
44025
44026
44027
44028
44029
44030
44031
44032
44033
44034
44035
44036
44037
44038
44039
44040
44041
44042
44043
44044
44045
44046
44047
44048
44049
44050
44051
44052
44053
44054
44055
44056
44057
44058
44059
44060
44061
44062
44063
44064
44065
44066
44067
44068
44069
44070
44071
44072
44073
44074
44075
44076
44077
44078
44079
44080
44081
44082
44083
44084
44085
44086
44087
44088
44089
44090
44091
44092
44093
44094
44095
44096
44097
44098
44099
44100
44101
44102
44103
44104
44105
44106
44107
44108
44109
44110
44111
44112
44113
44114
44115
44116
44117
44118
44119
44120
44121
44122
44123
44124
44125
44126
44127
44128
44129
44130
44131
44132
44133
44134
44135
44136
44137
44138
44139
44140
44141
44142
44143
44144
44145
44146
44147
44148
44149
44150
44151
44152
44153
44154
44155
44156
44157
44158
44159
44160
44161
44162
44163
44164
44165
44166
44167
44168
44169
44170
44171
44172
44173
44174
44175
44176
44177
44178
44179
44180
44181
44182
44183
44184
44185
44186
44187
44188
44189
44190
44191
44192
44193
44194
44195
44196
44197
44198
44199
44200
44201
44202
44203
44204
44205
44206
44207
44208
44209
44210
44211
44212
44213
44214
44215
44216
44217
44218
44219
44220
44221
44222
44223
44224
44225
44226
44227
44228
44229
44230
44231
44232
44233
44234
44235
44236
44237
44238
44239
44240
44241
44242
44243
44244
44245
44246
44247
44248
44249
44250
44251
44252
44253
44254
44255
44256
44257
44258
44259
44260
44261
44262
44263
44264
44265
44266
44267
44268
44269
44270
44271
44272
44273
44274
44275
44276
44277
44278
44279
44280
44281
44282
44283
44284
44285
44286
44287
44288
44289
44290
44291
44292
44293
44294
44295
44296
44297
44298
44299
44300
44301
44302
44303
44304
44305
44306
44307
44308
44309
44310
44311
44312
44313
44314
44315
44316
44317
44318
44319
44320
44321
44322
44323
44324
44325
44326
44327
44328
44329
44330
44331
44332
44333
44334
44335
44336
44337
44338
44339
44340
44341
44342
44343
44344
44345
44346
44347
44348
44349
44350
44351
44352
44353
44354
44355
44356
44357
44358
44359
44360
44361
44362
44363
44364
44365
44366
44367
44368
44369
44370
44371
44372
44373
44374
44375
44376
44377
44378
44379
44380
44381
44382
44383
44384
44385
44386
44387
44388
44389
44390
44391
44392
44393
44394
44395
44396
44397
44398
44399
44400
44401
44402
44403
44404
44405
44406
44407
44408
44409
44410
44411
44412
44413
44414
44415
44416
44417
44418
44419
44420
44421
44422
44423
44424
44425
44426
44427
44428
44429
44430
44431
44432
44433
44434
44435
44436
44437
44438
44439
44440
44441
44442
44443
44444
44445
44446
44447
44448
44449
44450
44451
44452
44453
44454
44455
44456
44457
44458
44459
44460
44461
44462
44463
44464
44465
44466
44467
44468
44469
44470
44471
44472
44473
44474
44475
44476
44477
44478
44479
44480
44481
44482
44483
44484
44485
44486
44487
44488
44489
44490
44491
44492
44493
44494
44495
44496
44497
44498
44499
44500
44501
44502
44503
44504
44505
44506
44507
44508
44509
44510
44511
44512
44513
44514
44515
44516
44517
44518
44519
44520
44521
44522
44523
44524
44525
44526
44527
44528
44529
44530
44531
44532
44533
44534
44535
44536
44537
44538
44539
44540
44541
44542
44543
44544
44545
44546
44547
44548
44549
44550
44551
44552
44553
44554
44555
44556
44557
44558
44559
44560
44561
44562
44563
44564
44565
44566
44567
44568
44569
44570
44571
44572
44573
44574
44575
44576
44577
44578
44579
44580
44581
44582
44583
44584
44585
44586
44587
44588
44589
44590
44591
44592
44593
44594
44595
44596
44597
44598
44599
44600
44601
44602
44603
44604
44605
44606
44607
44608
44609
44610
44611
44612
44613
44614
44615
44616
44617
44618
44619
44620
44621
44622
44623
44624
44625
44626
44627
44628
44629
44630
44631
44632
44633
44634
44635
44636
44637
44638
44639
44640
44641
44642
44643
44644
44645
44646
44647
44648
44649
44650
44651
44652
44653
44654
44655
44656
44657
44658
44659
44660
44661
44662
44663
44664
44665
44666
44667
44668
44669
44670
44671
44672
44673
44674
44675
44676
44677
44678
44679
44680
44681
44682
44683
44684
44685
44686
44687
44688
44689
44690
44691
44692
44693
44694
44695
44696
44697
44698
44699
44700
44701
44702
44703
44704
44705
44706
44707
44708
44709
44710
44711
44712
44713
44714
44715
44716
44717
44718
44719
44720
44721
44722
44723
44724
44725
44726
44727
44728
44729
44730
44731
44732
44733
44734
44735
44736
44737
44738
44739
44740
44741
44742
44743
44744
44745
44746
44747
44748
44749
44750
44751
44752
44753
44754
44755
44756
44757
44758
44759
44760
44761
44762
44763
44764
44765
44766
44767
44768
44769
44770
44771
44772
44773
44774
44775
44776
44777
44778
44779
44780
44781
44782
44783
44784
44785
44786
44787
44788
44789
44790
44791
44792
44793
44794
44795
44796
44797
44798
44799
44800
44801
44802
44803
44804
44805
44806
44807
44808
44809
44810
44811
44812
44813
44814
44815
44816
44817
44818
44819
44820
44821
44822
44823
44824
44825
44826
44827
44828
44829
44830
44831
44832
44833
44834
44835
44836
44837
44838
44839
44840
44841
44842
44843
44844
44845
44846
44847
44848
44849
44850
44851
44852
44853
44854
44855
44856
44857
44858
44859
44860
44861
44862
44863
44864
44865
44866
44867
44868
44869
44870
44871
44872
44873
44874
44875
44876
44877
44878
44879
44880
44881
44882
44883
44884
44885
44886
44887
44888
44889
44890
44891
44892
44893
44894
44895
44896
44897
44898
44899
44900
44901
44902
44903
44904
44905
44906
44907
44908
44909
44910
44911
44912
44913
44914
44915
44916
44917
44918
44919
44920
44921
44922
44923
44924
44925
44926
44927
44928
44929
44930
44931
44932
44933
44934
44935
44936
44937
44938
44939
44940
44941
44942
44943
44944
44945
44946
44947
44948
44949
44950
44951
44952
44953
44954
44955
44956
44957
44958
44959
44960
44961
44962
44963
44964
44965
44966
44967
44968
44969
44970
44971
44972
44973
44974
44975
44976
44977
44978
44979
44980
44981
44982
44983
44984
44985
44986
44987
44988
44989
44990
44991
44992
44993
44994
44995
44996
44997
44998
44999
45000
45001
45002
45003
45004
45005
45006
45007
45008
45009
45010
45011
45012
45013
45014
45015
45016
45017
45018
45019
45020
45021
45022
45023
45024
45025
45026
45027
45028
45029
45030
45031
45032
45033
45034
45035
45036
45037
45038
45039
45040
45041
45042
45043
45044
45045
45046
45047
45048
45049
45050
45051
45052
45053
45054
45055
45056
45057
45058
45059
45060
45061
45062
45063
45064
45065
45066
45067
45068
45069
45070
45071
45072
45073
45074
45075
45076
45077
45078
45079
45080
45081
45082
45083
45084
45085
45086
45087
45088
45089
45090
45091
45092
45093
45094
45095
45096
45097
45098
45099
45100
45101
45102
45103
45104
45105
45106
45107
45108
45109
45110
45111
45112
45113
45114
45115
45116
45117
45118
45119
45120
45121
45122
45123
45124
45125
45126
45127
45128
45129
45130
45131
45132
45133
45134
45135
45136
45137
45138
45139
45140
45141
45142
45143
45144
45145
45146
45147
45148
45149
45150
45151
45152
45153
45154
45155
45156
45157
45158
45159
45160
45161
45162
45163
45164
45165
45166
45167
45168
45169
45170
45171
45172
45173
45174
45175
45176
45177
45178
45179
45180
45181
45182
45183
45184
45185
45186
45187
45188
45189
45190
45191
45192
45193
45194
45195
45196
45197
45198
45199
45200
45201
45202
45203
45204
45205
45206
45207
45208
45209
45210
45211
45212
45213
45214
45215
45216
45217
45218
45219
45220
45221
45222
45223
45224
45225
45226
45227
45228
45229
45230
45231
45232
45233
45234
45235
45236
45237
45238
45239
45240
45241
45242
45243
45244
45245
45246
45247
45248
45249
45250
45251
45252
45253
45254
45255
45256
45257
45258
45259
45260
45261
45262
45263
45264
45265
45266
45267
45268
45269
45270
45271
45272
45273
45274
45275
45276
45277
45278
45279
45280
45281
45282
45283
45284
45285
45286
45287
45288
45289
45290
45291
45292
45293
45294
45295
45296
45297
45298
45299
45300
45301
45302
45303
45304
45305
45306
45307
45308
45309
45310
45311
45312
45313
45314
45315
45316
45317
45318
45319
45320
45321
45322
45323
45324
45325
45326
45327
45328
45329
45330
45331
45332
45333
45334
45335
45336
45337
45338
45339
45340
45341
45342
45343
45344
45345
45346
45347
45348
45349
45350
45351
45352
45353
45354
45355
45356
45357
45358
45359
45360
45361
45362
45363
45364
45365
45366
45367
45368
45369
45370
45371
45372
45373
45374
45375
45376
45377
45378
45379
45380
45381
45382
45383
45384
45385
45386
45387
45388
45389
45390
45391
45392
45393
45394
45395
45396
45397
45398
45399
45400
45401
45402
45403
45404
45405
45406
45407
45408
45409
45410
45411
45412
45413
45414
45415
45416
45417
45418
45419
45420
45421
45422
45423
45424
45425
45426
45427
45428
45429
45430
45431
45432
45433
45434
45435
45436
45437
45438
45439
45440
45441
45442
45443
45444
45445
45446
45447
45448
45449
45450
45451
45452
45453
45454
45455
45456
45457
45458
45459
45460
45461
45462
45463
45464
45465
45466
45467
45468
45469
45470
45471
45472
45473
45474
45475
45476
45477
45478
45479
45480
45481
45482
45483
45484
45485
45486
45487
45488
45489
45490
45491
45492
45493
45494
45495
45496
45497
45498
45499
45500
45501
45502
45503
45504
45505
45506
45507
45508
45509
45510
45511
45512
45513
45514
45515
45516
45517
45518
45519
45520
45521
45522
45523
45524
45525
45526
45527
45528
45529
45530
45531
45532
45533
45534
45535
45536
45537
45538
45539
45540
45541
45542
45543
45544
45545
45546
45547
45548
45549
45550
45551
45552
45553
45554
45555
45556
45557
45558
45559
45560
45561
45562
45563
45564
45565
45566
45567
45568
45569
45570
45571
45572
45573
45574
45575
45576
45577
45578
45579
45580
45581
45582
45583
45584
45585
45586
45587
45588
45589
45590
45591
45592
45593
45594
45595
45596
45597
45598
45599
45600
45601
45602
45603
45604
45605
45606
45607
45608
45609
45610
45611
45612
45613
45614
45615
45616
45617
45618
45619
45620
45621
45622
45623
45624
45625
45626
45627
45628
45629
45630
45631
45632
45633
45634
45635
45636
45637
45638
45639
45640
45641
45642
45643
45644
45645
45646
45647
45648
45649
45650
45651
45652
45653
45654
45655
45656
45657
45658
45659
45660
45661
45662
45663
45664
45665
45666
45667
45668
45669
45670
45671
45672
45673
45674
45675
45676
45677
45678
45679
45680
45681
45682
45683
45684
45685
45686
45687
45688
45689
45690
45691
45692
45693
45694
45695
45696
45697
45698
45699
45700
45701
45702
45703
45704
45705
45706
45707
45708
45709
45710
45711
45712
45713
45714
45715
45716
45717
45718
45719
45720
45721
45722
45723
45724
45725
45726
45727
45728
45729
45730
45731
45732
45733
45734
45735
45736
45737
45738
45739
45740
45741
45742
45743
45744
45745
45746
45747
45748
45749
45750
45751
45752
45753
45754
45755
45756
45757
45758
45759
45760
45761
45762
45763
45764
45765
45766
45767
45768
45769
45770
45771
45772
45773
45774
45775
45776
45777
45778
45779
45780
45781
45782
45783
45784
45785
45786
45787
45788
45789
45790
45791
45792
45793
45794
45795
45796
45797
45798
45799
45800
45801
45802
45803
45804
45805
45806
45807
45808
45809
45810
45811
45812
45813
45814
45815
45816
45817
45818
45819
45820
45821
45822
45823
45824
45825
45826
45827
45828
45829
45830
45831
45832
45833
45834
45835
45836
45837
45838
45839
45840
45841
45842
45843
45844
45845
45846
45847
45848
45849
45850
45851
45852
45853
45854
45855
45856
45857
45858
45859
45860
45861
45862
45863
45864
45865
45866
45867
45868
45869
45870
45871
45872
45873
45874
45875
45876
45877
45878
45879
45880
45881
45882
45883
45884
45885
45886
45887
45888
45889
45890
45891
45892
45893
45894
45895
45896
45897
45898
45899
45900
45901
45902
45903
45904
45905
45906
45907
45908
45909
45910
45911
45912
45913
45914
45915
45916
45917
45918
45919
45920
45921
45922
45923
45924
45925
45926
45927
45928
45929
45930
45931
45932
45933
45934
45935
45936
45937
45938
45939
45940
45941
45942
45943
45944
45945
45946
45947
45948
45949
45950
45951
45952
45953
45954
45955
45956
45957
45958
45959
45960
45961
45962
45963
45964
45965
45966
45967
45968
45969
45970
45971
45972
45973
45974
45975
45976
45977
45978
45979
45980
45981
45982
45983
45984
45985
45986
45987
45988
45989
45990
45991
45992
45993
45994
45995
45996
45997
45998
45999
46000
46001
46002
46003
46004
46005
46006
46007
46008
46009
46010
46011
46012
46013
46014
46015
46016
46017
46018
46019
46020
46021
46022
46023
46024
46025
46026
46027
46028
46029
46030
46031
46032
46033
46034
46035
46036
46037
46038
46039
46040
46041
46042
46043
46044
46045
46046
46047
46048
46049
46050
46051
46052
46053
46054
46055
46056
46057
46058
46059
46060
46061
46062
46063
46064
46065
46066
46067
46068
46069
46070
46071
46072
46073
46074
46075
46076
46077
46078
46079
46080
46081
46082
46083
46084
46085
46086
46087
46088
46089
46090
46091
46092
46093
46094
46095
46096
46097
46098
46099
46100
46101
46102
46103
46104
46105
46106
46107
46108
46109
46110
46111
46112
46113
46114
46115
46116
46117
46118
46119
46120
46121
46122
46123
46124
46125
46126
46127
46128
46129
46130
46131
46132
46133
46134
46135
46136
46137
46138
46139
46140
46141
46142
46143
46144
46145
46146
46147
46148
46149
46150
46151
46152
46153
46154
46155
46156
46157
46158
46159
46160
46161
46162
46163
46164
46165
46166
46167
46168
46169
46170
46171
46172
46173
46174
46175
46176
46177
46178
46179
46180
46181
46182
46183
46184
46185
46186
46187
46188
46189
46190
46191
46192
46193
46194
46195
46196
46197
46198
46199
46200
46201
46202
46203
46204
46205
46206
46207
46208
46209
46210
46211
46212
46213
46214
46215
46216
46217
46218
46219
46220
46221
46222
46223
46224
46225
46226
46227
46228
46229
46230
46231
46232
46233
46234
46235
46236
46237
46238
46239
46240
46241
46242
46243
46244
46245
46246
46247
46248
46249
46250
46251
46252
46253
46254
46255
46256
46257
46258
46259
46260
46261
46262
46263
46264
46265
46266
46267
46268
46269
46270
46271
46272
46273
46274
46275
46276
46277
46278
46279
46280
46281
46282
46283
46284
46285
46286
46287
46288
46289
46290
46291
46292
46293
46294
46295
46296
46297
46298
46299
46300
46301
46302
46303
46304
46305
46306
46307
46308
46309
46310
46311
46312
46313
46314
46315
46316
46317
46318
46319
46320
46321
46322
46323
46324
46325
46326
46327
46328
46329
46330
46331
46332
46333
46334
46335
46336
46337
46338
46339
46340
46341
46342
46343
46344
46345
46346
46347
46348
46349
46350
46351
46352
46353
46354
46355
46356
46357
46358
46359
46360
46361
46362
46363
46364
46365
46366
46367
46368
46369
46370
46371
46372
46373
46374
46375
46376
46377
46378
46379
46380
46381
46382
46383
46384
46385
46386
46387
46388
46389
46390
46391
46392
46393
46394
46395
46396
46397
46398
46399
46400
46401
46402
46403
46404
46405
46406
46407
46408
46409
46410
46411
46412
46413
46414
46415
46416
46417
46418
46419
46420
46421
46422
46423
46424
46425
46426
46427
46428
46429
46430
46431
46432
46433
46434
46435
46436
46437
46438
46439
46440
46441
46442
46443
46444
46445
46446
46447
46448
46449
46450
46451
46452
46453
46454
46455
46456
46457
46458
46459
46460
46461
46462
46463
46464
46465
46466
46467
46468
46469
46470
46471
46472
46473
46474
46475
46476
46477
46478
46479
46480
46481
46482
46483
46484
46485
46486
46487
46488
46489
46490
46491
46492
46493
46494
46495
46496
46497
46498
46499
46500
46501
46502
46503
46504
46505
46506
46507
46508
46509
46510
46511
46512
46513
46514
46515
46516
46517
46518
46519
46520
46521
46522
46523
46524
46525
46526
46527
46528
46529
46530
46531
46532
46533
46534
46535
46536
46537
46538
46539
46540
46541
46542
46543
46544
46545
46546
46547
46548
46549
46550
46551
46552
46553
46554
46555
46556
46557
46558
46559
46560
46561
46562
46563
46564
46565
46566
46567
46568
46569
46570
46571
46572
46573
46574
46575
46576
46577
46578
46579
46580
46581
46582
46583
46584
46585
46586
46587
46588
46589
46590
46591
46592
46593
46594
46595
46596
46597
46598
46599
46600
46601
46602
46603
46604
46605
46606
46607
46608
46609
46610
46611
46612
46613
46614
46615
46616
46617
46618
46619
46620
46621
46622
46623
46624
46625
46626
46627
46628
46629
46630
46631
46632
46633
46634
46635
46636
46637
46638
46639
46640
46641
46642
46643
46644
46645
46646
46647
46648
46649
46650
46651
46652
46653
46654
46655
46656
46657
46658
46659
46660
46661
46662
46663
46664
46665
46666
46667
46668
46669
46670
46671
46672
46673
46674
46675
46676
46677
46678
46679
46680
46681
46682
46683
46684
46685
46686
46687
46688
46689
46690
46691
46692
46693
46694
46695
46696
46697
46698
46699
46700
46701
46702
46703
46704
46705
46706
46707
46708
46709
46710
46711
46712
46713
46714
46715
46716
46717
46718
46719
46720
46721
46722
46723
46724
46725
46726
46727
46728
46729
46730
46731
46732
46733
46734
46735
46736
46737
46738
46739
46740
46741
46742
46743
46744
46745
46746
46747
46748
46749
46750
46751
46752
46753
46754
46755
46756
46757
46758
46759
46760
46761
46762
46763
46764
46765
46766
46767
46768
46769
46770
46771
46772
46773
46774
46775
46776
46777
46778
46779
46780
46781
46782
46783
46784
46785
46786
46787
46788
46789
46790
46791
46792
46793
46794
46795
46796
46797
46798
46799
46800
46801
46802
46803
46804
46805
46806
46807
46808
46809
46810
46811
46812
46813
46814
46815
46816
46817
46818
46819
46820
46821
46822
46823
46824
46825
46826
46827
46828
46829
46830
46831
46832
46833
46834
46835
46836
46837
46838
46839
46840
46841
46842
46843
46844
46845
46846
46847
46848
46849
46850
46851
46852
46853
46854
46855
46856
46857
46858
46859
46860
46861
46862
46863
46864
46865
46866
46867
46868
46869
46870
46871
46872
46873
46874
46875
46876
46877
46878
46879
46880
46881
46882
46883
46884
46885
46886
46887
46888
46889
46890
46891
46892
46893
46894
46895
46896
46897
46898
46899
46900
46901
46902
46903
46904
46905
46906
46907
46908
46909
46910
46911
46912
46913
46914
46915
46916
46917
46918
46919
46920
46921
46922
46923
46924
46925
46926
46927
46928
46929
46930
46931
46932
46933
46934
46935
46936
46937
46938
46939
46940
46941
46942
46943
46944
46945
46946
46947
46948
46949
46950
46951
46952
46953
46954
46955
46956
46957
46958
46959
46960
46961
46962
46963
46964
46965
46966
46967
46968
46969
46970
46971
46972
46973
46974
46975
46976
46977
46978
46979
46980
46981
46982
46983
46984
46985
46986
46987
46988
46989
46990
46991
46992
46993
46994
46995
46996
46997
46998
46999
47000
47001
47002
47003
47004
47005
47006
47007
47008
47009
47010
47011
47012
47013
47014
47015
47016
47017
47018
47019
47020
47021
47022
47023
47024
47025
47026
47027
47028
47029
47030
47031
47032
47033
47034
47035
47036
47037
47038
47039
47040
47041
47042
47043
47044
47045
47046
47047
47048
47049
47050
47051
47052
47053
47054
47055
47056
47057
47058
47059
47060
47061
47062
47063
47064
47065
47066
47067
47068
47069
47070
47071
47072
47073
47074
47075
47076
47077
47078
47079
47080
47081
47082
47083
47084
47085
47086
47087
47088
47089
47090
47091
47092
47093
47094
47095
47096
47097
47098
47099
47100
47101
47102
47103
47104
47105
47106
47107
47108
47109
47110
47111
47112
47113
47114
47115
47116
47117
47118
47119
47120
47121
47122
47123
47124
47125
47126
47127
47128
47129
47130
47131
47132
47133
47134
47135
47136
47137
47138
47139
47140
47141
47142
47143
47144
47145
47146
47147
47148
47149
47150
47151
47152
47153
47154
47155
47156
47157
47158
47159
47160
47161
47162
47163
47164
47165
47166
47167
47168
47169
47170
47171
47172
47173
47174
47175
47176
47177
47178
47179
47180
47181
47182
47183
47184
47185
47186
47187
47188
47189
47190
47191
47192
47193
47194
47195
47196
47197
47198
47199
47200
47201
47202
47203
47204
47205
47206
47207
47208
47209
47210
47211
47212
47213
47214
47215
47216
47217
47218
47219
47220
47221
47222
47223
47224
47225
47226
47227
47228
47229
47230
47231
47232
47233
47234
47235
47236
47237
47238
47239
47240
47241
47242
47243
47244
47245
47246
47247
47248
47249
47250
47251
47252
47253
47254
47255
47256
47257
47258
47259
47260
47261
47262
47263
47264
47265
47266
47267
47268
47269
47270
47271
47272
47273
47274
47275
47276
47277
47278
47279
47280
47281
47282
47283
47284
47285
47286
47287
47288
47289
47290
47291
47292
47293
47294
47295
47296
47297
47298
47299
47300
47301
47302
47303
47304
47305
47306
47307
47308
47309
47310
47311
47312
47313
47314
47315
47316
47317
47318
47319
47320
47321
47322
47323
47324
47325
47326
47327
47328
47329
47330
47331
47332
47333
47334
47335
47336
47337
47338
47339
47340
47341
47342
47343
47344
47345
47346
47347
47348
47349
47350
47351
47352
47353
47354
47355
47356
47357
47358
47359
47360
47361
47362
47363
47364
47365
47366
47367
47368
47369
47370
47371
47372
47373
47374
47375
47376
47377
47378
47379
47380
47381
47382
47383
47384
47385
47386
47387
47388
47389
47390
47391
47392
47393
47394
47395
47396
47397
47398
47399
47400
47401
47402
47403
47404
47405
47406
47407
47408
47409
47410
47411
47412
47413
47414
47415
47416
47417
47418
47419
47420
47421
47422
47423
47424
47425
47426
47427
47428
47429
47430
47431
47432
47433
47434
47435
47436
47437
47438
47439
47440
47441
47442
47443
47444
47445
47446
47447
47448
47449
47450
47451
47452
47453
47454
47455
47456
47457
47458
47459
47460
47461
47462
47463
47464
47465
47466
47467
47468
47469
47470
47471
47472
47473
47474
47475
47476
47477
47478
47479
47480
47481
47482
47483
47484
47485
47486
47487
47488
47489
47490
47491
47492
47493
47494
47495
47496
47497
47498
47499
47500
47501
47502
47503
47504
47505
47506
47507
47508
47509
47510
47511
47512
47513
47514
47515
47516
47517
47518
47519
47520
47521
47522
47523
47524
47525
47526
47527
47528
47529
47530
47531
47532
47533
47534
47535
47536
47537
47538
47539
47540
47541
47542
47543
47544
47545
47546
47547
47548
47549
47550
47551
47552
47553
47554
47555
47556
47557
47558
47559
47560
47561
47562
47563
47564
47565
47566
47567
47568
47569
47570
47571
47572
47573
47574
47575
47576
47577
47578
47579
47580
47581
47582
47583
47584
47585
47586
47587
47588
47589
47590
47591
47592
47593
47594
47595
47596
47597
47598
47599
47600
47601
47602
47603
47604
47605
47606
47607
47608
47609
47610
47611
47612
47613
47614
47615
47616
47617
47618
47619
47620
47621
47622
47623
47624
47625
47626
47627
47628
47629
47630
47631
47632
47633
47634
47635
47636
47637
47638
47639
47640
47641
47642
47643
47644
47645
47646
47647
47648
47649
47650
47651
47652
47653
47654
47655
47656
47657
47658
47659
47660
47661
47662
47663
47664
47665
47666
47667
47668
47669
47670
47671
47672
47673
47674
47675
47676
47677
47678
47679
47680
47681
47682
47683
47684
47685
47686
47687
47688
47689
47690
47691
47692
47693
47694
47695
47696
47697
47698
47699
47700
47701
47702
47703
47704
47705
47706
47707
47708
47709
47710
47711
47712
47713
47714
47715
47716
47717
47718
47719
47720
47721
47722
47723
47724
47725
47726
47727
47728
47729
47730
47731
47732
47733
47734
47735
47736
47737
47738
47739
47740
47741
47742
47743
47744
47745
47746
47747
47748
47749
47750
47751
47752
47753
47754
47755
47756
47757
47758
47759
47760
47761
47762
47763
47764
47765
47766
47767
47768
47769
47770
47771
47772
47773
47774
47775
47776
47777
47778
47779
47780
47781
47782
47783
47784
47785
47786
47787
47788
47789
47790
47791
47792
47793
47794
47795
47796
47797
47798
47799
47800
47801
47802
47803
47804
47805
47806
47807
47808
47809
47810
47811
47812
47813
47814
47815
47816
47817
47818
47819
47820
47821
47822
47823
47824
47825
47826
47827
47828
47829
47830
47831
47832
47833
47834
47835
47836
47837
47838
47839
47840
47841
47842
47843
47844
47845
47846
47847
47848
47849
47850
47851
47852
47853
47854
47855
47856
47857
47858
47859
47860
47861
47862
47863
47864
47865
47866
47867
47868
47869
47870
47871
47872
47873
47874
47875
47876
47877
47878
47879
47880
47881
47882
47883
47884
47885
47886
47887
47888
47889
47890
47891
47892
47893
47894
47895
47896
47897
47898
47899
47900
47901
47902
47903
47904
47905
47906
47907
47908
47909
47910
47911
47912
47913
47914
47915
47916
47917
47918
47919
47920
47921
47922
47923
47924
47925
47926
47927
47928
47929
47930
47931
47932
47933
47934
47935
47936
47937
47938
47939
47940
47941
47942
47943
47944
47945
47946
47947
47948
47949
47950
47951
47952
47953
47954
47955
47956
47957
47958
47959
47960
47961
47962
47963
47964
47965
47966
47967
47968
47969
47970
47971
47972
47973
47974
47975
47976
47977
47978
47979
47980
47981
47982
47983
47984
47985
47986
47987
47988
47989
47990
47991
47992
47993
47994
47995
47996
47997
47998
47999
48000
48001
48002
48003
48004
48005
48006
48007
48008
48009
48010
48011
48012
48013
48014
48015
48016
48017
48018
48019
48020
48021
48022
48023
48024
48025
48026
48027
48028
48029
48030
48031
48032
48033
48034
48035
48036
48037
48038
48039
48040
48041
48042
48043
48044
48045
48046
48047
48048
48049
48050
48051
48052
48053
48054
48055
48056
48057
48058
48059
48060
48061
48062
48063
48064
48065
48066
48067
48068
48069
48070
48071
48072
48073
48074
48075
48076
48077
48078
48079
48080
48081
48082
48083
48084
48085
48086
48087
48088
48089
48090
48091
48092
48093
48094
48095
48096
48097
48098
48099
48100
48101
48102
48103
48104
48105
48106
48107
48108
48109
48110
48111
48112
48113
48114
48115
48116
48117
48118
48119
48120
48121
48122
48123
48124
48125
48126
48127
48128
48129
48130
48131
48132
48133
48134
48135
48136
48137
48138
48139
48140
48141
48142
48143
48144
48145
48146
48147
48148
48149
48150
48151
48152
48153
48154
48155
48156
48157
48158
48159
48160
48161
48162
48163
48164
48165
48166
48167
48168
48169
48170
48171
48172
48173
48174
48175
48176
48177
48178
48179
48180
48181
48182
48183
48184
48185
48186
48187
48188
48189
48190
48191
48192
48193
48194
48195
48196
48197
48198
48199
48200
48201
48202
48203
48204
48205
48206
48207
48208
48209
48210
48211
48212
48213
48214
48215
48216
48217
48218
48219
48220
48221
48222
48223
48224
48225
48226
48227
48228
48229
48230
48231
48232
48233
48234
48235
48236
48237
48238
48239
48240
48241
48242
48243
48244
48245
48246
48247
48248
48249
48250
48251
48252
48253
48254
48255
48256
48257
48258
48259
48260
48261
48262
48263
48264
48265
48266
48267
48268
48269
48270
48271
48272
48273
48274
48275
48276
48277
48278
48279
48280
48281
48282
48283
48284
48285
48286
48287
48288
48289
48290
48291
48292
48293
48294
48295
48296
48297
48298
48299
48300
48301
48302
48303
48304
48305
48306
48307
48308
48309
48310
48311
48312
48313
48314
48315
48316
48317
48318
48319
48320
48321
48322
48323
48324
48325
48326
48327
48328
48329
48330
48331
48332
48333
48334
48335
48336
48337
48338
48339
48340
48341
48342
48343
48344
48345
48346
48347
48348
48349
48350
48351
48352
48353
48354
48355
48356
48357
48358
48359
48360
48361
48362
48363
48364
48365
48366
48367
48368
48369
48370
48371
48372
48373
48374
48375
48376
48377
48378
48379
48380
48381
48382
48383
48384
48385
48386
48387
48388
48389
48390
48391
48392
48393
48394
48395
48396
48397
48398
48399
48400
48401
48402
48403
48404
48405
48406
48407
48408
48409
48410
48411
48412
48413
48414
48415
48416
48417
48418
48419
48420
48421
48422
48423
48424
48425
48426
48427
48428
48429
48430
48431
48432
48433
48434
48435
48436
48437
48438
48439
48440
48441
48442
48443
48444
48445
48446
48447
48448
48449
48450
48451
48452
48453
48454
48455
48456
48457
48458
48459
48460
48461
48462
48463
48464
48465
48466
48467
48468
48469
48470
48471
48472
48473
48474
48475
48476
48477
48478
48479
48480
48481
48482
48483
48484
48485
48486
48487
48488
48489
48490
48491
48492
48493
48494
48495
48496
48497
48498
48499
48500
48501
48502
48503
48504
48505
48506
48507
48508
48509
48510
48511
48512
48513
48514
48515
48516
48517
48518
48519
48520
48521
48522
48523
48524
48525
48526
48527
48528
48529
48530
48531
48532
48533
48534
48535
48536
48537
48538
48539
48540
48541
48542
48543
48544
48545
48546
48547
48548
48549
48550
48551
48552
48553
48554
48555
48556
48557
48558
48559
48560
48561
48562
48563
48564
48565
48566
48567
48568
48569
48570
48571
48572
48573
48574
48575
48576
48577
48578
48579
48580
48581
48582
48583
48584
48585
48586
48587
48588
48589
48590
48591
48592
48593
48594
48595
48596
48597
48598
48599
48600
48601
48602
48603
48604
48605
48606
48607
48608
48609
48610
48611
48612
48613
48614
48615
48616
48617
48618
48619
48620
48621
48622
48623
48624
48625
48626
48627
48628
48629
48630
48631
48632
48633
48634
48635
48636
48637
48638
48639
48640
48641
48642
48643
48644
48645
48646
48647
48648
48649
48650
48651
48652
48653
48654
48655
48656
48657
48658
48659
48660
48661
48662
48663
48664
48665
48666
48667
48668
48669
48670
48671
48672
48673
48674
48675
48676
48677
48678
48679
48680
48681
48682
48683
48684
48685
48686
48687
48688
48689
48690
48691
48692
48693
48694
48695
48696
48697
48698
48699
48700
48701
48702
48703
48704
48705
48706
48707
48708
48709
48710
48711
48712
48713
48714
48715
48716
48717
48718
48719
48720
48721
48722
48723
48724
48725
48726
48727
48728
48729
48730
48731
48732
48733
48734
48735
48736
48737
48738
48739
48740
48741
48742
48743
48744
48745
48746
48747
48748
48749
48750
48751
48752
48753
48754
48755
48756
48757
48758
48759
48760
48761
48762
48763
48764
48765
48766
48767
48768
48769
48770
48771
48772
48773
48774
48775
48776
48777
48778
48779
48780
48781
48782
48783
48784
48785
48786
48787
48788
48789
48790
48791
48792
48793
48794
48795
48796
48797
48798
48799
48800
48801
48802
48803
48804
48805
48806
48807
48808
48809
48810
48811
48812
48813
48814
48815
48816
48817
48818
48819
48820
48821
48822
48823
48824
48825
48826
48827
48828
48829
48830
48831
48832
48833
48834
48835
48836
48837
48838
48839
48840
48841
48842
48843
48844
48845
48846
48847
48848
48849
48850
48851
48852
48853
48854
48855
48856
48857
48858
48859
48860
48861
48862
48863
48864
48865
48866
48867
48868
48869
48870
48871
48872
48873
48874
48875
48876
48877
48878
48879
48880
48881
48882
48883
48884
48885
48886
48887
48888
48889
48890
48891
48892
48893
48894
48895
48896
48897
48898
48899
48900
48901
48902
48903
48904
48905
48906
48907
48908
48909
48910
48911
48912
48913
48914
48915
48916
48917
48918
48919
48920
48921
48922
48923
48924
48925
48926
48927
48928
48929
48930
48931
48932
48933
48934
48935
48936
48937
48938
48939
48940
48941
48942
48943
48944
48945
48946
48947
48948
48949
48950
48951
48952
48953
48954
48955
48956
48957
48958
48959
48960
48961
48962
48963
48964
48965
48966
48967
48968
48969
48970
48971
48972
48973
48974
48975
48976
48977
48978
48979
48980
48981
48982
48983
48984
48985
48986
48987
48988
48989
48990
48991
48992
48993
48994
48995
48996
48997
48998
48999
49000
49001
49002
49003
49004
49005
49006
49007
49008
49009
49010
49011
49012
49013
49014
49015
49016
49017
49018
49019
49020
49021
49022
49023
49024
49025
49026
49027
49028
49029
49030
49031
49032
49033
49034
49035
49036
49037
49038
49039
49040
49041
49042
49043
49044
49045
49046
49047
49048
49049
49050
49051
49052
49053
49054
49055
49056
49057
49058
49059
49060
49061
49062
49063
49064
49065
49066
49067
49068
49069
49070
49071
49072
49073
49074
49075
49076
49077
49078
49079
49080
49081
49082
49083
49084
49085
49086
49087
49088
49089
49090
49091
49092
49093
49094
49095
49096
49097
49098
49099
49100
49101
49102
49103
49104
49105
49106
49107
49108
49109
49110
49111
49112
49113
49114
49115
49116
49117
49118
49119
49120
49121
49122
49123
49124
49125
49126
49127
49128
49129
49130
49131
49132
49133
49134
49135
49136
49137
49138
49139
49140
49141
49142
49143
49144
49145
49146
49147
49148
49149
49150
49151
49152
49153
49154
49155
49156
49157
49158
49159
49160
49161
49162
49163
49164
49165
49166
49167
49168
49169
49170
49171
49172
49173
49174
49175
49176
49177
49178
49179
49180
49181
49182
49183
49184
49185
49186
49187
49188
49189
49190
49191
49192
49193
49194
49195
49196
49197
49198
49199
49200
49201
49202
49203
49204
49205
49206
49207
49208
49209
49210
49211
49212
49213
49214
49215
49216
49217
49218
49219
49220
49221
49222
49223
49224
49225
49226
49227
49228
49229
49230
49231
49232
49233
49234
49235
49236
49237
49238
49239
49240
49241
49242
49243
49244
49245
49246
49247
49248
49249
49250
49251
49252
49253
49254
49255
49256
49257
49258
49259
49260
49261
49262
49263
49264
49265
49266
49267
49268
49269
49270
49271
49272
49273
49274
49275
49276
49277
49278
49279
49280
49281
49282
49283
49284
49285
49286
49287
49288
49289
49290
49291
49292
49293
49294
49295
49296
49297
49298
49299
49300
49301
49302
49303
49304
49305
49306
49307
49308
49309
49310
49311
49312
49313
49314
49315
49316
49317
49318
49319
49320
49321
49322
49323
49324
49325
49326
49327
49328
49329
49330
49331
49332
49333
49334
49335
49336
49337
49338
49339
49340
49341
49342
49343
49344
49345
49346
49347
49348
49349
49350
49351
49352
49353
49354
49355
49356
49357
49358
49359
49360
49361
49362
49363
49364
49365
49366
49367
49368
49369
49370
49371
49372
49373
49374
49375
49376
49377
49378
49379
49380
49381
49382
49383
49384
49385
49386
49387
49388
49389
49390
49391
49392
49393
49394
49395
49396
49397
49398
49399
49400
49401
49402
49403
49404
49405
49406
49407
49408
49409
49410
49411
49412
49413
49414
49415
49416
49417
49418
49419
49420
49421
49422
49423
49424
49425
49426
49427
49428
49429
49430
49431
49432
49433
49434
49435
49436
49437
49438
49439
49440
49441
49442
49443
49444
49445
49446
49447
49448
49449
49450
49451
49452
49453
49454
49455
49456
49457
49458
49459
49460
49461
49462
49463
49464
49465
49466
49467
49468
49469
49470
49471
49472
49473
49474
49475
49476
49477
49478
49479
49480
49481
49482
49483
49484
49485
49486
49487
49488
49489
49490
49491
49492
49493
49494
49495
49496
49497
49498
49499
49500
49501
49502
49503
49504
49505
49506
49507
49508
49509
49510
49511
49512
49513
49514
49515
49516
49517
49518
49519
49520
49521
49522
49523
49524
49525
49526
49527
49528
49529
49530
49531
49532
49533
49534
49535
49536
49537
49538
49539
49540
49541
49542
49543
49544
49545
49546
49547
49548
49549
49550
49551
49552
49553
49554
49555
49556
49557
49558
49559
49560
49561
49562
49563
49564
49565
49566
49567
49568
49569
49570
49571
49572
49573
49574
49575
49576
49577
49578
49579
49580
49581
49582
49583
49584
49585
49586
49587
49588
49589
49590
49591
49592
49593
49594
49595
49596
49597
49598
49599
49600
49601
49602
49603
49604
49605
49606
49607
49608
49609
49610
49611
49612
49613
49614
49615
49616
49617
49618
49619
49620
49621
49622
49623
49624
49625
49626
49627
49628
49629
49630
49631
49632
49633
49634
49635
49636
49637
49638
49639
49640
49641
49642
49643
49644
49645
49646
49647
49648
49649
49650
49651
49652
49653
49654
49655
49656
49657
49658
49659
49660
49661
49662
49663
49664
49665
49666
49667
49668
49669
49670
49671
49672
49673
49674
49675
49676
49677
49678
49679
49680
49681
49682
49683
49684
49685
49686
49687
49688
49689
49690
49691
49692
49693
49694
49695
49696
49697
49698
49699
49700
49701
49702
49703
49704
49705
49706
49707
49708
49709
49710
49711
49712
49713
49714
49715
49716
49717
49718
49719
49720
49721
49722
49723
49724
49725
49726
49727
49728
49729
49730
49731
49732
49733
49734
49735
49736
49737
49738
49739
49740
49741
49742
49743
49744
49745
49746
49747
49748
49749
49750
49751
49752
49753
49754
49755
49756
49757
49758
49759
49760
49761
49762
49763
49764
49765
49766
49767
49768
49769
49770
49771
49772
49773
49774
49775
49776
49777
49778
49779
49780
49781
49782
49783
49784
49785
49786
49787
49788
49789
49790
49791
49792
49793
49794
49795
49796
49797
49798
49799
49800
49801
49802
49803
49804
49805
49806
49807
49808
49809
49810
49811
49812
49813
49814
49815
49816
49817
49818
49819
49820
49821
49822
49823
49824
49825
49826
49827
49828
49829
49830
49831
49832
49833
49834
49835
49836
49837
49838
49839
49840
49841
49842
49843
49844
49845
49846
49847
49848
49849
49850
49851
49852
49853
49854
49855
49856
49857
49858
49859
49860
49861
49862
49863
49864
49865
49866
49867
49868
49869
49870
49871
49872
49873
49874
49875
49876
49877
49878
49879
49880
49881
49882
49883
49884
49885
49886
49887
49888
49889
49890
49891
49892
49893
49894
49895
49896
49897
49898
49899
49900
49901
49902
49903
49904
49905
49906
49907
49908
49909
49910
49911
49912
49913
49914
49915
49916
49917
49918
49919
49920
49921
49922
49923
49924
49925
49926
49927
49928
49929
49930
49931
49932
49933
49934
49935
49936
49937
49938
49939
49940
49941
49942
49943
49944
49945
49946
49947
49948
49949
49950
49951
49952
49953
49954
49955
49956
49957
49958
49959
49960
49961
49962
49963
49964
49965
49966
49967
49968
49969
49970
49971
49972
49973
49974
49975
49976
49977
49978
49979
49980
49981
49982
49983
49984
49985
49986
49987
49988
49989
49990
49991
49992
49993
49994
49995
49996
49997
49998
49999
50000
50001
50002
50003
50004
50005
50006
50007
50008
50009
50010
50011
50012
50013
50014
50015
50016
50017
50018
50019
50020
50021
50022
50023
50024
50025
50026
50027
50028
50029
50030
50031
50032
50033
50034
50035
50036
50037
50038
50039
50040
50041
50042
50043
50044
50045
50046
50047
50048
50049
50050
50051
50052
50053
50054
50055
50056
50057
50058
50059
50060
50061
50062
50063
50064
50065
50066
50067
50068
50069
50070
50071
50072
50073
50074
50075
50076
50077
50078
50079
50080
50081
50082
50083
50084
50085
50086
50087
50088
50089
50090
50091
50092
50093
50094
50095
50096
50097
50098
50099
50100
50101
50102
50103
50104
50105
50106
50107
50108
50109
50110
50111
50112
50113
50114
50115
50116
50117
50118
50119
50120
50121
50122
50123
50124
50125
50126
50127
50128
50129
50130
50131
50132
50133
50134
50135
50136
50137
50138
50139
50140
50141
50142
50143
50144
50145
50146
50147
50148
50149
50150
50151
50152
50153
50154
50155
50156
50157
50158
50159
50160
50161
50162
50163
50164
50165
50166
50167
50168
50169
50170
50171
50172
50173
50174
50175
50176
50177
50178
50179
50180
50181
50182
50183
50184
50185
50186
50187
50188
50189
50190
50191
50192
50193
50194
50195
50196
50197
50198
50199
50200
50201
50202
50203
50204
50205
50206
50207
50208
50209
50210
50211
50212
50213
50214
50215
50216
50217
50218
50219
50220
50221
50222
50223
50224
50225
50226
50227
50228
50229
50230
50231
50232
50233
50234
50235
50236
50237
50238
50239
50240
50241
50242
50243
50244
50245
50246
50247
50248
50249
50250
50251
50252
50253
50254
50255
50256
50257
50258
50259
50260
50261
50262
50263
50264
50265
50266
50267
50268
50269
50270
50271
50272
50273
50274
50275
50276
50277
50278
50279
50280
50281
50282
50283
50284
50285
50286
50287
50288
50289
50290
50291
50292
50293
50294
50295
50296
50297
50298
50299
50300
50301
50302
50303
50304
50305
50306
50307
50308
50309
50310
50311
50312
50313
50314
50315
50316
50317
50318
50319
50320
50321
50322
50323
50324
50325
50326
50327
50328
50329
50330
50331
50332
50333
50334
50335
50336
50337
50338
50339
50340
50341
50342
50343
50344
50345
50346
50347
50348
50349
50350
50351
50352
50353
50354
50355
50356
50357
50358
50359
50360
50361
50362
50363
50364
50365
50366
50367
50368
50369
50370
50371
50372
50373
50374
50375
50376
50377
50378
50379
50380
50381
50382
50383
50384
50385
50386
50387
50388
50389
50390
50391
50392
50393
50394
50395
50396
50397
50398
50399
50400
50401
50402
50403
50404
50405
50406
50407
50408
50409
50410
50411
50412
50413
50414
50415
50416
50417
50418
50419
50420
50421
50422
50423
50424
50425
50426
50427
50428
50429
50430
50431
50432
50433
50434
50435
50436
50437
50438
50439
50440
50441
50442
50443
50444
50445
50446
50447
50448
50449
50450
50451
50452
50453
50454
50455
50456
50457
50458
50459
50460
50461
50462
50463
50464
50465
50466
50467
50468
50469
50470
50471
50472
50473
50474
50475
50476
50477
50478
50479
50480
50481
50482
50483
50484
50485
50486
50487
50488
50489
50490
50491
50492
50493
50494
50495
50496
50497
50498
50499
50500
50501
50502
50503
50504
50505
50506
50507
50508
50509
50510
50511
50512
50513
50514
50515
50516
50517
50518
50519
50520
50521
50522
50523
50524
50525
50526
50527
50528
50529
50530
50531
50532
50533
50534
50535
50536
50537
50538
50539
50540
50541
50542
50543
50544
50545
50546
50547
50548
50549
50550
50551
50552
50553
50554
50555
50556
50557
50558
50559
50560
50561
50562
50563
50564
50565
50566
50567
50568
50569
50570
50571
50572
50573
50574
50575
50576
50577
50578
50579
50580
50581
50582
50583
50584
50585
50586
50587
50588
50589
50590
50591
50592
50593
50594
50595
50596
50597
50598
50599
50600
50601
50602
50603
50604
50605
50606
50607
50608
50609
50610
50611
50612
50613
50614
50615
50616
50617
50618
50619
50620
50621
50622
50623
50624
50625
50626
50627
50628
50629
50630
50631
50632
50633
50634
50635
50636
50637
50638
50639
50640
50641
50642
50643
50644
50645
50646
50647
50648
50649
50650
50651
50652
50653
50654
50655
50656
50657
50658
50659
50660
50661
50662
50663
50664
50665
50666
50667
50668
50669
50670
50671
50672
50673
50674
50675
50676
50677
50678
50679
50680
50681
50682
50683
50684
50685
50686
50687
50688
50689
50690
50691
50692
50693
50694
50695
50696
50697
50698
50699
50700
50701
50702
50703
50704
50705
50706
50707
50708
50709
50710
50711
50712
50713
50714
50715
50716
50717
50718
50719
50720
50721
50722
50723
50724
50725
50726
50727
50728
50729
50730
50731
50732
50733
50734
50735
50736
50737
50738
50739
50740
50741
50742
50743
50744
50745
50746
50747
50748
50749
50750
50751
50752
50753
50754
50755
50756
50757
50758
50759
50760
50761
50762
50763
50764
50765
50766
50767
50768
50769
50770
50771
50772
50773
50774
50775
50776
50777
50778
50779
50780
50781
50782
50783
50784
50785
50786
50787
50788
50789
50790
50791
50792
50793
50794
50795
50796
50797
50798
50799
50800
50801
50802
50803
50804
50805
50806
50807
50808
50809
50810
50811
50812
50813
50814
50815
50816
50817
50818
50819
50820
50821
50822
50823
50824
50825
50826
50827
50828
50829
50830
50831
50832
50833
50834
50835
50836
50837
50838
50839
50840
50841
50842
50843
50844
50845
50846
50847
50848
50849
50850
50851
50852
50853
50854
50855
50856
50857
50858
50859
50860
50861
50862
50863
50864
50865
50866
50867
50868
50869
50870
50871
50872
50873
50874
50875
50876
50877
50878
50879
50880
50881
50882
50883
50884
50885
50886
50887
50888
50889
50890
50891
50892
50893
50894
50895
50896
50897
50898
50899
50900
50901
50902
50903
50904
50905
50906
50907
50908
50909
50910
50911
50912
50913
50914
50915
50916
50917
50918
50919
50920
50921
50922
50923
50924
50925
50926
50927
50928
50929
50930
50931
50932
50933
50934
50935
50936
50937
50938
50939
50940
50941
50942
50943
50944
50945
50946
50947
50948
50949
50950
50951
50952
50953
50954
50955
50956
50957
50958
50959
50960
50961
50962
50963
50964
50965
50966
50967
50968
50969
50970
50971
50972
50973
50974
50975
50976
50977
50978
50979
50980
50981
50982
50983
50984
50985
50986
50987
50988
50989
50990
50991
50992
50993
50994
50995
50996
50997
50998
50999
51000
51001
51002
51003
51004
51005
51006
51007
51008
51009
51010
51011
51012
51013
51014
51015
51016
51017
51018
51019
51020
51021
51022
51023
51024
51025
51026
51027
51028
51029
51030
51031
51032
51033
51034
51035
51036
51037
51038
51039
51040
51041
51042
51043
51044
51045
51046
51047
51048
51049
51050
51051
51052
51053
51054
51055
51056
51057
51058
51059
51060
51061
51062
51063
51064
51065
51066
51067
51068
51069
51070
51071
51072
51073
51074
51075
51076
51077
51078
51079
51080
51081
51082
51083
51084
51085
51086
51087
51088
51089
51090
51091
51092
51093
51094
51095
51096
51097
51098
51099
51100
51101
51102
51103
51104
51105
51106
51107
51108
51109
51110
51111
51112
51113
51114
51115
51116
51117
51118
51119
51120
51121
51122
51123
51124
51125
51126
51127
51128
51129
51130
51131
51132
51133
51134
51135
51136
51137
51138
51139
51140
51141
51142
51143
51144
51145
51146
51147
51148
51149
51150
51151
51152
51153
51154
51155
51156
51157
51158
51159
51160
51161
51162
51163
51164
51165
51166
51167
51168
51169
51170
51171
51172
51173
51174
51175
51176
51177
51178
51179
51180
51181
51182
51183
51184
51185
51186
51187
51188
51189
51190
51191
51192
51193
51194
51195
51196
51197
51198
51199
51200
51201
51202
51203
51204
51205
51206
51207
51208
51209
51210
51211
51212
51213
51214
51215
51216
51217
51218
51219
51220
51221
51222
51223
51224
51225
51226
51227
51228
51229
51230
51231
51232
51233
51234
51235
51236
51237
51238
51239
51240
51241
51242
51243
51244
51245
51246
51247
51248
51249
51250
51251
51252
51253
51254
51255
51256
51257
51258
51259
51260
51261
51262
51263
51264
51265
51266
51267
51268
51269
51270
51271
51272
51273
51274
51275
51276
51277
51278
51279
51280
51281
51282
51283
51284
51285
51286
51287
51288
51289
51290
51291
51292
51293
51294
51295
51296
51297
51298
51299
51300
51301
51302
51303
51304
51305
51306
51307
51308
51309
51310
51311
51312
51313
51314
51315
51316
51317
51318
51319
51320
51321
51322
51323
51324
51325
51326
51327
51328
51329
51330
51331
51332
51333
51334
51335
51336
51337
51338
51339
51340
51341
51342
51343
51344
51345
51346
51347
51348
51349
51350
51351
51352
51353
51354
51355
51356
51357
51358
51359
51360
51361
51362
51363
51364
51365
51366
51367
51368
51369
51370
51371
51372
51373
51374
51375
51376
51377
51378
51379
51380
51381
51382
51383
51384
51385
51386
51387
51388
51389
51390
51391
51392
51393
51394
51395
51396
51397
51398
51399
51400
51401
51402
51403
51404
51405
51406
51407
51408
51409
51410
51411
51412
51413
51414
51415
51416
51417
51418
51419
51420
51421
51422
51423
51424
51425
51426
51427
51428
51429
51430
51431
51432
51433
51434
51435
51436
51437
51438
51439
51440
51441
51442
51443
51444
51445
51446
51447
51448
51449
51450
51451
51452
51453
51454
51455
51456
51457
51458
51459
51460
51461
51462
51463
51464
51465
51466
51467
51468
51469
51470
51471
51472
51473
51474
51475
51476
51477
51478
51479
51480
51481
51482
51483
51484
51485
51486
51487
51488
51489
51490
51491
51492
51493
51494
51495
51496
51497
51498
51499
51500
51501
51502
51503
51504
51505
51506
51507
51508
51509
51510
51511
51512
51513
51514
51515
51516
51517
51518
51519
51520
51521
51522
51523
51524
51525
51526
51527
51528
51529
51530
51531
51532
51533
51534
51535
51536
51537
51538
51539
51540
51541
51542
51543
51544
51545
51546
51547
51548
51549
51550
51551
51552
51553
51554
51555
51556
51557
51558
51559
51560
51561
51562
51563
51564
51565
51566
51567
51568
51569
51570
51571
51572
51573
51574
51575
51576
51577
51578
51579
51580
51581
51582
51583
51584
51585
51586
51587
51588
51589
51590
51591
51592
51593
51594
51595
51596
51597
51598
51599
51600
51601
51602
51603
51604
51605
51606
51607
51608
51609
51610
51611
51612
51613
51614
51615
51616
51617
51618
51619
51620
51621
51622
51623
51624
51625
51626
51627
51628
51629
51630
51631
51632
51633
51634
51635
51636
51637
51638
51639
51640
51641
51642
51643
51644
51645
51646
51647
51648
51649
51650
51651
51652
51653
51654
51655
51656
51657
51658
51659
51660
51661
51662
51663
51664
51665
51666
51667
51668
51669
51670
51671
51672
51673
51674
51675
51676
51677
51678
51679
51680
51681
51682
51683
51684
51685
51686
51687
51688
51689
51690
51691
51692
51693
51694
51695
51696
51697
51698
51699
51700
51701
51702
51703
51704
51705
51706
51707
51708
51709
51710
51711
51712
51713
51714
51715
51716
51717
51718
51719
51720
51721
51722
51723
51724
51725
51726
51727
51728
51729
51730
51731
51732
51733
51734
51735
51736
51737
51738
51739
51740
51741
51742
51743
51744
51745
51746
51747
51748
51749
51750
51751
51752
51753
51754
51755
51756
51757
51758
51759
51760
51761
51762
51763
51764
51765
51766
51767
51768
51769
51770
51771
51772
51773
51774
51775
51776
51777
51778
51779
51780
51781
51782
51783
51784
51785
51786
51787
51788
51789
51790
51791
51792
51793
51794
51795
51796
51797
51798
51799
51800
51801
51802
51803
51804
51805
51806
51807
51808
51809
51810
51811
51812
51813
51814
51815
51816
51817
51818
51819
51820
51821
51822
51823
51824
51825
51826
51827
51828
51829
51830
51831
51832
51833
51834
51835
51836
51837
51838
51839
51840
51841
51842
51843
51844
51845
51846
51847
51848
51849
51850
51851
51852
51853
51854
51855
51856
51857
51858
51859
51860
51861
51862
51863
51864
51865
51866
51867
51868
51869
51870
51871
51872
51873
51874
51875
51876
51877
51878
51879
51880
51881
51882
51883
51884
51885
51886
51887
51888
51889
51890
51891
51892
51893
51894
51895
51896
51897
51898
51899
51900
51901
51902
51903
51904
51905
51906
51907
51908
51909
51910
51911
51912
51913
51914
51915
51916
51917
51918
51919
51920
51921
51922
51923
51924
51925
51926
51927
51928
51929
51930
51931
51932
51933
51934
51935
51936
51937
51938
51939
51940
51941
51942
51943
51944
51945
51946
51947
51948
51949
51950
51951
51952
51953
51954
51955
51956
51957
51958
51959
51960
51961
51962
51963
51964
51965
51966
51967
51968
51969
51970
51971
51972
51973
51974
51975
51976
51977
51978
51979
51980
51981
51982
51983
51984
51985
51986
51987
51988
51989
51990
51991
51992
51993
51994
51995
51996
51997
51998
51999
52000
52001
52002
52003
52004
52005
52006
52007
52008
52009
52010
52011
52012
52013
52014
52015
52016
52017
52018
52019
52020
52021
52022
52023
52024
52025
52026
52027
52028
52029
52030
52031
52032
52033
52034
52035
52036
52037
52038
52039
52040
52041
52042
52043
52044
52045
52046
52047
52048
52049
52050
52051
52052
52053
52054
52055
52056
52057
52058
52059
52060
52061
52062
52063
52064
52065
52066
52067
52068
52069
52070
52071
52072
52073
52074
52075
52076
52077
52078
52079
52080
52081
52082
52083
52084
52085
52086
52087
52088
52089
52090
52091
52092
52093
52094
52095
52096
52097
52098
52099
52100
52101
52102
52103
52104
52105
52106
52107
52108
52109
52110
52111
52112
52113
52114
52115
52116
52117
52118
52119
52120
52121
52122
52123
52124
52125
52126
52127
52128
52129
52130
52131
52132
52133
52134
52135
52136
52137
52138
52139
52140
52141
52142
52143
52144
52145
52146
52147
52148
52149
52150
52151
52152
52153
52154
52155
52156
52157
52158
52159
52160
52161
52162
52163
52164
52165
52166
52167
52168
52169
52170
52171
52172
52173
52174
52175
52176
52177
52178
52179
52180
52181
52182
52183
52184
52185
52186
52187
52188
52189
52190
52191
52192
52193
52194
52195
52196
52197
52198
52199
52200
52201
52202
52203
52204
52205
52206
52207
52208
52209
52210
52211
52212
52213
52214
52215
52216
52217
52218
52219
52220
52221
52222
52223
52224
52225
52226
52227
52228
52229
52230
52231
52232
52233
52234
52235
52236
52237
52238
52239
52240
52241
52242
52243
52244
52245
52246
52247
52248
52249
52250
52251
52252
52253
52254
52255
52256
52257
52258
52259
52260
52261
52262
52263
52264
52265
52266
52267
52268
52269
52270
52271
52272
52273
52274
52275
52276
52277
52278
52279
52280
52281
52282
52283
52284
52285
52286
52287
52288
52289
52290
52291
52292
52293
52294
52295
52296
52297
52298
52299
52300
52301
52302
52303
52304
52305
52306
52307
52308
52309
52310
52311
52312
52313
52314
52315
52316
52317
52318
52319
52320
52321
52322
52323
52324
52325
52326
52327
52328
52329
52330
52331
52332
52333
52334
52335
52336
52337
52338
52339
52340
52341
52342
52343
52344
52345
52346
52347
52348
52349
52350
52351
52352
52353
52354
52355
52356
52357
52358
52359
52360
52361
52362
52363
52364
52365
52366
52367
52368
52369
52370
52371
52372
52373
52374
52375
52376
52377
52378
52379
52380
52381
52382
52383
52384
52385
52386
52387
52388
52389
52390
52391
52392
52393
52394
52395
52396
52397
52398
52399
52400
52401
52402
52403
52404
52405
52406
52407
52408
52409
52410
52411
52412
52413
52414
52415
52416
52417
52418
52419
52420
52421
52422
52423
52424
52425
52426
52427
52428
52429
52430
52431
52432
52433
52434
52435
52436
52437
52438
52439
52440
52441
52442
52443
52444
52445
52446
52447
52448
52449
52450
52451
52452
52453
52454
52455
52456
52457
52458
52459
52460
52461
52462
52463
52464
52465
52466
52467
52468
52469
52470
52471
52472
52473
52474
52475
52476
52477
52478
52479
52480
52481
52482
52483
52484
52485
52486
52487
52488
52489
52490
52491
52492
52493
52494
52495
52496
52497
52498
52499
52500
52501
52502
52503
52504
52505
52506
52507
52508
52509
52510
52511
52512
52513
52514
52515
52516
52517
52518
52519
52520
52521
52522
52523
52524
52525
52526
52527
52528
52529
52530
52531
52532
52533
52534
52535
52536
52537
52538
52539
52540
52541
52542
52543
52544
52545
52546
52547
52548
52549
52550
52551
52552
52553
52554
52555
52556
52557
52558
52559
52560
52561
52562
52563
52564
52565
52566
52567
52568
52569
52570
52571
52572
52573
52574
52575
52576
52577
52578
52579
52580
52581
52582
52583
52584
52585
52586
52587
52588
52589
52590
52591
52592
52593
52594
52595
52596
52597
52598
52599
52600
52601
52602
52603
52604
52605
52606
52607
52608
52609
52610
52611
52612
52613
52614
52615
52616
52617
52618
52619
52620
52621
52622
52623
52624
52625
52626
52627
52628
52629
52630
52631
52632
52633
52634
52635
52636
52637
52638
52639
52640
52641
52642
52643
52644
52645
52646
52647
52648
52649
52650
52651
52652
52653
52654
52655
52656
52657
52658
52659
52660
52661
52662
52663
52664
52665
52666
52667
52668
52669
52670
52671
52672
52673
52674
52675
52676
52677
52678
52679
52680
52681
52682
52683
52684
52685
52686
52687
52688
52689
52690
52691
52692
52693
52694
52695
52696
52697
52698
52699
52700
52701
52702
52703
52704
52705
52706
52707
52708
52709
52710
52711
52712
52713
52714
52715
52716
52717
52718
52719
52720
52721
52722
52723
52724
52725
52726
52727
52728
52729
52730
52731
52732
52733
52734
52735
52736
52737
52738
52739
52740
52741
52742
52743
52744
52745
52746
52747
52748
52749
52750
52751
52752
52753
52754
52755
52756
52757
52758
52759
52760
52761
52762
52763
52764
52765
52766
52767
52768
52769
52770
52771
52772
52773
52774
52775
52776
52777
52778
52779
52780
52781
52782
52783
52784
52785
52786
52787
52788
52789
52790
52791
52792
52793
52794
52795
52796
52797
52798
52799
52800
52801
52802
52803
52804
52805
52806
52807
52808
52809
52810
52811
52812
52813
52814
52815
52816
52817
52818
52819
52820
52821
52822
52823
52824
52825
52826
52827
52828
52829
52830
52831
52832
52833
52834
52835
52836
52837
52838
52839
52840
52841
52842
52843
52844
52845
52846
52847
52848
52849
52850
52851
52852
52853
52854
52855
52856
52857
52858
52859
52860
52861
52862
52863
52864
52865
52866
52867
52868
52869
52870
52871
52872
52873
52874
52875
52876
52877
52878
52879
52880
52881
52882
52883
52884
52885
52886
52887
52888
52889
52890
52891
52892
52893
52894
52895
52896
52897
52898
52899
52900
52901
52902
52903
52904
52905
52906
52907
52908
52909
52910
52911
52912
52913
52914
52915
52916
52917
52918
52919
52920
52921
52922
52923
52924
52925
52926
52927
52928
52929
52930
52931
52932
52933
52934
52935
52936
52937
52938
52939
52940
52941
52942
52943
52944
52945
52946
52947
52948
52949
52950
52951
52952
52953
52954
52955
52956
52957
52958
52959
52960
52961
52962
52963
52964
52965
52966
52967
52968
52969
52970
52971
52972
52973
52974
52975
52976
52977
52978
52979
52980
52981
52982
52983
52984
52985
52986
52987
52988
52989
52990
52991
52992
52993
52994
52995
52996
52997
52998
52999
53000
53001
53002
53003
53004
53005
53006
53007
53008
53009
53010
53011
53012
53013
53014
53015
53016
53017
53018
53019
53020
53021
53022
53023
53024
53025
53026
53027
53028
53029
53030
53031
53032
53033
53034
53035
53036
53037
53038
53039
53040
53041
53042
53043
53044
53045
53046
53047
53048
53049
53050
53051
53052
53053
53054
53055
53056
53057
53058
53059
53060
53061
53062
53063
53064
53065
53066
53067
53068
53069
53070
53071
53072
53073
53074
53075
53076
53077
53078
53079
53080
53081
53082
53083
53084
53085
53086
53087
53088
53089
53090
53091
53092
53093
53094
53095
53096
53097
53098
53099
53100
53101
53102
53103
53104
53105
53106
53107
53108
53109
53110
53111
53112
53113
53114
53115
53116
53117
53118
53119
53120
53121
53122
53123
53124
53125
53126
53127
53128
53129
53130
53131
53132
53133
53134
53135
53136
53137
53138
53139
53140
53141
53142
53143
53144
53145
53146
53147
53148
53149
53150
53151
53152
53153
53154
53155
53156
53157
53158
53159
53160
53161
53162
53163
53164
53165
53166
53167
53168
53169
53170
53171
53172
53173
53174
53175
53176
53177
53178
53179
53180
53181
53182
53183
53184
53185
53186
53187
53188
53189
53190
53191
53192
53193
53194
53195
53196
53197
53198
53199
53200
53201
53202
53203
53204
53205
53206
53207
53208
53209
53210
53211
53212
53213
53214
53215
53216
53217
53218
53219
53220
53221
53222
53223
53224
53225
53226
53227
53228
53229
53230
53231
53232
53233
53234
53235
53236
53237
53238
53239
53240
53241
53242
53243
53244
53245
53246
53247
53248
53249
53250
53251
53252
53253
53254
53255
53256
53257
53258
53259
53260
53261
53262
53263
53264
53265
53266
53267
53268
53269
53270
53271
53272
53273
53274
53275
53276
53277
53278
53279
53280
53281
53282
53283
53284
53285
53286
53287
53288
53289
53290
53291
53292
53293
53294
53295
53296
53297
53298
53299
53300
53301
53302
53303
53304
53305
53306
53307
53308
53309
53310
53311
53312
53313
53314
53315
53316
53317
53318
53319
53320
53321
53322
53323
53324
53325
53326
53327
53328
53329
53330
53331
53332
53333
53334
53335
53336
53337
53338
53339
53340
53341
53342
53343
53344
53345
53346
53347
53348
53349
53350
53351
53352
53353
53354
53355
53356
53357
53358
53359
53360
53361
53362
53363
53364
53365
53366
53367
53368
53369
53370
53371
53372
53373
53374
53375
53376
53377
53378
53379
53380
53381
53382
53383
53384
53385
53386
53387
53388
53389
53390
53391
53392
53393
53394
53395
53396
53397
53398
53399
53400
53401
53402
53403
53404
53405
53406
53407
53408
53409
53410
53411
53412
53413
53414
53415
53416
53417
53418
53419
53420
53421
53422
53423
53424
53425
53426
53427
53428
53429
53430
53431
53432
53433
53434
53435
53436
53437
53438
53439
53440
53441
53442
53443
53444
53445
53446
53447
53448
53449
53450
53451
53452
53453
53454
53455
53456
53457
53458
53459
53460
53461
53462
53463
53464
53465
53466
53467
53468
53469
53470
53471
53472
53473
53474
53475
53476
53477
53478
53479
53480
53481
53482
53483
53484
53485
53486
53487
53488
53489
53490
53491
53492
53493
53494
53495
53496
53497
53498
53499
53500
53501
53502
53503
53504
53505
53506
53507
53508
53509
53510
53511
53512
53513
53514
53515
53516
53517
53518
53519
53520
53521
53522
53523
53524
53525
53526
53527
53528
53529
53530
53531
53532
53533
53534
53535
53536
53537
53538
53539
53540
53541
53542
53543
53544
53545
53546
53547
53548
53549
53550
53551
53552
53553
53554
53555
53556
53557
53558
53559
53560
53561
53562
53563
53564
53565
53566
53567
53568
53569
53570
53571
53572
53573
53574
53575
53576
53577
53578
53579
53580
53581
53582
53583
53584
53585
53586
53587
53588
53589
53590
53591
53592
53593
53594
53595
53596
53597
53598
53599
53600
53601
53602
53603
53604
53605
53606
53607
53608
53609
53610
53611
53612
53613
53614
53615
53616
53617
53618
53619
53620
53621
53622
53623
53624
53625
53626
53627
53628
53629
53630
53631
53632
53633
53634
53635
53636
53637
53638
53639
53640
53641
53642
53643
53644
53645
53646
53647
53648
53649
53650
53651
53652
53653
53654
53655
53656
53657
53658
53659
53660
53661
53662
53663
53664
53665
53666
53667
53668
53669
53670
53671
53672
53673
53674
53675
53676
53677
53678
53679
53680
53681
53682
53683
53684
53685
53686
53687
53688
53689
53690
53691
53692
53693
53694
53695
53696
53697
53698
53699
53700
53701
53702
53703
53704
53705
53706
53707
53708
53709
53710
53711
53712
53713
53714
53715
53716
53717
53718
53719
53720
53721
53722
53723
53724
53725
53726
53727
53728
53729
53730
53731
53732
53733
53734
53735
53736
53737
53738
53739
53740
53741
53742
53743
53744
53745
53746
53747
53748
53749
53750
53751
53752
53753
53754
53755
53756
53757
53758
53759
53760
53761
53762
53763
53764
53765
53766
53767
53768
53769
53770
53771
53772
53773
53774
53775
53776
53777
53778
53779
53780
53781
53782
53783
53784
53785
53786
53787
53788
53789
53790
53791
53792
53793
53794
53795
53796
53797
53798
53799
53800
53801
53802
53803
53804
53805
53806
53807
53808
53809
53810
53811
53812
53813
53814
53815
53816
53817
53818
53819
53820
53821
53822
53823
53824
53825
53826
53827
53828
53829
53830
53831
53832
53833
53834
53835
53836
53837
53838
53839
53840
53841
53842
53843
53844
53845
53846
53847
53848
53849
53850
53851
53852
53853
53854
53855
53856
53857
53858
53859
53860
53861
53862
53863
53864
53865
53866
53867
53868
53869
53870
53871
53872
53873
53874
53875
53876
53877
53878
53879
53880
53881
53882
53883
53884
53885
53886
53887
53888
53889
53890
53891
53892
53893
53894
53895
53896
53897
53898
53899
53900
53901
53902
53903
53904
53905
53906
53907
53908
53909
53910
53911
53912
53913
53914
53915
53916
53917
53918
53919
53920
53921
53922
53923
53924
53925
53926
53927
53928
53929
53930
53931
53932
53933
53934
53935
53936
53937
53938
53939
53940
53941
53942
53943
53944
53945
53946
53947
53948
53949
53950
53951
53952
53953
53954
53955
53956
53957
53958
53959
53960
53961
53962
53963
53964
53965
53966
53967
53968
53969
53970
53971
53972
53973
53974
53975
53976
53977
53978
53979
53980
53981
53982
53983
53984
53985
53986
53987
53988
53989
53990
53991
53992
53993
53994
53995
53996
53997
53998
53999
54000
54001
54002
54003
54004
54005
54006
54007
54008
54009
54010
54011
54012
54013
54014
54015
54016
54017
54018
54019
54020
54021
54022
54023
54024
54025
54026
54027
54028
54029
54030
54031
54032
54033
54034
54035
54036
54037
54038
54039
54040
54041
54042
54043
54044
54045
54046
54047
54048
54049
54050
54051
54052
54053
54054
54055
54056
54057
54058
54059
54060
54061
54062
54063
54064
54065
54066
54067
54068
54069
54070
54071
54072
54073
54074
54075
54076
54077
54078
54079
54080
54081
54082
54083
54084
54085
54086
54087
54088
54089
54090
54091
54092
54093
54094
54095
54096
54097
54098
54099
54100
54101
54102
54103
54104
54105
54106
54107
54108
54109
54110
54111
54112
54113
54114
54115
54116
54117
54118
54119
54120
54121
54122
54123
54124
54125
54126
54127
54128
54129
54130
54131
54132
54133
54134
54135
54136
54137
54138
54139
54140
54141
54142
54143
54144
54145
54146
54147
54148
54149
54150
54151
54152
54153
54154
54155
54156
54157
54158
54159
54160
54161
54162
54163
54164
54165
54166
54167
54168
54169
54170
54171
54172
54173
54174
54175
54176
54177
54178
54179
54180
54181
54182
54183
54184
54185
54186
54187
54188
54189
54190
54191
54192
54193
54194
54195
54196
54197
54198
54199
54200
54201
54202
54203
54204
54205
54206
54207
54208
54209
54210
54211
54212
54213
54214
54215
54216
54217
54218
54219
54220
54221
54222
54223
54224
54225
54226
54227
54228
54229
54230
54231
54232
54233
54234
54235
54236
54237
54238
54239
54240
54241
54242
54243
54244
54245
54246
54247
54248
54249
54250
54251
54252
54253
54254
54255
54256
54257
54258
54259
54260
54261
54262
54263
54264
54265
54266
54267
54268
54269
54270
54271
54272
54273
54274
54275
54276
54277
54278
54279
54280
54281
54282
54283
54284
54285
54286
54287
54288
54289
54290
54291
54292
54293
54294
54295
54296
54297
54298
54299
54300
54301
54302
54303
54304
54305
54306
54307
54308
54309
54310
54311
54312
54313
54314
54315
54316
54317
54318
54319
54320
54321
54322
54323
54324
54325
54326
54327
54328
54329
54330
54331
54332
54333
54334
54335
54336
54337
54338
54339
54340
54341
54342
54343
54344
54345
54346
54347
54348
54349
54350
54351
54352
54353
54354
54355
54356
54357
54358
54359
54360
54361
54362
54363
54364
54365
54366
54367
54368
54369
54370
54371
54372
54373
54374
54375
54376
54377
54378
54379
54380
54381
54382
54383
54384
54385
54386
54387
54388
54389
54390
54391
54392
54393
54394
54395
54396
54397
54398
54399
54400
54401
54402
54403
54404
54405
54406
54407
54408
54409
54410
54411
54412
54413
54414
54415
54416
54417
54418
54419
54420
54421
54422
54423
54424
54425
54426
54427
54428
54429
54430
54431
54432
54433
54434
54435
54436
54437
54438
54439
54440
54441
54442
54443
54444
54445
54446
54447
54448
54449
54450
54451
54452
54453
54454
54455
54456
54457
54458
54459
54460
54461
54462
54463
54464
54465
54466
54467
54468
54469
54470
54471
54472
54473
54474
54475
54476
54477
54478
54479
54480
54481
54482
54483
54484
54485
54486
54487
54488
54489
54490
54491
54492
54493
54494
54495
54496
54497
54498
54499
54500
54501
54502
54503
54504
54505
54506
54507
54508
54509
54510
54511
54512
54513
54514
54515
54516
54517
54518
54519
54520
54521
54522
54523
54524
54525
54526
54527
54528
54529
54530
54531
54532
54533
54534
54535
54536
54537
54538
54539
54540
54541
54542
54543
54544
54545
54546
54547
54548
54549
54550
54551
54552
54553
54554
54555
54556
54557
54558
54559
54560
54561
54562
54563
54564
54565
54566
54567
54568
54569
54570
54571
54572
54573
54574
54575
54576
54577
54578
54579
54580
54581
54582
54583
54584
54585
54586
54587
54588
54589
54590
54591
54592
54593
54594
54595
54596
54597
54598
54599
54600
54601
54602
54603
54604
54605
54606
54607
54608
54609
54610
54611
54612
54613
54614
54615
54616
54617
54618
54619
54620
54621
54622
54623
54624
54625
54626
54627
54628
54629
54630
54631
54632
54633
54634
54635
54636
54637
54638
54639
54640
54641
54642
54643
54644
54645
54646
54647
54648
54649
54650
54651
54652
54653
54654
54655
54656
54657
54658
54659
54660
54661
54662
54663
54664
54665
54666
54667
54668
54669
54670
54671
54672
54673
54674
54675
54676
54677
54678
54679
54680
54681
54682
54683
54684
54685
54686
54687
54688
54689
54690
54691
54692
54693
54694
54695
54696
54697
54698
54699
54700
54701
54702
54703
54704
54705
54706
54707
54708
54709
54710
54711
54712
54713
54714
54715
54716
54717
54718
54719
54720
54721
54722
54723
54724
54725
54726
54727
54728
54729
54730
54731
54732
54733
54734
54735
54736
54737
54738
54739
54740
54741
54742
54743
54744
54745
54746
54747
54748
54749
54750
54751
54752
54753
54754
54755
54756
54757
54758
54759
54760
54761
54762
54763
54764
54765
54766
54767
54768
54769
54770
54771
54772
54773
54774
54775
54776
54777
54778
54779
54780
54781
54782
54783
54784
54785
54786
54787
54788
54789
54790
54791
54792
54793
54794
54795
54796
54797
54798
54799
54800
54801
54802
54803
54804
54805
54806
54807
54808
54809
54810
54811
54812
54813
54814
54815
54816
54817
54818
54819
54820
54821
54822
54823
54824
54825
54826
54827
54828
54829
54830
54831
54832
54833
54834
54835
54836
54837
54838
54839
54840
54841
54842
54843
54844
54845
54846
54847
54848
54849
54850
54851
54852
54853
54854
54855
54856
54857
54858
54859
54860
54861
54862
54863
54864
54865
54866
54867
54868
54869
54870
54871
54872
54873
54874
54875
54876
54877
54878
54879
54880
54881
54882
54883
54884
54885
54886
54887
54888
54889
54890
54891
54892
54893
54894
54895
54896
54897
54898
54899
54900
54901
54902
54903
54904
54905
54906
54907
54908
54909
54910
54911
54912
54913
54914
54915
54916
54917
54918
54919
54920
54921
54922
54923
54924
54925
54926
54927
54928
54929
54930
54931
54932
54933
54934
54935
54936
54937
54938
54939
54940
54941
54942
54943
54944
54945
54946
54947
54948
54949
54950
54951
54952
54953
54954
54955
54956
54957
54958
54959
54960
54961
54962
54963
54964
54965
54966
54967
54968
54969
54970
54971
54972
54973
54974
54975
54976
54977
54978
54979
54980
54981
54982
54983
54984
54985
54986
54987
54988
54989
54990
54991
54992
54993
54994
54995
54996
54997
54998
54999
55000
55001
55002
55003
55004
55005
55006
55007
55008
55009
55010
55011
55012
55013
55014
55015
55016
55017
55018
55019
55020
55021
55022
55023
55024
55025
55026
55027
55028
55029
55030
55031
55032
55033
55034
55035
55036
55037
55038
55039
55040
55041
55042
55043
55044
55045
55046
55047
55048
55049
55050
55051
55052
55053
55054
55055
55056
55057
55058
55059
55060
55061
55062
55063
55064
55065
55066
55067
55068
55069
55070
55071
55072
55073
55074
55075
55076
55077
55078
55079
55080
55081
55082
55083
55084
55085
55086
55087
55088
55089
55090
55091
55092
55093
55094
55095
55096
55097
55098
55099
55100
55101
55102
55103
55104
55105
55106
55107
55108
55109
55110
55111
55112
55113
55114
55115
55116
55117
55118
55119
55120
55121
55122
55123
55124
55125
55126
55127
55128
55129
55130
55131
55132
55133
55134
55135
55136
55137
55138
55139
55140
55141
55142
55143
55144
55145
55146
55147
55148
55149
55150
55151
55152
55153
55154
55155
55156
55157
55158
55159
55160
55161
55162
55163
55164
55165
55166
55167
55168
55169
55170
55171
55172
55173
55174
55175
55176
55177
55178
55179
55180
55181
55182
55183
55184
55185
55186
55187
55188
55189
55190
55191
55192
55193
55194
55195
55196
55197
55198
55199
55200
55201
55202
55203
55204
55205
55206
55207
55208
55209
55210
55211
55212
55213
55214
55215
55216
55217
55218
55219
55220
55221
55222
55223
55224
55225
55226
55227
55228
55229
55230
55231
55232
55233
55234
55235
55236
55237
55238
55239
55240
55241
55242
55243
55244
55245
55246
55247
55248
55249
55250
55251
55252
55253
55254
55255
55256
55257
55258
55259
55260
55261
55262
55263
55264
55265
55266
55267
55268
55269
55270
55271
55272
55273
55274
55275
55276
55277
55278
55279
55280
55281
55282
55283
55284
55285
55286
55287
55288
55289
55290
55291
55292
55293
55294
55295
55296
55297
55298
55299
55300
55301
55302
55303
55304
55305
55306
55307
55308
55309
55310
55311
55312
55313
55314
55315
55316
55317
55318
55319
55320
55321
55322
55323
55324
55325
55326
55327
55328
55329
55330
55331
55332
55333
55334
55335
55336
55337
55338
55339
55340
55341
55342
55343
55344
55345
55346
55347
55348
55349
55350
55351
55352
55353
55354
55355
55356
55357
55358
55359
55360
55361
55362
55363
55364
55365
55366
55367
55368
55369
55370
55371
55372
55373
55374
55375
55376
55377
55378
55379
55380
55381
55382
55383
55384
55385
55386
55387
55388
55389
55390
55391
55392
55393
55394
55395
55396
55397
55398
55399
55400
55401
55402
55403
55404
55405
55406
55407
55408
55409
55410
55411
55412
55413
55414
55415
55416
55417
55418
55419
55420
55421
55422
55423
55424
55425
55426
55427
55428
55429
55430
55431
55432
55433
55434
55435
55436
55437
55438
55439
55440
55441
55442
55443
55444
55445
55446
55447
55448
55449
55450
55451
55452
55453
55454
55455
55456
55457
55458
55459
55460
55461
55462
55463
55464
55465
55466
55467
55468
55469
55470
55471
55472
55473
55474
55475
55476
55477
55478
55479
55480
55481
55482
55483
55484
55485
55486
55487
55488
55489
55490
55491
55492
55493
55494
55495
55496
55497
55498
55499
55500
55501
55502
55503
55504
55505
55506
55507
55508
55509
55510
55511
55512
55513
55514
55515
55516
55517
55518
55519
55520
55521
55522
55523
55524
55525
55526
55527
55528
55529
55530
55531
55532
55533
55534
55535
55536
55537
55538
55539
55540
55541
55542
55543
55544
55545
55546
55547
55548
55549
55550
55551
55552
55553
55554
55555
55556
55557
55558
55559
55560
55561
55562
55563
55564
55565
55566
55567
55568
55569
55570
55571
55572
55573
55574
55575
55576
55577
55578
55579
55580
55581
55582
55583
55584
55585
55586
55587
55588
55589
55590
55591
55592
55593
55594
55595
55596
55597
55598
55599
55600
55601
55602
55603
55604
55605
55606
55607
55608
55609
55610
55611
55612
55613
55614
55615
55616
55617
55618
55619
55620
55621
55622
55623
55624
55625
55626
55627
55628
55629
55630
55631
55632
55633
55634
55635
55636
55637
55638
55639
55640
55641
55642
55643
55644
55645
55646
55647
55648
55649
55650
55651
55652
55653
55654
55655
55656
55657
55658
55659
55660
55661
55662
55663
55664
55665
55666
55667
55668
55669
55670
55671
55672
55673
55674
55675
55676
55677
55678
55679
55680
55681
55682
55683
55684
55685
55686
55687
55688
55689
55690
55691
55692
55693
55694
55695
55696
55697
55698
55699
55700
55701
55702
55703
55704
55705
55706
55707
55708
55709
55710
55711
55712
55713
55714
55715
55716
55717
55718
55719
55720
55721
55722
55723
55724
55725
55726
55727
55728
55729
55730
55731
55732
55733
55734
55735
55736
55737
55738
55739
55740
55741
55742
55743
55744
55745
55746
55747
55748
55749
55750
55751
55752
55753
55754
55755
55756
55757
55758
55759
55760
55761
55762
55763
55764
55765
55766
55767
55768
55769
55770
55771
55772
55773
55774
55775
55776
55777
55778
55779
55780
55781
55782
55783
55784
55785
55786
55787
55788
55789
55790
55791
55792
55793
55794
55795
55796
55797
55798
55799
55800
55801
55802
55803
55804
55805
55806
55807
55808
55809
55810
55811
55812
55813
55814
55815
55816
55817
55818
55819
55820
55821
55822
55823
55824
55825
55826
55827
55828
55829
55830
55831
55832
55833
55834
55835
55836
55837
55838
55839
55840
55841
55842
55843
55844
55845
55846
55847
55848
55849
55850
55851
55852
55853
55854
55855
55856
55857
55858
55859
55860
55861
55862
55863
55864
55865
55866
55867
55868
55869
55870
55871
55872
55873
55874
55875
55876
55877
55878
55879
55880
55881
55882
55883
55884
55885
55886
55887
55888
55889
55890
55891
55892
55893
55894
55895
55896
55897
55898
55899
55900
55901
55902
55903
55904
55905
55906
55907
55908
55909
55910
55911
55912
55913
55914
55915
55916
55917
55918
55919
55920
55921
55922
55923
55924
55925
55926
55927
55928
55929
55930
55931
55932
55933
55934
55935
55936
55937
55938
55939
55940
55941
55942
55943
55944
55945
55946
55947
55948
55949
55950
55951
55952
55953
55954
55955
55956
55957
55958
55959
55960
55961
55962
55963
55964
55965
55966
55967
55968
55969
55970
55971
55972
55973
55974
55975
55976
55977
55978
55979
55980
55981
55982
55983
55984
55985
55986
55987
55988
55989
55990
55991
55992
55993
55994
55995
55996
55997
55998
55999
56000
56001
56002
56003
56004
56005
56006
56007
56008
56009
56010
56011
56012
56013
56014
56015
56016
56017
56018
56019
56020
56021
56022
56023
56024
56025
56026
56027
56028
56029
56030
56031
56032
56033
56034
56035
56036
56037
56038
56039
56040
56041
56042
56043
56044
56045
56046
56047
56048
56049
56050
56051
56052
56053
56054
56055
56056
56057
56058
56059
56060
56061
56062
56063
56064
56065
56066
56067
56068
56069
56070
56071
56072
56073
56074
56075
56076
56077
56078
56079
56080
56081
56082
56083
56084
56085
56086
56087
56088
56089
56090
56091
56092
56093
56094
56095
56096
56097
56098
56099
56100
56101
56102
56103
56104
56105
56106
56107
56108
56109
56110
56111
56112
56113
56114
56115
56116
56117
56118
56119
56120
56121
56122
56123
56124
56125
56126
56127
56128
56129
56130
56131
56132
56133
56134
56135
56136
56137
56138
56139
56140
56141
56142
56143
56144
56145
56146
56147
56148
56149
56150
56151
56152
56153
56154
56155
56156
56157
56158
56159
56160
56161
56162
56163
56164
56165
56166
56167
56168
56169
56170
56171
56172
56173
56174
56175
56176
56177
56178
56179
56180
56181
56182
56183
56184
56185
56186
56187
56188
56189
56190
56191
56192
56193
56194
56195
56196
56197
56198
56199
56200
56201
56202
56203
56204
56205
56206
56207
56208
56209
56210
56211
56212
56213
56214
56215
56216
56217
56218
56219
56220
56221
56222
56223
56224
56225
56226
56227
56228
56229
56230
56231
56232
56233
56234
56235
56236
56237
56238
56239
56240
56241
56242
56243
56244
56245
56246
56247
56248
56249
56250
56251
56252
56253
56254
56255
56256
56257
56258
56259
56260
56261
56262
56263
56264
56265
56266
56267
56268
56269
56270
56271
56272
56273
56274
56275
56276
56277
56278
56279
56280
56281
56282
56283
56284
56285
56286
56287
56288
56289
56290
56291
56292
56293
56294
56295
56296
56297
56298
56299
56300
56301
56302
56303
56304
56305
56306
56307
56308
56309
56310
56311
56312
56313
56314
56315
56316
56317
56318
56319
56320
56321
56322
56323
56324
56325
56326
56327
56328
56329
56330
56331
56332
56333
56334
56335
56336
56337
56338
56339
56340
56341
56342
56343
56344
56345
56346
56347
56348
56349
56350
56351
56352
56353
56354
56355
56356
56357
56358
56359
56360
56361
56362
56363
56364
56365
56366
56367
56368
56369
56370
56371
56372
56373
56374
56375
56376
56377
56378
56379
56380
56381
56382
56383
56384
56385
56386
56387
56388
56389
56390
56391
56392
56393
56394
56395
56396
56397
56398
56399
56400
56401
56402
56403
56404
56405
56406
56407
56408
56409
56410
56411
56412
56413
56414
56415
56416
56417
56418
56419
56420
56421
56422
56423
56424
56425
56426
56427
56428
56429
56430
56431
56432
56433
56434
56435
56436
56437
56438
56439
56440
56441
56442
56443
56444
56445
56446
56447
56448
56449
56450
56451
56452
56453
56454
56455
56456
56457
56458
56459
56460
56461
56462
56463
56464
56465
56466
56467
56468
56469
56470
56471
56472
56473
56474
56475
56476
56477
56478
56479
56480
56481
56482
56483
56484
56485
56486
56487
56488
56489
56490
56491
56492
56493
56494
56495
56496
56497
56498
56499
56500
56501
56502
56503
56504
56505
56506
56507
56508
56509
56510
56511
56512
56513
56514
56515
56516
56517
56518
56519
56520
56521
56522
56523
56524
56525
56526
56527
56528
56529
56530
56531
56532
56533
56534
56535
56536
56537
56538
56539
56540
56541
56542
56543
56544
56545
56546
56547
56548
56549
56550
56551
56552
56553
56554
56555
56556
56557
56558
56559
56560
56561
56562
56563
56564
56565
56566
56567
56568
56569
56570
56571
56572
56573
56574
56575
56576
56577
56578
56579
56580
56581
56582
56583
56584
56585
56586
56587
56588
56589
56590
56591
56592
56593
56594
56595
56596
56597
56598
56599
56600
56601
56602
56603
56604
56605
56606
56607
56608
56609
56610
56611
56612
56613
56614
56615
56616
56617
56618
56619
56620
56621
56622
56623
56624
56625
56626
56627
56628
56629
56630
56631
56632
56633
56634
56635
56636
56637
56638
56639
56640
56641
56642
56643
56644
56645
56646
56647
56648
56649
56650
56651
56652
56653
56654
56655
56656
56657
56658
56659
56660
56661
56662
56663
56664
56665
56666
56667
56668
56669
56670
56671
56672
56673
56674
56675
56676
56677
56678
56679
56680
56681
56682
56683
56684
56685
56686
56687
56688
56689
56690
56691
56692
56693
56694
56695
56696
56697
56698
56699
56700
56701
56702
56703
56704
56705
56706
56707
56708
56709
56710
56711
56712
56713
56714
56715
56716
56717
56718
56719
56720
56721
56722
56723
56724
56725
56726
56727
56728
56729
56730
56731
56732
56733
56734
56735
56736
56737
56738
56739
56740
56741
56742
56743
56744
56745
56746
56747
56748
56749
56750
56751
56752
56753
56754
56755
56756
56757
56758
56759
56760
56761
56762
56763
56764
56765
56766
56767
56768
56769
56770
56771
56772
56773
56774
56775
56776
56777
56778
56779
56780
56781
56782
56783
56784
56785
56786
56787
56788
56789
56790
56791
56792
56793
56794
56795
56796
56797
56798
56799
56800
56801
56802
56803
56804
56805
56806
56807
56808
56809
56810
56811
56812
56813
56814
56815
56816
56817
56818
56819
56820
56821
56822
56823
56824
56825
56826
56827
56828
56829
56830
56831
56832
56833
56834
56835
56836
56837
56838
56839
56840
56841
56842
56843
56844
56845
56846
56847
56848
56849
56850
56851
56852
56853
56854
56855
56856
56857
56858
56859
56860
56861
56862
56863
56864
56865
56866
56867
56868
56869
56870
56871
56872
56873
56874
56875
56876
56877
56878
56879
56880
56881
56882
56883
56884
56885
56886
56887
56888
56889
56890
56891
56892
56893
56894
56895
56896
56897
56898
56899
56900
56901
56902
56903
56904
56905
56906
56907
56908
56909
56910
56911
56912
56913
56914
56915
56916
56917
56918
56919
56920
56921
56922
56923
56924
56925
56926
56927
56928
56929
56930
56931
56932
56933
56934
56935
56936
56937
56938
56939
56940
56941
56942
56943
56944
56945
56946
56947
56948
56949
56950
56951
56952
56953
56954
56955
56956
56957
56958
56959
56960
56961
56962
56963
56964
56965
56966
56967
56968
56969
56970
56971
56972
56973
56974
56975
56976
56977
56978
56979
56980
56981
56982
56983
56984
56985
56986
56987
56988
56989
56990
56991
56992
56993
56994
56995
56996
56997
56998
56999
57000
57001
57002
57003
57004
57005
57006
57007
57008
57009
57010
57011
57012
57013
57014
57015
57016
57017
57018
57019
57020
57021
57022
57023
57024
57025
57026
57027
57028
57029
57030
57031
57032
57033
57034
57035
57036
57037
57038
57039
57040
57041
57042
57043
57044
57045
57046
57047
57048
57049
57050
57051
57052
57053
57054
57055
57056
57057
57058
57059
57060
57061
57062
57063
57064
57065
57066
57067
57068
57069
57070
57071
57072
57073
57074
57075
57076
57077
57078
57079
57080
57081
57082
57083
57084
57085
57086
57087
57088
57089
57090
57091
57092
57093
57094
57095
57096
57097
57098
57099
57100
57101
57102
57103
57104
57105
57106
57107
57108
57109
57110
57111
57112
57113
57114
57115
57116
57117
57118
57119
57120
57121
57122
57123
57124
57125
57126
57127
57128
57129
57130
57131
57132
57133
57134
57135
57136
57137
57138
57139
57140
57141
57142
57143
57144
57145
57146
57147
57148
57149
57150
57151
57152
57153
57154
57155
57156
57157
57158
57159
57160
57161
57162
57163
57164
57165
57166
57167
57168
57169
57170
57171
57172
57173
57174
57175
57176
57177
57178
57179
57180
57181
57182
57183
57184
57185
57186
57187
57188
57189
57190
57191
57192
57193
57194
57195
57196
57197
57198
57199
57200
57201
57202
57203
57204
57205
57206
57207
57208
57209
57210
57211
57212
57213
57214
57215
57216
57217
57218
57219
57220
57221
57222
57223
57224
57225
57226
57227
57228
57229
57230
57231
57232
57233
57234
57235
57236
57237
57238
57239
57240
57241
57242
57243
57244
57245
57246
57247
57248
57249
57250
57251
57252
57253
57254
57255
57256
57257
57258
57259
57260
57261
57262
57263
57264
57265
57266
57267
57268
57269
57270
57271
57272
57273
57274
57275
57276
57277
57278
57279
57280
57281
57282
57283
57284
57285
57286
57287
57288
57289
57290
57291
57292
57293
57294
57295
57296
57297
57298
57299
57300
57301
57302
57303
57304
57305
57306
57307
57308
57309
57310
57311
57312
57313
57314
57315
57316
57317
57318
57319
57320
57321
57322
57323
57324
57325
57326
57327
57328
57329
57330
57331
57332
57333
57334
57335
57336
57337
57338
57339
57340
57341
57342
57343
57344
57345
57346
57347
57348
57349
57350
57351
57352
57353
57354
57355
57356
57357
57358
57359
57360
57361
57362
57363
57364
57365
57366
57367
57368
57369
57370
57371
57372
57373
57374
57375
57376
57377
57378
57379
57380
57381
57382
57383
57384
57385
57386
57387
57388
57389
57390
57391
57392
57393
57394
57395
57396
57397
57398
57399
57400
57401
57402
57403
57404
57405
57406
57407
57408
57409
57410
57411
57412
57413
57414
57415
57416
57417
57418
57419
57420
57421
57422
57423
57424
57425
57426
57427
57428
57429
57430
57431
57432
57433
57434
57435
57436
57437
57438
57439
57440
57441
57442
57443
57444
57445
57446
57447
57448
57449
57450
57451
57452
57453
57454
57455
57456
57457
57458
57459
57460
57461
57462
57463
57464
57465
57466
57467
57468
57469
57470
57471
57472
57473
57474
57475
57476
57477
57478
57479
57480
57481
57482
57483
57484
57485
57486
57487
57488
57489
57490
57491
57492
57493
57494
57495
57496
57497
57498
57499
57500
57501
57502
57503
57504
57505
57506
57507
57508
57509
57510
57511
57512
57513
57514
57515
57516
57517
57518
57519
57520
57521
57522
57523
57524
57525
57526
57527
57528
57529
57530
57531
57532
57533
57534
57535
57536
57537
57538
57539
57540
57541
57542
57543
57544
57545
57546
57547
57548
57549
57550
57551
57552
57553
57554
57555
57556
57557
57558
57559
57560
57561
57562
57563
57564
57565
57566
57567
57568
57569
57570
57571
57572
57573
57574
57575
57576
57577
57578
57579
57580
57581
57582
57583
57584
57585
57586
57587
57588
57589
57590
57591
57592
57593
57594
57595
57596
57597
57598
57599
57600
57601
57602
57603
57604
57605
57606
57607
57608
57609
57610
57611
57612
57613
57614
57615
57616
57617
57618
57619
57620
57621
57622
57623
57624
57625
57626
57627
57628
57629
57630
57631
57632
57633
57634
57635
57636
57637
57638
57639
57640
57641
57642
57643
57644
57645
57646
57647
57648
57649
57650
57651
57652
57653
57654
57655
57656
57657
57658
57659
57660
57661
57662
57663
57664
57665
57666
57667
57668
57669
57670
57671
57672
57673
57674
57675
57676
57677
57678
57679
57680
57681
57682
57683
57684
57685
57686
57687
57688
57689
57690
57691
57692
57693
57694
57695
57696
57697
57698
57699
57700
57701
57702
57703
57704
57705
57706
57707
57708
57709
57710
57711
57712
57713
57714
57715
57716
57717
57718
57719
57720
57721
57722
57723
57724
57725
57726
57727
57728
57729
57730
57731
57732
57733
57734
57735
57736
57737
57738
57739
57740
57741
57742
57743
57744
57745
57746
57747
57748
57749
57750
57751
57752
57753
57754
57755
57756
57757
57758
57759
57760
57761
57762
57763
57764
57765
57766
57767
57768
57769
57770
57771
57772
57773
57774
57775
57776
57777
57778
57779
57780
57781
57782
57783
57784
57785
57786
57787
57788
57789
57790
57791
57792
57793
57794
57795
57796
57797
57798
57799
57800
57801
57802
57803
57804
57805
57806
57807
57808
57809
57810
57811
57812
57813
57814
57815
57816
57817
57818
57819
57820
57821
57822
57823
57824
57825
57826
57827
57828
57829
57830
57831
57832
57833
57834
57835
57836
57837
57838
57839
57840
57841
57842
57843
57844
57845
57846
57847
57848
57849
57850
57851
57852
57853
57854
57855
57856
57857
57858
57859
57860
57861
57862
57863
57864
57865
57866
57867
57868
57869
57870
57871
57872
57873
57874
57875
57876
57877
57878
57879
57880
57881
57882
57883
57884
57885
57886
57887
57888
57889
57890
57891
57892
57893
57894
57895
57896
57897
57898
57899
57900
57901
57902
57903
57904
57905
57906
57907
57908
57909
57910
57911
57912
57913
57914
57915
57916
57917
57918
57919
57920
57921
57922
57923
57924
57925
57926
57927
57928
57929
57930
57931
57932
57933
57934
57935
57936
57937
57938
57939
57940
57941
57942
57943
57944
57945
57946
57947
57948
57949
57950
57951
57952
57953
57954
57955
57956
57957
57958
57959
57960
57961
57962
57963
57964
57965
57966
57967
57968
57969
57970
57971
57972
57973
57974
57975
57976
57977
57978
57979
57980
57981
57982
57983
57984
57985
57986
57987
57988
57989
57990
57991
57992
57993
57994
57995
57996
57997
57998
57999
58000
58001
58002
58003
58004
58005
58006
58007
58008
58009
58010
58011
58012
58013
58014
58015
58016
58017
58018
58019
58020
58021
58022
58023
58024
58025
58026
58027
58028
58029
58030
58031
58032
58033
58034
58035
58036
58037
58038
58039
58040
58041
58042
58043
58044
58045
58046
58047
58048
58049
58050
58051
58052
58053
58054
58055
58056
58057
58058
58059
58060
58061
58062
58063
58064
58065
58066
58067
58068
58069
58070
58071
58072
58073
58074
58075
58076
58077
58078
58079
58080
58081
58082
58083
58084
58085
58086
58087
58088
58089
58090
58091
58092
58093
58094
58095
58096
58097
58098
58099
58100
58101
58102
58103
58104
58105
58106
58107
58108
58109
58110
58111
58112
58113
58114
58115
58116
58117
58118
58119
58120
58121
58122
58123
58124
58125
58126
58127
58128
58129
58130
58131
58132
58133
58134
58135
58136
58137
58138
58139
58140
58141
58142
58143
58144
58145
58146
58147
58148
58149
58150
58151
58152
58153
58154
58155
58156
58157
58158
58159
58160
58161
58162
58163
58164
58165
58166
58167
58168
58169
58170
58171
58172
58173
58174
58175
58176
58177
58178
58179
58180
58181
58182
58183
58184
58185
58186
58187
58188
58189
58190
58191
58192
58193
58194
58195
58196
58197
58198
58199
58200
58201
58202
58203
58204
58205
58206
58207
58208
58209
58210
58211
58212
58213
58214
58215
58216
58217
58218
58219
58220
58221
58222
58223
58224
58225
58226
58227
58228
58229
58230
58231
58232
58233
58234
58235
58236
58237
58238
58239
58240
58241
58242
58243
58244
58245
58246
58247
58248
58249
58250
58251
58252
58253
58254
58255
58256
58257
58258
58259
58260
58261
58262
58263
58264
58265
58266
58267
58268
58269
58270
58271
58272
58273
58274
58275
58276
58277
58278
58279
58280
58281
58282
58283
58284
58285
58286
58287
58288
58289
58290
58291
58292
58293
58294
58295
58296
58297
58298
58299
58300
58301
58302
58303
58304
58305
58306
58307
58308
58309
58310
58311
58312
58313
58314
58315
58316
58317
58318
58319
58320
58321
58322
58323
58324
58325
58326
58327
58328
58329
58330
58331
58332
58333
58334
58335
58336
58337
58338
58339
58340
58341
58342
58343
58344
58345
58346
58347
58348
58349
58350
58351
58352
58353
58354
58355
58356
58357
58358
58359
58360
58361
58362
58363
58364
58365
58366
58367
58368
58369
58370
58371
58372
58373
58374
58375
58376
58377
58378
58379
58380
58381
58382
58383
58384
58385
58386
58387
58388
58389
58390
58391
58392
58393
58394
58395
58396
58397
58398
58399
58400
58401
58402
58403
58404
58405
58406
58407
58408
58409
58410
58411
58412
58413
58414
58415
58416
58417
58418
58419
58420
58421
58422
58423
58424
58425
58426
58427
58428
58429
58430
58431
58432
58433
58434
58435
58436
58437
58438
58439
58440
58441
58442
58443
58444
58445
58446
58447
58448
58449
58450
58451
58452
58453
58454
58455
58456
58457
58458
58459
58460
58461
58462
58463
58464
58465
58466
58467
58468
58469
58470
58471
58472
58473
58474
58475
58476
58477
58478
58479
58480
58481
58482
58483
58484
58485
58486
58487
58488
58489
58490
58491
58492
58493
58494
58495
58496
58497
58498
58499
58500
58501
58502
58503
58504
58505
58506
58507
58508
58509
58510
58511
58512
58513
58514
58515
58516
58517
58518
58519
58520
58521
58522
58523
58524
58525
58526
58527
58528
58529
58530
58531
58532
58533
58534
58535
58536
58537
58538
58539
58540
58541
58542
58543
58544
58545
58546
58547
58548
58549
58550
58551
58552
58553
58554
58555
58556
58557
58558
58559
58560
58561
58562
58563
58564
58565
58566
58567
58568
58569
58570
58571
58572
58573
58574
58575
58576
58577
58578
58579
58580
58581
58582
58583
58584
58585
58586
58587
58588
58589
58590
58591
58592
58593
58594
58595
58596
58597
58598
58599
58600
58601
58602
58603
58604
58605
58606
58607
58608
58609
58610
58611
58612
58613
58614
58615
58616
58617
58618
58619
58620
58621
58622
58623
58624
58625
58626
58627
58628
58629
58630
58631
58632
58633
58634
58635
58636
58637
58638
58639
58640
58641
58642
58643
58644
58645
58646
58647
58648
58649
58650
58651
58652
58653
58654
58655
58656
58657
58658
58659
58660
58661
58662
58663
58664
58665
58666
58667
58668
58669
58670
58671
58672
58673
58674
58675
58676
58677
58678
58679
58680
58681
58682
58683
58684
58685
58686
58687
58688
58689
58690
58691
58692
58693
58694
58695
58696
58697
58698
58699
58700
58701
58702
58703
58704
58705
58706
58707
58708
58709
58710
58711
58712
58713
58714
58715
58716
58717
58718
58719
58720
58721
58722
58723
58724
58725
58726
58727
58728
58729
58730
58731
58732
58733
58734
58735
58736
58737
58738
58739
58740
58741
58742
58743
58744
58745
58746
58747
58748
58749
58750
58751
58752
58753
58754
58755
58756
58757
58758
58759
58760
58761
58762
58763
58764
58765
58766
58767
58768
58769
58770
58771
58772
58773
58774
58775
58776
58777
58778
58779
58780
58781
58782
58783
58784
58785
58786
58787
58788
58789
58790
58791
58792
58793
58794
58795
58796
58797
58798
58799
58800
58801
58802
58803
58804
58805
58806
58807
58808
58809
58810
58811
58812
58813
58814
58815
58816
58817
58818
58819
58820
58821
58822
58823
58824
58825
58826
58827
58828
58829
58830
58831
58832
58833
58834
58835
58836
58837
58838
58839
58840
58841
58842
58843
58844
58845
58846
58847
58848
58849
58850
58851
58852
58853
58854
58855
58856
58857
58858
58859
58860
58861
58862
58863
58864
58865
58866
58867
58868
58869
58870
58871
58872
58873
58874
58875
58876
58877
58878
58879
58880
58881
58882
58883
58884
58885
58886
58887
58888
58889
58890
58891
58892
58893
58894
58895
58896
58897
58898
58899
58900
58901
58902
58903
58904
58905
58906
58907
58908
58909
58910
58911
58912
58913
58914
58915
58916
58917
58918
58919
58920
58921
58922
58923
58924
58925
58926
58927
58928
58929
58930
58931
58932
58933
58934
58935
58936
58937
58938
58939
58940
58941
58942
58943
58944
58945
58946
58947
58948
58949
58950
58951
58952
58953
58954
58955
58956
58957
58958
58959
58960
58961
58962
58963
58964
58965
58966
58967
58968
58969
58970
58971
58972
58973
58974
58975
58976
58977
58978
58979
58980
58981
58982
58983
58984
58985
58986
58987
58988
58989
58990
58991
58992
58993
58994
58995
58996
58997
58998
58999
59000
59001
59002
59003
59004
59005
59006
59007
59008
59009
59010
59011
59012
59013
59014
59015
59016
59017
59018
59019
59020
59021
59022
59023
59024
59025
59026
59027
59028
59029
59030
59031
59032
59033
59034
59035
59036
59037
59038
59039
59040
59041
59042
59043
59044
59045
59046
59047
59048
59049
59050
59051
59052
59053
59054
59055
59056
59057
59058
59059
59060
59061
59062
59063
59064
59065
59066
59067
59068
59069
59070
59071
59072
59073
59074
59075
59076
59077
59078
59079
59080
59081
59082
59083
59084
59085
59086
59087
59088
59089
59090
59091
59092
59093
59094
59095
59096
59097
59098
59099
59100
59101
59102
59103
59104
59105
59106
59107
59108
59109
59110
59111
59112
59113
59114
59115
59116
59117
59118
59119
59120
59121
59122
59123
59124
59125
59126
59127
59128
59129
59130
59131
59132
59133
59134
59135
59136
59137
59138
59139
59140
59141
59142
59143
59144
59145
59146
59147
59148
59149
59150
59151
59152
59153
59154
59155
59156
59157
59158
59159
59160
59161
59162
59163
59164
59165
59166
59167
59168
59169
59170
59171
59172
59173
59174
59175
59176
59177
59178
59179
59180
59181
59182
59183
59184
59185
59186
59187
59188
59189
59190
59191
59192
59193
59194
59195
59196
59197
59198
59199
59200
59201
59202
59203
59204
59205
59206
59207
59208
59209
59210
59211
59212
59213
59214
59215
59216
59217
59218
59219
59220
59221
59222
59223
59224
59225
59226
59227
59228
59229
59230
59231
59232
59233
59234
59235
59236
59237
59238
59239
59240
59241
59242
59243
59244
59245
59246
59247
59248
59249
59250
59251
59252
59253
59254
59255
59256
59257
59258
59259
59260
59261
59262
59263
59264
59265
59266
59267
59268
59269
59270
59271
59272
59273
59274
59275
59276
59277
59278
59279
59280
59281
59282
59283
59284
59285
59286
59287
59288
59289
59290
59291
59292
59293
59294
59295
59296
59297
59298
59299
59300
59301
59302
59303
59304
59305
59306
59307
59308
59309
59310
59311
59312
59313
59314
59315
59316
59317
59318
59319
59320
59321
59322
59323
59324
59325
59326
59327
59328
59329
59330
59331
59332
59333
59334
59335
59336
59337
59338
59339
59340
59341
59342
59343
59344
59345
59346
59347
59348
59349
59350
59351
59352
59353
59354
59355
59356
59357
59358
59359
59360
59361
59362
59363
59364
59365
59366
59367
59368
59369
59370
59371
59372
59373
59374
59375
59376
59377
59378
59379
59380
59381
59382
59383
59384
59385
59386
59387
59388
59389
59390
59391
59392
59393
59394
59395
59396
59397
59398
59399
59400
59401
59402
59403
59404
59405
59406
59407
59408
59409
59410
59411
59412
59413
59414
59415
59416
59417
59418
59419
59420
59421
59422
59423
59424
59425
59426
59427
59428
59429
59430
59431
59432
59433
59434
59435
59436
59437
59438
59439
59440
59441
59442
59443
59444
59445
59446
59447
59448
59449
59450
59451
59452
59453
59454
59455
59456
59457
59458
59459
59460
59461
59462
59463
59464
59465
59466
59467
59468
59469
59470
59471
59472
59473
59474
59475
59476
59477
59478
59479
59480
59481
59482
59483
59484
59485
59486
59487
59488
59489
59490
59491
59492
59493
59494
59495
59496
59497
59498
59499
59500
59501
59502
59503
59504
59505
59506
59507
59508
59509
59510
59511
59512
59513
59514
59515
59516
59517
59518
59519
59520
59521
59522
59523
59524
59525
59526
59527
59528
59529
59530
59531
59532
59533
59534
59535
59536
59537
59538
59539
59540
59541
59542
59543
59544
59545
59546
59547
59548
59549
59550
59551
59552
59553
59554
59555
59556
59557
59558
59559
59560
59561
59562
59563
59564
59565
59566
59567
59568
59569
59570
59571
59572
59573
59574
59575
59576
59577
59578
59579
59580
59581
59582
59583
59584
59585
59586
59587
59588
59589
59590
59591
59592
59593
59594
59595
59596
59597
59598
59599
59600
59601
59602
59603
59604
59605
59606
59607
59608
59609
59610
59611
59612
59613
59614
59615
59616
59617
59618
59619
59620
59621
59622
59623
59624
59625
59626
59627
59628
59629
59630
59631
59632
59633
59634
59635
59636
59637
59638
59639
59640
59641
59642
59643
59644
59645
59646
59647
59648
59649
59650
59651
59652
59653
59654
59655
59656
59657
59658
59659
59660
59661
59662
59663
59664
59665
59666
59667
59668
59669
59670
59671
59672
59673
59674
59675
59676
59677
59678
59679
59680
59681
59682
59683
59684
59685
59686
59687
59688
59689
59690
59691
59692
59693
59694
59695
59696
59697
59698
59699
59700
59701
59702
59703
59704
59705
59706
59707
59708
59709
59710
59711
59712
59713
59714
59715
59716
59717
59718
59719
59720
59721
59722
59723
59724
59725
59726
59727
59728
59729
59730
59731
59732
59733
59734
59735
59736
59737
59738
59739
59740
59741
59742
59743
59744
59745
59746
59747
59748
59749
59750
59751
59752
59753
59754
59755
59756
59757
59758
59759
59760
59761
59762
59763
59764
59765
59766
59767
59768
59769
59770
59771
59772
59773
59774
59775
59776
59777
59778
59779
59780
59781
59782
59783
59784
59785
59786
59787
59788
59789
59790
59791
59792
59793
59794
59795
59796
59797
59798
59799
59800
59801
59802
59803
59804
59805
59806
59807
59808
59809
59810
59811
59812
59813
59814
59815
59816
59817
59818
59819
59820
59821
59822
59823
59824
59825
59826
59827
59828
59829
59830
59831
59832
59833
59834
59835
59836
59837
59838
59839
59840
59841
59842
59843
59844
59845
59846
59847
59848
59849
59850
59851
59852
59853
59854
59855
59856
59857
59858
59859
59860
59861
59862
59863
59864
59865
59866
59867
59868
59869
59870
59871
59872
59873
59874
59875
59876
59877
59878
59879
59880
59881
59882
59883
59884
59885
59886
59887
59888
59889
59890
59891
59892
59893
59894
59895
59896
59897
59898
59899
59900
59901
59902
59903
59904
59905
59906
59907
59908
59909
59910
59911
59912
59913
59914
59915
59916
59917
59918
59919
59920
59921
59922
59923
59924
59925
59926
59927
59928
59929
59930
59931
59932
59933
59934
59935
59936
59937
59938
59939
59940
59941
59942
59943
59944
59945
59946
59947
59948
59949
59950
59951
59952
59953
59954
59955
59956
59957
59958
59959
59960
59961
59962
59963
59964
59965
59966
59967
59968
59969
59970
59971
59972
59973
59974
59975
59976
59977
59978
59979
59980
59981
59982
59983
59984
59985
59986
59987
59988
59989
59990
59991
59992
59993
59994
59995
59996
59997
59998
59999
60000
60001
60002
60003
60004
60005
60006
60007
60008
60009
60010
60011
60012
60013
60014
60015
60016
60017
60018
60019
60020
60021
60022
60023
60024
60025
60026
60027
60028
60029
60030
60031
60032
60033
60034
60035
60036
60037
60038
60039
60040
60041
60042
60043
60044
60045
60046
60047
60048
60049
60050
60051
60052
60053
60054
60055
60056
60057
60058
60059
60060
60061
60062
60063
60064
60065
60066
60067
60068
60069
60070
60071
60072
60073
60074
60075
60076
60077
60078
60079
60080
60081
60082
60083
60084
60085
60086
60087
60088
60089
60090
60091
60092
60093
60094
60095
60096
60097
60098
60099
60100
60101
60102
60103
60104
60105
60106
60107
60108
60109
60110
60111
60112
60113
60114
60115
60116
60117
60118
60119
60120
60121
60122
60123
60124
60125
60126
60127
60128
60129
60130
60131
60132
60133
60134
60135
60136
60137
60138
60139
60140
60141
60142
60143
60144
60145
60146
60147
60148
60149
60150
60151
60152
60153
60154
60155
60156
60157
60158
60159
60160
60161
60162
60163
60164
60165
60166
60167
60168
60169
60170
60171
60172
60173
60174
60175
60176
60177
60178
60179
60180
60181
60182
60183
60184
60185
60186
60187
60188
60189
60190
60191
60192
60193
60194
60195
60196
60197
60198
60199
60200
60201
60202
60203
60204
60205
60206
60207
60208
60209
60210
60211
60212
60213
60214
60215
60216
60217
60218
60219
60220
60221
60222
60223
60224
60225
60226
60227
60228
60229
60230
60231
60232
60233
60234
60235
60236
60237
60238
60239
60240
60241
60242
60243
60244
60245
60246
60247
60248
60249
60250
60251
60252
60253
60254
60255
60256
60257
60258
60259
60260
60261
60262
60263
60264
60265
60266
60267
60268
60269
60270
60271
60272
60273
60274
60275
60276
60277
60278
60279
60280
60281
60282
60283
60284
60285
60286
60287
60288
60289
60290
60291
60292
60293
60294
60295
60296
60297
60298
60299
60300
60301
60302
60303
60304
60305
60306
60307
60308
60309
60310
60311
60312
60313
60314
60315
60316
60317
60318
60319
60320
60321
60322
60323
60324
60325
60326
60327
60328
60329
60330
60331
60332
60333
60334
60335
60336
60337
60338
60339
60340
60341
60342
60343
60344
60345
60346
60347
60348
60349
60350
60351
60352
60353
60354
60355
60356
60357
60358
60359
60360
60361
60362
60363
60364
60365
60366
60367
60368
60369
60370
60371
60372
60373
60374
60375
60376
60377
60378
60379
60380
60381
60382
60383
60384
60385
60386
60387
60388
60389
60390
60391
60392
60393
60394
60395
60396
60397
60398
60399
60400
60401
60402
60403
60404
60405
60406
60407
60408
60409
60410
60411
60412
60413
60414
60415
60416
60417
60418
60419
60420
60421
60422
60423
60424
60425
60426
60427
60428
60429
60430
60431
60432
60433
60434
60435
60436
60437
60438
60439
60440
60441
60442
60443
60444
60445
60446
60447
60448
60449
60450
60451
60452
60453
60454
60455
60456
60457
60458
60459
60460
60461
60462
60463
60464
60465
60466
60467
60468
60469
60470
60471
60472
60473
60474
60475
60476
60477
60478
60479
60480
60481
60482
60483
60484
60485
60486
60487
60488
60489
60490
60491
60492
60493
60494
60495
60496
60497
60498
60499
60500
60501
60502
60503
60504
60505
60506
60507
60508
60509
60510
60511
60512
60513
60514
60515
60516
60517
60518
60519
60520
60521
60522
60523
60524
60525
60526
60527
60528
60529
60530
60531
60532
60533
60534
60535
60536
60537
60538
60539
60540
60541
60542
60543
60544
60545
60546
60547
60548
60549
60550
60551
60552
60553
60554
60555
60556
60557
60558
60559
60560
60561
60562
60563
60564
60565
60566
60567
60568
60569
60570
60571
60572
60573
60574
60575
60576
60577
60578
60579
60580
60581
60582
60583
60584
60585
60586
60587
60588
60589
60590
60591
60592
60593
60594
60595
60596
60597
60598
60599
60600
60601
60602
60603
60604
60605
60606
60607
60608
60609
60610
60611
60612
60613
60614
60615
60616
60617
60618
60619
60620
60621
60622
60623
60624
60625
60626
60627
60628
60629
60630
60631
60632
60633
60634
60635
60636
60637
60638
60639
60640
60641
60642
60643
60644
60645
60646
60647
60648
60649
60650
60651
60652
60653
60654
60655
60656
60657
60658
60659
60660
60661
60662
60663
60664
60665
60666
60667
60668
60669
60670
60671
60672
60673
60674
60675
60676
60677
60678
60679
60680
60681
60682
60683
60684
60685
60686
60687
60688
60689
60690
60691
60692
60693
60694
60695
60696
60697
60698
60699
60700
60701
60702
60703
60704
60705
60706
60707
60708
60709
60710
60711
60712
60713
60714
60715
60716
60717
60718
60719
60720
60721
60722
60723
60724
60725
60726
60727
60728
60729
60730
60731
60732
60733
60734
60735
60736
60737
60738
60739
60740
60741
60742
60743
60744
60745
60746
60747
60748
60749
60750
60751
60752
60753
60754
60755
60756
60757
60758
60759
60760
60761
60762
60763
60764
60765
60766
60767
60768
60769
60770
60771
60772
60773
60774
60775
60776
60777
60778
60779
60780
60781
60782
60783
60784
60785
60786
60787
60788
60789
60790
60791
60792
60793
60794
60795
60796
60797
60798
60799
60800
60801
60802
60803
60804
60805
60806
60807
60808
60809
60810
60811
60812
60813
60814
60815
60816
60817
60818
60819
60820
60821
60822
60823
60824
60825
60826
60827
60828
60829
60830
60831
60832
60833
60834
60835
60836
60837
60838
60839
60840
60841
60842
60843
60844
60845
60846
60847
60848
60849
60850
60851
60852
60853
60854
60855
60856
60857
60858
60859
60860
60861
60862
60863
60864
60865
60866
60867
60868
60869
60870
60871
60872
60873
60874
60875
60876
60877
60878
60879
60880
60881
60882
60883
60884
60885
60886
60887
60888
60889
60890
60891
60892
60893
60894
60895
60896
60897
60898
60899
60900
60901
60902
60903
60904
60905
60906
60907
60908
60909
60910
60911
60912
60913
60914
60915
60916
60917
60918
60919
60920
60921
60922
60923
60924
60925
60926
60927
60928
60929
60930
60931
60932
60933
60934
60935
60936
60937
60938
60939
60940
60941
60942
60943
60944
60945
60946
60947
60948
60949
60950
60951
60952
60953
60954
60955
60956
60957
60958
60959
60960
60961
60962
60963
60964
60965
60966
60967
60968
60969
60970
60971
60972
60973
60974
60975
60976
60977
60978
60979
60980
60981
60982
60983
60984
60985
60986
60987
60988
60989
60990
60991
60992
60993
60994
60995
60996
60997
60998
60999
61000
61001
61002
61003
61004
61005
61006
61007
61008
61009
61010
61011
61012
61013
61014
61015
61016
61017
61018
61019
61020
61021
61022
61023
61024
61025
61026
61027
61028
61029
61030
61031
61032
61033
61034
61035
61036
61037
61038
61039
61040
61041
61042
61043
61044
61045
61046
61047
61048
61049
61050
61051
61052
61053
61054
61055
61056
61057
61058
61059
61060
61061
61062
61063
61064
61065
61066
61067
61068
61069
61070
61071
61072
61073
61074
61075
61076
61077
61078
61079
61080
61081
61082
61083
61084
61085
61086
61087
61088
61089
61090
61091
61092
61093
61094
61095
61096
61097
61098
61099
61100
61101
61102
61103
61104
61105
61106
61107
61108
61109
61110
61111
61112
61113
61114
61115
61116
61117
61118
61119
61120
61121
61122
61123
61124
61125
61126
61127
61128
61129
61130
61131
61132
61133
61134
61135
61136
61137
61138
61139
61140
61141
61142
61143
61144
61145
61146
61147
61148
61149
61150
61151
61152
61153
61154
61155
61156
61157
61158
61159
61160
61161
61162
61163
61164
61165
61166
61167
61168
61169
61170
61171
61172
61173
61174
61175
61176
61177
61178
61179
61180
61181
61182
61183
61184
61185
61186
61187
61188
61189
61190
61191
61192
61193
61194
61195
61196
61197
61198
61199
61200
61201
61202
61203
61204
61205
61206
61207
61208
61209
61210
61211
61212
61213
61214
61215
61216
61217
61218
61219
61220
61221
61222
61223
61224
61225
61226
61227
61228
61229
61230
61231
61232
61233
61234
61235
61236
61237
61238
61239
61240
61241
61242
61243
61244
61245
61246
61247
61248
61249
61250
61251
61252
61253
61254
61255
61256
61257
61258
61259
61260
61261
61262
61263
61264
61265
61266
61267
61268
61269
61270
61271
61272
61273
61274
61275
61276
61277
61278
61279
61280
61281
61282
61283
61284
61285
61286
61287
61288
61289
61290
61291
61292
61293
61294
61295
61296
61297
61298
61299
61300
61301
61302
61303
61304
61305
61306
61307
61308
61309
61310
61311
61312
61313
61314
61315
61316
61317
61318
61319
61320
61321
61322
61323
61324
61325
61326
61327
61328
61329
61330
61331
61332
61333
61334
61335
61336
61337
61338
61339
61340
61341
61342
61343
61344
61345
61346
61347
61348
61349
61350
61351
61352
61353
61354
61355
61356
61357
61358
61359
61360
61361
61362
61363
61364
61365
61366
61367
61368
61369
61370
61371
61372
61373
61374
61375
61376
61377
61378
61379
61380
61381
61382
61383
61384
61385
61386
61387
61388
61389
61390
61391
61392
61393
61394
61395
61396
61397
61398
61399
61400
61401
61402
61403
61404
61405
61406
61407
61408
61409
61410
61411
61412
61413
61414
61415
61416
61417
61418
61419
61420
61421
61422
61423
61424
61425
61426
61427
61428
61429
61430
61431
61432
61433
61434
61435
61436
61437
61438
61439
61440
61441
61442
61443
61444
61445
61446
61447
61448
61449
61450
61451
61452
61453
61454
61455
61456
61457
61458
61459
61460
61461
61462
61463
61464
61465
61466
61467
61468
61469
61470
61471
61472
61473
61474
61475
61476
61477
61478
61479
61480
61481
61482
61483
61484
61485
61486
61487
61488
61489
61490
61491
61492
61493
61494
61495
61496
61497
61498
61499
61500
61501
61502
61503
61504
61505
61506
61507
61508
61509
61510
61511
61512
61513
61514
61515
61516
61517
61518
61519
61520
61521
61522
61523
61524
61525
61526
61527
61528
61529
61530
61531
61532
61533
61534
61535
61536
61537
61538
61539
61540
61541
61542
61543
61544
61545
61546
61547
61548
61549
61550
61551
61552
61553
61554
61555
61556
61557
61558
61559
61560
61561
61562
61563
61564
61565
61566
61567
61568
61569
61570
61571
61572
61573
61574
61575
61576
61577
61578
61579
61580
61581
61582
61583
61584
61585
61586
61587
61588
61589
61590
61591
61592
61593
61594
61595
61596
61597
61598
61599
61600
61601
61602
61603
61604
61605
61606
61607
61608
61609
61610
61611
61612
61613
61614
61615
61616
61617
61618
61619
61620
61621
61622
61623
61624
61625
61626
61627
61628
61629
61630
61631
61632
61633
61634
61635
61636
61637
61638
61639
61640
61641
61642
61643
61644
61645
61646
61647
61648
61649
61650
61651
61652
61653
61654
61655
61656
61657
61658
61659
61660
61661
61662
61663
61664
61665
61666
61667
61668
61669
61670
61671
61672
61673
61674
61675
61676
61677
61678
61679
61680
61681
61682
61683
61684
61685
61686
61687
61688
61689
61690
61691
61692
61693
61694
61695
61696
61697
61698
61699
61700
61701
61702
61703
61704
61705
61706
61707
61708
61709
61710
61711
61712
61713
61714
61715
61716
61717
61718
61719
61720
61721
61722
61723
61724
61725
61726
61727
61728
61729
61730
61731
61732
61733
61734
61735
61736
61737
61738
61739
61740
61741
61742
61743
61744
61745
61746
61747
61748
61749
61750
61751
61752
61753
61754
61755
61756
61757
61758
61759
61760
61761
61762
61763
61764
61765
61766
61767
61768
61769
61770
61771
61772
61773
61774
61775
61776
61777
61778
61779
61780
61781
61782
61783
61784
61785
61786
61787
61788
61789
61790
61791
61792
61793
61794
61795
61796
61797
61798
61799
61800
61801
61802
61803
61804
61805
61806
61807
61808
61809
61810
61811
61812
61813
61814
61815
61816
61817
61818
61819
61820
61821
61822
61823
61824
61825
61826
61827
61828
61829
61830
61831
61832
61833
61834
61835
61836
61837
61838
61839
61840
61841
61842
61843
61844
61845
61846
61847
61848
61849
61850
61851
61852
61853
61854
61855
61856
61857
61858
61859
61860
61861
61862
61863
61864
61865
61866
61867
61868
61869
61870
61871
61872
61873
61874
61875
61876
61877
61878
61879
61880
61881
61882
61883
61884
61885
61886
61887
61888
61889
61890
61891
61892
61893
61894
61895
61896
61897
61898
61899
61900
61901
61902
61903
61904
61905
61906
61907
61908
61909
61910
61911
61912
61913
61914
61915
61916
61917
61918
61919
61920
61921
61922
61923
61924
61925
61926
61927
61928
61929
61930
61931
61932
61933
61934
61935
61936
61937
61938
61939
61940
61941
61942
61943
61944
61945
61946
61947
61948
61949
61950
61951
61952
61953
61954
61955
61956
61957
61958
61959
61960
61961
61962
61963
61964
61965
61966
61967
61968
61969
61970
61971
61972
61973
61974
61975
61976
61977
61978
61979
61980
61981
61982
61983
61984
61985
61986
61987
61988
61989
61990
61991
61992
61993
61994
61995
61996
61997
61998
61999
62000
62001
62002
62003
62004
62005
62006
62007
62008
62009
62010
62011
62012
62013
62014
62015
62016
62017
62018
62019
62020
62021
62022
62023
62024
62025
62026
62027
62028
62029
62030
62031
62032
62033
62034
62035
62036
62037
62038
62039
62040
62041
62042
62043
62044
62045
62046
62047
62048
62049
62050
62051
62052
62053
62054
62055
62056
62057
62058
62059
62060
62061
62062
62063
62064
62065
62066
62067
62068
62069
62070
62071
62072
62073
62074
62075
62076
62077
62078
62079
62080
62081
62082
62083
62084
62085
62086
62087
62088
62089
62090
62091
62092
62093
62094
62095
62096
62097
62098
62099
62100
62101
62102
62103
62104
62105
62106
62107
62108
62109
62110
62111
62112
62113
62114
62115
62116
62117
62118
62119
62120
62121
62122
62123
62124
62125
62126
62127
62128
62129
62130
62131
62132
62133
62134
62135
62136
62137
62138
62139
62140
62141
62142
62143
62144
62145
62146
62147
62148
62149
62150
62151
62152
62153
62154
62155
62156
62157
62158
62159
62160
62161
62162
62163
62164
62165
62166
62167
62168
62169
62170
62171
62172
62173
62174
62175
62176
62177
62178
62179
62180
62181
62182
62183
62184
62185
62186
62187
62188
62189
62190
62191
62192
62193
62194
62195
62196
62197
62198
62199
62200
62201
62202
62203
62204
62205
62206
62207
62208
62209
62210
62211
62212
62213
62214
62215
62216
62217
62218
62219
62220
62221
62222
62223
62224
62225
62226
62227
62228
62229
62230
62231
62232
62233
62234
62235
62236
62237
62238
62239
62240
62241
62242
62243
62244
62245
62246
62247
62248
62249
62250
62251
62252
62253
62254
62255
62256
62257
62258
62259
62260
62261
62262
62263
62264
62265
62266
62267
62268
62269
62270
62271
62272
62273
62274
62275
62276
62277
62278
62279
62280
62281
62282
62283
62284
62285
62286
62287
62288
62289
62290
62291
62292
62293
62294
62295
62296
62297
62298
62299
62300
62301
62302
62303
62304
62305
62306
62307
62308
62309
62310
62311
62312
62313
62314
62315
62316
62317
62318
62319
62320
62321
62322
62323
62324
62325
62326
62327
62328
62329
62330
62331
62332
62333
62334
62335
62336
62337
62338
62339
62340
62341
62342
62343
62344
62345
62346
62347
62348
62349
62350
62351
62352
62353
62354
62355
62356
62357
62358
62359
62360
62361
62362
62363
62364
62365
62366
62367
62368
62369
62370
62371
62372
62373
62374
62375
62376
62377
62378
62379
62380
62381
62382
62383
62384
62385
62386
62387
62388
62389
62390
62391
62392
62393
62394
62395
62396
62397
62398
62399
62400
62401
62402
62403
62404
62405
62406
62407
62408
62409
62410
62411
62412
62413
62414
62415
62416
62417
62418
62419
62420
62421
62422
62423
62424
62425
62426
62427
62428
62429
62430
62431
62432
62433
62434
62435
62436
62437
62438
62439
62440
62441
62442
62443
62444
62445
62446
62447
62448
62449
62450
62451
62452
62453
62454
62455
62456
62457
62458
62459
62460
62461
62462
62463
62464
62465
62466
62467
62468
62469
62470
62471
62472
62473
62474
62475
62476
62477
62478
62479
62480
62481
62482
62483
62484
62485
62486
62487
62488
62489
62490
62491
62492
62493
62494
62495
62496
62497
62498
62499
62500
62501
62502
62503
62504
62505
62506
62507
62508
62509
62510
62511
62512
62513
62514
62515
62516
62517
62518
62519
62520
62521
62522
62523
62524
62525
62526
62527
62528
62529
62530
62531
62532
62533
62534
62535
62536
62537
62538
62539
62540
62541
62542
62543
62544
62545
62546
62547
62548
62549
62550
62551
62552
62553
62554
62555
62556
62557
62558
62559
62560
62561
62562
62563
62564
62565
62566
62567
62568
62569
62570
62571
62572
62573
62574
62575
62576
62577
62578
62579
62580
62581
62582
62583
62584
62585
62586
62587
62588
62589
62590
62591
62592
62593
62594
62595
62596
62597
62598
62599
62600
62601
62602
62603
62604
62605
62606
62607
62608
62609
62610
62611
62612
62613
62614
62615
62616
62617
62618
62619
62620
62621
62622
62623
62624
62625
62626
62627
62628
62629
62630
62631
62632
62633
62634
62635
62636
62637
62638
62639
62640
62641
62642
62643
62644
62645
62646
62647
62648
62649
62650
62651
62652
62653
62654
62655
62656
62657
62658
62659
62660
62661
62662
62663
62664
62665
62666
62667
62668
62669
62670
62671
62672
62673
62674
62675
62676
62677
62678
62679
62680
62681
62682
62683
62684
62685
62686
62687
62688
62689
62690
62691
62692
62693
62694
62695
62696
62697
62698
62699
62700
62701
62702
62703
62704
62705
62706
62707
62708
62709
62710
62711
62712
62713
62714
62715
62716
62717
62718
62719
62720
62721
62722
62723
62724
62725
62726
62727
62728
62729
62730
62731
62732
62733
62734
62735
62736
62737
62738
62739
62740
62741
62742
62743
62744
62745
62746
62747
62748
62749
62750
62751
62752
62753
62754
62755
62756
62757
62758
62759
62760
62761
62762
62763
62764
62765
62766
62767
62768
62769
62770
62771
62772
62773
62774
62775
62776
62777
62778
62779
62780
62781
62782
62783
62784
62785
62786
62787
62788
62789
62790
62791
62792
62793
62794
62795
62796
62797
62798
62799
62800
62801
62802
62803
62804
62805
62806
62807
62808
62809
62810
62811
62812
62813
62814
62815
62816
62817
62818
62819
62820
62821
62822
62823
62824
62825
62826
62827
62828
62829
62830
62831
62832
62833
62834
62835
62836
62837
62838
62839
62840
62841
62842
62843
62844
62845
62846
62847
62848
62849
62850
62851
62852
62853
62854
62855
62856
62857
62858
62859
62860
62861
62862
62863
62864
62865
62866
62867
62868
62869
62870
62871
62872
62873
62874
62875
62876
62877
62878
62879
62880
62881
62882
62883
62884
62885
62886
62887
62888
62889
62890
62891
62892
62893
62894
62895
62896
62897
62898
62899
62900
62901
62902
62903
62904
62905
62906
62907
62908
62909
62910
62911
62912
62913
62914
62915
62916
62917
62918
62919
62920
62921
62922
62923
62924
62925
62926
62927
62928
62929
62930
62931
62932
62933
62934
62935
62936
62937
62938
62939
62940
62941
62942
62943
62944
62945
62946
62947
62948
62949
62950
62951
62952
62953
62954
62955
62956
62957
62958
62959
62960
62961
62962
62963
62964
62965
62966
62967
62968
62969
62970
62971
62972
62973
62974
62975
62976
62977
62978
62979
62980
62981
62982
62983
62984
62985
62986
62987
62988
62989
62990
62991
62992
62993
62994
62995
62996
62997
62998
62999
63000
63001
63002
63003
63004
63005
63006
63007
63008
63009
63010
63011
63012
63013
63014
63015
63016
63017
63018
63019
63020
63021
63022
63023
63024
63025
63026
63027
63028
63029
63030
63031
63032
63033
63034
63035
63036
63037
63038
63039
63040
63041
63042
63043
63044
63045
63046
63047
63048
63049
63050
63051
63052
63053
63054
63055
63056
63057
63058
63059
63060
63061
63062
63063
63064
63065
63066
63067
63068
63069
63070
63071
63072
63073
63074
63075
63076
63077
63078
63079
63080
63081
63082
63083
63084
63085
63086
63087
63088
63089
63090
63091
63092
63093
63094
63095
63096
63097
63098
63099
63100
63101
63102
63103
63104
63105
63106
63107
63108
63109
63110
63111
63112
63113
63114
63115
63116
63117
63118
63119
63120
63121
63122
63123
63124
63125
63126
63127
63128
63129
63130
63131
63132
63133
63134
63135
63136
63137
63138
63139
63140
63141
63142
63143
63144
63145
63146
63147
63148
63149
63150
63151
63152
63153
63154
63155
63156
63157
63158
63159
63160
63161
63162
63163
63164
63165
63166
63167
63168
63169
63170
63171
63172
63173
63174
63175
63176
63177
63178
63179
63180
63181
63182
63183
63184
63185
63186
63187
63188
63189
63190
63191
63192
63193
63194
63195
63196
63197
63198
63199
63200
63201
63202
63203
63204
63205
63206
63207
63208
63209
63210
63211
63212
63213
63214
63215
63216
63217
63218
63219
63220
63221
63222
63223
63224
63225
63226
63227
63228
63229
63230
63231
63232
63233
63234
63235
63236
63237
63238
63239
63240
63241
63242
63243
63244
63245
63246
63247
63248
63249
63250
63251
63252
63253
63254
63255
63256
63257
63258
63259
63260
63261
63262
63263
63264
63265
63266
63267
63268
63269
63270
63271
63272
63273
63274
63275
63276
63277
63278
63279
63280
63281
63282
63283
63284
63285
63286
63287
63288
63289
63290
63291
63292
63293
63294
63295
63296
63297
63298
63299
63300
63301
63302
63303
63304
63305
63306
63307
63308
63309
63310
63311
63312
63313
63314
63315
63316
63317
63318
63319
63320
63321
63322
63323
63324
63325
63326
63327
63328
63329
63330
63331
63332
63333
63334
63335
63336
63337
63338
63339
63340
63341
63342
63343
63344
63345
63346
63347
63348
63349
63350
63351
63352
63353
63354
63355
63356
63357
63358
63359
63360
63361
63362
63363
63364
63365
63366
63367
63368
63369
63370
63371
63372
63373
63374
63375
63376
63377
63378
63379
63380
63381
63382
63383
63384
63385
63386
63387
63388
63389
63390
63391
63392
63393
63394
63395
63396
63397
63398
63399
63400
63401
63402
63403
63404
63405
63406
63407
63408
63409
63410
63411
63412
63413
63414
63415
63416
63417
63418
63419
63420
63421
63422
63423
63424
63425
63426
63427
63428
63429
63430
63431
63432
63433
63434
63435
63436
63437
63438
63439
63440
63441
63442
63443
63444
63445
63446
63447
63448
63449
63450
63451
63452
63453
63454
63455
63456
63457
63458
63459
63460
63461
63462
63463
63464
63465
63466
63467
63468
63469
63470
63471
63472
63473
63474
63475
63476
63477
63478
63479
63480
63481
63482
63483
63484
63485
63486
63487
63488
63489
63490
63491
63492
63493
63494
63495
63496
63497
63498
63499
63500
63501
63502
63503
63504
63505
63506
63507
63508
63509
63510
63511
63512
63513
63514
63515
63516
63517
63518
63519
63520
63521
63522
63523
63524
63525
63526
63527
63528
63529
63530
63531
63532
63533
63534
63535
63536
63537
63538
63539
63540
63541
63542
63543
63544
63545
63546
63547
63548
63549
63550
63551
63552
63553
63554
63555
63556
63557
63558
63559
63560
63561
63562
63563
63564
63565
63566
63567
63568
63569
63570
63571
63572
63573
63574
63575
63576
63577
63578
63579
63580
63581
63582
63583
63584
63585
63586
63587
63588
63589
63590
63591
63592
63593
63594
63595
63596
63597
63598
63599
63600
63601
63602
63603
63604
63605
63606
63607
63608
63609
63610
63611
63612
63613
63614
63615
63616
63617
63618
63619
63620
63621
63622
63623
63624
63625
63626
63627
63628
63629
63630
63631
63632
63633
63634
63635
63636
63637
63638
63639
63640
63641
63642
63643
63644
63645
63646
63647
63648
63649
63650
63651
63652
63653
63654
63655
63656
63657
63658
63659
63660
63661
63662
63663
63664
63665
63666
63667
63668
63669
63670
63671
63672
63673
63674
63675
63676
63677
63678
63679
63680
63681
63682
63683
63684
63685
63686
63687
63688
63689
63690
63691
63692
63693
63694
63695
63696
63697
63698
63699
63700
63701
63702
63703
63704
63705
63706
63707
63708
63709
63710
63711
63712
63713
63714
63715
63716
63717
63718
63719
63720
63721
63722
63723
63724
63725
63726
63727
63728
63729
63730
63731
63732
63733
63734
63735
63736
63737
63738
63739
63740
63741
63742
63743
63744
63745
63746
63747
63748
63749
63750
63751
63752
63753
63754
63755
63756
63757
63758
63759
63760
63761
63762
63763
63764
63765
63766
63767
63768
63769
63770
63771
63772
63773
63774
63775
63776
63777
63778
63779
63780
63781
63782
63783
63784
63785
63786
63787
63788
63789
63790
63791
63792
63793
63794
63795
63796
63797
63798
63799
63800
63801
63802
63803
63804
63805
63806
63807
63808
63809
63810
63811
63812
63813
63814
63815
63816
63817
63818
63819
63820
63821
63822
63823
63824
63825
63826
63827
63828
63829
63830
63831
63832
63833
63834
63835
63836
63837
63838
63839
63840
63841
63842
63843
63844
63845
63846
63847
63848
63849
63850
63851
63852
63853
63854
63855
63856
63857
63858
63859
63860
63861
63862
63863
63864
63865
63866
63867
63868
63869
63870
63871
63872
63873
63874
63875
63876
63877
63878
63879
63880
63881
63882
63883
63884
63885
63886
63887
63888
63889
63890
63891
63892
63893
63894
63895
63896
63897
63898
63899
63900
63901
63902
63903
63904
63905
63906
63907
63908
63909
63910
63911
63912
63913
63914
63915
63916
63917
63918
63919
63920
63921
63922
63923
63924
63925
63926
63927
63928
63929
63930
63931
63932
63933
63934
63935
63936
63937
63938
63939
63940
63941
63942
63943
63944
63945
63946
63947
63948
63949
63950
63951
63952
63953
63954
63955
63956
63957
63958
63959
63960
63961
63962
63963
63964
63965
63966
63967
63968
63969
63970
63971
63972
63973
63974
63975
63976
63977
63978
63979
63980
63981
63982
63983
63984
63985
63986
63987
63988
63989
63990
63991
63992
63993
63994
63995
63996
63997
63998
63999
64000
64001
64002
64003
64004
64005
64006
64007
64008
64009
64010
64011
64012
64013
64014
64015
64016
64017
64018
64019
64020
64021
64022
64023
64024
64025
64026
64027
64028
64029
64030
64031
64032
64033
64034
64035
64036
64037
64038
64039
64040
64041
64042
64043
64044
64045
64046
64047
64048
64049
64050
64051
64052
64053
64054
64055
64056
64057
64058
64059
64060
64061
64062
64063
64064
64065
64066
64067
64068
64069
64070
64071
64072
64073
64074
64075
64076
64077
64078
64079
64080
64081
64082
64083
64084
64085
64086
64087
64088
64089
64090
64091
64092
64093
64094
64095
64096
64097
64098
64099
64100
64101
64102
64103
64104
64105
64106
64107
64108
64109
64110
64111
64112
64113
64114
64115
64116
64117
64118
64119
64120
64121
64122
64123
64124
64125
64126
64127
64128
64129
64130
64131
64132
64133
64134
64135
64136
64137
64138
64139
64140
64141
64142
64143
64144
64145
64146
64147
64148
64149
64150
64151
64152
64153
64154
64155
64156
64157
64158
64159
64160
64161
64162
64163
64164
64165
64166
64167
64168
64169
64170
64171
64172
64173
64174
64175
64176
64177
64178
64179
64180
64181
64182
64183
64184
64185
64186
64187
64188
64189
64190
64191
64192
64193
64194
64195
64196
64197
64198
64199
64200
64201
64202
64203
64204
64205
64206
64207
64208
64209
64210
64211
64212
64213
64214
64215
64216
64217
64218
64219
64220
64221
64222
64223
64224
64225
64226
64227
64228
64229
64230
64231
64232
64233
64234
64235
64236
64237
64238
64239
64240
64241
64242
64243
64244
64245
64246
64247
64248
64249
64250
64251
64252
64253
64254
64255
64256
64257
64258
64259
64260
64261
64262
64263
64264
64265
64266
64267
64268
64269
64270
64271
64272
64273
64274
64275
64276
64277
64278
64279
64280
64281
64282
64283
64284
64285
64286
64287
64288
64289
64290
64291
64292
64293
64294
64295
64296
64297
64298
64299
64300
64301
64302
64303
64304
64305
64306
64307
64308
64309
64310
64311
64312
64313
64314
64315
64316
64317
64318
64319
64320
64321
64322
64323
64324
64325
64326
64327
64328
64329
64330
64331
64332
64333
64334
64335
64336
64337
64338
64339
64340
64341
64342
64343
64344
64345
64346
64347
64348
64349
64350
64351
64352
64353
64354
64355
64356
64357
64358
64359
64360
64361
64362
64363
64364
64365
64366
64367
64368
64369
64370
64371
64372
64373
64374
64375
64376
64377
64378
64379
64380
64381
64382
64383
64384
64385
64386
64387
64388
64389
64390
64391
64392
64393
64394
64395
64396
64397
64398
64399
64400
64401
64402
64403
64404
64405
64406
64407
64408
64409
64410
64411
64412
64413
64414
64415
64416
64417
64418
64419
64420
64421
64422
64423
64424
64425
64426
64427
64428
64429
64430
64431
64432
64433
64434
64435
64436
64437
64438
64439
64440
64441
64442
64443
64444
64445
64446
64447
64448
64449
64450
64451
64452
64453
64454
64455
64456
64457
64458
64459
64460
64461
64462
64463
64464
64465
64466
64467
64468
64469
64470
64471
64472
64473
64474
64475
64476
64477
64478
64479
64480
64481
64482
64483
64484
64485
64486
64487
64488
64489
64490
64491
64492
64493
64494
64495
64496
64497
64498
64499
64500
64501
64502
64503
64504
64505
64506
64507
64508
64509
64510
64511
64512
64513
64514
64515
64516
64517
64518
64519
64520
64521
64522
64523
64524
64525
64526
64527
64528
64529
64530
64531
64532
64533
64534
64535
64536
64537
64538
64539
64540
64541
64542
64543
64544
64545
64546
64547
64548
64549
64550
64551
64552
64553
64554
64555
64556
64557
64558
64559
64560
64561
64562
64563
64564
64565
64566
64567
64568
64569
64570
64571
64572
64573
64574
64575
64576
64577
64578
64579
64580
64581
64582
64583
64584
64585
64586
64587
64588
64589
64590
64591
64592
64593
64594
64595
64596
64597
64598
64599
64600
64601
64602
64603
64604
64605
64606
64607
64608
64609
64610
64611
64612
64613
64614
64615
64616
64617
64618
64619
64620
64621
64622
64623
64624
64625
64626
64627
64628
64629
64630
64631
64632
64633
64634
64635
64636
64637
64638
64639
64640
64641
64642
64643
64644
64645
64646
64647
64648
64649
64650
64651
64652
64653
64654
64655
64656
64657
64658
64659
64660
64661
64662
64663
64664
64665
64666
64667
64668
64669
64670
64671
64672
64673
64674
64675
64676
64677
64678
64679
64680
64681
64682
64683
64684
64685
64686
64687
64688
64689
64690
64691
64692
64693
64694
64695
64696
64697
64698
64699
64700
64701
64702
64703
64704
64705
64706
64707
64708
64709
64710
64711
64712
64713
64714
64715
64716
64717
64718
64719
64720
64721
64722
64723
64724
64725
64726
64727
64728
64729
64730
64731
64732
64733
64734
64735
64736
64737
64738
64739
64740
64741
64742
64743
64744
64745
64746
64747
64748
64749
64750
64751
64752
64753
64754
64755
64756
64757
64758
64759
64760
64761
64762
64763
64764
64765
64766
64767
64768
64769
64770
64771
64772
64773
64774
64775
64776
64777
64778
64779
64780
64781
64782
64783
64784
64785
64786
64787
64788
64789
64790
64791
64792
64793
64794
64795
64796
64797
64798
64799
64800
64801
64802
64803
64804
64805
64806
64807
64808
64809
64810
64811
64812
64813
64814
64815
64816
64817
64818
64819
64820
64821
64822
64823
64824
64825
64826
64827
64828
64829
64830
64831
64832
64833
64834
64835
64836
64837
64838
64839
64840
64841
64842
64843
64844
64845
64846
64847
64848
64849
64850
64851
64852
64853
64854
64855
64856
64857
64858
64859
64860
64861
64862
64863
64864
64865
64866
64867
64868
64869
64870
64871
64872
64873
64874
64875
64876
64877
64878
64879
64880
64881
64882
64883
64884
64885
64886
64887
64888
64889
64890
64891
64892
64893
64894
64895
64896
64897
64898
64899
64900
64901
64902
64903
64904
64905
64906
64907
64908
64909
64910
64911
64912
64913
64914
64915
64916
64917
64918
64919
64920
64921
64922
64923
64924
64925
64926
64927
64928
64929
64930
64931
64932
64933
64934
64935
64936
64937
64938
64939
64940
64941
64942
64943
64944
64945
64946
64947
64948
64949
64950
64951
64952
64953
64954
64955
64956
64957
64958
64959
64960
64961
64962
64963
64964
64965
64966
64967
64968
64969
64970
64971
64972
64973
64974
64975
64976
64977
64978
64979
64980
64981
64982
64983
64984
64985
64986
64987
64988
64989
64990
64991
64992
64993
64994
64995
64996
64997
64998
64999
65000
65001
65002
65003
65004
65005
65006
65007
65008
65009
65010
65011
65012
65013
65014
65015
65016
65017
65018
65019
65020
65021
65022
65023
65024
65025
65026
65027
65028
65029
65030
65031
65032
65033
65034
65035
65036
65037
65038
65039
65040
65041
65042
65043
65044
65045
65046
65047
65048
65049
65050
65051
65052
65053
65054
65055
65056
65057
65058
65059
65060
65061
65062
65063
65064
65065
65066
65067
65068
65069
65070
65071
65072
65073
65074
65075
65076
65077
65078
65079
65080
65081
65082
65083
65084
65085
65086
65087
65088
65089
65090
65091
65092
65093
65094
65095
65096
65097
65098
65099
65100
65101
65102
65103
65104
65105
65106
65107
65108
65109
65110
65111
65112
65113
65114
65115
65116
65117
65118
65119
65120
65121
65122
65123
65124
65125
65126
65127
65128
65129
65130
65131
65132
65133
65134
65135
65136
65137
65138
65139
65140
65141
65142
65143
65144
65145
65146
65147
65148
65149
65150
65151
65152
65153
65154
65155
65156
65157
65158
65159
65160
65161
65162
65163
65164
65165
65166
65167
65168
65169
65170
65171
65172
65173
65174
65175
65176
65177
65178
65179
65180
65181
65182
65183
65184
65185
65186
65187
65188
65189
65190
65191
65192
65193
65194
65195
65196
65197
65198
65199
65200
65201
65202
65203
65204
65205
65206
65207
65208
65209
65210
65211
65212
65213
65214
65215
65216
65217
65218
65219
65220
65221
65222
65223
65224
65225
65226
65227
65228
65229
65230
65231
65232
65233
65234
65235
65236
65237
65238
65239
65240
65241
65242
65243
65244
65245
65246
65247
65248
65249
65250
65251
65252
65253
65254
65255
65256
65257
65258
65259
65260
65261
65262
65263
65264
65265
65266
65267
65268
65269
65270
65271
65272
65273
65274
65275
65276
65277
65278
65279
65280
65281
65282
65283
65284
65285
65286
65287
65288
65289
65290
65291
65292
65293
65294
65295
65296
65297
65298
65299
65300
65301
65302
65303
65304
65305
65306
65307
65308
65309
65310
65311
65312
65313
65314
65315
65316
65317
65318
65319
65320
65321
65322
65323
65324
65325
65326
65327
65328
65329
65330
65331
65332
65333
65334
65335
65336
65337
65338
65339
65340
65341
65342
65343
65344
65345
65346
65347
65348
65349
65350
65351
65352
65353
65354
65355
65356
65357
65358
65359
65360
65361
65362
65363
65364
65365
65366
65367
65368
65369
65370
65371
65372
65373
65374
65375
65376
65377
65378
65379
65380
65381
65382
65383
65384
65385
65386
65387
65388
65389
65390
65391
65392
65393
65394
65395
65396
65397
65398
65399
65400
65401
65402
65403
65404
65405
65406
65407
65408
65409
65410
65411
65412
65413
65414
65415
65416
65417
65418
65419
65420
65421
65422
65423
65424
65425
65426
65427
65428
65429
65430
65431
65432
65433
65434
65435
65436
65437
65438
65439
65440
65441
65442
65443
65444
65445
65446
65447
65448
65449
65450
65451
65452
65453
65454
65455
65456
65457
65458
65459
65460
65461
65462
65463
65464
65465
65466
65467
65468
65469
65470
65471
65472
65473
65474
65475
65476
65477
65478
65479
65480
65481
65482
65483
65484
65485
65486
65487
65488
65489
65490
65491
65492
65493
65494
65495
65496
65497
65498
65499
65500
65501
65502
65503
65504
65505
65506
65507
65508
65509
65510
65511
65512
65513
65514
65515
65516
65517
65518
65519
65520
65521
65522
65523
65524
65525
65526
65527
65528
65529
65530
65531
65532
65533
65534
65535
65536
65537
65538
65539
65540
65541
65542
65543
65544
65545
65546
65547
65548
65549
65550
65551
65552
65553
65554
65555
65556
65557
65558
65559
65560
65561
65562
65563
65564
65565
65566
65567
65568
65569
65570
65571
65572
65573
65574
65575
65576
65577
65578
65579
65580
65581
65582
65583
65584
65585
65586
65587
65588
65589
65590
65591
65592
65593
65594
65595
65596
65597
65598
65599
65600
65601
65602
65603
65604
65605
65606
65607
65608
65609
65610
65611
65612
65613
65614
65615
65616
65617
65618
65619
65620
65621
65622
65623
65624
65625
65626
65627
65628
65629
65630
65631
65632
65633
65634
65635
65636
65637
65638
65639
65640
65641
65642
65643
65644
65645
65646
65647
65648
65649
65650
65651
65652
65653
65654
65655
65656
65657
65658
65659
65660
65661
65662
65663
65664
65665
65666
65667
65668
65669
65670
65671
65672
65673
65674
65675
65676
65677
65678
65679
65680
65681
65682
65683
65684
65685
65686
65687
65688
65689
65690
65691
65692
65693
65694
65695
65696
65697
65698
65699
65700
65701
65702
65703
65704
65705
65706
65707
65708
65709
65710
65711
65712
65713
65714
65715
65716
65717
65718
65719
65720
65721
65722
65723
65724
65725
65726
65727
65728
65729
65730
65731
65732
65733
65734
65735
65736
65737
65738
65739
65740
65741
65742
65743
65744
65745
65746
65747
65748
65749
65750
65751
65752
65753
65754
65755
65756
65757
65758
65759
65760
65761
65762
65763
65764
65765
65766
65767
65768
65769
65770
65771
65772
65773
65774
65775
65776
65777
65778
65779
65780
65781
65782
65783
65784
65785
65786
65787
65788
65789
65790
65791
65792
65793
65794
65795
65796
65797
65798
65799
65800
65801
65802
65803
65804
65805
65806
65807
65808
65809
65810
65811
65812
65813
65814
65815
65816
65817
65818
65819
65820
65821
65822
65823
65824
65825
65826
65827
65828
65829
65830
65831
65832
65833
65834
65835
65836
65837
65838
65839
65840
65841
65842
65843
65844
65845
65846
65847
65848
65849
65850
65851
65852
65853
65854
65855
65856
65857
65858
65859
65860
65861
65862
65863
65864
65865
65866
65867
65868
65869
65870
65871
65872
65873
65874
65875
65876
65877
65878
65879
65880
65881
65882
65883
65884
65885
65886
65887
65888
65889
65890
65891
65892
65893
65894
65895
65896
65897
65898
65899
65900
65901
65902
65903
65904
65905
65906
65907
65908
65909
65910
65911
65912
65913
65914
65915
65916
65917
65918
65919
65920
65921
65922
65923
65924
65925
65926
65927
65928
65929
65930
65931
65932
65933
65934
65935
65936
65937
65938
65939
65940
65941
65942
65943
65944
65945
65946
65947
65948
65949
65950
65951
65952
65953
65954
65955
65956
65957
65958
65959
65960
65961
65962
65963
65964
65965
65966
65967
65968
65969
65970
65971
65972
65973
65974
65975
65976
65977
65978
65979
65980
65981
65982
65983
65984
65985
65986
65987
65988
65989
65990
65991
65992
65993
65994
65995
65996
65997
65998
65999
66000
66001
66002
66003
66004
66005
66006
66007
66008
66009
66010
66011
66012
66013
66014
66015
66016
66017
66018
66019
66020
66021
66022
66023
66024
66025
66026
66027
66028
66029
66030
66031
66032
66033
66034
66035
66036
66037
66038
66039
66040
66041
66042
66043
66044
66045
66046
66047
66048
66049
66050
66051
66052
66053
66054
66055
66056
66057
66058
66059
66060
66061
66062
66063
66064
66065
66066
66067
66068
66069
66070
66071
66072
66073
66074
66075
66076
66077
66078
66079
66080
66081
66082
66083
66084
66085
66086
66087
66088
66089
66090
66091
66092
66093
66094
66095
66096
66097
66098
66099
66100
66101
66102
66103
66104
66105
66106
66107
66108
66109
66110
66111
66112
66113
66114
66115
66116
66117
66118
66119
66120
66121
66122
66123
66124
66125
66126
66127
66128
66129
66130
66131
66132
66133
66134
66135
66136
66137
66138
66139
66140
66141
66142
66143
66144
66145
66146
66147
66148
66149
66150
66151
66152
66153
66154
66155
66156
66157
66158
66159
66160
66161
66162
66163
66164
66165
66166
66167
66168
66169
66170
66171
66172
66173
66174
66175
66176
66177
66178
66179
66180
66181
66182
66183
66184
66185
66186
66187
66188
66189
66190
66191
66192
66193
66194
66195
66196
66197
66198
66199
66200
66201
66202
66203
66204
66205
66206
66207
66208
66209
66210
66211
66212
66213
66214
66215
66216
66217
66218
66219
66220
66221
66222
66223
66224
66225
66226
66227
66228
66229
66230
66231
66232
66233
66234
66235
66236
66237
66238
66239
66240
66241
66242
66243
66244
66245
66246
66247
66248
66249
66250
66251
66252
66253
66254
66255
66256
66257
66258
66259
66260
66261
66262
66263
66264
66265
66266
66267
66268
66269
66270
66271
66272
66273
66274
66275
66276
66277
66278
66279
66280
66281
66282
66283
66284
66285
66286
66287
66288
66289
66290
66291
66292
66293
66294
66295
66296
66297
66298
66299
66300
66301
66302
66303
66304
66305
66306
66307
66308
66309
66310
66311
66312
66313
66314
66315
66316
66317
66318
66319
66320
66321
66322
66323
66324
66325
66326
66327
66328
66329
66330
66331
66332
66333
66334
66335
66336
66337
66338
66339
66340
66341
66342
66343
66344
66345
66346
66347
66348
66349
66350
66351
66352
66353
66354
66355
66356
66357
66358
66359
66360
66361
66362
66363
66364
66365
66366
|
2012-11-28 Zeno Albisser <zeno@webkit.org>
[Qt][Win] Enable usage of QTWEBKIT_PLUGIN_PATH.
https://bugs.webkit.org/show_bug.cgi?id=103529
This patch enables the same behavior for Windows
as it is currently implemented for all other operating
systems supported by Qt.
Directories listed in the environment variable
QTWEBKIT_PLUGIN_PATH are being searched for additional
plugins.
The only difference is that directories on Windows
need to be separated by a semicolon instead of a colon.
Reviewed by Kenneth Rohde Christiansen.
* plugins/win/PluginDatabaseWin.cpp:
(WebCore):
(WebCore::addQtWebKitPluginPath):
(WebCore::PluginDatabase::defaultPluginDirectories):
2011-06-10 Konstantin Tokarev <ktokarev@smartlabs.tv>
Reviewed by Joseph Pecoraro.
Fixed build with enabled workers and disabled inspector
https://bugs.webkit.org/show_bug.cgi?id=62461
* inspector/InspectorWorkerAgent.cpp: Added inspector guard
2011-11-01 Zeno Albisser <zeno.albisser@nokia.com>
[Qt] bad codegen, pointer diff in JSC::JSCallbackConstructor::JSCallbackConstructor
https://bugs.webkit.org/show_bug.cgi?id=60951
Adjust symbols visibility for WebCore.
Reviewed by Simon Hausmann.
* WebCore.pro:
2011-10-28 Zeno Albisser <zeno.albisser@nokia.com>
[Qt] Unreviewed: Build fix for MSVC2005
Patch by Andy Shaw <andy.shaw@digia.com>
* platform/win/SystemTimeWin.cpp:
2011-10-13 Zeno Albisser <zeno.albisser@nokia.com>
[Qt] QtWebKit build error for Mac 32bit
https://bugs.webkit.org/show_bug.cgi?id=69914
In WebCore.pro and QtWebKit.pro we define NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES
when compiling with ENABLE_VIDEO and with WTF_USE_QTKIT.
But this is meant to be defined in NSGeometry.h under certain preconditions.
Without setting NS_BUILD_32_LIKE_64 none of these preconditions is
met and therefore NSGeometry.h will create several conflicting type definitions.
With this patch we create consistent definitions again.
Due to the order of include files we cannot remove
NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES from WebCore.pro.
Reviewed by Andreas Kling.
* WebCore.pro:
2011-09-12 Adam Klein <adamk@chromium.org>
Fix out-of-bounds access in Gradient::sortStopsIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=67958
Reviewed by Darin Adler.
Reported by Valgrind in http://crbug.com/77049.
The errant code was added as an optimization in r67804.
This patch reverts that one, as all parties agree that the optimization
doesn't seem worthwhile, and there clearly aren't any tests covering
the special case.
No new tests, as existing tests should cover the remaining call to
|std::stable_sort|.
* platform/graphics/Gradient.cpp:
(WebCore::Gradient::sortStopsIfNecessary):
2011-09-09 Dominic Mazzoni <dmazzoni@google.com>
Assert being hit in AccessibilityRenderObject::addChildren()
https://bugs.webkit.org/show_bug.cgi?id=61805
Reviewed by Chris Fleizach.
Fix nextSibling and previousSibling to handle adjacent continuations
properly, otherwise nodes end up appearing in the accessibility
tree twice (or a debug assertion could be raised).
Test: accessibility/adjacent-continuations-cause-assertion-failure.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::previousSibling):
(WebCore::AccessibilityRenderObject::nextSibling):
2011-09-08 Abhishek Arya <inferno@chromium.org>
:before content rendering issues with list markers and run-ins.
https://bugs.webkit.org/show_bug.cgi?id=67735
1) Remove the isAnonymous checks for run-in detection since the
run-in can belong to a node.
2) When the parent has block children, then the list marker will
be enclosed in an anonymous block. In that case, for going to the
next list marker, we need to traverse one level up. We don't need
this check when searching for generated run-in (loop 2), since we
know parent will have inline children, so the list marker wont be
enclosed in an anonymous block.
Reviewed by Dave Hyatt.
Tests: fast/lists/list-marker-before-content-table.html
fast/runin/runin-generated-before-content.html
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::beforePseudoElementRenderer):
2011-09-10 Ken Buchanan <kenrb@chromium.org>
Crash due to bad data in SVGDocumentExtensions m_pendingResources
https://bugs.webkit.org/show_bug.cgi?id=67488
Reviewed by Nikolas Zimmermann.
Resolving a crash condition caused by the deletion of
elements while pending resource entries for those elements are still
recorded.
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::registerResource)
* svg/SVGDocumentExtensions.h:
(WebCore::SVGDocumentExtensions::isElementInPendingResources)
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::addPendingResource)
(WebCore::SVGDocumentExtensions::isElementInPendingResources)
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources)
* svg/SVGStyledElement.h:
(WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible)
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded)
(WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible)
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged)
2011-09-08 Alexey Proskuryakov <ap@apple.com>
REGRESSION (r66874): Missing RefPtr in ScriptController
https://bugs.webkit.org/show_bug.cgi?id=67748
Reviewed by Adam Barth.
* bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript):
2011-09-06 Abhishek Arya <inferno@chromium.org>
Style not propagated to anonymous boxes and anonymous
inline-blocks.
https://bugs.webkit.org/show_bug.cgi?id=67364
Reviewed by James Robinson.
Share propagateStyleToAnonymousChildren with RenderBlock::styleDidChange.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren):
* rendering/RenderObject.h:
2011-09-04 Abhishek Arya <inferno@chromium.org>
Style not propagated to anonymous boxes and anonymous
inline-blocks.
https://bugs.webkit.org/show_bug.cgi?id=67364
Reviewed by James Robinson.
Tests: fast/ruby/ruby-block-style-not-updated-with-before-after-content.html
fast/ruby/ruby-block-style-not-updated.html
fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html
fast/ruby/ruby-inline-style-not-updated.html
fast/table/table-row-style-not-updated-with-after-content.html
fast/table/table-row-style-not-updated-with-before-content.html
fast/table/table-row-style-not-updated.html
fast/table/table-style-not-updated.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren):
* rendering/RenderObject.h:
(WebCore::RenderObject::isBeforeAfterContent):
* rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsInline::styleDidChange):
(WebCore::RenderRubyAsBlock::styleDidChange):
* rendering/RenderRuby.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::styleDidChange):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::styleDidChange):
(WebCore::RenderTableSection::addChild):
* rendering/RenderTableSection.h:
2011-09-05 Abhishek Arya <inferno@chromium.org>
Crash in RenderObjectChildList::destroyLeftOverChildren()
https://bugs.webkit.org/show_bug.cgi?id=64753
Reviewed by James Robinson.
If any of the ancestors between column span element and containing
column's block is a continuation, then don't attempt to render the
column span by splitting the block into continuations.
Test: fast/multicol/column-span-parent-continuation-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::columnsBlockForSpanningElement):
2011-08-30 Abhishek Arya <inferno@chromium.org>
Removed m_owner accessed in custom scrollbars.
https://bugs.webkit.org/show_bug.cgi?id=64737
Reviewed by David Hyatt.
Problem does not reproduce in DRT, even with Eventhandler tricks
and gc(). So, adding a manual test.
* manual-tests/custom-scrollbar-renderer-removed-crash.html: Added.
* page/FrameView.cpp:
(WebCore::FrameView::clearOwningRendererForCustomScrollbars):
* page/FrameView.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed): when this renderbox is getting
destroyed, clear the custom scrollbar in this frameview having this renderbox
as its owning renderer.
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::getScrollbarPseudoStyle): fix the null check.
2011-09-04 Abhishek Arya <inferno@chromium.org>
Crash in Range::processAncestorsAndTheirSiblings.
https://bugs.webkit.org/show_bug.cgi?id=67556
Reviewed by Ryosuke Niwa.
Create a temporary RefPtr Node vector to keep all the ancestor's
childs so that we don't access removed child nodes.
Test: fast/dom/Range/range-delete-contents-event-fire-crash.html
* dom/Range.cpp:
(WebCore::Range::processContents):
(WebCore::Range::processAncestorsAndTheirSiblings):
2011-08-30 Adam Barth <abarth@webkit.org>
Flaky crash with JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=66360
Reviewed by Nate Chapin.
This patch teaches DocumentWriter::begin to make a copy of the URL
before beginning a new document to avoid a crash.
Test: fast/loader/javascript-url-iframe-crash.html
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
2011-08-30 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Emit last progress notification before calling dispatchDidFinishLoad
https://bugs.webkit.org/show_bug.cgi?id=28851
Reviewed by Adam Barth.
Original patch by Xan Lopez. Change FrameLoader to dispatch the notifications in
a more natural sequence.
Test: http/tests/loading/progress-finished-callback.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2011-08-22 Nate Chapin <japhet@chromium.org>
Unload events can crash us when they blank out
a parent frame.
https://bugs.webkit.org/show_bug.cgi?id=64741
Reviewed by Adam Barth.
Test: fast/loader/document-destruction-within-unload.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading): Prevent unload events
from going into infinite recursion.
(WebCore::FrameLoader::setDocumentLoader): Ensure we don't
let set m_documentLoader to a DocumentLoader with a null Frame*.
(WebCore::FrameLoader::detachChildren): Save off a vector of
children to detach, rather than doing it inline.
2011-08-30 Abhishek Arya <inferno@chromium.org>
Style not updated for table parts in :before, :after content.
https://bugs.webkit.org/show_bug.cgi?id=66141
Reviewed by Dave Hyatt.
Tests: fast/table/table-before-child-style-update.html
fast/table/table-row-before-child-style-update.html
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
2011-08-25 Abhishek Arya <inferno@chromium.org>
Incorrect layout of :before and :after content, with display
table, table-row and table-cell.
https://bugs.webkit.org/show_bug.cgi?id=66699
Reviewed by David Hyatt.
Tests: fast/table/table-after-child-in-table.html
fast/table/table-before-child-in-table.html
fast/table/table-cell-after-child-in-block.html
fast/table/table-cell-after-child-in-table.html
fast/table/table-cell-before-child-in-block.html
fast/table/table-cell-before-child-in-table.html
fast/table/table-row-after-child-in-block.html
fast/table/table-row-after-child-in-table.html
fast/table/table-row-before-child-in-block.html
fast/table/table-row-before-child-in-table.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
Fix the looping condition to detect :after child correctly.
isAnonymousBlock() does not apply to tables, instead
using isAnonymous().
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild): Don't add the new child
in the generatedContainer with :before, :after content.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild): Don't add the new child
in the generatedContainer with :before, :after content.
2011-08-29 Abhishek Arya <inferno@chromium.org>
Crash in InlineBox::deleteLine due to accessing removed
renderer.
https://bugs.webkit.org/show_bug.cgi?id=66015
Reviewed by Simon Fraser.
Test: fast/block/line-layout/inline-box-wrapper-crash.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox): Make sure that the
previous inline box wrapper is destroyed properly, before
setting a new one.
2011-08-30 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
[Qt] Do not unconditionally use pkg-config in .pro files
https://bugs.webkit.org/show_bug.cgi?id=67055
Reviewed by Andreas Kling.
Original patch from Rohan McGovern <rohan.mcgovern@nokia.com>
Using the first pkg-config in PATH is prone to errors when cross
compiling inside the Qt repository (using Qt's build-system).
This patch protect calls for pkg-config with
!contains(QT_CONFIG, no-pkg-config). no-pkg-config is added to
QT_CONFIG by Qt's 'configure' when cross-compiling on systems
without pkg-config.
The respective change in Qt's configure has been submited already.
No new tests as this is just a build change.
* features.pri: protect pkg-config calls
2011-08-25 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
[Qt] Enable password echo on Symbian builds
https://bugs.webkit.org/show_bug.cgi?id=66954
Reviewed by Chang Shu.
No tests, as this is just a build change.
* config.h:
2011-08-23 Chang Shu <cshu@webkit.org>
Added support for momentarily revealing last typed character in password input.
Code change was partially based on Apple's iOS code and Samuel Nevala's work.
https://bugs.webkit.org/show_bug.cgi?id=32509
Reviewed by Alexey Proskuryakov.
* editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
* rendering/RenderText.cpp:
(WebCore::SecureTextTimer::SecureTextTimer):
(WebCore::SecureTextTimer::restartWithNewText):
(WebCore::SecureTextTimer::invalidate):
(WebCore::SecureTextTimer::lastTypedCharacterOffset):
(WebCore::SecureTextTimer::fired):
(WebCore::RenderText::willBeDestroyed):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::secureText):
(WebCore::RenderText::momentarilyRevealLastTypedCharacter):
* rendering/RenderText.h:
(WebCore::RenderText::isSecure):
* testing/Internals.cpp:
(WebCore::Internals::setPasswordEchoEnabled): Fixed some silly coding in Internals.
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):
2011-07-08 Chang Shu <cshu@webkit.org>
Update calling sites after function renamed.
https://bugs.webkit.org/show_bug.cgi?id=59114
Reviewed by Alexey Proskuryakov.
No new tests, just refactoring.
* editing/visible_units.cpp:
(WebCore::previousBoundary):
(WebCore::nextBoundary):
* rendering/RenderText.cpp:
(WebCore::RenderText::setTextInternal):
2011-08-18 Chang Shu <cshu@webkit.org>
Add support of setPasswordEchoEnabled and setPasswordEchoDuration for password echo feature
https://bugs.webkit.org/show_bug.cgi?id=66052
Reviewed by Alexey Proskuryakov.
Added runtime settings in WebCore.
Added support in window.internals for testing.
Tests: editing/input/password-echo-passnode.html
editing/input/password-echo-passnode2.html
editing/input/password-echo-passnode3.html
editing/input/password-echo-textnode.html
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setPasswordEchoEnabled):
(WebCore::Settings::passwordEchoEnabled):
(WebCore::Settings::setPasswordEchoDurationInSeconds):
(WebCore::Settings::passwordEchoDurationInSeconds):
* testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::setPasswordEchoEnabled):
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):
* testing/Internals.h:
* testing/Internals.idl:
2011-08-16 Chang Shu <cshu@webkit.org>
Support reset in WebCore::Internals
https://bugs.webkit.org/show_bug.cgi?id=66307
Reviewed by Dimitri Glazkov.
New tests will be added when function reset is implemented.
Added framework code in WebCoreTestSupport. The real implementation of
Internals::reset() depends on the need from the settings that require a reset.
* testing/Internals.cpp:
(WebCore::Internals::reset):
* testing/Internals.h:
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject):
* testing/js/WebCoreTestSupport.h:
* testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject):
* testing/v8/WebCoreTestSupport.h:
2011-06-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074
A weakness of the Qt DRT setup is that things like JSContextRef are abstracted
away from the QtWebKit API so we need DumpRenderTreeSupportQt to access WebCore internals.
Since the window.internals object requires JSContextRef we need to implement it in DumpRenderTreeSupportQt
where we can access it. DumpRenderTreeSupportQt cannot be compiled outside Qt's WebCore and as it
is our only possible route into the WebCoreTestSupport class neither can the new window.internals plumbing.
Likewise we can't put the accessor in WebCoreTestSupport because it would then need to know about QWebFrame
and others. The only alternative seems like a compile time guard which we would have to teach the bots about.
* CodeGenerators.pri:
* WebCore.pri:
* WebCore.pro:
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313
Test: fast/harness/internals-object.html
* Configurations/WebCoreTestSupport.xcconfig: Added.
* DerivedSources.make: Added support for generating from Internals.idl.
* WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
* WebCore.gypi: Ditto.
* WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
* testing/Internals.cpp: Added.
* testing/Internals.h: Added.
* testing/Internals.idl: Added.
* testing/js/WebCoreTestSupport.cpp: Added.
* testing/js/WebCoreTestSupport.h: Added.
* testing/v8/WebCoreTestSupport.cpp: Added.
* testing/v8/WebCoreTestSupport.h: Added.
2011-08-22 Abhishek Arya <inferno@chromium.org>
Crash in FocusController::advanceFocusInDocumentOrder
https://bugs.webkit.org/show_bug.cgi?id=66678
RefPtr the focusable node to prevent getting deleted by mutation
event.
Reviewed by Dave Hyatt.
Test: fast/frames/focus-controller-crash-change-event.html
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusInDocumentOrder):
2011-08-18 Ryosuke Niwa <rniwa@webkit.org>
SimplifiedBackwardsTextIterator returns incorrect offset with first-letter rule
https://bugs.webkit.org/show_bug.cgi?id=66086
Reviewed by Darin Adler.
The bug was caused by SimplifiedBackwardsTextIterator's not taking care of first-letter at all.
Fixing the bug by detecting RenderTextFragment in handleTextNode.
Also added m_shouldHandleFirstLetter to SimplifiedBackwardsTextIterator to keep track of whether or not
the next call to handleTextNode needs to process the first-letter part of the text fragment.
Test: editing/text-iterator/backward-textiterator-first-letter-crash.html
* editing/TextIterator.cpp:
(WebCore::firstRenderTextInFirstLetter): Extracted from handleTextNodeFirstLetter.
(WebCore::TextIterator::handleTextNodeFirstLetter): Calls firstRenderTextInFirstLetter.
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
(WebCore::SimplifiedBackwardsTextIterator::handleFirstLetter): Added.
* editing/TextIterator.h:
2011-08-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Fix build on Lion
https://bugs.webkit.org/show_bug.cgi?id=66770
Reviewed by Andreas Kling.
We were mistakenly picking up mac/WebCoreSystemInterface.h instead of
the Qt one, and building on Lion revealed this when a typedef for
IOSurfaceRef was wrapped in PLATFORM(MAC).
For now we fix this by including WebCoreSystemInterface using
brackets, so that we'll pick up the right file based on the
include paths. This also means exposing a few missing enums
in our own version of the file, so those were added.
Lasty, we need to link against the right system interface library
on Lion.
* platform/mac/WebVideoFullscreenHUDWindowController.mm:
* platform/qt/WebCoreSystemInterface.h:
2011-08-08 Cris Neckar <cdn@chromium.org>
Remove counter nodes from the tree and fix-up children when they are removed from the counter map.
https://bugs.webkit.org/show_bug.cgi?id=65346
Reviewed by Adam Barth.
Covered by existing CSS counter tests.
* rendering/CounterNode.cpp:
(WebCore::CounterNode::~CounterNode):
2011-08-17 Oliver Hunt <oliver@apple.com>
Move towards supporting user controlled prototypes on CanvasPixelArray
https://bugs.webkit.org/show_bug.cgi?id=66429
Reviewed by Gavin Barraclough.
Start using a per-global object structure for canvas pixel array.
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
2011-08-17 Abhishek Arya <inferno@chromium.org>
Crash in Document::recalcStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=66335
Reviewed by Simon Fraser.
When node is getting destroyed and its removedFromDocument
is not called due to entire document structure torn down(using
removeAllChildren), make sure to clear out the stylesheet
candidate node from document's structures in its destructor.
Test: svg/dom/stylesheet-candidate-node-crash-main.html
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::~ProcessingInstruction):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::~HTMLLinkElement):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::~HTMLStyleElement):
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::~SVGStyleElement):
2011-08-12 Abhishek Arya <inferno@chromium.org>
Crash in WebCore::editingIgnoresContent
https://bugs.webkit.org/show_bug.cgi?id=66125
Reviewed by Ryosuke Niwa.
RefPtr a few nodes in case they get blown away in
dispatchEvent calls.
Test: editing/selection/select-start-remove-root-crash.html
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
2011-08-13 Abhishek Arya <inferno@chromium.org>
Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody
https://bugs.webkit.org/show_bug.cgi?id=66187
Reviewed by Adam Barth.
RefPtr a few ContainerNodes to prevent premature deletion.
Test: fast/html/process-end-tag-for-inbody-crash.html
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
2011-08-10 Abhishek Arya <inferno@chromium.org>
Check that we do not need layout before trying to dirty
m_originatingLine for our floats.
https://bugs.webkit.org/show_bug.cgi?id=65938
Reviewed by Dave Hyatt.
Test: fast/block/float/float-originating-line-deleted-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::clearFloats):
2011-08-11 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed build fix for Qt.
Make sure we build when Qt is namespaced.
* platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
2011-08-06 Aron Rosenberg <arosenberg@logitech.com>
Reviewed by Benjamin Poulain.
[Qt] Fix build with Intel compiler on Windows
https://bugs.webkit.org/show_bug.cgi?id=65088
Intel compiler needs .lib suffixes instead of .a
* WebCore.pri:
2011-08-03 Kent Tamura <tkent@chromium.org>
Fix incorrect checks for HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=65590
Reviewed by Dimitri Glazkov.
<video> and <audio> can be an HTMLElement instance instead of
HTMLMediaElement if MediaPlayer::isAvailable() returns false or
the media feature is disabled at runtime.
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::insertedIntoTree):
(WebCore::HTMLSourceElement::willRemove):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
* html/shadow/MediaControlElements.cpp:
(WebCore::toParentMediaElement):
* page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaMuteButton):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::getMediaElementFromRenderObject):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaSliderTrack):
* rendering/RenderThemeWinCE.cpp:
(WebCore::mediaElementParent):
2011-07-28 Abhishek Arya <inferno@chromium.org>
Regression(82144): Crash in TrailingObjects::updateMidpointsForTrailingBoxes
https://bugs.webkit.org/show_bug.cgi?id=65137
Fix the looping condition to prevent trailingSpaceMidpoint from becoming negative.
Reviewed by Dave Hyatt.
Test: fast/block/update-midpoints-for-trailing-boxes-crash.html
* rendering/RenderBlockLineLayout.cpp:
(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
2011-08-01 Jochen Eisinger <jochen@chromium.org>
Never override the policy URL on form submissions.
https://bugs.webkit.org/show_bug.cgi?id=61809
Reviewed by Adam Barth.
Tests: http/tests/security/cookies/third-party-cookie-blocking-main-frame.html
http/tests/security/cookies/third-party-cookie-blocking-user-action.html
http/tests/security/cookies/third-party-cookie-blocking.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::addExtraFieldsToSubresourceRequest):
(WebCore::FrameLoader::addExtraFieldsToMainResourceRequest):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::loadDifferentDocumentItem):
* loader/FrameLoader.h:
2011-07-27 Alexis Menard <alexis.menard@openbossa.org>
[Qt] Unreviewed build fix for mac.
QtKit is now our default media player, the define is WTF_USE_QTKIT and it's not part
of the options passed to build-webkit, therefore DerivedSources should now generate the
includes when it's mac.
* DerivedSources.pro:
* WebCore.pro:
2011-07-07 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by David Hyatt.
Partial layout when a flex-box has visibility: collapse
https://bugs.webkit.org/show_bug.cgi?id=63776
Tests: fast/flexbox/crash-button-input-autofocus.html
fast/flexbox/crash-button-keygen.html
fast/flexbox/crash-button-relayout.html
The issue is that FlexBoxIterator would skip any child if it has visibility: collapsed.
However if one of the child is anonymous, it may wrap some other child that would be skipped.
Now FlexBoxIterator is called during the layout phase and thus some nodes would not relayouted
as expected.
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::FlexBoxIterator::next): When iterating, don't skip anonymous content as there may
be real content hiding below.
2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Nikolas Zimmermann.
Update SVG position values on SVG DOM updates
https://bugs.webkit.org/show_bug.cgi?id=62439
Test: svg/custom/crash-textPath-attributes.html
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::destroy): Notify our containing RenderSVGText that it needs
to update its positioning information.
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::calculateBoundaries): Check the type of the InlineBox
like the rest of the code (fixes an ASSERT_NOT_REACHED in InlineBox::calculateBoudaries).
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): Clear
our cached layout attributes every time we invalidate them. This avoids keeping stale
attribute that have a backpointer to a RenderObject.
2011-07-13 John Knottenbelt <jknotten@chromium.org>
Reference Geolocation object from GeoNotifier and Geolocation::setIsAllowed.
https://bugs.webkit.org/show_bug.cgi?id=64363
Reviewed by Tony Gentilcore.
Test: fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html
* page/Geolocation.cpp:
(WebCore::Geolocation::setIsAllowed):
* page/Geolocation.h:
2011-06-26 Adam Barth <abarth@webkit.org>
Reviewed by Kent Tamura.
m_formElementsWithFormAttribute doesn't ref the objects it holds
https://bugs.webkit.org/show_bug.cgi?id=62956
Test: fast/forms/form-associated-element-crash3.html
* dom/Document.h:
2011-05-26 David Levin <levin@chromium.org>
Reviewed by Dmitry Titov.
WebKit's font notification has problems when the WebKit main thread != UI thread.
https://bugs.webkit.org/show_bug.cgi?id=61391
This doesn't happen in DumpRenderTree, so it needs a unit test which is taking me
some time to write correctly. In the meantime, this issues happens to be causing
some crashes in Chrome so here's the fix alone for the time being.
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::invalidateFontCache): Ensure that FontCache::invalidate is only called on WebKit's main thread.
(WebCore::fontCacheRegisteredFontsChangedNotificationCallback): Call common function for font cache invalidation.
Note that the call to fontCache() is fine since the singleton is initialized well before calling this function. Theoretically,
there could be a problem due to a lack of a memory barrier but that is highly unlikely and this is debug only code.
(WebCore::fontCacheATSNotificationCallback): Ditto.
2011-07-07 Gavin Peters <gavinp@chromium.org>
Reviewed by Alexey Proskuryakov.
fast/dom/HTMLLinkElement/link-and-subresource-test.html is flaky on chromium debug bots
https://bugs.webkit.org/show_bug.cgi?id=60097
The culprit was that CachedResource:stopLoading() was using *this
after a call to checkNotify(), which isn't kosher. This patch
uses a CachedResourceHandle to keep the CachedResource alive.
The test is a very close copy of the eponymous
link-and-subresource-test.html, only substituting invalid
resources for the valid ones in that test. The reproduction is
timing related, and happens much more consistantly with an invalid
resource for whatever reason.
Test: fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::stopLoading):
2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>
Reviewed by Pavel Feldman.
Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
https://bugs.webkit.org/show_bug.cgi?id=52791
No new tests. The problem can be reproduced by trying to create InspectorValue
from 1.0e-100 and call ->toJSONString() on this.
* inspector/InspectorValues.cpp:
(WebCore::InspectorBasicValue::writeJSON):
Added checking the predicted buffer size and choosing exponential format, or
eventually "NaN" if the buffer is too small for decimal format.
2011-07-26 Alexis Menard <alexis.menard@openbossa.org>
[Qt] Disable video support on linux if the dependencies are not found.
If we can't find the necessary dependencies to build the GStreamer media player
we disable the video support. This is related to http://trac.webkit.org/changeset/91752.
Reviewed by Holger Freyther.
No new tests, it's a build fix.
* features.pri:
2011-07-26 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Change default backend to use GStreamer on Linux and QuickTime on Mac.
https://bugs.webkit.org/show_bug.cgi?id=63472
Enable the GStreamer backend and the QuickTime backend as default media players
for the Qt port on Mac and Linux. QtMultimedia is now a fallback option that you
can enable by passing DEFINES+=USE_QT_MULTIMEDIA=1 to enforce its usage.
No new tests. The media layout tests are disabled on the Qt port but hopefully with this
switch we can enable them again.
* WebCore.pri:
* WebCore.pro:
* features.pri:
2011-06-23 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Eric Carlson.
[Qt] Implement fullscreen support on Mac with the QuickTime backend.
https://bugs.webkit.org/show_bug.cgi?id=61728
Implement fullscreen support for Qt when using the QuickTime backend.
We mostly use what is already done for the Mac port.
* DerivedSources.pro: We use the mac files and they have <WebCore/x> type
of includes. We need to generate those headers.
* WebCore.pro:
* platform/mac/WebVideoFullscreenController.h:
* platform/mac/WebVideoFullscreenController.mm:
* platform/mac/WebVideoFullscreenHUDWindowController.h:
* platform/mac/WebVideoFullscreenHUDWindowController.mm:
* platform/qt/WebCoreSystemInterface.h:
* platform/qt/WebCoreSystemInterface.mm:
2011-06-21 Alexey Proskuryakov <ap@apple.com>
Fix Mac build in some configurations.
* platform/mac/WebCoreSystemInterface.h: Added an enum matching WKSI one, since we cannot use
WKSI in WebCore.
* platform/mac/WebVideoFullscreenHUDWindowController.mm: Removed an include of WebKitSystemInterface.h.
It's not meant to be used from WebCore, and if included, a wrong copy may be used.
(createControlWithMediaUIControlType): Added a FIXME about problems with Leopard build.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Ditto. Switched enum values to
WCSI style (lower level "wk").
2011-06-20 Jer Noble <jer.noble@apple.com>
Unreviewed build fix; Fix Leopard WebCore build.
* platform/mac/WebVideoFullscreenHUDWindowController.mm: On Leopard, NSWindowDelegate
is a category, not a protocol.
2011-06-20 Jer Noble <jer.noble@apple.com>
Unreviewed build fix; Fix 32-bit build.
Code recently moved from WebKit -> WebCore does not pass WebCore's more strict compiler warnings. Use
CGFloat, and float constants wherever possible, and use narrowPrecisionToFloat() where not.
* WebCore.xcodeproj/project.pbxproj: Add '-Wno-undef' flag for WebVideoFullScreenController.mm
* platform/mac/WebVideoFullscreenController.mm:
(constrainFrameToRatioOfFrame): Use CGFloat instead of Double.
(-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]): Use float constant.
* platform/mac/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController updateVolume]): Use float for volume.
(-[WebVideoFullscreenHUDWindowController maxVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController volumeChanged:]): Ditto.
(-[WebVideoFullscreenHUDWindowController decrementVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController incrementVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController volume]): Ditto.
(-[WebVideoFullscreenHUDWindowController setVolume:]): Ditto.
(timeToString): Narrow precision to float when converting to seconds.
* platform/mac/WebWindowAnimation.mm:
(scaledRect): Use CGFloat.
(-[WebWindowScaleAnimation init]): Use float constant.
(-[WebWindowScaleAnimation currentValue]): Ditto.
(-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]): Ditto.
(-[WebWindowFadeAnimation currentAlpha]): Ditto.
2011-06-01 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Move Full Screen Controllers into WebCore.
Remove dependency on QTKit from wekitExitFullscreen()
https://bugs.webkit.org/show_bug.cgi?id=61843
No new tests; the existing media full screen tests are sufficient.
* WebCore.exp.in: Add new exports.
* WebCore.xcodeproj/project.pbxproj: Add references to moved files.
* platform/mac/WebCoreSystemInterface.h: Add new WCSI interfaces to WKSI functions.
* platform/mac/WebCoreSystemInterface.mm:
* platform/mac/WebVideoFullscreenController.h: Renamed from Source/WebKit/mac/WebView/WebVideoFullscreenController.h.
* platform/mac/WebVideoFullscreenController.mm: Renamed from Source/WebKit/mac/WebView/WebVideoFullscreenController.mm.
The following functions have had UNUSED_PARAM added:
(-[WebVideoFullscreenController applicationDidResignActive:]):
(-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
(-[WebVideoFullscreenWindow mouseMoved:]):
Source/WebKit/mac/WebView/WebVideoFullscreenHUDWindowController.h.
* platform/mac/WebVideoFullscreenHUDWindowController.mm: Renamed from Source/WebKit/mac/WebView/WebVideoFullscreenHUDWindowController.mm.
The following functions have had UNUSED_PARAM added:
(-[WebVideoFullscreenHUDWindow cancelOperation:]):
(-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
(-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
(-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
(-[WebVideoFullscreenHUDWindowController togglePlaying:]):
(-[WebVideoFullscreenHUDWindowController mouseEntered:]):
(-[WebVideoFullscreenHUDWindowController mouseExited:]):
(-[WebVideoFullscreenHUDWindowController rewind:]):
(-[WebVideoFullscreenHUDWindowController fastForward:]):
(-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
(-[WebVideoFullscreenHUDWindowController windowDidClose:]):
The following functions have had WKSI calls converted to WCSI ones:
(createControlWithMediaUIControlType):
(createTimeTextField):
* platform/mac/WebWindowAnimation.h: Renamed from Source/WebKit/mac/WebView/WebWindowAnimation.h.
* platform/mac/WebWindowAnimation.mm: Renamed from Source/WebKit/mac/WebView/WebWindowAnimation.m.
(WebWindowAnimationDurationFromDuration):
The following functions have had WKSI calls converted to WCSI ones:
(-[WebWindowScaleAnimation setCurrentProgress:]):
(-[WebWindowFadeAnimation initWithDuration:window:initialAlpha:finalAlpha:]):
2011-07-27 Ryosuke Niwa <rniwa@webkit.org>
Calling window.find immediately after mutating the document crashes WebKit.
https://bugs.webkit.org/show_bug.cgi?id=65296
Reviewed by Darin Adler.
Don't forget to layout first.
Test: editing/text-iterator/find-after-mutation.html
* editing/TextIterator.cpp:
(WebCore::findPlainText):
2011-07-27 MORITA Hajime <morrita@google.com>
Inconsistent state of TreeScope reference.
https://bugs.webkit.org/show_bug.cgi?id=65235
The tree scope pointers on shadow tree nodes didn't cleared.
even when the tree scope (shadow root) is destroyed.
This change clear these poitners before detaching the shadow root.
Reviewed by Dimitri Glazkov.
Test: fast/dom/shadow/tree-scope-crash.html
* dom/Element.cpp:
(WebCore::Element::removeShadowRoot):
2011-05-22 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245
Test: existing fast/dom/shadow/layout-tests-can-access-shadow.html
* dom/Element.cpp:
(WebCore::Element::removeShadowRoot): Call detach if attached.
2011-07-22 Sergey Glazunov <serg.glazunov@gmail.com>
Perform the JavaScript navigation check on a complete URL
https://bugs.webkit.org/show_bug.cgi?id=65038
Reviewed by Adam Barth.
Test: http/tests/security/xss-DENIED-document-baseURI-javascript.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):
2011-07-22 David Grogan <dgrogan@chromium.org>
Fix crash in IDBRequest::abort
https://bugs.webkit.org/show_bug.cgi?id=64740
Reviewed by Nate Chapin.
Tested manually with the testcase in the bug.
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::~IDBRequest):
(WebCore::IDBRequest::abort):
2011-07-25 Daniel Bates <dbates@rim.com>
REGRESSION (r85964): Improper relayout of some nested positioned elements
https://bugs.webkit.org/show_bug.cgi?id=64286
Reviewed by David Hyatt.
Fixes an issue when traversing up the containing block hierarchy after skipping
relatively positioned inlines.
When processing a positioned element we skip any intermediate inlines to get to
to enclosing block B, but don't use the containing block for B (call this P_B) to
properly continue traversing up the containing block hierarchy. So, B may be
considered again instead of looking at P_B. Hence, we don't set the correct dirty
bits for P_B and may not schedule a relayout with respect to the correct layout node.
Test: fast/block/positioning/relayout-nested-positioned-elements-crash.html
* rendering/RenderObject.h:
(WebCore::RenderObject::markContainingBlocksForLayout):
2011-07-26 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=60778
Use after free because of line box culling optimization regression.
In the case of a child with no line box being removed (typically
a <br> in quirks mode), if there is no previous sibling with a line
box, then we have a potential problem with the culling optimization.
The culled inline may still have other leaf line box children, but
they may follow the removed <br>. In this case we can't rely on
them, since we need a line box that comes before the <br>.
The fix is to simply recur up to the parent if we are a culled inline
and could not find a previous line box.
Reviewed by Dan Bernstein.
Added editing/execCommand/crash-line-break-after-outdent.html
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
2011-07-19 Abhishek Arya <inferno@chromium.org>
Crash when removing unrenderered nodes in replacement fragment.
https://bugs.webkit.org/show_bug.cgi?id=64801
Reviewed by Ryosuke Niwa.
Test: editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::removeUnrenderedNodes):
2011-07-21 Gavin Peters <gavinp@chromium.org>
Extend the protector of a CSS style sheet. Because checkLoaded() can recursively delete
parent style elements, the protector should be extended to include the parent call.
https://bugs.webkit.org/show_bug.cgi?id=64736
Reviewed by Simon Fraser.
Test: fast/css/css-imports-2.html
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::checkLoaded):
2011-07-20 Tony Chang <tony@chromium.org>
Stale pointer due to floats not removed (flexible box display)
https://bugs.webkit.org/show_bug.cgi?id=64603
Reviewed by David Hyatt.
Flexbox items should avoid floats.
Test: fast/flexbox/horizontal-box-float-crash.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::avoidsFloats):
* rendering/RenderBox.h:
(WebCore::RenderBox::isDeprecatedFlexItem):
2011-07-12 Hui Huang <Hui.2.Huang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix compiling errors with QtWebkit 2.2 WINSCW build.
https://bugs.webkit.org/show_bug.cgi?id=64391
(QtWebKit-2.2 only, patch not in webkit trunk)
* bindings/generic/ActiveDOMCallback.cpp:
* css/CSSStyleSelector.h:
* page/PrintContext.cpp:
* page/PrintContext.h:
* platform/network/HTTPHeaderMap.cpp:
* xml/XPathFunctions.cpp:
* xml/XPathPredicate.cpp:
* xml/XPathResult.cpp:
2011-07-16 Sergey Glazunov <serg.glazunov@gmail.com>
DOMWindow::open performs a security check on a wrong window
https://bugs.webkit.org/show_bug.cgi?id=64651
Reviewed by Adam Barth.
Test: http/tests/security/xss-DENIED-window-open-parent.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::open):
2011-07-14 Adam Barth <abarth@webkit.org>
The beforeload event allows tracking URI changes in a frame
https://bugs.webkit.org/show_bug.cgi?id=64482
Reviewed by Nate Chapin.
Tests: http/tests/security/beforeload-iframe-client-redirect.html
http/tests/security/beforeload-iframe-server-redirect.html
Only dispatch the beforeload event for a frame if we haven't yet
committed our first real load. The URL that we send to our parent will
be the same URL the parent seens in the src attribute.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):
2011-07-14 Tim Horton <timothy_horton@apple.com>
Clear SVGElementInstance's children immediately upon detachment
https://bugs.webkit.org/show_bug.cgi?id=63739
<rdar://problem/9705708>
Reviewed by Nikolas Zimmermann.
In addition to clearing the instance's children in the destructor,
clear them when the instance is detached from its <use>. This way,
we won't attempt to use them after we're detached but before the
destructor has been called.
Test: svg/custom/use-crash-using-children-before-destroy.svg
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::~SVGElementInstance):
(WebCore::SVGElementInstance::clearChildren):
* svg/SVGElementInstance.h:
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::detachInstance):
2011-06-20 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
make-hash-tools.pl: Perl 5.14 compatibility
https://bugs.webkit.org/show_bug.cgi?id=61890
No new tests needed.
* make-hash-tools.pl: Use if/elsif instead of switch/case.
2011-07-13 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Issue with Frame lifetime due to deletion in beforeload event.
https://bugs.webkit.org/show_bug.cgi?id=64457
Copy the Frame protector higher in the stack from loadWithDocumentLoader
to loadFrameRequest since any of loadPostRequest or loadURL can call
loadWithDocumentLoader, thereby dispatching the beforeload event and
blowing away the frame. This deleted frame will be later accessed in
the loadFrameRequest function causing a crash.
Test: fast/events/form-iframe-target-before-load-crash2.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadWithDocumentLoader):
2011-06-03 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491
Do not flatten offscreen iframes during frame flattening, as flattening might make them visible.
Test: fast/frames/flattening/iframe-flattening-out-of-view.html
fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::flattenFrame):
2011-06-23 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
https://bugs.webkit.org/show_bug.cgi?id=30355
Test: plugins/mouse-click-plugin-clears-selection.html
PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
in order to clear the FrameSelection in the currently focused node. In its platform-specific
code Chromium already does this (WebPluginContainerImpl.cpp).
* WebCore.exp.in: Add symbol for FocusController::setFocusedNode
* plugins/PluginView.cpp:
(WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes
the call to FocusController:setFocusedFrame() and Document::setFocusedNode()
redundant, since it calls both.
2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Nikolas Zimmermann.
Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
https://bugs.webkit.org/show_bug.cgi?id=63076
Tests: svg/custom/crash-text-in-textpath.svg
svg/custom/text-node-in-text-invalidated.svg
The problem was that we did not call setNeedsPositionUpdate on RenderSVGText. When
doing our layout, we would not update the attributes on our SVGRenderInlineText as
we would not lay it out.
This was caused by childrenChanged being overridden on SVGTextPositioningElement but
not on SVGTextPathElement.
As both classes shared the same mother class, it made sense to move the logic here.
There should be no other side effects as SVGTextPathElement and SVGTextPositioningElement
are the only classes deriving from SVGTextContentElement.
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::childrenChanged): Moved this method from SVGTextPositioningElement.
* svg/SVGTextContentElement.h:
* svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::svgAttributeChanged): Updated after updatePositioningValuesInRenderer
removal, replaced by RenderSVGText::locateRenderSVGTextAncestor.
* svg/SVGTextPositioningElement.h:
2011-06-30 Abhishek Arya <inferno@chromium.org>
Reviewed by Ryosuke Niwa.
Crash when calling DOMSubtreeModified event when extracting range
contents.
https://bugs.webkit.org/show_bug.cgi?id=63650
Convert a few nodes to RefPtrs and add commonRoot verification checks
for Range::processContents.
Tests: fast/dom/Range/range-extract-contents-event-fire-crash.html
fast/dom/Range/range-extract-contents-event-fire-crash2.html
* dom/Range.cpp:
(WebCore::childOfCommonRootBeforeOffset):
(WebCore::Range::processContents):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::processAncestorsAndTheirSiblings):
2011-06-23 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
In RenderBlock, RenderWidget and RenderReplaced destroy functions,
call dirtyLinesFromChangedChild to tell our parent that we are going away.
https://bugs.webkit.org/show_bug.cgi?id=60307
Test: fast/block/child-not-removed-from-parent-lineboxes-crash.html
fast/block/block-not-removed-from-parent-lineboxes-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::destroy):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::destroy):
* rendering/RenderReplaced.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::destroy):
2011-05-05 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
<rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds to load and makes mail unresponsive
Culled inlines were triggering some pathological line box tree groveling that isn't even necessary.
Removed the ancient code (that used to be in RenderFlow), since it made no sense in the RenderBlock case
(it was running for inline blocks, which was definitely not even the intent) or in the RenderInline case
(the object being removed has no effect on any lines).
Also tweaked culledInlineFirstLineBox and culledInlineLastLineBox to avoid bailing if the first replaced object that
is encountered has a null inlineBoxWrapper(). Just a slight speed optimization to avoid an extra null check.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::destroy):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::destroy):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
2011-06-28 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Eric Seidel.
Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
https://bugs.webkit.org/show_bug.cgi?id=55930
Don't set style type BEFORE/AFTER on anonymous wrapper block.
Rather, check style type on generated wrapped child.
Tests: fast/ruby/generated-after-counter-doesnt-crash.html
fast/ruby/generated-before-and-after-counter-doesnt-crash.html
fast/ruby/generated-before-counter-doesnt-crash.html
* rendering/RenderRuby.cpp:
(WebCore::isAnonymousRubyInlineBlock):
(WebCore::isRubyBeforeBlock):
(WebCore::isRubyAfterBlock):
(WebCore::rubyBeforeBlock):
(WebCore::rubyAfterBlock):
(WebCore::createAnonymousRubyInlineBlock):
(WebCore::RenderRubyAsInline::addChild):
(WebCore::RenderRubyAsBlock::addChild):
2011-05-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
https://bugs.webkit.org/show_bug.cgi?id=58216
No new tests. The SVG tests mask-excessive-malloc.svg and pattern-excessive-malloc.svg exercise this code path.
* platform/graphics/FloatRect.cpp:
(WebCore::enclosingIntRect):
2011-06-27 Joe Wild <joseph.wild@nokia.com>
Reviewed by Simon Fraser.
Crash on www.crave.cnet.com in FrameView::windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=56393
Check for a null renderer to fix a crash. This situation can
arise when external content/plugins is referenced from html
elements with style="display:none".
Test: plugins/hidden-iframe-with-swf-plugin.html
* page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
2011-06-15 Jer Noble <jer.noble@apple.com>
Reviewed by Timothy Hatcher.
Full-screen live streams have status text in wrong location
https://bugs.webkit.org/show_bug.cgi?id=62733
Fix a misspelling in the user-agent stylesheet for full-screen mode.
* css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-status-display):
2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319
This patch is based on Noam Rosenthal original patch in the same bug.
When hinted with QWebElement metatype, we qualify the conversion
from JSElement as a "perfect match".
The test was failing because the wrong slot was called, since the QWebElement
match was taken as equal to the others and not chosen when the metacall happened.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant): Identify the conversion between JSElement
to QWebElement as a "perfect match" (dist = 0). Add comments to explain the reason
why we have the implicit conversion.
2011-06-27 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Fix removal of overhanging floats on style changes to absolute/fixed position.
https://bugs.webkit.org/show_bug.cgi?id=63355
1. If we are not currently positioned.
2. And we are not floating. (If we are floating, then this will be automatically
done in RenderBox::styleWillChange as part of removeFloatingOrPositionedChildFromBlockLists)
3. And we have overhanging floats from previous sibling blocks.
4. And our new new style tells that we will have absolute or fixed position.
Then, we mark all our descendants with floats for layout. This will make sure that
overhanging floats are removed. Also, it is important to do that since if that previous
sibling block goes away, it is not able to tell us that to remove those floats thinking
that being a positioned block, we should have removed them already.
Tests: fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html
fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html
fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html
fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html
fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html
fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html
fast/block/float/overhanging-float-add-in-static-position-block.html
fast/block/float/overhanging-float-add-in-static-position-block2.html
fast/block/float/overhanging-float-remove-from-absolute-position-block.html
fast/block/float/overhanging-float-remove-from-absolute-position-block2.html
fast/block/float/overhanging-float-remove-from-fixed-position-block.html
fast/block/float/overhanging-float-remove-from-fixed-position-block2.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
2011-06-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Crash in TextIterator
https://bugs.webkit.org/show_bug.cgi?id=63334
Fix a crash in TextIterator. Keep m_sortedTextBoxes and renderer consistent
and check !m_offset when handling first letter.
Also add more assertions to help detecting similar bugs.
Test: editing/text-iterator/first-letter-rtl-crash.html
* editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::emitText):
2011-06-27 Huang Dongsung <luxtella@company100.net>
Reviewed by Kenneth Rohde Christiansen.
TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
error.
https://bugs.webkit.org/show_bug.cgi?id=62422
REGRESSION(r77286): Remove bottomRight().
REGRESSION(r77312): Change the logic to get the bottom right point.
REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.
If the viewport width equals the contents width, especially in the mobile
device, TiledBackingStore endlessly creates and deletes the rightmost
column and bottom row of tiles.
In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
tiles infinitely.
Modified TiledDrawingAreaProxy also.
* platform/graphics/TiledBackingStore.cpp:
(WebCore::innerBottomRight):
(WebCore::TiledBackingStore::invalidate):
(WebCore::TiledBackingStore::paint):
(WebCore::TiledBackingStore::createTiles):
2011-06-27 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove Phonon MediaPlayer from the tree.
https://bugs.webkit.org/show_bug.cgi?id=63448
Remove Phonon mediaplayer as it is unused, not finished and
unmaintained.
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* features.pri:
* platform/graphics/MediaPlayer.cpp:
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Removed.
* platform/graphics/qt/MediaPlayerPrivatePhonon.h: Removed.
2011-06-10 Darin Adler <darin@apple.com>
Reviewed by Eric Carlson.
REGRESSION: Fullscreen video controller can't be dragged
https://bugs.webkit.org/show_bug.cgi?id=62462
No regression test because we don't have machinery for testing the fullscreen
mode. We may find a way to add this in the future.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::MediaControlPanelElement): Initialize new
booleans related to dragging.
(WebCore::MediaControlPanelElement::startDrag): Added. Starts drag if dragging
is allowed and a drag isn't already in progress.
(WebCore::MediaControlPanelElement::continueDrag): Added. Moves the window if
dragging is already in progress.
(WebCore::MediaControlPanelElement::endDrag): Added. Ends the capture that is
done during the dragging process.
(WebCore::MediaControlPanelElement::setPosition): Added. Positions the panel
using explicit top/left.
(WebCore::MediaControlPanelElement::resetPosition): Added. Removes the positioning
done by setPosition.
(WebCore::MediaControlPanelElement::defaultEventHandler): Added. Calls startDrag,
continueDrag, and endDrag in response to mouse events.
(WebCore::MediaControlPanelElement::setCanBeDragged): Added.
* html/shadow/MediaControlElements.h: Added new function and data members
as mentioned above.
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::enteredFullscreen): Call setCanBeDragged(true)
so you can drag the panel while in fullscreen.
(WebCore::MediaControlRootElement::exitedFullscreen): Call setCanBeDragged(false)
so you can't drag the panel while not in fullscreen. Also call resetPosition so
position changes from dragging don't affect the panel in other contexts.
2011-06-24 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=63373
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::pushParentStackFrame): Changed to use parentOrHostElement.
(WebCore::CSSStyleSelector::pushParent): Ditto.
* dom/Node.cpp:
(WebCore::Node::parentOrHostElement): Added.
* dom/Node.h:
2011-06-24 Alexey Proskuryakov <ap@apple.com>
Rubber-stamped by Maciej Stachowiak.
REGRESSION (r88984): Infinite recursion in DocumentLoader::detachFromFrame/stopLoading
No new tests, as there is no known way to reproduce this (but we'll keep investigating, as
the rollout will re-introduce the older less frequent crash).
* loader/DocumentLoader.cpp: (WebCore::DocumentLoader::detachFromFrame): Rollout the fix
for bug 62764.
2011-06-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
RefPtr m_style in MediaQueryEvaluator in case of callers like
MediaQueryMatcher::prepareEvaluator that do not retain its reference.
https://bugs.webkit.org/show_bug.cgi?id=63264
Test: fast/css/media-query-evaluator-crash.html
* css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::eval):
* css/MediaQueryEvaluator.h:
2011-06-22 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
https://bugs.webkit.org/show_bug.cgi?id=61594
When the tree is split at the cursor in InsertParagraphSeparatorCommand, it is possible for the position
split at to be at the end of a text node. The code assumes the position is at the start of the node, so
pass the correct node into splitTreeToNode() in that case.
Tests: editing/inserting/return-key-before-br-in-span.html
editing/inserting/return-key-middle-of-span.html
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
2011-05-24 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Clamp coordinates to integers for canvas create/getImageData routines
https://bugs.webkit.org/show_bug.cgi?id=61135
Test: fast/canvas/canvas-getImageData-largeNonintegralDimensions.html
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::convertLogicalToDevice): clamp to ints
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createImageData):
(WebCore::CanvasRenderingContext2D::getImageData):
* platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::ImageBufferData::getData):
2011-06-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Running script from attach can remove elements from the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=62160
When the tree build runs script synchronously, that script can remove
arbitrary elements from the stack of open elements. We need to hold a
reference to |parent| in attach instead of rely upon the reference in
the stack of open elements.
Test: fast/parser/document-write-onload-clear.html
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::attach):
2011-06-09 Mike Lawther <mikelawther@chromium.org>
Reviewed by Kent Tamura.
Parsing issue with -webkit-calc
https://bugs.webkit.org/show_bug.cgi?id=62276
Set the CSSParserString for the calc functions.
Test: css3/calc/regression-62276.html
* css/CSSParser.cpp:
(WebCore::CSSParser::lex):
2011-06-20 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting www.nba.com
https://bugs.webkit.org/show_bug.cgi?id=61774
This ASSERT triggers for the same underlying issue that causes
Bug 62971: When we tokenize a </script> tag, we don't realize that
we've already consumed the "</script>" from the input stream when we
extracted the previous token. That causes the source tracker to be
out-of-sync, triggering the incorrect view-source highlighting and this
ASSERT.
For now, let's just silence the assert while we work on Bug 62971.
Test: fast/parser/attributes-on-close-script.html
* html/parser/HTMLToken.h:
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::AtomicHTMLToken::initializeAttributes):
2011-06-16 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
RefPtr frame since it can get removed in
FrameLoader::finishedParsing.
https://bugs.webkit.org/show_bug.cgi?id=62812
Tests: already tested by fast/parser/document-write-into-initial-document.html.
* dom/Document.cpp:
(WebCore::Document::finishedParsing):
2011-06-07 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
Replicate WidthIterator.cpp fix from r88139.
https://bugs.webkit.org/show_bug.cgi?id=62238
No new tests. Covered by existing layout tests on XP debug bots.
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::advance):
2011-06-01 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Coding style nit. Move ec=0 initialization, change
recommended by Alexey in bug.
https://bugs.webkit.org/show_bug.cgi?id=60831
* dom/Document.cpp:
(WebCore::Document::setBody):
2011-06-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix setting of document.body
https://bugs.webkit.org/show_bug.cgi?id=60831
1. Only allowing setting to an element if it has a body tag.
2. If element is from another document, import it.
Test: fast/dom/document-set-body.html
* dom/Document.cpp:
(WebCore::Document::setBody):
2011-06-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Antti Koivisto.
Do not use the pushed style selector if it is not equal to the
parent document's style selector. It usually means that it is
in a bad state, e.g. already cleared.
https://bugs.webkit.org/show_bug.cgi?id=61737
* dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
2011-06-17 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
When we lose ability to propagate floats, need to find topmost
parent with that overhanging float, and then iterate over its
sibling blocks to remove the float.
https://bugs.webkit.org/show_bug.cgi?id=62875
Test: fast/block/float/float-not-removed-from-next-sibling5.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::hasOverhangingFloat):
* rendering/RenderBlock.h:
2011-05-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Add containsFloats call to hasOverhangingFloats.
https://bugs.webkit.org/show_bug.cgi?id=60537
Test: fast/block/float/no-overhanging-float-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::repaintOverhangingFloats):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::hasOverhangingFloats):
2011-05-05 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
When style changes for a RenderBlock and we lose our ability to intrude into
floats in the next siblings block (e.g a position change), make sure to mark
our childs with floats for layout and iterate through our next sibling block
chain to see which ones contain the float that also exists in our floating
objects list and clear those using markAllDescendantsWithFloatsForLayout.
https://bugs.webkit.org/show_bug.cgi?id=56299
Tests: fast/block/float/float-not-removed-from-next-sibling-crash.html
fast/block/float/float-not-removed-from-next-sibling.html
fast/block/float/float-not-removed-from-next-sibling2.html
fast/block/float/float-not-removed-from-next-sibling3.html
fast/block/float/float-not-removed-from-next-sibling4.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
* rendering/RenderBlock.h:
2011-06-16 Gabor Loki <loki@webkit.org>
[Qt] Unreviewed, build fix after r89118.
* dom/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::initializeParserContext):
2011-06-16 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Alexey Proskuryakov.
Using null bytes when setting innerHTML in XTHML results in assertion and a crash due to null-pointer dereference
https://bugs.webkit.org/show_bug.cgi?id=61053
XML parsing in-memory XML chunks now passes around a string object instead of a C string, ensuring null characters are properly handled.
Tests: fast/parser/xhtml-innerhtml-null-byte-first.xhtml
fast/parser/xhtml-innerhtml-null-byte.xhtml
* dom/XMLDocumentParser.h:
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLParserContext::createMemoryParser):
(WebCore::XMLDocumentParser::initializeParserContext):
(WebCore::XMLDocumentParser::appendFragmentSource):
2011-06-15 Abhishek Arya <inferno@chromium.org>
Reviewed by Antti Koivisto.
Revert speculative fix in r84151. It caused some issues with
stylesheet lifetimes.
https://bugs.webkit.org/show_bug.cgi?id=62586
Tests: fast/dom/body-clone-link-decl-parent-crash.html
fast/dom/styled-clone-inline-style-decl-parent-crash.html
fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash.html
* dom/Document.cpp:
(WebCore::Document::removedLastRef):
2011-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Alexey Proskuryakov.
Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache
https://bugs.webkit.org/show_bug.cgi?id=62764
This is an non-reproducible high volume crash, so no test :(.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::detachFromFrame):
Be conservative and stop loading when we detach a document loader from a frame.
2011-06-14 Jeffrey Pfau <jpfau@apple.com>
Reviewed by David Hyatt.
Null dereference in WebCore::RenderBlock::splitFlow regarding use of multicol, inline-block, and spanning elements
https://bugs.webkit.org/show_bug.cgi?id=60028
Ensure that the parent block of a spanning element, if it is not itself
a multicol element, is not inline.
Test: fast/multicol/span/span-as-nested-inline-block-child.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::columnsBlockForSpanningElement):
2011-06-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [Symbian] GraphicsLayer: support plugins on symbian
https://bugs.webkit.org/show_bug.cgi?id=57418
Implement graphics layer for plugins on Symbian.
* plugins/PluginView.h:
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::shouldUseAcceleratedCompositing):
(WebCore::PluginView::platformStart):
* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginGraphicsLayerQt::PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::~PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::paint):
(WebCore::PluginView::shouldUseAcceleratedCompositing):
(WebCore::PluginView::paint):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformLayer):
2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88796.
http://trac.webkit.org/changeset/88796
https://bugs.webkit.org/show_bug.cgi?id=62790
It made fast/dom/nodesFromRect-basic.html time out on Qt,
64-bit, debug mode (Requested by Ossy on #webkit).
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
2011-06-13 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Darin Adler.
Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900
Add more null checks so that removing children in MathML elements does not cause crashes.
Note that this only half fixes the third repro in the Bugzilla bug, as another bug will
still crash that repro.
Test: mathml/munderover-remove-children.html
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::stretchToHeight):
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layout):
(WebCore::RenderMathMLUnderOver::nonOperatorHeight):
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
REGRESSION (r81518): Crash in makeRange() when invoking the dictionary panel over a file input
https://bugs.webkit.org/show_bug.cgi?id=62544
Fixed the crash by adding null pointer checks.
No new tests since there's no way to open dictionary panel.
* dom/Position.cpp:
(WebCore::Position::parentAnchoredEquivalent):
* editing/VisiblePosition.cpp:
(WebCore::makeRange):
* page/Frame.cpp:
(WebCore::Frame::rangeForPoint):
2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319
Increase the likeness that JSElements are converted to QWebElements. When hinted
with QWebElement metatype, we qualify the conversion from JSElement as a "perfect
match".
The test was failing because the wrong slot was called, since the QWebElement
match was taken as equal to the others and not chosen when the metacall happened.
We also remove the implicit conversion between JSDocument (which is not an
element) to QWebElement. The conversion only worked for calling slots, while
without hint it returned a QVariantMap (as can be seen in domCycles test). It was
added for supporting DRT, but since this change we can use it as QVariantMap and
get the value for "documentElement".
This patch is based on Noam Rosenthal original patch in the same bug.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::hintForRealType):
Extracted function to choose the metatype hint based on the JSValue type. Add
QWebElement metatype as a hint for JSElement objects, this way if no hint is
provided, JSElement objects will always be converted to QWebElements.
(JSC::Bindings::convertValueToQVariant):
Use previous function. Identify the conversion between JSElement to QWebElement
as a "perfect match" (dist = 0). And remove the implicit conversion when the hint
is QWebElement metatype and we have a JSDocument. Changed from JSHTMLElement to
JSElement to cover the 'documentElement'.
2011-06-12 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/9513180> REGRESSION (r84166): recalcStyle for display:inline to display:none transition has complexity N^2 where N is the number of child Text nodes
https://bugs.webkit.org/show_bug.cgi?id=61557
Replaced the fix for bug 58500 with a refined version.
* rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint): Use the containing block unless it is
across a layer boundary.
2011-06-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Null parent element sheet pointers in CSSMutableStyleDeclaration consumers
when removed from document, set them when reinserted into document.
https://bugs.webkit.org/show_bug.cgi?id=62230
When a HTMLBodyElement, StyledElement are removed from document,
we didn't clear out the parent pointers from their link, style declarations.
These parent pointers pointed to the document's element sheet which will
get removed when document is getting destroyed. It does make sense to
clear out parent pointers when we are getting removed from document and
readd them when we get inserted again.
Tests: fast/dom/body-link-decl-parent-crash.html
fast/dom/styled-inline-style-decl-parent-crash.html
* dom/StyledElement.cpp:
(WebCore::StyledElement::insertedIntoDocument):
(WebCore::StyledElement::removedFromDocument):
* dom/StyledElement.h:
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseMappedAttribute):
(WebCore::HTMLBodyElement::insertedIntoDocument):
(WebCore::HTMLBodyElement::removedFromDocument):
(WebCore::HTMLBodyElement::didMoveToNewOwnerDocument):
* html/HTMLBodyElement.h:
2011-06-10 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
Don't execute scripts in shadow SVG.
https://bugs.webkit.org/show_bug.cgi?id=62225
Test: svg/dom/use-style-recalc-script-execute-crash.html
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::prepareScript):
2011-06-09 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419
Test: fast/files/blob-builder-crash.html
* fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):
2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Antti Koivisto.
REGRESSION(84329): Stylesheets on some pages do not load
https://bugs.webkit.org/show_bug.cgi?id=61400
Test: fast/css/link-disabled-attr.html
Fixed r84329: the change did not take into account the fact
that HTMLLinkElement did already contain the disabled information
and the 2 information were not linked as they should have!
The new logic pushes the information to the stylesheet as this
is what the spec mandates and what FF is doing. Also it keeps
one bit of information (that JS enabled the stylesheet) as it
is needed for the recalcStyleSelector logic.
* dom/Document.cpp:
(WebCore::Document::recalcStyleSelector): s/isDisabled/disabled.
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement): Removed m_disabledState,
replaced by m_isEnabledViaScript.
(WebCore::HTMLLinkElement::setDisabled): Updated the logic after
m_disabledState removal. It also matches the spec by forwarding
the disabled state to our stylesheet if we have one.
(WebCore::HTMLLinkElement::parseMappedAttribute): Removed harmful
handling of the disabledAttr.
(WebCore::HTMLLinkElement::process): Updated after m_disabledState removal.
* html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::isEnabledViaScript): Ditto.
(WebCore::HTMLLinkElement::isAlternate): Ditto.
2011-06-09 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Crashes in RenderLayerBacking::paintingGoesToWindow
https://bugs.webkit.org/show_bug.cgi?id=61159
Speculative fix for unreproducible crash that can occur when RenderObject::repaintUsingContainer()
finds a repaintContainer that is not the RenderView, but that is also not
composited (for unknown reasons), by checking to see if the layer is
compositing before using backing(). An assertion remains to try to catch
this in debug builds.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setBackingNeedsRepaintInRect):
2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384
Test: fast/css/webkit-keyframes-crash.html
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed
to return a non-null pointer. Thus null-check here like the rest of the code.
2011-06-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
constructTreeFromToken can re-enter parser, causing ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=62160
This patch clears the HTMLToken before constructing the tree from the
token, putting the HTMLDocumentParser in a good state to be re-entered.
Tests: fast/parser/document-write-onload-nesting.html
fast/parser/document-write-onload-ordering.html
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLToken.h:
(WebCore::HTMLToken::isUninitialized):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::constructTreeFromToken):
2011-06-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Build fix for building QtWebKit inside of Qt.
https://bugs.webkit.org/show_bug.cgi?id=62280
Remove CONFIG=staticlib, because it causes the configure script to add -lwebcore
into QtWebKit.prl.
No new tests, as this is just a build fix.
* WebCore.pri:
2011-06-08 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Laszlo Gombos.
[Symbian] Float{32,64}Array and Int16Array fail to build.
https://bugs.webkit.org/show_bug.cgi?id=62219
For some reason, RVCT 2.x is moaning about "class member designated by
a using-declaration must be visible in a direct base class".
Apply same fix as r69122 and r76592.
* html/canvas/Float32Array.h:
(WebCore::Float32Array::set):
* html/canvas/Float64Array.h:
(WebCore::Float64Array::set):
* html/canvas/Int16Array.h:
(WebCore::Int16Array::set):
2011-06-07 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix the error code for media resource failures when using QtMobility
https://bugs.webkit.org/show_bug.cgi?id=55901
To indicate the media resource failures, set the network state to
MediaPlayer::FormatError when receives QMediaPlayer::InvalidMedia or
QMediaPlayer::ResourceError.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::updateStates):
2011-06-05 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
fast/viewport/viewport-45.html fails in GTK+/Qt
https://bugs.webkit.org/show_bug.cgi?id=47481
computeViewportAttributes does many math operations with float point arithmetic
and in some cases there is loss of precision making tests have incorrect values.
* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
2011-06-04 Abhishek Arya <inferno@chromium.org>
Reviewed by Kent Tamura.
Add some asserts for array boundary checks in TextRun. Fix
an integer issue in linux text controller code.
https://bugs.webkit.org/show_bug.cgi?id=62085
Testing ComplexTextControllerLinux change requires a testcase
> 32 kb which is not feasible. All other changes are tested by
existing layouttests.
* platform/graphics/TextRun.h:
(WebCore::TextRun::operator[]): add assert.
(WebCore::TextRun::data): add assert.
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance): bail early and prevent access
to one byte across the text run boundary.
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::getNormalizedTextRun): wrong
int16 vs int comparison.
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunWalker::walk): bail early when from and to
is outside the text run boundary. this hit easily after adding
the assert when from = to = end and read in run.data(from).
2011-06-04 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Beth Dakin.
Crash in WebCore::RenderMathMLSubSup::baselinePosition()
https://bugs.webkit.org/show_bug.cgi?id=57897
Simple patch adding NULL checks in each function.
Test: mathml/msubsup-remove-children.xhtml
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::stretchToHeight):
(WebCore::RenderMathMLSubSup::baselinePosition):
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
* platform/network/qt/QtMIMETypeSniffer.h:
2011-06-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Fix the Phonon build when logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=61869
No new tests needed.
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Add missing guards.
(WebCore::MediaPlayerPrivatePhonon::networkState):
(WebCore::MediaPlayerPrivatePhonon::readyState):
(WebCore::MediaPlayerPrivatePhonon::updateStates):
(WebCore::MediaPlayerPrivatePhonon::stateChanged):
2011-05-31 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Improve hasMediaControls logic to check that node has
media controls. This can be false when cloning nodes.
https://bugs.webkit.org/show_bug.cgi?id=61765
Test: media/media-controls-clone-crash.html
* dom/Node.h:
(WebCore::Node::isMediaControls):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::hasMediaControls):
* html/shadow/MediaControls.h:
(WebCore::MediaControls::isMediaControls):
(WebCore::toMediaControls):
2011-05-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Alexey Proskuryakov.
Audio and video files saved to the Application Cache should preserve the original file extension
https://bugs.webkit.org/show_bug.cgi?id=61750
<rdar://9524922>
No new tests, it isn't possible to check the name of the file in the cache from within
DRT. Changes verified manually.
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::store): Append the original file extension to the cache
file name.
(WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory): Add extension parameter.
* loader/appcache/ApplicationCacheStorage.h:
2011-05-30 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler and Simon Fraser.
REGRESSION (r87622): Scrubbing a Vimeo movie when in fullscreen stops playback; no way to make it start again
https://bugs.webkit.org/show_bug.cgi?id=61717
rdar://problem/9522272
May be some good way to test this later. No immediate idea about the best way.
When a media element is taken into full-screen mode, stop events from propagating
outside the media element's shadow DOM, EventDispatcher::determineDispatchBehavior()
has been changed to take a shadow root node. In our full screen media element check,
we check to see if the passed shadow root is the shadow root of the full screen media
element, and if so, specify events should StayInsideShadowDOM. The end result is that
inside EventDispatcher::ensureEventAncestors, an ancestor chain is built up all the
way from the SliderThumb to the video element's shadow root, but no further.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::determineDispatchBehavior): Restrict events to the
shadow DOM when showing a full screen video.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Removed code to manage full screen controls.
The events telling us about activity in the shadow DOM no longer bubble out so we need to
handle this inside the shadow DOM on the root element.
(WebCore::HTMLMediaElement::play): Ditto.
(WebCore::HTMLMediaElement::playbackProgressTimerFired): Ditto.
(WebCore::HTMLMediaElement::defaultEventHandler): Ditto.
(WebCore::HTMLMediaElement::enterFullscreen): Ditto.
(WebCore::HTMLMediaElement::exitFullscreen): Ditto.
* html/HTMLMediaElement.h: Added isPlaying function, removed things moved to the root element.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler): Rolled out
changes that tried to make special rules for events using preDispatchEventHandler and such.
This rolls out both r87622 and r87655.
(WebCore::MediaControlMuteButtonElement::defaultEventHandler): Ditto.
(WebCore::MediaControlPanelMuteButtonElement::defaultEventHandler): Ditto.
(WebCore::MediaControlPlayButtonElement::defaultEventHandler): Ditto.
(WebCore::MediaControlSeekButtonElement::defaultEventHandler): Ditto.
(WebCore::MediaControlRewindButtonElement::defaultEventHandler): Ditto.
(WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): Ditto.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler): Ditto.
(WebCore::MediaControlTimelineElement::defaultEventHandler): Ditto.
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Ditto.
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Ditto.
* html/shadow/MediaControlElements.h: Ditto.
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::MediaControlRootElement): Initialize new data members.
(WebCore::MediaControlRootElement::playbackStarted): Start the timer so we will consider
hiding the controls later.
(WebCore::MediaControlRootElement::playbackProgressed): Hide the controls if the mouse
is no longer over the controls.
(WebCore::MediaControlRootElement::playbackStopped): Stop the timer since we only hide
automatically if we're playing.
(WebCore::MediaControlRootElement::enteredFullscreen): Start the timer.
(WebCore::MediaControlRootElement::exitedFullscreen): Stop the timer since we only care
if we are full screen.
(WebCore::MediaControlRootElement::containsRelatedTarget): Added. Helper for next function.
(WebCore::MediaControlRootElement::defaultEventHandler): Do the hide/show and timer functions
as the mouse is moved in and out.
(WebCore::MediaControlRootElement::startHideFullscreenControlsTimer): Start the timer if
needed.
(WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide if the conditions
are met.
(WebCore::MediaControlRootElement::stopHideFullscreenControlsTimer): Stop the timer.
* html/shadow/MediaControlRootElement.h: Added new functions and data members.
2011-05-29 Brian Weinstein <bweinstein@apple.com>
Reviewed by Darin Adler.
Controls never hide in full screen after user stops moving mouse
https://bugs.webkit.org/show_bug.cgi?id=61715
<rdar://problem/9522182>
When we get a mouse move event in HTMLMediaElement::defaultEventHandler, and we are in full screen,
show the media controls, and then start a timer.
The timer fires 3 seconds after the user's last mouse movement (timer is restarted on every mouse
move), and hides the controls.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize our new timer.
(WebCore::HTMLMediaElement::play): If we are in full screen mode, start our timer to hide the full screen
controls. We don't want the user to have to move the mouse to hide them when they use the spacebar
to play.
(WebCore::HTMLMediaElement::startHideFullscreenControlsTimer): Starts a oneshot timer 3 seconds in the future
if we are in full screen.
(WebCore::HTMLMediaElement::hideFullscreenControlsTimerFired): Make sure that we are currently playing, and
we are in full screen, and hide the controls. We don't want to hide the controls if we are paused.
(WebCore::HTMLMediaElement::stopHideFullscreenControlsTimer): Stops the timer.
(WebCore::HTMLMediaElement::defaultEventHandler): If we get a mouse move event and are in full screen, show the
controls and start a timer to hide them.
(WebCore::HTMLMediaElement::enterFullscreen): Start a timer to hide the full screen controls. The user shouldn't
have the move the mouse once they enter full screen to hide the controls.
(WebCore::HTMLMediaElement::exitFullscreen): Stop the timer to hide the full screen controls.
* html/HTMLMediaElement.h:
* html/shadow/MediaControls.h: Added pure virtual shouldHideControls() method.
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::playbackStopped): Stop the timer to hide the full screen controls.
(WebCore::MediaControlRootElement::shouldHideControls): Added, only report that
the caller should hide the controls if the panel is not hovered.
* html/shadow/MediaControlRootElement.h:
2011-05-29 Darin Adler <darin@apple.com>
Reviewed by Kevin Decker.
REGRESSION (r87622): In media documents, clicking the full screen button and the play button pauses the video
https://bugs.webkit.org/show_bug.cgi?id=61713
We need to come up with a way to regression-test these changes. Nothing at the moment.
The bug is that we removed calls to preventDefault, but we still do need to prevent
default handling of this event.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlElement::preDispatchEventHandler): Add back the preventDefault
that was in here before r87622 as well as the stopPropagation that was added in r87622.
(WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.
2011-05-28 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Mouse clicks propagate outside full-screen media controls.
https://bugs.webkit.org/show_bug.cgi?id=61689
Mouse click events are propagating out of the media controls, so mouse click
listeners registered on the video element are getting fired when the user
clicks on media controller buttons. By default, block propagation of click
events from MediaControlElements by overriding preDispatchEventHandler, and
convert all instances of defaultEventHandler -> preDispatchEventHandler. Change
all calls of event->setDefaultHandled() to event->stopPropagation().
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlElement::preDispatchEventHandler): Added. Block
propagation of all mouse click events.
(WebCore::MediaControlVolumeSliderContainerElement::preDispatchEventHandler):
Renamed from setDefaultHandled.
(WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlPanelMuteButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlTimelineElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlVolumeSliderElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.
* html/shadow/MediaControlElements.h:
2011-05-26 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed build fix for Qt and QuickTime backend.
r87328 added a new system interface, we need to add it too.
* platform/qt/WebCoreSystemInterface.h:
* platform/qt/WebCoreSystemInterface.mm:
2011-05-24 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403
No new tests; Covered by media/video-canvas-source.html.
Vimeo redirects their assets from player.vimeo.com to av.vimeo.com, which is rejected
by AVFoundation and QTKit due to our setting a ForbidCrossSiteReference option when
creating an AVAsset or QTMovie. Instead, we should just reject local->remote and
remote->local and make our answer to hasSingleSecurityOrigin dynamic.
When checking whether a given request has a single security origin, use a
SecurityOrigin to check the host, port, and scheme.
* WebCore.exp.in:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::assetURL): Added.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Exchange ForbidCrossSiteReference
for ForbidRemoteReferenceToLocal and ForbidLocalReferenceToRemote
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin): Check to see that the
requested and resolved URLs have the same host and port.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Exchange NoCrossSiteAttribute for
NoRemoteToLocalSiteAttribute and NoLocalToRemoteSiteAttribute.
(WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin): Check to see that the
requested and resolved URLs have the same host and port.
* platform/mac/WebCoreSystemInterface.h: Added wkAVAssetResolvedURL.
* platform/mac/WebCoreSystemInterface.mm: Ditto.
2011-05-15 Eric Carlson <eric.carlson@apple.com>
Reviewed by Maciej Stachowiak.
Use new AVAssetReferenceRestrictions to prevent cross site media references
https://bugs.webkit.org/show_bug.cgi?id=60791
<rdar://problem/9374202>
Test: http/tests/media/video-cross-site.html
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Set restriction
to prevent cross-domain references from being followed.
2011-05-10 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Files that load quickly sometimes won't play.
https://bugs.webkit.org/show_bug.cgi?id=60556
<rdar://problem/9330567>
No new tests, this failure is very difficult to reproduce on some machines. The fix was
verified manually.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::playabilityKnown): Move the call to updateStates
to dispatchNotification so it is more obvious which state changes call it.
(WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Correct logging typo.
(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Move updateStates call to
dispatchNotification.
(WebCore::MediaPlayerPrivateAVFoundation::rateChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Call updateStates after
processing "size changed" notification so we detect all state changes. Consolidate
calls to updateStates here.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Name the video layer in
a debug build.
2011-05-05 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Block callbacks delivered during destruction
https://bugs.webkit.org/show_bug.cgi?id=60291
<rdar://problem/9382942>
No new tests, tested by existing tests.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::~MediaPlayerPrivateAVFoundation): Call
setIgnoreLoadStateChanges(true) to cancel all callbacks.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Return immediately if
m_ignoreLoadStateChanges is true.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): loadStateChanged -> updateStates.
Don't call updateStates after calling loadedTimeRangesChanged, it already does it.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2011-05-25 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Fix media element regression where ended event stopped firing after changing the src attribute.
https://bugs.webkit.org/show_bug.cgi?id=61336
Test: media/media-ended.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad):
2011-05-25 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
REGRESSION: Fullscreen button on embedded Vimeo videos does nothing
https://bugs.webkit.org/show_bug.cgi?id=61461
Tests: fullscreen/full-screen-iframe-legacy.html
Allow calls from the legacy full-screen API to bypass the iframe
"webkitallowfullscreen" requirement by adding a parameter to
Document::webkitRequestFullScreenForElement specifying the strictness
of that check. Specify this new parameter everywhere that function is
called, including in the default controls' full-screen button handler.
* dom/Document.cpp:
(WebCore::Document::webkitRequestFullScreenForElement):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::requestFullScreen): Renamed from webkitRequestFullScreen.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Eric Carlson.
[Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
https://bugs.webkit.org/show_bug.cgi?id=61279
Enable the QuickTime backend for the Qt port on Mac. The patch adds the bits in WebCore
to enable the QTKit backend of the Mac port. It can be enabled by passing DEFINES+=USE_QTKIT=1
when calling build-webkit.
* WebCore.pri:
* WebCore.pro:
* features.pri:
* platform/KURL.h:
* platform/SharedBuffer.h:
* platform/cf/KURLCFNet.cpp:
* platform/cf/SharedBufferCF.cpp:
* platform/graphics/FloatSize.h:
* platform/graphics/IntRect.h:
* platform/graphics/IntSize.h:
* platform/graphics/MediaPlayer.cpp:
* platform/graphics/cg/FloatSizeCG.cpp:
* platform/graphics/cg/IntRectCG.cpp:
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
(WebCore::MediaPlayerPrivateQTKit::paint):
(-[WebCoreMovieObserver layerHostChanged:]):
* platform/mac/KURLMac.mm:
* platform/mac/SharedBufferMac.mm:
(+[WebCoreSharedBufferData initialize]):
* platform/mac/WebCoreObjCExtras.mm:
* platform/qt/WebCoreSystemInterface.h: Added.
* platform/qt/WebCoreSystemInterface.mm: Added.
2011-05-16 Jeremy Noble <jer.noble@apple.com>
Unreviewed; build fix for non-SnowLeopard builds.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Wrap definition
of layerIsDescendentOf in a #if check.
2011-05-13 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
Video is blank, controller is misplaced on trailers.apple.com movie in fullscreen (with two screens)
https://bugs.webkit.org/show_bug.cgi?id=60826
Listen for a WebKitLayerHostChanged notification and, if the affected layer is an
ancestor layer of the qtMovieLayer, tear down the layer and recreate it the
next time setVisible(true) is called.
* dom/Document.cpp:
(WebCore::Document::webkitDidEnterFullScreenForElement): Call setFullScreenRootLayer(0)
before disabling animation on the full screen renderer.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovie): Register an observer for the new
WebKitLayerHostChanged notification.
(WebCore::layerIsDescendentOf): Added.
(WebCore::MediaPlayerPrivateQTKit::layerHostChanged): Added. If the changed
layer is an ancestor of the movie layer, tear down rendering and re-
create the next time setVisible(true) is called.
(-[WebCoreMovieObserver layerHostChanged:]): Added ObjC listener wrapper.
2011-05-18 Jeremy Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Poster is not shown in Safari for video element with no playable source elements.
https://bugs.webkit.org/show_bug.cgi?id=61109
Test: media/video-src-invalid-poster.html
In the case where no video sources are playable, update the display state and
renderer, allowing the poster image to display.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::waitForSourceChange):
2011-05-14 Jeremy Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Exiting full screen causes <video> element inline controls to become visible
https://bugs.webkit.org/show_bug.cgi?id=60142
Create a queue of elements who must be targeted with webkitfullscreenchange events. Instead of dispatching
a single event with whatever the current value of m_fullScreenElement is (which may have been cleared, or
changed since the timer was asked to fire), dispatch one event for each entry in the queue.
Test: fullscreen/video-controls-override.html
* dom/Document.cpp:
(WebCore::Document::webkitDidEnterFullScreenForElement): Push current full screen element onto the
webkitfullscreenchange event delay queue.
(WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
(WebCore::Document::fullScreenElementRemoved): Ditto.
(WebCore::Document::fullScreenChangeDelayTimerFired): Empty the queue, dispatching a
webkitfullscreenchange event for each entry.
* dom/Document.h:
2011-05-05 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Removing the full screen element via parent.innerHTML="" does not result in a webkitfullscreenchange event.
https://bugs.webkit.org/show_bug.cgi?id=60278
Handle the removal of a full screen element from within Node::willRemove() instead
of Document::nodeWillBeRemoved(). The new function Document::fullScreenElementWillBeRemoved() will
be called by Node::willRemove() to handle those changes which used to occur in nodeWillBeRemoved().
Test: fullscreen/full-screen-remove-children.html
* dom/Document.cpp:
(WebCore::Document::nodeWillBeRemoved): Removed the code checking for the full screen element.
(WebCore::Document::fullScreenElementWillBeRemoved): Added, moved from nodeWillBeRemoved.
* dom/Document.h:
* dom/Node.cpp:
(WebCore::Node::willRemove): Check to see if this is the current full screen element.
2011-05-04 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[Gtk+] deadlock in gstreamer video player when exiting fullscreen
https://bugs.webkit.org/show_bug.cgi?id=58548
Block data flow towards the pipeline branch to remove to avoid
potential deadlocks during the PAUSED->READY transitions of the
elements to remove.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::exitFullscreen):
2011-05-11 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Video track sometimes fails to draw.
https://bugs.webkit.org/show_bug.cgi?id=60635
<rdar://problem/9281951>
No new tests, covered by existing pixel tests.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource): Set display mode to "Unknown" to force a
recalculation, and media engine notification, the next time the state machine runs.
2011-05-05 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
The preload attribute of the video tag is not completely implemented
https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/9369746>
This change implements "preload=metadata" for the AVFoundation backend.
Tested manually with manual-tests/media-elements/video-preload.html.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay.
(WebCore::HTMLMediaElement::prepareForLoad): Ditto.
(WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play.
(WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'auto'
because we need to have media data loaded to seek.
(WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
* html/HTMLMediaElement.h:
* manual-tests/media-elements/video-preload.html: Make changing urls work.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Remove
m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
(WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
(WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn.
Move all preload logic to setPreload, call it from here.
(WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to
setPreload, call it.
(WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
unlikely to be correct and isn't worth caching. Use invalidTime() function.
(WebCore::MediaPlayerPrivateAVFoundation::seeking): Use invalidTime() function.
(WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Add logging.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
to AssetStatus. Always create a AVPlayerItem for live streams because they can't be inspected
without one. Set networkState to 'idle' when the playback buffer is full because that is
a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA'
when the first frame is available.
(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
width, height, hasVideo, etc.
(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Use invalidTime() function.
(WebCore::MediaPlayerPrivateAVFoundation::timeChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
in derived classes.
(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
AVAsset and AVPlayerItem here.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
if we have painted a frame to the context.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
if necessary.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
the buffer is full.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
when we only have metadata.
(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
when when we haven't allocated the AVPlayerItem yet so that we can report attributes
when we only have metadata.
(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
we have allocated the AVPlayerItem.
2011-06-03 Doreen Jiang <doreen.jiang@nokia.com>
Reviewed by Benjamin Poulain.
[Qt]The minimum size of the select menu list is incorrect for qtwebkit
https://bugs.webkit.org/show_bug.cgi?id=56752
The minimum width of the select-box is calculated to be as small as possible
instead of hardcoded value (width of 7 characters) in minimumMenuListSize() function
This will avoid overapping the select lists in popular websites.
Test: fast/forms/selectlist-minsize.html
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::minimumMenuListSize):
2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: inline style is lost when deleting line break between paragraphs with same style
https://bugs.webkit.org/show_bug.cgi?id=61899
The bug was caused by ReplaceSelectionCommand::doApply's calling handleStyleSpansBeforeInsertion
before insertionPos is adjusted by positionAvoidingPrecedingNodes and positionOutsideTabSpan.
Fixed the bug by calling handleStyleSpansBeforeInsertion after the calls to these two functions.
Test: editing/deleting/delete-line-break-between-paragraphs-with-same-style.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
2011-06-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Simon Fraser.
REGRESSION: Text selection broken for text with line-height applied
https://bugs.webkit.org/show_bug.cgi?id=54929
The bug was caused by RenderText::positionForPoint's not considering the case where a point is
above selectionTop and below lineTop of the first root inline box. Fixed the bug by considering
any point between selectionTop and lineTop to be inside a root inline box. This condition is
consistent with the condition we use to determine the bottom of a line.
Test: editing/selection/hit-test-on-text-with-line-height.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren): Fixed a condition to determine whether
or not a point is above the first root line box. We need to check both selectionTop and logicalTop
for the same reason explained above.
* rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint): See above.
2011-06-02 Andreas Kling <kling@webkit.org>
Rubber-stamped by Simon Hausmann.
Remove Qt's precompiled header hack as it was broken, and was not even
used unless building WebKit inside a Qt tree.
* WebCore.pri:
2011-06-01 David Carson <dacarson@apple.com>
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=61831
If width and height of an iframe is fixed and should not be visible, then
it shouldn't be flattened.
Test: fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::flattenFrame): add a check for a zero width or height
2011-06-02 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Andreas Kling.
[Qt] Multiple drop events when doing DnD of images.
https://bugs.webkit.org/show_bug.cgi?id=61504
Duplicate entries of the url were getting added into drag data
which is removed. The duplicate entries were causing the same image
url to be copied twice. The code changes now match other webkit ports.
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::declareAndWriteDragImage):
2011-05-31 Rafael Brandao <rafael.lobo@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::render() failing
https://bugs.webkit.org/show_bug.cgi?id=60893
Due a problem on QPicture (http://bugreports.qt.nokia.com/browse/QTBUG-19496),
this test was calculating the final geometry incorrectly. As the order between
a translate and a draw operation could be relevant for it, but not for the
final rendered result, they were changed on ScrollbarThemeQt::paint.
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarThemeQt::paint):
2011-05-31 B.J. Wever <skylined@chromium.org>
Reviewed by Adam Barth.
requestFileSystem and resolveLocalFileSystemURI are not checking if
errorCallback is NULL before scheduling a callback on error.
https://bugs.webkit.org/show_bug.cgi?id=49539
Test: fast/filesystem/filesystem-no-callback-null-ptr-crash.html
* fileapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::scheduleCallback): Only call callback if
one is supplied.
2011-05-31 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Convert raw ptr to RefPtr for documentElement.
https://bugs.webkit.org/show_bug.cgi?id=61688
Test: fast/dom/xml-parser-error-message-crash.svg
* dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::insertErrorMessageBlock):
2011-05-31 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491
After r77988, when frame flattening is enabled, performPostLayoutTasks() is called on a timer for iframes.
This causes layout of nested iframes to sometimes happen asynchronously, but WebCore expects layout to always finish synchronously.
Added a call to updateWidgetPosition() for cases that performPostLayoutTasks() is now happening asynchronously.
Test: fast/frames/flattening/iframe-flattening-nested.html
* page/FrameView.cpp:
(WebCore::FrameView::layout):
2011-05-13 Adam Roben <aroben@apple.com>
Build fix after r86418
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
Made the destructor public so that this class can be used with
[Pass]OwnPtr.
2011-05-13 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Enable OwnPtr strict mode in MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=59466
Let the CreateMediaEnginePlayer function return a PassOwnPtr instead of a raw pointer.
Also fix the templete argument of OwnPtr for the m_private member variable.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::MediaPlayer):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
* platform/graphics/MediaPlayer.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::create):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::create):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::create):
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivatePhonon::create):
* platform/graphics/qt/MediaPlayerPrivatePhonon.h:
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::create):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::create):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::create):
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
* platform/graphics/wince/MediaPlayerPrivateWinCE.h:
2011-05-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59394
Properly fix this (formerly rolled out for breaking the build). I think the original
failure had nothing to do with Deque<OwnPtr>, which in fact appears to work fine.
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::PendingCallbacks::~PendingCallbacks):
(WebCore::PendingCallbacks::create):
(WebCore::PendingCallbacks::appendStartElementNSCallback):
(WebCore::PendingCallbacks::appendEndElementNSCallback):
(WebCore::PendingCallbacks::appendCharactersCallback):
(WebCore::PendingCallbacks::appendProcessingInstructionCallback):
(WebCore::PendingCallbacks::appendCDATABlockCallback):
(WebCore::PendingCallbacks::appendCommentCallback):
(WebCore::PendingCallbacks::appendInternalSubsetCallback):
(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::PendingCallbacks::PendingCallbacks):
(WebCore::XMLDocumentParser::XMLDocumentParser):
2011-05-31 Oleg Romashin <oleg.romashin@nokia.com>
Reviewed by Benjamin Poulain.
Fix compilation with debug enabled, m_lightSource.type is not valid anymore
https://bugs.webkit.org/show_bug.cgi?id=61719
* platform/graphics/filters/arm/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):
2011-05-12 Daniel Bates <dbates@rim.com>
Attempt to fix the build after changeset 86391 <http://trac.webkit.org/changeset/86391>
(https://bugs.webkit.org/show_bug.cgi?id=60681).
* page/PluginHalter.cpp:
(WebCore::PluginHalter::PluginHalter): Substitute m_client for client in ASSERT_ARG since client is now of type PassOwnPtr
so it becomes 0 when assigned to another variable.
2011-05-12 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Enable OwnPtr strict mode in PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=60681
Pass PluginHalterClient as (Pass)OwnPtr to Page and PluginHalter.
* WebCore.exp.in:
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):
* page/Page.h:
* page/PluginHalter.cpp:
(WebCore::PluginHalter::PluginHalter):
* page/PluginHalter.h:
2011-05-28 Alexey Proskuryakov <ap@apple.com>
Suggested by Simon Fraser.
REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
https://bugs.webkit.org/show_bug.cgi?id=61692
<rdar://problem/9488628>
* loader/ImageLoader.cpp: (WebCore::ImageLoader::notifyFinished): There was no need to use
ASSERT_UNUSED here.
2011-05-28 Alexey Proskuryakov <ap@apple.com>
Reviewed by Geoff Garen.
REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
https://bugs.webkit.org/show_bug.cgi?id=61692
<rdar://problem/9488628>
Test: fast/dom/gc-image-element-2.html
Manually verified that tests from bug 59604 and from bug 40926 still pass.
The problem here was that HTMLImageElement::hasPendingActivity() could return false when
a load (or error) event was still expected to fire.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::setRequest):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::wasCanceled):
(WebCore::CachedResource::errorOccurred):
Track whether the load was canceled. We want to always notify clients of load outcome,
as that's the only way they could make intelligent decisions.
* dom/ScriptElement.cpp: (WebCore::ScriptElement::execute): Cached resource clients now
get a notifyFinished call on cancellation. Handle this case, where we don't need the
execute the script, but also don't need to fire an error event.
* html/HTMLImageElement.cpp: Moved hasPendingActivity() to header, since it's just a single
function call now.
* html/HTMLImageElement.h: (WebCore::HTMLImageElement::hasPendingActivity): There is a large
window between when CachedResource::isLoading() becomes false and events are queued.
ImageLoader::haveFiredLoadEvent() is a much better indication of whether we are expecting
an event to fire.
* html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::onloadTimerFired): Again, don't do
anything on cancellation.
* loader/ImageLoader.cpp:
(WebCore::ImageEventSender::hasPendingEvents): Made it debug-only again, and fixed to
give an accurate result while looping over the list of events to dispatch.
(WebCore::ImageLoader::notifyFinished): Don't do anything when cancelled. We don't want to
switch to a broken image icon, or to dispatch events.
(WebCore::ImageEventSender::dispatchPendingEvents): Clear the current loader from dispatching
list, as the event is no longer pending when it's being dispatched.
* loader/ImageLoader.h: Removed unnecessary hasPendingLoadEvent(). We don't care whether one
is already pending, we only care if one is expected at some time in the future, and
!haveFiredLoadEvent() is our best idea of that.
* dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::notifyFinished): Another place to
handle cancellation.
2011-05-23 Syed Idris Shah <syed.idris-shah@nokia.com>
Reviewed by Andreas Kling.
GraphicsContext3DInternal object should be called for getAttachedShaders.
[Qt] fast/canvas/webgl/gl-object-get-calls.html crash for Qt based webkit
https://bugs.webkit.org/show_bug.cgi?id=61202
LayoutTests/fast/canvas/webgl/gl-object-get-calls.html
getAttachedShaders should be called on GraphicsContext3DInternal instance.
It was left out by mistake.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getAttachedShaders): GraphicsContext3DInternal instance should be called.
2011-05-26 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
WebCore::HTMLSummaryElement::isMainSummary ReadAV@NULL
https://bugs.webkit.org/show_bug.cgi?id=61511
Removed Unnecessary wrong cast to Elmement, which can be non-Element.
Test: fast/html/details-summary-document-child.html
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::detailsElement):
2011-05-26 Shane Stephens <shanestephens@google.com>
Reviewed by James Robinson.
REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689
When a transform is modified in a style, we were upgrading our understanding
of the difference from PositionedMovementOnly to SimplifiedLayout. However,
if the position of the style is independently changed at the same time, both
PositionedMovement and SimplifiedLayout passes are required.
Test: transforms/2d/set-transform-and-top.html
* rendering/RenderObject.cpp:
Added checks for SimplifiedLayoutAndPositionedMovement - when encountered,
set both PositionedMovement and SimplifiedLayout update flasgs.
* rendering/style/RenderStyleConstants.h:
Added a new StyleDifference enum value (SimplifiedLayoutAndPositionedMovement) for
cases when both PositionedMovement and SimplifiedLayout are required.
2011-05-26 Syed Idris Shah <syed.idris-shah@nokia.com>
Reviewed by Andreas Kling.
[Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
https://bugs.webkit.org/show_bug.cgi?id=60377
LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html
For an array of active uniform, we should be careful while truncating the name of the uniform.
Currently we are truncating the last three characters of an array with out checking for [0].
As a result we are truncating the the actual name of the active uniforms i.e. color to co.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getUniform): Strip "[0]" from the name if it's an array and is part of the name.
2011-05-24 Syed Idris Shah <syed.idris-shah@nokia.com>
Reviewed by Andreas Kling.
[Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
https://bugs.webkit.org/show_bug.cgi?id=60377
LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html
We do not need assert for the useProgram as program can be null.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::useProgram): Program can be null. Removing assert.
2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87368.
http://trac.webkit.org/changeset/87368
https://bugs.webkit.org/show_bug.cgi?id=61564
Wrong approach, will do the wrong thing if the element needs
simplified normal flow layout but is not positioned (Requested
by jamesr on #webkit).
* rendering/RenderObject.h:
(WebCore::RenderObject::needsPositionedMovementLayout):
2011-05-20 Abhishek Arya <inferno@chromium.org>
Reviewed by Kent Tamura.
Make auto-focus a post attach callback in
HTMLFormControlElement::attach().
https://bugs.webkit.org/show_bug.cgi?id=32882
Original patch by Darin Adler. This one uses a part of it.
Test: fast/forms/input-element-attach-crash.html
* dom/Document.cpp:
(WebCore::Document::recalcStyle): Make sure that m_inStyleRecalc is
already false by the time post-attach callbacks are done so that
layout triggered inside those callbacks can work properly.
* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus): Helper function that expresses
the rule for which form control elements should auto-focus.
(WebCore::focusPostAttach): Called post-attach to focus an
element if we discover it should be focused during attach.
(WebCore::HTMLFormControlElement::attach): Refactored code for
which elements need auto-focus into a separate function. Instead
of focusing right away, use the focusPostAttach function to focus
after attach is done. Also added calls to suspendPostAttachCallbacks
and resumePostAttachCallbacks so post-attach callbacks happen late
enough. Before, they could run inside the base attach function.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attach): Added calls to
suspendPostAttachCallbacks and resumePostAttachCallbacks so
post-attach callbacks happen late enough
2011-05-18 Rob Buis <rbuis@rim.com>
Reviewed by Nikolas Zimmermann.
NULL deref when SVG elements have table styles
https://bugs.webkit.org/show_bug.cgi?id=45561
Restrict computed CSS values for SVG display property to block, inline or none.
Tests: svg/custom/display-table-caption-foreignObject.svg
svg/custom/display-table-caption-inherit-foreignObject.xhtml
svg/custom/display-table-caption-inherit-text.xhtml
svg/custom/display-table-caption-text.svg
* css/CSSStyleSelector.cpp:
(WebCore::SVGDisplayPropertyGuard::SVGDisplayPropertyGuard):
(WebCore::SVGDisplayPropertyGuard::~SVGDisplayPropertyGuard):
(WebCore::isAcceptableForSVGElement):
(WebCore::CSSStyleSelector::applyProperty):
2011-05-17 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Clear the image from ImageLoader rather than clearing the ImageLoader in HTMLObjectElement::renderFallbackContent.
https://bugs.webkit.org/show_bug.cgi?id=61005
Test: http/tests/loading/nested_bad_objects.php
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderFallbackContent):
2011-05-10 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Crashes if the document inside iframe is removed during pasting some text into it.
https://bugs.webkit.org/show_bug.cgi?id=60534
Added missing null check.
Test: editing/pasteboard/paste-removing-iframe.html
* editing/Editor.cpp:
(WebCore::Editor::shouldChangeSelection):
2011-05-11 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel.
Frequent crashes beneath WebCore::ScriptElement::prepareScript
https://bugs.webkit.org/show_bug.cgi?id=60559
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::runScript):
Add null check and explanation that we are keeping the ASSERT to help
track down the cause and produce a test.
2011-05-08 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/9401853> REGRESSION (r78846): Insufficient expansion for justification when there are multiple inline boxes
https://bugs.webkit.org/show_bug.cgi?id=60432
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::setExpansion): Changed back to take a int, since the m_expansion member
variable is a (truncated) int anyway.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::computeExpansionForJustifiedText): Changed the expansion local variable into an int
so that the right amount is added to the total width. Also changed to use an early return.
2011-05-06 Jon Lee <jonlee@apple.com>
Reviewed by Alice Liu.
Crash when sending a wheel event to a node with no shadow ancestor node
https://bugs.webkit.org/show_bug.cgi?id=60429
<rdar://problem/9389619>
* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):add check to see if the shadow ancestor node of the node that was under the mouse exists before trying to dispatch the wheel event to it.
2011-05-25 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Always antialias borders, outlines and rules when scaling
https://bugs.webkit.org/show_bug.cgi?id=61502
r84273 changed the behavior of drawLineForBoxSide() to never antialias by default.
This actually disabled antialiasing in some circumstances where it used to be enabled,
for example collapsed table border drawing.
Fix by allowing antialiasing for collapsed table borders, column rules and span
outlines when the context is scaled.
Test: fast/borders/border-antialiasing.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorder):
2011-05-26 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Andreas Kling.
drag-not-loaded-image.html test crashes when WebKit is built with debug option
https://bugs.webkit.org/show_bug.cgi?id=61480
Checks if image has content before starting to drag.
* page/DragController.cpp:
(WebCore::DragController::startDrag):
2011-05-25 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Antonio Gomes.
[Qt] QtWebKit crashes when dragging not loaded images
https://bugs.webkit.org/show_bug.cgi?id=61314
Checks if nativeImageForCurrentFrame is a valid pointer.
Test: http/tests/misc/drag-not-loaded-image.html
* platform/qt/DragImageQt.cpp:
(WebCore::createDragImageFromImage):
2011-05-26 Shane Stephens <shanestephens@google.com>
Reviewed by James Robinson.
REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689
Test: transforms/2d/set-transform-and-top.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedLayout):
2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Antonio Gomes.
[Qt] When QWebView has a different style set on it then the scrollbars are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=34635
Make sure the scrollbar is properly rendered on Mac with another style than the Mac style. The code had
two paths, one for Mac and one for any other styles. The problem is that on Mac you can still run the
application with -style plastique for example, therefore the code used for other styles should also be
used whenever the current style is not the Mac style.
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarThemeQt::paint):
2011-05-24 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Ryosuke Niwa.
[SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
https://bugs.webkit.org/show_bug.cgi?id=60692
Add NULL check of 'holder' in WebCore::ReplacementFragment::ReplacementFragment()
before call VisibleSelection::selectionFromContentsOfNode() to prevent crashing.
Test: editing/pasteboard/drag-drop-input-in-svg.svg
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
2011-05-24 Andy Estes <aestes@apple.com>
Reviewed by Geoffrey Garen.
REGRESSION (r70748): WebKit cannot play QuickTime movies on Mac OS X Wiki Server pages
https://bugs.webkit.org/show_bug.cgi?id=61229
This site-specific hack maintains compatibility with Mac OS X Wiki Server,
which embeds QuickTime movies using an object tag containing QuickTime's
ActiveX classid. Treat this classid as valid only if OS X Server's unique
'generator' meta tag is present. Only apply this quirk if there is no
fallback content, which ensures the quirk will disable itself if Wiki
Server is updated to generate an alternate embed tag as fallback content.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Return
true if site-specific quirks are enabled, the object element has no
fallback content, the classid attribute matches QuickTime's classid and
the document has a 'generator' meta tag matching Mac OS X Web Services
Server's unique generator string.
(WebCore::HTMLObjectElement::hasValidClassId): Call
shouldAllowQuickTimeClassIdQuirk()
* html/HTMLObjectElement.h:
2011-05-24 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
fix render overflow computation for input type=range
https://bugs.webkit.org/show_bug.cgi?id=61132
Test: fast/forms/slider-hit-testing.html
We need to clear m_overflow otherwise we use the first
size of the slider for hit testing (i.e., changes to the size
cause problems). This only shows up if the thumb isn't contained
in the bounds of the slider. Making the range have a smaller height
than the thumb shows the bug.
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout): Clear the overflow during layout
so we re-compute the overflow based on the current size of the
slider.
2011-05-14 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
As per spec, only allow one font family name in a font face rule.
Other things like initial value, inherited value or multiple names
are discarded.
https://bugs.webkit.org/show_bug.cgi?id=60837
Test: fast/css/invalid-font-family-in-font-face-crash.html
* css/CSSParser.cpp:
(WebCore::CSSParser::createFontFaceRule):
2011-05-18 Abhishek Arya <inferno@chromium.org>
Reviewed by Dirk Schulze.
When SMIL element is getting removed, make sure to remove it
from target's animation elements list.
https://bugs.webkit.org/show_bug.cgi?id=60980
Test: svg/animations/smil-element-not-removed-crash.html
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::~SVGSMILElement):
2011-05-23 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Convert raw pointer to RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=61196
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::endElementNs):
* dom/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseEndElement):
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87007.
http://trac.webkit.org/changeset/87007
https://bugs.webkit.org/show_bug.cgi?id=61329
patch unnecessarily breaks HTML5 compatibility (Requested by
estes on #webkit).
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::hasValidClassId):
2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Darin Adler.
Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem()
https://bugs.webkit.org/show_bug.cgi?id=57140
Test: fast/storage/storage-detached-iframe.html
Access of localStorage on a detached iframe was causing a crash because a detached
iframe has a null m_page, and WebCore::privateBrowsingEnabled() wasn't testing for such.
* storage/StorageAreaImpl.cpp:
(WebCore::privateBrowsingEnabled): check that child->page() is non-null before
accessing it.
2011-05-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Enrica Casucci.
REGRESSION(r84311): WebKit copies too much styles when copying
https://bugs.webkit.org/show_bug.cgi?id=60914
The bug was caused by WebKit's cloning node hierarchy up until the node that has background color.
Fixed the bug by not cloning background color and adding the effective background color to the wrapping
style span.
Tests: editing/pasteboard/do-no-clone-unnecessary-styles-2.html
editing/pasteboard/do-no-clone-unnecessary-styles.html
* editing/EditingStyle.cpp:
(WebCore::cssValueToRGBA): Extracted from getRGBAFontColor.
(WebCore::getRGBAFontColor): Moved.
(WebCore::rgbaBackgroundColorInEffect): Added.
(WebCore::EditingStyle::init): Added support for InheritablePropertiesAndBackgroundColorInEffect.
(WebCore::EditingStyle::prepareToApplyAt): Include the effective background color at the given position.
Also remove the background color property when the effective background color is equal to the background
color property (in terms of RGBA value) of the editing style.
(WebCore::hasTransparentBackgroundColor): Moved from Editor class.
(WebCore::backgroundColorInEffect): Extracted from Editor::selectionStartCSSPropertyValue.
* editing/EditingStyle.h: Added prototypes for hasTransparentBackgroundColor and backgroundColorInEffect.
* editing/Editor.cpp:
(WebCore::Editor::selectionStartCSSPropertyValue): Calls backgroundColorInEffect.
* editing/Editor.h: Removed hasTransparentBackgroundColor.
* editing/markup.cpp:
(WebCore::isElementPresentational): Reverted r85090 and r84311.
(WebCore::createMarkup): Include the background color in effect when computing the editing style.
2011-05-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Enrica Casucci.
Wrap copied contents by one style span instead of two
https://bugs.webkit.org/show_bug.cgi?id=60988
Replaced sourceDocumentStyleSpan and copiedRangeStyleSpan by one wrapping style span. Instead
of wrapping the copied contents by user-applied style and document default style in serialization,
take the difference with the document default's style in paste code.
This will dramatically simplify our copy and paste code and pave a way to fix the bug 60914.
No new tests because copy & paste is tested by existing layout tests.
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::prepareToApplyAt): Remove the color property if RGBA values of color
matches that of the computed style at the specified position.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Replaced sourceDocumentStyleSpan and
copiedRangeStyleSpan by wrappingStyleSpan. When pasting as a quotation, compare style against
the document's default style to avoid keeping the document default style (tested by
editing/pasteboard/4930986-3.html).
* editing/ReplaceSelectionCommand.h:
* editing/markup.cpp:
(WebCore::createMarkup): Only use one style span to wrap the serialized contents.
2011-05-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Terminate css color parsing on integers which are not followed
by a terminator.
https://bugs.webkit.org/show_bug.cgi?id=61293
Test: fast/css/parse-color-int-or-percent-crash.html
* css/CSSParser.cpp:
(WebCore::parseColorIntOrPercentage):
2011-05-21 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r66731): pointer-events are broken in some cases
https://bugs.webkit.org/show_bug.cgi?id=45467
The SVGSVGElement shouldn't be the target of a mouse event, if its pointer-events attribute is set
to 'none'. This matches the behavior on Firefox where an embedded SVG element is the target of an event,
if none of its childs caught the event. This is the case for all pointer-events other than 'none'.
Tests: svg/custom/pointer-events-on-svg-with-pointer.xhtml
svg/custom/pointer-events-on-svg-without-pointer.xhtml
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):
2011-05-21 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/9479926> REGRESSION (r82144): Icon overlaps text in Twitter message dialog
https://bugs.webkit.org/show_bug.cgi?id=61241
Test: fast/block/positioning/start-ignoring-before.html
* rendering/RenderBlockLineLayout.cpp:
(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes): Added a boolean parameter saying
whether to merge the first trailing space with the line break.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): When adding a midpoint behind the current
character, account for trailing positioned objects that occurred after the midpoint by calling
updateMidpointsForTrailingBoxes(), which adds midpoints for them.
2011-05-20 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r70748): WebKit cannot play videos created by Podcast Producer.
https://bugs.webkit.org/show_bug.cgi?id=61229
Podcast Producer uses an object tag with a classid attribute to embed
QuickTime Player into a page. In r70748, we changed our behavior to
render the object's fallback content when a non-empty classid is
encountered, per HTML5. Since Podcast Producer videos have no fallback
content, this change in behavior causes the video to fail to load.
Since the object tag has a valid type attribute, we would be able to
load it if weren't for the non-empty classid. This patch changes our
policy to allow objects with non-empty classids if there is no fallback
content. We still continue to prefer fallback content if it exists,
however.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::hasValidClassId): Treat a non-empty
classid as valid if the object has no fallback content.
2011-05-20 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
SVG Large curve path segment OOM crash
https://bugs.webkit.org/show_bug.cgi?id=42079
Limit the depth of repeatedly splitting a segment on length calculation to 20. The limitation
is necessary for very big segments that would be splitter into millions of parts otherwise.
The limitation just cause a less accurate approximation.
At the moment the limit is fixed to 20. This is comparable with splitting the segment into
~1 million parts as a worst case. We might want to be more flexible later.
Test: svg/custom/path-getTotalLength-on-big-segment-crash.svg
* platform/graphics/PathTraversalState.cpp:
(WebCore::midPoint):
(WebCore::curveLength):
(WebCore::PathTraversalState::PathTraversalState):
(WebCore::PathTraversalState::moveTo):
(WebCore::PathTraversalState::quadraticBezierTo):
(WebCore::PathTraversalState::cubicBezierTo):
* platform/graphics/PathTraversalState.h:
2011-05-19 Andrew Wilson <atwilson@chromium.org>
Reviewed by Darin Adler.
MessagePortArray cloning code needs to verify source before copying.
https://bugs.webkit.org/show_bug.cgi?id=61130
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::fillMessagePortArray):
Changed code to not pre-allocate the destination array.
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::getMessagePortArray):
Changed code to not pre-allocate the destination array.
2011-05-06 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Darin Adler.
Fix two warnings of unused variables.
https://bugs.webkit.org/show_bug.cgi?id=60370
Remove two unused local variable from the code.
No new tests, the existing ones should cover.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutVerticalBox):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateNextProgressTime):
2011-05-18 Alexis Menard <alexis.menard@openbossa.org>, Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Eric Carlson.
MediaElements fails to load the data in some cases.
https://bugs.webkit.org/show_bug.cgi?id=60760
WebKitWebSourceGStreamer is the interface between WebKit and GStreamer
that uses the ResourceHandle API to request data and pass it down. For
our builds it is absolutely essential that we have a NetworkingContext
available there, in order to get access to the QNetworkAccessManager.
No access means we basically cannot load the video. The WebSource gains
access to the NetworkingContext through a WebCore::Frame pointer it has.
MediaPlayerPrivateGStreamer is responsible for propagating a pointer of
the WebCore::Frame to the WebKitWebSource in
mediaPlayerPrivateSourceChangedCallback. In there we used the MediaPlayer's
frameView() accessor to access the frame. However the frameView() member
is only set through the render tree's RenderVideo, which is rather unreliable
given that some sites create "fake" video tags initially that only become
visible later (or never).
A more reliable way is to simply use the document of the MediaPlayerClient,
which is provided at constructor time.
Test: http/tests/media/media-can-load-when-hidden.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
2011-05-19 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by Darin Adler.
Fix GraphicsContext3DQt.cpp compile error
https://bugs.webkit.org/show_bug.cgi?id=61128
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
clear() m_internal OwnPtr.
2011-05-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION (r83322): Many crashes in Mail.app in WebCore::Node::nodeIndex
https://bugs.webkit.org/show_bug.cgi?id=61012
The crash was caused by ReplaceSelectionCommand's inserting content into a middle of the paragraph
being moved when the insertion position's container node is the node to split to. Fixed the crash
by not changing the insertion position in such a case.
Unfortunately, this fix caused markup to bloat in some tests but we'll take this regression since
it's much better than crashing.
Test: editing/pasteboard/paste-after-inline-style-element.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
2011-05-19 Emil A Eklund <eae@chromium.org>
Reviewed by Alexey Proskuryakov.
REGRESSION (r80808): Multiple <select> - Selection reset to first element from multiple selected ones
https://bugs.webkit.org/show_bug.cgi?id=60986
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setMultiple):
Don't restore selection if the multiple attribute hasn't changed.
2011-05-18 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Andreas Kling.
[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
https://bugs.webkit.org/show_bug.cgi?id=33179
Fill the missing key text for the EnterKey event.
Tests: fast/events/onsearch-enter.html
* platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::keyTextForKeyEvent):
2011-05-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
JSGlobalObject and some others do GC allocation during initialization, which can cause heap corruption
https://bugs.webkit.org/show_bug.cgi?id=61090
Rather than having Constructor objects create their structure
as part of initialisation, we now pass their expected structure
in as an argument. This required fixing the few custom Constructors
and the code generator.
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor):
* bindings/js/JSAudioConstructor.h:
* bindings/js/JSDOMGlobalObject.h:
(WebCore::getDOMConstructor):
Pass the Constructor objects structure in as an argument
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
* bindings/js/JSImageConstructor.h:
* bindings/js/JSOptionConstructor.cpp:
(WebCore::JSOptionConstructor::JSOptionConstructor):
* bindings/js/JSOptionConstructor.h:
* bindings/scripts/CodeGeneratorJS.pm:
2011-05-18 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Fix tst_QWebFrame::getSetStaticProperty() autotest
https://bugs.webkit.org/show_bug.cgi?id=60984
The code for converting objects to QVariantMap was causing exception,
that was "leaking" to the next evaluation. One situation was reading
the property 'localStorage' when we do not have a proper security
origin, which throws a SECURITY_ERR.
Now, we will simply not include on the QVariantMap those properties,
and make sure that we clean the exception if necessary.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariantMap):
Extracted function that performs conversion from JSObject to a QVariantMap. This
functions makes sure that exception is clean after its execution.
(JSC::Bindings::convertValueToQVariant):
Use the previous function. Add a comment explaining the choice of distance value.
2011-05-18 Abhishek Arya <inferno@chromium.org>
Reviewed by Beth Dakin.
Remove removeChild on table caption since destroy call
already does that.
https://bugs.webkit.org/show_bug.cgi?id=61083
Test: fast/table/table-captions-child-visible-crash.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::recalcCaption):
2011-05-09 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Redirection of HTTP POST (3xx) incorrectly includes original POST data
https://bugs.webkit.org/show_bug.cgi?id=60440
Makes sure that the HTTP headers Content-type and Content-length are not included in
the requests that do not have any content.
Tests: http/tests/navigation/post-301-response.html
http/tests/navigation/post-302-response.html
http/tests/navigation/post-303-response.html
http/tests/navigation/post-307-response.html
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
2011-05-17 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] GraphicsLayerQtImpl: Remove an unused variable.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::paint):
2011-05-17 Sam Magnuson <smagnuson@netflix.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Node that have both an opacity and a transform animation on them seem not to fire.
https://bugs.webkit.org/show_bug.cgi?id=40841
Test: compositing/animation/busy-indicator.html
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::recache):
(WebCore::GraphicsLayerQtImpl::flushChanges):
(WebCore::GraphicsLayerQt::setContentsToImage):
(WebCore::TransformAnimationQt::getAnimatedProperty):
(WebCore::OpacityAnimationQt::getAnimatedProperty):
(WebCore::GraphicsLayerQt::addAnimation):
2011-05-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove bogus ASSERT in Document::setCompatibilityMode
https://bugs.webkit.org/show_bug.cgi?id=60935
The ASSERT is invalid when the parser is in the initial state and the
document is non-empty, which is strange but not impossible.
Test: fast/parser/append-child-followed-by-document-write.html
* dom/Document.cpp:
(WebCore::Document::setCompatibilityMode):
2011-05-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
https://bugs.webkit.org/show_bug.cgi?id=59699
Global object is recreated on teardown, for no good reason
(Another partial fix for <rdar://problem/9417875> REGRESSION: SunSpider
~7% slower in browser than on command line (was 17%))
I'm basically rolling out http://trac.webkit.org/changeset/49786 because
(a) it created this performance problem
and
(b) a more complete fix, which obsoletes http://trac.webkit.org/changeset/49786,
was committed in http://trac.webkit.org/changeset/53439.
Tested with the file attached to https://bugs.webkit.org/show_bug.cgi?id=29832.
* page/Frame.cpp:
(WebCore::Frame::~Frame): Don't create a new window every time we destroy
a frame.
2011-05-13 Mikhail Naganov <mnaganov@chromium.org>
Web Inspector: Unreviewed image glyph position fix in CSS after r85588.
* inspector/front-end/heapProfiler.css:
(.heapshot-help-status-bar-item .glyph):
2011-05-13 Alexey Proskuryakov <ap@apple.com>
Reviewed by Joseph Pecoraro.
Hide appcache status bar items
https://bugs.webkit.org/show_bug.cgi?id=60799
We have a number of non-trivial bugs that make these more misleading than helpful to developers.
* inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView):
Just hide the items for now. Removing all support code would be complicated, and not helpful.
2011-05-13 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Regression(r75823): Revert initialization back to the first RenderBlock
in the parent chain.
https://bugs.webkit.org/show_bug.cgi?id=60780
Test: fast/block/float/float-not-removed-crash.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
In r75823, I forgot to initialize parentBlock, when the original code
did and Hyatt did mention in c#5. Now, initializing parentBlock to the
first RenderBlock in the parent chain.
2011-05-13 Adam Roben <aroben@apple.com>
Tell ScrollView's child Widgets that their frame rects have changed when its own frame rect
changes
r79167 moved some code from setFrameRect to setBoundsSize, including a call to
frameRectsChanged. This was done because positionScrollbarLayers, which is called by
frameRectsChanged, only needs to be called when the bounds change, not when the frame rect
changes. But the recursive calls inside frameRectsChanged *do* need to be called when the
frame rect changes.
This patch moves the positionScrollbarLayers call out of frameRectsChanged, since it needs
to be called at different times from frameRectsChanged. Then it restores the
frameRectsChanged call to setFrameRect, which fixes the bug.
Test: platform/win/plugins/iframe-inside-overflow.html
Fixes <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION (r79167): Windowed
plugins in Google Reader don't move when the article list is scrolled
Reviewed by Dan Bernstein.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Added a positionScrollbarLayers call here now that
frameRectsChanged doesn't call it for us. Also added a FIXME because it seems strange to
call frameRectsChanged here when our frame rect hasn't changed.
(WebCore::ScrollView::setFrameRect): Added back the frameRectsChanged call that was removed
in r79167.
(WebCore::ScrollView::setBoundsSize): Replaced a frameRectsChanged call with a call to
positionScrollbarLayers. We were only calling frameRectsChanged here in order to get
positionScrollbarLayers to be called.
(WebCore::ScrollView::frameRectsChanged): Removed the call to positionScrollbarLayers. All
callers of frameRectsChanged have been updated to call positionScrollbarLayers if needed.
2011-05-11 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implements a disable appearance for Media Elements of Qt port.
https://bugs.webkit.org/show_bug.cgi?id=60561
Implements a disable appearance for the media controls of the Qt port
when the media is not yet available.
* platform/qt/RenderThemeQt.cpp:
(WebCore::mediaElementCanPlay):
(WebCore::RenderThemeQt::getMediaControlForegroundColor):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
2011-05-11 Chang Shu <cshu@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
https://bugs.webkit.org/show_bug.cgi?id=60477
PlatformKeyboardEvent.m_text should be set to "\t" instead of leaving as null.
The value is checked at EventHandler.cpp:2527 (r86166).
Function keyTextForKeyEvent is partially implemented and can be enhanced in
a need-base.
* platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::keyTextForKeyEvent):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2011-05-12 Rob Buis <rwlbuis@gmail.com>
Reviewed by Eric Seidel.
REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
https://bugs.webkit.org/show_bug.cgi?id=59941
Also consider fill-opacity when determining whether StyleDifferenceRepaint is needed.
Test: svg/custom/fill-opacity-update.svg
* rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::diff):
2011-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
REGRESSION (r65868): createContextualFragment does not work with <style>
https://bugs.webkit.org/show_bug.cgi?id=60155
createContextualFragment doesn't have a spec, so it's hard to tell what
we're supposed to do exactly. This patch appears to make our behavior
more like Firefox and should fix the compat issue with this site.
Tests: fast/parser/style-in-create-contextual-fragment-head.html
fast/parser/style-in-create-contextual-fragment.html
* dom/Element.cpp:
(WebCore::Element::deprecatedCreateContextualFragment):
2011-05-12 Carol Szabo <carol@webkit.org>
Reviewed by David Hyatt.
Fix reparenting and destruction of counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=57929
Fixed several issues related to not met assertions.
See below in the per file description.
Test: fast/css/counters/element-removal-crash.xhtml
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
Fixed the fact that Node::detach() used to be called
while the DOM tree was in an inconsistent state.
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::rendererRemovedFromTree):
Introduced this function to remove counters from
descendents of renderers removed from the renderer
tree not only from the removed renderers themselves.
* rendering/RenderCounter.h:
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
Changed to call RenderCounter::rendererRemovedFromTree
instead of RenderCounter::destroyCounters.
2011-05-11 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r85650.
http://trac.webkit.org/changeset/85650
https://bugs.webkit.org/show_bug.cgi?id=59983
Triggers m_numNodeListCaches > 0 assert in gc-heavy sites.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::childrenChanged):
* dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::setDocument):
(WebCore::Node::setTreeScopeRecursively):
(WebCore::Node::childNodes):
(WebCore::Node::registerDynamicNodeList):
(WebCore::Node::unregisterDynamicNodeList):
(WebCore::Node::notifyLocalNodeListsAttributeChanged):
(WebCore::Node::notifyLocalNodeListsChildrenChanged):
(WebCore::Node::getElementsByTagName):
(WebCore::Node::getElementsByTagNameNS):
(WebCore::Node::getElementsByName):
(WebCore::Node::getElementsByClassName):
* dom/Node.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::labels):
2011-05-06 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
REGRESSION (r77954): HTTP Live Streams have incorrect controller UI
https://bugs.webkit.org/show_bug.cgi?id=60304
<rdar://problem/9392609>
Don't assume that the only time the media controls UI may need to change is on a
network state change, readyState changes can be significant as well.
Tested manually because we don't have any live streams to test in DRT.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setNetworkState): changedNetworkState -> updateStatusDisplay.
(WebCore::HTMLMediaElement::setReadyState): Call updateStatusDisplay.
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::reset): changedNetworkState -> updateStatusDisplay.
(WebCore::MediaControlRootElement::updateStatusDisplay): Ditto.
* html/shadow/MediaControlRootElement.h:
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::reset): Ditto.
(WebCore::MediaControlRootElementChromium::updateStatusDisplay): Ditto.
* html/shadow/MediaControlRootElementChromium.h:
* html/shadow/MediaControls.h:
2011-05-06 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing
Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.
Added fast/inline/nested-top-alignment.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
2011-05-06 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=60390 (<rdar://problem/9364449>)
REGRESSION (r81992): portions of ticketmaster site render blank
Make simplified layout skip from a positioned object out to its containing block. There is no
need to dirty the intermediate inlines, and in this case it's actively harmful, since the
block responsible for the layout of the positioned object doesn't get m_posChildNeedsLayout set.
Added fast/block/positioning/hiding-inside-relpositioned-inline.html
* rendering/RenderObject.h:
(WebCore::RenderObject::markContainingBlocksForLayout):
2011-05-05 Bharathwaaj Srinivasan <bharathwaaj.s@gmail.com>
Reviewed by Holger Freyther.
Fix build-webkit --minimal.
https://bugs.webkit.org/show_bug.cgi?id=60257
No new tests. This is just a build fix.
* bindings/js/JSDOMBinding.cpp:
2011-05-08 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsContext3D::getImageData() does not retrieve image data correctly
https://bugs.webkit.org/show_bug.cgi?id=58556
Tests: fast/canvas/webgl/gl-teximage.html
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData):
2011-05-09 Jeremy Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
REGRESSION (r84706): Crazy rendering of vimeo.com after exiting fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=60512
Initialize m_containsFullScreenElement.
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
2011-05-08 Jeremy Noble <jer.noble@apple.com>
Reviewed by Dan Bernstein.
Full-screen video disappears behind black screen with scrollbar, followed by crash at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=60449
Make RenderFullScreen a non-anonymous block, so that it does not get deleted when a parent attempts to
coalesce anonymous children.
Test: fullscreen/full-screen-remove-sibling.html
* rendering/RenderObject.h:
(WebCore::RenderObject::isAnonymousBlock):
2011-05-10 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
REGRESSION(r73886): Frequent crashes in replaceSelectionWithFragment
https://bugs.webkit.org/show_bug.cgi?id=60090
SpellChecker uses TextCheckerClient, which belongs Page object,
which is possibly destroyed during SpellChecker's lifetime.
This change added to a guard before using TextCheckerClient to
ensure it being live.
No new tests, this is a speculative fix for a real crash.
* editing/Editor.cpp:
(WebCore::Editor::Editor):
* editing/SpellChecker.cpp:
(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::client):
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::requestCheckingFor):
* editing/SpellChecker.h:
2011-05-10 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Antonio Gomes.
Warning fix on PluginPackage.cpp.
https://bugs.webkit.org/show_bug.cgi?id=60371
Warning fix on conversion from time_t to unsigned on Linux with GCC 4.6.0.
Let's use a struct rather than an array so we can pass everything to StringHasher.
* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::hash):
2011-05-10 Andreas Kling <andreas.kling@nokia.com>
Rubber-stamped by Csaba Osztrogonác.
[Qt] Disable HAVE_QRAWFONT until Qt API stabilizes.
https://bugs.webkit.org/show_bug.cgi?id=60551
* WebCore.pro: Disable the line that enables HAVE_QRAWFONT
if the feature is found. Added a comment about why.
2011-05-10 Keith Kyzivat <keith.kyzivat@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtRawFont support should check based on feature, not version
https://bugs.webkit.org/show_bug.cgi?id=60513
Build fix - no tests added.
* WebCore.pro:
2011-05-09 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed Qt 4.8 fix.
* WebCore.pro: 4.8 bots are updated with the full QRawFont APIs, so we can set HAVE_QRAWFONT now.
2011-05-06 Andreas Kling <andreas.kling@nokia.com>
Unreviewed Qt 4.8 build fix.
* WebCore.pro: Don't set HAVE_QRAWFONT yet. Left a FIXME so we can
enable it after the 4.8 bots are updated with the full QRawFont APIs.
2011-05-09 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Simple small-caps text is displayed in uniform size.
https://bugs.webkit.org/show_bug.cgi?id=60492
Covered by existing tests.
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData): In the FontPlatformData constructor
used by SimpleFontData::scaledFontData(), pass the pixel size to both QFont and QRawFont
to make small caps and emphasis marks have the correct size when rendered through
the fast font path.
2011-05-09 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Fix the build on Embedded Linux.
https://bugs.webkit.org/show_bug.cgi?id=60347
qpa is the name for lighthouse but the old name for Qt for Embedded Linux should
still be used in order to build properly.
* WebCore.pri:
2011-05-06 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Alexey Proskuryakov.
Build fix with gcc 4.6 and c++0x support.
https://bugs.webkit.org/show_bug.cgi?id=60284
When enabling support of c++0x the compilation fails because of an
ambiguous overload error. In this code when constructing the pair
we use the new c++0x rvalue reference feature (&&). It means we are
calling String(const WTF::AtomicString&) which becomes ambiguous because
it has an overload WTF::String::String(const WTF::String&) and usually one
with the native port string type (e.g. QString). In this code we want the
String version because the pair store Strings.
No new tests, build fix.
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
2011-05-05 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
https://bugs.webkit.org/show_bug.cgi?id=60101
Test: fast/parser/close-while-stopping.html
* dom/Document.cpp:
(WebCore::Document::close): According to http://www.whatwg.org/specs/web-apps/current-work/#dom-document-close,
the close() steps should be aborted if there is no script-created parser
associated with the document. Our parser lives throughout
http://www.whatwg.org/specs/web-apps/current-work/#the-end, but it seems
the spec doesn't consider the parser active any more. So to properly
respect this, we need to check that the parser is still parsing.
2011-05-05 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Implement the fast font path for Qt.
https://bugs.webkit.org/show_bug.cgi?id=51106
Use the new QRawFont and QGlyphs APIs in Qt 4.8 to implement the fast paths for
rendering and measurement of simple text.
Since this is still unreleased API, it's guarded by HAVE(QRAWFONT) until the new
classes are fully integrated into the Qt 4.8 release branch.
* WebCore.pro: Add HAVE_QRAWFONT define (for Qt >= 4.8) and new files to build.
* platform/graphics/Font.cpp:
(WebCore::Font::drawText): Disable fast font path for stroked text, and when
painting text with a shadow. (Qt-only)
(WebCore::Font::codePath): Try to use fast font path in more cases.
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::rawFontForCharacters): Helper function, returns a suitable QRawFont
to use for rendering a given string. Goes through QTextLayout to find the best
font based on the original QFont query.
(WebCore::FontCache::getFontDataForCharacters): Implemented using helper above.
* platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::rawFont):
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData): Add a QRawFont member to FontPlatformData.
* platform/graphics/qt/FontQt.cpp:
(WebCore::fillPenForContext):
(WebCore::strokePenForContext):
(WebCore::drawTextCommon): Factored QPen creation out of drawTextCommon
to share code between complex and simple font rendering paths.
(WebCore::Font::drawGlyphs): Implemented using QPainter::drawGlyphs().
* platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
(WebCore::GlyphPage::fill): Implemented using QRawFont::glyphIndexesForString().
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::determinePitch): Return false when using QRawFont since we
have no way of knowing the pitch.
(WebCore::SimpleFontData::containsCharacters): Implemented using QRawFont::supportsCharacter().
(WebCore::SimpleFontData::platformWidthForGlyph): Implemented using QRawFont::advancesForGlyphIndexes().
(WebCore::SimpleFontData::scaledFontData): Added, based on other ports.
(WebCore::SimpleFontData::smallCapsFontData): Ditto.
(WebCore::SimpleFontData::emphasisMarkFontData): Ditto.
(WebCore::SimpleFontData::platformBoundsForGlyph): Stub.
(WebCore::SimpleFontData::platformInit): Use QRawFont APIs to retrieve font metrics.
(WebCore::SimpleFontData::platformCharWidthInit): Ditto.
2011-05-05 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
https://bugs.webkit.org/show_bug.cgi?id=60224
We should use nullptr rather than 0. nullptr will be added in the new C++ standard
but WebKit already has a nullptr class if there is no c++0x support.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::adjustSliderTrackStyle):
(WebCore::RenderThemeQt::adjustSliderThumbStyle):
2011-05-05 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: rename BrowserDebugger to DOMDebugger.
https://bugs.webkit.org/show_bug.cgi?id=60256
InspectorBrowserDebuggerAgent => InspectorDOMDebuggerAgent
browserDebugger => domDebugger
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::inspectedPageDestroyed):
(WebCore::InspectorAgent::disconnectFrontend):
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::DOMDebuggerAgent):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend):
* inspector/InspectorDOMDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp.
(WebCore::InspectorDOMDebuggerAgent::create):
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::~InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::debuggerWasEnabled):
(WebCore::InspectorDOMDebuggerAgent::debuggerWasDisabled):
(WebCore::InspectorDOMDebuggerAgent::disable):
(WebCore::InspectorDOMDebuggerAgent::clearFrontend):
(WebCore::InspectorDOMDebuggerAgent::discardBindings):
(WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::didInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::didRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorDOMDebuggerAgent::hasBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::updateSubtreeBreakpoints):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
(WebCore::InspectorDOMDebuggerAgent::clear):
* inspector/InspectorDOMDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
* inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorDOMDebuggerAgent):
(WebCore::InstrumentingAgents::setInspectorDOMDebuggerAgent):
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::connectFrontend):
2011-05-04 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: show only Console and Scripts panels in worker inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=60159
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.isWorkerFrontend):
* inspector/front-end/inspector.js: show only Scripts and Console panels in the worker inspector front-end.
2011-05-03 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
IndexedDB: Unit tests for LevelDB key coding functions
https://bugs.webkit.org/show_bug.cgi?id=59692
Fix some embarrassing bugs uncovered by unit tests.
No new functionality, but this is now covered by unit tests in the Chromium WebKit port.
* storage/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::decodeInt):
(WebCore::IDBLevelDBCoding::decodeVarInt):
2011-05-05 Young Han Lee <joybro@company100.net>
Reviewed by Csaba Osztrogonác.
[Texmap][Qt] Enable strict OwnPtr for Qt with texmap enabled.
https://bugs.webkit.org/show_bug.cgi?id=60251
No new tests. Build fix.
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
2011-05-04 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Adding a utility class to read a SharedBuffer line by line.
https://bugs.webkit.org/show_bug.cgi?id=59946
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/SharedBufferCRLFLineReader.cpp: Added.
* platform/SharedBufferCRLFLineReader.h: Added.
2011-05-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r85788.
http://trac.webkit.org/changeset/85788
https://bugs.webkit.org/show_bug.cgi?id=60250
svg/text/text-block-child-crash.xhtml asserts (Requested by
Ossy on #webkit).
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
2011-05-04 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Make more member functions in EventHandler private
https://bugs.webkit.org/show_bug.cgi?id=60200
Reduced the number of public member functions in EventHandler.
* WebCore.exp.in:
* page/EventHandler.cpp:
(WebCore::EventHandler::handleAutoscroll):
(WebCore::EventHandler::autoscrollTimerFired):
(WebCore::EventHandler::stopAutoscrollTimer):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):
* page/EventHandler.h:
(WebCore::EventHandler::mouseDownMayStartSelect):
2011-05-04 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
https://bugs.webkit.org/show_bug.cgi?id=60202
In r85136 I accidentally transposed two lines in GraphicsLayerChromium when adding a null check. This switches
the order back and adds a regression test.
Test: compositing/repaint/transform-style-change.html
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
2011-05-04 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902
Test: fast/media/media-svg-crash.html
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::webView):
* page/ChromeClient.h:
* page/brew/ChromeClientBrew.h:
(WebCore::ChromeClientBrew::webView):
2011-05-04 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Darin Adler.
Unable to Paste After Deleting Text from Input due to -webkit-user-select
https://bugs.webkit.org/show_bug.cgi?id=60219
When deleting all the text inside the input a placeholder <br>
element was inserted for the selection point. However, when
pasting, the test run computes the -webkit-user-select for the
<br> element, instead of what would be the text inside the
<input> and incorrectly disallows selection and prevented
the paste.
Test: editing/pasteboard/paste-placeholder-input.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::insertFragmentForTestRendering): skip
<br> elements above us as those are likely placeholder elements.
2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Martin Robinson.
Windows build of WebKit GTK needs to be able to find SystemInfo.h
https://bugs.webkit.org/show_bug.cgi?id=60221
* GNUmakefile.am: add Source/WebCore/platform/win to the paths searched
for headers, since Source/WebCore/platform/win/SystemInfo.h
header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp
on Windows.
2011-05-04 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Improve sorting of layers in hierarchies that preserve-3d
by testing for overlapping regions between layer pairs and doing a
topological sort to determine the right order.
https://bugs.webkit.org/show_bug.cgi?id=59255
Test: platform/chromium/compositing/perpendicular-layer-sorting.html
* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::clearRenderSurface):
* platform/graphics/chromium/cc/CCLayerSorter.cpp: Added.
(WebCore::perpProduct):
(WebCore::innerProduct):
(WebCore::pointInColinearEdge):
(WebCore::edgeEdgeTest):
(WebCore::CCLayerSorter::LayerIntersector::LayerIntersector):
(WebCore::CCLayerSorter::LayerIntersector::go):
(WebCore::CCLayerSorter::LayerIntersector::edgeTriangleTest):
(WebCore::CCLayerSorter::LayerIntersector::triangleTriangleTest):
(WebCore::CCLayerSorter::LayerIntersector::checkZDiff):
(WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint):
(WebCore::CCLayerSorter::CCLayerSorter):
(WebCore::CCLayerSorter::checkOverlap):
(WebCore::CCLayerSorter::createGraphNodes):
(WebCore::CCLayerSorter::createGraphEdges):
(WebCore::CCLayerSorter::removeEdgeFromList):
(WebCore::CCLayerSorter::sort):
* platform/graphics/chromium/cc/CCLayerSorter.h: Added.
(WebCore::CCLayerSorter::GraphNode::GraphNode):
(WebCore::CCLayerSorter::GraphEdge::GraphEdge):
2011-05-03 Jer Noble <jer.noble@apple.com>
Reviewed by Antti Koivisto.
Safari: Video at apple.com cannot play at full screen mode with layout distortion
https://bugs.webkit.org/show_bug.cgi?id=60140
Because a fullscreen element may be in a stacking context with a lower z-index than
a sibling stacking context, those higher contexts would sometimes "pop" through the
full screen renderer. To facilitate eliminating all the stacking contexts aside from
the full screen renderer, added a new pseudo-class specific to video or audio full
screen elements. Then, added a new UA rule which resets the z-index and opacities of
all elements under said pseudo-class to auto and 1 respectively. To facilitate quick
identity checking of HTMLMediaElements, added isMediaElement() virtual function to
Element and HTMLMediaElement.
Test: fullscreen/full-screen-stacking-context.html
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId): Support PseudoFullScreenMediaDocument.
(WebCore::nameToPseudoTypeMap): Support fullScreenMediaDocument.
(WebCore::CSSSelector::extractPseudoType): Support PseudoFullScreenMediaDocument.
* css/CSSSelector.h: Add PseudoFullScreenMediaDocument.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Support PseudoFullScreenMediaDocument.
* css/fullscreen.css:
(:root:-webkit-full-screen-document:not(:-webkit-full-screen)): Corrected these names,
which were missing the -webkit prefix.
(:root:-webkit-full-screen-media-document *:not(-webkit-full-screen)): Added.
* dom/Element.h:
(WebCore::Element::isMediaElement): Added, returns false.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::isMediaElement): Added, returns true.
* rendering/style/RenderStyleConstants.h: Added FULL_SCREEN_MEDIA_DOCUMENT.
2011-05-04 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Split findNextLineBreak into a LineBreaker class
https://bugs.webkit.org/show_bug.cgi?id=60209
Breaking findNextLineBreak into a new class inside RenderBlock. Currently it's tracking
nearly no state, but subsequent patches will move some of the local variables used throughout
the nextLineBreak function into member variables to simplify breaking off helper functions from
the bloated function.
No new tests since this is just moving code around.
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderBlock.h:
(WebCore::RenderBlock::LineBreaker::LineBreaker):
(WebCore::RenderBlock::LineBreaker::lineWasHyphenated): Accessor.
(WebCore::RenderBlock::LineBreaker::positionedObjects): Ditto.
(WebCore::RenderBlock::LineBreaker::clear): Ditto.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace):
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
(WebCore::RenderBlock::LineBreaker::reset):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Adam Barth.
Add COMPILER(MINGW) to the compilers using the Microsoft C Runtime's vsnprintf.
The vsnprintf is part of Microsoft C runtime used also by MinGW (GCC) toolchain.
https://bugs.webkit.org/show_bug.cgi?id=58579
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::error):
2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed warning fix.
The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
a warning in Release build.
* dom/Node.cpp:
(WebCore::Node::removeEventListener):
* platform/DateComponents.cpp:
(WebCore::DateComponents::parseTime):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::convertToLayerCoords):
* storage/StorageMap.cpp:
(WebCore::StorageMap::importItem):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildShadowTree):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed warning fix.
The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
a warning in Release build.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::lastChildConsideringContinuation):
2011-05-04 Dimitri Glazkov <dglazkov@chromium.org>
Sort xcodeproj files.
The WebCore.xcodeproj got out of sorts again.
* WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Adam Barth.
Warning fix.
* bindings/js/DOMObjectHashTableMap.h:
(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
2011-05-04 Rob Buis <rbuis@rim.com>
Reviewed by Darin Adler.
NULL deref when SVG elements have table styles
https://bugs.webkit.org/show_bug.cgi?id=45561
Restrict computed CSS values for SVG display property to block, inline or none.
Tests: svg/custom/display-table-caption-foreignObject.svg
svg/custom/display-table-caption-inherit-foreignObject.xhtml
svg/custom/display-table-caption-inherit-text.xhtml
svg/custom/display-table-caption-text.svg
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
2011-05-04 Tao Bai <michaelbai@chromium.org>
Reviewed by David Kilzer.
Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143
Parsed and populated apple-touch-icon url to FrameLoaderClient.
Changed favicon to be a type of icon.
* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::iconURL):
(WebCore::Document::setIconURL):
* dom/Document.h:
* dom/IconURL.cpp: Added.
(WebCore::toIconIndex):
* dom/IconURL.h: Added.
(WebCore::IconURL::IconURL):
* features.pri:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::tokenizeRelAttribute):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
* html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
(WebCore::HTMLLinkElement::isEnabledViaScript):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::iconURL):
(WebCore::DocumentLoader::setIconURL):
* loader/DocumentLoader.h:
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::iconURL):
(WebCore::FrameLoader::iconURLs):
(WebCore::FrameLoader::fillIconURL):
(WebCore::FrameLoader::getDefaultIconURL):
(WebCore::FrameLoader::setIconURL):
(WebCore::FrameLoader::didChangeIcons):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
2011-05-04 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Crash in PlatformCALayer ::replaceSublayer when layer has not superlayer
https://bugs.webkit.org/show_bug.cgi?id=60191
Skip replaceSublayer when there is no superlayer rather than asserting.
This is probably not a problem and happens when restructuring the layer
tree. Avoiding this crash will allow us to get more testing.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
2011-05-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
Fix the GTK+ 2.x build for Windows. Instead of making getStockIcon a RenderTheme
method, just use extern declarations to avoid having to declare it in the header.
This will prevent having to include glib.h in RenderThemeGtk.h, which is included
in many C++ files.
No new tests. This is just a build fix.
* platform/gtk/RenderThemeGtk.cpp: Update getStockIcon calls to say getStockIconForWidgetType.
(WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
(WebCore::RenderThemeGtk::paintCapsLockIndicator):
(WebCore::RenderThemeGtk::paintMediaButton):
* platform/gtk/RenderThemeGtk.h: Removed getStockIcon declaration. Make gtkContainer() and
gtkEntry() public because they are now accessed externally from getStockIcon().
* platform/gtk/RenderThemeGtk2.cpp: Update getStockIcon calls.
(WebCore::getStockIconForWidgetType):
* platform/gtk/RenderThemeGtk3.cpp: Ditto.
(WebCore::getStockIconForWidgetType):
2011-05-04 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB open (database) should fail if name is null
https://bugs.webkit.org/show_bug.cgi?id=60022
Test: storage/indexeddb/mozilla/open-database-null-name.html
Combination problem: Bug in IDL didn't pass null values to .cpp layer,
then .cpp layer didn't check for null value anyway.
* storage/IDBFactory.cpp:
(WebCore::IDBFactory::open): check for null name
* storage/IDBFactory.idl: pass null name as null
2011-05-04 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Entering full screen fails >= second time on Vimeo.com.
https://bugs.webkit.org/show_bug.cgi?id=60143
Force the RenderFullScreen's layer backing to be recreated when setAnimating() is called.
Previously, the RenderLayerCompositor would fail to reparent the RenderFullScreen's layer
at the end of an animation, if it determined that the RenderFullScreen would still require
a layer even when not animating.
* rendering/RenderFullScreen.cpp:
(RenderFullScreen::setAnimating): Clear the renderer's layer.
2011-05-04 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Avoid allocating a new image buffer in ~CanvasRenderingContext2D()
https://bugs.webkit.org/show_bug.cgi?id=59849
When attempting to unwind the graphics state stack in the
CanvasRenderingContext2D destructor, don't allow HTMLCanvasElement
to create a new ImageBuffer.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::existingDrawingContext):
* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
2011-05-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: expose shadow DOM in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=60160
Test: inspector/elements/shadow-dom.html
* dom/Element.cpp:
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::removeShadowRoot):
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
(WebCore::InspectorDOMAgent::isContainerNode):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.inShadowTree):
(WebInspector.DOMNode.prototype._setShadowRootPayload):
(WebInspector.DOMNode.prototype._renumber):
(WebInspector.DOMAgent.prototype._bindNodes):
(WebInspector.DOMAgent.prototype.querySelectorAll):
(WebInspector.DOMAgent.prototype._shadowRootUpdated):
(WebInspector.DOMDispatcher.prototype.searchResults):
(WebInspector.DOMDispatcher.prototype.shadowRootUpdated):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._nodeUpdated):
(WebInspector.ElementsPanel.prototype._attributesUpdated):
(WebInspector.ElementsPanel.prototype._nodeRemoved):
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement):
(WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
():
* inspector/front-end/inspector.css:
(#elements-content .dom-shadow-root):
(.outline-disclosure li .webkit-html-tag.shadow):
* inspector/front-end/utilities.js:
2011-05-03 Adam Roben <aroben@apple.com>
Remove an unnecessary OwnPtr equality check in XSLT code
Fixes <http://webkit.org/b/60053> Testing OwnPtrs for equality should cause a compiler error
Reviewed by Anders Carlsson and Antti Koivisto.
* dom/Document.cpp:
(WebCore::Document::setTransformSource): No need to check for equality. If the pointers are
equal, we're screwed anyway. (And the caller always passes in a newly-allocated object, so
we're safe.)
2011-05-04 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Tony Gentilcore.
Media Stream API: add the skeleton of the frame and page controllers and the embedder client.
https://bugs.webkit.org/show_bug.cgi?id=56922
Add the basic outlines of the page controller, the per-frame controller and the embedder
client interface for the Media Stream API. Provide methods to handle the situations
where a frame is detached from the page or transferred between pages.
Tests for the Media Stream API will be provided by the bug 56587.
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::~Frame):
(WebCore::Frame::pageDestroyed):
(WebCore::Frame::transferChildFrameToNewDocument):
* page/Frame.h:
(WebCore::Frame::mediaStreamFrameController):
* page/MediaStreamClient.h: Added.
(WebCore::MediaStreamClient::~MediaStreamClient):
* page/MediaStreamController.cpp: Added.
(WebCore::MediaStreamController::Request::Request):
(WebCore::MediaStreamController::Request::localId):
(WebCore::MediaStreamController::Request::frameController):
(WebCore::MediaStreamController::MediaStreamController):
(WebCore::MediaStreamController::~MediaStreamController):
(WebCore::MediaStreamController::unregisterFrameController):
(WebCore::MediaStreamController::registerRequest):
* page/MediaStreamController.h: Added.
* page/MediaStreamFrameController.cpp: Added.
(WebCore::MediaStreamFrameController::Request::Request):
(WebCore::MediaStreamFrameController::Request::~Request):
(WebCore::MediaStreamFrameController::Request::scriptExecutionContext):
(WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest):
(WebCore::MediaStreamFrameController::Request::isRecordedDataRequest):
(WebCore::MediaStreamFrameController::RequestMap::abort):
(WebCore::MediaStreamFrameController::RequestMap::abortAll):
(WebCore::MediaStreamFrameController::MediaStreamFrameController):
(WebCore::MediaStreamFrameController::~MediaStreamFrameController):
(WebCore::MediaStreamFrameController::securityOrigin):
(WebCore::MediaStreamFrameController::scriptExecutionContext):
(WebCore::MediaStreamFrameController::pageController):
(WebCore::MediaStreamFrameController::enterDetachedState):
(WebCore::MediaStreamFrameController::disconnectPage):
(WebCore::MediaStreamFrameController::disconnectFrame):
(WebCore::MediaStreamFrameController::transferToNewPage):
* page/MediaStreamFrameController.h: Added.
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):
* page/Page.h:
(WebCore::Page::mediaStreamController):
2011-05-04 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Double-click in a read-only style rule results in a non-editable blank property
https://bugs.webkit.org/show_bug.cgi?id=60150
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
2011-05-04 Dominic Battre <battre@chromium.org>
Reviewed by Tony Gentilcore.
Fix missing header in case SVG is disabled
https://bugs.webkit.org/show_bug.cgi?id=60153
* dom/EventDispatcher.cpp:
2011-05-04 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Rename CSSStyleApplyProperty::propertyValue and setPropertyValue.
https://bugs.webkit.org/show_bug.cgi?id=60006
No new tests as no functionality added. Simple rename only.
* css/CSSStyleApplyProperty.cpp:
Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
* css/CSSStyleApplyProperty.h:
Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
2011-05-04 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Cleanup conditionals in findNextLineBreak
https://bugs.webkit.org/show_bug.cgi?id=60117
Simplified conditional statements in findNextLineBreak.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
2011-05-04 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Make CSSStyleSelector::applyProperty() CSSPropertyWebkitHyphens case use appropriate macro.
https://bugs.webkit.org/show_bug.cgi?id=60114
No new tests as no functionality changes.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to remove code duplication.
2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Fix QNetworkReplyWrapper to not depend on QNetworkReply::isFinished() method
https://bugs.webkit.org/show_bug.cgi?id=59070
Applications using our API and our autotests subclass QNetworkReply as part of providing a
custom QNetworkAccessManager. But there's an API limitation in Qt 4.7, that makes
QNetworkReply::isFinished() always be false for these custom replies. This was fixed in Qt
4.8, see http://bugreports.qt.nokia.com/browse/QTBUG-11737.
The consequence is that QtWebKit cannot rely on this function. So now QNetworkReplyWrapper
watches for the finished() signal and set a dynamic property "_q_isFinished" on the reply
indicating that it is finished. When there's no finished signal (synchronous) we set the
dynamic property once we get the reply.
This fixes tst_QWebFrame::requestedUrl(), that was breaking because sniffer was not
emitting its own finished() signal, causing QWebFrame::loadFinished() to not be emitted.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
Connect the finished signal to the new setFinished() slot.
(WebCore::QNetworkReplyWrapper::synchronousLoad):
Since we don't get the finished signal for synchronous loads, set the dynamic property
before processing it.
(WebCore::QNetworkReplyWrapper::resetConnections):
Do not reset the connection to setFinished().
(WebCore::QNetworkReplyWrapper::setFinished):
Set the dynamic property in the reply.
(WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
(WebCore::QNetworkReplyHandler::start):
Change to use wrapper's isFinished() instead of asking the reply directly.
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyWrapper::isFinished):
Checks the dynamic property of the reply.
* platform/network/qt/QtMIMETypeSniffer.cpp:
(QtMIMETypeSniffer::sniff):
Use the dynamic property to check if the reply is finished.
2011-05-04 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
https://bugs.webkit.org/show_bug.cgi?id=60080
No functional change, just moving code.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxesFromBidiRuns):
(WebCore::RenderBlock::layoutRunsAndFloats):
2011-05-04 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove unused function FontPlatformData::pixelSize()
https://bugs.webkit.org/show_bug.cgi?id=60156
* platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformData::pixelSize): Removed.
2011-05-04 Luke Macpherson <macpherson@chromium.org>
Reviewed by Darin Adler.
Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()
https://bugs.webkit.org/show_bug.cgi?id=60011
No new tests added as no functionality changed.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove reundant check for auto table layout.
2011-05-04 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Adler.
Remove double-free checks for bug 56124
https://bugs.webkit.org/show_bug.cgi?id=60037
Antti's speculative fix for bug 56124 (r84151) appears to have worked,
these CRASH() calls are not triggering anymore.
* css/CSSSelector.h:
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::deleteSelectors):
2011-05-04 Satish Sampath <satish@chromium.org>
Reviewed by Tony Gentilcore.
Layout the speech input button to the left of outer spin button properly.
https://bugs.webkit.org/show_bug.cgi?id=59742
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
2011-05-04 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Build fix.
* bindings/js/JSInjectedScriptHostCustom.cpp: fix includes declaration
2011-05-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: can't inspect element in an iframe when element originates from non-frame document
https://bugs.webkit.org/show_bug.cgi?id=60031
Inspected object type evaluation has moved into native bindings. This way it doesn't
depend on the current JS context.
Test: inspector/elements/elements-inspect-iframe-from-different-domain.html
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::isHTMLAllCollection): this method helps distinguish
real undefined values from HTMLAllCollection
(WebCore::JSInjectedScriptHost::type): method that returns presice type of the passed
value
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
(WebCore::V8InjectedScriptHost::typeCallback):
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
(.):
2011-05-03 Pratik Solanki <psolanki@apple.com>
Reviewed by Antti Koivisto.
Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836
Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one. Clean
up some warnings and #if USE(CFNETWORK) around code.
* platform/mac/CookieJar.mm:
* platform/network/CookieStorage.h:
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::privateBrowsingCookieStorage):
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):
(WebCore::notifyCookiesChangedOnMainThread):
(WebCore::notifyCookiesChanged):
* platform/network/cf/CookieStorageCFNet.h:
* platform/network/mac/CookieStorageMac.mm:
2011-05-03 Justin Novosad <junov@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Make accelerated 2d canvas enabled by default with skia
https://bugs.webkit.org/show_bug.cgi?id=59929
No new tests. Covered by existing layout tests
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
Initialized for accelerated canvas if either the accelerated2dCanvas
or the legacyAccelerated2dCanvas flags are enabled
* page/Page.cpp:
(WebCore::Page::sharedGraphicsContext3D):
This is where the code goes to implement the functionality for the
legacy vs current acceleration paths for the 2D canvas. Currently,
this is a no-op, and always select the legacy path. This is temporary
until we are ready to sort the GPU layout tests (rebasline vs. bug)
* page/Settings.cpp: Added new flage for legacyAccelerated2dCanvas
(WebCore::Settings::Settings):
(WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
* page/Settings.h:
(WebCore::Settings::legacyAccelerated2dCanvasEnabled):
2011-04-29 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Seidel.
Implement FULLSCREEN_API on Windows, Part 4: Enable it
https://bugs.webkit.org/show_bug.cgi?id=59798
* WebCore.vcproj/WebCore.vcproj: Add missing full screen related
files to the project.
2011-05-03 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
More places from 0 to nullptr.
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::precompileScript):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::create):
* platform/graphics/gpu/BicubicShader.cpp:
(WebCore::BicubicShader::create):
* platform/graphics/gpu/ConvolutionShader.cpp:
(WebCore::ConvolutionShader::create):
* platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
(WebCore::LoopBlinnSolidFillShader::create):
* platform/graphics/gpu/SolidFillShader.cpp:
(WebCore::SolidFillShader::create):
* platform/graphics/gpu/TexShader.cpp:
(WebCore::TexShader::create):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::~PlatformContextSkia):
* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::createIterator):
* platform/text/LocalizedNumberICU.cpp:
(WebCore::createFormatterForCurrentLocale):
2011-05-03 Alpha Lam <hclam@chromium.org>
Not reviewed. Build fix.
Using nullptr instead of 0. This makes visual studio happy.
* storage/IDBTransactionBackendInterface.h:
2011-05-03 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Add template parameter to ApplyPropertyColor to improve clarity by removing constructor parameter side effects.
https://bugs.webkit.org/show_bug.cgi?id=59774
No new tests required as on new functionality.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyColor::applyValue):
Added template parameter "inheritColorFromParent = false".
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Use template parameter where appropriate.
2011-05-03 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/9313186> Make the fix for <rdar://problem/9190108> more robust.
Added a pointer from FloatingObject to its originating line, if there is one, and made sure to
dirty the line when the float is removed, instead of relying on the float always intersecting
its originating line.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::clearFloats):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::FloatingObject):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendFloatingObjectToLastLine):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::determineStartPosition):
2011-05-02 Jer Noble <jer.noble@apple.com>
Reviewed by Adam Roben.
Implement FULLSCREEN_API on Windows, Part 3: WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59845
Move WebFullScreenController into WebCore to facilitate code sharing between WebKit
and WebKit2. WebFullScreenController now uses a Client class to request work on its
behalf by WebKit and WebKit2. MediaPlayerPrivateFullscreenWindow now only creates a
CALayerHost once a root layer is set, as the CALayerHost was causing child window drawing
problems, and because a CALayerHost is overkill if the window is only drawing black to
its client area.
* WebCore.vcproj/WebCore.vcproj:
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow): Do not create
m_layerHost in the constructor.
(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): NULL check m_layerHost.
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Lazily instantiate m_layerHost.
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): NULL check m_layerHost; if a root layer is
not present, fill the window with black in WM_PAINT.
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
* platform/graphics/win/FullScreenController.cpp: Renamed from Source/WebKit/win/WebFullScreenController.cpp.
* platform/graphics/win/FullScreenController.h: Renamed from Source/WebKit/win/WebFullScreenController.h.
* platform/graphics/win/FullScreenControllerClient.h: Split out from FullScreenController.h
(WebCore::FullScreenControllerClient::~FullScreenControllerClient):
2011-05-03 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
WK2 Icon Database should provide access to all image representations in the icon.
Add an accessor for CG platforms to get a CFArrayRef of all the CGImageRefs represented:
* platform/graphics/BitmapImage.h:
* platform/graphics/Image.h:
(WebCore::Image::getCGImageArray):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::getCGImageArray):
2011-05-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
findNextLineBreak splits InlineIterator into 3 pieces
https://bugs.webkit.org/show_bug.cgi?id=60082
Avoid splitting InlineIterator into 3 variables with inter-dependencies.
* rendering/InlineIterator.h:
(WebCore::InlineIterator::fastIncrementInTextNode): Added.
(WebCore::InlineIterator::previousInSameNode): Added.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
2011-05-03 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
Interrupted transitions are not correctly removed
https://bugs.webkit.org/show_bug.cgi?id=60062
CompositeAnimation was replacing any existing
transition as a new one was created. However, it wasn't
clearing the lists in AnimationControllerPrivate that
signal when a hardware animation starts. Rather than
simple removing the existing transition, we now tell
AnimationControllerPrivate that is has gone.
Test: transitions/3d/interrupted-transition.html
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
2011-05-03 Enrica Casucci <enrica@apple.com>
Reviewed by Ryosuke Niwa.
Crash in SpellingCorrectionController::respondToChangedSelection.
https://bugs.webkit.org/show_bug.cgi?id=60071
<rdar://problem/9358190>
Creating a Visible position could trigger a layout and there is no
guarantee that the selection is still valid after that.
Tests: editing/selection/undo-crash.html
* editing/SpellingCorrectionController.cpp:
(WebCore::SpellingCorrectionController::respondToChangedSelection):
2011-05-03 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Refactor computeInlineDirectionPositionsForLine into smaller functions
https://bugs.webkit.org/show_bug.cgi?id=60072
Split three functions off from computeInlineDirectionPositionsForLine
to improve its readability.
No new tests since this is just moving code around.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::setMarginsForRubyRun):
(WebCore::setLogicalWidthForTextRun):
(WebCore::computeExpansionForJustifiedText):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
2011-05-03 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
Reviewed by Antti Koivisto.
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest): Set the
priority on the request if HTTP pipelining is enabled.
(WebCore::ResourceRequest::doUpdateResourceRequest): Read the
priority from the request if HTTP pipelining is enabled.
(readBooleanPreference): Enable code when compiling with
USE(CFNETWORK).
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Ditto.
Comment out setting the minimum fast lane priority on Windows
since it's not currently available.
2011-05-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/9278296> Flicker zooming on Google Maps satellite view with accelerated compositing turned on
Conditionalize compositing tiled layer size-constraining logic to older
OSes.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::constrainedSize):
2011-05-03 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Allow access keys to be used in shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=59979
Move access key methods and members back to Document from TreeScope.
Also traverse into shadow trees when building the access key map.
No new tests. (refactoring)
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::getElementByAccessKey):
(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::invalidateAccessKeyMap):
* dom/Document.h:
* dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::destroyTreeScopeData):
* dom/TreeScope.h:
2011-05-03 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
https://bugs.webkit.org/show_bug.cgi?id=60067
No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.
* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
results for flipped writing modes.
2011-05-03 Anton Muhin <antonm@chromium.org>
Reviewed by Yury Semikhatsky.
[v8] remove an ASSERT from grouping logic
https://bugs.webkit.org/show_bug.cgi?id=60024
This ASSERT was exploratory. Alas, right now I am aware of no easy way to
repro it. Removing for now for greener bots.
No new tests, only an ASSERT removal.
* bindings/v8/V8GCController.cpp:
(WebCore::calculateGroupId):
2011-05-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
WebKit allows selection that crosses the shadow boundary of a readonly input element
https://bugs.webkit.org/show_bug.cgi?id=60000
The bug was caused by VisibleSelection's not validating shadow DOM boundaries.
Fixed the bug by adding an extra adjustment, adjustSelectionToAvoidCrossingShadowBoundaries,
in its validation process.
Tests: editing/selection/select-across-readonly-input-1.html
editing/selection/select-across-readonly-input-2.html
editing/selection/select-across-readonly-input-3.html
editing/selection/select-across-readonly-input-4.html
editing/selection/select-across-readonly-input-5.html
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::validate): Calls adjustSelectionToAvoidCrossingShadowBoundaries.
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Added.
* editing/VisibleSelection.h:
2011-05-03 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Split out layoutRunsAndFloats from layoutInlineChildren
https://bugs.webkit.org/show_bug.cgi?id=60052
No new tests, just moving code here. There should be
no change in behavior.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::layoutInlineChildren):
2011-05-03 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
https://bugs.webkit.org/show_bug.cgi?id=59965
Fixes a few bugs leading to a crash if a canvas already being composited was resized to huge dimensions.
Test: fast/canvas/canvas-resize-after-paint.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::reset):
Mark the canvas's layer as needing a synthetic style recalculation when creating or destroying the backing
DrawingBuffer so that we exit compositing mode properly if we can't handle the canvas dimensions.
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::setLayerRenderer):
Add a null check for m_drawingBuffer
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clear):
Avoid clearing the m_context pointer in reset() - we destroy the DrawingBuffer whenever reset() fails, so
this is unnecessary.
2011-05-03 Adam Roben <aroben@apple.com>
Fix most strict PassOwnPtr violations on Windows
Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
enabled
Reviewed by Anders Carlsson.
* loader/EmptyClients.h:
* platform/GeolocationService.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
* platform/mock/GeolocationServiceMock.cpp:
* rendering/RenderTheme.cpp:
* rendering/RenderThemeSafari.cpp:
2011-05-03 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Extract LineInfo class
https://bugs.webkit.org/show_bug.cgi?id=60044
Created a LineInfo class in RenderBlockLineLayout.cpp that brings together the relevant
layout information about a line. This simplifies function signatures and clears up initialization.
No new tests as this is refactoring.
* rendering/RenderBlock.h: Updated internal layout function signatures to use LineInfo.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineInfo::LineInfo):
(WebCore::LineInfo::isFirstLine):
(WebCore::LineInfo::isLastLine):
(WebCore::LineInfo::isEmpty):
(WebCore::LineInfo::previousLineBrokeCleanly):
(WebCore::LineInfo::setFirstLine):
(WebCore::LineInfo::setLastLine):
(WebCore::LineInfo::setEmpty):
(WebCore::LineInfo::setPreviousLineBrokeCleanly):
(WebCore::RenderBlock::createLineBoxes):
(WebCore::RenderBlock::constructLine):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::skipNonBreakingSpace):
(WebCore::shouldCollapseWhiteSpace):
(WebCore::requiresLineBox): Moved from RenderBlock.h and made it locally scoped to RenderBlockLineLayout.cpp
(WebCore::RenderBlock::generatesLineBoxesForInlineChild):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):
2011-05-03 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Update node list cache count on the containing TreeScope rather than the Document
https://bugs.webkit.org/show_bug.cgi?id=59983
Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
Make setDocument() and setDocumentRecursively() private.
No new tests. (refactoring)
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::childrenChanged):
* dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::setDocument):
(WebCore::Node::setTreeScopeRecursively):
(WebCore::Node::childNodes):
(WebCore::Node::registerDynamicNodeList):
(WebCore::Node::unregisterDynamicNodeList):
(WebCore::Node::notifyLocalNodeListsAttributeChanged):
(WebCore::Node::notifyLocalNodeListsChildrenChanged):
(WebCore::Node::getElementsByTagName):
(WebCore::Node::getElementsByTagNameNS):
(WebCore::Node::getElementsByName):
(WebCore::Node::getElementsByClassName):
* dom/Node.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::labels):
2011-05-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Bundle trailingSpaceObject and trailingPositionedBoxes in findNextLineBreak as a class
https://bugs.webkit.org/show_bug.cgi?id=60046
Extracted TrailingObjects that encapsulates trailingSpaceObject and trailingPositionedBoxes.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::TrailingObjects::TrailingObjects):
(WebCore::TrailingObjects::setTrailingWhitespace):
(WebCore::TrailingObjects::clear):
(WebCore::TrailingObjects::appendBoxIfNeeded):
(WebCore::TrailingObjects::addMidpoints):
(WebCore::RenderBlock::findNextLineBreak):
2011-05-03 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Eric Seidel.
[Qt] Implement initial support to DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=58448
Implement initial support to DataTransferItems. DataTransferItems are used to
hold data for drag and drop operations. DataTransferItems hold a list of
DataTransferItem objects each of which holds an item being dragged.
* WebCore.pro:
* dom/DataTransferItems.idl:
* editing/qt/EditorQt.cpp:
(WebCore::Editor::newGeneralClipboard):
* page/qt/EventHandlerQt.cpp:
(WebCore::EventHandler::createDraggingClipboard):
* platform/chromium/DataTransferItemsChromium.h:
* platform/qt/ClipboardQt.cpp:
(WebCore::Clipboard::create):
(WebCore::ClipboardQt::ClipboardQt):
(WebCore::ClipboardQt::items):
* platform/qt/ClipboardQt.h:
(WebCore::ClipboardQt::create):
* platform/qt/DataTransferItemQt.cpp: Added.
(WebCore::DataTransferItem::create):
(WebCore::DataTransferItemQt::createFromPasteboard):
(WebCore::DataTransferItemQt::create):
(WebCore::DataTransferItemQt::DataTransferItemQt):
(WebCore::DataTransferItemQt::getAsString):
(WebCore::DataTransferItemQt::getAsFile):
* platform/qt/DataTransferItemQt.h: Added.
* platform/qt/DataTransferItemsQt.cpp: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
(WebCore::DataTransferItemsQt::create):
(WebCore::DataTransferItemsQt::DataTransferItemsQt):
(WebCore::DataTransferItemsQt::addPasteboardItem):
* platform/qt/DataTransferItemsQt.h: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Dimitri Glazkov.
Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703
No new tests, refactoring only.
* dom/Element.cpp:
(WebCore::Element::copyNonAttributeProperties):
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::insertedIntoTree):
(WebCore::Element::removedFromTree):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::shadowRoot):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::childrenChanged):
* dom/Node.cpp:
(WebCore::Node::setTreeScopeRecursively):
(WebCore::shadowRoot):
(WebCore::Node::setDocumentRecursively):
(WebCore::NodeRendererFactory::findVisualParent):
Updated all the call sites for shadowRoot and ensureShadowRoot in the 2
previous classes.
* dom/Element.h: Updated 2 methods' signature to return a ShadowRoot*.
* dom/ShadowRoot.h: Removed toShadowRoot as it is not used anymore.
* html/HTMLDetailsElement.cpp:
* html/HTMLSummaryElement.cpp:
Added #include for ShadowRoot.h.
2011-05-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Implement mediaSliderTrack
https://bugs.webkit.org/show_bug.cgi?id=59998
Implement paintMediaSliderTrack.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::paintMediaSliderTrack):
* platform/efl/RenderThemeEfl.h:
2011-05-03 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: [Chromium] Fix slowness of Summary view nodes expansion in detailed heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=60023
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.aggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._sortAggregateIndexes):
(WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
(WebInspector.HeapSnapshotFilteredOrderedIterator):
(WebInspector.HeapSnapshotNodesProvider):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.aggregates):
(WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForClass):
2011-05-03 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: [Chromium] Hint user that to display retaining paths, an object entry must be clicked.
https://bugs.webkit.org/show_bug.cgi?id=60029
* English.lproj/localizedStrings.js:
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotRetainingPathsList.prototype.reset):
(WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
2011-05-03 Beth Dakin <bdakin@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=60045
Scrollbar thumb sometimes leaves artifacts in the track after scrolling
-and corresponding-
<rdar://problem/9015376>
When we're using WK_SCROLLBAR_PAINTER, the AppleScrollBarVariant default should
always be ignored.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::updateArrowPlacement):
2011-05-03 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=60040
<rdar://problem/9261591>
Links broken at iplanwebsites.com. Make sure that culledInlineAbsoluteQuads still does
a translation of a 0,0 point to absolute coordinates so that the top left position is
accurate.
Added fast/inline/skipped-whitespace-client-rect.html
* rendering/RenderInline.cpp:
(WebCore::RenderInline::culledInlineAbsoluteQuads):
2011-05-03 Sam Weinig <sam@webkit.org>
Fix chromium build.
* page/Settings.cpp:
2011-05-02 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 59974 - Update image map on the containing TreeScope rather than the Document
https://bugs.webkit.org/show_bug.cgi?id=59974
No new tests. (reefactoring)
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::parseMappedAttribute):
(WebCore::HTMLMapElement::insertedIntoDocument):
(WebCore::HTMLMapElement::removedFromDocument):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageMap):
2011-05-03 Sam Weinig <sam@webkit.org>
Fix chromium build.
* loader/HistoryController.cpp:
2011-05-02 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 59966 - Update ID hash on the containing TreeScope rather than the Document
https://bugs.webkit.org/show_bug.cgi?id=59966
No new tests. (refactoring)
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::elementsFromAttribute):
(WebCore::AccessibilityRenderObject::activeDescendant):
* accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
* css/CSSCursorImageValue.cpp:
(WebCore::resourceReferencedByCursorElement):
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
* dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeList::itemWithName):
* dom/Element.h:
(WebCore::Element::updateId):
* dom/Node.cpp:
(WebCore::Node::querySelector):
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::insertedIntoTree):
(WebCore::FormAssociatedElement::resetFormOwner):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::dataList):
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::control):
* rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::layoutPath):
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
* svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::glyphElement):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::requestImageResource):
(WebCore::SVGFEImageElement::build):
* svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::collectGradientAttributes):
* svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::pathElement):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPatternAttributes):
* svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::collectGradientAttributes):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getElementById):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::updateReferencedText):
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedIntoDocument):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::hasCycleUseReferencing):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
* svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::viewTarget):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::eventBaseFor):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::targetElement):
* xml/XPathFunctions.cpp:
(WebCore::XPath::FunId::evaluate):
2011-05-03 Sam Weinig <sam@webkit.org>
Fix chromium build.
* css/StyleMedia.cpp:
2011-05-03 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Prune #includes from FrameView.h (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=59957
* page/FrameView.h:
Prune #includes.
* accessibility/chromium/AXObjectCacheChromium.cpp:
* page/win/FrameCGWin.cpp:
* platform/Scrollbar.cpp:
Add not necessary #includes.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
Add now necessary forward declaration.
2011-05-03 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE
https://bugs.webkit.org/show_bug.cgi?id=60026
Return a wrapper for Node in toV8(Node*) when called with a node of type
SHADOW_ROOT_NODE instead of entering infinite recursion.
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
2011-05-02 Adam Roben <aroben@apple.com>
Take advantage of implicit conversion from nullptr_t to PassOwnPtr
Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
doesn't work, but should
Reviewed by Adam Barth.
* bindings/js/ScheduledAction.cpp:
* css/CSSStyleSelector.cpp:
* css/MediaList.cpp:
* css/MediaQueryMatcher.cpp:
* css/SVGCSSStyleSelector.cpp:
* dom/MessagePort.cpp:
* html/InputType.cpp:
* html/canvas/WebGLRenderingContext.cpp:
* inspector/InspectorStyleSheet.cpp:
* page/ContextMenuController.cpp:
* page/Page.cpp:
* platform/PlatformGestureRecognizer.cpp:
* platform/PurgeableBuffer.h:
* platform/graphics/ImageBuffer.h:
* platform/leveldb/LevelDBDatabase.cpp:
* platform/mac/PurgeableBufferMac.cpp:
* platform/text/RegularExpression.cpp:
* rendering/RenderTheme.cpp:
* rendering/RenderThemeMac.mm:
* rendering/style/RenderStyle.h:
* rendering/style/SVGRenderStyleDefs.cpp:
* rendering/style/ShadowData.cpp:
* rendering/style/StyleRareInheritedData.cpp:
* rendering/style/StyleRareNonInheritedData.cpp:
* rendering/svg/RenderSVGResourcePattern.cpp:
2011-05-03 Pavel Feldman <pfeldman@google.com>
Not reviewed: fix inspector status bar image glyph reference in network panel.
* inspector/front-end/networkPanel.css:
(.network-larger-resources-status-bar-item .glyph):
2011-05-03 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: rename BrowserDebugger agent to DOMDebugger.
https://bugs.webkit.org/show_bug.cgi?id=60019
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
* inspector/generate-inspector-idl:
2011-05-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove special logic for type of document.__proto__
https://bugs.webkit.org/show_bug.cgi?id=60014
Test: inspector/console/console-log-document-proto.html
* inspector/InjectedScriptSource.js: removed unnecessary check nodeType === undefined
2011-05-03 Pavel Feldman <pfeldman@google.com>
Not reviewed: fixed typo in inspector style.
* inspector/front-end/inspector.css:
(.status-bar-item > .glyph):
2011-05-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: revision history storage is too slow.
https://bugs.webkit.org/show_bug.cgi?id=59939
It turns out that iterating localStorage keys is very
expensive (results in slow inspector start), refactor revision
history in order not to rely upon that operation.
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource._resourceRevisionRegistry):
(WebInspector.Resource.restoreRevisions.persist):
(WebInspector.Resource.restoreRevisions):
(WebInspector.Resource.persistRevision):
(WebInspector.Resource.prototype._persistRevision):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
2011-05-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: combine toolbar icon images.
https://bugs.webkit.org/show_bug.cgi?id=59931
* WebCore.gypi:
* inspector/front-end/Images/auditsIcon.png: Removed.
* inspector/front-end/Images/consoleIcon.png: Removed.
* inspector/front-end/Images/elementsIcon.png: Removed.
* inspector/front-end/Images/networkIcon.png: Removed.
* inspector/front-end/Images/profilesIcon.png: Removed.
* inspector/front-end/Images/resourcesIcon.png: Removed.
* inspector/front-end/Images/scriptsIcon.png: Removed.
* inspector/front-end/Images/timelineIcon.png: Removed.
* inspector/front-end/Images/toolbarIcons.png: Added.
* inspector/front-end/Images/toolbarIconsSmall.png: Added.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.toolbar-icon):
(#toolbar-dropdown .toolbar-icon):
(.toolbar-item:active .toolbar-icon):
(#toolbar-dropdown .toolbar-item:active .toolbar-icon):
(.toolbar-item.elements .toolbar-icon):
(.toolbar-item.resources .toolbar-icon):
(#toolbar-dropdown .toolbar-item.resources .toolbar-icon):
(.toolbar-item.network .toolbar-icon):
(#toolbar-dropdown .toolbar-item.network .toolbar-icon):
(.toolbar-item.scripts .toolbar-icon):
(#toolbar-dropdown .toolbar-item.scripts .toolbar-icon):
(.toolbar-item.timeline .toolbar-icon):
(#toolbar-dropdown .toolbar-item.timeline .toolbar-icon):
(.toolbar-item.profiles .toolbar-icon):
(#toolbar-dropdown .toolbar-item.profiles .toolbar-icon):
(.toolbar-item.audits .toolbar-icon):
(#toolbar-dropdown .toolbar-item.audits .toolbar-icon):
(.toolbar-item.console .toolbar-icon):
(#toolbar-dropdown .toolbar-item.console .toolbar-icon):
(.status-bar-item > .glyph):
2011-05-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: combine status bar button glyphs.
https://bugs.webkit.org/show_bug.cgi?id=59885
* WebCore.gypi:
* inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Removed.
* inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Removed.
* inspector/front-end/Images/clearConsoleButtonGlyph.png: Removed.
* inspector/front-end/Images/consoleButtonGlyph.png: Removed.
* inspector/front-end/Images/dockButtonGlyph.png: Removed.
* inspector/front-end/Images/enableOutlineButtonGlyph.png: Removed.
* inspector/front-end/Images/enableSolidButtonGlyph.png: Removed.
* inspector/front-end/Images/excludeButtonGlyph.png: Removed.
* inspector/front-end/Images/focusButtonGlyph.png: Removed.
* inspector/front-end/Images/garbageCollectButtonGlyph.png: Removed.
* inspector/front-end/Images/gearButtonGlyph.png: Removed.
* inspector/front-end/Images/helpButtonGlyph.png: Removed.
* inspector/front-end/Images/largerResourcesButtonGlyph.png: Removed.
* inspector/front-end/Images/nodeSearchButtonGlyph.png: Removed.
* inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Removed.
* inspector/front-end/Images/percentButtonGlyph.png: Removed.
* inspector/front-end/Images/prettyPrintButtonGlyph.png: Removed.
* inspector/front-end/Images/recordButtonGlyph.png: Removed.
* inspector/front-end/Images/recordToggledButtonGlyph.png: Removed.
* inspector/front-end/Images/reloadButtonGlyph.png: Removed.
* inspector/front-end/Images/statusBarButtonGlyphs.png: Added.
* inspector/front-end/Images/undockButtonGlyph.png: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.status-bar-item > .glyph):
(#dock-status-bar-item .glyph):
(body.detached #dock-status-bar-item .glyph):
(#console-status-bar-item .glyph):
(.clear-status-bar-item .glyph):
(button.enable-toggle-status-bar-item .glyph):
(button.enable-toggle-status-bar-item.toggled-on .glyph):
(.scripts-pause-on-exceptions-status-bar-item .glyph):
(.scripts-toggle-pretty-print-status-bar-item .glyph):
(.toggle-breakpoints .glyph):
(.toggle-breakpoints.toggled-on .glyph):
(.resources-larger-resources-status-bar-item .glyph):
(.timeline-filter-status-bar-item .glyph):
(.garbage-collect-status-bar-item .glyph):
(.record-profile-status-bar-item .glyph):
(.record-profile-status-bar-item.toggled-on .glyph):
(.heap-snapshot-status-bar-item .glyph):
(.node-search-status-bar-item .glyph):
(.percent-time-status-bar-item .glyph):
(.focus-profile-node-status-bar-item .glyph):
(.exclude-profile-node-status-bar-item .glyph):
(.reset-profile-status-bar-item .glyph):
(.delete-storage-status-bar-item .glyph):
(.refresh-storage-status-bar-item .glyph):
* inspector/front-end/inspector.js:
2011-05-02 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Possible crash when removing elements with reflections
https://bugs.webkit.org/show_bug.cgi?id=60009
RenderLayer's destructor deleted its z-order list Vector pointers
before removing the reflection layer. However, the reflection cleanup
code could call back into the RenderLayer to dirty z-order lists,
so move reflection cleanup to before z-order vector deletion.
The test crashes when run manually a few times with MallocScribble enabled,
but I was not able to create a test that crashed reliably.
Test: fast/reflections/remove-reflection-crash.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::~RenderLayer):
2011-05-02 Ian Henderson <ianh@apple.com>
Reviewed by Dan Bernstein.
CSS !important not respected by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=60007
The addParsedProperty and addParsedProperties methods were subtly
different. The former did not check for !important before setting the
given property.
Change addParsedProperties to call addParsedProperty and move the
relevant code. The one other caller of this method, in
editing/markup.cpp, probably wanted this behavior anyway.
Test: fast/css/important-js-override.html
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::addParsedProperties):
(WebCore::CSSMutableStyleDeclaration::addParsedProperty):
2011-05-02 Ben Wells <benwells@chromium.org>
Reviewed by Simon Fraser.
Cleanup variable usage in RenderObject.cpp paintOutline()
https://bugs.webkit.org/show_bug.cgi?id=59911
No new tests for this, there should be no change in behaviour.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintOutline):
2011-05-02 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by James Robinson.
REGRESSION(r84672): showTree doesn't work for input/textarea elements
https://bugs.webkit.org/show_bug.cgi?id=60001
When shadow is null, try retrieving the inner element of a render text control.
* dom/Node.cpp:
(WebCore::traverseTreeAndMark):
2011-05-02 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by David Kilzer.
Respect fixed text-indent on ::-webkit-input-placeholder
https://bugs.webkit.org/show_bug.cgi?id=59825
Test: fast/forms/input-placeholder-text-indent.html
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::paintPlaceholder): indent by
a fixed text-indent size specified on the placeholder style.
2011-05-02 Eric Uhrhane <ericu@chromium.org>
Reviewed by Eric Seidel.
Some FileWriter progress events should be queued
https://bugs.webkit.org/show_bug.cgi?id=50846
* fileapi/FileWriter.cpp:
* fileapi/FileWriter.h:
Create a new asynchronous Task [FileWriterCompletionEventTask] that will set readyState to DONE and fire off the right events.
2011-05-02 Jia Pu <jpu@apple.com>
Reviewed by Alexey Proskuryakov.
[Mac] Need to truncate the string sent to "Look Up … " menu item, if it's too long.
https://bugs.webkit.org/show_bug.cgi?id=59836
<rdar://problem/9275983>
* platform/DefaultLocalizationStrategy.cpp:
(WebCore::truncatedStringForLookupMenuItem):
(WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
2011-05-02 Brady Eidson <beidson@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
In Aperture, a WebView might be dealloc'ed before it finishes loading.
* WebCore.exp.in:
* platform/RuntimeApplicationChecks.cpp:
(WebCore::applicationIsAperture): Perform a com.apple.Aperture bundle check.
* platform/RuntimeApplicationChecks.h:
2011-05-02 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Avoid wasted cycles updating paths when popping the context stack
https://bugs.webkit.org/show_bug.cgi?id=59967
CanvasRenderingContext2D has to map the current path through
transforms whenever the context stack is popped, which creates
a lot of platform path objects. Avoid extra work here when the
path is empty, or when the transform is identity.
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::transform):
2011-05-02 Enrica Casucci <enrica@apple.com>
Reviewed by Dan Bernstein.
Text does not split on white space when typing to the edge of window.
https://bugs.webkit.org/show_bug.cgi?id=59968
<rdar://problem/9112683>
Test: editing/inserting/typing-at-end-of-line.html
This is a regression introduced when we converted the line box tree to
floating point in r78846. In findNextLineBreak, there was still one place where
the character width was treated as int and truncated and we were inconsistent
in the way we treated a character that did not fit entirely in the line.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
2011-04-19 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Don't unnecessarily resize skia/cg canvases when painting in compositor
https://bugs.webkit.org/show_bug.cgi?id=58907
Additionally, move the context save/restore logic to a place where it
will reset the translation added in LayerTilerChromium.
Test: compositing/repaint/same-size-invalidation.html
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerPainter::paint):
* platform/graphics/chromium/PlatformCanvas.cpp:
(WebCore::PlatformCanvas::resize):
(WebCore::PlatformCanvas::Painter::Painter):
(WebCore::PlatformCanvas::Painter::~Painter):
* platform/graphics/chromium/PlatformCanvas.h:
2011-05-02 Csaba Osztrogonác <ossy@webkit.org>
Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667
Unreviewed buildfix after r85343.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
2011-05-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r85483.
http://trac.webkit.org/changeset/85483
https://bugs.webkit.org/show_bug.cgi?id=59958
Causes media test failures. (Requested by eric_carlson on
#webkit).
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::seek):
(WebCore::HTMLMediaElement::updatePlayState):
* html/HTMLMediaElement.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::resumeLoad):
(WebCore::MediaPlayerPrivateAVFoundation::load):
(WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay):
(WebCore::MediaPlayerPrivateAVFoundation::paint):
(WebCore::MediaPlayerPrivateAVFoundation::duration):
(WebCore::MediaPlayerPrivateAVFoundation::seeking):
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):
(WebCore::MediaPlayerPrivateAVFoundation::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded):
(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged):
(WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
(WebCore::MediaPlayerPrivateAVFoundation::repaint):
(WebCore::MediaPlayerPrivateAVFoundation::setPreload):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::videoLayerIsReadyToDisplay):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59924
* css/CSSGrammar.y:
* platform/graphics/mac/SimpleFontDataMac.mm:
- Memory management for the font cache is somewhat... complext.
This will require some careful thought to sort out.
2011-05-02 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
showLineTree/showLineTreeForThis would make working with the line box tree easier
https://bugs.webkit.org/show_bug.cgi?id=59662
Adding a showLineTree/showLineTreeForThis method to help visualize and debug
the line tree. Also adding a missing showRenderTreeForThis method to RenderObject.
No new tests since this is a debugging feature only and not compiled in release.
* rendering/InlineBox.cpp:
(WebCore::InlineBox::showLineTreeForThis):
(WebCore::InlineBox::showLineTreeAndMark):
(WebCore::InlineBox::showBox):
(showLineTree):
* rendering/InlineBox.h:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::showLineTreeAndMark):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::showBox):
* rendering/InlineTextBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::showLineTreeAndMark):
* rendering/RenderBlock.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::showRenderTreeForThis):
(WebCore::RenderObject::showLineTreeForThis):
(showTree):
(showLineTree):
* rendering/RenderObject.h:
2011-05-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
REGRESSIONS (r71934): In standalone media documents, (double-)clicking the media element doesn’t play/pause
https://bugs.webkit.org/show_bug.cgi?id=59917
Since default event handlers are not retargeted, we should always attempt ancestor
traversal to find out whether the event.
* html/MediaDocument.cpp:
(WebCore::ancestorVideoElement): Added ancestor-traversing helper.
(WebCore::MediaDocument::defaultEventHandler): Changed to use ancestorVideoElement.
2011-05-02 Sam Weinig <sam@webkit.org>
Attempt to fix the Leopard build.
* platform/graphics/FontPlatformData.h:
* platform/graphics/mac/ComplexTextController.h:
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
* platform/mac/WebCoreSystemInterface.h:
2011-05-02 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
convert manual-tests/bugzilla-6821.html to a layout test
https://bugs.webkit.org/show_bug.cgi?id=59404
Test: fast/css/hover-update.html
* manual-tests/bugzilla-6821.html: Removed.
2011-05-02 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Prune ApplicationServices.h out of the headers
https://bugs.webkit.org/show_bug.cgi?id=59952
More forward declares are better.
* html/canvas/CanvasRenderingContext2D.cpp:
* html/canvas/CanvasRenderingContext2D.h:
* platform/graphics/GlyphBuffer.h:
* platform/graphics/cg/ImageBufferCG.cpp:
* platform/graphics/cg/PDFDocumentImage.cpp:
* platform/graphics/cg/PDFDocumentImage.h:
* platform/graphics/mac/ComplexTextController.h:
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
* platform/mac/WebCoreNSStringExtras.h:
* platform/mac/WebCoreSystemInterface.h:
2011-05-02 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7972529> Images with percentage based height/max-height are missing when they are inside blocks inside tables
https://bugs.webkit.org/show_bug.cgi?id=58006
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Expanded the scope of the fix for
<http://webkit.org/b/15359> from r29039 to cover not just the case of a auto-or-percent-height
table cell as the immediate containing block, but any case where all containing block ancestors
up to and including a table cell are auto-or-percent height.
2011-05-02 Daniel Bates <dbates@webkit.org>
Reviewed by Sam Weinig.
Convert manual test onblur-remove.html to a DRT test; onblur-remove.html fails
https://bugs.webkit.org/show_bug.cgi?id=59379
Move manual test onblur-remove.html to LayoutTests/fast/events.
Test: fast/events/onblur-remove.html
* manual-tests/onblur-remove.html: Removed.
2011-05-02 Sailesh Agrawal <sail@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium Mac: Add scrollbar overlay drawing functions
https://bugs.webkit.org/show_bug.cgi?id=59741
These functions are simply copied from WebCoreSystemInterface. These will be used to implement overlay scrollbars for Chromium Mac.
No new tests, since this code is only enabled on future versions of Mac OS X.
* WebCore.gypi:
* platform/chromium/ScrollbarOverlayUtilitiesMac.h: Added.
* platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Added.
(LookUpNSScrollerImpClass):
(LookUpNSScrollerImpPairClass):
(ScrollbarControlSizeToNSControlSize):
(wkScrollbarPainterUsesOverlayScrollers):
(wkScrollbarPainterIsHorizontal):
(wkScrollbarPainterKnobAlpha):
(wkScrollbarPainterSetOverlayState):
(wkScrollbarPainterPaint):
(wkScrollbarMinimumThumbLength):
(wkScrollbarPainterSetDelegate):
(wkScrollbarPainterTrackAlpha):
(wkMakeScrollbarPainter):
(wkScrollbarThickness):
(wkScrollbarMinimumTotalLengthNeededForThumb):
(wkVerticalScrollbarPainterForController):
(wkHorizontalScrollbarPainterForController):
(wkMakeScrollbarReplacementPainter):
(wkSetPainterForPainterController):
(wkSetScrollbarPainterControllerStyle):
(wkScrollbarPainterKnobRect):
(wkSetScrollbarPainterKnobAlpha):
(wkSetScrollbarPainterTrackAlpha):
(wkSetScrollbarPainterKnobStyle):
(wkMakeScrollbarPainterController):
(wkContentAreaScrolled):
(wkContentAreaWillPaint):
(wkMouseEnteredContentArea):
(wkMouseExitedContentArea):
(wkMouseMovedInContentArea):
(wkWillStartLiveResize):
(wkContentAreaResized):
(wkWillEndLiveResize):
(wkContentAreaDidShow):
(wkContentAreaDidHide):
(wkDidBeginScrollGesture):
(wkDidEndScrollGesture):
(wkScrollbarPainterForceFlashScrollers):
(IsScrollbarOverlayAPIAvailable):
2011-05-02 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Implement Length based CSS properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=59314
No new tests as no functionality changed.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::ApplyPropertyLength):
Added this class to handle all length types.
Property specific behavior is handled through set of boolean parameters.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Added calls to set up entries for the newly added length properties.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove property implementations mow implemented in CSSStyleApplyProperty.
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::rootElementStyle):
Expose m_rootElementStyle via getter.
2011-05-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
HTMLMediaElement should not seek to time 0 when readyState reaches HAVE_METADATA
https://bugs.webkit.org/show_bug.cgi?id=59828
No new tests required, no functional change because seeking to time zero before playback
begins has no effect.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setReadyState): Don't seek to time 0 when readyState reaches
HAVE_METADATA.
2011-05-02 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Fix extra whitespace in license in FocusDirection.h.
* page/FocusDirection.h:
2011-05-02 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Prune some #includes from DOMWindow.h
https://bugs.webkit.org/show_bug.cgi?id=59907
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setSecurityOrigin):
* page/DOMWindow.h:
Remove #includes of SecurityOrigin and MessagePort by forward declaring
and moving the SecurityOrigin setter to the .cpp file. Also adds EventTarget
#include that was getting added by MessagePort.h.
* bindings/js/JSCustomVoidCallback.cpp:
* bindings/js/JSCustomXPathNSResolver.cpp:
* bindings/js/JSDOMWindowCustom.h:
* bindings/js/JSHistoryCustom.cpp:
* bindings/js/ScriptController.h:
* html/HTMLAnchorElement.cpp:
* html/HTMLMediaElement.cpp:
* html/parser/XSSFilter.cpp:
* inspector/InspectorDOMStorageResource.cpp:
* loader/MainResourceLoader.cpp:
* page/DragController.cpp:
* page/EventSource.cpp:
* page/Location.cpp:
* websockets/WebSocket.cpp:
* xml/XSLTProcessorLibxslt.cpp:
Add now missing SecurityOrigin.h #includes.
2011-05-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Brady Eidson.
The preload attribute of the video tag is not completely implemented
https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/7508322>
Tested manually with manual-tests/media-elements/video-preload.html.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay.
(WebCore::HTMLMediaElement::prepareForLoad): Ditto.
(WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play.
(WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'metadata'
because we need to have media data loaded to seek.
(WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
* html/HTMLMediaElement.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Remove
m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
(WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
(WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn.
Move all preload logic to setPreload, call it from here.
(WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to
setPreload, call it.
(WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
unlikely to be correct and isn't worth caching.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
to AssetStatus. Create the AVPlayer once we know an asset is playable but preload is
'metadata'. Set networkState to 'idle' when the playback buffer is full because that is
a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA'
when the first frame is available.
(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
width, height, hasVideo, etc.
(WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
in derived classes.
(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
AVAsset and AVPlayerItem here.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
if we have painted a frame to the context.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
if necessary.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
the buffer is full.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
when we only have metadata.
(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
when when we haven't allocated the AVPlayerItem yet so that we can report attributes
when we only have metadata.
(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
we have allocated the AVPlayerItem.
2011-05-02 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] gdk_drawable_get_size() shouldn't be used with GTK+ >= 2.24
https://bugs.webkit.org/show_bug.cgi?id=59932
Use gdk_window_get_width() and gdk_window_get_height() if
available, instead of the deprecated gdk_drawable_get_size().
No new tests, build fix only.
* platform/gtk/WidgetRenderingContext.cpp:
(WebCore::WidgetRenderingContext::WidgetRenderingContext):
2011-05-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Brady Eidson.
The preload attribute of the video tag is not completely implemented
https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/7508322>
Test manually with manual-tests/media-elements/video-preload.html.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Add new "limit read-ahead"
attribute when preload is not "auto".
(WebCore::MediaPlayerPrivateQTKit::resumeLoad): Remove m_delayingLoad, we don't need it.
(WebCore::MediaPlayerPrivateQTKit::load): Correct comment.
(WebCore::MediaPlayerPrivateQTKit::prepareToPlay): Call setPreload('auto').
(WebCore::MediaPlayerPrivateQTKit::setPreload): Set new attribue if we already have
a QTMovie.
2011-05-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Brady Eidson.
The preload attribute of the video tag is not completely implemented
https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/7508322>
Manual test manual-tests/media-elements/video-preload.html added.
* manual-tests/media-elements/video-preload.html: Added. New manual test for media element
'preload' attribute because it is not possible to detect if a media engine supports
"preload=metadata" in a way that lets us have per-platform layout test results.
2011-05-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Carlson.
Regression(r74787): Media document mouse click and double-click
events should be checked on target node only and not its descendants.
https://bugs.webkit.org/show_bug.cgi?id=59886
* html/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Polish CSP host and port matching
https://bugs.webkit.org/show_bug.cgi?id=59899
Finish last two details of host and port matching. I don't think the
default port handling is testable with our current testing
infrastructure.
Tests: http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html
http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPSource::hostMatches):
(WebCore::CSPSource::portMatches):
2011-05-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP default-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58641
Add support for default-src. The default-src provides a default policy
for every directive that sends in "-src". If the more-specific
directive is present, it takes precedence. I also took this
opportunity to refactor the internals of ContentSecurityPolicy a bit to
reduce duplicate code.
Tests: http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html
http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html
http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::checkEval):
(WebCore::ContentSecurityPolicy::operativeDirective):
(WebCore::ContentSecurityPolicy::checkInlineAndReportViolation):
(WebCore::ContentSecurityPolicy::checkEvalAndReportViolation):
(WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
2011-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Prune some unnecessary #includes
https://bugs.webkit.org/show_bug.cgi?id=59895
Start getting rid of unnecessary #includes and forward declares.
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowShell.h:
* bindings/js/ScheduledAction.cpp:
* bindings/js/ScriptController.cpp:
* bindings/js/ScriptController.h:
* bindings/js/ScriptDebugServer.cpp:
* editing/Editor.h:
* inspector/InspectorClient.cpp:
* loader/FrameLoader.h:
* loader/NavigationScheduler.h:
* page/Console.cpp:
* xml/XMLTreeViewer.cpp:
* xml/XMLTreeViewer.h:
2011-05-01 Patrick Gansterer <paroga@webkit.org>
[WIN] Unreviewed buildfix after r85434.
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::createLayerForMovie):
2011-05-01 Patrick Gansterer <paroga@webkit.org>
[WIN] Unreviewed buildfix after r85434.
* platform/graphics/win/QTMovieVisualContext.cpp:
(QTMovieVisualContext::QTMovieVisualContext): Added missing header.
2011-05-01 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
History::stateObjectAdded should check origin via SecurityOrigin::canRequest
https://bugs.webkit.org/show_bug.cgi?id=59840
Tests: fast/loader/stateobjects/pushstate-in-data-url-denied.html
http/tests/navigation/replacestate-base-illegal.html
http/tests/navigation/replacestate-base-legal.html
* page/History.cpp:
(WebCore::History::stateObjectAdded):
2011-05-01 Patrick Gansterer <paroga@webkit.org>
[WIN] Unreviewed buildfix after r85434.
* platform/graphics/win/QTMovieVisualContext.cpp:
(QTMovieVisualContext::QTMovieVisualContext):
2011-05-01 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
[WINCE] Fix OwnPtr strict issues
https://bugs.webkit.org/show_bug.cgi?id=59898
* page/wince/FrameWinCE.cpp:
(WebCore::imageFromSelection):
* platform/graphics/wince/FontPlatformData.cpp:
(WebCore::FixedSizeFontData::create):
(WebCore::FontPlatformPrivateData::FontPlatformData::hfont):
(WebCore::FontPlatformPrivateData::FontPlatformData::getScaledFontHandle):
(WebCore::FontPlatformPrivateData::FontPlatformData::discardFontHandle):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::drawRoundCorner):
(WebCore::GraphicsContext::drawText):
* platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/wince/ImageWinCE.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
* platform/graphics/wince/SharedBitmap.cpp:
(WebCore::SharedBitmap::SharedBitmap):
2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
https://bugs.webkit.org/show_bug.cgi?id=59837
Removed EventHandler::sendContextMenuEvent(NSEvent*) and EventHandler::eventMayStartDrag(NSEvent*)
* WebCore.exp.in:
* page/EventHandler.h:
* page/mac/EventHandlerMac.mm:
2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
https://bugs.webkit.org/show_bug.cgi?id=59835
Moved currentKeyboardEvent.
* WebCore.exp.in:
* page/EventHandler.h:
* page/mac/EventHandlerMac.mm:
2011-05-01 ojab <ojab@ojab.ru>
Reviewed by Eric Seidel.
Fix build with --disable-video --enable-fullscreen-api
https://bugs.webkit.org/show_bug.cgi?id=59698
* rendering/RenderTheme.h:
(WebCore::RenderTheme::extraFullScreenStyleSheet):
2011-05-01 Jeff Timanus <twiz@chromium.org>
Reviewed by Eric Seidel.
Add solid-color checking to BitmapImage::checkForSolidColour in the skia port.
https://bugs.webkit.org/show_bug.cgi?id=59041
Test:css2.1/t140201-c533-bgimage-00-a.html
* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled): Removal of macro exclusion of assert for Skia path.
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImage::checkForSolidColor):
2011-05-01 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Fix OwnPtr strict issues in windows build
https://bugs.webkit.org/show_bug.cgi?id=59878
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::getDirtyRects):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
* platform/graphics/win/WKCAImageQueue.cpp:
(WebCore::WKCAImageQueue::WKCAImageQueue):
* platform/win/CursorWin.cpp:
(WebCore::createSharedCursor):
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage):
2011-05-01 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Use PassOwnPtr as return value of GraphicsContext::createWindowsBitmap
https://bugs.webkit.org/show_bug.cgi?id=59876
Also pass the size "as reference" instead of "as value".
* platform/graphics/GraphicsContext.h:
* platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap):
(WebCore::GraphicsContext::createWindowsBitmap):
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::paint):
2011-05-01 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
getComputedStyle() returns unitless values for some properties that require units
https://bugs.webkit.org/show_bug.cgi?id=55111
Change getComputedStyle to return value with unit for -webkit-column-width, -webkit-column-gap and -webkit-perspective
Test: fast/css/getComputedStyle/getComputedStyle-length-unit.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2011-05-01 Young Han Lee <joybro@company100.net>
Reviewed by Eric Seidel.
Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
https://bugs.webkit.org/show_bug.cgi?id=59608
TEXMAP_OPENGL_ES2 is a wrong name. TEXMAP_OPENGL_ES_2 is already defined in TextureMapper.h
No new functionality, no new tests.
* platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::TextureMapperGL):
2011-05-01 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
CSS3 nth-child(n) selector fails
https://bugs.webkit.org/show_bug.cgi?id=56943
Regression from r75158.
"n" is a valid parameter to nth() and should be allowed.
Test: fast/css/nth-child-n.html
* css/CSSParser.cpp:
(WebCore::isValidNthToken):
2011-05-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: address stack frame scriptName -> url rename in timeline panel.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
2011-05-01 Chris Fleizach <cfleizach@apple.com>
Reviewed by Maciej Stachowiak.
Crash in AccessibilityRenderObject while viewing PDFs in iframes
https://bugs.webkit.org/show_bug.cgi?id=59629
Could not reproduce this crash, but it's quite clear how it could happen.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
2011-05-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
LEAK: SVGElement leaks when detaching it in a pending resource state
https://bugs.webkit.org/show_bug.cgi?id=59072
Make the pending resources set non-refcounted again. We made it refcounted a while ago
to fix a security bug, as we had dangling pointers in the set in SVGDocumentExtensions.
Fix the underlying problem, by removing all pending resources referencing to a particular
SVGElement, upon its destruction or upon removing it from the document.
Example: <rect fill="url(#foo)" id="rect">
When we try to render the rect, the foo paint server can't be found and thus "foo" will be
added to the pending resource set, with "rect" as client. When "foo" appears, it would remove
itself from the pending resource set, and a ref count to the "rect" would be released.
If "foo" never appears, SVGDocumentExtensions still holds a ref to the <rect>, thus keeping
it and the associated document alive.
Tests: svg/custom/pending-resource-leak-2.svg
svg/custom/pending-resource-leak-3.svg
svg/custom/pending-resource-leak.svg
These tests cover several scenarios where we used to leak. Should fix several SVG*Element leaks on the bots.
I manually tested reloading above testcases dozens of times, before the leak count was incremented by 2 nodes on every reload, that's gone now.
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::registerResource):
* rendering/svg/RenderSVGShadowTreeRootContainer.cpp:
(WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
* rendering/svg/SVGResources.cpp:
(WebCore::registerPendingResource):
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::hasPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removePendingResource):
* svg/SVGDocumentExtensions.h:
* svg/SVGElement.cpp:
* svg/SVGElement.h:
* svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::SVGElementRareData):
(WebCore::SVGElementRareData::hasPendingResources):
(WebCore::SVGElementRareData::setHasPendingResources):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::~SVGStyledElement):
(WebCore::SVGStyledElement::insertedIntoDocument):
(WebCore::SVGStyledElement::removedFromDocument):
(WebCore::SVGStyledElement::hasPendingResources):
(WebCore::SVGStyledElement::setHasPendingResources):
* svg/SVGStyledElement.h:
(WebCore::SVGStyledElement::needsPendingResourceHandling):
(WebCore::SVGStyledElement::buildPendingResource):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::buildPendingResource):
* svg/SVGUseElement.h:
2011-05-01 Rafael Brandao <rafael.lobo@openbossa.org>
Reviewed by Csaba Osztrogonác.
[Qt] build-webkit warning Inspector.idl is missing
https://bugs.webkit.org/show_bug.cgi?id=59047
Added variable_out to pipe output from one compiler to another,
and then forced the output to be added to the sources.
* CodeGenerators.pri:
2011-05-01 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/9155067> REGRESSION (float-based line boxes): Gaps and overlaps in selection highlight
https://bugs.webkit.org/show_bug.cgi?id=56658
Test: fast/text/selection-rect-rounding.html
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::selectionRectForSimpleText): Account for non-integral anchor point coordinates.
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::selectionRectForComplexText): Ditto.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect): Floor the horizontal sides of the clip rect.
(WebCore::InlineTextBox::paintSelection): Pass the logical left location to Font::selectionRectForText(),
since it affects rounding.
2011-04-30 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Make RenderSVGResourceFilter take ownership of filter data when painting
https://bugs.webkit.org/show_bug.cgi?id=51524
Test: svg/custom/filter-on-svgimage.svg
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::removeClientFromCache):
(WebCore::RenderSVGResourceFilter::postApplyResource):
* rendering/svg/RenderSVGResourceFilter.h:
(WebCore::FilterData::FilterData):
2011-04-30 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Barth.
Enable strict mode for OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59428
Fix assignments and .set() calls with OwnPtr to use adoptPtr. Have GeolocationService
factory methods return a PassOwnPtr.
No new tests. This should not change functionality.
* platform/GeolocationService.cpp:
(WebCore::createGeolocationServiceNull):
(WebCore::GeolocationService::create):
* platform/GeolocationService.h:
* platform/android/GeolocationServiceAndroid.cpp:
(WebCore::GeolocationServiceAndroid::create):
* platform/android/GeolocationServiceAndroid.h:
* platform/efl/GeolocationServiceEfl.cpp:
(WebCore::GeolocationServiceEfl::create):
* platform/efl/GeolocationServiceEfl.h:
* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::appendPathToCairoContext):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawPathShadow):
(WebCore::GraphicsContext::clip):
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/cairo/OwnPtrCairo.h:
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::Path):
(WebCore::Path::operator=):
(WebCore::Path::apply):
* platform/gtk/GeolocationServiceGtk.cpp:
(WebCore::GeolocationServiceGtk::create):
* platform/gtk/GeolocationServiceGtk.h:
* platform/mock/GeolocationServiceMock.cpp:
(WebCore::GeolocationServiceMock::create):
* platform/mock/GeolocationServiceMock.h:
2011-04-30 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: inspector toolbar titles were 2px off.
* inspector/front-end/inspector.css:
(#toolbar-dropdown .toolbar-label):
2011-04-30 Mihai Parparita <mihaip@chromium.org>
Reviewed by Eric Seidel.
V8Proxy.h shouldn't include SecurityOrigin.h
https://bugs.webkit.org/show_bug.cgi?id=59859
Remove SecurityOrigin.h #include from V8Proxy.h. Touching
SecurityOrigin.h now rebuilds 234 targets instead of 638 (when building
chromium's DumpRenderTree).
* bindings/v8/NPV8Object.cpp:
* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:
* css/CSSStyleSelector.cpp:
* dom/XMLDocumentParserLibxml2.cpp:
* html/HTMLLinkElement.cpp:
* loader/SubframeLoader.cpp:
* page/History.cpp:
* storage/IDBFactory.cpp:
* storage/StorageAreaImpl.cpp:
2011-04-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP script-src should block eval
https://bugs.webkit.org/show_bug.cgi?id=59850
Rather than have JavaScriptCore call back into WebCore to learn whether
eval is enabled, we push that bit of the policy into JavaScriptCore.
Tests: http/tests/security/contentSecurityPolicy/eval-allowed.html
http/tests/security/contentSecurityPolicy/eval-blocked.html
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::disableEval):
* bindings/js/ScriptController.h:
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::internalAllowEval):
(WebCore::ContentSecurityPolicy::allowEval):
* page/ContentSecurityPolicy.h:
2011-04-29 Joseph Pecoraro <joepeck@webkit.org>
GTK build fix. Missed moving DateComponents and
adding LocalizedDate files for their build file.
* GNUmakefile.list.am:
2011-04-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
style-src should block @style
https://bugs.webkit.org/show_bug.cgi?id=59293
This patch blocks @style when style-src doesn't have the
'unsafe-inline' token. This patch blocks the parsing of the attribute
itself. That feels vaguely like too low a level to interpose the
policy, but there didn't seem to be anywhere else natural to enforce
the policy.
Tests: http/tests/security/contentSecurityPolicy/inline-style-attribute-allowed.html
http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked.html
http/tests/security/contentSecurityPolicy/inline-style-on-html.html
* dom/StyledElement.cpp:
(WebCore::StyledElement::parseMappedAttribute):
2011-04-29 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Kent Tamura.
Allow Localized Date Strings for Date Input Fields
https://bugs.webkit.org/show_bug.cgi?id=59752
Test: fast/forms/date-input-visible-strings.html
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj: update build files for
moving DateComponents from WebCore/html to WebCore/platform
and adding the LocalizedDate files.
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::serialize):
(WebCore::BaseDateAndTimeInputType::serializeWithComponents):
(WebCore::BaseDateAndTimeInputType::serializeWithMilliseconds):
InputType::serialize for a double value with date types is
different for the month type because it assumes the incoming
value is months instead of msecs (matching valueAsNumber in
HTML5). So provide a more general serialization function,
serializeWithComponents, that will always serialize a string
correctly for the current type but taking in a DateComponents
object. The default serialize, and new serializeWithMilliseconds,
can fall back to this and allows an override point for
the month type.
* html/MonthInputType.cpp:
(WebCore::MonthInputType::serializeWithMilliseconds): the month
type is a case where the default serialize does not take msec,
so provide an implementation for month which handles msec input.
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::setValueAsDate): switch
to serializeWithMilliseconds as the incoming date value is msec.
* html/MonthInputType.cpp:
(WebCore::MonthInputType::setValueAsDate): removed.
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::visibleValue): allow
localized formatting of a date value.
(WebCore::BaseDateAndTimeInputType::convertFromVisibleValue):
allow parsing for a formatted date value.
* html/BaseDateAndTimeInputType.h:
* platform/DateComponents.cpp: Renamed from Source/WebCore/html/DateComponents.cpp.
Expose the Type enum so it can be used outside of the DateComponents class.
* platform/text/LocalizedDate.h: Added.
* platform/text/LocalizedDateNone.cpp: Added.
(WebCore::formatLocalizedDate): Default implementation falls back to
existing HTML5 date input value formatting.
* html/BaseDateAndTimeInputType.h:
* html/DateInputType.cpp:
(WebCore::DateInputType::dateType):
* html/DateInputType.h:
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::dateType):
* html/DateTimeInputType.h:
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::dateType):
* html/DateTimeLocalInputType.h:
* html/MonthInputType.cpp:
(WebCore::MonthInputType::dateType):
* html/MonthInputType.h:
* html/TimeInputType.cpp:
(WebCore::TimeInputType::dateType):
* html/TimeInputType.h:
* html/WeekInputType.cpp:
(WebCore::WeekInputType::dateType):
* html/WeekInputType.h: Accessors for the desired date
type of a date input type. This allows the base class
to write a generic algorithm.
2011-04-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
style-src should block inline style from <style>
https://bugs.webkit.org/show_bug.cgi?id=59292
The spec has been updated to allow blocking of inline styles with
style-src. This will help folks defend against tricky CSS3 injections.
This patch covers the <style> case. The next patch will cover the
@style case.
Tests: http/tests/security/contentSecurityPolicy/inline-style-allowed.html
http/tests/security/contentSecurityPolicy/inline-style-blocked.html
* dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowInlineStyle):
* page/ContentSecurityPolicy.h:
2011-04-29 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Add WebCore::Setting to block displaying and/or running insecure content on secure pages
https://bugs.webkit.org/show_bug.cgi?id=58378
Test: To follow in subsequent patch, including the wiring to expose the new settings to LayoutTests.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkIfDisplayInsecureContent): Return whether or not the load should be blocked, and tweak the message upon blocking.
(WebCore::FrameLoader::checkIfRunInsecureContent): Return whether or not the load should be blocked, and tweak the message upon blocking.
* loader/FrameLoader.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::willSendRequest): Check if the frame load is blocked due to mixed content and cancel it if so. The check was moved up so that it occurs before firing the load callbacks, to avoid any outgoing network hits or accounting. Redirects are handled because willSendRequest is called for each one in the chain.
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): Handle the blocking of mixed-content plug-in loads.
(WebCore::SubframeLoader::loadPlugin): Handle the blocking of mixed-content plug-in loads.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest): Handle the blocking of various loads due to mixed content conditions.
* page/Settings.cpp:
(WebCore::Settings::Settings): Permit mixed-content loads by default to avoid a change in behavior by default.
* page/Settings.h: Add two new booleans to control blocking of mixed content (displaying and running thereof).
(WebCore::Settings::setAllowDisplayOfInsecureContent):
(WebCore::Settings::allowDisplayOfInsecureContent):
(WebCore::Settings::setAllowRunningOfInsecureContent):
(WebCore::Settings::allowRunningOfInsecureContent):
2011-04-29 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Extract a function to obtain VisiblePosition from RenderText::positionForPoint
https://bugs.webkit.org/show_bug.cgi?id=59811
Extracted lineDirectionPointFitsInBox from positionForPoint.
* rendering/RenderText.cpp:
(WebCore::lineDirectionPointFitsInBox):
(WebCore::RenderText::positionForPoint):
2011-04-29 Geoffrey Garen <ggaren@apple.com>
Reviewed by Alexey Proskuryakov.
REGRESSION: r83938 abandons GC memory
https://bugs.webkit.org/show_bug.cgi?id=59604
This bug was caused by script and image elements waiting indefinitely
for their loads to finish.
* bindings/js/JSNodeCustom.cpp:
(WebCore::isReachableFromDOM): Don't test for the load event firing,
since the load event doesn't fire in cases of canceled or errored loads.
Instead, test hasPendingActivity().
Don't do this test at all for script elements because script elements
can't load while outside the document. (fast/dom/script-element-gc.html
verifies that this is correct.)
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::hasPendingActivity):
* html/HTMLImageElement.h:
* loader/ImageLoader.cpp:
(WebCore::ImageEventSender::hasPendingEvents):
(WebCore::ImageLoader::hasPendingLoadEvent):
* loader/ImageLoader.h: Added API for finding out if an image element
has pending activity.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::setRequest): All loads are supposed to end in
data(allDataReceived = true) or error(), but in the edge case of a
canceled load, all we get is a call to setRequest(0). Be sure to
record that we're no longer loading in that case, otherwise our element
will leak forever, waiting for its load to complete.
2011-04-29 Emil Eklund <eae@chromium.org>
Reviewed by Tony Chang.
Setting outerHTML should merge text nodes
https://bugs.webkit.org/show_bug.cgi?id=52686
When setting outerHTML adjacent text nodes should be merged. This matches
the behavior of outerText and the IE implementation of outerHTML.
Test: fast/dom/set-outer-html.html
* html/HTMLElement.cpp:
(WebCore::mergeWithNextTextNode): Move function to before setOuterHTML.
(WebCore::HTMLElement::setOuterHTML): Merge adjacent text nodes after replacing the element.
2011-04-29 Emil A Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
Onchange on text fields has an incoherent behavior
https://bugs.webkit.org/show_bug.cgi?id=57330
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::insertedIntoDocument):
Initialize m_textAsOfLastFormControlChangeEvent to empty string rather
than null for empty fields.
2011-04-29 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Unreviewed buildfix after r85343.
Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667
* plugins/mac/PluginViewMac.mm:
(WebCore::PluginView::platformStart):
2011-04-29 Jon Lee <jonlee@apple.com>
Reviewed by mitzpettel.
REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs (59721)
<rdar://problem/9327332>
https://bugs.webkit.org/show_bug.cgi?id=59721
Removing shouldClearSelectionWhenLosingWebPageFocus(). Reverting changelist 83814.
* WebCore.exp.in:
* editing/EditingBehavior.h:
2011-04-29 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Allow only first table caption and destroy the remaining ones.
https://bugs.webkit.org/show_bug.cgi?id=58249
Previously, we were only laying out the first table caption.
However Table::layout didn't mark the other ones as not needing
layout. So after table layout completes, table is marked as not
needing layout with its other table caption still needing layout.
This causes incorrect layout root calculations and set it to a
node which is already getting deleted.
Tests: fast/table/dynamic-caption-add-before-child.xhtml
fast/table/dynamic-caption-add-remove-before-child.xhtml
fast/table/multiple-captions-crash.xhtml
fast/table/multiple-captions-crash2.xhtml
fast/table/multiple-captions-display.xhtml
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild): when new caption or a before
child caption is added, we need to explicitly trigger section
recalc or otherwise layout won't catch it.
(WebCore::RenderTable::removeChild): when child to be removed is
m_caption, make sure to trigger style recalc on the table.
(WebCore::RenderTable::recalcCaption): code to destroy captions
other than the first one.
(WebCore::RenderTable::recalcSections): call recalcCaption
helper. Store the next sibling early since child can get destroyed
in recalcCaption.
* rendering/RenderTable.h:
2011-04-29 David Kilzer <ddkilzer@apple.com>
Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678
* DerivedSources.make: Removed $(WebCore)/wml path in VPATH.
2011-04-29 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r85330.
http://trac.webkit.org/changeset/85330
https://bugs.webkit.org/show_bug.cgi?id=41311
Caused unexpected border rendering change on 500 tests on chromium linux.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::clipConvexPolygon):
2011-04-29 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Unreviewed buildfix after r85343.
Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::wndProc):
(WebCore::PluginView::snapshot):
2011-04-29 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Adam Barth.
Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
* platform/graphics/qt/ImageDecoderQt.h:
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
2011-04-29 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
Add ENABLE macro for WebKitAnimation
https://bugs.webkit.org/show_bug.cgi?id=59729
Add new feature to toggle WebKit Animation API.
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* dom/Element.idl:
* features.pri:
* page/DOMWindow.idl:
2011-04-29 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=59149
(Regression) Existing animations are not replaced when filling.
Hardware animations that fill forwards were not being correctly
replaced when the animation was removed. The actual animation
logic was working correctly, but it wasn't deleting the
CoreAnimation animation from the PlatformLayer. The fix was
to explicitly call endAnimation when disconnecting the animation
from its RenderObject.
Test: animations/3d/replace-filling-transform.html
* page/animation/AnimationBase.h:
(WebCore::AnimationBase::clear): call endAnimation as the animation is cleared
2011-04-29 Abhishek Arya <inferno@chromium.org>
Reviewed by Nikolas Zimmermann.
When svg inline text is getting destroyed, make sure to mark
its svg text ancestor as needing a positioning values update.
This helps to recalculate layout attributes and makes sure
that svg inline text is not used again.
https://bugs.webkit.org/show_bug.cgi?id=59161
Test: svg/text/inline-text-destroy-attributes-crash.xhtml
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::destroy):
* rendering/svg/RenderSVGInlineText.h:
2011-04-29 Kevin Ollivier <kevino@theolliviers.com>
[wx] Unreviewed build fix. Fix wxMSW trunk builds by adding include.
* platform/graphics/wx/GraphicsContextWx.cpp:
2011-04-29 Mike Reed <reed@google.com>
Reviewed by Ojan Vafai.
Skia: Need to implement GraphicsContext::clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=41311
This does not (yet) enable HAVE_PATH_BASED_BORDER_RADIUS_DRAWING
as that shows other issues/question unrelated to clipping.
https://bugs.webkit.org/show_bug.cgi?id=41311
No new tests. covered by existing layout tests
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::setPathFromConvexPoints):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::clipConvexPolygon):
2011-04-29 Mike Lawther <mikelawther@chromium.org>
Reviewed by Ojan Vafai.
Fix IR->SR typo in enum value (and resulting style fails)
https://bugs.webkit.org/show_bug.cgi?id=59779
No functionality change, so no new tests
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EShapeRendering):
2011-04-29 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: CSS editing breaks when entering "color: rgb(1"
https://bugs.webkit.org/show_bug.cgi?id=59789
Tests: inspector/styles/styles-add-invalid-property.html
inspector/styles/styles-cancel-editing.html
inspector/styles/styles-commit-editing.html
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSProperty.prototype.setText.callback):
(WebInspector.CSSProperty.prototype.setText):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.selectElement):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.originalPropertyText):
* inspector/front-end/inspector.js:
(WebInspector.startEditing.defaultFinishHandler):
(WebInspector.startEditing.keyDownEventListener):
(WebInspector.startEditing):
2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
ENABLE(QT_BEARER) -> USE(QT_BEARER)
* WebCore.pri:
* WebCore.pro:
* features.pri:
* platform/network/NetworkStateNotifier.h:
* platform/network/qt/NetworkStateNotifierQt.cpp:
2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
* WebCore.pri:
* features.pri:
2011-04-29 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
https://bugs.webkit.org/show_bug.cgi?id=59476
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
(WebInspector.PresentationBreakpoint.prototype.serialize):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype.reset):
2011-04-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: include script end line:column in scriptParsed parameters.
https://bugs.webkit.org/show_bug.cgi?id=59717
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
(WebCore::InspectorDebuggerAgent::Script::Script):
* inspector/ScriptDebugListener.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
* inspector/front-end/Script.js:
(WebInspector.Script):
2011-04-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [protocol] Evaluate should expose thrown exception value
https://bugs.webkit.org/show_bug.cgi?id=59000
Each evaluation command may have either thrown or returned result. This is indicated
by wasThrown property in the protocol.
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::evaluateOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::makeEvalCall):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
* inspector/Inspector.json: Removed "error" remote object type, added "wasThrown" property to
the evaluation results.
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::evaluateOn):
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions.evaluated):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
(WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
(WebInspector.ConsoleView.prototype._enterKeyPressed):
(WebInspector.ConsoleCommandResult):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.PresenationCallFrame.prototype.evaluate):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.update):
* inspector/front-end/PropertiesSidebarPane.js:
(WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
(WebInspector.SourceFrame.prototype._showPopup):
2011-04-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r85315.
http://trac.webkit.org/changeset/85315
https://bugs.webkit.org/show_bug.cgi?id=59792
Broke script-formatter.html test (Requested by podivilov on
#webkit).
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger.didRemoveBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
(WebInspector.PresentationBreakpoint.prototype.serialize):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype.reset):
2011-04-29 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Hyperlink Auditing (ping) requests are not shown in network panel
https://bugs.webkit.org/show_bug.cgi?id=58794
Added ping requests to network panel.
Test: http/tests/inspector/network/ping.html
* English.lproj/localizedStrings.js:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::continueAfterPingLoader):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
(WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get formParameters):
(WebInspector.Resource.prototype.requestContentType):
(WebInspector.Resource.prototype.isPingRequest):
* loader/PingLoader.cpp:
(WebCore::PingLoader::PingLoader):
* loader/PingLoader.h:
2011-04-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
https://bugs.webkit.org/show_bug.cgi?id=59476
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
(WebInspector.PresentationBreakpoint.prototype.serialize):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype.reset):
2011-04-29 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add "open link in new tab" action into the network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=59788
This change also distinguishes context menu items case between platforms.
* English.lproj/localizedStrings.js:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._handleContextMenuEvent):
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._contextMenuEventFired):
(WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._contextMenu):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
* inspector/front-end/Settings.js:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._contextMenu):
* inspector/front-end/inspector.js:
(WebInspector.openLinkExternallyLabel):
(WebInspector.openResource):
(WebInspector.useLowerCaseMenuTitles):
2011-04-28 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Mask placement on composited layer is incorrect sometimes
https://bugs.webkit.org/show_bug.cgi?id=59775
The mask layer always has the same size as its owning GraphicsLayer,
so it needs to share the same offsetFromRenderer as well. This fixes
the offset at which the mask layer contents are painted in cases where
that offset is non-zero, for example when outline style bloats all of
the layer sizes.
Test: compositing/masks/layer-mask-placement.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2011-04-28 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Mark Rowe.
Reverted r81319.
Fixes <rdar://problem/9331580> REGRESSION (r81319): Safari fails to display dropdown navigation on classics.berkeley.edu
* page/NavigatorBase.cpp:
2011-04-28 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dirk Schulze.
1px box-shadow looks ugly
https://bugs.webkit.org/show_bug.cgi?id=58100
and
ShadowBlur incorrectly handles zero-sized blur radius in one axis
https://bugs.webkit.org/show_bug.cgi?id=59710
blurLayerImage() has issues at the edges if the blur radius
is one, so in that case bump the buffer size out by a pixel.
This results in a correct, symmetrical blur.
Also fix an issue noticed during testing where a zero
height or width radius would still blur on that axis,
because we clamp the kernel size to a minimum of two.
Test: fast/box-shadow/single-pixel-shadow.html
* platform/graphics/ShadowBlur.h:
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::blurLayerImage):
Skip horizontal or vertial passes if the radius on that axis is zero.
Move the "if (pass && m_blurRadius.width() != m_blurRadius.height())"
clause to the end of the loop, since it only needs to execute once
after the first pass.
(WebCore::ShadowBlur::blurredEdgeSize):
New method to compute the width of the blurred edge (radius + extra
pixel when necessary).
(WebCore::ShadowBlur::calculateLayerBoundingRect):
(WebCore::ShadowBlur::templateSize):
(WebCore::ShadowBlur::drawRectShadow):
(WebCore::ShadowBlur::drawInsetShadow):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::drawLayerPieces):
Use the result of blurredEdgeSize() rather than recomputing.
2011-04-28 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Beth Dakin.
CSS sibling selector (~) does not work with :target pseudo class
https://bugs.webkit.org/show_bug.cgi?id=26539
Allow style recalculation of forward siblings of elements with
forward positional rules.
Tests: fast/css/pseudo-target-indirect-sibling-001.html
fast/css/pseudo-target-indirect-sibling-002.html
* dom/Element.cpp:
(WebCore::Element::recalcStyle):
2011-04-28 Nat Duca <nduca@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
https://bugs.webkit.org/show_bug.cgi?id=59626
* platform/graphics/chromium/Extensions3DChromium.h:
(WebCore::Extensions3DChromium::SwapBuffersCompleteCallbackCHROMIUM::~SwapBuffersCompleteCallbackCHROMIUM):
2011-04-28 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Change chromium media controls to use absolute positioning until bug 59644 is fixed.
https://bugs.webkit.org/show_bug.cgi?id=59732
* css/mediaControlsChromium.css:
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
2011-04-28 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Implement CSS border width and related properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=59414
No new tests as no functionality added.
* css/CSSStyleApplyProperty.cpp:
Separated ApplyPropertyDefault into parent and child so that other classes could inherit
the applyInheritValue and applyInitialValue methods only.
This was necessary to avoid casting from CSSPrimitiveValue to inappropriate types in ApplyPropertyDefault::applyValue().
Added ApplyPropertyWidth class for handling width based CSS properties.
* css/CSSStyleSelector.cpp:
Removed no-longer-required code for handling width based CSS properties.
* css/CSSStyleSelector.h:
Added a getter for m_rootElementStyle.
2011-04-28 Kent Tamura <tkent@chromium.org>
Run sort-Xcode-project-file.
* WebCore.xcodeproj/project.pbxproj:
2011-04-28 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[Cairo] Text underline is not shadowed when text-shadow is enabled
https://bugs.webkit.org/show_bug.cgi?id=48074
Use ContextShadow to enable shadows for text underlines. Also remove quite a bit
of duplicate code in GraphicsContext used for stroking lines. This code looks like it was
originally copied from the CG GraphicsContext.
* platform/graphics/GraphicsContext.h: Make adjustLineToPixelBoundaries so that we
can call it from a static helper function.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::calculateStrokePatternOffset): Abstracted this code into a helper.
(WebCore::drawLineOnCairoContext): Abstracted this code into a helper. We need to
call it multiple times when shadowing text underlines.
(WebCore::GraphicsContext::drawLine): Use drawLineOnCairoContext.
(WebCore::GraphicsContext::strokeArc): Use calculateStrokePatternOffset.
(WebCore::GraphicsContext::drawLineForText): Use drawLineOnCairoContext.
2011-04-28 Sam Weinig <sam@webkit.org>
Rubber-stamped by Mark Rowe.
Cleanup WebCore.xcodeproj a bit.
* WebCore.xcodeproj/project.pbxproj:
Added CompilerVersion.xcconfig and moved some JS bindings files into the
correct sub groups.
2011-04-28 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
Remove IMAGE_RESIZER related code.
https://bugs.webkit.org/show_bug.cgi?id=59735
* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* features.pri:
* html/AsyncImageResizer.cpp: Removed.
* html/AsyncImageResizer.h: Removed.
* html/ImageResizerThread.cpp: Removed.
* html/ImageResizerThread.h: Removed.
2011-04-28 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630.
* inspector/front-end/Settings.js:
(WebInspector.Settings):
2011-04-28 Beth Dakin <bdakin@apple.com>
Rubber-stamped by Sam Weinig.
Rolling out revision 85258! I want to fix that bug a different way.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
2011-04-28 Chang Shu <cshu@webkit.org>
Reviewed by Eric Seidel.
isContentEditable is not working properly with document.designMode
https://bugs.webkit.org/show_bug.cgi?id=53031
The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
indicates that the element.isContentEditable relies on document.designMode if its
and its ancestors' contenteditable attributes are set to inherit.
1. Sync document render style after document.designMode is changed.
2. Removed the code that does unnecessary and incorrect handling for contenteditable
attribute with "inherit" value.
3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.
Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html
fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
fast/dom/HTMLElement/iscontenteditable-designmodeon.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
* dom/Document.cpp:
(WebCore::Document::setDesignMode):
* dom/Node.cpp:
(WebCore::Node::rendererIsEditable):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::setContentEditable):
2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r85101.
http://trac.webkit.org/changeset/85101
https://bugs.webkit.org/show_bug.cgi?id=59757
it'd be better to rollout the patch and do another one with
another property name. Current one will bring us to a problem
at first run after upgrade because it's type was changed from
int to string. (Requested by loislo on #webkit).
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
(WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
(WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
2011-04-28 Mike Reed <reed@google.com>
Reviewed by Eric Seidel.
fix shadw behavior for both CSS and Canvas -- skia only
https://bugs.webkit.org/show_bug.cgi?id=59700
Test:
canvas/philip/tests/2d.shadow.alpha.3.html
canvas/philip/tests/2d.shadow.alpha.4.html
canvas/philip/tests/2d.shadow.alpha.5.html
fast/canvas/canvas-fillPath-alpha-shadow.html
fast/canvas/canvas-strokePath-alpha-shadow.html
fast/canvas/canvas-strokeRect-alpha-shadow.html
fast/css/text-input-with-webkit-border-radius.html
fast/repaint/shadow-multiple-horizontal.html
fast/repaint/shadow-multiple-strict-horizontal.html
fast/repaint/shadow-multiple-strict-vertical.html
fast/repaint/shadow-multiple-vertical.html
fast/canvas/canvas-getImageData.html
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
2011-04-28 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper
Reviewed by Chris Fleizach.
Previously, AXObjectCache::attachWrapper over-retained each
AccessibilityObjectWrapper it created, which is why
AXObjectCache::detachWrapper() contained an extra -release.
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::detachWrapper): Removed extra -release.
(WebCore::AXObjectCache::attachWrapper): Because setWrapper()
assigns to a RetainPtr<> instance variable, it doesn't need a +1
retained object passed in. Fix the leak by using a RetainPtr<>
for the AccessibilityObjectWrapper.
2011-04-28 Nat Duca <nduca@chromium.org>
Reviewed by Darin Fisher.
[chromium] Compute compositor fps value and history using the frameBegin timestamp
https://bugs.webkit.org/show_bug.cgi?id=59668
This change switches the compositor FPS meter to use the timestamp
of the beginning of the frame rather than the time we call
swapBuffers. When scheduling is correctly tied to vsync, we can
have highly variable times when we finish vsync and still have
stable frame rates.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateAndDrawLayers):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::onPresent):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
2011-04-28 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=59759
Overflow:scroll regions with overlay scrollbars show full thumb instead of just a
track when there is nothing to scroll to
<rdar://problem/9282066>
Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is
nothing to scroll to. Just dividing them to get a knob proportion yields 1, which
is not right. Set the proportion to 0 in this case instead.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
2011-04-28 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/9291132> Add support for -epub-prefixed properties
Test: fast/css/epub-properties.html
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
* css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
-webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
text-transform, text-transform, word-break, and -webkit-writing-mode.
2011-04-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678
This patch removes WML from WebCore. After removing WML, there's a
bunch of twisted code that could be untwisted, but this patch contains
only the purely mechanical part of removing the feature.
There's been a lot of discussion on webkit-dev about whether we should
remove WML. In addition to those threads, we've had an informal poll
of the reviewers as well as an in-person discussion at the WebKit
contributor's meeting. Removing any feature is likely to make some
folks unhappy, but, on balance, removing WML appears to be the right
thing for the project to do at this time.
* CMakeLists.txt:
* CodeGenerators.pri:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::linkAttribute):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::adjustRenderStyle):
* css/wml.css: Removed.
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::createElement):
* dom/Document.h:
(WebCore::Document::isMediaDocument):
* dom/Document.idl:
* dom/InputElement.h:
* dom/Node.cpp:
(WebCore::Node::toInputElement):
* dom/Node.h:
* dom/OptionElement.cpp:
(WebCore::toOptionElement):
(WebCore::isOptionElement):
* dom/OptionElement.h:
* dom/OptionGroupElement.cpp:
(WebCore::toOptionGroupElement):
(WebCore::isOptionGroupElement):
* dom/SelectElement.cpp:
(WebCore::toSelectElement):
* dom/SelectElement.h:
* dom/Text.cpp:
(WebCore::Text::attach):
* dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::insertErrorMessageBlock):
* dom/XMLDocumentParser.h:
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::internalSubset):
(WebCore::getEntityHandler):
* dom/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseDtd):
* editing/htmlediting.cpp:
(WebCore::canHaveChildrenForEditing):
* features.pri:
* history/BackForwardList.h:
* history/BackForwardListImpl.cpp:
* history/BackForwardListImpl.h:
* history/PageCache.cpp:
(WebCore::PageCache::canCachePageContainingThisFrame):
* html/HTMLAnchorElement.h:
* inspector/ConsoleMessage.cpp:
(WebCore::messageSourceValue):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype.toString):
* loader/FrameLoader.cpp:
(WebCore::isBackForwardLoadType):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::shouldReload):
(WebCore::FrameLoader::loadDifferentDocumentItem):
(WebCore::FrameLoader::loadItem):
* loader/FrameLoaderTypes.h:
* loader/HistoryController.cpp:
(WebCore::HistoryController::restoreDocumentState):
* manual-tests/wml: Removed.
* manual-tests/wml/StartTests.wml: Removed.
* manual-tests/wml/a-br-element.wml: Removed.
* manual-tests/wml/a-element.wml: Removed.
* manual-tests/wml/a-img-element.wml: Removed.
* manual-tests/wml/access-target.wml: Removed.
* manual-tests/wml/anchor-br-element.wml: Removed.
* manual-tests/wml/anchor-element.wml: Removed.
* manual-tests/wml/anchor-img-element.wml: Removed.
* manual-tests/wml/card-newcontext-attr.wml: Removed.
* manual-tests/wml/card-onenterbackward.wml: Removed.
* manual-tests/wml/card-onenterforward.wml: Removed.
* manual-tests/wml/card-ontimer.wml: Removed.
* manual-tests/wml/deck-access-control.wml: Removed.
* manual-tests/wml/input-format.wml: Removed.
* manual-tests/wml/onevent-go.wml: Removed.
* manual-tests/wml/onevent-noop.wml: Removed.
* manual-tests/wml/onevent-prev.wml: Removed.
* manual-tests/wml/onevent-refresh.wml: Removed.
* manual-tests/wml/onevent-shadow.wml: Removed.
* manual-tests/wml/resources: Removed.
* manual-tests/wml/resources/smiley.png: Removed.
* manual-tests/wml/select-element.wml: Removed.
* manual-tests/wml/select-onpick-event-crash.wml: Removed.
* manual-tests/wml/select-onpick-event.wml: Removed.
* manual-tests/wml/setvar-element.wml: Removed.
* manual-tests/wml/targetdeck.wml: Removed.
* manual-tests/wml/task-go-in-anchor.wml: Removed.
* manual-tests/wml/task-prev-in-anchor.wml: Removed.
* manual-tests/wml/task-refresh-in-anchor.wml: Removed.
* manual-tests/wml/template-go.wml: Removed.
* manual-tests/wml/template-ontimer.wml: Removed.
* manual-tests/wml/timer.wml: Removed.
* manual-tests/wml/variable-substitution.wml: Removed.
* page/Console.cpp:
(WebCore::printMessageSourceAndLevelPrefix):
* page/Console.h:
* page/Frame.cpp:
(WebCore::Frame::Frame):
* page/Page.cpp:
* page/Page.h:
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedNonImageMimeTypes):
* platform/network/FormDataBuilder.h:
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
* platform/wince/MIMETypeRegistryWinCE.cpp:
(WebCore::initMIMETypeEntensionMap):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absoluteLinkURL):
(WebCore::HitTestResult::isLiveLink):
* rendering/RenderBox.cpp:
* rendering/RenderButton.cpp:
(WebCore::RenderButton::updateFromElement):
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::findLegend):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::updateAltText):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::isLegend):
(WebCore::RenderObject::offsetParent):
* wml: Removed.
* wml/WMLAElement.cpp: Removed.
* wml/WMLAElement.h: Removed.
* wml/WMLAccessElement.cpp: Removed.
* wml/WMLAccessElement.h: Removed.
* wml/WMLAnchorElement.cpp: Removed.
* wml/WMLAnchorElement.h: Removed.
* wml/WMLAttributeNames.in: Removed.
* wml/WMLBRElement.cpp: Removed.
* wml/WMLBRElement.h: Removed.
* wml/WMLCardElement.cpp: Removed.
* wml/WMLCardElement.h: Removed.
* wml/WMLDoElement.cpp: Removed.
* wml/WMLDoElement.h: Removed.
* wml/WMLDocument.cpp: Removed.
* wml/WMLDocument.h: Removed.
* wml/WMLElement.cpp: Removed.
* wml/WMLElement.h: Removed.
* wml/WMLErrorHandling.cpp: Removed.
* wml/WMLErrorHandling.h: Removed.
* wml/WMLEventHandlingElement.cpp: Removed.
* wml/WMLEventHandlingElement.h: Removed.
* wml/WMLFieldSetElement.cpp: Removed.
* wml/WMLFieldSetElement.h: Removed.
* wml/WMLFormControlElement.cpp: Removed.
* wml/WMLFormControlElement.h: Removed.
* wml/WMLGoElement.cpp: Removed.
* wml/WMLGoElement.h: Removed.
* wml/WMLImageElement.cpp: Removed.
* wml/WMLImageElement.h: Removed.
* wml/WMLImageLoader.cpp: Removed.
* wml/WMLImageLoader.h: Removed.
* wml/WMLInputElement.cpp: Removed.
* wml/WMLInputElement.h: Removed.
* wml/WMLInsertedLegendElement.cpp: Removed.
* wml/WMLInsertedLegendElement.h: Removed.
* wml/WMLIntrinsicEvent.cpp: Removed.
* wml/WMLIntrinsicEvent.h: Removed.
* wml/WMLIntrinsicEventHandler.cpp: Removed.
* wml/WMLIntrinsicEventHandler.h: Removed.
* wml/WMLMetaElement.cpp: Removed.
* wml/WMLMetaElement.h: Removed.
* wml/WMLNoopElement.cpp: Removed.
* wml/WMLNoopElement.h: Removed.
* wml/WMLOnEventElement.cpp: Removed.
* wml/WMLOnEventElement.h: Removed.
* wml/WMLOptGroupElement.cpp: Removed.
* wml/WMLOptGroupElement.h: Removed.
* wml/WMLOptionElement.cpp: Removed.
* wml/WMLOptionElement.h: Removed.
* wml/WMLPElement.cpp: Removed.
* wml/WMLPElement.h: Removed.
* wml/WMLPageState.cpp: Removed.
* wml/WMLPageState.h: Removed.
* wml/WMLPostfieldElement.cpp: Removed.
* wml/WMLPostfieldElement.h: Removed.
* wml/WMLPrevElement.cpp: Removed.
* wml/WMLPrevElement.h: Removed.
* wml/WMLRefreshElement.cpp: Removed.
* wml/WMLRefreshElement.h: Removed.
* wml/WMLSelectElement.cpp: Removed.
* wml/WMLSelectElement.h: Removed.
* wml/WMLSetvarElement.cpp: Removed.
* wml/WMLSetvarElement.h: Removed.
* wml/WMLTableElement.cpp: Removed.
* wml/WMLTableElement.h: Removed.
* wml/WMLTagNames.in: Removed.
* wml/WMLTaskElement.cpp: Removed.
* wml/WMLTaskElement.h: Removed.
* wml/WMLTemplateElement.cpp: Removed.
* wml/WMLTemplateElement.h: Removed.
* wml/WMLTimerElement.cpp: Removed.
* wml/WMLTimerElement.h: Removed.
* wml/WMLVariables.cpp: Removed.
* wml/WMLVariables.h: Removed.
2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r85233 and r85235.
http://trac.webkit.org/changeset/85233
http://trac.webkit.org/changeset/85235
https://bugs.webkit.org/show_bug.cgi?id=59754
Causes issues with jsc. (Requested by dave_levin on #webkit).
* ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::defaultIcon):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::getOrCreateIconRecord):
(WebCore::IconDatabase::readFromDatabase):
2011-04-28 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Introducing a new class that allows serialization of a page back
to HTML/XML with all its sub-frames and also retrieves the page's
resources.
Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
https://bugs.webkit.org/show_bug.cgi?id=58947
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* dom/Document.cpp:
(WebCore::Document::suggestedMIMEType):
* dom/Document.h:
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendCustomAttributes):
(WebCore::MarkupAccumulator::appendElement):
* editing/MarkupAccumulator.h:
* html/parser/HTMLMetaCharsetParser.cpp:
(WebCore::HTMLMetaCharsetParser::processMeta):
(WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
* html/parser/HTMLMetaCharsetParser.h:
* page/PageSerializer.cpp: Added.
* page/PageSerializer.h: Added.
2011-04-28 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB createIndex should fail if name arg is null
https://bugs.webkit.org/show_bug.cgi?id=58365
Test: storage/indexeddb/mozilla/create-index-null-name.html
* storage/IDBObjectStore.idl:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::createIndex):
2011-04-28 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB put() should fail if second (key) parameter is null
https://bugs.webkit.org/show_bug.cgi?id=58613
If key arg is not specified, prpKey ends up as a null pointer in ::put().
However, if the key arg is specified but is null, prpKey ends up as a
valid IDBKey which has a null key type. As it happens, we need to be able
to detect the difference between these cases (the key arg is optional but
if specified must not be null).
Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
2011-04-07 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Add asserts to RefCounted to make sure ref/deref happens on the right thread.
https://bugs.webkit.org/show_bug.cgi?id=31639
No new functionality exposed so no new tests. (The change is basically adding
more testing.)
* ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
(WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
(WebCore::IconDatabase::setIconDataForIconURL): Ditto.
(WebCore::IconDatabase::readFromDatabase): Ditto.
2011-04-28 Kenneth Russell <kbr@google.com>
Unreviewed build fix for Web Audio with strict OwnPtr.
* platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
2011-04-28 Dominic Cooney <dominicc@chromium.org>
Reviewed by Geoffrey Garen.
Walk shadow hosts as well as parent nodes when finding opaque roots.
https://bugs.webkit.org/show_bug.cgi?id=59571
Test: fast/dom/shadow/gc-shadow.html
* bindings/js/JSDOMBinding.h:
(WebCore::root):
2011-04-28 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Click counting logic should be shared between WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59715
Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
into WebCore so that WebKit1 and WebKit2 can share the code.
No new tests. This is covered by fast/events/click-count.html.
* GNUmakefile.list.am: Added new files.
* platform/gtk/GtkClickCounter.cpp: Added.
(WebCore::GtkClickCounter::GtkClickCounter): Added.
(WebCore::GtkClickCounter::reset): Added.
(WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
(WebCore::getEventTime): Added.
(WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
* platform/gtk/GtkClickCounter.h: Added.
2011-04-28 Dan Bernstein <mitz@apple.com>
Build fix.
* css/CSSParser.cpp:
(WebCore::cssPropertyID):
2011-04-28 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
Allow specifying CSS property aliases in CSSPropertyNames.in files
https://bugs.webkit.org/show_bug.cgi?id=59712
* css/CSSParser.cpp:
(WebCore::cssPropertyID): Removed code to handle some aliases
* css/CSSPropertyNames.in: Added aliases no longer handled in code.
* css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
defining an alias, and add an appropriate entry to the gperf file.
2011-04-28 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Soup] does not load css stylesheets without content-type
https://bugs.webkit.org/show_bug.cgi?id=59697
When sniffing content type, do not replace http Content-Type header in
soup message anymore, but keep sniffed content type in a separate
variable.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::contentSniffedCallback):
* platform/network/soup/ResourceResponse.h:
(WebCore::ResourceResponse::sniffedContentType):
(WebCore::ResourceResponse::setSniffedContentType):
* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessage):
2011-04-28 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
https://bugs.webkit.org/show_bug.cgi?id=59704
No new tests, just code cleanup.
* WebCore.pri:
2011-04-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove "Pretty print" source frame context menu item.
https://bugs.webkit.org/show_bug.cgi?id=59709
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
2011-04-28 Satish Sampath <satish@chromium.org>
Reviewed by Tony Gentilcore.
Speech input button layout issues with padding and border.
https://bugs.webkit.org/show_bug.cgi?id=59613
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
(WebCore::RenderTextControlSingleLine::forwardEvent):
2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Check whether to use native scrollbars at run time
https://bugs.webkit.org/show_bug.cgi?id=59694
It's currently decided at build time depending on whether webkit2
build is enabled or not. That makes imposible to build both
webkit1 and webkit2 using the same libWebCore.
* GNUmakefile.am:
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::createScrollbar):
2011-04-28 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add status bar button for pretty print.
https://bugs.webkit.org/show_bug.cgi?id=59467
* WebCore.gypi:
* inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.get statusBarItems):
(WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.scripts-toggle-pretty-print-status-bar-item .glyph):
(.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
2011-04-28 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add ResourceTreeModel tests.
https://bugs.webkit.org/show_bug.cgi?id=59616
Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
http/tests/inspector/resource-tree/resource-tree-reload.html
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.frontendReused):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
(WebInspector.ResourceTreeModel.prototype.forAllResources):
(WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
(WebInspector.ResourceTreeModel.prototype._callForFrameResources):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._populateResourceTree):
(WebInspector.ResourcesPanel.prototype._frameAdded):
(WebInspector.ResourcesPanel.prototype._frameDetached):
(WebInspector.ResourcesPanel.prototype._frameNavigated):
(WebInspector.FrameTreeElement):
(WebInspector.FrameTreeElement.prototype.frameNavigated):
2011-04-28 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
https://bugs.webkit.org/show_bug.cgi?id=59592
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
(WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
(WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
(WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
(WebInspector.DetailedHeapshotView.prototype.changeView):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotPathFinder.prototype.findNext):
(WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
(WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
(WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
(WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
* inspector/front-end/heapProfiler.css:
(div.retaining-paths-view td.path-column div:hover):
2011-04-28 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
https://bugs.webkit.org/show_bug.cgi?id=59454
Test: inspector/profiler/heap-snapshot-loader.html
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotLoader):
(WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
(WebInspector.HeapSnapshotLoader.prototype.finishLoading):
(WebInspector.HeapSnapshotLoader.prototype._parseNodes):
(WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
2011-04-28 ojab <ojab@ojab.ru>
Reviewed by David Levin.
Fix build with libpng-1.5.1
https://bugs.webkit.org/show_bug.cgi?id=59607
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::readColorProfile):
2011-04-28 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Nikolas Zimmermann.
Optimizing gaussian blur filter to ARM-neon SIMD instruction set
https://bugs.webkit.org/show_bug.cgi?id=59447
This patch contains two sub-routines, one for speeding up
alpha channel only gaussian blur (by 2.5 times) and one
for speeding up all channel blur (by 4 times).
The common code is also redesigned to better fit for platform
specific code. This means large chunks of code was moved to
different files, and all platform specific files are added to
all build systems.
* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::apply):
* platform/graphics/filters/FEGaussianBlur.h:
(WebCore::FEGaussianBlur::kernelPosition):
(WebCore::FEGaussianBlur::platformApply):
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGeneric):
(WebCore::FELighting::drawLighting):
* platform/graphics/filters/FELighting.h:
(WebCore::FELighting::platformApply):
* platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
(WebCore::WTF_ALIGNED):
(WebCore::feGaussianBlurConstantsForNeon):
* platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
(WebCore::FEGaussianBlur::platformApplyNeon):
* platform/graphics/filters/arm/FELightingNEON.cpp:
(WebCore::WTF_ALIGNED):
(WebCore::FELighting::getPowerCoefficients):
* platform/graphics/filters/arm/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):
2011-04-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: provide a hotkey for script pause
https://bugs.webkit.org/show_bug.cgi?id=59593
In fact, F8 works as a hotkey, but this fact was not reflected
in the shortcut help popup.
* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._registerShortcuts):
2011-04-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginStream should play nice with strict OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59675
These failures appear when enabling strict OwnPtr on Qt.
* plugins/PluginStream.cpp:
(WebCore::PluginStream::PluginStream):
(WebCore::PluginStream::didReceiveData):
2011-04-26 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
https://bugs.webkit.org/show_bug.cgi?id=59326
Concrete CachedResource successors for stylesheets and scripts
can decode their content better than the generic approach we use.
* inspector/InspectorPageAgent.cpp:
(WebCore::decodeSharedBuffer):
(WebCore::prepareCachedResourceBuffer):
(WebCore::cachedResourceDecoded):
(WebCore::InspectorPageAgent::resourceContent):
(WebCore::InspectorPageAgent::resourceData):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::originalStyleSheetText):
2011-04-28 Jon Lee <jonlee@apple.com>
Reviewed by Simon Fraser.
REGRESSION: white overlay scrollbars on apple.com/startpage
https://bugs.webkit.org/show_bug.cgi?id=59540
<rdar://problem/9338653>
Now we look at the document background in addition to the <body> element,
and blend those colors in with the base background of the frame view to
arrive at our aggregate color. This provides a better result to determine
overlay scrollbar style.
* page/Frame.cpp:
(WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
* platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
2011-04-27 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Fix OwnPtr issues in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=59656
This patch is an attempt to fix the clang build. Clang can't seem to
cope with OwnPtrs to classes declared in an anonymous namespace because
OwnPtr's copy constructor isn't defined (but would need to be defined
in this translation unit).
* platform/leveldb/LevelDBDatabase.cpp:
2011-04-27 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Change cursor to LAZY_NATIVE_CURSOR
https://bugs.webkit.org/show_bug.cgi?id=59411
Enable LAZY_NATIVE_CURSOR on EFL build.
No test added because functionality is unchanged.
* CMakeListsEfl.txt: Add Cursor.cpp
* platform/Cursor.h:
(WebCore::Cursor::Cursor):
* platform/efl/CursorEfl.cpp:
(WebCore::Cursor::Cursor):
(WebCore::Cursor::~Cursor):
(WebCore::getCursorString):
(WebCore::Cursor::ensurePlatformCursor):
* platform/efl/WidgetEfl.cpp:
(WebCore::Widget::setCursor):
2011-04-27 Adam Barth <abarth@webkit.org>
Build fix from the future. Another trival strict OwnPtr fixes. This
is the last futuristic build fix I can detect with my time traveling
abilities.
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::initializeNewContext):
2011-04-27 Dmitry Lomov <dslomov@google.com>
Reviewed by David Levin.
CrossThreadCopier should not have a default specialization for raw pointers
https://bugs.webkit.org/show_bug.cgi?id=59234
Removed the ablity to pass raw pointers cross-thread
Added and applied annotations for doing that
* fileapi/FileReader.cpp:
(WebCore::FileReader::readInternal):
(WebCore::FileReader::abort):
* fileapi/FileStreamProxy.cpp:
(WebCore::FileStreamProxy::startOnFileThread):
(WebCore::FileStreamProxy::stopOnFileThread):
(WebCore::FileStreamProxy::getSize):
(WebCore::FileStreamProxy::getSizeOnFileThread):
(WebCore::FileStreamProxy::openForRead):
(WebCore::FileStreamProxy::openForReadOnFileThread):
(WebCore::FileStreamProxy::openForWrite):
(WebCore::FileStreamProxy::openForWriteOnFileThread):
(WebCore::FileStreamProxy::close):
(WebCore::FileStreamProxy::read):
(WebCore::FileStreamProxy::readOnFileThread):
(WebCore::FileStreamProxy::write):
(WebCore::FileStreamProxy::writeOnFileThread):
(WebCore::FileStreamProxy::truncate):
(WebCore::FileStreamProxy::truncateOnFileThread):
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
(WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
(WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
* page/GeolocationPositionCache.cpp:
(WebCore::GeolocationPositionCache::triggerReadFromDatabase):
(WebCore::GeolocationPositionCache::triggerWriteToDatabase):
* platform/CrossThreadCopier.h:
(WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
(WebCore::AllowCrossThreadAccessWrapper::value):
(WebCore::AllowCrossThreadAccess):
(WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
(WebCore::AllowExtendedLifetimeWrapper::value):
(WebCore::AllowExtendedLifetime):
* platform/graphics/chromium/cc/CCCompletionEvent.h:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
* storage/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
2011-04-27 Adam Barth <abarth@webkit.org>
Two build fixes from the future. (Trivial strict OwnPtr fixes.)
* page/Frame.cpp:
(WebCore::Frame::setTiledBackingStoreEnabled):
* platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::ReverbConvolver):
2011-04-27 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix five strict PassOwnPtr violations in WebCore
https://bugs.webkit.org/show_bug.cgi?id=59640
* css/MediaList.cpp:
(WebCore::MediaList::deleteMedium):
(WebCore::MediaList::setMediaText):
(WebCore::MediaList::appendMedium):
* css/MediaQuery.h:
* dom/MessagePort.cpp:
(WebCore::MessagePort::disentanglePorts):
(WebCore::MessagePort::entanglePorts):
* inspector/InspectorStyleSheet.cpp:
(ParsedStyleSheet::setText):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustMeterStyle):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
2011-04-27 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
https://bugs.webkit.org/show_bug.cgi?id=59648
Test: accessibility/aria-fallback-roles.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
2011-04-27 Beth Dakin <bdakin@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=59671
Race condition with scrollbar animations and closing a page can cause a crash in
WebCore::FrameView::setVisibleScrollerThumbRect + 15
-and corresponding-
<rdar://problem/9329253>
It is definitely possible for Page to be null here. So we should null-check it!
And we should not ASSERT.
* page/FrameView.cpp:
(WebCore::FrameView::didCompleteRubberBand):
(WebCore::FrameView::scrollbarStyleChanged):
(WebCore::FrameView::setVisibleScrollerThumbRect):
2011-04-27 Ryosuke Niwa <rniwa@webkit.org>
WinCE build fix after r85143.
* platform/graphics/wince/FontWinCE.cpp:
(WebCore::TextRunComponent::TextRunComponent):
2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB object store delete should fail if key is null
https://bugs.webkit.org/show_bug.cgi?id=58614
Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
2011-04-27 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Should have an easy way to construct starting BidiStatus for a paragraph root
https://bugs.webkit.org/show_bug.cgi?id=59226
Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
I've made this a constructor for BidiStatus instead.
As part of this effort I added a direction() accessor for TextRun and got
rid of the old m_rtl bool. This is part of the generic effort in the
Bidi code to replace old bool usage with the superior TextDirection enum
(this generally makes the code cleaner).
As part of this replacement effort I found several places which were
assuming LTR (by passing rtl=false) when they probably want to use
the current text direction. I suspect that LTR vs. RTL may affect
string width in the case of ligatures. It's unclear.
This is almost entirely a mechanical change.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawBidiText):
* platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
(WebCore::TextRun::direction):
(WebCore::TextRun::rtl):
(WebCore::TextRun::ltr):
(WebCore::TextRun::setDirection):
* platform/text/BidiResolver.h:
(WebCore::BidiStatus::BidiStatus):
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::getAvgCharWidth):
(WebCore::RenderTextControl::paintPlaceholder):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun):
* rendering/svg/SVGTextMetrics.cpp:
(WebCore::constructTextRun):
2011-04-27 Robert Hogan <robert@webkit.org>
Reviewed by Adam Barth.
Allow shadowing of history object
https://bugs.webkit.org/show_bug.cgi?id=55965
Tests: http/tests/history/cross-origin-replace-history-object-child.html
http/tests/history/cross-origin-replace-history-object.html
* page/DOMWindow.idl:
2011-04-27 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Ensure compositing layers are up to date before entering doComposite
https://bugs.webkit.org/show_bug.cgi?id=59159
Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
GraphicsLayerClient::paintContents() implementations).
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::~LayerChromium):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
* platform/graphics/chromium/LayerRendererChromium.h:
Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
2011-04-27 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fix OwnPtr strict issues in chromium linux build
https://bugs.webkit.org/show_bug.cgi?id=59664
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::getNormalizedTextRun):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
2011-04-27 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
https://bugs.webkit.org/show_bug.cgi?id=59641
No new tests since audio API is not yet implemented.
* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):
2011-04-27 Geoffrey Garen <ggaren@apple.com>
Motivated by Alexey Proskuryakov.
* bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
informative, since it confused Alexey and me.
2011-04-27 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
https://bugs.webkit.org/show_bug.cgi?id=59646
Made the cssValueRoots map per-world, instead of a global. When we deallocate
a world, we need to clear all entries in the map for that world, since
the finalizers that would otherwise clear those entries don't run. The
simplest way to do this is just to make the world own the map.
* bindings/js/DOMWrapperWorld.h:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
(WebCore::JSCSSValueOwner::finalize):
* bindings/js/JSDOMBinding.h:
2011-04-27 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix OwnPtr issues in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=59656
I didn't do an exhaustive review of this code, but I fixed the problems
caught by turning on strict OwnPtr and all their antecedents. This
patch is entirely tighter bookkeeping. There shouldn't be any actual
behavior change.
* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::LevelDBDatabase):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::createIterator):
* platform/leveldb/LevelDBDatabase.h:
* platform/leveldb/LevelDBIterator.cpp:
(WebCore::LevelDBIterator::LevelDBIterator):
* platform/leveldb/LevelDBIterator.h:
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
(WebCore::IDBLevelDBBackingStore::open):
(WebCore::getNewDatabaseId):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::getNewObjectStoreId):
(WebCore::deleteRange):
(WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::getNewIndexId):
(WebCore::findGreatestKeyLessThan):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::findLastIndexKeyEqualTo):
* storage/IDBLevelDBBackingStore.h:
2011-04-19 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
https://bugs.webkit.org/show_bug.cgi?id=58113
* Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
* Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
* Now MarkerMapVectorPair is no longer used.
No new tests, No behavior change.
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DocumentMarker.h:
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::copyMarkers):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::markersForNode):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::removeMarkersFromList):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::setRenderedRectForMarker):
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
(WebCore::DocumentMarkerController::shiftMarkers):
(WebCore::DocumentMarkerController::setMarkersActive):
(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
(WebCore::DocumentMarkerController::showMarkers):
* dom/DocumentMarkerController.h:
* dom/RenderedDocumentMarker.h: Added.
(WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
(WebCore::RenderedDocumentMarker::isRendered):
(WebCore::RenderedDocumentMarker::contains):
(WebCore::RenderedDocumentMarker::setRenderedRect):
(WebCore::RenderedDocumentMarker::renderedRect):
(WebCore::RenderedDocumentMarker::invalidate):
(WebCore::RenderedDocumentMarker::invalidMarkerRect):
2011-04-27 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r85112.
http://trac.webkit.org/changeset/85112
https://bugs.webkit.org/show_bug.cgi?id=59159
Broke mac compile
* page/FrameView.cpp:
(WebCore::FrameView::updateCompositingLayers):
* page/FrameView.h:
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::~LayerChromium):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
* platform/graphics/chromium/LayerRendererChromium.h:
2011-04-27 Mark Rowe <mrowe@apple.com>
Build fix.
* WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
2011-04-27 Pratik Solanki <psolanki@apple.com>
Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
* platform/network/ResourceHandleClient.h:
2011-04-27 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Ensure compositing layers are up to date before entering doComposite
https://bugs.webkit.org/show_bug.cgi?id=59159
Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
GraphicsLayerClient::paintContents() implementations).
* page/FrameView.cpp:
(WebCore::FrameView::updateCompositingLayers):
Add an optional CompositingUpdateType parameter.
* page/FrameView.h:
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::~LayerChromium):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
* platform/graphics/chromium/LayerRendererChromium.h:
Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers):
* rendering/RenderLayerCompositor.h:
Fix a typo in CompositingUpdateType Pait->Paint
2011-04-27 Pratik Solanki <psolanki@apple.com>
Reviewed by Antti Koivisto.
Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836
Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
willCacheResponse/shouldCacheResponse.
* loader/EmptyClients.h:
* loader/FrameLoaderClient.h:
* loader/ResourceLoader.h:
* loader/cf/ResourceLoaderCFNet.cpp:
* loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::willCacheResponse):
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::willCacheResponse):
(WebCore::ResourceHandleClient::shouldCacheResponse):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willCacheResponse):
2011-04-27 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Brian Weinstein.
Web Inspector: Stop on Exception state does not persist.
A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
https://bugs.webkit.org/show_bug.cgi?id=59630
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
(WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
(WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
2011-04-27 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, rollout r85075 (scissor rect changes)
https://bugs.webkit.org/show_bug.cgi?id=59020
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2011-04-27 Darin Adler <darin@apple.com>
Reviewed by David Levin.
Fix strict OwnPtr issues seen in about 30 more files
https://bugs.webkit.org/show_bug.cgi?id=59615
* bindings/js/JSCallbackData.h:
(WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
* css/CSSParser.cpp:
(WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
adoptPtr, and release.
* dom/MessageEvent.cpp:
(WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
and release.
* dom/MessagePortChannel.cpp:
(WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
* dom/ScriptExecutionContext.cpp:
(WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
* dom/default/PlatformMessagePortChannel.cpp:
(WebCore::MessagePortChannel::create): Use adoptPtr.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::detach): Use nullptr.
* inspector/InspectorAgent.cpp:
(WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
(WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
(WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend): Use adoptPtr.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
* page/FrameActionScheduler.cpp:
(WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayer::create): Use adoptPtr.
(WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
(WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
(WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
(WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
(WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
(WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
(WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
(WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
explicit initializations of OwnPtr members to 0. Use adoptPtr.
* workers/SharedWorkerContext.cpp:
(WebCore::createConnectEvent): Use adoptPtr.
* workers/Worker.cpp:
(WebCore::Worker::notifyFinished): Use nullptr.
2011-04-27 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>
When we are looking for wrapping elements that are presentational, we should
include elements that have a non transparent background color only if they
are not blocks.
Test: editing/pasteboard/do-not-copy-body-color.html
* editing/markup.cpp:
(WebCore::isElementPresentational):
2011-04-20 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Antti Koivisto.
Teach sub-selector chains about shadow descendants
https://bugs.webkit.org/show_bug.cgi?id=58342
The primary change is to the logic of parsing specifiers:
1) The shadow descendant selectors (those specifiers that are unknown
pseudo element selectors) are always kept at the top of the chain.
2) The sub-selectors after shadow descendant selectors are stashed right
behind the sub-selector, but not at the end of the chain.
3) Other sub-selectors are appended at the end of the chain.
* css/CSSGrammar.y: Changed specifier_list collection to use new
CSSParser::updateSpecifier helper.
* css/CSSParser.cpp:
(WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
look for the last ShadowDescendant relation in the chain of selectors,
because the next selector after it is the one that should get the
element name.
(WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
CSSGrammar.y. The new logic adjusts the selector chain to allow
shadow descendant selectors have sub-selectors (and have multiple shadow
descendants in the chain).
* css/CSSParser.h: Added decl.
* css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::insertTagHistory): Added.
(WebCore::CSSParserSelector::appendTagHistory): Aded.
* css/CSSParserValues.h: Added decls.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
shadow descendant selector match check, since now there could be many
of them in the selector chain.
2011-04-20 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
https://bugs.webkit.org/show_bug.cgi?id=59020
mapRect is the incorrect transform here. The parent scissor rect
needs to be projected into layer space instead.
Test: compositing/flat-with-transformed-child.html
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2011-04-27 Pratik Solanki <psolanki@apple.com>
Reviewed by Antti Koivisto.
Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836
* Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
* platform/mac/SoftLinking.h:
* platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
2011-04-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Antti Koivisto.
Cleanup CSSStyleApplyProperty.cpp
https://bugs.webkit.org/show_bug.cgi?id=59623
As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
Use typedefs instead of repating the function pointer declarations in a few places.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
(WebCore::ApplyPropertyColor::ApplyPropertyColor):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2011-04-27 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=59622
Test: fast/borders/border-image-trumps-radius.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
image, then border radius is ignored, so no bleed avoidance is needed.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
(WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
* rendering/RenderObject.h:
2011-02-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] editing/pasteboard/copy-standalone-image.html fails
https://bugs.webkit.org/show_bug.cgi?id=53645
When writing an image to the clipboard, also write the URL and title
into the markup and URL portion. This change also abstracts a helper
imageToMarkup into markup.{cpp/h} from several different locations
throughout the platform layer.
* editing/markup.h: Added new function definition.
* editing/markup.cpp:
(WebCore::imageToMarkup): Add this function which turns an image URL
and element into some markup representing that image, while preserving
non-src attributes.
* platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
to markup.cpp.
* platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode): Add this helper which gets the appropriate
image URL for a variety of image tag types.
(WebCore::Pasteboard::writeImage): Write the image URL and title to the
markup and URL portions of the clipboard. This will ensure that images
paste properly back into WebKit.
* platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
one from markup.h
2011-04-27 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Remove Android build system
https://bugs.webkit.org/show_bug.cgi?id=48111
This is to avoid the maintenance burden until the Android port is
fully upstreamed.
No new tests, build change only.
* Android.derived.jscbindings.mk: Removed.
* Android.derived.mk: Removed.
* Android.derived.v8bindings.mk: Removed.
* Android.jscbindings.mk: Removed.
* Android.mk: Removed.
* Android.v8bindings.mk: Removed.
2011-04-27 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Somehow about:blank gets into the icon database
https://bugs.webkit.org/show_bug.cgi?id=58067
rdar://problem/6751446
Implemented the policy Brady suggested, where only http and https URLs can
be associated with and icon, guarding both on the way in to the database,
and on the way out.
* loader/icon/IconDatabase.cpp:
(WebCore::pageCanHaveIcon): Added.
(WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
instead of just checking for an empty URL.
(WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
(WebCore::IconDatabase::retainIconForPageURL): Ditto.
(WebCore::IconDatabase::releaseIconForPageURL): Ditto.
(WebCore::IconDatabase::setIconURLForPageURL): Ditto.
(WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
(WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
two separate assertions and added a third.
(WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
* platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
(WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
overloaded it to work on both UChar and char, and added an assertion to it.
Also moved this to the top of the file and made the UChar version usable
in the shared code used even by Google.
(WebCore::KURL::invalidate): Updated for name change.
(WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
toASCIILower since it's faster.
(WebCore::KURL::parse): Updated for name changes.
(WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
since it's faster.
(WebCore::protocolIsInHTTPFamily): Added.
* platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
to protocolIsInHTTPFamily and added a version that works on a string.
Kept the old name as an inline function so we don't have to rename
all the cal sites now.
* platform/KURLGoogle.cpp: Renamed as above.
(WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
(WebCore::KURLGooglePrivate::setUtf8): Ditto.
(WebCore::KURLGooglePrivate::setAscii): Ditto.
(WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
(WebCore::KURLGooglePrivate::copyTo): Ditto.
(WebCore::KURL::KURL): Ditto.
(WebCore::KURL::protocolIsInHTTPFamily): Ditto.
(WebCore::KURL::invalidate): Ditto.
* platform/KURLGooglePrivate.h: Ditto.
* WebCore.exp.in: Updated for above changes.
2011-04-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: browser crash on evaluation of 'throw undefined'
https://bugs.webkit.org/show_bug.cgi?id=59611
Test: inspector/console/console-eval-throw-undefined.html
* inspector/InjectedScriptSource.js: use try/catch to protect from
exception during conversion of another exception to string.
2011-04-27 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: clicking bookmarklet multiplies resources panel entries.
https://bugs.webkit.org/show_bug.cgi?id=59590
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._populateResourceTree):
(WebInspector.FrameTreeElement):
(WebInspector.FrameTreeElement.prototype.appendResource):
* inspector/front-end/inspector.js:
(WebInspector.frontendReused):
2011-04-27 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: opening bookmarklet disconnects DOM agent.
https://bugs.webkit.org/show_bug.cgi?id=59588
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setDocument):
2011-04-27 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Gentilcore.
IndexedDB: Fix compiler warnings about uninitialized variables
https://bugs.webkit.org/show_bug.cgi?id=59599
Build fix. No new tests.
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::getNewObjectStoreId):
(WebCore::getNewIndexId):
2011-04-26 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Gentilcore.
IndexedDB: Move LevelDB key coding routines to separate file
https://bugs.webkit.org/show_bug.cgi?id=59452
Move all routines concerned with encoding, decoding and comparison of
LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
IDBLevelDBCoding.cpp.
This makes IDBLevelDBBackingStore.cpp easier to work with, and will
allow for unit testing of the coding routines.
No new functionality, no new tests.
* WebCore.gypi:
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::getInt):
(WebCore::putInt):
(WebCore::getString):
(WebCore::putString):
(WebCore::compareKeys):
(WebCore::compareIndexKeys):
(WebCore::Comparator::compare):
(WebCore::setUpMetadata):
(WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
(WebCore::getNewDatabaseId):
(WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::getNewObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
(WebCore::getNewVersionNumber):
(WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::clearObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::getNewIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::versionExists):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
* storage/IDBLevelDBCoding.cpp: Added.
(WebCore::IDBLevelDBCoding::encodeByte):
(WebCore::IDBLevelDBCoding::maxIDBKey):
(WebCore::IDBLevelDBCoding::minIDBKey):
(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::decodeInt):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::decodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):
(WebCore::IDBLevelDBCoding::encodeStringWithLength):
(WebCore::IDBLevelDBCoding::decodeStringWithLength):
(WebCore::IDBLevelDBCoding::encodeDouble):
(WebCore::IDBLevelDBCoding::decodeDouble):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
(WebCore::IDBLevelDBCoding::compare):
(WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
(WebCore::IDBLevelDBCoding::KeyPrefix::decode):
(WebCore::IDBLevelDBCoding::KeyPrefix::encode):
(WebCore::IDBLevelDBCoding::KeyPrefix::compare):
(WebCore::IDBLevelDBCoding::KeyPrefix::type):
(WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
(WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
(WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
(WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
(WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
(WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
(WebCore::IDBLevelDBCoding::IndexDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::IndexDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
(WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
(WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
(WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
* storage/IDBLevelDBCoding.h: Added.
(WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
(WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
2011-04-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: expose exception details when script is paused on exception
https://bugs.webkit.org/show_bug.cgi?id=59591
When script is paused on an exception, the exception value is added as <exception>
property in the local scope and the breakpoint details message says
"Paused on excepion: '<exception to strin value>'."
* English.lproj/localizedStrings.js:
* inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
2011-04-26 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [protocol] Paused event should expose exception value that caused it
https://bugs.webkit.org/show_bug.cgi?id=58996
Debug.pause event now contains an optional reference to the exception
object in case script execution is paused on a JavaScript exception.
Also JavaScript call frames are passed directly into the injected script when
we need to wrap them for passing to the front-end. This change breaks cyclic
dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
* bindings/js/JSInjectedScriptHostCustom.cpp:
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidPause):
* bindings/js/ScriptDebugServer.h:
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::breakProgram):
(WebCore::ScriptDebugServer::editScriptSource):
(WebCore::ScriptDebugServer::breakProgramCallback):
(WebCore::ScriptDebugServer::handleV8DebugEvent):
* bindings/v8/ScriptDebugServer.h:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::wrapCallFrames):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
* inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::init):
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::wrapCallFrames):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::didContinue):
(WebCore::InspectorDebuggerAgent::clear):
* inspector/InspectorDebuggerAgent.h:
* inspector/ScriptDebugListener.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
2011-04-27 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: implement incremental CSS editing in the structure view.
https://bugs.webkit.org/show_bug.cgi?id=59455
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
2011-04-27 Mihai Parparita <mihaip@chromium.org>
Reviewed by Eric Seidel.
Frame.h shouldn't include Document.h
https://bugs.webkit.org/show_bug.cgi?id=59560
Frame can use a forward-declared Document if we move
Frame::displayStringModifiedByEncoding's implementation out of the
header.
Size #includes Size * #includes
Before: page/Frame.h: 0.746 653 487.138
dom/Document.h: 0.220 1306 287.320
After: page/Frame.h: 0.646 653 421.838
dom/Document.h: 0.220 1189 261.580
* WebCore.exp.in:
* bindings/ScriptControllerBase.cpp:
* bindings/generic/BindingSecurityBase.cpp:
* bindings/v8/V8Proxy.cpp:
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
* dom/CharacterData.cpp:
* dom/UserTypingGestureIndicator.cpp:
* editing/chromium/SelectionControllerChromium.cpp:
* inspector/InspectorDOMStorageResource.cpp:
* inspector/InspectorInstrumentation.h:
* loader/PingLoader.cpp:
* loader/SubresourceLoader.cpp:
* loader/appcache/DOMApplicationCache.cpp:
* loader/cache/CachedResourceRequest.cpp:
* page/Frame.cpp:
(WebCore::Frame::displayStringModifiedByEncoding):
* page/Frame.h:
* page/Geolocation.cpp:
* page/Location.cpp:
* page/Navigator.cpp:
* page/PageGroupLoadDeferrer.cpp:
* page/PerformanceTiming.cpp:
* xml/XSLTProcessorLibxslt.cpp:
2011-04-27 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59377
This cleans up some strict OwnPtr<> violations around text and box shadow data. ShadowData's linked list data
structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperShadow::blend):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setTextShadow):
(WebCore::RenderStyle::setBoxShadow):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::textShadow):
* rendering/style/ShadowData.cpp:
(WebCore::ShadowData::ShadowData):
* rendering/style/ShadowData.h:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::next):
(WebCore::ShadowData::setNext):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::~StyleRareInheritedData):
* rendering/style/StyleRareInheritedData.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2011-04-26 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
Fix some strict PassOwnPtr issues in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=59563
* css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
* platform/text/TextCodecLatin1.cpp:
(WebCore::newStreamingTextDecoderWindowsLatin1):
* platform/text/TextCodecUTF16.cpp:
(WebCore::newStreamingTextDecoderUTF16LE):
(WebCore::newStreamingTextDecoderUTF16BE):
* platform/text/TextCodecUserDefined.cpp:
(WebCore::newStreamingTextDecoderUserDefined):
* platform/text/mac/TextCodecMac.cpp:
(WebCore::newTextCodecMac):
* workers/Worker.cpp:
(WebCore::Worker::notifyFinished):
2011-04-26 Justin Novosad <junov@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Expose skia gpu canvas rendering as a runtime flag
https://bugs.webkit.org/show_bug.cgi?id=58683
Replace the SKIA_GPU compile flag by the pre-existing
acceleratedDrawingEnabled flag. Most code changes are trivial:
compile-time conditionals on SKIA_GPU were either replaced with
a run-time check, or a compile time check on USE(SKIA)
No new tests. Covered by existing tests.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
* page/Page.cpp:
(WebCore::Page::sharedGraphicsContext3D):
Added check for the acceleratedDrawing flag.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):
* platform/graphics/gpu/DrawingBuffer.h:
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::create):
On Skia builds, this methos now receives a bool arg to turn on
GPU-accelerated skia rendering
(WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
(WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
(WebCore::SharedGraphicsContext3D::grContext):
* platform/graphics/gpu/SharedGraphicsContext3D.h:
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::computeResamplingMode):
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::~PlatformContextSkia):
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
(WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
(WebCore::PlatformContextSkia::prepareForSoftwareDraw):
(WebCore::PlatformContextSkia::prepareForHardwareDraw):
(WebCore::PlatformContextSkia::syncSoftwareCanvas):
(WebCore::PlatformContextSkia::markDirtyRect):
* platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::accelerationMode):
(WebCore::PlatformContextSkia::useGPU):
(WebCore::PlatformContextSkia::useSkiaGPU):
2011-04-26 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: restore inspector test disabled in r84913.
Test: http/tests/inspector-enabled/dom-storage-open.html
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::clearFrontend):
2011-04-26 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Tony Chang.
[Chromium] Vertical positions are off for some Arabic glyphs on Linux
https://bugs.webkit.org/show_bug.cgi?id=59182
Use vertical offsets of the shaping results.
Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::ComplexTextController):
Added initialization of m_startingY.
(WebCore::ComplexTextController::nextScriptRun):
Followed the change in handling positions.
(WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
(WebCore::ComplexTextController::createGlyphArrays): Ditto.
(WebCore::ComplexTextController::resetGlyphArrays): Ditto.
(WebCore::ComplexTextController::setGlyphPositions):
Changed to use vertical offsets as same as horizontal offsets.
* platform/graphics/chromium/ComplexTextControllerLinux.h:
Removed m_xPositions and Added m_positions and m_startingY.
(WebCore::ComplexTextController::positions): Added.
* platform/graphics/chromium/FontLinux.cpp:
Followed the change in ComplexTextController.
(WebCore::Font::drawComplexText): Ditto.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::glyphIndexForXPositionInScriptRun): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.
(WebCore::Font::selectionRectForComplexText): Ditto.
2011-04-26 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Root element should establish a new block formatting context
https://bugs.webkit.org/show_bug.cgi?id=54573
Always expanding the root renderer to include overhanging floats.
Test: fast/block/float/float-overhangs-root.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
2011-04-26 Dawit Alemayehu <adawit@kde.org>
Reviewed by Andreas Kling.
[Qt] Improper rendering of <button> tag when it contains a <br>
https://bugs.webkit.org/show_bug.cgi?id=50521
Test: platform/qt/fast/forms/button-line-break.html
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::setButtonPadding):
2011-04-26 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Only reset tiles if the LayerRendererChromium is actually changing
https://bugs.webkit.org/show_bug.cgi?id=59572
http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
when LayerRendererChromium was set. We set this pointer every frame
and should only reset the tiles if the new LayerRendererChromium is
different from the old one (indicating a context loss), not just reset
on every frame.
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::setLayerRenderer):
* platform/graphics/chromium/LayerTilerChromium.h:
2011-04-26 Dinesh K Garg <dineshg@codeaurora.org>
Reviewed by Eric Seidel.
beginElement broken by setAttribute
https://bugs.webkit.org/show_bug.cgi?id=26019
Test: svg/animations/animate-beginElementAt.svg
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::attributeChanged):
Reset the animation state here as the rest of the code reads it and would still
think we are animating when we are not.
* svg/animation/SVGSMILElement.h:
(WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
2011-04-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84989.
http://trac.webkit.org/changeset/84989
https://bugs.webkit.org/show_bug.cgi?id=59566
REGRESSION (r84989): Lots of vertical text tests failing on
windows (Requested by weinig on #webkit).
* platform/graphics/FontPlatformData.h:
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
2011-04-26 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel.
Try again:
Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
https://bugs.webkit.org/show_bug.cgi?id=59310
* bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::createStructure):
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
2011-04-26 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* Android.jscbindings.mk:
* Android.v8bindings.mk:
* CMakeLists.txt:
* CodeGenerators.pri:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* GNUmakefile.list.am:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDataGridColumnListCustom.cpp: Removed.
* bindings/js/JSDataGridDataSource.cpp: Removed.
* bindings/js/JSDataGridDataSource.h: Removed.
* bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
* bindings/v8/V8DataGridDataSource.cpp: Removed.
* bindings/v8/V8DataGridDataSource.h: Removed.
* bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
* bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
* css/CSSStyleSelector.cpp:
* css/CSSStyleSelector.h:
* css/html.css:
(input, textarea, keygen, select, button, isindex):
(select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
* editing/htmlediting.cpp:
(WebCore::canHaveChildrenForEditing):
* features.pri:
* html/DOMDataGridDataSource.cpp: Removed.
* html/DOMDataGridDataSource.h: Removed.
* html/DataGridColumn.cpp: Removed.
* html/DataGridColumn.h: Removed.
* html/DataGridColumn.idl: Removed.
* html/DataGridColumnList.cpp: Removed.
* html/DataGridColumnList.h: Removed.
* html/DataGridColumnList.idl: Removed.
* html/DataGridDataSource.h: Removed.
* html/HTMLDataGridCellElement.cpp: Removed.
* html/HTMLDataGridCellElement.h: Removed.
* html/HTMLDataGridCellElement.idl: Removed.
* html/HTMLDataGridColElement.cpp: Removed.
* html/HTMLDataGridColElement.h: Removed.
* html/HTMLDataGridColElement.idl: Removed.
* html/HTMLDataGridElement.cpp: Removed.
* html/HTMLDataGridElement.h: Removed.
* html/HTMLDataGridElement.idl: Removed.
* html/HTMLDataGridRowElement.cpp: Removed.
* html/HTMLDataGridRowElement.h: Removed.
* html/HTMLDataGridRowElement.idl: Removed.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::ieForbidsInsertHTML):
* html/HTMLElementsAllInOne.cpp:
* html/HTMLTagNames.in:
* page/DOMWindow.idl:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
* rendering/RenderDataGrid.cpp: Removed.
* rendering/RenderDataGrid.h: Removed.
* rendering/RenderingAllInOne.cpp:
2011-04-26 Chun-Lung Huang <alvincl.huang@gmail.com>
Reviewed by Adele Peterson.
On WebKit (Windows), glyphs in vertical text tests are rotated 90
degrees clockwise. https://bugs.webkit.org/show_bug.cgi?id=48459
This platform dependent patch makes WebKit (Windows) show the
vertical writing text correctly. Job was done by adding a prefix '@'
in front of the font family name (Windows Only). No new tests added.
Some layout tests images:
http://www.flickr.com/photos/burorly/sets/72157625585506341/
* platform/graphics/FontPlatformData.h:
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
2011-04-26 Jer Noble <jer.noble@apple.com>
Reviewed by Brady Eidson.
HTML5 video fullscreen transition causes an audio stutter
https://bugs.webkit.org/show_bug.cgi?id=59544
AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer
from its AVPlayer. Since you shouldn't necessarily have to destroy the
layer to render it invisible, instead just set the layer as hidden.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
2011-04-26 Christian Dywan <christian@lanedo.com>
Reviewed by Eric Seidel.
Extra separator after Select All in context menu
https://bugs.webkit.org/show_bug.cgi?id=54092
* page/ContextMenuController.cpp: Move separator to non-GTK+
port guards since it is for the spelling options menu
which the GTK+ port doesn't use.
2011-04-26 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Clear out LayerTilerChromium's tiles on lost context
https://bugs.webkit.org/show_bug.cgi?id=59233
Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset. In this case the tiles are
no longer valid since they exist in the previous LayerRendererChromium.
Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
* platform/graphics/chromium/LayerTilerChromium.h:
(WebCore::LayerTilerChromium::setLayerRenderer):
2011-04-26 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[GTK] Flash in divs with overflow: auto is not positioned and clipped properly
https://bugs.webkit.org/show_bug.cgi?id=57644
Manual test: plugins/windowed-in-iframe-2.html
* manual-tests/plugins/windowed-in-iframe-2.html: Added.
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
* plugins/PluginView.h: Added helper method to set the allocation and clip.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
the allocation immediately. Bring this method into sync with the implementation in
the Qt port.
(WebCore::PluginView::updateWidgetAllocationAndClip): Added.
(WebCore::PluginView::plugAddedCallback): Call the new helper method.
2011-04-26 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] fast/block/float/overhanging-tall-block.html crashes in the bots
https://bugs.webkit.org/show_bug.cgi?id=58818
Prevent allocating scratch buffers larger than the target GdkDrawable
when creating a WidgetRenderingContext. This prevents incredibly large
widgets from crashing the X Server. This change also allowed greatly
simplifying the way that the painting offset is calculated.
* platform/gtk/WidgetRenderingContext.cpp:
(WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
larger than the target GdkDrawable.
(WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
blit by looking at the location of the target rect itself, rather than delaying the
calculation up to this point.
(WebCore::WidgetRenderingContext::calculateClipRect): Added.
(WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
(WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
(WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
(WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
(WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
(WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
(WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
(WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
(WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
* platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
a member to store the IntSize mapping from the coordinates of the target to the coordinates
of the scratch buffer.
2011-04-26 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Respect charset in handleDataURL
https://bugs.webkit.org/show_bug.cgi?id=47746
Original patch by Kwang Yul Seo <skyul@company100.net>
We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
returns an empty string because encoding name is not specified.
Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
This change fixes over 130 layout tests when running GTK port with cURL network backend.
* platform/network/DataURL.cpp:
(WebCore::handleDataURL):
2011-04-26 Anders Carlsson <andersca@apple.com>
Fix clang++ build.
You can never have too many casts!
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper position]):
* editing/mac/SelectionControllerMac.mm:
(WebCore::accessibilityConvertScreenRect):
2011-04-26 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Fix web audio build on mac port
https://bugs.webkit.org/show_bug.cgi?id=59355
No new tests since audio API is not yet implemented.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContext::visitChildren):
* bindings/js/JSJavaScriptAudioNodeCustom.cpp:
(WebCore::JSJavaScriptAudioNode::visitChildren):
* webaudio/AudioContext.idl:
2011-04-26 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add FFTFrame implementation for FFmpeg
https://bugs.webkit.org/show_bug.cgi?id=59408
No new tests since audio API is not yet implemented.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/audio/FFTFrame.h:
* platform/audio/FFTFrameStub.cpp:
* platform/audio/ffmpeg: Added.
* platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::getUpToDateComplexData):
(WebCore::FFTFrame::contextForSize):
* platform/audio/mac/FFTFrameMac.cpp:
* webaudio/ConvolverNode.cpp:
2011-04-26 Jeff Miller <jeffm@apple.com>
Add a newline at the end of SVGFEDropShadowElement.idl.
* svg/SVGFEDropShadowElement.idl:
2011-04-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Eric Seidel.
InlineBox.h shouldn't include RenderBR.h
https://bugs.webkit.org/show_bug.cgi?id=59480
Per bug 59348 RenderBR.h is a "top header" by include * size, because
InlineBox.h includes it. There's no reason why it has to.
* rendering/InlineBox.h:
* rendering/InlineTextBox.cpp:
* rendering/RenderBlock.h:
2011-04-26 Sam Weinig <sam@webkit.org>
Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
I should do.
* bindings/js/JSDOMBinding.h:
(WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
(WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
(WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
(WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
2011-04-26 Sam Weinig <sam@webkit.org>
Fix build.
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
2011-04-26 Sam Weinig <sam@webkit.org>
Roll r84945 back in with infinite recursion removed.
* bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::createStructure):
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
2011-04-26 Sam Weinig <sam@webkit.org>
Rollout previous patch. It broke stuff.
* bindings/js/JSDOMBinding.h:
(WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
(WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
(WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
(WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
2011-04-26 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
https://bugs.webkit.org/show_bug.cgi?id=59310
* bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::createStructure):
(WebCore::JSDOMWrapper::JSDOMWrapper):
Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
* bindings/scripts/CodeGeneratorJS.pm:
Make JSDOMWrapper the base class.
2011-04-26 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
Choose the compiler based on the Xcode version for Snow Leopard debug builds.
* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Added.
2011-04-26 Adrienne Walker <enne@google.com>
Reviewed by Geoffrey Garen.
Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
https://bugs.webkit.org/show_bug.cgi?id=59469
* platform/chromium/TraceEvent.h:
(WebCore::internal::ScopeTracer::ScopeTracer):
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Nixed special finalizer handling for WebCore strings
https://bugs.webkit.org/show_bug.cgi?id=59425
Not needed anymore, since weak handles have finalizers.
* WebCore.exp.in: Exports!
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::JSStringOwner::finalize):
(WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
so we don't need special treatment anymore.
* bindings/js/DOMWrapperWorld.h:
(WebCore::JSStringOwner::JSStringOwner):
(WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
instead of a WeakGCMap, so we can specify a custom finalizer.
* bindings/js/JSDOMBinding.cpp:
(WebCore::jsStringSlowCase):
* bindings/js/JSDOMBinding.h:
(WebCore::jsString): Updated for string map change.
2011-04-26 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
Reviewed by Antti Koivisto.
To enable HTTP pipelining post-SnowLeopard, use this command:
defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::readBooleanPreference): Re-added. Originally added in
r76756 and removed in r84120.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
HTTP pipelining if use default is set to true. Added macro
guards to match those in ResourceRequestMac.mm.
2011-04-26 Antti Koivisto <antti@apple.com>
Reviewed by Adele Peterson.
Don't strip fragments from file: urls in memory cache
https://bugs.webkit.org/show_bug.cgi?id=59463
<rdar://problem/9231130>
Some clients expect file: resources to be unique based on fragment identifier.
Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
Test: fast/loader/file-protocol-fragment.html
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
2011-04-26 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Fix more strict OwnPtr in WebCore (round N).
https://bugs.webkit.org/show_bug.cgi?id=59464
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::attach):
* fileapi/FileReader.cpp:
(WebCore::FileReader::terminate):
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::preflightFailure):
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerConnectTask::create):
(WebCore::SharedWorkerScriptLoader::load):
2011-04-26 Ruben <chromium@hybridsource.org>
Reviewed by Tony Chang.
Change linux ifdefs for Chromium to Unix instead, allowing
new Unix ports to be enabled by default
https://bugs.webkit.org/show_bug.cgi?id=59297
No new tests, just changing preprocessor defines.
* bindings/js/JSInspectorFrontendHostCustom.cpp:
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
* dom/SelectElement.cpp:
* loader/cache/CachedFont.cpp:
* page/EventHandler.cpp:
* page/chromium/EventHandlerChromium.cpp:
* platform/Scrollbar.cpp:
* platform/chromium/PlatformBridge.h:
* platform/graphics/chromium/FontPlatformData.h:
* platform/graphics/skia/FontCustomPlatformData.cpp:
* platform/graphics/skia/FontCustomPlatformData.h:
2011-04-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
[RTL] Arabic/AB - after typing a date, cursors doesn't go back
https://bugs.webkit.org/show_bug.cgi?id=49111
Even when the offset corresponds to a position visually left of the box
and there aren't any inline boxes on the left, the previous/next position
may still correspond to some position in the same line.
The bug was caused by our ignoring such cases. Fixed the bug by comparing
previous/next position's inline box to the current box. If they match,
then we stay on the same position because moving to the left visually at
the left edge should not result in a position on the same line.
Also fixed a bug that WebKit uses offsets that are not extrema when moved to
the left edge or to the right edge, and a bug that WebKit could not move to
the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
Test cases are added to editing/selection/move-left-right.html
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
2011-04-26 Gabor Loki <loki@webkit.org>
Reviewed by Csaba Osztrogonác.
Speeding up SVG filters with multicore (SMP) support
https://bugs.webkit.org/show_bug.cgi?id=43903
Some SVG filters execute a huge number of pixel manipulations, which
cannot be sped up by graphics accelerators, since their algorithm is
too complex. Using the power of Symmetric Multi Processing (SMP) we
can split up a task to smaller (data independent) tasks, which can be
executed independently.
The ParallelJobs framework provides a simple way for distributed
programming. The framework is based on WebKit's threading infrastructure,
Open Multi-Processing's (OpenMP) API, and libdispatch API.
* ForwardingHeaders/wtf/ParallelJobs.h: Added.
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::PaintingData::PaintingData):
(WebCore::FETurbulence::noise2D):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint):
(WebCore::FETurbulence::fillRegion):
(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::apply):
* platform/graphics/filters/FETurbulence.h:
2011-04-26 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: close button is off in docked mode on a mac.
https://bugs.webkit.org/show_bug.cgi?id=59453
* inspector/front-end/inspector.css:
(.toolbar-item.close-left):
2011-04-26 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: New Style is not working (UI glitch)
https://bugs.webkit.org/show_bug.cgi?id=59451
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::setFrontend):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype._documentElementId):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._addAttribute):
(WebInspector.DOMNode.prototype.documentElement):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.PageDispatcher.prototype.frameDetached):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._createNewRule):
2011-04-26 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce DOMStorage::enable and disable.
https://bugs.webkit.org/show_bug.cgi?id=59445
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::restore):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
* inspector/InspectorDOMStorageAgent.h:
(WebCore::InspectorDOMStorageAgent::create):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._reset):
* inspector/front-end/inspector.js:
2011-04-26 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
https://bugs.webkit.org/show_bug.cgi?id=59440
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::setFrontend):
(WebCore::InspectorPageAgent::frameNavigated):
* inspector/InspectorPageAgent.h:
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype._onLoadEventFired):
(WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModelResourceBinding):
(WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane):
(WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._inspectedURLChanged):
(WebInspector.ExtensionServer.prototype.initExtensions):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel):
(WebInspector.NetworkPanel.prototype._onLoadEventFired):
(WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
(WebInspector.NetworkPanel.prototype._frameNavigated):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
(WebInspector.PageDispatcher):
(WebInspector.PageDispatcher.prototype.domContentEventFired):
(WebInspector.PageDispatcher.prototype.loadEventFired):
(WebInspector.PageDispatcher.prototype.frameNavigated):
(WebInspector.PageDispatcher.prototype.frameDetached):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._onLoadEventFired):
(WebInspector.ResourcesPanel.prototype._frameNavigated):
* inspector/front-end/inspector.js:
2011-04-26 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
because it broke transitions/multiple-text-shadow-transition.html
Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59377
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* page/animation/AnimationBase.cpp:
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperShadow::blend):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setTextShadow):
(WebCore::RenderStyle::setBoxShadow):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::textShadow):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::~StyleRareInheritedData):
* rendering/style/StyleRareInheritedData.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2011-04-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Turn off make built-in implicit rules for derived sources makefile
https://bugs.webkit.org/show_bug.cgi?id=59418
We don't use any of make's built-in implicit rules, turning them off
speeds up parsing of the makefile.
* WebCore.xcodeproj/project.pbxproj:
* gyp/generate-derived-sources.sh:
2011-04-26 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
ASSERT failure in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=59313
In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
was wrong because the document may not be well-formed.
This patch asserts the element is not pending on resource or the
document is not well-formed.
Test: svg/custom/use-crash-in-non-wellformed-document.svg
* svg/SVGUseElement.cpp:
(WebCore::isWellFormedDocument):
(WebCore::SVGUseElement::insertedIntoDocument):
2011-04-26 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
https://bugs.webkit.org/show_bug.cgi?id=59438
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._changeView):
2011-04-26 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
Fix a few OwnPtr strict errors in WebCore headers.
https://bugs.webkit.org/show_bug.cgi?id=59431
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
* css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
* dom/NodeRareData.h:
(WebCore::NodeListsNodeData::create):
* dom/ScriptRunner.h:
(WebCore::ScriptRunner::create):
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::connectFrontend):
* loader/icon/IconDatabase.h:
(WebCore::IconDatabase::create):
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
* rendering/svg/SVGResources.h:
(WebCore::SVGResources::ClipperFilterMaskerData::create):
(WebCore::SVGResources::MarkerData::create):
(WebCore::SVGResources::FillStrokeData::create):
* storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::close):
* workers/WorkerContext.cpp:
(WebCore::CloseWorkerContextTask::create):
* workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerTask::create):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerContextDestroyedTask::create):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerThreadActivityReportTask::create):
* workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::Task::create):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
(WebCore::WorkerThreadShutdownFinishTask::create):
(WebCore::WorkerThreadShutdownStartTask::create):
2011-04-26 Adam Klein <adamk@chromium.org>
Reviewed by Adam Barth.
Fix last strict OwnPtr violation under svg/...
https://bugs.webkit.org/show_bug.cgi?id=59429
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::removePendingResource):
2011-04-26 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix more strict OwnPtr violations in WebCore
https://bugs.webkit.org/show_bug.cgi?id=59433
These manifest in the Chromium build.
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::editScriptSource):
* bindings/v8/V8DOMMap.cpp:
(WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::precompileScript):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::speechInput):
* platform/PlatformGestureRecognizer.cpp:
(WebCore::PlatformGestureRecognizer::create):
* platform/PlatformGestureRecognizer.h:
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::create):
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::decodeHelper):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::decode):
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::decodeAtIndex):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::decode):
* storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
2011-04-25 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
Fix OwnPtr strict errors in CrossThreadTask.h
https://bugs.webkit.org/show_bug.cgi?id=59427
* dom/CrossThreadTask.h:
(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask8::create):
2011-04-25 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
* css/CSSStyleApplyProperty.h:
(WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
2011-04-25 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
REGRESSION: a character appears after tab span when typing immediately before the tab span
https://bugs.webkit.org/show_bug.cgi?id=58132
Correcting the order of operations we use to avoid inserting into invalid positions in
ReplaceSelectionCommand to avoid inserting into tab-spans.
Test: editing/pasteboard/paste-before-tab-span.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
positionAvoidingPrecedingNodes, since that function could once again put our position
inside a tab span.
2011-04-25 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
Fix OwnPtr strict error in ImageBuffer.h
https://bugs.webkit.org/show_bug.cgi?id=59422
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtr violations and whitelist known-tricky files
https://bugs.webkit.org/show_bug.cgi?id=59421
With this patch, WebCore builds cleanly with strict OwnPtrs.
* dom/MessagePort.cpp:
(WebCore::MessagePort::MessagePort):
* dom/XMLDocumentParserLibxml2.cpp:
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::ContextMenuController):
(WebCore::ContextMenuController::clearContextMenu):
* page/PluginHalter.cpp:
* platform/graphics/MediaPlayer.cpp:
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
* svg/SVGDocumentExtensions.cpp:
2011-04-25 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
Fix OwnPtr strict errors in DatasetDOMStringMap.h.
https://bugs.webkit.org/show_bug.cgi?id=59419
* dom/DatasetDOMStringMap.h:
(WebCore::DatasetDOMStringMap::create):
2011-04-25 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Eric Seidel.
KeyboardEvent.cpp should work with strict OwnPtrs.
https://bugs.webkit.org/show_bug.cgi?id=59403
* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::KeyboardEvent):
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59377
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* page/animation/AnimationBase.cpp:
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperShadow::blend):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setTextShadow):
(WebCore::RenderStyle::setBoxShadow):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::textShadow):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::~StyleRareInheritedData):
* rendering/style/StyleRareInheritedData.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2011-04-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84864.
http://trac.webkit.org/changeset/84864
https://bugs.webkit.org/show_bug.cgi?id=59413
Expect result of use-crash-in-non-wellformed-document.svg is
platform dependent (Requested by leoyang on #webkit).
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedIntoDocument):
2011-04-25 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
ASSERT failure in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=59313
In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
was wrong because the document may not be well-formed.
This patch asserts the element is not pending on resource or the
document is not well-formed.
Test: svg/custom/use-crash-in-non-wellformed-document.svg
* svg/SVGUseElement.cpp:
(WebCore::isWellFormedDocument):
(WebCore::SVGUseElement::insertedIntoDocument):
2011-04-25 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Tony Chang.
Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
https://bugs.webkit.org/show_bug.cgi?id=59028
The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
Moving the code for base class we can reduce the efforts to support DataTransferItems
element in different platforms.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DataTransferItem.cpp:
(WebCore::DataTransferItem::DataTransferItem):
(WebCore::DataTransferItem::owner):
(WebCore::DataTransferItem::kind):
(WebCore::DataTransferItem::type):
* dom/DataTransferItem.h:
* dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
(WebCore::DataTransferItems::DataTransferItems):
(WebCore::DataTransferItems::length):
(WebCore::DataTransferItems::item):
(WebCore::DataTransferItems::deleteItem):
(WebCore::DataTransferItems::clear):
(WebCore::DataTransferItems::add):
* dom/DataTransferItems.h:
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItem::create):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
* platform/chromium/DataTransferItemChromium.h:
* platform/chromium/DataTransferItemsChromium.cpp:
(WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
* platform/chromium/DataTransferItemsChromium.h:
2011-04-25 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
REGRESSION(75137): directly composited images are double-drawn sometimes
https://bugs.webkit.org/show_bug.cgi?id=58632
Depending on the order of operations (layout, creating compositing
layers and creating simple image layers) a layer can have both image
content and have m_drawsContent=true. In this case 2 copies of the image
are drawn in the layer. If the image has alpha, it looks wrong.
I added an updateDrawsContent() call after setting the image contents
to make sure it's correct.
I couldn't create a test case that shows the problem because layerTreeAsText()
doesn't emit enough info to show this level of detail. I've opened
https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateImageContents):
2011-04-25 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Fix OwnPtr strict errors in InlineFlowBox.cpp
https://bugs.webkit.org/show_bug.cgi?id=59392
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):
2011-04-25 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Fix OwnPtr strict errors in TransformState.cpp
https://bugs.webkit.org/show_bug.cgi?id=59380
* rendering/TransformState.cpp:
(WebCore::TransformState::applyTransform):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
DOMWindow.cpp should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59356
* page/DOMWindow.cpp:
(WebCore::PostMessageTimer::fired):
(WebCore::DOMWindow::postMessageTimerFired):
* page/DOMWindow.h:
2011-04-25 Adam Klein <adamk@chromium.org>
Reviewed by James Robinson.
Fix OwnPtr strict errors in some SVG classes.
https://bugs.webkit.org/show_bug.cgi?id=59395
* rendering/style/SVGRenderStyleDefs.cpp:
(WebCore::StyleShadowSVGData::StyleShadowSVGData):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::supplementalTransform):
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::supplementalTransform):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
2011-04-25 Adam Barth <abarth@webkit.org>
Re-land changes to ValidationMessage.
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::setMessage):
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
(WebCore::ValidationMessage::requestToHideMessage):
2011-04-25 Ojan Vafai <ojan@chromium.org>
Reviewed by James Robinson.
fix OwnPtr strict error in FrameView.cpp
https://bugs.webkit.org/show_bug.cgi?id=59402
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::addWidgetToUpdate):
2011-04-25 Adam Klein <adamk@chromium.org>
Unreviewed, rolling out r84844.
http://trac.webkit.org/changeset/84844
https://bugs.webkit.org/show_bug.cgi?id=59395
Checked in too much.
* rendering/style/SVGRenderStyleDefs.cpp:
(WebCore::StyleShadowSVGData::StyleShadowSVGData):
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::removePendingResource):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::supplementalTransform):
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::supplementalTransform):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
2011-04-25 Adrienne Walker <enne@google.com>
Reviewed by David Levin.
Make ActiveDOMCallback play nice with OwnPtr strict mode
https://bugs.webkit.org/show_bug.cgi?id=59398
* bindings/generic/ActiveDOMCallback.cpp:
(WebCore::ActiveDOMCallback::ActiveDOMCallback):
2011-04-25 Adam Klein <adamk@chromium.org>
Reviewed by James Robinson.
Fix OwnPtr strict errors in some SVG classes.
https://bugs.webkit.org/show_bug.cgi?id=59395
* rendering/style/SVGRenderStyleDefs.cpp:
(WebCore::StyleShadowSVGData::StyleShadowSVGData):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::supplementalTransform):
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::supplementalTransform):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
2011-04-25 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r84835.
http://trac.webkit.org/changeset/84835
https://bugs.webkit.org/show_bug.cgi?id=59394
Breaks compile because Deque<OwnPtr> doesn't work
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::PendingCallbacks::~PendingCallbacks):
(WebCore::PendingCallbacks::appendStartElementNSCallback):
(WebCore::PendingCallbacks::appendEndElementNSCallback):
(WebCore::PendingCallbacks::appendCharactersCallback):
(WebCore::PendingCallbacks::appendProcessingInstructionCallback):
(WebCore::PendingCallbacks::appendCDATABlockCallback):
(WebCore::PendingCallbacks::appendCommentCallback):
(WebCore::PendingCallbacks::appendInternalSubsetCallback):
(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::XMLDocumentParser::XMLDocumentParser):
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::setMessage):
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
(WebCore::ValidationMessage::requestToHideMessage):
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Sam Weinig.
Fix OwnPtr strict mode violation in ImageBufferCG
https://bugs.webkit.org/show_bug.cgi?id=59396
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
2011-04-25 Huang Dongsung <luxtella@company100.net>
Reviewed by Dirk Schulze.
[Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
https://bugs.webkit.org/show_bug.cgi?id=59308
An unused local variable is created and even allocates heap memory.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::readbackHardwareToSoftware):
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Qt build fix: Updated files not used by other ports for rename.
* bindings/js/JSTouchCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSTouchListCustom.cpp:
(WebCore::toJSNewlyCreated):
2011-04-25 Adrienne Walker <enne@google.com>
Reviewed by David Levin.
WebCore/css/CSS* files should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59382
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
* css/CSSParser.cpp:
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parseValue):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59394
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::PendingCallbacks::PendingCallbacks):
(WebCore::PendingCallbacks::appendStartElementNSCallback):
(WebCore::PendingCallbacks::appendEndElementNSCallback):
(WebCore::PendingCallbacks::appendCharactersCallback):
(WebCore::PendingCallbacks::appendProcessingInstructionCallback):
(WebCore::PendingCallbacks::appendCDATABlockCallback):
(WebCore::PendingCallbacks::appendCommentCallback):
(WebCore::PendingCallbacks::appendInternalSubsetCallback):
(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::XMLDocumentParser::XMLDocumentParser):
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::setMessage):
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
(WebCore::ValidationMessage::requestToHideMessage):
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fix OwnPtr strictness issues in WebCore/inspector/
https://bugs.webkit.org/show_bug.cgi?id=59387
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::ensureSourceData):
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Beth Dakin.
Removed XPathNamespace because it was unused
https://bugs.webkit.org/show_bug.cgi?id=59381
This allows us to make Node::ownerDocument() non-virtual, though it has
the unhappy side-effect of rebuilding the world.
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
* dom/Node.h: Hello fast code!
* xml/XPathNamespace.cpp: Removed.
* xml/XPathNamespace.h: Removed.
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
HistoryItemMac should play nice with OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59388
* history/mac/HistoryItemMac.mm:
(WebCore::HistoryItem::setTransientProperty):
2011-04-25 David Levin <levin@chromium.org>
Reviewed by Kenneth Russell.
Fix strict OwnPtrs in ContextMenuController.cpp
https://bugs.webkit.org/show_bug.cgi?id=59375
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::createContextMenu):
(WebCore::separatorItem):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
CheckedRadioButton should play nice with strict OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59386
* dom/CheckedRadioButtons.cpp:
(WebCore::CheckedRadioButtons::addButton):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Resource*.cpp should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59383
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::RuntimeMethod):
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::ResourceHandle):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::copyData):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59374
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::initGroup):
* page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
* page/mac/PageMac.cpp:
(WebCore::Page::addSchedulePair):
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Build fix: This time for sure!
* dom/make_names.pl:
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Build fix: Let's edit the script instead of the autogenrated file. That
way, our change will stand the test of time.
* dom/make_names.pl:
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
https://bugs.webkit.org/show_bug.cgi?id=59368
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
* platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fix strict OwnPtr violations in Render*.cpp
https://bugs.webkit.org/show_bug.cgi?id=59361
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::finishDelayUpdateScrollInfo):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::addVisualOverflow):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::styleDidChange):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateTransform):
(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):
(WebCore::RenderLayer::ensureBacking):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::styleDidChange):
* rendering/RenderView.cpp:
(WebCore::RenderView::compositor):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::addCachedPseudoStyle):
(WebCore::RenderStyle::accessCounterDirectives):
(WebCore::RenderStyle::accessAnimations):
(WebCore::RenderStyle::accessTransitions):
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
* rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::SVGResources):
2011-04-25 Adam Barth <abarth@webkit.org>
Attempt to fix the compile.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::loadWithNextMediaEngine):
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Rubber-stamped by Beth Dakin.
Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into
CREATE_DOM_WRAPPER because there's no meaningful difference between
them anymore.
* bindings/js/JSCDATASectionCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS):
* bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
* bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
* bindings/js/JSTextCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSWebKitCSSMatrixCustom.cpp:
(WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocketConstructor::constructJSWebSocket):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):
* bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
HTMLDocumentParser should play nice with OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59363
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
Frame.cpp should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59360
* page/Frame.cpp:
(WebCore::createRegExpForLabels):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtr in Element.cpp
https://bugs.webkit.org/show_bug.cgi?id=59357
* dom/NodeRareData.h:
(WebCore::NodeRareData::ensureEventTargetData):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Fix strict OwnPtr issues in Media*.cpp
https://bugs.webkit.org/show_bug.cgi?id=59354
There's still a tricky case in MediaPlayer.cpp, but we'll worry about
that later.
* css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::addListener):
* dom/Document.cpp:
* platform/graphics/MediaPlayer.cpp:
(WebCore::createNullMediaPlayer):
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by David Levin.
Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=59353
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
Worker*.cpp should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59346
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::WorkerContext):
* workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::WorkerRunLoop):
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::createResourceRequest):
2011-04-25 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Remove bad use of OwnPtr::set() in IconDatabase.cpp
https://bugs.webkit.org/show_bug.cgi?id=59344
Needed for strict OwnPtr compliance.
* loader/icon/IconDatabase.cpp:
(WebCore::readySQLiteStatement):
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
ImageBuffer.h should work with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59341
This patch is to prepare for the strict OwnPtr hack-a-thon.
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
2011-04-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Brian Weinstein.
WebCore build on Windows should include windows.h in its precompiled header to speed builds
https://bugs.webkit.org/show_bug.cgi?id=59339
windows.h is included by several of the underlying wtf headers, including Atomics.h and
ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation.
On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes
(a 12% speedup).
* WebCorePrefix.h: Include windows.h
2011-04-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint()
https://bugs.webkit.org/show_bug.cgi?id=59311
* platform/gtk/MainFrameScrollbarGtk.cpp:
(MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar
disconnect any lingering signal handlers. This prevents an adjustment from controlling the
active ScrollView and some zombie ScrollView.
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Another shot at fixing the EFL build.
* UseJSC.cmake:
* bindings/js/JSDOMBinding.cpp:
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Try to fix EFL build.
* UseJSC.cmake: Added a missing file.
2011-04-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts
https://bugs.webkit.org/show_bug.cgi?id=59333
* WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing.
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDocumentCustom.cpp:
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::visitChildren): Removed now-unused functions.
* bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject
lifetime management.
* dom/Document.idl: No need for a custom mark function anymore, since
ActiveDOMObjets now manage their own lifetimes.
* dom/MessagePort.cpp:
(WebCore::MessagePort::hasPendingActivity): Correctly report that we
have pending activity when we're remotely entangled, instead of relying
on our clients to know this about us and do the check for us.
* dom/MessagePort.h: FIXME!
* dom/MessagePort.idl:
* fileapi/DOMFileSystem.idl:
* fileapi/FileReader.idl:
* fileapi/FileWriter.idl:
* notifications/Notification.idl:
* notifications/NotificationCenter.idl:
* page/EventSource.idl:
* storage/IDBDatabase.idl:
* storage/IDBRequest.idl:
* storage/IDBTransaction.idl:
* webaudio/AudioContext.idl:
* websockets/WebSocket.idl:
* workers/AbstractWorker.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl: Opt in to ActiveDOMObject lifetime management.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::hasPendingActivity): No need to make up for
MessagePort::hasPendingActivity being wrong anymore, since it's now right.
* xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management.
2011-04-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: worker messages should be routed to corresponding worker front-end
https://bugs.webkit.org/show_bug.cgi?id=59323
Added WorkerManager which is responsible for routing messages between
Page inspector front-end and Worker inspector front-ends.
* WebCore.gypi:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/WorkerManager.js: Added.
(WebInspector.WorkerManager):
(WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend):
(WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded):
(WebInspector.WorkerManager.loaded):
(WebInspector.WorkerFrontendStub):
(WebInspector.WorkerFrontendStub.prototype._receiveMessage):
(WebInspector.WorkerDispatcher):
(WebInspector.WorkerDispatcher.prototype._receiveMessage):
(WebInspector.WorkerDispatcher.prototype.workerCreated):
(WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.loaded):
2011-04-25 Annie Sullivan <sullivan@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Resources panel] Should be easy to copy data.
https://bugs.webkit.org/show_bug.cgi?id=45662
Adds context menu items to copy resource location, resource request headers, and resource response headers.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu.
(WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard.
(WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard.
(WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders.
(WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.
2011-04-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
https://bugs.webkit.org/show_bug.cgi?id=59322
Use TextResourceDecoder to determine external stylesheet charsets correctly.
Test: inspector/styles/parse-utf8-bom.html
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::originalStyleSheetText):
2011-04-25 Pavel Feldman <pfeldman@google.com>
Not reviewed: Inspector.json cleanup.
* inspector/Inspector.json:
2011-04-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce InspectorWorkerAgent
https://bugs.webkit.org/show_bug.cgi?id=59320
InspectorWorkerAgent is responsible for routing inspector messages
between worker context inspector agents and corresponding worker
inspector front-end.
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::workerAgent):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willStartWorkerContext):
(WebCore::InspectorInstrumentation::didStartWorkerContext):
* inspector/InspectorWorkerAgent.cpp: Added.
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend):
(WebCore::InspectorWorkerAgent::create):
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
* inspector/InspectorWorkerAgent.h: Added.
* inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorWorkerAgent):
(WebCore::InstrumentingAgents::setInspectorWorkerAgent):
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::connectFrontend):
* inspector/generate-inspector-idl:
* workers/Worker.cpp:
(WebCore::Worker::notifyFinished):
* workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector
messages sent from the inspected page worker agent to the worker context inspector agents.
(WebCore::WorkerContextInspectorProxy::connectFrontend):
(WebCore::WorkerContextInspectorProxy::disconnectFrontend):
(WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector):
(WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
* workers/WorkerContextProxy.h:
(WebCore::WorkerContextProxy::inspectorProxy):
2011-04-25 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: move Frame and Resource Tree management into the Page agent.
https://bugs.webkit.org/show_bug.cgi?id=59321
Network agent should only handle network-related activities.
Frame structure should be managed by the Page agent instead.
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::setFrontend):
(WebCore::InspectorDOMAgent::restore):
(WebCore::InspectorDOMAgent::highlightFrame):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::loadEventFiredImpl):
(WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::resourceContent):
(WebCore::InspectorPageAgent::resourceContentBase64):
(WebCore::InspectorPageAgent::resourceData):
(WebCore::InspectorPageAgent::cachedResource):
(WebCore::InspectorPageAgent::resourceTypeString):
(WebCore::InspectorPageAgent::cachedResourceType):
(WebCore::InspectorPageAgent::cachedResourceTypeString):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::setFrontend):
(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::open):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::getResourceContent):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::loadEventFired):
(WebCore::InspectorPageAgent::frameNavigated):
(WebCore::InspectorPageAgent::frameDetached):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::mainFrame):
(WebCore::pointerAsId):
(WebCore::InspectorPageAgent::frameForId):
(WebCore::InspectorPageAgent::frameId):
(WebCore::InspectorPageAgent::loaderId):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
* inspector/InspectorPageAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForCachedResource):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::setInitialXHRContent):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
* inspector/InspectorResourceAgent.h:
(WebCore::InspectorResourceAgent::create):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.requestContent):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel):
(WebInspector.NetworkPanel.prototype.frameNavigated):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype.frontendReused):
(WebInspector.ResourceTreeModel.prototype.frameNavigated):
(WebInspector.ResourceTreeModel.prototype.frameDetached):
* inspector/front-end/inspector.js:
(WebInspector.domContentEventFired):
(WebInspector.loadEventFired):
(WebInspector.frameNavigated):
(WebInspector.frameDetached):
2011-04-25 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: few protocol improvements.
https://bugs.webkit.org/show_bug.cgi?id=59319
- Page domain is documented
- setUserAgentOverride is moved to the Network agent
- setSearchingForNode -> setInspectModeEnabled
- highlightDOMNode -> highlightNode
- reloadPage -> reload
- openInNewWindow -> open with optional parameter
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::highlightNode):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::hideNodeHighlight):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::clearFrontend):
(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::open):
* inspector/InspectorPageAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::clearFrontend):
(WebCore::InspectorResourceAgent::applyUserAgentOverride):
(WebCore::InspectorResourceAgent::setUserAgentOverride):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._reloadResources):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.setSearchingForNode):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._openInNewTab):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype.ondblclick):
* inspector/front-end/inspector.js:
(WebInspector.highlightDOMNode):
(WebInspector.openResource):
(WebInspector.documentKeyDown):
2011-04-25 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
Switch the scrollbar's overlay style depending on its frame's background color.
This refactors the getDocumentBackgroundColor method needed for gestures. The style
is determined and set on every paint() call to the Mac scrollbar theme.
* WebCore.exp.in: adding method to allow changing style
* page/Frame.cpp:
(WebCore::Frame::getDocumentBackgroundColor): moving code from WebFrame for reuse by FrameView
* page/Frame.h:
* page/FrameView.cpp:
(WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
* page/FrameView.h:
* platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
2011-04-25 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9113516> REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation)
https://bugs.webkit.org/show_bug.cgi?id=59315
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar): Initialize new member variables.
(WebCore::Scrollbar::moveThumb): Added a boolean draggingDocument parameter. When true, the document
is scrolled a distance equal to the change in the mouse position.
(WebCore::Scrollbar::mouseMoved): Check with the theme whether the mouse move event should drag
the document rather than the thumb, and pass the result to moveThumb.
(WebCore::Scrollbar::mouseUp): Reset m_draggingDocument.
* platform/Scrollbar.h:
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb): Added. The base class implementation
returns false.
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb): Overridden to return true if the
Option key is down.
2011-04-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed a use of markDOMObjectWrapper: WebGL, XHR, workers; plus, more autogeneration
https://bugs.webkit.org/show_bug.cgi?id=59307
* WebCore.xcodeproj/project.pbxproj: Added Blob.idl, so it's easier to edit.
* bindings/js/JSCSSRuleCustom.cpp:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
* bindings/js/JSCanvasRenderingContextCustom.cpp:
* bindings/js/JSDOMApplicationCacheCustom.cpp: Autogenerate these instead
of hand-coding them.
* bindings/js/JSDOMBinding.h:
(WebCore::root): Moved some GC helpers here from JSNodeCustom.h, because
they're reasonably generic.
* bindings/js/JSDOMImplementationCustom.cpp:
* bindings/js/JSDOMStringMapCustom.cpp:
* bindings/js/JSDOMTokenListCustom.cpp:
* bindings/js/JSHTMLCollectionCustom.cpp:
* bindings/js/JSMediaListCustom.cpp: Autogenerate these instead of
hand-coding them.
* bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::visitChildren):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::visitChildren): Use addOpaqueRoot instead of
markDOMObjectWrapper. This is one of the few cases where a DOM object is
considered a stand-alone root. It's not as efficient as the shared root
case, but workers and message ports are very rare objects, so it's no
big deal.
* bindings/js/JSNamedNodeMapCustom.cpp: Autogenerate!
* bindings/js/JSNodeCustom.h: Moved to JSDOMBinding.h.
* bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorker::visitChildren): Use addOpaqueRoot instead of
markDOMObjectWrapper, as above. Once again, a stand-alone root.
* bindings/js/JSStyleSheetCustom.cpp:
* bindings/js/JSStyleSheetListCustom.cpp: Autogenerate!
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::visitChildren): Use the opaque roots
system for marking WebGL contexts and their associated satellite objects.
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::visitChildren):
* bindings/js/JSXMLHttpRequestCustom.cpp: Use addOpaqueRoot instead of
markDOMObjectWrapper, as above. Once again, stand-alone roots.
(WebCore::JSXMLHttpRequest::visitChildren):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp: No need to mark our owner
XHR because it is not reachable from us.
* bindings/scripts/CodeGeneratorJS.pm: Added autogeneration support for a
bunch of repetitive cases of isReachableFromOpaqueRoots callbacks.
* css/CSSRule.idl:
* css/CSSStyleDeclaration.idl:
* css/MediaList.idl:
* css/StyleMedia.idl:
* css/StyleSheet.idl:
* css/StyleSheetList.idl:
* dom/DOMImplementation.idl:
* dom/DOMStringMap.idl:
* dom/MessagePort.idl:
* dom/NamedNodeMap.idl:
* fileapi/Blob.idl:
* html/DOMTokenList.idl: Opt in to autogeneration.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext): Standardized on PassOwnPtr/OwnPtr
usage, to reduce human error and make ownership rules more obvious.
* html/HTMLCollection.idl:
* html/canvas/ArrayBuffer.idl: Opt in to autogeneration.
* html/canvas/CanvasRenderingContext.cpp:
* html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::ref):
(WebCore::CanvasRenderingContext::deref):
* html/canvas/CanvasRenderingContext2D.h:
(WebCore::CanvasRenderingContext2D::create):
(WebCore::CanvasRenderingContext2D::state): Standardized on PassOwnPtr/OwnPtr
usage, to reduce human error and make ownership rules more obvious.
Inlined some functions to match our standard idiom and to make the code
in the header document itself.
* html/canvas/CanvasRenderingContext.idl: Opt in to autogeneration.
* html/canvas/OESStandardDerivatives.cpp:
(WebCore::OESStandardDerivatives::OESStandardDerivatives):
(WebCore::OESStandardDerivatives::create):
* html/canvas/OESStandardDerivatives.h:
* html/canvas/OESStandardDerivatives.idl:
* html/canvas/OESTextureFloat.cpp:
(WebCore::OESTextureFloat::OESTextureFloat):
(WebCore::OESTextureFloat::create):
* html/canvas/OESTextureFloat.h:
* html/canvas/OESTextureFloat.idl:
* html/canvas/OESVertexArrayObject.cpp:
(WebCore::OESVertexArrayObject::OESVertexArrayObject):
(WebCore::OESVertexArrayObject::create):
* html/canvas/OESVertexArrayObject.h:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/WebGLExtension.cpp:
(WebCore::WebGLExtension::WebGLExtension):
* html/canvas/WebGLExtension.h:
(WebCore::WebGLExtension::ref):
(WebCore::WebGLExtension::deref):
(WebCore::WebGLExtension::context):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::getExtension):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebKitLoseContext.cpp:
(WebCore::WebKitLoseContext::WebKitLoseContext):
(WebCore::WebKitLoseContext::create):
(WebCore::WebKitLoseContext::loseContext):
* html/canvas/WebKitLoseContext.h:
* html/canvas/WebKitLoseContext.idl: Updated the ownership model for WebGL
canavs rendering contexts to match the model for 2D canvas rendering
contexts. This makes garbage collection a lot more straightforward, but
it also makes the behavior of these objects more reliable. (Previously,
satellite objects would magically stop working when the last reference
to their owner object was dropped. Now, satellite objects keep their owner
alive through reference counting.)
* loader/appcache/DOMApplicationCache.idl:
* page/BarInfo.idl:
* page/Console.idl:
* page/DOMSelection.idl:
* page/Geolocation.idl:
* page/History.idl:
* page/Location.idl:
* page/Navigator.idl:
* page/Screen.idl:
* page/WorkerNavigator.idl:
* plugins/DOMMimeTypeArray.h:
(WebCore::DOMMimeTypeArray::frame):
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPluginArray.h:
(WebCore::DOMPluginArray::frame):
* plugins/DOMPluginArray.idl:
* storage/Storage.idl:
* workers/WorkerLocation.idl: Opt in to autogeneration.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::~XMLHttpRequest):
* xml/XMLHttpRequest.h:
* xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::scriptExecutionContext):
* xml/XMLHttpRequestUpload.h:
(WebCore::XMLHttpRequestUpload::create):
(WebCore::XMLHttpRequestUpload::ref):
(WebCore::XMLHttpRequestUpload::deref):
(WebCore::XMLHttpRequestUpload::xmlHttpRequest):
(WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload):
* xml/XMLHttpRequestUpload.idl: Updated the ownership model for XHR and
its associated upload object to match the model for canvas. This makes
garbage collection a lot more straightforward, but it also makes the
behavior of these objects more reliable.
2011-04-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84759.
http://trac.webkit.org/changeset/84759
https://bugs.webkit.org/show_bug.cgi?id=59306
Caused gc-shadow.html to start crashing in V8. (Requested by
dglazkov|away on #webkit).
* dom/Node.cpp:
(WebCore::NodeRendererFactory::createRendererAndStyle):
(WebCore::Node::styleForRenderer):
2011-04-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by George Staikos.
Handling of URLs like http:/example.com/ is incorrect
https://bugs.webkit.org/show_bug.cgi?id=59300
<rdar://problem/9231956>
URLs like http:/example.com/ or http:example.com/ are now correctly
canonicalized as http://example.com/
The code still doesn't quite match other browsers - at least some
other browsers seem to base parsing behavior on whether they
recongize a scheme from a fixed list, and ignore whether // is
present in the URL or not.
* platform/KURL.cpp:
(WebCore::isNonFileHierarchicalScheme): New helper function.
(WebCore::KURL::parse): For a particular list of whitelisted schemes,
assume they are hierarchical and need an authority even if there is no //
after the :/
2011-04-24 Dan Bernstein <mitz@apple.com>
LLVM Compiler build fix.
* page/ContentSecurityPolicy.cpp: Removed an unused function.
2011-04-24 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Crash when adding a text node to a shadow root
https://bugs.webkit.org/show_bug.cgi?id=59304
Text nodes need to consult their host element for style.
Test: fast/dom/shadow/append-child-text.html
* dom/Node.cpp:
(WebCore::NodeRendererFactory::styleForRenderer):
(WebCore::NodeRendererFactory::createRendererAndStyle):
(WebCore::Node::styleForRenderer): forward to NodeRendererFactory
2011-04-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update Content-Security-Policy syntax to match new version of spec
https://bugs.webkit.org/show_bug.cgi?id=59291
Brandon removed disable-xss-protection in favor of unsafe-inline and
allow-eval in favor of unsafe-eval. This change in syntax also means
the options directive no longer exists.
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPSourceList::allowInline):
(WebCore::CSPSourceList::allowEval):
(WebCore::CSPSourceList::CSPSourceList):
(WebCore::CSPSourceList::parseSource):
(WebCore::CSPSourceList::addSourceUnsafeInline):
(WebCore::CSPSourceList::addSourceUnsafeEval):
(WebCore::CSPDirective::allowInline):
(WebCore::CSPDirective::allowEval):
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
2011-04-24 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
Manual test for <rdar://problem/9329741> Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com
https://bugs.webkit.org/show_bug.cgi?id=59299
* manual-tests/back-from-document-with-scrollbar.html: Added.
2011-04-24 Rik Cabanier <cabanier@adobe.com>
Reviewed by Simon Fraser.
Tables are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=59138
Test: fast/table/auto-100-percent-width.html
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
2011-04-23 Simon Fraser <simon.fraser@apple.com>
Fix Windows build, which complains about unreachable code.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::hasLayerForHorizontalScrollbar):
(WebCore::ScrollableArea::hasLayerForVerticalScrollbar):
(WebCore::ScrollableArea::hasLayerForScrollCorner):
2011-04-23 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Area under composited scrollbars not repainted in WebKit2 on scrolling
https://bugs.webkit.org/show_bug.cgi?id=59294
<rdar://problem/9299062>
When computing the rect that can be copied on scrolling, we normally
exclude the areas occupied by overlay scrollbars to avoid smeared scrollbars;
the assumption is that other code will repaint these areas. However, when
scrollbars are in their own compositing layers, we can, and should
copy the entire area.
Not testable in DRT because it does not allow tests to use overlay scrollbars.
* platform/ScrollView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::rectToCopyOnScroll):
New method, with code moved from scrollContents and fixed to look
for scrollbars in layers.
(WebCore::ScrollView::scrollContents):
Call rectToCopyOnScroll().
* platform/ScrollableArea.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::hasLayerForHorizontalScrollbar):
(WebCore::ScrollableArea::hasLayerForVerticalScrollbar):
(WebCore::ScrollableArea::hasLayerForScrollCorner):
Methods we can call outside of the ACCELERATED_COMPOSITING #ifdef.
2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84740.
http://trac.webkit.org/changeset/84740
https://bugs.webkit.org/show_bug.cgi?id=59290
change breaks apple internal builds and is incorrect
(Requested by smfr on #webkit).
* WebCore.exp.in:
* page/FrameView.cpp:
* page/FrameView.h:
* platform/ScrollTypes.h:
* platform/ScrollableArea.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
2011-04-23 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/8970549> WebFindOptionsAtWordStarts fails with Japanese words
https://bugs.webkit.org/show_bug.cgi?id=59288
* platform/text/mac/TextBoundaries.mm:
(WebCore::wordStringTokenizer): Added this helper function.
(WebCore::findNextWordFromIndex): Changed to use a CFStringTokenizer with kCFStringTokenizerUnitWord,
whose behavior is not locale-dependent.
2011-04-23 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Nodes in shadow DOM should not be GCed while their hosts are alive
https://bugs.webkit.org/show_bug.cgi?id=59284
Test: fast/dom/shadow/gc-shadow.html
* bindings/v8/V8GCController.cpp:
(WebCore::calculateGroupId): group shadow nodes with their hosts
2011-04-23 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
[Refactoring] NodeRenderParentDetector should be NodeRenderFactory
https://bugs.webkit.org/show_bug.cgi?id=59280
- Rename NodeRenderParentDetector to NodeRendererFactory
- move createRendererAndStyle() and createRendererIfNeeded to
NodeRendererFactory
No new test, no behavioral change.
* dom/Node.cpp:
(WebCore::NodeRendererFactory::NodeRendererFactory):
(WebCore::NodeRendererFactory::document):
(WebCore::NodeRendererFactory::nextRenderer):
(WebCore::NodeRendererFactory::findVisualParent):
(WebCore::NodeRendererFactory::shouldCreateRenderer):
(WebCore::NodeRendererFactory::createRendererAndStyle):
(WebCore::NodeRendererFactory::createRendererIfNeeded):
(WebCore::Node::parentNodeForRenderingAndStyle):
(WebCore::Node::createRendererIfNeeded):
* dom/Node.h:
* html/HTMLDetailsElement.cpp:
(WebCore::DetailsSummaryElement::detailsElement): Added const_cast due to the chage on parentNodeForRenderingAndStyle()
2011-04-23 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899
https://bugs.webkit.org/show_bug.cgi?id=59281
Styles for -webkit-meter-bar and -webkit-progress-bar missed width property, which caused unexpected layout results
for vertical writing modes. This fix added a width property for each of them.
Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/dom/HTMLProgressElement/progress-writing-mode.html
* css/html.css:
(meter::-webkit-meter-bar):
(progress::-webkit-progress-bar):
2011-04-23 Kevin Ollivier <kevino@theolliviers.com>
[wx] Unreviewed build fix. Added missing header.
* platform/graphics/filters/FEDropShadow.h:
2011-04-23 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59241
<rdar://problem/9150861>
Covered by manual-tests/print-after-window-close.html.
Re-fixing <https://bugs.webkit.org/show_bug.cgi?id=51357> in a way that doesn't cause the
regression.
* loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didCancel): We shouldn't be
doing complicated work while the loader is half-canceled.
* manual-tests/print-after-window-close.html: Extended to actually print a non-empty page,
thus being more practical.
* page/Chrome.cpp: (WebCore::Chrome::print): Added a FIXME about a need for PageGroupLoadDeferrer.
It's too scary for me to try now.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::finishedLoading):
* page/DOMWindow.h:
Reverted the previous fix for <https://bugs.webkit.org/show_bug.cgi?id=51357>.
2011-04-19 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
[V8] Use implicit references for V8 listeners on DOM nodes.
https://bugs.webkit.org/show_bug.cgi?id=58953
Instead of allocating an auxiliary V8 array referencing V8
listener objects associated with a DOM node and using an extra
pointer in every DOM node wrapper, we can register implicit
references between nodes and their listeners during GC. This also
makes V8 bindings more aligned with JSC bindings.
No new tests because this is a refactoring.
* bindings/scripts/CodeGeneratorV8.pm: Stopped generating the
listener cache internal field for DOM nodes.
* bindings/v8/V8AbstractEventListener.h: Exposed the lister handle
to the GC.
(WebCore::V8AbstractEventListener::existingListenerObjectPeristentHandle):
* bindings/v8/V8GCController.cpp: Started using implicit references.
(WebCore::GrouperVisitor::visitDOMWrapper):
* dom/EventTarget.h: Implemented an iterator over all listeners.
(WebCore::EventListenerIterator):
2011-04-22 Jon Lee <jonlee@apple.com>
Reviewed by Beth Dakin.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
* WebCore.exp.in: adding method to allow changing style
* page/FrameView.cpp:
(WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
* page/FrameView.h:
* platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
* platform/ScrollableArea.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
2011-04-22 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Upgrade CSS loads from mixed content warning (displayed) to mixed
content error (ran)
https://bugs.webkit.org/show_bug.cgi?id=59056
Test: http/tests/security/mixedContent/insecure-css-in-iframe.html
Test: http/tests/security/mixedContent/insecure-css-in-main-frame.html
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest): CSS loads are running rather than displaying content.
2011-04-22 Geoffrey Garen <ggaren@apple.com>
Fixed an upside-down conditional in my last check-in.
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::isObservable):
2011-04-22 Geoffrey Garen <ggaren@apple.com>
Rolled back in r84725 and r84728 with appcache crash fixed.
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=59260
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since
we use the opaque roots system now.
* bindings/js/JSNavigatorCustom.cpp: Ditto.
* bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects
whose opaque roots are frames.
* css/StyleMedia.h:
(WebCore::StyleMedia::frame): Added an accessor for the sake of GC.
* css/StyleMedia.idl:
* loader/appcache/DOMApplicationCache.idl:
* page/BarInfo.idl:
* page/Console.idl:
* page/DOMSelection.idl:
* page/Geolocation.idl:
* page/History.idl:
* page/Location.idl:
* page/Navigator.idl:
* page/Screen.idl:
* storage/Storage.idl: Updated to use the opaque roots system.
2011-04-22 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Don't use XMLTreeViewer when script is disabled (it uses Javascript
to build a prettified version of the xml document).
https://bugs.webkit.org/show_bug.cgi?id=59113
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84725 and r84728.
http://trac.webkit.org/changeset/84725
http://trac.webkit.org/changeset/84728
https://bugs.webkit.org/show_bug.cgi?id=59270
It broke http/tests/appcache tests (Requested by Ossy on
#webkit).
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitChildren):
* bindings/js/JSNavigatorCustom.cpp:
(WebCore::JSNavigator::visitChildren):
* bindings/scripts/CodeGeneratorJS.pm:
* css/StyleMedia.h:
* css/StyleMedia.idl:
* loader/appcache/DOMApplicationCache.idl:
* page/BarInfo.idl:
* page/Console.idl:
* page/DOMSelection.idl:
* page/DOMWindow.h:
(WebCore::DOMWindow::optionalScreen):
(WebCore::DOMWindow::optionalSelection):
(WebCore::DOMWindow::optionalHistory):
(WebCore::DOMWindow::optionalCrypto):
(WebCore::DOMWindow::optionalLocationbar):
(WebCore::DOMWindow::optionalMenubar):
(WebCore::DOMWindow::optionalPersonalbar):
(WebCore::DOMWindow::optionalScrollbars):
(WebCore::DOMWindow::optionalStatusbar):
(WebCore::DOMWindow::optionalToolbar):
(WebCore::DOMWindow::optionalConsole):
(WebCore::DOMWindow::optionalNavigator):
(WebCore::DOMWindow::optionalLocation):
(WebCore::DOMWindow::optionalMedia):
(WebCore::DOMWindow::optionalSessionStorage):
(WebCore::DOMWindow::optionalLocalStorage):
(WebCore::DOMWindow::optionalPerformance):
* page/Geolocation.idl:
* page/History.idl:
* page/Location.idl:
* page/Navigator.h:
(WebCore::Navigator::optionalGeolocation):
* page/Navigator.idl:
* page/Screen.idl:
* storage/Storage.idl:
2011-04-22 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
Change SVG-related shadow root checks to use isSVGShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=59237
Covered by existing tests, no behavior change.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Use isSVGShadowRoot.
* svg/SVGUseElement.cpp:
(WebCore::ShadowTreeUpdateBlocker::while): Ditto.
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedIntoDocument): Ditto.
2011-04-22 Geoffrey Garen <ggaren@apple.com>
Mac build fix.
* page/DOMWindow.h:
(WebCore::DOMWindow::optionalApplicationCache): Restored this function,
which is used after all.
2011-04-22 Geoffrey Garen <ggaren@apple.com>
Mac build fix.
* page/DOMWindow.h:
(WebCore::DOMWindow::optionalApplicationCache): Restored this function,
which is used after all.
2011-04-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=59260
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since
we use the opaque roots system now.
* bindings/js/JSNavigatorCustom.cpp: Ditto.
* bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects
whose opaque roots are frames.
* css/StyleMedia.h:
(WebCore::StyleMedia::frame): Added an accessor for the sake of GC.
* css/StyleMedia.idl:
* loader/appcache/DOMApplicationCache.idl:
* page/BarInfo.idl:
* page/Console.idl:
* page/DOMSelection.idl:
* page/Geolocation.idl:
* page/History.idl:
* page/Location.idl:
* page/Navigator.idl:
* page/Screen.idl:
* storage/Storage.idl: Updated to use the opaque roots system.
2011-04-22 Xiaomei Ji <xji@chromium.org>
Reviewed by Ryosuke Niwa.
move caret by word in visual order returns wrong result when caret itself is at word boundary.
https://bugs.webkit.org/show_bug.cgi?id=58504.
positionBeforeNextWord should take care that the current position is after current word.
positionAfterPreviousWord should take care that the current positin is before current word.
* editing/visible_units.cpp:
(WebCore::positionBeforeNextWord):
(WebCore::positionAfterPreviousWord):
2011-04-19 Jer Noble <jer.noble@apple.com>
Reviewed by Daniel Bates.
Full Screen from within an <iframe> does not cause <iframe> to resize.
https://bugs.webkit.org/show_bug.cgi?id=58638
Tests: fullscreen/full-screen-frameset.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Add the
-webkit-full-screen pseudo class to frame elements which contain
full screen elements.
* css/fullscreen.css:
(iframe:-webkit-full-screen): Add iframe-specific styling rules.
* dom/Document.cpp:
(WebCore::Document::setContainsFullScreenElementRecursively): Added. Walk up each
successive document owner element, calling setContainsFullScreenElement() if
owner is a frame element.
(WebCore::Document::fullScreenIsAllowedForElement): Use the new Element::isFrameElementBase
call instead of checking the element's tag name.
(WebCore::Document::webkitWillEnterFullScreenForElement): Mark any containing
iframes as containing a full screen element.
(WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
* dom/Element.h:
(WebCore::Element::isFrameElementBase): Added.
* html/HTMLFrameElement.h:
(WebCore::HTMLFrameElement::allowFullScreen): Disable full screen from within
HTMLFrameElements.
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Added.
* html/HTMLFrameElementBase.h:
(WebCore::HTMLFrameElementBase::containsFullScreenElement): Added.
(WebCore::HTMLFrameElementBase::isFrameElementBase): Added.
2011-04-22 Michael Saboff <msaboff@apple.com>
Reviewed by Maciej Stachowiak.
Creating copy of ContainerNode's when inserting or removing is inefficient
https://bugs.webkit.org/show_bug.cgi?id=58695
Eliminated node copying in willRemove() and insertedIntoDocument().
No new tests as this is a more efficient implementation of
existing code that is covered by existing tests.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::willRemove): Changed method to use
RefPtr<> to protect against modification during removal.
(WebCore::ContainerNode::insertedIntoDocument): Changed method to use
RefPtr<> and two other deletion checks to protect against
modification during insertion.
2011-04-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
We have an autogenerator, so use it
https://bugs.webkit.org/show_bug.cgi?id=59247
* bindings/js/JSCSSRuleCustom.cpp:
* bindings/js/JSCSSRuleListCustom.cpp:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
* bindings/js/JSCSSValueCustom.cpp:
* bindings/js/JSCanvasRenderingContextCustom.cpp:
* bindings/js/JSDOMImplementationCustom.cpp:
* bindings/js/JSDOMStringMapCustom.cpp:
* bindings/js/JSHTMLCollectionCustom.cpp:
* bindings/js/JSNamedNodeMapCustom.cpp:
* bindings/js/JSNodeCustom.h:
* bindings/js/JSNodeListCustom.cpp:
* bindings/js/JSStyleSheetCustom.cpp:
* bindings/js/JSStyleSheetListCustom.cpp: Removed repetitive hand-written code.
* bindings/scripts/CodeGeneratorJS.pm: Augmented autogenerator to do the job.
* css/CSSRule.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSValue.idl:
* css/MediaList.idl:
* css/StyleSheet.idl:
* css/StyleSheetList.idl:
* dom/DOMImplementation.idl:
* dom/DOMStringMap.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeList.idl:
* html/DOMTokenList.idl:
* html/HTMLCollection.idl:
* html/canvas/CanvasRenderingContext.idl: Updated attributes to plug into
the autogenerator.
2011-04-22 Beth Dakin <bdakin@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=59223
REGRESSION (r82185): iframe not displayed after navigation back to cached page
Manual test added.
* manual-tests/frame-layout-on-back.html: Added.
* manual-tests/resources/empty-document-goes-back.html: Added.
* manual-tests/resources/simple-iframe.html: Added.
2011-04-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Sam Weinig.
HTMLFormControlElement::labels should allow custom attributes.
https://bugs.webkit.org/show_bug.cgi?id=59128
Cache the labels list when it is created and keep using it for future
labels calls.
Test: fast/forms/labels-custom-property.html
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::labels):
2011-04-22 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Remove minimum texture size for compositor tiling
https://bugs.webkit.org/show_bug.cgi?id=59236
This was mistakenly committed in r83915 and causes bad filtering
on very small textures.
Tests: compositing/images/content-image-change.html
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::setTileSize):
2011-04-22 Beth Dakin <bdakin@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=59223
REGRESSION (r82185): iframe not displayed after navigation back to cached page
-and corresponding-
<rdar://problem/9323763>
Cache the scroll position in Document::setInPageCache() instead of
FrameView::resetScrollbarsAndClearContentsSize(), and only clear the contents size
for the mainFrame(). Still resetScrollbars() for other frames, which matches pre-
r82185 code.
* dom/Document.cpp:
(WebCore::Document::setInPageCache):
* page/FrameView.cpp:
(WebCore::FrameView::resetScrollbarsAndClearContentsSize):
2011-04-22 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Kent Tamura.
Let the RenderTheme decide if an input type should have a spinner
https://bugs.webkit.org/show_bug.cgi?id=59246
Whether an input should have a spinner or not should
be a UI decision made by the RenderTheme. Remove
WebCore's default hasSpinButton values and defer
to the RenderTheme.
No change in functionality, covered by existing tests.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isRangeControl): expose isRangeControl
for possible RenderTheme queries.
* html/HTMLInputElement.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
For both of these ask the render theme if the input should
have a spinner.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::shouldHaveSpinButtonForInputElement):
Steppable inputs (number, date, and range) but not range
should have spinners. This does not change existing behavior.
* rendering/RenderTheme.h:
* dom/InputElement.h:
* html/BaseDateAndTimeInputType.cpp: remove hasSpinButton.
* html/BaseDateAndTimeInputType.h: remove hasSpinButton.
* html/InputType.cpp: remove hasSpinButton.
* html/InputType.h: remove hasSpinButton.
* html/NumberInputType.cpp: remove hasSpinButton.
* html/NumberInputType.h: remove hasSpinButton.
2011-04-22 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Kent Tamura.
Don't rely on hasSpinButton to check if an input type can be stepped
https://bugs.webkit.org/show_bug.cgi?id=59224
Add isSteppable to know for certain if an input type can
be stepped or not. Previously we were checking if the input
has a spin control or is the range input type. These are UI
details, but the step functionality does not require there
to be a UI.
No change in behavior, covered by existing tests.
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::isSteppable):
* html/BaseDateAndTimeInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isSteppable):
(WebCore::HTMLInputElement::stepUpFromRenderer): remove the
check for a spinner and range control and instead ASSERT
that the type is steppable.
* html/HTMLInputElement.h:
* html/InputType.cpp:
(WebCore::InputType::isSteppable):
* html/InputType.h:
* html/NumberInputType.cpp:
(WebCore::NumberInputType::isSteppable):
* html/NumberInputType.h:
* html/RangeInputType.cpp:
(WebCore::RangeInputType::isSteppable):
* html/RangeInputType.h:
2011-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP frame-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58643
In this patch, I've audited all the callers to
SecurityOrigin::canDisplay to make sure they all the appropriate
Content-Security-Policy method as well. I'm not sure how to test all
these cases, but making this changes fixed the frame-src test.
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
(WebCore::SubframeLoader::createJavaAppletWidget):
(WebCore::SubframeLoader::loadSubframe):
(WebCore::SubframeLoader::loadPlugin):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
- While I was understanding this code, I fixed the FIXME here.
* loader/cache/CachedResourceLoader.h:
2011-04-22 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
Clear shared graphics context when destroying CanvasRenderingContext2D.
https://bugs.webkit.org/show_bug.cgi?id=59212
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
2011-04-22 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
End/Home keys do not work in a contentEditable element
https://bugs.webkit.org/show_bug.cgi?id=50564
Changing logical[Start/End]OfLine to return a valid VisiblePosition for for editable contexts that are
inline and share a line with non-editable content.
Test: editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html
* editing/visible_units.cpp:
(WebCore::logicalStartOfLine):
(WebCore::logicalEndOfLine):
2011-04-22 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
Make showTree/showTreeForThis aware of the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=52965
No new tests, because this code is only compiled in DEBUG.
* dom/Node.cpp:
(WebCore::traverseTreeAndMark): Moved tree traversal logic here, adding
recursive sub-traversal of the shadow tree.
(WebCore::Node::showTreeAndMark): Changed to use the new tree traversal function.
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough and Oliver Hunt.
Arrays should participate in global object forwarding fun
https://bugs.webkit.org/show_bug.cgi?id=59215
Change callers of constructArray to use the new variant that takes
a global object.
* bindings/js/JSClipboardCustom.cpp:
(WebCore::JSClipboard::types):
* bindings/js/JSConsoleCustom.cpp:
(WebCore::JSConsole::profiles):
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::scopeChain):
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::ports):
* bindings/js/JSScriptProfileNodeCustom.cpp:
(WebCore::JSScriptProfileNode::children):
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
(WebCore::JSWebGLRenderingContext::getAttachedShaders):
(WebCore::JSWebGLRenderingContext::getSupportedExtensions):
2011-04-22 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Unreviewed typo fix after r84522.
* WebCore.pro:
2011-04-22 Daniel Bates <dbates@rim.com>
Fix misspelled word in comment; tagets => targets.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):
2011-04-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: Element and Document
https://bugs.webkit.org/show_bug.cgi?id=59178
* GNUmakefile.list.am:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp: Build!
* bindings/js/JSDOMImplementationCustom.cpp:
(WebCore::JSDOMImplementationOwner::isReachableFromOpaqueRoots):
(WebCore::JSDOMImplementationOwner::finalize):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::toJS): Use the opaque roots system for DOMImplementation. Also,
DOMImplementation does not need to keep its document wrapper alive, since
there's no DOM API for getting a DOMImplementation's document.
* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMapOwner::isReachableFromOpaqueRoots):
(WebCore::JSDOMStringMapOwner::finalize):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::toJS): Use the opaque roots system for DOMStringMap.
* bindings/js/JSDOMTokenListCustom.cpp: Added.
(WebCore::JSDOMTokenListOwner::isReachableFromOpaqueRoots):
(WebCore::JSDOMTokenListOwner::finalize):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::toJS): Use the opaque roots system for DOMTokenList.
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::visitChildren):
* bindings/js/JSElementCustom.cpp: No more need for explicit marking.
* bindings/scripts/CodeGeneratorV8.pm: Boo on whoever made this design decision.
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::DOMImplementation):
(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::createHTMLDocument):
* dom/DOMImplementation.h:
(WebCore::DOMImplementation::create):
(WebCore::DOMImplementation::ref):
(WebCore::DOMImplementation::deref):
(WebCore::DOMImplementation::document): Fixed the DOMImplementation
ownership model to match other satellite objects in the DOM. This was
necessary to fix some crashes due to incorrect reference counting.
* dom/DOMImplementation.idl:
* dom/DOMStringMap.idl:
* dom/Document.cpp:
(WebCore::Document::~Document):
* dom/Document.h:
* dom/Element.cpp:
* dom/Element.h:
* dom/Element.idl:
* html/DOMTokenList.idl: Updated to match changes above.
2011-04-22 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Rounded corners don't looks smooth when background-image is a gradient
https://bugs.webkit.org/show_bug.cgi?id=59213
Add the "shrink background" behavior to the slow background
drawing code path.
Test: fast/backgrounds/gradient-background-leakage.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::backgroundRectAdjustedForBleedAvoidance):
Utility function that returns a shrunk border rect based
on the context scale.
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Use backgroundRectAdjustedForBleedAvoidance() in both the fast
and slow paths.
2011-04-22 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Local caret rectangle calculation should be relative to its containing block.
https://bugs.webkit.org/show_bug.cgi?id=49508.
InlineBox and caret rectangle are positioned relative to its containing block.
So its left and right edge value should be relative to its containing block as well.
Test: fast/forms/cursor-at-editable-content-boundary.html
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
2011-04-22 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Fisher.
REGRESSION: left property broken with position:fixed elements in RTL documents
https://bugs.webkit.org/show_bug.cgi?id=59204
http://code.google.com/p/chromium/issues/detail?id=80216
Test: fast/block/positioning/rtl-fixed-positioning.html
fast/block/positioning/vertical-rl/fixed-positioning.html
Returning the proper scroll offsets for fixed position content in RTL documents.
We regressed to X and Y offsets not updating while scrolling when we clamped to zero,
but RTL documents scroll in negative space.
* page/FrameView.cpp:
(WebCore::FrameView::scrollXForFixedPosition): Properly handling RTL documents where
the scroll origin and offsets are negative.
(WebCore::FrameView::scrollYForFixedPosition): Properly handling vertical writing-
mode RTL documents, like above.
* platform/ScrollView.h:
(WebCore::ScrollView::scrollOrigin): Changing this accessor to const.
2011-04-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Eric Seidel.
Should assert on invalid type in FEComponentTransfer::apply
https://bugs.webkit.org/show_bug.cgi?id=57959
No functional change. No new tests needed.
* platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::apply):
2011-04-22 MORITA Hajime <morrita@google.com>
Unreviewed crash fix.
* html/HTMLDetailsElement.cpp:
(WebCore::DetailsSummaryElement::shouldInclude):
2011-04-22 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
Exclude scrollbars from the dirty rect passed to the document
https://bugs.webkit.org/show_bug.cgi?id=59206
No test added because functionality is unchanged.
* platform/ScrollView.cpp:
(WebCore::ScrollView::paint): Compute a clip rectangle (analogous to the frame of the clip view
in an NSScrollView) by subtracting non-overlay scrollbars, and intersect the document dirty rect
with it. If the result is empty, avoid calling paintContents().
2011-04-22 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
https://bugs.webkit.org/show_bug.cgi?id=59147
Add a new isAVFoundationEnabled setting and check it before adding
MediaPlayerPrivateAVFoundationObjC to the media engine registry.
* WebCore.exp.in:
* page/Settings.cpp:
* page/Settings.h:
(WebCore::Settings::setAVFoundationEnabled): Added.
(WebCore::Settings::isAVFoundationEnabled): Added.
* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Check the settings added above.
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Remove remaining uses of deprecated version of toJS
https://bugs.webkit.org/show_bug.cgi?id=59170
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::toJS):
(WebCore::JSCanvasRenderingContext2D::strokeStyle):
(WebCore::JSCanvasRenderingContext2D::fillStyle):
(WebCore::JSCanvasRenderingContext2D::createPattern):
* bindings/js/JSConsoleCustom.cpp:
(WebCore::JSConsole::profiles):
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSSQLStatementErrorCallback::handleEvent):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMMimeTypeArrayCustom.cpp:
(WebCore::JSDOMMimeTypeArray::nameGetter):
* bindings/js/JSDOMPluginArrayCustom.cpp:
(WebCore::JSDOMPluginArray::nameGetter):
* bindings/js/JSDOMPluginCustom.cpp:
(WebCore::JSDOMPlugin::nameGetter):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::event):
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
* bindings/js/JSInjectedScriptHostCustom.cpp:
Propagate stored global object down access chain.
(WebCore::InjectedScriptHost::nodeAsScriptValue):
Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
(WebCore::JSInjectedScriptHost::currentCallFrame):
(WebCore::JSInjectedScriptHost::inspectedNode):
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::nameGetter):
* bindings/js/JSNodeListCustom.cpp:
(WebCore::callNodeList):
(WebCore::JSNodeList::nameGetter):
* bindings/js/JSScriptProfileNodeCustom.cpp:
(WebCore::JSScriptProfileNode::children):
* bindings/js/JSStyleSheetListCustom.cpp:
(WebCore::JSStyleSheetList::nameGetter):
* bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessor::transformToFragment):
(WebCore::JSXSLTProcessor::transformToDocument):
* bindings/scripts/CodeGeneratorJS.pm:
Propagate stored global object down access chain.
* css/MediaQueryListListener.cpp:
(WebCore::MediaQueryListListener::queryChanged):
Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype,
we will want refactor this to match other callbacks so we can remove this.
2011-04-22 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Eric Seidel.
[Chromium]Mac UI polish to add left/right padding space for autofill popup window.
https://bugs.webkit.org/show_bug.cgi?id=58960
http://code.google.com/p/chromium/issues/detail?id=51077
No new test because Chromium Autofill popup window doesn't have any test framework.
This assumes only AutofillPopupMenuClient gives TexFieldPart appearance.
Only if Autofill popup window has right/left padding.
The code should be removed after Autofill popup window logic is separated from WebKit to Chromium.
* rendering/RenderThemeChromiumMac.h: Add popupInternalPaddingRight() and popupInternalPaddingLeft().
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft): Return padding size only if TextFieldPart is specified.
(WebCore::RenderThemeChromiumMac::popupInternalPaddingRight): Return padding size only if TextFieldPart is specified.
2011-04-21 Adam Roben <aroben@apple.com>
Add code to enumerate all the functions imported by a particular Windows binary
PEImage is where all the logic starts. It represents a single Portable Executable (PE)
binary. The various enumerator classes are used in conjunction with PEImage to enumerate the
modules and functions imported by that image.
I couldn't figure out how to write a test for this. :-(
Part of <http://webkit.org/b/51063> <rdar://problem/8769281> REGRESSION (WebKit2): No
context menu appears when right-clicking on windowless Flash plugin
Reviewed by Sam Weinig, and given a good once-over by Jeff Miller.
* WebCore.vcproj/WebCore.vcproj: Added the new files.
* platform/win/PEImage.cpp: Added.
(WebCore::PEImage::PEImage): Checks that the module contains the expected magic numbers,
then initializes m_ntHeaders using the module.
(WebCore::PEImage::convertRVAToAddress): Converts a relative virtual address (RVA) to a
non-relative address, which can then be dereferenced. (The PE format uses RVAs in lots of
places.)
(WebCore::PEImage::dataDirectoryEntryAddress): Returns the address of the data associated
with the given entry in the image's DataDirectory.
* platform/win/PEImage.h: Added.
(WebCore::PEImage::isValid): We're a valid image if the validation code in our constructor
succeeded, in which case m_ntHeaders will be set.
* platform/win/ImportedFunctionsEnumerator.cpp: Added. This class enumerates all the
functions imported by the image from a single module by walking the Import Name Table (INT)
and Import Address Table (IAT).
(WebCore::ImportedFunctionsEnumerator::ImportedFunctionsEnumerator): Initialize our members.
(WebCore::ImportedFunctionsEnumerator::isAtEnd): The INT and IAT are both 0-terminated
arrays.
(WebCore::ImportedFunctionsEnumerator::next): Step to the next entries in the INT and IAT.
(WebCore::ImportedFunctionsEnumerator::currentFunctionName): Gets the address of the
function's name, if possible, using the INT.
(WebCore::ImportedFunctionsEnumerator::addressOfCurrentFunctionPointer): Returns the address
of the function pointer for the current function. This function pointer is used whenever
code in m_image calls the current function. (A future patch will take advantage of this by
overwriting this function pointer with another, thereby redirecting calls to that function.)
* platform/win/ImportedFunctionsEnumerator.h: Added.
* platform/win/ImportedModulesEnumeratorBase.h: Added. This base class is used by
ImportedModulesEnumerator and DelayLoadedModulesEnumerator, and allows code to be written
that works with either one.
* platform/win/ImportedModulesEnumerator.cpp: Added. This class enumerates all the
non-delay-loaded modules imported by the image by walking the image's import array.
(WebCore::ImportedModulesEnumerator::ImportedModulesEnumerator): Module import information
is stored in the IMAGE_DIRECTORY_ENTRY_IMPORT entry of the image's DataDirectory.
(WebCore::ImportedModulesEnumerator::isAtEnd): The import array is 0-terminated.
(WebCore::ImportedModulesEnumerator::next): Steps along the import array.
(WebCore::ImportedModulesEnumerator::currentModuleName): Gets the address of the module's
name.
(WebCore::ImportedModulesEnumerator::functionsEnumerator): Get's the addresses of the INT
and IAT for this module and wraps them in an ImportedFunctionsEnumerator.
* platform/win/ImportedModulesEnumerator.h: Added.
* platform/win/DelayLoadedModulesEnumerator.cpp: Added. This class enumerates all the
delay-loaded modules that are imported by the given PEImage by walking the image's
ImageDelayDescr array.
(WebCore::DelayLoadedModulesEnumerator::DelayLoadedModulesEnumerator): Delay-load
information is stored in the IMAGE_DIRECTORY_ENTRY_DELAY_IMPORT entry of the image's
DataDirectory.
(WebCore::DelayLoadedModulesEnumerator::isAtEnd): The delay-loaded modules array is
0-terminated.
(WebCore::DelayLoadedModulesEnumerator::next): Steps along the delay-loaded modules array.
(WebCore::DelayLoadedModulesEnumerator::currentModuleName): Gets the address of the module's
name out of the descriptor.
(WebCore::DelayLoadedModulesEnumerator::functionsEnumerator): Gets the INT and IAT for the
current module out of the descriptor and makes an ImportedFunctionsEnumerator from them.
(WebCore::DelayLoadedModulesEnumerator::convertPotentialRVAToAddress): Pre-VC7.0 images
stored non-relative addresses in the ImageDelayDescr structures, while VC7.0 and later
images store RVAs. This function abstracts away the difference.
* platform/win/DelayLoadedModulesEnumerator.h: Added.
2011-04-21 Adam Roben <aroben@apple.com>
Add a shared do-nothing window class that anyone can use
Fixes <http://webkit.org/b/59102> WebKit has too many dummy window classes
Reviewed by Anders Carlsson.
* WebCore.vcproj/WebCore.vcproj: Added DefWndProcWindowClass.{cpp,h}. Moved Arena.cpp out of
platform/win and into platform. Let VS reorder other files.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Changed to use the shared
dummy window class instead of creating our own.
* platform/win/DefWndProcWindowClass.cpp: Added.
(WebCore::registerClass): Register it!
(WebCore::defWndProcWindowClassName): Register it and return it!
* platform/win/DefWndProcWindowClass.h: Added.
2011-04-21 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Content of <details> should be forwarded through the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=59055
- Made ShadowContentElement abstract and added shouldInclude() pure virtual method.
- Added SummaryContentElement, DetailsContentElement, DetailsSummaryElement as
subclasses of ShadowContentElement.
- Gave two shadow children for HTMLDetailsElement. One is DetailsContentElement, that
handles non-summary contents of <details>. Another is SummaryContentElement, that
handles the main summary element.
- Removed most of RenderDetails custom layout mechanism, which is replaced by
ShadowContentElement subclasses.
Tests: fast/html/details-add-child-1.html
fast/html/details-add-child-2.html
fast/html/details-remove-child-1.html
fast/html/details-remove-child-2.html
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::contentContainerFor):
(WebCore::ShadowRoot::hostChildrenChanged):
(WebCore::ShadowRoot::hasContentElement):
* dom/ShadowRoot.h:
* html/HTMLDetailsElement.cpp:
(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsContentElement::create):
(WebCore::DetailsContentElement::shouldInclude):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
(WebCore::DetailsSummaryElement::create):
(WebCore::DetailsSummaryElement::shouldInclude):
(WebCore::HTMLDetailsElement::create):
(WebCore::HTMLDetailsElement::HTMLDetailsElement):
(WebCore::HTMLDetailsElement::ensureShadowSubtreeOf):
(WebCore::findSummaryFor):
(WebCore::HTMLDetailsElement::ensureMainSummary):
(WebCore::HTMLDetailsElement::refreshMainSummary):
(WebCore::HTMLDetailsElement::createShadowSubtree):
* html/HTMLDetailsElement.h:
* html/HTMLSummaryElement.cpp:
(WebCore::SummaryContentElement::SummaryContentElement):
(WebCore::SummaryContentElement::shouldInclude):
(WebCore::SummaryContentElement::create):
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/shadow/ShadowContentElement.h:
* rendering/RenderDetails.cpp:
(WebCore::RenderDetails::RenderDetails):
(WebCore::RenderDetails::addChild):
* rendering/RenderDetails.h:
* rendering/RenderSummary.cpp:
* rendering/RenderSummary.h:
2011-04-21 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Extra GraphicsContext::save() in InlineTextBox::paintDecoration()
https://bugs.webkit.org/show_bug.cgi?id=59109
Remove an extraneous GraphicsContext::save() in InlineTextBox::paintDecoration().
Add an assertion that fires when a GraphicsContext() is destroyed with a non-
empty state stack. Fix canvas to avoid this assertion, since bad content might
trigger it.
Also add an assertion that fires for mismatched begin/endTransparencyLayers.
Test: fast/text/multiple-text-shadow-alpha.html
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::~HTMLCanvasElement):
Make sure that the CanvasRenderingContext goes away before the ImageBuffer,
so that CanvasRenderingContext2D has a chance to unwind the state stack in
the ImageBuffer's GraphicsContext.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
Balance unmatched state saves in the canvas context.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::~GraphicsContext):
Assert that the stack is empty.
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
Changes to allow for asserting for unmatched transparency layer begin/ends.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):
Remove an unbalanced save().
2011-04-22 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add Save As context menu item to the TextViewer.
https://bugs.webkit.org/show_bug.cgi?id=59196
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame.prototype.requestContent):
(WebInspector.ResourceSourceFrame.prototype.suggestedFileName):
(WebInspector.RevisionSourceFrame.prototype.requestContent):
(WebInspector.RevisionSourceFrame.prototype.suggestedFileName):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.SourceFrame.prototype.suggestedFileName):
(WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled):
(WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._contextMenu):
(WebInspector.TextViewerDelegate.prototype.cancelEditing):
(WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegate.prototype.suggestedFileName):
2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Move detailed heap snapshots storage and processing into workers.
https://bugs.webkit.org/show_bug.cgi?id=59094
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* gyp/streamline-inspector-source.sh:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.dispose):
(WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
(WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
(WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotIteratorsTuple.prototype.dispose):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
(MixInSnapshotNodeFunctions):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.dispose):
(WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.searchCancelled):
(WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):
(WebInspector.DetailedHeapshotView.prototype.dispose):
(WebInspector.DetailedHeapshotView.prototype.get profileWrapper):
(WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotLoader):
(WebInspector.HeapSnapshotLoader.prototype.finishLoading):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot.prototype.pushBaseIds):
(WebInspector.HeapSnapshot.prototype.createDiff):
(WebInspector.HeapSnapshot.prototype._parseFilter):
(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshot.prototype.createNodesProvider):
(WebInspector.HeapSnapshot.prototype.createPathFinder):
(WebInspector.HeapSnapshot.prototype.updateStaticData):
(WebInspector.HeapSnapshotPathFinder):
(WebInspector.HeapSnapshotPathFinder.prototype.updateRoots):
(WebInspector.HeapSnapshotPathFinder.prototype._reset):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotRealWorker):
(WebInspector.HeapSnapshotRealWorker.prototype._messageReceived):
(WebInspector.HeapSnapshotRealWorker.prototype.postMessage):
(WebInspector.HeapSnapshotRealWorker.prototype.terminate):
(WebInspector.HeapSnapshotFakeWorker):
(WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
(WebInspector.HeapSnapshotFakeWorker.prototype.terminate):
(WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotWorker.prototype.createObject):
(WebInspector.HeapSnapshotWorker.prototype.dispose):
(WebInspector.HeapSnapshotWorker.prototype.disposeObject):
(WebInspector.HeapSnapshotWorker.prototype.callGetter):
(WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod.wrapCallback):
(WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod):
(WebInspector.HeapSnapshotWorker.prototype.callMethod):
(WebInspector.HeapSnapshotWorker.prototype._findFunction):
(WebInspector.HeapSnapshotWorker.prototype._messageReceived):
(WebInspector.HeapSnapshotWorker.prototype._postMessage):
(WebInspector.HeapSnapshotProxyObject):
(WebInspector.HeapSnapshotProxyObject.prototype._callWorker):
(WebInspector.HeapSnapshotProxyObject.prototype.dispose):
(WebInspector.HeapSnapshotProxyObject.prototype.disposeWorker):
(WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod):
(WebInspector.HeapSnapshotProxyObject.prototype.callGetter):
(WebInspector.HeapSnapshotProxyObject.prototype.callMethod):
(WebInspector.HeapSnapshotLoaderProxy):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.callLoadCallbacks):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype.get loaded):
(WebInspector.HeapSnapshotLoaderProxy.prototype.startLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype.pushJSONChunk):
(WebInspector.HeapSnapshotProxy):
(WebInspector.HeapSnapshotProxy.prototype.aggregates):
(WebInspector.HeapSnapshotProxy.prototype.createDiff):
(WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createNodesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createPathFinder):
(WebInspector.HeapSnapshotProxy.prototype.dispose):
(WebInspector.HeapSnapshotProxy.prototype.finishLoading):
(WebInspector.HeapSnapshotProxy.prototype.get loaded):
(WebInspector.HeapSnapshotProxy.prototype.get nodeCount):
(WebInspector.HeapSnapshotProxy.prototype.nodeFieldValuesByIndex):
(WebInspector.HeapSnapshotProxy.prototype.pushBaseIds):
(WebInspector.HeapSnapshotProxy.prototype.get rootNodeIndex):
(WebInspector.HeapSnapshotProxy.prototype.updateStaticData):
(WebInspector.HeapSnapshotProxy.prototype.startLoading):
(WebInspector.HeapSnapshotProxy.prototype.get totalSize):
(WebInspector.HeapSnapshotProxy.prototype.get uid):
(WebInspector.HeapSnapshotProviderProxy):
(WebInspector.HeapSnapshotProviderProxy.prototype.isEmpty):
(WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems):
(WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind):
(WebInspector.HeapSnapshotPathFinderProxy):
(WebInspector.HeapSnapshotPathFinderProxy.prototype.findNext):
(WebInspector.HeapSnapshotPathFinderProxy.prototype.updateRoots):
(WebInspector.HeapSnapshotsDiffProxy):
(WebInspector.HeapSnapshotsDiffProxy.prototype.calculate):
(WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds):
(WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
* inspector/front-end/HeapSnapshotWorker.js: Added.
(WebInspector.UIString):
(postMessageWrapper):
* inspector/front-end/HeapSnapshotWorkerDispatcher.js: Added.
(WebInspector.HeapSnapshotWorkerDispatcher):
(WebInspector.HeapSnapshotWorkerDispatcher.prototype._findFunction):
(WebInspector.HeapSnapshotWorkerDispatcher.prototype.dispatchMessage):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-04-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix de-obfuscation of scripts inlined in html.
https://bugs.webkit.org/show_bug.cgi?id=58538
Use html tokenizer to find script boundaries instead of relying on scriptParsed events.
Test: inspector/debugger/script-formatter.html
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/JavaScriptFormatter.js: Renamed from Source/WebCore/inspector/front-end/UglifyJS/JavaScriptFormatter.js.
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter):
(WebInspector.ScriptFormatter.prototype.formatContent):
(WebInspector.ScriptFormatter.prototype._didFormatContent):
* inspector/front-end/ScriptFormatterWorker.js:
(onmessage):
(formatScript):
(HTMLScriptFormatter):
(HTMLScriptFormatter.prototype.format):
(HTMLScriptFormatter.prototype.scriptStarted):
(HTMLScriptFormatter.prototype.scriptEnded):
(HTMLScriptFormatter.prototype.styleSheetStarted):
(HTMLScriptFormatter.prototype.styleSheetEnded):
* inspector/front-end/SourceFile.js:
(WebInspector.FormattedSourceFile.prototype._didRequestContent):
* inspector/front-end/SourceHTMLTokenizer.js:
(WebInspector.SourceHTMLTokenizer.prototype.scriptStarted):
(WebInspector.SourceHTMLTokenizer.prototype.scriptEnded):
(WebInspector.SourceHTMLTokenizer.prototype.styleSheetStarted):
(WebInspector.SourceHTMLTokenizer.prototype.styleSheetEnded):
(WebInspector.SourceHTMLTokenizer.prototype.nextToken):
* inspector/front-end/SourceHTMLTokenizer.re2js:
* inspector/front-end/WebKit.qrc:
2011-04-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extensions API] misc API cleanup
https://bugs.webkit.org/show_bug.cgi?id=59194
* inspector/front-end/ExtensionAPISchema.json:
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane.prototype._setObject):
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: group content scripts in the scripts panel drop down.
https://bugs.webkit.org/show_bug.cgi?id=59108
* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
2011-04-22 Mike West <mkwst@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Tiny improvement to UI for adding an XHR breakpoint
https://bugs.webkit.org/show_bug.cgi?id=59100
Improve web inspector UI around adding XHR breakpoints by adding
a textual label to the input-like `span` used to specify which
XHR requests the breakpoint ought to target.
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing):
(WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
* inspector/front-end/inspector.css:
(#breakpoint-condition-input):
2011-04-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: js formatter should never insert new tokens or remove existing tokens and comments.
https://bugs.webkit.org/show_bug.cgi?id=59191
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
(WebInspector.ScriptFormatter.prototype.formatContent):
* inspector/front-end/ScriptFormatterWorker.js:
(onmessage):
* inspector/front-end/SourceFile.js:
(WebInspector.SourceFile.prototype._loadResourceContent):
(WebInspector.FormattedSourceFile.prototype._didRequestContent):
(WebInspector.FormattedSourceMapping):
(WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine):
(WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
(WebInspector.FormattedSourceMapping.prototype._convertPosition):
* inspector/front-end/UglifyJS/JavaScriptFormatter.js: Added.
(FormattedContentBuilder): Helper class for building formatted script content.
(FormattedContentBuilder.prototype.addToken):
(FormattedContentBuilder.prototype.addSpace):
(FormattedContentBuilder.prototype.addNewLine):
(FormattedContentBuilder.prototype.increaseNestingLevel):
(FormattedContentBuilder.prototype.decreaseNestingLevel):
(FormattedContentBuilder.prototype.content):
(FormattedContentBuilder.prototype.mapping):
(Tokenizer): Wrapper class for UglifyJS tokenizer.
(Tokenizer.prototype.content):
(Tokenizer.prototype.next):
(Tokenizer.prototype._convertUglifyToken):
(JavaScriptFormatter): New formatter based on UglifyJS tokenizer.
(JavaScriptFormatter.prototype.format):
* inspector/front-end/UglifyJS/process.js: Removed.
* inspector/front-end/WebKit.qrc:
2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Refactor code prior to moving detailed heap snapshots into workers.
https://bugs.webkit.org/show_bug.cgi?id=59189
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/BinarySearch.js: Added.
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._populate.sorted):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
(WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.sort):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainingPathsList.prototype._performSorting):
(WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded):
(WebInspector.DetailedHeapshotView.prototype._changeBase):
(WebInspector.DetailedHeapshotView.prototype._changeView):
(WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString):
(WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.pushBaseNodeIds):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNextItems):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAndRewind):
(WebInspector.HeapSnapshotEdgesProvider.prototype._serialize):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
(WebInspector.HeapSnapshotsDiff.prototype.calculate):
(WebInspector.HeapSnapshotsDiff.prototype.pushBaseIds):
(WebInspector.HeapSnapshotsDiff.prototype.pushBaseSelfSizes):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createNodesProvider):
(WebInspector.HeapSnapshotProxy.prototype.pushBaseIds):
(WebInspector.HeapSnapshotProviderProxy):
(WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems):
(WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind):
(WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds):
(WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
* inspector/front-end/PleaseWaitMessage.js:
(WebInspector.PleaseWaitMessage.prototype.showAndWaitFor):
(WebInspector.PleaseWaitMessage.prototype.unlistenAndHide):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/utilities.js:
2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
Unreviewed fix after r84484 -- conditional statement was inverted incorrectly.
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.handleShortcut):
2011-04-22 Annie Sullivan <sullivan@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Timeline is too narrow
https://bugs.webkit.org/show_bug.cgi?id=58399
Changed Network Panel widths so that Timeline is 50%.
Added titles to the values in the other columns, so that a tooltip will show the value if the column is too narrow.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._createTable): Changed column widths.
(WebInspector.NetworkPanel.prototype._toggleGridMode): Changed column widths.
(WebInspector.NetworkDataGridNode.prototype.refreshResource): Added titles to column values.
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): Ditto
(WebInspector.NetworkDataGridNode.prototype._refreshSizeCell): Ditto
(WebInspector.NetworkDataGridNode.prototype._refreshTimeCell): Ditto
* inspector/front-end/utilities.js:
(Element.prototype.setTextAndTitle): Added new method to set the textContent and title of an Element at the same time, so that it can have a tooltip.
2011-04-22 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playing audio-only media
https://bugs.webkit.org/show_bug.cgi?id=59180
Test: media/audio-controls-do-not-fade-out.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::playbackProgressTimerFired): Only start fading out the controls if there is
a video track.
2011-04-22 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Add FontItalics and FontSmallCaps enums to be used instead of boolean values.
https://bugs.webkit.org/show_bug.cgi?id=59080
No new tests as no new functionality added.
* css/CSSPrimitiveValueMappings.h:
Add casts to/from FontItalics and FontSmallCaps
* css/CSSStyleSelector.cpp:
Use new casts defined in PrimitiveValueMappings.h
* platform/graphics/Font.h:
Use FontItalics enum.
* platform/graphics/FontDescription.h:
Define and use FontItalics and FontSmallCaps enums.
2011-04-21 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: exception in front-end when user selects resource info for resource that does not have response headers yet
https://bugs.webkit.org/show_bug.cgi?id=59123
* inspector/front-end/ResourceCookiesView.js:
(WebInspector.ResourceCookiesView):
(WebInspector.ResourceCookiesView.prototype.show):
(WebInspector.ResourceCookiesView.prototype.get _gotCookies):
(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):
2011-04-21 Beth Dakin <bdakin@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=57898
REGRESSION (r82185): Scroll position not restored on navigation back to a page in
the page cache
-and corresponding-
<rdar://problem/9226652>
The original fix for this change broke scroll-position restore for pages that are
*not* in the page cache. This patch fixes both cached and non-cached pages by
using the cachedScrollPosition() only for cached pages.
* loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
2011-04-21 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Remove redundant calls to RenderStyle::setDisplay()
https://bugs.webkit.org/show_bug.cgi?id=59060
No new tests / no new functionality added.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove redundant calls to RenderStyle::setDisplay()
2011-04-21 John Bauman <jbauman@chromium.org>
Reviewed by Kenneth Russell.
WebGL context drawing buffer may not be cleared if FBO bound
https://bugs.webkit.org/show_bug.cgi?id=58956
Clear the drawing buffer even if it's not currently bound, by
switching between FBOs around the clear. Also, make sure that we
handle depth and stencil masks properly.
No new tests, because testing this under DRT doesn't work.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::depthMask):
* html/canvas/WebGLRenderingContext.h:
*
2011-04-21 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
WebKit is erroneously modifying the DOM; adding 'aria-selected' to tables
https://bugs.webkit.org/show_bug.cgi?id=59140
WebKit should not modify the DOM when the screen reader requests certain things be set. There is no
specification that allows this behavior yet, but we are working on something for the future.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setARIAGrabbed):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelected):
(WebCore::AccessibilityRenderObject::setValue):
2011-04-21 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
AX: order AccessibilityRole alphabetically
https://bugs.webkit.org/show_bug.cgi?id=31524
* accessibility/AccessibilityObject.h:
2011-04-21 Jia Pu <jpu@apple.com>
Reviewed by Maciej Stachowiak.
[Mac] correctionPanelTimerFired() crashes due to rangeToBeReplaced being cleared.
https://bugs.webkit.org/show_bug.cgi?id=59155
<rdar://problem/9261698>
Make sure the range isn't cleared before calling windowRectForRange() on it. Also removed unused functions in Editor.h,
and fixed a typo in function name.
* editing/Editor.h:
* editing/SpellingCorrectionController.cpp:
(WebCore::SpellingCorrectionController::correctionPanelTimerFired):
(WebCore::SpellingCorrectionController::respondToChangedSelection):
* editing/SpellingCorrectionController.h:
(WebCore::SpellingCorrectionController::shouldStartTimerFor):
2011-04-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
Add a feature define to allow <details> and <summary> to be disabled
https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>
No new tests; no behavior change.
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* features.pri:
* html/HTMLDetailsElement.cpp:
* html/HTMLSummaryElement.cpp:
* html/HTMLTagNames.in:
* html/shadow/DetailsMarkerControl.cpp:
* rendering/RenderBlock.cpp:
(WebCore::canMergeContiguousAnonymousBlocks):
* rendering/RenderDetails.cpp:
* rendering/RenderDetails.h:
* rendering/RenderDetailsMarker.cpp:
* rendering/RenderDetailsMarker.h:
* rendering/RenderObject.h:
* rendering/RenderSummary.cpp:
* rendering/RenderSummary.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
2011-04-21 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adele Peterson.
REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
https://bugs.webkit.org/show_bug.cgi?id=59053
Turns out, the relatedTarget of an event could be also an ancestor of an event,
not just its parent. Duh.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::adjustToShadowBoundaries): Changed to use shadowHost
explicitly.
2011-04-21 Michael Saboff <msaboff@apple.com>
Reviewed by Maciej Stachowiak.
Qualified names used for all TagName access, yet namespace usage is rare
https://bugs.webkit.org/show_bug.cgi?id=58997
The methods getElementsByTagName and getElementsByTagNameNS where
always creating and using QualifiedNames. QualifiedName::init
was consistently in the top 3 routines when running the Dromaeo
DOM-query benchmark. Split out the functionality so that
getElementsByTagName uses just the local name, an implied "*"
namespace and a separate TagNodeListCache keyed by an atomic name
instead of a QualifiedName. Access to elements via
getElementsByTagNameNS that have "*" namespace are forwarded to
getElementsByTagName as well. This provides ~10% speed up in that
Dromaeo test.
No new tests added, existing tests have coverage. The changes are
an optimization of existing functionality.
* dom/Node.cpp:
(WebCore::Node::removeCachedTagNodeList):
(WebCore::Node::getElementsByTagName):
(WebCore::Node::getElementsByTagNameNS):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::isEmpty):
* dom/Node.h:
* dom/NodeRareData.h:
* dom/TagNodeList.cpp:
(WebCore::TagNodeList::~TagNodeList):
2011-04-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: more style- and node-related stuff
https://bugs.webkit.org/show_bug.cgi?id=59127
* bindings/js/JSCanvasRenderingContextCustom.cpp:
* bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::JSCanvasRenderingContextOwner::isReachableFromOpaqueRoots):
(WebCore::JSCanvasRenderingContextOwner::finalize):
(WebCore::wrapperOwner):
(WebCore::wrapperContext): Use opaque roots for marking canvas rendering
contexts, so JSNode isn't responsible for it.
* bindings/js/JSElementCustom.cpp:
(WebCore::JSElement::markChildren):
* bindings/js/JSHTMLCanvasElementCustom.cpp:
* bindings/js/JSHTMLLinkElementCustom.cpp:
* bindings/js/JSHTMLStyleElementCustom.cpp: Removed obsolete marking code.
* bindings/js/JSNodeCustom.cpp:
(WebCore::isObservable):
(WebCore::isReachableFromDOM):
(WebCore::JSNodeOwner::isReachableFromOpaqueRoots): Removed a bunch of
CSS object model related special cases, since the CSS object model
now tracks its own lifetime through the opaque roots system. Removed
canvas special case, covered above.
* bindings/js/JSProcessingInstructionCustom.cpp:
* bindings/js/JSWebKitAnimationListCustom.cpp:
* dom/ProcessingInstruction.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLLinkElement.idl:
* html/HTMLStyleElement.idl:
* page/WebKitAnimationList.idl: Removed obsolete marking code.
2011-04-21 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Only update the contents of layers that are going to
be drawn. Remove individual texture unreserves that happen
after the layer draw calls with a single unreserve for all the
textures in the texture manager.
https://bugs.webkit.org/show_bug.cgi?id=59129
Tests: No new functionality. Covered by existing layout tests.
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::draw):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::updateCompositorResources):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::updateAndDrawLayers):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::paintLayerContents):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/LayerTexture.cpp:
* platform/graphics/chromium/LayerTexture.h:
* platform/graphics/chromium/LayerTilerChromium.cpp:
* platform/graphics/chromium/LayerTilerChromium.h:
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::drawSurface):
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::unprotectAllTextures):
* platform/graphics/chromium/TextureManager.h:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::owner):
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
canCopyCut and canPaste now takes Frame* for which supportedCopyCut and supportedPaste are called.
This allows editor client to grant copy/cut and paste permissions per origin.
* editing/EditorCommand.cpp:
(WebCore::supportedCopyCut):
(WebCore::supportedPaste):
* loader/EmptyClients.h:
(WebCore::EmptyEditorClient::canCopyCut):
(WebCore::EmptyEditorClient::canPaste):
* page/EditorClient.h:
2011-04-21 Oliver Hunt <oliver@apple.com>
Whoops, change lost during merge
* bindings/js/JSEventListener.h:
2011-04-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a failure seen in fast/dom/prototype-inheritance-2.html due to
wrong global object use.
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter): Use the right global object.
2011-04-21 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Start moving to a general visitor pattern for GC traversal
https://bugs.webkit.org/show_bug.cgi?id=59141
This is just a rename:
markChildren -> visitChildren
markAggregate -> visitAggregate
markStack -> visitor
MarkStack -> typedef'd to SlotVisitor
* bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::visitChildren):
* bindings/js/JSAudioConstructor.cpp:
(WebCore::constructAudio):
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::JSCSSRule::visitChildren):
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::visitChildren):
* bindings/js/JSDOMBinding.cpp:
(WebCore::visitActiveObjectsForContext):
(WebCore::markDOMObjectWrapper):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::visitChildren):
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMImplementationCustom.cpp:
(WebCore::JSDOMImplementation::visitChildren):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitChildren):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::visitChildren):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::visitChildren):
* bindings/js/JSElementCustom.cpp:
(WebCore::JSElement::visitChildren):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::markJSFunction):
* bindings/js/JSEventListener.h:
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::visitChildren):
* bindings/js/JSHTMLLinkElementCustom.cpp:
(WebCore::JSHTMLLinkElement::visitChildren):
* bindings/js/JSHTMLStyleElementCustom.cpp:
(WebCore::JSHTMLStyleElement::visitChildren):
* bindings/js/JSImageConstructor.cpp:
(WebCore::constructImage):
* bindings/js/JSJavaScriptAudioNodeCustom.cpp:
(WebCore::JSJavaScriptAudioNode::visitChildren):
* bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::visitChildren):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::visitChildren):
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMapOwner::isReachableFromOpaqueRoots):
(WebCore::JSNamedNodeMap::visitChildren):
* bindings/js/JSNavigatorCustom.cpp:
(WebCore::JSNavigator::visitChildren):
* bindings/js/JSNodeCustom.cpp:
(WebCore::isObservable):
(WebCore::isReachableFromDOM):
(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
(WebCore::JSNode::visitChildren):
* bindings/js/JSNodeCustom.h:
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
* bindings/js/JSNodeFilterCondition.h:
* bindings/js/JSNodeFilterCustom.cpp:
(WebCore::JSNodeFilter::visitChildren):
* bindings/js/JSNodeIteratorCustom.cpp:
(WebCore::JSNodeIterator::visitChildren):
* bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
* bindings/js/JSProcessingInstructionCustom.cpp:
(WebCore::JSProcessingInstruction::visitChildren):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::visitChildren):
* bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorker::visitChildren):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheet::visitChildren):
* bindings/js/JSTreeWalkerCustom.cpp:
(WebCore::JSTreeWalker::visitChildren):
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::visitChildren):
* bindings/js/JSWebKitAnimationListCustom.cpp:
(WebCore::JSWebKitAnimationList::visitChildren):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::visitChildren):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitChildren):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::visitChildren):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::visitChildren):
(JSC::Bindings::QtInstance::markAggregate):
* bridge/qt/qt_instance.h:
* bridge/qt/qt_pixmapruntime.cpp:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
* bridge/qt/qt_runtime.h:
* dom/EventListener.h:
(WebCore::EventListener::visitJSFunction):
* dom/EventTarget.h:
(WebCore::EventTarget::visitJSEventListeners):
* dom/Node.h:
* dom/NodeFilterCondition.h:
(WebCore::NodeFilterCondition::visitAggregate):
* page/DOMWindow.h:
* workers/WorkerContext.h:
2011-04-21 Beth Dakin <bdakin@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=59048
Need to track whether overlay scrollbar is currently visible and in lower-
righthand corner
-and corresponding-
<rdar://problem/9211232>
Whenever we start a new ScrollbarPartAnimation, check if the scrollbar is vertical
and showing (alpha of 1), and if so, call setVisibleScrollerThumbRect with the
knob rect, otherwise with an empty rect. ScrollAnimatorMac has a local rect to
track this value so that it can avoid sending messages across the ChromeClient to
the UIProcess if the rect has not changed.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::setVisibleScrollerThumbRect):
Plumbing for the chrome client.
* page/ChromeClient.h:
(WebCore::ChromeClient::notifyScrollerThumbIsVisibleInRect):
* page/FrameView.cpp:
(WebCore::FrameView::setVisibleScrollerThumbRect):
* page/FrameView.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::setVisibleScrollerThumbRect):
New WebCoreSystemInterface function to get the knob rect.
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
2011-04-21 Nat Duca <nduca@chromium.org>
Reviewed by James Robinson.
[chromium] Fix artefacts in compositor HUD when resizing
https://bugs.webkit.org/show_bug.cgi?id=58969
HUD was using the tiler program and not setting the texture
transform. The HUD would thus draw with a texture transform based
on the last tile drawn, leading sometimes to distortion.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
2011-04-21 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
only return false if we actually in a skia-gpu accelerated canvas for isNativeFontRenderingAllowed
https://bugs.webkit.org/show_bug.cgi?id=59024
No new tests. The bug (and fix) depend on enabling SKIA_GPU. When that is enabled, the bug
shows all text w/o lcd rendering. This is a regression from a recent CL when we switch to
calling skia::SupportsPlatformPaint. This CL fixes that.
There should be no change for the default builds when SKIA_GPU is not enabled.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2011-04-21 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Don't upload partially drawn tiles in the compositor
https://bugs.webkit.org/show_bug.cgi?id=59112
Use the same set of tiles for painting as is used for updating.
Before, a larger set of tiles were being uploaded, causing some to
only be partially undirtied because they were not fully painted.
As tiles are clear their dirty rect after being unpainted, this caused
artifacts to appear when scrolling.
Unfortunately, no layout test can test this behavior yet because
scrolling invalidations are done differently in test shell.
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateCompositorResources):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::update):
(WebCore::LayerTilerChromium::uploadCanvas):
(WebCore::LayerTilerChromium::updateFromPixels):
* platform/graphics/chromium/LayerTilerChromium.h:
2011-04-21 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=58725
Fix a compile issue on Solaris 10 with Sun Studio 12,
ternary operators (?:) must have the same types
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::popArchiveForSubframe):
* loader/archive/ArchiveFactory.cpp:
(WebCore::ArchiveFactory::create):
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::setIconDataForIconURL):
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollCornerStyle):
(WebCore::RenderLayer::updateResizerStyle):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarPart):
* rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::RenderTextFragment):
2011-04-21 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
[chromium, win] Multiple failures of shadow rendering layout tests
https://bugs.webkit.org/show_bug.cgi?id=58772
No new tests. This CL fixes a regression in the following tests
fast/multicol/shadow-breaking.html
fast/repaint/shadow-multiple-horizontal.html
fast/repaint/shadow-multiple-strict-horizontal.html
fast/repaint/shadow-multiple-strict-vertical.html
fast/repaint/shadow-multiple-vertical.html
fast/text/shadow-translucent-fill.html
fast/transforms/shadows.html
svg/css/group-with-shadow.svg
svg/css/shadow-changes.svg
svg/css/text-shadow-multiple.xhtml
transitions/svg-text-shadow-transition.html
svg/css/composite-shadow-text.svg
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
2011-04-21 Geoffrey Garen <ggaren@apple.com>
Try to fix the Qt build.
* UseJSC.cmake:
* WebCore.pro: Use correct file name.
2011-04-21 Dirk Schulze <krit@webkit.org>
Unreviewed Qt build fix.
SVG feDropShadow implementation of SVG Filters 1.2
https://bugs.webkit.org/show_bug.cgi?id=52513
* CodeGenerators.pri:
2011-04-21 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Clamp dirty regions on content layers to layer bounds
https://bugs.webkit.org/show_bug.cgi?id=58933
This prevents garbage being rendered when layers are resized and a
previous invalidation (now off-layer) is no longer valid.
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
2011-04-21 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 59012 - Shadows should be imported along with their host nodes
https://bugs.webkit.org/show_bug.cgi?id=59012
Copy the shadow tree of an element (even on a shallow copy!).
Test: fast/dom/shadow/import-shadowroot.html
* dom/Element.cpp:
(WebCore::Element::copyNonAttributeProperties):
* dom/Element.h:
2011-04-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: CSS Object Model
https://bugs.webkit.org/show_bug.cgi?id=59057
This is 24 hours of my life I will never get back. Thank you, W3C.
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj: Build!
* bindings/js/JSCSSFontFaceRuleCustom.cpp:
* bindings/js/JSCSSImportRuleCustom.cpp:
* bindings/js/JSCSSMediaRuleCustom.cpp:
* bindings/js/JSCSSPageRuleCustom.cpp:
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::JSCSSRuleOwner::isReachableFromOpaqueRoots):
(WebCore::JSCSSRuleOwner::finalize):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::JSCSSRule::markChildren):
* bindings/js/JSCSSRuleListCustom.cpp:
(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):
(WebCore::JSCSSRuleListOwner::finalize):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::toJS):
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclarationOwner::isReachableFromOpaqueRoots):
(WebCore::JSCSSStyleDeclarationOwner::finalize):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::JSCSSStyleDeclaration::markChildren): Removed custom mark functions,
and replaced with use of the opaque roots system. This has the nice benefit
of allowing us to eagerly recycle far more CSS wrappers and their associated
DOM wrappers.
(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue): Made this function
custom because it must maintain the sorrowful invariant that primitive
values can be mapped back to objects that are reachable through the DOM.
We maintain this invariant through an external hash table because
making all primitive values bigger would be a too-large memory use
penalty. Luckily, nobody uses this feature, so the cost of the hash table
is no big deal.
(WebCore::toJS): We need a custom toJS so we can specify our own WeakHandleOwner.
* bindings/js/JSCSSStyleRuleCustom.cpp: Removed custom mark, as above.
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::cssValueRoots):
(WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
(WebCore::JSCSSValueOwner::finalize):
(WebCore::wrapperOwner):
(WebCore::wrapperContext): Use the opaque roots system. Piggy-back on
the external hash table filled by JSCSSStyleDeclaration::getPropertyCSSValue.
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::markChildren): No need to mark our stylesheet list,
since all style-related objects can use our opaque root to determine
liveness.
* bindings/js/JSMediaListCustom.cpp: Added.
(WebCore::JSMediaListOwner::isReachableFromOpaqueRoots):
(WebCore::JSMediaListOwner::finalize):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::toJS): Use the opaque roots system.
* bindings/js/JSNodeCustom.h:
(WebCore::root): Added helpers for computing style-related roots.
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheetOwner::isReachableFromOpaqueRoots):
(WebCore::JSStyleSheetOwner::finalize):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::JSStyleSheet::markChildren): Use the opaque roots system instead
of direct marking.
* bindings/js/JSStyleSheetListCustom.cpp:
(WebCore::JSStyleSheetListOwner::isReachableFromOpaqueRoots):
(WebCore::JSStyleSheetListOwner::finalize):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::toJS): Ditto.
* bindings/js/JSWebKitCSSKeyframeRuleCustom.cpp:
* bindings/js/JSWebKitCSSKeyframesRuleCustom.cpp:
* css/CSSFontFaceRule.idl:
* css/CSSImportRule.idl: No more custom mark, since we use the opaque
roots system instead.
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule): Fixed a bug where a media rule
would incorrectly have no parent, since this got in the way of correctly
computing the media rule's root.
* css/CSSMediaRule.idl:
* css/CSSPageRule.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleRule.idl:
* css/MediaList.idl: Match behavior changes above.
* css/StyleBase.cpp:
(WebCore::StyleBase::node): Helper function for computing roots of the
style system. This object model is pretty weird and not very well factored,
but I'm pretty sure this covers all the relevant cases.
* css/StyleBase.h:
* css/StyleSheetList.idl:
* css/WebKitCSSKeyframeRule.idl:
* css/WebKitCSSKeyframesRule.idl: Updated to match the behavior changes above.
2011-04-21 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG feDropShadow implementation of SVG Filters 1.2
https://bugs.webkit.org/show_bug.cgi?id=52513
This is the implementation of feDropShadow, a shorthand filter and a combination of feGaussianBlur,
feOffset, feFlood and feComposite to create a drop shadow of an input effect.
Creating this new filter effect makes it possible to optimize the often used workflow. ShadowBlur, with its
fast blurring algorithm, is used to blur the shadow and composite operators are responsible for combining the
source with different colored shadows.
Shadow color and opacity can be set with the properties flood-color and flood-opacity.
Tests: svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html
svg/filters/feDropShadow.svg
* Android.mk:
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
(WebCore::createElementClassMap):
* bindings/objc/DOMSVG.h:
* page/DOMWindow.idl:
* platform/graphics/ShadowBlur.cpp: Added missing copyright after r84410.
* platform/graphics/ShadowBlur.h: Made blurLayerImage public.
* platform/graphics/filters/FEDropShadow.cpp: Added.
(WebCore::FEDropShadow::FEDropShadow):
(WebCore::FEDropShadow::create):
(WebCore::FEDropShadow::determineAbsolutePaintRect):
(WebCore::FEDropShadow::apply):
(WebCore::FEDropShadow::dump):
(WebCore::FEDropShadow::externalRepresentation):
* platform/graphics/filters/FEDropShadow.h: Added.
(WebCore::FEDropShadow::stdDeviationX):
(WebCore::FEDropShadow::setStdDeviationX):
(WebCore::FEDropShadow::stdDeviationY):
(WebCore::FEDropShadow::setStdDeviationY):
(WebCore::FEDropShadow::dx):
(WebCore::FEDropShadow::setDx):
(WebCore::FEDropShadow::dy):
(WebCore::FEDropShadow::setDy):
(WebCore::FEDropShadow::shadowColor):
(WebCore::FEDropShadow::setShadowColor):
(WebCore::FEDropShadow::shadowOpacity):
(WebCore::FEDropShadow::setShadowOpacity):
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::calculateKernelSize): Make kernel calculations accessible for feDropShadow.
* platform/graphics/filters/FEGaussianBlur.h:
* svg/SVGAllInOne.cpp:
* svg/SVGFEDropShadowElement.cpp: Added.
(WebCore::SVGFEDropShadowElement::SVGFEDropShadowElement):
(WebCore::SVGFEDropShadowElement::create):
(WebCore::SVGFEDropShadowElement::stdDeviationXIdentifier):
(WebCore::SVGFEDropShadowElement::stdDeviationYIdentifier):
(WebCore::SVGFEDropShadowElement::setStdDeviation):
(WebCore::SVGFEDropShadowElement::parseMappedAttribute):
(WebCore::SVGFEDropShadowElement::svgAttributeChanged):
(WebCore::SVGFEDropShadowElement::synchronizeProperty):
(WebCore::SVGFEDropShadowElement::build):
* svg/SVGFEDropShadowElement.h: Added.
* svg/SVGFEDropShadowElement.idl: Added.
* svg/svgtags.in:
2011-04-21 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 58704 - Decide on node type for ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=58704
Add a new node type SHADOW_ROOT_NODE.
Adapt all calling sites of nodeType().
Test: fast/dom/shadow/nodetype.html
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
* bindings/objc/DOM.mm:
(kitClass):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):
* dom/Node.cpp:
(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::appendTextContent):
(WebCore::Node::setTextContent):
* dom/Node.h:
* dom/Range.cpp:
(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::checkNodeBA):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
(WebCore::Range::surroundContents):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::nodeType):
* dom/Traversal.cpp:
(WebCore::Traversal::acceptNode):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):
* html/parser/HTMLElementStack.h:
(WebCore::isInHTMLNamespace):
* xml/XPathUtil.cpp:
(WebCore::XPath::isValidContextNode):
2011-04-20 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
REGRESSION (r75543): Styles bleed into new shadow DOM (like slider and video)
https://bugs.webkit.org/show_bug.cgi?id=52917
In order to determine whether a rule should apply inside of a shadow DOM subtree,
we collect three pieces of information:
1) Are we parsing UA sheets?
2) Does the current tree scope allows applying author sheets?
3) Does the rule explicitly reach into shadow DOM (using pseudo-elements, for example)?
If the answer to all of these is no, we ignore the rule.
Test: fast/css/shadow-dom-scope.html
* css/CSSStyleSelector.cpp:
(WebCore::MatchingUARulesScope::MatchingUARulesScope): Added a scope helper to
track whether we are currently matching UA rules.
(WebCore::CSSStyleSelector::matchRulesForList): Added the check for three
conditions mentioned above.
(WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker): Added
initializer for the flag, which helps us determine whether the rule
explicitly reaches into shadow DOM.
(WebCore::CSSStyleSelector::matchUARules): Started using the scope helper.
(WebCore::CSSStyleSelector::checkSelector): Added initializing of the
flag.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added setting
of the flag when we encounter unknown pseudo-elements.
* css/CSSStyleSelector.h: Adjusted decls.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::applyAuthorSheets): Added.
* dom/ShadowRoot.h: Adjusted decls.
* dom/TreeScope.cpp:
(WebCore::TreeScope::applyAuthorSheets): Added.
* dom/TreeScope.h: Adjusted decls.
2011-04-21 Levi Weintraub <leviw@chromium.org>
Reviewed by Simon Fraser.
position fixed element does not render properly when dynamically updated via javascript
https://bugs.webkit.org/show_bug.cgi?id=54297
Disabling the LayoutState fast-path for fixed-position content.
Tests: fast/repaint/fixed-contents-changed-after-scroll.html
fast/repaint/transformed-contents-changed-after-scroll.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
2011-04-20 Matthew Delaney <mdelaney@apple.com>
Reviewed by Maciej Stachowiak.
arc() should add a circle to the path when start and end angles are far enough apart
https://bugs.webkit.org/show_bug.cgi?id=58934
Test: fast/canvas/canvas_arc_largeangles.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::arc):
2011-04-20 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Content of <summary> should be forwarded through the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=58914
- Introduced ShadowContentElement which hosts forwarded children of <summary>
- Encapsulated Node::parentNodeForRenderingAndStyle() and shouldCreateRendererFor()
into NodeVisualParentLookupResult class.
- The parent lookup is also aware of node forwarding. If the visual parent node has
a shadow root, the node is possibly forwarded to ShadowContentElement
- ShadowContentElement lookup is implemented inside ShadowRoot.
Tests: fast/html/details-add-summary-child-1.html
fast/html/details-add-summary-child-2.html
fast/html/details-remove-summary-child-1.html
fast/html/details-remove-summary-child-2.html
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Element.cpp:
(WebCore::Element::childrenChanged):
* dom/Node.cpp:
(WebCore::NodeRenderParentDetector::NodeRenderParentDetector):
(WebCore::NodeRenderParentDetector::parentNodeForRenderingAndStyle):
(WebCore::NodeRenderParentDetector::findVisualParent):
(WebCore::NodeRenderParentDetector::shouldCreateRenderer):
(WebCore::Node::parentNodeForRenderingAndStyle):
(WebCore::Node::createRendererAndStyle):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::contentContainerFor):
(WebCore::ShadowRoot::hostChildrenChanged):
(WebCore::ShadowRoot::firstContentElement):
* dom/ShadowRoot.h:
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLSummaryElement.h:
* html/shadow/ShadowContentElement.h: Copied from Source/WebCore/dom/ShadowRoot.h.
(WebCore::ShadowContentElement::ShadowContentElement):
(WebCore::ShadowContentElement::isShadowBoundary):
(WebCore::ShadowContentElement::createRenderer):
(WebCore::ShadowContentElement::create):
2011-04-21 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix calls to WebInspector.ObjectPropertiesSection constructor
https://bugs.webkit.org/show_bug.cgi?id=59105
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._formatobject):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane.prototype._setObject):
* inspector/front-end/ResourceJSONView.js:
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
(WebInspector.SourceFrame.prototype._showPopup):
2011-04-21 Adam Barth <abarth@webkit.org>
Remove support for CSP's frame-src. This approach causes too many
extra console messages to be logged. I'm leaving in the test (which
now shows failure).
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed):
2011-04-21 Eunsol Park <eunsol47.park@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Scroll doesn't work on tiled backing store.
https://bugs.webkit.org/show_bug.cgi?id=55021
It was added from Changeset 72242, but it worked wrong in EFL port.
The visible rect should not be returned as content rect for scrolling in EFL tiled backing store,
because it works differently from QT.
* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
2011-04-21 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel.
Create RIAA class for GraphicsContext::save() and restore()
https://bugs.webkit.org/show_bug.cgi?id=58807
Use GraphicsContextStateSaver in a lot more places.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::draw):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextStateSaver::save):
(WebCore::GraphicsContextStateSaver::restore):
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::drawShadowBuffer):
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::drawLayerPieces):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::draw):
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::apply):
* platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::apply):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::paint):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
* platform/mac/ThemeMac.mm:
(WebCore::paintCheckbox):
(WebCore::paintRadio):
(WebCore::paintStepper):
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paintSelection):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintTextMatchMarker):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintSelection):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorationsWithSize):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintBorder):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintReplaced):
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintChildLayerIntoColumns):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::paintPlaceholder):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::paint):
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::paint):
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::paint):
* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::paint):
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::paint):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::fillAndStrokePath):
(WebCore::RenderSVGPath::paint):
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
* rendering/svg/RenderSVGResourceMarker.cpp:
(WebCore::RenderSVGResourceMarker::draw):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::paint):
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paint):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::paint):
(WebCore::SVGInlineTextBox::paintDecorationWithStyle):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
* svg/SVGFont.cpp:
(WebCore::Font::drawTextUsingSVGFont):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw):
2011-04-20 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extensions API] console API is not exposed to code evaluated by sidebar.setExpression()
https://bugs.webkit.org/show_bug.cgi?id=59006
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane.prototype.setExpression):
2011-04-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Split SVGGlyphIdentifier class out of SVGGlyphElement.h
https://bugs.webkit.org/show_bug.cgi?id=59101
Move SVGGlyphIdentifier class out of SVGGlyphElement.h, place it in platform/graphics/SVGGlyph.h
and rename the contained struct to SVGGlyph. It will be used in follow-up patches that will integrate SVGGlyph & GlyphPage.
Several utility functions are moved from SVGFont.cpp to SVGGlyph.cpp, as that's the place where they really belong to.
Renamed nameLength to unicodeStringLength in the SVGGlyph struct for clarity.
* Android.mk: Add SVGGlyph.cpp/h to build.
* CMakeLists.txt: Ditto.
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/graphics/SVGGlyph.cpp: Copied from svg/SVGFont.cpp. Removed everything except the methods listed below, that belong here.
(WebCore::processArabicFormDetection):
(WebCore::charactersWithArabicForm):
(WebCore::isCompatibleArabicForm):
(WebCore::isCompatibleGlyph):
* platform/graphics/SVGGlyph.h: Copied from svg/SVGGlyphElement.h. Renamed SVGGlyphIdentifier to SVGGlyph.
(WebCore::SVGGlyph::SVGGlyph):
(WebCore::SVGGlyph::operator==):
* platform/graphics/SimpleFontData.cpp: Adapt for SVGGlyphIdentifier -> SVGGlyph and nameLength -> unicodeStringLength rename.
(WebCore::SimpleFontData::SimpleFontData):
* svg/SVGFont.cpp: Ditto. Remove helper functions that are now living in SVGGlyph.cpp
(WebCore::SVGTextRunWalker::walk):
(WebCore::floatWidthUsingSVGFontCallback):
(WebCore::drawTextUsingSVGFontCallback):
(WebCore::drawTextMissingGlyphCallback):
(WebCore::Font::drawTextUsingSVGFont):
* svg/SVGFontElement.cpp: Ditto.
(WebCore::SVGFontElement::getGlyphIdentifiersForString):
* svg/SVGFontElement.h: Ditto.
* svg/SVGGlyphElement.cpp: Ditto.
(WebCore::parseArabicForm):
(WebCore::parseOrientation):
(WebCore::SVGGlyphElement::inheritUnspecifiedAttributes):
(WebCore::parseSVGGlyphAttribute):
(WebCore::SVGGlyphElement::buildGenericGlyphIdentifier):
(WebCore::SVGGlyphElement::buildGlyphIdentifier):
* svg/SVGGlyphElement.h: Ditto.
* svg/SVGGlyphMap.h: Ditto.
(WebCore::SVGGlyphMap::add):
(WebCore::SVGGlyphMap::compareGlyphPriority):
(WebCore::SVGGlyphMap::get):
2011-04-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Live streams won't play with AVFoundation backend
https://bugs.webkit.org/show_bug.cgi?id=58961
rdar://problem/9284748
Tested manually because we don't have any live streams to test in DRT.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::seek): Do nothing when asked to seek to the
current time.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): If the readyState is HaveEnoughData,
don't revert when the new state is "ready to play" or "buffer full".
(WebCore::MediaPlayerPrivateAVFoundation::movieLoadType): Use new convenience function isLiveStream.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::isLiveStream): New.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Don't use AVAsset's
tracksWithMediaCharacteristic because it doesn't give us what we need with live
streams.
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Cookies section in empty on page re-launch.
https://bugs.webkit.org/show_bug.cgi?id=59095
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._reset):
(WebInspector.ResourcesPanel.prototype._frameNavigated):
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: rename De-obfuscate to Pretty print.
https://bugs.webkit.org/show_bug.cgi?id=59093
* English.lproj/localizedStrings.js:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: following Image URL link in the network panel does nothing.
https://bugs.webkit.org/show_bug.cgi?id=59092
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
(WebInspector.ImageView.prototype._createContentIfNeeded):
* inspector/front-end/inspector.js:
(WebInspector.linkifyURLAsNode):
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: implement Go To Line for network panel.
https://bugs.webkit.org/show_bug.cgi?id=59090
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView.prototype._tabSelected):
(WebInspector.NetworkItemView.prototype._installHighlightSupport):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype.selectTab):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.highlightLine):
2011-04-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Split GlyphPage from GlyphPageTreeNode.h into its own header
https://bugs.webkit.org/show_bug.cgi?id=59096
* GNUmakefile.list.am: Add GlyphPage.h to build.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/graphics/GlyphPage.h: Copied from platform/graphics/GlyphPageTreeNode.h. Removed GlyphPageTreeNode class, leaving only GlyphPage.
* platform/graphics/GlyphPageTreeNode.h: Removed GlyphPage class.
2011-04-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Centralize typedef unsigned short Glyph in Glyph.h
https://bugs.webkit.org/show_bug.cgi?id=59087
* GNUmakefile.list.am: Add Glyph.h to build.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/graphics/Glyph.h: Added.
* platform/graphics/GlyphBuffer.h: Include Glyph.h instead of duplicating the Glyph typedef.
* platform/graphics/GlyphMetricsMap.h: Ditto.
* platform/graphics/GlyphPageTreeNode.h: Ditto.
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: toolbar background is blank on Mac Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=59089
* inspector/front-end/inspector.css:
(body.detached.platform-mac-snowleopard:not(.remote) #toolbar):
2011-04-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add support for Go To Line in Resources panel.
https://bugs.webkit.org/show_bug.cgi?id=59077
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.show):
(WebInspector.GoToLineDialog.createShortcut):
(WebInspector.GoToLineDialog.prototype._onKeyDown):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.handleShortcut):
* inspector/front-end/Panel.js:
(WebInspector.Panel):
(WebInspector.Panel.prototype._restoreScrollPositions):
(WebInspector.Panel.prototype.handleShortcut):
(WebInspector.Panel.prototype.registerShortcuts):
(WebInspector.Panel.prototype._showGoToLineDialog):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.handleShortcut):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._registerShortcuts):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/inspector.js:
(WebInspector._registerShortcuts):
(WebInspector.documentKeyDown):
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: persist local resource history between inspector / browser launches.
https://bugs.webkit.org/show_bug.cgi?id=58993
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._restoreRevisions):
2011-04-20 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Metrics pane editing and visual feedback improvements
https://bugs.webkit.org/show_bug.cgi?id=58992
Added visual feedback when hovering over the box model components of the Metrics pane
and handling of the [Page]Up/Down keys when editing the box model values.
* inspector/DOMNodeHighlighter.cpp:
(WebCore::DOMNodeHighlighter::DrawNodeHighlight):
* inspector/DOMNodeHighlighter.h:
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::highlight):
(WebCore::InspectorDOMAgent::highlightDOMNode):
(WebCore::InspectorDOMAgent::highlightFrame):
(WebCore::InspectorDOMAgent::drawNodeHighlight):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSProperty.prototype.setText.callback):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setValue):
(WebInspector.CSSProperty.prototype.setDisabled.callback):
(WebInspector.CSSProperty.prototype.setDisabled):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.startEditingStyle):
(WebInspector.ElementsPanel.prototype.endEditingStyle):
(WebInspector.ElementsPanel.prototype._attributesUpdated):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane):
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.getBoxRectangleElement):
(WebInspector.MetricsSidebarPane.prototype._update.createBoxPartElement):
(WebInspector.MetricsSidebarPane.prototype._update):
(WebInspector.MetricsSidebarPane.prototype.startEditing):
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
(WebInspector.MetricsSidebarPane.prototype.editingEnded):
(WebInspector.MetricsSidebarPane.prototype.editingCancelled):
(WebInspector.MetricsSidebarPane.prototype._applyUserInput.callback):
(WebInspector.MetricsSidebarPane.prototype._applyUserInput):
(WebInspector.MetricsSidebarPane.prototype.editingCommitted):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.alteredFloatNumber):
(WebInspector.StylesSidebarPane.alteredHexNumber):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
* inspector/front-end/inspector.css:
(.metrics .hovered > .label):
(.metrics .position):
(.metrics .margin):
(.metrics .margin.hovered):
(.metrics .border):
(.metrics .border.hovered):
(.metrics .padding):
(.metrics .padding.hovered):
(.metrics .content):
(.metrics .content.hovered):
* inspector/front-end/inspector.js:
(WebInspector.highlightDOMNode):
2011-04-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP report-uri is missing
https://bugs.webkit.org/show_bug.cgi?id=58639
Our implementation of report-uri differs from what's currently in the
spec. I sent the working group an email explaining why. Generally,
we're using normal form encoding instead of JSON and we're sending less
information to a wider set of URLs. Specifically, we send the current
document's URL as well as the directive that was violated. The spec
(currently) tells us to send the raw HTTP headers and the URL that
caused the violation, but both of these pieces of data could contain
information that's sensitive, so we omit them for now.
Test: http/tests/security/contentSecurityPolicy/report-uri.html
* loader/PingLoader.cpp:
(WebCore::PingLoader::reportContentSecurityPolicyViolation):
* loader/PingLoader.h:
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirective::CSPDirective):
(WebCore::CSPDirective::text):
(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::parseReportURI):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
2011-04-21 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
remove unneeded function from graphicscontext3d.cpp (59076)
https://bugs.webkit.org/show_bug.cgi?id=59076
<rdar://problem/9315681>
* platform/graphics/GraphicsContext3D.cpp: removing unused function unpackOneRowOfRGBA8ToRGBA8
2011-04-21 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
REGRESSION: Korean encoding alias KSC5601 does not work
https://bugs.webkit.org/show_bug.cgi?id=59075
<rdar://problem/9303233>
* platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames): Added a
KSC5601 alias for KSC_5601, which effectively makes it windows-949.
2011-04-20 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
layoutTestController can create and destroy shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=59058
Test: fast/dom/shadow/layout-tests-can-access-shadow.html
* WebCore.exp.in: Mac DRT needs to see Element::ensure/removeShadowRoot
2011-04-20 Pratik Solanki <psolanki@apple.com>
Reviewed by Ryosuke Niwa.
Follow on fix for https://bugs.webkit.org/show_bug.cgi?id=58926
Fix assertions in Chromium builds.
* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled): Skia and Wx do not have proper implementations of
BitmapImage::checkForSolidColor() so we shouldn't assert on those platforms.
2011-04-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
[EFL] Add timeline to mediaControlsEfl.css
https://bugs.webkit.org/show_bug.cgi?id=58865
Add timeline to mediaControlsEfl.css in order to show playing time of media
content.
* css/mediaControlsEfl.css:
(audio):
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
2011-04-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel.
Create RIAA class for GraphicsContext::save() and restore()
https://bugs.webkit.org/show_bug.cgi?id=58807
Make a stack-based class that can be used to save and restore
the graphics state. It has conditional behavior to deal with the many cases
where we decide to save/restore based on some runtime condition.
Change RenderBoxModelObject to use it for now; it can be used more widely
once committed.
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextStateSaver::GraphicsContextStateSaver):
(WebCore::GraphicsContextStateSaver::~GraphicsContextStateSaver):
(WebCore::GraphicsContextStateSaver::saveState):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::RenderBoxModelObject::paintBoxShadow):
2011-04-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP frame-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58643
This is a first cut at an implementation of frame-src. There are a
couple things that will need to be improved:
1) I don't think we're handling in-frame navigation properly. This
patch only covers setting the src attribute of the frame, but I
think the intent of the spec is to cover navigation as well.
2) The console message is printed twice, once when we try to load the
frame and again when we attach the frame to the render tree.
I'll file bugs about these issues (blocking
https://bugs.webkit.org/show_bug.cgi?id=53572) once this patch lands.
Tests: http/tests/security/contentSecurityPolicy/frame-src-allowed.html
http/tests/security/contentSecurityPolicy/frame-src-blocked.html
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
2011-04-20 Jia Pu <jpu@apple.com>
Reviewed by Maciej Stachowiak.
[Mac] Correction panel shows up at incorrect location after webpage is scrolled.
https://bugs.webkit.org/show_bug.cgi?id=59052
<rdar://problem/9312513>
Fixed a regression caused by interaction between patch for bug 57353 and patch for bug 55571.
See bug webpage for detail.
* editing/Editor.cpp:
(WebCore::Editor::selectionStartHasMarkerFor):
* editing/SpellingCorrectionController.cpp:
(WebCore::SpellingCorrectionController::windowRectForRange):
2011-04-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP policy violations should log to the console
https://bugs.webkit.org/show_bug.cgi?id=58646
We now log policy violations to the JavaScript console to help
developers debug what's going on with their Content-Security-Policy.
Tests: http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html
http/tests/security/contentSecurityPolicy/javascript-url-allowed.html
http/tests/security/contentSecurityPolicy/javascript-url-blocked.html
http/tests/security/contentSecurityPolicy/object-src-none-allowed.html
http/tests/security/contentSecurityPolicy/object-src-none-blocked.html
http/tests/security/contentSecurityPolicy/script-src-self-blocked-01.html
http/tests/security/contentSecurityPolicy/script-src-self-blocked-02.html
http/tests/security/contentSecurityPolicy/script-src-self-blocked-03.html
* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
(WebCore::ContentSecurityPolicy::create):
2011-04-20 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9095366> With a non-1 page scale, scrolling to reveal selection fails
https://bugs.webkit.org/show_bug.cgi?id=59046
Test: fast/transforms/selection-bounds-in-transformed-view.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer): If the repaint container is the RenderView, and
it has a composited layer that paints straight to the window, then translate from view coordinates
to window coordinates here.
* rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer): Do not apply our transform if we are the painting root.
(WebCore::RenderView::computeRectForRepaint): Ditto. Applying the transform here was compensating
for not applying it in RenderObject::repaintUsingContainer(), but for purposes other than repainting,
such as computing selection bounds, this function was returning the wrong results.
2011-04-20 Dan Bernstein <mitz@apple.com>
Reviewed by Eric Carlson.
<rdar://problem/9304956> media/broken-video.html crashes
* platform/graphics/MediaPlayer.cpp:
(WebCore::nextMediaEngine): Fixed an off-by-one error.
2011-04-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Split out isIteratorTarget from bidiNext and bidiFirst
https://bugs.webkit.org/show_bug.cgi?id=59033
This is the first (tiny) step of many. When I tried to
make larger changes to this function I broke stuff, so
doing this in tiny pieces so we know it's right.
* rendering/InlineIterator.h:
(WebCore::isIteratorTarget):
(WebCore::bidiNext):
(WebCore::bidiFirstSkippingInlines):
(WebCore::bidiFirstNotSkippingInlines):
2011-04-20 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Kenneth Russell.
Check for null m_context in WebGLLayerChromium and add resetting platform layer's context in the destructor of GraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=59045
Lose context extension test might not catch this bug, more reliable
way is forcing the crash of the GPU process, which is done by Chromium
browser tests.
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::setContext):
* platform/graphics/chromium/WebGLLayerChromium.h:
2011-04-20 Jia Pu <jpu@apple.com>
Reviewed by Maciej Stachowiak.
[Mac]Regression: extending word that is already marked misspelled doesn't remove misspelling underline.
https://bugs.webkit.org/show_bug.cgi?id=59032
<rdar://problem/9312444>
This fixes a regression introduced in recent refactoring work in Editor. See bug webpage for detail.
manual test: Source/WebCore/manual-tests/autocorrection/remove-misspelling-marker-after-appending-letter.html
* editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):
* manual-tests/autocorrection/remove-misspelling-marker-after-appending-letter.html: Added.
2011-04-20 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
CrashTracer: 301 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityRenderObject::visiblePositionForPoint const + 297
https://bugs.webkit.org/show_bug.cgi?id=57405
The offending line in this crash was a null pointer access in
m_renderer->document()->topDocument()->renderer()->view()->frameView();
It seems likely that one of those calls was invalid. I could not reproduce and there was no
information on reproducible steps, hence the absence of a layout test.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::topRenderer):
(WebCore::AccessibilityRenderObject::topDocument):
(WebCore::AccessibilityRenderObject::topDocumentFrameView):
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
* accessibility/AccessibilityRenderObject.h:
2011-04-20 Andy Estes <aestes@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION (WK2): Animated GIF stops when navigating forward, back
https://bugs.webkit.org/show_bug.cgi?id=59042
When loading the page from the b/f cache,
document()->view()->isOffscreen() returns true in
RenderObject::willRenderImage(), so BitmapImage::startAnimation()
returns without actually kicking off the animation.
In WebKit1, the ScrollView is a platform widget, so
ScrollView::isOffscreen() calls [NSWindow isVisible]. In WebKit2, the
ScrollView isn't a platform widget so it asks the WebCore Widget
whether or not it is visible. It always returns false since
setParentVisible(false) was called on the old ScrollView before
navigating to a new page, but setParentVisible(true) is never called
when restoring it from the back/forward cache. This is probably a
long-standing bug.
Fix this by calling setParentVisible(true) when a cached main frame is
being restored.
Test: fast/images/animated-gif-restored-from-bfcache.html
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore): If the cached frame is the main
frame, call setParentVisible(true) on the frame's view.
2011-04-20 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKit2: Can't scroll page after printing on Yahoo.com and other sites
<rdar://problem/9233291>
https://bugs.webkit.org/show_bug.cgi?id=59049
* page/Frame.cpp:
(WebCore::Frame::setPrinting): Match Mac WebKit1 code when ending printing,
and call forceLayout() instead of forceLayoutForPagination().
2011-04-20 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Reduce size of GraphicsContext3D's compiled code
https://bugs.webkit.org/show_bug.cgi?id=59029
Changed format conversion operations to work line-by-line instead
of pixel-by-pixel, and passed them as function pointers rather
than template parameters. Simplified computation of source
increment, since elements per row is now all that is needed.
These changes reduce the size of GraphicsContext3D.o in release
mode on Linux from 299 KB to 53 KB.
No new tests. Existing layout tests cover these format conversions
well, and caught one typo in the restructuring. Also ran WebGL
conformance suite and other demos.
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::doUnpackingAndPacking):
(WebCore::computeSourceElementsPerRow):
(WebCore::doPacking):
(WebCore::doFloatingPointPacking):
(WebCore::GraphicsContext3D::packPixels):
2011-04-20 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element.
https://bugs.webkit.org/show_bug.cgi?id=59037
Test: fast/events/simulated-click-disabled.html
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick): Added check for disabled element.
2011-04-20 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Split bidiFirst into two functions
https://bugs.webkit.org/show_bug.cgi?id=59025
I don't have a full understanding of the skipInlines case yet
(hence it's not as pretty as the non-skipping case), but
this is clearly a win, as both functions are much simpler
than their combined version.
Both of these functions still have bad names. However the
bidiNext/bidiFirst names date all the way back to revision 1
of the WebKit repository. :) So I don't feel too bad keeping
them for the moment.
* rendering/InlineIterator.h:
(WebCore::bidiNext):
(WebCore::bidiFirstSkippingInlines):
(WebCore::bidiFirstNotSkippingInlines):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
2011-04-20 Jia Pu <jpu@apple.com>
Reviewed by Adele Peterson.
[Mac] Like autocorrection, other types of substitution need to respect undo.
https://bugs.webkit.org/show_bug.cgi?id=59009
<rdar://problem/8601537>
Similar to autocorrection, we use SpellingCorrectionCommand to carry out other types of text substitution, so that
if user undoes the substitution, it will not be applied again. For CreateLinkCommand, we add marker when it's undone
so that we won't automatically add link again.
* editing/CreateLinkCommand.h:
(WebCore::CreateLinkCommand::isCreateLinkCommand):
* editing/EditCommand.cpp:
(WebCore::EditCommand::isCreateLinkCommand):
* editing/EditCommand.h:
* editing/Editor.cpp:
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
* editing/SpellingCorrectionController.cpp:
(WebCore::SpellingCorrectionController::respondToAppliedEditing):
(WebCore::SpellingCorrectionController::respondToUnappliedEditing):
* editing/SpellingCorrectionController.h:
(WebCore::SpellingCorrectionController::UNLESS_ENABLED):
2011-04-20 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
[chromium] Move Chromium media controls into own root element.
https://bugs.webkit.org/show_bug.cgi?id=59018
No new tests as there is no functional change
* WebCore.gypi:
* css/mediaControlsChromium.css:
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
* html/shadow/MediaControlRootElementChromium.cpp: Added.
Clone of html/shadow/MediaControlRootElement.cpp with all unused code removed.
* html/shadow/MediaControlRootElementChromium.h: Added.
2011-04-20 Charlie Lee <chocobo@chromium.org>
Reviewed by Dirk Schulze.
LEFilter change doesn't compile on ARM neon targets
https://bugs.webkit.org/show_bug.cgi?id=58671
Build fix for Chromium ARM/NEON platform. Added platform/graphics/filters/arm directory to build system.
* WebCore.gyp/WebCore.gyp:
2011-04-20 Xiaomei Ji <xji@chromium.org>
Reviewed by Ryosuke Niwa.
Continue (3rd) experiment with moving caret by word in visual order.
https://bugs.webkit.org/show_bug.cgi?id=58294
This patch along with r82588 and r83483 implements moving caret by
word in visual order.
The overall algorithm is:
1. First get the InlineBox and offset of the pass-in VisiblePosition.
2. Based on the position (left boundary, middle, right boundary) of the offset and the
direction of the movement, look for visually adjacent word breaks.
2.1 If the offset is the minimum offset of the box,
return the rightmost word boundary in previous boxes if moving left.
return the leftmost word boundary in box and next boxes if moving right.
2.2 Similar for the case when offset is at the maximum offset of the box.
2.3 When offset is inside the box (not at boundaries), first find the previousWordPosition
or nextWordPosition based on the directionality of the box. If this word break position
is also inside the same box, return it. Otherwise (the nextWordPosition or
previousWordPosition is not in the same box or is at the box boundary), collect all the
word breaks in the box and search for the one closest to the input "offset" based on
box directionality, block directionality, and movement direction. Continue search in
adjacent boxes if needed.
Notes:
1. Word boundaries are collected one box at a time. Only when a boundary that is closest to
the input position (in the moving direction) is not available in current box, word
boundaries in adjacent box will be collected. So, there is no need to save InlineBox in
word boundaries. Instead, the word boundaries are saved as a pair
(VisiblePosition, offset) to avoid recomputing VisiblePosition.
2. We only collect boundaries of the right kind (i.e. left boundary of a word in LTR block
and right boundary of a word in RTL block). And word boundaries are collected using
previousWordPosition() and nextWordPosition(). So when box directionality is the same as
block directionality, word boundaries are collected from right to left visually in a LTR
box, and word boundaries are collected from left to right visually in a RTL box. It is
the other way around when box directionality is different from block directionality.
3. To find the right kinds of word boundaries, we must move back and forth between words
in some situations. For example, if we're moving to the right in a LTR box in LTR block,
we cannot simply return nextWordPosition() because it would return the right boundary
of a word. Instead, we return nextWordPosition()'s nextWordPosition()'s previousWordPosition().
4. When collecting word breaks inside a box, it first computes a start position, then
collect the right kind of word breaks until it reaches the end of (or beyond) the box.
In the meanwhile, it might need special handling on the rightmost or leftmost position
based on the directionality of the box and block. These computations do not consider the
box's bidi level.
* editing/visible_units.cpp:
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
(WebCore::collectWordBreaksInBox):
(WebCore::previousWordBoundaryInBox):
(WebCore::nextWordBoundaryInBox):
(WebCore::visuallyLastWordBoundaryInBox):
(WebCore::leftWordBoundary):
(WebCore::rightWordBoundary):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):
2011-04-20 Cris Neckar <cdn@chromium.org>
Reviewed by Dirk Schulze.
Return early when the paint rect and the source rect do not overlap as no bytes need to be copied.
https://bugs.webkit.org/show_bug.cgi?id=57885
Test: svg/filters/svg-transform-blur-crash.xhtml
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::copyImageBytes):
2011-04-20 Jian Li <jianli@chromium.org>
Reviewed by Kenneth Russell.
Support DataView in workers
https://bugs.webkit.org/show_bug.cgi?id=59014
Test: fast/canvas/webgl/worker-data-view-test.html
* workers/WorkerContext.idl: Expose DataView constructor.
2011-04-20 Chris Marrin <cmarrin@apple.com>
Reviewed by Adam Roben.
REGRESSION (WebKit2): CSS animations on pages that use accelerated compositing stop after switching tabs
https://bugs.webkit.org/show_bug.cgi?id=57868
Running CACFAnimations aren't remembered when layer tree is unparented and
then reparented. Added a new ensureAnimationsSubmitted function to
PlatformCALayer to traverse the tree and resubmit animations, setting the
beginTime to the original start time of the animation. This is called in WK2
when layer tree is newly parented.
I also consolidated currentTimeToMediaTime into PlatformCALayer so it can be shared
between PlatformCALayer and GraphicsLayerCA.
* platform/graphics/ca/GraphicsLayerCA.cpp:
* platform/graphics/ca/PlatformCAAnimation.h:
Remember actual animation start time in CACFAnimation beginTime property
* platform/graphics/ca/PlatformCALayer.h:
New ensureAnimationsSubmitted function which traverses layers and resubmits all animations
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
2011-04-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Adopt QTKit API for listing and deleting file in its media cache.
<rdar://problem/9130029>
https://bugs.webkit.org/show_bug.cgi?id=58795
Not possible to test automatically, verified manually.
* WebCore.exp.in: Export new media download cache functions.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Register cache management functions.
(WebCore::MediaPlayerPrivateQTKit::getSitesInMediaCache): New, return cache origins.
(WebCore::MediaPlayerPrivateQTKit::clearMediaCache): New, empty the media cache.
(WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForSite): New, delete files in the media
cache for one origin.
* platform/mac/WebCoreSystemInterface.h: Add new WKSI functions.
* platform/mac/WebCoreSystemInterface.mm: Ditto.
2011-04-20 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Fraser.
SVG feDropShadow implementation of SVG Filters 1.2
https://bugs.webkit.org/show_bug.cgi?id=52513
Support different radii for horizontal and vertical blurring in ShadowBlur. This is a preperation for feDropShadow.
feDropShadow is a new shorthand filter effect for the up-comming Filter 1.0 specification and will use ShadowBlur.
feGaussianBlur might make use of ShadowBlur as well later (on SourceAlpha input).
Added ShadowBlur to remaining platforms.
The changes can't be tested before the changes in feGaussianBlur or feDropShadow. Current behavior is not affected.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.pro:
* platform/graphics/FloatSize.h:
(WebCore::FloatSize::scale):
* platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::ScratchBuffer):
(WebCore::ScratchBuffer::setLastShadowValues):
(WebCore::ScratchBuffer::setLastInsetShadowValues):
(WebCore::ScratchBuffer::matchesLastShadow):
(WebCore::ScratchBuffer::matchesLastInsetShadow):
(WebCore::ScratchBuffer::clearScratchBuffer):
(WebCore::ShadowBlur::ShadowBlur):
(WebCore::calculateLobes):
(WebCore::ShadowBlur::blurLayerImage):
(WebCore::ShadowBlur::adjustBlurRadius):
(WebCore::ShadowBlur::calculateLayerBoundingRect):
(WebCore::computeSliceSizesFromRadii):
(WebCore::ShadowBlur::templateSize):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::drawLayerPieces):
* platform/graphics/ShadowBlur.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
2011-04-19 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 52963 - Enable O(1) access to root from any node in shadow DOM subtree
https://bugs.webkit.org/show_bug.cgi?id=52963
.) Change base class of ShadowRoot from DocumentFragment to TreeScope.
.) Re-enable tree scope handling in Node (had ASSERT_NOT_REACHED, etc.).
.) Merged setTreeScope() with setTreeScopeRecursively()
.) Call setTreeScopeRecursively in DOM manipulation functions where applicable.
.) Adapt JavaScript Node wrappers (temporary code - see https://bugs.webkit.org/show_bug.cgi?id=58704).
No new tests. (refactoring)
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::parserAddChild):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setDocType):
* dom/Element.h:
* dom/Node.cpp:
(WebCore::Node::treeScope):
(WebCore::Node::setTreeScopeRecursively):
* dom/Node.h:
(WebCore::Node::document):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::nodeType):
(WebCore::ShadowRoot::cloneNode):
(WebCore::ShadowRoot::childTypeAllowed):
* dom/ShadowRoot.h:
(WebCore::toShadowRoot):
* dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::setParentTreeScope):
* dom/TreeScope.h:
* rendering/RenderSlider.cpp:
2011-04-20 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Update front-end files list in WebCore.vcproj
https://bugs.webkit.org/show_bug.cgi?id=58896
* WebCore.vcproj/WebCore.vcproj:
2011-04-20 Dimitri Glazkov <dglazkov@chromium.org>
Qt build fix after r84380.
* css/CSSPrimitiveValueMappings.h: Moved EBorderCollapse-related casts from under ENABLE(SVG) guard.
2011-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Build libWebCore with the gtk sources too
https://bugs.webkit.org/show_bug.cgi?id=58968
In some cases webcore files are compiled twice, so it improves the
build time.
* GNUmakefile.am: Add webcore gtk sources to libWebCore sources.
2011-04-20 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Allow casting between CSSPrimitiveValue and EBorderCollapse to remove special-case logic from CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=58964
No new tests as no new functionality added.
* css/CSSPrimitiveValueMappings.h:
Support casting to/from EBorderCollapse.
* css/CSSStyleSelector.cpp:
Use new casting ability to simplify code.
* rendering/style/RenderStyle.h:
Use EBorderCollapse instead of a bool for representing border collapse member variable.
* rendering/style/RenderStyleConstants.h:
Added EBorderCollapse enum.
2011-04-19 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Move and rename GLES2Canvas.
https://bugs.webkit.org/show_bug.cgi?id=58927
Move GLES2Canvas to platform/graphcs/gpu, where all the other
gpu-related files live, and rename it to GraphicsContextGPU to better
reflect its purpose.
Covered by existing tests.
* WebCore.gypi:
* platform/graphics/chromium/GLES2Canvas.cpp:
* platform/graphics/chromium/GLES2Canvas.h:
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/skia/ImageBufferSkia.cpp:
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::drawBitmapGLES2):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
* platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::gpuCanvas):
2011-04-20 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] Clean the style of our cookie methods
https://bugs.webkit.org/show_bug.cgi?id=58987
Got rid of the variables named "u" in favor just converting the url when needed.
* platform/qt/CookieJarQt.cpp:
(WebCore::setCookies): The variable p was unused.
The ::toAscii() depends on the default codec, use toLatin1() instead.
(WebCore::cookies): foreach() should use const reference.
(WebCore::cookieRequestHeaderFieldValue):
2011-04-19 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
ScriptController.h is included in too many places
https://bugs.webkit.org/show_bug.cgi?id=58963
Remove ScriptController.h #includes from a bunch of .cpp files where it
doesn't appear to be necessary.
* bindings/js/JSCustomPositionCallback.cpp:
* bindings/js/JSCustomPositionErrorCallback.cpp:
* bindings/js/JSCustomVoidCallback.cpp:
* bindings/js/JSCustomXPathNSResolver.cpp:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowShell.cpp:
* bindings/js/JSDocumentCustom.cpp:
* bindings/js/ScriptDebugServer.cpp:
* bindings/v8/NPV8Object.cpp:
* bindings/v8/ScriptCachedFrameData.cpp:
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8IsolatedContext.cpp:
* bindings/v8/V8Proxy.cpp:
* bindings/v8/custom/V8LocationCustom.cpp:
* dom/Node.cpp:
* dom/ScriptElement.cpp:
* dom/XMLDocumentParser.cpp:
* dom/XMLDocumentParserQt.cpp:
* html/HTMLEmbedElement.cpp:
* html/HTMLObjectElement.cpp:
* html/HTMLPlugInElement.cpp:
* html/parser/HTMLConstructionSite.cpp:
* html/parser/HTMLTreeBuilder.cpp:
* inspector/InspectorProfilerAgent.cpp:
* loader/icon/IconDatabase.cpp:
* page/Chrome.cpp:
* page/Navigator.cpp:
* page/Page.cpp:
* plugins/PluginView.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/qt/PluginViewQt.cpp:
* plugins/symbian/PluginViewSymbian.cpp:
* plugins/win/PluginViewWin.cpp:
* svg/SVGDocumentExtensions.cpp:
* xml/XMLTreeViewer.cpp:
2011-04-20 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add Save As to the Resources panel context menu.
https://bugs.webkit.org/show_bug.cgi?id=58983
* English.lproj/localizedStrings.js:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype.onattach):
(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent.save):
(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.save):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
2011-04-20 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Cleanup includepath adjustment for generated files
https://bugs.webkit.org/show_bug.cgi?id=58869
Build cleanup, no new tests.
* WebCore.pri: Add the directory of generated files to the include path
with absolute path to make it valid in the final build step. Remove
unnecessary logic.
2011-04-20 Mariusz Grzegorczyk <mariusz.g@samsung.com>
Reviewed by Andreas Kling.
[EFL] Initializing m_window member field in PluginView.cpp for efl port
https://bugs.webkit.org/show_bug.cgi?id=58311
No new tests needed: only initializing class member.
* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
2011-04-20 Pavel Feldman <pfeldman@google.com>
Not reviewed: fix Leopard compile.
* inspector/InspectorFrontendClient.h:
* inspector/InspectorFrontendClientLocal.h:
(WebCore::InspectorFrontendClientLocal::saveAs):
2011-04-20 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add saveAs into the InspectorFrontendHost binding.
https://bugs.webkit.org/show_bug.cgi?id=58979
* English.lproj/localizedStrings.js:
* inspector/InspectorFrontendClient.h:
(WebCore::InspectorFrontendClient::saveAs):
(WebCore::InspectorFrontendClient::saveSessionSetting):
(WebCore::InspectorFrontendClient::loadSessionSetting):
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::saveAs):
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.saveAs.fr.onload):
(.WebInspector.InspectorFrontendHostStub.prototype.saveAs):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._contextMenu):
(WebInspector.NetworkPanel.prototype._copyAll):
(WebInspector.NetworkPanel.prototype._copyResource):
(WebInspector.NetworkPanel.prototype._exportAll):
(WebInspector.NetworkPanel.prototype._exportResource):
* inspector/front-end/Settings.js:
* inspector/front-end/utilities.js:
():
2011-04-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Tony Gentilcore.
Error event in <script> element shouldn't bubble
https://bugs.webkit.org/show_bug.cgi?id=51040
Test: svg/dom/SVGScriptElement/script-onerror-bubbling.svg
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::dispatchErrorEvent): the method now has same implementation for all script
elements, script load error event doesn' bubble.
* dom/ScriptElement.h:
* html/HTMLScriptElement.cpp:
* html/HTMLScriptElement.h:
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::parseMappedAttribute): SVG script element now supports onerror
hanlder which behaves the same way as onerror in HTML script element: it's invoked when
script loading fails and the event doesn't bubble.
* svg/SVGScriptElement.h:
2011-04-20 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: minor protocol cleanups (refined types).
https://bugs.webkit.org/show_bug.cgi?id=58970
* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:
2011-04-20 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Eric Seidel.
Leaks beneath RenderSVGShadowTreeRootContainer::updateFromElement seen on SnowLeopard Intel Leaks
https://bugs.webkit.org/show_bug.cgi?id=56672
~RenderSVGShadowTreeRootContainer() cleared shadow host only if
the shadow root is attached. This is wrong because it will
leak shadow root when the root is not attached. For example, it
leaks shadow root of <use> element which is pending on resource.
This patch is clearing shadow host if m_shadowRoot is valid to
prevent leaking.
Fixing leaking, no new tests.
* rendering/svg/RenderSVGShadowTreeRootContainer.cpp:
(WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
2011-04-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
Reproducible crash two-finger zooming at multiple sites in WebCore::RenderLayer::isTransparent
https://bugs.webkit.org/show_bug.cgi?id=58868
I could not figure out how to make a test.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer): Check for existence of a
parent before calling a method on it.
2011-04-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Daniel Bates.
[EFL] Add current time to media control panel.
https://bugs.webkit.org/show_bug.cgi?id=58866
Implement paintMediaCurrentTime() to show playing time of media content.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::formatMediaControlsCurrentTime):
(WebCore::RenderThemeEfl::paintMediaCurrentTime):
* platform/efl/RenderThemeEfl.h:
2011-04-19 Jungshik Shin <jshin@chromium.org>
Reviewed by Adam Barth
Update the list of Unicode blocks to treat as complex scripts
per Unicode 6.0. Also, make [U+02E5..U+02E9] (IPA tone marks)
go through the complex script code path.
Test: fast/text/ipa-tone-letters.html
http://bugs.webkit.org/show_bug.cgi?id=39799
* platform/graphics/Font.cpp:
(WebCore::Font::codePath):
2011-04-19 Pratik Solanki <psolanki@apple.com>
Reviewed by Simon Fraser.
Follow on fix for https://bugs.webkit.org/show_bug.cgi?id=58926
Move the assert from Image::drawPattern() to Image::drawTiled() so we don't hit it when
trying to paint GeneratedImages.
* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):
2011-04-19 Simon Fraser <simon.fraser@apple.com>
Fix 32-bit builds.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::determineBackgroundBleedAvoidance):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
2011-04-19 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kent Tamura.
[Chromium]UI polishes and tweaks to Autofill dropdown menu.
https://bugs.webkit.org/show_bug.cgi?id=58505
http://code.google.com/p/chromium/issues/detail?id=51077
No new tests. Because this is autofill looking problem in Chromium.
Add m_menuType as PopupMenuStyle to change popup style change.
Put kLinePaddingHeight at the top and bottom of each line if m_menuType is AutofillPopup.
Change separator color to #dcdcdc and remove sparatorPadding at the edge if m_menuType is AutofillPopup.
Change the line height of separator as only the piece if m_menuType is AutofillPopup.
Change the label font size 0.9 time smaller than regular font size if m_menuType is AutofillPopup.
* platform/PopupMenuStyle.h: Add enum PopupMenuType;
(WebCore::PopupMenuStyle::PopupMenuStyle): Add m_menuType.
(WebCore::PopupMenuStyle::menuType): Add to change the style according to the return value.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::paintRow):Change the separator color to #dcdcdc.
Change the edge padding according to menuStyle().
(WebCore::PopupListBox::getRowHeight): Add kLineHeightMargin*2 for each line height.
2011-04-19 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
background color of elements with border-radius shows around outer edge of border at corners
https://bugs.webkit.org/show_bug.cgi?id=21819
When drawing a background followed by a border with the same rounded
clip, some border color leaks out because of antialiasing.
Fix this by using two different strategies depending on the colors.
If the border is opaque on all sides, we can inset the background by
a device pixel. If not, then we have to draw the unclipped background
and border into a transparency layer, and then clip that.
A futher possible solution is mentioned in a comment in
determineBackgroundBleedAvoidance() but not yet implemented.
Also don't try to paint shadows with zero offset, spread and blur.
Test: fast/backgrounds/background-leakage.html,
fast/backgrounds/background-leakage-transforms.html
* rendering/RenderBoxModelObject.h:
Add a BackgroundBleedAvoidance enum with a value for each
strategy.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Pass BackgroundBleedAvoidance, bail early if the border rect is empty.
If using the transparency layer solution, don't bother to clip
to the rounded rect for the background. If the strategy is to
shrink the background, do that.
(WebCore::BorderEdge::BorderEdge):
(WebCore::BorderEdge::obscuresBackgroundEdge):
Helper method to determine if this border side will totally
obscured by the border edge, allowing us to inset it.
(WebCore::RenderBoxModelObject::paintOneBorderSide):
Pass BackgroundBleedAvoidance through.
(WebCore::RenderBoxModelObject::paintBorderSides):
Ditto.
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
Ditto.
(WebCore::RenderBoxModelObject::paintBorder):
Fill BorderEdges using getBorderEdgeInfo now.
Don't clip to the rounded border if we are using the
transparency layer solution.
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
Pass bleedAvoidance through, and use it for double borders.
(WebCore::RenderBoxModelObject::getBorderEdgeInfo):
Helper to fill in the BorderEdge array.
(WebCore::RenderBoxModelObject::borderObscuresBackgroundEdge):
Used to determine if we can use the background shrinkage solution.
(WebCore::RenderBoxModelObject::paintBoxShadow):
Don't paint shadows that should not be visible.
* rendering/RenderBox.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxFillLayers):
Pass BackgroundBleedNone for the root box.
(WebCore::RenderBox::determineBackgroundBleedAvoidance):
Determine which bleed strategy we can use.
(WebCore::RenderBox::paintBoxDecorationsWithSize):
Based on the bleedAvoidance, make a transparency layer
which will be clipped to the rounded border outside edge,
and pass bleedAvoidance to the background and border-painting
methods.
(WebCore::RenderBox::paintMaskImages):
Use BackgroundBleedNone.
(WebCore::RenderBox::paintFillLayers):
(WebCore::RenderBox::paintFillLayer):
Pass bleedAvoidance through.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
Pass BackgroundBleedNone. At some point we may want to do the right
thing for split inlines.
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
Pass BackgroundBleedNone.
2011-04-19 Yuta Kitamura <yutak@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket: Add assertion for SocketStreamError::failingURL.
https://bugs.webkit.org/show_bug.cgi?id=58765
No new tests, because an existing test http/tests/inspector/console-websocket-error.html should cover this.
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didFail): If error.failingURL() is provided, it must be the same as
m_handshake.url(). failingURL may be null if SocketStreamHandle has created a SocketStreamError
using zero- or one-argument constructor (which is old version but some ports are still using it).
In that case, m_handshake.url() is passed to addMessage().
2011-04-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dimitri Glazkov.
Media controls status display should not be hidden for live streams
https://bugs.webkit.org/show_bug.cgi?id=58952
Tested manually because we don't have any live streams to test in DRT.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlStatusDisplayElement::update): Set the status to "Loading" only until
there is something to display (readyState exceeds HAVE_METADATA).
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::loadedMetadata): Don't hide the status display for
live streams.
2011-04-19 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=45425
HTMLLinkElement.disabled does not forward value to the Stylesheet's disabled attribute on setting
Test: fast/html/htmllink-disable.html
Test: fast/dom/HTMLLinkElement/disabled-attribute.html
Match the HTML5 specification by forwarding the 'disabled' attribute to our stylesheet.
Based on previous work by Bijan Amirzada <bijana@codeaurora.org>.
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::disabled): Return our stylesheet's 'disabled' value or
false if we don't have a stylesheet.
(WebCore::HTMLLinkElement::setDisabled): Set our stylesheet's 'disabled' value or
ignore the call if we don't have a stylesheet.
* html/HTMLLinkElement.h:
* html/HTMLLinkElement.idl: Remove 'Reflect' as it is not a reflected attribute anymore in HTML5.
This matches the way FF4, Opera and IE9 handle the attribute.
2011-04-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Remove calls to deprecatedOffset and deprecatedNode in TypingCommand
https://bugs.webkit.org/show_bug.cgi?id=58569
Removed all calls to deprecatedOffset and deprecatedNode.
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
2011-04-19 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Initialize depth mask to known value before getBooleanv call
https://bugs.webkit.org/show_bug.cgi?id=58948
This trips an assert in the GPU command buffer client code if the
pointed-to value is not initialized to 0 or -1.
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clearFramebuffer):
2011-04-19 Pratik Solanki <psolanki@apple.com>
Reviewed by Simon Fraser.
BitmapImage::destroyMetadataAndNotify should clear m_checkedForSolidColor
https://bugs.webkit.org/show_bug.cgi?id=58926
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyMetadataAndNotify): Set m_checkedForSolidColor to false.
* platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::assertNotSolidColor):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern): Add assert to make sure this is not called for a 1x1 image.
2011-04-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
REGRESSION(r83967): Crash in selectionExtentRespectingEditingBoundary
https://bugs.webkit.org/show_bug.cgi?id=58910
The crash was caused by selectionExtentRespectingEditingBoundary's incorrectly assuming that
targetNode always have renderer when there selection has an editable root and the target node
is outside of the editable root.
Fixed the bug by adding an early exit when the target node is null.
No new tests are added since we don't have a reduction for this crash.
* page/EventHandler.cpp:
(WebCore::selectionExtentRespectingEditingBoundary):
2011-04-19 Geoffrey Garen <ggaren@apple.com>
Try to fix v8 build.
* bindings/scripts/CodeGeneratorV8.pm: This is a pretty bad system.
2011-04-19 Enrica Casucci <enrica@apple.com>
Reviewed by Ryosuke Niwa.
REGRESSION(r55762): Highlight color can't be copied in gmail.
https://bugs.webkit.org/show_bug.cgi?id=58925
<rdar://problem/9253057>
Test: editing/pasteboard/copy-text-with-backgroundcolor.html
The changes of r55762 uncovered the underlying issue here. The markup fragment
placed in the pasteboard does not contain the background color style.
This occurs only if the selection is limited to a single text node, whereas if the
selection spans across multiple nodes, the style is preserved correctly.
The fix consists in changing the logic that decides whether we should include the wrapping
node in the markup. That logic is based on the code in highestAncestorToWrapMarkup which relies
on isElementPresentational to choose candidates to be the wrapping node.
I've extended it to accept nodes that have non fully transparent background colors.
* editing/Editor.cpp:
(WebCore::Editor::hasTransparentBackgroundColor): Now is a static method of the class.
* editing/Editor.h:
* editing/markup.cpp:
(WebCore::isElementPresentational): Modified to use hasTransparentBackgroundColor.
2011-04-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: NodeLists
https://bugs.webkit.org/show_bug.cgi?id=58939
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::markChildren): No need to mark node lists, because
now they use the opaque roots system to decide their lifetimes.
* bindings/js/JSNamedNodeMapCustom.cpp: Removed stray newline.
* bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
(WebCore::JSNodeListOwner::finalize):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::toJS): Use the opaque roots system to avoid relying on
markDOMObjectWrapper.
* dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeList::isDynamicNodeList):
* dom/DynamicNodeList.h:
(WebCore::DynamicNodeList::rootNode): Added the ability to get the node
backing a NodeList, for use in the opaque roots system.
* dom/Node.cpp:
* dom/Node.h:
* dom/NodeList.h:
(WebCore::NodeList::isDynamicNodeList): Ditto. Removed cruft related
to the old way of marking NodeLists.
* dom/NodeList.idl: We need a custom toJS so we can specify a custom
WeakHandleOwner at construction time.
2011-04-19 Antoine Labour <piman@chromium.org>
Reviewed by James Robinson.
For invisible iframes, propagate compositing to parent instead of setting self
as root.
https://bugs.webkit.org/show_bug.cgi?id=58414
Tests: compositing/iframes/invisible-iframe.html
compositing/iframes/invisible-nested-iframe-hide.html
compositing/iframes/invisible-nested-iframe-show.html
compositing/iframes/invisible-nested-iframe.html
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
Propagate compositing to parent even if frame owner has no renderer.
2011-04-19 Dan Bernstein <mitz@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/9271848> Crash when the document element is removed
Test: fast/events/overflow-viewport-renderer-deleted.html
* page/FrameView.cpp:
(WebCore::FrameView::calculateScrollbarModesForLayout): Reset m_viewportRenderer, in case this
function takes a code path that doesn’t call applyOverflowToViewport().
(WebCore::FrameView::layout): Whitespace change.
2011-04-19 Beth Dakin <bdakin@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=57898
REGRESSION (r82185): Scroll position not restored on navigation back to a page in
the page cache
-and corresponding-
<rdar://problem/9226652>
Setting the contentsSize of a ScrollView to (0, 0) necessarily causes the scroll
position to be lost. (The scroll position is computed based on the
visibleContentSize.) This patch provides a mechanism to cache the current scroll
position, and then the HistoryController accesses only the cached position rather
than calling scrollPosition() which does a computation based on the
visibleContentSize.
* loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
* page/FrameView.cpp:
(WebCore::FrameView::resetScrollbarsAndClearContentsSize):
* platform/ScrollView.h:
(WebCore::ScrollView::cacheCurrentScrollPosition):
(WebCore::ScrollView::cachedScrollPosition):
2011-04-19 Renata Hodovan <reni@webkit.org>
Reviewed by Eric Seidel.
Move the alignment related macros in Vector.h to new Alignment.h.
https://bugs.webkit.org/show_bug.cgi?id=56000
Adding the new file to the forwarding headers of WebCore.
* ForwardingHeaders/wtf/Alignment.h: Added.
2011-04-19 Oliver Hunt <oliver@apple.com>
Reviewed by Andreas Kling.
[Qt] QtInstance method cache ownership rules are unclear
https://bugs.webkit.org/show_bug.cgi?id=58820
Make the QtInstance method cache use WriteBarrier, and handle
ownership properly.
* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
(JSC::Bindings::QtClass::fieldNamed):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::~QtInstance):
(JSC::Bindings::QtInstance::removeCachedMethod):
(JSC::Bindings::QtInstance::newRuntimeObject):
(JSC::Bindings::QtInstance::markAggregate):
* bridge/qt/qt_instance.h:
2011-04-19 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/57867> Re-order enum ResourceLoadPriority to make Unresolved value less important
Reviewed by Antti Koivisto.
* platform/network/ResourceLoadPriority.h:
(enum ResourceLoadPriority): Moved Unresolved enum to the top of
the list and set to -1 to emphasize the fact that this is an
unresolved priority (rather than one higher than the highest
priority). Removed whitespace from the end of all enum lines.
2011-04-19 Simon Fraser <simon.fraser@apple.com>
Reviewed by David Hyatt.
Background radius is wrong for split inline
https://bugs.webkit.org/show_bug.cgi?id=58843
When computing the radii for a segment of a split inline, we have to
constrain those radii for the current segment, while still drawing
using the entire logical width.
Tests: fast/backgrounds/border-radius-split-background-image.html
fast/backgrounds/border-radius-split-background.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintFillLayer):
Pass height and width for this box only to paintFillLayer()
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayer):
Pass 0 for unused inlineBox height and width.
* rendering/RenderBoxModelObject.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
When computing the rounded background rect, we have to take the size of
this segment of the inline box into account for radius constraining.
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Call getBackgroundRoundedRect() in two places.
2011-04-19 Simon Fraser <simon.fraser@apple.com>
Build fix. For some reason RenderBoxModelObject.cpp
was missing from my last commit.
* rendering/RenderBoxModelObject.cpp:
(WebCore::borderWillArcInnerEdge):
(WebCore::edgeFlagForSide):
(WebCore::includesEdge):
(WebCore::BorderEdge::BorderEdge):
(WebCore::BorderEdge::hasVisibleColorAndStyle):
(WebCore::BorderEdge::shouldRender):
(WebCore::BorderEdge::presentButInvisible):
(WebCore::BorderEdge::usedWidth):
(WebCore::BorderEdge::getDoubleBorderStripeWidths):
(WebCore::edgesShareColor):
(WebCore::styleRequiresClipPolygon):
(WebCore::borderStyleFillsBorderArea):
(WebCore::borderStyleHasInnerDetail):
(WebCore::borderStyleIsDottedOrDashed):
(WebCore::borderStyleHasUnmatchedColorsAtCorner):
(WebCore::colorsMatchAtCorner):
(WebCore::willBeOverdrawn):
(WebCore::borderStylesRequireMitre):
(WebCore::joinRequiresMitre):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::findInnerVertex):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
(WebCore::RenderBoxModelObject::paintBoxShadow):
2011-04-19 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Refactor GLES2Canvas state application out into its own function.
https://bugs.webkit.org/show_bug.cgi?id=58906
Covered by existing tests in fast/canvas and canvas/philip.
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::applyState):
New function to apply compositing and clipping state.
(WebCore::GLES2Canvas::fillPath):
(WebCore::GLES2Canvas::fillRect):
(WebCore::GLES2Canvas::beginShadowDraw):
(WebCore::GLES2Canvas::endShadowDraw):
Refactor calls to applyState().
* platform/graphics/chromium/GLES2Canvas.h:
2011-04-19 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt.
Fix multiple border rendering issues
https://bugs.webkit.org/show_bug.cgi?id=58761
Fix various border-drawing bugs, and optimize some common cases.
Also refactors a lot of the border-drawing code to be more maintainable.
Rounded border rendering with different border widths looks strange
https://bugs.webkit.org/show_bug.cgi?id=17468
paintBorder in RenderObject paint two times the corners
https://bugs.webkit.org/show_bug.cgi?id=20495
Overdraw at box corners when using RGBA colors with alpha
https://bugs.webkit.org/show_bug.cgi?id=21835
Enable antialiasing for border drawing, when transformed
https://bugs.webkit.org/show_bug.cgi?id=22746
Drawing border-radius from path sometimes fails to round outer border in the double style when it should
https://bugs.webkit.org/show_bug.cgi?id=41301
Drawing border-radius from path doesn't appear to always match up border edges correctly
https://bugs.webkit.org/show_bug.cgi?id=41302
Also fixes
Should be able to create Path from RoundedIntRect
https://bugs.webkit.org/show_bug.cgi?id=58809
Tests: fast/borders/border-radius-different-width-001.html
fast/borders/border-radius-inset-outset.html
fast/borders/table-borders.html
* platform/graphics/FloatPoint.h:
* platform/graphics/FloatPoint.cpp:
(WebCore::findSlope):
(WebCore::findIntersection):
New geometry helper functions (should eventually move into a new
GeometryUtilities file).
* platform/graphics/Path.h:
* platform/graphics/Path.cpp:
(WebCore::Path::addRoundedRect):
Add an overload of addRoundedRect() that takes a RoundedIntRect.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::clipOutRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
Can now add a RoundedIntRect to a Path directly.
* platform/graphics/IntRect.h:
(WebCore::IntRect::minXMinYCorner):
(WebCore::IntRect::maxXMinYCorner):
(WebCore::IntRect::minXMaxYCorner):
(WebCore::IntRect::maxXMaxYCorner):
Convenience functions to get the rect corners, in a writing-mode-
friendly way.
* platform/graphics/RoundedIntRect.h:
* platform/graphics/RoundedIntRect.cpp:
(WebCore::RoundedIntRect::isRenderable):
We need to know when Path::addRoundedRect() will fail because
the sum of the radii exceed the height or width. This method tells
us that.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillRectWithRoundedHole):
Can now add a RoundedIntRect to a Path directly.
* rendering/RenderBoxModelObject.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::borderWillArcInnerEdge):
This can just to see if there are inner radii now.
(WebCore::edgeFlagForSide):
(WebCore::includesEdge):
Convenience functions for the BorderEdgeFlags bitmask.
(WebCore::BorderEdge::BorderEdge):
(WebCore::BorderEdge::hasVisibleColorAndStyle):
(WebCore::BorderEdge::shouldRender):
(WebCore::BorderEdge::presentButInvisible):
(WebCore::BorderEdge::usedWidth):
(WebCore::BorderEdge::getDoubleBorderStripeWidths):
Convenience class to hold data about how a single edge
is drawn, and to contain some commonly used width-related methods.
(WebCore::edgesShareColor):
(WebCore::styleRequiresClipPolygon):
(WebCore::borderStyleFillsBorderArea):
(WebCore::borderStyleHasInnerDetail):
(WebCore::borderStyleIsDottedOrDashed):
(WebCore::borderStyleHasUnmatchedColorsAtCorner):
(WebCore::colorsMatchAtCorner):
(WebCore::willBeOverdrawn):
(WebCore::borderStylesRequireMitre):
(WebCore::joinRequiresMitre):
Functions used to make the border drawing code more readable,
which are used to determine when corners need a mitre, and
need antialiasing.
(WebCore::RenderBoxModelObject::paintOneBorderSide):
Code to paint one side of a border, either via the path, or
using rects/polygons, the appropriate mitres and antialiasing
at the corners. includeLogicalLeftEdge and includeLogicalRightEdge need
to be passed all the way down here so that when we recompute the
path for double and ridge/groove borders, we correctly handle split box
borders.
(WebCore::RenderBoxModelObject::paintBorderSides):
Paints the 4 border sides (if present).
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
Called when one or more of the borders has a non-opaque color,
and uses a transparency layer for each set of same-colored
sides to avoid overdraw at the corners.
(WebCore::RenderBoxModelObject::paintBorder):
Builds an array of BorderEdge so we can iterate over them to
detect different border compbinations, and optimizations. Has
a fast path for all-solid borders.
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
Moved from RenderObject, since all callers are in RenderBoxModelObject.
Has the following changes:
* Don't attempt to draw dashes if there is only space for a few,
since it looks bad.
* Handle double and groove borders on split inlines correctly,
making use of includeLogicalLeftEdge, includeLogicalRightEdge
(WebCore::findInnerVertex):
For borders with a radiused inner edge, the per-side clip polygon
has to project inside the padding box to avoid clipping the inner edge.
This function computes a reasonable inner corner for the clipping
polygon.
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
Have the corner joins pass through the corners of the inner and outer
border rectangles, ensure we don't clip the inside if necessary,
and handle antialiasing on the two mitres.
(WebCore::RenderBoxModelObject::paintBoxShadow):
Use RenderStyle::getRoundedInnerBorderFor() rather than computeBorderInnerRect()
etc.
* rendering/RenderObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
Moved to RenderBoxModelObject.
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getRoundedBorderFor):
(WebCore::RenderStyle::getRoundedInnerBorderFor):
There was some very clumsy code that computed a rounded rect
given the border rect and side widths. Cleaned this up by moving
some code into RenderStyle. The overloaded getRoundedInnerBorderFor()
which takes the border widths is used by the double and groove drawing
code.
2011-04-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dimitri Glazkov.
REGRESSION(r74228-75294): removing nodes is 200+ times slower when selection is inside a shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=57061
The bug was caused by Range::compareNode's incorrectly returning NODE_INSIDE when the selection is inside
a shadow DOM and the node is outside of the shadow DOM. This caused respondToNodeModification to call
RenderView::clearSelection every time a node is removed when selection is in a shadow DOM and resulted in
a significant performance regression.
Fixed Ranged::compareNode by making Range::compareBoundaryPoints throw a WRONG_DOCUMENT_ERR when there are
no common ancestors between containerA and containerB. This will force compareNode to also throw an exception
and prevents respondToNodeModification from clearing selection.
No new tests because this is a performance improvement and the fix in Range cannot be tested since shadow DOM
isn't exposed to JavaScript.
* dom/Range.cpp:
(WebCore::Range::setStart): Calls compareBoundaryPoints; since we ensures that the root container noes of
start and end nodes are same, we should never get an exception from compareBoundaryPoints.
(WebCore::Range::setEnd): Ditto.
(WebCore::Range::isPointInRange): Calls compareBoundaryPoints; returns false when compareBoundaryPoints
throws an exception.
(WebCore::Range::comparePoint): Calls compareBoundaryPoints; exit early when an exception is thrown by
compareBoundaryPoints.
(WebCore::Range::compareBoundaryPoints): Throws an exception when two containers do not have a common ancestor.
(WebCore::Range::boundaryPointsValid): Calls compareBoundaryPoints and checks that it didn't throw an exception.
* dom/Range.h:
* editing/SelectionController.cpp:
(WebCore::SelectionController::respondToNodeModification):
* editing/htmlediting.cpp:
(WebCore::comparePositions): Calls compareBoundaryPoints.
* editing/markup.cpp:
(WebCore::createMarkup): Calls compareBoundaryPoints; since startNode and pastEnd are both in the same document
and neither are in a shadow DOM, it should never throw an exception.
* page/DOMSelection.cpp:
(WebCore::DOMSelection::containsNode): Calls compareBoundaryPoints; node is fully selected only if no exception
was thrown.
2011-04-19 Jungshik Shin <jshin@chromium.org>
Reviewed by David Levin
Make U+FEFF be treated as a zero-width character in both
simple script and complex script code paths. In Chromium
Windows, UniscribeHelper needs a rather extensive changes
summarized below. Other ports need minor changes.
https://bugs.webkit.org/show_bug.cgi?id=48860
Test: fast/text/zero-width-characters-complex-script.html
* platform/graphics/Font.h:
(WebCore::Font::treatAsZeroWidthSpace): U+FEFF is added to the list
(WebCore::Font::treatAsZeroWidthSpaceInComplexScript): Added. Same as the above except that ZWNJ and ZWJ are excluded.
* platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage): U+FEFF is made to have zero-width characters in simple script (fast) code path.
* platform/graphics/chromium/FontUtilsChromiumWin.cpp:
(WebCore::FontMap::getSpaceGlyph): Added to get the gid for space glyph to use in adjustSpaceAdvance when zero-width glyph character has a non-zero width and potentially 'visible' glyph.
(WebCore::FontMap::FontData::FontData): spaceGlyph member added.
(WebCore::getDerivedFontData): spaceGlyph is retrieved as well.
* platform/graphics/chromium/FontUtilsChromiumWin.h:
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::UniscribeHelper): m_spaceGlyph added.
(WebCore::UniscribeHelper::shape): spaceGlyph is obtained stored for a font tried for each item.
(WebCore::UniscribeHelper::adjustSpaceAdvances): For zero-width complex script characters, set the advance width to zero and replace a non-zero-width/visible glyph with a space glyph.
(WebCore::UniscribeHelper::applySpacing):
(WebCore::UniscribeHelper::containsMissingGlyphs): turned to a member function because it cannot work on glyphs alone any more but need to take into account a character corresponding to a glyph
* platform/graphics/chromium/UniscribeHelper.h:
(WebCore::UniscribeHelper::Shaping::Shaping): m_spaceGlyph is added
* platform/graphics/chromium/UniscribeHelperTextRun.cpp:
(WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): When calling UniscriberHelper, add a new argument for spaceGlyph.
2011-04-19 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Extend the DIBPixelData class with the facility for writing the
bitmap representation to disk for debugging purposes.
https://bugs.webkit.org/show_bug.cgi?id=58862.
* platform/graphics/win/DIBPixelData.cpp:
(WebCore::DIBPixelData::writeToFile): New function.
* platform/graphics/win/DIBPixelData.h:
2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
https://bugs.webkit.org/show_bug.cgi?id=58883
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::didReceiveData):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didReceiveContentLength):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveContentLength):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.dataReceived):
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
* loader/DocumentThreadableLoader.h:
* loader/FrameLoaderClient.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveData):
* loader/MainResourceLoader.h:
* loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::didReceiveData):
* loader/NetscapePlugInStreamLoader.h:
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::didReceiveData):
(WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
(WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
* loader/ResourceLoadNotifier.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveData):
* loader/ResourceLoader.h:
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveData):
* loader/SubresourceLoader.h:
* loader/SubresourceLoaderClient.h:
(WebCore::SubresourceLoaderClient::didReceiveData):
(WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveCachedMetadata):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveData):
* loader/appcache/ApplicationCacheGroup.h:
* loader/appcache/ApplicationCacheHost.h:
* notifications/Notification.cpp:
(WebCore::Notification::didReceiveData):
* notifications/Notification.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::didReceiveData):
* platform/network/BlobResourceHandle.cpp:
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::didReceiveData):
* platform/network/android/ResourceHandleAndroid.cpp:
(WebCore::SyncLoader::didReceiveData):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::WebCoreSynchronousLoaderClient::didReceiveData):
* platform/network/curl/ResourceHandleCurl.cpp:
* platform/network/mac/ResourceHandleMac.mm:
(WebCoreSynchronousLoaderClient::didReceiveData):
* platform/network/soup/ResourceHandleSoup.cpp:
* platform/network/win/ResourceHandleWin.cpp:
* workers/WorkerScriptLoader.h:
* xml/XMLHttpRequest.h:
2011-04-19 Stephen White <senorblanco@chromium.org>
Reviewed by Eric Seidel.
Pull framebuffer clearing out into its own function.
https://bugs.webkit.org/show_bug.cgi?id=58897
Covered by fast/canvas and canvas/philip tests.
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clearFramebuffer):
(WebCore::DrawingBuffer::reset):
* platform/graphics/gpu/DrawingBuffer.h:
2011-04-19 Brian Salomon <bsalomon@google.com>
Reviewed by Eric Seidel.
When flushing GrContext in ~PlatformContextSkia be sure correct GL context is set
https://bugs.webkit.org/show_bug.cgi?id=58788
Chromium browser test will be added that loads canvas page and then an
acclerated-composited page. Test must trigger ~PlatformContextSkia()
followed by invocation of GL compositor.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::~PlatformContextSkia):
2011-04-19 Csaba Osztrogonác <ossy@webkit.org>
[Qt] REGRESSION(84176): http/tests/xmlhttprequest/event-listener-gc.html fails
https://bugs.webkit.org/show_bug.cgi?id=58871
Unreviewed, rolling out r84176, r84178, r84186, r84212 and r84231.
http://trac.webkit.org/changeset/84176 (original patch)
http://trac.webkit.org/changeset/84178 (original patch - part 2)
http://trac.webkit.org/changeset/84186 (build fix)
http://trac.webkit.org/changeset/84212
http://trac.webkit.org/changeset/84231 (skip failing test)
original bugs:
- https://bugs.webkit.org/show_bug.cgi?id=58718
- https://bugs.webkit.org/show_bug.cgi?id=58853
* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::removeCachedMethod):
(JSC::Bindings::QtInstance::markAggregate):
* bridge/qt/qt_instance.h:
2011-04-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84050.
http://trac.webkit.org/changeset/84050
https://bugs.webkit.org/show_bug.cgi?id=58892
fast/dom/HTMLKeygenElement/keygen.html is crashing on Chromium
(Requested by jknotten on #webkit).
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::parserAddChild):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setDocType):
* dom/Element.h:
* dom/Node.cpp:
(WebCore::Node::treeScope):
(WebCore::Node::setTreeScope):
(WebCore::Node::setTreeScopeRecursively):
* dom/Node.h:
(WebCore::Node::document):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
* dom/ShadowRoot.h:
* dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::setParentTreeScope):
* dom/TreeScope.h:
* rendering/RenderSlider.cpp:
2011-04-19 Kinuko Yasuda <kinuko@chromium.org>
Not reviewed; windows build fix attempt.
* storage/StorageInfo.cpp:
(WebCore::StorageInfo::~StorageInfo):
* storage/StorageInfo.h:
2011-04-19 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
[Chromium] Enable QUOTA API at runtime if enable-quota flag is given
https://bugs.webkit.org/show_bug.cgi?id=58784
No new tests as this does not change any functionality.
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::quotaEnabled):
(WebCore::RuntimeEnabledFeatures::setQuotaEnabled):
* page/DOMWindow.idl:
2011-04-19 John Gregg <johnnyg@google.com>
Reviewed by Darin Fisher.
Enable folder drag-n-drop when using a "webkitdirectory" file input
https://bugs.webkit.org/show_bug.cgi?id=58401
This uses a new ChromeClient API to enumerate the directory and
return all the files, as if the user had selected that directory
by clicking the control in the normal way.
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::enumerateChosenDirectory):
* page/Chrome.cpp:
(WebCore::Chrome::enumerateChosenDirectory):
* page/Chrome.h:
* page/ChromeClient.h:
* platform/network/FormData.cpp:
(WebCore::FormData::appendKeyValuePairItems):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::receiveDropForDirectoryUpload):
(WebCore::RenderFileUploadControl::receiveDroppedFiles):
* rendering/RenderFileUploadControl.h:
2011-04-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84150.
http://trac.webkit.org/changeset/84150
https://bugs.webkit.org/show_bug.cgi?id=58875
Broken backspace in Search box of Web Inspector (Requested by
apavlov on #webkit).
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
2011-04-19 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: NPE in TextEditorModel
https://bugs.webkit.org/show_bug.cgi?id=58870
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._frameAdded):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.prototype.setText):
2011-04-19 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Gentilcore.
IndexedDB: Remove accidental header include directive from LevelDB backend.
https://bugs.webkit.org/show_bug.cgi?id=58872
No new functionality, no new tests.
* storage/IDBLevelDBBackingStore.cpp:
2011-04-19 Herczeg Zoltan <zherczeg@webkit.org>
Build fix.
LEFilter change doesn't compile on ARM neon targets
https://bugs.webkit.org/show_bug.cgi?id=58671
Thanks for Charlie Lee to fixing this.
* WebCore.gypi:
2011-04-19 Daniel Bates <dbates@webkit.org>
Attempt to fix the Qt Linux Release Minimal build after changeset 84225
<http://trac.webkit.org/changeset/84225> (https://bugs.webkit.org/show_bug.cgi?id=52788).
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::ensureEventAncestors): Add ENABLE(SVG) guards around call
to Node::svgShadowHost() since this method is only defined when building with SVG enabled.
2011-04-18 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Makes SVG shadow roots and DOM shadow roots distinct.
https://bugs.webkit.org/show_bug.cgi?id=52788
Not a functional change. Covered by existing SVG tests.
* dom/EventDispatcher.cpp:
(WebCore::findElementInstance):
(WebCore::EventDispatcher::adjustToShadowBoundaries):
(WebCore::EventDispatcher::adjustRelatedTarget):
(WebCore::EventDispatcher::ensureEventAncestors):
* dom/Node.cpp:
(WebCore::Node::setShadowHost):
(WebCore::Node::svgShadowHost):
(WebCore::Node::shadowTreeRootNode):
* dom/Node.h:
(WebCore::Node::isSVGShadowRoot):
(WebCore::Node::parentNode):
(WebCore::Node::parentNodeGuaranteedHostFree):
* rendering/svg/RenderSVGShadowTreeRootContainer.cpp:
(WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
(WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
* rendering/svg/SVGShadowTreeElements.cpp:
(WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement):
(WebCore::SVGShadowTreeRootElement::create):
(WebCore::SVGShadowTreeRootElement::attachElement):
(WebCore::SVGShadowTreeRootElement::clearSVGShadowHost):
* rendering/svg/SVGShadowTreeElements.h:
(WebCore::SVGShadowTreeRootElement::isSVGShadowRoot):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::title):
2011-04-18 Taiju TSUIKI <develop@tzik.jp>
Reviewed by Darin Fisher.
Vendor-prefix requestFileSystem in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=58517
Prefix from:
- window.requestFileSystem to window.webkitRequestFileSystem
- window.resolveLocalFileSystemURL to window.webkitResolveLocalFileSystemURL
- window.Flags to window.WebKitFlags
- WorkerContext.requestFileSystem to WorkerContext.webkitRequestFileSystem
- WorkerContext.resolveLocalFileSystemURL to WorkerContext.webkitResolveLocalFileSystemURL
- WorkerContext.Flags to WorkerContext.WebKitFlags
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDirectoryEntryCustom.cpp:
(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):
* bindings/js/JSDirectoryEntrySyncCustom.cpp:
(WebCore::getFlags):
(WebCore::JSDirectoryEntrySync::getFile):
(WebCore::JSDirectoryEntrySync::getDirectory):
* bindings/v8/custom/V8DirectoryEntryCustom.cpp:
(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):
* bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
(WebCore::getFlags):
(WebCore::V8DirectoryEntrySync::getDirectoryCallback):
(WebCore::V8DirectoryEntrySync::getFileCallback):
* fileapi/DOMFileSystemBase.cpp:
(WebCore::DOMFileSystemBase::getFile):
(WebCore::DOMFileSystemBase::getDirectory):
* fileapi/DOMFileSystemBase.h:
* fileapi/DirectoryEntry.cpp:
(WebCore::DirectoryEntry::getFile):
(WebCore::DirectoryEntry::getDirectory):
* fileapi/DirectoryEntry.h:
* fileapi/DirectoryEntry.idl:
* fileapi/DirectoryEntrySync.cpp:
(WebCore::DirectoryEntrySync::getFile):
(WebCore::DirectoryEntrySync::getDirectory):
* fileapi/DirectoryEntrySync.h:
* fileapi/DirectoryEntrySync.idl:
* fileapi/WebKitFlags.h: Renamed from Source/WebCore/fileapi/Flags.h.
(WebCore::WebKitFlags::create):
(WebCore::WebKitFlags::isCreate):
(WebCore::WebKitFlags::setCreate):
(WebCore::WebKitFlags::isExclusive):
(WebCore::WebKitFlags::setExclusive):
(WebCore::WebKitFlags::WebKitFlags):
* fileapi/WebKitFlags.idl: Renamed from Source/WebCore/fileapi/Flags.idl.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitRequestFileSystem):
(WebCore::DOMWindow::webkitResolveLocalFileSystemURL):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::webkitRequestFileSystem):
(WebCore::WorkerContext::webkitRequestFileSystemSync):
(WebCore::WorkerContext::webkitResolveLocalFileSystemURL):
(WebCore::WorkerContext::webkitResolveLocalFileSystemSyncURL):
* workers/WorkerContext.h:
* workers/WorkerContext.idl:
2011-04-18 Steve Lacey <sjl@chromium.org>
Reviewed by Dimitri Glazkov.
Decouple media controls usage from implementation.
This allows each port to implement thier own controls in a different
manner to the default webkit implementation.
Convert media controls hooks to a client interface
https://bugs.webkit.org/show_bug.cgi?id=58346
No new tests as there is no functional change.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::ensureMediaControls):
(WebCore::HTMLMediaElement::preDispatchEventHandler):
* html/HTMLMediaElement.h:
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement):
(WebCore::MediaControlPanelMuteButtonElement::create):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::create):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
(WebCore::MediaControlFullscreenButtonElement::create):
* html/shadow/MediaControlElements.h:
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControls::create):
* html/shadow/MediaControlRootElement.h:
* html/shadow/MediaControls.cpp: Added.
(WebCore::MediaControls::MediaControls):
* html/shadow/MediaControls.h: Added.
(WebCore::MediaControls::~MediaControls):
2011-04-18 Pascal Massimino <pascal.massimino@gmail.com>
Reviewed by Adam Barth.
Add incremental decoding to WebP decoder
https://bugs.webkit.org/show_bug.cgi?id=58851
No new tests, as it's not possible for the layout test framework to
force the decoders to decode incrementally.
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::WEBPImageDecoder):
(WebCore::WEBPImageDecoder::decode):
* platform/image-decoders/webp/WEBPImageDecoder.h:
2011-04-18 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
With PAN_SCROLLING, mousedown events for a mouse button aren't dispatched while
pressing-and-holding another mouse button
https://bugs.webkit.org/show_bug.cgi?id=58700
Fixes an issue where mousedown events weren't dispatched when pressing a mouse button A
while pressing and holding a mouse button B, where A != B. This issue only affects builds
that enable PAN_SCROLLING.
On mouse press with autoscroll in progress (m_autoscrollInProgress == true) we stopped
the autoscroll timer, invalidated the click, and swallowed the mouse press. Instead, we
should only stop the autoscroll timer.
Test: fast/events/fire-mousedown-while-pressing-mouse-button.html
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
2011-04-18 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
With overlay scrollbars, textarea resize corner gains borders when the textarea becomes scrollable
https://bugs.webkit.org/show_bug.cgi?id=58617
<rdar://problem/9048012>
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintResizer): Check for overlay scrollbars first, and then if the bars were created, before displaying the borders
2011-04-18 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Selected item background in list box gets rendered on top of overlay scrollbar knob (58824)
https://bugs.webkit.org/show_bug.cgi?id=58824
<rdar://problem/9292680>
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintObject): Moving the stage of painting the scrollbars to the foreground if using overlay scrollbars
2011-04-18 John Bauman <jbauman@chromium.org>
Reviewed by Kenneth Russell.
Don't cast BitmapImageSingleFrameSkia to BitmapImage
https://bugs.webkit.org/show_bug.cgi?id=58821
BitmapImageSingleFrameSkia has isBitmap return true, but
can't be cast to a BitmapImage. Instead of using BitmapImage,
use isOpaque from SkBitmap to determine if the image has alpha.
No new tests.
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
2011-04-18 Jessie Berlin <jberlin@apple.com>
Reviewed by Steve Falkenburg.
If deleting the StorageTracker.db file fails, local storage is left in a strange state.
https://bugs.webkit.org/show_bug.cgi?id=58805
* storage/StorageTracker.cpp:
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
When cleaning up the StorageTracker.db file, is not enough to call syncDeleteOrigin.
deleteOrigin itself must be called to update the data structures that syncDeleteOrigin
depends on and to prevent clashes between a theoretical web page editing local storage
at the same time this method is called.
(WebCore::StorageTracker::syncDeleteAllOrigins):
If it is not possible to delete the StorageTracker.db file, empty it.
(WebCore::StorageTracker::deleteOriginOnMainThread):
Wrapper for deleteOrigin.
* storage/StorageTracker.h:
2011-04-18 Geoffrey Garen <ggaren@apple.com>
Build fix.
Added back missing #include.
* bindings/js/DOMWrapperWorld.cpp:
2011-04-18 Enrica Casucci <enrica@apple.com>
Reviewed by Maciej Stachowiak.
Dropping a file in a WKView (WebKit2) doesn't load the file.
https://bugs.webkit.org/show_bug.cgi?id=58842
<rdar://problem/8514409>
The URL string for the file contains an extra %00 at the end
that causes the network framework to fail to load the file.
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getURL):
2011-04-18 Geoffrey Garen <ggaren@apple.com>
Discovered and rubber-stamped by Stephanie Lewis.
Restored some code I accidentally deleted in <http://trac.webkit.org/changeset/83990>
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::clearWrappers): Do clear / destroy all our
window shells when clearing / destroying ourselves. r83990 removed this
behavior for documents since there are no per-document maps anymore,
but removing this behavior for window shells too was a typo.
2011-04-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Made DOM handle ownership customizable, and customized it for Nodes and NamedAttrMaps
https://bugs.webkit.org/show_bug.cgi?id=58828
* WebCore.exp.in: Blah.
* bindings/js/DOMWrapperWorld.cpp: Moved code related to JSNode ownership
to JSNodeCustom, where other custom JSNode-related code goes.
(WebCore::JSDOMWrapperOwner::finalize):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
* bindings/js/DOMWrapperWorld.h:
(WebCore::JSDOMWrapperOwner::JSDOMWrapperOwner):
(WebCore::DOMWrapperWorld::defaultWrapperOwner): Renamed DOMObjectHandleOwner
to JSDOMWrapperOwner, to match the name of JSDOMWrapper.
* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::toJSArrayBufferView):
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::toJS): Removed "DOMObject" and "Node" from the names of wrapper-
related functions, since there is no meaningful distinction between the
two anymore -- they both use the same extensible interface.
* bindings/js/JSDOMBinding.cpp: Removed some now-unused functions.
* bindings/js/JSDOMBinding.h:
(WebCore::getInlineCachedWrapper):
(WebCore::setInlineCachedWrapper):
(WebCore::clearInlineCachedWrapper):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::getCachedWrapper):
(WebCore::cacheWrapper):
(WebCore::uncacheWrapper):
(WebCore::createWrapper):
(WebCore::wrap): Created a generic, extensible mechanism for creating,
caching, retrieving, marking, and destroying DOM wrappers. This eliminates
the difference between DOM object wrappers and DOM node wrappers, and
lays the groundwork for getting rid of MarkStack::deprecatedAppend usage
for marking the remainder of our DOM objects.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):
* bindings/js/JSDataViewCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
(WebCore::toJS):
* bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS): Updated for renames mentioned above.
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMapOwner::isReachableFromOpaqueRoots):
(WebCore::JSNamedNodeMapOwner::finalize):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::JSNamedNodeMap::markChildren):
(WebCore::toJS): Updated to use our new interface for customizing wrapper
lifetime management through function overloading without using
MarkStack::deprecatedAppend.
* bindings/js/JSNodeCustom.cpp:
(WebCore::isObservable):
(WebCore::isReachableFromDOM):
(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
(WebCore::JSNodeOwner::finalize):
(WebCore::createWrapperInline): Moved node-related code from JSDOMBinding
to here. Removed special case marking code for JSNamedNodeMap because
JSNamedNodeMap now knows how to maintain its own lifetime invariants.
* bindings/js/JSNodeCustom.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::getInlineCachedWrapper):
(WebCore::setInlineCachedWrapper):
(WebCore::clearInlineCachedWrapper):
(WebCore::toJS): Updated to use our new interface for customizing wrapper
lifetime management through function overloading without using
MarkStack::deprecatedAppend or special-case code for nodes.
* bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS): Updated for renames mentioned above.
* bindings/scripts/CodeGeneratorJS.pm: Fixed up newlines. Updated for
renames mentioned above.
* dom/NamedNodeMap.idl: NamedNodeMap needs a custom toJS function now
because it needs to provide a custom WeakHandleOwner at wrapper creation time.
2011-04-18 Jessie Berlin <jberlin@apple.com>
Rubber-stamped by Sam Weinig.
REGRESSION (r84094): Many tests failing assertions in WebCore::localizedString on Windows.
https://bugs.webkit.org/show_bug.cgi?id=58747
Copy the WebCore Localizable.strings file into the output directory.
* WebCore.vcproj/WebCoreGenerated.vcproj:
* WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
* WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
* WebCore.vcproj/copyInspectorFiles.cmd: Removed.
* WebCore.vcproj/copyWebCoreResourceFiles.cmd: Copied from Source/WebCore/WebCore.vcproj/copyInspectorFiles.cmd.
2011-04-18 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] PluginViewQt needs to update geometry of plugin widget before scheduling a repaint
When scheduling a repaint for the plugin's widget, PluginViewQt
needs to make sure the widget's geometry is up to date. Otherwise
the paint event happens on the widget's old location.
https://bugs.webkit.org/show_bug.cgi?id=57179
Added a manual test.
* manual-tests/qt/plugin-painting.html: Added.
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::invalidateRect):
2011-04-18 Oliver Hunt <oliver@apple.com>
Fix Qt build
* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::removeCachedMethod):
* bridge/qt/qt_instance.h:
2011-04-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove DeprecatedPtr
https://bugs.webkit.org/show_bug.cgi?id=58718
Replace use of DeprecatedPtr<> with Global<> as ownership rules
aren't obvious, have filed bug #58820 on seeing if this is safe.
* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::removeCachedMethod):
(JSC::Bindings::QtInstance::markAggregate):
* bridge/qt/qt_instance.h:
2011-04-14 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
[CG] Use vImage (un)premultiplyImageData functions for get/putImageData with IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=58088
* platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::convertScanline): un/premultiplies and converts a scanline of image data from/to BGRA to/from RGBA
(WebCore::unpremultitplyScanline):
(WebCore::premultitplyScanline):
(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):
2011-04-18 Jeff Miller <jeffm@apple.com>
Reviewed by Dan Bernstein.
Allow all log channels to be initialized from WebCoreLogLevel Windows environment variable
https://bugs.webkit.org/show_bug.cgi?id=58811
* platform/win/LoggingWin.cpp:
(WebCore::InitializeLoggingChannelsIfNecessary): Support initializing LogResourceLoading, LogProgress, and LogFileAPI from WebCoreLogLevel Windows environment variable.
2011-04-18 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Reset fullscreen element reference when leaving fullscreen mode and some other cleanup.
https://bugs.webkit.org/show_bug.cgi?id=58719
Test: fullscreen/full-screen-cancel.html
* dom/Document.cpp:
(WebCore::Document::Document): Remove m_isFullscreen.
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement): Remove duplicate call to setAnimating().
(WebCore::Document::webkitDidExitFullScreenForElement): Reset m_fullScreenElement reference.
* dom/Document.h:
(WebCore::Document::webkitIsFullScreen): Use m_fullScreenElement instead of m_isFullscreen.
(WebCore::Document::webkitFullScreenKeyboardInputAllowed): Ditto.
2011-04-18 Dan Bernstein <mitz@apple.com>
Reviewed by Eric Seidel.
<rdar://problem/9282486> REGRESSION (r81992): Facebook photo tags can get cut off when moving the mouse.
https://bugs.webkit.org/show_bug.cgi?id=58500
Test: fast/repaint/text-in-relative-positioned-inline.html
* rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint): Use the container’s repaint rect, not
the containing block’s. This matters when the containing block is outside the RenderText’s
enclosing layer, as is the case here.
2011-04-15 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Speed up DrawingBuffer::reset().
https://bugs.webkit.org/show_bug.cgi?id=58706
When DrawingBuffer::reset() is called, it should not reallocate
the FBOs if the size has not changed. It should just do a glClear().
Covered by tests in fast/canvas and canvas/philip.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
Initialize the size to -1, -1, so the size change check will work on
first reset.
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::reset):
If the size hasn't changed, don't resize the FBOs. Just clear the
relevant buffers.
2011-04-18 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: group resources by type in the resources panel.
https://bugs.webkit.org/show_bug.cgi?id=58796
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._frameAdded):
(WebInspector.ResourcesPanel.prototype._resourceAdded):
(WebInspector.BaseStorageTreeElement):
(WebInspector.BaseStorageTreeElement.prototype.onattach):
(WebInspector.StorageCategoryTreeElement):
(WebInspector.FrameTreeElement):
(WebInspector.FrameTreeElement.prototype.setTitles):
(WebInspector.FrameTreeElement.prototype.set hovered):
(WebInspector.FrameTreeElement.prototype.appendResource):
(WebInspector.FrameTreeElement.prototype.appendChild):
(WebInspector.FrameTreeElement.prototype._insertInPresentationOrder):
(WebInspector.FrameTreeElement.prototype._insertInPresentationOrder.compare):
2011-04-18 Timothy Hatcher <timothy@apple.com>
Make update-webkit-localizable-strings put WebKit/win strings in WebCore
now that all localized strings in WebKit/win use WEB_UI_STRING.
https://webkit.org/b/58747
Reviewed by Dan Bernstein.
* English.lproj/Localizable.strings: Updated with strings from WebKit/win.
2011-04-15 MORITA Hajime <morrita@google.com>
Reviewed by Adam Barth.
REGRESSION: <progress> doesn't animate if it doesn't have value
https://bugs.webkit.org/show_bug.cgi?id=58693
The initial value of RenderProgress::m_position is accidentally same as
the indeterminate value, that makes update code on updateFromElement() skipped.
This change set unique invalid value for the initial value of m_position.
No new tests. Testing animated bar is not possible with DRT.
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::position):
* html/HTMLProgressElement.h:
* rendering/RenderProgress.cpp:
(WebCore::RenderProgress::RenderProgress):
(WebCore::RenderProgress::isDeterminate):
2011-04-18 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
REGRESSION: [Chromium Win] details-add-summary-1.html start crashing after r84039
https://bugs.webkit.org/show_bug.cgi?id=58791
On refreshMainSummary(), findMainSummary() possibly releases oldSummary.
We should guard it again RefPtr.
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::refreshMainSummary):
2011-04-18 Antti Koivisto <antti@apple.com>
Reviewed by Simon Fraser.
CSSSelector double frees
https://bugs.webkit.org/show_bug.cgi?id=56124
<rdar://problem/9119036>
In all stacks this is occuring when the document is kept alive by the guard ref only
and the node holding it is deleted.
As a speculative fix, clear the document stylesheets when it turns into a guard ref zombie.
This has a pretty good chance of fixing the actual bug. At minimum it will move the
crash to an earlier, more easily traceble point.
No tests, crash stacks only, no idea how to reproduce.
* dom/Document.cpp:
(WebCore::Document::removedLastRef):
2011-04-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Backspace in the Console is broken
https://bugs.webkit.org/show_bug.cgi?id=58764
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
2011-04-18 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
LevelDB backend for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=57372
Only available behind a run-time flag. Covered by existing layout
tests.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* platform/leveldb/LevelDBComparator.h: Added.
(WebCore::LevelDBComparator::~LevelDBComparator):
* platform/leveldb/LevelDBDatabase.cpp: Added.
(WebCore::makeSlice):
(WebCore::makeLevelDBSlice):
(WebCore::makeVector):
(WebCore::LevelDBDatabase::LevelDBDatabase):
(WebCore::LevelDBDatabase::~LevelDBDatabase):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::put):
(WebCore::LevelDBDatabase::remove):
(WebCore::LevelDBDatabase::get):
(WebCore::LevelDBDatabase::newIterator):
* platform/leveldb/LevelDBDatabase.h: Added.
* platform/leveldb/LevelDBIterator.cpp: Added.
(WebCore::LevelDBIterator::~LevelDBIterator):
(WebCore::LevelDBIterator::LevelDBIterator):
(WebCore::makeSlice):
(WebCore::makeLevelDBSlice):
(WebCore::LevelDBIterator::isValid):
(WebCore::LevelDBIterator::seekToLast):
(WebCore::LevelDBIterator::seek):
(WebCore::LevelDBIterator::next):
(WebCore::LevelDBIterator::prev):
(WebCore::LevelDBIterator::key):
(WebCore::LevelDBIterator::value):
* platform/leveldb/LevelDBIterator.h: Added.
* platform/leveldb/LevelDBSlice.h: Added.
(WebCore::LevelDBSlice::LevelDBSlice):
(WebCore::LevelDBSlice::~LevelDBSlice):
(WebCore::LevelDBSlice::begin):
(WebCore::LevelDBSlice::end):
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::encodeByte):
(WebCore::maxIDBKey):
(WebCore::minIDBKey):
(WebCore::encodeInt):
(WebCore::decodeInt):
(WebCore::encodeVarInt):
(WebCore::decodeVarInt):
(WebCore::encodeString):
(WebCore::decodeString):
(WebCore::encodeStringWithLength):
(WebCore::decodeStringWithLength):
(WebCore::encodeDouble):
(WebCore::decodeDouble):
(WebCore::encodeIDBKey):
(WebCore::decodeIDBKey):
(WebCore::extractEncodedIDBKey):
(WebCore::compareEncodedIDBKeys):
(WebCore::getInt):
(WebCore::putInt):
(WebCore::getString):
(WebCore::putString):
(WebCore::KeyPrefix::SchemaVersionKey::encode):
(WebCore::KeyPrefix::MaxDatabaseIdKey::encode):
(WebCore::KeyPrefix::DatabaseFreeListKey::DatabaseFreeListKey):
(WebCore::KeyPrefix::DatabaseFreeListKey::decode):
(WebCore::KeyPrefix::DatabaseFreeListKey::encode):
(WebCore::KeyPrefix::DatabaseFreeListKey::databaseId):
(WebCore::KeyPrefix::DatabaseFreeListKey::compare):
(WebCore::KeyPrefix::DatabaseNameKey::decode):
(WebCore::KeyPrefix::DatabaseNameKey::encode):
(WebCore::KeyPrefix::DatabaseNameKey::origin):
(WebCore::KeyPrefix::DatabaseNameKey::databaseName):
(WebCore::KeyPrefix::DatabaseNameKey::compare):
(WebCore::KeyPrefix::DatabaseMetaDataKey::encode):
(WebCore::KeyPrefix::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
(WebCore::KeyPrefix::ObjectStoreMetaDataKey::decode):
(WebCore::KeyPrefix::ObjectStoreMetaDataKey::encode):
(WebCore::KeyPrefix::ObjectStoreMetaDataKey::objectStoreId):
(WebCore::KeyPrefix::ObjectStoreMetaDataKey::metaDataType):
(WebCore::KeyPrefix::ObjectStoreMetaDataKey::compare):
(WebCore::KeyPrefix::IndexMetaDataKey::IndexMetaDataKey):
(WebCore::KeyPrefix::IndexMetaDataKey::decode):
(WebCore::KeyPrefix::IndexMetaDataKey::encode):
(WebCore::KeyPrefix::IndexMetaDataKey::compare):
(WebCore::KeyPrefix::IndexMetaDataKey::indexId):
(WebCore::KeyPrefix::IndexMetaDataKey::metaDataType):
(WebCore::KeyPrefix::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
(WebCore::KeyPrefix::ObjectStoreFreeListKey::decode):
(WebCore::KeyPrefix::ObjectStoreFreeListKey::encode):
(WebCore::KeyPrefix::ObjectStoreFreeListKey::objectStoreId):
(WebCore::KeyPrefix::ObjectStoreFreeListKey::compare):
(WebCore::KeyPrefix::IndexFreeListKey::IndexFreeListKey):
(WebCore::KeyPrefix::IndexFreeListKey::decode):
(WebCore::KeyPrefix::IndexFreeListKey::encode):
(WebCore::KeyPrefix::IndexFreeListKey::compare):
(WebCore::KeyPrefix::IndexFreeListKey::objectStoreId):
(WebCore::KeyPrefix::IndexFreeListKey::indexId):
(WebCore::KeyPrefix::ObjectStoreNamesKey::decode):
(WebCore::KeyPrefix::ObjectStoreNamesKey::encode):
(WebCore::KeyPrefix::ObjectStoreNamesKey::compare):
(WebCore::KeyPrefix::ObjectStoreNamesKey::objectStoreName):
(WebCore::KeyPrefix::IndexNamesKey::IndexNamesKey):
(WebCore::KeyPrefix::IndexNamesKey::decode):
(WebCore::KeyPrefix::IndexNamesKey::encode):
(WebCore::KeyPrefix::IndexNamesKey::compare):
(WebCore::KeyPrefix::IndexNamesKey::indexName):
(WebCore::KeyPrefix::ObjectStoreDataKey::decode):
(WebCore::KeyPrefix::ObjectStoreDataKey::encode):
(WebCore::KeyPrefix::ObjectStoreDataKey::compare):
(WebCore::KeyPrefix::ObjectStoreDataKey::userKey):
(WebCore::KeyPrefix::ExistsEntryKey::decode):
(WebCore::KeyPrefix::ExistsEntryKey::encode):
(WebCore::KeyPrefix::ExistsEntryKey::compare):
(WebCore::KeyPrefix::ExistsEntryKey::userKey):
(WebCore::KeyPrefix::IndexDataKey::IndexDataKey):
(WebCore::KeyPrefix::IndexDataKey::decode):
(WebCore::KeyPrefix::IndexDataKey::encode):
(WebCore::KeyPrefix::IndexDataKey::encodeMaxKey):
(WebCore::KeyPrefix::IndexDataKey::compare):
(WebCore::KeyPrefix::IndexDataKey::databaseId):
(WebCore::KeyPrefix::IndexDataKey::objectStoreId):
(WebCore::KeyPrefix::IndexDataKey::indexId):
(WebCore::KeyPrefix::IndexDataKey::userKey):
(WebCore::KeyPrefix::realCompare):
(WebCore::KeyPrefix::compareKeys):
(WebCore::KeyPrefix::compareIndexKeys):
(WebCore::KeyPrefix::Comparator::compare):
(WebCore::KeyPrefix::Comparator::name):
(WebCore::setUpMetadata):
(WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
(WebCore::IDBLevelDBBackingStore::open):
(WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
(WebCore::getNewDatabaseId):
(WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::getNewObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::deleteRange):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
(WebCore::getNewVersionNumber):
(WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::clearObjectStore):
(WebCore::IDBLevelDBBackingStore::createInvalidRecordIdentifier):
(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::getNewIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::findGreatestKeyLessThan):
(WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::getObjectViaIndex):
(WebCore::versionExists):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::findLastIndexKeyEqualTo):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
(WebCore::IDBLevelDBBackingStore::createTransaction):
* storage/IDBLevelDBBackingStore.h:
2011-04-18 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add test for CSS-resource binding.
https://bugs.webkit.org/show_bug.cgi?id=58786
Test: inspector/styles/styles-history.html
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::toggleProperty):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::toggleProperty):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.if):
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.mycallback):
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged):
(WebInspector.CSSStyleModel.prototype.setStyleSheetText):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSProperty.prototype.setText.callback):
(WebInspector.CSSProperty.prototype.setText):
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83996.
http://trac.webkit.org/changeset/83996
https://bugs.webkit.org/show_bug.cgi?id=58790
layout test editing/selection/move-by-word-visually.html is
failing (Requested by jknotten on #webkit).
* editing/visible_units.cpp:
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
(WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality):
(WebCore::previousWordBreakInBox):
(WebCore::leftWordBoundary):
(WebCore::rightWordBoundary):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):
2011-04-18 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Daniel Bates.
Modify make_names.pl to not include conditional includes unconditionally
https://bugs.webkit.org/show_bug.cgi?id=53672
Fixed conditional includes being unconditionally included.
No new tests (no change in functionality)
* dom/make_names.pl:
- Modified printJSElementIncludes() to only print unconditional element includes.
- Modified printElementIncludes() to only print unconditional element includes.
- Added printConditionalElementIncludes() which takes care of printing conditional element includes.
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83803.
http://trac.webkit.org/changeset/83803
https://bugs.webkit.org/show_bug.cgi?id=58782
Caused focus rings to appear in youtube videos (Requested by
inferno-sec on #webkit).
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
2011-04-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Need a workaround for bug 58422
https://bugs.webkit.org/show_bug.cgi?id=58780
Instead of the A:before content, the link text is displayed as the A tag content.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.linkifyUncopyable):
(WebInspector.StylePropertiesSection):
* inspector/front-end/inspector.css:
2011-04-18 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after 82465.
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedString):
2011-04-18 Andrey Adaikin <aandrey@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: TAB should not move focus from the text editor while live editing
https://bugs.webkit.org/show_bug.cgi?id=58537
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._registerShortcuts):
(WebInspector.TextViewer.prototype._cancelEditing):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
(WebInspector.TextEditorMainPanel.prototype.handleTabKeyPress):
(WebInspector.TextEditorMainPanel.prototype._setCaretLocation):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._setText):
2011-04-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Incorrect content area dimensions in Metrics pane for box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=58551
Test: inspector/styles/metrics-box-sizing.html
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._getPropertyValueAsPx):
(WebInspector.MetricsSidebarPane.prototype._getBox):
(WebInspector.MetricsSidebarPane.prototype._update.getContentAreaWidthPx):
(WebInspector.MetricsSidebarPane.prototype._update.getContentAreaHeightPx):
(WebInspector.MetricsSidebarPane.prototype._update):
(WebInspector.MetricsSidebarPane.prototype.startEditing):
(WebInspector.MetricsSidebarPane.prototype.editingCommitted.setEnabledValueCallback):
(WebInspector.MetricsSidebarPane.prototype.editingCommitted):
2011-04-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Database agent stops to propagate it's events after navigation.
https://bugs.webkit.org/show_bug.cgi?id=58776
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::clearFrontend):
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::disable):
(WebCore::InspectorDatabaseAgent::restore):
* inspector/InspectorDatabaseAgent.h:
(WebCore::InspectorDatabaseAgent::create):
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83968.
http://trac.webkit.org/changeset/83968
https://bugs.webkit.org/show_bug.cgi?id=58769
Breaks Backspace in Web Inspector console (Requested by
apavlov on #webkit).
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
2011-04-15 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce WorkerInspectorController
https://bugs.webkit.org/show_bug.cgi?id=58668
WorkerInspectorController will be owned by WorkerContext and will hold all inspector
agents and will also manage connection to the inspector frontend.
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromWorkerContext):
* bindings/js/ScriptState.h:
* bindings/v8/ScriptState.cpp:
(WebCore::scriptStateFromWorkerContext):
* bindings/v8/ScriptState.h:
* inspector/InspectorState.cpp:
(WebCore::InspectorState::updateCookie):
* inspector/WorkerInspectorController.cpp: Added.
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::~WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
(WebCore::WorkerInspectorController::dispatchMessageFromFrontend):
* inspector/WorkerInspectorController.h: Copied from Source/WebCore/bindings/js/ScriptState.h.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::WorkerContext):
* workers/WorkerContext.h:
(WebCore::WorkerContext::workerInspectorController):
2011-04-17 Thierry Reding <thierry.reding@avionic-design.de>
Reviewed by Adam Barth.
Fix build with GCC 4.6.
* dom/make_names.pl: Execute preprocessor without the -P option. The
preprocessor in GCC 4.6 eats empty lines, effectively breaking the
parsing performed by this script. Dropping the -P option when invoking
the preprocessor keeps the empty lines but as a side-effect also adds
additional linemarkers.
From the cpp manpage:
-P Inhibit generation of linemarkers in the output from the
preprocessor. This might be useful when running the preprocessor
on something that is not C code, and will be sent to a program
which might be confused by the linemarkers.
The linemarkers are not problematic, however, because the script
properly handles them by ignoring all lines starting with a #.
2011-04-17 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
<rdar://problem/9268729>
Reviewed by Dan Bernstein.
This replaces support for the WebKitEnableHTTPPipelining user
default with methods on the WebCore::ResourceRequest class in
WebCore, the WebView class in WebKit1, and the WebContext class
in WebKit2. It also removes support for the
WebKitForceHTTPPipeliningPriorityHigh user default which was not
needed.
Run these commands if you set the user defaults previously,
replacing "BUNDLE.ID" with your application's bundle ID:
defaults delete BUNDLE.ID WebKitEnableHTTPPipelining
defaults delete BUNDLE.ID WebKitForceHTTPPipeliningPriorityHigh
* WebCore.exp.in: Export ResourceRequest::httpPipeliningEnabled()
and ResourceRequest::setHTTPPipeliningEnabled().
* platform/network/ResourceRequestBase.h:
(WebCore::isHTTPPipeliningEnabled): Removed declaration.
(WebCore::shouldForceHTTPPipeliningPriorityHigh): Removed declaration.
* platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::httpPipeliningEnabled): Added declaration.
(WebCore::ResourceRequest::setHTTPPipeliningEnabled): Added declaration.
(WebCore::ResourceRequest::s_httpPipeliningEnabled): Added declaration.
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::s_httpPipeliningEnabled): Added.
(WebCore::ResourceRequest::httpPipeliningEnabled): Added.
(WebCore::ResourceRequest::setHTTPPipeliningEnabled): Added.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Switched
to use ResourceRequest::httpPipeliningEnabled().
(WebCore::readBooleanPreference): Removed.
(WebCore::isHTTPPipeliningEnabled): Removed.
(WebCore::shouldForceHTTPPipeliningPriorityHigh): Removed.
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest): Switched to
use ResourceRequest::httpPipeliningEnabled(). Removed check for
shouldForceHTTPPipeliningPriorityHigh().
(WebCore::ResourceRequest::doUpdatePlatformRequest): Ditto.
2011-04-17 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION (r84096): <br> moved to the right in fast/block/float/032.html
https://bugs.webkit.org/show_bug.cgi?id=58736
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendFloatingObjectToLastLine): It is enough to extend the float so
that it touches the bottom of the previous line, since RenderBlock::markLinesDirtyInBlockRange()
always dirties the line after the last one in the range.
2011-04-17 Patrick Gansterer <paroga@webkit.org>
Unreviewed. Add missing include to fix build without precompiled header.
* rendering/RenderMediaControls.cpp:
2011-04-17 Daniel Bates <dbates@webkit.org>
Attempt to fix the Chromium build after changeset 84110 <http://trac.webkit.org/changeset/84110>
(https://bugs.webkit.org/show_bug.cgi?id=57842).
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest): Rename CachedResource::LinkPrefetch to CachedResource::LinkResource.
2011-04-17 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Remove pthread dependency of GCController
https://bugs.webkit.org/show_bug.cgi?id=54833
* bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):
2011-04-17 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
Add support for link rel type "subresource"
https://bugs.webkit.org/show_bug.cgi?id=57842
Link rel=prefetch is great for cache warming for resources on
subsequent pages, but it launches requests at too low a priority
to use for subresources of the current page.
Particularly after https://bugs.webkit.org/show_bug.cgi?id=51940
is implemented, a rel type that launches requests at an higher
priority is going to be very useful. This rel type is in the
HTML5 spec at http://wiki.whatwg.org/wiki/RelExtensions . An
expected use case will be for servers to provide subresource hints
in link headers, which will allow servers to help make the web
faster.
This feature continues my implementation of the Link header, which
we've talked about in WebKit-dev in
https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html.
Tests: fast/dom/HTMLLinkElement/subresource.html
http/tests/misc/link-rel-prefetch-and-subresource.html
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::tokenizeRelAttribute):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::onloadTimerFired):
(WebCore::HTMLLinkElement::notifyFinished):
* html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
* loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::isLinkResource):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::incrementRequestCount):
(WebCore::CachedResourceLoader::decrementRequestCount):
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp:
(WebCore::cachedResourceTypeToTargetType):
(WebCore::CachedResourceRequest::load):
2011-04-17 Dan Bernstein <mitz@apple.com>
Reviewed by Joseph Pecoraro.
<rdar://problem/9296211> REGRESSION (r83514): Failing fast/repaint/trailing-floats-root-line-box-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=58745
This is really a regression from r82611, but it went unnoticed due to a mistake in r73385,
which was fixed in r83514.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Actually assign the bottom visual overflow to the
variable so named, not the top layout overflow.
2011-04-17 Geoffrey Garen <ggaren@apple.com>
Strongly suggested, but not necessarily reviewed, by
Sam Weinig and Maciej Stachowiak.
Renamed DOMObject* => JSDOMWrapper*.
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::isObservable):
(WebCore::DOMObjectHandleOwner::finalize):
* bindings/js/DOMWrapperWorld.h:
* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::toJSArrayBufferView):
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDOMBinding.h:
(WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
(WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::createDOMObjectWrapper):
(WebCore::getDOMObjectWrapper):
* bindings/js/JSDOMWrapper.cpp:
(WebCore::JSDOMWrapper::~JSDOMWrapper):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
(WebCore::toJS):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
2011-04-17 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Rename PLATFORM(CA) to USE(CA)
https://bugs.webkit.org/show_bug.cgi?id=58742
* config.h:
* platform/graphics/ca/TransformationMatrixCA.cpp:
* platform/graphics/cg/ImageBufferDataCG.h:
* platform/graphics/transforms/TransformationMatrix.h:
* platform/mac/WebCoreSystemInterface.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::containsPaintedContent):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
2011-04-17 Young Han Lee <joybro@company100.net>
Reviewed by Benjamin Poulain.
[Texmap] [Qt] Improve readability by using gInVertexAttributeIndex instead of 0.
https://bugs.webkit.org/show_bug.cgi?id=58739
gInVertexAttributeIndex is a constant variable to point the location of
"InVertex" attribute of the vertex shaders.
* platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::paintToTarget):
2011-04-17 Kinuko Yasuda <kinuko@chromium.org>
Not reviewed: Fix copyright (I had submitted the file with wrong
copyright line).
* storage/StorageInfo.idl:
2011-04-17 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
* config.h:
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toDataURL):
* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
* loader/cache/CachedFont.cpp:
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::createImage):
* platform/FloatConversion.h:
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):
* platform/graphics/BitmapImage.h:
* platform/graphics/Color.h:
* platform/graphics/DashArray.h:
* platform/graphics/FloatPoint.h:
* platform/graphics/FloatRect.h:
* platform/graphics/FloatSize.h:
* platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hash):
* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::add):
(WebCore::GlyphBuffer::expandLastAdvance):
* platform/graphics/Gradient.h:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setLegacyShadow):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextState::GraphicsContextState):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/Image.cpp:
* platform/graphics/Image.h:
* platform/graphics/ImageBuffer.cpp:
* platform/graphics/ImageBuffer.h:
* platform/graphics/ImageBufferData.h:
* platform/graphics/ImageSource.h:
* platform/graphics/IntPoint.h:
* platform/graphics/IntRect.h:
* platform/graphics/IntSize.h:
* platform/graphics/Path.h:
* platform/graphics/Pattern.h:
* platform/graphics/SimpleFontData.h:
* platform/graphics/cg/ColorCG.cpp:
* platform/graphics/cg/FloatPointCG.cpp:
* platform/graphics/cg/FloatRectCG.cpp:
* platform/graphics/cg/FloatSizeCG.cpp:
* platform/graphics/cg/ImageCG.cpp:
* platform/graphics/cg/ImageSourceCG.cpp:
* platform/graphics/cg/IntPointCG.cpp:
* platform/graphics/cg/IntRectCG.cpp:
* platform/graphics/cg/IntSizeCG.cpp:
* platform/graphics/cg/PDFDocumentImage.cpp:
* platform/graphics/cg/PDFDocumentImage.h:
* platform/graphics/cg/PathCG.cpp:
* platform/graphics/cg/TransformationMatrixCG.cpp:
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/PlatformCanvas.cpp:
(WebCore::PlatformCanvas::resize):
(WebCore::PlatformCanvas::AutoLocker::AutoLocker):
(WebCore::PlatformCanvas::Painter::Painter):
* platform/graphics/chromium/PlatformCanvas.h:
* platform/graphics/chromium/PlatformImage.cpp:
(WebCore::PlatformImage::updateFromImage):
* platform/graphics/opentype/OpenTypeUtilities.cpp:
* platform/graphics/transforms/AffineTransform.h:
* platform/graphics/transforms/TransformationMatrix.h:
* platform/graphics/win/DIBPixelData.h:
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::platformInit):
(WebCore::createGDIFont):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/win/GraphicsContextWin.cpp:
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
* platform/graphics/win/SimpleFontDataWin.cpp:
* platform/image-decoders/ImageDecoder.cpp:
* platform/image-decoders/ImageDecoder.h:
* rendering/RenderObject.h:
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):
* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/svg/RenderSVGResourceGradient.h:
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
2011-04-16 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
about:blank documents in new tabs can XHR anywhere
https://bugs.webkit.org/show_bug.cgi?id=58712
Empty security origins have supposed to be low-privilege, we should
mark them as having a unique origin.
* manual-tests/about-blank-xhr.html: Added.
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
* page/SecurityOrigin.h:
2011-04-16 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/9190108> Crash when hiding a float
Test: fast/block/float/overhanging-tall-block.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverhangingFloats): Moved the call to childLogicalTop() out of the loop.
Capped the logical bottom so that we get the correct maximum.
* rendering/RenderBlock.h: Decleared appendFloatingObjectToLastLine().
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendFloatingObjectToLastLine): Added. Ensures correct bookkeeping by
extending the float if needed so that it touches the line.
(WebCore::RenderBlock::layoutInlineChildren): Changed to call appendFloatingObjectToLastLine().
(WebCore::RenderBlock::checkFloatsInCleanLine): Capped the float height so the we mark the right
range of lines as dirty.
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::appendFloat): Replaced the floats() accessor with this function, which
allows the creation of the vector to be combined with appending the first float.
2011-04-16 Sam Weinig <sam@webkit.org>
Reviewed by Simon Fraser.
Pages in the PageCache don't have the correct visited link coloring after being restored
https://bugs.webkit.org/show_bug.cgi?id=58721
* WebCore.exp.in:
Add export of markPagesForVistedLinkStyleRecalc for use by WebKit2.
* history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):
* history/CachedPage.h:
(WebCore::CachedPage::markForVistedLinkStyleRecalc):
Add bit, set by calling markForVistedLinkStyleRecalc, which forces a visited link
style recalc when being restored.
* history/PageCache.h:
* history/PageCache.cpp:
(WebCore::PageCache::markPagesForVistedLinkStyleRecalc):
Mark all pages in the page cache as requiring visited link style recalc.
* page/PageGroup.cpp:
(WebCore::PageGroup::addVisitedLink):
(WebCore::PageGroup::removeVisitedLinks):
(WebCore::PageGroup::removeAllVisitedLinks):
Set dirty bit when changing any visited link information.
2011-04-16 Leo Yang <leoyang.webkit@gmail.com>
Reviewed by Nikolas Zimmermann.
ASSERT failure when svg <use> element changes href
https://bugs.webkit.org/show_bug.cgi?id=58726
m_resourceId was not empty after the pending resource
becomes available. This will trigger the assertion at
line 509 of SVGUseElement.cpp when the <use> element's
href becomes empty or invalid.
This patch makes m_resourceId be empty after the pending
resource becomes available to avoid assertion failure.
Test: svg/custom/use-crash-when-href-change.svg
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildPendingResource):
2011-04-16 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Rename PLATFORM(CAIRO) to USE(CAIRO)
https://bugs.webkit.org/show_bug.cgi?id=55192
* CMakeListsEfl.txt:
* config.h:
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypesForEncoding):
* platform/graphics/ContextShadow.h:
* platform/graphics/DashArray.h:
* platform/graphics/FloatRect.h:
* platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::isHashTableDeletedValue):
* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::glyphAt):
(WebCore::GlyphBuffer::add):
* platform/graphics/Gradient.cpp:
* platform/graphics/Gradient.h:
* platform/graphics/GraphicsContext.cpp:
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextState::GraphicsContextState):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/ImageBufferData.h:
* platform/graphics/ImageSource.h:
* platform/graphics/Path.h:
* platform/graphics/Pattern.h:
* platform/graphics/SimpleFontData.h:
* platform/graphics/cairo/DrawErrorUnderline.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
* platform/graphics/cairo/ImageCairo.cpp:
* platform/graphics/gstreamer/ImageGStreamer.h:
* platform/graphics/transforms/AffineTransform.h:
* platform/graphics/transforms/TransformationMatrix.h:
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::createGDIFont):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/win/GraphicsContextWin.cpp:
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintWindowedPluginIntoContext):
* rendering/RenderObject.h:
2011-04-16 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r84033.
* platform/win/LocalizedStringsWin.cpp:
(WebCore::localizedString):
2011-04-16 Abhishek Arya <inferno@chromium.org>
Reviewed by Nikolas Zimmermann.
Only allow inline child for SVG text since we cannot
handle block childs.
https://bugs.webkit.org/show_bug.cgi?id=58678
Test: svg/text/text-block-child-crash.xhtml
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::isChildAllowed):
* rendering/svg/RenderSVGText.h:
2011-04-15 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=57833
* inspector/Inspector.json:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::setFrontend):
(WebCore::InspectorDatabaseAgent::clearFrontend):
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::disable):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::executeSQL):
* inspector/InspectorDatabaseAgent.h:
* inspector/front-end/inspector.js:
2011-04-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP media-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58642
Yay HTMLMediaElement for having the exact hook we need!
Tests: http/tests/security/contentSecurityPolicy/media-src-allowed.html
http/tests/security/contentSecurityPolicy/media-src-blocked.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isSafeToLoadURL):
- Although it's tempting to add this branch to the previous
if-block, that results in the wrong error message being logged to
the console (covered by the "blocked" test).
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
- These changes are routine.
2011-04-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP should block string arguments to setTimeout and setInterval unless options eval-script
https://bugs.webkit.org/show_bug.cgi?id=58610
It's somewhat sadness that the JSC and V8 code for setTimeout and
setInterval are so different. I struggled for a while with how to
handle the worker case, but I decided to punt on it for now.
Tests: http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html
http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setTimeout):
(WebCore::JSDOMWindow::setInterval):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::setInterval):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
* bindings/js/ScheduledAction.h:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowEval):
* page/ContentSecurityPolicy.h:
2011-04-15 Shishir Agrawal <shishir@chromium.org>
Reviewed by James Robinson.
Add a flag to guard Page Visibility API changes.
https://bugs.webkit.org/show_bug.cgi?id=58464
* Configurations/FeatureDefines.xcconfig:
2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Martin Robinson.
Make plugins compile during WebKit GTK Windows build.
Ifdef properly relevant parts so that the PluginViewGtk compiles on Windows.
https://bugs.webkit.org/show_bug.cgi?id=58580
* plugins/PluginView.cpp:
(WebCore::PluginView::stop):
* plugins/PluginView.h:
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::platformStart):
2011-04-15 MORITA Hajime <morrita@google.com>
Reviewed by Simon Fraser.
Calls to WebCore::Document::mayCauseFlashOfUnstyledContent make frequently-run drawing methods slower
https://bugs.webkit.org/show_bug.cgi?id=58512
Manually rolled out r72367 at which mayCauseFlashOfUnstyledContent() was introduced.
This change keeps an small refactoring on
FrameView::shouldUpdate(), which doesn't affect on the behavior.
* dom/Document.cpp:
* dom/Document.h:
* page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::shouldUpdate):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintContents):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
2011-04-15 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Reduce default kernel size of SincResampler to favor better speed over quality
https://bugs.webkit.org/show_bug.cgi?id=58710
No new tests since audio API is not yet implemented.
* platform/audio/SincResampler.h:
2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Martin Robinson.
Expand the ntohs, ntohl, htons and htonl defines for OS(WINDOWS)
These have to be defined for Windows in general, since win32 API
does not provide them.
https://bugs.webkit.org/show_bug.cgi?id=58582
* platform/graphics/WOFFFileFormat.cpp:
2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Adam Barth.
Show a console message when X-Frame-Options blocks a load
https://bugs.webkit.org/show_bug.cgi?id=39087
Added console message when X-Frame-Options headers block resource loading
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse):
2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Martin Robinson.
Evaluate PLATFORM(GTK) before the all-encompassing OS(WINDOWS)
test. This allows Windows build of WebKit GTK to chose the right
path.
https://bugs.webkit.org/show_bug.cgi?id=58576
* platform/FileSystem.h:
2011-04-08 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QWebPage MIME type handling inconsistency with other web browsers
https://bugs.webkit.org/show_bug.cgi?id=46968
Implementing mime type sniffing based on
http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
* WebCore.pro:
* platform/network/MIMESniffing.cpp: Added.
(MagicNumbers::dataSizeNeededForImageSniffing):
(MagicNumbers::maskedCompare):
(MagicNumbers::checkSpaceOrBracket):
(MagicNumbers::compare):
(MagicNumbers::findMIMEType):
(MagicNumbers::findSimpleMIMEType):
(MagicNumbers::textOrBinaryTypeSniffingProcedure):
(MagicNumbers::unknownTypeSniffingProcedure):
(MagicNumbers::imageTypeSniffingProcedure):
(MagicNumbers::checkText):
(MagicNumbers::checkRDF):
(MagicNumbers::skipTag):
(MagicNumbers::feedTypeSniffingProcedure):
(MIMESniffer::MIMESniffer):
* platform/network/MIMESniffing.h: Added.
(MIMESniffer::dataSize):
(MIMESniffer::sniff):
(MIMESniffer::isValid):
* platform/network/NetworkingContext.h:
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::release):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType):
(WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyWrapper::advertisedMIMEType):
(WebCore::QNetworkReplyWrapper::mimeType):
* platform/network/qt/QtMIMETypeSniffer.cpp: Added.
(QtMIMETypeSniffer::QtMIMETypeSniffer):
(QtMIMETypeSniffer::sniff):
(QtMIMETypeSniffer::trySniffing):
* platform/network/qt/QtMIMETypeSniffer.h: Added.
(QtMIMETypeSniffer::mimeType):
(QtMIMETypeSniffer::isFinished):
2011-04-15 Emil A Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
input field with focus makes appendChild operation ~42x slower
https://bugs.webkit.org/show_bug.cgi?id=57059
Change ContainerNode::cloneChildNodes to only disable the
deleteButtonController if the container itself (or any of its children)
is being edited. Thus avoiding a reflow in cases where it's not.
Test: perf/clone-with-focus.html
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::cloneChildNodes):
2011-04-15 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Expose unified Quota API if QUOTA build flag is enabled
https://bugs.webkit.org/show_bug.cgi?id=58648
Test: storage/storageinfo-query-usage.html
* CMakeLists.txt: Added new file entries.
* DerivedSources.cpp: Added new file entries.
* DerivedSources.make: Added new file entries.
* GNUmakefile.am: Added new file entries.
* WebCore.gypi: Added new file entries.
* WebCore.vcproj/WebCore.vcproj: Added new file entries.
* WebCore.xcodeproj/project.pbxproj: Added new file entries.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitStorageInfo): Added.
* page/DOMWindow.h:
* page/DOMWindow.idl:
* storage/StorageInfo.h: Added storage type enum.
* storage/StorageInfo.idl: Added.
* storage/StorageInfoErrorCallback.idl: Added.
* storage/StorageInfoUsageCallback.idl: Added.
2011-04-15 Oliver Hunt <oliver@apple.com>
GC allocate Structure
https://bugs.webkit.org/show_bug.cgi?id=58483
Rolling r83894 r83827 r83810 r83809 r83808 back in with
a workaround for the gcc bug seen by the gtk bots
* WebCore.exp.in:
* bindings/js/JSAudioConstructor.h:
(WebCore::JSAudioConstructor::createStructure):
* bindings/js/JSDOMBinding.cpp:
(WebCore::cacheDOMStructure):
* bindings/js/JSDOMBinding.h:
(WebCore::DOMObjectWithGlobalPointer::createStructure):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
(WebCore::DOMConstructorObject::createStructure):
(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::markChildren):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::createStructure):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
* bindings/js/JSDOMWindowBase.h:
(WebCore::JSDOMWindowBase::createStructure):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::createStructure):
* bindings/js/JSDOMWrapper.h:
(WebCore::DOMObject::DOMObject):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
* bindings/js/JSImageConstructor.h:
(WebCore::JSImageConstructor::createStructure):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSOptionConstructor.h:
(WebCore::JSOptionConstructor::createStructure):
* bindings/js/JSWorkerContextBase.cpp:
(WebCore::JSWorkerContextBase::JSWorkerContextBase):
* bindings/js/JSWorkerContextBase.h:
(WebCore::JSWorkerContextBase::createStructure):
* bindings/js/ScriptCachedFrameData.h:
* bindings/js/SerializedScriptValue.h:
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::initScript):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/c/CRuntimeObject.h:
(JSC::Bindings::CRuntimeObject::createStructure):
* bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::createStructure):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaRuntimeMethod::createStructure):
* bridge/jni/jsc/JavaRuntimeObject.h:
(JSC::Bindings::JavaRuntimeObject::createStructure):
* bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::createStructure):
* bridge/objc/objc_instance.mm:
(ObjCRuntimeMethod::createStructure):
* bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::createStructure):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::createStructure):
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntimeObject::createStructure):
* bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMethod::createStructure):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::RuntimeArray):
* bridge/runtime_array.h:
(JSC::RuntimeArray::createStructure):
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::RuntimeMethod):
* bridge/runtime_method.h:
(JSC::RuntimeMethod::createStructure):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::RuntimeObject):
* bridge/runtime_object.h:
(JSC::Bindings::RuntimeObject::createStructure):
* history/HistoryItem.h:
2011-04-15 Jessie Berlin <jberlin@apple.com>
Reviewed by Brian Weinstein.
Hang underneath ApplicationCacheStorage::writeDataToUniqueFileInDirectory when loading
http://www.webkit.org/demos/calendar.
https://bugs.webkit.org/show_bug.cgi?id=58698
* platform/win/FileSystemWin.cpp:
(WebCore::openFile):
Add breaks to the case statement.
(WebCore::directoryName):
Remove any trailing slash in directoryName. After closer inspection of all callers, it
appears the that callers do not need the trailing slash, and those that use the length do
so only to change the direction of the slashes throughout the length of the path.
2011-04-15 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 52963 - Enable O(1) access to root from any node in shadow DOM subtree
https://bugs.webkit.org/show_bug.cgi?id=52963
.) Change base class of ShadowRoot from DocumentFragment to TreeScope.
.) Re-enable tree scope handling in Node (had ASSERT_NOT_REACHED, etc.).
.) Merged setTreeScope() with setTreeScopeRecursively()
.) Call setTreeScopeRecursively in DOM manipulation functions where applicable.
No new tests. (refactoring)
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::parserAddChild):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setDocType):
* dom/Element.h:
* dom/Node.cpp:
(WebCore::Node::treeScope):
(WebCore::Node::setTreeScopeRecursively):
* dom/Node.h:
(WebCore::Node::document):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::nodeType):
(WebCore::ShadowRoot::cloneNode):
(WebCore::ShadowRoot::childTypeAllowed):
* dom/ShadowRoot.h:
(WebCore::toShadowRoot):
* dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::setParentTreeScope):
* dom/TreeScope.h:
* rendering/RenderSlider.cpp:
2011-04-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
DOM object handles are never removed from cache
https://bugs.webkit.org/show_bug.cgi?id=58707
We were trying to remove hash table items by value instead of by key.
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::JSNodeHandleOwner::finalize): Changed to work more like
DOMObjectHandleOwner::finalize because I'm going to merge them.
(WebCore::DOMObjectHandleOwner::finalize): Remove hash table items
by key, not value. (Oops!) Use a helper function to make sure we get
this right.
* bindings/js/JSDOMBinding.cpp:
(WebCore::cacheDOMObjectWrapper): Store the hash table key as our weak
handle context, so we can use it at destruction time.
* bindings/js/JSDOMBinding.h: Removed unnecessary include.
* bindings/js/JSNodeCustom.h:
(WebCore::cacheDOMNodeWrapper): Store the hash table key as our weak
handle context, so we can use it at destruction time.
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::setWrapper): Forward context parameter, to
support the above.
2011-04-15 Kenneth Russell <kbr@google.com>
Unreviewed. Chromium Linux Release build fix due to unused variables.
* platform/audio/mkl/FFTFrameMKL.cpp:
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::cleanup):
2011-04-15 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build change after r83945.
New 'PlatformPathCairo.cpp' was not added to the WinCairo build.
* WebCore.vcproj/WebCore.vcproj: Add missing file to WinCairo
build. Exclude for standard Apple build.
2011-04-15 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Fade the find page overlay
https://bugs.webkit.org/show_bug.cgi?id=58697
Add a symbol that WebKit2 needs.
* WebCore.exp.in:
2011-04-15 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
RenderDetailsMarker should belong to shadow element.
https://bugs.webkit.org/show_bug.cgi?id=58591
- Introduced DetailsMarkerControl element, which is a shadow element of <summary>, creates RenderDetailsMarker.
- Removed custom layout code from RenderDetails, RenderDetailsMarker, which is now done by usual CSS layout.
Note that marker size is given via style for -webkit-details-marker pseudo class.
- Converted default summary implementation from pure-renderer style to shadow of HTMLDetailsElement.
Now RenderDetails knows nothing about default summary.
- Moved event handling code from HTMLDetailsElement to HTMLSummaryElement because now the marker is always child of
<summary>, and the clickable area is now <summary> itself.
- Note that the rendering result is changed due to the conversion from custom layout code to usual CSS styling.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/html.css:
(summary::-webkit-details-marker):
* dom/Element.cpp:
(WebCore::Element::attach):
* dom/Node.cpp:
(WebCore::shouldCreateRendererFor):
* dom/Node.h:
(WebCore::Node::canHaveLightChildRendererWithShadow):
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::findSummaryFor):
(WebCore::HTMLDetailsElement::findMainSummary):
(WebCore::HTMLDetailsElement::refreshMainSummary):
(WebCore::HTMLDetailsElement::createShadowSubtree):
(WebCore::HTMLDetailsElement::childrenChanged):
(WebCore::HTMLDetailsElement::finishParsingChildren):
(WebCore::HTMLDetailsElement::toggleOpen):
* html/HTMLDetailsElement.h:
(WebCore::HTMLDetailsElement::canHaveLightChildRendererWithShadow):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::create):
(WebCore::HTMLSummaryElement::createShadowSubtree):
(WebCore::HTMLSummaryElement::detailsElement):
(WebCore::HTMLSummaryElement::isMainSummary):
(WebCore::HTMLSummaryElement::defaultEventHandler):
* html/HTMLSummaryElement.h:
(WebCore::HTMLSummaryElement::canHaveLightChildRendererWithShadow):
* html/shadow/DetailsMarkerControl.cpp: Added.
(WebCore::DetailsMarkerControl::DetailsMarkerControl):
(WebCore::DetailsMarkerControl::createRenderer):
(WebCore::DetailsMarkerControl::rendererIsNeeded):
(WebCore::DetailsMarkerControl::shadowPseudoId):
(WebCore::DetailsMarkerControl::summaryElement):
* html/shadow/DetailsMarkerControl.h: Added.
(WebCore::DetailsMarkerControl::create):
* rendering/RenderDetails.cpp:
(WebCore::RenderDetails::RenderDetails):
(WebCore::RenderDetails::styleDidChange):
(WebCore::RenderDetails::moveSummaryToContents):
(WebCore::RenderDetails::checkMainSummary):
(WebCore::RenderDetails::layout):
* rendering/RenderDetails.h:
* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::RenderDetailsMarker):
(WebCore::RenderDetailsMarker::isOpen):
(WebCore::RenderDetailsMarker::getPath):
(WebCore::RenderDetailsMarker::paint):
(WebCore::RenderDetailsMarker::details):
* rendering/RenderDetailsMarker.h:
2011-04-15 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Implement localize strings for windows WebKit2
https://bugs.webkit.org/show_bug.cgi?id=58688
* platform/win/LocalizedStringsWin.cpp:
(WebCore::createWebKitBundle):
(WebCore::webKitBundle):
(WebCore::localizedString):
Add implementation of localizedString for Windows.
2011-04-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Some mechanical DOM wrapper cleanup
https://bugs.webkit.org/show_bug.cgi?id=58689
* WebCore.exp.in: Export!
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::isReachableFromDOM): Inverted the inDocument test to make the
relationship of the special cases to the normal case clearer.
* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::toJSArrayBufferView):
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDOMBinding.cpp:
(WebCore::getCachedDOMObjectWrapper):
(WebCore::cacheDOMObjectWrapper):
* bindings/js/JSDOMBinding.h:
(WebCore::createDOMObjectWrapper):
(WebCore::getDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):
(WebCore::getDOMNodeWrapper): Changed DOM wrapper functions to operate
in terms of DOMWrapperWorlds instead of ExecStates. This is clearer,
and ever-so-slightly faster.
Removed hasCachedXXX functions, now that they're unused.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
(WebCore::toJS):
* bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
* bindings/js/JSNodeCustom.h:
(WebCore::getCachedDOMNodeWrapper):
(WebCore::cacheDOMNodeWrapper):
(WebCore::toJS):
* bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS): Updated for changes above.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::dropProtection): Removed use of hasCachedDOMObjectWrapper
because XHR is almost always created and used by JavaScript, so it's
simpler to just always report extra cost.
2011-04-15 Andreas Kling <kling@webkit.org>
Rolling out accidental part of r84010.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::setButtonPadding):
2011-04-15 Oliver Hunt <oliver@apple.com>
Forgot windows build fix.
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
2011-04-15 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Yury Semikhatsky.
Frontend Part of Web Inspector: Remote Web Inspector - Cross Platform InspectorServer
https://bugs.webkit.org/show_bug.cgi?id=51364
The front end should not use a transparent background when
loaded as a web page (remote debugging) but should when loaded
regularly in a custom window. This adds a "remote" style class
onto the document body when the page is loaded remotely.
* inspector/front-end/inspector.css:
(body.detached.platform-mac-snowleopard:not(.remote) #toolbar): respect the "remote" class.
* inspector/front-end/inspector.js: add a "remote" class on the body when loaded remotely.
2011-04-15 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by David Kilzer.
JSLock ASSERT seen often when using the inspector for long
periods of time. We should take the JSLock whenever we
might allocate memory in the JavaScript Heap.
JSC InjectedScriptHost::nodeAsScriptValue should take JSLock before possible JavaScript Allocations
https://bugs.webkit.org/show_bug.cgi?id=58674
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::nodeAsScriptValue): take the JSLock.
2011-04-14 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make JSNodeFilterCondition handle its lifetime correctly
https://bugs.webkit.org/show_bug.cgi?id=58622
Switch over to a WeakHandle and external roots to keep the
condition value live.
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
(WebCore::JSNodeFilterCondition::markAggregate):
(WebCore::JSNodeFilterCondition::acceptNode):
(WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
* bindings/js/JSNodeFilterCondition.h:
(WebCore::JSNodeFilterCondition::create):
* bindings/js/JSNodeFilterCustom.cpp:
(WebCore::toNodeFilter):
* bindings/scripts/CodeGeneratorJS.pm:
2011-04-13 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QNetworkReplyHandler refactoring: some adjustments
https://bugs.webkit.org/show_bug.cgi?id=57092
- Removing flag m_redirected from QNetworkReplyHandler and using m_redirectionTargetUrl.isValid() instead.
- Moving flag m_responseContainsData from QNetworkReplyHandler to the reply wrapper and removing the connection of
signal metaDataChanged for m_responseContainsData to be consistent.
- Using an OwnPtr to keep the reference to the QNetworkReplyWrapper.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::didReceiveReadyRead):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::release):
(WebCore::shouldIgnoreHttpError):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::redirect):
(WebCore::QNetworkReplyHandler::forwardData):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyWrapper::responseContainsData):
(WebCore::QNetworkReplyWrapper::redirected):
2011-04-15 Alexey Proskuryakov <ap@apple.com>
Chromium build fix.
* platform/SecureTextInput.h: CARBON_SECURE_INPUT_MODE no longer exists.
2011-04-15 Mike Reed <reed@google.com>
Reviewed by Darin Fisher.
hide unused static function when SKIA_GPU is enabled
https://bugs.webkit.org/show_bug.cgi?id=58670
No new tests. Just fixes a warning (treated as an error) when SKIA_GPU is enabled
* platform/graphics/skia/ImageSkia.cpp:
2011-04-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Beth Dakin.
Some borders with border-radius do not have rounded inner edges
https://bugs.webkit.org/show_bug.cgi?id=58457
Improve the logic used to compute the inner radii on curved
borders, to maintain borders of even thickness around the curve.
Tests: fast/borders/mixed-border-styles-radius.html
fast/borders/mixed-border-styles.html
* rendering/RenderBoxModelObject.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computeBorderOuterRect):
(WebCore::RenderBoxModelObject::computeBorderInnerRect):
Two new utility functions to share some code that was in both paintBorder()
and paintBoxShaadow().
getRoundedInnerBorderWithBorderWidths() now takes the outer border box
as well as the inner box.
(WebCore::RenderBoxModelObject::paintBorder): Call new methods.
(WebCore::RenderBoxModelObject::paintBoxShadow): Ditto.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawBoxSideFromPath):
getRoundedInnerBorderWithBorderWidths() now takes the outer border box
as well as the inner box.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
* rendering/style/RenderStyle.h:
Compute the inner radii by starting with teh radii used for the
outer box, and then shrinking them down based on the border thickness.
2011-04-14 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
WebKit2: Password field input does not switch to ASCII-compatible source
https://bugs.webkit.org/show_bug.cgi?id=58583
<rdar://problem/9059651>
* platform/SecureTextInput.cpp:
(WebCore::enableSecureTextInput):
(WebCore::disableSecureTextInput):
This is now only used by Chromium. There is no need to change TSMDocument properties in
renderer process (and really, all secure text input logic in WebCore should be eliminated).
2011-04-13 Xiaomei Ji <xji@chromium.org>
Reviewed by Ryosuke Niwa.
Continue (3rd) experiment with moving caret by word in visual order.
https://bugs.webkit.org/show_bug.cgi?id=58294
This patch along with r82588 and r83483 implements moving caret by
word in visual order.
The overall algorithm is:
1. First get the InlineBox and offset of the pass-in VisiblePosition.
2. Based on the position (left boundary, middle, right boundary) of the offset and the
direction of the movement, look for visually adjacent word breaks.
2.1 If the offset is the minimum offset of the box,
return the rightmost word boundary in previous boxes if moving left.
return the leftmost word boundary in box and next boxes if moving right.
2.2 Similar for the case when offset is at the maximum offset of the box.
2.3 When offset is inside the box (not at boundaries), first find the previousWordPosition
or nextWordPosition based on the directionality of the box. If this word break position
is also inside the same box, return it. Otherwise (the nextWordPosition or
previousWordPosition is not in the same box or is at the box boundary), collect all the
word breaks in the box and search for the one closest to the input "offset" based on
box directionality, block directionality, and movement direction. Continue search in
adjacent boxes if needed.
Notes:
1. Word boundaries are collected one box at a time. Only when a boundary that is closest to
the input position (in the moving direction) is not available in current box, word
boundaries in adjacent box will be collected. So, there is no need to save InlineBox in
word boundaries. Instead, the word boundaries are saved as a pair
(VisiblePosition, offset) to avoid recomputing VisiblePosition.
2. We only collect boundaries of the right kind (i.e. left boundary of a word in LTR block
and right boundary of a word in RTL block). And word boundaries are collected using
previousWordPosition() and nextWordPosition(). So when box directionality is the same as
block directionality, word boundaries are collected from right to left visually in a LTR
box, and word boundaries are collected from left to right visually in a RTL box. It is
the other way around when box directionality is different from block directionality.
3. To find the right kinds of word boundaries, we must move back and forth between words
in some situations. For example, if we're moving to the right in a LTR box in LTR block,
we cannot simply return nextWordPosition() because it would return the right boundary
of a word. Instead, we return nextWordPosition()'s nextWordPosition()'s previousWordPosition().
4. When collecting word breaks inside a box, it first computes a start position, then
collect the right kind of word breaks until it reaches the end of (or beyond) the box.
In the meanwhile, it might need special handling on the rightmost or leftmost position
based on the directionality of the box and block. These computations do not consider the
box's bidi level.
* editing/visible_units.cpp:
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
(WebCore::collectWordBreaksInBox):
(WebCore::previousWordBoundaryInBox):
(WebCore::nextWordBoundaryInBox):
(WebCore::visuallyLastWordBoundaryInBox):
(WebCore::leftWordBoundary):
(WebCore::rightWordBoundary):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):
2011-04-14 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Use HTMLImageElement in Canvas 2D / WebGL before response is ready causes crash
https://bugs.webkit.org/show_bug.cgi?id=58501
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::texImage2D): Call validateHTMLImageElement().
(WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
(WebCore::WebGLRenderingContext::validateHTMLImageElement): Make sure image is ready.
* html/canvas/WebGLRenderingContext.h:
2011-04-07 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
DocumentMaker::AllMarkers should not be a part of DocumentMarker::MarkerType
https://bugs.webkit.org/show_bug.cgi?id=58112
- Converted DocumentMarker::MarkerTypes from unsigned int to a class.
- Converted DocumentMarker::AllMarkers from an enum entry to a subclass of MarkerTypes.
- Changed type of some MarkerType argument on DocumentMarkerController API to MarkerTypes
which should allow a combination of MarkerType constansts.
- Removed some MarkerType arguments on DocumentMarkerController API
which only received AllMarkers.
No new tests, no behavior change.
* WebCore.exp.in:
* dom/DocumentMarker.h:
(WebCore::DocumentMarker::MarkerTypes::MarkerTypes):
(WebCore::DocumentMarker::MarkerTypes::contains):
(WebCore::DocumentMarker::MarkerTypes::intersects):
(WebCore::DocumentMarker::MarkerTypes::operator==):
(WebCore::DocumentMarker::MarkerTypes::add):
(WebCore::DocumentMarker::MarkerTypes::remove):
(WebCore::DocumentMarker::AllMarkers::AllMarkers):
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::possiblyHasMarkers):
(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::copyMarkers):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::markersInRange):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::shiftMarkers):
(WebCore::DocumentMarkerController::setMarkersActive):
(WebCore::DocumentMarkerController::hasMarkers):
(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
* dom/DocumentMarkerController.h:
2011-04-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Complicated hash table is complicated
https://bugs.webkit.org/show_bug.cgi?id=58631
Now that we use the opaque roots system to track node wrapper lifetime,
we can remove a lot of complicated hash-tablery that used to do the same.
Now normal world node wrappers are just set as direct properties of
ScriptWrappable, while isolated world node wrappers and other DOM object
wrappers are stored in a shared, per-world hash table.
In addition to reducing complexity, this makes DOM wrapper allocation
1.6X faster (tested with scratch-gc-dom3.html), and it reduces the memory
footprint of normal world wrappers by ~2/3, and isolated world wrappers
by ~1/3.
* WebCore.exp.in: Paying the patch tithe.
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::clearWrappers): No more per-document hash tables.
(WebCore::JSNodeHandleOwner::finalize): Changed to call a helper function,
so the code to destroy a wrapper can live next to the code to create one.
* bindings/js/DOMWrapperWorld.h: No more per-document hash tables.
* bindings/js/JSDOMBinding.cpp:
(WebCore::uncacheDOMObjectWrapper):
* bindings/js/JSDOMBinding.h:
(WebCore::createDOMNodeWrapper):
(WebCore::getDOMNodeWrapper): No more per-document hash tables.
Added uncacheDOMObjectWrapper to be symmetrical with cacheDOMObjectWrapper.
* bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS):
* bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline): Ditto.
* bindings/js/JSNodeCustom.h:
(WebCore::getCachedDOMNodeWrapper):
(WebCore::cacheDOMNodeWrapper):
(WebCore::uncacheDOMNodeWrapper):
(WebCore::toJS): Implemented the scheme described above.
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::clearWrapper): ScriptWrappable needs a handle
owner now, since we don't have an extra handle living in a hash table
to maintain ownership for us.
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
* dom/Document.h:
* dom/Node.cpp:
(WebCore::Node::setDocument): No more per-document hash tables.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer): Removed call to
hasCachedDOMNodeWrapperUnchecked because that was the old way of doing
things, and I was in the mood for getting rid of the old way. It's
debatable whether the check was ever a good idea. Even when a <canvas>
doesn't have a direct JS wrapper, other JS references can still keep
the <canvas> alive. So, it's probably best always to report extra cost.
2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Rename rawRequestHeadersText and RawResponseHeadersText to requestHeadersText and responseHeadersText
https://bugs.webkit.org/show_bug.cgi?id=58650
* inspector/Inspector.json:
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForResourceResponse):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get requestHeadersText):
(WebInspector.Resource.prototype.set requestHeadersText):
(WebInspector.Resource.prototype.get requestHeadersSize):
(WebInspector.Resource.prototype.get responseHeadersText):
(WebInspector.Resource.prototype.set responseHeadersText):
(WebInspector.Resource.prototype.get responseHeadersSize):
(WebInspector.Resource.prototype._headersSize):
* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView):
(WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle):
(WebInspector.ResourceHeadersView.prototype._refreshHeadersText):
(WebInspector.ResourceHeadersView.prototype._toggleRequestHeadersText):
(WebInspector.ResourceHeadersView.prototype._toggleResponseHeadersText):
(WebInspector.ResourceHeadersView.prototype._createHeadersToggleButton):
* inspector/front-end/networkPanel.css:
(.resource-headers-view .outline-disclosure li.headers-text):
* platform/network/ResourceLoadInfo.h:
2011-04-15 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Implement css overflow properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=58633
No new tests required as no functionality changes.
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Add initializers for CSSPropertyOverflowX, CSSPropertyOverflowY and CSSPropertyOverflow.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Delete existing implementations.
2011-04-15 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Make mac WebKit1 use the default localization strategy
https://bugs.webkit.org/show_bug.cgi?id=58628
* English.lproj/Localizable.strings:
Update by running update-webkit-localizable-strings.
* platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
(WebCore::DefaultLocalizationStrategy::keygenKeychainItemName):
(WebCore::DefaultLocalizationStrategy::imageTitle):
Match the WebKit1 versions of these functions by special casing CF platforms.
2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: No console message and headers in inspector when X-Frame-Options header blocks a load
https://bugs.webkit.org/show_bug.cgi?id=58136
Passed response info to inspector when X-Frame-Options header blocks resource loading.
Test: http/tests/inspector/network/x-frame-options-deny.html
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDeniedImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse):
2011-04-15 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: TextViewer and TextEditorModel must support both \n and \r\n as line separators
https://bugs.webkit.org/show_bug.cgi?id=58449
Test: inspector/editor/text-editor-model.html
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel):
(WebInspector.TextEditorModel.prototype.get text):
(WebInspector.TextEditorModel.prototype.setText):
(WebInspector.TextEditorModel.prototype._innerSetText):
(WebInspector.TextEditorModel.prototype.copyRange):
2011-04-15 Sergey Vorobyev <sergeyvorobyev@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Network events don't preserves,
when inspector frontend closed and open again
https://bugs.webkit.org/show_bug.cgi?id=58064
Added InspectorFrontendProxy and EventsCollector.
They allow captured messages from InspectorResourceAgent
to frontend (or mockFrontend if frontend disabled) and
push collected data when frontend reconnect.
This functionality is disabled by default.
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/EventsCollector.cpp: Added.
(WebCore::EventsCollector::EventsCollector):
(WebCore::EventsCollector::addEvent):
(WebCore::EventsCollector::sendCollectedEvents):
* inspector/EventsCollector.h: Added.
(WebCore::EventsCollector::~EventsCollector):
* inspector/Inspector.json:
* inspector/InspectorFrontendProxy.cpp: Added.
(WebCore::InspectorFrontendProxy::InspectorFrontendProxy):
(WebCore::InspectorFrontendProxy::setInspectorFrontendChannel):
(WebCore::InspectorFrontendProxy::setEventsCollector):
(WebCore::InspectorFrontendProxy::sendMessageToFrontend):
* inspector/InspectorFrontendProxy.h: Added.
(WebCore::InspectorFrontendProxy::~InspectorFrontendProxy):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::loadEventFiredImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willSendRequest):
(WebCore::InspectorInstrumentation::willReceiveResourceResponse):
(WebCore::InspectorInstrumentation::didReceiveContentLength):
(WebCore::InspectorInstrumentation::didFinishLoading):
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
(WebCore::InspectorInstrumentation::frameDetachedFromParent):
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::setFrontend):
(WebCore::InspectorResourceAgent::resourceContent):
(WebCore::InspectorResourceAgent::~InspectorResourceAgent):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::domContentEventFired):
(WebCore::InspectorResourceAgent::loadEventFired):
(WebCore::InspectorResourceAgent::enabledBackgoundEventsCoollection):
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.domContentEventFired):
(WebInspector.NetworkDispatcher.prototype.loadEventFired):
* inspector/front-end/inspector.js:
(WebInspector.domContentEventFired):
(WebInspector.loadEventFired):
2011-04-15 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Dimitri Glazkov.
REGRESSION(r83397) [Qt] When clicking on the media elements they grow 2 pixels.
https://bugs.webkit.org/show_bug.cgi?id=58477
Since r83397 the media controls elements are actual DOM elements.
Therefore the global style-sheet applies to them. html.css defines
input[type="button"]:active to be border-style: inset which means
that when the buttons are active they grow by their border size. Therefore
ports which are not using the borders must explicitly disable them in their custom
stylesheet.
* css/mediaControlsQt.css:
(audio::-webkit-media-controls-mute-button):
(video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button):
(video::-webkit-media-controls-play-button):
(video::-webkit-media-controls-fullscreen-button):
* css/mediaControlsQuickTime.css:
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
(audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
2011-04-15 Zelidrag Hornung <zelidrag@chromium.org>
Reviewed by Darin Fisher.
Added enums for external file system type.
https://bugs.webkit.org/show_bug.cgi?id=58456
* fileapi/DOMFileSystemBase.cpp:
(WebCore::DOMFileSystemBase::crackFileSystemURL):
* fileapi/DOMFileSystemBase.h:
* fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURL):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::requestFileSystem):
* page/DOMWindow.h:
* platform/AsyncFileSystem.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::requestFileSystem):
(WebCore::WorkerContext::requestFileSystemSync):
* workers/WorkerContext.h:
2011-04-15 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: make resource revisions use dedicated type (not Resource clone).
https://bugs.webkit.org/show_bug.cgi?id=58659
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.setStyleSheetText):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.addRevision):
(WebInspector.Resource.prototype._innerRequestContent.onResourceContent):
(WebInspector.Resource.prototype._innerRequestContent):
(WebInspector.ResourceRevision):
(WebInspector.ResourceRevision.prototype.get resource):
(WebInspector.ResourceRevision.prototype.get timestamp):
(WebInspector.ResourceRevision.prototype.get content):
(WebInspector.ResourceRevision.prototype.revertToThis):
(WebInspector.ResourceRevision.prototype.requestContent.mycallback):
(WebInspector.ResourceRevision.prototype.requestContent):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.resourceViewTypeMatchesResource):
(WebInspector.ResourceView.resourceViewForResource):
(WebInspector.ResourceView.recreateResourceView):
(WebInspector.ResourceView.existingResourceViewForResource):
(WebInspector.RevisionSourceFrame):
(WebInspector.RevisionSourceFrame.prototype.get resource):
(WebInspector.RevisionSourceFrame.prototype.isContentEditable):
(WebInspector.RevisionSourceFrame.prototype.requestContent):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._showResourceView):
(WebInspector.ResourcesPanel.prototype._showRevisionView):
(WebInspector.ResourcesPanel.prototype._fetchAndApplyDiffMarkup.step1):
(WebInspector.ResourcesPanel.prototype._fetchAndApplyDiffMarkup.step2):
(WebInspector.ResourcesPanel.prototype._fetchAndApplyDiffMarkup):
(WebInspector.ResourceRevisionTreeElement):
(WebInspector.ResourceRevisionTreeElement.prototype.get itemURL):
(WebInspector.ResourceRevisionTreeElement.prototype.onselect):
(WebInspector.ResourceRevisionTreeElement.prototype._ondragstart):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._ensureContentLoaded):
(WebInspector.SourceFrame.prototype.requestContent):
(WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
(WebInspector.SourceFrame.prototype.commitEditing):
2011-04-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Prevent Backspace keypresses from routing into the inspected page
https://bugs.webkit.org/show_bug.cgi?id=58653
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
2011-04-15 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Ryosuke Niwa.
Text selection changes unexpectedly when dragging out of the <input>
https://bugs.webkit.org/show_bug.cgi?id=55552
Tests: editing/selection/select-out-of-editable.html
editing/selection/select-out-of-floated-contenteditable.html
editing/selection/select-out-of-floated-input.html
editing/selection/select-out-of-floated-textarea.html
* page/EventHandler.cpp:
(WebCore::selectionExtentRespectingEditingBoundary): When dragging from an editable element, check that
the endpoint is not outside the element. If it is, translate the point into a local point within
the editable element.
(WebCore::EventHandler::updateSelectionForMouseDrag): Call targetPositionForSelectionEndpoint() to
calculate the selection endpoint.
2011-04-15 Adam Roben <aroben@apple.com>
Roll out r83954
It was causing fast/dom/Window/timer-null-script-execution-context.html to crash on multiple
bots.
See <http://webkit.org/b/58610>.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setTimeout):
(WebCore::JSDOMWindow::setInterval):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::setInterval):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
* bindings/js/ScheduledAction.h:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
* page/ContentSecurityPolicy.cpp:
* page/ContentSecurityPolicy.h:
2011-04-15 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: refactor resource setContent / revisions infrastructure to get
rid of onRevert callback.
https://bugs.webkit.org/show_bug.cgi?id=58649
Instead, we will have DomainModel/Resource binding responsible for changing
underlying model upon resource changes and vice versa.
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):
* inspector/InspectorCSSAgent.h:
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged):
(WebInspector.CSSStyleModel.prototype.setStyleSheetText):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setText.callback):
(WebInspector.CSSProperty.prototype.setDisabled.callback):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.prototype.setText):
(WebInspector.CSSStyleModelResourceBinding):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._frameNavigated):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerSetContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._loadStyleSheetHeaders):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource):
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
(WebInspector.DebuggerPresentationModelResourceBinding):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
* inspector/front-end/Object.js:
(WebInspector.Object.prototype.hasEventListeners):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.registerDomainModelBinding):
(WebInspector.Resource.prototype.isEditable):
(WebInspector.Resource.prototype.setContent):
(WebInspector.Resource.prototype.addRevision):
(WebInspector.Resource.prototype.revertToThis.callback):
(WebInspector.Resource.prototype.revertToThis):
(WebInspector.ResourceDomainModelBinding):
(WebInspector.ResourceDomainModelBinding.prototype.canSetContent):
(WebInspector.ResourceDomainModelBinding.prototype.setContent):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.createResourceView):
(WebInspector.ResourceView.resourceViewTypeMatchesResource):
(WebInspector.ResourceSourceFrame.prototype.isContentEditable):
(WebInspector.ResourceSourceFrame.prototype.editContent):
(WebInspector.ResourceSourceFrame.prototype.endEditing):
(WebInspector.ResourceSourceFrame.prototype._clearIncrementalUpdateTimer):
(WebInspector.ResourceSourceFrame.prototype._requestContent):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._resourceAdded):
(WebInspector.FrameResourceTreeElement):
(WebInspector.FrameResourceTreeElement.prototype._populateRevisions):
(WebInspector.FrameResourceTreeElement.prototype._revisionAdded):
(WebInspector.FrameResourceTreeElement.prototype._appendRevision):
* inspector/front-end/inspector.html:
2011-04-15 Andrey Kosyakov <caseq@chromium.org>
Unreviewed, rolling out r83949.
http://trac.webkit.org/changeset/83949
https://bugs.webkit.org/show_bug.cgi?id=57960
broke 31 tests in chromium win & linux
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::drawTexturedRect):
* platform/graphics/chromium/GLES2Canvas.h:
* platform/graphics/gpu/Texture.cpp:
(WebCore::copySubRect):
(WebCore::Texture::load):
(WebCore::Texture::updateSubRect):
* platform/graphics/gpu/Texture.h:
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
2011-04-15 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
Fix building with Sun Studio 12: function pointers for extern "C" are treated differently
https://bugs.webkit.org/show_bug.cgi?id=58508
Since extern "C" makes a different type (although most compilers ignore that),
we should be more careful when passing NPAPI callback functions.
* plugins/npapi.cpp:
(NPN_PluginThreadAsyncCall):
2011-04-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP should block string arguments to setTimeout and setInterval unless options eval-script
https://bugs.webkit.org/show_bug.cgi?id=58610
It's somewhat sadness that the JSC and V8 code for setTimeout and
setInterval are so different. I struggled for a while with how to
handle the worker case, but I decided to punt on it for now.
Tests: http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html
http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setTimeout):
(WebCore::JSDOMWindow::setInterval):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::setInterval):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
* bindings/js/ScheduledAction.h:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowEval):
* page/ContentSecurityPolicy.h:
2011-04-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add support for CSP's 'self' source
https://bugs.webkit.org/show_bug.cgi?id=58604
This change is now trivially easy.
Test: http/tests/security/contentSecurityPolicy/script-src-self.html
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPSourceList::addSourceSelf):
2011-04-15 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Renaming TRACK feature define to VIDEO_TRACK
https://bugs.webkit.org/show_bug.cgi?id=53556
No new tests. No new functionality.
* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* features.pri:
* html/HTMLTagNames.in:
* html/HTMLTrackElement.cpp:
* html/HTMLTrackElement.h:
* html/HTMLTrackElement.idl:
2011-04-14 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Ctrl+Left/Right switch panels during live editing
https://bugs.webkit.org/show_bug.cgi?id=58521
Disable Ctrl+Left/Right keyboard shortcuts while in live edit.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.readOnlyStateChanged):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.set readOnly):
(WebInspector.TextViewer.prototype.get readOnly):
(WebInspector.TextViewer.prototype._doubleClick):
(WebInspector.TextViewer.prototype._commitEditing.didCommitEditing):
(WebInspector.TextViewer.prototype._commitEditing):
(WebInspector.TextViewer.prototype._cancelEditing):
(WebInspector.TextViewerDelegate.prototype.readOnlyStateChanged):
(WebInspector.TextEditorMainPanel.prototype.set readOnly):
* inspector/front-end/inspector.js:
(WebInspector.markBeingEdited):
(WebInspector.isEditingAnyField):
(WebInspector.startEditing.cleanUpAfterEditing):
2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Enable raw HTTP headers support
https://bugs.webkit.org/show_bug.cgi?id=58259
Added raw headers text support to inspector.
* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForResourceResponse):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.get transferSize):
(WebInspector.Resource.prototype.set requestHeaders):
(WebInspector.Resource.prototype.get rawRequestHeadersText):
(WebInspector.Resource.prototype.set rawRequestHeadersText):
(WebInspector.Resource.prototype.get requestHeadersSize):
(WebInspector.Resource.prototype.set responseHeaders):
(WebInspector.Resource.prototype.get rawResponseHeadersText):
(WebInspector.Resource.prototype.set rawResponseHeadersText):
(WebInspector.Resource.prototype.get responseHeadersSize):
(WebInspector.Resource.prototype._headersSize):
* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView):
(WebInspector.ResourceHeadersView.prototype._refreshParms):
(WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle):
(WebInspector.ResourceHeadersView.prototype._refreshHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshRawHeadersText):
(WebInspector.ResourceHeadersView.prototype._toggleRawRequestHeadersText):
(WebInspector.ResourceHeadersView.prototype._toggleRawResponseHeadersText):
(WebInspector.ResourceHeadersView.prototype._createToggleButton):
(WebInspector.ResourceHeadersView.prototype._createHeadersToggleButton):
* inspector/front-end/networkPanel.css:
(.resource-headers-view .outline-disclosure li .header-toggle):
(.resource-headers-view .outline-disclosure li.expanded .header-toggle):
(.resource-headers-view .outline-disclosure li .header-toggle:hover):
(.resource-headers-view .outline-disclosure li.raw-headers-text):
* platform/network/ResourceLoadInfo.h:
2011-04-14 Justin Novosad <junov@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Accelerated 2D Canvas is slow to execute putImageData
https://bugs.webkit.org/show_bug.cgi?id=57960
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::drawTexturedRect):
Added an option for using the blend ops for alpha multiplication
instead of compositing.
(WebCore::GLES2Canvas::applyClipping):
(WebCore::GLES2Canvas::putImageData):
New method for drawing raw pixel data from memory to the canvas
(WebCore::GLES2Canvas::putUnmultipliedImageData):
Wrapper for putImageData
(WebCore::GLES2Canvas::putPremultipliedImageData):
Wrapper for putImageData
* platform/graphics/chromium/GLES2Canvas.h:
* platform/graphics/gpu/Texture.cpp:
(WebCore::copySubRect):
(WebCore::Texture::load):
(WebCore::Texture::updateSubRect):
Added an overload of the updateSubRect method that can receive a pixel
of a size that is different from texture size. Improved the performance
of updateSubrect by avoiding the allocation of a temporary buffer when
not required.
* platform/graphics/gpu/Texture.h:
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
In the unmultiplied path, division by alpha now performs proper
rounding in order to avoid generational degradation with putImageData
(WebCore::putImageData):
Alpha multiplication now performs proper rounding in order to be
consistent with the hardware rendering path: OpenGL always rounds when
converting to fixed point representation.
(WebCore::ImageBuffer::putUnmultipliedImageData):
Now supports a hardware rendering path, which eliminates the need
for a readback from the GPU
(WebCore::ImageBuffer::putPremultipliedImageData):
Now supports a hardware rendering path, which eliminates the need
for a readback from the GPU
2011-04-14 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
Creating a CairoPath instance is not thread safe
https://bugs.webkit.org/show_bug.cgi?id=58514
This patch allows a cairo surface to be created just one time in order to
guarantee thread safety.
In addition, CairoPath.{h,cpp} is renamed to PlatformPathCairo.{h,cpp} to
prevent confusing them with PathCairo.cpp
* CMakeListsEfl.txt: Added PlatformPathCairo.cpp
* GNUmakefile.list.am: Added PlatformPathCairo.{h,cpp} instead of CairoPath.h.
* platform/graphics/cairo/CairoPath.h: Removed.
* platform/graphics/cairo/CairoUtilities.cpp: Include PlatformPathCairo.h instead of CairoPath.h.
* platform/graphics/cairo/GraphicsContextCairo.cpp: Ditto.
* platform/graphics/cairo/PathCairo.cpp: Ditto.
* platform/graphics/cairo/PlatformPathCairo.cpp: Added.
(WebCore::getPathSurface): Getting a static cairo surface.
(WebCore::CairoPath::CairoPath): Moved the implementation of the constructor
into the CPP file.
* platform/graphics/cairo/PlatformPathCairo.h: Renamed CairoPath.h to this.
(WebCore::CairoPath::~CairoPath):
(WebCore::CairoPath::context):
2011-04-14 Nat Duca <nduca@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add lowpass filter and graph to fps indicator
https://bugs.webkit.org/show_bug.cgi?id=58186
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::onPresent):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
2011-04-14 Beth Dakin <bdakin@apple.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=58612
Crash switching overlay/non-overlay scrollbar preference
(WebCore::Page::setNeedsRecalcStyleInAllFrames + 9)
-and corresponding-
<rdar://problem/9241920>
Speculative fix: Page could definitely be null here.
* page/FrameView.cpp:
(WebCore::FrameView::scrollbarStyleChanged):
2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size
https://bugs.webkit.org/show_bug.cgi?id=58447
FrameLoader now takes encoded data length for synchronous requests from the field with the same name.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
* platform/network/ResourceLoadInfo.h:
(WebCore::ResourceLoadInfo::ResourceLoadInfo):
2011-04-14 Alok Priyadarshi <alokp@chromium.org>
Reviewed by James Robinson.
Remove dependency on chromium skia::PlatformCanvas
https://bugs.webkit.org/show_bug.cgi?id=57563
This patch does not change any functionality, just the type of object skia::PlatformCanvas -> SkCanvas. The object is still being created by a factory method skia::CreateBitmapCanvas defined in Chromium. We will eventually define an API that every port using skia will define.
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::Font::drawComplexText):
* platform/graphics/chromium/ImageBufferDataSkia.h:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/PlatformCanvas.cpp:
(WebCore::PlatformCanvas::resize):
* platform/graphics/chromium/PlatformCanvas.h:
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::compositeTextComposite):
(WebCore::TransparencyWin::makeLayerOpaque):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setCanvas):
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
* platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::canvas):
(WebCore::PlatformContextSkia::printing):
(WebCore::PlatformContextSkia::setPrinting):
2011-04-14 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
PumpSession should not call currentTime() in the constructor
https://bugs.webkit.org/show_bug.cgi?id=55211
currentTime() is expensive. So we avoid calling it in the constructor
and instead set startTime on the first check for a yield
(which in the synchronous case never happens, and in the yielding
case will happen immediately after the first token due to
processedTokens being set to INT_MAX).
This ended up being a large win on (my local copy of)
peacekeeper's domDynamicCreationCreateElement:
Before:
avg 366.3333333333333
median 366
stdev 2.712112747574399
min 362
max 377
After:
avg 345.96666666666664
median 346
stdev 1.6829207415152454
min 343
max 349
* html/parser/HTMLDocumentParser.cpp:
* html/parser/HTMLParserScheduler.h:
(WebCore::PumpSession::PumpSession):
(WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
2011-04-14 Ami Fischman <fischman@google.com>
Reviewed by Eric Carlson.
Remove unnecessary bottom margin of controls in video elements on media documents.
This makes the cases of media documents and non-media documents consistent,
and makes it possible to reason about the height of a rendered media document
(needed e.g. for sizing iframes).
This change is covered by (the currently Skipped, but soon-to-be-un-Skipped)
media/video-controls-in-media-document.html layouttest (see bug 54634 for
the un-Skipping).
https://bugs.webkit.org/show_bug.cgi?id=58442
* css/mediaControls.css:
(video:-webkit-full-page-media::-webkit-media-controls-panel):
* css/mediaControlsEfl.css:
(video:-webkit-full-page-media::-webkit-media-controls-panel):
* css/mediaControlsQuickTime.css:
(video:-webkit-full-page-media::-webkit-media-controls-panel):
2011-04-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Use opaque roots instead of direct marking for nodes in the DOM
https://bugs.webkit.org/show_bug.cgi?id=58624
A node treats the root of its tree (usually the document) as its opaque
root during GC.
This is needed for correctness in a generational GC world, but it also
happens to be a 3.5X speedup in a DOM-heavy GC test (scratch-gc-dom2.html).
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::isObservable):
(WebCore::isReachableFromDOM): Moved a helper function from JSDOMBinding.
We use this function to determine whether a node is observable.
(WebCore::JSNodeHandleOwner::isReachableFromOpaqueRoots): Start using
our weak handle callback to determine reachability, instead of direct
marking traversal through the DOM.
* bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::markChildren): Updated to use the opaque roots mechanism
instead of direct marking.
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h: Moved code mentioned above. Removed
markDOMNodeWrapper because it is now unused. This is a good thing because
markDOMNodeWrapper used deprecatedAppend, which is not compatible
with generational GC.
* bindings/js/JSDOMImplementationCustom.cpp:
(WebCore::JSDOMImplementation::markChildren): Updated to use opaque roots.
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::markChildren): No need to mark our child nodes directly,
since they will take care of themselves through the opaque roots mechanism.
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::markChildren): Updated to use opaque roots.
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren): No need to mark our tree or our document
directly, since they will take care of themselves through the opaque
roots mechanism.
* bindings/js/JSNodeCustom.h:
(WebCore::root): Helper function for accessing the root of a node tree.
This is O(1) while you're in the document, O(log(N)) when you're in a
reasonably balanced disconnected tree, and O(N) in the pathological case
of a disconnected tree that's shaped like a linked list. If average case
O(long(N)) turns out to be too slow, we can optimize through use of
rare data or an external hash table, but it is so uncommon that I have
ignored it for now.
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::markChildren): Updated to use opaque roots.
2011-04-14 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
fix shadows with gradients
https://bugs.webkit.org/show_bug.cgi?id=58376
No new tests. Existing tests exercise this
LayoutTests/fast/canvas/canvas-fillPath-gradient-shadow.html
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: No headers information in network panel for downloads.
https://bugs.webkit.org/show_bug.cgi?id=58139
Passed resource response to inspector for PolicyDownload and PolicyIgnore requests.
Test: http/tests/inspector/network/download.html
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveResourceResponseButCanceledImpl):
(WebCore::InspectorInstrumentation::continueWithPolicyDownloadImpl):
(WebCore::InspectorInstrumentation::continueWithPolicyIgnoreImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::continueWithPolicyDownload):
(WebCore::InspectorInstrumentation::continueWithPolicyIgnore):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::continueAfterContentPolicy):
2011-04-14 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
Convert use of raw pointers to RefPtr in using Cairo
https://bugs.webkit.org/show_bug.cgi?id=57717
No new tests added becaue of just replacing raw pointers with smart pointers.
* platform/graphics/cairo/ContextShadowCairo.cpp: Use a RefPtr<cairo_surface_t> instead of raw pointer.
(WebCore::purgeScratchBuffer):
(WebCore::getScratchBuffer):
* platform/graphics/cairo/ImageBufferCairo.cpp: Use a RefPtr<cairo_t> instead of raw pointer.
(copySurface):
2011-04-14 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Eric Seidel.
[Chromium]Change menu list background fallback value to transparent to work background:none for HTML select tag.
https://bugs.webkit.org/show_bug.cgi?id=57818
Test: fast/forms/select-background-none.html
This fix is only for Chromium on Linux. Chromium on Mac already works fine.
But Windows has the same problem. This change doesn't include Windows part.
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::RenderThemeChromiumLinux::paintMenuList): Change the default color to transparent.
2011-04-14 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Implement border style css properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=58506
No new functionality added.
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Added new property initializers.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Removed old property handlers.
2011-04-14 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Ojan Vafai.
Presence of shadow DOM should suppress rendering of ordinary child nodes
https://bugs.webkit.org/show_bug.cgi?id=58073
Test: fast/dom/shadow/no-renderers-for-light-children.html
* dom/Node.cpp:
(WebCore::shadowRoot): Added a helper function.
(WebCore::Node::setDocumentRecursively): Changed to use the helper.
(WebCore::shouldCreateRendererFor): Expanded a long condition check into a helper function,
added a check for children of an element with a shadow DOM.
(WebCore::Node::createRendererAndStyle): Changed to use the helper.
2011-04-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Tile content and image layers
https://bugs.webkit.org/show_bug.cgi?id=57113
Layers tile by default if any dimension is larger than 512. Smaller
layers are contained within a single texture but still use the tiler
infrastructure so that there's only one code path.
Remove large layer support from content layers. Content layers no
longer own a platform canvas--they own a tiler. Refactor tiler to
allow for better separation of update/upload/paint. Add rect
parameter to update and draw functions on layers for the layer-space
rect of interest. This is necessary to know which tiles need to be
drawn.
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::~ContentLayerChromium):
(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerPainter::paint):
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::setLayerRenderer):
(WebCore::ContentLayerChromium::tilingTransform):
(WebCore::ContentLayerChromium::visibleLayerRect):
(WebCore::ContentLayerChromium::layerBounds):
(WebCore::ContentLayerChromium::updateLayerSize):
(WebCore::ContentLayerChromium::draw):
(WebCore::ContentLayerChromium::createTilerIfNeeded):
(WebCore::ContentLayerChromium::updateCompositorResources):
(WebCore::ContentLayerChromium::setTilingOption):
(WebCore::ContentLayerChromium::bindContentsTexture):
(WebCore::ContentLayerChromium::unreserveContentsTexture):
(WebCore::ContentLayerChromium::setIsMask):
(WebCore::ContentLayerChromium::dumpLayerProperties):
* platform/graphics/chromium/ContentLayerChromium.h:
(WebCore::ContentLayerChromium::drawsContent):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setMaskLayer):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::updateCompositorResources):
(WebCore::ImageLayerChromium::layerBounds):
(WebCore::ImageLayerChromium::tilingTransform):
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::invalidateRect):
(WebCore::LayerChromium::paintContentsIfDirty):
(WebCore::LayerChromium::setIsMask):
(WebCore::LayerChromium::draw):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintContentsRecursive):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::setTileSize):
(WebCore::LayerTilerChromium::getSingleTexture):
(WebCore::LayerTilerChromium::invalidateRect):
(WebCore::LayerTilerChromium::update):
(WebCore::LayerTilerChromium::uploadCanvas):
(WebCore::LayerTilerChromium::updateFromPixels):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::unreserveTextures):
* platform/graphics/chromium/LayerTilerChromium.h:
(WebCore::LayerTilerChromium::setLayerRenderer):
(WebCore::LayerTilerChromium::skipsDraw):
* platform/graphics/chromium/PlatformCanvas.cpp:
(WebCore::PlatformCanvas::AutoLocker::AutoLocker):
(WebCore::PlatformCanvas::Painter::Painter):
* platform/graphics/chromium/PlatformCanvas.h:
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::draw):
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::draw):
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
* platform/graphics/chromium/cc/CCPluginLayerImpl.h:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
2011-04-14 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
[chromium] REGRESSION(83820): Composited scrollbar layers sometimes not positioned when initially creating frame
https://bugs.webkit.org/show_bug.cgi?id=58575
Tell the RenderLayerCompositor to create/destroy composited layers for overflow controls on a FrameView when visibleContentsResized()
is called, not contentsResized() so that we always update layers when adding or removing scrollbars.
Covered by several chromium pixel tests.
* page/FrameView.cpp:
(WebCore::FrameView::contentsResized):
(WebCore::FrameView::visibleContentsResized):
2011-04-07 David Levin <levin@chromium.org>
Reviewed by Brady Eidson.
Fix some threading issues in IconDatabase.
https://bugs.webkit.org/show_bug.cgi?id=57985
No functionality change so no new tests. It would be very hard to test this, but
I am working on a change for bug 31639 to detect these (which makes layout tests
fail for at least one of these issues).
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::setIconDataForIconURL): Release imageData so that it won't get deref'ed outside of locks.
(WebCore::IconDatabase::readFromDatabase): Ditto.
(WebCore::IconDatabase::writeToDatabase): Acquire m_urlAndIconLock because the SharedBuffer<> data
is used, and this lock seems to be the one which consistently guards it.
2011-04-14 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
Simplifying Worker termination sequence (removing unnecessary mutex)
https://bugs.webkit.org/show_bug.cgi?id=57090
No new tests. Existing Worker tests should pass.
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
Check for Terminator-caused exception (or Terminator::shouldTerminate since sometimes
JS might not run significant enough chunk to be terminated by Terminator) and set
the flag to forbid future reentry into JS.
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::scheduleExecutionTermination):
(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::isExecutionForbidden):
* bindings/js/WorkerScriptController.h:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::scheduleExecutionTermination):
(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::isExecutionForbidden):
* bindings/v8/WorkerScriptController.h:
(WebCore::WorkerScriptController::proxy):
Symmetrical changes to JSC and V8 WorkerScriptControllers:
- remove Mutex around operations with executionForbidden flag.
- set/check that flag only on Worker thread.
- some renaming in attempt to better reflect what the methods do.
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):
(WebCore::V8AbstractEventListener::invokeEventHandler):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
Check for v8::TryCatch::CanContinue() and set forbidExecution flag.
This result indicates that TerminateExecution() was in effect - we should
not reenter V8 anymore after that.
* dom/Document.h:
(WebCore::Document::isJSExecutionForbidden):
* dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
Stop dispatching messages once the worker context started to close.
Per Workers spec, once WorkerGlobalScope.Close() is called, the next
JS execution does not happen, including onmessage events. Before this
change, Close() was setting the forbidExecution flag, indirectly stopping
events from dispatching.
* dom/ScriptExecutionContext.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::close):
(WebCore::WorkerContext::isJSExecutionForbidden):
* workers/WorkerContext.h:
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):
2011-04-14 Beth Dakin <bdakin@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=56493
Drag-scrolling overlay scrollbars thumb in overflow regions does not work
-and corresponding-
<rdar://problem/9112688>
There was an original change to fix this in the normal hit-testing case, but hit
testing of transformed and/or positioned objects was still broken. The transformed
case is fixed by sending an OverlayScrollbarSizeRelevancy parameter to
calculateRects(). Getting positioned objects right is a little trickier. Those need
to opt into using temporary clip rects during hit testing. To avoid doing that when
it is not necessary, I added a new bit to ScrollView to track whether there are
currently overlay scrollbars painted in the view.
* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(WebCore::ScrollView::containsScrollableAreaWithOverlayScrollbars):
(WebCore::ScrollView::setContainsScrollableAreaWithOverlayScrollbars):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::backgroundClipRect):
(WebCore::RenderLayer::calculateRects):
* rendering/RenderLayer.h:
2011-04-14 Antti Koivisto <antti@apple.com>
Reviewed by Oliver Hunt.
REGRESSION(r74107): Including svg format in @font-face rules makes Web Fonts fail to load
https://bugs.webkit.org/show_bug.cgi?id=57766
<rdar://problem/9232183>
Move the knowledge of whether to interpret a font as SVG from CachedFont to CSSFontFaceSource. This way
we can try to interpret the same cached resource in multiple ways.
Test: fast/css/font-face-repeated-url.html
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData):
* css/CSSFontFaceSource.h:
(WebCore::CSSFontFaceSource::setHasExternalSVGFont):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::ensureSVGFontData):
Use TextResourceDecoder correctly.
(WebCore::CachedFont::getSVGFontById):
* loader/cache/CachedFont.h:
* svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::loadFont):
2011-04-14 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Enable building Web Audio with MKL in Chrome-branded builds
https://bugs.webkit.org/show_bug.cgi?id=58561
Factored out MKL support into a separate GYP file that is
incorporated in Chrome-branded builds. Changed how the FFTFrame
implementations are pulled in and chosen so that all files can be
unconditionally compiled.
Tested with both Chrome-branded build (incorporating MKL) and
Chromium build (building just FFTFrameStub.cpp) on Linux.
* WebCore.gyp/WebCore.gyp:
* platform/audio/fftw/FFTFrameFFTW.cpp:
* platform/audio/mkl/FFTFrameMKL.cpp:
2011-04-14 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Reviewed by Antonio Gomes.
[Qt] Web Inspector does not highlight elements
https://bugs.webkit.org/show_bug.cgi?id=35125
We should call drawNodeHighlight() just if a highlighted node exists
to avoid do save()/restore() on the Graphics Context unnecessarily.
Added highlightedNode() method to check if we need to call drawNodeHighlight()
and only on this case do save()/restore() on the Graphics Context.
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::highlightedNode):
2011-04-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] TilingData should return 1 tile when tile size is texture size.
https://bugs.webkit.org/show_bug.cgi?id=58364
* platform/graphics/gpu/TilingData.cpp:
(WebCore::computeNumTiles):
2011-04-14 Andy Estes <aestes@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r72141): Acid3 rendering is not pixel perfect.
https://bugs.webkit.org/show_bug.cgi?id=55734
WebCore should render text with a 0px font size at 0px regardless of
minimum font size settings. This is compatible with other browsers that
have a minimum font size preference and ensures pixel-perfect rendering
on Acid3.
Test: fast/text/zero-font-size.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): If
specifiedSize is 0, return specified size regardless of zoom factor or
minimum font size.
2011-04-14 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Have canvas drawImageFromRect just redirect to use drawImage
https://bugs.webkit.org/show_bug.cgi?id=58516
Test: fast/canvas/drawImageFromRect_withToDataURLAsSource.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
* html/canvas/CanvasRenderingContext2D.h:
2011-04-14 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=58535
Change PLATFORM(MAC) guards to !PLATFORM(CHROMIUM) so they apply correctly to the windows build.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresScrollCornerLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::shouldCompositeOverflowControls):
2011-04-14 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
BlobBuilder should be vendor-prefixed
https://bugs.webkit.org/show_bug.cgi?id=58518
Renamed BlobBuilder to WebKitBlobBuilder.
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* fileapi/WebKitBlobBuilder.cpp: Renamed from Source/WebCore/fileapi/BlobBuilder.cpp.
(WebCore::WebKitBlobBuilder::WebKitBlobBuilder):
(WebCore::WebKitBlobBuilder::getBuffer):
(WebCore::WebKitBlobBuilder::append):
(WebCore::WebKitBlobBuilder::getBlob):
* fileapi/WebKitBlobBuilder.h: Renamed from Source/WebCore/fileapi/BlobBuilder.h.
(WebCore::WebKitBlobBuilder::create):
* fileapi/WebKitBlobBuilder.idl: Renamed from Source/WebCore/fileapi/BlobBuilder.idl.
* page/DOMWindow.idl:
* workers/WorkerContext.idl:
2011-04-14 Adam Barth <abarth@webkit.org>
Remove some trailing whitespace. I'm making this change to initialize
the SVN credentials on a new commit-queue machine. I'm sure there's a
better way to do this, but I don't know it.
* dom/Document.cpp:
(WebCore::Document::Document):
2011-04-14 Pratik Solanki <psolanki@apple.com>
Reviewed by David Kilzer.
Set minimum priority for fast lane connections
https://bugs.webkit.org/show_bug.cgi?id=58353
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Call
wkSetHTTPPipeliningMinimumFastLanePriority to allow javascript resources to use the fast
lane connections.
2011-04-14 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Fix Web Audio build on Linux Debug and with stub FFTFrame
https://bugs.webkit.org/show_bug.cgi?id=58555
Built Chromium/Linux in Debug mode to test.
* platform/audio/FFTFrame.cpp:
* platform/audio/FFTFrameStub.cpp:
(WebCore::FFTFrame::initialize):
* webaudio/AudioContext.cpp:
* webaudio/DefaultAudioDestinationNode.cpp:
2011-04-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: add initial implementation of WorkerScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=58552
* bindings/v8/DebuggerScript.js:
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): each worker context
now have a debug id (similar to frame contexts).
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::retrieveWorkerContext):
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause): run message loop until
debugger command is received and execution is resumed.
(WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
* bindings/v8/WorkerScriptDebugServer.h:
* inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
(WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
2011-04-14 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
Add webkit prefix to Blob.slice method and change its semantics to be
like Array.slice
https://bugs.webkit.org/show_bug.cgi?id=58496
Renamed Blob.slice to blob.webkitSlice and made it take start and end
parameters that're like Array.slice.
Test: fast/files/blob-slice-test.html
* fileapi/Blob.cpp:
(WebCore::Blob::webkitSlice):
* fileapi/Blob.h:
* fileapi/Blob.idl:
2011-04-14 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Height of "Ahem" font differs from all other ports.
https://bugs.webkit.org/show_bug.cgi?id=57954
QFontMetricsF::descent() returns the actual descent minus 1,
to account for the baseline. Add it back to get correct metrics
for WebKit.
QFontMetricsF::leading() may return negative values on some
platforms (those using FreeType), this breaks WebKit's assumption
that lineSpacing >= (ascent + descent), so we work around this in
the same fashion as SimpleFontDataFreeType and SimpleFontDataPango.
This is covered by thousands of layout tests.
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformInit):
2011-04-14 Kevin Ollivier <kevino@theolliviers.com>
[wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
* platform/graphics/wx/FontPlatformDataWx.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/wx/FileSystemWx.cpp:
(WebCore::writeToFile):
2011-04-14 Anders Carlsson <andersca@apple.com>
Fix build.
RuntimeApplicationChecks.h needs to be a private header so WebKit can find it.
* WebCore.xcodeproj/project.pbxproj:
2011-04-14 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, build fix for r83864.
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._childNodeRemoved):
2011-04-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Content area highlight does not cover scrollbars
https://bugs.webkit.org/show_bug.cgi?id=58528
* inspector/DOMNodeHighlighter.cpp:
(WebCore::DOMNodeHighlighter::DrawNodeHighlight):
2011-04-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: re-implement dom breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=57038
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/BreakpointManager.js: Removed.
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.NativeBreakpointsSidebarPane):
(WebInspector.NativeBreakpointsSidebarPane.prototype._reset):
(WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype.setStatus):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
* inspector/front-end/DOMBreakpointsSidebarPane.js: Added.
(WebInspector.DOMBreakpointsSidebarPane):
(WebInspector.DOMBreakpointsSidebarPane.prototype.setInspectedURL):
(WebInspector.DOMBreakpointsSidebarPane.prototype.populateNodeContextMenu.toggleBreakpoint):
(WebInspector.DOMBreakpointsSidebarPane.prototype.populateNodeContextMenu):
(WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage.didPushNodeToFrontend):
(WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage):
(WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage.formatters.s):
(WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage.append):
(WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage):
(WebInspector.DOMBreakpointsSidebarPane.prototype.nodeRemoved):
(WebInspector.DOMBreakpointsSidebarPane.prototype._removeBreakpointsForNode):
(WebInspector.DOMBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.DOMBreakpointsSidebarPane.prototype._removeBreakpoint):
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint):
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):
(WebInspector.DOMBreakpointsSidebarPane.prototype._checkboxClicked):
(WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.DOMBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
(WebInspector.DOMBreakpointsSidebarPane.prototype._createBreakpointId):
(WebInspector.DOMBreakpointsSidebarPane.prototype._saveBreakpoints):
(WebInspector.DOMBreakpointsSidebarPane.prototype.restoreBreakpoints):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.show):
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.coalesceCollapsedCrumbs):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.show):
(WebInspector.ScriptsPanel.prototype._debuggerPaused.didCreateBreakpointHitStatusMessage):
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._clearInterface):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
(WebInspector.Settings.prototype._set):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.inspectedURLChanged):
* inspector/front-end/utilities.js:
():
2011-04-14 Satish Sampath <satish@chromium.org>
Reviewed by Kent Tamura.
Disable speech input for readonly and disabled input fields.
https://bugs.webkit.org/show_bug.cgi?id=58540
Test: fast/speech/input-readonly-and-disabled.html
* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Rollout r83849 and r83857.
* inspector/Inspector.json:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::setFrontend):
(WebCore::InspectorDatabaseAgent::clearFrontend):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::executeSQL):
* inspector/InspectorDatabaseAgent.h:
* inspector/front-end/inspector.js:
2011-04-14 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r83847.
http://trac.webkit.org/changeset/83847
https://bugs.webkit.org/show_bug.cgi?id=58477
Chromium media controls do use button borders, so this change
is incorrect.
* css/mediaControls.css:
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
(audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
2011-04-14 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by Andreas Kling.
Fix GraphicsContext3DQt.cpp compilation warnings treated as errors
https://bugs.webkit.org/show_bug.cgi?id=58478
No new tests.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::getProcAddress):
Do not use deprecated QString constructor to avoid warning.
(WebCore::GraphicsContext3D::reshape):
Use parenthesis to avoid warning.
2011-04-14 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Removed ScrollableArea::paintScrollCorner() added in r83820,
as it breaks chromium clang build (shadowed by RenderLayer::paintScrollCorner()
with a different signature)
* platform/ScrollableArea.h:
2011-04-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Ready to move detailed heap snapshots storage and processing into workers.
https://bugs.webkit.org/show_bug.cgi?id=58534
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _countPercent):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.idsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.nodeFieldValuesByIndex):
(WebInspector.HeapSnapshot.prototype._numbersComparator):
(WebInspector.HeapSnapshot.prototype.baseSnapshotHasNode):
(WebInspector.HeapSnapshot.prototype.updateBaseNodeIds):
(WebInspector.HeapSnapshotsDiff):
(WebInspector.HeapSnapshotsDiff.prototype.set baseIds):
(WebInspector.HeapSnapshotsDiff.prototype.set baseSelfSizes):
(WebInspector.HeapSnapshotsDiff.prototype.calculate):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy):
(WebInspector.HeapSnapshotProxy.prototype.createDiff):
(WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createNodesProvider):
(WebInspector.HeapSnapshotProxy.prototype.dispose):
(WebInspector.HeapSnapshotProxy.prototype.nodeFieldValuesByIndex):
(WebInspector.HeapSnapshotProxy.prototype.pushBaseIds):
(WebInspector.HeapSnapshotsDiffProxy):
(WebInspector.HeapSnapshotsDiffProxy.prototype.calculate):
(WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds):
(WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=57833
* inspector/Inspector.json:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::setFrontend):
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::disable):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::executeSQL):
* inspector/InspectorDatabaseAgent.h:
* inspector/front-end/inspector.js:
2011-04-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] "Remove Breakpoint" menu item is absent in the DOM breakpoints sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=58530
* inspector/front-end/ElementsPanel.js:
2011-04-14 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Dimitri Glazkov.
REGRESSION(r83397) [Qt] When clicking on the media elements they
grow 2 pixels.
https://bugs.webkit.org/show_bug.cgi?id=58477
Since r83397 the media controls elements are actual DOM elements.
Therefore the global style-sheet applies to them. html.css defines
input[type="button"]:active to be border-style: inset which means
that when the buttons are active they grow by their border size.
* css/mediaControls.css:
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
(audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
2011-04-14 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Improve disable style for input elements in mobile theme
https://bugs.webkit.org/show_bug.cgi?id=58480
* platform/qt/QtMobileWebStyle.cpp:
(QtMobileWebStyle::drawControl):
(QtMobileWebStyle::drawPrimitive):
(QtMobileWebStyle::drawComplexControl):
2011-04-14 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: restore previous selection in Resources panel upon front-end reopen.
https://bugs.webkit.org/show_bug.cgi?id=58533
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._processCachedResources):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._initDefaultSelection):
(WebInspector.ResourcesPanel.prototype._populateResourceTree):
(WebInspector.ResourcesPanel.prototype._cachedResourcesLoaded):
* inspector/front-end/inspector.css:
(#close-button-left, #close-button-right):
2011-04-14 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: implement incremental CSS free flow editing.
https://bugs.webkit.org/show_bug.cgi?id=58529
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleSheet.prototype.setText):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.isResourceRevision):
(WebInspector.Resource.prototype.setContent):
* inspector/front-end/ResourceView.js:
(WebInspector.CSSSourceFrame.prototype.isContentEditable):
(WebInspector.CSSSourceFrame.prototype.editContent):
(WebInspector.CSSSourceFrame.prototype.endEditing.commitIncrementalEdit):
(WebInspector.CSSSourceFrame.prototype.endEditing):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype.editContent):
2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector:Duplicated display of storage db when running Web SQL from an iframe.
https://bugs.webkit.org/show_bug.cgi?id=57830
There was created a new InspectorDatabaseResource entry for every didOpenDatabase event.
Moreover there is new WebCore::Database for each didOpenDatabase event.
I decided to change the old instance of the Database to a new one if they both use the same file.
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::findByFileName):
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDatabaseResource.h:
(WebCore::InspectorDatabaseResource::setDatabase):
2011-04-14 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg crashes in Debug build
https://bugs.webkit.org/show_bug.cgi?id=58525
A renderer is created even for those filter primitives
which parent is not a filter. A rendererIsNeeded() is
added to SVGFilterPrimitiveStandardAttributes.
Test: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
* svg/SVGFilterPrimitiveStandardAttributes.h:
2011-04-14 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
REGRESSION(r83397) [Qt] When the video is loading and the poster is shown
all the controls are not visible except the play button.
https://bugs.webkit.org/show_bug.cgi?id=58484
r83397 introduces a new API hasOwnDisabledStateHandlingFor to handle when
the controls should be disabled. Qt port paints its own controls, we don't want
the default implementation to handle the hidden/disable state for us.
Existing tests covers the visibility of the controls.
* platform/qt/RenderThemeQt.h:
(WebCore::RenderThemeQt::hasOwnDisabledStateHandlingFor):
2011-04-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Disabled form controls don't actually look disabled.
https://bugs.webkit.org/show_bug.cgi?id=58490
Unsetting QStyle::State_Enabled is not enough to get the "disabled" appearance
when painting controls. We must also set the QStyleOption's palette's current
color group.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::initializeCommonQStyleOptions):
2011-04-14 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Benjamin Poulain.
[Qt] MediaPlayerPrivateQt::supportsType does not parse codec parameter
https://bugs.webkit.org/show_bug.cgi?id=58188
The codec parameter in MediaPlayerPrivateQt::supportsType was not parsed into
a QStringList. This change parses and trims the list.
An additional test was added to video-can-play-type.html to test parsing of codec parameter.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::supportsType):
2011-04-14 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Nikolas Zimmermann.
Optimizing lightning filter to ARM-NEON SIMD instruction set
https://bugs.webkit.org/show_bug.cgi?id=54456
NEON is the SIMD instruction set for ARM. This instruction set
allows to speed-up the lighting filter by 4 times on ARM
(on WebCore/manual-tests/svg-filter-animation.svg).
* WebCore.pri:
* WebCore.pro:
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::drawLighting):
(WebCore::getPowerCoefficients):
(WebCore::FELighting::drawInteriorPixels):
* platform/graphics/filters/FELighting.h:
* platform/graphics/filters/arm/FELightingNEON.cpp: Added.
(__attribute__):
* platform/graphics/filters/arm/FELightingNEON.h: Added.
2011-04-14 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Benjamin Poulain.
[Qt] GraphicsContext3D internal buffers are not freed
https://bugs.webkit.org/show_bug.cgi?id=57530
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
2011-04-14 Andy Estes <aestes@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION (r75555): Safari RSS sidebar jiggles when scrolling
https://bugs.webkit.org/show_bug.cgi?id=52988
Safari RSS relies on synchronous dispatch of ScrollEvent to update the
position of its sidebar during scrolling without producing a jiggling
effect. Due to r75555, this event is no longer dispatched synchronously
which results in stale repaints before the onscroll handler gets a
chance to update the position of the sidebar.
Since it is impractical to resolve this issue in Safari RSS itself, add
a quirk that restores synchronous ScrollEvent dispatch for Safari RSS.
No tests. This is an app-specific change that doesn't affect web
content.
* Android.mk: Add platform/RuntimeApplicationChecks.[cpp|h]
* CMakeLists.txt: Ditto.
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* dom/EventQueue.cpp:
(WebCore::shouldDispatchScrollEventSynchronously): Send ScrollEvent
synchronously if the embedding application is Safari and the document's
URL scheme is "feed" or "feeds".
(WebCore::EventQueue::enqueueOrDispatchScrollEvent): Dispatch
ScrollEvent synchronously if shouldDispatchScrollEventSynchronously()
returns true.
* dom/EventQueue.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::sendScrollEvent): Call enqueueOrDispatchScrollEvent().
* platform/RuntimeApplicationChecks.cpp: Added.
(WebCore::mainBundleIsEqualTo): Add a helper routine for CF platforms
that checks if the main bundle's identifier is equal to a given string.
This function returns false for non-CF platforms.
(WebCore::applicationIsSafari): Call mainBundleIsEqualTo().
(WebCore::applicationIsAppleMail): Ditto.
(WebCore::applicationIsMicrosoftMessenger): Ditto.
(WebCore::applicationIsAdobeInstaller): Ditto.
(WebCore::applicationIsAOLInstantMessenger): Ditto.
(WebCore::applicationIsMicrosoftMyDay): Ditto.
(WebCore::applicationIsMicrosoftOutlook): Ditto.
* platform/mac/RuntimeApplicationChecks.mm: Removed. Functions moved to
RuntimeApplicationChecks.cpp.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo): Call enqueueOrDispatchScrollEvent().
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollTo): Call enqueueOrDispatchScrollEvent().
2011-04-14 John Bates <jbates@google.com>
Reviewed by Kenneth Russell.
Fix bug with adding wrong context to LayerRendererChromium and get rid of RefPtr loop.
https://bugs.webkit.org/show_bug.cgi?id=58383
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::addChildContext):
(WebCore::LayerRendererChromium::removeChildContext):
* platform/graphics/chromium/LayerRendererChromium.h:
2011-04-14 Renata Hodovan <reni@webkit.org>
Reviewed by Nikolas Zimmermann.
CSS related SVG*Element changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=56906
The changes of some CSS related SVGFilter properties e.g. lighting_color, flood_color, flood_opacity
need only repaint. To avoid the default invalidation of filters in SVGResourceCache::clientStyleChange()
we need an early return. So RenderSVGResourceFilterPrimitive::styleDidChange() can handle these properties
via RenderSVGResourceFilter::primitiveAttributeChanged() the same way like we do it for the other SVGAttributes.
Tests: svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html
svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html
svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html
* platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::setFloodColor):
(WebCore::FEFlood::setFloodOpacity):
* platform/graphics/filters/FEFlood.h:
* platform/graphics/filters/FESpecularLighting.cpp:
(WebCore::FESpecularLighting::setLightingColor):
* platform/graphics/filters/FESpecularLighting.h:
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):
* rendering/svg/RenderSVGResourceFilterPrimitive.h:
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientStyleChanged):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
* svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::setFilterEffectAttribute):
* svg/SVGFEFloodElement.h:
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
2011-04-13 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Allow setting composited backing stores for scrollbars and scroll corners
https://bugs.webkit.org/show_bug.cgi?id=57202
This teaches ScrollableArea to manage GraphicsLayer backings for the two scrollbars and
scroll corner. ScrollableArea can position the layers and route invalidation and paint calls to
the correct place but depends on subclasses to manage the lifetime of the GraphicsLayers and
place them into the correct place in the hierarchy.
FrameView and RenderLayerCompositor updated to provide layers for frames with overflow controls.
that need them. The overflow control layers are siblings of the frame's clip layer.
RenderLayer and RenderLayerBacking updated to provide overflow control layers for layers that
need them. Currently, layers are only created for overflow controls on layers that are already composited
for other reasons and not necessarily for every RenderLayer with overflow. Overflow control layers are siblings
of the RenderLayerBacking's clipping layer if it exists, otherwise they are siblings of the layer's normal
children.
Tested by a number of compositing/ tests that have scrollbars and by these new tests:
compositing/iframes/repaint-after-losing-scrollbars.html
compositing/overflow/clip-content-under-overflow-controls.html
compositing/overflow/content-gains-scrollbars.html
compositing/overflow/content-loses-scrollbars.html
compositing/overflow/overflow-scrollbar-layers.html
compositing/overflow/repaint-after-losing-scrollbars.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
* page/FrameView.cpp:
(WebCore::FrameView::layerForHorizontalScrollbar):
(WebCore::FrameView::layerForVerticalScrollbar):
(WebCore::FrameView::layerForScrollCorner):
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::contentsResized):
(WebCore::FrameView::updateScrollCorner):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollbar):
(WebCore::ScrollableArea::invalidateScrollCorner):
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::paintScrollCorner):
(WebCore::ScrollableArea::layerForHorizontalScrollbar):
(WebCore::ScrollableArea::layerForVerticalScrollbar):
(WebCore::ScrollableArea::layerForScrollCorner):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::invalidateRect):
* platform/Scrollbar.h:
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::setViewport):
(WebCore::LayerRendererChromium::updateAndDrawLayers):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::setRootLayer):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPartAnimation setCurrentProgress:]):
* platform/win/PopupMenuWin.h:
(WebCore::PopupMenuWin::invalidateScrollCornerRect):
(WebCore::PopupMenuWin::isScrollCornerVisible):
(WebCore::PopupMenuWin::scrollCornerRect):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollCornerRect):
(WebCore::RenderLayer::scrollCornerAndResizerRect):
(WebCore::RenderLayer::isScrollCornerVisible):
(WebCore::RenderLayer::invalidateScrollbarRect):
(WebCore::RenderLayer::invalidateScrollCornerRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::layerForHorizontalScrollbar):
(WebCore::RenderLayer::layerForVerticalScrollbar):
(WebCore::RenderLayer::layerForScrollCorner):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::horizontalScrollbar):
(WebCore::RenderLayer::verticalScrollbar):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::updateAfterWidgetResize):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateInternalHierarchy):
(WebCore::RenderLayerBacking::updateClippingLayers):
(WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresScrollCornerLayer):
(WebCore::RenderLayerBacking::updateOverflowControlsLayers):
(WebCore::paintScrollbar):
(WebCore::RenderLayerBacking::paintContents):
* rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::layerForHorizontalScrollbar):
(WebCore::RenderLayerBacking::layerForVerticalScrollbar):
(WebCore::RenderLayerBacking::layerForScrollCorner):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::frameViewDidChangeLocation):
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::rootPlatformLayer):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::paintScrollbar):
(WebCore::RenderLayerCompositor::paintContents):
(WebCore::shouldCompositeOverflowControls):
(WebCore::RenderLayerCompositor::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerCompositor::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerCompositor::requiresScrollCornerLayer):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
(WebCore::RenderLayerCompositor::destroyRootPlatformLayer):
(WebCore::RenderLayerCompositor::detachRootPlatformLayer):
* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::layerForHorizontalScrollbar):
(WebCore::RenderLayerCompositor::layerForVerticalScrollbar):
(WebCore::RenderLayerCompositor::layerForScrollCorner):
* rendering/RenderListBox.h:
(WebCore::RenderListBox::isScrollCornerVisible):
(WebCore::RenderListBox::scrollCornerRect):
(WebCore::RenderListBox::invalidateScrollCornerRect):
2011-04-13 Cary Clark <caryclark@chromium.org>
Reviewed by Eric Seidel.
[Chromium] allow concurrent Skia and CG datatypes
https://bugs.webkit.org/show_bug.cgi?id=57848
The Chromium port is experimenting with running Skia as the WebKit rendering engine, and CoreGraphics
as the UI rendering engine. This permits Chromium to unify its graphics story while leveraging OS X to
draw elements like scrollbars and buttons.
Restructure the common graphics units, points, and rectangles, to convert to Sk-types and CG-types at
the same time. This requires only adding to the existing preprocessor commands, and will have no effect
on any existing platform.
Eventually, WTF_USE_SKIA_ON_MAC_CHROME will be defined to enable this, but for now, there's no
functional change.
No new tests as this provides no new functionality.
* platform/graphics/FloatPoint.h: Add USE(SKIA_ON_MAC_CHROME) to make CG type and operators visible
to a Skia-based Chrome Mac build.
* platform/graphics/FloatRect.h: Ditto.
* platform/graphics/FloatSize.h: Ditto.
* platform/graphics/IntPoint.h: Ditto.
* platform/graphics/IntRect.h: Ditto.
* platform/graphics/IntSize.h: Ditto.
* platform/graphics/cg/FloatPointCG.cpp: Ditto.
* platform/graphics/cg/FloatRectCG.cpp: Ditto.
* platform/graphics/cg/FloatSizeCG.cpp: Ditto.
* platform/graphics/cg/IntPointCG.cpp: Ditto.
* platform/graphics/cg/IntRectCG.cpp: Ditto.
* platform/graphics/cg/IntSizeCG.cpp: Ditto.
2011-04-13 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 58460 - childTypeAllowed() should be const
https://bugs.webkit.org/show_bug.cgi?id=58460
Made childTypeAllowed const.
No new tests. (minor refactoring).
* dom/Attr.cpp:
(WebCore::Attr::childTypeAllowed):
* dom/Attr.h:
* dom/CDATASection.cpp:
(WebCore::CDATASection::childTypeAllowed):
* dom/CDATASection.h:
* dom/Comment.cpp:
(WebCore::Comment::childTypeAllowed):
* dom/Comment.h:
* dom/Document.cpp:
(WebCore::Document::childTypeAllowed):
* dom/Document.h:
* dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::childTypeAllowed):
* dom/DocumentFragment.h:
* dom/Element.cpp:
(WebCore::Element::childTypeAllowed):
* dom/Element.h:
* dom/Node.h:
(WebCore::Node::childTypeAllowed):
* dom/Notation.cpp:
(WebCore::Notation::childTypeAllowed):
* dom/Notation.h:
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::childTypeAllowed):
* dom/ProcessingInstruction.h:
* dom/Text.cpp:
(WebCore::Text::childTypeAllowed):
* dom/Text.h:
2011-04-13 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION(r81880): Paste menu is disabled for many edit fields (yahoo and google search, yahoo mail msg, forms, etc)
https://bugs.webkit.org/show_bug.cgi?id=58284
<rdar://problem/9246149>
* WebCore.exp.in: Exporting EditingBehavior.h for use in WebKit2
* editing/EditingBehavior.h:
(WebCore::EditingBehavior::shouldClearSelectionWhenLosingWebPageFocus): moving the platform-specific code out of an #ifdef and into this class for run-time instead of compile-time checking
2011-04-13 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
constructLine should take bidiRuns as a parameter
https://bugs.webkit.org/show_bug.cgi?id=58458
Pass bidiRuns to constructLine and move reachedEndOfTextRenderer so that it is
declared before constructLine.
No new tests as this is refactoring only.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::reachedEndOfTextRenderer):
(WebCore::RenderBlock::constructLine):
(WebCore::RenderBlock::layoutInlineChildren):
2011-04-13 Cary Clark <caryclark@google.com>
Reviewed by Eric Seidel.
Allow CG Font support in Chrome Darwin build using Skia
https://bugs.webkit.org/show_bug.cgi?id=58321
This allows Chrome to use Skia to do WebKit rendering, while
using CoreGraphics for glyph creation and computing font metrics.
It relies on an undefined platform token, WTF_USE_SKIA_ON_MAC_CHROME.
No new tests needed, no functionality change.
* loader/cache/CachedFont.cpp: Make CGFontRef functions and
CG-specific font code available to Chrome builds on Darwin using Skia.
* platform/graphics/FontPlatformData.h: Ditto.
(WebCore::FontPlatformData::hash): Ditto.
* platform/graphics/GlyphBuffer.h: Ditto.
(WebCore::GlyphBuffer::advanceAt): Ditto.
(WebCore::GlyphBuffer::add): Ditto.
(WebCore::GlyphBuffer::expandLastAdvance): Ditto.
* platform/graphics/SimpleFontData.h: Ditto.
2011-04-13 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Dimitri Glazkov.
The timeline of the video controls is unusable if the multimedia backend returns a
infinite duration.
https://bugs.webkit.org/show_bug.cgi?id=58452
In case the underlaying media element backend returns crazy values, e.g.
an infinite duration for the video we need to bail out and hide the timeline
rather than in a broken state where you can't use it. The previous code was just
checking if the duration was NaN.
We can't control from JS what the backend will return as a duration for the video
so we can't make an test for it.
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::reset):
2011-04-13 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
Draw outline for render widgets.
https://bugs.webkit.org/show_bug.cgi?id=57439
Test: fast/frames/iframe-outline.html
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
2011-04-13 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Change the representation of ShadowRoot nodes in render tree dumps
https://bugs.webkit.org/show_bug.cgi?id=58432
Show "#shadow-root" for ShadorRoot nodes instead of "#document-fragment"
in DRT results.
No new tests. This change doesn't affect existing tests yet.
* dom/DocumentFragment.h:
Make nodeName() protected in order that ShdowRoot can override it.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::nodeName): Returns "#shadow-root".
* dom/ShadowRoot.h: Declare nodeName().
* rendering/RenderTreeAsText.cpp:
(WebCore::nodePosition): Don't show "child N " if the node is a shadow boundary.
We don't use isShadowRoot() here because the legacy shadow root nodes
return true for isShadowRoot() and we don't want to update existing
test results.
2011-04-13 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Merge LineOffsets and LineWidth
https://bugs.webkit.org/show_bug.cgi?id=58411
Merged lineOffsets into LineWidth.
After this patch, available width is updated in positionNewFloatOnLine via updateAvailableWidth and
shrinkAvailableWidthForNewFloatIfNeeded instead of findNextBreak. This is correct because
- LineOffsets::update and LineOffsets::shrinkWidthForNewFloatIfNeeded were only called in positionNewFloatOnLine
besides LineOffsets' constructor
- positionNewFloatOnLine was only called in skipLeadingWhitespace and findNextLineBreak
- findNextLineBreak updates the available width whenever it calls skipLeadingWhitespace or positionNewFloatOnLine
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::skipLeadingWhitespace): Takes LineWidth instead of LineOffset
(WebCore::LineWidth::LineWidth): Takes RenderBlock* and boolean isFirstLine; call updateAvailableWidth
because the initial available width was used to be computed from lineOffsets.width().
(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight): Added.
(WebCore::LineWidth::updateAvailableWidth): Renamed from LineOffsets::update; this function now updates
m_availableWidth via computeAvailableWidthFromLeftAndRight as well as m_left and m_right.
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Renamed from
LineOffsets::shrinkWidthForNewFloatIfNeeded. This function also calls computeAvailableWidthFromLeftAndRight.
(WebCore::LineWidth::applyOverhang): No longer takes arguments since both arguments were member variables
of LineOffsets.
(WebCore::LineWidth::fitBelowFloats): No longer takes isFirstLine.
(WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.
(WebCore::RenderBlock::positionNewFloatOnLine): Takes a reference to LineWidth.
2011-04-13 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[CMAKE] Separate DerivedSources.
https://bugs.webkit.org/show_bug.cgi?id=58427
No new tests since these are refactoring only.
* CMakeLists.txt:
* UseJSC.cmake:
2011-04-13 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Kenneth Russell.
[chromium] Fix canvas.toDataURL mimeType assertion
https://bugs.webkit.org/show_bug.cgi?id=58425
Following r81213, reassert expected toDataURL() mimeType, remove an unused variable.
No new tests. Covered by existing tests.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageToDataURL):
(WebCore::ImageBuffer::toDataURL):
2011-04-12 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
https://bugs.webkit.org/show_bug.cgi?id=58375
As QNAM now makes actual synchronous loads there is no need for a nested event loop
in ResourceHandleQt.
Moving the call for QNetworkReplyWrapper::synchronousLoad from
ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
redirections to work in synchronous requests.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):
2011-04-13 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by David Hyatt.
Bug 55930 - Incorrect handling of 'display:' property within nested <ruby> tags
https://bugs.webkit.org/show_bug.cgi?id=55930
Non-inline :before/:after generated content is now wrapped with an anonymous inline block.
Also, added an additional check in RenderObjectChildList::updateBeforeAfterContent()
to verify that the created render object is legal under the parent.
Tests: fast/ruby/after-block-doesnt-crash.html
fast/ruby/after-table-doesnt-crash.html
fast/ruby/before-block-doesnt-crash.html
fast/ruby/before-table-doesnt-crash.html
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
* rendering/RenderRuby.cpp:
(WebCore::isAnonymousRubyInlineBlock):
(WebCore::rubyBeforeBlock):
(WebCore::rubyAfterBlock):
(WebCore::createAnonymousRubyInlineBlock):
(WebCore::lastRubyRun):
(WebCore::RenderRubyAsInline::addChild):
(WebCore::RenderRubyAsInline::removeChild):
(WebCore::RenderRubyAsBlock::addChild):
(WebCore::RenderRubyAsBlock::removeChild):
* rendering/RenderRuby.h:
2011-04-13 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
[CG] Refactor get/putImageData routines from ImageBufferCG into a (new) ImageBufferDataCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=58084
No new tests. Does not affect outward behavior.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/ImageBuffer.h:
* platform/graphics/ImageBufferData.h: Added.
* platform/graphics/cairo/ImageBufferData.h: Removed.
* platform/graphics/cairo/ImageBufferDataCairo.h: Added.
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
* platform/graphics/cg/ImageBufferDataCG.cpp: Added.
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::haveVImageRoundingErrorFix):
(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):
* platform/graphics/cg/ImageBufferData.h: Removed.
* platform/graphics/cg/ImageBufferDataCG.h: Added.
* platform/graphics/chromium/ImageBufferData.h: Removed.
* platform/graphics/chromium/ImageBufferDataSkia.h: Added.
* platform/graphics/haiku/ImageBufferData.h: Removed.
* platform/graphics/haiku/ImageBufferDataHaiku.h: Added.
* platform/graphics/qt/ImageBufferData.h: Removed.
* platform/graphics/qt/ImageBufferDataQt.h: Added.
* platform/graphics/wince/ImageBufferData.h: Removed.
* platform/graphics/wince/ImageBufferDataWince.h: Added.
* platform/graphics/wx/ImageBufferData.h: Removed.
* platform/graphics/wx/ImageBufferDataWx.h: Added.
2011-04-13 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Remove std:: prefix on some min/max calls
https://bugs.webkit.org/show_bug.cgi?id=58493
Remove std:: namespacing on min/max in favor of a 'using' clause.
* platform/graphics/RoundedIntRect.cpp:
(WebCore::RoundedIntRect::Radii::expand):
* rendering/style/RenderStyle.cpp:
(WebCore::calcConstraintScaleFor):
2011-04-13 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
Replace our own RenderThemeQt::getMediaElementFromRenderObject by
MediaControlsElement::toParentMediaElement used by every other port.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
* platform/qt/RenderThemeQt.h:
2011-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Switched DOM wrappers to use HashMap of Weak<T> instead of WeakGCMap<T>
https://bugs.webkit.org/show_bug.cgi?id=58482
This will allow wrappers to make individual decisions about their lifetimes.
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::JSNodeHandleOwner::isReachableFromOpaqueRoots):
(WebCore::JSNodeHandleOwner::finalize):
(WebCore::DOMObjectHandleOwner::isReachableFromOpaqueRoots):
(WebCore::DOMObjectHandleOwner::finalize):
* bindings/js/DOMWrapperWorld.h:
(WebCore::JSNodeHandleOwner::JSNodeHandleOwner):
(WebCore::DOMObjectHandleOwner::DOMObjectHandleOwner):
(WebCore::DOMWrapperWorld::jsNodeHandleOwner):
(WebCore::DOMWrapperWorld::domObjectHandleOwner): Added handle owners
for JSNode and DOMObject, our two hash table values. For now, the owners
just take care to remove their handles from their respective hash tables.
Changed the hash table type to be a standard HashMap of weak pointers,
instead of a WeakGCMap.
* bindings/js/JSDOMBinding.cpp:
(WebCore::getCachedDOMObjectWrapper):
(WebCore::cacheDOMObjectWrapper):
(WebCore::cacheDOMNodeWrapper):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::takeWrappers):
(WebCore::updateDOMNodeDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper): Updated wrapper hash table access to
accomodate its new data type.
* bindings/js/JSNodeCustom.h:
(WebCore::getCachedDOMNodeWrapper): Ditto.
* dom/Document.h: Updated declaration to match the above.
2011-04-13 Sam Weinig <sam@webkit.org>
Fix Mac builds.
* WebCore.exp.in:
2011-04-13 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
<rdar://problem/9260518>
Notify the scrollbar painter controller when gesture scrolls begin and end.
* WebCore.exp.in:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::endScrollGesture):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
2011-04-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Maciej Stachowiak.
MediaPlayerPrivateAVFoundationObjC should adopt [AVURLAsset isPlayableExtendedMIMEType:]
https://bugs.webkit.org/show_bug.cgi?id=58451
<rdar://problem/9278468>
No new tests, supported MIME types haven't changed.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType): Use
[AVURLAsset isPlayableExtendedMIMEType] instead of just the list of types.
2011-04-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Alexey Proskuryakov.
Media engine fallback doesn't always work
https://bugs.webkit.org/show_bug.cgi?id=58462
No new tests, this was verified manually with the url noted in the bug.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::networkStateChanged):
2011-04-13 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Extension3D needs to provide a way to check if an extension is enabled
https://bugs.webkit.org/show_bug.cgi?id=58410
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::setupFlags): Use isEnabled() instead of supports().
* platform/graphics/Extensions3D.h: Add isEnabled().
* platform/graphics/chromium/Extensions3DChromium.h: Ditto.
* platform/graphics/opengl/Extensions3DOpenGL.cpp: Ditto.
(WebCore::Extensions3DOpenGL::isEnabled):
* platform/graphics/opengl/Extensions3DOpenGL.h: Ditto.
* platform/graphics/qt/Extensions3DQt.cpp: Ditto.
(WebCore::Extensions3DQt::isEnabled):
* platform/graphics/qt/Extensions3DQt.h: Ditto.
2011-04-13 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make PropertyMapEntry use a WriteBarrier for specificValue
https://bugs.webkit.org/show_bug.cgi?id=58407
Pass JSGlobalData reference on to APIs that now need them
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::all):
2011-04-12 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix source mapping for de-obfuscated scripts.
https://bugs.webkit.org/show_bug.cgi?id=58231
* inspector/front-end/ScriptFormatterWorker.js:
(buildMapping):
* inspector/front-end/SourceFile.js:
(WebInspector.SourceMapping):
(WebInspector.SourceMapping.prototype.sourceLineToScriptLocation):
(WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation):
(WebInspector):
(WebInspector.FormattedSourceMapping):
(WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine):
(WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
2011-04-13 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Consider editable and non editable nodes when calculating selection offsets
https://bugs.webkit.org/show_bug.cgi?id=58431
Use firstPositionInOrBeforeNode() and lastPositionInOrAfterNode().
This is needed to ensure that getSelectionOffsetsForObject() works
well when non editable nodes are present in the selection, since
firstPositionInNode() and lastPositionInNode() don't work in those
cases (they assume the node is editable).
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(getSelectionOffsetsForObject): Updated calls.
2011-04-13 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Missing nullchecks in GTK's a11y wrapper
https://bugs.webkit.org/show_bug.cgi?id=58429
Add missing nullchecks for coreObject->document().
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(atkParentOfRootObject): Add missing nullcheck.
(getPangoLayoutForAtk): Ditto.
(webkit_accessible_text_get_caret_offset): Ditto.
(textExtents): Ditto.
(webkit_accessible_editable_text_insert_text): Ditto.
(webkit_accessible_editable_text_delete_text): Ditto.
2011-04-13 Thierry Reding <thierry.reding@avionic-design.de>
Gtk+ port fails to build when enabling WebGL
https://bugs.webkit.org/show_bug.cgi?id=58434
Fix the GTK+ WebGL build after the introduction of PlatformContextCairo.
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::paintToCanvas):
2011-04-12 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
REGRESSION(r83561): doesn't pause in-window playback during fullscreen playback
https://bugs.webkit.org/show_bug.cgi?id=58312
Make sure to link the videoValve in all cases, fpsdisplaysink
being used or not.
No new test, this patch fixes an internal feature of the player,
not publicly exposed. Having two video sinks and pausing one while
the other displays the fullscreen video is an implementation
detail of the GStreamer player.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
2011-04-13 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: there is a problem if an optional param is not at the end of a params list.
https://bugs.webkit.org/show_bug.cgi?id=58440
In InspectorBackend.dispatch method we are converting the message's params object into array of arguments
for a callback. But in some cases the optional parameter is declared in the middle of the params list.
That gets us into a problem if this param has been skipped in the message. In that case the tail of the
event params will be shifted. We can slightly modify dispatcher and it will put the params in right places.
* inspector/CodeGeneratorInspector.pm:
2011-04-13 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=57337
Work around a bug in ternary opertions in the Solaris Studio
12/12.1/12.2 compilers, using an if clause.
* dom/NodeRenderStyle.h:
(WebCore::Node::renderStyle):
2011-04-13 Brian Salomon <bsalomon@google.com>
Reviewed by Kenneth Russell.
Use new skia API for wrapping DrawingBuffer's FBO/Tex IDs in skia object
https://bugs.webkit.org/show_bug.cgi?id=58363
No new tests needed, exercised by all existing canvas2d tests.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::getGrPlatformSurfaceDesc):
* platform/graphics/gpu/DrawingBuffer.h:
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2011-04-13 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Fix chromium clang build problem:
ApplyPropertyExpandingSuppressValue::applyValue() shadows a virtual method
with a different signature in base class instead of overriding it.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyExpandingSuppressValue::applyValue):
2011-04-13 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Add mock implementation and plumbing code for unified Quota API
https://bugs.webkit.org/show_bug.cgi?id=57927
Added mock implementation and some plumbing code for the quota API,
that is based on the discussion on public-webapps:
http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html
No new tests: tests will be added when we expose the API.
* CMakeLists.txt: Added new file entries.
* DerivedSources.cpp: Added new file entries.
* DerivedSources.make: Added new file entries.
* GNUmakefile.am: Added new file entries.
* WebCore.gypi: Added new file entries.
* WebCore.pro: Added new file entries.
* WebCore.vcproj/WebCore.vcproj: Added new file entries.
* WebCore.xcodeproj/project.pbxproj: Added new file entries.
* storage/StorageInfo.cpp: Added.
* storage/StorageInfo.h: Added.
* storage/StorageInfoErrorCallback.h: Added.
* storage/StorageInfoQuotaCallback.h: Added.
* storage/StorageInfoUsageCallback.h: Added.
2011-04-13 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Martin Robinson.
[GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
https://bugs.webkit.org/show_bug.cgi?id=58297
Make sure we do not load plugins that use symbols of a different
GTK+ major version to avoid bugs and crashes.
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::moduleMixesGtkSymbols):
(WebCore::PluginPackage::load):
2011-04-13 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Implement undo/redo in text editor
https://bugs.webkit.org/show_bug.cgi?id=58426
Native undo/redo does not work because we modify DOM structure (highlights, chunks and etc.)
Implement it via keyboard shortcuts for now (Cmd/Ctrl+Z and Cmd/Ctrl+Shift+Z).
FIXME: Do something with the popup's Undo and Redo menu options - they invoke native's undo/redo.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.endEditing):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.prototype.setText):
(WebInspector.TextEditorModel.prototype._innerSetText):
(WebInspector.TextEditorModel.prototype._pushUndoableCommand):
(WebInspector.TextEditorModel.prototype.undo):
(WebInspector.TextEditorModel.prototype.redo):
(WebInspector.TextEditorModel.prototype._doUndo):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._textChanged):
(WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
(WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
(WebInspector.TextViewer.prototype._registerShortcuts):
(WebInspector.TextViewer.prototype._cancelEditing):
(WebInspector.TextViewer.prototype._handleUndoRedo):
(WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorGutterPanel.prototype.textChanged):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo.callback):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
(WebInspector.TextEditorMainPanel.prototype._restoreSelection):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype.textChanged):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
2011-04-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make optional event parameter last to prevent regressions.
https://bugs.webkit.org/show_bug.cgi?id=58433
* inspector/Inspector.json:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
2011-04-13 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: revert Inspector.json change for breaking world.
* inspector/Inspector.json:
2011-04-13 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: swap methods in the Inspector.json.
* inspector/Inspector.json:
2011-04-13 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed, rolling out r83695.
http://trac.webkit.org/changeset/83695
https://bugs.webkit.org/show_bug.cgi?id=58375
[Qt][WK2]It broke http tests
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::synchronousLoad):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::resourceResponse):
(WebCore::WebCoreSynchronousLoader::resourceError):
(WebCore::WebCoreSynchronousLoader::data):
(WebCore::WebCoreSynchronousLoader::setReplyFinished):
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::WebCoreSynchronousLoader::waitForCompletion):
(WebCore::ResourceHandle::loadResourceSynchronously):
2011-04-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inactive style sheets should be read only.
https://bugs.webkit.org/show_bug.cgi?id=58423
* inspector/front-end/ResourceView.js:
(WebInspector.CSSSourceFrame):
(WebInspector.CSSSourceFrame.prototype.isContentEditable):
(WebInspector.CSSSourceFrame.prototype._loadStyleSheet.didGetAllStyleSheets.didCreateForId):
(WebInspector.CSSSourceFrame.prototype._loadStyleSheet):
2011-04-13 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Prepare to move detailed heap snapshots storage and processing into workers.
https://bugs.webkit.org/show_bug.cgi?id=58320
Introduce a proxy object that emulates worker behavior and change UI code to cope with it.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate.sorted):
(WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort.afterPopulate):
(WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
(WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotIteratorsTuple.prototype.sortAndRewind):
(WebInspector.HeapSnapshotDiffNode.prototype._calculateDiff):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorObjectNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.baseSnapshotNodeIdsReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.pushBaseSnapshotNodeIds):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.snapshotNodeIdsReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotRetainingPathsList):
(WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
(WebInspector.DetailedHeapshotView.profileCallback):
(WebInspector.DetailedHeapshotView):
(WebInspector.DetailedHeapshotView.prototype.get profileWrapper):
(WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper):
(WebInspector.DetailedHeapshotView.prototype.show.profileCallback1):
(WebInspector.DetailedHeapshotView.prototype.show.profileCallback2):
(WebInspector.DetailedHeapshotView.prototype.show):
(WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded):
* inspector/front-end/HeapSnapshot.js:
* inspector/front-end/HeapSnapshotProxy.js: Added.
* inspector/front-end/PleaseWaitMessage.js:
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-04-13 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Web Page Performance auditing fails
https://bugs.webkit.org/show_bug.cgi?id=58322
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
2011-04-13 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: enumerate properties in Inspector.json using array, not object keys.
https://bugs.webkit.org/show_bug.cgi?id=58418
* inspector/Inspector.json:
2011-04-06 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add "De-obfuscate Source" item to source frame text area context menu.
https://bugs.webkit.org/show_bug.cgi?id=57942
* English.lproj/localizedStrings.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.formatSourceFilesToggled):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.toggleFormatSourceFiles):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._contextMenu):
(WebInspector.SourceFrame.prototype._populateLineGutterContextMenu):
(WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):
(WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
(WebInspector.SourceFrameDelegate.prototype.toggleFormatSourceFiles):
(WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled):
2011-04-13 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVGTextContentElements textLength returns 0
https://bugs.webkit.org/show_bug.cgi?id=52543
Add proper handling of the SVGTextContentElement textLength property, according to SVG 1.1 2nd edition.
If the textLength attributes is not explicitely set "textContentElement.textLength.baseVal"
will return the same as "textContentElement.getComputedTextLength()". If it's set the values
aren't equal anymore. getComputedTextLength() ignores the textLength attributes as well as the
lengthAdjust attribute. Adapt all of SVGTextQuery to ignore the lengthAdjust/textLength attributes.
This is how Opera implements it, and it makes sense to a certain degree, as otherwhise getComputedTextLength()
and textLength.baseVal.value would always be the same. Nor does the spec mention that textLength is honored
in the SVG Text DOM API.
Fixes svg/custom/text-dom-01-f.svg (from SVG 1.1 2nd edition, should be moved into the new W3C-SVG-1.1-SE directory).
Fixes svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg (last subtest related to textLength now passes).
Added new svg/dynamic-updates testcases covering dynamic changes of lengthAdjust/textLength and the synchronization
with getComputedTextLength().
Tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr.html
svg/dynamic-updates/SVGTextElement-dom-textLength-attr.html
svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop.html
svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop.html
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::positionForPoint):
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::offsetForPositionInFragment):
(WebCore::SVGInlineTextBox::selectionRect):
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::paint):
(WebCore::SVGInlineTextBox::calculateBoundaries):
* rendering/svg/SVGTextChunkBuilder.cpp:
(WebCore::SVGTextChunkBuilder::buildTextChunks):
(WebCore::SVGTextChunkBuilder::layoutTextChunks):
(WebCore::SVGTextChunkBuilder::addTextChunk):
(WebCore::SVGTextChunkBuilder::processTextChunk):
(WebCore::SVGTextChunkBuilder::processTextLengthSpacingCorrection):
(WebCore::SVGTextChunkBuilder::processTextAnchorCorrection):
* rendering/svg/SVGTextFragment.h:
(WebCore::SVGTextFragment::SVGTextFragment):
(WebCore::SVGTextFragment::buildFragmentTransform):
(WebCore::SVGTextFragment::transformAroundOrigin):
(WebCore::SVGTextFragment::buildTransformForTextOnPath):
(WebCore::SVGTextFragment::buildTransformForTextOnLine):
* rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::parentDefinesTextLength):
(WebCore::SVGTextLayoutEngine::beginTextPathLayout):
(WebCore::dumpTextBoxes):
(WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
(WebCore::SVGTextLayoutEngine::finishLayout):
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
* rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::textLengthCallback):
(WebCore::SVGTextQuery::subStringLengthCallback):
(WebCore::SVGTextQuery::startPositionOfCharacterCallback):
(WebCore::SVGTextQuery::endPositionOfCharacterCallback):
(WebCore::SVGTextQuery::rotationOfCharacterCallback):
(WebCore::calculateGlyphBoundaries):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::SVGTextContentElement):
(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::textLengthAnimated):
(WebCore::SVGTextContentElement::parseMappedAttribute):
(WebCore::SVGTextContentElement::svgAttributeChanged):
* svg/SVGTextContentElement.h:
(WebCore::SVGTextContentElement::specifiedTextLength):
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::svgAttributeChanged):
* svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::svgAttributeChanged):
2011-04-13 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: requestDocument can result in race condition in DOMAgent.js
https://bugs.webkit.org/show_bug.cgi?id=58415
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.requestDocument.onDocumentAvailable):
(WebInspector.DOMAgent.prototype.requestDocument):
2011-04-12 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: another pass of protocol renames.
https://bugs.webkit.org/show_bug.cgi?id=58340
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::setSearchingForNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._setSearchingForNode):
(WebInspector.ElementsPanel.prototype.setSearchingForNode):
2011-04-12 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Implement remaining Background and Mask css properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=58390
No new tests required as no functionality changed.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyExpanding): Class to expand one property to 0-4 properties.
(WebCore::ApplyPropertyExpandingSuppressValue): Expand properties but suppress applyValue.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
(WebCore::CSSStyleSelector::applyProperty): Remove implementations that have been moved to CSSStyleApplyProperty.
2011-04-12 Sergey Glazunov <serg.glazunov@gmail.com>
Reviewed by Dimitri Glazkov.
Element::setAttribute should check the namespace of an id attribute
https://bugs.webkit.org/show_bug.cgi?id=58359
Test: fast/dom/id-attribute-with-namespace-crash.html
* dom/Element.cpp:
(WebCore::Element::setAttribute):
2011-04-12 Mike Lawther <mikelawther@chromium.org>
Reviewed by James Robinson.
Update boolean operators in RenderStyle to be compatible with check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=58409
No new functionality, so no new tests.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::operator==):
(WebCore::RenderStyle::inheritedNotEqual):
(WebCore::positionedObjectMoved):
(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::applyTransform):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::isOriginalDisplayInlineType):
2011-04-12 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
https://bugs.webkit.org/show_bug.cgi?id=58375
As QNAM now makes actual synchronous loads there is no need for a nested event loop
in ResourceHandleQt.
Moving the call for QNetworkReplyWrapper::synchronousLoad from
ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
redirections to work in synchronous requests.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):
2011-04-12 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Move the calculation of the layer's z coordinate to the
right spot so that it can be picked up by its sublayers.
https://bugs.webkit.org/show_bug.cgi?id=58397
Test: platform/chromium/compositing/child-layer-3d-sorting.html
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2011-04-12 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QNetworkReplyHandler refactoring: signal queue
https://bugs.webkit.org/show_bug.cgi?id=57075
The idea is to make all signals that come from the QNetworkReply to pass through a queue and to
stop that queue when loading is deferred. This way almost all the deferred logic can be removed
from QNetworkReplyHandler class and encapsulated in its own class.
To stop the queue during wrapper methods execution avoids stacking handler methods over wrapper
methods. Because of this there is no chance for the wrapper to be destroyed inside one of its methods.
This together with empting the queue at wrapper destruction time makes sure that the handler will
not receive calls from a dead wrapper.
The new class is named QNetworkReplyHandlerCallQueue.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandlerCallQueue::QNetworkReplyHandlerCallQueue):
(WebCore::QNetworkReplyHandlerCallQueue::push):
(WebCore::QNetworkReplyHandlerCallQueue::lock):
(WebCore::QNetworkReplyHandlerCallQueue::unlock):
(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
(WebCore::QNetworkReplyHandlerCallQueue::flush):
(WebCore::QueueLocker::QueueLocker):
(WebCore::QueueLocker::~QueueLocker):
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::readyRead):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::synchronousLoad):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyHandlerCallQueue::deferSignals):
(WebCore::QNetworkReplyHandlerCallQueue::clear):
(WebCore::QNetworkReplyWrapper::synchronousLoad):
(WebCore::QNetworkReplyHandler::setLoadingDeferred):
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):
2011-04-12 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Kent Tamura.
Fix wrong calculation of HTMLFormElement::m_associatedElementsAfterIndex.
https://bugs.webkit.org/show_bug.cgi?id=58247
- Increment m_associatedElementsAfterIndex when the form owner and an
inserted form associated element have the same parent chain.
- Always iterate over m_associatedElements to decrease indexes when a
form associated element is removed. This is needed for a case that the
form associated element is removed from the form element due to
deleting the 'form' attribute. No behavioral change expected with this
change.
Tests: fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html
fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2.html
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formElementIndexWithFormAttribute):
Incremet m_associatedElementsAfterIndex when compareDocumentPosition()
returns DOCUMENT_POSITION_CONTAINED_BY.
(WebCore::HTMLFormElement::removeFormElement):
Always iterate m_associatedElements to adjust indexes.
2011-04-12 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Do not show scrollbars when use mobile theme
https://bugs.webkit.org/show_bug.cgi?id=58380
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarThemeQt::scrollbarThickness):
2011-04-12 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Alexey Proskuryakov.
The default backspace event handler should mark the event as handled if navigation succeeds.
https://bugs.webkit.org/show_bug.cgi?id=58379
We should mark the event as handled only if we were able to successfully navigate backwards or forwards.
These navigations can fail if there is now back/forward history. This can occur in cases like ChromeFrame
where history is managed by an external browser like IE.
No new tests added as this scenario can occur when the history view is split across two browsers (WebKit and IE)
It is non trivial to simulate this environment.
* page/EventHandler.cpp:
(WebCore::EventHandler::defaultBackspaceEventHandler):
2011-04-12 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Make availableWidth and totalOverhangWidth in findNextLineBreak member variables of LineWidth
https://bugs.webkit.org/show_bug.cgi?id=58400
Added m_availableWidth and m_overhangWidth to LineWidth this allows us to encapsulate m_overhangWidth.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine): Added; returns true if current width + first argument <= availableWidth.
(WebCore::LineWidth::availableWidth): Added.
(WebCore::LineWidth::setAvailableWidth): Added; takes LineOffsets.
(WebCore::LineWidth::applyOverhang): Added; obtains the overhang width from ruby run and inflates
the available width.
(WebCore::LineWidth::fitBelowFloats): Moved from RenderBlock.
(WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.
2011-04-12 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed warning fix.
MediaControlElements has been moved to html/shadow.
* WebCore.pro:
2011-04-12 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
Rename onEndChain and make it a static method.
https://bugs.webkit.org/show_bug.cgi?id=58403
No new tests since this is refactoring only.
* rendering/InlineFlowBox.cpp:
(WebCore::isLastChildForRenderer):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
* rendering/InlineFlowBox.h:
2011-04-12 Eric Carlson <eric.carlson@apple.com>
Not reviewed, build fix.
Fix non-accelerated build after r83667.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): Guard call to
mediaPlayerRenderingModeChanged with USE(ACCELERATED_COMPOSITING.
2011-04-12 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] TilingData mishandles very small texture sizes
https://bugs.webkit.org/show_bug.cgi?id=58364
Use zero tiles when the texture size is too small for tiling.
* platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::TilingData):
(WebCore::TilingData::setMaxTextureSize):
2011-04-12 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed, rolling out r83634 and r83659.
http://trac.webkit.org/changeset/83634
http://trac.webkit.org/changeset/83659
https://bugs.webkit.org/show_bug.cgi?id=57075
It made 2 tests time out
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::setLoadingDeferred):
(WebCore::QNetworkReplyHandler::resumeDeferredLoad):
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::resourceResponse):
(WebCore::WebCoreSynchronousLoader::resourceError):
(WebCore::WebCoreSynchronousLoader::data):
(WebCore::WebCoreSynchronousLoader::setReplyFinished):
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::WebCoreSynchronousLoader::waitForCompletion):
(WebCore::ResourceHandle::loadResourceSynchronously):
2011-04-12 Sam Weinig <sam@webkit.org>
Reviewed by Simon Fraser.
Frames prevent scrolling containing page
<rdar://problem/8990409>
https://bugs.webkit.org/show_bug.cgi?id=58392
Also fixes:
Should rubber-band on pages with no scrollbars
<rdar://problem/9034280>
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
Make the main frame rubber-band horizontally and vertically always.
* platform/ScrollTypes.h:
Add ScrollElasticity enum.
* platform/ScrollableArea.cpp:
Default to no elasticity.
(WebCore::ScrollableArea::ScrollableArea):
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::setVerticalScrollElasticity):
(WebCore::ScrollableArea::verticalScrollElasticity):
(WebCore::ScrollableArea::setHorizontalScrollElasticity):
(WebCore::ScrollableArea::horizontalScrollElasticity):
Add state for horizontal and vertical elasticity.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
Bail out of new scrolling behavior if we can't rubber-band. By bailing before
accepting the wheel event, we allow the wheel event to be forwarded. We will
need to refine this logic to allow subframe scrolling in the future.
(WebCore::ScrollAnimatorMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
Switch stretching behavior based on the ScrollableArea's elasticity.
2011-04-12 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Try to fix the Chromium build.
Why have one URL when you can have two at twice the price?
* platform/KURL.h:
(WebCore::KURL::KURL):
(WebCore::KURL::isHashTableDeletedValue):
* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::KURLGooglePrivate):
* platform/KURLGooglePrivate.h: Added a GoogleURL path for KURL's hash
table deleted value constructor.
2011-04-12 Stephanie Lewis <slewis@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=58280
Fix a layout test by correctly comparing enums, and not adding exceptions.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
* bindings/js/SerializedScriptValue.h:
2011-04-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Apple movie trailers play only audio
https://bugs.webkit.org/show_bug.cgi?id=58339
<rdar://problem/9237606>
No new tests, covered by existing layout and manual tests.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerEngineUpdated): Do the logging before calling any functions.
(WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): New, if still displaying the poster
change the display mode to Video and force a style recalc so the video layer gets hooked
up the the render tree.
* html/HTMLMediaElement.h: Define new display mode, PosterWaitingForVideo, to signal that we
want to stop displaying the poster as soon as the first frame of video is available.
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::setDisplayMode): Change display mode to PosterWaitingForVideo when
we want to display Video but the media engines doesn't have the first frame yet.
* html/HTMLVideoElement.h:
(WebCore::HTMLVideoElement::shouldDisplayPosterImage): Update to return true when display mode
is PosterWaitingForVideo.
* manual-tests/media-elements/video-replaces-poster.html: Clean up bit-rot from patch changes.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::firstVideoFrameAvailable): New, passthrough from media engien to element.
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerFirstVideoFrameAvailable):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Initialize
m_haveReportedFirstVideoFrame and m_playWhenFramesAvailable.
(WebCore::MediaPlayerPrivateAVFoundation::play): Don't actually start playback until the first
frame of video has loaded, or audio will begin to play before we can show video.
(WebCore::MediaPlayerPrivateAVFoundation::pause): Clear m_playWhenFramesAvailable.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): When first frame of video is
available, inform elment and begin playback if it was previousl requested.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer): Correct logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPlay): Renamed from play.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause): Rename from pause.
2011-04-12 Jian Li <jianli@chromium.org>
Unreviewed, rolling out r83649.
http://trac.webkit.org/changeset/83649
https://bugs.webkit.org/show_bug.cgi?id=57563
This patch causes compiling errors for chromium
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::Font::drawComplexText):
* platform/graphics/chromium/ImageBufferData.h:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/PlatformCanvas.cpp:
(WebCore::PlatformCanvas::resize):
* platform/graphics/chromium/PlatformCanvas.h:
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::compositeTextComposite):
(WebCore::TransparencyWin::makeLayerOpaque):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setCanvas):
(WebCore::PlatformContextSkia::isPrinting):
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
* platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::canvas):
2011-04-12 Enrica Casucci <enrica@apple.com>
Reviewed by Alexey Proskuryakov.
Implement non-activating clicks to allow dragging out of a background window.
https://bugs.webkit.org/show_bug.cgi?id=55053
<rdar://problem/9042197>
* WebCore.exp.in: Added new exported method.
2011-04-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Geoffrey Garen.
Cleaned up hash traits, and added hash traits for handles
https://bugs.webkit.org/show_bug.cgi?id=58381
* dom/QualifiedName.h: Use new SimpleClassHashTraits to avoid duplication.
* platform/KURL.h:
(WebCore::KURL::KURL):
(WebCore::KURL::isHashTableDeletedValue): Added explicit hash table
deleted value constructor, to be more explicit and enable use of
SimpleClassHashTraits.
* platform/KURLHash.h: Use new SimpleClassHashTraits to avoid duplication.
* platform/graphics/FontCache.cpp: Ditto.
* platform/network/ProtectionSpaceHash.h: Ditto.
* svg/properties/SVGAnimatedPropertyDescription.h: Ditto.
2011-04-12 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
https://bugs.webkit.org/show_bug.cgi?id=58375
As QNAM now makes actual synchronous loads there is no need for a nested event loop
in ResourceHandleQt.
Moving the call for QNetworkReplyWrapper::synchronousLoad from
ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
redirections to work in synchronous requests.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):
2011-04-11 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
REGRESSION: Vimeo fullscreen video displays incorrectly
https://bugs.webkit.org/show_bug.cgi?id=58291
Set the RenderFullScreen's zIndex to the max. And make sure to override
a video element's specified width and height by making its full screen rules
important. Also, always show the controls when a media element is in full
screen mode.
Test: fullscreen/video-specified-size.html
Test: fullscreen/full-screen-zIndex.html
* css/fullscreen.css:
(video:-webkit-full-screen):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::controls): Always show controls in full screen mode.
(WebCore::HTMLMediaElement::preDispatchEventHandler): Added. Handle the fullscreen
change event and hide or show the controls accordingly.
* html/HTMLMediaElement.h:
* rendering/RenderFullScreen.cpp:
(RenderFullScreen::createFullScreenStyle): Set the zIndex to INT_MAX and use a
vertical flexbox instead of a horizontal one.
2011-04-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Page tears and stutters in WebKit2 when page is > 2048 pixels wide
https://bugs.webkit.org/show_bug.cgi?id=58330
Added API to GraphicsLayer to disable switching to tiled layers. This is
set in the nonCompositedContentLayer in WK2, causing that layer to never
switch to tiles and avoiding the asynchronous update of the content during
scroll.
* platform/graphics/ca/GraphicsLayerCA.cpp:
Implement setAllowTiledLayer() to simulate a SizeChanged action to
properly switch between tiled and untiled layer.
* platform/graphics/ca/GraphicsLayerCA.h:
2011-04-12 Alok Priyadarshi <alokp@chromium.org>
Reviewed by James Robinson.
Remove dependency on chromium skia::PlatformCanvas
https://bugs.webkit.org/show_bug.cgi?id=57563
This patch does not change any functionality, just the type of object skia::PlatformCanvas -> SkCanvas.
The object is still being created by a factory method skia::CreateBitmapCanvas defined in Chromium.
We will eventually define an API that every port using skia will define.
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::Font::drawComplexText):
* platform/graphics/chromium/ImageBufferData.h:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/PlatformCanvas.cpp:
(WebCore::PlatformCanvas::resize):
* platform/graphics/chromium/PlatformCanvas.h:
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::compositeTextComposite):
(WebCore::TransparencyWin::makeLayerOpaque):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setCanvas):
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
* platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::canvas):
(WebCore::PlatformContextSkia::printing):
(WebCore::PlatformContextSkia::setPrinting):
2011-04-11 Stephanie Lewis <slewis@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=58280
<rdar://problem/9252824> javascript in an inconsistent state due to serialization returning an un-handled exception
Currently serialization and deserialization can throw javascript exceptions. Since SerializedScriptValue is called in
several places that do not always involve direct calls into javascript have the functions return an error code and the callers
decide whether or not to throw exceptions.
Don't allow SerializedScriptValue to attempt to serialize objects that inherit from JSNavigator.h. Walking that object creates
additional objects which eventually causes serialization to end up throwing a stack overflow error. Instead fail immediately.
Untangle header includes. SerializedScriptValue was inheriting ScriptValue.h, but not using it. Since ScriptValue depends on
SerializedScriptValue this could lead to a circular header dependency.
No change in functionality, covered by current tests
* WebCore.exp.in:
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::initMessageEvent):
* bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::deserialize):
* bindings/js/ScriptValue.h:
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
(WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):
(WebCore::SerializedScriptValue::serializationDidCompleteSuccessfully):
* bindings/js/SerializedScriptValue.h:
* bindings/js/JSWorkerContextBase.cpp: header include fix
* loader/FrameLoader.h: header include fix
* page/Frame.cpp: header include fix
2011-03-28 Adam Barth <abarth@webkit.org>
Reviewed by Kenneth Russell.
Move libtess from WebCore/thirdparty to ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=57288
* WebCore.gyp/WebCore.gyp:
- Add libtess as a legit dependency.
* WebCore.gypi:
- Remove libtess files from the gypi.
* thirdparty/glu: Removed.
2011-04-12 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by David Hyatt.
Bundle w and tmpW in findNextLineBreak together as a class
https://bugs.webkit.org/show_bug.cgi?id=58362
Renamed w, tempW, and width in findNextLineBreak to committedWidth, uncommittedWidth,
and availableWidth respectively. Also bundled committedWidth and uncommittedWith as a class
named LineWidth.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth): Added.
(WebCore::LineWidth::currentWidth): Added; returns the sum of committed and uncommitted width.
(WebCore::LineWidth::uncommittedWidth): Added.
(WebCore::LineWidth::committedWidth): Added.
(WebCore::LineWidth::addUncommittedWidth): Added; adds the specified width to the uncommitted width.
(WebCore::LineWidth::commit): Added; commits the current width and clears the uncommitted width.
(WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.
2011-04-12 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html
https://bugs.webkit.org/show_bug.cgi?id=57459
Slightly change the way we decide if a InlineFlowBox is the last box for its renderer.
We include the border in that box under these conditions:
(1) The next line was not created, or it is constructed. We check the previous line for rtl.
(2) The logicallyLastRun is not a descendant of this renderer.
(3) The logicallyLastRun is a descendant of this renderer, but it is the last child of this renderer and it does not wrap to the next line.
I added the tests from bug 47210, because now the draw the borders correctly.
Tests: fast/borders/bidi-002.html
fast/borders/bidi-004.html
fast/borders/bidi-009a.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::onEndChain):
(WebCore::isAnsectorAndWithinBlock):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
* rendering/InlineFlowBox.h:
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::constructLine):
(WebCore::RenderBlock::layoutInlineChildren):
2011-04-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Cleaned up some Vector traits, and added missing Vector traits for handles
https://bugs.webkit.org/show_bug.cgi?id=58372
* platform/graphics/BitmapImage.h: Added a FIXME because the current
Vector traits for FrameData are logically incorrect, but I couldn't find
a place where this currently results in bad behavior, and it's not
immediately obvious what the right solution is.
2011-04-12 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
Move MediaControlElements to html/shadow.
https://bugs.webkit.org/show_bug.cgi?id=58347
Mechanical move of the files.
* Android.mk: Updated the build file.
* CMakeLists.txt: Ditto.
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto, also ran sort-XCode-project-files.
* html/shadow/MediaControlElements.cpp: Copied from Source/WebCore/rendering/MediaControlElements.cpp.
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
* html/shadow/MediaControlElements.h: Copied from Source/WebCore/rendering/MediaControlElements.h.
* rendering/MediaControlElements.cpp: Removed.
* rendering/MediaControlElements.h: Removed.
* rendering/RenderingAllInOne.cpp: Removed the files that were moved.
2011-04-12 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QNetworkReplyHandler refactoring: signal queue
https://bugs.webkit.org/show_bug.cgi?id=57075
The idea is to make all signals that come from the QNetworkReply to pass through a queue and to
stop that queue when loading is deferred. This way almost all the deferred logic can be removed
from QNetworkReplyHandler class and encapsulated in its own class.
To stop the queue during wrapper methods execution avoids stacking handler methods over wrapper
methods. Because of this there is no chance for the wrapper to be destroyed inside one of its methods.
This together with empting the queue at wrapper destruction time makes sure that the handler will
not receive calls from a dead wrapper.
The new class is named QNetworkReplyHandlerCallQueue.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandlerCallQueue::QNetworkReplyHandlerCallQueue):
(WebCore::QNetworkReplyHandlerCallQueue::push):
(WebCore::QNetworkReplyHandlerCallQueue::lock):
(WebCore::QNetworkReplyHandlerCallQueue::unlock):
(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
(WebCore::QueueLocker::QueueLocker):
(WebCore::QueueLocker::~QueueLocker):
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::readyRead):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::synchronousLoad):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyHandlerCallQueue::deferSignals):
(WebCore::QNetworkReplyHandlerCallQueue::clear):
(WebCore::QNetworkReplyWrapper::synchronousLoad):
(WebCore::QNetworkReplyHandler::setLoadingDeferred):
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):
2011-04-12 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=58176
Inline replaced elements following positioned elements on lines are not rendered. Make sure the
logic for skipping run construction in appendRunsForObject matches the new logic that I added
to findNextLineBreak. If they don't match up, you risk confusing the run construction code and
causing it to not make runs for objects that follow the positioned object on the line.
Added fast/inline/positioned-object-between-replaced-elements.html
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendRunsForObject):
2011-04-12 Alice Liu <alice.liu@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=58292
Provide new setting to allow site icon loading despite disabling automatic image loading in general.
Test: http/tests/misc/favicon-loads-with-icon-loading-override.html
* WebCore.exp.in: Added export symbol
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::startIconLoader): Check new setting before deciding that site icon images shouldn't be loaded.
* page/Settings.cpp:
(WebCore::Settings::Settings): Add initializer for new setting
(WebCore::Settings::setLoadsSiteIconsIgnoringImageLoadingSetting): Add setter for new setting.
* page/Settings.h: Explain nuances regarding loadsImagesAutomatically setting.
(WebCore::Settings::loadsSiteIconsIgnoringImageLoadingSetting): Added getter.
2011-04-12 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Move StyleChange and other global functions from ApplyStyleCommand to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55974
Moved StyleChange, getIdentifierValue, and legacyFontSizeFromCSSValue from ApplyStyleCommand
to EditingStyle. Also moved reconcileTextDecorationProperties, getIdentifierValue,
setTextDecorationProperty, isCSSValueLength, legacyFontSizeFromCSSValue, extractTextStyles,
diffTextDecorations, fontWeightIsBold, getTextAlignment, and getPropertiesNotIn.
Because of this move, getPropertiesNotIn is no longer visible outside of EditingStyle.cpp
* editing/ApplyStyleCommand.cpp:
* editing/ApplyStyleCommand.h:
* editing/EditingStyle.cpp:
(WebCore::reconcileTextDecorationProperties):
(WebCore::StyleChange::StyleChange):
(WebCore::setTextDecorationProperty):
(WebCore::getRGBAFontColor):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
(WebCore::fontWeightIsBold):
(WebCore::getTextAlignment):
(WebCore::getPropertiesNotIn):
(WebCore::getIdentifierValue):
(WebCore::isCSSValueLength):
(WebCore::legacyFontSizeFromCSSValue):
* editing/EditingStyle.h:
(WebCore::StyleChange::cssStyle):
(WebCore::StyleChange::applyBold):
(WebCore::StyleChange::applyItalic):
(WebCore::StyleChange::applyUnderline):
(WebCore::StyleChange::applyLineThrough):
(WebCore::StyleChange::applySubscript):
(WebCore::StyleChange::applySuperscript):
(WebCore::StyleChange::applyFontColor):
(WebCore::StyleChange::applyFontFace):
(WebCore::StyleChange::applyFontSize):
(WebCore::StyleChange::fontColor):
(WebCore::StyleChange::fontFace):
(WebCore::StyleChange::fontSize):
(WebCore::StyleChange::operator==):
(WebCore::StyleChange::operator!=):
2011-04-12 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Better padding for inputs and comboxes in mobile theme
https://bugs.webkit.org/show_bug.cgi?id=58248
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::setButtonPadding):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::paintTextField):
(WebCore::RenderThemeQt::adjustMenuListStyle):
2011-04-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Replace insertChildNode with addChild in handleRunIn's reparenting
of inlineRunIn to currBlock.
https://bugs.webkit.org/show_bug.cgi?id=58228
Use addChild instead of insertChildNode since it handles
correct placement of the children, esp where we cannot insert
anything before the first child. e.g. details tag requires that its
first child be a summary child and won't be able to remove child if
that is not the case.
Test: fast/runin/runin-reparent-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::handleRunInChild):
2011-04-12 Chris Fleizach <cfleizach@apple.com>
Unreviewed. Fixing Leopard build.
REGRESSION: WK2: misspelled AX attributes no longer returned from text fields
https://bugs.webkit.org/show_bug.cgi?id=58304
checkTextOfParagraph is not available on Leopard. That code needs to be conditionalized with USE(UNIFIED_TEXT_CHECKING).
* accessibility/mac/AccessibilityObjectWrapper.mm:
(AXAttributeStringSetSpelling):
2011-04-12 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed. Added missing files to GNUmakefile.list.am.
* GNUmakefile.list.am: Added IDBLevelDBBackingStore.[h|cpp].
2011-04-12 Cris Neckar <cdn@chromium.org>
Reviewed by Nikolas Zimmermann.
Add handling for non-svg inline text boxes in text box lists.
https://bugs.webkit.org/show_bug.cgi?id=57933
Test: svg/text/svg-rtl-text-crash.html
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::positionForPoint):
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGInlineTextBoxes):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::closestLeafChildForPosition):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
* rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::collectTextBoxesInFlowBox):
2011-04-12 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Expose menu items and menus as children of a menu bar
https://bugs.webkit.org/show_bug.cgi?id=56659
Ensure menu items get exposed when they're children of menu bars.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
Consider menu bars as potential parent objects for menu items.
2011-04-12 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: remove scriptWorldType from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=58324
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/ScriptDebugListener.h:
(WebCore::ScriptDebugListener::~ScriptDebugListener):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
* inspector/front-end/Script.js:
(WebInspector.Script):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/SourceFile.js:
(WebInspector.SourceFile):
2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
Should MediaControls::changedNetworkState fiddle with Fullscreen controls?
https://bugs.webkit.org/show_bug.cgi?id=58163
Covered by existing tests and manual-tests/media-controls.html.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::reset): Moved fullscreen showing/hiding here.
(WebCore::MediaControls::changedNetworkState): ... from here.
2011-04-12 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
https://bugs.webkit.org/show_bug.cgi?id=58335
It was the method for Inspector layout tests.
We can use RuntimeAgent.evaluate instead.
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend):
* inspector/front-end/TestController.js:
(WebInspector.TestController.prototype.notifyDone):
2011-04-12 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] some public callbacks remain
https://bugs.webkit.org/show_bug.cgi?id=58307
Cleanup of the player public/private APIs. Moving the GstMessage
handling code inside of the player allowed some APIs to move to
the private scope of the class.
No new tests, this patch is a cleanup and should not affect
current tests coverage.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateMessageCallback):
(WebCore::mediaPlayerPrivateSourceChangedCallback):
(WebCore::mediaPlayerPrivateVolumeChangedCallback):
(WebCore::mediaPlayerPrivateMuteChangedCallback):
(WebCore::mediaPlayerPrivateRepaintCallback):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::currentTime):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
(WebCore::MediaPlayerPrivateGStreamer::triggerRepaint):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2011-04-12 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] advertize HTTP Live Streaming mime-type
https://bugs.webkit.org/show_bug.cgi?id=58318
Register the hls mime-type in the internal cache if found in the
typefind factories.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache):
2011-04-11 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
RenderIndicator and ShadowBlockElement are no longer used.
https://bugs.webkit.org/show_bug.cgi?id=58277
Removed RenderIndicator and ShadowBlockElement.
No new tests. Just removed unused code.
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderIndicator.cpp: Removed.
* rendering/RenderIndicator.h: Removed.
* rendering/RenderMeter.h:
* rendering/RenderingAllInOne.cpp:
* rendering/ShadowElement.cpp:
* rendering/ShadowElement.h:
2011-04-12 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Benjamin Poulain.
fast/css/dashboard-regions-attr-crash.html asserts
https://bugs.webkit.org/show_bug.cgi?id=58233
Move DASHBOARD_SUPPORT feature detection from features.pri to CodeGenerators.pri
not to generate incorrect properties into CSSPropertyNames.h.
* CodeGenerators.pri:
* features.pri:
2011-04-12 Chris Fleizach <cfleizach@apple.com>
Reviewed by Dan Bernstein.
REGRESSION: WK2: misspelled AX attributes no longer returned from text fields
https://bugs.webkit.org/show_bug.cgi?id=58304
checkSpellingOfString is no longer implemented in WK2. Accessibility needs to change to use
checkTextOfParagraph in order to retrieve misspelled ranges.
Existing tests cover this functionality.
* accessibility/mac/AccessibilityObjectWrapper.mm:
(AXAttributeStringSetSpelling):
2011-04-12 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Remove m_idleHandler from ResourceHandleSoup
https://bugs.webkit.org/show_bug.cgi?id=58319
The m_idleHandler attribute is no longer used in ResourceHandleSoup.
No new tests needed, no functionality change.
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2011-04-12 Andrey Adaikin <aandrey@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Breakpoints and execution line decoration should stay in place if the edited line is not whitespace
https://bugs.webkit.org/show_bug.cgi?id=58314
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._lineNumberAfterEditing):
2011-04-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move shortcut handlers from SourceFrame to TextViewer.
https://bugs.webkit.org/show_bug.cgi?id=58238
Commit/cancel editing functionality is common for all resource types, and it deals with TextViewer state.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.isContentEditable):
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype.cancelEditing):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._doubleClick):
(WebInspector.TextViewer.prototype._registerShortcuts):
(WebInspector.TextViewer.prototype._handleKeyDown):
(WebInspector.TextViewer.prototype._commitEditing.didCommitEditing):
(WebInspector.TextViewer.prototype._commitEditing):
(WebInspector.TextViewer.prototype._cancelEditing):
(WebInspector.TextViewerDelegate.prototype.endEditing):
(WebInspector.TextViewerDelegate.prototype.commitEditing):
(WebInspector.TextViewerDelegate.prototype.cancelEditing):
2011-04-12 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: cookies view is empty even for sites with cookies.
https://bugs.webkit.org/show_bug.cgi?id=58316
Test: http/tests/inspector/resource-tree-model.html
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._callForFrameResources):
2011-04-11 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
[chromium] GPU-accelerated canvas-to-canvas drawImage is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=58258
When one accelerated canvas is drawn to another via drawImage(), if the
prior call in the source canvas was non-accelerated, the
hardware canvas is not up-to-date, and the results will be incorrect.
Fixed by calling prepareForHardwareDraw() on the source context.
Test: fast/canvas/canvas-to-canvas.html
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::draw):
2011-04-12 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Add some more tests for detailed heap snapshots UI.
https://bugs.webkit.org/show_bug.cgi?id=58146
Tests: inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-comparison-show-all.html
inspector/profiler/detailed-heapshots-comparison-show-next.html
inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-comparison-sorting.html
inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-dominators-show-all.html
inspector/profiler/detailed-heapshots-dominators-show-next.html
inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-dominators-sorting.html
inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotDiffDataGrid):
2011-04-12 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: there was incorrect value of id property of responses for malformed json-rpc 2.0 requests.
https://bugs.webkit.org/show_bug.cgi?id=58305
It was 0 if the message is not a json object or it has no id property. But according to spec it must be null.
* inspector/CodeGeneratorInspector.pm:
2011-04-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [chromium] script formatting doesn't work when chromium is built with debug_devtools=1.
https://bugs.webkit.org/show_bug.cgi?id=58232
* WebCore.gypi:
2011-04-12 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: REGRESSION: Most resources in the Network panel show a blank panel when clicked.
https://bugs.webkit.org/show_bug.cgi?id=58273
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.get visible):
(WebInspector.SourceFrame.prototype.set visible):
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.hide):
(WebInspector.SourceFrame.prototype.detach):
(WebInspector.SourceFrame.prototype._ensureContentLoaded):
(WebInspector.SourceFrame.prototype.markDiff):
(WebInspector.SourceFrame.prototype.addMessage):
(WebInspector.SourceFrame.prototype.clearMessages):
(WebInspector.SourceFrame.prototype.get scrollTop):
(WebInspector.SourceFrame.prototype.set scrollTop):
(WebInspector.SourceFrame.prototype.highlightLine):
(WebInspector.SourceFrame.prototype._clearLineHighlight):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype.performSearch):
(WebInspector.SourceFrame.prototype.searchCanceled):
(WebInspector.SourceFrame.prototype._jumpToSearchResult):
(WebInspector.SourceFrame.prototype.setExecutionLine):
(WebInspector.SourceFrame.prototype.clearExecutionLine):
(WebInspector.SourceFrame.prototype.resize):
2011-04-12 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: document runtime agent, share remote object definition between domains.
https://bugs.webkit.org/show_bug.cgi?id=58246
* inspector/Inspector.json:
2011-04-12 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: document console domain, support cross-domain type references.
https://bugs.webkit.org/show_bug.cgi?id=58240
* inspector/ConsoleMessage.cpp:
(WebCore::messageSourceValue):
(WebCore::messageTypeValue):
(WebCore::messageLevelValue):
(WebCore::ConsoleMessage::addToFrontend):
* inspector/Inspector.json:
* inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::buildInspectorObject):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
(WebInspector.ConsoleMessage.prototype.isEqual):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
* inspector/generate-inspector-idl:
* page/Console.h:
2011-04-06 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] RTSP playback broken
https://bugs.webkit.org/show_bug.cgi?id=56930
Rely on {audio,video}-changed playbin2 signals instead of the
-tags-changed signals because some media don't provide tags and
then can trick the media-player to not paint video, for instance.
Also trigger a video size calculation after the video sink
negotiated its caps. This is useful in the cases where
audio-changed signal is emitted but the video sink takes more time
to negociate caps with its peer.
This patch also fixes the rtsp manual-test with a new stream url
which seems to be more permanent than the previous WWDC keynote
stream.
* manual-tests/video-rtsp.html:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateVideoChangedCallback):
(WebCore::mediaPlayerPrivateAudioChangedCallback):
(WebCore::mediaPlayerPrivateAudioChangeTimeoutCallback):
(WebCore::mediaPlayerPrivateVideoChangeTimeoutCallback):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::paint):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2011-04-12 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Failed/canceled resource requests kept showing as Pending in network panel.
https://bugs.webkit.org/show_bug.cgi?id=58135
Added statuses for failed/canceled resource loading.
* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didFailLoading):
* inspector/front-end/NetworkManager.js:
* inspector/front-end/NetworkPanel.js:
* inspector/front-end/Resource.js:
2011-04-12 Steve Block <steveblock@google.com>
Reviewed by Oliver Hunt.
Callable objects created via JavaScriptCore API cannot be used as Geolocation callbacks
https://bugs.webkit.org/show_bug.cgi?id=40012
Covered by fast/dom/Geolocation/argument-types.html
* bindings/js/CallbackFunction.cpp:
(WebCore::checkFunctionOnlyCallback):
2011-04-07 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] report playback statistics
https://bugs.webkit.org/show_bug.cgi?id=58033
Provide media playback statistics using fpsdisplaysink and
position queries.
* manual-tests/video-statistics.html: Added.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::decodedFrameCount):
(WebCore::MediaPlayerPrivateGStreamer::droppedFrameCount):
(WebCore::MediaPlayerPrivateGStreamer::audioDecodedByteCount):
(WebCore::MediaPlayerPrivateGStreamer::videoDecodedByteCount):
(WebCore::MediaPlayerPrivateGStreamer::updateAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2011-04-11 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] warnings in media/video-set-rate-from-pause.html
https://bugs.webkit.org/show_bug.cgi?id=58220
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setRate): Pause the
pipeline if new rate is zero, like advised in the GStreamer
documentation of gst_event_new_seek().
2011-04-11 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Properly invalidate the contents of ImageLayerChromium's
when the actual image contents change.
https://bugs.webkit.org/show_bug.cgi?id=58181
Test: compositing/images/content-image-change.html
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::updateTexture):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::ImageLayerChromium):
(WebCore::ImageLayerChromium::setContents):
(WebCore::ImageLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/ImageLayerChromium.h:
2011-04-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
-webkit-box-shadow:inset does not animate transform as an inset shadow
https://bugs.webkit.org/show_bug.cgi?id=45176
Two fixes:
1. Don't run transitions between different shadow styles (normal vs. inset).
2. When either source or destination is null, use a default shadow with a
matching style so that the transition runs.
Test: transitions/mismatched-shadow-styles.html
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
(WebCore::PropertyWrapperShadow::blend):
2011-04-11 John Bates <jbates@google.com>
Reviewed by Kenneth Russell.
chromium support for glSetLatch and glWaitLatch between 3D contexts
https://bugs.webkit.org/show_bug.cgi?id=58003
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setDrawingBuffer):
(WebCore::Canvas2DLayerChromium::setLayerRenderer):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::Cubic::Cubic):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::updateAndDrawLayers):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::addChildContext):
(WebCore::LayerRendererChromium::removeChildContext):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::~WebGLLayerChromium):
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::setContext):
(WebCore::WebGLLayerChromium::setLayerRenderer):
* platform/graphics/chromium/WebGLLayerChromium.h:
2011-04-11 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by James Robinson.
LayerChromium/CCLayerImpl ownership fix
https://bugs.webkit.org/show_bug.cgi?id=58283
CCLayerImpl's m_owner field lifetime should match the lifetime of the
corresponding LayerChromium. This change moves resetting of m_owner
into LayerChromium's destructor.
Tested similarly to bug 57577.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::~LayerChromium):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::cleanupResources):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::resetOwner):
2011-04-11 Daniel Bates <dbates@rim.com>
Attempt to fix the GTK build after changeset 83527 <http://trac.webkit.org/changeset/83527>
(https://bugs.webkit.org/show_bug.cgi?id=53556).
* GNUmakefile.list.am: Append files HTMLTrackElement.{h, cpp} to the list webcore_sources.
2011-04-11 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9251515> and https://bugs.webkit.org/show_bug.cgi?id=58072
URLs accessed as a result of pushState/replaceState should count as "visited" and be in the global history
Test: fast/loader/stateobjects/state-url-sets-links-visited.html
* loader/HistoryController.cpp:
(WebCore::HistoryController::pushState): Notify the history client and add the visited link.
(WebCore::HistoryController::replaceState): Ditto.
2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
Rename MediaControls to MediaControlRootElement.
https://bugs.webkit.org/show_bug.cgi?id=58250
Mechanical move using do-webcore-rename.
2011-04-11 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=58285
CompositeAnimation is cleared while an AnimationBase is waiting for notification
Occasionally hardware animations would trigger a state where
they would tell the AnimationControllerPrivate that it should notify
any waiting animations that they are ready to start, even though
the RenderObject had gone away and hence the CompositeAnimation
had been destroyed. The fix is to zero the pointer from AnimationBase
when the CompositeAnimation destructor runs (or its animations are
cleared) and test the validity of the CompositeAnimation before it
is used in AnimationBase.
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::updatePlayState):
(WebCore::AnimationBase::freezeAtTime):
(WebCore::AnimationBase::beginAnimationUpdateTime):
- test that the CompositeAnimation exists
* page/animation/AnimationBase.h:
(WebCore::AnimationBase::clear):
- rename clearRenderer() to clear() as it now also clears the CompositeAnimation
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::clearRenderer):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
- call clear() rather than clearRenderer()
2011-04-11 Justin Novosad <junov@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Text anti-aliasing fails when rendering text with shadow
https://bugs.webkit.org/show_bug.cgi?id=57584
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::drawGlyphsWin): new static function, code factored-out
from WebCore::Font::drawGlyphs
(WebCore::Font::drawGlyphs): may separate font rendering into two
passes to allow foreground glyphs to be rendered with GDI when Skia
is required for rendering shadows
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::windowsCanHandleDrawTextShadow):
Modified method so that it does not assume a shadow is present, and
returns true if there is no shadow (GDI can draw 'no shadow')
(WebCore::windowsCanHandleTextDrawing):
Factored out into sub methods so that the the shadow and foregound
glyph properties can be tested separately independently.
(WebCore::windowsCanHandleTextDrawingWithoutShadow):
New method returns true if the foreground glyph only has effect
that can be draw with GDI
(WebCore::paintSkiaText):
* platform/graphics/skia/SkiaFontWin.h:
2011-04-11 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed, rolling out r83515.
http://trac.webkit.org/changeset/83515
https://bugs.webkit.org/show_bug.cgi?id=57178
Broke GTK builds. nextOnLineExists and prevOnLineExists are still used in AccessibilityObjectWrapperAtk.cpp.
* rendering/InlineBox.cpp:
(WebCore::InlineBox::nextOnLineExists):
(WebCore::InlineBox::prevOnLineExists):
* rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
2011-04-11 Brady Eidson <beidson@apple.com>
Reverting, seeing something else still broken. Sorry.
* html/HTMLTrackElement.cpp:
2011-04-11 Brady Eidson <beidson@apple.com>
Fix the build.
* html/HTMLTrackElement.cpp: Case-sensitive, please.
2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed build fix for Mac.
An idl file was added in the wrong place.
* WebCore.xcodeproj/project.pbxproj:
2011-04-11 Chris Marrin <cmarrin@apple.com>
Rubberstamped by Dan Bernstein.
xhr.responseType = 'arraybuffer' works on Mac but not on Windows
https://bugs.webkit.org/show_bug.cgi?id=50334
Got rid of guards around arraybuffer logic in XHR. ArrayBuffer and friends
are always turned on now, so there's not need for the guard. I reenabled the
test that was Skipped on Windows and it works now.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::send):
(WebCore::JSXMLHttpRequest::response):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseArrayBuffer):
(WebCore::XMLHttpRequest::setResponseType):
(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::clearResponseBuffers):
(WebCore::XMLHttpRequest::didReceiveData):
* xml/XMLHttpRequest.h:
(WebCore::XMLHttpRequest::optionalResponseArrayBuffer):
2011-04-11 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
https://bugs.webkit.org/show_bug.cgi?id=53556
No new tests. No real functionality added just yet.
* CMakeLists.txt:
* CodeGenerators.pri:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* features.pri:
* html/HTMLAttributeNames.in:
* html/HTMLTagNames.in:
* html/HTMLTrackElement.cpp: Added.
(WebCore::HTMLTrackElement::HTMLTrackElement):
(WebCore::HTMLTrackElement::create):
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::src):
(WebCore::HTMLTrackElement::setSrc):
(WebCore::HTMLTrackElement::kind):
(WebCore::HTMLTrackElement::setKind):
(WebCore::HTMLTrackElement::srclang):
(WebCore::HTMLTrackElement::setSrclang):
(WebCore::HTMLTrackElement::label):
(WebCore::HTMLTrackElement::setLabel):
(WebCore::HTMLTrackElement::isDefault):
(WebCore::HTMLTrackElement::setIsDefault):
(WebCore::HTMLTrackElement::isURLAttribute):
* html/HTMLTrackElement.h: Added.
* html/HTMLTrackElement.idl: Added.
2011-04-11 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=57535
Better compile fix for Solaris 10/Sun Studio 12 CC
needing <sys/time.h>
* loader/icon/IconRecord.h:
* page/Page.h:
* platform/network/ResourceResponseBase.h:
2011-04-11 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
WebKit2: Cannot use Ctrl-Delete as a custom keyboard shortcut
https://bugs.webkit.org/show_bug.cgi?id=58265
<rdar://problem/9221468>
* page/EventHandler.cpp:
(WebCore::EventHandler::defaultKeyboardEventHandler): Handle Backspace.
(WebCore::EventHandler::defaultSpaceEventHandler): Enabled this on Mac, and added checks for
other modifiers - no one wants to scroll on Ctrl+Alt+Space and such.
(WebCore::EventHandler::defaultBackspaceEventHandler): Backspace goes back, Shift-backspace
goes forward. All browsers do it.
(WebCore::EventHandler::defaultArrowEventHandler): Assert that this function was called
for a correct event.
(WebCore::EventHandler::defaultTabEventHandler): Ditto.
* page/EventHandler.h: Added defaultBackspaceEventHandler.
2011-04-11 Matthew Delaney <mdelaney@apple.com>
Reviewed by Dan Bernstein.
[CG] drawImage with a subimage bleeds pixel data at borders
https://bugs.webkit.org/show_bug.cgi?id=58267
Test: fast/canvas/DrawImageSinglePixelStretch.html
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw): Any interpolation quality other than 'none' will graft out the subimage first now.
2011-04-11 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
iframe/compositing propagation should also work for <object> and framesets
https://bugs.webkit.org/show_bug.cgi?id=39037
Generalized the code that handles the parenting of composited <iframe> elements
to include <frame> and <object> elements. This includes forcing the parent
element to be composited and constructing the layer tree in the child document
and properly parenting it. Much of the change is giving the function calls more
generic names (from ...IFrame... to ...Frame...)
Compositing tests that were done in RenderIFrame have been moved to RenderPart
since this is the highest base class common to all 3 elements.
I also renamed several ...IFrame... functions to
...Frame... and changed them so they work on a RenderPart for determining
if the renderer is composited. One other detail is that <iframe> and
<object> never share style since they might be composited. I had to add
<frame> to that list.
Tests: compositing/framesets/composited-frame-alignment.html
compositing/objects/composited-object-alignment.html
* css/CSSStyleSelector.cpp: Add <frame> to list of element types that should never share style since it might be composited.
(WebCore::CSSStyleSelector::canShareStyleWithElement):
* page/FrameView.cpp:
(WebCore::FrameView::hasCompositedContentIncludingDescendants):
(WebCore::FrameView::setIsOverlapped):
* rendering/RenderIFrame.cpp: Moved methods to RenderPart
* rendering/RenderIFrame.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterWidgetResize):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::paintingGoesToWindow):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::frameContentsCompositor):
(WebCore::RenderLayerCompositor::parentFrameContentLayers):
(WebCore::RenderLayerCompositor::didMoveOnscreen):
(WebCore::RenderLayerCompositor::allowsIndependentlyCompositedFrames):
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
(WebCore::RenderLayerCompositor::enclosingFrameElement):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):
(WebCore::RenderLayerCompositor::requiresScrollLayer):
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
(WebCore::RenderLayerCompositor::attachRootPlatformLayer):
(WebCore::RenderLayerCompositor::detachRootPlatformLayer):
* rendering/RenderLayerCompositor.h:
* rendering/RenderPart.cpp: Functions moved from RenderIFrame
(WebCore::RenderPart::requiresLayer):
(WebCore::RenderPart::requiresAcceleratedCompositing):
* rendering/RenderPart.h:
2011-04-11 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
InlineBox::prevOnline and InlineBox::prevOnlineExists() are confusing and should be renamed
https://bugs.webkit.org/show_bug.cgi?id=57178
Remove prevOnLineExists() and nextOnLineExists() as they are not used anymore.
No new tests needed because this is cleanup only.
* rendering/InlineBox.cpp:
* rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::setPrevOnLine):
2011-04-11 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=58261
Fix for layout regression on marketwatch.com. When I converted TrailingFloatsRootInlineBox over
to the new overflow model, I messed up the math and passed a bottom value where I should have
passed a height value. This patch fixes the code to be logically equivalent to the way it
was prior to my changes.
Added fast/overflow/trailing-float-linebox.html.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
2011-04-11 Adrienne Walker <enne@google.com>
Unreviewed, rolling out r83500.
http://trac.webkit.org/changeset/83500
https://bugs.webkit.org/show_bug.cgi?id=57113
Regresses huge-layer-rotated test
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::~ContentLayerChromium):
(WebCore::ContentLayerChromium::cleanupResources):
(WebCore::ContentLayerChromium::requiresClippedUpdateRect):
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::resizeUploadBuffer):
(WebCore::ContentLayerChromium::updateTextureIfNeeded):
(WebCore::ContentLayerChromium::updateTexture):
(WebCore::ContentLayerChromium::draw):
(WebCore::ContentLayerChromium::updateCompositorResources):
(WebCore::ContentLayerChromium::unreserveContentsTexture):
(WebCore::ContentLayerChromium::bindContentsTexture):
(WebCore::ContentLayerChromium::dumpLayerProperties):
* platform/graphics/chromium/ContentLayerChromium.h:
(WebCore::ContentLayerChromium::drawsContent):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setMaskLayer):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::updateTextureIfNeeded):
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::draw):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintContentsRecursive):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::contentLayerProgram):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::invalidateRect):
(WebCore::LayerTilerChromium::update):
(WebCore::LayerTilerChromium::updateFromPixels):
(WebCore::LayerTilerChromium::draw):
* platform/graphics/chromium/LayerTilerChromium.h:
* platform/graphics/chromium/PlatformCanvas.cpp:
(WebCore::PlatformCanvas::AutoLocker::AutoLocker):
(WebCore::PlatformCanvas::Painter::Painter):
* platform/graphics/chromium/PlatformCanvas.h:
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::draw):
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::draw):
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
* platform/graphics/chromium/cc/CCPluginLayerImpl.h:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
2011-04-11 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/9267042> Assertion failure on launch in
LayerChangesFlusher::setHook().
https://bugs.webkit.org/show_bug.cgi?id=58270
Reviewed by Adam Roben.
* platform/graphics/ca/win/LayerChangesFlusher.cpp:
(WebCore::LayerChangesFlusher::setHook):
MSDN says that the HINSTANCE passed in must be null if the thread ID
passed is a thread created by this process and the hook procedure is
within this process.
2011-04-11 MORITA Hajime <morrita@google.com>
Unreviewed build fix.
Changeset 83492 broke Leopard build.
https://bugs.webkit.org/show_bug.cgi?id=58268
* editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToWord):
2011-03-25 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Tile content and image layers
https://bugs.webkit.org/show_bug.cgi?id=57113
Layers tile by default if any dimension is larger than 512. Smaller
layers are contained within a single texture but still use the tiler
infrastructure so that there's only one code path.
Remove large layer support from content layers. Content layers no
longer own a platform canvas--they own a tiler. Refactor tiler to
allow for better separation of update/upload/paint. Add rect
parameter to update and draw functions on layers for the layer-space
rect of interest. This is necessary to know which tiles need to be
drawn.
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::~ContentLayerChromium):
(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerPainter::paint):
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::setLayerRenderer):
(WebCore::ContentLayerChromium::tilingTransform):
(WebCore::ContentLayerChromium::visibleLayerRect):
(WebCore::ContentLayerChromium::layerBounds):
(WebCore::ContentLayerChromium::updateLayerSize):
(WebCore::ContentLayerChromium::draw):
(WebCore::ContentLayerChromium::createTilerIfNeeded):
(WebCore::ContentLayerChromium::updateCompositorResources):
(WebCore::ContentLayerChromium::setTilingOption):
(WebCore::ContentLayerChromium::bindContentsTexture):
(WebCore::ContentLayerChromium::unreserveContentsTexture):
(WebCore::ContentLayerChromium::setIsMask):
(WebCore::ContentLayerChromium::dumpLayerProperties):
* platform/graphics/chromium/ContentLayerChromium.h:
(WebCore::ContentLayerChromium::drawsContent):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setMaskLayer):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::updateCompositorResources):
(WebCore::ImageLayerChromium::layerBounds):
(WebCore::ImageLayerChromium::tilingTransform):
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::invalidateRect):
(WebCore::LayerChromium::paintContentsIfDirty):
(WebCore::LayerChromium::setIsMask):
(WebCore::LayerChromium::draw):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintContentsRecursive):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::getSingleTexture):
(WebCore::LayerTilerChromium::invalidateRect):
(WebCore::LayerTilerChromium::update):
(WebCore::LayerTilerChromium::uploadCanvas):
(WebCore::LayerTilerChromium::updateFromPixels):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::unreserveTextures):
* platform/graphics/chromium/LayerTilerChromium.h:
(WebCore::LayerTilerChromium::setLayerRenderer):
(WebCore::LayerTilerChromium::skipsDraw):
* platform/graphics/chromium/PlatformCanvas.cpp:
(WebCore::PlatformCanvas::AutoLocker::AutoLocker):
(WebCore::PlatformCanvas::Painter::Painter):
* platform/graphics/chromium/PlatformCanvas.h:
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::draw):
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::draw):
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
* platform/graphics/chromium/cc/CCPluginLayerImpl.h:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
2011-04-11 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Ignore context change callbacks when not on the main thread
https://bugs.webkit.org/show_bug.cgi?id=58256
<rdar://problem/9266090>
* platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
(WebCore::WKCACFViewLayerTreeHost::contextDidChange): Do nothing when not called
on the main thread. This should only happen when no changes have actually
been committed to the context, eg. when a video frame has been added to an image
queue, so return without triggering animations etc.
2011-04-11 Daniel Cheng <dcheng@chromium.org>
Reviewed by Dmitry Titov.
[chromium] Implement image/png support in DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=58106
This patch implements DataTransferItem::getAsFile() using Blobs. In
addition, plumbing for image/png has been added so image paste will be
supported as long as the renderer makes that data available.
Tests: editing/pasteboard/data-transfer-items-image-png.html
* dom/DataTransferItem.h:
* dom/DataTransferItem.idl:
* platform/chromium/ClipboardMimeTypes.cpp:
* platform/chromium/ClipboardMimeTypes.h:
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
* platform/chromium/DataTransferItemChromium.h:
* platform/chromium/PlatformBridge.h:
2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[Gtk] Implement support for Embedded Objects
https://bugs.webkit.org/show_bug.cgi?id=52148
Expose special OBJECT character for replaced elements, implementing
AtkText and AtkHyperlink when required.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::textIteratorBehaviorForTextRange): New helper function,
to return the right behavior, depending on the platform, so it
ensures that object replacement characters get emitted for GTK.
(WebCore::AccessibilityRenderObject::textUnderElement): Use the
new helper function textIteratorBehaviorForTextRange.
(WebCore::AccessibilityRenderObject::stringValue): Ditto.
(WebCore::AccessibilityRenderObject::indexForVisiblePosition):
Consider replaced elements when calculating range length in GTK.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(textForRenderer): Ouput the 'object replacement character' for
replaced objects.
(getSelectionOffsetsForObject): Consider replaced elements when
calculating range length in GTK.
(webkitAccessibleHypertextGetLink): Remove wrong extra check that
were causing only links to be considered.
(webkitAccessibleHypertextGetNLinks): Replace wrong 'isLink()'
check with the right one, by checking that the right ATK interface
is being implemented by the AtkObject.
(getInterfaceMaskFromObject): Implement the Hyperlink interface
both for links and replaced objects.
(objectAndOffsetUnignored): Consider replaced elements when
calculating range length in GTK.
* accessibility/gtk/WebKitAccessibleHyperlink.cpp:
(getRangeLengthForObject): Ensure spaces are used for replaced
elements when calling to TextIterator::rangeLength().
* editing/TextIterator.h: New value in the TextIteratorBehavior
enumeration (TextIteratorEmitsObjectReplacementCharacters) and new
private variable to consider that new option internally.
* editing/TextIterator.cpp:
(WebCore::TextIterator::TextIterator): Initialize the new private
attribute m_emitsObjectReplacementCharacters in constructors.
(WebCore::TextIterator::handleReplacedElement): Emit the 'object
replacement character' when m_emitsObjectReplacementCharacters.
2011-04-11 Jia Pu <jpu@apple.com>
Reviewed by Adele Peterson.
Shouldn't carry out autocorrection when start typing a new word
https://bugs.webkit.org/show_bug.cgi?id=58241
<rdar://problem/9264736>
Tests: platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1.html
platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2.html
In TypingCommand::markMisspellingsAfterTyping(), we want to call Editor::markMisspellingsAfterTypingToWord()
only when the typing command is an insertion command, and preceding word contains at least one non-whitespace
character.
* editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToWord):
* editing/Editor.h:
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::markMisspellingsAfterTyping):
2011-04-11 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
PerformanceTiming returns inconsistent values when timing is null.
https://bugs.webkit.org/show_bug.cgi?id=58143
Made PerformanceTiming returned values consistent when there is no timing object.
* page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::domainLookupStart):
(WebCore::PerformanceTiming::domainLookupEnd):
(WebCore::PerformanceTiming::connectStart):
(WebCore::PerformanceTiming::connectEnd):
(WebCore::PerformanceTiming::requestStart):
(WebCore::PerformanceTiming::responseStart):
(WebCore::PerformanceTiming::domLoading):
2011-04-05 Stephen White <senorblanco@chromium.org>
Fix for jittering when animating a rotated image.
https://bugs.webkit.org/show_bug.cgi?id=50775
Make GraphicsContext::roundToDevicePixels a no-op on Chrome/Mac.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):
2011-04-06 Xiaomei Ji <xji@chromium.org>
Reviewed by Ryosuke Niwa.
Continue experiment with moving caret by word in visual order.
https://bugs.webkit.org/show_bug.cgi?id=57806
This is the 2nd patch, which adds implementation when caret is inside box
(not at boundaries). If the word break is inside the same box and not at the boundaries
either, the word break will be returned. If need to search the adjacent boxes for word
breaks, then, only the cases implemented in bug 57336 work.
* editing/visible_units.cpp:
(WebCore::leftmostPositionInRTLBoxInLTRBlock):
(WebCore::rightmostPositionInLTRBoxInRTLBlock):
(WebCore::lastWordBreakInBox):
(WebCore::positionIsVisuallyOrderedInBoxInBlockWithDifferentDirectionality):
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
(WebCore::WordBoundaryEntry::WordBoundaryEntry):
(WebCore::collectWordBreaksInBoxInsideBlockWithSameDirectionality):
(WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality):
(WebCore::greatestValueUnder):
(WebCore::smallestOffsetAbove):
(WebCore::positionIsInsideBox):
(WebCore::positionBeforeNextWord):
(WebCore::positionAfterPreviousWord):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):
2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Unskip accessibility/input-slider.html and accessibility/media-element.html
https://bugs.webkit.org/show_bug.cgi?id=58040
Don't expose objects of role SliderThumbRoles in GTK.
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::addChildren): Allow the platform
make a final decision before including children in the hierarchy.
(WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
Implemented by relying on accessibilityPlatformIncludesObject().
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Ignore accessibility objects with role SliderThumbRole.
2011-04-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Divide by zero in calcColumnWidth
https://bugs.webkit.org/show_bug.cgi?id=58230
Test: fast/multicol/huge-column-count.html
Make sure we have at least one column, to avoid divide by zero.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcColumnWidth):
2011-04-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 58198 - Clean up JSValue implementation for JSVALUE64
JSNumberCell.h has been deprecated.
* ForwardingHeaders/runtime/JSNumberCell.h: Removed.
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/c/c_instance.cpp:
2011-04-11 Dan Bernstein <mitz@apple.com>
Build fix.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
2011-04-11 Antti Koivisto <antti@apple.com>
Reviewed by Tony Gentilcore.
Document source preload scanned repeatedly
https://bugs.webkit.org/show_bug.cgi?id=58123
Don't clear the preload scanner after execution resumes. This would lose the current
scanning point and lead to rescanning when the preload scanner would get reconstructed
due to main parser blocking again.
Instead clear the scanner only in the specific case of receiving new data while the main
parser has already reached the end of the current input.
Also switched to using isWaitingForScripts() instead of m_treeBuilder->isPaused() for consistency.
The case the clearing in resumeParsingAfterScriptExecution() was added for is covered by
http/tests/loading/preload-slow-loading.php.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
2011-04-11 Dan Bernstein <mitz@apple.com>
Build fix.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
2011-04-11 Dan Bernstein <mitz@apple.com>
Reviewed by Alexey Proskuryakov.
Assertion failure in CanvasRenderingContext2D::State::fontsNeedUpdate when invalidating the font cache after opening canvas/philip/tests/initial.reset.2dstate.html (occurs on Qt debug test bot)
https://bugs.webkit.org/show_bug.cgi?id=58229
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State): Added copy constructor, to register the copy with
the font selector if needed.
(WebCore::CanvasRenderingContext2D::State::operator=): Added assignment constructor, to handle
registration with the font selector as needed.
* html/canvas/CanvasRenderingContext2D.h:
2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] ARIA tables not exposing cells as HTML tables do
https://bugs.webkit.org/show_bug.cgi?id=57463
Expose cells for ARIA grids consistently with HTML tables in GTK,
keeping the same behaviour for the other platforms.
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addChild): Add the row's children
to the accessibility hierarchy when accessibility objects for rows
are ignoring accessibility, otherwise add the row.
(WebCore::AccessibilityARIAGrid::addChildren): Do not check at
this point whether every child of the table ignores or not
accessibility, letting addChild() make the proper decision later.
* accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::parentTable): Consider that
rows could be ignoring accessibility, hence the parent could be
retrieved in the first call to parentObjectUnignored().
(WebCore::AccessibilityARIAGridCell::rowIndexRange): Ditto.
(WebCore::AccessibilityARIAGridCell::columnIndexRange): Ditto..
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(atkRole): Map ColumnHeader and RowHeader to ATK_ROLE_TABLE_CELL.
2011-04-11 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix make distcheck
https://bugs.webkit.org/show_bug.cgi?id=58224
Removed a file that is no longer in the source tree.
* GNUmakefile.list.am:
2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Martin Robinson.
REGRESSION(r83397): Most GTK media controls are hidden when no valid source is specified
https://bugs.webkit.org/show_bug.cgi?id=58204
Covered by existing tests.
* platform/gtk/RenderThemeGtk.h:
(WebCore::RenderThemeGtk::hasOwnDisabledStateHandlingFor): Let GTK handle
the the state of media controls.
2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
Remove obsolete comment, which was mistakenly landed in r83397.
Though potentially a work of art, the comment lost its functional meaning a long time ago.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::create): Removed comment.
2011-04-05 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
IndexedDB: Introduce skeleton for LevelDB backend
https://bugs.webkit.org/show_bug.cgi?id=57827
No new tests: no new functionality (yet).
* WebCore.gyp/WebCore.gyp:
Add dependency on leveldb when ENABLE_LEVELDB=1 in feature_defines.
* WebCore.gypi:
Add new files.
* storage/IDBBackingStore.h:
(WebCore::IDBBackingStore::ObjectStoreRecordIdentifier::~ObjectStoreRecordIdentifier):
Introduce abstract type ObjectStoreRecordIdentifier. The SQLite
backend uses integers to refer to a specific row in a table, but
the LevelDB backend will use something else.
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):
Change functions to pass along the database id for operations that
concern object stores. We want to be able to group object stores
ids per database.
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
Decide which backend to use based on the backingStoreType
parameter.
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):
* storage/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::create):
Pass database and object store id to backend functions concerning
indexes.
* storage/IDBLevelDBBackingStore.cpp: Added.
(WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
(WebCore::IDBLevelDBBackingStore::~IDBLevelDBBackingStore):
(WebCore::IDBLevelDBBackingStore::open):
(WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::clearObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::getObjectViaIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
(WebCore::IDBLevelDBBackingStore::createTransaction):
* storage/IDBLevelDBBackingStore.h: Added.
Add an empty implementation of the LevelDB backend.
* storage/IDBObjectStoreBackendImpl.cpp:
Keep track of database id, use the new RecordIdentifier.
(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore::populateIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):
* storage/IDBObjectStoreBackendImpl.h:
(WebCore::IDBObjectStoreBackendImpl::create):
(WebCore::IDBObjectStoreBackendImpl::databaseId):
* storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::open):
(WebCore::IDBSQLiteBackingStore::createObjectStore):
(WebCore::IDBSQLiteBackingStore::deleteObjectStore):
(WebCore::IDBSQLiteBackingStore::getObjectStoreRecord):
(WebCore::IDBSQLiteBackingStore::putObjectStoreRecord):
(WebCore::IDBSQLiteBackingStore::clearObjectStore):
(WebCore::IDBSQLiteBackingStore::deleteObjectStoreRecord):
(WebCore::IDBSQLiteBackingStore::nextAutoIncrementNumber):
(WebCore::IDBSQLiteBackingStore::keyExistsInObjectStore):
(WebCore::IDBSQLiteBackingStore::forEachObjectStoreRecord):
(WebCore::IDBSQLiteBackingStore::getIndexes):
(WebCore::IDBSQLiteBackingStore::createIndex):
(WebCore::IDBSQLiteBackingStore::deleteIndex):
(WebCore::IDBSQLiteBackingStore::putIndexDataForRecord):
(WebCore::IDBSQLiteBackingStore::deleteIndexDataForRecord):
(WebCore::IDBSQLiteBackingStore::getObjectViaIndex):
(WebCore::IDBSQLiteBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBSQLiteBackingStore::keyExistsInIndex):
(WebCore::IDBSQLiteBackingStore::openObjectStoreCursor):
(WebCore::IDBSQLiteBackingStore::openIndexKeyCursor):
(WebCore::IDBSQLiteBackingStore::openIndexCursor):
* storage/IDBSQLiteBackingStore.h:
2011-04-11 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Duplicate CSS properties are reported for non-lowercase property names in the Styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=58226
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::populateAllProperties):
2011-04-07 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: get rid of source frame delegates for resources panel.
https://bugs.webkit.org/show_bug.cgi?id=58041
Use TextViewer configured with a domain-specific delegate to show/edit resource contents in resources panel.
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.createResourceView):
(WebInspector.ResourceView.resourceViewTypeMatchesResource):
(WebInspector.ResourceSourceFrame):
(WebInspector.ResourceSourceFrame.prototype.get resource):
(WebInspector.ResourceSourceFrame.prototype.contentEditable):
(WebInspector.ResourceSourceFrame.prototype._requestContent):
(WebInspector.CSSSourceFrame):
(WebInspector.CSSSourceFrame.prototype.contentEditable):
(WebInspector.CSSSourceFrame.prototype._editContent):
(WebInspector.CSSSourceFrame.prototype._editContent.handleInfos):
(WebInspector.CSSSourceFrame.prototype._saveStyleSheet):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._ensureContentLoaded):
(WebInspector.SourceFrame.prototype._requestContent):
(WebInspector.SourceFrame.prototype._handleSave):
(WebInspector.SourceFrame.prototype._editContent):
2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Regression : r83051 Oxygen's lineedits are not rendered properly
https://bugs.webkit.org/show_bug.cgi?id=58076
State_Sunken is more generic than pressed. It is used by items such as frames or
line edits because they are "sunken" frames (e.g. QLineEdit). It can be required
by some style like Oxygen. Therefore only in the mobile theme we check if the object
is pressed.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintTextField):
2011-04-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add support for optional output parameters.
https://bugs.webkit.org/show_bug.cgi?id=58207
Output parameters such as "redirectResponse" are optional, but
do not allow specifying them as such.
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.json:
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForResourceResponse):
(WebCore::buildObjectForCachedResource):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
* inspector/generate-inspector-idl:
2011-04-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: refactor / document call frames in debugger domain.
https://bugs.webkit.org/show_bug.cgi?id=58187
Note that we are not special casing with(element) and with(document) anymore
and do not tell user that it is "Event target" and "Event document". Strictly speaking,
we should not have done it for with(element) not necessarily being related to an event.
* English.lproj/localizedStrings.js:
* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:
* inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update):
2011-04-10 ChangSeok Oh <shivamidow@gmail.com>
Reviewed by Eric Seidel.
Make correspondence of file name related with event to other port.
https://bugs.webkit.org/show_bug.cgi?id=57416
Some file names are changed to make correspondence naming rule.
Keyboard, mouse and wheel event file names for GTK port have been different from other ports.
This has made user hard to find a specific file related with event for GTK port.
No test required. This patch just changes some file names.
* GNUmakefile.list.am:
* platform/gtk/KeyEventGtk.cpp: Removed.
* platform/gtk/MouseEventGtk.cpp: Removed.
* platform/gtk/PlatformKeyboardEventGtk.cpp: Added.
* platform/gtk/PlatformMouseEventGtk.cpp: Added.
* platform/gtk/PlatformWheelEventGtk.cpp: Added.
* platform/gtk/WheelEventGtk.cpp: Removed.
2011-04-10 Simon Fraser <simon.fraser@apple.com>
Revert the FloatRect.cpp part of r83422, since
clampToInteger() is broken for some inputs. I filed
https://bugs.webkit.org/show_bug.cgi?id=58216
* platform/graphics/FloatRect.cpp:
(WebCore::safeFloatToInt):
(WebCore::enclosingIntRect):
2011-04-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Maciej Stachowiak.
Car model dropdowns at audiusa.com lay out incorrectly with compositing enabled
https://bugs.webkit.org/show_bug.cgi?id=56660
When overflow on an element changes, we need to inform compositing
layers which create and position an "ancestor clipping" layer based
on that overflow. Do this by triggering a rebuild of compositing layers
when overflow changes on a layer whose stacking context has compositing
descendants. (We can't just check whether the layer itself has compositing
descendants, because overflow follows the render tree, but compositing
follows the z-order tree.)
Test: compositing/geometry/ancestor-overflow-change.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2011-04-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Ariya Hidayat.
Allow ShadowBlur to re-use the last buffer if it already contains the correct shadow
https://bugs.webkit.org/show_bug.cgi?id=58161
ShadowBlur already has a singleton scratch buffer that is re-used
between shadows. Enhance use of this scratch buffer to avoid drawing
and blurring the shadow if the results will match what is already
in the buffer.
Cleaned up ShadowBlur code to remove beginShadowLayer() and endShadowLayer(),
which ended up with little reusable code after adding the re-use logic.
* platform/graphics/FloatRect.cpp:
(WebCore::enclosingIntRect): Replace safeFloatToInt() with the existing
clampToInteger() from MathExtras.h
* platform/graphics/FloatSize.h:
(WebCore::expandedIntSize): New method to safely ceil() the size.
* platform/graphics/RoundedIntRect.h:
Add operator== for Radii and RoundedIntRect.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::ScratchBuffer):
(WebCore::ScratchBuffer::setLastShadowValues):
(WebCore::ScratchBuffer::setLastInsetShadowValues):
(WebCore::ScratchBuffer::matchesLastShadow):
(WebCore::ScratchBuffer::matchesLastInsetShadow):
(WebCore::ScratchBuffer::clearScratchBuffer):
Have the scratch buffer remember what shadow parameters were used
to render the buffer contents.
(WebCore::ShadowBlur::drawShadowBuffer):
Renamed from endShadowLayer(), and only contains the drawing
logic now.
(WebCore::ShadowBlur::drawRectShadow):
Promote some code from beginShadowLayer().
(WebCore::ShadowBlur::drawInsetShadow):
Promote some code from beginShadowLayer().
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
These methods now check to see if the buffer already matches
their required parameters, and avoid work if it does.
(WebCore::ShadowBlur::blurShadowBuffer):
Factored some code into this new method.
(WebCore::ShadowBlur::blurAndColorShadowBuffer):
Minor refactoring.
* platform/graphics/ShadowBlur.h:
2011-04-10 Geoffrey Garen <ggaren@apple.com>
Build fix: Updated for file move.
* bindings/js/GCController.cpp:
* bindings/js/ScriptGCEvent.cpp:
2011-04-10 Geoffrey Garen <ggaren@apple.com>
Rubber-stamped by Beth Dakin.
Moved Heap.h and Heap.cpp to the heap folder, because anything less
would be uncivilized.
* ForwardingHeaders/heap/Heap.h: Copied from WebCore/ForwardingHeaders/runtime/Heap.h.
* ForwardingHeaders/runtime/Heap.h: Removed.
2011-04-10 Luke Macpherson <macpherson@chromium.org>
Reviewed by Simon Fraser.
Rename CSSStyleApplyProperty::inherit,initial,value applyInheritValue,applyInitialValue,applyValue
https://bugs.webkit.org/show_bug.cgi?id=58212
No new tests - function renaming only / no functionality changes.
* css/CSSStyleApplyProperty.cpp:
Rename all instances of inherit, initial and value.
* css/CSSStyleApplyProperty.h:
Rename all instances of inherit, initial and value.
* css/CSSStyleSelector.cpp:
Rename all instances of inherit, initial and value.
2011-04-10 Mike Lawther <mikelawther@chromium.org>
Reviewed by Ojan Vafai.
flex/bison tokens and grammar for CSS calc
https://bugs.webkit.org/show_bug.cgi?id=54412
Tests: css3/calc/calc-errors.html
css3/calc/lexer-regression-57581-2.html
css3/calc/lexer-regression-57581-3.html
css3/calc/lexer-regression-57581.html
css3/calc/minmax-errors.html
css3/calc/nested-rounded-corners.html
css3/calc/simple-calcs.html
css3/calc/simple-minmax.html
* css/CSSGrammar.y:
* css/CSSParserValues.cpp:
(WebCore::CSSParserValueList::insertValueAt):
(WebCore::CSSParserValueList::extend):
* css/CSSParserValues.h:
* css/tokenizer.flex:
2011-04-10 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Ryosuke Niwa.
Change EventHandler::updateSelectionForMouseDrag to take a HitTestResult only.
https://bugs.webkit.org/show_bug.cgi?id=57923
Change EventHandler::updateSelectionForMouseDrag to take a HitTestResult
rather than a Node* and an IntPoint&, as the selection may actually not
extend into the Node found by the HitTest.
No new tests. Refactoring only.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::updateSelectionForMouseDrag):
* page/EventHandler.h:
2011-04-10 Kent Tamura <tkent@chromium.org>
Unreviewed, rolling out r83353.
http://trac.webkit.org/changeset/83353
https://bugs.webkit.org/show_bug.cgi?id=58106
The new test doesn't pass on all Chromium platforms.
* dom/DataTransferItem.h:
* dom/DataTransferItem.idl:
* platform/chromium/ClipboardMimeTypes.cpp:
* platform/chromium/ClipboardMimeTypes.h:
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::getAsString):
* platform/chromium/DataTransferItemChromium.h:
* platform/chromium/PlatformBridge.h:
2011-04-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Carlson.
[EFL] Add seek forward / backward buttons to MediaControl UI.
https://bugs.webkit.org/show_bug.cgi?id=56810
Add seek forward / backward buttons to media control. And, change formType name
for media control.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::edjeGroupFromFormType):
(WebCore::RenderThemeEfl::emitMediaButtonSignal):
(WebCore::RenderThemeEfl::paintMediaMuteButton):
(WebCore::RenderThemeEfl::paintMediaPlayButton):
(WebCore::RenderThemeEfl::paintMediaSeekBackButton):
(WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
* platform/efl/RenderThemeEfl.h:
2011-04-10 Chris Guillory <chris.guillory@google.com>
Reviewed by Eric Seidel.
Remove unused function declaration in PlatformContextSkia.h.
https://bugs.webkit.org/show_bug.cgi?id=55983
* platform/graphics/skia/PlatformContextSkia.h:
2011-04-10 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix for !ENABLE(XSLT) after r82562.
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doEnd):
2011-04-10 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix for !ENABLE(XSLT) after r82562.
* xml/XMLTreeViewer.cpp: Readded #if ENABLE(XSLT).
2011-04-10 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Anders Carlsson.
REGRESSION(r83256): Text-decoration bleeds into shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=58205
Now that the shadow root is a never-styled element, we need to walk to
parent to find out if we're inside of a shadow DOM subtree.
Test: media/controls-styling.html
* css/CSSStyleSelector.cpp:
(WebCore::isAtShadowBoundary): Added helper function.
(WebCore::CSSStyleSelector::adjustRenderStyle): Changed to use the helper.
2011-04-07 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
[Meta] Convert HTMLMediaElement to use the new shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=53020
This conversion is non-trivial, for several reasons:
1) Since HTMLMediaElement now hosts the shadow DOM for controls, hiding
and showing controls does not result in destroying and re-creating the
shadow DOM tree. Instead, the tree is created as needed and shown/hidden
using inline styles.
2) Instead of detaching/attaching on each style change, the control parts
are now using a set of higher fidelity callbacks that notify MediaControls
about changes to which it should react. Each reaction results in hiding,
showing, or changing the state of the control parts using inline styles
and DOM APIs.
3) Hiding and showing controls is accomplished using inline styles, rather
than wiring rendererIsNeeded, because renderers are now re-created less
frequently.
4) Instead of constantly querying RenderTheme about visibility of a particular
control part, we let the theme determine which parts are supported and
which parts are visible in certain conditions.
5) Custom hit-testing, event forwarding, and style updates are completely
removed, since they are now unnecessary.
6) Fading controls in/out is now done as CSS animation, since shadow DOM
supports it.
Test: manual-tests/media-controls.html
2011-04-09 Dan Bernstein <mitz@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/9215280> Detached canvas draws with incorrect font
Test: fast/canvas/font-update.html
The existing mechanism for updating the font in a canvas 2D context was lacking in at least
two ways: it neglected to update fonts in all but the topmost state in the stack, and since it
was based on HTMLCanvasElemen's attach() and recalcStyle(), it did not work when the element
was not attached.
This change takes the responsibility for font updates away from the canvas element and gives it
to the canvas context and its graphics state.
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::registerForInvalidationCallbacks): Added. Adds to the set of registered
font selector clients.
(WebCore::CSSFontSelector::unregisterForInvalidationCallbacks): Added. Removes from the set of
registered font selector clients.
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks): Calls fontsNeedUpdate() on all registered
clients and forces a style recalc on the document.
(WebCore::CSSFontSelector::fontLoaded): Changed to call dispatchInvalidationCallbacks().
(WebCore::CSSFontSelector::fontCacheInvalidated): Ditto.
* css/CSSFontSelector.h:
* html/HTMLCanvasElement.cpp: Removed overrides of attach() and recalcStyle().
* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::~State): Added. Unregisters with the font selector.
(WebCore::CanvasRenderingContext2D::State::fontsNeedUpdate): Added. Called by the font selector
when its fonts need to be updated. Updates the font.
(WebCore::CanvasRenderingContext2D::setFont): Registers the state with the font selector.
* html/canvas/CanvasRenderingContext2D.h:
* platform/graphics/FontSelector.h:
(WebCore::FontSelectorClient::~FontSelectorClient):
2011-04-09 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Try recommitting some things svn left out of my last commit.
* bridge/qt/qt_runtime.h:
2011-04-09 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Try recommitting some things svn left out of my last commit.
* ForwardingHeaders/collector: Removed.
* ForwardingHeaders/collector/handles: Removed.
* ForwardingHeaders/collector/handles/Global.h: Removed.
2011-04-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Ojan Vafai.
Implement proper handling of mouseover/mouseout events in regard to shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=55515
This implements XBL 2.0's specified handling of mouseover/mouseout events:
http://dev.w3.org/2006/xbl2/Overview.html#the-mouseover-and-mouseout-events
To do this, we:
1) calculate lowest common ancestor between relatedTarget and target, and
the nearest boundaries around them: the outer (common) boundary, and the
inner (specific to relatedTarget) boundary. Then, we
2) ensure that events only propagate up to the common boundary (or
all the way if boundary is not found), while
3) updating relatedTarget be the inner boundary.
We also detect the most common case when no common boundary could exist
and provide a fast path to short-circuit most of the boundary detection
logic.
Test: fast/events/shadow-boundary-crossing.html
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::adjustToShadowBoundaries): Added a helper to determine lowest
common ancestor, the boundaries around it, and compute adjustments
to relatedTarget and event target ancestor chain.
(WebCore::ancestorsCrossShadowBoundaries): Added.
(WebCore::EventDispatcher::adjustRelatedTarget): Changed to calculate
inner/outer shadow DOM boundaries and adjust ancestors chain accordingly.
(WebCore::EventDispatcher::EventDispatcher): Added flag initializer
(WebCore::EventDispatcher::ensureEventAncestors): Renamed from getEventAncestors,
converted to use initialization flag, rather than testing for empty.
* dom/EventDispatcher.h: Adjusted decls.
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent): Changed to send event
to adjustRelatedTarget.
2011-04-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A few heap-related renames and file moves.
WeakGCPtr<T> => Weak<T>
Global<T> => Strong<T>
collector/ => heap/
collector/* => heap/*
runtime/WeakGCPtr.h => heap/Weak.h
(Eventually, even more files should move into the heap directory. Like
Heap.h and Heap.cpp, for example.)
* CMakeLists.txt:
* ForwardingHeaders/collector: Removed.
* ForwardingHeaders/heap: Copied from ForwardingHeaders/collector.
* ForwardingHeaders/heap/Strong.h: Copied from ForwardingHeaders/collector/handles/Global.h.
* ForwardingHeaders/heap/Weak.h: Copied from ForwardingHeaders/runtime/WeakGCPtr.h.
* ForwardingHeaders/runtime/WeakGCPtr.h: Removed.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* bindings/js/JSCallbackData.h:
* bindings/js/JSCustomVoidCallback.h:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSDataGridDataSource.h:
* bindings/js/JSEventListener.h:
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction):
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
* bindings/js/ScriptCachedFrameData.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createWindowShell):
* bindings/js/ScriptController.h:
* bindings/js/ScriptObject.h:
* bindings/js/ScriptState.h:
* bindings/js/ScriptValue.cpp:
* bindings/js/ScriptValue.h:
* bindings/js/ScriptWrappable.h:
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
* bindings/js/WorkerScriptController.h:
* bridge/jsc/BridgeJSC.h:
* bridge/qt/qt_runtime.h:
* bridge/runtime_root.h:
* xml/XMLHttpRequest.cpp:
2011-04-09 Keith Kyzivat <keith.kyzivat@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Don't link against fontconfig or X11 if embedded
https://bugs.webkit.org/show_bug.cgi?id=58104
No functional change so no new tests.
* WebCore.pri: qpa=>embedded should be done very early so all cases of embedded are uniform.
2011-04-09 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Unreviewed trivial fix after r83344.
* WebCore.pro: Update HEADERS list.
2011-04-09 Jon Lee <jonlee@apple.com>
Reviewed by Beth Dakin.
Overlay scrollbar flashes in scrollable <textarea> with each keystroke (58180)
https://bugs.webkit.org/show_bug.cgi?id=58180
<rdar://problem/9047984>
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollToPoint): Check that there is a change before submitting
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
2011-04-09 Sreeram Ramachandran <sreeram@google.com>
Reviewed by Ryosuke Niwa.
Gather data on modal dialogs shown during unload events
https://bugs.webkit.org/show_bug.cgi?id=58115
Add a new method to the ChromeClient API to allow clients to receive
notifications of modal dialogs dispatched during page dismissal events.
The new method has a default empty definition; only chromium overrides
it to keep track of histograms.
No tests because this is a no-op for all ports except chromium (and it's
not clear how to test chromium histograms from webkit).
* page/Chrome.cpp:
(WebCore::isDuringPageDismissal):
(WebCore::willRunModalDialog):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::willRunModalHTMLDialog):
* page/Chrome.h:
* page/ChromeClient.h:
(WebCore::ChromeClient::willRunModalDialogDuringPageDismissal):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog):
2011-04-08 David Humphrey <david.humphrey@senecac.on.ca>
Reviewed by Eric Carlson.
Fix call order of media element muted and play(), such that setting muted before play() works.
https://bugs.webkit.org/show_bug.cgi?id=57673
https://code.google.com/p/chromium/issues/detail?id=70777
Manual test added: manual-tests/media-muted.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updatePlayState):
* manual-tests/media-muted.html: Added.
2011-04-08 Nat Duca <nduca@chromium.org>
Reviewed by David Levin.
[chromium] Fix windows assertion on ~CCThread
https://bugs.webkit.org/show_bug.cgi?id=58153
Because ~CCThread uses waitForThreadCompletion,
calling detachThread is not necessary.
* platform/graphics/chromium/cc/CCThread.cpp:
(WebCore::CCThread::runLoop):
2011-04-08 Jian Li <jianli@chromium.org>
Unreviewed, rolling out r83348.
http://trac.webkit.org/changeset/83348
https://bugs.webkit.org/show_bug.cgi?id=49508
Breaks layout tests in QT, Win7 and Chromium.
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
2011-04-08 MORITA Hajime <morrita@google.com>
Reviewed by Simon Fraser.
Negative spread should not make a sharp corner rounded
https://bugs.webkit.org/show_bug.cgi?id=58162
Handled inset shadow path for rounded and non-rounded rect
differently as normal shadow path is doing.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
2011-04-07 Simon Fraser <simon.fraser@apple.com>
Reviewed by Martin Robinson.
REGRESSION (r77034-r77220): CSS box-shadow no longer renders on PowerPC
https://bugs.webkit.org/show_bug.cgi?id=55180
The endianness #ifdef in ShadowBlur was unnecessary and harmful. The
data we get back from ImageBuffer::getImageData() do not vary in
endianness.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::blurLayerImage):
2011-04-08 Erik Arvidsson <arv@chromium.org>
Reviewed by Dimitri Glazkov.
IFrame is getting the focus even though it is hidden
https://bugs.webkit.org/show_bug.cgi?id=55861
Test: fast/dom/hidden-iframe-no-focus.html
* html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::isKeyboardFocusable):
* html/HTMLFrameOwnerElement.h:
2011-04-08 Jeff Timanus <twiz@chromium.org>
Reviewed by Kenneth Russell.
Fall back to software rendering for Canvas2D when requesting a DrawingBuffer larger than supported by the GL environment.
https://bugs.webkit.org/show_bug.cgi?id=57768
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::reset):
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::reset):
* platform/graphics/gpu/DrawingBuffer.h:
2011-04-08 Daniel Cheng <dcheng@chromium.org>
Reviewed by Dmitry Titov.
[chromium] Implement image/png support in DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=58106
This patch implements DataTransferItem::getAsFile() using Blobs. In
addition, plumbing for image/png has been added so image paste will be
supported as long as the renderer makes that data available.
Tests: editing/pasteboard/data-transfer-items-image-png.html
* dom/DataTransferItem.h:
* dom/DataTransferItem.idl:
* platform/chromium/ClipboardMimeTypes.cpp:
* platform/chromium/ClipboardMimeTypes.h:
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
* platform/chromium/DataTransferItemChromium.h:
* platform/chromium/PlatformBridge.h:
2011-04-08 MORITA Hajime <morrita@google.com>
Unreviewed windows build fix.
* editing/SpellingCorrectionController.h:
(WebCore::SpellingCorrectionController::UNLESS_ENABLED):
2011-04-08 Enrica Casucci <enrica@apple.com>
Reviewed by Maciej Stachowiak.
Improve lifetime management of nodes in ReplaceNodeWithSpanCommand.
https://bugs.webkit.org/show_bug.cgi?id=57595
<rdar://problem/9222122>
Test: editing/style/bold-with-dom-changes.html
* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
2011-04-07 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 58060 - Prepare access to TreeScope from Node, using NodeRareData
https://bugs.webkit.org/show_bug.cgi?id=58060
Add a TreeScope pointer to NodeRareData to allow direct access to the containing tree scope.
However, in case the containing scope is the document, this is not set, and the
document pointer within Node is used instead.
In an object derived from TreeScope (currently Document), the tree scope pointer
points to itself. Such objects also contain a parent tree scope pointer that
points to the containing scope. For Document, this is 0.
Add new functions setTreeScope[Recursively] that replace setDocument[Recursively]
in public usage. setDocument[Recursively] are now only used internally and are
thererfore protected.
No new tests. (no new functionality)
* dom/ContainerNode.cpp: change DOM manipulation methods to update scope of inserted nodes
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::setDocType): Ditto
(WebCore::Document::adoptNode): Ditto
* dom/Document.h:
* dom/Node.cpp:
(WebCore::Node::treeScope): use NodeRareData to check if a non-Document scope is set
(WebCore::Node::setTreeScope): update NodeRareData depending on whether scope is a document
(WebCore::Node::setTreeScopeRecursively):
(WebCore::Node::setDocumentRecursively):
* dom/Node.h:
* dom/NodeRareData.h: add scope pointer
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::treeScope):
(WebCore::NodeRareData::setTreeScope):
* dom/TreeScope.cpp: add parentTreeScope pointer
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::setParentTreeScope):
* dom/TreeScope.h:
(WebCore::TreeScope::parentTreeScope):
2011-04-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Local caret rectangle calculation should be relative to its containing block.
https://bugs.webkit.org/show_bug.cgi?id=49508.
InlineBox and caret rectangle are positioned relative to its containing block.
So its left and right edge value should be relative to its containing block as well.
Test: fast/forms/cursor-at-editable-content-boundary.html
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
2011-04-08 MORITA Hajime <morrita@google.com>
Unreviewed build fix.
* editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToWord):
2011-04-08 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=57971
Rework visited/unvisited links for before/after content. Propagate the bits earlier so that we don't lose
them when we throw away the visited style. Don't throw away the visited link style for pseudo elements
either, so that the styles are consistent.
Added fast/history/visited-generated-content-test.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
2011-04-06 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
[Refactoring] Auto correction panel should be handled by its own class.
https://bugs.webkit.org/show_bug.cgi?id=55571
Extracted code inside SUPPORT_AUTOCORRECTION_PANEL into
SpellingCorrectionController class.
This change also remove some SUPPORT_AUTOCORRECTION_PANEL guard if
code paths inside the never reached without autocorrection support.
Removing guards reduces unintentional build breakage.
No new tests, no behavior chagne.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* editing/CorrectionPanelInfo.h: Removed.
* editing/EditingAllInOne.cpp:
* editing/Editor.cpp:
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::Editor):
(WebCore::Editor::~Editor):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
(WebCore::Editor::cut):
(WebCore::Editor::paste):
(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::isAutomaticSpellingCorrectionEnabled):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::unappliedSpellCorrection):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
(WebCore::Editor::startCorrectionPanelTimer):
(WebCore::Editor::handleCorrectionPanelResult):
(WebCore::Editor::dismissCorrectionPanelAsIgnored):
* editing/Editor.h:
* editing/SpellingCorrectionCommand.cpp:
* editing/SpellingCorrectionController.cpp: Added.
(WebCore::markerTypesForAutocorrection):
(WebCore::markerTypesForReplacement):
(WebCore::markersHaveIdenticalDescription):
(WebCore::SpellingCorrectionController::SpellingCorrectionController):
(WebCore::SpellingCorrectionController::~SpellingCorrectionController):
(WebCore::SpellingCorrectionController::startCorrectionPanelTimer):
(WebCore::SpellingCorrectionController::stopCorrectionPanelTimer):
(WebCore::SpellingCorrectionController::stopPendingCorrection):
(WebCore::SpellingCorrectionController::applyPendingCorrection):
(WebCore::SpellingCorrectionController::hasPendingCorrection):
(WebCore::SpellingCorrectionController::isSpellingMarkerAllowed):
(WebCore::SpellingCorrectionController::show):
(WebCore::SpellingCorrectionController::handleCancelOperation):
(WebCore::SpellingCorrectionController::dismiss):
(WebCore::SpellingCorrectionController::dismissSoon):
(WebCore::SpellingCorrectionController::applyCorrectionPanelInfo):
(WebCore::SpellingCorrectionController::applyAutocorrectionBeforeTypingIfAppropriate):
(WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
(WebCore::SpellingCorrectionController::correctionPanelTimerFired):
(WebCore::SpellingCorrectionController::handleCorrectionPanelResult):
(WebCore::SpellingCorrectionController::isAutomaticSpellingCorrectionEnabled):
(WebCore::SpellingCorrectionController::windowRectForRange):
(WebCore::SpellingCorrectionController::respondToChangedSelection):
(WebCore::SpellingCorrectionController::respondToAppliedEditing):
(WebCore::SpellingCorrectionController::client):
(WebCore::SpellingCorrectionController::textChecker):
(WebCore::SpellingCorrectionController::recordAutocorrectionResponseReversed):
(WebCore::SpellingCorrectionController::markReversed):
(WebCore::SpellingCorrectionController::markCorrection):
(WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
* editing/SpellingCorrectionController.h: Added.
(WebCore::SpellingCorrectionController::UNLESS_ENABLED):
(WebCore::SpellingCorrectionController::shouldStartTimeFor):
(WebCore::SpellingCorrectionController::shouldRemoveMarkersUponEditing):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
* editing/htmlediting.h:
(WebCore::isAmbiguousBoundaryCharacter):
* page/EditorClient.h:
* page/Frame.cpp:
(WebCore::Frame::setPageAndTextZoomFactors):
2011-04-08 Alpha Lam <hclam@chromium.org>
Unreviewed, rolling out r83335.
http://trac.webkit.org/changeset/83335
https://bugs.webkit.org/show_bug.cgi?id=53556
GTK and QT bots are broken
* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* features.pri:
* html/HTMLAttributeNames.in:
* html/HTMLTagNames.in:
* html/HTMLTrackElement.cpp: Removed.
* html/HTMLTrackElement.h: Removed.
* html/HTMLTrackElement.idl: Removed.
2011-04-08 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=58155 and part of <rdar://problem/9251767>
BitmapImage::getFirstCGImageRefOfSize fails if the frameCount hasn't been initialized from the image source.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::getFirstCGImageRefOfSize): Call frameCount() instead of accessing m_frames.size() to
make sure the frames are properly tallied first.
2011-04-08 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] Dragging and dropping an image in edit mode does not work
https://bugs.webkit.org/show_bug.cgi?id=19385
When adding an image to the clipboard, we should also include the HTML code of that image so
it can be used for internal drag and drop.
This HTML is expected by all clients of drop events so a fragment can be moved from one browser to
another, or inside the same browser.
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::declareAndWriteDragImage):
2011-04-07 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
https://bugs.webkit.org/show_bug.cgi?id=53556
No new tests. No real functionality added just yet.
* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* features.pri:
* html/HTMLAttributeNames.in:
* html/HTMLTagNames.in:
* html/HTMLTrackElement.cpp: Added.
(WebCore::HTMLTrackElement::HTMLTrackElement):
(WebCore::HTMLTrackElement::create):
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::src):
(WebCore::HTMLTrackElement::setSrc):
(WebCore::HTMLTrackElement::kind):
(WebCore::HTMLTrackElement::setKind):
(WebCore::HTMLTrackElement::srclang):
(WebCore::HTMLTrackElement::setSrclang):
(WebCore::HTMLTrackElement::label):
(WebCore::HTMLTrackElement::setLabel):
(WebCore::HTMLTrackElement::isDefault):
(WebCore::HTMLTrackElement::setIsDefault):
(WebCore::HTMLTrackElement::isURLAttribute):
* html/HTMLTrackElement.h: Added.
* html/HTMLTrackElement.idl: Added.
2011-04-07 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Logic error in HTMLMediaElement::exitFullscreen()
https://bugs.webkit.org/show_bug.cgi?id=58085
The new full screen API case could fall through to the legacy API case
unintentionally if a script calls exitFullscreen on an element which is
not the current full screen element.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen):
(WebCore::HTMLMediaElement::exitFullscreen):
2011-04-08 Mike Reed <reed@google.com>
Reviewed by Eric Seidel.
Replace SKIA_TEXT with isNativeFontRenderingAllowed() for print-preview to work
https://bugs.webkit.org/show_bug.cgi?id=57782
No new tests. This change only affects print-preview and build option SKIA_GPU
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::paintSkiaText):
2011-04-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang, Darin Adler, and Enrica Casucci.
REGRESSION(r81887): Crash in SplitElement
https://bugs.webkit.org/show_bug.cgi?id=57743
The crash was caused by ReplaceSelectionCommand::doApply's calling splitElement with computeNodeAfterPosition
even when the position was after the last node in it container. Since all we are doing here is to splitting tree
up until the highest ancestor with isInlineNodeWithStyle, replaced the while loop by calls to splitTreeToNode
and highestEnclosingNodeOfType.
Also fixed a bug in splitTreeToNode not to check the difference in visible position when splitting the ancestor,
which would have introduced unnecessary nodes when splitting tree and a bug in highestEnclosingNodeOfType that
it incorrectly called deprecatedNode instead of containerNode.
Test: editing/inserting/insert-images-in-pre-x-crash.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::splitTreeToNode):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
* editing/htmlediting.cpp:
(WebCore::highestEnclosingNodeOfType):
2011-04-08 Antti Koivisto <antti@apple.com>
Reviewed by Tony Gentilcore.
Incoming source should be preload scanned when the parser is blocked
https://bugs.webkit.org/show_bug.cgi?id=58117
Scan the appended source if parser is blocked.
Test: http/tests/loading/preload-append-scan.php
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::append):
2011-04-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix the WebKit2 build for older versions of GTK+
https://bugs.webkit.org/show_bug.cgi?id=58095
No new tests. This is just a build fix.
* platform/gtk/GtkVersioning.c:
(gdk_window_create_similar_surface): Reimplement this method for older versions of GDK.
* platform/gtk/GtkVersioning.h: Add the new method to the header.
2011-04-08 Misha Tyutyunik <michael.tyutyunik@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Plugin is not scrolled together with page content or jumping
when content is rendered using cache (backing store).
https://bugs.webkit.org/show_bug.cgi?id=56130
This is a Symbian portion of the fix. For Linux it looks like
it's enough to call set geometry which should be addressed in
https://bugs.webkit.org/show_bug.cgi?id=57179
No new tests required. This can be tested with manual tests from
WebCore/manual-tests/qt and WebCore/manual-tests/plugins
* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::updatePluginWidget):
2011-04-08 Abhishek Arya <inferno@chromium.org>
Unreviewed. Remove accidental printf added in r83306.
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):
2011-04-08 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
Dragging text in a WebKit2 window results in a copy instead of a move.
https://bugs.webkit.org/show_bug.cgi?id=56772
<rdar://problem/9165140>
cleanupAfterSystemDrag cannot call dragEnd in WebKit2, since
the call to startDrag is asynchronous.
* page/mac/DragControllerMac.mm:
(WebCore::DragController::cleanupAfterSystemDrag):
2011-04-05 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Move WheelEvent-dispatching logic into WheelEventDispatchMediator.
https://bugs.webkit.org/show_bug.cgi?id=57642
Covered by existing tests, no functional change.
* dom/Event.cpp:
* dom/Event.h:
(WebCore::EventDispatchMediator::EventDispatchMediator): Added default
constructor.
(WebCore::EventDispatchMediator::event): Inlined.
(WebCore::EventDispatchMediator::setEvent): Added.
* dom/EventDispatcher.cpp: Removed dispatchWheelEvent.
* dom/EventDispatcher.h: Updated decls.
* dom/Node.cpp:
(WebCore::Node::dispatchWheelEvent): Changed to use the mediator and
return a bool, like other dispatch event functions.
* dom/Node.h: Changed decl.
* dom/WheelEvent.cpp:
(WebCore::granularity): Moved from EventDispatcher.
(WebCore::WheelEventDispatchMediator::WheelEventDisatchMediator): Added.
(WebCore::WheelEventDispatchMediator::event): Added.
(WebCore::WheelEventDispatchMediator::dispatchEvent): Added.
* dom/WheelEvent.h: Updated decls.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent): Changed to receive and react
to the return value.
2011-04-08 Jessie Berlin <jberlin@apple.com>
Windows build warning fix.
* WebCore.vcproj/WebCore.vcproj:
Since ShadowRoot.cpp is included in the DOMAllInOne.cpp file, it should be excluded from
the build.
2011-04-07 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: update breakpoints according to source frame decorations after live edit.
https://bugs.webkit.org/show_bug.cgi?id=58029
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._updateResourceContent.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._updateResourceContent):
* inspector/front-end/SourceFile.js:
(WebInspector.SourceFile.prototype.set content):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
(WebInspector.SourceFrame.prototype._handleSave):
2011-04-08 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix scripts concatenation in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=58138
When there is just one script starting at 0:0 it should not be surrounded by <script> framing.
* inspector/front-end/SourceFile.js:
(WebInspector.SourceFile.prototype._loadResourceContent):
(WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent):
2011-04-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI elements.
https://bugs.webkit.org/show_bug.cgi?id=58118
This change reuses location for call frames in the protocol + structures script
location <-> source lines interaction better. When we need UI columns, we will add
them, but we should distinguish between script and UI terms on the type level, not naming.
* English.lproj/localizedStrings.js:
* bindings/v8/DebuggerScript.js:
* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLine):
(WebInspector.CallStackSidebarPane.prototype.update):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.PresenationCallFrame):
(WebInspector.PresenationCallFrame.prototype.sourceLine.didRequestSourceMapping):
(WebInspector.PresenationCallFrame.prototype.sourceLine):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.locationToPosition):
(WebInspector.ScriptFormatter.lineToPosition):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype.showAnchorLocation):
(WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
* inspector/front-end/SourceFile.js:
(WebInspector.SourceMapping.prototype.scriptLocationToSourceLine):
(WebInspector.SourceMapping.prototype.sourceLineToScriptLocation):
(WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine):
(WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
2011-04-08 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: distinguish breakpoints set on de-obfuscated sources from breakponts set on original sources.
https://bugs.webkit.org/show_bug.cgi?id=58133
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype._reset):
2011-04-07 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: make SourceFrame TextViewer's delegate for editing operations.
https://bugs.webkit.org/show_bug.cgi?id=58026
This is the first step of decoupling TextViewer from SourceFrame.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.hide):
(WebInspector.SourceFrame.prototype._ensureContentLoaded):
(WebInspector.SourceFrame.prototype.contentEditable):
(WebInspector.SourceFrame.prototype.startEditing):
(WebInspector.SourceFrame.prototype.endEditing):
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype._handleSave):
(WebInspector.SourceFrame.prototype._handleRevertEditing):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
(WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
(WebInspector.TextViewer.prototype._syncDecorationsForLine):
(WebInspector.TextViewer.prototype._doubleClick):
(WebInspector.TextViewerDelegate):
(WebInspector.TextViewerDelegate.prototype.contentEditable):
(WebInspector.TextViewerDelegate.prototype.startEditing):
(WebInspector.TextViewerDelegate.prototype.endEditing):
(WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
* inspector/front-end/inspector.html:
2011-04-08 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Steve Block.
Media Stream API: add the getUserMedia method and the Javascript bindings.
https://bugs.webkit.org/show_bug.cgi?id=56586
Add the getUserMedia method to the navigator and its new Javascript types.
Current specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication
Tests: fast/dom/MediaStream/argument-types.html
fast/dom/MediaStream/enabled.html
fast/dom/MediaStream/no-interface-object.html
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* Android.v8bindings.mk:
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSNavigatorCustom.cpp:
(WebCore::JSNavigator::webkitGetUserMedia):
* bindings/v8/custom/V8NavigatorCustom.cpp: Added.
(WebCore::V8Navigator::webkitGetUserMediaCallback):
* page/Navigator.cpp:
(WebCore::Navigator::webkitGetUserMedia):
* page/Navigator.h:
* page/Navigator.idl:
* page/NavigatorUserMediaError.h: Added.
(WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
(WebCore::NavigatorUserMediaError::~NavigatorUserMediaError):
(WebCore::NavigatorUserMediaError::code):
* page/NavigatorUserMediaError.idl: Added.
* page/NavigatorUserMediaErrorCallback.h: Added.
(WebCore::NavigatorUserMediaErrorCallback::~NavigatorUserMediaErrorCallback):
* page/NavigatorUserMediaErrorCallback.idl: Added.
* page/NavigatorUserMediaSuccessCallback.h: Added.
(WebCore::NavigatorUserMediaSuccessCallback::~NavigatorUserMediaSuccessCallback):
* page/NavigatorUserMediaSuccessCallback.idl: Added.
2011-04-08 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
https://bugs.webkit.org/show_bug.cgi?id=58010
https://bugs.webkit.org/show_bug.cgi?id=58011
Added tests for "Containment" view. Minor refactorings, bugs fixed.
Split one large tests into smaller ones to avoid timing out in debug mode.
Tests: inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-containment-show-all.html
inspector/profiler/detailed-heapshots-containment-show-next.html
inspector/profiler/detailed-heapshots-containment-sorting.html
inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-summary-show-all.html
inspector/profiler/detailed-heapshots-summary-show-next.html
inspector/profiler/detailed-heapshots-summary-sorting.html
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.doSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDominatorObjectNode):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid):
2011-04-08 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Bugs in some corner cases in the text editor
https://bugs.webkit.org/show_bug.cgi?id=58025
This solves the following bugs:
1) The very last _empty_ line would not be deleted if you hit a Backspace on it, or the selection text to be deleted is extended to the very bottom of the editor.
2) An odd corner case: delete all source code from the editor, hit backspace on the only empty line, then add a character. In this case the browser will insert a TEXT node instead of a DIV node for a lineRow.
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
(WebInspector.TextEditorMainPanel.prototype._enclosingLineRowOrSelf):
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
2011-04-07 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add test for script formatter worker.
https://bugs.webkit.org/show_bug.cgi?id=57447
Test: inspector/debugger/script-formatter.html
* GNUmakefile.am:
* WebCore.xcodeproj/project.pbxproj:
* gyp/streamline-inspector-source.sh:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._formatter):
* inspector/front-end/ScriptFormatterWorker.js:
2011-04-08 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Tweak dynamically constants for the async highlighting in text editor
https://bugs.webkit.org/show_bug.cgi?id=58035
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype._expandChunks):
(WebInspector.TextEditorMainPanel.prototype._schedulePaintLines):
(WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
(WebInspector.TextEditorMainPanel.prototype._restorePaintLinesOperationsCredit):
(WebInspector.TextEditorMainPanel.prototype._adjustPaintLinesOperationsRefreshValue):
2011-04-08 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: HAR compliance fixes
https://bugs.webkit.org/show_bug.cgi?id=58124
- Always provide some values for queryString and cookies, even though arrays may be empty
- Always provide an empty cache object
- Added entire HARLog to test
- Workaround in test to avoid custom expectations (favicon.ico appears in log on certain platforms)
* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype.build):
(WebInspector.HAREntry.prototype._buildRequest):
(WebInspector.HAREntry.prototype._buildResponse):
2011-04-08 Adam Barth <abarth@webkit.org>
Attempt to fix the Qt build.
* css/CSSStyleApplyProperty.cpp:
2011-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Refactor WebCore/GNUMakefile.am to separate list of files
https://bugs.webkit.org/show_bug.cgi?id=58116
This change is similar to the cooresponding to change to
JavaScriptCore. We hope to generate GNUmakefile.list.am automatically
using GYP.
* GNUmakefile.am:
* GNUmakefile.list.am: Added.
2011-04-07 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Rolled out some accidentally-committed changes in my last commit.
* dom/EventTarget.cpp:
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):
* dom/EventTarget.h:
2011-04-07 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Alexey Proskuryakov.
EventSource should only accept UTF-8 charset
https://bugs.webkit.org/show_bug.cgi?id=56942
Following the discussion on bug 45372, this change implements the recommended
way of handling "charset". We only accept UTF-8 but no other encoding. This matches
the encoding of the EventSource and also may fix TomCat that automatically send this
charset.
* page/EventSource.cpp:
(WebCore::EventSource::didReceiveResponse): We now check the charset attribute and if it is
not UTF-8, abort the connection and log the error to the console. Also we log if the MIME type
is wrong to the console to help debugging (only in the case of an HTTP 200 response though).
2011-04-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Some Handle<T> cleanup
https://bugs.webkit.org/show_bug.cgi?id=58109
* bindings/js/ScriptValue.h:
(WebCore::ScriptValue::ScriptValue): Updated for new null constructor.
(WebCore::ScriptValue::hasNoValue): Updated for removal of isEmpty().
2011-04-07 Dominic Cooney <dominicc@google.com>
Reviewed by Dimitri Glazkov.
Let shadow DOM have a list of nodes at the top level of a shadow.
https://bugs.webkit.org/show_bug.cgi?id=57813
Adds ShadowRoot, a list of nodes, to be a parent for top-level
shadow children. Forwards rendering through the root and into the
host's renderer.
Covered by existing tests of elements that use this style of shadow.
* Android.mk: add ShadowRoot.h/cpp
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve): proxy style to host
* dom/ContainerNode.cpp: parent nodes that are shadow roots are alive
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::appendChild):
* dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::DocumentFragment):
* dom/DocumentFragment.h:
* dom/Element.cpp:
(WebCore::Element::recalcStyle): look through ShadowRoots for host's style
(WebCore::Element::shadowRoot): should be const
(WebCore::Element::ensureShadowRoot): simpler than setShadowRoot
* dom/Element.h:
* dom/ElementRareData.h:
* dom/Node.cpp:
(WebCore::Node::parentNodeForRenderingAndStyle): indirection so
ShadowRoot can forward to the host's renderer
(WebCore::Node::createRendererAndStyle):
(WebCore::Node::createRendererIfNeeded):
* dom/Node.h:
(WebCore::Node::isShadowBoundary): temporary, to differentiate
old- and new-style, until all roots are ShadowRoot instances
* dom/ShadowRoot.cpp: Added.
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::recalcStyle): forward recalc to children
* dom/ShadowRoot.h: Added.
(WebCore::ShadowRoot::isShadowBoundary):
(WebCore::ShadowRoot::create):
* html/HTMLKeygenElement.cpp: use ensureShadowRoot
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
(WebCore::HTMLKeygenElement::parseMappedAttribute):
(WebCore::HTMLKeygenElement::appendFormData):
(WebCore::HTMLKeygenElement::reset):
(WebCore::HTMLKeygenElement::shadowSelect):
* html/HTMLKeygenElement.h:
* html/HTMLMeterElement.cpp: use ensureShadowRoot
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp: use ensureShadowRoot
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/InputType.cpp: use ensureShadowRoot
(WebCore::InputType::destroyShadowSubtree):
* html/RangeInputType.cpp: use ensureShadowRoot
(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):
(WebCore::RangeInputType::valueChanged):
(WebCore::RangeInputType::shadowSliderThumb):
* html/RangeInputType.h:
* html/ValidationMessage.cpp: use ensureShadowRoot
(WebCore::ValidationMessage::buildBubbleTree):
(WebCore::ValidationMessage::deleteBubbleTree):
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint):
(WebCore::SliderThumbElement::hostInput):
* html/shadow/SliderThumbElement.h:
* rendering/MediaControlElements.cpp: use ensureShadowRoot
(WebCore::MediaControlInputElement::attach):
(WebCore::MediaControlInputElement::updateStyle):
* rendering/RenderSlider.cpp: use ensureShadowRoot
(WebCore::RenderSlider::thumbRect):
(WebCore::RenderSlider::layout):
(WebCore::RenderSlider::shadowSliderThumb):
(WebCore::RenderSlider::inDragMode):
* rendering/RenderSlider.h:
2011-04-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Simon Fraser.
REGRESSION (r80871): Crash when visiting http://broadband.biglobe.ne.jp/
https://bugs.webkit.org/show_bug.cgi?id=56297
<rdar://problem/9131597>
Test: fast/css-generated-content/table-row-after-no-crash.html
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange): Factor out generation of before/after
content, and only do it if the row already has a parent. For construction of
anonymous cells to work correctly, the row needs to already have a parent, so
in that case wait a bit.
(WebCore::RenderTableRow::updateBeforeAndAfterContent): Factored out to here.
* rendering/RenderTableRow.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild): When adding a row, update its
before/after content, in case it had any.
2011-04-07 Beth Dakin <bdakin@apple.com>
Reviewed by Simon Fraser.
Probable fix for <rdar://problem/9251443> Crashing on exception: -
[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]: unrecognized
selector sent to instance ADDRESS.
Need to implement new delegate method.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]):
2011-04-07 Ian Henderson <ianh@apple.com>
Reviewed by Simon Fraser.
Optimize filling rounded rects that are actually ellipses
https://bugs.webkit.org/show_bug.cgi?id=58098
In CG, drawing an ellipse directly is faster than constructing and
filling a rounded rect path. Detect when the given rounded rect is
actually an ellipse and draw it directly in this case.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillRoundedRect):
2011-04-07 Ned Holbrook <nholbrook@apple.com>
Reviewed by Dan Bernstein.
CTLine objects should outlive their CTRuns
https://bugs.webkit.org/show_bug.cgi?id=58063
* platform/graphics/mac/ComplexTextController.h: Add m_coreTextLines, to be destroyed after m_complexTextRuns.
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Moot m_coreTextRun.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Append line to m_coreTextLines.
2011-04-07 Nat Duca <nduca@chromium.org>
Reviewed by David Levin.
[chromium] Compositor thread infrastructure
https://bugs.webkit.org/show_bug.cgi?id=56131
Introduce chrome compositor thread and related
infrastructure.
* WebCore.gypi:
* platform/graphics/chromium/cc/CCMainThread.cpp: Added.
(WebCore::CCMainThread::performTask):
(WebCore::CCMainThread::postTask):
* platform/graphics/chromium/cc/CCMainThread.h: Added.
(WebCore::CCMainThread::Task::~Task):
(WebCore::CCMainThread::Task::instance):
(WebCore::CCMainThread::Task::Task):
* platform/graphics/chromium/cc/CCMainThreadTask.h: Added.
(WebCore::MainThreadTask0::create):
(WebCore::MainThreadTask0::MainThreadTask0):
(WebCore::MainThreadTask0::performTask):
(WebCore::MainThreadTask1::create):
(WebCore::MainThreadTask1::MainThreadTask1):
(WebCore::MainThreadTask1::performTask):
(WebCore::MainThreadTask2::create):
(WebCore::MainThreadTask2::MainThreadTask2):
(WebCore::MainThreadTask2::performTask):
(WebCore::MainThreadTask3::create):
(WebCore::MainThreadTask3::MainThreadTask3):
(WebCore::MainThreadTask3::performTask):
(WebCore::createMainThreadTask):
* platform/graphics/chromium/cc/CCThread.cpp: Added.
(WebCore::CCThread::create):
(WebCore::CCThread::CCThread):
(WebCore::CCThread::~CCThread):
(WebCore::CCThread::postTask):
(WebCore::CCThread::compositorThreadStart):
(WebCore::CCThread::runLoop):
* platform/graphics/chromium/cc/CCThread.h: Added.
(WebCore::CCThread::Task::~Task):
(WebCore::CCThread::Task::instance):
(WebCore::CCThread::Task::Task):
(WebCore::CCThread::threadID):
(WebCore::CCCompletionEvent::CCCompletionEvent):
(WebCore::CCCompletionEvent::~CCCompletionEvent):
(WebCore::CCCompletionEvent::wait):
(WebCore::CCCompletionEvent::signal):
* platform/graphics/chromium/cc/CCThreadTask.h: Added.
(WebCore::CCThreadTask0::create):
(WebCore::CCThreadTask0::CCThreadTask0):
(WebCore::CCThreadTask0::performTask):
(WebCore::CCThreadTask1::create):
(WebCore::CCThreadTask1::CCThreadTask1):
(WebCore::CCThreadTask1::performTask):
(WebCore::CCThreadTask2::create):
(WebCore::CCThreadTask2::CCThreadTask2):
(WebCore::CCThreadTask2::performTask):
(WebCore::CCThreadTask3::create):
(WebCore::CCThreadTask3::CCThreadTask3):
(WebCore::CCThreadTask3::performTask):
(WebCore::createCCThreadTask):
2011-04-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
https://bugs.webkit.org/show_bug.cgi?id=57872
r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.
r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
avoiding the tab span.
Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.
Also reverted r46914 for the general code path because re-creating node hierarchy duplicates nodes when
we're moving nodes after the paragraph separator. Instead, we now split the tree up until the start block
before moving the nodes.
Tests: editing/inserting/insert-paragraph-after-tab-span-and-text.html
editing/inserting/insert-paragraph-separator-tab-span.html
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::saveTypingStyleState): Since EditingStyle's constructor avoids a tab span,
no longer calls positionBeforeTabSpan on the position passed to EditingStyle's constructor.
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph
separator into a paragraph separator.
* editing/htmlediting.cpp:
(WebCore::positionOutsideTabSpan): Renamed from positionBeforeTabSpan. Also returns the position in the parent
node after the tab span if the position was at the end of the tab span.
* editing/htmlediting.h:
2011-04-07 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
[Mac] Editor::setComposition() should not trigger correction panel timer.
https://bugs.webkit.org/show_bug.cgi?id=58049
<rdar://problem/9226305>
On Mac OS X that supports autocorrection panel, typing unconfirmed composition (i.e. unconfirmed Japanese or Chinese input)
should not start autocorrection timer. We added a member variable, m_shouldPreventSpellChecking, to TypingCommand.
When this value is true, markMisspellingsAfterTyping() will not be called in TypingCommand::typingAddedToOpenCommand().
m_shouldPreventSpellChecking is set to true in the TypingCommand objects created by Editor::setComposition().
No new tests. No deterministically reproducible test case. Patch is based on static code analysis. Testing this also requires firing
autocorrection panel timer, which can not be easily done in automated fashion.
* editing/Editor.cpp:
(WebCore::Editor::deleteWithDirection):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::confirmComposition):
(WebCore::Editor::setComposition):
* editing/EditorCommand.cpp:
(WebCore::executeDelete):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparator):
(WebCore::TypingCommand::typingAddedToOpenCommand):
* editing/TypingCommand.h:
(WebCore::TypingCommand::create):
(WebCore::TypingCommand::setShouldPreventSpellChecking):
2011-04-07 John Bauman <jbauman@chromium.org>
Reviewed by Kenneth Russell.
clearIfComposited call is really slow
https://bugs.webkit.org/show_bug.cgi?id=57999
Move getContextAttributes call after the if, so it isn't called nearly as often.
No new tests.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::clearIfComposited):
2011-04-07 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Implement Backgroun and Mask properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=57922
No tests added as no behavioral changes.
* css/CSSStyleApplyProperty.cpp:
Added ApplyPropertyFillLayer test to handle Background and Mask CSS Properties.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Added constructor calls to set up:
CSSPropertyBackgroundAttachment
CSSPropertyBackgroundClip
CSSPropertyWebkitBackgroundClip
CSSPropertyWebkitBackgroundComposite
CSSPropertyBackgroundOrigin
CSSPropertyWebkitBackgroundOrigin
CSSPropertyBackgroundSize
CSSPropertyWebkitBackgroundSize
CSSPropertyWebkitMaskAttachment
CSSPropertyWebkitMaskClip
CSSPropertyWebkitMaskComposite
CSSPropertyWebkitMaskOrigin
CSSPropertyWebkitMaskSize
* css/CSSStyleApplyProperty.h:
(WebCore::CSSStyleApplyProperty::setPropertyValue):
Add function to specify an equivalent property value in the lookup table.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove sections now implemented by CSSStyleApplyProperty.
* css/CSSStyleSelector.h:
Make CSSStyleApplyProperty a friend class so that the mapFill* functions are accessible.
2011-04-04 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Split run storage out from BidiResolver into a new BidiRunList class
https://bugs.webkit.org/show_bug.cgi?id=57764
Part of what makes BidiResolver and InlineIterator so difficult to understand
(and bug 50912 so difficult to fix) is that BidiResolver is both a state machine
for the Unicode Bidi Algorithm (UBA) as well as storage for the resulting
BidiRuns from the algorithm. This patch breaks the storage aspect off
into its own class BidiRunList.
This patch is only a start. It does not actually fix the problematic ownership
relationship, but it does make it possible to fix such in a second patch.
The run pointers and addRun/prependRun, etc. were already a tightly coupled
logical subset of the BidiResolver class, so moving them into their own class
was both obvious and easy. The only piece of logic I had to move was that
deleteRuns() had a side-effect of setting the m_emptyRun bit on the resolver.
I believe this deleteRuns side-effect was only ever used for one place
(right after findNextLineBreak) and that it's only needed because
findNextLineBreak can sometimes create bidi runs. Run creation appears to be
an unintentional side-effect of how InlineIterator calls through to BidiResolver
as part of bidiNext and not a desired effect of the code. I have added the call
to markCurrentRunEmpty to both places deleteRuns was called (where the resolver
could get re-used) as a safety precaution. We could replace both with ASSERTs
in a later patch.
I suspect there may be a small performance win from further refactoring so that
findNextLineBreak does not need to create BidiRuns.
As I commented in the code, callers should own their own BidiRunList which they
pass to BidiResolver::createBidiRunsForLine. I attempted to implement that in
an earlier version of this patch, but it was too complicated with the current
twisted dependencies between InlineIterator/bidiNext and InlineBidiResolver.
raise/lowerExplicitEmbeddingLevel are called unconditionally
from commitExplicitEmbedding (which is called by bidiNext) and expect to have
access to a runs list even in cases where we don't want any runs (findNextLineBreak).
I also cleaned up some of the callers to pass around BidiRunList objects instead
of InlineBidiResolvers now that they're separate objects.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawBidiText):
* platform/text/BidiResolver.h:
(WebCore::BidiResolver::BidiResolver):
(WebCore::BidiResolver::runs):
(WebCore::BidiResolver::markCurrentRunEmpty):
(WebCore::::appendRun):
(WebCore::::lowerExplicitEmbeddingLevel):
(WebCore::::raiseExplicitEmbeddingLevel):
(WebCore::::reorderRunsFromLevels):
(WebCore::::createBidiRunsForLine):
* rendering/InlineIterator.h:
(WebCore::InlineBidiResolver::appendRun):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::createRun):
(WebCore::RenderBlock::appendRunsForObject):
(WebCore::reachedEndOfTextRenderer):
(WebCore::RenderBlock::handleTrailingSpaces):
(WebCore::RenderBlock::layoutInlineChildren):
2011-04-07 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Adam Barth.
[Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner.
https://bugs.webkit.org/show_bug.cgi?id=57911
http://code.google.com/p/chromium/issues/detail?id=78073
Manual test added: manual-tests/autofill-popup-location.html
Originally only height is checked so that it introduces the bug.
So I changed it to check both width and height as size.
* manual-tests/autofill-popup-location.html: Added.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::refresh): Check window size between original and new before calling setFrameRect().
2011-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement img-src style-src and font-src
https://bugs.webkit.org/show_bug.cgi?id=58018
These are pretty straight forward given the rest of the infrastructure
we've built so far.
Tests: http/tests/security/contentSecurityPolicy/image-allowed.html
http/tests/security/contentSecurityPolicy/image-blocked.html
http/tests/security/contentSecurityPolicy/style-allowed.html
http/tests/security/contentSecurityPolicy/style-blocked.html
http/tests/security/contentSecurityPolicy/xsl-allowed.php
http/tests/security/contentSecurityPolicy/xsl-blocked.php
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
2011-04-07 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Make IconSnapshot and PageURLRecord member variables private.
https://bugs.webkit.org/show_bug.cgi?id=58080
No change in functionality so no new tests.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::writeToDatabase): Changed to used the accessor functions.
(WebCore::IconDatabase::writeIconSnapshotToSQLDatabase): Ditto.
* loader/icon/IconRecord.h:
(WebCore::IconSnapshot::IconSnapshot): Changed to use the new member variable names.
(WebCore::IconSnapshot::iconURL): Expose the property.
(WebCore::IconSnapshot::timestamp): Ditto.
(WebCore::IconSnapshot::data): Ditto.
* loader/icon/PageURLRecord.h:
(WebCore::PageURLSnapshot::PageURLSnapshot): Changed to use the new member variable names.
(WebCore::PageURLSnapshot::pageURL): Expose the property.
(WebCore::PageURLSnapshot::iconURL): Ditto.
2011-04-07 Dan Bernstein <mitz@apple.com>
Build fix.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):
2011-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add stub support for generating Gtk build system from gyp
https://bugs.webkit.org/show_bug.cgi?id=58086
This does not produce a buildable WebCore, but it
does allow running gyp/configure --port=gtk and having
it generate a gtk.Makefile which we can use for testing
the rest of the plumbing.
* gyp/gtk.gyp: Added.
2011-04-07 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=57736
Crash on openstreetmap.org while using the map. Fix a bad interaction between the positioned movement layout
optimization and the simplified layout optimization that could lead to blocks remaining marked as dirty when
layout finished. This would eventually lead to an inability to properly determine the correct layout root and
would cause a deleted root to be used later on.
Added fast/block/positioning/complex-positioned-movement.html.
* page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayoutOfSubtree):
Add asserts to catch cases in the future where a layout root is set that has a dirty containing block.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedLayout):
Change simplified layout so that the positioned movement optimization no longer clears the other layout
flags. This will ensure that we still lay out our descendants if they need it.
(WebCore::RenderBlock::layoutPositionedObjects):
Changed to clear our layout flags now if the positioned movement is successful, since tryLayoutDoingPositionedMovementOnly
no longer does the clear.
* rendering/RenderBox.h:
(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
tryLayoutDoingPositionedMovementOnly now returns a boolean indicating success or failure. On success it no longer
does setNeedsLayout(false), but instead will let the caller take care of it. This way the caller can still look at
the other flags in case other kinds of layout are still needed.
* rendering/RenderObject.h:
(WebCore::RenderObject::setNeedsPositionedMovementLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
Changed these methods to only set their respective flags and not to try to be clever about avoiding propagation.
2011-04-07 Andrew Scherkus <scherkus@chromium.org>
Revert ENABLE_TRACK patch due to compile failures.
* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* features.pri:
* html/HTMLAttributeNames.in:
* html/HTMLTagNames.in:
* html/HTMLTrackElement.cpp: Removed.
* html/HTMLTrackElement.h: Removed.
* html/HTMLTrackElement.idl: Removed.
2011-04-07 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/9018212> Underline thickness is not uniform under non-integral scale factor
https://bugs.webkit.org/show_bug.cgi?id=58083
Test: fast/text/decorations-transformed.html
* platform/graphics/GraphicsContext.h: Added a RoundingMode enum with two values. RoundAllSides
is the existing rounding mode, where each side of the rectangle snaps to the nearest pixel
gridline. RoundOriginAndDimensions snaps the origin to the nearest pixel gridpoint and rounds
the width and the height. In this new mode, translating a rectangle in user space never changes
its dimensions in device pixels.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Implemented RoundOriginAndDimensions.
(WebCore::GraphicsContext::drawLineForText): Use RoundOriginAndDimensions, thus ensuring that
all underlines have the same thickness in device pixels.
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Added RoundingMode parameter, but did not implement it.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Ditto.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Ditto.
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Ditto.
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Ditto.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):
2011-04-06 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Nate Chapin.
[V8] Remove custom DOMImplementation getter on Document.
https://bugs.webkit.org/show_bug.cgi?id=57991
The custom getter is no longer required because DOMImplementation
objects are now created per document.
Test: fast/dom/DOMImplementation/implementation-identity.html
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/custom/V8DocumentCustom.cpp:
* dom/Document.idl:
2011-04-07 Sergey Glazunov <serg.glazunov@gmail.com>
Reviewed by Dimitri Glazkov.
setHasID() is only called for styled elements
https://bugs.webkit.org/show_bug.cgi?id=57267
Test: fast/dom/non-styled-element-id-crash.html
* dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::Element::idAttributeChanged):
* dom/Element.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::parseMappedAttribute):
2011-04-07 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
HTMLVideoElement::webkitEnterFullscreen does not use new Full Screen API when available.
https://bugs.webkit.org/show_bug.cgi?id=58070
Make the HTMLMediaElement full screen functions call into the new Full Screen API when
FULLSCREEN_API is enabled.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen):
(WebCore::HTMLMediaElement::exitFullscreen):
2011-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement CSP's options directive
https://bugs.webkit.org/show_bug.cgi?id=58014
This patch contains the full options parser, but we only have enough of
CSP implemented to see the effects of disable-xss-protection. Will
need to do some more work before we can see eval-script in action.
Tests: http/tests/security/contentSecurityPolicy/inline-script-allowed.html
http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPOptions::CSPOptions):
(WebCore::CSPOptions::disableXSSProtection):
(WebCore::CSPOptions::evalScript):
(WebCore::CSPOptions::parse):
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
2011-04-07 Alexey Proskuryakov <ap@apple.com>
Reviewed by Anders Carlsson.
REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
https://bugs.webkit.org/show_bug.cgi?id=58066
<rdar://problem/8965302>
* platform/mac/HTMLConverter.h:
* platform/mac/HTMLConverter.mm: (+[WebHTMLConverter editingAttributedStringFromRange:]):
Changed editingAttributedStringFromRange: to use WebCore::Range instead of DOMRange, since
it's now used in WebKit2.
2011-04-07 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r64712): Microsoft Outlook 2011: original message contents
not included when replying to an email.
https://bugs.webkit.org/show_bug.cgi?id=57794
* WebCore.exp.in:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedParsing): Call Frame::injectUserScripts()
before checking if the FrameLoader is parsing the initial empty document.
This allows user scripts to be injected at the end of document parsing
(if the setting is enabled).
* page/Frame.cpp:
(WebCore::Frame::injectUserScripts): Do not inject scripts if this
feature is disabled on the initial empty document.
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h: Add a setting for injecting user scripts into the
initial empty document (defaults to false).
(WebCore::Settings::setInjectUserScriptsInInitialEmptyDocument):
(WebCore::Settings::injectUserScriptsInInitialEmptyDocument):
* platform/mac/RuntimeApplicationChecks.h:
* platform/mac/RuntimeApplicationChecks.mm:
(WebCore::applicationIsMicrosoftOutlook): Check if the embedding
application is Microsoft Outlook.
2011-04-06 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
AVF: MediaPlayerPrivateAVFoundation never reaches playable state.
https://bugs.webkit.org/show_bug.cgi?id=57962
Add support for a new AVPlayerItem API which will notify clients when their
seek completes. This requires a new Notification type to be passed to the main
thread in MediaPlayerPrivateAVFoundation.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Added.
(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification): Added two new
overloaded functions which take a Notification; and a Notification::Type and boolean.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Support new SeekCompleted
Notification type.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification): Added one new constructor.
(WebCore::MediaPlayerPrivateAVFoundation::Notification::finished): Added ivar and accessor.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime): Call new AVPlayerItem API.
(-[WebCoreAVFMovieObserver seekCompleted:]): Added.
2011-04-07 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Eric Carlson.
Parse quotes from content type parameters
https://bugs.webkit.org/show_bug.cgi?id=53275
This functionality is tested in video-can-play-type.html layout test
where I've added codecs parameter with good and bad formatting.
* platform/ContentType.cpp:
(WebCore::ContentType::parameter):
2011-04-07 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: remove "enabled" from the setBreakpoint protocol.
https://bugs.webkit.org/show_bug.cgi?id=58047
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::hasBreakpoint):
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::buildObjectForBreakpointCookie):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/ScriptBreakpoint.h:
(WebCore::ScriptBreakpoint::ScriptBreakpoint):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.callback):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled.afterUpdate):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpointsFromSettings):
(WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._reset):
(WebInspector.PresentationBreakpoint):
2011-04-07 Dan Bernstein <mitz@apple.com>
Reviewed by Adam Roben.
Removed a redundant line of code.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes): No need to compare line gap values, as
this is covered by the earlier hasIdenticalAscentDescentAndLineGap() check.
2011-04-07 Liang Qi <liang.qi@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Enable webkit build with GCCE on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=57841
* WebCore.pri: Thanks for Norbert Leser <norbert.leser@nokia.com> who checked RVCT part.
--rw-base value in QMAKE_LFLAGS.ARMCC and -Tdata value in QMAKE_LFLAGS.GCCE are updated
to 0x1000000 together. They need to be updated in the future when WebKit grows.
2011-04-06 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: get rid of Breakpoint.js.
https://bugs.webkit.org/show_bug.cgi?id=57949
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/Breakpoint.js: Removed.
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint.didLoadSnippet):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype._debuggerWasDisabled):
(WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.prototype.removeBreakpoint):
(WebInspector.DebuggerModel.prototype._breakpointResolved):
(WebInspector.DebuggerModel.prototype.reset):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._refreshBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._reset):
(WebInspector.PresentationBreakpoint):
(WebInspector.PresentationBreakpoint.prototype.get sourceFile):
(WebInspector.PresentationBreakpoint.prototype.get url):
(WebInspector.PresentationBreakpoint.prototype.get resolved):
(WebInspector.PresentationBreakpoint.prototype.loadSnippet):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._onResourceStarted):
(WebInspector.ResourceTreeModel.prototype._addResourceToFrame):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._breakpointUpdated):
(WebInspector.ScriptsPanel.prototype.reset):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-04-07 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: console messages names should adhere to the common naming style
https://bugs.webkit.org/show_bug.cgi?id=58042
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::updateRepeatCountInConsole):
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messagesCleared):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
2011-04-06 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: migrate Inspector protocol messages format to JSON-RPC.
https://bugs.webkit.org/show_bug.cgi?id=57957
There is not a significant difference between inspector messages spec and and JSON-RPC 2.0 messages spec.
Also JSON-RPC has a pretty clear specification for error descriptions which we haven't.
It was decided that we will use it.
the list of renames:
1) type-> /dev/null
2) domain + '.' + event => method // for events
3) domain + '.' + command => method // for requests
4) requestId => id // for responses
5) arguments => params // for requests
6) data => params // for events
7) body => result // for responses
protocolErrors and error properties will be converted to JSON-RPC error format.
The order of properties in messages also will be adjusted.
The only thing that looks unnecessary is jsonrpc property.
* inspector/CodeGeneratorInspector.pm:
2011-04-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Add functions to update left and right offsets to LineOffsets
https://bugs.webkit.org/show_bug.cgi?id=58028
Added update() and shrinkWidthForNewFloatIfNeeded(FloatingObject*) to LineOffsets,
which are used to update m_left and m_right. Also added m_block and m_isFirstLine
member variables to LineOffsets so that users of LineOffsets don't have to pass them around.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::skipLeadingWhitespace): No longer passes firstLine to positionNewFloatOnLine.
(WebCore::LineOffsets::LineOffsets): Takes RenderBlock* and isFirstLine instead of left and right offsets.
(WebCore::LineOffsets::update): Extracted from findNextLineBreak and positionNewFloatOnLine.
(WebCore::LineOffsets::shrinkWidthForNewFloatIfNeeded): Extracted from positionNewFloatOnLine.
(WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine.
(WebCore::RenderBlock::positionNewFloatOnLine): Calls shrinkWidthForNewFloatIfNeeded and update and
no longer passes firstLine around.
2011-04-06 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: migrate debugger domain to the unified breakpoint location notion.
https://bugs.webkit.org/show_bug.cgi?id=57928
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::buildObjectForBreakpointCookie):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.prototype._breakpointResolved):
2011-04-07 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Benjamin Poulain.
[Qt] Mask the QStyle::State_Horizontal hint for vertical scrollbars.
When initializing a QStyleOptionSlider from a widget, the State_Horizontal
hint may get set depending on how that widget is laid out in its parent.
If this happens when drawing a vertical scrollbar, the hint is never
cleared and we end up painting a vertical scrollbar with horizontal arrows.
Covered by pixel tests which should no longer paint silly scrollbars.
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::styleOptionSlider):
2011-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
script-src should block inline script
https://bugs.webkit.org/show_bug.cgi?id=58012
Block inline scripts at the ScriptElement layer. This should catch
exactly the scripts we want to catch.
Test: http/tests/security/contentSecurityPolicy/inline-script-blocked.html
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- This patch also adds the ability to supply a CSP policy via a
<meta> tag. We'll update the name of the header once we've
finished implementing the spec.
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeScript):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowInlineScript):
* page/ContentSecurityPolicy.h:
2011-04-07 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Ryosuke Niwa.
Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
https://bugs.webkit.org/show_bug.cgi?id=57921
Moves the MouseEventWithHitTestResults::targetNode() method on to EventHandler, so
that the same logic can be used for a HitTestResult.
No visible changes, just cleanup, so no tests.
* page/EventHandler.cpp:
(WebCore::EventHandler::selectClosestWordFromMouseEvent):
(WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
(WebCore::EventHandler::handleMousePressEventTripleClick):
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::subframeForHitTestResult):
Made public static member, so that it can access targetNode(), and be accessed by
webkitwebview in gtk.
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::targetNode):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::sendContextMenuEvent):
* page/EventHandler.h:
* page/MouseEventWithHitTestResults.cpp:
(WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
* page/MouseEventWithHitTestResults.h:
* page/android/EventHandlerAndroid.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/brew/EventHandlerBrew.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/chromium/EventHandlerChromium.cpp:
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/efl/EventHandlerEfl.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/haiku/EventHandlerHaiku.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passSubframeEventToSubframe):
* page/wx/EventHandlerWx.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
2011-04-07 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: build mapping for formatted scripts based on keywords positions.
https://bugs.webkit.org/show_bug.cgi?id=57936
Mapping based on [\$\.\w]+ was not accurate because string literals representation
may be different in original and formatted scripts.
* inspector/front-end/ScriptFormatterWorker.js:
(buildMapping.regexp.b):
(buildMapping):
2011-04-07 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Spinbuttons become unclickable if right padding is large.
https://bugs.webkit.org/show_bug.cgi?id=56298
An inner-spin-button is put on the right border and ignores right
padding in RenderTextControlSingleLine::layout(), but forwardEvent()
checks if a point is in an area just right of an internal text block.
This inconsistency caused a bug that an inner-spin-button with large
padding didn't receive mouse events.
To fix this bug, we render spin buttons as layers, and remove manual
event forwarding code.
Test: fast/forms/input-number-large-padding.html
* css/html.css: Add "position:relative" to make a spin-button a layer.
(input::-webkit-inner-spin-button):
(input::-webkit-outer-spin-button):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::forwardEvent):
Remove manual event forwarding code.
2011-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP object-src should block plugin loads
https://bugs.webkit.org/show_bug.cgi?id=57283
This change is pretty straight-forward. It's slighly unclear to me
whether this patch is correct w.r.t. the code in DocumentWriter. I've
added a FIXME comment, and I'll investigate that case more in the future.
Test: http/tests/security/contentSecurityPolicy/object-src-none.html
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestPlugin):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
2011-04-06 Beth Dakin <bdakin@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=58009
Frame::scalePage() results in visual artifacts with scale factors less than 1
-and corresponding-
<rdar://problem/8683230>
Fall into the case where we fill with a background base color when there is a page
scale factor that is less than 1.
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
2011-04-06 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
AVF: MediaPlayerPrivateAVFoundationObjC should not use -[AVPlayerItem isPlaybackBufferEmpty]
https://bugs.webkit.org/show_bug.cgi?id=57982
Query our cached loaded time array instead of asking AVPlayerItem if its buffer is empty.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
2011-04-06 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
MediaPlayerPrivateAVFoundation does not change rate due to setRate().
https://bugs.webkit.org/show_bug.cgi?id=57919
Test: media/video-set-rate-from-pause.html
The base class of MediaPlayerPrivateAVFoundation does not actually change the rate
of the media; instead a subclass must do that work. So when setRate() is called,
inform a subclass through a new pure virtual updateRate() function that there's
work to be done.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::setRate): Call updateRate()
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateRate): Added. Set the requested rate.
2011-04-06 Dai Mikurube <dmikurube@chromium.org>
Reviewed by David Levin.
Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918
* Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
* GNUmakefile.am: Added QUOTA build flag
* WebCore.pri: Added QUOTA build flag
2011-04-06 Stephanie Lewis <slewis@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=57997
<rdar://problem/9187856> REGRESSION(r75555): ~5-7 MB increase in memory between iBench runs
Navigating away from a Scrolled page which queues a scroll event that is never dispatched.
Cancel all enqueued events when detaching the Document the events cannot keep the Document
alive.
No change in functionality so no new tests.
* dom/Document.cpp:
(WebCore::Document::detach):
* dom/EventQueue.cpp:
(WebCore::EventQueue::cancelQueuedEvents):
* dom/EventQueue.h:
2011-04-06 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/9084761> REGRESSION (r73993): Default Arabic line spacing has gotten very loose when the specified font is not Arabic
https://bugs.webkit.org/show_bug.cgi?id=58002
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit): The version of Geeza Pro in Snow Leopard
does not require the vertical metrics tweaks that were needed in Leopard. That the
tweaks were being applied went mostly unnoticed until r73993, because until then it
only affected cases where Geeza Pro was specified, not when it occurred as a fallback
font.
2011-04-06 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 57994 - Move guardRef functionality back to Document
https://bugs.webkit.org/show_bug.cgi?id=57994
Move the relevant code parts from TreeScope back into Document.
No new tests. (no new functionality)
* dom/Document.cpp:
(WebCore::Document::removedLastRef):
* dom/Document.h:
* dom/TreeScope.cpp:
(WebCore::TreeScope::destroyTreeScopeData):
* dom/TreeScope.h:
2011-04-06 Ian Henderson <ianh@apple.com>
Reviewed by Simon Fraser, Antti Koivisto.
Fast path for parsing simple CSS values
https://bugs.webkit.org/show_bug.cgi?id=57964
Add functions to parse simple color or dimension values, skipping the
overhead of full CSS parsing.
Change parseValue to a static method to avoid unnecessary allocation
of a CSSParser in the fast case.
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setProperty):
Changed to use the new, static parseValue method.
* css/CSSParser.cpp:
(WebCore::isColorPropertyID):
(WebCore::parseColorValue):
Parses any color accepted by the existing parseColor() static method.
We must handle color identifiers separately, since parseColor() will
change 'red' into 'rgb(255, 0, 0)'.
(WebCore::isSimpleLengthPropertyID):
(WebCore::parseSimpleLengthValue):
Parses a value of the form 'NNpx', 'NN%', or 'NN' (when strict is
false, or 'NN' is '0'). Returns false to fall back to the slow path.
(WebCore::CSSParser::parseValue):
* css/CSSParser.h:
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
Changed to use the new, static parseValue method.
2011-04-06 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Darin Adler.
Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
https://bugs.webkit.org/show_bug.cgi?id=27551
* config.h:
2011-04-06 Simon Fraser <simon.fraser@apple.com>
Reviewed by Antti Koivisto.
Some minor style resolution optimizations
https://bugs.webkit.org/show_bug.cgi?id=57996
A couple of minor optimizations to style-related code.
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::isCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::putDelegate):
Avoid calling cssPropertyName() twice when setting style on an element.
* css/CSSStyleSelector.cpp:
(WebCore::useSVGZoomRules):
(WebCore::CSSStyleSelector::applyProperty):
Avoid calling isSVGElement() for every property, since only a two properties
care about it.
2011-04-06 Ian Henderson <ianh@apple.com>
Reviewed by Antti Koivisto.
Unnecessary string allocation in CSSStyleDeclaration::setProperty
https://bugs.webkit.org/show_bug.cgi?id=57995
Pass the bool representing the property's importance directly instead
of constructing a string.
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::setProperty):
2011-04-06 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Steve Block.
Make the style of createFunctionOnlyCallback in V8 consistent with the JavaScriptCore version.
https://bugs.webkit.org/show_bug.cgi?id=57963
No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html
* bindings/v8/V8Utilities.h:
(WebCore::createFunctionOnlyCallback):
* bindings/v8/custom/V8GeolocationCustom.cpp:
(WebCore::V8Geolocation::getCurrentPositionCallback):
(WebCore::V8Geolocation::watchPositionCallback):
2011-04-06 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
WebKit2: Support Windows 7 Gestures
https://bugs.webkit.org/show_bug.cgi?id=49824
<rdar://problem/8689728>
Move WindowTouch.h from WebKit/win, so it can be used in both WebKit and WebKit2.
* WebCore.vcproj/WebCore.vcproj:
* platform/win/WindowsTouch.h: Copied from WebKit/win/WindowsTouch.h.
2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
https://bugs.webkit.org/show_bug.cgi?id=57974
We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
No new tests needed, just a config flag rename.
* features.pri:
2011-04-06 Tyler Close <tjclose@chromium.org>
Reviewed by Nate Chapin.
run-bindings-tests reference files out of sync with CodeGenerator*.pm
https://bugs.webkit.org/show_bug.cgi?id=57967
* bindings/scripts/test/V8/V8TestCallback.cpp:
2011-04-06 Asanka Herath <asanka@chromium.org>
Reviewed by Darin Fisher.
Add new TargetType: TargetIsFavicon
https://bugs.webkit.org/show_bug.cgi?id=57659
No new functionality added, so no additional tests.
* platform/network/ResourceRequestBase.h:
2011-04-06 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=57981
Update the column count and width computation algorithm for CSS3 multi-column layout
to match the revised pseudo-algorithm in the latest draft of the spec.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcColumnWidth):
2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
borderPaddingMarginStart and borderPaddingMarginEnd should take RenderInline
https://bugs.webkit.org/show_bug.cgi?id=57965
Changed the argument types of borderPaddingMarginStart and borderPaddingMarginEnd
from RenderBoxModelObject to RenderInline since they call marginStart and marginEnd
instead of marginStartForChild and marginEndForChild respectively.
Calling these two functions on RenderInline is okay because writing-mode cannot differ
from that of the containing block.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::borderPaddingMarginStart):
(WebCore::borderPaddingMarginEnd):
(WebCore::inlineLogicalWidth):
2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83039.
http://trac.webkit.org/changeset/83039
https://bugs.webkit.org/show_bug.cgi?id=57978
introduced a new regression in conjunction to
ReplaceSelectionCommand (Requested by rniwa on #webkit).
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::init):
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
2011-04-06 Naoki Takano <takano.naoki@gmail.com>
Reviewed by David Levin.
Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects
https://bugs.webkit.org/show_bug.cgi?id=27658
Test: fast/events/select-element.html
* dom/SelectElement.cpp:
(WebCore::nextValidIndex): Moved from elsewhere in the file to be used by other routines.
(WebCore::nextSelectableListIndexPageAway): Returns a selectable index one page away from the given index.
(WebCore::nextSelectableListIndex): Implemented with nextValidIndex.
And converted to a normal static function from a private function of SelectElement.
(WebCore::previousSelectableListIndex): Implemented with nextValidIndex.
And converted to a normal static function from a private function of SelectElement.
(WebCore::firstSelectableListIndex): Returns the first selectable index.
(WebCore::lastSelectableListIndex): Returns the last selectable index.
(WebCore::SelectElement::menuListDefaultEventHandler): Converted from C cast to C++ cast.
(WebCore::SelectElement::listBoxDefaultEventHandler): Adds support for PageUp/PageDown/Home/End with both single and multiple selection.
* dom/SelectElement.h:
(WebCore::SelectElement::): Remove nextSelectableListIndex() and previousSelectableListIndex().
* rendering/RenderListBox.h: Makes RenderListBox::size public so that PageUp/PageDown behavior can use the actual list size rather than that specified in HTML.
They can differ due to the minimum size imposed by RenderListBox.
2011-04-06 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=57975
The "More..." link for line clamping no longer shows up in Safari RSS. Fix the isLink() check
to just look at the style, so that it can find the InlineTextBox and not care that it's a child
of the link element and not the line box for the link element itself (since that line box got
culled).
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyLineClamp):
2011-04-06 Brady Eidson <beidson@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=57973 and https://bugs.webkit.org/show_bug.cgi?id=57973
WK2 icon database should be able to get a CGImage of a specific size
* platform/graphics/BitmapImage.h:
* platform/graphics/Image.h:
(WebCore::Image::getFirstCGImageRefOfSize):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::getFirstCGImageRefOfSize): Walk the frames of the image until reaching the
first frame of the requested size.
2011-04-06 Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
Reviewed by Kevin Ollivier.
[wx] Fix cursor handling so that we always call the chrome to set it.
https://bugs.webkit.org/show_bug.cgi?id=57972
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::setCursor):
2011-04-06 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=41445
Visited links painting with black background. Make sure that if the visited style has
the initial background color (transparent) set that we just use the unvisited color.
Added fast/history/visited-link-background-color.html
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::visitedDependentColor):
2011-04-06 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed Qt buildfix after r83079.
* WebCore.pro:
2011-04-06 Dean Jackson <dino@apple.com>
Reviewed by Chris Marrin.
https://bugs.webkit.org/show_bug.cgi?id=56936
Crash in ImplicitAnimation::~ImplicitAnimation
Make sure the style and start time waiting lists
are cleared in the CompositeAnimation destructor. This
way, no running transitions can be left in a state
where they are destroyed as the AnimationControllerPrivate
cleans up.
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::~CompositeAnimation):
2011-04-06 Robert Sesek <rsesek@chromium.org>
Reviewed by Alexey Proskuryakov.
Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
https://bugs.webkit.org/show_bug.cgi?id=54969
No change in behavior; no new tests.
* editing/TextIterator.cpp:
(WebCore::TextIterator::locationAndLengthFromRange): New method from duplicated code in WebKits
* editing/TextIterator.h:
* page/Frame.cpp:
(WebCore::Frame::rangeForPoint): New method from duplicated code in WebKits
2011-04-06 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Steve Block.
Factoring the creation of 'FunctionOnly' callbacks in JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=57770
Create a template from an existing functionality in JSGeolocationCustom.cpp
to be used by the custom bindings of both Geolocation and the Media Stream API.
V8 version of this bug: https://bugs.webkit.org/show_bug.cgi?id=57760
No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html
* Android.jscbindings.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/CallbackFunction.cpp: Added.
(WebCore::checkFunctionOnlyCallback):
* bindings/js/CallbackFunction.h: Added.
(WebCore::createFunctionOnlyCallback):
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSGeolocationCustom.cpp:
(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):
2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Implement fullscreen playback for the GStreamer backend.
https://bugs.webkit.org/show_bug.cgi?id=56826
Implement support for fullscreen playback when building the
Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
The implementation is done in FullScreenVideoQt alongside with
the Qt Multimedia support.
No new tests because layout tests cover it. They are not yet activated
but will be any time soon.
* platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
(FullScreenVideoWindow::FullScreenVideoWindow):
(FullScreenVideoWindow::setVideoElement):
(FullScreenVideoWindow::closeEvent):
(FullScreenVideoWindow::keyPressEvent):
(FullScreenVideoWindow::event):
(FullScreenVideoWindow::showFullScreen):
(FullScreenVideoWindow::hideCursor):
(FullScreenVideoWindow::showCursor):
2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dimitri Glazkov.
Bundle lineLeftOffset and lineRightOffset as a class
https://bugs.webkit.org/show_bug.cgi?id=57851
Added a new class LineOffsets that encapsulates lineLeftOffset and lineRightOffset.
The patch makes clear that lineLeftOffset and lineRightOffset are never read individually
and only the difference is used to compute the width.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::skipLeadingWhitespace): Takes LineOffsets instead of two integers.
(WebCore::LineOffsets::LineOffsets): Added.
(WebCore::LineOffsets::width): Added.
(WebCore::LineOffsets::setLeft): Added.
(WebCore::LineOffsets::setRight): Added.
(WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine.
(WebCore::RenderBlock::positionNewFloatOnLine): Takes LineOffsets instead of two integers.
2011-04-06 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=57916
Implement an optimization to the line box tree to cull out most of the intermediate
line boxes that can occur between the root line box and the leaves of the tree (images
and text).
RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
that starts off as false. Only if it gets flipped to true will there be any line boxes
created for that RenderInline.
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
Adjust the ordering of updateLayout calls to make sure rects aren't queried unless layout
is up to date.
* page/SpatialNavigation.cpp:
(WebCore::hasOffscreenRect):
(WebCore::nodeRectInAbsoluteCoordinates):
Add asserts in spatial navigation code to catch any future bad queries that might be made
for rectangles without layout being up to date.
* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::uniteIfNonZero):
* platform/graphics/FloatRect.h:
* platform/graphics/IntRect.cpp:
(WebCore::IntRect::uniteIfNonZero):
* platform/graphics/IntRect.h:
Add a new unite function that is useful for the render tree to FloatRect and IntRect. This
version allows rect unites to happen if either width or height is nonzero.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
Make sure rect-based hit testing properly adds in culled inline ancestors to the set of nodes
if content inside those inlines is hit.
* rendering/InlineBox.h:
(WebCore::InlineBox::logicalFrameRect):
Fix a bug in this function for obtaining the logical frame rect of an inline box.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
addToLine now also checks line gap in the line box tree optimization checks.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverflow):
* rendering/InlineFlowBox.h:
Rewritten to add the text box overflow to the text box itself.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::destroy):
Destroy has been changed to call a helper function to remove and destroy the line boxes that
is now called from one additional spot.
(WebCore::InlineTextBox::logicalOverflowRect):
(WebCore::InlineTextBox::setLogicalOverflowRect):
Text boxes now cache their own overflow in a global hash table.
(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
Changed to not assume that the parent line box's renderer is the RenderText's immediate
parent, since intermediate line boxes may have been culled.
(WebCore::InlineTextBox::paint):
Paint now properly checks only the text box overflow instead of the parent line box's overflow.
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::logicalTopVisualOverflow):
(WebCore::InlineTextBox::logicalBottomVisualOverflow):
(WebCore::InlineTextBox::logicalLeftVisualOverflow):
(WebCore::InlineTextBox::logicalRightVisualOverflow):
New accessors to obtain overflow for inline text boxes.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
updateFirstLetter now removes text boxes from the line box tree before it destroys them, since those
text boxes may not have anything in between them and the block that contains the inline first letter
container.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
The culling optimization is done here. Only if the RenderInline says that boxes are allowed will they
be created.
(WebCore::RenderBlock::layoutInlineChildren):
The state of the RenderInline is updated here, in case it is discovered that line boxes are now needed.
This is done before any lines are built.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
The new m_alwaysCreateLineBoxes flag has been added to the constructor.
(WebCore::RenderInline::styleDidChange):
An initial update of the m_alwaysCreateLineBoxes happens here for things that can be checked immediately
(like having a layer, borders, padding, margins or backgrounds). Some checks that depend on examining
the RenderInline's parent (including first line styles) happen later in layoutInlineChildren.
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
The function called by layoutInlineChildren to check parent and child style differences (e.g., font,
vertical alignment, line height, etc.).
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::culledInlineAbsoluteRects):
absoluteRects calls culledInlineAbsoluteRects when m_alwaysCreateLineBoxes is false.
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::culledInlineAbsoluteQuads):
absoluteQuads calls culledInlineAbsoluteQuads when m_alwaysCreateLineBoxes is false.
(WebCore::RenderInline::offsetLeft):
(WebCore::RenderInline::offsetTop):
offsetLeft and offsetTop now check descendant renderers when m_alwaysCreateLineBoxes is false.
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::culledInlineBoundingBox):
lineBoundingBox calls culledInlineBoundingBox when m_alwaysCreateLineBoxes is false.
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
Helpers that return the first and last line box descendants. Used by firstLineBoxIncludingCulling and
lastLineBoxIncludingCulling (which are in turn called by offsetLeft and offsetTop).
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
linesVisualOverflowBoundingBox calls culledInlineVisualOverflowBoundingBox when m_alwaysCreateLineBoxes is false.
(WebCore::RenderInline::clippedOverflowRectForRepaint):
The initial bailout check is now done using firstLineBoxIncludingCulling instead of just firstLineBox.
(WebCore::RenderInline::dirtyLineBoxes):
dirtyLineBoxes now crawls into descendants to figure out which root lines to dirty when
m_alwaysCreateLineBoxes is false.
(WebCore::RenderInline::createAndAppendInlineFlowBox):
Clear the m_alwaysCreateLineBoxes if a box gets added anyway. This happens for leaf inline flows and also
when line-box-contain is set to an unusual value.
(WebCore::RenderInline::addFocusRingRects):
Used culledInlineAbsoluteRects in place of the line box walk when m_alwaysCreateLineBoxes is false.
* rendering/RenderInline.h:
(WebCore::RenderInline::firstLineBoxIncludingCulling):
(WebCore::RenderInline::lastLineBoxIncludingCulling):
Helpers used in a few places (like offsetLeft and offsetTop), mostly in places where the existence of a box
is all that needs checking.
(WebCore::RenderInline::alwaysCreateLineBoxes):
(WebCore::RenderInline::setAlwaysCreateLineBoxes):
Functions for getting and setting the m_alwaysCreateLineBoxes flag.
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
Modified to use firstLineBoxIncludingCulling and lastLineBoxIncludingCulling to ensure the right set of
lines get dirtied.
* rendering/RenderText.cpp:
(WebCore::RenderText::removeAndDestroyTextBoxes):
New helper invoked by destroy and also from updateFirstLetter.
(WebCore::RenderText::destroy):
Changed to call removeAndDestroyTextBoxes.
(WebCore::RenderText::absoluteRects):
Fixed to be properly physical instead of logical.
(WebCore::RenderText::linesVisualOverflowBoundingBox):
New implementation for RenderText that gives the bounding box of the text boxes including overflow from
shadows, glyphs, text-stroke, etc. Used by RenderInline::culledInlineVisualOverflowBoundingBox.
* rendering/RenderText.h:
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::RenderSVGInline):
RenderSVGInline always sets m_alwaysCreateLineBoxes to true so that SVG is unaffected by this optimization.
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
Move the isInlineFlowBox asserts to after the generated content skips, since the generated content boxes are
now InlineTextBoxes (the enclosing InlineFlowBoxes got culled).
2011-04-05 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
REGRESSION: Drag & Drop Gmail Attachments doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=57909
<rdar://problem/9103220>
In WebKit2 we cannot rely on the value returned by platformData() that
on Mac returns an NSDraggingInfo object. This is available only in the UI
process. Therefore we should use m_pasteboard instead.
We cannot change what platformData() returns on Mac, since there are
delegate methods that receive a NSDraggingInfo object (only in WebKit).
* platform/DragData.h:
(WebCore::DragData::pasteboard): Added.
* platform/mac/ClipboardMac.mm:
(WebCore::Clipboard::create): Changed to use pasteboard() instead of platformData().
* platform/mac/DragDataMac.mm:
(WebCore::DragData::asColor): Replaced references to m_platformData with m_pasteboard.
(WebCore::DragData::asURL): Same as above.
2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Darin Adler.
ClipboardWin has unused variables "ExceptionCode ec"
https://bugs.webkit.org/show_bug.cgi?id=57952
Remove the unused variable.
* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::declareAndWriteDragImage):
(WebCore::ClipboardWin::writePlainText):
2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dimitri Glazkov.
Split getBorderPaddingMargin into two functions
https://bugs.webkit.org/show_bug.cgi?id=57947
* rendering/RenderBlockLineLayout.cpp:
(WebCore::borderPaddingMarginStart): Extracted from getBorderPaddingMargin.
(WebCore::borderPaddingMarginEnd): Ditto.
(WebCore::inlineLogicalWidth): Calls borderPaddingMarginStart and borderPaddingMarginEnd.
(WebCore::RenderBlock::findNextLineBreak): Ditto.
2011-04-06 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
[Refactoring] <progress> should not have manual layout code.
https://bugs.webkit.org/show_bug.cgi?id=57801
- Simplified RenderProgress, removing its custom layout code
- Introducing ProgressValueElement and ProgressBarElement, replacing
ProgressBarValueElement.
Now the structure is almost identical to <meter>,
other than:
- RenderProgress has animated painting, thus manages its own timer.
- Both ProgressValueElement and ProgressBarElement has pseudo classes
which don't changes during its lifetime.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/html.css:
(progress):
(progress::-webkit-progress-bar):
(progress::-webkit-progress-value):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::~HTMLProgressElement):
(WebCore::HTMLProgressElement::create):
(WebCore::HTMLProgressElement::attach):
(WebCore::HTMLProgressElement::didElementStateChange):
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLProgressElement.h:
* html/shadow/ProgressShadowElement.cpp: Copied from Source/WebCore/html/shadow/ProgressBarValueElement.h.
(WebCore::ProgressShadowElement::ProgressShadowElement):
(WebCore::ProgressShadowElement::progressElement):
(WebCore::ProgressShadowElement::rendererIsNeeded):
(WebCore::ProgressBarElement::shadowPseudoId):
(WebCore::ProgressValueElement::shadowPseudoId):
(WebCore::ProgressValueElement::setWidthPercentage):
* html/shadow/ProgressShadowElement.h: Renamed from Source/WebCore/html/shadow/ProgressBarValueElement.h.
(WebCore::ProgressBarElement::ProgressBarElement):
(WebCore::ProgressBarElement::create):
(WebCore::ProgressValueElement::ProgressValueElement):
(WebCore::ProgressValueElement::create):
* rendering/RenderProgress.cpp:
(WebCore::RenderProgress::RenderProgress):
(WebCore::RenderProgress::updateFromElement):
(WebCore::RenderProgress::animationTimerFired):
* rendering/RenderProgress.h:
(WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):
(WebCore::RenderProgress::canHaveChildren):
2011-04-06 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Do not reference AccessibilityRenderObject from platform dependent code
https://bugs.webkit.org/show_bug.cgi?id=57955
Do not reference AccessibilityRenderObject from platform specific code
Added new virtual functions to AccessibilityObject.h and removed
explicit references to AccessibilityRenderObject from GTK code.
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::renderer): New virtual method,
returning 0 by default. Overriden by AccessibilityRenderObject.
(WebCore::AccessibilityObject::correspondingLabelForControlElement):
New virtual method, returning 0 by default. It complements the
already present method correspondingControlForLabelElement().
* accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::renderer): Made virtual.
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::emitTextChanged): Reference AccessibilityObject,
instead of AccessibilityRenderObject.
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
Ditto.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_name): Do not reference
AccessibilityRenderObject.
(webkit_accessible_get_description): Ditto.
(setAtkRelationSetFromCoreObject): Ditto.
(optionFromList): Ditto.
(optionFromSelection): Ditto.
(webkit_accessible_selection_clear_selection): Ditto.
(webkit_accessible_selection_get_selection_count): Ditto.
(webkit_accessible_selection_select_all_selection): Ditto.
(textForObject): Ditto.
(webkit_accessible_text_get_text): Ditto.
(getPangoLayoutForAtk): Ditto.
(webkit_accessible_text_get_caret_offset): Ditto.
(baselinePositionForRenderObject): Ditto.
(getAttributeSetForAccessibilityObject): Ditto.
(accessibilityObjectLength): Ditto.
(getSelectionOffsetsForObject): Ditto.
(webkit_accessible_text_set_selection): Ditto.
(webkit_accessible_text_set_caret_offset): Ditto.
(webkit_accessible_table_get_caption): Ditto.
(getInterfaceMaskFromObject): Ditto.
* accessibility/gtk/WebKitAccessibleHyperlink.cpp:
(getRangeLengthForObject): Ditto.
Removed unused renderer() method from AccessibilityMenuList.
* accessibility/AccessibilityMenuList.h: Removed unused method.
* accessibility/AccessibilityMenuList.cpp: Removed unused method.
2011-04-06 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Javascipt warning link expand and overlap with icons in js console
https://bugs.webkit.org/show_bug.cgi?id=57939
* inspector/front-end/inspector.js:
(WebInspector.linkifyURLAsNode):
2011-04-06 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Beautify parameter names in Inspector.json (CSS domain)
https://bugs.webkit.org/show_bug.cgi?id=57931
* inspector/Inspector.json:
2011-04-06 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
[Mac] WebCore need to notify AppKit spell checker after user has modified autocorrected text.
https://bugs.webkit.org/show_bug.cgi?id=57665
<rdar://problem/7350477>
We need to track how user modified an autocorrected word. If he changed it back to original
text, we want to record AutocorrectionReverted response. And if he changed it to something
else, we want to record AutocorrectionEdited response.
To achieve this, we need to distringuish between text replacement caused by autocorrection
from that due to other causes, such as reversion, text substitution, etc. So we added a new
marker type "Autocorrected". We also need to be able to check for correction, even when we
don't intend to actually carry out replacement. For this, we introduced a new TextCheckingOption
value, "CheckForCorrection".
We also added DocumentMarkerController::markersInRange() to retrieve a vector of markers in
specified range, and of specified type.
* dom/DocumentMarker.h:
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::markersInRange):
(WebCore::DocumentMarkerController::hasMarkers):
* dom/DocumentMarkerController.h:
* editing/Editor.cpp:
(WebCore::markerTypesForAutocorrection):
(WebCore::markersHaveIdenticalDescription):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::recordSpellcheckerResponseForModifiedCorrection):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::markMisspellingsAndBadGrammar):
(WebCore::Editor::applyCorrectionPanelInfo):
(WebCore::Editor::unappliedSpellCorrection):
(WebCore::Editor::textCheckingTypeMaskFor):
* editing/Editor.h:
* editing/SpellingCorrectionCommand.cpp:
(WebCore::SpellingCorrectionCommand::doApply):
2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83045.
http://trac.webkit.org/changeset/83045
https://bugs.webkit.org/show_bug.cgi?id=57953
Broke win layout tests (Requested by podivilov on #webkit).
* GNUmakefile.am:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
Moved the declaration of positionNewFloatOnLine in RenderBlock.h after r83042.
* rendering/RenderBlock.h:
2011-03-27 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Re-draw the <input> fields for Qt Mobile Theme to do not override elements already styled.
https://bugs.webkit.org/show_bug.cgi?id=57007
* CodeGenerators.pri:
* css/themeQtMobile.css: Removed.
* platform/qt/QtMobileWebStyle.cpp:
(drawRectangularControlBackground):
(QtMobileWebStyle::drawPrimitive):
(QtMobileWebStyle::drawComplexControl):
* platform/qt/QtMobileWebStyle.h:
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::paintTextField):
2011-04-06 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
[Mac] When autocorrection occurs without showing correction panel, WebCore need to post accessibility notification.
https://bugs.webkit.org/show_bug.cgi?id=57800
<rdar://problem/9218223>
Defined a new accessibility notification type, AXAutocorrectionOccured. Editor::markAllMisspellingsAndBadGrammarInRanges()
now posts said notification when any autocorrection or text replacement (e.g. replacing "(c)" with copyright mark) takes place.
* accessibility/AXObjectCache.h:
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
2011-04-06 Martin Robinson <mrobinson@igalia.com>
Build fix for debug Cairo builds.
* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::pushImageMask): Update the reference to m_maskInformation.
2011-04-06 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Style fix for QtMobileWebStyle.h
https://bugs.webkit.org/show_bug.cgi?id=57708
* platform/qt/QtMobileWebStyle.h:
2011-04-06 Andras Becsi <abecsi@webkit.org>
Reviewed by Darin Adler.
Invalid color #{predefined colorName} is accepted by the CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=15360
Test: fast/css/invalid-predefined-color.html
* css/CSSGrammar.y: Remove superfluous hexcolor production.
* css/tokenizer.flex: A hexadecimal number should consist of [a-fA-F0-9] values ({h}).
2011-03-30 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add test for script formatter worker.
https://bugs.webkit.org/show_bug.cgi?id=57447
Test: inspector/debugger/script-formatter.html
* GNUmakefile.am:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
2011-04-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Cairo] Hide the details of image masking in PlatformContextCairo
https://bugs.webkit.org/show_bug.cgi?id=57878
No new tests. This is just a refactor.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::savePlatformState): Call into PlatformContextCairo now to
do the actual cairo_save. Remove information about image masking.
(WebCore::GraphicsContext::restorePlatformState): Call into PlatformContextCairo now to
do the actual cairo_restore. Remove information about image masking.
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::clip): Use PlatformContextCairo here now.
* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::restore): Added.
(WebCore::PlatformContextCairo::save): Added.
(WebCore::PlatformContextCairo::pushImageMask): Added.
* platform/graphics/cairo/PlatformContextCairo.h:
(WebCore::ImageMaskInformation::update): Moved from GraphicsContextPlatformPrivateCairo.h.
(WebCore::ImageMaskInformation::isValid): Ditto.
(WebCore::ImageMaskInformation::maskSurface): Ditto.
(WebCore::ImageMaskInformation::maskRect): Ditto.
2011-04-02 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Radio buttons are showing wrong with mobile theme
https://bugs.webkit.org/show_bug.cgi?id=57706
* platform/qt/QtMobileWebStyle.cpp:
(QtMobileWebStyle::drawRadio):
2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Move RenderBlock::positionNewFloatOnLine to RenderBlockLineLayout.cpp
https://bugs.webkit.org/show_bug.cgi?id=57943
* rendering/RenderBlock.cpp: Removed positionNewFloatOnLine.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::positionNewFloatOnLine): Moved from RenderBlock.cpp
2011-04-05 Diego Gonzalez <diegohcg@webkit.org>
Buildfix after r82125.
[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087
* platform/qt/QtMobileWebStyle.cpp:
(QtMobileWebStyle::findChecker):
(QtMobileWebStyle::findRadio):
(QtMobileWebStyle::findComboButton):
2011-04-06 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: inline script imports in ScriptFormatterWorker.js so it works in Safari release.
https://bugs.webkit.org/show_bug.cgi?id=57641
* WebCore.xcodeproj/project.pbxproj:
* gyp/streamline-inspector-source.sh:
* inspector/combine-javascript-resources.pl: Renamed from Source/WebCore/combine-javascript-resources.
* inspector/inline-javascript-imports.py: Added.
2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
https://bugs.webkit.org/show_bug.cgi?id=57872
r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.
r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
avoiding the tab span.
Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.
Test: editing/inserting/insert-paragraph-separator-tab-span.html
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph
separator into a paragraph separator.
2011-04-06 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Add member functions for determining line/paragraph separation to InlineIterator
https://bugs.webkit.org/show_bug.cgi?id=57938
Adding atTextParagraphSeparator and atParagraphSeparator inline convenience functions to
InlineIterator, where it makes far more sense for them to be. Also moving
shouldPreserveNewline to RenderObject and renaming it preservesNewline.
No new tests as this provides no new functionality.
* rendering/InlineIterator.h:
(WebCore::InlineIterator::atTextParagraphSeparator):
(WebCore::InlineIterator::atParagraphSeparator):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::requiresLineBox):
(WebCore::RenderBlock::findNextLineBreak):
* rendering/RenderObject.h:
(WebCore::RenderObject::preservesNewline):
2011-04-05 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Range insertNode function does not update content in the inspector
https://bugs.webkit.org/show_bug.cgi?id=57829
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
2011-04-06 Alejandro G. Castro <alex@igalia.com>
Fix GTK3 compilation after r82962.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::paintToggle):
(WebCore::renderButton):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::paintTextField):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::paintProgressBar):
(WebCore::paintSpinArrowButton):
* platform/gtk/ScrollbarThemeGtk3.cpp:
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
2011-04-06 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Extensions API] remove inspectedPage.* events
https://bugs.webkit.org/show_bug.cgi?id=57763
- Removed webInspector.inspectedPage.* events
- moved onNavigated to webInspector.resources
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI):
(WebInspector.injectedExtensionAPI.InspectedWindow):
* inspector/front-end/ExtensionAPISchema.json:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.notifyInspectedURLChanged):
* inspector/front-end/inspector.js:
(WebInspector.domContentEventFired):
(WebInspector.loadEventFired):
(WebInspector.inspectedURLChanged):
2011-04-06 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Antti Koivisto.
Add <head> to the simpleUserAgentStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=57915
* css/CSSStyleSelector.cpp:
(WebCore::elementCanUseSimpleDefaultStyle): add head to the
simple stylesheet, display:none.
2011-04-05 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
https://bugs.webkit.org/show_bug.cgi?id=57856
Test: inspector/profiler/detailed-heapshots-summary.html
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid):
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.doSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
2011-04-06 Anders Bakken <agbakken@gmail.com>
Reviewed by David Levin.
[Qt] SmartReplaceQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40261
This patch does not require new test cases.
* editing/qt/SmartReplaceQt.cpp:
(WebCore::isCharacterSmartReplaceExempt):
2011-04-06 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Ryosuke Niwa.
REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element
https://bugs.webkit.org/show_bug.cgi?id=57755
Test: editing/execCommand/insert-line-break-onload.html
* editing/TypingCommand.cpp:
(WebCore::canAppendNewLineFeed): Added null pointer check for rootEditableElement().
2011-04-05 Antti Koivisto <antti@apple.com>
Reviewed by Cameron Zwarich.
Avoid calling currentTime() from FrameView::adjustedDeferredRepaintDelay() when repaints are deferred
https://bugs.webkit.org/show_bug.cgi?id=57914
Don't call adjustedDeferredRepaintDelay unnecessarily.
* page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::adjustedDeferredRepaintDelay):
2011-04-05 Steve VanDeBogart <vandebo@chromium.org>
Reviewed by David Levin.
Update call to SkAdvancedTypefaceMetrics to new API.
https://bugs.webkit.org/show_bug.cgi?id=57887
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::emSizeInFontUnits):
2011-04-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Rename event dispatching functions after form event removal
https://bugs.webkit.org/show_bug.cgi?id=57908
* dom/InputElement.cpp:
(WebCore::InputElement::setValueFromRenderer):
* dom/Node.cpp:
(WebCore::Node::dispatchChangeEvent):
(WebCore::Node::dispatchInputEvent):
(WebCore::Node::defaultEventHandler):
* dom/Node.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
(WebCore::HTMLFormControlElement::dispatchFormControlInputEvent):
(WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
Renamed "events" to "event", since there is only one event to dispatch now.
2011-04-05 Anders Bakken <agbakken@gmail.com>
Reviewed by David Levin.
[Qt] DragControllerQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40258
This patch does not require new test cases.
* page/qt/DragControllerQt.cpp:
(WebCore::DragController::dragOperation):
2011-04-05 Steve VanDeBogart <vandebo@chromium.org>
Reviewed by David Levin.
Update deprecated include: platform_canvas_win.h to platform_canvas.h.
https://bugs.webkit.org/show_bug.cgi?id=57896
* platform/graphics/chromium/FontChromiumWin.cpp:
2011-04-05 Darin Adler <darin@apple.com>
Try to fix Leopard bots.
* platform/mac/HTMLConverter.mm: Fix #if back the way Alexey seems
to have intended it.
2011-04-05 Darin Adler <darin@apple.com>
Try to fix Leopard bots.
* platform/mac/HTMLConverter.mm: Move declarations of new functions
inside the appropriate #if.
2011-04-05 Adrienne Walker <enne@google.com>
Reviewed by Tony Chang.
Correctly set color when using skia's fillRoundedRect.
https://bugs.webkit.org/show_bug.cgi?id=57907
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::fillRoundedRect):
2011-04-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Move attributedStringFromRange down to WebCore
https://bugs.webkit.org/show_bug.cgi?id=57905
No change in behavior, so no new tests.
Also tweaked HTMLConverter to not use methods defined in WebKit.
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/HTMLConverter.h:
* platform/mac/HTMLConverter.mm:
(-[WebHTMLConverter _newTabForElement:]):
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(+[WebHTMLConverter editingAttributedStringFromRange:]):
(fileWrapperForURL):
(fileWrapperForElement):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection):
* platform/mac/WebNSAttributedStringExtras.h: Copied from Source/WebKit/mac/Misc/WebNSAttributedStringExtras.h.
* platform/mac/WebNSAttributedStringExtras.mm: Copied from Source/WebKit/mac/Misc/WebNSAttributedStringExtras.mm.
(WebCore::attributedStringByStrippingAttachmentCharacters):
2011-04-05 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Rename variables in border drawing code for readability
https://bugs.webkit.org/show_bug.cgi?id=57894
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::drawBoxSideFromPath):
(WebCore::RenderObject::drawArcForBoxSide):
2011-04-05 Antti Koivisto <antti@apple.com>
Reviewed by Darin Adler.
Defer repaints during style recalc
https://bugs.webkit.org/show_bug.cgi?id=57886
This reduces the need to do (often expensive) platform surface invalidation.
We already do this during layout but style recalculation may trigger
invalidation as well.
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
2011-04-05 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
HTML5 Player Has no Fullscreen Mode
https://bugs.webkit.org/show_bug.cgi?id=57795
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::supportsFullscreen): Call the new ChromeClient API
supportsFullScreenForElement() before the old supportsFullScreenForNode() API.
2011-04-05 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix data url's status and timing the network panel.
https://bugs.webkit.org/show_bug.cgi?id=53066
Added data url support for status of network resources.
* English.lproj/localizedStrings.js:
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.isDataURL):
2011-04-04 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
[V8] Keep dirty primitive CSS values alive.
https://bugs.webkit.org/show_bug.cgi?id=57810
* bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
2011-04-05 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adele Peterson.
Add a fast path for simple color backgrounds
https://bugs.webkit.org/show_bug.cgi?id=57773
Add a fast path for drawing simple color backgrounds. It's
faster to fill a path or rect than it is to set up a clip,
and then paint the rect.
No visible behavior change so no new tests.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
2011-04-05 Patrick Gansterer <paroga@webkit.org>
Unreviewed EFL build fix for r82962.
* CMakeListsEfl.txt:
2011-04-05 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add support for offline audio rendering to AudioContext API
https://bugs.webkit.org/show_bug.cgi?id=57676
No new tests since audio API is not yet implemented.
* DerivedSources.make:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContextConstructor::constructJSAudioContext):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
* dom/Event.cpp:
(WebCore::Event::isOfflineAudioCompletionEvent):
* dom/Event.h:
* dom/EventTarget.cpp:
(WebCore::EventTarget::toAudioContext):
* dom/EventTarget.h:
* platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::waitForLoaderThreadCompletion):
* platform/audio/HRTFDatabaseLoader.h:
(WebCore::HRTFDatabaseLoader::loader):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createOfflineContext):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::constructCommon):
(WebCore::AudioContext::document):
(WebCore::AudioContext::scriptExecutionContext):
(WebCore::AudioContext::toAudioContext):
(WebCore::AudioContext::startRendering):
(WebCore::AudioContext::fireCompletionEvent):
* webaudio/AudioContext.h:
(WebCore::AudioContext::isOfflineContext):
(WebCore::AudioContext::eventTargetData):
(WebCore::AudioContext::ensureEventTargetData):
(WebCore::AudioContext::refEventTarget):
(WebCore::AudioContext::derefEventTarget):
* webaudio/AudioContext.idl:
* webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
* webaudio/AudioDestinationNode.h:
(WebCore::AudioDestinationNode::reset):
(WebCore::AudioDestinationNode::numberOfChannels):
* webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::setBuffer):
* webaudio/DefaultAudioDestinationNode.cpp: Added.
(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
(WebCore::DefaultAudioDestinationNode::~DefaultAudioDestinationNode):
(WebCore::DefaultAudioDestinationNode::initialize):
(WebCore::DefaultAudioDestinationNode::uninitialize):
(WebCore::DefaultAudioDestinationNode::startRendering):
* webaudio/DefaultAudioDestinationNode.h: Added.
(WebCore::DefaultAudioDestinationNode::create):
(WebCore::DefaultAudioDestinationNode::sampleRate):
* webaudio/OfflineAudioCompletionEvent.cpp: Added.
(WebCore::OfflineAudioCompletionEvent::create):
(WebCore::OfflineAudioCompletionEvent::OfflineAudioCompletionEvent):
(WebCore::OfflineAudioCompletionEvent::~OfflineAudioCompletionEvent):
(WebCore::OfflineAudioCompletionEvent::isOfflineAudioCompletionEvent):
* webaudio/OfflineAudioCompletionEvent.h: Added.
(WebCore::OfflineAudioCompletionEvent::renderedBuffer):
* webaudio/OfflineAudioCompletionEvent.idl: Added.
* webaudio/OfflineAudioDestinationNode.cpp: Added.
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::initialize):
(WebCore::OfflineAudioDestinationNode::uninitialize):
(WebCore::OfflineAudioDestinationNode::startRendering):
(WebCore::OfflineAudioDestinationNode::renderEntry):
(WebCore::OfflineAudioDestinationNode::render):
(WebCore::OfflineAudioDestinationNode::notifyCompleteDispatch):
(WebCore::OfflineAudioDestinationNode::notifyComplete):
* webaudio/OfflineAudioDestinationNode.h: Added.
(WebCore::OfflineAudioDestinationNode::create):
(WebCore::OfflineAudioDestinationNode::sampleRate):
2011-04-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150
Add a PlatformContextCairo which right now stores the cairo_t* for a
GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
and image masking layers into this PlatformContextCairo class.
No new tests. This patch is only a code cleanup.
* GNUmakefile.am:
* platform/graphics/GraphicsContext.h: The platform context is no longer a
cairo_t, but our new class the PlatformContextCairo.
* platform/graphics/cairo/ContextShadowCairo.cpp: Updated to reflect new class.j
* platform/graphics/cairo/FontCairo.cpp: Ditto.
* platform/graphics/cairo/GradientCairo.cpp: Ditto.
* platform/graphics/cairo/GraphicsContextCairo.cpp: Mostly mechanical
changes which now reference platformContext()->cr() to get the cairo_t.
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Now hold the
PlatformContextCairo instead of the cairo_t.
* platform/graphics/cairo/ImageBufferCairo.cpp: Update to reflect new class.
* platform/graphics/cairo/ImageCairo.cpp: Ditto.
* platform/graphics/cairo/PathCairo.cpp: Ditto.
* platform/graphics/cairo/PlatformContextCairo.cpp: Added.
* platform/graphics/cairo/PlatformContextCairo.h: Added.
* platform/graphics/gtk/FontGtk.cpp: Update to reflect new class.
* platform/graphics/gtk/IconGtk.cpp: Ditto.
* platform/graphics/win/GraphicsContextCairoWin.cpp: Now fill out
m_data with a private section containing the platform context instead of
just a cairo_t.
* platform/gtk/RenderThemeGtk.cpp: Update to reflect new class.
* platform/gtk/WidgetRenderingContext.cpp: Ditto.
(WebCore::WidgetRenderingContext::~WidgetRenderingContext): Ditto.
* plugins/gtk/PluginViewGtk.cpp: Ditto.
2011-04-05 David Dorwin <ddorwin@chromium.org>
Reviewed by David Levin.
Fullscreen code assumes all layers use GPU compositing when USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=57400
Check whether the full screen renderer layer is being composited by the GPU before assuming that the backing is valid.
Accelerated compositing may be compiled in but disabled at runtime or for some elements.
Tests: Fullscreen layout tests on Chromium.
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Regression: Invalid write in SVGTextLayoutEngine
https://bugs.webkit.org/show_bug.cgi?id=57721
Properly stop layout if all metrics object refer to zero-width/height characters,
which can happen for instance when using <text font-size="0">.
Test: svg/text/font-size-null-assertion.svg
* rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes):
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics):
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
Removed WebCore::SpellCheckingResult and replaced it with TextCheckingResult.
This change also added TextCheckerClient::requestCheckingOfString() should have
TextCheckingTypeMask as a parameter to control text checking type.
* WebCore.exp.in:
* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::textCheckingTypeMaskFor): Extracted from markAllMisspellingsAndBadGrammarInRanges()
* editing/SpellChecker.cpp:
(WebCore::SpellChecker::requestCheckingFor): Added a parameter.
(WebCore::SpellChecker::markAt): Extracted from didCheck(), Added a check for the GrammarDetail object.
(WebCore::SpellChecker::didCheck):
* editing/SpellChecker.h:
* loader/EmptyClients.h:
(WebCore::EmptyTextCheckerClient::checkTextOfParagraph):
(WebCore::EmptyTextCheckerClient::requestCheckingOfString):
* platform/text/TextCheckerClient.h:
2011-04-04 Antti Koivisto <antti@apple.com>
Reviewed by Sam Weinig.
Print stylesheet on nytimes.com loads too early
https://bugs.webkit.org/show_bug.cgi?id=57814
Don't load resources with Very Low priority until there are no other resources to
load for the host (or until document is complete enough that we stop limiting requests).
No tests, this is difficult to observe reliably with our current testing infrastructure.
Verified working with Wireshark.
* loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::servePendingRequests):
(WebCore::ResourceLoadScheduler::HostInformation::limitRequests):
* loader/ResourceLoadScheduler.h:
2011-04-04 Steve Block <steveblock@google.com>
Reviewed by Dimitri Glazkov.
JavaInstance should be a pure interface
https://bugs.webkit.org/show_bug.cgi?id=55383
This patch fixes JavaInstance for V8 only.
It factors out a JavaInstance interface which does not use JNI
types. This will allow the Java bridge to be used with objects
that don't use JNI directly. The existing jobject-backed
implementation is moved to a new JavaInstanceJobject class which
implements the interface.
No new tests, refactoring only.
* Android.v8bindings.mk:
* WebCore.gypi:
* bridge/jni/JobjectWrapper.h:
* bridge/jni/v8/JNIUtilityPrivate.cpp:
(JSC::Bindings::jvalueToJavaValue):
(JSC::Bindings::javaValueToJvalue):
* bridge/jni/v8/JavaInstanceJobjectV8.cpp:
(JavaInstanceJobject::JavaInstanceJobject):
(JavaInstanceJobject::~JavaInstanceJobject):
(JavaInstanceJobject::begin):
(JavaInstanceJobject::end):
(JavaInstanceJobject::getClass):
(JavaInstanceJobject::invokeMethod):
(JavaInstanceJobject::getField):
* bridge/jni/v8/JavaInstanceJobjectV8.h: Copied from Source/WebCore/bridge/jni/v8/JavaInstanceV8.h.
(JSC::Bindings::JavaInstanceJobject::javaInstance):
* bridge/jni/v8/JavaInstanceV8.h:
(JSC::Bindings::JavaInstance::~JavaInstance):
2011-04-05 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Move MouseEvent-dispatching logic into MouseEventDispatchMediator.
https://bugs.webkit.org/show_bug.cgi?id=57639
Refactoring, covered by existing tests.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent): Moved useful assertion here
from dispatchMouseEvent.
(WebCore::EventDispatcher::adjustRelatedTarget): Converted into a method.
* dom/EventDispatcher.h: Adjusted decls.
(WebCore::EventDispatcher::node): Added.
* dom/MouseEvent.cpp:
(WebCore::MouseEvent::create): Moved useful assertion here from
dispatchMouseEvent.
(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator): Added.
(WebCore::MouseEventDispatchMediator::event): Added.
(WebCore::MouseEventDispatchMediator::dispatchEvent): Added.
* dom/MouseEvent.h:
(WebCore::MouseEvent::setRelatedTarget): Added.
* dom/Node.cpp:
(WebCore::Node::dispatchMouseEvent): Changed to use MouseEventDispatchMediator.
2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Adam Roben & Dirk Schulze.
text-tspan-02-b.svg from SVG 1.1 2nd edition fails
https://bugs.webkit.org/show_bug.cgi?id=57831
We were not spanning rotation values correcty accross text children, which resulted in text-span-02-b.svg misrendering.
While rewriting the rotation specific code, it came apparent that the LayoutScope concept is flawed in general and
should be replaced by a global list of x/y/dx/dy/rotate values for the whole text subtree. This makes it much simpler
to implement the demand that the last rotation value spans the whole scope. A follow-up patch will optimize the
required memory.
Example:
<text rotate="10,20,999,50">AB<tspan rotate="30">CDE</>FGH</text>
text: A B C D E F G H
rotate="10 20 30 30 30 50 50 50"
Tests: svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg
svg/text/text-midpoint-split-bug.svg
* rendering/RenderBlockLineLayout.cpp: Move SVG specific midpoint creation after the non-SVG specific code that may mutate the midpoints. otherwhise we end up in an
(WebCore::RenderBlock::findNextLineBreak): inconsistent state. We were intereferring with the ignoreSpaces code resulting in wrong truncations - covered by new testcase.
* rendering/svg/SVGTextLayoutAttributes.cpp:
(WebCore::SVGTextLayoutAttributes::reserveCapacity): Also reserveCapacity for the text metrics list (minor optimization).
(WebCore::SVGTextLayoutAttributes::fillWithEmptyValue): Added helper function for use from SVGTextLayoutAttributesBuilder.
(WebCore::SVGTextLayoutAttributes::appendEmptyValue): Ditto.
(WebCore::safeValueAtPosition): Ditto. (Inline helper)
(WebCore::SVGTextLayoutAttributes::appendSingleValueFromAttribute): Ditto.
* rendering/svg/SVGTextLayoutAttributes.h: Ditto.
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Rewrite code, see explaination above.
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree):
(WebCore::processRenderSVGInlineText):
(WebCore::SVGTextLayoutAttributesBuilder::collectTextPositioningElements):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForAllCharacters):
(WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes):
(WebCore::fillListAtPosition):
(WebCore::SVGTextLayoutAttributesBuilder::fillAttributesAtPosition):
* rendering/svg/SVGTextLayoutAttributesBuilder.h:
(WebCore::SVGTextLayoutAttributesBuilder::TextPosition::TextPosition):
2011-04-05 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
DeleteButtonController is given invalid style
https://bugs.webkit.org/show_bug.cgi?id=57853
DeleteButtonController was assigned an invalid style that can lead to assertions
in debug builds. This matches up the code with its intent.
No new tests as this changes nothing on release builds.
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
2011-04-05 Anders Bakken <agbakken@gmail.com>
Reviewed by Laszlo Gombos.
[Qt] EditorQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40260
This patch does not require new test cases.
* editing/qt/EditorQt.cpp:
2011-04-05 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: go to line dialog highlights wrong line.
https://bugs.webkit.org/show_bug.cgi?id=57845
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
2011-04-05 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Implement CSSPropertyDirection in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=57608
No new tests required as no new functionality introduced.
* css/CSSStyleApplyProperty.cpp:
Add implementation class for CSSPropertyDirection
* css/CSSStyleSelector.cpp:
Remove existing implementation for CSSPropertyDirection
* css/CSSStyleSelector.h:
Add getter for element
2011-04-05 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Steve Block.
Factoring the creation of 'FunctionOnly' callbacks in V8.
https://bugs.webkit.org/show_bug.cgi?id=57760
This method creates a template from an existing functionality in V8GeolocationCustom.cpp
to V8Utilities to be used by the custom bindings of both Geolocation and the Media Stream API.
No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html
* bindings/v8/V8Utilities.cpp:
(WebCore::throwTypeMismatchException):
* bindings/v8/V8Utilities.h:
(WebCore::createFunctionOnlyCallback):
* bindings/v8/custom/V8GeolocationCustom.cpp:
(WebCore::V8Geolocation::getCurrentPositionCallback):
(WebCore::V8Geolocation::watchPositionCallback):
2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Andreas Kling.
Switch from Vector<UChar> to StringBuilder in bindings/
https://bugs.webkit.org/show_bug.cgi?id=57838
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyName):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyInfo):
2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Andreas Kling.
Switch from Vector<UChar> to StringBuilder in accessibility/
https://bugs.webkit.org/show_bug.cgi?id=57837
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityDescriptionForElements):
2011-04-05 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Scripts with syntax errors are cropped in the UI
https://bugs.webkit.org/show_bug.cgi?id=57828
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.addMessageToSource):
2011-04-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Remove onformchange and onforminput events/event handlers
https://bugs.webkit.org/show_bug.cgi?id=55755
<rdar://problem/9087969>
Covered by existing tests.
* dom/Document.h:
* dom/Document.idl:
* dom/Element.h:
* dom/Element.idl:
* dom/Event.cpp:
(WebCore::Event::fromUserGesture):
* dom/EventNames.h:
* html/FormAssociatedElement.h:
* html/HTMLAttributeNames.in:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
* html/HTMLElement.h:
* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::isEnumeratable):
* html/HTMLFormElement.cpp:
* html/HTMLFormElement.h:
* html/HTMLFormElement.idl:
* html/HTMLInputElement.h:
* html/HTMLKeygenElement.h:
* html/HTMLObjectElement.h:
(WebCore::HTMLObjectElement::isEnumeratable):
* html/HTMLOutputElement.h:
(WebCore::HTMLOutputElement::isEnumeratable):
* html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::isEnumeratable):
* html/HTMLTextAreaElement.h:
(WebCore::HTMLTextAreaElement::isEnumeratable):
* page/DOMWindow.h:
* page/DOMWindow.idl:
2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82915.
http://trac.webkit.org/changeset/82915
https://bugs.webkit.org/show_bug.cgi?id=57825
Broke 270 chromium tests on win and linux (Requested by
podivilov on #webkit).
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::defaultGUIFont):
2011-04-05 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Stop preload scanning CSS when it's impossible to have another @import.
https://bugs.webkit.org/show_bug.cgi?id=57664
@import statements are only allowed at the beginning of a CSS file.
Only comments or @charset can precede them. After seeing anything else,
abort early so that we:
- don't have to parse the rest of the CSS.
- don't preload something that the regular parser won't load.
* html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::scan): Terminate early if we're done with @imports.
(WebCore::CSSPreloadScanner::tokenize): Terminate early if we see a {} or any style rule.
(WebCore::CSSPreloadScanner::emitRule): Only @charset or @import are allowed to precede @import.
* html/parser/CSSPreloadScanner.h: Add DoneParsingImportRules state.
2011-04-05 Takayoshi Kochi <kochi@chromium.org>
Reviewed by Tony Chang.
[chromium] Specify 'sans-serif' as a fallback to the default UI font
'Arial' for non-latin UI scripts (e.g. CJK).
https://bugs.webkit.org/show_bug.cgi?id=55035
No new tests, because it may still fail if the system is not configured
properly to resolve 'sans-serif' to existing real font file, thus even
manual test is hard to systematically tell it is working properly.
* rendering/RenderThemeChromiumSkia.cpp
2011-04-05 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Setting defaultValue on a textarea with a modified value still clobbers the value
https://bugs.webkit.org/show_bug.cgi?id=57636
If the dirty flag is true, we shouldn't update the value when the
defaultValue is updated
Test: fast/forms/textarea-set-defaultvalue-after-value.html
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::childrenChanged):
(WebCore::HTMLTextAreaElement::setDefaultValue):
2011-04-04 Kent Tamura <tkent@chromium.org>
Add a case label which was unexpectedly removed in r82899.
https://bugs.webkit.org/show_bug.cgi?id=50661
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
2011-04-04 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7709452> Implement Default Ruby Overhang Behavior
https://bugs.webkit.org/show_bug.cgi?id=49334
Tests: fast/ruby/overhang-horizontal.html
fast/ruby/overhang-vertical.html
This is a first cut at ruby overhang. It allows ruby text to hang over other
text of equal or smaller size. Two notable omissions are that max preferred
width computation was not patched, so it will overshoot, and that overhang
ignores the width of the adjoining text runs.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust margins
of ruby runs for overhang.
(WebCore::RenderBlock::fitBelowFloats): Maintain the increase in line width to
compensate for overhang.
(WebCore::RenderBlock::findNextLineBreak): When encountering
a ruby run, increase the line width to account for the fact that overhang will be
collapsed.
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::getOverhang): Added. Allows ruby to overhang if
the adjoining renderer is text with equal or smaller font size.
* rendering/RenderRubyRun.h:
(WebCore::toRenderRubyRun):
2011-04-04 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
Reviewed by Alexey Proskuryakov.
* WebCore.exp.in: Export wkSetHTTPPipeliningMaximumPriority().
* platform/mac/WebCoreSystemInterface.h:
(wkSetHTTPPipeliningMaximumPriority): Added function pointer
declaration.
* platform/mac/WebCoreSystemInterface.mm:
(wkSetHTTPPipeliningMaximumPriority): Added function pointer.
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Call
wkSetHTTPPipeliningMaximumPriority() to set the maximum HTTP
pipelining priority.
* platform/network/cf/ResourceRequestCFNet.h:
(WebCore::toResourceLoadPriority): Renamed from
mapHTTPPipeliningPriorityToResourceLoadPriority(). Updated to
to handle Unresolved case.
(WebCore::toHTTPPipeliningPriority): Renamed from
mapResourceLoadPriorityToHTTPPipeliningPriority(). Updated to
handle Unresolved case.
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest): Switched to
use toResourceLoadPriority().
(WebCore::ResourceRequest::doUpdatePlatformRequest): Switched to
use toHTTPPipeliningPriority(). Moved
shouldForceHTTPPipeliningPriorityHigh() check into the argument
of toHTTPPipeliningPriority() instead of hard-coding a
now-incorrect value.
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Convert <meter> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50661
Eliminated a large part of <meter> custom layout code,
which is replaced by a shadow tree.
Note that the shadow tree is created on construction time and
will remain during the host HTMLMeterElement lifecycle.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setProperty):
* css/CSSMutableStyleDeclaration.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/html.css:
(meter):
(meter::-webkit-meter-bar):
(meter::-webkit-meter-optimum-value):
(meter::-webkit-meter-suboptimum-value):
(meter::-webkit-meter-even-less-good-value):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::~HTMLMeterElement):
(WebCore::HTMLMeterElement::parseMappedAttribute):
(WebCore::HTMLMeterElement::attach):
(WebCore::HTMLMeterElement::valueRatio):
(WebCore::HTMLMeterElement::didElementStateChange):
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLMeterElement.h:
* html/shadow/MeterShadowElement.cpp: Added.
(WebCore::MeterShadowElement::MeterShadowElement):
(WebCore::MeterShadowElement::meterElement):
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore::MeterBarElement::shadowPseudoId):
(WebCore::MeterValueElement::shadowPseudoId):
(WebCore::MeterValueElement::setWidthPercentage):
* html/shadow/MeterShadowElement.h: Added.
(WebCore::MeterBarElement::MeterBarElement):
(WebCore::MeterBarElement::create):
(WebCore::MeterValueElement::MeterValueElement):
(WebCore::MeterValueElement::create):
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::~RenderMeter):
(WebCore::RenderMeter::valueRatio):
* rendering/RenderMeter.h:
(WebCore::RenderMeter::renderName):
(WebCore::RenderMeter::isMeter):
(WebCore::RenderMeter::requiresForcedStyleRecalcPropagation):
(WebCore::RenderMeter::canHaveChildren):
2011-04-04 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
Introduce EventDispatchMediator abstraction, which encapsulate all
non-trivial logic around firing a specific type of an event.
https://bugs.webkit.org/show_bug.cgi?id=57562
Refactoring, covered by existing tests.
* dom/Event.cpp:
(WebCore::EventDispatchMediator::EventDispatchMediator): Added.
(WebCore::EventDispatchMediator::~EventDispatchMediator): Added.
(WebCore::EventDispatchMediator::dispatchEvent): Added.
(WebCore::EventDispatchMediator::event): Added.
* dom/Event.h: Added decl.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent): Changed to use EventDispatchMediator.
* dom/EventDispatcher.h: Updated decls.
* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEventDispatchMediator::KeyboardEventDispatchMediator): Added.
(WebCore::KeyboardEventDispatchMediator::dispatchEvent): Added.
* dom/KeyboardEvent.h: Updated decls
* dom/Node.cpp:
(WebCore::Node::dispatchEvent): Changed to use EventDispatchMediator.
(WebCore::Node::dispatchKeyEvent): Changed to use KeyboardEventDispatchMediator.
2011-04-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Cairo] Memory leak in RefPtrCairo
https://bugs.webkit.org/show_bug.cgi?id=57758
No new tests. This just fixes a memory leak.
* platform/graphics/cairo/RefPtrCairo.cpp:
(WTF::derefIfNotNull): Deref should unref the cairo_font_fact_t, not reference it.
2011-04-04 Adrienne Walker <enne@google.com>
Unreviewed, rolling out r82880.
http://trac.webkit.org/changeset/82880
https://bugs.webkit.org/show_bug.cgi?id=50661
Meter elements not rendered in Chromium Linux layout tests
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSMutableStyleDeclaration.cpp:
* css/CSSMutableStyleDeclaration.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/html.css:
(meter):
(meter::-webkit-meter):
(meter::-webkit-meter-bar):
(meter::-webkit-meter-optimum-value):
(meter::-webkit-meter-suboptimal-value):
(meter::-webkit-meter-even-less-good-value):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::create):
(WebCore::HTMLMeterElement::parseMappedAttribute):
(WebCore::HTMLMeterElement::attach):
* html/HTMLMeterElement.h:
* html/shadow/MeterShadowElement.cpp: Removed.
* html/shadow/MeterShadowElement.h: Removed.
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::~RenderMeter):
(WebCore::RenderMeter::createPart):
(WebCore::RenderMeter::updateFromElement):
(WebCore::RenderMeter::layoutParts):
(WebCore::RenderMeter::styleDidChange):
(WebCore::RenderMeter::shouldHaveParts):
(WebCore::RenderMeter::valueRatio):
(WebCore::RenderMeter::barPartRect):
(WebCore::RenderMeter::valuePartRect):
(WebCore::RenderMeter::valuePseudoId):
(WebCore::RenderMeter::barPseudoId):
(WebCore::RenderMeter::detachShadows):
(WebCore::RenderMeter::updateShadows):
* rendering/RenderMeter.h:
(WebCore::RenderMeter::renderName):
(WebCore::RenderMeter::isMeter):
(WebCore::RenderMeter::shadowAttached):
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
setContentEditable with true/false/inherit string is not working properly
https://bugs.webkit.org/show_bug.cgi?id=52058
Move isContentEditable from HTMLElement to Node. Thus, Node provides two functions for
checking editability: rendererIsEditable and isContentEdiable. The former is a fast path,
which does NOT trigger layout and only checks the render style of usermodify. The latter
updates the layout first to make sure the render style syncs with DOM contenteditable
attribute. Certain call sites that need to call isContentEditable rather than rendererIsEditable
are also updated in the patch. But a complete fix will follow up in bug 57244.
This patch fixes all the failed layout tests related to set contenteditable.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isReadOnly):
* dom/Node.cpp:
(WebCore::Node::isContentEditable):
(WebCore::Node::shouldUseInputMethod):
* dom/Node.h:
* html/HTMLElement.cpp:
* html/HTMLElement.h:
2011-04-04 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 57689 - Extract scoping functionality from Document
https://bugs.webkit.org/show_bug.cgi?id=57689
Moved selfOnlyRef (renamed to guardRef), element ID, image map
and accesss key functionalities from Document to a new base
class TreeScope.
TreeShared: made removedLastRef protected
No new tests. (refactoring)
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::destroyScope):
(WebCore::Document::getElementById):
(WebCore::Document::childrenChanged):
(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::attach):
(WebCore::Document::detach):
* dom/Document.h:
(WebCore::Node::Node):
* dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getElementById):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
* dom/DocumentOrderedMap.h:
* dom/DOMAllInOne.cpp:
* dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::setDocument):
* dom/Node.h:
* dom/TreeScope.cpp: Added.
* dom/TreeScope.h: Added.
* platform/TreeShared.h:
(WebCore::TreeShared::removedLastRef): made protected
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Convert <meter> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50661
Eliminated a large part of <meter> custom layout code,
which is replaced by a shadow tree.
Note that the shadow tree is created on construction time and
will remain during the host HTMLMeterElement lifecycle.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setProperty):
* css/CSSMutableStyleDeclaration.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/html.css:
(meter):
(meter::-webkit-meter-bar):
(meter::-webkit-meter-optimum-value):
(meter::-webkit-meter-suboptimum-value):
(meter::-webkit-meter-even-less-good-value):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::~HTMLMeterElement):
(WebCore::HTMLMeterElement::parseMappedAttribute):
(WebCore::HTMLMeterElement::attach):
(WebCore::HTMLMeterElement::valueRatio):
(WebCore::HTMLMeterElement::didElementStateChange):
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLMeterElement.h:
* html/shadow/MeterShadowElement.cpp: Added.
(WebCore::MeterShadowElement::MeterShadowElement):
(WebCore::MeterShadowElement::meterElement):
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore::MeterBarElement::shadowPseudoId):
(WebCore::MeterValueElement::shadowPseudoId):
(WebCore::MeterValueElement::setWidthPercentage):
* html/shadow/MeterShadowElement.h: Added.
(WebCore::MeterBarElement::MeterBarElement):
(WebCore::MeterBarElement::create):
(WebCore::MeterValueElement::MeterValueElement):
(WebCore::MeterValueElement::create):
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::~RenderMeter):
(WebCore::RenderMeter::valueRatio):
* rendering/RenderMeter.h:
(WebCore::RenderMeter::renderName):
(WebCore::RenderMeter::isMeter):
(WebCore::RenderMeter::requiresForcedStyleRecalcPropagation):
(WebCore::RenderMeter::canHaveChildren):
2011-04-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebGL support
https://bugs.webkit.org/show_bug.cgi?id=31517
Add WebGL support for the GTK+ bits of WebCore.
No new tests. This will be covered by the existing WebGL tests once
the bots are capable of running WebGL tests.
* GNUmakefile.am: Added new files required for WebGL support.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext): Extend #ifdef to cover GTK+ as well, which does not
yet support accelerated compositing.
* platform/graphics/ANGLEWebKitBridge.h: Update to reflect the fact that ANGLE isn't compiled as
a framework for GTK+.
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::platformTexture): Added a declaration of this method for Cairo.
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer): Ditto.
* platform/graphics/cairo/GraphicsContext3DCairo.cpp: Added.
(WebCore::GraphicsContext3D::getImageData): Added.
(WebCore::GraphicsContext3D::paintToCanvas): Added.
* platform/graphics/cairo/OpenGLShims.cpp: Added. This file controls loading of GL extension
functions dynamically. They have different names across the different vendors' GL implementations.
(WebCore::lookupOpenGLFunctionAddress): Added
(WebCore::openGLFunctionTable): Added
(WebCore::initializeOpenGLShims): Added
* platform/graphics/cairo/OpenGLShims.h: Added.
* platform/graphics/gtk/DrawingBufferGtk.cpp: Added.
(WebCore::DrawingBuffer::DrawingBuffer): Very generic implementation for Cairo.
(WebCore::DrawingBuffer::~DrawingBuffer): Ditto.
(WebCore::DrawingBuffer::didReset): Ditto.
(WebCore::DrawingBuffer::platformColorBuffer): Ditto.
* platform/graphics/gtk/GraphicsContext3DGtk.cpp: Added.
(WebCore::GraphicsContext3D::create): Initial implementation.
(WebCore::GraphicsContext3D::GraphicsContext3D): Ditto.
(WebCore::GraphicsContext3D::~GraphicsContext3D): Ditto.
(WebCore::GraphicsContext3D::makeContextCurrent): Ditto.
(WebCore::GraphicsContext3D::platformGraphicsContext3D): Ditto.
(WebCore::GraphicsContext3D::isGLES2Compliant): Ditto.
* platform/graphics/gtk/GraphicsContext3DInternal.cpp: Added.
(sharedDisplay): Added this shared display which is required by some
display drivers.
(WebCore::activeGraphicsContexts): This method keeps track of all active GraphicsContext3D
contexts, in order to clean them up at exit. This prevents crashes on certain OpenGL drivers.
(WebCore::GraphicsContext3DInternal::addActiveGraphicsContext): Ditto.
(WebCore::GraphicsContext3DInternal::removeActiveGraphicsContext): Ditto.
(WebCore::GraphicsContext3DInternal::cleanupActiveContextsAtExit): Ditto.
(WebCore::GraphicsContext3DInternal::create): Figure out the best way to create an OpenGL
context given the current environment.
(WebCore::GraphicsContext3DInternal::createPbufferContext): Pbuffer context initializer.
(WebCore::GraphicsContext3DInternal::createPixmapContext): Pixmap context initializer.
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): Initial implementation.
(WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): Ditto.
(WebCore::GraphicsContext3DInternal::makeContextCurrent): Ditto.
* platform/graphics/gtk/GraphicsContext3DInternal.h: Added.
* platform/graphics/opengl/Extensions3DOpenGL.cpp: Added generic implementation.
(WebCore::Extensions3DOpenGL::ensureEnabled): Ditto.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshape): Test for the context using the public API rather than
the private bits that are specific to the Apple port.
2011-04-04 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51230
<rdar://problem/8780989>
<rdar://problem/9015250> REGRESSION (WebKit2): Key events not fired for modifier keys
* page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Moved Caps Lock handling from
WebKits to WebCore, because WebKit shouldn't be smart.
2011-04-04 Steve Falkenburg <sfalken@apple.com>
Fix Windows build warning.
* WebCore.vcproj/WebCore.vcproj: Exclude EventQueue.cpp in Debug_All build.
2011-04-04 Adam Roben <aroben@apple.com>
Attempted Mac build fix, part III
* WebCore.exp.in: Export PlatformCALayer::setGeometryFlipped. Also resorted some symbols.
2011-04-04 Andy Estes <aestes@apple.com>
Fix the Mac build.
* WebCore.exp.in:
2011-04-04 David Dorwin <ddorwin@chromium.org>
Reviewed by David Levin.
Chromium Mac crashes when entering fullscreen
https://bugs.webkit.org/show_bug.cgi?id=57483
Override extraFullScreenStyleSheet in RenderThemeChromiumMac to avoid hitting the ASSERT_NOT_REACHED in RenderThemeMac.
* WebCore.gyp/WebCore.gyp:
* rendering/RenderThemeChromiumMac.h:
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::extraFullScreenStyleSheet):
2011-04-04 Adam Roben <aroben@apple.com>
Attempted Mac build fix, part II
* WebCore.xcodeproj/project.pbxproj: Marked PlatformCALayerClient.h and
PlatformCAAnimation.h as private so that WebKit2 can #include them (transitively).
2011-04-04 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Remove unused AnalyzeWithLargeStack code from Windows build files
https://bugs.webkit.org/show_bug.cgi?id=57771
This was used for us to build with prefast automatically,
but it is out-of-date and hasn't been used for some time.
Removing completely for now.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCorePreBuild.cmd:
2011-04-01 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
[CG] Do not accelerate small canvases
https://bugs.webkit.org/show_bug.cgi?id=57596
No new tests. No outward behavior changes.
* platform/graphics/cg/ImageBufferCG.cpp:
2011-04-04 Adam Roben <aroben@apple.com>
Attempted Mac build fix
* WebCore.xcodeproj/project.pbxproj: Marked PlatformCALayer.h and GraphicsLayerCA.h private
so that WebKit can #include them.
2011-04-04 Malcolm MacLeod <mmacleod@webmail.co.za>
Reviewed by Kevin Ollivier.
[wx] Implement support for temporary files.
https://bugs.webkit.org/show_bug.cgi?id=57772
* platform/FileSystem.h:
* platform/wx/FileSystemWx.cpp:
(WebCore::getFileModificationTime):
(WebCore::openTemporaryFile):
(WebCore::closeFile):
(WebCore::writeToFile):
2011-04-01 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make StructureChain GC allocated
https://bugs.webkit.org/show_bug.cgi?id=56695
Update for new Structure marking function
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::markChildren):
2011-04-04 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add support for the enumerated types in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=57761
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setPauseOnExceptions):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::scriptImportedImpl):
* inspector/InspectorResourceAgent.cpp:
(WebCore::cachedResourceTypeString):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::setInitialXHRContent):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/ScriptsPanel.js:
* inspector/generate-inspector-idl:
2011-04-04 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: InspectorRuntimeAgent should not depend on Page
https://bugs.webkit.org/show_bug.cgi?id=57759
Descendants of InspectorRuntimeAgent should implement a method providing access to the default
inspected state used for console evaluations.
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent): runtime agent is created and deleted along with other agents.
(WebCore::InspectorAgent::setFrontend):
* inspector/InspectorAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::create):
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
* inspector/InspectorRuntimeAgent.h:
(WebCore::InspectorRuntimeAgent::InspectedStateProvider::~InspectedStateProvider):
2011-04-04 Yong Li <yoli@rim.com>
Reviewed by Antonio Gomes.
https://bugs.webkit.org/show_bug.cgi?id=55969
Fix the issue that document state is not saved when
going backward and ending up with error page.
Test: platform/qt/fast/history/back-to-unreachable-url-then-forward.html
(For manual test, load a non-existent html first, then load
fast/history/resources/check-scroll-position.html, then go
back and go forward. If it doesn't show "SUCCESS" at the bottom
of the page, your browser has failed the test)
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::load):
2011-04-04 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix make distcheck for 1.4.0
https://bugs.webkit.org/show_bug.cgi?id=57750
Added a missing header file to the Makefile
* GNUmakefile.am:
2011-04-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] http/tests/plugins/post-url-file.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=55826
Correct the implementation of handlePostReadFile which uses GIO APIs and
actually resizes the buffer to fit the entire size of the file data. This
was likely leading to memory corruption until now.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::handlePostReadFile): Fix this method.
2011-04-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Extensions API] add notifications on panels shown/hidden
https://bugs.webkit.org/show_bug.cgi?id=57752
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.PanelImpl):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.notifyPanelShown):
(WebInspector.ExtensionServer.prototype.notifyPanelHidden):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.show):
(WebInspector.Panel.prototype.hide):
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: search in resources panel is broken.
https://bugs.webkit.org/show_bug.cgi?id=57631
Search in resources panel should trigger source frame content load.
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ResourcesPanel.js:
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype.focusSearchField):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype._ensureContentLoaded):
(WebInspector.SourceFrame.prototype.performSearch):
2011-04-03 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Split out UnicodeBidi enum into its own header (to allow use in platform)
https://bugs.webkit.org/show_bug.cgi?id=57722
unicode-bidi is a CSS concept. However the same concept is really needed throughout
the bidi code in platform as well. So I'm moving the enum to platform.
The only part of the enum which doesn't make much sense to platform/ is "normal".
* WebCore.xcodeproj/project.pbxproj:
* css/CSSPrimitiveValueMappings.h:
* platform/text/UnicodeBidi.h: Added.
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
2011-04-04 Andrey Adaikin <aandrey@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Highlighted search tokens would not be shown on long lines in the text viewer
https://bugs.webkit.org/show_bug.cgi?id=57749
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
2011-04-04 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Incorrectly reports warning on missing/incorrect content-type for 304s
https://bugs.webkit.org/show_bug.cgi?id=48525
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
2011-04-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on DOMNode rather than function
https://bugs.webkit.org/show_bug.cgi?id=57632
Moved the affected method onto the DOMNode.prototype as "appropriateSelectorFor".
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.appropriateSelectorFor):
* inspector/front-end/EventListenersSidebarPane.js:
():
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.addBlankSection):
* inspector/front-end/utilities.js:
2011-04-04 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Followup to an incomplete commit in r82806.
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setHeight):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
(WebInspector.injectedExtensionAPI):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane):
(WebInspector.ExtensionSidebarPane.prototype.setPage):
(WebInspector.ExtensionSidebarPane.prototype._setObject):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype.notifyExtensionSidebarUpdated):
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
(WebInspector.ExtensionServer.prototype.createClientIframe):
(WebInspector.ExtensionServer.prototype._onSetSidebarContent):
2011-04-04 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Qt minimal build.
* inspector/InspectorFrontendChannel.h:
2011-04-01 Sergey Vorobyev <sergeyvorobyev@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Separate sendMessageToFrontend function
from InspectorClient to individual interface.
https://bugs.webkit.org/show_bug.cgi?id=57548
Refactoring - covered with existing inspector tests.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/InspectorClient.h:
* inspector/InspectorFrontendChannel.h: Added.
(WebCore::InspectorFrontendChannel::~InspectorFrontendChannel):
2011-04-04 Nico Weber <thakis@chromium.org>
Reviewed by Eric Seidel.
Prefer a using directive over qualified names in LocalizedNumberICU.cpp
https://bugs.webkit.org/show_bug.cgi?id=57742
Requested by ap in https://bugs.webkit.org/show_bug.cgi?id=57715
* platform/text/LocalizedNumberICU.cpp:
(WebCore::createFormatterForCurrentLocale):
(WebCore::numberFormatter):
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
2011-04-04 Andrey Adaikin <aandrey@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Breakpoints in the gutter stay static while editing the text
https://bugs.webkit.org/show_bug.cgi?id=57616
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype._saveViewerState):
(WebInspector.SourceFrame.prototype._restoreViewerState):
(WebInspector.SourceFrame.prototype._endEditing):
(WebInspector.SourceFrame.prototype._lineNumberAfterEditing):
(WebInspector.SourceFrame.prototype.addBreakpoint):
(WebInspector.SourceFrame.prototype.removeBreakpoint):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._syncDecorationsForLine):
(WebInspector):
(WebInspector.TextEditorChunkedPanel.prototype.removeDecoration):
(WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
(WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
(WebInspector.TextEditorMainPanel.prototype._splitChunkOnALine):
2011-04-04 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: remove obsolete doc generating code from CodeGenerator.
https://bugs.webkit.org/show_bug.cgi?id=57748
* inspector/CodeGeneratorInspector.pm:
2011-04-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=57622
Merged WatchExpressionSidebarPane into ExtensionSidebarPane, added setPage(url).
Fixed wrong getter in schema (scripts -> elements)
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setObject):
(WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setPage):
* inspector/front-end/ExtensionAPISchema.json:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onSetSidebarPage):
2011-04-04 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce support of 'optional' flag for command arguments.
https://bugs.webkit.org/show_bug.cgi?id=57698
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::reloadPage):
* inspector/InspectorPageAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::getResourceContent):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
* inspector/InspectorRuntimeAgent.h:
* inspector/generate-inspector-idl:
2011-04-04 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: InjectedScriptManager should not try to access inspected window in case of workers
https://bugs.webkit.org/show_bug.cgi?id=57637
* bindings/js/JSInjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::injectedScriptFor):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::injectedScriptFor):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::canAccessInspectedWindow):
* inspector/InjectedScript.h:
* inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createForPage):
(WebCore::InjectedScriptManager::createForWorker):
(WebCore::InjectedScriptManager::InjectedScriptManager): access check function is passed as a parameter to the constructor
and it depends on which type of context we're inspecting(worker or page).
(WebCore::InjectedScriptManager::canAccessInspectedWorkerContext):
* inspector/InjectedScriptManager.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
2011-04-04 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Eric Seidel.
V8StringCallback.cpp requires V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=57699
No new tests required because of just adding header file.
* bindings/scripts/CodeGeneratorV8.pm:
2011-04-03 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Eric Seidel.
[CMAKE] Clean duplicated files in WebCore_Sources
https://bugs.webkit.org/show_bug.cgi?id=57741
No new tests, Only duplicated files were removed.
* CMakeLists.txt:
2011-04-03 Luke Macpherson <macpherson@chromium.org>
Reviewed by Darin Adler.
Fix 2-space indentation introduced in bug 54706.
https://bugs.webkit.org/show_bug.cgi?id=57740
No new tests - whitespace changes only.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Convert 2-space indentation to 4-space indentation.
2011-04-03 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Make CSSStyleApplyProperty non-copyable
https://bugs.webkit.org/show_bug.cgi?id=57738
No new functionality added so no new tests required.
* css/CSSStyleApplyProperty.h:
Added WTF_MAKE_NONCOPYABLE(CSSStyleApplyProperty) to ensure singleton stays single.
2011-04-03 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
fast/images/extra-image-in-image-document.html crashes when run after embed-image.html
https://bugs.webkit.org/show_bug.cgi?id=57733
The crash happens because resetting the page scale as part of preparing the WebView for the
next test triggered layout, which in turn caused a plug-in to make a resource request, and
DumpRenderTree's delegate to be dispatched. The delegate doesn’t expect to be called between
tests, and it references the layout test controller, which is null.
* page/Frame.cpp:
(WebCore::Frame::scalePage): Avoid an unnecessary layout if the page scale isn’t changing. This
is more efficient, and has the side effect of avoiding the crash in DumpRenderTree, although
DumpRenderTree could still crash when after a test with disabled plug-ins and a non-1 page scale.
I think there are currently no such tests, so I am not fixing DumpRenderTree.
2011-04-03 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Teach InlineIterator how to work from any root, not just a RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=57726
For implementing bidi-unicode: isolate, we need to be able to run the
bidi algorithm over a subtree of inlines, not just from a block root.
This is the first step in making this possible.
* rendering/InlineIterator.h:
(WebCore::InlineIterator::InlineIterator):
(WebCore::InlineIterator::root):
(WebCore::bidiNext):
(WebCore::bidiFirst):
(WebCore::InlineIterator::increment):
(WebCore::InlineBidiResolver::appendRun):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
2011-04-03 Eric Seidel <eric@webkit.org>
Reviewed by Dan Bernstein.
Split out handling of trailing spaces from layoutInlineChildren
https://bugs.webkit.org/show_bug.cgi?id=57432
There is much more we could split out from this function, but this is a start.
I suspect this is very hot code. Hopefully the compiler will do the right thing.
If it doesn't the Chromium PLT bots will tell us.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::handleTrailingSpaces):
(WebCore::RenderBlock::layoutInlineChildren):
2011-03-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
editing commands shouldn't run when there's no body
https://bugs.webkit.org/show_bug.cgi?id=56771
The bug was caused by WebKit's not checking the existence of root editable element
in enabled* functions. Although isContentEditable returns true whenever we're in design mode,
we should not run editing commands in a document without a body element editable because
doing so results in appending a non-body element to the document node.
Fixed the bug by modifying various enabled* functions to ensure we have a root editable element.
New behavior tries to match that of Firefox except StyleWithCSS, which Firefox seems to ignore
when there are no body element. Since StyleWithCSS is a document's state or property, we allow
execCommand('StyleWithCSS') even in a document without a body element.
WebKit's and Firefox's behaviors also deviate in insert-image-with-selecting-document.html.
Whereas WebKit respects selection set by script and ignores execCommand, Firefox modifies
the selection when document.write("x") is ran and successfully inserts image.
Thus, empty-document-delete.html and empty-document-justify-right.html both pass on Firefox
while empty-document-stylewithcss.html and insert-image-with-selecting-document.html both fail.
Since Internet Explorer does not allow execCommand to run under design mode properly, we could
not test its behavior.
Tests: editing/editability/empty-document-delete.html
editing/editability/empty-document-justify-right.html
editing/editability/empty-document-stylewithcss.html
editing/execCommand/insert-image-with-selecting-document.html
* editing/Editor.cpp:
(WebCore::Editor::canEdit): Verify that the root editable element exists
instead of just checking that selection endpoints are editable because
selection endpoints could be document node without a body element in design mode
and we don't want to consider such a document editable.
(WebCore::Editor::canDelete): Ditto.
* editing/EditorCommand.cpp:
(WebCore::enabledInEditableText): Ditto.
(WebCore::enabledInRichlyEditableText): Ditto.
(WebCore::enabledDelete): Call enabledCut and enabledInEditableText instead
of duplicating the code in order to fix the same bug.
2011-04-02 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION (r82786): Media controls render incorrectly on GTK and Qt
https://bugs.webkit.org/show_bug.cgi?id=57719
r82786 exposed an incorrect assumption inRenderMediaControlTimeDisplay::layout()
that the timeline container is the parent of the time display. This is not true
with the GTK media style, where the current time display is an inline box, and
thus wrapped in an anonymous flexible box. The code was incorrectly considering
the width of the anonymous box and deciding to hide the time display. Prior to
r82786, this mistake was corrected by the call to computeLogicalWidth() in line layout.
* rendering/MediaControlElements.cpp:
(WebCore::RenderMediaControlTimeDisplay::layout): Changed to skip past anonymous ancestors.
2011-04-02 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
Explicitly use icu namespace for ports building with U_USING_ICU_NAMESPACE=0
By default, ICU includes |using namespace icu;| in its header files
for backwards compatibility. Clients can define
U_USING_ICU_NAMESPACE=0 to tell ICU to not do this. Prefixing all ICU
classes with |icu::| makes this file compile no matter what
U_USING_ICU_NAMESPACE is set to.
https://bugs.webkit.org/show_bug.cgi?id=57715
* platform/text/LocalizedNumberICU.cpp:
(WebCore::createFormatterForCurrentLocale):
(WebCore::numberFormatter):
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
2011-04-02 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
Remove an unnecessary extra computeLogicalWidth() from line layout
https://bugs.webkit.org/show_bug.cgi?id=57711
Changes in behavior (MathML progression) covered by existing layout tests.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
actually prevents MathML rows from reverting to an incorrect width.
2011-04-02 Dan Bernstein <mitz@apple.com>
Reviewed by Beth Dakin.
<details> marker loses its margin
https://bugs.webkit.org/show_bug.cgi?id=57713
* rendering/RenderDetails.cpp:
(WebCore::RenderDetails::computePreferredLogicalWidths): Override to update
the marker location.
* rendering/RenderDetails.h:
(WebCore::RenderDetails::renderName): Made private.
(WebCore::RenderDetails::isDetails): Ditto.
* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::computePreferredLogicalWidths): Set the margins
in the style, like RenderListMarker does.
(WebCore::RenderDetailsMarker::layout): Set the margins from the style.
2011-04-02 Andy Estes <aestes@apple.com>
Reviewed by Oliver Hunt.
REGRESSION (r69237): Black border around map elements while using an image map on Mac platform
https://bugs.webkit.org/show_bug.cgi?id=52518
Test: fast/images/imagemap-focus-ring-zero-outline-width.html
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintAreaElementFocusRing): Return early if outlineWidth is 0.
2011-04-02 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=57605
Frame::pageScaleFactor() should not affect getBoundingClientRect() or
getClientRects()
-and corresponding-
<rdar://problem/9194541>
New functions adjust*ForPageScale() are analogous to adjust*ForAbsoluteZoom().
* dom/Element.cpp:
(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):
* dom/Range.cpp:
(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):
(WebCore::Range::getBorderAndTextQuads):
* rendering/RenderObject.h:
(WebCore::adjustFloatPointForPageScale):
(WebCore::adjustFloatQuadForPageScale):
(WebCore::adjustFloatRectForPageScale):
2011-04-02 Dan Bernstein <mitz@apple.com>
Reverted r82775 due to changes in <details> test results, which are
likely progressions.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
2011-04-02 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
Remove an unnecessary extra computeLogicalWidth() from line layout
https://bugs.webkit.org/show_bug.cgi?id=57711
Changes in behavior (MathML progression) covered by existing layout tests.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
actually prevents MathML rows from reverting to an incorrect width.
2011-04-02 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Martin Robinson.
[GTK] Fix leaked pointer in FontGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=57307
Fix a memory leak.
No new functionality, so no new tests.
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::utf16ToUtf8): Rename utf16_to_utf8 and fix indentation.
(WebCore::convertUniCharToUTF8):
2011-04-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: we should be able to have in and out arguments of a command with same name.
https://bugs.webkit.org/show_bug.cgi?id=57701
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.json:
2011-04-01 Ilya Tikhonovsky <loislo@chromium.org>
Not reviewed trivial change.
Web Inspector: The page agent should be enabled even if JAVASCRIPT_DEBUGGER is off.
Followup change for r82281.
https://bugs.webkit.org/show_bug.cgi?id=57327
* inspector/InspectorPageAgent.cpp:
* inspector/InspectorPageAgent.h:
2011-04-01 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
Cached Resource Overhead Space Usage and Accounting Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=57488
Fixed windows test failures.
Changed the fixed overhead value for ResourceResponse to 3800 bytes.
Modified ResourceResponse::platformLazyInit() to handle "base" level
attributes or all attributes. The base attributes, like URL, status
code, mime type and a few header fields (mostly cache related) are
suitable for most resources. This reduces the per resource memory
needs by over 1K bytes per resource thus saving memory in the cache.
Collectively, these two changes bring the overhead memory calculation
in line with reality.
No new tests added due to existing tests cover areas of change and
there is no functional change. The change is limited to reducing
memory usage along existing paths.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::canUseCacheValidator):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::isHTTP):
(WebCore::ResourceResponseBase::url):
(WebCore::ResourceResponseBase::setURL):
(WebCore::ResourceResponseBase::mimeType):
(WebCore::ResourceResponseBase::setMimeType):
(WebCore::ResourceResponseBase::expectedContentLength):
(WebCore::ResourceResponseBase::setExpectedContentLength):
(WebCore::ResourceResponseBase::textEncodingName):
(WebCore::ResourceResponseBase::setTextEncodingName):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusCode):
(WebCore::ResourceResponseBase::setHTTPStatusCode):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::ResourceResponseBase::hasCacheValidatorFields):
(WebCore::ResourceResponseBase::date):
(WebCore::ResourceResponseBase::age):
(WebCore::ResourceResponseBase::expires):
(WebCore::ResourceResponseBase::lastModified):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):
(WebCore::ResourceResponseBase::lazyInit):
* platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::platformLazyInit):
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::memoryUsage):
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit):
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):
2011-04-01 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=45855
Windowless plugins added dynamically to the DOM should receive paint events.
This is done by ensuring that the plugin widget is marked for painting when
it is added.
Test: plugins/windowless_plugin_paint_test.html
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
2011-04-01 Mike Reed <reed@google.com>
Reviewed by James Robinson.
always use native font rendering on skia_gpu
fixes a crash when SKIA_GPU is enabled, as we can't call getTopPlatformDevice()
https://bugs.webkit.org/show_bug.cgi?id=57663
No new tests. existing rendering tests will exercise this
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82712, r82729, and r82746.
http://trac.webkit.org/changeset/82712
http://trac.webkit.org/changeset/82729
http://trac.webkit.org/changeset/82746
https://bugs.webkit.org/show_bug.cgi?id=57682
fast/frames/frame-programmatic-noresize.html is failing on
Windows bots. Will look into this offline. (Requested by dydx
on #webkit).
* html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::HTMLFrameElement):
(WebCore::HTMLFrameElement::attach):
(WebCore::HTMLFrameElement::parseMappedAttribute):
* html/HTMLFrameElement.h:
(WebCore::HTMLFrameElement::noResize):
* rendering/RenderFrame.cpp:
* rendering/RenderFrame.h:
* rendering/RenderFrameSet.cpp:
* rendering/RenderFrameSet.h:
2011-04-01 Adam Barth <abarth@webkit.org>
Reviewed by Tony Chang.
Valgrind error in _ZN7WebCore8Document11updateTitleERKNS_19StringWithDirectionE
https://bugs.webkit.org/show_bug.cgi?id=57656
We should initialize memory when constructing objects.
* platform/text/StringWithDirection.h:
(WebCore::StringWithDirection::StringWithDirection):
2011-04-01 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
WebKit2: Link from PDF opens in a new tab instead of in the same tab
https://bugs.webkit.org/show_bug.cgi?id=57528
* WebCore.exp.in: Export MouseEvent::create().
2011-04-01 John Bauman <jbauman@chromium.org>
Reviewed by Kenneth Russell.
Avoid decoding images twice in texImage2D
https://bugs.webkit.org/show_bug.cgi?id=51498
Make sure to redecode the image only if it's not opaque and texImage2D
wouldn't premultiply it anyway.
* platform/graphics/BitmapImage.h:
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::getImageData):
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
2011-04-01 Alexey Proskuryakov <ap@apple.com>
32-bit Mac build fix.
* dom/KeyboardEvent.h: (WebCore::KeypressCommand::KeypressCommand): Use 0U to index a String
to avoid ambiguity.
2011-04-01 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Make WebKit2 text input handling more like WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57649
* dom/KeyboardEvent.h: (WebCore::KeypressCommand::KeypressCommand): Put back the assertions
we used to have. It is dangerous to confuse editor commands and selector names - besides the
presence of a semicolon, they sometimes have different names, and WebKit2 failed to map those.
2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82711.
http://trac.webkit.org/changeset/82711
https://bugs.webkit.org/show_bug.cgi?id=57657
Made every test crash on XP and Win7 (Requested by
abarth|gardening on #webkit).
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::canUseCacheValidator):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::isHTTP):
(WebCore::ResourceResponseBase::url):
(WebCore::ResourceResponseBase::setURL):
(WebCore::ResourceResponseBase::mimeType):
(WebCore::ResourceResponseBase::setMimeType):
(WebCore::ResourceResponseBase::expectedContentLength):
(WebCore::ResourceResponseBase::setExpectedContentLength):
(WebCore::ResourceResponseBase::textEncodingName):
(WebCore::ResourceResponseBase::setTextEncodingName):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusCode):
(WebCore::ResourceResponseBase::setHTTPStatusCode):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::ResourceResponseBase::date):
(WebCore::ResourceResponseBase::age):
(WebCore::ResourceResponseBase::expires):
(WebCore::ResourceResponseBase::lastModified):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):
(WebCore::ResourceResponseBase::lazyInit):
* platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::platformLazyInit):
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::memoryUsage):
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit):
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):
2011-04-01 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Behavior of isAccelerated() for a IOSurface-backed canvas should be consistent with accelerated status of its ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=57651
No new tests. This patch does not affect outward behavior.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::isAccelerated):
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::isAccelerated):
2011-04-01 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Frame's noResize attribute can not be set by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=14845
Tests: fast/frames/frame-inherit-noresize-from-frameset.html
fast/frames/frame-programmatic-noresize.html
fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html
fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html
Implements support to programmatically allow and disallow frame resizing.
Currently, HTMLFrameElement::parseMappedAttribute() is hardcoded to disallow frame resize (i.e.
m_noResize = true) when either the noresize DOM attribute is specified (or existed at some
point in time) or the value of the noResize attribute is modified. Instead we should allow/disallow
frame resize depending on the presence of the noresize DOM attribute/the value of the noResize
attribute.
* html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::HTMLFrameElement):
(WebCore::HTMLFrameElement::noResize): Made this a non-inline function since this
code path isn't performance critical.
(WebCore::HTMLFrameElement::attach): Removed code to inherit noresize attribute from
parent <frameset> since this functionality is part of RenderFrameSet::computeEdgeInfo().
(WebCore::HTMLFrameElement::parseMappedAttribute):
* html/HTMLFrameElement.h:
* rendering/RenderFrame.cpp:
(WebCore::RenderFrame::updateFromElement): Added.
* rendering/RenderFrame.h:
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::notifyFrameEdgeInfoChanged): Added.
* rendering/RenderFrameSet.h:
2011-04-01 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
Cached Resource Overhead Space Usage and Accounting Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=57488
Changed the fixed overhead value for ResourceResponse to 3800 bytes.
Modified ResourceResponse::platformLazyInit() to handle "base" level
attributes or all attributes. The base attributes, like URL, status
code, mime type and a few header fields (mostly cache related) are
suitable for most resources. This reduces the per resource memory
needs by over 1K bytes per resource thus saving memory in the cache.
Collectively, these two changes bring the overhead memory calculation
in line with reality.
No new tests added due to existing tests cover areas of change and
there is no functional change. The change is limited to reducing
memory usage along existing paths.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::canUseCacheValidator):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::isHTTP):
(WebCore::ResourceResponseBase::url):
(WebCore::ResourceResponseBase::setURL):
(WebCore::ResourceResponseBase::mimeType):
(WebCore::ResourceResponseBase::setMimeType):
(WebCore::ResourceResponseBase::expectedContentLength):
(WebCore::ResourceResponseBase::setExpectedContentLength):
(WebCore::ResourceResponseBase::textEncodingName):
(WebCore::ResourceResponseBase::setTextEncodingName):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusCode):
(WebCore::ResourceResponseBase::setHTTPStatusCode):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::ResourceResponseBase::hasCacheValidatorFields):
(WebCore::ResourceResponseBase::date):
(WebCore::ResourceResponseBase::age):
(WebCore::ResourceResponseBase::expires):
(WebCore::ResourceResponseBase::lastModified):
(WebCore::ResourceResponseBase::lazyInit):
* platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::platformLazyInit):
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::memoryUsage):
* platform/network/cf/ResourceResponseCFNet.cpp:
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):
2011-04-01 Timothy Hatcher <timothy@apple.com>
Make momentum scroll event latching work in WebKit2 on Mac.
<rdar://problem/8751861>
Reviewed by Darin Adler.
* WebCore.exp.in: Remove _wkIsLatchingWheelEvent, add _wkGetNSEventMomentumPhase.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent): Set m_useLatchedWheelEventNode based on the
event's momentumPhase.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::wheelEvent): Remove the setting of m_useLatchedWheelEventNode.
It is now done in EventHandler::handleWheelEvent.
* platform/mac/WebCoreSystemInterface.h: Remove wkIsLatchingWheelEvent, add wkGetNSEventMomentumPhase.
* platform/mac/WebCoreSystemInterface.mm: Ditto.
* platform/mac/WheelEventMac.mm:
(WebCore::momentumPhaseForEvent): Return a phase on older Mac system by using wkGetNSEventMomentumPhase.
2011-04-01 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JavaClass should be an interface and free of JNI types
https://bugs.webkit.org/show_bug.cgi?id=57533
This patch fixes JavaClass for V8 only.
It factors out a JavaClass interface which does not use JNI types.
This will allow the Java bridge to be used with objects that
don't use JNI directly. The existing jobject-backed
implementation is moved to a new JavaClassJobject class which
implements the interface.
No new tests, refactoring only.
* Android.v8bindings.mk:
* WebCore.gypi:
* bridge/jni/v8/JavaClassJobjectV8.cpp:
(JavaClassJobject::JavaClassJobject):
(JavaClassJobject::~JavaClassJobject):
(JavaClassJobject::methodsNamed):
(JavaClassJobject::fieldNamed):
* bridge/jni/v8/JavaClassJobjectV8.h: Copied from Source/WebCore/bridge/jni/v8/JavaClassV8.h.
* bridge/jni/v8/JavaClassV8.h:
(JSC::Bindings::JavaClass::~JavaClass):
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::getClass):
2011-04-01 Jaehun Lim <ljaehun.lim@samsung.com>
Unreviewed build fix.
Fix build break when font backend is Pango.
Pango is missed in changeset 80589.
https://bugs.webkit.org/show_bug.cgi?id=57609
* platform/graphics/pango/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82687.
http://trac.webkit.org/changeset/82687
https://bugs.webkit.org/show_bug.cgi?id=57643
This patch broke accessibility aria-treegrid test in Mac
(Requested by msanchez on #webkit).
* accessibility/AccessibilityARIAGrid.cpp:
* accessibility/AccessibilityARIAGrid.h:
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(atkRole):
* accessibility/mac/AccessibilityObjectWrapper.mm:
2011-03-31 Abhishek Arya <inferno@chromium.org>
Reviewed by Andreas Kling.
Whenever a relayout is trigger for SVGPath, make sure
to clear its previous marker layout info. This helps
to prevent removed markers from being used.
https://bugs.webkit.org/show_bug.cgi?id=57492
Test: svg/dom/path-marker-removed-crash.svg
* rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::layout):
* rendering/svg/SVGMarkerLayoutInfo.cpp:
(WebCore::SVGMarkerLayoutInfo::clear):
* rendering/svg/SVGMarkerLayoutInfo.h:
2011-04-01 Rob Buis <rwlbuis@gmail.com>
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=55750
SVG <image> referenced by <use> is displayed incorrectly
Reintroduce old behaviour for valid base URI, for invalid
keep using document base URI.
Fixes regression of W3C-SVG-1.1/struct-image-07-t.svg.
Test: svg/custom/image-base-uri.svg
* svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::sourceURI):
2011-04-01 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
ARIA Grid tables should return GridRole in roleValue() method
https://bugs.webkit.org/show_bug.cgi?id=57614
This change does not need any test since it doesn't change anything
from the point of view of the consumers (Assistive Technoglogies).
It's just an internal change to simplify identifying HTML and ARIA
tables by calling to the AccessibilityObject::roleValue method.
* accessibility/AccessibilityARIAGrid.h:
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::roleValue): Return GridRole.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(atkRole): Removed unneeded comment.
* accessibility/mac/AccessibilityObjectWrapper.mm: Map GridRole to
NSAccessibilityTableRole, to keep the same behaviour.
2011-04-01 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
<meter> can only support horizontal indicator
https://bugs.webkit.org/show_bug.cgi?id=56001
- Removed code which deals with the direction and
left the horizontal path.
- Removed "horizontal" from related names which is now
redundant.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/html.css:
(meter::-webkit-meter-bar):
(meter::-webkit-meter-optimum-value):
(meter::-webkit-meter-suboptimal-value):
(meter::-webkit-meter-even-less-good-value):
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::~RenderMeter):
(WebCore::RenderMeter::createPart):
(WebCore::RenderMeter::updateFromElement):
(WebCore::RenderMeter::layoutParts):
(WebCore::RenderMeter::styleDidChange):
(WebCore::RenderMeter::shouldHaveParts):
(WebCore::RenderMeter::valuePartRect):
(WebCore::RenderMeter::valuePseudoId):
(WebCore::RenderMeter::barPseudoId):
(WebCore::RenderMeter::detachShadows):
(WebCore::RenderMeter::updateShadows):
* rendering/RenderMeter.h:
(WebCore::RenderMeter::shadowAttached):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::supportsMeter):
* rendering/RenderTheme.h:
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::supportsMeter):
* rendering/style/RenderStyleConstants.h:
2011-03-23 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix reveal line in formatted script.
https://bugs.webkit.org/show_bug.cgi?id=56941
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.sourceFileForScriptURL):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
(WebInspector.NetworkPanel.prototype.showAnchorLocation):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.canShowAnchorLocation):
(WebInspector.Panel.prototype.showAnchorLocation):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.canShowAnchorLocation):
(WebInspector.ResourcesPanel.prototype.showAnchorLocation):
(WebInspector.ResourcesPanel.prototype.showResource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype.showAnchorLocation):
(WebInspector.ScriptsPanel.prototype._showSourceLine):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.highlightLine):
(WebInspector.SourceFrame.prototype._createTextViewer):
* inspector/front-end/inspector.js:
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
(WebInspector._showAnchorLocation):
2011-04-01 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make editScriptSource a Script's method.
https://bugs.webkit.org/show_bug.cgi?id=57615
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.editScriptSource):
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.editSource):
2011-04-01 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: event should have "data" attribute, not "body"
https://bugs.webkit.org/show_bug.cgi?id=57628
* inspector/CodeGeneratorInspector.pm:
2011-04-01 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: checkboxes are broken in xhr breakpoints sidebar pane.
https://bugs.webkit.org/show_bug.cgi?id=57610
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
2011-04-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: up/down keys are not treating hex numbers properly while editing styles.
https://bugs.webkit.org/show_bug.cgi?id=40522
Drive-by: fix inc/dec for numbers like ".5"
Test: inspector/styles/up-down-numerics-and-colors.html
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
2011-03-30 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove dead code from Script.js.
https://bugs.webkit.org/show_bug.cgi?id=57454
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
* inspector/front-end/Script.js:
(WebInspector.Script):
(WebInspector.Script.prototype.requestSource.didGetScriptSource):
(WebInspector.Script.prototype.requestSource):
2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82667.
http://trac.webkit.org/changeset/82667
https://bugs.webkit.org/show_bug.cgi?id=57612
Breaks Leopard layout tests (Requested by podivilov on
#webkit).
* GNUmakefile.am:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
2011-03-30 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove unused SourceFrameContent class.
https://bugs.webkit.org/show_bug.cgi?id=57453
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ResourceView.js:
(WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._createTextViewer):
* inspector/front-end/SourceFrameContent.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-03-30 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add test for script formatter worker.
https://bugs.webkit.org/show_bug.cgi?id=57447
Test: inspector/debugger/script-formatter.html
* GNUmakefile.am:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
2011-03-30 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [chromium] script formatting doesn't work when all scripts are concatenated.
https://bugs.webkit.org/show_bug.cgi?id=57446
* inspector/front-end/ScriptFormatterWorker.js:
2011-04-01 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: allow file access from inspector page so inspector can use workers.
https://bugs.webkit.org/show_bug.cgi?id=57339
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
2011-03-31 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inspected page crashes on attempt to log object with broken .toString
https://bugs.webkit.org/show_bug.cgi?id=57557
If ScriptValue.toString causes a JavaScript exception, the exception is cleared
before returning from the toString method.
Test: inspector/console/console-log-toString-object.html
* bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::toString):
* bindings/js/ScriptValue.h:
* bindings/v8/ScriptValue.cpp:
(WebCore::ScriptValue::toString):
2011-03-31 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
- removed documentWide parameter to querySelector[All]() (user document node id instead)
- factor out document request logic within DOMAgent into separate method
- add querySelector() and querySelectorAll() to DOMAgent.js, assure we have document before calling back-end
- use the above wrappers for querySelector() and querySelectorAll(), do not call backend directly
- minor style fixes in Inspector.json
- more error logging
Web Inspector: provide front-end wrappers for DOMAgent.querySelector[All]() that take care of fetching the document
https://bugs.webkit.org/show_bug.cgi?id=57466
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::querySelector):
(WebCore::InspectorDOMAgent::querySelectorAll):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.requestDocument.onDocumentAvailable):
(WebInspector.DOMAgent.prototype.requestDocument):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
(WebInspector.DOMAgent.prototype.cancelSearch):
(WebInspector.DOMAgent.prototype.querySelector):
(WebInspector.DOMAgent.prototype.querySelectorAll):
2011-04-01 Kent Tamura <tkent@chromium.org>
Apply sort-Xcode-project-file.
* WebCore.xcodeproj/project.pbxproj:
2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82652.
http://trac.webkit.org/changeset/82652
https://bugs.webkit.org/show_bug.cgi?id=57603
Test still fails (Requested by abarth|gardener on #webkit).
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
2011-03-31 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kent Tamura.
REGRESSION (r64712): Safari removes the first blank line in a textarea
https://bugs.webkit.org/show_bug.cgi?id=56434
Test: fast/forms/textarea-newline.html
A linefeed removal after a textarea tag is originally processed in WebCore::HTMLTextAreaElement::defaultValue().
But HTML5 tree builder now removes the linefeed. It means linefeed removal happens twice.
And devalutValue() removal is not needed anymore.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setDefaultValue): Remove an extra linefeed insertion at the beginning.
(WebCore::HTMLTextAreaElement::defaultValue): Remove linefeed removal check in default value creation function.
2011-03-31 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Remove refcounting of CSSStyleApplyProperty singleton
https://bugs.webkit.org/show_bug.cgi?id=57592
No new tests required as no functionality changes.
* css/CSSStyleApplyProperty.h:
2011-03-31 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=45855
Windowless plugins added dynamically to the DOM should receive paint events.
This is done by ensuring that the plugin widget is marked for painting when
it is added.
Test: plugins/windowless_plugin_paint_test.html
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
2011-03-31 Adam Roben <aroben@apple.com>
Add a new AbstractCACFLayerTreeHost base class
This class exposes the interface that LayerChangesFlusher and PlatformCALayer rely on.
CACFLayerTreeHost now derives from AbstractCACFLayerTreeHost. In the future, WebKit2's
LayerTreeHostCA will also derive from it (on Windows).
This should cause no change in behavior.
Fixes <http://webkit.org/b/57598> Coupling between CACFLayerTreeHost and other CACF-related
code is too high
Reviewed by Anders Carlsson.
* WebCore.vcproj/WebCore.vcproj: Added AbstractCACFLayerTreeHost, and let VS reorder files.
* platform/graphics/ca/win/AbstractCACFLayerTreeHost.h: Added.
* platform/graphics/ca/win/CACFLayerTreeHost.h: Changed to derive from
AbstractCACFLayerTreeHost, and annotated the overrides of its functions.
AbstractCACFLayerTreeHost also allows us to get rid of the friend relationship with
PlatformCALayer.
* platform/graphics/ca/win/LayerChangesFlusher.cpp:
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
(WebCore::LayerChangesFlusher::cancelPendingFlush):
(WebCore::LayerChangesFlusher::hookFired):
* platform/graphics/ca/win/LayerChangesFlusher.h:
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(layerTreeHostForLayer):
(PlatformCALayer::rootLayer):
(PlatformCALayer::setNeedsCommit):
(PlatformCALayer::addAnimationForKey):
(PlatformCALayer::removeAnimationForKey):
Changed to use AbstractCACFLayerTreeHost instead of using CACFLayerTreeHost directly.
2011-03-31 Andy Estes <aestes@apple.com>
Reviewed by Alexey Proskuryakov.
REGRESSION: Java applet fails to load when <object> has a classid attribute.
https://bugs.webkit.org/show_bug.cgi?id=52703
Java applets embedded with the object element sometimes use classid to
specify their main resource. When this is done, the classid is prefixed
with "java:". Treat these as supported classids in WebKit.
Test: java/embedding-java-with-object.html
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::hasValidClassId): If the MIME type is a
Java Applet type and the classid starts with "java:", the classid
should be considered valid.
2011-03-31 Brent Fulgham <bfulgham@webkit.org>
Reviewed Adam Roben.
[WinCairo] Implement Missing drawWindowsBitmap method.
https://bugs.webkit.org/show_bug.cgi?id=57409
* WebCore.vcproj/WebCore.vcproj: Add new DIBPixelData files.
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::WindowsBitmap::buffer):
(WebCore::GraphicsContext::WindowsBitmap::bufferLength):
(WebCore::GraphicsContext::WindowsBitmap::size):
(WebCore::GraphicsContext::WindowsBitmap::bytesPerRow):
(WebCore::GraphicsContext::WindowsBitmap::bitsPerPixel):
(WebCore::GraphicsContext::WindowsBitmap::windowsDIB):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::CGContextWithHDC):
(WebCore::GraphicsContext::releaseWindowsContext): Modified to use
new common routines.
* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::drawBitmapToContext): New common drawing implementation.
(WebCore::GraphicsContext::releaseWindowsContext): Modified to use
new common routines.
(WebCore::GraphicsContext::drawWindowsBitmap):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): Modified
to use new DIBPixelData data type.
* platform/graphics/win/DIBPixelData.cpp: Added.
(WebCore::DIBPixelData::DIBPixelData):
(WebCore::DIBPixelData::initialize):
* platform/graphics/win/DIBPixelData.h: Added.
(WebCore::DIBPixelData::DIBPixelData):
(WebCore::DIBPixelData::buffer):
(WebCore::DIBPixelData::bufferLength):
(WebCore::DIBPixelData::size):
(WebCore::DIBPixelData::bytesPerRow):
(WebCore::DIBPixelData::bitsPerPixel):
2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81849.
http://trac.webkit.org/changeset/81849
https://bugs.webkit.org/show_bug.cgi?id=57588
CSS Parsing broke with -webkit-calc and introduced crashes
(Requested by inferno-sec on #webkit).
* css/CSSGrammar.y:
* css/CSSParserValues.cpp:
* css/CSSParserValues.h:
* css/tokenizer.flex:
2011-03-31 Adam Roben <aroben@apple.com>
Don't ref CACFLayerTreeHosts when telling them to flush layer changes
LayerChangesFlusher was reffing CACFLayerTreeHosts before calling out to them. This would
have protected us if calling out to one CACFLayerTreeHost could cause a different
CACFLayerTreeHost to be destroyed. But that isn't possible; each CACFLayerTreeHost is
associated with its own page, and flushing layer changes doesn't touch any other page. So it
isn't possible for a CACFLayerTreeHost to be deleted while another one is flushing layer
changes.
One benefit of this change is that it will make it easier to make LayerChangesFlusher
interact with a forthcoming abstract base class, rather than with CACFLayerTreeHost itself.
This should cause no change in behavior.
Fixes <http://webkit.org/b/57590> LayerChangesFlusher unnecessarily refs CACFLayerTreeHost
before calling out to it
Reviewed by Darin Adler.
* platform/graphics/ca/win/LayerChangesFlusher.cpp:
(WebCore::LayerChangesFlusher::hookFired): Just store bare pointers to the
CACFLayerTreeHosts.
2011-03-31 Antti Koivisto <antti@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=57574
Preload scanner fails to pick up resources from document.write() output
- Scan script inserted source using a separate preload scanner.
- Make the main preload scanner correctly process the remaining source if script execution blocked the parser.
Tests: fast/preloader/document-write-2.html
fast/preloader/document-write.html
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):
* html/parser/HTMLDocumentParser.h:
(WebCore::HTMLDocumentParser::hasPreloadScanner):
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::execute):
* html/parser/HTMLScriptRunnerHost.h:
2011-03-31 Tony Gentilcore <tonyg@chromium.org>
Build fix: Add missing include
https://bugs.webkit.org/show_bug.cgi?id=57587
* loader/cache/CachedResourceLoader.cpp:
2011-03-31 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Antti Koivisto.
PreloadScanner doesn't find image while executing script in head
https://bugs.webkit.org/show_bug.cgi?id=45072
Previously, while parsing the head, no resources in the body would be
preloaded. After this patch, we will preload scripts and styles in the
body, although we continue to hold off on all images until the page is
first rendered.
To evaluate this change, I've recorded a sampling of 45 of alexa's top
sites and replayed them under simulated bandwidth conditions, loading
each 5-15 times until stddev is small enough.
Time to the load event improved at the overall average by 3%.
Most sites are unchanged, but sites with certain blocking patterns had
big wins -- ebay 19% (331ms), microsoft 15% (226ms), conduit 15% (277ms)
nytimes 7% (182ms).
Time to DOM content loaded event improved by 6% with some even bigger
individual wins.
First paint time held steady.
Note that I originally wanted to allow preloading of images while in the
head, but that regressed first paint time (even though it was better for
overall load time).
Test: fast/preloader/scan-body-from-head.html
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload):
2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82616.
http://trac.webkit.org/changeset/82616
https://bugs.webkit.org/show_bug.cgi?id=57585
New test does not pass on Gtk, chromium-mac, chromium-linux
and possibly elsewhere (Requested by abarth|gardener on
#webkit).
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
2011-03-31 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Fix ownership semantics for LayerChromium/CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=57577
LayerRendererChromium now uses a RefPtr to preserve ownership of all
of the CCLayerImpl layers that it is using during the update/draw
pass. Addtionally, when a LayerChromium is destroyed, the weak
owner pointer from its CCLayerImpl is correctly unset.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::compareLayerZ):
(WebCore::LayerRendererChromium::updateAndDrawLayers):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::drawsContent):
(WebCore::CCLayerImpl::cleanupResources):
2011-03-31 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Rename WebCore's UI_STRING to WEB_UI_STRING to not overlap with WebKit API
https://bugs.webkit.org/show_bug.cgi?id=57582
* platform/DefaultLocalizationStrategy.cpp:
* platform/LocalizedStrings.h:
2011-03-31 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Rename BidiResolver::lastBeforeET to m_lastBeforeET to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57550
* platform/text/BidiResolver.h:
(WebCore::::createBidiRunsForLine):
2011-03-31 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by James Robinson.
https://bugs.webkit.org/show_bug.cgi?id=45855
Windowless plugins added dynamically to the DOM should receive paint events.
This is done by ensuring that the plugin widget is marked for painting when
it is added.
Test: plugins/windowless_plugin_paint_test.html
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
2011-03-31 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Speed up accelerated path drawing.
https://bugs.webkit.org/show_bug.cgi?id=57371
This CL does three things: re-uses the same vertex and index buffer
for all path draws, converts all vertex layouts from vec3 to vec2, and
does a convexity check for polygons before passing them to the
tesselator.
Covered by canvas/philip/tests/2d.path.bezierCurveTo.*, and others.
* platform/graphics/chromium/GLES2Canvas.cpp:
Replace the Vector<double> for interpolated curves with a
Vector<FloatPoint>.
(WebCore::Cubic::evaluate):
Inline the evaluation function (as Quadratic does).
(WebCore::GLES2Canvas::GLES2Canvas):
Initialize the m_pathIndexBuffer.
(WebCore::GLES2Canvas::~GLES2Canvas):
Delete the path vertex and index buffers on destruction.
(WebCore::interpolateQuadratic):
(WebCore::interpolateCubic):
Interpolate directly to a Vector<FloatPoint>, rather than
Vector<double>.
(WebCore::PolygonData::PolygonData):
(WebCore::combineData):
Replace the DoubleVector with a FloatPointVector.
(WebCore::GLES2Canvas::tesselateAndFillPath):
Move curve drawing into this function, and rename it to reflect the
new behaviour. Re-use the common vertex and index buffers. If the
curve consists of a single convex polygon, draw the curve as a single
triangle fan. Otherwise, convert it to doubles and pass it to the
tesselator.
(WebCore::GLES2Canvas::fillPathInternal):
* platform/graphics/chromium/GLES2Canvas.h:
Rename createVertexBufferFromPath() -> tesselateAndFillPath().
Add a persistent index buffer for all path draws.
* platform/graphics/gpu/BicubicShader.cpp:
(WebCore::BicubicShader::create):
(WebCore::BicubicShader::use):
* platform/graphics/gpu/ConvolutionShader.cpp:
(WebCore::ConvolutionShader::create):
(WebCore::ConvolutionShader::use):
Use vec2s instead of vec3s for all vertex data.
* platform/graphics/gpu/LoopBlinnMathUtils.cpp:
(WebCore::LoopBlinnMathUtils::convexCompare):
(WebCore::LoopBlinnMathUtils::convexCross):
(WebCore::LoopBlinnMathUtils::convexCheckTriple):
(WebCore::LoopBlinnMathUtils::isConvex):
* platform/graphics/gpu/LoopBlinnMathUtils.h:
Implement a convexity check, based on the code in Graphics Gems IV.
* platform/graphics/gpu/Shader.cpp:
(WebCore::Shader::generateVertex):
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::useQuadVertices):
* platform/graphics/gpu/SolidFillShader.cpp:
(WebCore::SolidFillShader::use):
* platform/graphics/gpu/TexShader.cpp:
(WebCore::TexShader::use):
Use vec2s instead of vec3s for all vertex data.
2011-03-31 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=57565
Optimize overflow computations on lines to avoid allocating RenderOverflows in nearly all cases and to avoid even having
to check the line for overflow in the first place.
For the purposes of overflow computation, an inline object's default containment box for overflow is now assumed to extend
all the way from lineTop to lineBottom instead of snugly fitting the inline object's own block dimensions. This allows
replaced objects to be inside spans without triggering overflow allocation.
The overflow accessors on InlineFlowBox have been changed to require passing in the lineTop and lineBottom so that the block
dimensions can be forced to those values. Because these values are checked during painting and hit testing of lines, the
lineTop and lineBottom are now passed as arguments to the painting and hit testing functions to avoid repeatedly crawling
back up to the root box to fetch them.
Added a new boolean flag to all InlineBoxes, knownToHaveNoOverflow(), and optimized for common cases where no overflow can
possibly be present. When the bit is set, computeOverflow will just immediately return.
This change speeds up line layout by ~10%.
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::nodeAtPoint):
* rendering/EllipsisBox.h:
* rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
(WebCore::InlineBox::nodeAtPoint):
(WebCore::InlineBox::clearKnownToHaveNoOverflow):
* rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::logicalFrameRect):
(WebCore::InlineBox::knownToHaveNoOverflow):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::addReplacedChildOverflow):
(WebCore::InlineFlowBox::computeOverflow):
(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):
(WebCore::InlineFlowBox::setOverflowFromLogicalRects):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalTopLayoutOverflow):
(WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
(WebCore::InlineFlowBox::logicalLayoutOverflowRect):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::logicalTopVisualOverflow):
(WebCore::InlineFlowBox::logicalBottomVisualOverflow):
(WebCore::InlineFlowBox::logicalVisualOverflowRect):
(WebCore::InlineFlowBox::frameRectIncludingLineHeight):
(WebCore::InlineFlowBox::logicalFrameRectIncludingLineHeight):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
* rendering/InlineTextBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::adjustLinePositionForPagination):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
* rendering/RenderBox.h:
(WebCore::RenderBox::hasRenderOverflow):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paintEllipsisBox):
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::paint):
(WebCore::RootInlineBox::nodeAtPoint):
(WebCore::RootInlineBox::paddedLayoutOverflowRect):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::logicalTopVisualOverflow):
(WebCore::RootInlineBox::logicalBottomVisualOverflow):
(WebCore::RootInlineBox::logicalTopLayoutOverflow):
(WebCore::RootInlineBox::logicalBottomLayoutOverflow):
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paint):
* rendering/svg/SVGInlineFlowBox.h:
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paint):
* rendering/svg/SVGInlineTextBox.h:
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
* rendering/svg/SVGRootInlineBox.h:
2011-03-31 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: disable properties abbreviation.
https://bugs.webkit.org/show_bug.cgi?id=57525
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::getProperties):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
(.):
():
* inspector/Inspector.json:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions.evaluated):
(WebInspector.ConsoleView.prototype._formatarray):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.prototype.update.callback):
(WebInspector.ObjectPropertiesSection.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
(WebInspector.ObjectPropertyTreeElement.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
* inspector/front-end/PropertiesSidebarPane.js:
(WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.getOwnProperties):
(WebInspector.RemoteObject.prototype.getAllProperties):
(WebInspector.RemoteObject.prototype._getProperties):
(WebInspector.LocalJSONObject.prototype.getOwnProperties):
(WebInspector.LocalJSONObject.prototype.getAllProperties):
* inspector/front-end/inspector.css:
(.console-formatted-string, .console-formatted-regexp):
2011-03-31 Adam Roben <aroben@apple.com>
Update WKCACFViewLayerTreeHost for changes to WKCACFView API
This should not result in any change in behavior.
Fixes <http://webkit.org/b/57560> WKCACFViewLayerTreeHost needs to tell WKCACFView where to
render
Reviewed by Darin Adler.
* platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Updated API declarations.
(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost): Tell WKCACFView it should
render into the window we give it.
2011-03-31 Marius Storm-Olsen <marius.storm-olsen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
https://bugs.webkit.org/show_bug.cgi?id=57017
Build fix. No new tests.
* WebCore.pri:
2011-03-31 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
XML viewer is not shown when frame has non-null opener
https://bugs.webkit.org/show_bug.cgi?id=56384
Removed opener check in XML viewer
Test: http/tests/xmlviewer/extensions-api.html
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::hasNoStyleInformation):
* xml/XMLViewer.js:
2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82589.
http://trac.webkit.org/changeset/82589
https://bugs.webkit.org/show_bug.cgi?id=57564
This patch requires many more updated results than it contains
(Requested by abarth|gardener on #webkit).
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/html.css:
(meter::-webkit-meter-horizontal-bar):
(meter::-webkit-meter-vertical-bar):
(meter::-webkit-meter-horizontal-optimum-value):
(meter::-webkit-meter-horizontal-suboptimal-value):
(meter::-webkit-meter-horizontal-even-less-good-value):
(meter::-webkit-meter-vertical-optimum-value):
(meter::-webkit-meter-vertical-suboptimal-value):
(meter::-webkit-meter-vertical-even-less-good-value):
* rendering/RenderMeter.cpp:
(WebCore::MeterPartElement::MeterPartElement):
(WebCore::MeterPartElement::createForPart):
(WebCore::MeterPartElement::hide):
(WebCore::MeterPartElement::restoreVisibility):
(WebCore::MeterPartElement::updateStyleForPart):
(WebCore::MeterPartElement::saveVisibility):
(WebCore::RenderMeter::~RenderMeter):
(WebCore::RenderMeter::createPart):
(WebCore::RenderMeter::updateFromElement):
(WebCore::RenderMeter::layoutParts):
(WebCore::RenderMeter::shouldHaveParts):
(WebCore::RenderMeter::valuePartRect):
(WebCore::RenderMeter::orientation):
(WebCore::RenderMeter::valuePseudoId):
(WebCore::RenderMeter::barPseudoId):
* rendering/RenderMeter.h:
(WebCore::RenderMeter::shadowAttached):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::supportsMeter):
* rendering/RenderTheme.h:
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::supportsMeter):
* rendering/style/RenderStyleConstants.h:
2011-03-31 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Link explicitly with XRender on Linux/Unix
https://bugs.webkit.org/show_bug.cgi?id=57558
* GNUmakefile.am: add XRender CFLAGS.
2011-03-31 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Rename BidiResolver::emptyRun to m_emtpyRun to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57549
* platform/text/BidiResolver.h:
(WebCore::BidiResolver::BidiResolver):
(WebCore::::appendRun):
(WebCore::::lowerExplicitEmbeddingLevel):
(WebCore::::raiseExplicitEmbeddingLevel):
(WebCore::::deleteRuns):
(WebCore::::createBidiRunsForLine):
* rendering/InlineIterator.h:
(WebCore::InlineBidiResolver::appendRun):
2011-03-31 Tom Sepez <tsepez@chromium.org>
Reviewed by Eric Seidel.
Make ContainerNode::insertIntoDocument() collect all nodes before
operating on any of them. Add small helper function and use it
througout the file where this action is already taking place.
https://bugs.webkit.org/show_bug.cgi?id=57265
Test: svg/dom/range-delete.html
* dom/ContainerNode.cpp:
(WebCore::collectNodes):
(WebCore::collectTargetNodes):
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::willRemoveChildren):
(WebCore::ContainerNode::insertedIntoDocument):
2011-03-31 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
While drawing a speech input button, validate that the node is really a speech input button.
https://bugs.webkit.org/show_bug.cgi?id=57469
Test: fast/speech/speech-style-on-non-speech-elements.html
* dom/Element.h:
(WebCore::Element::isInputFieldSpeechButtonElement):
* html/shadow/TextControlInnerElements.h:
(WebCore::InputFieldSpeechButtonElement::isInputFieldSpeechButtonElement):
(WebCore::toInputFieldSpeechButtonElement):
* rendering/RenderInputSpeech.cpp:
(WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
2011-03-31 Ryosuke Niwa <rniwa@webkit.org>
Build fix after r82588. Reverted unintentional change.
* editing/SelectionController.cpp:
(WebCore::SelectionController::modifyMovingLeft):
2011-03-31 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[GTK] Warnings happening because of unhandled switch cases in AccessibilityObjectWrapperAtk
https://bugs.webkit.org/show_bug.cgi?id=57534
Fix compilation warnings.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(getAttributeSetForAccessibilityObject): Add unhandled cases.
2011-03-30 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove unnecessary newBody output parameter from editScriptSource protocol method.
https://bugs.webkit.org/show_bug.cgi?id=57444
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::editScriptSource):
* bindings/js/ScriptDebugServer.h:
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::editScriptSource):
* bindings/v8/ScriptDebugServer.h:
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::editScriptSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.editScriptSource):
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
(WebInspector.SourceFrame.prototype._handleSave):
2011-03-30 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
<meter> can only support horizontal indicator
https://bugs.webkit.org/show_bug.cgi?id=56001
- Removed code which deals with the direction and
left the horizontal path.
- Removed "horizontal" from related names which is now
redundant.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/html.css:
(meter::-webkit-meter-bar):
(meter::-webkit-meter-optimum-value):
(meter::-webkit-meter-suboptimal-value):
(meter::-webkit-meter-even-less-good-value):
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::~RenderMeter):
(WebCore::RenderMeter::createPart):
(WebCore::RenderMeter::updateFromElement):
(WebCore::RenderMeter::layoutParts):
(WebCore::RenderMeter::styleDidChange):
(WebCore::RenderMeter::shouldHaveParts):
(WebCore::RenderMeter::valuePartRect):
(WebCore::RenderMeter::valuePseudoId):
(WebCore::RenderMeter::barPseudoId):
(WebCore::RenderMeter::detachShadows):
(WebCore::RenderMeter::updateShadows):
* rendering/RenderMeter.h:
(WebCore::RenderMeter::shadowAttached):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::supportsMeter):
* rendering/RenderTheme.h:
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::supportsMeter):
* rendering/style/RenderStyleConstants.h:
2011-03-30 Xiaomei Ji <xji@chromium.org>
Reviewed by Ryosuke Niwa.
Experiment with moving caret by word in visual order.
https://bugs.webkit.org/show_bug.cgi?id=57336
Follow Firefox's convention in Windows,
In LTR block, word break visually moves cursor to the left boundary of words,
In RTL block, word break visually moves cursor to the right boundary of words.
This is the 1st version of implementing "move caret by word in visual order".
It only works in the following situation:
1. For a LTR box in a LTR block or a RTL box in RTL block,
when caret is at the left boundary of the box and we are looking for
the word boundary in right.
2. For a LTR or RTL box in a LTR block, when caret is at the left boundary
of the box and we are looking for the word boundary in left and
previous box is a LTR box.
3. For a LTR or RTL box in a RTL block, when the caret is at the right
boundary of the box and we are looking for the word boundary in right and next box is RTL box.
An experimental granularity is introduced, as a side effect, functions having switch statements
to handle those granularities have to add more one case to handle this new granularity.
The experimental granularity is exposed though JS by '-webkit-visual-word".
The overall algorithm is looping through inline boxes visually and looking
for the visually nearest word break position.
Test: editing/selection/move-by-word-visually.html
* editing/SelectionController.cpp:
(WebCore::SelectionController::modifyExtendingRight):
(WebCore::SelectionController::modifyExtendingForward):
(WebCore::SelectionController::modifyMovingRight):
(WebCore::SelectionController::modifyMovingForward):
(WebCore::SelectionController::modifyExtendingLeft):
(WebCore::SelectionController::modifyExtendingBackward):
(WebCore::SelectionController::modifyMovingLeft):
(WebCore::SelectionController::modifyMovingBackward):
* editing/TextGranularity.h:
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
* editing/visible_units.cpp:
(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
(WebCore::wordBoundaryInBox):
(WebCore::wordBoundaryInAdjacentBoxes):
(WebCore::leftWordBoundary):
(WebCore::rightWordBoundary):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):
* editing/visible_units.h:
* page/DOMSelection.cpp:
(WebCore::DOMSelection::modify):
2011-03-31 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Move coordinate-computing logic into MouseRelatedEvent.
https://bugs.webkit.org/show_bug.cgi?id=57521
Refactoring, covered by existing tests.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchWheelEvent): Yank calculation of
coordinates out.
(WebCore::EventDispatcher::dispatchMouseEvent): Ditto.
* dom/MouseEvent.cpp:
(WebCore::MouseEvent::create): Add coordinate-computing logic.
* dom/MouseEvent.h: Adjust decl to reflect new meaning of params.
* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent): Ditto.
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent): Ditto.
2011-03-30 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: document CSS agent.
https://bugs.webkit.org/show_bug.cgi?id=57435
* inspector/Inspector.json:
2011-03-31 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: remove periods at the end of error messages
https://bugs.webkit.org/show_bug.cgi?id=57544
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::makeObjectCall):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::elementForId):
(WebCore::InspectorCSSAgent::styleSheetForId):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::assertNode):
(WebCore::InspectorDOMAgent::assertElement):
(WebCore::InspectorDOMAgent::assertHTMLElement):
(WebCore::InspectorDOMAgent::querySelector):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::setAttribute):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeValue):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::resourceContent):
(WebCore::InspectorResourceAgent::resourceContentBase64):
(WebCore::InspectorResourceAgent::getResourceContent):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::setPropertyValue):
2011-03-31 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
<title> should support dir attribute
https://bugs.webkit.org/show_bug.cgi?id=50961
Introduce a new StringWithDirection object that carries a String along
with the TextDirection associated with the String. Use this object for
document titles used within WebCore, because in HTML the direction of
a title can be set with the 'dir' attribute.
Put FIXMEs at the WebKit level to expose the new direction information
to clients.
No behavioral change intended, so no new tests. A follow-up will expose
the title direction and hopefully can be accompanied by tests that
verify it is correct.
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::updateTitle):
(WebCore::Document::setTitle):
(WebCore::Document::removeTitle):
* dom/Document.h:
(WebCore::Document::title):
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::HTMLTitleElement):
(WebCore::HTMLTitleElement::childrenChanged):
(WebCore::HTMLTitleElement::text):
(WebCore::HTMLTitleElement::textWithDirection):
* html/HTMLTitleElement.h:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setTitle):
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::title):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidReceiveTitle):
(WebCore::EmptyFrameLoaderClient::setTitle):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::setTitle):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/HistoryController.cpp:
(WebCore::HistoryController::updateForBackForwardNavigation):
(WebCore::HistoryController::updateForReload):
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
(WebCore::HistoryController::updateForClientRedirect):
(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::setCurrentItemTitle):
(WebCore::HistoryController::initializeItem):
* loader/HistoryController.h:
* platform/text/StringWithDirection.h: Added.
(WebCore::StringWithDirection::StringWithDirection):
(WebCore::StringWithDirection::operator==):
(WebCore::StringWithDirection::operator!=):
* svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::insertedIntoDocument):
(WebCore::SVGTitleElement::childrenChanged):
2011-03-31 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: CSS domain - make a "range" object, get rid of "properties" object for Style objects
https://bugs.webkit.org/show_bug.cgi?id=57538
* inspector/InspectorStyleSheet.cpp:
(WebCore::buildSourceRangeObject):
(WebCore::InspectorStyle::buildObjectForStyle):
(WebCore::InspectorStyle::populateObjectWithStyleProperties):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleDeclaration):
2011-03-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82565.
http://trac.webkit.org/changeset/82565
https://bugs.webkit.org/show_bug.cgi?id=57541
Caused assertion failures. (Requested by bbandix on #webkit).
* platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::setFloodColor):
(WebCore::FEFlood::setFloodOpacity):
* platform/graphics/filters/FEFlood.h:
* platform/graphics/filters/FESpecularLighting.cpp:
(WebCore::FESpecularLighting::setLightingColor):
* platform/graphics/filters/FESpecularLighting.h:
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
* rendering/svg/RenderSVGResourceFilterPrimitive.h:
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientStyleChanged):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
* svg/SVGFEFloodElement.cpp:
* svg/SVGFEFloodElement.h:
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
2011-03-31 Renata Hodovan <reni@webkit.org>
Reviewed by Dirk Schulze.
CSS related SVG*Element changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=56906
The changes of some CSS related SVGFilter properties e.g. lighting-color, flood-color, flood-opacity
need only repaint. To avoid the default invalidation of filters in SVGResourceCache::clientStyleChange()
we need an early return. So RenderSVGResourceFilterPrimitive::styleDidChange() can handle these properties
via RenderSVGResourceFilter::primitiveAttributeChanged() the same way like we do it for the other SVGAttributes.
Tests: svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html
svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html
svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html
* platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::setFloodColor):
(WebCore::FEFlood::setFloodOpacity):
* platform/graphics/filters/FEFlood.h:
* platform/graphics/filters/FESpecularLighting.cpp:
(WebCore::FESpecularLighting::setLightingColor):
* platform/graphics/filters/FESpecularLighting.h:
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):
* rendering/svg/RenderSVGResourceFilterPrimitive.h:
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientStyleChanged):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
* svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::setFilterEffectAttribute):
* svg/SVGFEFloodElement.h:
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
2011-03-29 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
XML Viewer: declared namespaces are not rendered.
https://bugs.webkit.org/show_bug.cgi?id=56262
XML viewer rewritten on javascript.
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doEnd):
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
* xml/XMLViewer.css: Added.
* xml/XMLViewer.js: Added.
* xml/XMLViewer.xsl: Removed.
* xml/XSLStyleSheet.h:
2011-03-31 Jaehun Lim <ljaehun.lim@samsung.com>
Unreviewed build fix.
Fix build break after rolling out r82496
https://bugs.webkit.org/show_bug.cgi?id=57536
* platform/efl/RenderThemeEfl.cpp:
2011-03-31 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: execution line is displayed incorrectly after source editing.
https://bugs.webkit.org/show_bug.cgi?id=57229
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._saveViewerState):
(WebInspector.SourceFrame.prototype._restoreViewerState):
(WebInspector.SourceFrame.prototype._startEditing):
(WebInspector.SourceFrame.prototype._endEditing):
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype.setExecutionLine):
(WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
(WebInspector.SourceFrame.prototype._handleSave):
(WebInspector.SourceFrame.prototype._handleRevertEditing):
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorChunkedPanel.prototype.addDecoration):
(WebInspector.TextEditorChunkedPanel.prototype.removeDecoration):
(WebInspector.TextEditorMainPanel.prototype.makeLineAChunk):
(WebInspector.TextEditorMainPanel.prototype._positionToSelection):
2011-03-30 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Make the CSStyle "shorthandValues" name-value map an array
https://bugs.webkit.org/show_bug.cgi?id=57452
No new tests, as this is a refactoring.
* inspector/InspectorCSSAgent.cpp:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::populateObjectWithStyleProperties):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleDeclaration):
(WebInspector.CSSStyleDeclaration.buildShorthandValueMap):
2011-03-30 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JavaField should not expose JavaString in its API
https://bugs.webkit.org/show_bug.cgi?id=55766
This patch fixes JavaField for V8 only.
- Factors out a JavaField interface which does not use JNI types.
This will allow the Java bridge to be used with objects that
don't use JNI directly. The existing jobject-backed
implementation is moved to a new JavaFieldJobject class which
implements the interface.
- Use WTF::String in place of JavaString in the API, as JavaString
exposes JNI types in its interface.
No new tests, refactoring only.
* Android.v8bindings.mk:
* WebCore.gypi:
* bridge/jni/JavaMethod.h:
(JSC::Bindings::JavaMethod::~JavaMethod):
* bridge/jni/JobjectWrapper.h:
* bridge/jni/v8/JavaClassV8.cpp:
(JavaClass::JavaClass):
* bridge/jni/v8/JavaFieldJobjectV8.cpp:
(JavaFieldJobject::JavaFieldJobject):
* bridge/jni/v8/JavaFieldJobjectV8.h:
(JSC::Bindings::JavaFieldJobject::name):
(JSC::Bindings::JavaFieldJobject::typeClassName):
(JSC::Bindings::JavaFieldJobject::type):
* bridge/jni/v8/JavaFieldV8.h:
(JSC::Bindings::JavaField::~JavaField):
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::getField):
2011-03-31 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Clean up from r82447.
https://bugs.webkit.org/attachment.cgi?bugid=57532
No new tests since this doesn't change behavior.
* rendering/RenderBlock.cpp: Removing unnecessary visible_units.h include.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::getLogicalStartBoxWithNode): Making const.
(WebCore::RootInlineBox::getLogicalEndBoxWithNode): Ditto.
* rendering/RootInlineBox.h:
2011-03-31 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ojan Vafai.
DeleteSelectionCommand::removeNode tries to insert block placeholder in non-editable table cell positions
https://bugs.webkit.org/show_bug.cgi?id=57079
Test: editing/execCommand/delete-table-with-empty-contents.html
This bug results in an ASSERT fail in CompositeEditCommand::insertNodeAt, so is only observable in debug builds
of WebKit.
* editing/DeleteSelectionCommand.cpp:
(WebCore::firstEditablePositionInNode):
(WebCore::DeleteSelectionCommand::removeNode): Use firstEditablePositionInNode rather than firstPositionInNode
to find anchor node for the placeholder's position, if any.
2011-03-30 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Roben.
REGRESSION (r82400): Leaks seen beneath CSSParser::createFloatingVectorSelector when parsing UA stylesheet
https://bugs.webkit.org/show_bug.cgi?id=57478
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::sinkFloatingSelectorVector):
* css/CSSParser.h:
2011-03-30 Dominic Cooney <dominicc@google.com>
Reviewed by Dimitri Glazkov.
Adds layoutTestController.shadowRoot accessor to Mac DRT.
https://bugs.webkit.org/show_bug.cgi?id=57415
* WebCore.exp.in: DRT needs to link WebCore::Element::shadowRoot
2011-03-30 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Simplify HTMLFormElement::validateInteractively() for asynchronous scroll event
https://bugs.webkit.org/show_bug.cgi?id=57424
r75555 made 'scroll' event asynchronous. So we don't need to worry about
deleting or moving a target node in scrollIntoViewIfNeeded().
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively): Remove unnecessary code.
2011-03-30 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
REGRESSION (r74895): Crash if input.type = 'file' twice
https://bugs.webkit.org/show_bug.cgi?id=57343
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
Don't call setAttribute() if the type is not changed.
2011-03-30 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Autocorrection panel isn't positioned correctly in Safari (mac) when the zooming is not 1x.
https://bugs.webkit.org/show_bug.cgi?id=57353
<rdar://problem/9163983>
We use Range::textQuads() instead of Range::boundingRect() to compute the position of correction
panel. The latter function compensates for zooming, which we don't need in this case. We also
dismiss correction panel when zooming factor is changed. This is done in Frame::setPageAndTextZoomFactors().
* WebCore.exp.in:
* dom/Range.cpp:
(WebCore::Range::textQuads):
* dom/Range.h:
* editing/Editor.cpp:
(WebCore::Editor::windowRectForRange):
* editing/Editor.h:
* page/Frame.cpp:
(WebCore::Frame::setPageAndTextZoomFactors):
2011-03-30 Chris Guillory <chris.guillory@google.com>
Reviewed by Dimitri Glazkov.
Render fonts using skia when requested by platform context.
https://bugs.webkit.org/show_bug.cgi?id=56441
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
* platform/graphics/skia/PlatformContextSkia.h:
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::windowsCanHandleTextDrawing):
(WebCore::skiaDrawText):
(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):
2011-03-30 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/9199518> Crash when focusing a styled editable element
Test: editing/deleting/delete-button-background-image-none.html
* editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement): Check all background layers for background images.
* rendering/style/RenderStyle.h: Removed backgroundImage() as it was only used, incorrectly,
in the above function.
2011-03-30 Martin Robinson <mrobinson@igalia.com>
Try once more to fix the EFL build.
* platform/efl/RenderThemeEfl.cpp:
2011-03-30 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
Regression: VO cursor doesn't follow KB focus back into HTML view
https://bugs.webkit.org/show_bug.cgi?id=57509
In WK2, because the web area never believes focus leave the area, sending the initial
focus change when moving back into the web area, does not trigger a notification.
That behavior needs to be overridden by explicitly posting a focused UI element change
at the appropriate time. This is only used in WK2, hence the absence of a layout test for now.
* page/FocusController.cpp:
(WebCore::FocusController::setInitialFocus):
2011-03-30 MORITA Hajime <morrita@google.com>
Reviewed by Simon Fraser.
box-shadow radii stays the same regardless of any spread set
https://bugs.webkit.org/show_bug.cgi?id=49726
- Removed special shadowSpread handling path
- Fixed broken multple inset shadow border computation.
Test: fast/box-shadow/spread-multiple-inset.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
2011-03-29 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Use the Accelerate vImage vectorized (un)premultiplyImageData functions for ImageBufferCG
https://bugs.webkit.org/show_bug.cgi?id=53134
Test: fast/canvas/getPutImageDataPairTest.html
* platform/graphics/cg/ImageBufferCG.cpp:
2011-03-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Share most vsprops between Release and Production builds in releaseproduction.vsprops
https://bugs.webkit.org/show_bug.cgi?id=57508
* WebCore.vcproj/QTMovieWinProduction.vsprops:
* WebCore.vcproj/QTMovieWinRelease.vsprops:
* WebCore.vcproj/QTMovieWinReleaseCairoCFLite.vsprops:
* WebCore.vcproj/WebCoreProduction.vsprops:
* WebCore.vcproj/WebCoreRelease.vsprops:
* WebCore.vcproj/WebCoreReleaseCairoCFLite.vsprops:
2011-03-30 Timur Iskhodzhanov <timurrrr@google.com>
Reviewed by Alexey Proskuryakov.
Add some dynamic annotations to JavaScriptCore/wtf
https://bugs.webkit.org/show_bug.cgi?id=53747
By using these annotations we can improve the precision of finding
WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
These files don't add new functionality, so don't need extra tests.
* ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
2011-03-30 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Fix wrong type assumptions in editing code. Move code
from ASSERTs to hard checks.
https://bugs.webkit.org/show_bug.cgi?id=57348
Test: editing/execCommand/remove-format-non-html-element-crash.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* editing/ApplyStyleCommand.cpp:
(WebCore::getRGBAFontColor):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
* editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
* editing/Editor.cpp:
(WebCore::Editor::textDirectionForSelection):
* editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::elementForFormatBlockCommand):
2011-03-30 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Speed up clipping in accelerated 2D canvas.
https://bugs.webkit.org/show_bug.cgi?id=57464
Instead of clearing the entire stencil buffer when removing clipping paths, we erase the path with a DECR stencil operation.
Covered by canvas/philip/tests/2d.path.clip.intersect.html, and others.
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::PathAndTransform::PathAndTransform):
New structure to keep track of the CTM at the time the clipping path was added.
(WebCore::GLES2Canvas::State::State):
Replace m_clippingEnabled with a count of total clipping paths.
(WebCore::GLES2Canvas::clearRect):
Check the total clipping path count, instead of m_clippingEnabled.
(WebCore::GLES2Canvas::fillPath):
(WebCore::GLES2Canvas::fillRect):
Perform state application after doing shadows. This is necessary
since restore() may now leave clipping enabled.
(WebCore::GLES2Canvas::clipPath):
Explicitly specify the stencil operation as INCR. Store the current
transformation when saving clipping paths.
(WebCore::GLES2Canvas::restore):
Don't clear the stencil buffer and re-draw active paths on each restore.
Erase the old paths with DECR.
(WebCore::GLES2Canvas::drawTexturedRect):
Check m_numClippingPaths instead of m_clippingEnabled.
(WebCore::GLES2Canvas::beginShadowDraw):
Perform state application when drawing hard shadows.
(WebCore::GLES2Canvas::endShadowDraw):
Check m_numClippingPaths instead of m_clippingEnabled.
(WebCore::GLES2Canvas::beginStencilDraw):
Make the stencil op a parameter to beginShadowDraw().
(WebCore::GLES2Canvas::applyClipping):
Compare against the total number of stencil paths, not just the ones in
the current state.
* platform/graphics/chromium/GLES2Canvas.h:
Make the stencil op a parameter to beginShadowDraw().
2011-03-29 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Move factory-like things in EventDispatcher::dispatchMouseEvent to a factory, clean up names and ordering.
https://bugs.webkit.org/show_bug.cgi?id=57419
Refactoring, covered by existing tests.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchMouseEvent): Reordered and clarified names.
* dom/MouseEvent.cpp:
(WebCore::MouseEvent::create): Added a new factory method that takes PlatformMouseEvent.
* dom/MouseEvent.h: Added decl.
2011-03-30 Erik Arvidsson <arv@chromium.org>
Reviewed by Alexey Proskuryakov.
Missing DOM bindings for a ping
https://bugs.webkit.org/show_bug.cgi?id=51955
Test: fast/dom/ping-attribute-dom-binding.html
* html/HTMLAnchorElement.idl:
* html/HTMLAreaElement.idl:
2011-03-30 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r82465.
* CMakeListsWinCE.txt:
2011-03-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Update Windows production build logic for new production configurations
https://bugs.webkit.org/show_bug.cgi?id=57494
* WebCore.vcproj/QTMovieWinProduction.vsprops:
* WebCore.vcproj/WebCore.make:
* WebCore.vcproj/WebCoreProduction.vsprops:
2011-03-30 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
WebKit2: Attempting to view css file from url causes it to download
<rdar://problem/9102611>
https://bugs.webkit.org/show_bug.cgi?id=57501
* WebCore.exp.in:
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeUnsupportedTextMIMETypes):
(WebCore::initializeMIMETypeRegistry):
(WebCore::MIMETypeRegistry::isUnsupportedTextMIMEType):
(WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes):
* platform/MIMETypeRegistry.h:
Add set of unsupported text MIME types, taken from WebKit/mac.
2011-03-30 Brian Weinstein <bweinstein@apple.com>
Reviewed by Darin Adler.
Crash when closing "Add Bookmark" dialog using the Enter Key
https://bugs.webkit.org/show_bug.cgi?id=57294
<rdar://problem/9044756>
Protect the FrameView in EventHandler::keyEvent, like we do in other EventHandler
functions that could destroy the frame.
* page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
2011-03-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82463.
http://trac.webkit.org/changeset/82463
https://bugs.webkit.org/show_bug.cgi?id=57482
Assertion failure in Node::rendererIsEditable on multiple
editing tests (Requested by aroben|meeting on #webkit).
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
2011-03-24 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QNetworkReplyHandler refactoring: signal sequence.
https://bugs.webkit.org/show_bug.cgi?id=57049
This is the first step in QNetworkReplyHandler. The main objective here is to create simple invariants:
1 - that the signals metadatachanged, readyRead and finished will come in this order.
2 - that signals metadatachanged and finished will be called exactly once.
Having these invariants further simplifications will be possible and will come in future patches.
Class QNetworkReplyWrapper was created to handle QNetworkReply object. To connect to the signals of it
instead of connecting to the signals of QNetworkReply is what guarantees the sequence of the signals.
QNetworkReplyWrapper will be used in future to perform mime type sniffing before sending
metadatachanged signal.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::release):
(WebCore::QNetworkReplyWrapper::resetConnections):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::redirect):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyWrapper::reply):
(WebCore::QNetworkReplyWrapper::redirectionTargetUrl):
(WebCore::QNetworkReplyWrapper::encoding):
(WebCore::QNetworkReplyWrapper::advertisedMimeType):
(WebCore::QNetworkReplyHandler::reply):
2011-03-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Rename Windows configuration Release_LTCG to Production for clarity
https://bugs.webkit.org/show_bug.cgi?id=57465
* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/QTMovieWinProduction.vsprops: Copied from Source/WebCore/WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops.
* WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops: Removed.
* WebCore.vcproj/WebCore.sln:
* WebCore.vcproj/WebCore.submit.sln:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreGenerated.vcproj:
* WebCore.vcproj/WebCoreProduction.vsprops: Copied from Source/WebCore/WebCore.vcproj/WebCoreReleaseLTCG.vsprops.
* WebCore.vcproj/WebCoreReleaseLTCG.vsprops: Removed.
2011-03-30 Brian Weinstein <bweinstein@apple.com>
Reviewed by Anders Carlsson.
ASSERT(cookieStorageAdapter) when calling stopObservingCookieChanges after WebProcess has crashed
https://bugs.webkit.org/show_bug.cgi?id=57477
<rdar://problem/9178751>
If someone has called startObservingCookieChanges, and the WebProcess crashes and restarts, the UIProcess
will call stopObservingCookieChanges when cookieStorageAdapter is nil.
The assert is wrong when the web process crashes, and there is no harm in dispatching a message to nil,
so remove the assert.
* platform/network/mac/CookieStorageMac.mm:
(WebCore::stopObservingCookieChanges):
2011-03-30 Sam Weinig <sam@webkit.org>
Fix Leopard build.
* platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
2011-03-30 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add default localization strategy that can be shared by WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57406
Currently, only WebKit2 uses this default strategy, but WebKit1 should be able
to adopt it soon.
* platform/DefaultLocalizationStrategy.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp.
(WebCore::DefaultLocalizationStrategy::DefaultLocalizationStrategy):
* platform/DefaultLocalizationStrategy.h: Copied from Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h.
Copy the implementation of the Localization strategy from WebKit2 into a shared default strategy.
* platform/LocalizedStrings.cpp:
(WebCore::localizedString):
Add default implementation of localization bottleneck function.
* platform/LocalizedStrings.h:
Add localization macros here, instead of defining them in the above layer.
* platform/PlatformStrategies.cpp:
(WebCore::PlatformStrategies::createLocalizationStrategy):
* platform/PlatformStrategies.h:
Add default implementation of strategy creation function which creates the default strategy.
* platform/win/LocalizedStringsWin.cpp: Copied from Source/WebCore/platform/mac/LocalizedStringsMac.mm.
(WebCore::localizedString):
Add stub for windows, this will be update to pull from the bundle in a follow up patch.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Add new files.
2011-03-30 Andras Becsi <abecsi@webkit.org>
Reviewed by Darin Adler.
CSS: Slow parsing of rgb() with percent values
https://bugs.webkit.org/show_bug.cgi?id=16708
Implement fast-path parsing for percentage color values.
Gain ~30% speedup on http://canvex.lazyilluminati.com/misc/3d.html
Relanding with rounding fix after it was rolled out in r82315.
* css/CSSParser.cpp:
(WebCore::checkForValidDouble): Extend to return the number of characters forming a valid double.
(WebCore::parseDouble): Function for parsing double values if they are valid.
(WebCore::parseColorIntOrPercentage): Extend parseColorInt to deal with percentage values.
(WebCore::parseAlphaValue): Use the new functions.
(WebCore::CSSParser::parseColor): Ditto.
2011-03-30 Ofri Wolfus <ofri@dhcp-172-28-40-178.tlv.corp.google.com>
Reviewed by Eric Seidel.
Add support for parsing unicode-bidi: -webkit-plaintext.
https://bugs.webkit.org/show_bug.cgi?id=57457
Test: css3/unicode-bidi-plaintext-parse.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
2011-03-30 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Remove unused variables in GraphicsContext::fillRect()
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillRect):
2011-03-30 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
REGRESSION(r82419): New pixel test failure fast/box-shadow/basic-shadows.html
https://bugs.webkit.org/show_bug.cgi?id=57442
When checking the position of the inline iterator in the logicallyLastRun, we should not consider BR as text.
No new tests as existing test covers this case.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::reachedEndOfTextRenderer):
2011-03-30 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
https://bugs.webkit.org/show_bug.cgi?id=47636
Define new roles in WebCore and map them to ATK accordingly.
Test: platform/gtk/accessibility/aria-roles-unignored.html
* accessibility/AccessibilityObject.h: Added new roles to
represent paragraphs, labels, forms and div sections.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
Return ParagraphRole, LabelRole, FormRole and DivRole when needed
for the GTK platform only.
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::allowsTextRanges): Consider the new
roles now that those kind of nodes won't return true to isGroup().
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(atkRole): Map new WebCore roles to ATK Roles.
(webkit_accessible_get_role): Remove code to define roles for
paragraphs, labels, forms and divs based on node's tag name.
Update mappings for the Mac platform.
* accessibility/mac/AccessibilityObjectWrapper.mm:
(createAccessibilityRoleMap): Add explicit mappings from the new
roles introduced to NSAccessibilityGroupRole.
2011-03-30 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Build fix for Efl and Qt Win.
* inspector/PageDebuggerAgent.cpp: removed ENABLE(WORKERS) guard from code that has nothing to do with workers.
2011-03-30 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: audit run never completes, fails in DOMAgent.js
https://bugs.webkit.org/show_bug.cgi?id=57349
- assure document is present before calling DOMAgent.querySelectAll()
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
2011-03-30 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Build fix.
* UseJSC.cmake: fix typo PageDebugServer -> PageScriptDebugServer
2011-03-30 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: split debugger agent into Page and Worker-specific ones
https://bugs.webkit.org/show_bug.cgi?id=57345
ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
and Page/WorkerDebuggerAgent.
* CMakeLists.txt:
* GNUmakefile.am:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::currentCallFrame):
* bindings/js/PageScriptDebugServer.cpp: Added.
(WebCore::toPage):
(WebCore::PageScriptDebugServer::shared):
(WebCore::PageScriptDebugServer::PageScriptDebugServer):
(WebCore::PageScriptDebugServer::~PageScriptDebugServer):
(WebCore::PageScriptDebugServer::addListener):
(WebCore::PageScriptDebugServer::removeListener):
(WebCore::PageScriptDebugServer::recompileAllJSFunctions):
(WebCore::PageScriptDebugServer::getListenersForGlobalObject):
(WebCore::PageScriptDebugServer::didPause):
(WebCore::PageScriptDebugServer::didContinue):
(WebCore::PageScriptDebugServer::didRemoveLastListener):
(WebCore::PageScriptDebugServer::setJavaScriptPaused):
* bindings/js/PageScriptDebugServer.h: Added.
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::sourceParsed):
(WebCore::ScriptDebugServer::dispatchFunctionToListeners):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::pauseIfNeeded):
* bindings/js/ScriptDebugServer.h:
* bindings/js/WorkerScriptDebugServer.cpp: Added.
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::removeListener):
* bindings/js/WorkerScriptDebugServer.h: Added.
(WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
(WebCore::WorkerScriptDebugServer::getListenersForGlobalObject):
(WebCore::WorkerScriptDebugServer::didPause):
(WebCore::WorkerScriptDebugServer::didContinue):
* bindings/v8/PageScriptDebugServer.cpp: Added.
(WebCore::retrieveFrame):
(WebCore::PageScriptDebugServer::shared):
(WebCore::PageScriptDebugServer::PageScriptDebugServer):
(WebCore::PageScriptDebugServer::addListener):
(WebCore::PageScriptDebugServer::removeListener):
(WebCore::PageScriptDebugServer::setClientMessageLoop):
(WebCore::PageScriptDebugServer::getDebugListenerForContext):
(WebCore::PageScriptDebugServer::runMessageLoopOnPause):
(WebCore::PageScriptDebugServer::quitMessageLoopOnPause):
* bindings/v8/PageScriptDebugServer.h: Added.
(WebCore::PageScriptDebugServer::setEnabled):
(WebCore::PageScriptDebugServer::ClientMessageLoop::~ClientMessageLoop):
(WebCore::PageScriptDebugServer::~PageScriptDebugServer):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setPauseOnNextStatement):
(WebCore::ScriptDebugServer::breakProgram):
(WebCore::ScriptDebugServer::continueProgram):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::editScriptSource):
(WebCore::toScriptDebugServer):
(WebCore::ScriptDebugServer::breakProgramCallback):
(WebCore::ScriptDebugServer::v8DebugEventCallback):
(WebCore::ScriptDebugServer::handleV8DebugEvent):
(WebCore::ScriptDebugServer::isPaused):
* bindings/v8/ScriptDebugServer.h:
* bindings/v8/WorkerScriptDebugServer.cpp: Added.
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::removeListener):
* bindings/v8/WorkerScriptDebugServer.h: Added.
(WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
(WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::currentCallFrameCallback):
* inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::init):
(WebCore::InjectedScriptHost::debuggerAgent):
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::setBreakpointsActive):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::editScriptSource):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::resume):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::enable):
(WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
* inspector/PageDebuggerAgent.cpp: Added.
(WebCore::PageDebuggerAgent::create):
(WebCore::PageDebuggerAgent::PageDebuggerAgent):
(WebCore::PageDebuggerAgent::~PageDebuggerAgent):
(WebCore::PageDebuggerAgent::startListeningScriptDebugServer):
(WebCore::PageDebuggerAgent::stopListeningScriptDebugServer):
(WebCore::PageDebuggerAgent::scriptDebugServer):
* inspector/PageDebuggerAgent.h: Added.
* inspector/WorkerDebuggerAgent.cpp: Added.
(WebCore::WorkerDebuggerAgent::create):
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
(WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
(WebCore::WorkerDebuggerAgent::scriptDebugServer):
* inspector/WorkerDebuggerAgent.h: Added.
2011-03-30 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Clicking below last line of right-to-left editable text that puts caret in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=38087
Moving getLogical[Start/End]BoxWithNode to RootInlineBox and using it in positionForPointWithInlineChildren
instead of lastLeafChild, which wasn't correct in the RTL case.
Test: editing/selection/click-below-rtl-text.html
* editing/visible_units.cpp:
(WebCore::logicalStartPositionForLine): Moved to RootInlineBox.
(WebCore::logicalEndPositionForLine): Ditto.
* editing/visible_units.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren): Useing getLogicalEndBoxWithNode instead
of lastLeafChild.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::getLogicalStartBoxWithNode): Moved and refactored.
(WebCore::RootInlineBox::getLogicalEndBoxWithNode): Ditto.
* rendering/RootInlineBox.h:
2011-03-30 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Rollout r82438 and r82436.
* CMakeLists.txt:
* GNUmakefile.am:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::currentCallFrame):
* bindings/js/PageScriptDebugServer.cpp: Removed.
* bindings/js/PageScriptDebugServer.h: Removed.
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::shared):
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::addListener):
(WebCore::ScriptDebugServer::removeListener):
(WebCore::ScriptDebugServer::hasListenersInterestedInPage):
(WebCore::toPage):
(WebCore::ScriptDebugServer::sourceParsed):
(WebCore::ScriptDebugServer::dispatchFunctionToListeners):
(WebCore::ScriptDebugServer::setJavaScriptPaused):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::pauseIfNeeded):
(WebCore::ScriptDebugServer::recompileAllJSFunctions):
(WebCore::ScriptDebugServer::didAddListener):
(WebCore::ScriptDebugServer::didRemoveListener):
* bindings/js/ScriptDebugServer.h:
* bindings/js/WorkerScriptDebugServer.cpp: Removed.
* bindings/js/WorkerScriptDebugServer.h: Removed.
* bindings/v8/PageScriptDebugServer.cpp: Removed.
* bindings/v8/PageScriptDebugServer.h: Removed.
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::retrieveFrame):
(WebCore::ScriptDebugServer::shared):
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::addListener):
(WebCore::ScriptDebugServer::removeListener):
(WebCore::ScriptDebugServer::setPauseOnNextStatement):
(WebCore::ScriptDebugServer::breakProgram):
(WebCore::ScriptDebugServer::continueProgram):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::editScriptSource):
(WebCore::ScriptDebugServer::setEnabled):
(WebCore::ScriptDebugServer::breakProgramCallback):
(WebCore::ScriptDebugServer::v8DebugEventCallback):
(WebCore::ScriptDebugServer::handleV8DebugEvent):
(WebCore::ScriptDebugServer::didResume):
* bindings/v8/ScriptDebugServer.h:
(WebCore::ScriptDebugServer::pageCreated):
(WebCore::ScriptDebugServer::ClientMessageLoop::~ClientMessageLoop):
(WebCore::ScriptDebugServer::setClientMessageLoop):
* bindings/v8/WorkerScriptDebugServer.cpp: Removed.
* bindings/v8/WorkerScriptDebugServer.h: Removed.
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::currentCallFrameCallback):
* inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::init):
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::create):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::setBreakpointsActive):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::editScriptSource):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::resume):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::enable):
(WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
* inspector/PageDebuggerAgent.cpp: Removed.
* inspector/PageDebuggerAgent.h: Removed.
* inspector/WorkerDebuggerAgent.cpp: Removed.
* inspector/WorkerDebuggerAgent.h: Removed.
2011-03-30 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix compilation on Windows and EFL.
* CMakeLists.txt:
* bindings/js/JSBindingsAllInOne.cpp:
2011-03-30 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: split debugger agent into Page and Worker-specific ones
https://bugs.webkit.org/show_bug.cgi?id=57345
ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
and Page/WorkerDebuggerAgent.
* GNUmakefile.am:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::currentCallFrame):
* bindings/js/PageScriptDebugServer.cpp: Added.
(WebCore::toPage):
(WebCore::PageScriptDebugServer::shared):
(WebCore::PageScriptDebugServer::PageScriptDebugServer):
(WebCore::PageScriptDebugServer::~PageScriptDebugServer):
(WebCore::PageScriptDebugServer::addListener):
(WebCore::PageScriptDebugServer::removeListener):
(WebCore::PageScriptDebugServer::recompileAllJSFunctions):
(WebCore::PageScriptDebugServer::getListenersForGlobalObject):
(WebCore::PageScriptDebugServer::didPause):
(WebCore::PageScriptDebugServer::didContinue):
(WebCore::PageScriptDebugServer::didRemoveLastListener):
(WebCore::PageScriptDebugServer::setJavaScriptPaused):
* bindings/js/PageScriptDebugServer.h: Added.
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::sourceParsed):
(WebCore::ScriptDebugServer::dispatchFunctionToListeners):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::pauseIfNeeded):
* bindings/js/ScriptDebugServer.h:
* bindings/js/WorkerScriptDebugServer.cpp: Added.
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::removeListener):
* bindings/js/WorkerScriptDebugServer.h: Added.
(WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
(WebCore::WorkerScriptDebugServer::getListenersForGlobalObject):
(WebCore::WorkerScriptDebugServer::didPause):
(WebCore::WorkerScriptDebugServer::didContinue):
* bindings/v8/PageScriptDebugServer.cpp: Added.
(WebCore::retrieveFrame):
(WebCore::PageScriptDebugServer::shared):
(WebCore::PageScriptDebugServer::PageScriptDebugServer):
(WebCore::PageScriptDebugServer::addListener):
(WebCore::PageScriptDebugServer::removeListener):
(WebCore::PageScriptDebugServer::setClientMessageLoop):
(WebCore::PageScriptDebugServer::getDebugListenerForContext):
(WebCore::PageScriptDebugServer::runMessageLoopOnPause):
(WebCore::PageScriptDebugServer::quitMessageLoopOnPause):
* bindings/v8/PageScriptDebugServer.h: Added.
(WebCore::PageScriptDebugServer::setEnabled):
(WebCore::PageScriptDebugServer::ClientMessageLoop::~ClientMessageLoop):
(WebCore::PageScriptDebugServer::~PageScriptDebugServer):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setPauseOnNextStatement):
(WebCore::ScriptDebugServer::breakProgram):
(WebCore::ScriptDebugServer::continueProgram):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::editScriptSource):
(WebCore::toScriptDebugServer):
(WebCore::ScriptDebugServer::breakProgramCallback):
(WebCore::ScriptDebugServer::v8DebugEventCallback):
(WebCore::ScriptDebugServer::handleV8DebugEvent):
(WebCore::ScriptDebugServer::isPaused):
* bindings/v8/ScriptDebugServer.h:
* bindings/v8/WorkerScriptDebugServer.cpp: Added.
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::removeListener):
* bindings/v8/WorkerScriptDebugServer.h: Added.
(WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
(WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::currentCallFrameCallback):
* inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::init):
(WebCore::InjectedScriptHost::debuggerAgent):
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::setBreakpointsActive):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::editScriptSource):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::resume):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::enable):
(WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
* inspector/PageDebuggerAgent.cpp: Added.
(WebCore::PageDebuggerAgent::create):
(WebCore::PageDebuggerAgent::PageDebuggerAgent):
(WebCore::PageDebuggerAgent::~PageDebuggerAgent):
(WebCore::PageDebuggerAgent::startListeningScriptDebugServer):
(WebCore::PageDebuggerAgent::stopListeningScriptDebugServer):
(WebCore::PageDebuggerAgent::scriptDebugServer):
* inspector/PageDebuggerAgent.h: Added.
* inspector/WorkerDebuggerAgent.cpp: Added.
(WebCore::WorkerDebuggerAgent::create):
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
(WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
(WebCore::WorkerDebuggerAgent::scriptDebugServer):
* inspector/WorkerDebuggerAgent.h: Added.
2011-03-30 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Make the getStylesForNode result "styleAttributes" value an array rather than a map
https://bugs.webkit.org/show_bug.cgi?id=57440
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):
* inspector/InspectorCSSAgent.h:
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getStylesAsync):
2011-03-30 Evan Martin <evan@chromium.org>
Reviewed by Ryosuke Niwa.
Fix a last-second ASSERT in previous change that was wrong.
* dom/Document.cpp:
(WebCore::Document::setTitle):
2011-03-30 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
RTL: Directionality always reset on hard line break
https://bugs.webkit.org/show_bug.cgi?id=23124
No longer clearing all BidiContexts when we hit a hard line break.
Instead, directionality applied by DOM elements is preserved by
reconstructing the context stack ignoring those that didn't come
from the DOM.
Test: fast/text/international/bidi-br-as-paragraph-separator.html
* platform/text/BidiContext.cpp:
(WebCore::BidiContext::createUncached):
(WebCore::BidiContext::create):
(WebCore::copyContextAndRebaselineLevel): Helper to make a copy of a context
and recalculate its bidi level.
(WebCore::BidiContext::copyStackRemovingUnicodeEmbeddingContexts): Returns the top of
a BidiContext stack that's equivalent but without contexts from Unicode directional
characters.
(WebCore::operator==): Now takes into account embedding source.
* platform/text/BidiContext.h:
(WebCore::BidiContext::source): Enum to specify whether an embedded
bidirectional control came from the DOM/Style or Unicode characters
(WebCore::BidiContext::BidiContext):
* platform/text/BidiResolver.h:
(WebCore::BidiEmbedding::BidiEmbedding): An embedding is now a direction
and a hint about where it came from so we can differentiate DOM directions
from unicode direction control characters.
(WebCore::BidiEmbedding::direction):
(WebCore::BidiEmbedding::source):
(WebCore::::embed): Now takes a source as well as a direction.
(WebCore::::commitExplicitEmbedding):
(WebCore::::createBidiRunsForLine):
* rendering/InlineIterator.h:
(WebCore::bidiNext):
(WebCore::bidiFirst):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
2011-03-30 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JavaMethod should not expose JavaString in its API
https://bugs.webkit.org/show_bug.cgi?id=55765
- Factors out a JavaMethod interface which does not use JNI types.
This will allow the Java bridge to be used with objects that
don't use JNI directly. The existing jobject-backed
implementation is moved to a new JavaMethodJobject class which
implements the interface.
- Use WTF::String in place of JavaString in the API, as JavaString
exposes JNI types in its interface.
- Remove the method ID as it uses JNI types.
No new tests, refactoring only.
* Android.jscbindings.mk:
* Android.v8bindings.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bridge/jni/JavaMethod.h:
* bridge/jni/JavaMethodJobject.cpp:
(JavaMethodJobject::JavaMethodJobject):
(JavaMethodJobject::~JavaMethodJobject):
(appendClassName):
(JavaMethodJobject::signature):
* bridge/jni/JavaMethodJobject.h: Copied from Source/WebCore/bridge/jni/JavaMethod.h.
(JSC::Bindings::JavaMethodJobject::name):
(JSC::Bindings::JavaMethodJobject::returnTypeClassName):
(JSC::Bindings::JavaMethodJobject::parameterAt):
(JSC::Bindings::JavaMethodJobject::returnType):
(JSC::Bindings::JavaMethodJobject::isStatic):
(JSC::Bindings::JavaMethodJobject::numParameters):
* bridge/jni/jsc/JavaClassJSC.cpp:
(JavaClass::JavaClass):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
* bridge/jni/v8/JavaClassV8.cpp:
(JavaClass::JavaClass):
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::invokeMethod):
2011-03-30 Evan Martin <evan@chromium.org>
Reviewed by Ryosuke Niwa.
clean up Document's handling of title changes
https://bugs.webkit.org/show_bug.cgi?id=57433
Document::setTitle has two entry points:
1) from DOM bindings, like document.title="foo"
2) from title tags, like <title>foo</title> in HTML
Split these two code paths to make the code easier to follow.
Also, replace the repeated pattern of
m_rawTitle = "foo"; updateTitle();
with
updateTitle("foo");
* dom/Document.cpp:
(WebCore::Document::updateTitle):
(WebCore::Document::setTitle):
(WebCore::Document::setTitleElement):
(WebCore::Document::removeTitle):
* dom/Document.h:
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::insertedIntoDocument):
(WebCore::HTMLTitleElement::childrenChanged):
* svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::insertedIntoDocument):
(WebCore::SVGTitleElement::childrenChanged):
2011-03-30 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
BreakBlockQuoteCommand assumes all li tags have list item renderers
https://bugs.webkit.org/show_bug.cgi?id=57253
Checking that the renderers of li nodes are actually RenderListItems
before treating them as such.
Test: editing/execCommand/crash-breaking-blockquote-with-list.html
* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockQuoteCommand::doApply):
2011-03-30 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: fixing typo in the inspector front-end.
Web Inspector: REGRESSION: Broken live edit errors handling
https://bugs.webkit.org/show_bug.cgi?id=57436
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
2011-03-30 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
Left/Right borders/padding/margins are not always added correctly when rendering multiline inline boxes with bidi elements
https://bugs.webkit.org/show_bug.cgi?id=9272
Also fixes https://bugs.webkit.org/show_bug.cgi?id=47210 and https://bugs.webkit.org/show_bug.cgi?id=8392.
Change how we decide if an InlineFlowBox is the last one for its renderer. Use the position of resolver's logicallyLastRun
to decide if there is more text in the next line.
Tests: fast/borders/rtl-border-01.html
fast/borders/rtl-border-02.html
fast/borders/rtl-border-03.html
fast/borders/rtl-border-04.html
fast/borders/rtl-border-05.html
* rendering/InlineFlowBox.cpp:
(WebCore::isAnsectorAndWithinBlock):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
* rendering/InlineFlowBox.h:
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::constructLine):
(WebCore::reachedEndOfTextRenderer):
(WebCore::RenderBlock::layoutInlineChildren):
2011-03-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
REGRESSION (r68976): Incorrect bidi rendering in SVG text
https://bugs.webkit.org/show_bug.cgi?id=53980
Deconvolute SVGTextLayoutEngine code, which was confusing due to the simultaneous processing of the rendered text
in visual and logical order. Added several helper methods to make the code more readable.
Fix Unicode directional formatting characters support, now works as expected.
Test: svg/text/bidi-embedded-direction.svg
* editing/visible_units.cpp: Refactor getLeafBoxesInLogicalOrder(), move to InlineFlowBox.
(WebCore::getLogicalStartBoxAndNode): Use new collectLeafBoxesInLogicalOrder() method in InlineFlowBox.
(WebCore::getLogicalEndBoxAndNode): Ditto.
* rendering/InlineFlowBox.cpp: Add new helper function, that returns a list of all leaf boxes in logical order.
(WebCore::InlineFlowBox::collectLeafBoxesInLogicalOrder):
* rendering/InlineFlowBox.h:
* rendering/svg/RenderSVGText.cpp: Actually trigger reordering the x/y/dx/dy/rotate value lists, if needed.
(WebCore::RenderSVGText::RenderSVGText):
(WebCore::RenderSVGText::layout):
* rendering/svg/RenderSVGText.h: Ditto.
(WebCore::RenderSVGText::layoutAttributes):
(WebCore::RenderSVGText::needsReordering):
* rendering/svg/SVGRootInlineBox.cpp: Use new InlineFlowBox::collectLeafBoxesINLogicalOrder(), with a custom "inline box reverse" implementation,
which not only reverses the order of InlineBoxes, but also the order of the x/y/dx/dy/rotate value lists, if needed.
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::swapItems):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
(WebCore::SVGRootInlineBox::reorderValueLists):
* rendering/svg/SVGRootInlineBox.h:
* rendering/svg/SVGTextLayoutAttributes.cpp: Store RenderSVGInlineText* pointer, where we belong to.
(WebCore::SVGTextLayoutAttributes::SVGTextLayoutAttributes):
(WebCore::SVGTextLayoutAttributes::dump):
* rendering/svg/SVGTextLayoutAttributes.h:
(WebCore::SVGTextLayoutAttributes::context):
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Pass RenderSVGInlineText* object when creating SVGTextLayoutAttributes.
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree):
(WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes):
* rendering/svg/SVGTextLayoutAttributesBuilder.h:
* rendering/svg/SVGTextLayoutEngine.cpp: Rewrite & cleanup the main layout algorithm, to be less confusing.
(WebCore::SVGTextLayoutEngine::SVGTextLayoutEngine):
(WebCore::SVGTextLayoutEngine::updateRelativePositionAdjustmentsIfNeeded):
(WebCore::SVGTextLayoutEngine::recordTextFragment):
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes):
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics):
(WebCore::SVGTextLayoutEngine::currentVisualCharacterMetrics):
(WebCore::SVGTextLayoutEngine::advanceToNextLogicalCharacter):
(WebCore::SVGTextLayoutEngine::advanceToNextVisualCharacter):
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
* rendering/svg/SVGTextLayoutEngine.h:
2011-03-30 Ilya Tikhonovsky <loislo@chromium.org>
Not reviewed trivial change.
Web Inspector: Remove unnecessary function arguments after r82281.
https://bugs.webkit.org/show_bug.cgi?id=57327
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::domContentLoadedEventFired):
* inspector/InspectorAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
2011-03-30 Kent Tamura <tkent@chromium.org>
Reviewed by Ojan Vafai.
H1 element should have different default style if it is in HTML5 sectioning elements.
https://bugs.webkit.org/show_bug.cgi?id=52693
Test: fast/css/h1-in-section-elements.html
* css/html.css: Add font-size and margin declarations to follow HTML5 specification.
(:-webkit-any(article,aside,nav,section) h1):
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
2011-03-29 Beth Dakin <bdakin@apple.com>
Reviewed by Maciej Stachowiak.
Fix for https://bugs.webkit.org/show_bug.cgi?id=57408
webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
-and corresponding-
<rdar://problem/8665411>
* platform/mac/PlatformScreenMac.mm:
(WebCore::windowScaleFactor):
(WebCore::toUserSpace):
(WebCore::toDeviceSpace):
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Rename BidiResolver::eor and sor to m_eor and m_sor to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57369
I considered renaming these to m_endOfRun and m_startOfRun but decided
that was too verbose for now (given how often they're used). I suspect
with a bit more refactoring we'll find they're not used very often and can be renamed
if so desired.
* platform/text/BidiResolver.h:
(WebCore::::appendRun):
(WebCore::::checkDirectionInLowerRaiseEmbeddingLevel):
(WebCore::::lowerExplicitEmbeddingLevel):
(WebCore::::raiseExplicitEmbeddingLevel):
(WebCore::::createBidiRunsForLine):
* rendering/InlineIterator.h:
(WebCore::InlineBidiResolver::appendRun):
2011-03-29 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Remove exact retained size request in detailed heap snapshots.
https://bugs.webkit.org/show_bug.cgi?id=57351
* bindings/js/ScriptHeapSnapshot.h:
* bindings/v8/ScriptHeapSnapshot.cpp:
* bindings/v8/ScriptHeapSnapshot.h:
* inspector/Inspector.json:
* inspector/InspectorProfilerAgent.cpp:
* inspector/InspectorProfilerAgent.h:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Split more logic out from createBidiRunsForLine for readability
https://bugs.webkit.org/show_bug.cgi?id=57341
I marked reorderRunsFromLevels inline, but it probably doesn't actually need to (or want to) be.
This lops another large hunk off of reorderRunsFromLevels further reducing the size and complexity.
* platform/text/BidiResolver.h:
(WebCore::::reorderRunsFromLevels):
(WebCore::::createBidiRunsForLine):
2011-03-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Make validation message bubble testable
https://bugs.webkit.org/show_bug.cgi?id=57290
Introduce a setting for validation message timer so that we can configure
how long we show a validation message bubble.
Test: fast/forms/validation-message-appearance.html
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
Don't set a timer if the timer magnification value is 0 or negative.
Otherwise, hides the bubble length * magnification / 1000 seconds.
* page/Settings.cpp:
(WebCore::Settings::Settings): Initialize the timer magnification value.
* page/Settings.h:
(WebCore::Settings::setValidationMessageTimerMagnification): Added.
(WebCore::Settings::validationMessageTimerMaginification): Added.
2011-03-29 Dimitri Glazkov <dglazkov@chromium.org>
Remove the extraneous declaration I accidentally added in r82376.
* dom/MouseEvent.h: Removed createSimulated decl.
2011-03-29 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Compositor crash with show-layer-borders flag
https://bugs.webkit.org/show_bug.cgi?id=57292
Synchronize the debug border color/width with other properties to ensure the appropriate
CCLayerImpl exists. Code is only exercised with a debugging command line flag so no layout
test.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::setBorderColor):
(WebCore::LayerChromium::setBorderWidth):
* platform/graphics/chromium/LayerChromium.h:
2011-03-29 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Teach the preload scanner about <input type=image>
https://bugs.webkit.org/show_bug.cgi?id=57404
I did a very rough sample of the top 50 web pages to see how many of each
HTML resource type they include:
img src: 1,359
script src: 276
link href: 256
iframe src: 104
input src: 50
embed src: 37
@import: 13
object data: 11
Based on this, it seems worthwhile to preload inputs and iframes (possibly embed).
This patch only does inputs.
Test: fast/preloader/input.html
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::HTMLNames::PreloadTask::PreloadTask):
(WebCore::HTMLNames::PreloadTask::processAttributes):
(WebCore::HTMLNames::PreloadTask::inputTypeAttributeIsImage):
(WebCore::HTMLNames::PreloadTask::preload):
2011-03-29 Luke Macpherson <macpherson@chromium.org>
Reviewed by David Levin.
Improve the massive switch statement in CSSStyleSelector::applyProperty.
https://bugs.webkit.org/show_bug.cgi?id=56288
No new tests are needed because no new functionality exposed.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Asserted that cases implemented in the CSSStyleApplyProperty lookup table are unreachable.
Updated comment.
2011-03-29 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Introduce SimulatedMouseEvent and teach EventDispatcher how to use it.
https://bugs.webkit.org/show_bug.cgi?id=57402
No functional changes, covered by existing tests.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick): Changed to use SimulatedMouseEvent.
(WebCore::EventDispatcher::dispatchMouseEvent): Combined two dispatchMouseEvent methods
into one, now that simulated-click events don't need one.
* dom/EventDispatcher.h: Updated decls.
* dom/MouseEvent.cpp:
(WebCore::SimulatedMouseEvent::create): Added.
(WebCore::SimulatedMouseEvent::~SimulatedMouseEvent): Added.
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent): Added.
* dom/MouseEvent.h: Made constructor protected.
2011-03-29 Anders Carlsson <andersca@apple.com>
Fix build.
* WebCore.exp.in:
2011-03-29 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JavaInstance should not use jvalue in its API
https://bugs.webkit.org/show_bug.cgi?id=57019
This change updates JavaInstance for V8 to use JavaValue, rather than
jvalue, in its API. This will allow us to create an API for
JavaInstance that is independent of JNI, to allow it to be
implemented on platforms that do not use JNI directly.
Refactoring only, no new tests.
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::invokeMethod):
(JavaInstance::getField):
* bridge/jni/v8/JavaInstanceV8.h:
* bridge/jni/v8/JavaNPObjectV8.cpp:
(JSC::Bindings::JavaNPObjectInvoke):
(JSC::Bindings::JavaNPObjectGetProperty):
* bridge/jni/v8/JavaValueV8.h:
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Rename BidiResolver::last to m_last to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57367
* platform/text/BidiResolver.h:
(WebCore::::lowerExplicitEmbeddingLevel):
(WebCore::::raiseExplicitEmbeddingLevel):
(WebCore::::createBidiRunsForLine):
2011-03-29 Justin Schuh <jschuh@chromium.org>
Reviewed by Maciej Stachowiak.
SVGComponentTransferFunctionElement should validate type
https://bugs.webkit.org/show_bug.cgi?id=56960
Test: svg/filters/feComponentTransfer-style-crash.xhtml
* svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::svgAttributeChanged):
* svg/SVGComponentTransferFunctionElement.h:
2011-03-29 Thomas Klausner <tk@giga.or.at>
Reviewed by David Levin.
png-1.5 fixes
https://bugs.webkit.org/show_bug.cgi?id=54406
Fix compilation with png-1.5: struct members were hidden, and
a new API to terminate data processing was added (especially for
WebKit).
Compilation fixes, so no new tests.
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
2011-03-29 Gavin Peters <gavinp@chromium.org>
Reviewed by Tony Gentilcore.
Add beforeload to icon and prefetch link rel types
https://bugs.webkit.org/show_bug.cgi?id=56424
Over in https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html , a webkit-dev
thread, I've discussed my hopes for the link element, and adding the link header. This
change helps improve the link header by making it participate in the beforeload event in
two more important cases.
Tests: fast/dom/HTMLLinkElement/prefetch-beforeload.html
http/tests/misc/link-rel-icon-beforeload.html
webarchive/test-link-rel-icon-beforeload.html
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::checkBeforeLoadEvent):
(WebCore::HTMLLinkElement::process):
* html/HTMLLinkElement.h:
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Rename BidiResolver::current to BidiResolver::m_current to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57363
I was very confused by current until I realized it was a member variable.
I also did m_reachedEndOfLine since that was small.
* platform/text/BidiResolver.h:
(WebCore::BidiResolver::position):
(WebCore::BidiResolver::setPosition):
(WebCore::BidiResolver::increment):
(WebCore::::createBidiRunsForLine):
2011-03-29 Geoff Pike <gpike@chromium.org>
Reviewed by Dimitri Glazkov.
In HitTestResult objects, initialize the ListHashSet<RefPtr<Node> >
lazily. In my informal testing it seems to be used hardly at all, so
it's wasteful to create it eagerly. Initializing a ListHashSet
is expensive because a ListHashSet initially has space for 256
elements, and that space is memset to 0.
This change should improve performance but have no impact on
correctness. On x86-64, for example, the change cuts the
cost of HitTestResult(IntPoint()) in EventHandler::mouseMoved()
from ~1700 cycles to ~300 cycles.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult): copy *m_rectBasedTestResult if m_rectBasedTestResult isn't 0
(WebCore::HitTestResult::operator=): copy *m_rectBasedTestResult if m_rectBasedTestResult isn't 0
(WebCore::HitTestResult::addNodeToRectBasedTestResult): use mutableRectBasedTestResult() rather than m_rectBasedTestResult
(WebCore::HitTestResult::append): append *(other.m_rectBasedTestResult) if other.m_rectBasedTestResult isn't 0
* rendering/HitTestResult.h:
(WebCore::HitTestResult::rectBasedTestResult): Add a typedef for ListHashSet<RefPtr<Node> > to ease readability. Change m_rectBasedTestResult from ListHashSet<RefPtr<Node> > to an OwnPtr of same. Modify rectBasedTestResult() and add mutableRectBasedTestResult().
2011-03-29 Timothy Hatcher <timothy@apple.com>
Update the order of the context menu to better match AppKit on Mac.
<rdar://problem/9054893>
Reviewed by John Sullivan.
* English.lproj/Localizable.strings: Updated.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate): Update the order of items on Mac.
* platform/LocalizationStrategy.h:
* platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
* platform/LocalizedStrings.h:
* platform/android/LocalizedStringsAndroid.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
* platform/brew/LocalizedStringsBrew.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
* platform/haiku/LocalizedStringsHaiku.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
* platform/wx/LocalizedStringsWx.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
2011-03-29 Dean Jackson <dino@apple.com>
Reviewed by Chris Marrin and Ken Russell.
https://bugs.webkit.org/show_bug.cgi?id=57248
Occlusion issues with WebGL in Safari
The depth buffer on Safari ports was being set up with a
maximum of 16 bits. Now we use a combined 24/8 depth/stencil
buffer on Mac ports.
No new tests as this is the setting for a particular port. Other
ports may use different defaults.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::validateAttributes):
- use Extensions3D to test for depth and multisample extensions
rather than querying OpenGL directly.
(WebCore::GraphicsContext3D::reshape):
- use a 24bit depth buffer when the extension is enabled.
2011-03-29 Dimitri Glazkov <dglazkov@chromium.org>
Sorted XCode project. It's gotten quite out of sorts.
* WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
2011-03-29 Emil A Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
DatasetDOMStringMap::item and ::contains copies attribute name string
https://bugs.webkit.org/show_bug.cgi?id=55645
Change propertyNameMatchesAttributeName to match without creating a copy
of the string.
* dom/DatasetDOMStringMap.cpp:
(WebCore::propertyNameMatchesAttributeName):
2011-03-29 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed rollout r82282, part of r82288, r82298.
* css/CSSParser.cpp:
(WebCore::parseColorInt):
(WebCore::isValidDouble):
(WebCore::parseAlphaValue):
(WebCore::CSSParser::parseColor):
2011-03-25 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=55981
Second round of clean-ups, aimed at supporting GTK with the
same unified FontPlatformData header. This version removes
some unneeded WinCairo code, and aligns the WinCairo and
GTK ports to reduce code duplication.
* WebCore.vcproj/WebCore.vcproj: Get rid of a dangling reference
to an old WinCairo file.
* platform/graphics/FontPlatformData.h: Remove unneeded member
for m_fontFace, which is a member of m_scaledFont. Switch to
standard Cairo hashing.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hashTableDeletedFontValue):
* platform/graphics/win/FontCacheWin.cpp: Update to no longer use
the unnecessary fontFace() accessor.
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
* platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::platformIsEqual):
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
2011-03-29 Jian Li <jianli@chromium.org>
Reviewed by Adam Barth.
Inline worker powered by blob URL does not work with files URL even if
allowFileAccessFromFileURLs is enabled
https://bugs.webkit.org/show_bug.cgi?id=56063
Test: fast/files/workers/inline-worker-via-blob-url.html
* fileapi/BlobURL.cpp: Removed unneeded getOrigin() method.
* fileapi/BlobURL.h: Removed unneeded getOrigin() method.
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin): Extended the logic to handle
filesystem URL also to blob URL. Also fixed the problem that m_isUnique
is incorrectly set for blob and filesystem URLs.
(WebCore::SecurityOrigin::create): Removed the special logic for blob URL
since we use the same logic in SecurityOrigin constructor as filesystem
URL.
(WebCore::SecurityOrigin::canRequest): Removed the special logic for blob
URL since it is not needed with the fix in SecurityOrigin constructor.
2011-03-29 Timothy Hatcher <timothy@apple.com>
Update WebCore Localizable.strings to contain WebCore, WebKit/mac and WebKit2 strings.
https://webkit.org/b/57354
Reviewed by Sam Weinig.
* English.lproj/Localizable.strings: Updated.
* StringsNotToBeLocalized.txt: Removed. To hard to maintain in WebCore.
* platform/network/cf/LoaderRunLoopCF.h: Remove a single quote in an #error so
extract-localizable-strings does not complain about unbalanced single quotes.
2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82295 and r82300.
http://trac.webkit.org/changeset/82295
http://trac.webkit.org/changeset/82300
https://bugs.webkit.org/show_bug.cgi?id=57380
This patch breaks compile on Chromium (Requested by
abarth|gardener on #webkit).
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(atkRole):
(webkit_accessible_get_role):
* accessibility/mac/AccessibilityObjectWrapper.mm:
2011-03-29 Anders Carlsson <andersca@apple.com>
Fix clang build.
* platform/text/BidiResolver.h:
(WebCore::::createBidiRunsForLine):
2011-03-29 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Use per-configuration vsprops in WebCore to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
https://bugs.webkit.org/show_bug.cgi?id=57378
Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
the IDE. To avoid this, add a separate vsprops file for each project configuration that
contains the required inherited property sheets.
* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/QTMovieWinDebug.vsprops: Added.
* WebCore.vcproj/QTMovieWinDebugAll.vsprops: Added.
* WebCore.vcproj/QTMovieWinDebugCairoCFLite.vsprops: Added.
* WebCore.vcproj/QTMovieWinRelease.vsprops: Added.
* WebCore.vcproj/QTMovieWinReleaseCairoCFLite.vsprops: Added.
* WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops: Added.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreDebug.vsprops: Added.
* WebCore.vcproj/WebCoreDebugAll.vsprops: Added.
* WebCore.vcproj/WebCoreDebugCairoCFLite.vsprops: Added.
* WebCore.vcproj/WebCoreRelease.vsprops: Added.
* WebCore.vcproj/WebCoreReleaseCairoCFLite.vsprops: Added.
* WebCore.vcproj/WebCoreReleaseLTCG.vsprops: Added.
2011-03-29 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/9194927> REGRESSION (r81691): Page at www.mondaynote.com lays out incorrectly
Back out the optimization that stopped when it hit the first float. This was an incorrect optimization
and can't be done without more work.
Added fast/block/float/float-forced-below-other-floats.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Start to clean up BidiResolver::createBidiRunsForLine so that mere mortals can understand it
https://bugs.webkit.org/show_bug.cgi?id=57338
I'm attempting to break createBidiRunsForLine into understandable pieces
so that we can tell what it's actually doing. Our implementation of the
unicode bidi algorithm is slightly different from the spec in that we
run it per-line (instead of over the entire paragraph at once). This is
great for performance (our implementation is resumable), but it makes
things a bit tricky to understand. Splitting createBidiRunsForLine into
pieces should help make our UBA implementation more readable.
* platform/text/BidiResolver.h:
(WebCore::::updateStatusLastFromCurrentDirection):
(WebCore::::createBidiRunsForLine):
2011-03-29 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] Consistent crash from Google/ARIA combobox click
https://bugs.webkit.org/show_bug.cgi?id=55883
Do not call to firstChild() to avoid entering into infinite loops.
This would happen when current item is a WebCore Group and some of
its children have either role 'option' or 'menuitem'. Other than
that the logic behind that call to firstChild() seems to be no
longer needed so it's safe to remove it.
Test: platform/gtk/accessibility/aria-options-and-menuitems-crash.html
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Remove call to firsChild, which was leading to crashes sometimes.
2011-03-29 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
https://bugs.webkit.org/show_bug.cgi?id=47636
Define new roles in WebCore and map them to ATK accordingly.
Test: platform/gtk/accessibility/aria-roles-unignored.html
* accessibility/AccessibilityObject.h: Added new roles to
represent paragraphs, labels, forms and div sections.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
Return ParagraphRole, LabelRole, FormRole and DivRole when needed.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(atkRole): Map new WebCore roles to ATK Roles.
(webkit_accessible_get_role): Remove code to define roles for
paragraphs, labels, forms and divs based on node's tag name.
Update mappings for the Mac platform.
* accessibility/mac/AccessibilityObjectWrapper.mm:
(createAccessibilityRoleMap): Add explicit mappings from the new
roles introduced to NSAccessibilityGroupRole.
2011-03-29 Philippe Normand <pnormand@igalia.com>
Unreviewed build fix. Remove ASSERT hitting consitently on GTK.
* rendering/InlineIterator.h:
(WebCore::InlineIterator::moveToStartOf):
2011-03-29 Darin Adler <darin@apple.com>
Fix some just-introduced build failures.
* WebCore.pro: Correct spelling of filename.
* css/CSSParser.cpp:
(WebCore::parseColorIntOrPercentage): Fix double/int conversion that fails to compile
on Leopard. Also renamed one local variabel.
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didCommitLoad): Removed unused argument names to avoid warning.
(WebCore::InspectorAgent::domContentLoadedEventFired): Ditto.
2011-03-29 Andras Becsi <abecsi@webkit.org>
Reviewed by Darin Adler.
CSS: Slow parsing of rgb() with percent values
https://bugs.webkit.org/show_bug.cgi?id=16708
Implement fast-path parsing for percentage color values.
Gain ~30% speedup on http://canvex.lazyilluminati.com/misc/3d.html.
* css/CSSParser.cpp:
(WebCore::checkForValidDouble): Extend to return the number of characters forming a valid double.
(WebCore::parseDouble): Function for parsing double values if they are valid.
(WebCore::parseColorIntOrPercentage): Extend parseColorInt to deal with percentage values.
(WebCore::parseAlphaValue): Use the new functions.
(WebCore::CSSParser::parseColor): Ditto.
2011-03-29 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract InspectorPageAgent from InspectorAgent.
https://bugs.webkit.org/show_bug.cgi?id=57327
There are page related methods and inspector related methods in InspectorAgent.
It would be nice to extract page specific methods for future usage the rest of methods in workers debugger.
* GNUmakefile.am:
* WebCore.gypi:
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::domContentLoadedEventFired):
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::pageAgent):
* inspector/InspectorPageAgent.cpp: Added.
(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::setFrontend):
(WebCore::InspectorPageAgent::clearFrontend):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad):
(WebCore::InspectorPageAgent::reloadPage):
(WebCore::InspectorPageAgent::openInInspectedWindow):
(WebCore::InspectorPageAgent::setUserAgentOverride):
(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):
(WebCore::InspectorPageAgent::inspectedURLChanged):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::didCommitLoad):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::loadEventFired):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::applyUserAgentOverride):
* inspector/InspectorPageAgent.h: Added.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
(WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::loadEventFiredImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::retrievePageAgent):
* inspector/InspectorInstrumentation.h:
* inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorPageAgent):
(WebCore::InstrumentingAgents::setInspectorPageAgent):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._reloadResources):
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._deleteCookie):
(WebInspector.Cookies.getCookiesAsync):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._openInNewTab):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype.ondblclick):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
* inspector/front-end/inspector.js:
(WebInspector.openResource):
(WebInspector.documentKeyDown):
2011-03-29 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=57276
Add optimizations to make the vertical placement of boxes much faster. Whenever a box is added
to a line, compare it with the parent box. If we can determine that the child box has the exact
same height and baseline position as the parent box, then we keep a boolean flag set called
descendantsHaveSameLineHeightAndBaseline(). If the box is different for any reason then we clear the
flag up the line box parent chain.
When it comes time to do computeLogicalboxHeights, we can avoid recurring into the children of
a box whose descendants all have the same position. When we do placeBoxesInBlockDirection, we
can do a simplified recursion that just calls adjustBlockDirectionPosition to offset the boxes
without doing anything else.
Because of the quirks mode rule of only shrinking boxes with no immediate text children, we need
to track whether a box has text descendants now as well. When we avoid doing the recursion
this flag tells us whether the collection of boxes should have an effect on the ascent and descent
of the line in quirks mode.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::hasTextDescendants):
(WebCore::InlineFlowBox::descendantsHaveSameLineHeightAndBaseline):
(WebCore::InlineFlowBox::clearDescendantsHaveSameLineHeightAndBaseline):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
(WebCore::RenderBlock::constructLine):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Remove a bunch of duplicate code by adding some InlineIterator helper methods
https://bugs.webkit.org/show_bug.cgi?id=57326
Once I started adding these it became clear how much crazy duplicated code
we had due to treating InlineIterator as a struct and accessing its
members directly. We can't quite make the members private yet since
findNextLineBreak still splits out the members. But this change
makes the code much cleaner.
* rendering/InlineIterator.h:
(WebCore::InlineIterator::clear):
(WebCore::InlineIterator::moveToStartOf):i
(WebCore::InlineIterator::moveTo):
(WebCore::InlineIterator::increment):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::tryHyphenating):
(WebCore::RenderBlock::findNextLineBreak):
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Clean up bidiNext by abstracting repeated code
https://bugs.webkit.org/show_bug.cgi?id=57335
I also added a comment to explain what bidiNext is actually doing.
This whole area of code is confusing but need not be.
* rendering/InlineIterator.h:
(WebCore::embedCharFromDirection):
(WebCore::notifyResolverEnteredObject):
(WebCore::notifyResolverWillExitObject):
(WebCore::bidiNext):
(WebCore::bidiFirst):
2011-03-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Support external CSS stylesheet freeflow text editing
https://bugs.webkit.org/show_bug.cgi?id=54397
In this implementation, Ctrl/Cmd-S commits the current changes into the model.
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.createResourceView):
(WebInspector.CSSSourceFrameDelegateForResourcesPanel):
(WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.canEditScriptSource):
(WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.editScriptSource):
(WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.editScriptSource.handleInfos):
(WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype._saveStyleSheet):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._applyDiffMarkup):
(WebInspector.FrameResourceTreeElement.prototype._contentChanged):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._createTextViewer):
2011-03-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
playbackRate should not be set to defaultPlaybackRate in play()
https://bugs.webkit.org/show_bug.cgi?id=55943
Test: media/video-playbackrate.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::playbackRate): No need to ask the media engine for the current
rate, we already have the current value cached.
(WebCore::HTMLMediaElement::playInternal): Don't reset the engine's playback rate to
the default rate.
(WebCore::HTMLMediaElement::togglePlayState): Do reset the engine's playback rate to
the default rate before triggering playback.
* manual-tests/media-default-playback-rate.html: Added.
2011-03-28 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
Remove specialization of EventDispatcher with inversion of control.
https://bugs.webkit.org/show_bug.cgi?id=57285
Since some events have extra logic around their dispatch, allow them
to dispatch themselves and specialize the logic. This change only
converts KeyboardEvent to this model.
No functional change, covered by existing tests.
* dom/Event.cpp:
(WebCore::Event::dispatch): Added.
* dom/Event.h: Updated decls.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent): Changed to ask event to dispatch
itself.
* dom/EventDispatcher.h: Updated decls.
* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::dispatch): Added, moving code from EventDispatcher.
* dom/KeyboardEvent.h: Updated decls.
* dom/Node.cpp:
(WebCore::Node::dispatchKeyEvent): Changed to use the new ways.
2011-03-29 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: InspectorDOMAgent has unnecessary dependency from InspectorAgent.
https://bugs.webkit.org/show_bug.cgi?id=57329
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::setFrontend):
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::inspect):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::setFrontend):
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::inspect):
(WebCore::InspectorDOMAgent::focusNode):
(WebCore::InspectorDOMAgent::highlight):
(WebCore::InspectorDOMAgent::hideHighlight):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Nikolas Zimmermann.
Rename InlineIterator::pos to m_pos to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57342
Somehow I failed to upload this one earlier, no wonder later patches didn't apply.
* rendering/InlineIterator.h:
(WebCore::InlineIterator::InlineIterator):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::InlineIterator::increment):
(WebCore::InlineIterator::current):
(WebCore::InlineBidiResolver::appendRun):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::checkMidpoints):
(WebCore::RenderBlock::appendRunsForObject):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::tryHyphenating):
(WebCore::RenderBlock::findNextLineBreak):
2011-03-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: document BrowserDebugger agent.
https://bugs.webkit.org/show_bug.cgi?id=57331
* inspector/Inspector.json:
2011-03-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
https://bugs.webkit.org/show_bug.cgi?id=56310
Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
"styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
by CSSAgent.getStyleSheet() anymore.
Test: inspector/styles/get-set-stylesheet-text.html
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getAllStyleSheets):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
(WebInspector.CSSStyleModel.prototype._onRevert):
(WebInspector.CSSStyleSheet):
(WebInspector.CSSStyleSheet.prototype.setText):
2011-03-29 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Eric Seidel.
Implement text-align:match-parent as -webkit-match-parent.
https://bugs.webkit.org/show_bug.cgi?id=50951
Add support to the CSS parser.
Tests: fast/css/text-align-webkit-match-parent-parse.html
fast/css/text-align-webkit-match-parent.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Rename InlineIterator::nextBreakablePosition to m_nextBreakablePosition to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57323
All of these m_nextBreakablePosition = -1 could probably be replaced with
some new methods. But I'll do that in a separate change. Clearly
m_nextBreakablePosition is just a cached value which should be cleared
at the right times. I suspect we may even fail to clear it sometimes when
we should due to the current used of direct access instead of smarter functions.
* rendering/InlineIterator.h:
(WebCore::InlineIterator::InlineIterator):
(WebCore::InlineIterator::increment):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::tryHyphenating):
(WebCore::RenderBlock::findNextLineBreak):
2011-03-29 Jeff Miller <jeffm@apple.com>
Reviewed by Jon Honeycutt.
Add WebCore::copyCertificateToData() on Windows
https://bugs.webkit.org/show_bug.cgi?id=57296
Create a new win directory in platform/cf and add CertificateCFWin.cpp and CertificateCFWin.h to it.
* WebCore.vcproj/WebCore.vcproj: Added CertificateCFWin.cpp and CertificateCFWin.h.
* WebCore.vcproj/copyForwardingHeaders.cmd: Copy all header files in \platform\cf\win\.
* platform/cf/win: Added.
* platform/cf/win/CertificateCFWin.cpp: Added.
(WebCore::deallocCertContext): Added.
(WebCore::createCertContextDeallocator): Added.
(WebCore::copyCertificateToData): Added.
* platform/cf/win/CertificateCFWin.h: Added.
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Rename InlineIterator::block to m_block to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57321
I could have made m_block private, since it's only accessed in
one place outside of InlineIterator (for an ASSERT). But I chose
not to do so in this change.
* rendering/InlineIterator.h:
(WebCore::InlineIterator::InlineIterator):
(WebCore::InlineIterator::increment):
(WebCore::InlineBidiResolver::appendRun):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
2011-03-29 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
Incorrect offset of svg <use> element which is in <symbol> element
https://bugs.webkit.org/show_bug.cgi?id=57318
When webkit expanded a svg <symbol> element in the shadow tree it
would clone the children of the <symbol>. The children may contain
SVGShadowTreeContainerElement which was expanded from svg <use>
element. But the clone operation would clone a
SVGShadowTreeContainerElement as a svg <g> element. This resulted
that updateContainerOffset wouldn't update offset for those elements
which were expand from <use> elements.
This patch implements cloneElementWithoutAttributesAndChildren for
SVGShadowTreeContainerElement to make the container clone itself
correctly.
Test: svg/custom/use-in-symbol-with-offset.svg
* rendering/svg/SVGShadowTreeElements.cpp:
(WebCore::SVGShadowTreeContainerElement::cloneElementWithoutAttributesAndChildren):
* rendering/svg/SVGShadowTreeElements.h:
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Rename InlineIterator::obj to m_obj to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57319
I started this rename after confusion in InlineBidiResolver::appendRun.
(Which uses an "obj" local in InlineIterator.h. It's not actually
masking m_obj because it's a separate class, but I didn't realize
that at the time because it's in InlineIterator.h which is itself confusing!)
* rendering/InlineIterator.h:
(WebCore::InlineIterator::InlineIterator):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::InlineIterator::increment):
(WebCore::InlineIterator::atEnd):
(WebCore::InlineIterator::current):
(WebCore::InlineIterator::direction):
(WebCore::InlineBidiResolver::appendRun):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::checkMidpoints):
(WebCore::RenderBlock::appendRunsForObject):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::skipNonBreakingSpace):
(WebCore::RenderBlock::requiresLineBox):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::tryHyphenating):
(WebCore::RenderBlock::findNextLineBreak):
2011-03-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: document Timeline domain, make timeline event types of type string.
https://bugs.webkit.org/show_bug.cgi?id=57299
* inspector/Inspector.json:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::willDispatchEvent):
(WebCore::InspectorTimelineAgent::didDispatchEvent):
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::didLayout):
(WebCore::InspectorTimelineAgent::willRecalculateStyle):
(WebCore::InspectorTimelineAgent::didRecalculateStyle):
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::didPaint):
(WebCore::InspectorTimelineAgent::willWriteHTML):
(WebCore::InspectorTimelineAgent::didWriteHTML):
(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::willFireTimer):
(WebCore::InspectorTimelineAgent::didFireTimer):
(WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
(WebCore::InspectorTimelineAgent::didChangeXHRReadyState):
(WebCore::InspectorTimelineAgent::willLoadXHR):
(WebCore::InspectorTimelineAgent::didLoadXHR):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::didReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didMarkTimeline):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
* inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
* inspector/front-end/TimelineAgent.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelineDispatcher.prototype.started):
(WebInspector.TimelineDispatcher.prototype.stopped):
(WebInspector.TimelineDispatcher.prototype.eventRecorded):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
2011-03-29 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Fixing live edits tests on chromium.
https://bugs.webkit.org/show_bug.cgi?id=57316
* inspector/front-end/ScriptsPanel.js:
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
(WebInspector.SourceFrame.prototype._handleSave):
(WebInspector.SourceFrameDelegate.prototype.editScriptSource):
2011-03-29 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: fix call frames positions in formatted scripts.
https://bugs.webkit.org/show_bug.cgi?id=57036
Introduce PresentationCallFrame class that encapsulates source mapping details from UI components.
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLocation):
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
(WebInspector.CallStackSidebarPane.prototype._placardSelected):
(WebInspector.CallStackSidebarPane.prototype._contextMenu):
(WebInspector.CallStackSidebarPane.prototype._copyStackTrace):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
(WebInspector.DebuggerModel.prototype.get debuggerPausedDetails):
(WebInspector.DebuggerModel.prototype._pausedScript):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._reset):
(WebInspector.PresenationCallFrame): Call frame wrapper for UI.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._debuggerResumed):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
(WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
* inspector/front-end/SourceFile.js:
(WebInspector.SourceFile.prototype.get content):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype.setExecutionLine):
(WebInspector.SourceFrame.prototype.clearExecutionLine):
(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
(WebInspector.SourceFrame.prototype._showPopup):
2011-03-29 Emil A Eklund <eae@chromium.org>
Reviewed by Darin Adler.
Fix for execCommand("Delete") with an empty selection.
https://bugs.webkit.org/show_bug.cgi?id=56652
Test: editing/execCommand/delete-empty-container.html
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::makeEditableRootEmpty): Add check for root element.
2011-03-29 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Refactor HeapSnapshot-related code to
make sure we don't return big amounts of data to forms.
https://bugs.webkit.org/show_bug.cgi?id=57227
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _countPercent):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
(WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _countPercent):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.setDataSource):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get dominatorIndex):
(WebInspector.HeapSnapshotNode.prototype.get retainers):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype.get _allNodes):
(WebInspector.HeapSnapshot.prototype.get nodeCount):
(WebInspector.HeapSnapshot.prototype.get rootNodeIndex):
(WebInspector.HeapSnapshot.prototype.hasId):
(WebInspector.HeapSnapshot.prototype.get nodeIds):
(WebInspector.HeapSnapshot.prototype._retainersForNode):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes):
(WebInspector.HeapSnapshot.prototype._buildIdsList):
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
(WebInspector.HeapSnapshotFilteredOrderedIterator):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.next):
(WebInspector.HeapSnapshotEdgesProvider):
(WebInspector.HeapSnapshotNodesProvider):
2011-03-29 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Fix detailed heap snapshots UI.
https://bugs.webkit.org/show_bug.cgi?id=57235
Fix two problems:
1. Text color of grid cells under selection needs to be white, otherwise it's unreadable for some colors;
2. Long strings need to be truncated in grid, their contents can be shown on hover.
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._getHoverAnchor):
(WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
* inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .console-formatted-string):
(.detailed-heapshot-view .data-grid tr.selected *):
(.detailed-heapshot-view .data-grid:focus tr.selected *):
2011-03-29 Andrey Adaikin <aandrey@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Highlight visible lines first
https://bugs.webkit.org/show_bug.cgi?id=57013
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleChunkNumber):
(WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
(WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber.compareLineRowOffsetTops):
(WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber):
(WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
(WebInspector.TextEditorMainPanel.prototype._paintLines):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainChunk.prototype.set expanded):
2011-03-29 Emil A Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
Relative mouse coordinates recalculated for each target
https://bugs.webkit.org/show_bug.cgi?id=57130
Calculate relative coordinates lazily for mouse events instead of doing
it for each target. Speeds up dispatching of mouse events in deep dom
structures significantly, O(n^2) to O(n).
Also fixes https://bugs.webkit.org/show_bug.cgi?id=34973
Tests: fast/events/mouse-relative-position.html
perf/mouse-event.html
* dom/Event.cpp:
(WebCore::Event::setTarget):
* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::initCoordinates):
(WebCore::pageZoomFactor):
(WebCore::MouseRelatedEvent::receivedTarget):
(WebCore::MouseRelatedEvent::computeRelativePosition):
(WebCore::MouseRelatedEvent::layerX):
(WebCore::MouseRelatedEvent::layerY):
(WebCore::MouseRelatedEvent::offsetX):
(WebCore::MouseRelatedEvent::offsetY):
* dom/MouseRelatedEvent.h:
* dom/UIEvent.cpp:
(WebCore::UIEvent::layerX):
(WebCore::UIEvent::layerY):
* dom/UIEvent.h:
2011-03-29 Emil A Eklund <eae@chromium.org>
Reviewed by Darin Adler.
getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue
https://bugs.webkit.org/show_bug.cgi?id=57266
Add null check to counterToCSSValue.
Test: fast/css/getComputedStyle/counterIncrement-without-counter.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::counterToCSSValue):
2011-03-29 Gavin Peters <gavinp@chromium.org>
Reviewed by Tony Gentilcore.
Implement onerror events for <link rel=prefetch>
https://bugs.webkit.org/show_bug.cgi?id=57182
These events are equired on link elements, see
http://dev.w3.org/html5/spec/Overview.html#the-link-element
After a discussion in WebKit-dev about the direction of prefetch in the loader, and about a path
to adding the Link header, we decided to look at making onerror, onload and onbeforeload events
more uniformly supported. See the thread at
https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html .
It turned out that part of adding onerror for link prefetch was to make the top CachedResource less
abstract. It was pure virtual until prefetch became the first consumer to use an unspecialised
implementation, and this CL continues that by adding a default checkNotify method to it. As it
happens there were already two subclasses using what amounted to the generic checkNotify, so I
also removed those, buying us some code cleanup with the change.
Test: fast/dom/HTMLLinkElement/prefetch-onerror.html
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::onloadTimerFired):
(WebCore::HTMLLinkElement::notifyFinished):
* loader/cache/CachedImage.cpp:
* loader/cache/CachedImage.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::checkNotify):
(WebCore::CachedResource::data):
(WebCore::CachedResource::error):
* loader/cache/CachedResource.h:
* loader/cache/CachedScript.cpp:
* loader/cache/CachedScript.h:
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Add support for parsing unicode-bidi: -webkit-isolate
https://bugs.webkit.org/show_bug.cgi?id=57181
Test: css3/unicode-bidi-insolate-parse.html
* WebCore.xcodeproj/project.pbxproj:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyleConstants.h:
2011-03-29 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r82193.
* platform/wince/FileSystemWinCE.cpp:
(WebCore::openTemporaryFile):
2011-03-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82198.
http://trac.webkit.org/changeset/82198
https://bugs.webkit.org/show_bug.cgi?id=57304
Broke Chromium Win build. (Requested by dave_levin on
#webkit).
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
2011-03-28 Ofri Wolfus <ofri@google.com>
Reviewed by Eric Seidel.
RTL: Select elements with a size attribute are always left aligned.
https://bugs.webkit.org/show_bug.cgi?id=50928
Added support for alignment in RenderListBox.
Test: fast/forms/listbox-bidi-align.html
* rendering/RenderListBox.cpp:
(WebCore::itemOffsetForAlignment):
(WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.
2011-03-28 Kwang Yul Seo <skyul@company100.net>
Reviewed by Benjamin Poulain.
[Qt] Change TextureMapperVideoLayer to TextureMapperMediaLayer
https://bugs.webkit.org/show_bug.cgi?id=57142
TextureMapperMediaLayer is a better name here because both video and plugins use this layer.
Remove ENABLE(VIDEO) guard.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
* platform/graphics/qt/MediaPlayerPrivateQt.h:
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
* platform/graphics/texmap/TextureMapperNode.h:
* platform/graphics/texmap/TextureMapperPlatformLayer.h:
(WebCore::TextureMapperMediaLayer::layerType):
2011-03-28 Thomas Klausner <tk@giga.or.at>
Reviewed by David Levin.
png-1.5 fixes
https://bugs.webkit.org/show_bug.cgi?id=54406
Fix compilation with png-1.5: struct members were hidden, and
a new API to terminate data processing was added (especially for
WebKit).
Compilation fixes, so no new tests.
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
2011-03-28 Kwang Yul Seo <skyul@company100.net>
Reviewed by Adam Barth.
Replace fprintf(stderr, ...) with LOG_ERROR
https://bugs.webkit.org/show_bug.cgi?id=57216
LOG_ERROR is a better choice here.
* bridge/jni/v8/JavaClassV8.cpp:
(JavaClass::JavaClass):
2011-03-28 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Add a new JavaValue to type to represent a Java value in the Java bridge
https://bugs.webkit.org/show_bug.cgi?id=57022
This change introduces a new JavaValue type and uses it in place of jvalue
in the conversions to and from JavaNPObject used in the V8 Java bridge.
Refactoring only, no new tests.
* WebCore.gypi:
* bridge/jni/JNIUtility.cpp:
(JSC::Bindings::javaTypeFromClassName):
(JSC::Bindings::signatureFromJavaType):
(JSC::Bindings::getJNIField):
(JSC::Bindings::callJNIMethod):
* bridge/jni/JavaType.h:
* bridge/jni/v8/JNIUtilityPrivate.cpp:
(JSC::Bindings::convertNPVariantToJavaValue):
(JSC::Bindings::convertJavaValueToNPVariant):
(JSC::Bindings::jvalueToJavaValue):
(JSC::Bindings::javaValueToJvalue):
* bridge/jni/v8/JNIUtilityPrivate.h:
* bridge/jni/v8/JavaNPObjectV8.cpp:
(JSC::Bindings::JavaNPObjectInvoke):
(JSC::Bindings::JavaNPObjectGetProperty):
* bridge/jni/v8/JavaValueV8.h: Added.
(JSC::Bindings::JavaValue::JavaValue):
2011-03-28 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Use String instead of CString as return value of openTemporaryFile
https://bugs.webkit.org/show_bug.cgi?id=55332
We usually store all paths as UTF-16. Do this for temporary files too.
* WebCore.exp.in
* platform/FileSystem.h:
* platform/android/FileSystemAndroid.cpp:
* platform/brew/FileSystemBrew.cpp:
* platform/efl/FileSystemEfl.cpp:
* platform/gtk/FileSystemGtk.cpp:
* platform/haiku/FileSystemHaiku.cpp:
* platform/mac/FileSystemMac.mm:
* platform/qt/FileSystemQt.cpp:
* platform/win/FileSystemWin.cpp:
* platform/wince/FileSystemWinCE.cpp:
* platform/wx/FileSystemWx.cpp:
* plugins/PluginStream.cpp:
(WebCore::PluginStream::destroyStream):
* plugins/PluginStream.h:
2011-03-28 Jeff Johnson <opendarwin@lapcatsoftware.com>
Reviewed by Pavel Feldman.
Web Inspector: empty, non-functional window
https://bugs.webkit.org/show_bug.cgi?id=56354
Check whether DOM local storage is enabled
before attempting to access window.localStorage.
No new tests.
* inspector/front-end/Settings.js:
(WebInspector.Settings.prototype.findSettingForAllProjects):
(WebInspector.Settings.prototype._get):
(WebInspector.Settings.prototype._set):
2011-03-28 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=57286 Alternative fix for:
Horizontal scroller stops appearing after going Forward
-and corresponding-
<rdar://problem/9026946>
This patch rolls out revision 79053 and fixes the same bug in a better way.
New function resetScrollbarsAndClearContentsSize() calls resetScrollbars() and then
sets the contents size to 0. This is called when a document is going into the page
cache.
* dom/Document.cpp:
(WebCore::Document::setInPageCache):
(WebCore::FrameView::resetScrollbarsAndClearContentsSize):
Roll-out of 79053.
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
* page/FrameView.h:
2011-03-28 Ojan Vafai <ojan@chromium.org>
Reviewed by Antti Koivisto.
fix style sharing with :any and sibling selectors
https://bugs.webkit.org/show_bug.cgi?id=57211
Test: fast/css/sibling-selectors.html
* css/CSSStyleSelector.cpp:
(WebCore::collectFeaturesFromList):
2011-03-27 Ojan Vafai <ojan@chromium.org>
Reviewed by Antti Koivisto.
fix :-webkit-any(:last-child)
https://bugs.webkit.org/show_bug.cgi?id=57207
We were passing the wrong arguments to checkSelector. Also, we were not
passing through the encounteredLink bool.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* css/CSSStyleSelector.h:
2011-03-27 Ojan Vafai <ojan@chromium.org>
Reviewed by Antti Koivisto.
fix :-webkit-any(:last-child)
https://bugs.webkit.org/show_bug.cgi?id=57207
We were passing the wrong arguments to checkSelector. Also, we were not
passing through the encounteredLink bool.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* css/CSSStyleSelector.h:
2011-03-28 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
REGRESSION(r82152): fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
https://bugs.webkit.org/show_bug.cgi?id=57291
* platform/KURL.cpp:
(WebCore::KURL::parse): Instead of considering URLs with
credentials but no host invalid, consider them to have a host
ending in @ (which fails down the line)/
2011-03-28 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Fix some problems of the appearance of form validation message bubble.
https://bugs.webkit.org/show_bug.cgi?id=57208
No new tests. Validation message bubble appearance is not testable
because it depends on a timer.
* css/html.css:
(::-webkit-validation-bubble):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-arrow):
(::-webkit-validation-bubble-arrow-clipper):
- Explicitly set margin, padding, and color.
- Make the shadow darker.
- Make the background color darker.
- Make opacity larger.
- Make the border color lighter.
- Add inset shadows
- Change the implementation of an arrow.
Stop making a right triangle by the border trick.
Use -webkit-transform instead.
- Make min-width workable by changing display property of
-webkit-validation-bubble to "inline-block".
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
Change the node structure. Before this change, -webkit-validation-bubble
had three DIVs inside. After this change, it has two DIVs;
-webkit-validation-bubble-arrow-clipper and
-webkit-validation-bubble-message, and
-webkit-validation-bubble-arrow-clipper contains
-webkit-validation-bubble-arrow.
2011-03-28 Enrica Casucci <enrica@apple.com>
Reviewed by Sam Weinig.
REGRESSION: Can't enter pasted with context or Edit menu text in search or address field in the browser.
https://bugs.webkit.org/show_bug.cgi?id=57275
<rdar://problem/8246691>
We need to classify cut and paste actions as user typing actions even when
the action is triggered by a context menu selection to
allow the propagation of the textDidChangeInTextField event.
* editing/EditorCommand.cpp:
The following methods have been modified to properly set up
the UserTypingGestureAction when the command source is the
menu or a key binding sequence.
(WebCore::executeCut):
(WebCore::executePaste):
(WebCore::executePasteAndMatchStyle):
(WebCore::executePasteAsPlainText):
(WebCore::executeDelete):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected): Changed to
call execute command instead of referring to the specific method in
the editor class.
2011-03-28 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
instanceof Array test fails when using iframes
https://bugs.webkit.org/show_bug.cgi?id=17250
Update for new function and date apis
Test: fast/js/js-constructors-use-correct-global.html
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.cpp:
(WebCore::jsDateOrNull):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
2011-03-28 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=57124 When the scroller style is
changed via delegate method, the page needs a full relayout and repaint
-and corresponding-
<rdar://problem/9059129>
Call into WebKitSystemInterface to associate the new painter with the existing
painter controller. Reset the scrollbar frame rects to the new thickness -- normally
this only happens when a scrollbar is created, so we have to reset the thickness
here to pick up the new theme thickness. Finally, force a full relayout and style
recall with setNeedsRecalcStyleInAllFrames()
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
setNeedsRecalcStyleInAllFrames() used to be a static method in Settings.cpp. This
patch moves it to be a member function on Page so that it can be called from
FrameView when the scrollbar style changes.
* page/FrameView.cpp:
(WebCore::FrameView::setNeedsRecalcStyleInAllFrames):
* page/FrameView.h:
* page/Page.cpp:
(WebCore::Page::setNeedsRecalcStyleInAllFrames):
* page/Page.h:
* page/Settings.cpp:
(WebCore::Settings::setStandardFontFamily):
(WebCore::Settings::setFixedFontFamily):
(WebCore::Settings::setSerifFontFamily):
(WebCore::Settings::setSansSerifFontFamily):
(WebCore::Settings::setCursiveFontFamily):
(WebCore::Settings::setFantasyFontFamily):
(WebCore::Settings::setMinimumFontSize):
(WebCore::Settings::setMinimumLogicalFontSize):
(WebCore::Settings::setDefaultFontSize):
(WebCore::Settings::setDefaultFixedFontSize):
(WebCore::Settings::setTextAreasAreResizable):
(WebCore::Settings::setAuthorAndUserStylesEnabled):
(WebCore::Settings::setFontRenderingMode):
(WebCore::Settings::setAcceleratedCompositingEnabled):
(WebCore::Settings::setShowDebugBorders):
(WebCore::Settings::setShowRepaintCounter):
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::setNeedsRecalcStyleInAllFrames):
2011-03-28 Dirk Pranke <dpranke@chromium.org>
RS=Tony Chang.
r81977 moved FontPlatformData.h from
WebCore/platform/graphics/cocoa to platform/graphics. This
change updates the chromium build accordingly.
https://bugs.webkit.org/show_bug.cgi?id=57281
* platform/graphics/chromium/CrossProcessFontLoading.mm:
2011-03-28 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
MediaPlayerPrivateAVFoundation should report that it supportsFullScreen()
https://bugs.webkit.org/show_bug.cgi?id=57249
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::supportsFullscreen):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2011-03-28 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
AVFoundation can indeed support full screen.
MediaPlayerPrivateAVFoundation should report that it supportsFullScreen()
https://bugs.webkit.org/show_bug.cgi?id=57249
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::supportsFullscreen): Return true if using
the new full screen APIs.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2011-03-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
http streams don't always display video with AVFoundation backend
https://bugs.webkit.org/show_bug.cgi?id=57203
No new tests, we don't currently have tests for http live streams. Changes verified manually.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::MediaPlayer): Initialize m_shouldPrepareToRender.
(WebCore::MediaPlayer::loadWithNextMediaEngine): Call prepareForRendering on new engine
if m_shouldPrepareToRender is set.
(WebCore::MediaPlayer::prepareForRendering): Set m_shouldPrepareToRender.
* platform/graphics/MediaPlayer.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::isReadyForVideoSetup): Don't return true until
m_isAllowedToRender has been set.
(WebCore::MediaPlayerPrivateAVFoundation::prepareForRendering): Always call setUpVideoRendering,
it has logic to figure out when setup is required.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Call setUpVideoRendering when we aren't
using the preferred rendering mode because if we get a file's metadata between the
time supportsAcceleratedRendering() and paint() are called, we will allocate a software
renderer even when we prefer a layer backed renderer.
(WebCore::MediaPlayerPrivateAVFoundation::movieLoadType): Return "unknown" until we have metadata.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Use itemKVOProperties() instead of
an explicit list of key path names.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): metadataKeyNames renamed
to assetMetadataKeyNames, return an NSArray instead of a CFArrayRef since that is what the
callers need.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Return the duration of the
player item, not the asset, because AVAsset.duration always returns an indefinite time
for all streaming files.
(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): metadataKeyNames renamed
to assetMetadataKeyNames.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext): Do nothing until
metadata is available.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Split size calculation logic off
into sizeChanged().
(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): New. Use AVPlayerItem.presentationSize
until tracks is non-NULL so we have a size as early as possible.
(WebCore::MediaPlayerPrivateAVFoundationObjC::assetMetadataKeyNames): Renamed from metadataKeyNames.
(WebCore::MediaPlayerPrivateAVFoundationObjC::itemKVOProperties): New, return an array of
KVO observable properties.
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Respond to
presentationSize change.
2011-03-28 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Search field focus ring is missing
https://bugs.webkit.org/show_bug.cgi?id=57270
<rdar://problem/8765555>
Add an _automaticFocusRingDisabled method which returns YES.
* platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView _automaticFocusRingDisabled]):
2011-03-28 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Move more events to EventDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=57247
No functional changes, covered by existing tests.
* dom/EventDispatcher.cpp:
(WebCore::eventTargetRespectingSVGTargetRules): Made a static function,
since it's not used anywhere outside of the EventDispatcher.
(WebCore::EventDispatcher::dispatchScopedEvent): Moved from Node.cpp.
(WebCore::EventDispatcher::dispatchKeyEvent): Ditto.
(WebCore::EventDispatcher::dispatchWheelEvent): Ditto.
(WebCore::EventDispatcher::dispatchEvent): Changed to use eventTargetRespectingSVGTargetRules
as a static function.
* dom/EventDispatcher.h: Updated decls.
* dom/Node.cpp:
(WebCore::Node::dispatchScopedEvent): Replaced with calling EventDispatcher.
(WebCore::Node::dispatchKeyEvent): Ditto.
(WebCore::Node::dispatchWheelEvent): Ditto.
2011-03-28 Adele Peterson <adele@apple.com>
Reviewed by Eric Seidel.
Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
https://bugs.webkit.org/show_bug.cgi?id=57173
Test: editing/spelling/grammar.html
* WebCore.exp.in: Add symbol for new selectionStartHasMarkerFor method.
* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Every use of paragraph is specific to spelling or grammar,
so to avoid confusion, we should explicitly use spellingParagraph or grammarParagraph. In the case of this bug,
when we're consider ambiguous boundary characters (characters that could indicate word boundaries, but are used
in the middle of words too, like apostrophes), we should use the use the spellingParagraph since the spellingParagraph
is the only one operated on when this information is used.
(WebCore::Editor::selectionStartHasMarkerFor): Changed from selectionStartHasSpellingMarkerFor so it can check for grammar as well as spelling.
* editing/Editor.h:
2011-03-28 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/8895977> REGRESSION: multicol crashes with positioned elements
https://bugs.webkit.org/show_bug.cgi?id=48983
Test: fast/multicol/paginated-layer-crash.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintPaginatedChildLayer): Bring the logic for finding pagintating layers
into sync with updatePagination() after r68069.
(WebCore::RenderLayer::hitTestPaginatedChildLayer): Ditto.
2011-03-28 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler' .
URLSs with non-empty username but empty hostname treat first path segment as hostname, potentially enabling XSS
https://bugs.webkit.org/show_bug.cgi?id=57220
Test: http/tests/uri/username-with-no-hostname.html
* platform/KURL.cpp:
(WebCore::hostPortIsEmptyButUserPassIsNot):
(WebCore::KURL::parse):
2011-03-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
script-src should block inline event handlers
https://bugs.webkit.org/show_bug.cgi?id=57212
I considered wrapping this into the canExecute check, but that approach
would require passing that function a bunch of context information to
behave correctly once we add support for the "options" directive that
re-enables these features.
Test: http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
- This function was a mess. I couldn't resist cleaning it up a
bunch. Notice that we ASSERT at the beginning of the function
that scriptExecutionContext is a document and that both ways of
getting the global object are the same when document->frame() is
non-zero because the document must be active and there is a
one-to-one relation between Frames and active Documents.
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
* page/ContentSecurityPolicy.h:
2011-03-28 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
ResourceError::certificate() should return a PCCERT_CONTEXT
https://bugs.webkit.org/show_bug.cgi?id=57262
* platform/network/cf/ResourceError.h: certificate() now returns a PCCERT_CONTEXT.
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::certificate): Added.
2011-03-28 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser and Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=57221, memory corruption/crashes when positioned objects
occur at the end of a line.
The old code and new code for dealing with a trailing space object midpoint manipulated a raw
array instead of the Vector. Otherwise this corruption would have been caught prior to check-in.
I have patched the code to only go through the Vector and to make it handle the case that led to
the corruption. Trailing positioned objects can occur both prior to and following the trailing space
object's midpoint, so we have to be prepared to deal with both cases.
This is already tested by fast/block/positioning/052.html, and that test now properly progresses
like the other positioning tests did.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
2011-03-28 Andrei Popescu <andreip@google.com>
Reviewed by Steve Block.
V8IDBKeyCustom.cpp does not compile with INDEXED_DATABASE disabled
https://bugs.webkit.org/show_bug.cgi?id=57100
Close the ENABLE guard and the namespace in the right order.
No new tests, just cleanup.
* bindings/v8/custom/V8IDBAnyCustom.cpp:
* bindings/v8/custom/V8IDBKeyCustom.cpp:
2011-03-28 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
Include certificate when sending a WebCore::ResourceError to UI process on Windows
https://bugs.webkit.org/show_bug.cgi?id=57195
Add support for tracking the certificate in WebCore::ResourceError.
* platform/network/ResourceErrorBase.cpp:
(WebCore::ResourceErrorBase::copy): Call platformCopy() to copy platform-specific fields.
* platform/network/ResourceErrorBase.h:
(WebCore::ResourceErrorBase::platformCopy): Added.
* platform/network/cf/ResourceError.h: Added constructor that takes certificate data, shadowed platformCopy, added m_certificate.
(WebCore::ResourceError::certificate): Added.
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError): Added constructor that takes certificate data.
(WebCore::ResourceError::platformLazyInit): Read any certificate from the userInfo dictionary.
(WebCore::ResourceError::platformCopy): Copy m_certificate.
(WebCore::ResourceError::cfError): Add any certificate data to the userInfo dictionary in the CFErrorRef.
2011-03-28 Jessie Berlin <jberlin@apple.com>
Rubber-stamped by Adam Roben.
Add an extra newline to the end of the generated Inspector.idl file so that it does not
trigger the Windows "no newline at at end of file" warning.
* inspector/generate-inspector-idl:
2011-03-28 Csaba Osztrogonác <ossy@webkit.org>
Buildfix after r82125.
[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087
* platform/graphics/qt/MediaPlayerPrivateQt.cpp: Convert all char* to QString explicitly.
(WebCore::MediaPlayerPrivateQt::getSupportedTypes):
(WebCore::MediaPlayerPrivateQt::commitLoad):
2011-03-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82099.
http://trac.webkit.org/changeset/82099
https://bugs.webkit.org/show_bug.cgi?id=57245
Breaks live edits tests on chromium. (Requested by pfeldman on
#webkit).
* inspector/front-end/ScriptsPanel.js:
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._handleSave):
(WebInspector.SourceFrameDelegate.prototype.editScriptSource):
2011-03-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: brush up and rename debugger domain functions.
https://bugs.webkit.org/show_bug.cgi?id=57240
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::postWorkerNotificationToFrontend):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointsActive):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::editScriptSource):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::failedToParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::didContinue):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.prototype.removeBreakpoint):
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
(WebInspector.DebuggerDispatcher.prototype.paused):
(WebInspector.DebuggerDispatcher.prototype.resumed):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
(WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse):
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.toggleBreakpointsClicked):
* inspector/front-end/inspector.js:
(WebInspector.didCreateWorker):
(WebInspector.didDestroyWorker):
2011-03-28 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/57239> Use forward class declaration instead of including header
Reviewed by Dan Bernstein.
Adding a "using namespace WebCore;" statement in a header may
cause issues when <WebCore/Length.h> is included before
<CoreText/CoreText.h>.
Length.h defines the LengthType enum with a 'Fixed' value.
CoreText.h includes MacTypes.h, which has a
"typedef SInt32 Fixed;" statement, and then CoreText.h includes
other headers that also use 'Fixed', but expect the typedef to
be defined, not the enum. If another header includes
"using namespace WebCore;" before CoreText.h, the
following compiler errors result (paths abbreviated):
CoreText.framework/Headers/SFNTLayoutTypes.h:689: error: reference to 'Fixed' is ambiguous
MacTypes.h:184: error: candidates are: typedef SInt32 Fixed
Length.h:37: error: WebCore::LengthType WebCore::Fixed
SFNTLayoutTypes.h:689: error: 'Fixed' does not name a type
* platform/mac/HTMLConverter.h: Use forward declaration of
DocumentLoader class instead of including header. Remove the
unused "using namespace WebCore;" statement.
2011-03-26 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
Introduce EventDispatcher, the new common way to fire events.
https://bugs.webkit.org/show_bug.cgi?id=57168
The goal here is two-fold:
1) reduce the need to randomly sprinkle guards around the dispatch code
by creating a well-scoped abstraction for dispatching events.
2) create a place where fiddly event-related things like creating event
contexts for ancestors can be done lazily.
Additionally, with all the free-standing static functions, this code was
just begging to come out of Node.cpp.
The first step is a near-mechanical extraction of mouse-related events
from Node.cpp to EventDispatcher. For now, the call sites are just
replaced with invoking EventDispatcher. Later, we can remove these methods
from Node.
Refactoring, no functional changes.
* Android.mk: Added EventDispatcher to build system.
* CMakeLists.txt: Ditto.
* GNUmakefile.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* dom/DOMAllInOne.cpp: Ditto.
* dom/EventDispatcher.cpp: Added.
* dom/EventDispatcher.h: Added.
* dom/Node.cpp:
(WebCore::Node::dispatchScopedEvent): Replaced to use EventDispatcher.
(WebCore::Node::dispatchEvent): Ditto.
(WebCore::Node::dispatchMouseEvent): Ditto.
(WebCore::Node::dispatchSimulatedClick): Ditto.
* dom/Node.h: Updated decls.
2011-03-28 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9003382> Incomplete repaint of overflow in flipped lines writing modes
https://bugs.webkit.org/show_bug.cgi?id=57197
Tests: fast/repaint/overflow-flipped-writing-mode-block.html
fast/repaint/overflow-flipped-writing-mode-table.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint): Flip the overflow rect before testing for intersection
with the damage rect.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paint): Made the intersection check more like the one in
RenderBlock::paint().
2011-03-28 Xiaomei Ji <xji@chromium.org>
Reviewed by Ryosuke Niwa.
move directionOfEnclosingBlock() to be global so that it could be reused.
https://bugs.webkit.org/show_bug.cgi?id=57233.
Provide global function directionOfEnclosingBlock(Node*) so that it could be
reused in SelectionController and other functionalities that need enclosing
block's direcionality, such as moving caret by word in visual order.
No new functionality, so no new tests.
* editing/SelectionController.cpp:
(WebCore::SelectionController::directionOfEnclosingBlock):
* editing/htmlediting.cpp:
(WebCore::directionOfEnclosingBlock):
* editing/htmlediting.h:
2011-03-28 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Benjamin Poulain.
[Qt] fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html fails
https://bugs.webkit.org/show_bug.cgi?id=56825
Fixes for context attribute handling:
- Initialize depth and stencil buffer depending on whether they
are enabled in context attributes.
- Always enable depth buffer when stencil buffer is enabled.
- Disable stencil buffer on OpenGL ES 2.0
- Cleaned up clutter code from initialization. Made code paths
more sane.
- Clear mask is now set correctly in reshape().
Tests: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::isValid):
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::reshape):
(WebCore::GraphicsContext3DInternal::paint):
(WebCore::GraphicsContext3DInternal::getProcAddress):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::bindFramebuffer):
2011-03-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: rename network domain events from didHappenSomething to somethingHappened.
https://bugs.webkit.org/show_bug.cgi?id=57226
* inspector/Inspector.json:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveContentLength):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::setInitialContent):
(WebCore::InspectorResourceAgent::didCommitLoad):
(WebCore::InspectorResourceAgent::frameDetachedFromParent):
(WebCore::InspectorResourceAgent::didCreateWebSocket):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.dataReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):
(WebInspector.NetworkDispatcher.prototype.loadingFailed):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.frameDetached):
(WebInspector.NetworkDispatcher.prototype.initialContentSet):
(WebInspector.NetworkDispatcher.prototype.frameNavigated):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketClosed):
2011-03-28 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: [Chromium] Delete native CPU profiles and heap snapshots on binding disposal.
https://bugs.webkit.org/show_bug.cgi?id=57099
* bindings/v8/ScriptHeapSnapshot.cpp:
(WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot):
* bindings/v8/ScriptHeapSnapshot.h:
* bindings/v8/ScriptProfile.cpp:
(WebCore::ScriptProfile::~ScriptProfile):
* bindings/v8/ScriptProfile.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::resetState):
2011-03-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: fix console messages positions in formatted scripts.
https://bugs.webkit.org/show_bug.cgi?id=57010
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage.didRequestMapping):
(WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype.clearConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype._reset):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.addConsoleMessage):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.addConsoleMessage):
(WebInspector.ScriptsPanel.prototype.clearConsoleMessages):
(WebInspector.ScriptsPanel.prototype._consoleMessageAdded):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
* inspector/front-end/SourceFile.js:
(WebInspector.SourceFile):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.addMessage):
(WebInspector.SourceFrame.prototype._addExistingMessagesToSource):
(WebInspector.SourceFrame.prototype.addMessageToSource):
2011-03-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: refactor ResourceTreeModel to remove poor dependencies.
https://bugs.webkit.org/show_bug.cgi?id=57186
- ResourceTreeModel is now event target (Object)
- There is no ResourceTreeModel -> UI dependencies
- NetworkManager -> ResourceTreeModel dependencies has been removed
- NetworkManager is no longer dealing with the resources tree, it is only responsible for network events
- ResourceTreeModel requests tree structure from the backend separately
- Cached resources tree payload is now limited to url and type (no headers involved)
- Resources tree is being rendered lazily upon request from the panel.
* inspector/Inspector.json:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::resourceContent):
(WebCore::InspectorResourceAgent::resourceContentBase64):
(WebCore::buildObjectForFrameTree):
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::getCachedResources):
(WebCore::InspectorResourceAgent::getResourceContent):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend):
(.WebInspector.InspectorFrontendHostStub.prototype.loadSessionSetting):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype.frontendReused):
(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
(WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.frameDetachedFromParent):
(WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel):
(WebInspector.NetworkPanel.prototype._updateSummaryBar):
(WebInspector.NetworkPanel.prototype._onFrameCommitLoad):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype.frontendReused):
(WebInspector.ResourceTreeModel.prototype._processCachedResources):
(WebInspector.ResourceTreeModel.prototype._addOrUpdateFrame):
(WebInspector.ResourceTreeModel.prototype.frames):
(WebInspector.ResourceTreeModel.prototype.subframes):
(WebInspector.ResourceTreeModel.prototype.resources):
(WebInspector.ResourceTreeModel.prototype._onCommitLoad):
(WebInspector.ResourceTreeModel.prototype._onFrameDetachedFromParent):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
(WebInspector.ResourceTreeModel.prototype._addResourceToFrame):
(WebInspector.ResourceTreeModel.prototype.resourceForURL):
(WebInspector.ResourceTreeModel.prototype._bindResourceURL):
(WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
(WebInspector.ResourceTreeModel.prototype._clearResources):
(WebInspector.ResourceTreeModel.prototype._callForFrameResources):
(WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeModel.prototype._createResource):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.show):
(WebInspector.ResourcesPanel.prototype._populateResourceTree.populateFrame):
(WebInspector.ResourcesPanel.prototype._populateResourceTree):
(WebInspector.ResourcesPanel.prototype._frameAdded):
(WebInspector.ResourcesPanel.prototype._frameDetached):
(WebInspector.ResourcesPanel.prototype._resourceAdded):
(WebInspector.ResourcesPanel.prototype._frameNavigated):
(WebInspector.FrameTreeElement.prototype.setTitles):
* inspector/front-end/inspector.js:
(WebInspector.frontendReused):
2011-03-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
WebKit's behavior for text-align inherit differs from other browsers
https://bugs.webkit.org/show_bug.cgi?id=56377
The bug was caused by WebKit's resolving text-align: start and text-align: end too early.
As discussed on the bug, when text-align: start and text-align: end are inherited by descendent nodes,
the alignment of the text in those nodes should be determined based on the directionality of the text,
not by the directionality of the ancestor node from which text-align property is inherited.
Fixed the bug by introducing new enum values to ETextAlign: TASTART and TAEND. These two values will
align text to the left in a LTR context and to the right in a RTL context respectively.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added the support for TASTART and TAEND.
(WebCore::CSSPrimitiveValue::operator ETextAlign): Ditto.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): No longer processes CSSValueStart and CSSValueEnd.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::localCaretRect): Added the support for TASTART and TAEND.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Added the support for TASTART and TAEND.
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect): Ditto.
* rendering/style/RenderStyle.h: ETextAlign now has 10 values and requires 4 bits.
* rendering/style/RenderStyleConstants.h: Added TASTART and TAEND to ETextAlign.
2011-03-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: fix breakpoints positions in formatted scripts.
https://bugs.webkit.org/show_bug.cgi?id=56931
Add async requestMapping method to SourceFile interface as required for populating
breakpoints sidebar pane when in "format all scripts" mode.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.PresentationBreakpoint): Breakpoint wrapper for UI.
(WebInspector.PresentationBreakpoint.prototype.get sourceFileId):
(WebInspector.PresentationBreakpoint.prototype.get lineNumber):
(WebInspector.PresentationBreakpoint.prototype.get condition):
(WebInspector.PresentationBreakpoint.prototype.get enabled):
(WebInspector.PresentationBreakpoint.prototype.get url):
(WebInspector.PresentationBreakpoint.prototype.get resolved):
(WebInspector.PresentationBreakpoint.prototype.loadSnippet):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
(WebInspector.ScriptFormatter.prototype.formatContent):
* inspector/front-end/SourceFile.js:
(WebInspector.SourceFile.prototype.requestSourceMapping):
(WebInspector.FormattedSourceFile.prototype.requestSourceMapping):
(WebInspector.FormattedSourceFile.prototype._didRequestContent):
(WebInspector.SourceMapping):
(WebInspector.SourceMapping.prototype.scriptLocationToSourceLocation):
(WebInspector.SourceMapping.prototype.sourceLocationToScriptLocation):
(WebInspector.FormattedSourceMapping):
(WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLocation):
(WebInspector.FormattedSourceMapping.prototype.sourceLocationToScriptLocation):
(WebInspector.FormattedSourceMapping.prototype._convertPosition):
2011-03-28 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Csaba Osztrogonác.
This patch fixes linking errors on Qt Webkit Windows MinGW builds.
This patch sets the BUILDING_WEBKIT & QT_MAKEDLL macros so that
QWEBKIT_EXPORT is defined as follows:
#define QWEBKIT_EXPORT Q_DECL_EXPORT
No new tests needed since only changing .pro file.
* WebCore.pro:
2011-03-28 Andrey Adaikin <aandrey@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: source frame should show the error to user when live edit is failed
https://bugs.webkit.org/show_bug.cgi?id=57002
* inspector/front-end/ScriptsPanel.js:
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._handleSave.didSaveScriptSource):
(WebInspector.SourceFrame.prototype._handleSave):
(WebInspector.SourceFrameDelegate.prototype.editScriptSource):
2011-03-26 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Expose the AtkValue interface for WAI-ARIA sliders
https://bugs.webkit.org/show_bug.cgi?id=56655
Implement AtkValue interface for WAI-ARIA sliders.
Test: platform/gtk/accessibility/aria-slider-required-attributes.html
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Emit the
'property-change::accessible-value' signal when needed.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(core): New, returns a core object from an AtkValue.
(webkitAccessibleValueGetCurrentValue): New, implements AtkValue.
(webkitAccessibleValueGetMaximumValue): Ditto.
(webkitAccessibleValueGetMinimumValue): Ditto.
(webkitAccessibleValueSetCurrentValue): Ditto.
(webkitAccessibleValueGetMinimumIncrement): Ditto.
(atkValueInterfaceInit): Ditto.
(GetAtkInterfaceTypeFromWAIType): Add ATK_TYPE_VALUE.
(getInterfaceMaskFromObject): Set the WAI_VALUE bit for sliders.
2011-03-28 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Assigning location.path to something that doesn't start with / mangles the authority
https://bugs.webkit.org/show_bug.cgi?id=57209
<rdar://problem/9195132>
Tests: http/tests/uri/assign-path-with-leading-slash.html
http/tests/uri/assign-path-without-leading-slash.html
* platform/KURL.cpp:
(WebCore::KURL::setPath): If the new path does not have a leading slash, add one.
2011-03-28 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Extract functions to update logical width from computeInlineDirectionPositionsForLine
https://bugs.webkit.org/show_bug.cgi?id=57213
Extracted updateLogicalWidthForLeftAlignedBlock, updateLogicalWidthForRightAlignedBlock,
and updateLogicalWidthForCenterAlignedBlock from computeInlineDirectionPositionsForLine.
They are used to update logical widths, logical left, and total logical width for left,
right, and center aligned blocks.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::updateLogicalWidthForLeftAlignedBlock):
(WebCore::updateLogicalWidthForRightAlignedBlock):
(WebCore::updateLogicalWidthForCenterAlignedBlock):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
2011-03-28 Evan Martin <evan@chromium.org>
Reviewed by Ryosuke Niwa.
Refactor duplicate code in HTMLTextElement
https://bugs.webkit.org/show_bug.cgi?id=57215
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::childrenChanged):
This method did an equivalent loop to the text() method on
the same object.
2011-03-27 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Don't call WebSocket::didClose() more than once.
https://bugs.webkit.org/show_bug.cgi?id=57081
If WebSocket close() is called, and connection is established, then
it will call didClose() that resets m_channel to 0.
After that, when connection is closed, WebSocketChannel will call
didClose for the WebSocket instance.
Call WebSocketChannel::disconnect() before m_channel = 0 to make sure
WebSocketChannel suppress the second didClose().
Test: http/tests/websocket/tests/close-unref-websocket.html
* websockets/WebSocket.cpp:
(WebCore::WebSocket::didClose):
2011-03-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix script-src redirect handling
https://bugs.webkit.org/show_bug.cgi?id=57196
Resource-loading requirements in CSP apply to each hop in the redirect
chain. To make that work properly, we need to move enforcement into
the loader. Fortunately, we already have a choke-point in the loader
for enforcing this kind of policy.
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript):
* html/parser/HTMLDocumentParser.cpp:
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLScriptRunnerHost.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
* page/ContentSecurityPolicy.h:
2011-03-27 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Full Screen: disable keyboard access by default
https://bugs.webkit.org/show_bug.cgi?id=56684
Pass whether keyboard access was requested up to ChromeClient when asking
if fullscreen mode is supported.
* dom/Document.cpp:
(WebCore::Document::webkitRequestFullScreenForElement):
* page/ChromeClient.h:
(WebCore::ChromeClient::supportsFullscreenForElement):
2011-03-27 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Generate WebKitVersion.h
https://bugs.webkit.org/show_bug.cgi?id=57128
This file will be used for the user agent string by the CMake based ports.
* CMakeLists.txt:
2011-03-27 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=57170 Fix last elements
in an enum to remove a trailing comma. Sun Studio 12 CC errors out.
Compile fix only, no actual code change.
* dom/ExceptionCode.h:
* editing/EditorInsertAction.h:
* loader/FrameLoaderTypes.h:
* platform/PlatformKeyboardEvent.h:
* platform/ScrollTypes.h:
* platform/graphics/BitmapImage.h:
* platform/image-decoders/ImageDecoder.h:
* platform/network/ProtectionSpace.h:
* platform/network/ResourceHandleClient.h:
* platform/network/ResourceRequestBase.h:
* platform/text/TextCodec.h:
2011-03-27 Rob Buis <rwlbuis@gmail.com>
Reviewed by Nikolas Zimmermann.
Text on path positioning at zero startOffset
https://bugs.webkit.org/show_bug.cgi?id=56245
Since for length 0 no previous point is set, choose epsilon
length to get normal at starting point of the path.
Test: svg/text/text-path-middle-align.svg
* platform/graphics/Path.cpp:
(WebCore::Path::normalAngleAtLength):
2011-03-27 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=57151, patch derived from set
created by Thiago Macieria in bug https://bugs.webkit.org/show_bug.cgi?id=24932
Fix compile issue on Solaris 10/Sun Studio 12 regarding ambiguity on ?: functions
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::thisObject):
2011-03-26 Jer Noble <jer.noble@apple.com>
Unreviewed build fix.
Fix a bug which was causing the "skip back" button to be missing, causing
the media layout tests to fail.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::shouldRenderMediaControlPart):
2011-03-26 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9180716> REGRESSION (r80582): Angle bracket rendered upright in vertical mode
https://bugs.webkit.org/show_bug.cgi?id=57169
Test: fast/blockflow/fallback-orientation.html
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataForCharacter): If the font has vertical glyphs, use it, rather
than continuing down the fallback list.
2011-03-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Follow-up fix for crash with giant inline stylesheets - actually don't crash, and add test
https://bugs.webkit.org/show_bug.cgi?id=56150
Test: fast/css/giant-stylesheet-crash.html
* dom/StyleElement.cpp:
(WebCore::StyleElement::process):
2011-03-22 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Media controls must use full screen style when in new full screen mode.
https://bugs.webkit.org/show_bug.cgi?id=56851
Add new full screen styles for the full screen media elements.
* DerivedSources.make: Add fullScreenQuickTime.css.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* css/CSSStyleSelector.cpp: Removed loadFullScreenRulesIfNeeded().
(WebCore::CSSStyleSelector::CSSStyleSelector): Ditto.
(WebCore::CSSStyleSelector::styleForElement): Load full screen rules
if needed.
* css/fullscreenQuickTime.css: Added.
* css/mediaControls.css:
* html/shadow/MediaControls.cpp:
(WebCore::isFullScreen): Added.
(WebCore::MediaControls::create): Add new full screen volume controls.
(WebCore::MediaControls::updateStyle): Ditto.
(WebCore::MediaControls::update): Ditto.
(WebCore::MediaControls::updateVolumeSliderContainer): Ditto.
(WebCore::MediaControls::forwardEvent): Ditto.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement): Added.
(WebCore::MediaControlFullscreenVolumeSliderElement::create): Added.
(WebCore::MediaControlFullscreenVolumeSliderElement::shadowPseudoId): Added.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement): Addet
(WebCore::MediaControlFullscreenVolumeMinButtonElement::create): Added.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Added.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement): Added.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::create): Added.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Added.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::shadowPseudoId): Added.
* rendering/MediaControlElements.h:
Added m_overridePosition.
(WebCore::MediaControlVolumeSliderContainerElement::setOverridesPosition): Added.
* rendering/MediaControlElements.h:
(WebCore::MediaControlVolumeSliderContainerElement::overridesPosition): Added.
* rendering/RenderTheme.h:
(WebCore::RenderTheme::extraFullScreenStyleSheet): Added.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::extraFullScreenStyleSheet): Added.
(WebCore::RenderThemeMac::shouldRenderMediaControlPart): Render seek forward and backward
buttons.
2011-03-26 Jer Noble <jer.noble@apple.com>
Reviewed by Dan Bernstein.
RenderMedia should obey the view's flattening bit.
https://bugs.webkit.org/show_bug.cgi?id=57156
Paint the current frame in software when the associated FrameView
has its flattening bit set.
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::paintReplaced):
2011-03-26 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix for !ENABLE(DOM_STORAGE).
* storage/StorageTracker.cpp:
Added #if ENABLE(DOM_STORAGE) like in the other storage files.
2011-03-26 Kwang Yul Seo <skyul@company100.net>
Reviewed by Benjamin Poulain.
[Qt] Remove GraphicsLayerTextureMapper::nativeLayer
https://bugs.webkit.org/show_bug.cgi?id=57141
GraphicsLayer::nativeLayer was removed in r73380.
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
2011-03-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Teach Content Security Policy how to parse source-list
https://bugs.webkit.org/show_bug.cgi?id=54799
This patch is larger than I would like, but I wasn't sure how to make
it any smaller while still being reasonably testable. I've left out
some features (such as host wildcarding and 'self') so I can add them
in later patches with tests.
Test: http/tests/security/contentSecurityPolicy/source-list-parsing.html
* bindings/ScriptControllerBase.cpp:
* dom/ScriptElement.cpp:
* html/parser/HTMLDocumentParser.cpp:
* loader/FrameLoader.cpp:
- Add include explicitly now that we're not spamming the include
everywhere.
* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
- We need to pass the SecurityOrigin object to
ContentSecurityPolicy so that it can resolve implicit parts of
source patterns, such as the scheme.
* dom/Document.h:
- Forward declare ContentSecurityPolicy rather than including the
header. Technically this could be a separate change, but I was
getting annoyed at the world re-builds.
* page/ContentSecurityPolicy.cpp:
(WebCore::skipExactly):
(WebCore::skipUtil):
(WebCore::skipWhile):
- Clean up these parser helper functions. We might consider moving
them to a more general location. They're very helpful for
writing secure HTTP header parsers.
(WebCore::CSPSource::CSPSource):
- New class to represent one source in a source-list.
(WebCore::CSPSource::matches):
(WebCore::CSPSource::schemeMatches):
(WebCore::CSPSource::hostMatches):
(WebCore::CSPSource::portMatches):
(WebCore::CSPSource::isSchemeOnly):
- Currently we represent scheme-only sources using with an empty
m_host. Another approach I considered was using another bool,
but that seemed slighly messier.
(WebCore::CSPSourceList::CSPSourceList):
- CSPSourceList doesn't need to ref SecurityOrigin because
CSPSourceList is owned by ContentSecurityPolicy, which holds a
ref.
(WebCore::CSPSourceList::parse):
(WebCore::CSPSourceList::matches):
(WebCore::CSPSourceList::parseSource):
(WebCore::CSPSourceList::parseScheme):
(WebCore::CSPSourceList::parseHost):
(WebCore::CSPSourceList::parsePort):
- A basic "segment and recurse" parser. This parser causes us to
take more branches than we need, but I don't think we need to
squeeze every last ouch of performance out of this parser. This
approach is more simple than some of the other approaches I
tried.
(WebCore::CSPSourceList::addSourceSelf):
(WebCore::CSPDirective::CSPDirective):
(WebCore::CSPDirective::allows):
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::parse):
(WebCore::ContentSecurityPolicy::parseDirective):
(WebCore::ContentSecurityPolicy::addDirective):
- I couldn't resist re-writing this parser to use the helper
functions and to match the style of the source-list parser.
* page/ContentSecurityPolicy.h:
(WebCore::ContentSecurityPolicy::create):
- Accept a SecurityOrigin context object.
2011-03-26 Patrick Gansterer <paroga@webkit.org>
Unreviewed EFL and WinCE build fix for r81977.
* platform/graphics/FontPlatformData.h:
2011-03-26 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r82000.
* platform/wince/FileSystemWinCE.cpp:
(WebCore::openFile): Added missing function.
2011-03-25 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix, don't use the new FPD implementation yet, until we can merge ours with it.
* platform/graphics/FontPlatformData.h:
2011-03-25 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
MediaPlayerPrivateQuickTimeVisualContext should use the Application Cache during load.
https://bugs.webkit.org/show_bug.cgi?id=57047
No new tests.
When loading a URL, checkk osee if the Appplication Cache has a version of that URL
stored; if so, use the local path to that cached media instead of the remote URL.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::loadInternal):
* platform/graphics/win/QTMovie.cpp:
(QTMovie::loadPath):
* platform/graphics/win/QTMovie.h:
2011-03-25 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/9134330> Missing expansion before ideograph at the beginning or end of a text run
https://bugs.webkit.org/show_bug.cgi?id=57106
Test: fast/text/justify-ideograph-leading-expansion.html
* platform/graphics/TextRun.h:
Replaced TrailingExpansionBehavior enum with ExpansionBehavior flags.
(WebCore::TextRun::TextRun): Constructors now take an expansionBehavior parameter.
(WebCore::TextRun::allowsLeadingExpansion): Added this accessor.
(WebCore::TextRun::allowsTrailingExpansion): Changed to use the m_expansionBehavior member.
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator): Initialize m_isAfterExpansion from the TextRun, allowing
leading expansion when appropriate.
(WebCore::WidthIterator::advance): Moved the last-glyph-in-run check to only apply to expansion
after the glyph, not expansion before the glyph, since that is not trailing expansion. Added code
to handle expansion before the first glyph.
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController): Initialize m_afterExpansion from the
TextRun, allowing leading expansion when appropriate. Set m_runWidthSoFar to the leading expansion.
(WebCore::ComplexTextController::offsetForPosition): Account for leading expansion.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Similar to WidthIterator::advance()
* platform/graphics/mac/ComplexTextController.h: Added m_leadingExpansion member variable.
* rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox): Renamed m_hasSelectedChildren to m_hasSelectedChildrenOrCanHaveLeadingExpansion
to reflect the use of this bit by InlineTextBox.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect): Replaced calls to trailingExpansionBehavior() with expansionBehavior().
(WebCore::InlineTextBox::paint): Ditto.
(WebCore::InlineTextBox::paintSelection): Ditto.
(WebCore::InlineTextBox::paintCompositionBackground): Ditto.
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto.
(WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.
(WebCore::InlineTextBox::offsetForPosition): Ditto.
(WebCore::InlineTextBox::positionForOffset): Ditto.
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::canHaveLeadingExpansion): Added this accessor.
(WebCore::InlineTextBox::setCanHaveLeadingExpansion): Ditto.
(WebCore::InlineTextBox::expansionBehavior): Replaced trailingExpansionBehavior() with this function,
which also considers canHaveLeadingExpansion().
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Call setCanHaveLeadingExpansion() on
text boxes that can have leading expansion. Avoid negative expansion.
* rendering/RootInlineBox.cpp:
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::hasSelectedChildren): Updated for renaming of the flag.
(WebCore::RootInlineBox::setHasSelectedChildren): Ditto.
2011-03-23 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
MediaPlayerPrivateAVFoundation should use the Application Cache during load.
https://bugs.webkit.org/show_bug.cgi?id=56997
No new tests.
When loading a URL, check to see if the Application Cache has a version of that URL
stored; if so, use the local path to that cached media instead of the remote URL.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Check to see if the media should be loaded
from the application cache.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Split out from createAVPlayerForURL.
2011-03-25 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=57122. Solaris 10/SunStudio 12 expect
both sides of a ?: operation to have the same types. Extracted from original
https://bugs.webkit.org/show_bug.cgi?id=24932, patch 13 of 17, and originally
created by Thiago Macieira.
fixes a compile issue on Solaris 10/SunStudio 12
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::serverRedirectSourceForHistory):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
2011-02-03 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
MediaPlayerPrivateQTKit should use the Application Cache during load.
https://bugs.webkit.org/show_bug.cgi?id=53818
No new tests.
When loading a URL, check to see if the Application Cache has a version of that URL
stored; if so, use that data instead of the remote URL.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::loadInternal):
2011-03-25 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Move draw implementations to CCLayerImpl for everything except content layers
https://bugs.webkit.org/show_bug.cgi?id=56793
Moves the implementation of the layer's draw() function from LayerChromium subclasses to CCLayerImpl subclasses for
all layer types except content layers. This gets us closer to decoupling the composite step itself from updating the layers.
The biggest change in this patch is adding a set of CCLayerImpl subclasses to implement the different drawing routines
and moving the code from each XXXLayerChromium to CCXXXLayerImpl. In order to render from the CCLayerImpl side all state
needed at draw time also has to be synchronized, which is performed in pushPropertiesTo().
On the LayerRendererChromium side there are a few changes. I've split the updateContents calls on LayerChromiums into two operations
tentatively named 'paintContentsIfNeeded' and 'updateCompositorResources'. paintContents() is used for any code that calls into WebKit in order to generate
new pixel data. It's expected that this call may take a long period of time and may involve "odd" side effects. updateCompositorResources() is used for
code that needs to update the compositor's texture data or other state. It is not expected that this callback will take long (since it's just inserting
commands into the GL command stream, ideally) and this call is expected to have access to the compositor's context, unlike paintContents().
The updateAndDrawLayers cycle now looks like this:
1.) update the root content layer
2.) update the root layer scrollbars
3.) for each LayerChromium in tree order:
a.) ensure a CCLayerImpl of the correct type exists for this layer
b.) push all draw time properties from the LayerChromium to the CCLayerImpl
c.) construct the appropriate draw transforms, render surfaces and render surface z-order sublayer lists
4.) for each LayerChromium in tree order, paint the layer's contents
5.) for each LayerChromium in tree order, update the associate compositor resources (textures, etc)
6.) draw the root layer and its scrollbars
7.) for each CCLayerImpl in render surface order, draw it
Step 3 should really happen after step 5, but right now painting a content layer requires knowledge of the render surface properties and draw transforms
in order to paint. We also currently push layer properties from LayerChromium->CCLayerImpls twice now - once at 3.b and once after 5 so we can pick
up any texture updates. This will also get fixed when the paint dependency on render surfaces is resolved.
I haven't modified the root layer or content layers in order to minimize conflicts with the other pending work in that area.
Tests: compositing/
* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
* platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::createCCLayerImpl):
(WebCore::CanvasLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/CanvasLayerChromium.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::requiresClippedUpdateRect):
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::updateCompositorResources):
(WebCore::ContentLayerChromium::bindContentsTexture):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::cleanupResources):
(WebCore::LayerChromium::setLayerRenderer):
(WebCore::LayerChromium::setName):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::dumpLayer):
(WebCore::LayerChromium::createCCLayerImpl):
(WebCore::LayerChromium::createCCLayerImplIfNeeded):
(WebCore::LayerChromium::ccLayerImpl):
(WebCore::LayerChromium::layerRenderer):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::paintContentsIfDirty):
(WebCore::LayerChromium::updateCompositorResources):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::paintContentsRecursive):
(WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::LayerRendererChromium::initializeSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::canvasLayerProgram):
(WebCore::LayerRendererChromium::pluginLayerProgram):
(WebCore::LayerRendererChromium::videoLayerRGBAProgram):
(WebCore::LayerRendererChromium::videoLayerYUVProgram):
* platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::createCCLayerImpl):
(WebCore::PluginLayerChromium::setTextureId):
(WebCore::PluginLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/PluginLayerChromium.h:
(WebCore::PluginLayerChromium::textureId):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::createCCLayerImpl):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/VideoLayerChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
* platform/graphics/chromium/WebGLLayerChromium.h:
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp.
(WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl):
(WebCore::CCCanvasLayerImpl::~CCCanvasLayerImpl):
(WebCore::CCCanvasLayerImpl::draw):
(WebCore::CCCanvasLayerImpl::dumpLayerProperties):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.
(WebCore::CCCanvasLayerImpl::create):
(WebCore::CCCanvasLayerImpl::setTextureId):
(WebCore::CCCanvasLayerImpl::setPremultipliedAlpha):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::descendantsDrawsContent):
(WebCore::CCLayerImpl::updateCompositorResources):
(WebCore::CCLayerImpl::writeIndent):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setAnchorPoint):
(WebCore::CCLayerImpl::setAnchorPointZ):
(WebCore::CCLayerImpl::setMasksToBounds):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setPosition):
(WebCore::CCLayerImpl::setPreserves3D):
(WebCore::CCLayerImpl::setSublayerTransform):
(WebCore::CCLayerImpl::setTransform):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp.
(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::~CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::draw):
(WebCore::CCPluginLayerImpl::dumpLayerProperties):
* platform/graphics/chromium/cc/CCPluginLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.
(WebCore::CCPluginLayerImpl::create):
(WebCore::CCPluginLayerImpl::setTextureId):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: Added.
(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::setTexture):
(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):
(WebCore::CCVideoLayerImpl::dumpLayerProperties):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.
(WebCore::CCVideoLayerImpl::create):
(WebCore::CCVideoLayerImpl::setSkipsDraw):
(WebCore::CCVideoLayerImpl::setFrameFormat):
2011-03-25 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Allow defineOwnProperty to work on DOMObjects
https://bugs.webkit.org/show_bug.cgi?id=57129
As other engines are allowing defineOwnProperty to be applied
to host objects there's no reason for us to retain this
restriction.
* bindings/js/JSDOMWrapper.cpp:
* bindings/js/JSDOMWrapper.h:
2011-03-25 Andy Estes <aestes@apple.com>
Reviewed by Adele Peterson.
REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016
AC_QuickTime.js uses the common <object>/<embed> paradigm to embed the
QuickTime plug-in in web pages. r70748 removed our mapping of classids
to MIME types, which causes WebKit to fall back from the object to the
embed tag when QuickTime is embedded by this script. The script emits
the following embed tag to embed a QuickTime movie with a poster frame:
<embed src="poster-frame.png" target="quicktimeplayer" href="movie.mov">
The expectation is that a QuickTime plug-in is instantiated to display the
poster frame, since QuickTime registers for many common image MIME
types. This is how Gecko behaves for embed. However, WebKit prefers to
use its native image rendering for image embeds, in which case no movie
is played when the poster frame is clicked.
Fix this by changing embed to check for a plug-in that can handle the
image type before rendering the image natively. This matches Gecko.
Test: plugins/embed-prefers-plugins-for-images.html
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::HTMLEmbedElement):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::HTMLObjectElement):
(WebCore::HTMLObjectElement::parametersForPlugin):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::isImageType):
(WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
* html/HTMLPlugInImageElement.h:
(WebCore::HTMLPlugInImageElement::shouldPreferPlugInsForImages):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::objectContentType):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::defaultObjectContentType):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::resourceWillUsePlugin):
(WebCore::SubframeLoader::requestPlugin):
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::shouldUsePlugin):
* loader/SubframeLoader.h:
2011-03-23 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Application Cache should save audio/ and video/ mime types as flat files
https://bugs.webkit.org/show_bug.cgi?id=53784
<rdar://problem/8932473>
No new tests, as this behavior is not possible to test without changes to the MediaPlayer engines.
Store certain mime types as flat files alongside the Application Cache database.
This requires plumbing the saved file path from ApplicationCacheStorage through
to ApplicationCacheResource.
(WebCore::ApplicationCacheStorage::openDatabase): Modify the CacheResourceData schema and
add a new DeletedCacheResources table, add a new CacheResourceDataDeleted trigger.
(WebCore::ApplicationCacheStorage::store): Add the new path data when adding new rows in
CacheResourceData, and store media resources as flat files.
(WebCore::ApplicationCacheStorage::loadCache): Pull the "path" column from CacheResourceData
when loading cache items.
(WebCore::ApplicationCacheStorage::remove): Call checkForDeletedResources.
(WebCore::ApplicationCacheStorage::empty): Ditto.
(WebCore::ApplicationCacheStorage::storeCopyOfCache): Ditto.
(WebCore::ApplicationCacheStorage::deleteCacheGroup): Ditto.
(WebCore::ApplicationCacheStorage::checkForDeletedResources): Walk through DeletedCacheResourceData
looking for entries with non-empty "path" columns; if found, delete.
(WebCore::ApplicationCacheStorage::flatFileAreaSize): Walk through CacheResourceData rows
and sum the file size of those rows with flat file storage.
(WebCore::ApplicationCacheStorage::verifySchemaVersion): Call deleteTables() instead of
clearAllTables() directly.
(WebCore::ApplicationCacheStorage::deleteTables): Call empty() before deleting the tables,
so that flat files get deleted.
(WebCore::ApplicationCacheStorage::shouldStoreResourceAsFlatFile): Added.
(WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory): Added.
* loader/appcache/ApplicationCacheStorage.h:
* platform/win/FileSystemWin.cpp:
(WebCore::openFile): Implement openFile on Windows.
2011-03-24 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=56909
Add a simplified normal flow layout path optimization for overflow recomputation
and for positioned objects inside relative positioned containers.
Currently there is an optimized code path for positioned objects, but as soon as
we encounter a normal flow object in the containing block chain, we lose the
optimization.
This patch adds a new type of style difference called SimplifiedLayout that is
returned when only overflow needs to be recomputed. Whenever a transform changes,
this is the hint returned now instead of a full layout.
In addition, when positioned objects need layout and start marking up the
containing block chain, we now propagate the fact that the layout is simplified
all the way up to the root, even when we encounter normal flow containing
blocks.
The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout()
and is now used for all of these cases (in addition to what it handled before).
The simplified layout optimization (even in ToT) did not work correctly when
static distances needed to be recomputed. In order to make static distance
computations work with simplified layout, positioned objects now always compute
their static offsets, even if they explicitly specify left/top. That way normal
flow layout never has to re-run when the positioned object moves. This makes
movement of a positioned object along a single non-auto axis much faster when the
other axis is auto. Because this code kicked in more often for absolutely positioned
objects whose original display was inline, I went ahead and fixed the trailing space
issue with those objects. This causes a bunch of layout tests to progress.
Added fast/block/positioning/static-inline-position-dynamic.html and trailing-space-test.html.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::simplifiedLayout):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::setStaticPositions):
(WebCore::RenderBlock::findNextLineBreak):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::positionLineBox):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleWillChange):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::adjustStyleDifference):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::styleDidChange):
* rendering/RenderObject.h:
(WebCore::RenderObject::needsLayout):
(WebCore::RenderObject::needsPositionedMovementLayoutOnly):
(WebCore::RenderObject::needsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::markContainingBlocksForLayout):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyleConstants.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
2011-03-25 Martin Robinson <mrobinson@igalia.com>
Fix the GTK+ build until we can implement the new cross-platform
FontPlatformData.h bits.
* platform/graphics/FontPlatformData.h: Include the proper old font headers.
(WebCore::FontPlatformData::FontPlatformData): Eliminate GTK+ specific bits of this file
which reference our obsolete font implementation.
(WebCore::FontPlatformData::hash): Ditto.
2011-03-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Brian Weinstein.
Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll
https://bugs.webkit.org/show_bug.cgi?id=57119
<rdar://problem/9054148>
This plug-in from Microsoft links against xpcom.dll, which is a Firefox-specific DLL
not available in WebKit. The plug-in is fairly widespread, since it was included in
a Windows Update push at one point.
* plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackage::isPluginBlacklisted): Blacklist npwpf.dll.
2011-03-25 Tony Chang <tony@chromium.org>
Try to fix the chromium mac build.
We used the mac FontPlatformData on chromium mac.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/graphics/FontPlatformData.h:
2011-03-25 Tony Chang <tony@chromium.org>
Build fix:
have chromium and qt use the correct FontPlatformData.h
https://bugs.webkit.org/show_bug.cgi?id=57115
* platform/graphics/FontPlatformData.h:
2011-03-25 Beth Dakin <bdakin@apple.com>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=57057 Overlay scrollbars in overflow
areas paint behind positive z-index content
-and corresponding-
<rdar://problem/9070500>
Since overlay scrollbars don't clip the scrollable content like other scrollbars do,
the only way to get them to paint on top of all possible scrollable content is to
make them paint on top of everything. To do this, this patch adds a second trip
through the layer tree if it contains overlay scrollbars that need painting.
After calling paint() on the rootLayer, call paintOverlayScrollers() if
containsDirtyOverlayScrollbars() is true.
* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
RenderLayer has two new member variable. m_containsDirtyOverlayScrollbars is a bool
that is set on the root layer when it has child layers that need overlay scrollbars
to be painted. m_cachedOverlayScrollbarOffset is an IntPoint to cache the tx and ty
of the overlay scrollbars on the first (normal) pass through the layer tree. This
prevents us from having to re-enter the render tree during the second (overlay-only)
pass. Finally, there is also a new paint flag: PaintLayerPaintingOverlayScrollbars.
* rendering/RenderLayer.h:
(WebCore::RenderLayer::containsDirtyOverlayScrollbars):
(WebCore::RenderLayer::setContainsDirtyOverlayScrollbars):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintOverlayScrollbars):
(WebCore::RenderLayer::paintLayer):
2011-03-25 Jessie Berlin <jberlin@apple.com>
Reviewed by Sam Weinig.
WebKit2: Need to be able to set and get the Cookie Storage Policy.
https://bugs.webkit.org/show_bug.cgi?id=50780
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::privateCookieStorage):
Rename privateBrowsingCookieStorage to privateCookieStorage.
(WebCore::currentCookieStorage):
Ditto.
(WebCore::setCurrentCookieStorage):
Ditto.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
Ditto.
(WebCore::defaultCookieStorage):
Return the default cookie storage.
(WebCore::privateBrowsingCookieStorage):
Return privateCookieStorage().get()
* platform/network/cf/CookieStorageCFNet.h:
2011-03-25 Emil A Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
Text field "onchange" event is triggered if actual value unchanged
https://bugs.webkit.org/show_bug.cgi?id=36314
Change RenderTextControl::subtreeHasChanged to only return true if the
subtree has changed since the last event was triggered.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::insertedIntoDocument):
(WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
* html/HTMLFormControlElement.h:
(WebCore::HTMLTextFormControlElement::setTextAsOfLastFormControlChangeEvent):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::setValue):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setValue):
(WebCore::HTMLTextAreaElement::setNonDirtyValue):
2011-03-25 Brent Fulgham <bfulgham@webkit.org>
Reviewed by David Hyatt.
Clean up FontPlatformData structure so that a single implementation
is used across all ports. This first patch works for the Windows
build (both CG and WinCairo), and Cocoa.
* WebCore.vcproj/WebCore.vcproj:
* platform/graphics/FontPlatformData.cpp: Added.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
* platform/graphics/FontPlatformData.h: Added.
(WebCore::toCTFontRef):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::useGDI):
(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::cgFont):
(WebCore::FontPlatformData::size):
(WebCore::FontPlatformData::setSize):
(WebCore::FontPlatformData::syntheticBold):
(WebCore::FontPlatformData::syntheticOblique):
(WebCore::FontPlatformData::isColorBitmapFont):
(WebCore::FontPlatformData::orientation):
(WebCore::FontPlatformData::textOrientation):
(WebCore::FontPlatformData::widthVariant):
(WebCore::FontPlatformData::setOrientation):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::fontFace):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hashTableDeletedFontValue):
* platform/graphics/cg/FontPlatformData.h: Removed.
* platform/graphics/cocoa/FontPlatformData.h: Removed.
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::~FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
* platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
* platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/win/cairo/FontPlatformData.h: Removed.
2011-03-25 Enrica Casucci <enrica@apple.com>
Reviewed by Oliver Hunt.
Pasteboard data's RTF data doesn't always include URLs via NSLinkAttributeName.
https://bugs.webkit.org/show_bug.cgi?id=57107
<rdar://problem/9084267>
If the selection is at the beginning of content inside an anchor tag
we move the selection start to include the anchor.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection): Modified to change the selection
start according to the new rule.
2011-03-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: refactor Network domain's frame tree API
https://bugs.webkit.org/show_bug.cgi?id=57103
* inspector/Inspector.json:
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForFrameResource):
(WebCore::buildObjectForCachedResource):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::buildObjectForFrame):
(WebCore::buildObjectForFrameTree):
(WebCore::InspectorResourceAgent::didCommitLoad):
(WebCore::InspectorResourceAgent::enable):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype.willSendRequest):
(WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
(WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.frameDetachedFromParent):
(WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame):
(WebInspector.NetworkDispatcher.prototype.didCreateWebSocket):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._addFramesRecursively):
(WebInspector.NetworkDispatcher.prototype._createResource):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame):
(WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
(WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
(WebInspector.ResourceTreeModel.prototype._clearResources):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.addOrUpdateFrame):
(WebInspector.ResourcesPanel.prototype.addResourceToFrame):
2011-03-25 Dave Hyatt <hyatt@apple.com>
Reviewed by Adele Peterson.
REGRESSION(r77257): Only first page of a document is printed
https://bugs.webkit.org/show_bug.cgi?id=56958
Test: printing/page-count-layout-overflow.html
* page/FrameView.cpp:
(WebCore::FrameView::forceLayoutForPagination): Moved clearing of overflow
to the right place.
2011-03-25 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087
Use explicit conversion for string to avoid depending on the default codec
installed by the user code.
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapToDataUrlMethod::invoke):
(JSC::Bindings::QtPixmapInstance::valueOf):
* platform/qt/LanguageQt.cpp:
(WebCore::platformDefaultLanguage):
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeSelection):
* plugins/qt/PluginPackageQt.cpp:
(WebCore::initializeGtk):
* plugins/qt/PluginViewQt.cpp:
(WebCore::getPluginDisplay):
2011-03-25 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
rename Node::isContentEditable and all call sites to rendererIsEditable
https://bugs.webkit.org/show_bug.cgi?id=54290
This is part of the effort to separate JS API HTMLElement isContentEditable from
internal Node::rendererIsEditable.
Code refactoring. No new tests.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isReadOnly):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
* dom/Document.cpp:
(WebCore::acceptsEditingFocus):
* dom/Node.cpp:
(WebCore::Node::rendererIsEditable):
(WebCore::Node::shouldUseInputMethod):
(WebCore::Node::canStartSelection):
(WebCore::Node::rootEditableElement):
* dom/Node.h:
(WebCore::Node::isContentEditable):
(WebCore::Node::rendererIsEditable):
(WebCore::Node::rendererIsRichlyEditable):
* dom/Position.cpp:
(WebCore::nextRenderedEditable):
(WebCore::previousRenderedEditable):
(WebCore::Position::atEditingBoundary):
(WebCore::Position::parentEditingBoundary):
(WebCore::Position::upstream):
(WebCore::Position::downstream):
(WebCore::Position::isCandidate):
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
* editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::AppendNodeCommand):
(WebCore::AppendNodeCommand::doApply):
(WebCore::AppendNodeCommand::doUnapply):
* editing/ApplyStyleCommand.cpp:
(WebCore::containsNonEditableRegion):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
* editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
(WebCore::enclosingDeletableElement):
* editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeNode):
* editing/Editor.cpp:
(WebCore::Editor::canDeleteRange):
(WebCore::Editor::markMisspellingsOrBadGrammar):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
* editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
* editing/FormatBlockCommand.cpp:
(WebCore::enclosingBlockToSplitTreeTo):
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::outdentParagraph):
* editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):
* editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):
* editing/JoinTextNodesCommand.cpp:
(WebCore::JoinTextNodesCommand::doApply):
(WebCore::JoinTextNodesCommand::doUnapply):
* editing/MergeIdenticalElementsCommand.cpp:
(WebCore::MergeIdenticalElementsCommand::doApply):
(WebCore::MergeIdenticalElementsCommand::doUnapply):
* editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::doApply):
(WebCore::RemoveNodeCommand::doUnapply):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
* editing/SelectionController.cpp:
(WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
(WebCore::SelectionController::setSelectionFromNone):
* editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::executeApply):
(WebCore::SplitElementCommand::doUnapply):
* editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doApply):
(WebCore::SplitTextNodeCommand::doUnapply):
(WebCore::SplitTextNodeCommand::doReapply):
* editing/SplitTextNodeContainingElementCommand.cpp:
(WebCore::SplitTextNodeContainingElementCommand::doApply):
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::canonicalPosition):
* editing/WrapContentsInDummySpanCommand.cpp:
(WebCore::WrapContentsInDummySpanCommand::doUnapply):
(WebCore::WrapContentsInDummySpanCommand::doReapply):
* editing/htmlediting.cpp:
(WebCore::highestEditableRoot):
(WebCore::lowestEditableAncestor):
(WebCore::isEditablePosition):
(WebCore::isRichlyEditablePosition):
(WebCore::firstEditablePositionAfterPositionInRoot):
(WebCore::extendRangeToWrappingNodes):
(WebCore::enclosingNodeWithTag):
(WebCore::enclosingNodeOfType):
(WebCore::highestEnclosingNodeOfType):
(WebCore::canMergeLists):
* editing/visible_units.cpp:
(WebCore::previousLeafWithSameEditability):
(WebCore::previousLinePosition):
(WebCore::nextLeafWithSameEditability):
(WebCore::nextLinePosition):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::supportsFocus):
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::setActive):
(WebCore::HTMLAnchorElement::canStartSelection):
(WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::supportsFocus):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::supportsFocus):
(WebCore::HTMLElement::isContentEditable):
(WebCore::HTMLElement::contentEditable):
* html/HTMLElement.h:
* page/DragController.cpp:
(WebCore::DragController::operationForLoad):
(WebCore::DragController::canProcessDrag):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::selectCursor):
* page/FocusController.cpp:
(WebCore::relinquishesEditingFocus):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isContentEditable):
* rendering/RenderBlock.cpp:
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::hasLineIfEmpty):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::addOverflowFromInlineChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::canBeProgramaticallyScrolled):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createVisiblePosition):
* rendering/RootInlineBox.cpp:
(WebCore::isEditableLeaf):
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::supportsFocus):
2011-03-25 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
Crash when a wbr element is inserted inside mroot
https://bugs.webkit.org/show_bug.cgi?id=56352
Test: mathml/wbr-in-mroot-crash.html
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::layout): Look for the first box model child of the first
child, instead of just assuming.
2011-03-25 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
XML Viewer: extensions can't render original XML
https://bugs.webkit.org/show_bug.cgi?id=56263
Added source xml to transformed document, renamed onload function.
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
* xml/XMLViewer.xsl:
2011-03-25 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] Get rid of the invalid string conversion with ::fromAscii()
https://bugs.webkit.org/show_bug.cgi?id=57102
Replace ::fromAscii() with ::fromLatin1() to make sure the codec does not depend on the user code.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
* platform/qt/CookieJarQt.cpp:
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
2011-03-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81953.
http://trac.webkit.org/changeset/81953
https://bugs.webkit.org/show_bug.cgi?id=57096
"inspector test breakage: part 2/2" (Requested by apavlov on
#webkit).
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getAllStyles):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
(WebInspector.CSSStyleModel.prototype._onRevert):
(WebInspector.CSSStyleSheet):
(WebInspector.CSSStyleSheet.prototype.setText):
2011-03-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
https://bugs.webkit.org/show_bug.cgi?id=56310
Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
"styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
by CSSAgent.getStyleSheet() anymore.
Test: inspector/styles/get-set-stylesheet-text.html
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getAllStyleSheets):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
(WebInspector.CSSStyleModel.prototype._onRevert):
(WebInspector.CSSStyleSheet):
(WebInspector.CSSStyleSheet.prototype.setText):
2011-03-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extension server should not convert all resources to HAR when there are no extensions.
https://bugs.webkit.org/show_bug.cgi?id=57044
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._notifyResourceFinished):
(WebInspector.ExtensionServer.prototype._hasSubscribers):
2011-03-25 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
SVG <use> element performance improvement
https://bugs.webkit.org/show_bug.cgi?id=57077
SVG <use> element was expanding nesting <use> and <symbol> elements
in an inefficient way. After it expanded an <use> or a <symbol>
element it would restart expanding from the shadow tree root.
This behavior was leading about 160 millions of calls to
expandUseElementInShadowTree or expandSymbolElementInShadowTree for
a single shadow tree which is illustrated by
http://upload.wikimedia.org/wikipedia/commons/4/4e/Sierpinski_carpet_6.svg.
But the effective calls, which really expand <use> or <symbol>
elements, were about 5200; others were passing-by calls, which are
recursively down to the children.
This patch is altering the expanding path to reduce the passing-by
calls. It will expand elements in sibling chain where there is an
effective call, because the effective call replaces element which is
expanded and the replacement results lose of the sibling chain of
the replaced on the upper recursion stack. With this patch the
passing-by calls are reduced from about 160 millions to about 30
thousands.
No functionality change, no new tests.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
* svg/SVGUseElement.h:
2011-03-25 Dominic Cooney <dominicc@google.com>
Reviewed by Kent Tamura.
Makes keygen support autofocus attribute.
https://bugs.webkit.org/show_bug.cgi?id=57091
Test: fast/forms/autofocus-keygen.html
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::attach):
2011-03-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Add sound / mute button to MediaControl UI
https://bugs.webkit.org/show_bug.cgi?id=56726
Add sound / mute button to MediaControl UI.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::edjeGroupFromFormType):
(WebCore::RenderThemeEfl::emitMediaButtonSignal):
(WebCore::RenderThemeEfl::paintMediaMuteButton):
* platform/efl/RenderThemeEfl.h:
2011-03-24 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Darin Adler.
Introduce WTF HexNumber.h
https://bugs.webkit.org/show_bug.cgi?id=56099
Introduce a set of functions that ease converting from a bye or a number to a hex string,
replacing several of these conversions and String::format("%x") usages all over WebCore.
* ForwardingHeaders/wtf/HexNumber.h: Added.
* css/CSSOMUtils.cpp:
(WebCore::serializeCharacterAsCodePoint):
* css/CSSParser.cpp:
(WebCore::quoteCSSString):
* inspector/InspectorResourceAgent.cpp:
(WebCore::createReadableStringFromBinary):
* platform/FileSystem.cpp:
(WebCore::encodeForFileName):
* platform/KURL.cpp:
(WebCore::appendEscapedChar):
* platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
* platform/graphics/Color.cpp:
(WebCore::Color::serialized):
* platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::encodeStringAsFormData):
* rendering/RenderTreeAsText.cpp:
(WebCore::quoteAndEscapeNonPrintables):
2011-03-24 Stephanie Lewis <slewis@apple.com>
Reviewed by Geoff Garen.
<rdar://problem/9146716> REGRESSION: ~10 MB increase in memory under CachedScripts
Add back a call to destroy decoded data after access. Keep the SourceProviderCache
around as long as their are still clients to use it.
No new tests because there is no change in behavior. Current tests pass.
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::script):
(WebCore::CachedScript::destroyDecodedData):
2011-03-24 Stephanie Lewis <slewis@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=57073
Rework the AtomicHTMLConstructor to reserve space for attributes based on the size of the attribute list.
Saves 1.5 MB on Membuster.
No new tests because there was no change in behavior. Current tests pass.
* html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):
2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071
broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::HTMLEmbedElement):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::HTMLObjectElement):
(WebCore::HTMLObjectElement::parametersForPlugin):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::isImageType):
(WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
* html/HTMLPlugInImageElement.h:
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::objectContentType):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::defaultObjectContentType):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::resourceWillUsePlugin):
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::shouldUsePlugin):
* loader/SubframeLoader.h:
2011-03-24 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Eliminate Node::dispatchGenericEvent.
https://bugs.webkit.org/show_bug.cgi?id=57045
No functional change, covered by existing tests.
* dom/Node.cpp:
(WebCore::Node::dispatchEvent): Combined with the body of dispatchGenericEvent,
removed unnecessary extra refs and a stale comment.
* dom/Node.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchLoadEvent): Changed to use dispatchEvent.
* svg/SVGElement.cpp:
(WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::dispatchEvent): Ditto. The code here still
works thanks to SVG-aware retargeting in Node.
2011-03-24 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
web audio: Properly sample-rate convert audio assets in chromium port
https://bugs.webkit.org/show_bug.cgi?id=56980
No new tests since audio API is not yet implemented.
* WebCore.gypi:
* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):
* platform/audio/AudioBus.h:
* platform/audio/HRTFKernel.cpp:
(WebCore::extractAverageGroupDelay):
(WebCore::HRTFKernel::HRTFKernel):
* platform/audio/SincResampler.cpp:
* platform/audio/chromium/AudioBusChromium.cpp:
(WebCore::AudioBus::loadPlatformResource):
(WebCore::createBusFromInMemoryAudioFile):
2011-03-24 Rik Cabanier <cabanier@adobe.com>
Reviewed by David Hyatt.
REGRESSION (r81625): fast/css/percentage-non-integer.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=56829
Test: fast/css/percentage-non-integer.html
* platform/Length.h:
(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
(WebCore::Length::calcFloatValue):
2011-03-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
[Chromium] Vertical Japanese text is not displayed on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=56962
Make Snow Leopard check added by r80740 into a runtime check for
Chromium, since it uses the same binary on both Leopard and Snow Leopard.
* platform/graphics/mac/FontMac.mm:
(WebCore::hasBrokenCTFontGetVerticalTranslationsForGlyphs):
(WebCore::showGlyphsWithAdvances):
2011-03-24 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=57058
Hookup the UIProcess WebIconDatabase to a WebCore::IconDatabase as its implementation
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousLoadDecisionForIconURL): Only add the DocumentLoader to the set if it's non-zero.
(WebCore::IconDatabase::IconDatabase): Add more logging.
(WebCore::IconDatabase::performURLImport): Dispatch the "didFinishURLImport" client callback using the following 3 methods.
(WebCore::FinishedURLImport::FinishedURLImport):
(WebCore::FinishedURLImport::performWork):
(WebCore::IconDatabase::dispatchDidFinishURLImportOnMainThread):
* loader/icon/IconDatabase.h:
(WebCore::IconDatabase::create): Expose a PassOwnPtr<> creator.
* WebCore.exp.in:
2011-03-23 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Application Cache should save audio/ and video/ mime types as flat files
https://bugs.webkit.org/show_bug.cgi?id=53784
<rdar://problem/8932473>
No new tests.
ApplicationCacheResource::create() now takes an additional "path" parameter. To facilitate
extracting this path information, two functions in ApplicationCacheHost have been made public.
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveResponse): Pass along new "path" parameter.
(WebCore::ApplicationCacheGroup::didFail): Ditto.
* loader/appcache/ApplicationCacheHost.h:
(WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache): Made public.
(WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource): Made public.
* loader/appcache/ApplicationCacheResource.cpp:
(WebCore::ApplicationCacheResource::ApplicationCacheResource): Add new "path" parameter.
* loader/appcache/ApplicationCacheResource.h:
(WebCore::ApplicationCacheResource::create): Ditto.
(WebCore::ApplicationCacheResource::path): New accessor.
2011-03-24 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016
AC_QuickTime.js uses the common <object>/<embed> paradigm to embed the
QuickTime plug-in in web pages. r70748 removed our mapping of classids
to MIME types, which causes WebKit to fall back from the object to the
embed tag when QuickTime is embedded by this script. The script emits
the following embed tag to embed a QuickTime movie with a poster frame:
<embed src="poster-frame.png" target="quicktimeplayer" href="movie.mov">
The expectation is that a QuickTime plug-in is instantiated to display the
poster frame, since QuickTime registers for many common image MIME
types. This is how Gecko behaves for embed. However, WebKit prefers to
use its native image rendering for image embeds, in which case no movie
is played when the poster frame is clicked.
Fix this by changing embed to check for a plug-in that can handle the
image type before rendering the image natively. This matches Gecko.
Test: fast/images/embed-image-plugins-disabled.html
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::isImageType):
(WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
* html/HTMLPlugInImageElement.h:
(WebCore::HTMLPlugInImageElement::preferPluginsForImages):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::objectContentType):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::defaultObjectContentType):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::resourceWillUsePlugin):
(WebCore::SubframeLoader::requestPlugin):
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::shouldUsePlugin):
* loader/SubframeLoader.h:
2011-03-24 Mike Reed <reed@google.com>
Reviewed by James Robinson.
Move lifetime management of grContext from a global to being
per-SharedGraphicsContext3D, which correctly is 1:1 with the
underlying opengl context.
https://bugs.webkit.org/show_bug.cgi?id=54330
No new tests. Existing <canvas> tests exercise this:
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::setGrContext):
* platform/graphics/gpu/DrawingBuffer.h:
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
(WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
(WebCore::SharedGraphicsContext3D::getGrContext):
* platform/graphics/gpu/SharedGraphicsContext3D.h:
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::~PlatformContextSkia):
(WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2011-03-24 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Untangle dependency between event ancestor chain computation and InspectorDOMAgent.
https://bugs.webkit.org/show_bug.cgi?id=57050
Inspector's list of event listeners does not need to invoke Node::getEventListeners,
because it simply wants to collect all ancestors and never uses EventContext bits.
No functional change, covered by existing tests.
* dom/Node.cpp:
(WebCore::getEventAncestors): Converted into a static function.
(WebCore::Node::dispatchGenericEvent): Changed to pass node to getEventAncestors.
* dom/Node.h: Removed decl, moved EventDispatchBehavior enum inside.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getEventListenersForNode): Replaced the call
to getEventAncestors with a simple ancestor traversal loop.
2011-03-24 Adam Klein <adamk@chromium.org>
Reviewed by David Levin.
[fileapi] Make FileError and FileException accessible from WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=57041
* workers/WorkerContext.idl:
2011-03-24 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove legacy version of findPlainText.
https://bugs.webkit.org/show_bug.cgi?id=57056
* editing/TextIterator.cpp:
* editing/TextIterator.h:
Remove legacy overload of findPlainText that doesn't
take an options parameter.
2011-03-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Ensure that all compilation takes place within a dynamic global object scope
https://bugs.webkit.org/show_bug.cgi?id=57054
* bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent): Updated for signature change.
2011-03-24 John Bauman <jbauman@chromium.org>
Reviewed by Kenneth Russell.
preserveDrawingBuffer=true is ignored
https://bugs.webkit.org/show_bug.cgi?id=56987
Add code to the V8 and JSC bindings to support grabbing the value of
preserveDrawingBuffer from the input context attributes. Also, in
WebGLRenderingContext use the WebGLContextAttributes that were input
directly, not those from the GraphicsContext3D which could have been
changed.
No new tests, as this can't be tested with DRT. However, this works
when tested manually.
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
2011-03-24 Enrica Casucci <enrica@apple.com>
Reviewed by Alexey Proskuryakov.
WebKit2:Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
https://bugs.webkit.org/show_bug.cgi?id=56975
<rdar://problem/8915066>
Adding support in WebCore to implement readSelectionFromPasteboard
to support Mac OS X services from WebKit2.
* WebCore.exp.in:
* editing/Editor.h:
* editing/mac/EditorMac.mm:
(WebCore::Editor::readSelectionFromPasteboard): Added entry point
to call the paste functions with the specified pasteboard.
2011-03-24 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Inspector does not show correct transfer size for synchronous requests
https://bugs.webkit.org/show_bug.cgi?id=56951
Fixed transfer size for synchronous load.
Test: http/tests/inspector/network/network-size-sync.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::willLoadMediaElementURL):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::loadResourceSynchronously):
(WebCore::FrameLoader::loadedResourceFromMemoryCache):
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
* loader/ResourceLoadNotifier.h:
2011-03-24 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=57030
REGRESSION (r81782): http/tests/inspector/extensions-resources-redirect.html sometimes crashes WebKit2's
web process while handling a WebIconDatabaseProxy::ReceivedIconLoadDecision message
The callback objects had some bogus ASSERTs and missed a relevant null check. If a callback was waiting on
a message back from the UIProcess, but was invalidated from within the WebProcess in the meantime, it's
perfectly valid to attempt to performCallback() after the callback function pointer has been cleared.
* loader/icon/IconDatabaseBase.h:
(WebCore::EnumCallback::performCallback):
(WebCore::EnumCallback::invalidate):
(WebCore::EnumCallback::EnumCallback):
(WebCore::ObjectCallback::performCallback):
(WebCore::ObjectCallback::invalidate):
(WebCore::ObjectCallback::ObjectCallback):
2011-03-24 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Dictionary text extraction is not correctly detecting word boundaries on bing.com
<rdar://problem/9078569>
https://bugs.webkit.org/show_bug.cgi?id=56995
* WebCore.exp.in:
Add some editing related exports needed by WebKit2.
2011-03-24 Andy Estes <aestes@apple.com>
Reviewed by Eric Seidel.
REGRESSION (r80231): Bad cast in HTMLTreeBuilder with closed </form> tags
https://bugs.webkit.org/show_bug.cgi?id=56836
During fragment parsing, HTMLConstructionSite holds a reference to the
fragment context's closest form ancestor. If a misnested form end tag is
then encountered as the first node of the fragment, we will check to see
if a corresponding form start tag is in scope even though no such tag
exists. This led to isScope() walking the HTMLElementStack all the way
to the root DocumentFragment and attempting to cast it to Element*.
Fix this by ensuring that the inScope() family of functions operate in
terms of ContainerNodes to account for the fragment case.
Test: fast/parser/fragment-closest-form-ancestor.html
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
(WebCore::HTMLNames::isTableBodyScopeMarker):
(WebCore::HTMLNames::isTableRowScopeMarker):
(WebCore::HTMLElementStack::hasOnlyHTMLElementsInScope):
(WebCore::HTMLElementStack::inScope):
2011-03-24 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
Repeated copy and paste-in-place operation results in increasingly verbose HTML.
<rdar://problem/8690506>
https://bugs.webkit.org/show_bug.cgi?id=56874
When we calculate the style to apply at the insertion point we compare the initial
style at the insertion point against the style calculated at the span we wrap the
copied markup fragment with. We could end up with a series of unnecessary spans
to remove the initial style that simply grow our markup.
The consists in moving the insertion point outside any inline element that could
affect the fragment being inserted when we are not pasting and matching the style.
Test: editing/pasteboard/paste-text-with-style.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::isInlineNodeWithStyle): Added.
(WebCore::ReplaceSelectionCommand::doApply): Added logic to change the insertion
point according to the new rules.
2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
https://bugs.webkit.org/show_bug.cgi?id=40884
The software fallback is now only needed for corner cases like a manual rendering
of the page to QImage.
Keeping the image with the last pixel values is no longer needed. Removing it reduce the
performance for real-time rendering on software surface, but this case should no longer be
supported.
The conversion from OpenGL color space and coordinates is done manually for performance. This
also fix the bug of the inverted X axis due to the transformation.
The tests and benchmarks are done through Qt API tests.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::swapBgrToRgb):
(WebCore::GraphicsContext3DInternal::paint):
(WebCore::GraphicsContext3D::reshape):
2011-03-24 Nat Duca <nduca@chromium.org>
Reviewed by James Robinson.
[chromium] Remove bool that forces compositor HUD to always be enabled
https://bugs.webkit.org/show_bug.cgi?id=57034
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore::CCHeadsUpDisplay::enabled):
2011-03-24 Nat Duca <nduca@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Add traceEvents to compositor
https://bugs.webkit.org/show_bug.cgi?id=56965
* WebCore.gypi:
* platform/chromium/TraceEvent.h: Added.
(WebCore::internal::ScopeTracer::ScopeTracer):
(WebCore::internal::ScopeTracer::~ScopeTracer):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateRootLayerContents):
(WebCore::LayerRendererChromium::updateRootLayerScrollbars):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::finish):
(WebCore::LayerRendererChromium::present):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::update):
2011-03-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: render XHRs matching JSON regex as JSON.
https://bugs.webkit.org/show_bug.cgi?id=57035
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
* inspector/front-end/RemoteObject.js:
(WebInspector.LocalJSONObject.prototype.get description.switch.case):
(WebInspector.LocalJSONObject.prototype.get description):
(WebInspector.LocalJSONObject.prototype._concatenate):
(WebInspector.LocalJSONObject.prototype.getProperties):
(WebInspector.LocalJSONObject.prototype._children):
* inspector/front-end/ResourceJSONView.js: Added.
(WebInspector.ResourceJSONView):
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype.hasContent):
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype.show):
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.resource-view.json):
* inspector/front-end/inspector.html:
2011-03-24 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Move media controls subtree creation into one method.
https://bugs.webkit.org/show_bug.cgi?id=56969
Mechanical move, no changes in functionality.
The purpose of this patch is to align existing code closer with its
future version, when MediaControls is an element whose tree is created
at the instantiation.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::create): Added, consolidating all subtree generation logic into one place.
(WebCore::MediaControls::update): Replaced methods with one call.
* html/shadow/MediaControls.h: Updated decls.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::create): Moved setting of attributes here.
(WebCore::MediaControlVolumeSliderElement::create): Ditto.
2011-03-24 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Use proper string method to generate webloc string.
https://bugs.webkit.org/show_bug.cgi?id=57028
<rdar://problem/9181955>
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getWebLocData):
2011-03-24 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=32821
Fix conditionals which had an int for one case and a pointer for another.
Fix is similar to https://bugs.webkit.org/show_bug.cgi?id=56198
No new tests. Fix compilation on Solaris 10 with SunStudio 12 C++
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
2011-03-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: provide live edit callback to source frame delegate.
https://bugs.webkit.org/show_bug.cgi?id=57003
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.editScriptSource):
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
Regression: WebKit does not build with Python 3 following 56807
https://bugs.webkit.org/show_bug.cgi?id=56923
The module string does not have the function replace in Python 3. The str.replace function
can do the same operation in this case and works with the versions 2 and 3.
* inspector/generate-inspector-idl:
2011-03-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: brush up Network agent API.
https://bugs.webkit.org/show_bug.cgi?id=57001
* inspector/Inspector.json:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willSendRequestImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willSendRequest):
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForResourceRequest):
(WebCore::buildObjectForResourceResponse):
(WebCore::buildObjectForCachedResource):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::setExtraHeaders):
* inspector/InspectorResourceAgent.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource):
(WebInspector.NetworkDispatcher.prototype.willSendRequest):
(WebInspector.NetworkDispatcher.prototype.didReceiveWebSocketHandshakeResponse):
(WebInspector.NetworkDispatcher.prototype.didCloseWebSocket):
* inspector/front-end/Resource.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
(WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):
2011-03-11 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JNIType is not specific to JNI so should be renamed
https://bugs.webkit.org/show_bug.cgi?id=56197
This patch renames JNIType to JavaType, renames the values of
the enum, and moves it out of JNIUtility.h to its own file.
Also renames the corresponding JavaField and JavaMethod getters.
No new tests, refactoring only.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bridge/jni/JNIUtility.cpp:
(JSC::Bindings::javaTypeFromClassName):
(JSC::Bindings::signatureFromJavaType):
(JSC::Bindings::javaTypeFromPrimitiveType):
(JSC::Bindings::getJNIField):
(JSC::Bindings::callJNIMethod):
* bridge/jni/JNIUtility.h:
* bridge/jni/JavaMethod.cpp:
(JavaMethod::JavaMethod):
(JavaMethod::signature):
* bridge/jni/JavaMethod.h:
(JSC::Bindings::JavaMethod::returnTypeClassName):
(JSC::Bindings::JavaMethod::returnType):
* bridge/jni/JavaType.h: Copied from Source/WebCore/bridge/jni/JavaMethod.h.
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::toString):
* bridge/jni/jni_objc.mm:
(JSC::Bindings::dispatchJNICall):
* bridge/jni/jsc/JNIUtilityPrivate.cpp:
(JSC::Bindings::convertArrayInstanceToJavaArray):
(JSC::Bindings::convertValueToJValue):
* bridge/jni/jsc/JNIUtilityPrivate.h:
* bridge/jni/jsc/JavaArrayJSC.cpp:
(JavaArray::setValueAt):
(JavaArray::valueAt):
* bridge/jni/jsc/JavaClassJSC.cpp:
* bridge/jni/jsc/JavaFieldJSC.cpp:
(JavaField::JavaField):
(JavaField::dispatchValueFromInstance):
(JavaField::valueFromInstance):
(JavaField::dispatchSetValueToInstance):
(JavaField::setValueToInstance):
* bridge/jni/jsc/JavaFieldJSC.h:
(JSC::Bindings::JavaField::typeClassName):
(JSC::Bindings::JavaField::type):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
* bridge/jni/v8/JNIUtilityPrivate.cpp:
(JSC::Bindings::convertNPVariantToJValue):
(JSC::Bindings::convertJValueToNPVariant):
* bridge/jni/v8/JNIUtilityPrivate.h:
* bridge/jni/v8/JavaFieldV8.cpp:
(JavaField::JavaField):
* bridge/jni/v8/JavaFieldV8.h:
(JSC::Bindings::JavaField::typeClassName):
(JSC::Bindings::JavaField::type):
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::invokeMethod):
(JavaInstance::getField):
* bridge/jni/v8/JavaNPObjectV8.cpp:
(JSC::Bindings::JavaNPObjectInvoke):
(JSC::Bindings::JavaNPObjectGetProperty):
2011-03-24 Ojan Vafai <ojan@chromium.org>
Was being a little braindead when I committed this.
Only simple selectors are allowed, but sibling selectors
are sibling selectors.
* css/CSSStyleSelector.cpp:
(WebCore::collectFeaturesFromList):
2011-03-23 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Spellcheck feature specific symbols should be defined.
https://bugs.webkit.org/show_bug.cgi?id=56818
* Introduced USE(UNIFIED_TEXT_CHECKING), USE(GRAMMAR_CHECKING) and USE(AUTOMATIC_TEXT_REPLACEMENT)
* Replaced a part of of BUILDING_ON_* conditionals with them.
Note that small amount of code path on Editor.cpp is now compiled under USE(GRAMMAR_CHECKING)
because these code path is already built under non-Mac ports and
Keeping them buildable for such platforms reduces the build breakage risk.
These path is guarded by Settings thus should never get reached.
No new tests. No behavioral change.
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* editing/Editor.cpp:
(WebCore::Editor::advanceToNextMisspelling):
(WebCore::Editor::isSelectionUngrammatical):
(WebCore::Editor::guessesForUngrammaticalSelection):
(WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markMisspellingsOrBadGrammar):
(WebCore::Editor::markBadGrammar):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::markMisspellingsAndBadGrammar):
* editing/Editor.h:
* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
(WebCore::TextCheckingHelper::isUngrammatical):
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
(WebCore::TextCheckingHelper::markAllBadGrammar):
* loader/EmptyClients.h:
* platform/text/TextCheckerClient.h:
* platform/text/TextChecking.h: Added.
2011-03-23 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Force to make validation bubble DIV position:absolute
https://bugs.webkit.org/show_bug.cgi?id=56901
Test: fast/forms/interactive-validation-crash-by-style-override.html
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree): Add position:absolute
because we need to move the validation message to a good position.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::addChild):
2011-03-23 Mike Lawther <mikelawther@chromium.org>
Reviewed by Ojan Vafai.
flex/bison tokens and grammar for CSS calc
https://bugs.webkit.org/show_bug.cgi?id=54412
Tests: css3/calc/calc-errors.html
css3/calc/minmax-errors.html
css3/calc/simple-calcs.html
css3/calc/simple-minmax.html
* css/CSSGrammar.y:
* css/CSSParserValues.cpp:
(WebCore::CSSParserValueList::insertValueAt):
(WebCore::CSSParserValueList::extend):
* css/CSSParserValues.h:
* css/tokenizer.flex:
2011-03-23 Adam Klein <adamk@chromium.org>
Reviewed by David Levin.
Fix resolveLocalFileSystemURL (and sync version) error codes to match the spec
https://bugs.webkit.org/show_bug.cgi?id=56961
See error code listing in the Files & Directories spec:
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#widl-LocalFileSystemSync-resolveLocalFileSystemSyncURL
Note that the spec currently only specifies errors for the sync
version; I've used the same codes for the async version.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::resolveLocalFileSystemURL):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::resolveLocalFileSystemURL):
(WebCore::WorkerContext::resolveLocalFileSystemSyncURL):
2011-03-23 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Hook up new AppKit autocorrection UI with WK2.
https://bugs.webkit.org/show_bug.cgi?id=56055
<rdar://problem/8947463>
This patch is to enable WK2 to utilize autocorrection UI on Mac OS X. It contains following
major changes:
1. All but one autocorrection related message is synchronous. Since dismissing autocorrection
panel can potentially cause editing to occur, a synchronous dismissCorrectionPanelSoon() function
is introduced to ensure all editing commands occur in correct order.
2. Additional condition variable is needed to implement dismissCorrectionPanelSoon().
To improve maintainability, CorrectionPanel class is introduced to manage the
internal state related to correction panel. This change is applied to both WK1 and WK2.
3. EditorClient::isShowingCorrectionPanel() has been removed. The original purpose is to allow
editor to know when to handle ESC key event. Now this is handled internally in AppKit, so
EditorClient::isShowingCorrectionPanel() isn't necessary anymore.
4. The Editor* argument in EditorClient::showCorrectionPanel() has been removed, since we can
access object via WebView or WKView.
* editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::correctionPanelTimerFired):
(WebCore::Editor::dismissCorrectionPanel):
(WebCore::Editor::dismissCorrectionPanelSoon):
(WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
* editing/Editor.h:
* editing/EditorCommand.cpp:
(WebCore::createCommandMap):
* loader/EmptyClients.h:
(WebCore::EmptyEditorClient::showCorrectionPanel):
(WebCore::EmptyEditorClient::dismissCorrectionPanelSoon):
* manual-tests/autocorrection/close-window-when-correction-is-shown.html: Added.
* page/EditorClient.h:
2011-03-22 Ojan Vafai <ojan@chromium.org>
Reviewed by Antti Koivisto.
move :not over to using selectorList instead of simpleSelector
https://bugs.webkit.org/show_bug.cgi?id=56894
Saves memory and simplifies code.
No new tests since existing tests cover this code.
* css/CSSGrammar.y:
Also removed extranenous calls to updateLastSelectorLineAndPosition in
simple_selector_list. These happened to work, but are only actually
needed in selector_list.
* css/CSSParserValues.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::specificityForOneSelector):
Removed null-check. The parser null-checks, I don't see why we need to here.
(WebCore::CSSSelector::selectorText):
Ditto.
(WebCore::CSSSelector::setArgument):
(WebCore::CSSSelector::isSimple):
* css/CSSSelector.h:
* css/CSSSelectorList.cpp:
(WebCore::forEachTagSelector):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::collectFeaturesFromSelector):
(WebCore::collectFeaturesFromList):
2011-03-23 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
Made sure that renderers displaying counters are invalidated upon
counter destruction.
Assertion and incorrect rendering of counters.
https://bugs.webkit.org/show_bug.cgi?id=56896
Test: fast/css/counters/2displays.html
* rendering/CounterNode.cpp:
(WebCore::CounterNode::~CounterNode):
Added to make sure that its display renderers are always reset when
the node is deleted.
(WebCore::CounterNode::resetRenderers):
Fixed bug that would prevent reset of second and subsequent
display renderers.
* rendering/CounterNode.h:
* rendering/RenderCounter.cpp:
(WebCore::destroyCounterNodeWithoutMapRemoval):
removed unnecessary calls to resetRenderers() as the CounterNode
destructor takes care of that now.
2011-03-23 Brian Weinstein <bweinstein@apple.com>
Reviewed by Maciej Stachowiak.
WebKit2: Need API to manage the Media Cache
https://bugs.webkit.org/show_bug.cgi?id=56878
<rdar://problem/9082503>
Add functions that need to be exported.
* WebCore.exp.in:
2011-03-23 Robert Kroeger <rjkroege@chromium.org>
Reviewed by James Robinson.
Correct use of ENABLE() Macro
In http://trac.webkit.org/changeset/81618, I mis-used the ENABLE()
macro. This patch corrects.
https://bugs.webkit.org/show_bug.cgi?id=56964
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleTouchEvent):
* page/EventHandler.h:
2011-03-23 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
Scrubbing <video> with HTTP Live Stream resizes element to 0x0
https://bugs.webkit.org/show_bug.cgi?id=55702
QTKit will occasionally set the natural size of a QTMovie to 0x0 while scrubbing
an HTTP Live Stream. So we will cache the last valid value returned by QTKit
and use that as our naturalSize until a new valid value is returned.
Unfortunately, QTKit will also fail to generate a notification when the natural size
changes, so we are forced to cache the natural size from within naturalSize(), which
is a const function, necessitating a const_cast to set m_cachedNaturalSize.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h: Added m_cachedNaturalSize.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_cachedNaturalSize.
(WebCore::MediaPlayerPrivateQTKit::naturalSize):
2011-03-23 Alexey Proskuryakov <ap@apple.com>
Build fix.
* loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
Removed a stray parenthesis.
2011-03-23 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION: Infinite recursion in recursiveCheckLoadComplete()/checkLoadCompleteForThisFrame()/stopLoading()
https://bugs.webkit.org/show_bug.cgi?id=56978
<rdar://problem/9041670>
No new tests, because there is no known way to reproduce.
Removed strange code that was trying to stop a non-loading provisional document loader and
even its subframes (?!). Added assertions to catch it if we can actually be loading here in
some sense.
Rewrote a condition for clarity - starting with r43148, it was acting as an opposite of a
recursion guard (but that didn't cause immediate problems then).
* loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2011-03-23 Brady Eidson <beidson@apple.com>
Attempt to fix the build for platforms that have the icon database
disabled but still provide settings API for it...?
* loader/icon/IconDatabase.h:
(WebCore::IconDatabase::defaultDatabaseFilename):
2011-03-23 Mark Rowe <mrowe@apple.com>
Fix the build.
* WebCore.exp.in: Export the new version of IconDatabase::open.
2011-03-23 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Change IconDatabase opening to allow for arbitrary filenames
https://bugs.webkit.org/show_bug.cgi?id=56977
* WebCore.exp.in:
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::open):
* loader/icon/IconDatabase.h:
* loader/icon/IconDatabaseBase.cpp:
(WebCore::IconDatabaseBase::open):
* loader/icon/IconDatabaseBase.h:
* loader/icon/IconDatabaseClient.h:
2011-03-23 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
[chromium] WebGLRenderingContext and other DOMWindow properties should remain if WebGL is disabled
https://bugs.webkit.org/show_bug.cgi?id=56947
Removed the RuntimeEnabledFeatures setting for WebGL and the
EnabledAtRuntime extended attribute from the WebGL-related
properties on the DOMWindow. WebGL support is now controlled
exclusively through the page's Settings.
No new tests; tested manually in Chromium with --disable-webgl
command line argument and blacklist.
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
* page/DOMWindow.idl:
2011-03-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81802.
http://trac.webkit.org/changeset/81802
https://bugs.webkit.org/show_bug.cgi?id=56963
Broke a layout test, and this fix is not trivial. (Requested
by dhyatt on #webkit).
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutOnlyPositionedObjects):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleWillChange):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::adjustStyleDifference):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::styleDidChange):
* rendering/RenderObject.h:
(WebCore::RenderObject::needsLayout):
(WebCore::RenderObject::needsPositionedMovementLayoutOnly):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
(WebCore::RenderObject::markContainingBlocksForLayout):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyleConstants.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
2011-03-23 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by David Hyatt.
REGRESSION(81035): crash in RenderDetails::removeChild
https://bugs.webkit.org/show_bug.cgi?id=56773
Test: fast/html/details-children-merge-crash.html
Preventing merging of RenderDetails's anonymous children.
* rendering/RenderBlock.cpp:
(WebCore::canMergeContiguousAnonymousBlocks):
Fixing RenderDetails::removeChild and cleaning m_marker in RenderDetails::destroy.
* rendering/RenderDetails.cpp:
(WebCore::RenderDetails::destroy):
(WebCore::RenderDetails::removeChild):
2011-03-23 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Preserve unicode-bidi:bidi-override in anonymous block.
https://bugs.webkit.org/show_bug.cgi?id=21440
unicode-bidi:bidi-override should be preserved in anonymous block
according to http://www.w3.org/TR/CSS21/visuren.html#propdef-unicode-bidi.
Introduce a helper function RenderStyle()::createAnonymousStyle() which
creates a default RenderStyle, inherits the inherited style from parent,
and inherit unicode-bidi:bidi-override from parent.
And replace the style creation when anonymous block is created.
Note: the TABLE releated anonymous blocks are untouched, including:
TABLE, TABLE_CELL, TABLE_ROW, TABLE_ROW_GROUP anonymous blocks created in
RenderObject, RenderTable, RenderTableRow, and RenderTableSection,
due to the expected behavior is not clear.
Please refer to https://bugs.webkit.org/show_bug.cgi?id=56594.
Test: fast/css/bidi-override-in-anonymous-block.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::createAnonymousBlock):
(WebCore::RenderBlock::createAnonymousColumnsBlock):
(WebCore::RenderBlock::createAnonymousColumnSpanBlock):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addChildIgnoringContinuation):
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::createAnonymousStyle):
* rendering/style/RenderStyle.h:
2011-03-23 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=56909
Add a simplified normal flow layout path optimization for overflow recomputation
and for positioned objects inside relative positioned containers.
Currently there is an optimized code path for positioned objects, but as soon as
we encounter a normal flow object in the containing block chain, we lose the
optimization.
This patch adds a new type of style difference called SimplifiedLayout that is
returned when only overflow needs to be recomputed. Whenever opacity changes or
a transform changes, this is the hint returned now instead of a full layout.
In addition, when positioned objects need layout and start marking up the
containing block chain, we now propagate the fact that the layout is simplified
all the way up to the root, even when we encounter normal flow containing
blocks.
The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout()
and is now used for all of these cases (in addition to what it handled before).
No new tests, since existing tests covered this very well (especially the opacity
and transforms repaint tests in fast/repaint).
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::simplifiedLayout):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleWillChange):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::adjustStyleDifference):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::styleDidChange):
* rendering/RenderObject.h:
(WebCore::RenderObject::needsLayout):
(WebCore::RenderObject::needsPositionedMovementLayoutOnly):
(WebCore::RenderObject::needsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::markContainingBlocksForLayout):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyleConstants.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
2011-03-23 Tyler Close <tjclose@chromium.org>
Reviewed by Jeremy Orlow.
Fix ambiguous method call in V8 IDL generated code for DOMStringList callback parameter
https://bugs.webkit.org/show_bug.cgi?id=56950
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
(WebDOMTestCallback::callbackWithStringList):
* bindings/scripts/test/CPP/WebDOMTestCallback.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
(webkit_dom_test_callback_callback_with_string_list):
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::callbackWithStringList):
* bindings/scripts/test/JS/JSTestCallback.h:
* bindings/scripts/test/ObjC/DOMTestCallback.h:
* bindings/scripts/test/ObjC/DOMTestCallback.mm:
(-[DOMTestCallback callbackWithStringList:]):
* bindings/scripts/test/TestCallback.idl:
* bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithStringList):
* bindings/scripts/test/V8/V8TestCallback.h:
2011-03-23 Cris Neckar <cdn@chromium.org>
Reviewed by Eric Seidel.
Add refptr for widget. Mutations can happen within the event handler.
https://bugs.webkit.org/show_bug.cgi?id=56774
Test: plugins/change-widget-and-click-crash.html
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
2011-03-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Add combine text cast checks since style property is insufficient
in telling object types.
https://bugs.webkit.org/show_bug.cgi?id=56358
Test: fast/text/input-box-text-fragment-combine-text-crash.html
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
* rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache):
2011-03-23 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] "Unwavering" HTML5 game freezes the web page.
https://bugs.webkit.org/show_bug.cgi?id=56944
For canvas's getImageData() API, we don't want to make a deep-copy of
the pixels, which is the case on Qt's "raster" graphics system.
To work around this, we trick QPixmap::toImage() into giving us the
QPixmap's backing QImage by temporarily pointing the paint engine to
a null paint device.
* platform/graphics/qt/ImageBufferData.h:
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBufferData::toQImage): Added, returns the
ImageBufferData as a QImage, avoiding a backend deep-copy if possible.
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
2011-03-23 Viet-Trung Luu <viettrungluu@chromium.org>
Reviewed by Tony Chang.
[chromium] Add FormatPlainText to WebClipboard::Format enumeration.
https://bugs.webkit.org/show_bug.cgi?id=56868
Chromium's WebClipboard::isFormatAvailable() will be correspondingly
extended.
* platform/chromium/PasteboardPrivate.h: Add corresponding enum entry.
This part of the change is inert and should have no effect.
2011-03-23 Tyler Close <tjclose@chromium.org>
Reviewed by Jeremy Orlow.
run-bindings-tests reference files are out of sync with CodeGenerator*.pm
https://bugs.webkit.org/show_bug.cgi?id=56934
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::createStructure):
(WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
(WebCore::JSTestInterface::createPrototype):
* bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterface::createStructure):
(WebCore::JSTestInterfacePrototype::createStructure):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::createStructure):
(WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
(WebCore::JSTestMediaQueryListListener::createPrototype):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::createStructure):
(WebCore::JSTestMediaQueryListListenerPrototype::createStructure):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::createStructure):
(WebCore::JSTestObjConstructor::JSTestObjConstructor):
(WebCore::JSTestObj::createPrototype):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::createStructure):
(WebCore::JSTestObjPrototype::createStructure):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
(WebCore::JSTestSerializedScriptValueInterface::createPrototype):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::createStructure):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure):
* bindings/scripts/test/V8/V8TestCallback.cpp:
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
2011-03-23 Daniel Bates <dbates@rim.com>
Reviewed by Antonio Gomes.
Clean up: Rename HTMLFrameSetElement::{noresize, frameborder, and frameBorderSet}
to conform to the WebKit Code style guidelines
https://bugs.webkit.org/show_bug.cgi?id=56871
No functionality changed. So, no new tests.
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
(WebCore::HTMLFrameSetElement::parseMappedAttribute):
(WebCore::HTMLFrameSetElement::attach):
(WebCore::HTMLFrameSetElement::defaultEventHandler):
* html/HTMLFrameSetElement.h:
(WebCore::HTMLFrameSetElement::hasFrameBorder):
(WebCore::HTMLFrameSetElement::noResize):
2011-03-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
Replace height with logicalHeight when removing items from
gPercentHeightDescendantMap so that it is writing mode aware.
https://bugs.webkit.org/show_bug.cgi?id=56902
Test: fast/block/percent-height-descendant-not-removed-crash.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::destroy):
(WebCore::RenderBox::styleDidChange):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::destroy):
2011-03-23 Anders Carlsson <andersca@apple.com>
Fix clang build.
* inspector/DOMNodeHighlighter.cpp:
Remove an unused function.
2011-03-22 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Add asynchronous load decision call to WebKit2 IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=56887
Clear the callback when it's made:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::continueIconLoadWithDecision):
Don't load icons when using new-style icon database if in private browsing:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueIconLoadWithDecision):
Enhance the IconDatabase callbacks to have an ID and inherit from a common base:
* loader/icon/IconDatabaseBase.h:
(WebCore::CallbackBase::~CallbackBase):
(WebCore::CallbackBase::callbackID):
(WebCore::CallbackBase::CallbackBase):
(WebCore::CallbackBase::context):
(WebCore::CallbackBase::generateCallbackID):
(WebCore::EnumCallback::performCallback):
(WebCore::EnumCallback::EnumCallback):
(WebCore::ObjectCallback::performCallback):
(WebCore::ObjectCallback::ObjectCallback):
2011-03-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move scripts concatenation logic to SourceFile.
https://bugs.webkit.org/show_bug.cgi?id=56756
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/SourceFile.js:
(WebInspector.SourceFile.prototype._requestContent):
(WebInspector.SourceFile.prototype._loadResourceContent):
(WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent):
(WebInspector.SourceFile.prototype._concatenateScriptsContent):
2011-03-23 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Steve Block.
Media Stream API: add a flag to RuntimeEnabledFeatures.
https://bugs.webkit.org/show_bug.cgi?id=56921
Add a flag to RuntimeEnabledFeatures to check if the Media Stream API is enabled at runtime.
Tests for the Media Stream API will be provided by the bug 56587.
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::mediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetUserMediaEnabled):
2011-03-23 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
Modified RenderCounter::originalText() to correctly attach
the created counter to the before/after container even when
that is not the RenderCounter's direct parent.
CSS 2.1 failure: various before-after-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=47207
Test: fast/css/counters/complex-before.html
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::originalText):
2011-03-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Add play / pause button to media control
https://bugs.webkit.org/show_bug.cgi?id=55463
Add play|pause button to media control.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::edjeGroupFromFormType):
(WebCore::RenderThemeEfl::emitMediaButtonSignal): Added.
(WebCore::RenderThemeEfl::paintMediaPlayButton):
* platform/efl/RenderThemeEfl.h:
2011-03-23 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Andreas Kling.
[Qt] QtWebKit rendering problem when maximizing and doing a back
https://bugs.webkit.org/show_bug.cgi?id=56669
Contents of the page are not re-sized on going back after
maximizing. ContentsResized() is not getting called. Hence old
document width and height are used. Corrected this behaviour by
calling setBoundsSize() which calls contentsSize().
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
2011-03-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add support for formating source files in debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=56558
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.reset):
(WebInspector.DebuggerModel.prototype.get scripts):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._refreshBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
(WebInspector.DebuggerPresentationModel.prototype._reset):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
(WebInspector.ScriptFormatter.prototype.formatContent):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
* inspector/front-end/Settings.js:
* inspector/front-end/SourceFile.js:
(WebInspector.SourceFile.prototype.scriptLocationToSourceLocation):
(WebInspector.SourceFile.prototype.sourceLocationToScriptLocation):
(WebInspector.FormattedSourceFile):
(WebInspector.FormattedSourceFile.prototype.scriptLocationToSourceLocation):
(WebInspector.FormattedSourceFile.prototype.sourceLocationToScriptLocation):
(WebInspector.FormattedSourceFile.prototype._didRequestContent):
2011-03-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: use unsigned char instead of char when storing script source
https://bugs.webkit.org/show_bug.cgi?id=56920
* bindings/v8/DebuggerScript.js:
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
* inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::injectedScriptSource):
* inspector/InjectedScriptSource.js: whitespace change to trigger compilation
* inspector/xxd.pl:
* xml/XMLViewer.xsl:
2011-03-23 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move node searching and node highlight related methods from InspectorAgent to InspectorDOMAgent.
https://bugs.webkit.org/show_bug.cgi?id=56912
The next functions were moved:
setSearchingForNode
highlightDOMNode
hideDOMNodeHighlight
highlightFrame
hideFrameHighlight
mouseDidMoveOverElement
handleMousePress
The code which does real highlight in Graphic context was moved to new files DOMNodeHighlighter.*
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/DOMNodeHighlighter.cpp: Added.
(WebCore::DOMNodeHighlighter::DrawNodeHighlight):
* inspector/DOMNodeHighlighter.h: Added.
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::~InspectorAgent):
(WebCore::InspectorAgent::inspectedPageDestroyed):
(WebCore::InspectorAgent::disconnectFrontend):
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::drawNodeHighlight):
(WebCore::InspectorController::hideHighlight):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::~InspectorDOMAgent):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::searchingForNodeInPage):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::highlight):
(WebCore::InspectorDOMAgent::highlightDOMNode):
(WebCore::InspectorDOMAgent::highlightFrame):
(WebCore::InspectorDOMAgent::hideHighlight):
(WebCore::InspectorDOMAgent::drawNodeHighlight):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::hideDOMNodeHighlight):
(WebCore::InspectorDOMAgent::hideFrameHighlight):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl):
(WebCore::InspectorInstrumentation::handleMousePressImpl):
* inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorAgent):
(WebCore::InstrumentingAgents::setInspectorAgent):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.setSearchingForNode):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameTreeElement.prototype.onselect):
(WebInspector.FrameTreeElement.prototype.set hovered):
* inspector/front-end/inspector.js:
(WebInspector.highlightDOMNode):
2011-03-23 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Rollout r81768 which broke compilation on Win.
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
* xml/XMLViewer.xsl:
2011-03-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove unnecessary reinterpret_cast in XMLTreeViewer
https://bugs.webkit.org/show_bug.cgi?id=56919
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
* xml/XMLViewer.xsl: whitespace change to trigger compilation.
2011-03-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move content loading logic to a new SourceFile class.
https://bugs.webkit.org/show_bug.cgi?id=56748
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent):
(WebInspector.DebuggerPresentationModel.prototype._addScript.contentChanged):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
* inspector/front-end/SourceFile.js: Added.
(WebInspector.SourceFile):
(WebInspector.SourceFile.prototype.addScript):
(WebInspector.SourceFile.prototype.requestContent):
(WebInspector.SourceFile.prototype.forceLoadContent):
(WebInspector.SourceFile.prototype.reload):
(WebInspector.SourceFile.prototype._requestContent):
(WebInspector.SourceFile.prototype._loadResourceContent):
(WebInspector.SourceFile.prototype._loadScriptContent):
(WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent):
(WebInspector.SourceFile.prototype._didRequestContent):
(WebInspector.SourceFile.prototype._hasPendingResource):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-03-23 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, fix compilation broken by r81758.
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
2011-03-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: define array types properly in the Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=56915
* inspector/Inspector.json:
* inspector/generate-inspector-idl:
2011-03-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
https://bugs.webkit.org/show_bug.cgi?id=56843
* inspector/front-end/WebKit.qrc:
2011-03-23 Andrey Adaikin <aandrey@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Add a star while editing a source code
https://bugs.webkit.org/show_bug.cgi?id=56743
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._startEditing):
(WebInspector.SourceFrame.prototype._registerShortcuts):
(WebInspector.SourceFrame.prototype._handleSave):
(WebInspector.SourceFrame.prototype._handleRevertEditing):
(WebInspector.SourceFrameDelegate.prototype.setScriptSourceIsBeingEdited):
2011-03-23 Andrey Adaikin <aandrey@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Scrolling and navigation is not smooth on a script with many long lines
https://bugs.webkit.org/show_bug.cgi?id=56559
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorChunkedPanel.prototype._expandChunks):
(WebInspector.TextEditorMainPanel.prototype._expandChunks):
(WebInspector.TextEditorMainPanel.prototype._highlightDataReady):
(WebInspector.TextEditorMainPanel.prototype._schedulePaintLines):
(WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
(WebInspector.TextEditorMainPanel.prototype._restorePaintLinesOperationsCredit):
(WebInspector.TextEditorMainPanel.prototype._paintLines):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
2011-03-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
https://bugs.webkit.org/show_bug.cgi?id=56843
DebuggerScript.js is now translated into a char[] array before inspector compilation.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
* bindings/v8/ScriptDebugServer.h:
* inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::injectedScriptSource):
* inspector/InjectedScriptSource.js: whitespace change to trigger InjectedScriptSource.h generation.
* inspector/xxd.pl:
2011-03-23 Mark Rowe <mrowe@apple.com>
Fix the 32-bit build.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::initializeNewContext):
2011-03-22 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Ojan Vafai.
[chromium] skia image encoders should use <wtf/Vector.h>
https://bugs.webkit.org/show_bug.cgi?id=56893
No new tests. Covered by existing canvas.toDataURL tests.
* platform/image-encoders/skia/JPEGImageEncoder.h:
* platform/image-encoders/skia/PNGImageEncoder.h:
2011-03-22 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin.
Move the cellWidthChanged bit out of RenderObject and back down into RenderTableCell in order to
free up a bit for another performance optimization I have planned.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
* rendering/RenderObject.h:
(WebCore::RenderObject::setHasColumns):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::cellWidthChanged):
(WebCore::RenderTableCell::setCellWidthChanged):
2011-03-22 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=56892
Adding floats to an empty block is O(n^2).
If you just add floats back to back to an empty block, the addition is essentially O(n^2)
once the floats move below your current line position. This is because we repeatedly ask for the
available width for the line from scratch every time we add a float, regardless of whether the
float even vertically intersected our current line position.
Change positionNewFloatOnLine to update left and right line offsets intelligently and to only
do it based off the single new float that just got added.
This fix cuts the IE MazeSolver time in half.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionNewFloatOnLine):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):
2011-03-22 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=56890 It is possible to calculate a
NaN value for "value" in ScrollbarThemeMac::paint()
-and corresponding-
<rdar://problem/9160621>
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
2011-03-17 Ojan Vafai <ojan@chromium.org>
Reviewed by Antti Koivisto.
webkit should implement -moz-any selector (as -webkit-any obviously)
https://bugs.webkit.org/show_bug.cgi?id=38095
For now, match the Mozilla implementation with respect to specificity
and only allowing simple selectors. Both of these are likely to change
pending discussion on www-style@.
Tests: fast/css/pseudo-any.html
fast/dom/SelectorAPI/unknown-pseudo.html
* css/CSSGrammar.y:
Create simple_selector_list. This is exactly like selector_list
except it only allows simple selectors and creates a new vector
instead of a reusable one since there can be multiple in one rule.
* css/CSSParser.cpp:
(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::lex):
(WebCore::CSSParser::createFloatingSelectorVector):
(WebCore::CSSParser::sinkFloatingSelectorVector):
* css/CSSParser.h:
* css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::adoptSelectorVector):
* css/CSSParserValues.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::specificityForOneSelector):
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::selectorText):
(WebCore::CSSSelector::setSelectorList):
(WebCore::CSSSelector::RareData::RareData):
(WebCore::CSSSelector::RareData::~RareData):
These need to be moved into the cpp file so that we can
have an OwnPtr<CSSSelectorList> in CSSSelector::RareData.
* css/CSSSelector.h:
(WebCore::CSSSelector::selectorList):
* css/CSSSelectorList.cpp:
(WebCore::forEachTagSelector):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::collectFeaturesFromSelector):
* css/tokenizer.flex:
2011-03-22 John Bauman <jbauman@chromium.org>
Reviewed by Kenneth Russell.
Add support for preserveDrawingBuffer context creation attribute
https://bugs.webkit.org/show_bug.cgi?id=56431
For the accelerated compositing case, only prepare the texture if it
has been updated since the last composite. For the non-accelerated case, make sure to
grab a copy of the image buffer and paint from that if the backbuffer
would be cleared.
In both cases, make sure to clear the context's backbuffer before the
first operation that uses it.
No new tests. It seems to be difficult/impossible to trigger an early
compositing operation in DumpRenderTree, making this hard to
test automatically. However, Chromium and Safari (Mac) have been
tested manually on the webgl conformance test for this.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::makePresentationCopy):
(WebCore::HTMLCanvasElement::clearPresentationCopy):
* html/HTMLCanvasElement.h:
* html/canvas/WebGLContextAttributes.cpp:
(WebCore::WebGLContextAttributes::preserveDrawingBuffer):
(WebCore::WebGLContextAttributes::setPreserveDrawingBuffer):
* html/canvas/WebGLContextAttributes.h:
* html/canvas/WebGLContextAttributes.idl:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::markLayerComposited):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::paintRenderingResultsToImageData):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::clearColor):
(WebCore::WebGLRenderingContext::clearDepth):
(WebCore::WebGLRenderingContext::clearStencil):
(WebCore::WebGLRenderingContext::colorMask):
(WebCore::WebGLRenderingContext::disable):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::enable):
(WebCore::WebGLRenderingContext::readPixels):
* html/canvas/WebGLRenderingContext.h:
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::Attributes::Attributes):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateContentsIfDirty):
(WebCore::WebGLLayerChromium::textureUpdated):
(WebCore::WebGLLayerChromium::setContext):
* platform/graphics/chromium/WebGLLayerChromium.h:
* platform/graphics/mac/GraphicsContext3DMac.mm
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::layerComposited):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::layerComposited):
2011-03-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER.
<rdar://problem/8944718>
* DerivedSources.make:
Remove generation of HeaderDetection.h.
* WebCore.xcodeproj/project.pbxproj:
Remove HeaderDetection.h.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
Replace use of USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER with USE(WK_SCROLLBAR_PAINTER).
2011-03-22 Victoria Kirst <vrk@google.com>
Reviewed by Kenneth Russell.
[chromium] Properly reset VideoLayerChromium textures after lost renderer context
https://bugs.webkit.org/show_bug.cgi?id=56514
The VideoLayerChromium textures were still mapped to the old
renderer's context when LayerRendererChromium was being recreated
i.e. when GPU process is killed. This patch allows VideoLayerChromium
it recreate textures in the new context when the old renderer is lost.
Patch also does a bit of refactoring and code clean-up.
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::~VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateContentsIfDirty):
(WebCore::VideoLayerChromium::allocateTexturesIfNeeded):
(WebCore::VideoLayerChromium::computeVisibleSize):
(WebCore::VideoLayerChromium::drawYUV):
(WebCore::VideoLayerChromium::drawRGBA):
(WebCore::VideoLayerChromium::resetFrameParameters):
(WebCore::VideoLayerChromium::saveCurrentFrame):
* platform/graphics/chromium/VideoLayerChromium.h:
2011-03-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebCore GYP build should export the headers needed by WebKit
https://bugs.webkit.org/show_bug.cgi?id=56883
* WebCore.gypi:
* gyp/WebCore.gyp:
- Export a couple more headers.
- Remove FIXME comments for things we've already fixed.
2011-03-22 Anton D'Auria <adauria@apple.com>
Reviewed by Alexey Proskuryakov.
Add +[WebApplicationCache getOriginsWithCache]
https://bugs.webkit.org/show_bug.cgi?id=56722
Added test that exercises WebCore API to get origins with application cache.
Test: http/tests/appcache/origins-with-appcache.html
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::getOriginsWithCache):
* loader/appcache/ApplicationCacheStorage.h:
2011-03-22 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
Introduced double linkage between a CounterNode and its display renderer.
use of freed pointer in WebCore::RenderCounter::originalText()
https://bugs.webkit.org/show_bug.cgi?id=56065
No new tests. This bug could only be reproduced manually by
refreshing the page during load at a critical point.
See bug attachment for testing.
* rendering/CounterNode.cpp:
Introduced new member "m_owner" to store the renderer that has the
style directives that produce the CounterNode.
Repurposed m_renderer to reffer to the RenderCounter that shows the
CounterNode.
(WebCore::CounterNode::CounterNode):
Updated member initialization.
(WebCore::CounterNode::create):
(WebCore::CounterNode::addRenderer):
(WebCore::CounterNode::removeRenderer):
Introduced to manage the renderer list associated wit this CounterNode.
(WebCore::CounterNode::resetRenderers):
This is the old resetRenderer. Renamed to take into account that there may be
more than one renderer to a CounterNode.
(WebCore::CounterNode::resetThisAndDescendantsRenderers):
This is the old resetRenderers renamed for clarity.
(WebCore::CounterNode::recount):
(WebCore::CounterNode::insertAfter):
(WebCore::CounterNode::removeChild):
No functional changes.
(WebCore::showTreeAndMark):
Added flushing to ensure that the output is complete.
* rendering/CounterNode.h:
(WebCore::CounterNode::owner):
Renamed from renderer()
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
Fixed comments. No functional changes.
(WebCore::RenderCounter::~RenderCounter):
Made sure that the CounterNode that this renderers displays is
detached from this.
(WebCore::RenderCounter::originalText):
(WebCore::RenderCounter::invalidate):
Changed to maintain the bidirectional relationship with the displayed CounterNode.
Also made "invalidate" private as it should be used only by CounterNode.
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
No change, just kept code in line with the changes above.
(showCounterRendererTree):
Added fflush to ensure complete display.
* rendering/RenderCounter.h:
* rendering/RenderObjectChildList.cpp:
* rendering/RenderObjectChildList.h:
Removed unneeded invalidateCounters related functions.
2011-03-22 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=56242
Interrupted accelerated animations/transitions were causing
subsequent animations to not start (because they were stuck
waiting for a response from the compositing layer). I renamed
the instance variable that indicates whether or not to
notify animations of start time, from m_waitingForStartTimeResponse
to m_waitingForAsyncStartNotification, so that it makes more sense.
The actual bug fix was changing the logic so that the flag is reset
when the list of waiting animations becomes empty. I mistakenly committed
the bad logic in r81613.
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):
- Always set paused time as we enter the paused state
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::endAnimationUpdate):
(WebCore::AnimationControllerPrivate::receivedStartTimeResponse):
(WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse):
(WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse):
- reset the waiting flag when the list is empty (rather than not empty)
(WebCore::AnimationControllerPrivate::startTimeResponse):
* page/animation/AnimationControllerPrivate.h:
- rename m_waitingForStartTimeResponse to m_waitingForAsyncStartNotification
2011-03-22 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
* loader/icon/IconDatabase.cpp:
Add a dummy client implementation for non-Mac, non-Win ports:
(WebCore::DefaultIconDatabaseClient::performImport):
(WebCore::DefaultIconDatabaseClient::didImportIconURLForPageURL):
(WebCore::DefaultIconDatabaseClient::didImportIconDataForPageURL):
(WebCore::DefaultIconDatabaseClient::didChangeIconForPageURL):
(WebCore::DefaultIconDatabaseClient::didRemoveAllIcons):
(WebCore::DefaultIconDatabaseClient::didFinishURLImport):
(WebCore::defaultClient):
Either call the client directly when on the main thread, or use the dispatch functions below
if on the background thread:
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::readFromDatabase):
(WebCore::IconDatabase::removeAllIconsOnThread):
Add a very targeted WorkItem interface for dispatching client calls on the main thread:
(WebCore::ClientWorkItem::ClientWorkItem):
(WebCore::ClientWorkItem::~ClientWorkItem):
(WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWorkItem):
(WebCore::ImportedIconURLForPageURLWorkItem::~ImportedIconURLForPageURLWorkItem):
(WebCore::ImportedIconURLForPageURLWorkItem::performWork):
(WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURLWorkItem):
(WebCore::ImportedIconDataForPageURLWorkItem::~ImportedIconDataForPageURLWorkItem):
(WebCore::ImportedIconDataForPageURLWorkItem::performWork):
(WebCore::RemovedAllIconsWorkItem::RemovedAllIconsWorkItem):
(WebCore::RemovedAllIconsWorkItem::performWork):
(WebCore::performWorkItem):
Use the client WorkItem interface to perform these callbacks on the main thread:
(WebCore::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread):
(WebCore::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread):
(WebCore::IconDatabase::dispatchDidRemoveAllIconsOnMainThread):
* loader/icon/IconDatabase.h:
* loader/icon/IconDatabaseClient.h:
2011-03-22 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=56869
Make horizontal writing mode a bit on RenderObject with a fast inlined method for access. This should be
a little faster than having to access the information from the RenderStyle's sub-structure.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::blockDirectionOffset):
(WebCore::inlineDirectionOffset):
(WebCore::RenderBlock::logicalRectToPhysicalRect):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::positionForPoint):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::lastLineBoxBaseline):
(WebCore::RenderBlock::nextPageLogicalTop):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::marginValuesForChild):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::logicalWidthForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::setLogicalHeightForFloat):
(WebCore::RenderBlock::setLogicalWidthForFloat):
(WebCore::RenderBlock::xPositionForFloatIncludingMargin):
(WebCore::RenderBlock::yPositionForFloatIncludingMargin):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::findNextLineBreak):
(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::logicalScroll):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::flipForWritingMode):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::styleWillChange):
* rendering/RenderObject.h:
(WebCore::RenderObject::isHorizontalWritingMode):
(WebCore::RenderObject::setHorizontalWritingMode):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::scrollbarsChanged):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::verticalPositionForBox):
2011-03-22 Simon Fraser <simon.fraser@apple.com>
Reviewed by Beth Dakin.
Incorrect rendering of composited element with negative z-index child
https://bugs.webkit.org/show_bug.cgi?id=56846
When a composited element has a child with negative z-index, we make
a separate layer for that element's foreground content. This layer
was positioned incorrectly (but the content happened to paint at
the right location), resulting in right/bottom clipping.
Fix this, remove the little-used graphicsLayerToContentsCoordinates()
contentsToGraphicsLayerCoordinates() methods, and optimize incremental
repaints in the foreground and mask layers.
Tests: compositing/geometry/foreground-layer.html
compositing/geometry/repaint-foreground-layer.html
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setNeedsDisplayInRect): Cull repaints
which fall outside the layer bounds, so callers don't have to,
and to avoid unnecessary layer commits.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): If
we have a foreground layer inside a clipping layer, the foreground
layer's offset is zero, since the clipping layer is its parent.
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): Use
offsetFromRenderer() directly instead of contentsToGraphicsLayerCoordinates().
Also do incremental repaints of the foreground and mask layers.
(WebCore::RenderLayerBacking::paintContents): It was incorrect to always
use compositedBounds() to compute the painting offset, since that's
per-RenderLayerBacking, but a single RenderLayerBacking can have different
GraphicsLayers with different offsets (e.g. the foreground layer).
Instead, use offsetFromRenderer(), which gives has the correct offset.
* rendering/RenderLayerBacking.h: Remove unused methods.
2011-03-22 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Use default-output instead of default-input to get hardware sample-rate
https://bugs.webkit.org/show_bug.cgi?id=56858
No new tests since audio API is not yet implemented.
* platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::hardwareSampleRate):
2011-03-22 Pratik Solanki <psolanki@apple.com>
Reviewed by David Kilzer.
Implement -connection:didReceiveDataArray: NSURLConnection delegate method
https://bugs.webkit.org/show_bug.cgi?id=56838
Add experimental support for the didReceiveDataArray callback on
NSURLConnection. A RessourceHandleClient indicates its ability to
handle this callback by returning true from supportsDataArray() method.
Currently only SubresourceLoader uses this so we get the benefit for
CSS, JS and image loads. For other clients we call didReceiveData with
the CFData contents as before.
* WebCore.xcodeproj/project.pbxproj:
* loader/ResourceLoader.h:
* loader/SubresourceLoader.h:
(WebCore::SubresourceLoader::supportsDataArray):
* loader/cf/SubresourceLoaderCF.cpp: Added.
(WebCore::SubresourceLoader::didReceiveDataArray):
* loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::didReceiveDataArray):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::clear):
(WebCore::SharedBuffer::buffer):
* platform/SharedBuffer.h:
* platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::copyDataArrayAndClear):
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::supportsDataArray):
(WebCore::ResourceHandleClient::didReceiveDataArray):
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
2011-03-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
https://bugs.webkit.org/show_bug.cgi?id=56867
This should make it possible to build the gyp-generated WebCore.xcodeproj
from a WebCore directory outside of Source.
* gyp/WebCore.gyp:
* gyp/run-if-exists.sh: Added.
* gyp/update-info-plist.sh: Added.
2011-03-22 Anders Carlsson <andersca@apple.com>
Fix WebKit2 build.
* WebCore.exp.in:
Export a symbol needed by WebKit2.
2011-03-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add the remaining steps to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56864
These steps match the normal build. After this patch, I believe the
WebCore GYP build is complete.
* WebCore.gypi:
* gyp/WebCore.gyp:
* gyp/copy-inspector-resources.sh: Added.
2011-03-22 Beth Dakin <bdakin@apple.com>
Reviewed by Simon Fraser.
Fix for https://bugs.webkit.org/show_bug.cgi?id=56856 RenderListBox needs to be
added to Page::scrollableAreaSet()
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):
* rendering/RenderListBox.h:
(WebCore::RenderListBox::disconnectFromPage):
2011-03-22 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add high-quality band-limited audio resampling algorithm
https://bugs.webkit.org/show_bug.cgi?id=56692
No new tests since audio API is not yet implemented.
* platform/audio/SincResampler.cpp: Added.
(WebCore::SincResampler::SincResampler):
(WebCore::SincResampler::initializeKernel):
(WebCore::SincResampler::consumeSource):
(WebCore::SincResampler::process):
* platform/audio/SincResampler.h: Added.
2011-03-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebCore GYP build should build without help from normal WebCore build
https://bugs.webkit.org/show_bug.cgi?id=56860
Before this patch, the WebCore GYP build wasn't generating the derived
sources quite right because the ENABLE macros were not being
communicated to the "Derived Sources" target.
This patch also adds the "Copy Forwarding and ICU Headers" as well as
the "Streamline Inspector Source" steps, which are present in the
normal build. Unlike the normal build, these steps occur in a new
target, called "WebCore Support", which is less than aesthetically
beautiful. Hopefully we'll be able to move them into the WebCore
target proper in the future, but that will likely require some GYP
changes.
This patch probably could have been broken down into a couple smaller
patches, but that doesn't seem necessary.
* WebCore.gypi:
- This file appears to no longer exist.
* gyp/WebCore.gyp:
* gyp/copy-forwarding-and-icu-headers.sh: Added.
* gyp/streamline-inspector-source.sh: Added.
2011-03-22 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=56859
Floats in the floating object list occur in the order that they are positioned. This means
that for a given vertical offset, the last left object in the list that intersects that offset
will be the rightmost float. There is no need to check any previous floats, since they have to be
further left than that rightmost float. The same rules hold true for right-aligned floats.
Change logicalLeft/RightOffsetForLine to iterate backwards instead of forwards and to stop the moment
they encounter a float that intersects the vertical range.
This cuts the maze solving time for a 20x20 maze in the IE MazeSolver test in half.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
2011-03-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
SVG displacement map should validate channel selections
https://bugs.webkit.org/show_bug.cgi?id=56794
Test: svg/filters/feDisplacementMap-crash-test.xhtml
* svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
2011-03-22 Huahui Wu <mediadependent@gmail.com>
Reviewed by Steve Block.
[Android] Update PlatformTouchEvent for android so it can pass IDs and states around.
https://bugs.webkit.org/show_bug.cgi?id=56763
No new tests as no new functionality is exposed.
* platform/PlatformTouchEvent.h:
* platform/android/PlatformTouchEventAndroid.cpp:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
2011-03-22 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Implement the CSS3 line-box-contain property. This property provides authors with more control over spacing between lines. For example,
you can fix the height of lines and cause all line contents to be ignored. You can make lines fit to glyphs. You can ignore leading and
fit to the font size. You can ignore replaced elements, etc.
Refactor the code in computeLogicalBoxHeights into helper methods on RootInlineBox. verticalPositionForBox moved over to RootInlineBox
so that it could be called from RenderBlockLineLayout. ascentAndDescentForBox is the new method that computes the appropriate box
height based off the block's line-box-contain value.
GlyphOverflow can now have a computeBounds parameter set, in which case glyph bounds will be computed and stored in the overflow struct.
RenderInline no longer returns 0 margins in the block direction, since line-box-contain can size around the margin box.
Added new tests in fast/block/lineboxcontain
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::createLineBoxContainValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSLineBoxContainValue.cpp: Added.
(WebCore::CSSLineBoxContainValue::CSSLineBoxContainValue):
(WebCore::CSSLineBoxContainValue::cssText):
* css/CSSLineBoxContainValue.h: Added.
(WebCore::CSSLineBoxContainValue::create):
(WebCore::CSSLineBoxContainValue::value):
(WebCore::CSSLineBoxContainValue::isCSSLineBoxContainValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseLineBoxContain):
* css/CSSParser.h:
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValue.h:
(WebCore::CSSValue::isCSSLineBoxContainValue):
* css/CSSValueKeywords.in:
* platform/graphics/Font.cpp:
(WebCore::Font::width):
* platform/graphics/Font.h:
(WebCore::GlyphOverflow::GlyphOverflow):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::floatWidthForSimpleText):
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::floatWidthForComplexText):
* platform/graphics/win/FontWin.cpp:
(WebCore::Font::floatWidthForComplexText):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
* rendering/InlineFlowBox.h:
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::marginLeft):
(WebCore::RenderInline::marginRight):
(WebCore::RenderInline::marginTop):
(WebCore::RenderInline::marginBottom):
(WebCore::RenderInline::marginBefore):
(WebCore::RenderInline::marginAfter):
* rendering/RenderInline.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::width):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::setAscentAndDescent):
(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):
(WebCore::RootInlineBox::includeLeadingForBox):
(WebCore::RootInlineBox::includeFontForBox):
(WebCore::RootInlineBox::includeGlyphsForBox):
(WebCore::RootInlineBox::includeMarginForBox):
(WebCore::RootInlineBox::fitsToGlyphs):
(WebCore::RootInlineBox::includesRootLineBoxFontOrLeading):
* rendering/RootInlineBox.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::lineBoxContain):
(WebCore::InheritedFlags::setLineBoxContain):
(WebCore::InheritedFlags::initialLineBoxContain):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
2011-03-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81653.
http://trac.webkit.org/changeset/81653
https://bugs.webkit.org/show_bug.cgi?id=56839
Breaks fast/text/drawBidiText.html on Chromium. (Requested by
pfeldman on #webkit).
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):
2011-03-22 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rolling out 81657, 81654, 81651 for breaking tests on chromium.
* inspector/Inspector.json:
* inspector/InspectorDatabaseResource.cpp:
(WebCore::InspectorDatabaseResource::bind):
* inspector/front-end/Database.js:
(WebInspector.DatabaseDispatcher.prototype.addDatabase):
2011-03-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION] scripts panel is broken when frontend is reopened.
https://bugs.webkit.org/show_bug.cgi?id=56747
Debugger should be enabled on front-end side to guarantee initialization sequence (resources come before scripts).
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::showProfilesPanel):
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::showAndEnableDebugger):
* inspector/InspectorController.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setFrontend):
(WebCore::InspectorDebuggerAgent::clearFrontend):
* inspector/InspectorDebuggerAgent.h:
2011-03-22 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Benjamin Poulain.
[Qt] WebGL: renderbufferStorage() fails with internal format GL_RGBA4
https://bugs.webkit.org/show_bug.cgi?id=56824
On desktop OpenGL substitute in renderbufferStorage:
- GL_DEPTH24_STENCIL8 for GL_DEPTH_STENCIL
- GL_DEPTH_COMPONENT for GL_DEPTH_COMPONENT16
- GL_RGBA for GL_RGBA4 and GL_RGBA565
- GL_RGB for RGB5_A1.
Tests: fast/canvas/webgl/uninitialized-test.html
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::renderbufferStorage):
2011-03-16 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
Move volume slider positioning logic to a custom renderer.
https://bugs.webkit.org/show_bug.cgi?id=56498
No functional change, covered by existing tests.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::updateVolumeSliderContainer): Removed positioning logic.
* rendering/MediaControlElements.cpp:
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer): Added.
(WebCore::RenderMediaVolumeSliderContainer::layout): Added.
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): Removed storing of coordinates.
(WebCore::MediaControlVolumeSliderContainerElement::createRenderer): Added.
(WebCore::MediaControlVolumeSliderContainerElement::styleForElement): Removed setting of coordinates.
* rendering/MediaControlElements.h: Changed corresponding decls.
2011-03-22 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by Benjamin Poulain.
[Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
https://bugs.webkit.org/show_bug.cgi?id=54138
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::getViewportGLWidget):
Check if we actually have a QWebPageClient before dereferencing it.
2011-03-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: document DOM domain types and protocol methods.
https://bugs.webkit.org/show_bug.cgi?id=56807
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::wrapNode):
* inspector/InjectedScript.h:
* inspector/Inspector.json:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeValue):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
* inspector/front-end/EventListenersSidebarPane.js:
* inspector/front-end/PropertiesSidebarPane.js:
(WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.resolveNode):
2011-03-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Production configuration in GYP isn't set up correctly
https://bugs.webkit.org/show_bug.cgi?id=56786
Update WebCore.gyp with information mined from WebCore.xcodeproj.
* WebCore.gypi:
* gyp/WebCore.gyp:
2011-03-22 Ofri Wolfus <ofri@google.com>
Reviewed by Eric Seidel.
RTL: Select elements with a size attribute are always left aligned.
https://bugs.webkit.org/show_bug.cgi?id=50928
Added support for alignment in RenderListBox.
Test: fast/forms/listbox-bidi-align.html
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.
2011-03-22 Ilya Sherman <isherman@chromium.org>
Reviewed by Kent Tamura.
Clear autofilled flag when reseting a form
In service of https://code.google.com/p/chromium/issues/detail?id=70037
https://bugs.webkit.org/show_bug.cgi?id=56802
Test: fast/forms/reset-autofilled.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::reset): Clear the autofilled flag.
2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: protocol cleanup. DatabaseAgent.
https://bugs.webkit.org/show_bug.cgi?id=56815
see protocol metabug:
- All events should use notification wording, not command wording:
addDatabase was renamed to DatabaseOpened.
Test: inspector/protocol/database-agent.html
* inspector/Inspector.json:
* inspector/InspectorDatabaseResource.cpp:
(WebCore::InspectorDatabaseResource::bind):
* inspector/front-end/Database.js:
(WebInspector.DatabaseDispatcher.prototype.DatabaseOpened):
2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: protocol cleanup. ConsoleAgent.
https://bugs.webkit.org/show_bug.cgi?id=56806
renamed method: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount);
new method: disable()
deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::updateRepeatCountInConsole):
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::disable):
* inspector/InspectorConsoleAgent.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdated):
(WebInspector.ConsoleView.prototype.setConsoleMessageExpiredCount):
* inspector/front-end/inspector.js:
2011-03-22 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
REGRESSION(r80096): Number type input unexpectedly rounds fractional values
https://bugs.webkit.org/show_bug.cgi?id=56367
Because the default value of the maximum fractional digits of NSNumberFormatter
and ICU NumberFormat is 3, the value 0.55555 is rounded to 0.556 in a
localized representation. This bug affects only in Mac and Chromium.
To fix this bug,
- Add "maximum fractional digits" parameter to formatLocalizedNumber(), and
- NumberInputType::visibleValue uses parseToDoubleForNumberTypeWithDecimalPlaces()
instead of parseToDoubleForNumberType().
No automated tests because the behavior is locale-dependent. This change
updates a manual test.
* html/NumberInputType.cpp:
(WebCore::NumberInputType::visibleValue):
Use parseToDoubleForNumberTypeWithDecimalPlaces() and passing fractional
part length to formatLocalizedNumber().
* manual-tests/input-number-localization.html:
Update the test to cover this change.
* platform/text/LocalizedNumber.h: Add a parameter to formatLocalizedNumber().
* platform/text/LocalizedNumberICU.cpp:
(WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().
* platform/text/LocalizedNumberNone.cpp:
(WebCore::formatLocalizedNumber):
* platform/text/mac/LocalizedNumberMac.mm:
(WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().
2011-03-21 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Seidel.
Anonymous blocks need isRenderBlock cast check. Also, need
to allow display BOX for flexible boxes.
https://bugs.webkit.org/show_bug.cgi?id=56709
Test: accessibility/anchor-linked-anonymous-block-crash.html
* rendering/RenderBlock.cpp:
(WebCore::canMergeContiguousAnonymousBlocks): remove specific
fix in r81088 which is no longer needed.
* rendering/RenderObject.h:
(WebCore::RenderObject::isAnonymousBlock): Add isRenderBlock cast
check.
2011-03-21 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Seidel.
Revert small change made in r78846 of replacing move with positionLineBox
in the adjusting position function for inline box.
https://bugs.webkit.org/show_bug.cgi?id=56300
The change in r78846 caused positioning line boxes during the step of adjusting
position for inline box, thereby causing line boxes to be nuked. This happens as
part of aligning boxes in block direction in RenderBlock::computeBlockDirectionPositionsForLine.
Later on, we do the positioning of line boxes again later in that function. This
causes use of removed inline box leading to crash. Also, it is unnecessary to do
this twice.
Tests: fast/inline/inline-box-adjust-position-crash.html
fast/inline/inline-box-adjust-position-crash2.html
* rendering/InlineBox.cpp:
(WebCore::InlineBox::adjustPosition):
2011-03-21 Adam Klein <adamk@chromium.org>
Reviewed by David Levin.
[fileapi] Add URI resolution support to WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=55644
Tests: http/tests/filesystem/workers/resolve-url-sync.html
http/tests/filesystem/workers/resolve-url.html
* fileapi/LocalFileSystem.cpp:
(WebCore::LocalFileSystem::readFileSystem):
Add support for workers.
* fileapi/LocalFileSystem.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::resolveLocalFileSystemURL):
(WebCore::WorkerContext::resolveLocalFileSystemSyncURL):
* workers/WorkerContext.h:
* workers/WorkerContext.idl:
2011-03-21 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
XHR in Workers doesn't set the referrer correctly.
https://bugs.webkit.org/show_bug.cgi?id=24683
Tests: http/tests/xmlhttprequest/workers/referer.html
http/tests/xmlhttprequest/workers/shared-worker-referer.html
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadResourceSynchronously): Fill in empty string for the outgoing referrer.
(WebCore::DocumentThreadableLoader::create): Added the ability to set the outgoing referrer.
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto.
(WebCore::DocumentThreadableLoader::loadRequest): Ditto.
* loader/DocumentThreadableLoader.h: Ditto.
* loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Ditto.
* loader/ResourceLoadScheduler.h: Ditto.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create): Fixed bug (caught by the test) in last minute change done in previous check-in.
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::WorkerThreadableLoader): Fill in the outgoing referrer.
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Plumbing for the outgoing referrer.
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): Plumbing for the outgoing referrer.
* loader/WorkerThreadableLoader.h:
2011-03-21 Nate Chapin <japhet@chromium.org>
Reviewed by Brady Eidson.
Do not check the DocumentLoader's request cache policy
in determining whether we should force revalidation of a cached
subresource. If the main resource received headers telling it not
to cache, that policy will be propagated to subresources.
The previous behavior is left in behind a flag in Settings, since
QuickLook depends on it.
https://bugs.webkit.org/show_bug.cgi?id=38690
Tests: http/tests/cache/post-redirect-get.php
http/tests/cache/post-with-cached-subresources.php
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):
(WebCore::FrameLoader::loadPostRequest):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setUseQuickLookResourceCachingQuirks):
(WebCore::Settings::useQuickLookResourceCachingQuirks):
2011-03-21 Rik Cabanier <cabanier@adobe.com>
Reviewed by James Robinson.
bug 56052: percentages are incorrectly rounded in WebKit
https://bugs.webkit.org/show_bug.cgi?id=56052
test: fast/css/percentage-non-integer.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* page/PrintContext.cpp:
(WebCore::PrintContext::pageProperty):
* platform/Length.h:
(WebCore::Length::Length):
(WebCore::Length::operator*=):
(WebCore::Length::value):
(WebCore::Length::percent):
(WebCore::Length::setValue):
(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
(WebCore::Length::isUndefined):
(WebCore::Length::isZero):
(WebCore::Length::isPositive):
(WebCore::Length::isNegative):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
(WebCore::FixedTableLayout::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addCell):
(WebCore::RenderTableSection::layoutRows):
* rendering/style/BorderData.h:
(WebCore::BorderData::hasBorderRadius):
2011-03-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add WebCoreExportFileGenerator to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56778
This target mirrors the eponymous target from WebCore.xcodeproj.
* WebCore.gypi:
* gyp/WebCore.gyp:
* generate-webcore-export-file-generator.sh: Added.
2011-03-21 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
WebCore GYP build shouldn't crash on startup
https://bugs.webkit.org/show_bug.cgi?id=56776
Debug builds shouldn't define NDEBUG. This same logic exists in the
project.pbxproj file.
* gyp/WebCore.gyp:
2011-03-21 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Implement glue between DataTransferItems and the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=56330
Support retrieving clipboard data in a paste through DataTransferItems.
Test: editing/pasteboard/data-transfer-items.html
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::items):
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::createFromPasteboard):
(WebCore::DataTransferItemChromium::create):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsString):
* platform/chromium/DataTransferItemChromium.h:
* platform/chromium/DataTransferItemsChromium.cpp:
(WebCore::DataTransferItemsChromium::addPasteboardItem):
* platform/chromium/DataTransferItemsChromium.h:
2011-03-21 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: showContextMenu not working in WK2
https://bugs.webkit.org/show_bug.cgi?id=56734
WebKit2 is not able to directly open a context menu because the UI is in the other process.
Instead the chrome client should be used. This also means implementing showContextMenu() in WebKit1
code.
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
2011-03-21 Robert Kroeger <rjkroege@chromium.org>
Reviewed by Antonio Gomes.
Add Support to WebCore to optionally call a platform-specific gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=49345
Added an ability for the EventHandler to invoke an optional platform
specific gesture recognizer.
No tests added because the change should be functionally invisible.
* WebCore.gypi:
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleTouchEvent):
* page/EventHandler.h:
* platform/PlatformGestureRecognizer.cpp: Added.
(WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer):
(WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer):
(WebCore::PlatformGestureRecognizer::create):
* platform/PlatformGestureRecognizer.h: Added.
2011-03-21 Dean Jackson <dino@apple.com>
Reviewed by Chris Marrin and Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=56325
ASSERTION FAILED: paused() in AnimationBase::updateStateMachine()
AnimationBase had a custom linked-list/self-pointer for keeping
track of animations that needed to be notified of style updates
and start progress. This caused problems when AnimationBase was
destroyed, since the pointer wasn't managed in any way. I replaced
these pointers with HashSets and moved the code that removes animations
from the sets into AnimationControllerPrivate, where it belongs.
CompositeAnimation is also more careful to tell AnimationControllerPrivate
when it no longer needs to keep track of waiting animations.
This should stop the style updates being called on non-active animations
(which was the cause of the state machine error here) and should also
stop a few of the related flakey test failures and occasional crashes.
Test: animations/body-removal-crash.html
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::AnimationBase):
(WebCore::AnimationBase::updateStateMachine):
* page/animation/AnimationBase.h:
(WebCore::AnimationBase::~AnimationBase):
- Remove the linked-list
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStyle):
(WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStyle):
(WebCore::AnimationControllerPrivate::styleAvailable):
(WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse):
(WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse):
(WebCore::AnimationControllerPrivate::startTimeResponse):
(WebCore::AnimationControllerPrivate::animationWillBeRemoved):
- New method to remove animations from the waiting lists
* page/animation/AnimationControllerPrivate.h:
- use a HashSet rather than an AnimationBase* pointer.
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::~CompositeAnimation):
(WebCore::CompositeAnimation::clearRenderer):
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
- remove the animations and transitions from the lists when we know
they are no longer active (rather than waiting for the AnimationBase
to do it when destructing)
2011-03-21 Justin Schuh <jschuh@chromium.org>
Reviewed by James Robinson.
Stop inserting when the parent is removed
https://bugs.webkit.org/show_bug.cgi?id=56690
Tests: fast/dom/insertedIntoDocument-child.html
fast/dom/insertedIntoDocument-iframe.html
fast/dom/insertedIntoDocument-sibling.html
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertedIntoDocument):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::insertedIntoDocument):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::insertedIntoDocument):
2011-03-07 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
SubresourceLoader should expose a way to set the outgoing referer/origin
https://bugs.webkit.org/show_bug.cgi?id=55903
No new tests as no new functionality is exposed.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create):
* loader/SubresourceLoader.h:
2011-03-21 Daniel Sievers <sievers@google.com>
Reviewed by Simon Fraser.
[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139
* WebCore.exp.in:
* WebCore.order:
* page/Frame.cpp:
(WebCore::Frame::layerTreeAsText):
* page/Frame.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
* rendering/RenderLayerCompositor.h:
2011-03-21 Chang Shu <cshu@webkit.org>
Reviewed by Alexey Proskuryakov.
REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665
r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.
* WebCore.exp.in:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isReadOnly):
* dom/Node.cpp:
(WebCore::Node::isContentEditable):
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelectionFromNone):
* page/DragController.cpp:
(WebCore::DragController::operationForLoad):
* page/Page.cpp:
(WebCore::Page::Page):
* page/Page.h:
(WebCore::Page::setEditable):
(WebCore::Page::isEditable):
2011-03-21 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
[fileapi/chromium] Fetch platform path using GetMetadata before creating File from FileEntry*
https://bugs.webkit.org/show_bug.cgi?id=56704
* fileapi/DOMFileSystemSync.cpp
(DOMFileSystemSync::createFile)
(class GetPathHelper): Added, to look up path before creating File.
* fileapi/DOMFileSystem.cpp
(DOMFileSystem::createFile)
(GetPathCallback): Added, to look up path before creating File.
* platform/FileMetadata.h
(struct FileMetadata): Added new field platformPath.
2011-03-21 Dominic Cooney <dominicc@google.com>
Reviewed by Jeremy Orlow.
Establishes a V8 context before executing MediaQueryList callbacks.
https://bugs.webkit.org/show_bug.cgi?id=56166
MediaQueryList listener callbacks didn't establish a V8 context
before running script, causing crashes on C++-only
callstacks (such as user resizing, printing, etc.) I believe this
could also be contrived to execute media query list listener
callbacks across domain.
Test: fast/media/media-query-list-callback.html
* css/MediaQueryListListener.cpp:
(WebCore::MediaQueryListListener::queryChanged):
2011-03-21 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] Add QNetworkReplyHandler::wasAborted()
Instead of checking if the ResourceHandle is null everywhere,
use a wasAborted() method to make the code readable.
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyHandler::wasAborted):
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::redirect):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::uploadProgress):
2011-03-21 Christian Dywan <christian@lanedo.com>
Reviewed by Martin Robinson.
WebKitIconDatabase may trigger crash in cairoImageSurfaceToGdkPixbuf
https://bugs.webkit.org/show_bug.cgi?id=56201
* platform/graphics/gtk/ImageGtk.cpp: Don't attempt to make a pixbuf
if there is no image.
2011-03-21 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes
https://bugs.webkit.org/show_bug.cgi?id=56737
Only consider parent objects not ignoring accessibility.
* accessibility/gtk/WebKitAccessibleHyperlink.cpp:
(webkitAccessibleHyperlinkGetStartIndex): Look for the parent
object not ignoring accessibility for the current hyperlink.
(webkitAccessibleHyperlinkGetEndIndex): Ditto.
2011-03-21 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Remove handling of QNetworkAccessManager::UnknownOperation
Now that Qt 4.7 is required we never have to fall back to UnknownOperation.
Custom verb requests are using CustomOperation already, so this was dead code.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
2011-03-21 Adam Roben <aroben@apple.com>
Fix multiple-definition linker warnings on Windows
* WebCore.vcproj/WebCore.vcproj: Exclude RenderSVGPath.cpp from the build, since it is
already being compiled via RenderingAllInOne.cpp. Let VS have its way with the rest of the
file.
2011-03-21 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Clean up QNetworkReplyHandler::release()
Since QNetworkReplyHandler no longer uses queued connections to
the QNetworkReply, it's not necessary to mess with the event
queue when releasing a reply.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::abort):
(WebCore::QNetworkReplyHandler::release):
2011-03-21 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
https://bugs.webkit.org/show_bug.cgi?id=56691
Added transfer size support in inspector for compressed data.
Test: http/tests/inspector/network/network-size-chunked.html
* inspector/Inspector.idl:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didReceiveContentLength):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveContentLength):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.didReceiveContentLength):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get transferSize):
(WebInspector.Resource.prototype.increaseTransferSize):
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::didReceiveData):
(WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
(WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
* loader/ResourceLoadNotifier.h:
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveData):
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::forwardData):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::gotChunkCallback):
* platform/network/win/ResourceHandleWin.cpp:
(WebCore::ResourceHandle::onRequestComplete):
(WebCore::ResourceHandle::fileLoadTimer):
2011-03-21 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Dirk Schulze.
symbol display <use> at wrong scale
https://bugs.webkit.org/show_bug.cgi?id=54538
SVG spec: http://www.w3.org/TR/SVG/struct.html#UseElement
Quotation for referenced <symbol>: "If attributes 'width'
and/or 'height' are provided on the 'use' element, then
these attributes will be transferred to the generated 'svg'."
Quotation for referenced <svg>: "If attributes 'width'
and/or 'height' are provided on the 'use' element, then
these values will override the corresponding attributes
on the 'svg' in the generated tree."
For above quotations, we should treat 'use' element as referencing
'use' element, just like Firefox 3.6 and Opera 11, instead of
corrensponding 'use' element.
Tests: svg/custom/use-transfer-width-height-properties-to-svg.svg
svg/custom/use-transfer-width-height-properties-to-svg1.svg
svg/custom/use-transfer-width-height-properties-to-svg2.svg
svg/custom/use-transfer-width-height-properties-to-symbol.svg
svg/custom/use-transfer-width-height-properties-to-symbol1.svg
svg/custom/use-transfer-width-height-properties-to-symbol2.svg
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::SVGElementInstance):
* svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::create):
(WebCore::SVGElementInstance::correspondingUseElement):
(WebCore::SVGElementInstance::directUseElement):
(WebCore::SVGElementInstance::clearUseElements):
* svg/SVGUseElement.cpp:
(WebCore::updateContainerSize):
(WebCore::SVGUseElement::updateContainerSizes):
(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::detachInstance):
(WebCore::SVGUseElement::buildInstanceTree):
2011-03-21 Jaehun Lim <ljaehun.lim@samsung.com>
Reviewed by Pavel Feldman.
Fix build break when inspector is enabled.
https://bugs.webkit.org/show_bug.cgi?id=56735
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Add ENABLE(INSPECTOR).
2011-03-21 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK distcheck build fix.
* GNUmakefile.am:
2011-03-21 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)
Test: fast/css/webkit-empty-transform-preserve3d-crash.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::layoutOverflowRectForPropagation): Mimicked the
rest of the code and check that the RenderBox has a layer to avoid
crashing on the layer() call.
2011-03-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move cookie processing and appcache from DOMAgent.js
https://bugs.webkit.org/show_bug.cgi?id=56713
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheDispatcher):
(WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
(WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus):
(WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
* inspector/front-end/CookieItemsView.js:
(WebInspector.Cookies.getCookiesAsync):
(WebInspector.Cookies.buildCookiesFromString):
(WebInspector.Cookies.cookieMatchesResourceURL):
(WebInspector.Cookies.cookieDomainMatchesResourceDomain):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.eventListeners):
* inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update):
2011-03-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: migrate Inspector.json to valid JSON types.
https://bugs.webkit.org/show_bug.cgi?id=56651
This change migrates inspector from long to int as
dom, storage, database and other id types.
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::inspectedNode):
(WebCore::InjectedScriptHost::databaseIdImpl):
(WebCore::InjectedScriptHost::storageIdImpl):
(WebCore::InjectedScriptHost::didCreateWorker):
(WebCore::InjectedScriptHost::didDestroyWorker):
* inspector/InjectedScriptHost.h:
* inspector/InjectedScriptHost.idl:
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::highlightDOMNode):
* inspector/InspectorAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
* inspector/InspectorBrowserDebuggerAgent.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStyleForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::elementForId):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::count):
(WebCore::InspectorConsoleAgent::addInspectedNode):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::bind):
(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::assertNode):
(WebCore::InspectorDOMAgent::assertElement):
(WebCore::InspectorDOMAgent::assertHTMLElement):
(WebCore::InspectorDOMAgent::nodeToSelectOn):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::nodeForId):
(WebCore::InspectorDOMAgent::getChildNodes):
(WebCore::InspectorDOMAgent::querySelector):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::boundNodeId):
(WebCore::InspectorDOMAgent::setAttribute):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::pushNodeToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::loadEventFired):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
(WebCore::InspectorDOMAgent::didModifyDOMAttr):
(WebCore::InspectorDOMAgent::characterDataModified):
(WebCore::InspectorDOMAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
(WebCore::InspectorDOMAgent::copyNode):
(WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDOMStorageResource.cpp:
* inspector/InspectorDOMStorageResource.h:
(WebCore::InspectorDOMStorageResource::id):
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::executeSQL):
(WebCore::InspectorDatabaseAgent::databaseId):
(WebCore::InspectorDatabaseAgent::databaseForId):
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDatabaseResource.cpp:
* inspector/InspectorDatabaseResource.h:
(WebCore::InspectorDatabaseResource::id):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::identifierForInitialRequest):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveContentLength):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::setInitialContent):
(WebCore::InspectorResourceAgent::didCreateWebSocket):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
* inspector/generate-inspector-idl:
2011-03-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make frameId in network agent of type string, not unsigned long.
https://bugs.webkit.org/show_bug.cgi?id=56708
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::highlightFrame):
* inspector/InspectorAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::pointerAsId):
(WebCore::buildObjectForDocumentLoader):
(WebCore::buildObjectForFrame):
(WebCore::InspectorResourceAgent::frameDetachedFromParent):
(WebCore::InspectorResourceAgent::frameForId):
(WebCore::InspectorResourceAgent::resourceContent):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.addOrUpdateFrame):
2011-03-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: expose object id as string, not JSON struct in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=56681
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::inspect):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::inspectCallback):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluateOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::nodeForObjectId):
(WebCore::InjectedScript::setPropertyValue):
(WebCore::InjectedScript::releaseObject):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::inspectImpl):
* inspector/InjectedScriptHost.h:
* inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::injectedScriptForObjectId):
(WebCore::InjectedScriptManager::releaseObjectGroup):
* inspector/InjectedScriptManager.h:
* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushNodeToFrontend):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluateOn):
(WebCore::InspectorRuntimeAgent::getProperties):
(WebCore::InspectorRuntimeAgent::setPropertyValue):
(WebCore::InspectorRuntimeAgent::releaseObject):
(WebCore::InspectorRuntimeAgent::releaseObjectGroup):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
(WebInspector.ConsoleView.prototype.completions):
* inspector/front-end/PropertiesSidebarPane.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update):
* inspector/front-end/inspector.js:
(WebInspector.inspect):
2011-03-20 Bill Budge <bbudge@chromium.org>
Reviewed by Adam Barth.
Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714
No new tests. Exposes no new functionality.
* ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from ForwardingHeaders/wtf/ThreadSafeShared.h.
* ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
* bindings/v8/SerializedScriptValue.h:
* dom/Document.cpp:
* dom/default/PlatformMessagePortChannel.h:
* fileapi/FileThread.h:
* loader/ThreadableLoaderClientWrapper.h:
(WebCore::ThreadableLoaderClientWrapper::create):
(WebCore::ThreadableLoaderClientWrapper::clearClient):
(WebCore::ThreadableLoaderClientWrapper::done):
(WebCore::ThreadableLoaderClientWrapper::didSendData):
(WebCore::ThreadableLoaderClientWrapper::didReceiveResponse):
(WebCore::ThreadableLoaderClientWrapper::didReceiveData):
(WebCore::ThreadableLoaderClientWrapper::didReceiveCachedMetadata):
(WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
(WebCore::ThreadableLoaderClientWrapper::didFail):
(WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
(WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancellation):
(WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
* page/SecurityOrigin.h:
* platform/CrossThreadCopier.h:
* platform/network/BlobData.h:
* platform/network/cf/SocketStreamHandle.h:
* storage/AbstractDatabase.h:
* storage/DatabaseAuthorizer.h:
* storage/DatabaseCallback.h:
* storage/DatabaseThread.h:
* storage/IDBCallbacks.h:
* storage/IDBCursorBackendInterface.h:
* storage/IDBDatabaseBackendInterface.h:
* storage/IDBFactoryBackendInterface.h:
* storage/IDBIndexBackendInterface.h:
* storage/IDBKey.h:
* storage/IDBKeyRange.h:
* storage/IDBObjectStoreBackendInterface.h:
* storage/IDBRequest.h:
* storage/IDBTransactionBackendInterface.h:
* storage/SQLError.h:
* storage/SQLResultSet.h:
* storage/SQLStatement.h:
* storage/SQLStatementCallback.h:
* storage/SQLStatementErrorCallback.h:
* storage/SQLTransaction.h:
* storage/SQLTransactionCallback.h:
* storage/SQLTransactionErrorCallback.h:
* websockets/ThreadableWebSocketChannelClientWrapper.h:
* workers/DefaultSharedWorkerRepository.cpp:
2011-03-20 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Clean up redirection logic in QNetworkReplyHandler
https://bugs.webkit.org/show_bug.cgi?id=56717
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
Use resetState() when constructing QNRH as well.
(WebCore::QNetworkReplyHandler::resetState):
Delete (deferred) the m_reply if one exists (only when redirecting.)
(WebCore::QNetworkReplyHandler::finish):
Return early when redirecting.
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::redirect):
Move the redirection logic from sendResponseIfNeeded() into a
separate redirect() method.
2011-03-19 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Rename ignoreHttpError() to shouldIgnoreHttpError()
The function doesn't ignore anything, thus it shouldn't have an imperative name.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::shouldIgnoreHttpError):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
2011-03-19 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Kill layer violation FIXME in ResourceHandleQt.
We were including qwebframe_p.h from WebKit/qt for no reason.
* platform/network/qt/ResourceHandleQt.cpp:
2011-03-19 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Refactor handling of deferred loads
https://bugs.webkit.org/show_bug.cgi?id=56715
Split QNetworkReplyHandler's "load mode" into two parameters
instead of trying to fit the deferral mechanism into it.
Loads are now AsynchronousLoad (default) or SynchronousLoad (for sync XHR.)
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::setLoadingDeferred):
(WebCore::QNetworkReplyHandler::resumeDeferredLoad):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::resetState):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
(WebCore::ResourceHandle::platformSetDefersLoading):
2011-03-19 Anton D'Auria <adauria@apple.com>
Reviewed by Alexey Proskuryakov.
ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
https://bugs.webkit.org/show_bug.cgi?id=56415
To delete all Application Cache for an origin, we must obsolete all
in-memory cache groups for that origin. If a cache group isn't in memory,
then it must be deleted from disk. The previous implementation correctly
removed on-disk cache groups, but did not mark in-memory cache groups as obsolete.
This caused an assertion failure in ApplicationCacheStorage::cacheGroupDestroyed()
when the DocumentLoader was destroyed.
Test: http/tests/appcache/origin-delete.html
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::clearStorageID):
(WebCore::ApplicationCache::deleteCacheForOrigin):
* loader/appcache/ApplicationCache.h:
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::findInMemoryCacheGroup):
* loader/appcache/ApplicationCacheStorage.h:
2011-03-19 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Add dummy GeolocationServiceEfl. cpp | h
https://bugs.webkit.org/show_bug.cgi?id=56710
Add dummy GeolocationServiceEfl.cpp | h to platform/efl.
* CMakeListsEfl.txt:
* platform/efl/GeolocationServiceEfl.cpp: Added.
(WebCore::GeolocationServiceEfl::create):
(WebCore::GeolocationServiceEfl::GeolocationServiceEfl):
(WebCore::GeolocationServiceEfl::~GeolocationServiceEfl):
(WebCore::GeolocationServiceEfl::startUpdating):
(WebCore::GeolocationServiceEfl::stopUpdating):
(WebCore::GeolocationServiceEfl::suspend):
(WebCore::GeolocationServiceEfl::resume):
(WebCore::GeolocationServiceEfl::lastPosition):
(WebCore::GeolocationServiceEfl::lastError):
* platform/efl/GeolocationServiceEfl.h: Added.
2011-03-19 Patrick Gansterer <paroga@webkit.org>
Unreviewed, rolling out r81551.
http://trac.webkit.org/changeset/81551
https://bugs.webkit.org/show_bug.cgi?id=55336
Broke some storage tests on Win32.
* platform/win/FileSystemWin.cpp:
(WebCore::statFile):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::fileExists):
2011-03-19 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Remove support for Qt 4.6
https://bugs.webkit.org/show_bug.cgi?id=56712
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/qt/FontQt.cpp:
(WebCore::drawTextCommon):
(WebCore::Font::drawSimpleText):
(WebCore::Font::floatWidthForSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::paint):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::getImageData):
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::transform):
* platform/network/qt/DnsPrefetchHelper.h:
(WebCore::DnsPrefetchHelper::DnsPrefetchHelper):
(WebCore::DnsPrefetchHelper::lookup):
* platform/network/qt/NetworkStateNotifierPrivate.h:
* platform/network/qt/NetworkStateNotifierQt.cpp:
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::httpMethod):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintMediaSliderTrack):
2011-03-19 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
Use Win32 API to get file information
https://bugs.webkit.org/show_bug.cgi?id=55336
Use GetFileInformationByHandle() in favour over _wstat64(), GetFileSizeEx()
and GetFileAttributesEx() so we can share the code with WinCE.
* platform/win/FileSystemWin.cpp:
(WebCore::createFileHandle):
(WebCore::getFileInformation):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::fileExists):
2011-03-19 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Simplify GObjectEventListener
https://bugs.webkit.org/show_bug.cgi?id=56698
Get rid of special case for DOMWindow, since it's also an
EventTarget.
* bindings/gobject/GObjectEventListener.cpp:
(WebCore::GObjectEventListener::GObjectEventListener): remove
DOMWindow special casing.
(WebCore::GObjectEventListener::~GObjectEventListener): ditto.
(WebCore::GObjectEventListener::gobjectDestroyed):
* bindings/gobject/GObjectEventListener.h:
(WebCore::GObjectEventListener::addEventListener): ditto.
(WebCore::GObjectEventListener::removeEventListener): ditto.
2011-03-19 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=56195
Fix conditional which had an int for one case and a pointer for another.
Similar fix as https://bugs.webkit.org/show_bug.cgi?id=56198
No new tests. Fix compilation on Solaris 10 with Sun Studio C++
* svg/SVGElement.cpp:
(WebCore::SVGElement::sendSVGLoadEventIfPossible):
2011-03-19 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Rename WTF::StringHasher methods
https://bugs.webkit.org/show_bug.cgi?id=53532
Rename createHash to computeHash and createBlobHash to hashMemory.
Also add a using WTF::StringHasher in the header file.
* dom/Document.cpp:
(WebCore::FormElementKeyHash::hash):
* dom/QualifiedName.h:
(WebCore::hashComponents):
* dom/StyledElement.cpp:
(WebCore::MappedAttributeHash::hash):
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::urlHostHash):
* page/SecurityOriginHash.h:
(WebCore::SecurityOriginHash::hash):
* platform/LinkHash.cpp:
(WebCore::visitedLinkHashInline):
* platform/cf/BinaryPropertyList.cpp:
(WebCore::IntegerArrayHash::hash):
* platform/cf/SchedulePair.h:
(WebCore::SchedulePairHash::hash):
* platform/graphics/FontCache.cpp:
(WebCore::computeHash):
* platform/graphics/chromium/FontPlatformDataChromiumWin.h:
(WebCore::FontPlatformData::RefCountedHFONT::hash):
* platform/graphics/cocoa/FontPlatformData.h:
(WebCore::FontPlatformData::hash):
* platform/graphics/pango/FontPlatformData.h:
(WebCore::FontPlatformData::hash):
* platform/graphics/wince/FontPlatformData.cpp:
(WebCore::FixedSizeFontDataKeyHash::hash):
* platform/graphics/wx/FontPlatformDataWx.cpp:
(WebCore::FontPlatformData::computeHash):
* platform/network/ProtectionSpaceHash.h:
(WebCore::ProtectionSpaceHash::hash):
* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::hash):
* plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackage::hash):
* svg/properties/SVGAnimatedPropertyDescription.h:
(WebCore::SVGAnimatedPropertyDescriptionHash::hash):
2011-03-18 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/56688> Fix clang static analyzer warning in WebCoreViewFactory.m
Reviewed by Anders Carlsson.
Fixes the following static analyzer warning:
Source/WebCore/page/mac/WebCoreViewFactory.m:45:5: warning: Returning 'self' while it is not set to the result of '[(super or self) init...]'
return self;
^
* page/mac/WebCoreViewFactory.m:
(-[WebCoreViewFactory init]): Assign the result of [super init]
to self.
2011-03-18 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
WebCore GYP build should build
https://bugs.webkit.org/show_bug.cgi?id=56696
After this patch, the WebCore GYP build successfully compiles and
links. I haven't trying executing it yet.
* WebCore.gypi:
- DOMMouseEvent should be included as part of the Objective-C bindings.
* WebCore.xcodeproj/project.pbxproj:
- RenderSVGPath.cpp was mistakenly included directly in the project
instead of being built by RenderSVGAllInOne.
* gyp/WebCore.gyp:
- Exclude some more files from the build. These files are absent
in the normal build. I didn't see them earlier because the dead
code stripping was hiding them. (They're probably unreferenced.)
- Switch to using RenderSVGAllInOne. I'm not entirely sure if this
part of the patch is necessary, but it matches the normal build
more closely.
* platform/mac/WebCoreObjCExtras.mm:
- The normal build passes the -Wdeprecated-declarations flag when
compiling this file. The GYP folks explicitly do not want to add
that feature to GYP, and there does not appear to be a way to
remove the deprecated call from this file.
* rendering/svg/RenderSVGAllInOne.cpp:
- Add RenderSVGPath.cpp, which was missing previously.
2011-03-18 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
WebCore GYP build should (almost!) link
https://bugs.webkit.org/show_bug.cgi?id=56689
This patch is a grab-bag of small changes to bring the WebCore GYP
build down to two link errors or one compile error (take your pick).
We might need a GYP change to get this last file to compile, however.
* WebCore.gypi:
* gyp/WebCore.gyp:
2011-03-16 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Add a test for r81266 and fix HTML Editing for fallback contents in object element
https://bugs.webkit.org/show_bug.cgi?id=56505
The bug was caused by canHaveChildrenForEditing's always returning false even when
object element used fallback content. Fixed the bug by adding a check.
Test: editing/editability/ignored-content.html
* editing/htmlediting.cpp:
(WebCore::canHaveChildrenForEditing):
2011-03-18 Andy Estes <aestes@apple.com>
Reviewed by Eric Seidel.
REGRESSION (r80231): Bad cast in HTMLTreeBuilder::processStartTag
https://bugs.webkit.org/show_bug.cgi?id=56380
Fix two issues with parsing a fragment that has a foreign content
element as its context element. The first issue is that the parser will
initially be in the InForeignContentMode insertion mode when processing
the first tag in the fragment in this case so one call site needs to
change from currentElement() to currentNode(). The second issue is that
when we changed fragments from using a fake HTML root element to a
DocumentFragment we broke checks that assumed the root element was in
the HTML namespace. Fix this by claiming that the DocumentFragment is
also in the HTML namespace.
Test: fast/parser/fragment-foreign-content-context.html
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isForeignContentScopeMarker):
(WebCore::HTMLElementStack::hasOnlyHTMLElementsInScope):
* html/parser/HTMLElementStack.h:
(WebCore::isInHTMLNamespace):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
2011-03-18 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
REGRESSION(78846) [chromium] Justified text renders at incorrect offsets on windows
https://bugs.webkit.org/show_bug.cgi?id=56629
Preserves offsets as absolute floating point offsets and rounds to
advances at the last possible second. I can't prove to myself that
this is sound but it seems to work on the test cases I've constructed.
Will probably change the pixel tests on chromium windows given that we
were horribly broken before this patch.
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
2011-03-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
REGRESSION(81374, 81384): editing/deleting/5206311-1.html hits assertion on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=56599
Debug build fix.
* dom/Position.cpp:
(WebCore::Position::parentAnchoredEquivalent): If the original position was a position before a node,
then we can't necessarily instantiate a position inside the node.
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::toNormalizedRange): Even if s and e were not null, container nodes of s and e
could be null. Exit early in those cases as well.
2011-03-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add ObjC bindings to the WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56671
It turns out we generate a bunch of ObjC bindings files that we don't
actually build. I've manually synced the list of ObjC derived source
files to match the existing list. This brings us down to 19 link
errors.
* WebCore.gypi:
* gyp/WebCore.gyp:
2011-03-18 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Eric Seidel.
[CMAKE] Split JSC related configurations from WebCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=56624
No new tests, just splitting jsc related configuration.
* CMakeLists.txt:
* UseJSC.cmake: Added.
2011-03-16 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Implement GPU-accelerated shadows.
https://bugs.webkit.org/show_bug.cgi?id=56476
For hard shadows, we simply offset the CTM and draw in the shadow
color. For soft shadows, we use a separable Gaussian convolution,
with a bilinear downsample and Mitchell-Netravali upsample in order to
preserve quality.
* WebCore.gypi:
Add BicubicShader and ConvolutionShader to the build.
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::State::State):
Add shadow-related members to the GLES2Canvas::State
(WebCore::GLES2Canvas::State::shadowActive):
Add a helper function to know if shadows are active.
(WebCore::GLES2Canvas::clearRect):
(WebCore::GLES2Canvas::scissorClear):
Refactor the scissor clearing function out of clearRect().
(WebCore::GLES2Canvas::fillPath):
Add hook for shadow rendering in paths. Bind framebuffer at this level.
(WebCore::GLES2Canvas::fillRect):
Add hook for shadow rendering in rects. Bind framebuffer at this level.
(WebCore::GLES2Canvas::fillRectInternal):
Rename fillRect() -> fillRectInternal(), which does bind its vertex
buffer, but does not bind the framebuffer.
(WebCore::GLES2Canvas::setShadowColor):
(WebCore::GLES2Canvas::setShadowOffset):
(WebCore::GLES2Canvas::setShadowBlur):
(WebCore::GLES2Canvas::setShadowsIgnoreTransforms):
Implement graphicsContext-style setters for shadow parameters.
(WebCore::GLES2Canvas::clipPath):
Call fillPathInternal(), not fillPath().
(WebCore::GLES2Canvas::restore):
(WebCore::GLES2Canvas::drawTexturedRect):
Bind the framebuffer at this level. Do not bind vertices here (will
be done in drawTexturedQuad).
(WebCore::GLES2Canvas::drawTexturedRectTile):
drawQuad() -> drawTexturedQuad().
(WebCore::GLES2Canvas::convolveRect):
Implement one pass of a convolution filter (X or Y).
(WebCore::gauss):
(WebCore::buildKernel):
Some helper functions to build a Gaussian convolution kernel.
(WebCore::GLES2Canvas::drawTexturedQuad):
Rename drawQuad() -> drawTexturedQuad(), to be more clear. Do not
bind the framebuffer at this level (it will be done higher).
(WebCore::GLES2Canvas::drawTexturedQuadMitchell):
Implement Mitchell-Netravali bicubic sampling, using BicubicShader.
(WebCore::GLES2Canvas::fillPathInternal):
Rename fillPath() -> fillPathInternal(), which does use quad vertices,
but does not bind the framebuffer or set the compositing mode.
(WebCore::GLES2Canvas::flipRect):
Implement a helper function to flip a rectangle in Y within the canvas.
(WebCore::GLES2Canvas::clearBorders):
Implement a helper function to clear an n-pixel border around a rect.
(WebCore::GLES2Canvas::beginShadowDraw):
Setup before drawing a primitive's shadow: for hard shadows, just
offset the CTM by the shadow offset. For soft shadows, bind to an
offscreen DrawingBuffer.
(WebCore::GLES2Canvas::endShadowDraw):
Tear-down after drawing a primitive's shadow: for hard shadows, just
restore the CTM. For soft shadows, downsample (if necessary), then
blur in X, blur in Y, upsample if necessary).
* platform/graphics/chromium/GLES2Canvas.h:
* platform/graphics/gpu/BicubicShader.cpp: Added.
(WebCore::BicubicShader::BicubicShader):
(WebCore::BicubicShader::create):
(WebCore::BicubicShader::use):
* platform/graphics/gpu/BicubicShader.h: Added.
Implement a bicubic image filtering shader.
* platform/graphics/gpu/ConvolutionShader.cpp: Added.
(WebCore::ConvolutionShader::ConvolutionShader):
(WebCore::ConvolutionShader::create):
(WebCore::ConvolutionShader::use):
* platform/graphics/gpu/ConvolutionShader.h: Added.
Implement a 1-dimensional convolution shader. In order to minimize
texture samples, this shader is parameterized at compile time by the
width of the convolution kernel.
* platform/graphics/gpu/DrawingBuffer.h:
(WebCore::DrawingBuffer::colorBuffer):
Add an accessor to retrieve a DrawingBuffer's texture ID.
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::create):
(WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
(WebCore::SharedGraphicsContext3D::useBicubicProgram):
(WebCore::SharedGraphicsContext3D::useConvolutionProgram):
Create BicubicShader and cMaxKernelWidth ConvolutionShader's (one for
each possible kernel width).
(WebCore::SharedGraphicsContext3D::getOffscreenBuffer):
Implement a simple cache of offscreen DrawingBuffers, integer-indexed.
This is done to minimize the VRAM usage: only 2 buffers are used for
all canvases.
* platform/graphics/gpu/SharedGraphicsContext3D.h:
Add bicubic and convolution shader members, and useXXX() functions.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
Hook into GraphicsContextSkia's platform shadow setters to set
parameters on GLES2Canvas.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::canAccelerate):
Remove shadows (loopers) from the list of things we can't accelerate.
2011-03-18 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Remove unused method FontFallbackList::fontDataForCharacters()
https://bugs.webkit.org/show_bug.cgi?id=56657
* platform/graphics/Font.h:
* platform/graphics/FontFallbackList.cpp:
* platform/graphics/FontFallbackList.h:
2011-03-18 Andreas Kling <kling@webkit.org>
Reverting accidental changes in r81498.
2011-03-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: rename console agent events.
https://bugs.webkit.org/show_bug.cgi?id=56646
addConsoleMessage -> consoleMessage
updateConsoleMessageExpiredCount -> consoleMessageExpiredCountUpdate
updateConsoleMessageRepeatCount -> consoleMessageRepeatCountUpdate
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::updateRepeatCountInConsole):
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessage):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageExpiredCountUpdate):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdate):
2011-03-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81487.
http://trac.webkit.org/changeset/81487
https://bugs.webkit.org/show_bug.cgi?id=56662
"Breaks inspector/styles/styles-add-blank-property.html"
(Requested by apavlov on #webkit).
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getAllStyles):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
(WebInspector.CSSStyleModel.prototype._onRevert):
(WebInspector.CSSStyleSheet):
(WebInspector.CSSStyleSheet.prototype.setText):
2011-03-18 Justin Novosad <junov@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Canvas shadow is not working with drawImage
https://bugs.webkit.org/show_bug.cgi?id=55506
Patch also fixes shadow blur quality and color.
Affects Chromium win/linux. Also fixes the following bugs:
https://bugs.webkit.org/show_bug.cgi?id=50112
https://bugs.webkit.org/show_bug.cgi?id=51989
https://bugs.webkit.org/show_bug.cgi?id=55410
No tests were added, impact is already covered by multiple layout tests.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::paintSkBitmap):
2011-03-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
https://bugs.webkit.org/show_bug.cgi?id=56310
Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
"styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
by CSSAgent.getStyleSheet() anymore.
Test: inspector/styles/get-set-stylesheet-text.html
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getAllStyleSheets):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
(WebInspector.CSSStyleModel.prototype._onRevert):
(WebInspector.CSSStyleSheet):
(WebInspector.CSSStyleSheet.prototype.setText):
2011-03-18 David Keijser <keijser@gmail.com> and Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] On-demand event-listeners for DOM event signals
https://bugs.webkit.org/show_bug.cgi?id=49649
Add explicit EventTarget API to add/remove event listeners instead
of using GSignal, which due to internal limitations in glib makes
us preemptively add listeners for all event types.
* bindings/gobject/GObjectEventListener.cpp: add new
addEventListener/removeEventListener methods, and small
refactoring to store an EventTarget internally instead of a DOM
node, which is more generic and can be reused in more cases.
* bindings/gobject/GObjectEventListener.h: ditto.
* bindings/gobject/WebKitDOMEventTarget.cpp:
(webkit_dom_event_target_add_event_listener): new iface method to
add an event listener.
(webkit_dom_event_target_remove_event_listener): new iface method
to remove an event listener.
* bindings/gobject/WebKitDOMEventTarget.h: add new iface methods.
* bindings/scripts/CodeGeneratorGObject.pm: change code generation
accordingly.
2011-03-18 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=56425
More groundwork for WebKit2 IconDatabase
-Update the synchronous method names to be prefixed with "synchronous."
-Call asynchronous versions of the appropriate methods if the IconDatabase supports them.
Update icon database calls to be prefixed with "synchronous":
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::synchronousIconDataKnownForIconURL):
(WebCore::IconDatabaseBase::synchronousLoadDecisionForIconURL):
(WebCore::IconDatabaseBase::synchronousIconForPageURL):
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::readIconForPageURLFromDisk):
(WebCore::IconDatabase::synchronousIconURLForPageURL):
(WebCore::IconDatabase::synchronousLoadDecisionForIconURL):
(WebCore::IconDatabase::synchronousIconDataKnownForIconURL):
* loader/icon/IconDatabase.h:
* loader/icon/IconDatabaseBase.cpp:
(WebCore::IconDatabaseBase::synchronousIconURLForPageURL):
Add nascent support for an asynchronous icon database mode:
* loader/icon/IconDatabaseBase.h:
(WebCore::EnumCallback::create):
(WebCore::EnumCallback::~EnumCallback):
(WebCore::EnumCallback::performCallback):
(WebCore::EnumCallback::invalidate):
(WebCore::EnumCallback::EnumCallback):
(WebCore::ObjectCallback::create):
(WebCore::ObjectCallback::~ObjectCallback):
(WebCore::ObjectCallback::performCallback):
(WebCore::ObjectCallback::invalidate):
(WebCore::ObjectCallback::ObjectCallback):
(WebCore::IconDatabaseBase::supportsAsynchronousMode):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::iconDataForIconURL):
Add interfaces to use the asynchronous versions of certain IconDatabase calls:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::iconLoadDecisionAvailable):
(WebCore::iconLoadDecisionCallback):
(WebCore::DocumentLoader::getIconLoadDecisionForIconURL):
(WebCore::DocumentLoader::continueIconLoadWithDecision):
(WebCore::iconDataCallback):
(WebCore::DocumentLoader::getIconDataForIconURL):
* loader/DocumentLoader.h:
Break "startIconLoader" into two pieces so it can be used from both the synchronous and asynchronous
icon database modes:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::iconLoadDecisionReceived):
(WebCore::FrameLoader::startIconLoader):
(WebCore::FrameLoader::continueIconLoadWithDecision):
* loader/FrameLoader.h:
* WebCore.exp.in:
2011-03-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: add missing brace to the generated Inspector.idl.
* inspector/generate-inspector-idl:
2011-03-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: migrate from Inspector.idl to InspectorAPI.json for protocol schema definition meta bug.
https://bugs.webkit.org/show_bug.cgi?id=56294
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* inspector/Inspector.idl: Removed.
* inspector/Inspector.json: Added.
* inspector/generate-inspector-idl: Added.
2011-03-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement inspector session storage.
https://bugs.webkit.org/show_bug.cgi?id=56643
We would like to enable debugger/profiler from frontend side only.
However, when user clicks "Start Debugging JavaScript" in Safari, we
need to enable debugger when frontend is opened or re-opened for the
same page. The idea is to store debugger-enabled setting in session
storage and check it on frontend load.
* inspector/InspectorFrontendClient.h:
(WebCore::InspectorFrontendClient::saveSessionSetting):
(WebCore::InspectorFrontendClient::loadSessionSetting):
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::saveSessionSetting):
(WebCore::InspectorFrontendHost::loadSessionSetting):
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
2011-03-18 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable GraphicsContext3D only when the window surface support OpenGL
https://bugs.webkit.org/show_bug.cgi?id=56555
Allow creation of WebGLRenderingContext in the HTMLCanvasElement
only if accelerated compositing is enabled. In GraphicsContext3D,
while blitting the surface check that viewport hasn't changed from
creation and painter is associated to the viewport.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::getViewportGLWidget):
(WebCore::GraphicsContext3DInternal::paint):
2011-03-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract content loading logic from scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=55237
Encapsulate source files creation logic in debugger presentation model
to support source mappings in a pluggable way.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.sourceFile):
(WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource):
(WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded):
(WebInspector.DebuggerPresentationModel.prototype._resourceForURL):
(WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
(WebInspector.DebuggerPresentationModel.prototype.reset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._sourceFileAdded):
(WebInspector.ScriptsPanel.prototype._showSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFileChanged):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
2011-03-18 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: console doesn't scroll when multiline expression is being evaluated
https://bugs.webkit.org/show_bug.cgi?id=56639
Always scoll in the console when command result is received.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.addMessage):
2011-03-18 Adam Roben <aroben@apple.com>
Fix a CFNumber leak seen on the leaks bot
Reviewed by Gavin Barraclough.
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream): Use a RetainPtr to cause the CFNumber we allocate to be
released.
2011-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add some of the remaining platform/mac files to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56616
These files used to be hard, but are now magically easy. 76 link errors.
* gyp/WebCore.gyp:
2011-03-17 Adam Klein <adamk@chromium.org>
Reviewed by Adam Barth.
[filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
https://bugs.webkit.org/show_bug.cgi?id=56502
* fileapi/Entry.idl:
* fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURL):
* fileapi/EntryBase.h:
* fileapi/EntrySync.idl:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::resolveLocalFileSystemURL):
* page/DOMWindow.h:
* page/DOMWindow.idl:
2011-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update CSP directive parser to match spec
https://bugs.webkit.org/show_bug.cgi?id=56582
Brandon updated the CSP spec. I've updated our implementation to
match. In the process, I found a couple bugs in the spec, which I've
sent to the working group. This patch assumes that the bugs will be
fixed in the way I suggested. If they get fixed a different way, we
might need to update the parser again.
Test: http/tests/security/contentSecurityPolicy/directive-parsing.html
* page/ContentSecurityPolicy.cpp:
(WebCore::isDirectiveNameCharacter):
(WebCore::isDirectiveValueCharacter):
(WebCore::advanceUntil):
(WebCore::ContentSecurityPolicy::parse):
(WebCore::ContentSecurityPolicy::parseDirective):
* page/ContentSecurityPolicy.h:
2011-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebCore GYP build should have PrivateHeaders
https://bugs.webkit.org/show_bug.cgi?id=56604
I've manually verified that this produces the correct set of
PrivateHeaders (modulo the ForwardingHeaders and icu issue).
Unforunately, this patch breakes compile slightly, but I'll fix that
in a followup patch.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* gyp/WebCore.gyp:
2011-03-17 Victoria Kirst <vrk@google.com>
Reviewed by Kenneth Russell.
[chromium] Video colors have wrong brightness/contrast
https://bugs.webkit.org/show_bug.cgi?id=56598
This patch changes the YUV to RGB color conversion matrix
to have brighter whites and darker blacks in accordance to
the BT.601 standard.
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::FragmentShaderYUVVideo::FragmentShaderYUVVideo):
(WebCore::FragmentShaderYUVVideo::init):
(WebCore::FragmentShaderYUVVideo::getShaderString):
* platform/graphics/chromium/ShaderChromium.h:
(WebCore::FragmentShaderYUVVideo::yuvAdjLocation):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::drawYUV):
* platform/graphics/chromium/VideoLayerChromium.h:
2011-03-17 Zhenyao Mo <zmo@google.com>
Reviewed by Adam Barth.
RequestAnimationFrame callbacks prevent Document from being released on detach
https://bugs.webkit.org/show_bug.cgi?id=56607
* dom/Document.cpp:
(WebCore::Document::removedLastRef): Remove RequestAnimationFrame callbacks.
(WebCore::Document::detach): Ditto.
2011-03-17 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=56596 Overlay scrollbars sometimes
fail to appear
-and corresponding-
<rdar://problem/8953779>
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
2011-03-17 Dan Bernstein <mitz@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/9052166> Emphasis marks appear over combined text rather than beside it
https://bugs.webkit.org/show_bug.cgi?id=56480
Test: fast/text/emphasis-combined-text.html
* rendering/InlineTextBox.cpp:
(WebCore::rotation): Added this helper.
(WebCore::InlineTextBox::paint): Paint a single emphasis mark beside the combined text,
centered vertically.
2011-03-17 Jian Li <jianli@chromium.org>
Reviewed by Adam Barth.
Blob URL should not be allow to get created from the code running from data URI
https://bugs.webkit.org/show_bug.cgi?id=56600
Test: http/tests/fileapi/create-blob-url-from-data-url.html
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::createPublicBlobURL):
* fileapi/BlobURL.cpp:
(WebCore::BlobURL::createBlobURL):
* fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURI):
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
2011-03-17 Jeff Miller <jeffm@apple.com>
Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
*.mode*
*.pbxuser
*.perspective*
project.xcworkspace
xcuserdata
* WebCore.xcodeproj: Modified property svn:ignore.
* manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.
2011-03-17 Sam Weinig <sam@webkit.org>
Fix Mac build.
* WebCore.exp.in:
Add missing symbol.
2011-03-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adele Peterson and Enrica Casucci.
Assert that editing does not ignore position's anchorNode if position is an offset in anchor
https://bugs.webkit.org/show_bug.cgi?id=56027
Debug build fix.
* dom/Element.cpp:
(WebCore::Element::updateFocusAppearance): "this" can be an input element so can't always instantiate
a position inside the node. Call firstPositionInOrBeforeNode instead.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::positionAvoidingPrecedingNodes): Exit early when a node's content is ignored by editing instead
of just when the node is br.
* editing/htmlediting.cpp:
(WebCore::lastEditablePositionBeforePositionInRoot): The shadow ancestor node is usually an input element
so don't instantiate a position inside it. Call firstPositionInOrBeforeNode instead.
2011-03-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81369.
http://trac.webkit.org/changeset/81369
https://bugs.webkit.org/show_bug.cgi?id=56579
breaks debugger test (Requested by podivilov on #webkit).
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
(WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
(WebInspector.DebuggerPresentationModel.prototype.reset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._parsedScriptSource):
(WebInspector.ScriptsPanel.prototype._failedToParseScriptSource):
(WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
(WebInspector.ScriptsPanel.prototype._addScript):
(WebInspector.ScriptsPanel.prototype._resourceForURL):
(WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourceFrameIfNeeded):
(WebInspector.ScriptsPanel.prototype._showSourceFrame):
(WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFileIdForScript):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
2011-03-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Justin Garcia.
Assert that editing does not ignore position's anchorNode if position is an offset in anchor
https://bugs.webkit.org/show_bug.cgi?id=56027
Added the assertion in Position::Position and Position::moveToPosition. This assertion catches
places where we instantiate positions inside a node on which editingIgnoresContent returns true.
Test: editing/execCommand/button.html
* dom/Position.cpp:
(WebCore::Position::Position): Added an assertion.
(WebCore::Position::moveToPosition): Ditto.
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::operator Position): Avoid creating a position immediately below
a node whose content is ignored by editing. While this does not avoid creation of positions
inside ignored contents completely, it works in most cases. Filed the bug 56027 to resolve
the underlying problem. Without this change, the assertion hits in existing layout tests.
cannot be tested directly.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Call firstPositionInOrBeforeNode
instead of firstPositionInNode because startNode may as well be a br element. Without this change,
the assertion hits in existing layout tests.
* editing/htmlediting.cpp:
(WebCore::canHaveChildrenForEditing): button is editable so content is not ignored. Added a test
for this.
* editing/visible_units.cpp:
(WebCore::previousBoundary): Added a FIXME.
(WebCore::startPositionForLine): Because br can also have an inline text box, checking that
startBox is an inline text box isn't an adequate to instantiate a position inside startNode.
Call startNode->isTextNode() instead. Without this change, the assertion hits in existing layout
tests.
2011-03-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract content loading logic from scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=55237
Encapsulate source files creation logic in debugger presentation model
to support source mappings in a pluggable way.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.sourceFile):
(WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource):
(WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded):
(WebInspector.DebuggerPresentationModel.prototype._resourceForURL):
(WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
(WebInspector.DebuggerPresentationModel.prototype.reset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._sourceFileAdded):
(WebInspector.ScriptsPanel.prototype._showSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFileChanged):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
2011-03-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add types markup to the IDL, remove Value types from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=56562
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::evaluateOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::setPropertyValue):
(WebCore::InjectedScript::callFrames):
(WebCore::InjectedScript::makeCall):
(WebCore::InjectedScript::makeObjectCall):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.idl:
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStyleForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::resolveNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::editScriptSource):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::identifierForInitialRequest):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::evaluateOn):
(WebCore::InspectorRuntimeAgent::getProperties):
(WebCore::InspectorRuntimeAgent::setPropertyValue):
* inspector/InspectorRuntimeAgent.h:
* inspector/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::buildInspectorArray):
* inspector/ScriptCallStack.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._createResource):
2011-03-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81350.
http://trac.webkit.org/changeset/81350
https://bugs.webkit.org/show_bug.cgi?id=56560
"Breaks twenty Chromium Webkit Win builder webkit_gpu_tests"
(Requested by apavlov on #webkit).
* WebCore.gypi:
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::State::State):
(WebCore::GLES2Canvas::clearRect):
(WebCore::GLES2Canvas::fillPath):
(WebCore::GLES2Canvas::fillRect):
(WebCore::GLES2Canvas::clipPath):
(WebCore::GLES2Canvas::restore):
(WebCore::GLES2Canvas::drawTexturedRect):
(WebCore::GLES2Canvas::drawTexturedRectTile):
(WebCore::GLES2Canvas::drawQuad):
* platform/graphics/chromium/GLES2Canvas.h:
* platform/graphics/gpu/BicubicShader.cpp: Removed.
* platform/graphics/gpu/BicubicShader.h: Removed.
* platform/graphics/gpu/ConvolutionShader.cpp: Removed.
* platform/graphics/gpu/ConvolutionShader.h: Removed.
* platform/graphics/gpu/DrawingBuffer.h:
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::create):
(WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
* platform/graphics/gpu/SharedGraphicsContext3D.h:
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::canAccelerate):
2011-03-17 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Clean up Inspector strings.
https://bugs.webkit.org/show_bug.cgi?id=56557
* English.lproj/localizedStrings.js:
2011-03-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: refactor event listener breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=56305
- restore event listener breakpoints one by one instead of using setAllBrowserBreakpoints
- store event listener breakpoints in a separate separate setting
- move presentation-related code from BreakpointManager to EventListenerBreakpointsSidebarPane
Test: inspector/debugger/event-listener-breakpoints.html
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::setFrontend):
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::clear):
* inspector/InspectorBrowserDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.setEventListenerBreakpoint):
(WebInspector.BreakpointManager.prototype.removeEventListenerBreakpoint):
(WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
(WebInspector.BreakpointManager.prototype._projectChanged):
(WebInspector.BreakpointManager.prototype._saveBreakpoints):
(WebInspector.BreakpointManager.prototype._validateBreakpoints):
(WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane):
(WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._restoreBreakpoints):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype.setStatus):
(WebInspector.CallStackSidebarPane.prototype._domBreakpointHit):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._clearInterface):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
2011-03-16 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Implement GPU-accelerated shadows.
https://bugs.webkit.org/show_bug.cgi?id=56476
For hard shadows, we simply offset the CTM and draw in the shadow
color. For soft shadows, we use a separable Gaussian convolution,
with a bilinear downsample and Mitchell-Netravali upsample in order to
preserve quality.
* WebCore.gypi:
Add BicubicShader and ConvolutionShader to the build.
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::State::State):
Add shadow-related members to the GLES2Canvas::State
(WebCore::GLES2Canvas::State::shadowActive):
Add a helper function to know if shadows are active.
(WebCore::GLES2Canvas::clearRect):
(WebCore::GLES2Canvas::scissorClear):
Refactor the scissor clearing function out of clearRect().
(WebCore::GLES2Canvas::fillPath):
Add hook for shadow rendering in paths. Bind framebuffer at this level.
(WebCore::GLES2Canvas::fillRect):
Add hook for shadow rendering in rects. Bind framebuffer at this level.
(WebCore::GLES2Canvas::fillRectInternal):
Rename fillRect() -> fillRectInternal(), which does bind its vertex
buffer, but does not bind the framebuffer.
(WebCore::GLES2Canvas::setShadowColor):
(WebCore::GLES2Canvas::setShadowOffset):
(WebCore::GLES2Canvas::setShadowBlur):
(WebCore::GLES2Canvas::setShadowsIgnoreTransforms):
Implement graphicsContext-style setters for shadow parameters.
(WebCore::GLES2Canvas::clipPath):
Call fillPathInternal(), not fillPath().
(WebCore::GLES2Canvas::restore):
(WebCore::GLES2Canvas::drawTexturedRect):
Bind the framebuffer at this level. Do not bind vertices here (will
be done in drawTexturedQuad).
(WebCore::GLES2Canvas::drawTexturedRectTile):
drawQuad() -> drawTexturedQuad().
(WebCore::GLES2Canvas::convolveRect):
Implement one pass of a convolution filter (X or Y).
(WebCore::gauss):
(WebCore::buildKernel):
Some helper functions to build a Gaussian convolution kernel.
(WebCore::GLES2Canvas::drawTexturedQuad):
Rename drawQuad() -> drawTexturedQuad(), to be more clear. Do not
bind the framebuffer at this level (it will be done higher).
(WebCore::GLES2Canvas::drawTexturedQuadMitchell):
Implement Mitchell-Netravali bicubic sampling, using BicubicShader.
(WebCore::GLES2Canvas::fillPathInternal):
Rename fillPath() -> fillPathInternal(), which does use quad vertices,
but does not bind the framebuffer or set the compositing mode.
(WebCore::GLES2Canvas::flipRect):
Implement a helper function to flip a rectangle in Y within the canvas.
(WebCore::GLES2Canvas::clearBorders):
Implement a helper function to clear an n-pixel border around a rect.
(WebCore::GLES2Canvas::beginShadowDraw):
Setup before drawing a primitive's shadow: for hard shadows, just
offset the CTM by the shadow offset. For soft shadows, bind to an
offscreen DrawingBuffer.
(WebCore::GLES2Canvas::endShadowDraw):
Tear-down after drawing a primitive's shadow: for hard shadows, just
restore the CTM. For soft shadows, downsample (if necessary), then
blur in X, blur in Y, upsample if necessary).
* platform/graphics/chromium/GLES2Canvas.h:
* platform/graphics/gpu/BicubicShader.cpp: Added.
(WebCore::BicubicShader::BicubicShader):
(WebCore::BicubicShader::create):
(WebCore::BicubicShader::use):
* platform/graphics/gpu/BicubicShader.h: Added.
Implement a bicubic image filtering shader.
* platform/graphics/gpu/ConvolutionShader.cpp: Added.
(WebCore::ConvolutionShader::ConvolutionShader):
(WebCore::ConvolutionShader::create):
(WebCore::ConvolutionShader::use):
* platform/graphics/gpu/ConvolutionShader.h: Added.
Implement a 1-dimensional convolution shader. In order to minimize
texture samples, this shader is parameterized at compile time by the
width of the convolution kernel.
* platform/graphics/gpu/DrawingBuffer.h:
(WebCore::DrawingBuffer::colorBuffer):
Add an accessor to retrieve a DrawingBuffer's texture ID.
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::create):
(WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
(WebCore::SharedGraphicsContext3D::useBicubicProgram):
(WebCore::SharedGraphicsContext3D::useConvolutionProgram):
Create BicubicShader and cMaxKernelWidth ConvolutionShader's (one for
each possible kernel width).
(WebCore::SharedGraphicsContext3D::getOffscreenBuffer):
Implement a simple cache of offscreen DrawingBuffers, integer-indexed.
This is done to minimize the VRAM usage: only 2 buffers are used for
all canvases.
* platform/graphics/gpu/SharedGraphicsContext3D.h:
Add bicubic and convolution shader members, and useXXX() functions.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
Hook into GraphicsContextSkia's platform shadow setters to set
parameters on GLES2Canvas.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::canAccelerate):
Remove shadows (loopers) from the list of things we can't accelerate.
2011-03-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Andreas Kling.
Tiled backing store should only request repaint for updated areas
https://bugs.webkit.org/show_bug.cgi?id=56464
Reuse updateBackBuffer's dirty rectangle calculations to only
invalidate the necessary parts of the window.
* platform/graphics/Tile.h:
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::updateTileBuffers):
* platform/graphics/qt/TileQt.cpp:
(WebCore::Tile::updateBackBuffer):
2011-03-17 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Reduce memory consumption by detailed heap snapshots indexes.
https://bugs.webkit.org/show_bug.cgi?id=56395
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotRetainerEdge): Added
(WebInspector.HeapSnapshotRetainerEdgeIterator): Added
(WebInspector.HeapSnapshotNode.prototype.get retainers):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.hasId):
(WebInspector.HeapSnapshot.prototype.retainers):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._buildIdsList):
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
(WebInspector.HeapSnapshot.prototype._findNodePositionInIndex):
(WebInspector.HeapSnapshot.prototype._findNearestNodeIndex):
(WebInspector.HeapSnapshot.prototype._getRetainerIndex):
(WebInspector.HeapSnapshot.prototype._markInvisibleEdges):
(WebInspector.HeapSnapshot.prototype._numbersComparator):
(WebInspector.HeapSnapshotPathFinder.prototype.get _lastEdge):
(WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
(WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
(WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
2011-03-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81243.
http://trac.webkit.org/changeset/81243
https://bugs.webkit.org/show_bug.cgi?id=56471
Breaks GTK 64-bit Debug tests (Requested by podivilov on
#webkit).
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::setFrontend):
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::setFrontend):
(WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
(WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::discardBindings):
(WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::clear):
* inspector/InspectorBrowserDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint):
(WebInspector.BreakpointManager.prototype._createEventListenerBreakpoint):
(WebInspector.BreakpointManager.prototype.setXHRBreakpoint):
(WebInspector.BreakpointManager.prototype.removeXHRBreakpoint):
(WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
(WebInspector.BreakpointManager.prototype._projectChanged):
(WebInspector.BreakpointManager.prototype._saveBreakpoints):
(WebInspector.BreakpointManager.prototype._validateBreakpoints):
(WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
(WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
(WebInspector.EventListenerBreakpoint):
(WebInspector.EventListenerBreakpoint.prototype._enable):
(WebInspector.EventListenerBreakpoint.prototype._disable):
(WebInspector.EventListenerBreakpoint.prototype._serializeToJSON):
(WebInspector.EventListenerBreakpointView):
(WebInspector.EventListenerBreakpointView.eventNameForUI):
(WebInspector.EventListenerBreakpointView.prototype.get eventName):
(WebInspector.EventListenerBreakpointView.prototype.compareTo):
(WebInspector.EventListenerBreakpointView.prototype.populateLabelElement):
(WebInspector.EventListenerBreakpointView.prototype.populateStatusMessageElement):
(WebInspector.EventListenerBreakpointView.prototype._uiEventName):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointAdded):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointHitStateChanged):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointRemoved):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._projectChanged):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
(WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
(WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._clearInterface):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
2011-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add more ObjC++ files to the build
https://bugs.webkit.org/show_bug.cgi?id=56548
96 link errors.
* WebCore.gypi:
* gyp/WebCore.gyp:
2011-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add a few Objective-C++ files to the WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56547
464 link errors.
* gyp/WebCore.gyp:
2011-03-17 Yuta Kitamura <yutak@chromium.org>
Unreviewed build fix.
Non-ASCII characters in XMLTreeViewer.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=56549
* xml/XMLTreeViewer.cpp: Replace non-ASCII characters with ASCII equivalents.
* xml/XMLTreeViewer.h: Ditto.
2011-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add plugins and bridge to the WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56546
506 link errors.
* gyp/WebCore.gyp:
2011-03-16 Jeff Johnson <github@lapcatsoftware.com>
Reviewed by Alexey Proskuryakov.
Logic error in -[WebHTMLView close]
https://bugs.webkit.org/show_bug.cgi?id=56445
The function setDraggingImageURL() is no longer called and can be deleted.
No new tests. Deleting dead code.
* page/DragController.h:
2011-03-16 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Ryosuke Niwa.
Textarea maxlength doesn't account for newlines
https://bugs.webkit.org/show_bug.cgi?id=54443
When a user presses a return key, TypingCommand::insertLineBreak() is called.
So before append a new line, check if we can add the new line.
* editing/TypingCommand.cpp:
(WebCore::canAppendNewLineFeed): Implement new helper function to check if we can add new line.
(WebCore::TypingCommand::insertLineBreak): Added check logic before adding the new line.
(WebCore::TypingCommand::insertParagraphSeparator): Added check logic before adding the new line.
2011-03-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebCore GYP build should build more derived sources
https://bugs.webkit.org/show_bug.cgi?id=56529
This patch brings us down to 597 link errors.
* gyp/WebCore.gyp:
2011-03-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebCore GYP should build (most) remaining source files
https://bugs.webkit.org/show_bug.cgi?id=56515
We're still not building all the files and we have 1305 link errors,
but this patch is progress.
* WebCore.gypi:
* gyp/WebCore.gyp:
* plugins/PluginStream.cpp:
2011-03-16 Dan Bernstein <mitz@apple.com>
Reviewed by Alexey Proskuryakov.
Update the default navigator.vendor value
https://bugs.webkit.org/show_bug.cgi?id=56449
* page/NavigatorBase.cpp: Updated the default value of
WEBCORE_NAVIGATOR_VENDOR.
2011-03-16 John Bauman <jbauman@chromium.org>
Reviewed by James Robinson.
texImage2D gets old contents of canvas
https://bugs.webkit.org/show_bug.cgi?id=56414
Always update the canvas contents in copiedImage, as there's no reason
to ask for an out-of-date image.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::copiedImage):
2011-03-16 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
Remove USE(BUILTIN_UTF8_CODEC)
https://bugs.webkit.org/show_bug.cgi?id=56508
* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerEncodingNames):
* platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps):
2011-03-16 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Viewport no longer allows an auto value for "user-scalable"
https://bugs.webkit.org/show_bug.cgi?id=55416
This restores our behavior before r67376 the default "user-scalable"
behavior can be defined by a WebKit client if a value was not
explicitly provided in web content (via the viewport <meta> tag).
Here, all WebKit ports default to "yes" after computing
viewport arguments. However, in the future they may consider
changing the default user-scalable value based on the type
of the document being viewed, a user preference, or other reasons.
Covered by existing tests. Should be no changes.
* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes): be explicit about 0.
(WebCore::findUserScalableValue): convert to return a float, the instance variable type.
* dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments): convert the boolean back to a float to
allow for 3 states. Explicit no, explicit yes, and ValueAuto to be defined by the
WebKit client.
2011-03-16 David Levin <levin@chromium.org>
Reviewed by Dmitry Titov.
REGRESSION(r81289): Fix valgrind error (and crashes) when running the chromium unit test "test_shell_test".
Conditional jump or move depends on uninitialised value(s)
WebCore::RenderLayerCompositor::RenderLayerCompositor(WebCore::RenderView*) (third_party/WebKit/Source/WebCore/rendering/RenderLayerCompositor.cpp:117)
* page/Settings.cpp:
(WebCore::Settings::Settings):
2011-03-16 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=56493 Drag-scrolling overlay
scrollbars thumb in overflow regions does not work
-and corresponding-
<rdar://problem/9112688> Drag-scrolling overlay scrollbars thumb in overflow
regions does not work
Up until now, overlay scrollbars have always been treated in the Render Tree as if
they have a thickness of 0 because they should not affect layout. However, it is
important to consider their size when hit-testing because otherwise, we have this
bug! This patch adds a boolean parameter to overflowClipRect(),
RenderLayer::verticalScrollbarWidth(), and
RenderLayer::horizontalScrollbarHeight(). This bool indicates whether to include
the actual overlay scrollbar thickness. It defaults to false and is only sent is
as true from RenderBloc::nodeAtPoint().
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::overflowClipRect):
* rendering/RenderBox.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):
* rendering/RenderLayer.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::overflowClipRect):
* rendering/RenderTable.h:
2011-03-16 Keith Kyzivat <keith.kyzivat@nokia.com>
Reviewed by Andreas Kling.
[Qt] Fix std::swap not found issue on mobile Qt devices.
https://bugs.webkit.org/show_bug.cgi?id=56463
Include <algorithm> in TextBreakIteratorQt.cpp so std::swap is found
on some Qt mobile devices.
No new tests: No tests needed - compilation verified manually.
* platform/text/qt/TextBreakIteratorQt.cpp:
(WebCore::acquireLineBreakIterator):
2011-03-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] WebGL content not shown when accelerated compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=56339
Removed all previously implemented WebGL code from GraphicsLayerQt
because API has changed. GraphicsContext3D provides PlatformLayer
that is added as a child of GraphicsLayer and is therefore painted
through QGraphicsView pipeline.
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paint):
(WebCore::GraphicsContext3DInternal::boundingRect):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::reshape):
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::paint):
(WebCore::GraphicsLayerQtImpl::flushChanges):
(WebCore::GraphicsLayerQt::setContentsToCanvas):
* platform/graphics/qt/GraphicsLayerQt.h:
2011-03-16 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Get rid of nearestMailBlockquote
https://bugs.webkit.org/show_bug.cgi?id=56439
Removed nearestMailBlockquote and replaced the calls to the function by calls
to enclosingNodeOfType and highestEnclosingNodeOfType.
Also fixed a bug in BreakBlockquoteCommand and DeleteSelectionCommand not to
respect editing boundaries. Added a test for the former command.
Test: editing/execCommand/break-non-editable-blockquote.html
* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply): No longer crosses editing boundary
when looking for a Mail blockquote.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::saveTypingStyleState): Ditto.
(WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::hasMatchingQuoteLevel):
(WebCore::handleStyleSpansBeforeInsertion):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
(WebCore::ReplaceSelectionCommand::doApply):
* editing/htmlediting.cpp:
(WebCore::enclosingNodeOfType): Check rule upfront to improve the performance.
(WebCore::highestEnclosingNodeOfType): Ditto; also add the missing check.
* editing/htmlediting.h:
(WebCore::firstPositionInOrBeforeNode): Added a null pointer check.
(WebCore::lastPositionInOrAfterNode): Ditto.
* editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup):
(WebCore::createMarkup):
2011-03-16 Jer Noble <jer.noble@apple.com>
Reviewed by Beth Dakin.
RenderFullScreen::createFullScreenStyle() leaks
https://bugs.webkit.org/show_bug.cgi?id=53384
Two problems: a) not calling release() on the style returned in setFullScreenRenderer
causes an unnecessary ref/deref, and b) the fullscreen renderer needs to be destroyed,
not just detached, when it is no longer needed.
* dom/Document.cpp:
(WebCore::Document::setFullScreenRenderer): Destroy the current renderer when a new one is set.
* rendering/RenderFullScreen.cpp:
(RenderFullScreen::createFullScreenStyle): release() the return value.
2011-03-16 Mike Reed <reed@google.com>
Reviewed by James Robinson.
Reestablish typeface/size/encoding when drawing stroked text
https://bugs.webkit.org/show_bug.cgi?id=56481
No new tests. LayoutTests/svg/css/composite-shadow-text.svg
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::paintSkiaText):
2011-03-16 Daniel Sievers <sievers@google.com>
Reviewed by James Robinson.
Add setting to always force compositing mode
https://bugs.webkit.org/show_bug.cgi?id=56156
No new tests needed as this defaults to disabled (and is unfeasible
to be tested through property overriding at runtime).
* page/Settings.h:
(WebCore::Settings::setForceCompositingMode):
(WebCore::Settings::forceCompositingMode):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
* rendering/RenderLayerCompositor.h:
2011-03-16 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Fixing backface visibility for transformed layers.
https://bugs.webkit.org/show_bug.cgi?id=56237
Test: platform/chromium/compositing/backface-visibility-transformed.html
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayer):
2011-03-16 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r76147): Dragging slider thumb is impossible or results in drawing artifacts.
https://bugs.webkit.org/show_bug.cgi?id=56469
Technically, this is not a regression, but rather uncovering of an old
problem. When the RenderSlider::layout was written, the layout state was
pushed with a wrong offset. However, since the whole slider track was
always repainted, the problem didn't manifest itself until we actually
started being more precise in our repaints.
Test: fast/repaint/slider-thumb-float.html
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout): Changed to pass actual thumb offset
to the LayoutStateMaintainer, rather than thumb size.
2011-03-16 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
Add play state callbacks to MediaControls, kill timeUpdate timer.
https://bugs.webkit.org/show_bug.cgi?id=56473
No change in behavior, covered by existing tests.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::playbackProgressTimerFired): Added a call to
media controls.
(WebCore::HTMLMediaElement::updatePlayState): Ditto.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::MediaControls): Removed initialization of the timer.
(WebCore::MediaControls::playbackProgressed): Added.
(WebCore::MediaControls::playbackStarted): Added, for now routing to just
call playbackProgressed.
(WebCore::MediaControls::playbackStopped): Ditto.
(WebCore::MediaControls::update): Removed the code to start/stop the
timer that's now gone.
* html/shadow/MediaControls.h: Removed timer decls.
2011-03-16 Bill Budge <bbudge@chromium.org>
Reviewed by David Levin.
DocumentThreadableLoaderClient needs a protected default Constructor
https://bugs.webkit.org/show_bug.cgi?id=56479
No new tests. Exposes no new functionality.
* loader/DocumentThreadableLoaderClient.h:
(WebCore::DocumentThreadableLoaderClient::DocumentThreadableLoaderClient):
2011-03-16 David Levin <levin@chromium.org>
Chromium Leopard build fix attempt #2.
Same error as before.
* bindings/v8/V8GCController.cpp:
2011-03-16 David Levin <levin@chromium.org>
Chromium Leopard build fix attempt.
The error was 'WebCore::GrouperVisitor' has a field 'WebCore::GrouperVisitor::m_grouper' whose type uses the anonymous namespace.
* bindings/v8/V8GCController.cpp:
2011-03-16 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dimitri Glazkov and Darin Adler.
Node::isContentEditable should always call parentNode() instead of parentOrHostNode()
https://bugs.webkit.org/show_bug.cgi?id=56472
Replaced the call to parentOrHostNode() in Node::isContentEditable by a call to parentNode().
Node::isContentEditable now calls parentNode() on all nodes.
No tests are added since this behavior change is not visible to scripts at the moment.
* dom/Node.cpp:
(WebCore::Node::isContentEditable):
2011-03-16 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
WK2: Need to propagate enhanced accessibility flag from UI -> web process
https://bugs.webkit.org/show_bug.cgi?id=56379
Allow the enhanced accessibility flag to be toggleable.
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):
2011-03-16 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Buildfix after r81230.
* WebCore.pri: Missing include path added.
2011-03-15 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make Structure creation require a JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=56438
Mechanical change to make all structure creation use GlobalData
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor):
* bindings/js/JSAudioConstructor.h:
(WebCore::JSAudioConstructor::createStructure):
* bindings/js/JSDOMBinding.h:
(WebCore::DOMObjectWithGlobalPointer::createStructure):
(WebCore::DOMConstructorObject::createStructure):
(WebCore::getDOMStructure):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::createStructure):
* bindings/js/JSDOMWindowBase.h:
(WebCore::JSDOMWindowBase::createStructure):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::createStructure):
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
* bindings/js/JSImageConstructor.h:
(WebCore::JSImageConstructor::createStructure):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSOptionConstructor.cpp:
(WebCore::JSOptionConstructor::JSOptionConstructor):
* bindings/js/JSOptionConstructor.h:
(WebCore::JSOptionConstructor::createStructure):
* bindings/js/JSWorkerContextBase.h:
(WebCore::JSWorkerContextBase::createStructure):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/c/CRuntimeObject.h:
(JSC::Bindings::CRuntimeObject::createStructure):
* bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::createStructure):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaRuntimeMethod::createStructure):
* bridge/jni/jsc/JavaRuntimeObject.h:
(JSC::Bindings::JavaRuntimeObject::createStructure):
* bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::createStructure):
* bridge/objc/objc_instance.mm:
(ObjCRuntimeMethod::createStructure):
* bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::createStructure):
* bridge/runtime_array.h:
(JSC::RuntimeArray::createStructure):
* bridge/runtime_method.h:
(JSC::RuntimeMethod::createStructure):
* bridge/runtime_object.h:
(JSC::Bindings::RuntimeObject::createStructure):
2011-03-16 Pratik Solanki <psolanki@apple.com>
Reviewed by Alexey Proskuryakov.
REGRESSION: Crash in adjustMIMETypeIfNecessary since r81001
https://bugs.webkit.org/show_bug.cgi?id=56345
Add NULL check for Content-Type header field.
Test: http/tests/xmlhttprequest/xmlhttprequest-no-content-type.html
* platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary):
2011-03-15 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
https://bugs.webkit.org/show_bug.cgi?id=56407
Fixing the creation of incorrect ranges from TextIterator due to passing node/offset pairs that
weren't parent-anchored. Also changing canHaveChildrenForEditing to properly handle nodes that
have had children appended to them that editing wouldn't normally allow.
Tests: editing/style/iframe-onload-crash-mac.html
editing/style/iframe-onload-crash-unix.html
editing/style/iframe-onload-crash-win.html
* editing/TextIterator.cpp:
(WebCore::TextIterator::rangeFromLocationAndLength): Passing parent-anchored values to range.
* editing/htmlediting.cpp:
(WebCore::canHaveChildrenForEditing): Adding a condition that the nodes don't already have children
for hr and datagrid, as you can append any node to another using javascript.
2011-03-16 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Report object groups and single DOM-related objects
to the new heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=53659
* Android.v8bindings.mk:
* WebCore.gypi:
* WebCore.pro:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/RetainedDOMInfo.cpp: Added.
(WebCore::RetainedDOMInfo::RetainedDOMInfo):
* bindings/v8/RetainedDOMInfo.h: Added.
* bindings/v8/RetainedObjectInfo.h: Added.
* bindings/v8/ScriptProfiler.cpp:
(WebCore::retainedDOMInfo):
(WebCore::ScriptProfiler::initialize):
* bindings/v8/ScriptProfiler.h:
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/V8GCController.cpp:
(WebCore::GroupId::GrouperItem::GrouperItem):
(WebCore::GroupId::GrouperItem::groupId):
(WebCore::GroupId::GrouperItem::createRetainedObjectInfo):
(WebCore::calculateGroupId):
(WebCore::GrouperVisitor::visitDOMWrapper):
(WebCore::GrouperVisitor::applyGrouping):
* bindings/v8/WrapperTypeInfo.h:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
(WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):
(WebInspector.DetailedHeapshotView.prototype._changeRetainingPathsRoot):
(WebInspector.DetailedHeapshotView.prototype.get isTracingToWindowObjects):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get className):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshotPathFinder.prototype.updateRoots):
(WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren):
* inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .retaining-paths-view .title > span):
(.detailed-heapshot-view .retaining-paths-to-windows):
2011-03-16 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Add WebKit2 API to figure out if an input or textarea was edited
https://bugs.webkit.org/show_bug.cgi?id=56474
Add HTMLInputElement::lastChangeWasUserEdit and HTMLTextAreaElement::lastChangeWasUserEdit
and use them to implement -[DOMHTMLInputElement _isEdited] and -[DOMHTMLTextAreaElement _isEdited]
as well as API in WebKit2.
* WebCore.exp.in:
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLInputElement _isEdited]):
(-[DOMHTMLTextAreaElement _isEdited]):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::lastChangeWasUserEdit):
* html/HTMLInputElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::lastChangeWasUserEdit):
* html/HTMLTextAreaElement.h:
2011-03-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
https://bugs.webkit.org/show_bug.cgi?id=56376
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._setDocument):
2011-03-16 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
text-combine text retains compressed font after adding characters to it
https://bugs.webkit.org/show_bug.cgi?id=56448
Test: fast/dynamic/text-combine.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Allow styles with text-combine to be shared, since
only the clones on the RenderCombineText will be mutated.
* rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange): Clone the style, to avoid mutating the parent’s
style.
(WebCore::RenderCombineText::combineText): Start off with the original font; restore it if
the text cannot be combined.
* rendering/RenderCombineText.h:
(WebCore::RenderCombineText::originalFont): Added. Returns the parent’s font.
2011-03-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: refactor event listener breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=56305
- restore event listener breakpoints one by one instead of using setAllBrowserBreakpoints
- store event listener breakpoints in a separate separate setting
- move presentation-related code from BreakpointManager to EventListenerBreakpointsSidebarPane
Test: inspector/debugger/event-listener-breakpoints.html
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::setFrontend):
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::clear):
* inspector/InspectorBrowserDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.setEventListenerBreakpoint):
(WebInspector.BreakpointManager.prototype.removeEventListenerBreakpoint):
(WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
(WebInspector.BreakpointManager.prototype._projectChanged):
(WebInspector.BreakpointManager.prototype._saveBreakpoints):
(WebInspector.BreakpointManager.prototype._validateBreakpoints):
(WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane):
(WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._restoreBreakpoints):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype.setStatus):
(WebInspector.CallStackSidebarPane.prototype._domBreakpointHit):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._clearInterface):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
2011-03-16 David Kilzer <ddkilzer@apple.com>
Minor clean-up after r81156, r81172
Follow-up for:
<http://webkit.org/b/56381> Objective-C classes should be typedef-ed as structs (not void*) in C++
* platform/graphics/GraphicsLayer.h: Removed unused @class
WebLayer declaration.
* platform/graphics/ca/PlatformCAAnimation.h: Changed typedef
struct CAPropertyAnimation to class declaration.
2011-03-16 Andrey Adaikin <aandrey@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Remove live-edit code
https://bugs.webkit.org/show_bug.cgi?id=56177
* inspector/front-end/Settings.js:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype._doubleClick):
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.set readOnly):
2011-03-16 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Martin Robinson.
[GStreamer] There is no need to set the state of the pipeline to playing, HTMLMediaElement will do it.
https://bugs.webkit.org/show_bug.cgi?id=56403
In case of a seek on a live pipeline there is no need to call gst_element_set_state(m_playBin, GST_STATE_PLAYING);
As soon as HTMLMediaElement::updatePlayState() is called (like when the data comes in) the playback will be relaunched
i.e the pause() made when beginScrubbing is done is just internal.
No new tests: Verified manually.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
2011-03-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebCore GYP build should build platform/
https://bugs.webkit.org/show_bug.cgi?id=56430
Adding platform/ to the GYP build required disabling
ALWAYS_SEARCH_USER_PATHS, which in turn required fixing some latent
style issues. I suspect we'll end up excluding some of these files
from the build in the final analysis, but we might as well fix the
style errors while we're here.
* bindings/js/JSMainThreadExecState.h:
* bindings/js/ScheduledAction.h:
* css/CSSPrimitiveValueCache.cpp:
* gyp/WebCore.gyp:
* platform/KillRingNone.cpp:
(WebCore::KillRing::append):
(WebCore::KillRing::prepend):
* platform/graphics/ContextShadow.h:
* platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
(WebCore::LoopBlinnPathProcessor::buildContours):
(WebCore::TessellationState::combineCallback):
* platform/graphics/gpu/PODRedBlackTree.h:
(WebCore::PODRedBlackTree::updateNode):
(WebCore::PODRedBlackTree::logIfVerbose):
* platform/graphics/opengl/TextureMapperGL.cpp:
* platform/graphics/opengl/TextureMapperGL.h:
* platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::save):
(WebCore::TextureMapper::paintToTarget):
* platform/graphics/texmap/TextureMapperNode.h:
2011-03-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
https://bugs.webkit.org/show_bug.cgi?id=56370
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateMessageCallback): Let the
mediaPlayerClient handle the stream error, in this case the
HTMLMediaElement will emit a stalled event.
2011-03-10 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] Frame accurate seeking isn't always accurate
https://bugs.webkit.org/show_bug.cgi?id=55217
Attempt to build the seek GstClockTime position by converting the
float time value to a GTimeVal value rounded at microsecond
precision. Additionally perform the seek with the ACCURATE seek
flag. These modifications at least fix this manual-test:
http://www.massive-interactive.nl/html5_video/smpte_test_universal.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::currentTime):
(WebCore::MediaPlayerPrivateGStreamer::seek):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2011-03-15 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: split InspectorAgent.populateScriptObjects into more granular agent-specific requests
https://bugs.webkit.org/show_bug.cgi?id=56389
Instead of sending one big request populateScriptObjects each agent requests
for initial data in its constructor.
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::pushDataCollectedOffline):
(WebCore::InspectorAgent::getPreferredPanel):
* inspector/InspectorAgent.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::setFrontend):
(WebCore::InspectorDOMAgent::restore):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setFrontend):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorProfilerAgent.h:
(WebCore::InspectorProfilerAgent::isEnabled):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/inspector.js:
2011-03-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Devirtualize isContentEditable and isRichlyContentEditable
https://bugs.webkit.org/show_bug.cgi?id=56421
Rewrote Node::isContentEditable as a non-recursive non-virtual function.
* dom/Document.cpp: Removed isContentEditable and isContentRichlyEditable.
* dom/Document.h: Ditto.
* dom/Node.cpp:
(WebCore::Node::isContentEditable): Rewritten.
* dom/Node.h:
(WebCore::Node::isContentEditable): Calls isContentEditable(Editable).
(WebCore::Node::isContentRichlyEditable): Calls isContentEditable(RichlyEditable).
* html/HTMLElement.cpp: Removed isContentEditable and isContentRichlyEditable.
* html/HTMLElement.h: Ditto.
2011-03-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebCore GYP build should build inspector/ loader/ mathml/ notifications/ and page/
https://bugs.webkit.org/show_bug.cgi?id=56412
Yay for smooth sailing.
* gyp/WebCore.gyp:
2011-03-15 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
REGRESSION(r76147): A slider thumb that is styled cannot be programmatically moved
https://bugs.webkit.org/show_bug.cgi?id=56059
Test: fast/dom/HTMLInputElement/input-slider-update-styled.html
* html/RangeInputType.cpp:
(WebCore::RangeInputType::valueChanged): Changed to use setPositionFromValue.
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromValue): Added.
(WebCore::SliderThumbElement::dragFrom): Changed to use setPositionFromPoint.
(WebCore::SliderThumbElement::setPositionFromPoint): Ditto.
(WebCore::SliderThumbElement::defaultEventHandler): Ditto.
* html/shadow/SliderThumbElement.h: Added decls.
2011-03-15 David Levin <levin@chromium.org>
Attempted build fix following r81213. Same song second verse.
* platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::encodePixels):
2011-03-15 David Levin <levin@chromium.org>
Attempted build fix for Chromium OSX release build following r81213.
* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::encodePixels): Change scoping of |pixels| to be after setjmp call.
2011-03-15 John Bauman <jbauman@chromium.org>
Reviewed by Kenneth Russell.
Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D
https://bugs.webkit.org/show_bug.cgi?id=56238
Attempt to get an ImageData (non-premultiplied) from a WebGL canvas
instead of getting an ImageBuffer, so there's a chance the data can be
passed straight through to the consumer with no premultiplication
necessary. Fixes Chromium and Safari.
Test: fast/canvas/webgl/premultiplyalpha-test.html
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toDataURL):
(WebCore::HTMLCanvasElement::getImageData):
* html/HTMLCanvasElement.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::paintRenderingResultsToImageData):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
* html/canvas/WebGLRenderingContext.h:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/ImageBuffer.h:
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::CGImageToDataURL):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageToDataURL):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):
* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::preMultipliedBGRAtoRGB):
(WebCore::RGBAtoRGB):
(WebCore::encodePixels):
(WebCore::JPEGImageEncoder::encode):
* platform/image-encoders/skia/JPEGImageEncoder.h:
* platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::preMultipliedBGRAtoRGBA):
(WebCore::encodePixels):
(WebCore::PNGImageEncoder::encode):
* platform/image-encoders/skia/PNGImageEncoder.h:
2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix, only compile the methods when the INDEXED_DATABASE feature is enabled.
* storage/IDBDatabaseCallbacksImpl.cpp:
2011-03-15 Brady Eidson <beidson@apple.com>
Build fix after r81208 for https://bugs.webkit.org/show_bug.cgi?id=56425
* loader/icon/IconDatabaseBase.h: #include instead of forward declare.
2011-03-15 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/8944558> Overlay scrollers in overflow areas need to
send notifications appropriate times (showing up, resizing)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=56067
The general strategy here is to add a HashSet of ScrollableAreas to the page that
can be accessed when necessary to send notifications to all ScrollableAreas. In
turn, all of the ScrollableArea classes that add themselves to the HashSet must
keep a weak pointer to Page so that they can remove themselves without relying on
Frames or Renderers to still have references.
Find layers for relevant node and if the layers are in the Page's ScrollableArea
set, then send the relevant notification.
* page/EventHandler.cpp:
(WebCore::layerForNode):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):
When the page is set active or not active, iterate through the Page's
ScrollableAreas to send hide/show notifications.
* page/FocusController.cpp:
(WebCore::FocusController::setActive):
When a FrameView is created, add it to the ScrollableArea set. When it's
destroyed, remove it.
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
Iterate through the Page's ScrollableAreas to send the paint notification.
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
* page/FrameView.h:
(WebCore::FrameView::disconnectFromPage):
Add the new ScrollableArea set.
* page/Page.cpp:
(WebCore::Page::~Page):
(WebCore::Page::addScrollableArea):
(WebCore::Page::removeScrollableArea):
(WebCore::Page::containsScrollableArea):
* page/Page.h:
(WebCore::Page::scrollableAreaSet):
notifyPageThatContentAreaWillPaint() is a dummy function implemented in FrameView.
* platform/ScrollView.cpp:
(WebCore::ScrollView::notifyPageThatContentAreaWillPaint):
Call notifyPageThatContentAreaWillPaint() instead of calling
contentAreaWillPaint() just for the ScrollView.
(WebCore::ScrollView::paint):
* platform/ScrollView.h:
Add/remove ScrollableAreas to the set. Add new disconnectFromPage().
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::disconnectFromPage):
* rendering/RenderDataGrid.cpp:
(WebCore::RenderDataGrid::RenderDataGrid):
(WebCore::RenderDataGrid::~RenderDataGrid):
* rendering/RenderDataGrid.h:
(WebCore::RenderDataGrid::disconnectFromPage):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::disconnectFromPage):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):
* rendering/RenderListBox.h:
(WebCore::RenderListBox::disconnectFromPage):
Should have implemented this ScrollableArea-interface function a while ago.
(WebCore::RenderLayer::currentMousePosition):
2011-03-15 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=56425
WebKit2 icon database.
* WebCore.exp.in:
2011-03-15 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
WebCore GYP build should build editing, fileapi, history, and html
https://bugs.webkit.org/show_bug.cgi?id=56411
These all went smoothly.
* gyp/WebCore.gyp:
2011-03-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebCore GYP build should build dom/
https://bugs.webkit.org/show_bug.cgi?id=56409
* gyp/WebCore.gyp:
2011-03-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebCore GYP build should build css/
https://bugs.webkit.org/show_bug.cgi?id=56408
CSSParser.cpp #includes tokenizer.cpp, which we haven't included in the
build yet. I've punted on that problem for now, but we'll come back to
it.
* gyp/WebCore.gyp:
2011-03-15 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
WebCore GYP build should build bindings/
https://bugs.webkit.org/show_bug.cgi?id=56406
I wanted to include bindings/objc in this patch, but they were somewhat
complicated. It looks like they include headers from the output
directory (via PrivateHeaders), but we haven't wired up the
PrivateHeaders yet.
* gyp/WebCore.gyp:
2011-03-15 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
Need different behavior for ensuring execution order of dynamically loaded scripts
https://bugs.webkit.org/show_bug.cgi?id=50115
Dynamically added scripts with async=false will load in parallel, but execute in order.
See: http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#force-async
Tests: fast/dom/HTMLScriptElement/script-async-attr.html
http/tests/misc/script-async-load-execute-in-order.html
* Android.mk: Rename AsyncScriptRunner -> ScriptRunner.
* CMakeLists.txt: Ditto.
* GNUmakefile.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* dom/DOMAllInOne.cpp: Ditto.
* dom/Document.cpp:
(WebCore::Document::Document): Ditto.
(WebCore::Document::~Document): Ditto.
* dom/Document.h:
(WebCore::Document::scriptRunner): Ditto.
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement): Added forceAsync and willExecuteInOrder.
(WebCore::ScriptElement::handleAsyncAttribute): Called by HTMLScriptElement when async attribute changes.
(WebCore::ScriptElement::prepareScript): Added support for forceAsync.
(WebCore::ScriptElement::notifyFinished): Tell ScriptRunner to execute in order if needed.
* dom/ScriptElement.h:
(WebCore::ScriptElement::forceAsync): Added.
* dom/ScriptRunner.cpp: Renamed from Source/WebCore/dom/AsyncScriptRunner.cpp.
(WebCore::ScriptRunner::ScriptRunner): Added in-order script queue.
(WebCore::ScriptRunner::~ScriptRunner): Ditto.
(WebCore::ScriptRunner::executeScriptSoon):
(WebCore::ScriptRunner::queueScriptForInOrderExecution): Added.
(WebCore::ScriptRunner::suspend):
(WebCore::ScriptRunner::resume):
(WebCore::ScriptRunner::timerFired): Execute in-order scripts if ready.
* dom/ScriptRunner.h: Renamed from Source/WebCore/dom/AsyncScriptRunner.h.
(WebCore::ScriptRunner::create):
(WebCore::ScriptRunner::hasPendingScripts): Check for in-order scripts too.
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::attributeChanged): Notify ScriptElement when async changes.
(WebCore::HTMLScriptElement::setAsync): Ditto.
(WebCore::HTMLScriptElement::async): Include forceAsync in calculation.
* html/HTMLScriptElement.h:
* html/HTMLScriptElement.idl: Removed Reflect from async for custom behavior.
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Rename AsyncScriptRunner -> ScriptRunner.
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): Ditto.
2011-03-15 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
pngcrush images used by inspector
https://bugs.webkit.org/show_bug.cgi?id=56426
This saves 120k in WebCore and 8k in WebKit/chromium. I ran
pngcrush -brute, so none of the meta data (ancillary chunks)
are modified.
No new tests, just compressing png files.
* inspector/front-end/Images/applicationCache.png:
* inspector/front-end/Images/auditsIcon.png:
* inspector/front-end/Images/back.png:
* inspector/front-end/Images/breakpointBorder.png:
* inspector/front-end/Images/breakpointConditionalBorder.png:
* inspector/front-end/Images/breakpointConditionalCounterBorder.png:
* inspector/front-end/Images/breakpointCounterBorder.png:
* inspector/front-end/Images/breakpointsActivateButtonGlyph.png:
* inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png:
* inspector/front-end/Images/checker.png:
* inspector/front-end/Images/clearConsoleButtonGlyph.png:
* inspector/front-end/Images/closeButtons.png:
* inspector/front-end/Images/consoleButtonGlyph.png:
* inspector/front-end/Images/consoleIcon.png:
* inspector/front-end/Images/cookie.png:
* inspector/front-end/Images/database.png:
* inspector/front-end/Images/databaseTable.png:
* inspector/front-end/Images/debuggerContinue.png:
* inspector/front-end/Images/debuggerPause.png:
* inspector/front-end/Images/debuggerStepInto.png:
* inspector/front-end/Images/debuggerStepOut.png:
* inspector/front-end/Images/debuggerStepOver.png:
* inspector/front-end/Images/disclosureTriangleSmallDown.png:
* inspector/front-end/Images/disclosureTriangleSmallDownBlack.png:
* inspector/front-end/Images/disclosureTriangleSmallDownWhite.png:
* inspector/front-end/Images/disclosureTriangleSmallRight.png:
* inspector/front-end/Images/disclosureTriangleSmallRightBlack.png:
* inspector/front-end/Images/disclosureTriangleSmallRightDown.png:
* inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png:
* inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png:
* inspector/front-end/Images/disclosureTriangleSmallRightWhite.png:
* inspector/front-end/Images/dockButtonGlyph.png:
* inspector/front-end/Images/elementsIcon.png:
* inspector/front-end/Images/enableOutlineButtonGlyph.png:
* inspector/front-end/Images/enableSolidButtonGlyph.png:
* inspector/front-end/Images/errorIcon.png:
* inspector/front-end/Images/errorMediumIcon.png:
* inspector/front-end/Images/errorRedDot.png:
* inspector/front-end/Images/excludeButtonGlyph.png:
* inspector/front-end/Images/focusButtonGlyph.png:
* inspector/front-end/Images/forward.png:
* inspector/front-end/Images/frame.png:
* inspector/front-end/Images/garbageCollectButtonGlyph.png:
* inspector/front-end/Images/gearButtonGlyph.png:
* inspector/front-end/Images/glossyHeader.png:
* inspector/front-end/Images/glossyHeaderPressed.png:
* inspector/front-end/Images/glossyHeaderSelected.png:
* inspector/front-end/Images/glossyHeaderSelectedPressed.png:
* inspector/front-end/Images/goArrow.png:
* inspector/front-end/Images/graphLabelCalloutLeft.png:
* inspector/front-end/Images/graphLabelCalloutRight.png:
* inspector/front-end/Images/helpButtonGlyph.png:
* inspector/front-end/Images/largerResourcesButtonGlyph.png:
* inspector/front-end/Images/localStorage.png:
* inspector/front-end/Images/networkIcon.png:
* inspector/front-end/Images/nodeSearchButtonGlyph.png:
* inspector/front-end/Images/paneAddButtons.png:
* inspector/front-end/Images/paneBottomGrow.png:
* inspector/front-end/Images/paneBottomGrowActive.png:
* inspector/front-end/Images/paneGrowHandleLine.png:
* inspector/front-end/Images/paneSettingsButtons.png:
* inspector/front-end/Images/pauseOnExceptionButtonGlyph.png:
* inspector/front-end/Images/percentButtonGlyph.png:
* inspector/front-end/Images/popoverArrows.png:
* inspector/front-end/Images/popoverBackground.png:
* inspector/front-end/Images/profileGroupIcon.png:
* inspector/front-end/Images/profileIcon.png:
* inspector/front-end/Images/profileSmallIcon.png:
* inspector/front-end/Images/profilesIcon.png:
* inspector/front-end/Images/profilesSilhouette.png:
* inspector/front-end/Images/programCounterBorder.png:
* inspector/front-end/Images/radioDot.png:
* inspector/front-end/Images/recordButtonGlyph.png:
* inspector/front-end/Images/recordToggledButtonGlyph.png:
* inspector/front-end/Images/reloadButtonGlyph.png:
* inspector/front-end/Images/resourceCSSIcon.png:
* inspector/front-end/Images/resourceDocumentIcon.png:
* inspector/front-end/Images/resourceDocumentIconSmall.png:
* inspector/front-end/Images/resourceJSIcon.png:
* inspector/front-end/Images/resourcePlainIcon.png:
* inspector/front-end/Images/resourcePlainIconSmall.png:
* inspector/front-end/Images/resourcesIcon.png:
* inspector/front-end/Images/resourcesSizeGraphIcon.png:
* inspector/front-end/Images/resourcesTimeGraphIcon.png:
* inspector/front-end/Images/scriptsIcon.png:
* inspector/front-end/Images/scriptsSilhouette.png:
* inspector/front-end/Images/searchSmallBlue.png:
* inspector/front-end/Images/searchSmallBrightBlue.png:
* inspector/front-end/Images/searchSmallGray.png:
* inspector/front-end/Images/searchSmallWhite.png:
* inspector/front-end/Images/segment.png:
* inspector/front-end/Images/segmentEnd.png:
* inspector/front-end/Images/segmentHover.png:
* inspector/front-end/Images/segmentHoverEnd.png:
* inspector/front-end/Images/segmentSelected.png:
* inspector/front-end/Images/segmentSelectedEnd.png:
* inspector/front-end/Images/sessionStorage.png:
* inspector/front-end/Images/splitviewDimple.png:
* inspector/front-end/Images/splitviewDividerBackground.png:
* inspector/front-end/Images/statusbarButtons.png:
* inspector/front-end/Images/statusbarMenuButton.png:
* inspector/front-end/Images/statusbarMenuButtonSelected.png:
* inspector/front-end/Images/statusbarResizerHorizontal.png:
* inspector/front-end/Images/statusbarResizerVertical.png:
* inspector/front-end/Images/successGreenDot.png:
* inspector/front-end/Images/thumbActiveHoriz.png:
* inspector/front-end/Images/thumbActiveVert.png:
* inspector/front-end/Images/thumbHoriz.png:
* inspector/front-end/Images/thumbHoverHoriz.png:
* inspector/front-end/Images/thumbHoverVert.png:
* inspector/front-end/Images/thumbVert.png:
* inspector/front-end/Images/timelineBarBlue.png:
* inspector/front-end/Images/timelineBarGray.png:
* inspector/front-end/Images/timelineBarGreen.png:
* inspector/front-end/Images/timelineBarOrange.png:
* inspector/front-end/Images/timelineBarPurple.png:
* inspector/front-end/Images/timelineBarRed.png:
* inspector/front-end/Images/timelineBarYellow.png:
* inspector/front-end/Images/timelineCheckmarks.png:
* inspector/front-end/Images/timelineDots.png:
* inspector/front-end/Images/timelineHollowPillBlue.png:
* inspector/front-end/Images/timelineHollowPillGray.png:
* inspector/front-end/Images/timelineHollowPillGreen.png:
* inspector/front-end/Images/timelineHollowPillOrange.png:
* inspector/front-end/Images/timelineHollowPillPurple.png:
* inspector/front-end/Images/timelineHollowPillRed.png:
* inspector/front-end/Images/timelineHollowPillYellow.png:
* inspector/front-end/Images/timelineIcon.png:
* inspector/front-end/Images/timelinePillBlue.png:
* inspector/front-end/Images/timelinePillGray.png:
* inspector/front-end/Images/timelinePillGreen.png:
* inspector/front-end/Images/timelinePillOrange.png:
* inspector/front-end/Images/timelinePillPurple.png:
* inspector/front-end/Images/timelinePillRed.png:
* inspector/front-end/Images/timelinePillYellow.png:
* inspector/front-end/Images/toolbarItemSelected.png:
* inspector/front-end/Images/trackHoriz.png:
* inspector/front-end/Images/trackVert.png:
* inspector/front-end/Images/treeDownTriangleBlack.png:
* inspector/front-end/Images/treeDownTriangleWhite.png:
* inspector/front-end/Images/treeRightTriangleBlack.png:
* inspector/front-end/Images/treeRightTriangleWhite.png:
* inspector/front-end/Images/treeUpTriangleBlack.png:
* inspector/front-end/Images/treeUpTriangleWhite.png:
* inspector/front-end/Images/undockButtonGlyph.png:
* inspector/front-end/Images/userInputIcon.png:
* inspector/front-end/Images/userInputPreviousIcon.png:
* inspector/front-end/Images/userInputResultIcon.png:
* inspector/front-end/Images/warningIcon.png:
* inspector/front-end/Images/warningMediumIcon.png:
* inspector/front-end/Images/warningOrangeDot.png:
* inspector/front-end/Images/warningsErrors.png:
2011-03-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Crash in ReplaceSelectionCommand::doApply when inserting a node under a document node
https://bugs.webkit.org/show_bug.cgi?id=56372
The bug was caused by insertNodeAfter's calling parentElement on document's child.
Fixed this by changing the node that AppendNodeCommand takes.
There was also a bug that document node always returned false for isContentEditable
and isContentRichlyEditable because they never overrode Node's default implementation.
Fixed this by overriding them in Document.
Test: editing/execCommand/append-node-under-document.html
* dom/Document.cpp:
(WebCore::Document::isContentEditable): Added.
(WebCore::Document::isContentRichlyEditable): Added.
* dom/Document.h:
* editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::AppendNodeCommand): Takes ContainerNode instead of Element.
* editing/AppendNodeCommand.h:
(WebCore::AppendNodeCommand::create): Ditto.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::appendNode): Ditto.
(WebCore::CompositeEditCommand::insertNodeAfter): Calls parentNode instead of parentElement.
* editing/CompositeEditCommand.h:
2011-03-15 David Grogan <dgrogan@chromium.org>
Reviewed by Jeremy Orlow.
Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=56350
When a frame is unloaded, ScriptExecutionContext::stopActiveDOMObjects
calls stop() on each ActiveDOMObject.
Calling IDBDatabase::stop() can cause IDBDatabase to be destroyed:
* IDBDatabase::stop() causes the chrome message dispatcher to remove
its reference to IDBDatabase, which it has as type
IDBDatabaseCallbacks.
* If that reference is the last one, the IDBDatabase is destroyed.
* Destroying an ActiveDOMObject while they are being iterated over causes
a defensive crash.
This change creates a separate IDBDatabaseCallbacks object that is not
an ActiveDOMObject, so it can be destroyed by
ScriptExecutionContext::stopActiveDOMObjects.
Because the chrome message dispatcher is only used in multi-process
chromium, that's the only platform affected. Chromium browser tests
forthcoming.
* WebCore.gypi:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::open):
* storage/IDBDatabase.h:
* storage/IDBDatabaseCallbacks.h:
(WebCore::IDBDatabaseCallbacks::unRegisterDatabase):
* storage/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h.
(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::onVersionChange):
(WebCore::IDBDatabaseCallbacksImpl::unRegisterDatabase):
* storage/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h.
(WebCore::IDBDatabaseCallbacksImpl::~IDBDatabaseCallbacksImpl):
2011-03-15 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
accessibility should build in WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56405
This patch changes our include/exclude strategy to more closely match
the strategy used by the Chromium GYP build system. Ideally, we'd find
a way to share more of these patterns. In the meantime, I'm going to
slowly increase the number of translation units in the project and
adjust the include/exclude filters appropriately.
* gyp/WebCore.gyp:
2011-03-15 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
REGRESSION (WebKit2): keygen element doesn't work
https://bugs.webkit.org/show_bug.cgi?id=56402
<rdar://problem/9006545>
Covered by existing regresison tests.
* English.lproj/Localizable.strings:
* WebCore.exp.in: Removed WebCoreKeyGenerator, which no longer exists. Added
_wkSignedPublicKeyAndChallengeString, so that this WKSI function could be used in WebCore.
* platform/mac/SSLKeyGeneratorMac.mm: Removed.
* platform/mac/WebCoreKeyGenerator.h: Removed.
* platform/mac/WebCoreKeyGenerator.m: Removed.
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* WebCore.xcodeproj/project.pbxproj:
Renamed SSLKeyGeneratorMac.mm to .cpp, as it doesn't use any Objective C any more.
Removed WebCoreKeyGenerator, as we no longer need an interface to WebKit.
* platform/LocalizationStrategy.h:
* platform/LocalizedStrings.cpp:
(WebCore::keygenMenuItem512):
(WebCore::keygenMenuItem1024):
(WebCore::keygenMenuItem2048):
(WebCore::keygenKeychainItemName):
* platform/LocalizedStrings.h:
Added strings used by keygen element, now that the code using them is in WebCore.
* platform/mac/SSLKeyGeneratorMac.cpp: Copied from Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm.
(WebCore::getSupportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):
Moved the code from WebKit. There is never any need to provide implementation at runtime,
like old code was doing.
* platform/win/SSLKeyGeneratorWin.cpp: (WebCore::WebCore::getSupportedKeySizes):
Added a FIXME about localization. Note that Safari for Windows doesn't support keygen.
2011-03-15 Anders Carlsson <andersca@apple.com>
Fix clang build.
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/GraphicsLayer.h:
2011-03-15 Simon Fraser <simon.fraser@apple.com>
Fix Lion build after r81161.
Pass the PlatformCALayer down into drawLayerContents()
so we can use its acceleratesDrawing() method.
* platform/graphics/mac/WebLayer.h:
* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
(-[WebLayer drawInContext:]):
* platform/graphics/mac/WebTiledLayer.mm:
(-[WebTiledLayer drawInContext:]):
2011-03-15 Alok priyadarshi <alokp@chromium.org>
Reviewed by James Robinson.
Valgrind error due to uninitialized PluginLayerChromium::m_textureId
https://bugs.webkit.org/show_bug.cgi?id=56390
* platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::PluginLayerChromium):
* platform/graphics/chromium/PluginLayerChromium.h:
(WebCore::PluginLayerChromium::textureId):
2011-03-14 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
REGRESSION (r68976): Incorrect bidi rendering in SVG text
https://bugs.webkit.org/show_bug.cgi?id=53980
rework the test engine or SVG "text-intro" tests so we can turn them back on
https://bugs.webkit.org/show_bug.cgi?id=6524
svg/W3C-SVG-1.1/text-intro-0*.svg fail when MS Office fonts are present
https://bugs.webkit.org/show_bug.cgi?id=11662
svg/batik/text/textBiDi.svg failing
https://bugs.webkit.org/show_bug.cgi?id=17392
SVG bidi examples at w3C I18N WG tutorials are not rendered correctly.
https://bugs.webkit.org/show_bug.cgi?id=24374
Implement proper bidirectionality support for SVG text.
BiDi didn't work properly until now, because the x/y/dx/dy/rotate value lists are stored in logical order (aka. in
the order the characters appear in the markup), and when laying out bidi text, we associated the current character
in visual order with the current x/y/dx/dy/rotate value in logical order, messing up RTL text layout.
The BiDi algorithm itself, inherited by RenderBlockLineLayout, works just fine, the inline box tree is correct.
Long story:
Before the inline box tree is created, SVGTextLayoutAttributesBuilder builds a list of x/y/dx/dy/rotate/<text metrics>
for each RenderSVGInlineText* object, called SVGTextLayoutAttributes. This happens in logical order, as specified in
the markup. <text x="10 20" y="10">abcdef</text> creates a SVGTextLayoutAttributes object in the renderer associated with
"abcdef" that contains (10, 20) for x, (10) for y, the dx/dy/rotate lists are empty, and the SVGTextMetrics list holds 6
width/height values for each of the glyphs (and some other infromation, see SVGTextMetrics class).
The SVGTextLayoutAttributes object is _used by_ RenderBlockLineLayout when applying the BiDi algorithm as SVG demands
that BiDi reordering does not happen across text chunks (a text chunk is defined by an absolute position, eg. x="10").
To summarize: SVGTextLayoutAttributes are stored in all RenderSVGInlineText renderers, caching the metrics of all
characters, their position based on the DOM attributes x/y/dx/dy/rotate. Using that information it's possible to
determine whether a position starts a new text chunk, and that's used by RenderBlockLineLayout to create the
inline box tree, in _visual order_, as it will appear on screen.
After the inline box tree is created, the SVGRootInlineBox traverses its children in visual order and feeds the
found text boxes to SVGTextLayoutEngine, which lays out the text on a line or a path, according to SVG text layout
rules. For each character of the passed in InlineTextBox, it determines the x/y/dx/dy/rotate value, and the position
in the <text metrics> list of the renderer. The problem here is that the passed in text boxes are in visual order,
the x/y/.. lists are all in logical order.
Example: <text direction="rtl" unicde-bidi="bidi-override" x="10 20">abcdef</text>, reverse the text direction:
the visual order now is: "fedcba", where 'f' should be associated with x="10" and 'e' with x="20".
Fix that problem, by computing a list of text boxes in _logical_ order in advance and pass it to SVGTextLayoutEngine,
before it starts processing the boxes in visual order, fed by SVGRootInlineBox. When laying oout text, we can now
process text in visual order, but grab the x/y/.. coordinates from the renderer in logical order.
Some more work was needed to truly fix Arabic. The SVGTextLayoutAttributesBuilder measured all characters isolated,
which is not a problem with latin text, but results in wrong advances for Arabic text, as isolated forms, instead of
shaped forms are measured. This broke text-anchor support, text queries on Arabic text etc. Fixed now, covered by
dozens of new tests.
Tests: svg/W3C-I18N/g-dirLTR-ubNone.svg
svg/W3C-I18N/g-dirLTR-ubOverride.svg
svg/W3C-I18N/g-dirRTL-ubNone.svg
svg/W3C-I18N/g-dirRTL-ubOverride.svg
svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg
svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle.svg
svg/W3C-I18N/text-anchor-dirLTR-anchorStart.svg
svg/W3C-I18N/text-anchor-dirNone-anchorEnd.svg
svg/W3C-I18N/text-anchor-dirNone-anchorMiddle.svg
svg/W3C-I18N/text-anchor-dirNone-anchorStart.svg
svg/W3C-I18N/text-anchor-dirRTL-anchorEnd.svg
svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle.svg
svg/W3C-I18N/text-anchor-dirRTL-anchorStart.svg
svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd.svg
svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle.svg
svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart.svg
svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd.svg
svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle.svg
svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart.svg
svg/W3C-I18N/text-anchor-no-markup.svg
svg/W3C-I18N/text-dirLTR-ubNone.svg
svg/W3C-I18N/text-dirLTR-ubOverride.svg
svg/W3C-I18N/text-dirRTL-ubNone.svg
svg/W3C-I18N/text-dirRTL-ubOverride.svg
svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context.svg
svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context.svg
svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context.svg
svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context.svg
svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg
svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context.svg
svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context.svg
svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context.svg
svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg
svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context.svg
svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg
svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context.svg
svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context.svg
svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context.svg
svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context.svg
svg/W3C-I18N/tspan-direction-ltr.svg
svg/W3C-I18N/tspan-direction-rtl.svg
svg/W3C-SVG-1.1-SE/text-intro-02-b.svg
svg/W3C-SVG-1.1-SE/text-intro-05-t.svg
svg/W3C-SVG-1.1-SE/text-intro-09-b.svg
svg/W3C-SVG-1.1/text-align-08-b.svg
svg/W3C-SVG-1.1/text-fonts-03-t.svg
svg/W3C-SVG-1.1/text-intro-01-t.svg
svg/W3C-SVG-1.1/text-intro-02-b.svg
svg/W3C-SVG-1.1/text-intro-03-b.svg
svg/W3C-SVG-1.1/text-intro-04-t.svg
svg/text/bidi-reorder-value-lists.svg
svg/text/bidi-text-anchor-direction.svg
svg/text/bidi-text-query.svg
svg/text/bidi-tspans.svg
* rendering/RenderBlockLineLayout.cpp: Remove hack that forced LTR support when unicode-bidi="normal" and handling SVG text.
(WebCore::RenderBlock::determineStartPosition):
* rendering/svg/SVGInlineTextBox.cpp: s/fragment.positionListOffset/fragment.characterOffset/
(WebCore::SVGInlineTextBox::offsetForPositionInFragment):
(WebCore::SVGInlineTextBox::constructTextRun):
(WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
* rendering/svg/SVGRenderTreeAsText.cpp: Ditto.
(WebCore::writeSVGInlineTextBox):
* rendering/svg/SVGRootInlineBox.cpp: Add new buildTextBoxListInLogicalOrder(), collecting all text boxes recursively in logical order (aka. as specified in markup).
This is needed as we have to process x/y/dx/dy/rotate value lists of text/tspan/.. elements in logical order, not in visual
order as the characters are presented on screen.
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::buildTextBoxListInLogicalOrder):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
* rendering/svg/SVGRootInlineBox.h:
* rendering/svg/SVGTextChunk.cpp: Cleanup code, minimize SVGTextChunks memory consumption.
(WebCore::SVGTextChunk::SVGTextChunk): A text chunk now know whether its base progress direction is left-to-right or right-to-left.
(WebCore::SVGTextChunk::calculateLength):
(WebCore::SVGTextChunk::calculateTextAnchorShift): Make text-anchor direction aware. text-anchor="start/end" meaning depends on the context (ltr vs. rtl).
* rendering/svg/SVGTextChunk.h: Adapt code, merging three members into a bitfield.
(WebCore::SVGTextChunk::isVerticalText):
(WebCore::SVGTextChunk::hasDesiredTextLength):
(WebCore::SVGTextChunk::hasTextAnchor):
(WebCore::SVGTextChunk::hasLengthAdjustSpacing):
(WebCore::SVGTextChunk::hasLengthAdjustSpacingAndGlyphs):
* rendering/svg/SVGTextChunkBuilder.cpp: Adapt to SVGTextChunk code changes.
(WebCore::SVGTextChunkBuilder::addTextChunk):
(WebCore::SVGTextChunkBuilder::processTextChunk):
* rendering/svg/SVGTextFragment.h: Add metricsListOffset, needed only while laying out text.
(WebCore::SVGTextFragment::SVGTextFragment): Rename positionListOffset to characterOffset, as it describes an offset in the textRenderer->characters() array.
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp
(WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): Fix measuring Arabic text in LTR/RTL modes. Assure that each SVGTextMetrics object
that we cache, refers to the _rendered_ character. For Arabic text that means, that we're
measuring the shaped width of the glyph, not the glyph in its isolated form. Without that
fix reordering boxes containing Arabic is wrong.
* rendering/svg/SVGTextLayoutEngine.cpp: SVGTextLayoutEngine is fed with text boxes to be laid out in _visual_ order, left-to-right, after the BiDi algorithm
has been applied by RenderBlockLineLayout to create the inline box tree. The coordinates lists x/y/dx/dy/rotate have
to be processed in _logical_ order. SVGRootInlineBox now passes a list of text boxes in logical order to SVGTextLayoutEngine,
to assure it grabs the coordinates from the correct InlineTextBox. See examples at the top of the ChangeLog.
(WebCore::SVGTextLayoutEngine::SVGTextLayoutEngine):
(WebCore::SVGTextLayoutEngine::recordTextFragment): No need to measure text here anymore, SVGTextLayoutAttributesBuilder now provides exact advances for each glyph.
The width of a SVGTextFragment is always equal to the sum of each glyph advance. (This was not the case for
Arabic until now.)
(WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
(WebCore::SVGTextLayoutEngine::nextLogicalBoxAndOffset): Computes the next logical box and the offset to the next coordinate value in its position list.
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
* rendering/svg/SVGTextLayoutEngine.h: Add CharacterRange helper struct.
(WebCore::SVGTextLayoutEngine::CharacterRange::CharacterRange):
* rendering/svg/SVGTextMetrics.cpp: Remove unused measureAllCharactersIndividually() method.
(WebCore::constructTextRun): Pass direction and unicode-bidi="override" values to the TextRun, otherwhise LTR is always asumed.
* rendering/svg/SVGTextMetrics.h:
(WebCore::SVGTextMetrics::setWidth): Add private setter, only SVGTextLayoutAttributesBuilder is allowed to modify the metrics (to fix up glyph widths for Arabic).
* rendering/svg/SVGTextQuery.cpp: s/fragment.positionListOffset/fragment.characterOffset/
(WebCore::SVGTextQuery::subStringLengthCallback):
(WebCore::SVGTextQuery::startPositionOfCharacterCallback):
(WebCore::SVGTextQuery::endPositionOfCharacterCallback):
(WebCore::calculateGlyphBoundaries):
2011-03-15 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix make distcheck for 1.3.13 release
https://bugs.webkit.org/show_bug.cgi?id=56371
No new tests as this is a build fix.
* GNUmakefile.am: added a couple of missing files.
2011-03-08 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Get rid of firstDeepEditingPositionForNode and lastDeepEditingPositionForNode
https://bugs.webkit.org/show_bug.cgi?id=52642
Replacing calls to first/lastDeepEditingPositionForNode with calls to their analogous
functions that create new positions. Also fixing various parts of editing code that
incorrectly handled the new positions now being created.
No new tests as this is refactoring/cleanup.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionRange):
* dom/Position.cpp:
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::atFirstEditingPositionForNode):
(WebCore::Position::atLastEditingPositionForNode):
(WebCore::Position::upstream):
(WebCore::Position::isCandidate):
(WebCore::Position::getInlineBoxAndOffset):
* dom/Position.h:
(WebCore::operator==):
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::operator Position):
* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
* editing/DeleteSelectionCommand.cpp:
(WebCore::isTableCellEmpty):
(WebCore::DeleteSelectionCommand::removeNode):
* editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::unlistifyParagraph):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::forwardDeleteKeyPressed):
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::selectionFromContentsOfNode):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
* editing/htmlediting.cpp:
(WebCore::firstEditablePositionAfterPositionInRoot):
(WebCore::lastEditablePositionBeforePositionInRoot):
(WebCore::enclosingEmptyListItem):
* editing/htmlediting.h:
* editing/visible_units.cpp:
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
(WebCore::startOfEditableContent):
(WebCore::endOfEditableContent):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionForPoint):
2011-03-15 Beth Dakin <bdakin@apple.com>
Attempted build fix.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::cancelAnimations):
2011-03-15 David Hyatt <hyatt@apple.com>
Reviewed by Dave Levin.
https://bugs.webkit.org/show_bug.cgi?id=56329
Fix FontCache problems on Linux. Make sure not to mutate the platform data passed in to SimpleFontData's
constructor. Change this code to match Mac and to set the new m_hasVerticalGlyphs boolean instead of
mutating orientation.
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformInit):
2011-03-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Disable ShadowBlur shadow drawing in accelerated contexts
https://bugs.webkit.org/show_bug.cgi?id=56392
When drawing into a graphics context that is accelerated, don't use
ShadowBlur, because it may be slower.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::setIsCALayerContext):
(WebCore::GraphicsContext::isCALayerContext):
(WebCore::GraphicsContext::setIsAcceleratedContext):
(WebCore::GraphicsContext::isAcceleratedContext):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
2011-03-15 Beth Dakin <bdakin@apple.com>
Reviewed by Simon Fraser.
Fix for <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
Tell the ScrollAnimator to cancelAnimations() since we are navigating to a new
page.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
Scroll animations should be suspended if the FrameLoadState is anything but
complete.
* page/FrameView.cpp:
(WebCore::FrameView::shouldSuspendScrollAnimations):
* page/FrameView.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::shouldSuspendScrollAnimations):
* rendering/RenderDataGrid.cpp:
(WebCore::RenderDataGrid::shouldSuspendScrollAnimations):
* rendering/RenderDataGrid.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldSuspendScrollAnimations):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::shouldSuspendScrollAnimations):
* rendering/RenderListBox.h:
New virtual function cancelAnimations() is only needed on the Mac, so the base
class is empty.
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::cancelAnimations):
ScrollAnimatorMac needs to keep track of whether the page has been scrolled since
it started loading. If so, we will override optimizations that wait for the
FrameLoadState to be complete before animating scrollbars.
* platform/mac/ScrollAnimatorMac.h:
(WebCore::ScrollAnimatorMac::haveScrolledSincePageLoad):
If the scrollbar animations should be suspended, we start a timer to make sure
that we do flash the scrollbars. Animating the scrollbars is expensive, so this is
both a performance optimization and a UI enhancement since the scrollbar won't
jump around nearly as much on a page load.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate cancelAnimations]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::startScrollbarPaintTimer):
(WebCore::ScrollAnimatorMac::scrollbarPaintTimerIsActive):
(WebCore::ScrollAnimatorMac::stopScrollbarPaintTimer):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
New WebCoreSystemInterface function to force the scrollbars to flash
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
2011-03-15 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
Remove stale comment at RenderStyle::diff.
https://bugs.webkit.org/show_bug.cgi?id=56387
* rendering/style/RenderStyle.cpp: Removed comment.
2011-03-15 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/56381> Objective-C classes should be typedef-ed as structs (not void*) in C++
Reviewed by Simon Fraser.
Typedef-ing Objective-C classes as void* for pure C++ makes it
easier for bugs to creep in because compilers can't do any type
checking for void pointers.
* platform/graphics/GraphicsContext3D.h: Changed typedef
declarations for CALayer and WebGLLayer from void* to structs.
(WebCore::GraphicsContext3D::platformLayer): Changed
static_cast<CALayer*> to reinterpret_cast<CALayer*> now that
CALayer and WebGLLayer are not void pointers.
* platform/graphics/GraphicsLayer.h: Changed typedef declaration
for PlatformLayer from void* to struct CALayer.
* platform/graphics/ca/PlatformCAAnimation.h: Changed typedef
declaration for CAPropertyAnimation from void* to a struct.
Extracted typdef for PlatformAnimationRef.
2011-03-15 Ilya Sherman <isherman@chromium.org>
Reviewed by Tony Chang.
Autofilled form elements are assigned fixed background color but not text color
https://bugs.webkit.org/show_bug.cgi?id=48382
Test: fast/forms/input-autofilled.html
* css/html.css:
(input:-webkit-autofill): Added foreground color: #000000
* css/wml.css:
(input:-webkit-autofill): Added foreground color: #000000
2011-03-15 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Eric Carlson.
HTMLMediaElement::mediaPlayerPlaybackStateChanged should not change the "public" state of the element
if it's an internal pause for example.
https://bugs.webkit.org/show_bug.cgi?id=56374
In case of an internal pause, the callback from the mediaplayer should be ignored to avoid reflecting the
change into the DOM.
No new tests: Verified manually.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged):
2011-03-12 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: re-implement xhr breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=56252
- restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
- store xhr breakpoints in a separate setting
- move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane
Test: inspector/debugger/xhr-breakpoints.html
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
(WebCore::InspectorBrowserDebuggerAgent::clear):
* inspector/InspectorBrowserDebuggerAgent.h:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.setXHRBreakpoint):
(WebInspector.BreakpointManager.prototype.removeXHRBreakpoint):
(WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
(WebInspector.BreakpointManager.prototype._projectChanged):
(WebInspector.BreakpointManager.prototype._validateBreakpoints):
(WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.XHRBreakpointsSidebarPane):
(WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing):
(WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
(WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
(WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing):
(WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):
(WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
(WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints):
(WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints):
(WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._clearInterface):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/inspector.js:
(WebInspector.resetFocusElement):
(WebInspector.set attached):
2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Darin Adler.
Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
info into the headers rather than in export symbol definition files, but disable it on
all platforms initially so we can deal with port build issues one port at a time.
https://bugs.webkit.org/show_bug.cgi?id=27551
* config.h:
* platform/mac/LoggingMac.mm:
2011-03-15 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix.
Chromium: shared lib linux build are failing.
Two exclude rules for LocalizedNumberNone and TextEncodingDetectorNone were added to the wrong library.
It was webcore_remaining instead of webcore_platform.
* WebCore.gyp/WebCore.gyp:
2011-03-15 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: expanding/collapsing object shouldn't affect outer console.group expansion state
https://bugs.webkit.org/show_bug.cgi?id=56373
* inspector/front-end/Section.js:
(WebInspector.Section):
(WebInspector.Section.prototype.toggleExpanded):
(WebInspector.Section.prototype.handleClick): stop click even propagation if it was handled by this section.
2011-03-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: crash upon "//html//@id" search in elements panel.
https://bugs.webkit.org/show_bug.cgi?id=56334
* inspector/InspectorDOMAgent.cpp:
* inspector/front-end/ElementsTreeOutline.js:
2011-03-15 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: further extension API cleanup (removed inspectedPage, add experimental prefix)
https://bugs.webkit.org/show_bug.cgi?id=56327
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI):
* inspector/front-end/ExtensionAPISchema.json:
2011-03-15 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: when console.groupEnd calls twice
https://bugs.webkit.org/show_bug.cgi?id=56114
Test: inspector/console/console-nested-group.html
* inspector/ConsoleMessage.h:
(WebCore::ConsoleMessage::type):
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addConsoleMessage): do not coalesce adjacent EndGroup messages.
2011-03-15 Chris Mumford <chris.mumford@palm.com>
Reviewed by Adam Barth.
Initializing several member variables that were not initialized in
their constructors. These values were all read prior to initialization
as reported by Valgrind.
No new tests: No feature additions/removals.
* accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
* xml/XPathResult.cpp:
(WebCore::XPathResult::XPathResult):
2011-03-15 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=56255
Fix build on Solaris 10/Sun Studio 12 C++
No new tests. This is to fix compilation on Solaris 10 with Sun Studio 12 C++
* bridge/runtime_array.h:
(JSC::RuntimeArray::getConcreteArray):
2011-03-14 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben
about:blank fake responses don't get serialized when sent the UIProcess
<rdar://problem/9108119>
https://bugs.webkit.org/show_bug.cgi?id=56357
Test: AboutBlankLoad
* platform/network/cf/ResourceResponse.h:
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::cfURLResponse):
Create a CFURLResponseRef if one does not exist yet as we do for
NSURLResponses on the mac.
2011-03-14 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Seeking videos using the timeline bar does not work properly and stop the video playback.
https://bugs.webkit.org/show_bug.cgi?id=56145
We do not need seekTimeout and queuedSeekTimeout anymore. setPosition on QMediaPlayer is good enough.
positionChanged() will be emitted when the data is buffered. On Linux the signal was not emitted because
of a bug in QtMultimedia.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::seek):
(WebCore::MediaPlayerPrivateQt::stateChanged):
(WebCore::MediaPlayerPrivateQt::positionChanged):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
2011-03-14 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=44138
Crash beneath SocketStreamHandle::readStreamCallback when running websocket/tests/workers/worker-handshake-challenge-randomness.html
https://bugs.webkit.org/show_bug.cgi?id=55375
http/tests/websocket/tests/reload-crash.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
https://bugs.webkit.org/show_bug.cgi?id=56185
http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
* platform/network/cf/SocketStreamHandle.h: Made SocketStreamHandle ThreadSafeShared, so that
a pointer can be passed across threads when wrapped in a RefPtr.
* platform/network/cf/SocketStreamHandleCFNet.cpp: Make sure that an object still exists
when executing a method on main thread by using RefPtr.
2011-03-14 Sam Weinig <sam@webkit.org>
Mac build fix. Part 1 of N.
* WebCore.exp.in:
2011-03-14 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Eric Carlson.
Stalled media elements don't stop delaying the load event
https://bugs.webkit.org/show_bug.cgi?id=56316
We should stop delaying the load event when the load has
stalled naturally, or if we require a user gesture to
continue the load.
Test: http/tests/media/video-play-stall-before-meta-data.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setNetworkState): when suspending, stop delaying.
(WebCore::HTMLMediaElement::progressEventTimerFired): when stalling, stop delaying.
2011-03-13 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
Crash when dragging and dropping in a document with an invalid XHTML header
https://bugs.webkit.org/show_bug.cgi?id=48799
DragController tried to dispatch textInput event even when the
drag destination is not the editable area.
This change skips the event dispatching on that case.
Test: editing/pasteboard/drop-file-svg.html
* page/DragController.cpp:
(WebCore::DragController::dispatchTextInputEventFor):
(WebCore::DragController::concludeEditDrag):
2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81094.
http://trac.webkit.org/changeset/81094
https://bugs.webkit.org/show_bug.cgi?id=56355
Broke the chromium DRT related build. (Requested by dave_levin
on #webkit).
* WebCore.exp.in:
* WebCore.order:
* page/Frame.cpp:
(WebCore::Frame::layerTreeAsText):
* page/Frame.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
* rendering/RenderLayerCompositor.h:
2011-03-14 Adam Barth <abarth@webkit.org>
Apparently we need to exclude DefaultSharedWorkerRepository.cpp from
the Chromium build, otherwise the objects visible in the global scope
change.
* WebCore.gyp/WebCore.gyp:
2011-03-14 Adam Barth <abarth@webkit.org>
Attempted Chromium build fix. Exclude AllInOne harder.
* WebCore.gyp/WebCore.gyp:
2011-03-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
EventHandler calls shouldChangeSelection needlessly
https://bugs.webkit.org/show_bug.cgi?id=56324
Extracted setSelectionIfNeeded and setNonDirectionalSelectionIfNeeded and
avoided calling shouldChangeSelection and setSelection when the existing
selection is identical to that of new selection.
* page/EventHandler.cpp:
(WebCore::setSelectionIfNeeded): Extracted.
(WebCore::setNonDirectionalSelectionIfNeeded): Extracted.
(WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls a helper function above.
(WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto.
(WebCore::EventHandler::handleMousePressEventTripleClick): Ditto.
(WebCore::EventHandler::handleMousePressEventSingleClick): Ditto.
(WebCore::EventHandler::updateSelectionForMouseDrag): Ditto.
(WebCore::EventHandler::handleMouseReleaseEvent): Ditto.
2011-03-14 Daniel Sievers <sievers@google.com>
Reviewed by Simon Fraser.
[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139
* WebCore.exp.in:
* WebCore.order:
* page/Frame.cpp:
(WebCore::Frame::layerTreeAsText):
* page/Frame.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
* rendering/RenderLayerCompositor.h:
2011-03-14 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add remaining files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=56351
Adding the remaining files to WebCore.gypi required updating the
include/exclude lists in WebCore.gyp. These lists aren't overly
elegant, but we can try to improve them in the future.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* bindings/v8/ScriptCachedFrameData.cpp:
- Added ifdefs to this file to match the header.
* platform/graphics/WOFFFileFormat.cpp:
- Fixed build error when compiling without ENABLE(OPENTYPE_SANITIZER).
2011-03-14 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Rework object group building.
https://bugs.webkit.org/show_bug.cgi?id=55399
Instead of going top-down (from owner to owned elements), go up---from objects
to their group ids. That fits better to v8's object grouping model and guarantees
that each wrapper belongs to the single group.
Alas, this cannot be implemented for one kind of objects---CSSProperties.
Part of core GC algorithm and tested extensively by exisiting layout tests.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/V8/V8TestInterface.cpp:
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
* bindings/scripts/test/V8/V8TestObj.cpp:
* bindings/v8/V8GCController.cpp:
(WebCore::calculateGroupId):
(WebCore::calculateRootStyleSheet):
(WebCore::GrouperVisitor::visitDOMWrapper):
(WebCore::GrouperVisitor::applyGrouping):
(WebCore::V8GCController::gcPrologue):
* bindings/v8/WrapperTypeInfo.h:
(WebCore::WrapperTypeInfo::isSubclass):
* css/CSSRuleList.h:
(WebCore::CSSRuleList::styleList):
* css/StyleSheetList.h:
(WebCore::StyleSheetList::document):
2011-03-14 Kent Tamura <tkent@chromium.org>
Reviewed by James Robinson.
Assertion failure by form validation message for <select required> with float:left
https://bugs.webkit.org/show_bug.cgi?id=55995
Test: fast/forms/interactive-validation-select-crash.html
* rendering/RenderBlock.cpp:
(WebCore::canMergeContiguousAnonymousBlocks):
isAnonymousBlock() doesn't mean it is a RenderBlock. We need to check isRenderBlock().
2011-03-14 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Adam Roben.
[Qt][WK2]Unbreak InjectedBundle on Qt
https://bugs.webkit.org/show_bug.cgi?id=54109
No code changes so no new tests.
Revert the changes that were needed to use KURL
in WebKitTestRunner.
* Configurations/WebCore.xcconfig:
* WebCore.exp.in:
2011-03-14 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Compilation fails with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=55964
* WebCore.pro:
* platform/graphics/qt/Extensions3DQt.cpp:
2011-03-14 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben and Gavin Barraclough.
FileSystemWin.cpp needs listDirectory() implementation
https://bugs.webkit.org/show_bug.cgi?id=56331
<rdar://problem/9126635>
Move PathWalker from an inline class in WebKit2 to its own class in WebCore,
so it can be used from both WebCore and WebKit2.
Implement FileSystemWin::listDirectory using PathWalker to populate the Vector
of paths matching the passed in pattern.
* WebCore.vcproj/WebCore.vcproj:
* platform/win/FileSystemWin.cpp:
(WebCore::listDirectory): Call through to PathWalker.
* platform/win/PathWalker.cpp: Added.
(WebCore::PathWalker::PathWalker): Moved from WebKit2. Added a second argument
for the pattern to pass to the Windows File APIs.
(WebCore::PathWalker::~PathWalker): Moved from WebKit2.
(WebCore::PathWalker::isValid): Ditto.
(WebCore::PathWalker::data): Ditto.
(WebCore::PathWalker::step): Ditto.
* platform/win/PathWalker.h: Added.
2011-03-14 Brady Eidson <beidson@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=56320
Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
Remove HistoryItem::icon():
* history/HistoryItem.cpp:
* history/HistoryItem.h:
* WebCore.exp.in:
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::defaultIcon):
2011-03-14 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
Timer-based events should inherit the user gesture state of their
originating event in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=55104
If a timer is installed by a gesture-originated event and will fire
within one second, the timer-initiated event should behave as if it
were also initiated by a user gesture. Multi-shot timers should only
get this behavior on their first execution. Nested timers should not
get this behavior. This makes us compatible with Gecko when handling
popups and file chooser dialogs created from timer events.
Test: fast/events/popup-blocking-timers.html
* page/DOMTimer.cpp:
(WebCore::timeoutId): Create a helper function so that m_timeoutId can
be initialized in the data member initialization list.
(WebCore::shouldForwardUserGesture): Ditto, but for
m_shouldForwardUserGesture.
(WebCore::DOMTimer::DOMTimer): Move initialization of data members from
the ctor body to the data member initialization list. Also rename the
argument 'timeout' to 'interval'.
(WebCore::DOMTimer::fired): Create a UserGestureIndicator and set its
state based on the value of m_shouldForwardUserGesture.
(WebCore::DOMTimer::adjustMinimumTimerInterval): m_originalTimeout was
renamed to m_originalInterval.
* page/DOMTimer.h: Add m_shouldForwardUserGesture and rename
m_originalTimeout to m_originalInterval.
2011-03-09 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Deleting content directly following a button inserts an unnecessary placeholder
https://bugs.webkit.org/show_bug.cgi?id=56053
Fixing a use of Node's enclosingBlockFlowElement with enclosingBlock htmlediting's
enclosingBlock, as enclosingBlockFlowElement would return inline-block elements despite
DeleteSelectionCommand treating them as blockflow.
Test: editing/deleting/delete-inserts-br-after-button.html
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs):
2011-03-14 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=45164
REGRESSION: <a><img align=top></a> Clickable area too large
Make sure to clamp hit testing of quirky inline flow boxes the same way we already clamped
painting.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
2011-03-14 Chris Marrin <cmarrin@apple.com>
Reviewed by Adam Roben.
REGRESSION (r75138-r75503): Animations on Apple HTML5 Gallery demo are wrong
https://bugs.webkit.org/show_bug.cgi?id=52845
The lastCommitTime() value in CACFLayerTreeHost was returning as the time
the render previous to this one happened. That often made it seem like
animations started more in the past than they did, breaking many animations.
The startAnimations() call actually fires from a CACF callback after all the
WebKit content has been rendered. So sending currentTime as the start time
to the animations is close enough for proper synchronization.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
2011-03-11 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Selection uses first mousemove's localRect instead of that of mousedown
https://bugs.webkit.org/show_bug.cgi?id=56213
Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent
using the mouse coordinates of the mousedown event that started the drag.
Test: editing/selection/drag-select-rapidly.html
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
2011-03-14 Mark Rowe <mrowe@apple.com>
Reviewed by Timothy Hatcher.
Apply a large, blunt object directly to the skull of the Leopard build.
* Configurations/Base.xcconfig: Disable the generation of debugging symbols when
building the Debug configuration on Leopard. This should cut the size of the object
files that the linker needs to process by over 85%. This will hopefully allow them
to fit in to the 32-bit address space of the Leopard linker.
2011-03-14 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin.
https://bugs.webkit.org/show_bug.cgi?id=56246
Add support for relative positioning to table cells. Back out the code that hacked around the lack of support
for offsetLeft, and add new tests to demonstrate that relative positioning works.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::offsetParent):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRelPositioned):
* rendering/RenderTableCell.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
2011-03-14 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin.
Partial backout of https://bugs.webkit.org/show_bug.cgi?id=56230. Go back to repainting the root
layer, since first layouts and printing mess up otherwise.
* page/FrameView.cpp:
(WebCore::FrameView::layout):
2011-03-11 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Clean up full repainting of layers during layout and at other times. Platforms that did not do an invalidation on
size changes were incorrectly relying on the DoFullRepaint case of RenderLayer::updateLayerPositions to invalidate
for them. However this code is now wrong, since it assumed that the outermost layer was a RenderView that encompassed
all of the child layers. This is no longer the case since the overflow changes that tightened up visual overflow
and limited that overflow only to content that the layer painted.
Eliminate the DoFullRepaint flag and actually make no repainting of any kind happen from the layer code if FrameView's
m_doFullRepaint boolean is set. This will flush out any ports that aren't just invalidating the world on their
own in response to view resizes or fixed layout size changes and force them to fix things to be consistent with
the other ports.
Make the two dynamic calls to updateLayerPositions still do a full repaint by setting the repaint flag on the layer.
I'm suspicious as to the correctness of the repainting in both of these cases (both before and after this patch),
but the behavior should be the same.
No new tests, since this is untestable on ports that invalidate on a resize.
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleDidChange):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::removeOnlyThisLayer):
* rendering/RenderLayer.h:
2011-03-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214
Make sure everything builds still.
* bridge/c/c_class.cpp:
* bridge/c/c_runtime.cpp:
* bridge/jni/JavaMethod.cpp:
* plugins/PluginViewNone.cpp:
2011-03-14 Luiz Agostini <luiz.agostini@openbossa.org>
Unreviewed build fix for r81035.
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::defaultEventHandler):
* rendering/RenderDetailsMarker.cpp:
(WebCore::createDownArrowPath):
(WebCore::createUpArrowPath):
(WebCore::createLeftArrowPath):
(WebCore::createRightArrowPath):
2011-03-13 Jer Noble <jer.noble@apple.com>
FullScreen: Handle entering full screen security restrictions
https://bugs.webkit.org/show_bug.cgi?id=56264
Tests: fullscreen/full-screen-iframe-allowed.html
fullscreen/full-screen-iframe-not-allowed.html
Disable full screen documents in the following conditions:
1) requesting element is in an iframe which does not have a
webkitallowfullscreen attribute.
2) page is not processing a user gesture.
* dom/Document.cpp:
(WebCore::Document::fullScreenIsAllowedForElement): Added. Checks
to see if elements contained in IFRAMES are allowed to
enter full screen.
(WebCore::Document::webkitRequestFullScreenForElement): Checks
if page is currently processing a user gesture.
* dom/Document.h:
* html/HTMLAttributeNames.in: Added webkitallowfullscreenAttr.
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::allowFullScreen): Added.
* html/HTMLFrameElementBase.h:
2011-03-14 Anton D'Auria <adauria@apple.com>
Reviewed by David Levin.
REGRESSION(r80892): Use of uninitialized variable "m_syncCloseDatabase" in StorageAreaSync::sync
https://bugs.webkit.org/show_bug.cgi?id=56303
Initialized m_syncCloseDatabase to false in the StorageAreaSync constructor.
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::StorageAreaSync):
2011-03-14 Steve Block <steveblock@google.com>
Reviewed by Oliver Hunt.
JavaMethod.cpp does not compile with V8
https://bugs.webkit.org/show_bug.cgi?id=56306
Moved the ScopeChain.h include to JavaStringJSC.
No new tests, build fix only.
* bridge/jni/JavaMethod.cpp:
* bridge/jni/jsc/JavaStringJSC.h
2011-02-28 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Dave Hyatt.
HTML5 <details> and <summary>: rendering
https://bugs.webkit.org/show_bug.cgi?id=51071
Tests: fast/html/details-add-summary-1-and-click.html
fast/html/details-add-summary-1.html
fast/html/details-add-summary-10-and-click.html
fast/html/details-add-summary-10.html
fast/html/details-add-summary-2-and-click.html
fast/html/details-add-summary-2.html
fast/html/details-add-summary-3-and-click.html
fast/html/details-add-summary-3.html
fast/html/details-add-summary-4-and-click.html
fast/html/details-add-summary-4.html
fast/html/details-add-summary-5-and-click.html
fast/html/details-add-summary-5.html
fast/html/details-add-summary-6-and-click.html
fast/html/details-add-summary-6.html
fast/html/details-add-summary-7-and-click.html
fast/html/details-add-summary-7.html
fast/html/details-add-summary-8-and-click.html
fast/html/details-add-summary-8.html
fast/html/details-add-summary-9-and-click.html
fast/html/details-add-summary-9.html
fast/html/details-mouse-click.html
fast/html/details-no-summary1.html
fast/html/details-no-summary2.html
fast/html/details-no-summary3.html
fast/html/details-no-summary4.html
fast/html/details-open-javascript.html
fast/html/details-open1.html
fast/html/details-open2.html
fast/html/details-open3.html
fast/html/details-open4.html
fast/html/details-open5.html
fast/html/details-open6.html
fast/html/details-position.html
fast/html/details-remove-summary-1-and-click.html
fast/html/details-remove-summary-1.html
fast/html/details-remove-summary-2-and-click.html
fast/html/details-remove-summary-2.html
fast/html/details-remove-summary-3-and-click.html
fast/html/details-remove-summary-3.html
fast/html/details-remove-summary-4-and-click.html
fast/html/details-remove-summary-4.html
fast/html/details-remove-summary-5-and-click.html
fast/html/details-remove-summary-5.html
fast/html/details-remove-summary-6-and-click.html
fast/html/details-remove-summary-6.html
fast/html/details-writing-mode.html
http://www.w3.org/TR/html5/interactive-elements.html#the-details-element
The main <summary> element is the first <summary> element of a <details> element.
All other childs of the <details> element are rendered only if the attribute 'open' is set.
Click event toggles the 'open' attribute.
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::HTMLDetailsElement):
(WebCore::HTMLDetailsElement::findMainSummary):
(WebCore::HTMLDetailsElement::childrenChanged):
(WebCore::HTMLDetailsElement::finishParsingChildren):
(WebCore::HTMLDetailsElement::parseMappedAttribute):
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
(WebCore::HTMLDetailsElement::defaultEventHandler):
* html/HTMLDetailsElement.h:
(WebCore::HTMLDetailsElement::mainSummary):
Method createRenderer added to class HTMLSummaryElement.
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createRenderer):
* html/HTMLSummaryElement.h:
The first <summary> element is positioned at the top of its <details> parent.
The area occupied by this main <summary> element is the interactive area of the
<details> element. If the <details> tag has no <summary> child an OwnedSummaryRenderer
is created and added to the corresponding RenderDetails object.
* rendering/RenderDetails.cpp:
(WebCore::RenderDetails::RenderDetails):
(WebCore::RenderDetails::destroy):
(WebCore::RenderDetails::summaryBlock):
(WebCore::RenderDetails::contentBlock):
(WebCore::RenderDetails::addChild):
(WebCore::RenderDetails::removeChild):
(WebCore::RenderDetails::setMarkerStyle):
(WebCore::RenderDetails::styleDidChange):
(WebCore::RenderDetails::getRenderPosition):
(WebCore::RenderDetails::markerDestroyed):
(WebCore::RenderDetails::summaryDestroyed):
(WebCore::RenderDetails::moveSummaryToContents):
(WebCore::RenderDetails::createSummaryStyle):
(WebCore::RenderDetails::replaceMainSummary):
(WebCore::RenderDetails::createDefaultSummary):
(WebCore::RenderDetails::checkMainSummary):
(WebCore::RenderDetails::layout):
(WebCore::RenderDetails::isOpen):
(WebCore::RenderDetails::getParentOfFirstLineBox):
(WebCore::RenderDetails::firstNonMarkerChild):
(WebCore::RenderDetails::updateMarkerLocation):
* rendering/RenderDetails.h:
(WebCore::RenderDetails::interactiveArea):
(WebCore::RenderDetails::removeLeftoverAnonymousBlock):
(WebCore::RenderDetails::createsAnonymousWrapper):
(WebCore::RenderDetails::requiresForcedStyleRecalcPropagation):
A marker is added to the main <summary> element to indicate the current value of the 'open'
attribute of the <details> element.
* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::RenderDetailsMarker):
(WebCore::RenderDetailsMarker::destroy):
(WebCore::RenderDetailsMarker::lineHeight):
(WebCore::RenderDetailsMarker::baselinePosition):
(WebCore::RenderDetailsMarker::computePreferredLogicalWidths):
(WebCore::RenderDetailsMarker::layout):
(WebCore::RenderDetailsMarker::getRelativeMarkerRect):
(WebCore::RenderDetailsMarker::isOpen):
(WebCore::createPath):
(WebCore::createDownArrowPath):
(WebCore::createUpArrowPath):
(WebCore::createLeftArrowPath):
(WebCore::createRightArrowPath):
(WebCore::RenderDetailsMarker::orientation):
(WebCore::RenderDetailsMarker::getCanonicalPath):
(WebCore::RenderDetailsMarker::getPath):
(WebCore::RenderDetailsMarker::paint):
* rendering/RenderDetailsMarker.h:
(WebCore::toRenderDetailsMarker):
* rendering/RenderSummary.cpp:
(WebCore::RenderSummary::RenderSummary):
(WebCore::RenderSummary::destroy):
(WebCore::RenderSummary::parentDetails):
(WebCore::RenderSummary::styleDidChange):
* rendering/RenderSummary.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
2011-03-14 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=56296
Clean up IconDatabaseBase header.
-Get rid of the "PlatformString.h" include and replace it with a forward declaration.
-Group methods by which are used in WebCore directly and which are used in WebKit ports.
This'll make it easier to use in external frameworks (like WebKit2).
* loader/icon/IconDatabase.h:
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::retainIconForPageURL):
(WebCore::IconDatabaseBase::releaseIconForPageURL):
(WebCore::IconDatabaseBase::iconForPageURL):
(WebCore::IconDatabaseBase::setIconURLForPageURL):
(WebCore::IconDatabaseBase::setIconDataForIconURL):
(WebCore::IconDatabaseBase::iconDataKnownForIconURL):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::importIconURLForPageURL):
(WebCore::IconDatabaseBase::importIconDataForIconURL):
(WebCore::IconDatabaseBase::open):
2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81026.
http://trac.webkit.org/changeset/81026
https://bugs.webkit.org/show_bug.cgi?id=56313
Breaks gtk 64-bit tests (Requested by podivilov on #webkit).
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
(WebCore::InspectorBrowserDebuggerAgent::clear):
* inspector/InspectorBrowserDebuggerAgent.h:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.createXHRBreakpoint):
(WebInspector.BreakpointManager.prototype._createXHRBreakpoint):
(WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
(WebInspector.BreakpointManager.prototype._projectChanged):
(WebInspector.BreakpointManager.prototype._validateBreakpoints):
(WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
(WebInspector.BreakpointManager.prototype._createXHRBreakpointId):
(WebInspector.XHRBreakpoint):
(WebInspector.XHRBreakpoint.prototype._enable):
(WebInspector.XHRBreakpoint.prototype._disable):
(WebInspector.XHRBreakpoint.prototype._serializeToJSON):
(WebInspector.XHRBreakpointView):
(WebInspector.XHRBreakpointView.prototype.compareTo):
(WebInspector.XHRBreakpointView.prototype.populateEditElement):
(WebInspector.XHRBreakpointView.prototype.populateLabelElement):
(WebInspector.XHRBreakpointView.prototype.populateStatusMessageElement):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.XHRBreakpointsSidebarPane.addButtonClicked):
(WebInspector.XHRBreakpointsSidebarPane):
(WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem):
(WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._clearInterface):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/inspector.js:
(WebInspector.resetFocusElement):
(WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded):
(WebInspector.createXHRBreakpointsSidebarPane):
(WebInspector.set attached):
2011-03-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function.
https://bugs.webkit.org/show_bug.cgi?id=56312
Test: inspector/utilities.html
* inspector/front-end/utilities.js:
2011-03-12 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: re-implement xhr breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=56252
- restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
- store xhr breakpoints in a separate setting
- move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane
Test: inspector/debugger/xhr-breakpoints.html
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
(WebCore::InspectorBrowserDebuggerAgent::clear):
* inspector/InspectorBrowserDebuggerAgent.h:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.setXHRBreakpoint):
(WebInspector.BreakpointManager.prototype.removeXHRBreakpoint):
(WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
(WebInspector.BreakpointManager.prototype._projectChanged):
(WebInspector.BreakpointManager.prototype._validateBreakpoints):
(WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.XHRBreakpointsSidebarPane):
(WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing):
(WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
(WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
(WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing):
(WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):
(WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
(WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints):
(WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints):
(WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._clearInterface):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/inspector.js:
(WebInspector.resetFocusElement):
(WebInspector.set attached):
2011-03-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move breakpoints restoring to debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=56123
DebuggerModel's "breakpoint-added" and "breakpoint-removed" events are gone since
setBreakpoint/removeBreakpoint are now called from DPM only.
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype._debuggerWasEnabled):
(WebInspector.DebuggerModel.prototype._debuggerWasDisabled):
(WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.prototype.removeBreakpoint):
(WebInspector.DebuggerModel.prototype._breakpointResolved):
(WebInspector.DebuggerModel.prototype.reset):
(WebInspector.DebuggerDispatcher.prototype.debuggerWasEnabled):
(WebInspector.DebuggerDispatcher.prototype.debuggerWasDisabled):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.reset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81015.
http://trac.webkit.org/changeset/81015
https://bugs.webkit.org/show_bug.cgi?id=56308
A Similar patch landed in r76960 (Requested by philn-tp on
#webkit).
* GNUmakefile.am:
2011-03-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: don't use innerText, use textContent instead.
https://bugs.webkit.org/show_bug.cgi?id=56307
* inspector/front-end/AuditFormatters.js:
(WebInspector.AuditFormatters.snippet):
* inspector/front-end/ElementsTreeOutline.js:
* inspector/front-end/GoToLineDialog.js:
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen):
* inspector/front-end/ShortcutsHelp.js:
(WebInspector.ShortcutsSection.prototype.renderSection):
(WebInspector.ShortcutsSection.prototype._renderHeader):
2011-03-14 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Disable live-edit in favor of the text editor
https://bugs.webkit.org/show_bug.cgi?id=56176
* inspector/front-end/Settings.js:
2011-03-14 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] scroll does not work in source frame when mouse is inside the gutter
https://bugs.webkit.org/show_bug.cgi?id=56095
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
2011-03-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move breakpoints restoring after live edit to debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=56179
Presentation model should move breakpoints based on text diff as required by "revert to revision" action in resources panel.
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.reset):
(WebInspector.DebuggerModel.prototype.editScriptSource.didEditScriptSource):
(WebInspector.DebuggerModel.prototype.editScriptSource):
(WebInspector.DebuggerModel.prototype.get callFrames):
(WebInspector.DebuggerModel.prototype._pausedScript):
(WebInspector.DebuggerModel.prototype._resumedScript):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
2011-03-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
https://bugs.webkit.org/show_bug.cgi?id=56111
This change reduces the getStylesForNode() payload more than twice for BODY elements.
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::populateObjectWithStyleProperties):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSProperty.parsePayload):
2011-03-14 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877
On Page destruction, any outstanding Geolocation permission
requests should be cancelled, because the Geolocation can only
access the client indirectly via m_frame->page().
Page destruction is signalled by a call to the
Frame::pageDestroyed() method. This explictly calls
DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.
Geolocation::reset() detaches from the GeolocationController,
cancels requests, watches and single shots, and sets the
permission state back to Unknown.
Frame::pageDestroyed() is also called by FrameLoader even though
the page is not destroyed. We should still cancel permission
requests, because the GeolocationClient will become inaccessible
to the Geolocation object after this call.
Frame::transferChildFrameToNewDocument also indirectly calls
Geolocation::reset when the frame is reparented between
pages. Ideally we would like the Geolocation's activities to
continue after reparenting, see bug
https://bugs.webkit.org/show_bug.cgi?id=55577
Since GeolocationController is owned by Page, and all Geolocation
objects will now unsubscribe from the GeolocationController on
pageDetached(), we no longer need to call stopUpdating() from the
GeolocationController's destructor. Instead we can simply assert
that there should be no no observers. See related bug
https://bugs.webkit.org/show_bug.cgi?id=52216 .
Introduced new method 'numberOfPendingPermissionRequests' on
GeolocationClientMock to count the number of outstanding pending
permission requests. This provides a reusable implementation for
client-based implementations of the LayoutTestController's
numberOfPendingGeolocationPermissionRequests method.
Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::resetGeolocation):
* page/DOMWindow.h:
* page/Frame.cpp:
(WebCore::Frame::pageDestroyed):
(WebCore::Frame::transferChildFrameToNewDocument):
* page/Geolocation.cpp:
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::page):
(WebCore::Geolocation::reset):
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
* page/Geolocation.h:
* page/GeolocationController.cpp:
(WebCore::GeolocationController::~GeolocationController):
* page/Navigator.cpp:
(WebCore::Navigator::resetGeolocation):
* page/Navigator.h:
* platform/mock/GeolocationClientMock.cpp:
(WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
* platform/mock/GeolocationClientMock.h:
2011-03-14 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: REGRESSION: Messed up with the tabIndex for text editor
https://bugs.webkit.org/show_bug.cgi?id=56183
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._handleKeyDown):
(WebInspector.SourceFrame.prototype._handleSave):
(WebInspector.SourceFrame.prototype._handleRevertEditing):
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.set readOnly):
2011-03-14 Chris Rogers <crogers@google.com>
Reviewed by Xan Lopez.
Add all web audio auto-generated files to GTK make system
https://bugs.webkit.org/show_bug.cgi?id=50497
No new tests since these are build-system tweaks.
* GNUmakefile.am:
2011-03-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
https://bugs.webkit.org/show_bug.cgi?id=56268
* inspector/Inspector.idl:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::cancelSearch):
(WebCore::InspectorDOMAgent::onMatchJobsTimer):
(WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.requestDocument.mycallback):
(WebInspector.DOMAgent.prototype.requestDocument):
(WebInspector.DOMAgent.prototype._attributesUpdated):
(WebInspector.DOMAgent.prototype._characterDataModified):
(WebInspector.DOMAgent.prototype._documentUpdated):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._childNodeCountUpdated):
(WebInspector.DOMAgent.prototype._childNodeInserted):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMAgent.prototype._removeBreakpoints):
(WebInspector.DOMAgent.prototype.performSearch):
(WebInspector.DOMAgent.prototype.cancelSearch):
(WebInspector.DOMDispatcher.prototype.searchResults):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._reset):
(WebInspector.ElementsPanel.prototype._documentUpdated):
(WebInspector.ElementsPanel.prototype.searchCanceled):
(WebInspector.ElementsPanel.prototype.performSearch):
(WebInspector.ElementsPanel.prototype._addNodesToSearchResult):
(WebInspector.ElementsPanel.prototype._attributesUpdated):
(WebInspector.ElementsPanel.prototype._characterDataModified):
(WebInspector.ElementsPanel.prototype._nodeInserted):
(WebInspector.ElementsPanel.prototype._nodeRemoved):
(WebInspector.ElementsPanel.prototype._childNodeCountUpdated):
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
2011-03-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add tests for edit dom operations.
https://bugs.webkit.org/show_bug.cgi?id=56248
Test: inspector/elements/edit-dom-actions.html
* inspector/Inspector.idl:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::assertNode):
(WebCore::InspectorDOMAgent::assertElement):
(WebCore::InspectorDOMAgent::assertHTMLElement):
(WebCore::InspectorDOMAgent::nodeToSelectOn):
(WebCore::InspectorDOMAgent::querySelector):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::setAttribute):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::setOuterHTML):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.setAttribute):
(WebInspector.DOMNode.prototype.removeAttribute):
* inspector/front-end/inspector.js:
(WebInspector.startEditing.defaultFinishHandler):
2011-03-14 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/8762095> and https://bugs.webkit.org/show_bug.cgi?id=55172
Need WK2 API to view/manage origins with LocalStorage
* storage/StorageTracker.cpp:
(WebCore::StorageTracker::initializeTracker): Make sure the TextEncoding map is initialized on the main thread
before the StorageTracker thread can do it on the background thread.
2011-03-13 Anton D'Auria <adauria@apple.com>
Reviewed by Brady Eidson and David Levin, landed by Brady Eidson.
Fixed lock-taking order to prevent deadlock, added lock for m_client,
removed premature return in syncImportOriginIdentifiers when tracker
db does not exist because that prevented syncFileSystemAndTrackerDatabase()
from running until next LocalStorage db creation, cleaned up
StorageTracker::scheduleTask() code for readability.
https://bugs.webkit.org/show_bug.cgi?id=56285
* storage/StorageTracker.cpp:
(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::syncImportOriginIdentifiers): If tracker db isn't
optionally opened (as in the case when it doesn't exist on disk), don't
exit early and call syncFileSystemAndTrackerDatabase(), which will create
a tracker db if localstorage db files are found on disk by calling setOriginDetails.
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask): readability changes.
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin): order lock-taking consistently to avoid deadlock.
(WebCore::StorageTracker::setClient):
* storage/StorageTracker.h:
2011-03-13 Anton D'Auria <adauria@apple.com>
Reviewed and landed by Brady Eidson.
Invalid assertion in StorageTracker - PageGroup::numberOfPageGroups() == 1
https://bugs.webkit.org/show_bug.cgi?id=56240
This assertion is invalid until LocalStorage is either global or is isolated by PageGroup.
* storage/StorageTracker.cpp:
(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):
2011-03-13 Pratik Solanki <psolanki@apple.com>
Reviewed by Dan Bernstein.
Make adjustMIMETypeIfNecessary use CFNetwork directly
https://bugs.webkit.org/show_bug.cgi?id=55912
Follow up fix for Layout Test failure. Fix typo - it should be text/plain, not test/plain.
* platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary):
2011-03-13 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
Include hyphenation information in text representation of render tree
https://bugs.webkit.org/show_bug.cgi?id=56287
(WebCore::writeTextRun): If the text box is hyphenated, output the hyphenation
string.
2011-03-13 David Levin <levin@chromium.org>
Improve my hasitly added build fix and added a bug https://bugs.webkit.org/show_bug.cgi?id=56288
above addressing this FIXME.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
2011-03-13 David Levin <levin@chromium.org>
Build fix adding remaining enum values to switch statement.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
2011-03-13 Sam Weinig <sam@webkit.org>
Fix windows build.
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError):
Add missing constructor.
2011-03-13 David Sosby <dsosby@rim.com>
Reviewed by Dan Bernstein.
REGRESSION: Soft hyphen is not always rendered
https://bugs.webkit.org/show_bug.cgi?id=56017
The check to flag a text block as hyphenated was only
occurring at break points in the line. If no break points
were found after the soft hyphen then the line would not
be flagged hyphenated. Adding a check for soft hyphen at
the end of the text run resolves the issue.
Test: fast/text/soft-hyphen-4.html
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
2011-03-13 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
REGRESSION (r80438): fast/text/hyphenate-character failing in pixel mode
https://bugs.webkit.org/show_bug.cgi?id=56280
* rendering/RenderBlockLineLayout.cpp:
(WebCore::tryHyphenating): Avoid subtracting 1 from an unsigned 0.
2011-03-13 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add ability to create a WKErrorRef
<rdar://problem/9115768>
https://bugs.webkit.org/show_bug.cgi?id=56279
* WebCore.exp.in:
Add new exports.
* platform/network/cf/ResourceError.h:
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::cfStreamError):
(WebCore::ResourceError::operator CFStreamError):
* platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::nsError):
(WebCore::ResourceError::operator NSError *):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
Clean up ResourceError a bit and add ability to create a ResourceError from a CFErrorRef
regardless of whether CFNetwork is being used.
2011-03-13 Pratik Solanki <psolanki@apple.com>
Reviewed by Brady Eidson.
Make adjustMIMETypeIfNecessary use CFNetwork directly
https://bugs.webkit.org/show_bug.cgi?id=55912
Convert category method [NSURLResponse adjustMIMETypeIfNecessary] to C function
WebCore::adjustMIMETypeIfNecessary() that takes a CFURLResponseRef and is functionally
identical.
Testing is covered by existing LayoutTests.
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
* platform/network/mac/WebCoreURLResponse.h:
* platform/network/mac/WebCoreURLResponse.mm:
(WebCore::createBinaryExtensionsSet):
(WebCore::createExtensionToMIMETypeMap):
(WebCore::mimeTypeFromUTITree):
(WebCore::adjustMIMETypeIfNecessary):
2011-03-13 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dimitri Glazkov.
Update comment in CSSValueKeywords.in
https://bugs.webkit.org/show_bug.cgi?id=56266
The enums the comment refers to were moved from RenderStyle.h to RenderStyleConstants.h
in r36579 but it appears that the comment in CSSValueKeywords.in wasn't updated.
No tests - just updating a comment.
* css/CSSValueKeywords.in:
2011-03-13 Anton D'Auria <adauria@apple.com>
Reviewed by Alice Liu.
StorageTracker constructor shouldn't have initialization code and isMainThread() assertion
https://bugs.webkit.org/show_bug.cgi?id=56259
Move all StorageTracker initialization to
StorageTracker::initializeTracker. This also removes the
requirement that the StorageTracker constructor isn't run
on the main thread.
* storage/StorageTracker.cpp:
(WebCore::StorageTracker::initializeTracker):
(WebCore::StorageTracker::tracker):
(WebCore::StorageTracker::StorageTracker):
2011-03-13 Rob Buis <rwlbuis@gmail.com>
Reviewed by Dave Hyatt.
REGRESSION (r61383): Navigation menu laid out incorrectly on aboardtheworld.com
https://bugs.webkit.org/show_bug.cgi?id=53470
Prefer !important over normal properties when dealing with duplicate properties in style rules.
Test: fast/css/duplicate-property-in-rule-important.html
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80895.
http://trac.webkit.org/changeset/80895
https://bugs.webkit.org/show_bug.cgi?id=56261
Causing crashes in several tests including
t1202-counters-16-c.html (see
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80956%20(15528)/results.html)
(Requested by dave_levin on #webkit).
* rendering/CounterNode.cpp:
(WebCore::CounterNode::CounterNode):
(WebCore::CounterNode::create):
(WebCore::CounterNode::resetRenderer):
(WebCore::CounterNode::resetRenderers):
(WebCore::CounterNode::recount):
(WebCore::CounterNode::insertAfter):
(WebCore::CounterNode::removeChild):
(WebCore::showTreeAndMark):
* rendering/CounterNode.h:
(WebCore::CounterNode::renderer):
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
(WebCore::RenderCounter::~RenderCounter):
(WebCore::RenderCounter::originalText):
(WebCore::RenderCounter::invalidate):
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
(showCounterRendererTree):
* rendering/RenderCounter.h:
* rendering/RenderObjectChildList.cpp:
(WebCore::invalidateCountersInContainer):
(WebCore::RenderObjectChildList::invalidateCounters):
* rendering/RenderObjectChildList.h:
2011-03-12 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r76474): IntegerArray hash hashes only 1/4 of the array
https://bugs.webkit.org/show_bug.cgi?id=56258
No tests because the wrong hashing is mostly harmless. The only symptom
we have seen is an occasional assertion in debug builds about the size
not being a multiple of two. But a worse hash is worse for performance too.
* platform/cf/BinaryPropertyList.cpp:
(WebCore::IntegerArrayHash::hash): Pass in the size in bytes rather
than the number of array entries.
2011-03-12 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
Fix the build with newer GCCs and remove some extra whitespae.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::uint8_t):
2011-03-12 Cameron Zwarich <zwarich@apple.com>
Rubber-stamped by Oliver Hunt.
Removed unused ARMv5 code. The ARMv5 case now falls under the general
unaligned accessed case.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readLittleEndian):
(WebCore::CloneDeserializer::readString):
2011-03-12 Cameron Zwarich <zwarich@apple.com>
Reviewed by Oliver Hunt.
WebCore fails to build with Clang on ARM
https://bugs.webkit.org/show_bug.cgi?id=56257
Add an explicit instantiation of writeLittleEndian for uint8_t and move it to
namespace scope, since explicit specializations are not allowed at class scope.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::writeLittleEndian):
2011-03-11 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Dragging image to desktop gives webloc instead of image file in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56193
* WebCore.exp.in: Added some additional exports. Re-sorted.
2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80919.
http://trac.webkit.org/changeset/80919
https://bugs.webkit.org/show_bug.cgi?id=56251
all windows bots failed to compile this change (Requested by
loislo on #webkit).
* bridge/c/c_class.cpp:
* bridge/c/c_runtime.cpp:
* bridge/jni/JavaMethod.cpp:
* plugins/PluginViewNone.cpp:
2011-03-12 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r80900.
* CMakeListsWinCE.txt: Removed IconDatabaseNone.cpp.
2011-03-12 Andras Becsi <abecsi@webkit.org>
Unreviewed typo fix.
No new tests needed.
* WebCore.pro: Fix typo in header name.
2011-03-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Inspect Element action regression fix.
* inspector/front-end/inspector.js:
(WebInspector.inspect):
2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. One line fix for inspector/dom-breakpoints.html
* inspector/front-end/BreakpointManager.js:
(WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix.
Almost all inspector tests are crashing after r80928.
* inspector/front-end/inspector.js:
2011-03-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up to error reporting, fixing multiple regressions.
https://bugs.webkit.org/show_bug.cgi?id=56243
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::setPropertyValue):
* inspector/InjectedScript.h:
* inspector/Inspector.idl:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getChildNodes):
(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::setPropertyValue):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.setNodeName):
(WebInspector.DOMNode.prototype.setNodeValue):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype.getOuterHTML):
(WebInspector.DOMNode.prototype.setOuterHTML):
(WebInspector.DOMNode.prototype.removeNode):
(WebInspector.DOMNode.prototype.copyNode):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
(WebInspector.EventListeners.getEventListenersForNode):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage.prototype.getEntries):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype.update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
(WebInspector.ElementsTreeElement.prototype.updateChildren):
():
* inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
* inspector/front-end/PropertiesSidebarPane.js:
(WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.evaluate):
* inspector/front-end/inspector.js:
2011-03-12 Jer Noble <jer.noble@apple.com>
Unreviewed build fix.
Fix GTK+ builds by wrapping sections of full screen code in USE(ACCELERATED_COMPOSITING)
checks.
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
2011-03-12 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix.
[EFL] Fix build break because of several reason.
https://bugs.webkit.org/show_bug.cgi?id=56244
* CMakeLists.txt: Add missing files.
* platform/posix/FileSystemPOSIX.cpp: Add PLATFORM(EFL).
2011-03-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move profiler related methods from inspector agent to profiler agent
https://bugs.webkit.org/show_bug.cgi?id=56204
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::populateScriptObjects):
(WebCore::InspectorAgent::showProfilesPanel):
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::enableProfiler):
(WebCore::InspectorController::disableProfiler):
(WebCore::InspectorController::profilerEnabled):
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
(WebCore::InspectorController::isRecordingUserInitiatedProfile):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::profilerEnabledImpl):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::enable):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::setFrontend):
(WebCore::InspectorProfilerAgent::clearFrontend):
(WebCore::InspectorProfilerAgent::restore):
(WebCore::InspectorProfilerAgent::restoreEnablement):
(WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
(WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
* inspector/InspectorProfilerAgent.h:
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileType.prototype.buttonClicked):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._toggleProfiling):
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
https://bugs.webkit.org/show_bug.cgi?id=56226
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer().
(WebCore::Document::webkitDidEnterFullScreenForElement): Ditto.
(WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
(WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Create new interface stubs to support full screen mode in WebKit2.
WebKit2: Plumb new full screen animation APIs through WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=55993
* page/ChromeClient.h:
(WebCore::ChromeClient::setRootFullScreenLayer): Added.
2011-03-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214
Make sure everything builds still.
* bridge/c/c_class.cpp:
* bridge/c/c_runtime.cpp:
* bridge/jni/JavaMethod.cpp:
* plugins/PluginViewNone.cpp:
2011-03-11 Mark Rowe <mrowe@apple.com>
Fix the 32-bit build.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
2011-03-11 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Eric Carlsson.
<rdar://problem/9124537> Crashes during layout tests due to overrelease of AVFoundation objects.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAsset):
2011-03-11 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Fixes an error with the checkin for https://bugs.webkit.org/show_bug.cgi?id=52468
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
2011-03-11 Brady Eidson <beidson@apple.com>
Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
* loader/icon/IconDatabase.h: Make this guy public.
2011-03-11 Brady Eidson <beidson@apple.com>
Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
* loader/icon/IconDatabase.h:
(WebCore::IconDatabase::delayDatabaseCleanup): Maybe Qt has Icon Database disabled, so we need to define this here?
2011-03-11 Brady Eidson <beidson@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=56216
Fix the Qt build following the same pattern of the patch.
* loader/icon/IconDatabase.h:
* loader/icon/IconDatabaseBase.cpp:
(WebCore::IconDatabaseBase::databasePath): Added to the virtual base.
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::isOpen): Ditto.
2011-03-11 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=56198
Fix conditional which had an int for one case and a pointer for another.
No new tests. Fix compilation on Solaris 10 with SunStudio 12 C++
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
2011-03-11 Brady Eidson <beidson@apple.com>
Windows build fix.
* history/HistoryItem.cpp:
* loader/icon/IconDatabaseBase.cpp:
2011-03-11 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
Project file stuff:
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* WebCore.vcproj/WebCore.vcproj:
* loader/icon/IconDatabase.cpp:
* loader/icon/IconDatabase.h: Inherit from IconDatabaseBase.
* loader/icon/IconDatabaseBase.cpp: Added.
(WebCore::IconDatabaseBase::iconURLForPageURL):
(WebCore::iconDatabase):
(WebCore::setGlobalIconDatabase):
* loader/icon/IconDatabaseBase.h: Added.
(WebCore::IconDatabaseBase::IconDatabaseBase):
(WebCore::IconDatabaseBase::~IconDatabaseBase):
(WebCore::IconDatabaseBase::setEnabled):
(WebCore::IconDatabaseBase::isEnabled):
(WebCore::IconDatabaseBase::defaultIcon):
(WebCore::IconDatabaseBase::retainIconForPageURL):
(WebCore::IconDatabaseBase::releaseIconForPageURL):
(WebCore::IconDatabaseBase::iconForPageURL):
(WebCore::IconDatabaseBase::setIconURLForPageURL):
(WebCore::IconDatabaseBase::setIconDataForIconURL):
(WebCore::IconDatabaseBase::iconDataKnownForIconURL):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::pageURLMappingCount):
(WebCore::IconDatabaseBase::retainedPageURLCount):
(WebCore::IconDatabaseBase::iconRecordCount):
(WebCore::IconDatabaseBase::iconRecordCountWithData):
(WebCore::IconDatabaseBase::importIconURLForPageURL):
(WebCore::IconDatabaseBase::importIconDataForIconURL):
(WebCore::IconDatabaseBase::shouldStopThreadActivity):
(WebCore::IconDatabaseBase::open):
(WebCore::IconDatabaseBase::close):
(WebCore::IconDatabaseBase::removeAllIcons):
(WebCore::IconDatabaseBase::setPrivateBrowsingEnabled):
(WebCore::IconDatabaseBase::setClient):
* loader/icon/IconDatabaseNone.cpp: Removed.
2011-03-11 Brady Eidson <beidson@apple.com>
Attempt at a build-fix for https://bugs.webkit.org/show_bug.cgi?id=51878
* page/PageGroup.h: Declare this method, even if the definition will end up being empty.
2011-03-11 Michael Nordman <michaeln@google.com>
Reviewed by Dmitry Titov.
Adding the '~' to the dtor (duh).
No new tests.
* storage/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::~SQLCallbackWrapper):
2011-03-11 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
Introduced double linkage between a CounterNode and its display renderer.
use of freed pointer in WebCore::RenderCounter::originalText()
https://bugs.webkit.org/show_bug.cgi?id=56065
No new tests. This bug could only be reproduced manually by
refreshing the page during load at a critical point.
See bug attachment for testing.
* rendering/CounterNode.cpp:
Introduced new member "m_owner" to store the renderer that has the
style directives that produce the CounterNode.
Repurposed m_renderer to reffer to the RenderCounter that shows the
CounterNode.
(WebCore::CounterNode::CounterNode):
Updated member initialization.
(WebCore::CounterNode::create):
(WebCore::CounterNode::resetRenderer):
(WebCore::CounterNode::resetRenderers):
(WebCore::CounterNode::recount):
(WebCore::CounterNode::removeChild):
(WebCore::CounterNode::insertAfter):
No functional changes.
(WebCore::showTreeAndMark):
Added flushing to ensure that the output is complete.
* rendering/CounterNode.h:
(WebCore::CounterNode::owner):
Renamed from renderer()
(WebCore::CounterNode::renderer):
(WebCore::CounterNode::setRenderer):
Added new accessors for the display renderer.
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
Fixed comments. No functional changes.
(WebCore::RenderCounter::~RenderCounter):
Made sure that the CounterNode that this renderers displays is
detached from this.
(WebCore::RenderCounter::originalText):
(WebCore::RenderCounter::invalidate):
Added code to update m_renderer on the displayed CounterNode.
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
No change, just kept code in line with the changes above.
(showCounterRendererTree):
Added fflush to ensure complete display.
* rendering/RenderCounter.h:
* rendering/RenderObjectChildList.cpp:
* rendering/RenderObjectChildList.h:
Removed unneeded invalidateCounters related functions.
2011-03-11 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Introduce lookup-table based approach for applying CSS properties.
The aim is to be a starting point for refactoring
CSSStyleSelector::applyProperty() into more readable, maintainable code.
https://bugs.webkit.org/show_bug.cgi?id=54707
No new behavior / covered by existing tests.
* css/CSSStyleApplyProperty.cpp: Added.
(WebCore::ApplyPropertyNull):
Class that provides empty implementations of inherit, initial, value.
(WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
Class that calls the appropriate RenderStyle setters directly.
(WebCore::ApplyPropertyColorBase::ApplyPropertyColorBase):
Class for handling CSSProperty*Color.
(WebCore::ApplyPropertyColor::ApplyPropertyColor):
Class for handling CSSPropertyColor.
(WebCore::CSSStyleApplyProperty::sharedCSSStyleApplyProperty):
Singleton initializer.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Constructor that bulds up the map from property id to apply-er objects.
* css/CSSStyleApplyProperty.h: Added.
(WebCore::CSSStyleApplyProperty::inherit):
Handle the inherit case for a given property.
(WebCore::CSSStyleApplyProperty::initial):
Handle the initial case for a given property.
(WebCore::CSSStyleApplyProperty::value):
Apply a value to a given property.
(WebCore::CSSStyleApplyProperty::implements):
Returns true if the provided property id is implemented.
(WebCore::CSSStyleApplyProperty::index):
Private function to determine the index of a property the property map.
(WebCore::CSSStyleApplyProperty::valid):
Function to determine that a given property id is valid.
(WebCore::CSSStyleApplyProperty::setPropertyValue):
(WebCore::CSSStyleApplyProperty::propertyValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
Get reference to the CSSStyleApplyProperty singleton.
(WebCore::CSSStyleSelector::applyProperty):
Now calls into CSSStyleApplyProperty for implemented property ids.
Deleted color-related methods from the property id switch.
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::style):
Made public to allow access from CSSStyleApplyProperty.
(WebCore::CSSStyleSelector::parentStyle):
Made public to allow access from CSSStyleApplyProperty.
* rendering/style/RenderStyle.h:
Made CSSStyleApplyProperty a friend class. Necessary because it needs
to access the private getters and setters on this clsass.
2011-03-11 Anton D'Auria <adauria@apple.com>
Reviewed and landed by Brady Eidson.
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878
Created StorageTracker as a central point for tracking and deleting LocalStorage per origin.
StorageTracker maintains its own database of origin identifiers and backing db paths,
and this allows it to contain more relational data in the future, like variable quotas per origin.
On initialization, StorageTracker syncs its database with LocalStorage files on disk. It adds
an origin entry when StorageAreaSync performs a first sync for an origin.
All StorageTracker file operations are performed on one background thread with a task queue.
Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html
storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html
storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html
storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html
storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/PageGroup.cpp:
(WebCore::PageGroup::clearLocalStorageForAllOrigins):
(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore::PageGroup::syncLocalStorage):
(WebCore::PageGroup::numberOfPageGroups):
* page/PageGroup.h:
* platform/chromium/FileSystemChromium.cpp:
(WebCore::listDirectory):
* platform/posix/FileSystemPOSIX.cpp:
(WebCore::listDirectory):
* storage/LocalStorageTask.cpp:
(WebCore::LocalStorageTask::LocalStorageTask):
(WebCore::LocalStorageTask::performTask):
* storage/LocalStorageTask.h:
(WebCore::LocalStorageTask::createOriginIdentifiersImport):
(WebCore::LocalStorageTask::createSetOriginDetails):
(WebCore::LocalStorageTask::createDeleteOrigin):
(WebCore::LocalStorageTask::createDeleteAllOrigins):
* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::clearForOriginDeletion):
(WebCore::StorageAreaImpl::sync):
* storage/StorageAreaImpl.h:
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::scheduleCloseDatabase):
(WebCore::StorageAreaSync::openDatabase):
(WebCore::StorageAreaSync::sync):
(WebCore::StorageAreaSync::deleteEmptyDatabase):
(WebCore::StorageAreaSync::scheduleSync):
* storage/StorageAreaSync.h:
* storage/StorageNamespace.h:
* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::clearOriginForDeletion):
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceImpl::sync):
* storage/StorageNamespaceImpl.h:
* storage/StorageTracker.cpp: Added.
(WebCore::StorageTracker::initializeTracker):
(WebCore::StorageTracker::tracker):
(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::setStorageDirectoryPath):
(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::openTrackerDatabase):
(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask):
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::willDeleteAllOrigins):
(WebCore::StorageTracker::willDeleteOrigin):
(WebCore::StorageTracker::canDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin):
(WebCore::StorageTracker::setClient):
(WebCore::StorageTracker::syncLocalStorage):
* storage/StorageTracker.h: Added.
* storage/StorageTrackerClient.h: Added.
(WebCore::StorageTrackerClient::~StorageTrackerClient):
2011-03-11 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JavaMethod does not correctly check for a null jstring for the method name
https://bugs.webkit.org/show_bug.cgi?id=56187
No new tests, simple typo fix.
* bridge/jni/JavaMethod.cpp:
(JavaMethod::JavaMethod):
2011-03-11 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Compositor uses too much texture memory for scrollbars
https://bugs.webkit.org/show_bug.cgi?id=56212
Compositor invalidations can be off the page (and very large), but
scrollbars only need to care about the invalidation that's visible.
The large invalidation was causing the tiler layer size to grow
needlessly larger than the scrollbar.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
2011-03-11 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=52987
REGRESSION: Overflowing columns not repainted correctly
Make sure to add in column overflow as visual overflow as well. It was only propagating layout overflow, which is obviously not
sufficient, since blocks paint their own columns.
Added fast/multicol/scrolling-overflow.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromChildren):
2011-03-11 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Set canvasUsesAcceleratedDrawing setting to be off(false) by default
https://bugs.webkit.org/show_bug.cgi?id=56215
No new tests. Does not affect behavior. Just keeping the setting off by default.
* page/Settings.cpp:
(WebCore::Settings::Settings):
2011-03-11 Andy Estes <aestes@apple.com>
Reviewed by David Hyatt.
Table cells with dynamically added percentage height descendants do not
grow in size if the table has already been laid out.
https://bugs.webkit.org/show_bug.cgi?id=56174
Table cells ignore their specified size and collapse to fit their
children. When a descendent with percentage height is present before
the table is first laid out, the descendent is sized based on the
specified size of the table cell. However, when the child isn't present
when the table is first laid out, the table cell ignores its specified
size and collapses down to 0. Then, when the child div is added in a
separate run loop iteration, it is sized to be 100% of the collapsed
cell height instead of 100% of the cell's specified height. We should
not get different layouts depending on the timing of tree construction.
Fix this by clearing intrinsic padding before calculating the table
cell's override height when we detect a child that should flex the
table cell.
Test: fast/table/dynamic-descendant-percentage-height.html
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::setOverrideSizeFromRowHeight): clear
intrinsic padding before setting the override size.
* rendering/RenderTableCell.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows): Call
setOverrideSizeFromRowHeight() instead of setOverrideSize().
2011-03-11 Michael Nordman <michaeln@google.com>
Reviewed by David Levin.
Add SQLCallbackWrapper
Instead of directly holding RefPtrs to the Callback objects in SQLStatement and SQLTransaction, hold a wrapper objects
which holds those references whose dtors will schedule the release of those references on the ScriptExecution thread.
https://bugs.webkit.org/show_bug.cgi?id=55919
No new tests, existing tests apply.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* storage/SQLCallbackWrapper.h: Added.
(WebCore::SQLCallbackWrapper::SQLCallbackWrapper):
(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::unwrap):
(WebCore::SQLCallbackWrapper::hasCallback):
(WebCore::SQLCallbackWrapper::safeRelease):
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::create):
(WebCore::SQLStatement::SQLStatement):
(WebCore::SQLStatement::performCallback):
* storage/SQLStatement.h:
(WebCore::SQLStatement::hasStatementCallback):
(WebCore::SQLStatement::hasStatementErrorCallback):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::postflightAndCommit):
(WebCore::SQLTransaction::deliverSuccessCallback):
(WebCore::SQLTransaction::handleTransactionError):
(WebCore::SQLTransaction::deliverTransactionErrorCallback):
* storage/SQLTransaction.h:
2011-03-11 Eric Carlson <eric.carlson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8955589> Adopt AVFoundation media back end on Lion.
No new tests, existing media tests cover this.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Register MediaPlayerPrivateAVFoundationObjC.
(WebCore::bestMediaEngineForTypeAndCodecs): Kill some whitespace.
(WebCore::MediaPlayer::loadWithNextMediaEngine): Ditto.
(WebCore::MediaPlayer::inMediaDocument): Ditto.
* platform/graphics/MediaPlayer.h:
* platform/graphics/avfoundation: Added.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: Added.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Added.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Added.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Added.
2011-03-11 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=56205
m_restrictions needs to allow multiple values (a bitfield)
HTMLMediaElement::m_restrictions needs to hold multiple values, so
change BehaviorRestrictions to an unsigned typedef and rename the
existing enum BehaviorRestrictionFlags.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::setBehaviorRestrictions):
2011-03-11 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=47206
Table rows don't support ::before/::after. Add support to RenderTableRow::styleDidChange so that ::before/::after content gets
properly constructed.
Added fast/css-generated-content/table-row-before-after.html
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
* rendering/RenderTableRow.h:
2011-03-11 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Avoid updating a composited layer's contents if the layer has nonpositive dimensions
https://bugs.webkit.org/show_bug.cgi?id=56209
This matches the behavior prior to r80482. No test since the only changes in
behavior are avoiding work on invisible layers, which is unobservable,
and fixing a crash due to bug 56153.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateContentsRecursive):
2011-03-11 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=47159
CSS2.1 failures in background position parsing.
Rewrite background position component parsing to match the spec. Our old parsing would allow "100% left" to be valid
when it should not have. Rename parseFillPositionXY to parseFillPositionComponent and pass in enough information for
it to understand what the first component was.
For individual property parsing using background-position-x/y, I added new functions that just handle that without
worrying about the other component.
In order to pass the CSS2.1 test, I also had to fix multiple background parsing. The number of layers in multiple
backgrounds is determined solely by the background-image property and not by any of the other properties. cullEmptyLayers
has been changed to always consider a layer empty if it has no image set, even if other properties are set.
A number of layout tests had to be patched as they were invalid. A couple of them relied on incorrect background-position
parsing (e.g., "50 left") and another relied on incorrect multiple background parsing. It's not clear if the computed style
should actually include the additional values when no image is set though, so that should perhaps be the subject of a
follow-up bug.
Added fast/backgrounds/background-position-parsing.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parsePerspectiveOrigin):
* css/CSSParser.h:
* rendering/style/FillLayer.cpp:
(WebCore::FillLayer::fillUnsetProperties):
(WebCore::FillLayer::cullEmptyLayers):
2011-03-11 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Allow large layers with non-identity transforms to be drawn
as long as their visible portion is smaller than the largest supported
texture size. This code will soon be replaced by tiled layers.
https://bugs.webkit.org/show_bug.cgi?id=55984
Test: platform/chromium/compositing/huge-layer-rotated.html
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::updateContentsIfDirty):
(WebCore::ContentLayerChromium::draw):
* platform/graphics/chromium/ContentLayerChromium.h:
2011-03-09 Chris Marrin <cmarrin@apple.com>
Reviewed by Adam Roben.
REGRESSION (5.0.3-ToT): Scrolling text doesn't scroll in Star Wars intro animation
https://bugs.webkit.org/show_bug.cgi?id=52468
Added WIN32 to the ifdef controlling whether animations are applied in normal or
reverse order. On Mac, animations used to be applied in reverse, but
<rdar://problem/7095638> fixed this in the release after Snow Leopard.
But that patch has not be applied to the Safari Windows SDK yet. For now
I've made Windows use the reverse order logig. <rdar://problem/9112233> is
tracking the inclusion of the patch on Windows.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
2011-03-11 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Let the parser yield for layout before running scripts
https://bugs.webkit.org/show_bug.cgi?id=54355
Prior to this patch, the parser would yield to perform a layout/paint before running a
script only if the script or a stylesheet blocking the script is not loaded yet. Since we
don't preload scan into the body while parsing the head, typically we'll block on a script
early in the body that causes us to yield to do the first paint within a reasonable time.
However, I'm planning to change the PreloadScanner to scan into the body from the head.
That significantly improves overall load time, but would hurt first paint time because
fewer scripts would be blocked during parsing and thus wouldn't yield.
This change causes us to yield before running scripts if we haven't painted yet (regardless
of whether or not the script is loaded). In addition to allowing the above mentioned
PreloadScanner change to be implemented without regressing first paint time, this also
improves first paint time by itself.
I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
signifcant change in page load time.
Within the pages tested, 33 had no statistically significant change in time to first paint,
12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point.
(WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused
means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does
the right thing whether we are just before a token or waiting for a script. Now that we may
yield before a token or before a script, this may be called while paused.
* html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
* page/FrameView.h:
(WebCore::FrameView::hasEverPainted): Added.
2011-03-11 Dimitri Glazkov <dglazkov@chromium.org>
Fix crashes in dom/html/level2/html/HTMLInputElement*.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle): Added a null-check for e,
because e can certainly be a null.
2011-03-09 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by David Hyatt.
Choke text-decoration when entering shadow DOM subtree.
https://bugs.webkit.org/show_bug.cgi?id=56044
No new tests, because the functionality can't be tested yet.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle): Added a check for shadow DOM root.
2011-03-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer.
https://bugs.webkit.org/show_bug.cgi?id=55972
Instead of poking at the time display elements all the way from RenderMedia,
let the standard layout cycle take care of things. Move the logic of calculating
when to collapse the time display elements into a custom renderer, since
this is not something that can be accomplished with CSS.
Also, the logic of keeping the timeline slider at least 100px needed refreshing,
since it didn't actually keep it at 100px.
* html/shadow/MediaControls.cpp: Moved the logic of determining visibility
of time display elements to RenderMediaControlTimeDisplay, eliminating
updateTimeDisplayVisibility method.
* html/shadow/MediaControls.h: Removed decl.
* rendering/MediaControlElements.cpp:
(WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
Added new renderer class.
(WebCore::RenderMediaControlTimeDisplay::layout): Simplified (and corrected)
size-sensing logic, still using hard-coded values.
(WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
Removed m_isVisible member, which is no longer necessary.
(WebCore::MediaControlTimeDisplayElement::createRenderer): Added to
return the new renderer.
* rendering/MediaControlElements.h: Adjusted decls.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout): Remove the now-unnecessary poking at
media controls in layout.
2011-03-09 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
Start focusing updates to media controls, away from always updating everything.
https://bugs.webkit.org/show_bug.cgi?id=56038
For now, the new methods just call generic MediaControls::update.
Covered by existing tests.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged): Changed to use MediaControls::reset.
(WebCore::HTMLMediaElement::setMuted): Changed to use MediaControls::changedMute.
(WebCore::HTMLMediaElement::updateVolume): Changed to use MediaControls::changedVolume.
(WebCore::HTMLMediaElement::defaultEventHandler): Changed to use the new mediaControls
accessor.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Changed to use
MediaControls::changedClosedCaptionsVisibility.
(WebCore::HTMLMediaElement::mediaControls): Added.
(WebCore::HTMLMediaElement::hasMediaControls): Added.
* html/HTMLMediaElement.h: Added decls.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::reset): Added.
(WebCore::MediaControls::changedMute): Added.
(WebCore::MediaControls::changedVolume): Added.
(WebCore::MediaControls::changedClosedCaptionsVisibility): Added.
* html/shadow/MediaControls.h: Added decls.
2011-03-11 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Martin Robinson.
[GStreamer] When seeking webKitWebSrcStop release the frame but should not.
https://bugs.webkit.org/show_bug.cgi?id=55703
When calling webKitWebSrcStop in case of a seeking, the frame should not
be reset (the source hasn't change). The frame may be used to get the network
context. Some network stack (like Qt) are relaying on the network context
to work.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStop):
2011-03-11 Dean Jackson <dino@apple.com>
Unreviewed.
Build fixes for GTK and Leopard.
* bindings/gobject/GNUmakefile.am:
- add missing WebKitAnimation* generated bindings
* page/WebKitAnimation.idl:
- use double in place of float (the core values are double anyway)
2011-03-11 Dean Jackson <dino@apple.com>
Unreviewed build fix for QT.
* WebCore.pro:
2011-03-11 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser and Chris Marrin.
https://bugs.webkit.org/show_bug.cgi?id=54151
Implement an API to play/pause/scrub animations
This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
APIs, exposed via Element.getWebKitAnimations(). This first pass
is a read-only API - a subsequent commit will add the ability
to scrub animations.
Test: animations/animation-api-1.html
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* Android.mk:
* Android.v8bindings.mk:
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
- All build settings updated for new files
* bindings/js/JSBindingsAllInOne.cpp:
- Include new custom files
* bindings/js/JSWebKitAnimationCustom.cpp: Added.
(WebCore::JSWebKitAnimation::iterationCount):
- Custom property getter so that we can return INFINITY
* bindings/js/JSWebKitAnimationListCustom.cpp: Added.
(WebCore::JSWebKitAnimationList::markChildren):
- Make sure WebKitAnimations are marked
* bindings/v8/custom/V8WebKitAnimationCustom.cpp: Added.
(WebCore::V8WebkitAnimation::iterationCountAccessorGetter):
- Custom property getter so that we can return INFINITY
* dom/Element.cpp:
(WebCore::Element::webkitGetAnimations):
* dom/Element.h:
* dom/Element.idl:
- New API entry point
* page/DOMWindow.idl:
- Constructor definitions for WebKitAnimation and WebKitAnimationList
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::~AnimationBase):
- Since AnimationBase can now live longer (if a WebKitAnimation is
held in Javascript) we need to guard for the renderer having disappeared.
(WebCore::AnimationBase::setElapsedTime):
(WebCore::AnimationBase::play):
(WebCore::AnimationBase::pause):
- Stub implementations at present
* page/animation/AnimationBase.h:
(WebCore::AnimationBase::animation):
- Expose the Animation properties
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::animationsForRenderer):
(WebCore::AnimationController::animationsForRenderer):
- Builds the list of WebKitAnimations
* page/animation/AnimationController.h:
* page/animation/AnimationControllerPrivate.h:
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateKeyframeAnimations):
- Make sure we clear the renderer if we are removing the animation
(WebCore::CompositeAnimation::animations):
* page/animation/CompositeAnimation.h:
* page/WebKitAnimation.cpp: Added.
(WebCore::WebKitAnimation::WebKitAnimation):
(WebCore::WebKitAnimation::name):
(WebCore::WebKitAnimation::duration):
(WebCore::WebKitAnimation::elapsedTime):
(WebCore::WebKitAnimation::setElapsedTime):
(WebCore::WebKitAnimation::delay):
(WebCore::WebKitAnimation::iterationCount):
(WebCore::WebKitAnimation::paused):
(WebCore::WebKitAnimation::ended):
(WebCore::WebKitAnimation::direction):
(WebCore::WebKitAnimation::fillMode):
(WebCore::WebKitAnimation::pause):
(WebCore::WebKitAnimation::play):
- The implementation of the new API. All the read-only parts are
done, but elapsedTime, play() and pause() are stubs.
* page/WebKitAnimation.h: Added.
(WebCore::WebKitAnimation::create):
(WebCore::WebKitAnimation::~WebKitAnimation):
* page/WebKitAnimation.idl: Added.
* page/WebKitAnimationList.cpp: Added.
* page/WebKitAnimationList.h: Added.
* page/WebKitAnimationList.idl: Added.
- Copies NodeList implementation
2011-03-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce error argument for all the callbacks on frontend.
https://bugs.webkit.org/show_bug.cgi?id=56100
* inspector/CodeGeneratorInspector.pm:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.evaluateInTargetWindow):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getStylesAsync):
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleModel.prototype.getInlineStyleAsync):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
(WebInspector.CSSStyleModel.prototype._onRevert):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSProperty.prototype.setText.callback):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setDisabled.callback):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.createForId):
(WebInspector.CSSStyleSheet.prototype.setText):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.setNodeName):
(WebInspector.DOMNode.prototype.setNodeValue):
(WebInspector.DOMNode.prototype.setAttribute):
(WebInspector.DOMNode.prototype.removeAttribute):
(WebInspector.DOMNode.prototype.childNodes.mycallback):
(WebInspector.DOMNode.prototype.childNodes):
(WebInspector.DOMNode.prototype.outerHTML):
(WebInspector.DOMNode.prototype.setOuterHTML):
(WebInspector.DOMNode.prototype.removeNode):
(WebInspector.DOMNode.prototype.copyNode):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
(WebInspector.DOMAgent.prototype._documentUpdated):
(WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
(WebInspector.Cookies.getCookiesAsync):
(WebInspector.EventListeners.getEventListenersForNodeAsync):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage.prototype.getEntries):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
* inspector/front-end/Database.js:
(WebInspector.Database.prototype.getTableNames):
(WebInspector.Database.prototype.executeSql):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.prototype.editScriptSource):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._setSearchingForNode):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
():
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionWatchSidebarPane.prototype._onEvaluate):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkManager.prototype._processCachedResources):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView.profileCallback):
(WebInspector.CPUProfileView):
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.resolveNode):
(WebInspector.RemoteObject.prototype.getProperties.remoteObjectBinder):
(WebInspector.RemoteObject.prototype.getProperties):
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.evaluate):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.requestSource.didGetScriptSource):
(WebInspector.Script.prototype.requestSource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
(WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
* inspector/front-end/inspector.js:
():
(WebInspector.doLoadedDone.onPopulateScriptObjects):
(WebInspector.doLoadedDone.propertyNamesCallback):
(WebInspector.doLoadedDone):
2011-03-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173
Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
* bindings/js/JSInjectedScriptManager.cpp: Added.
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
* inspector/ConsoleMessage.h:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::canAccessInspectedWindow):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::create):
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::~InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
(WebCore::InjectedScriptHost::inspectImpl):
(WebCore::InjectedScriptHost::clearConsoleMessages):
(WebCore::InjectedScriptHost::databaseIdImpl):
(WebCore::InjectedScriptHost::storageIdImpl):
* inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::init):
(WebCore::InjectedScriptHost::setFrontend):
(WebCore::InjectedScriptHost::clearFrontend):
* inspector/InjectedScriptManager.cpp: Added.
(WebCore::InjectedScriptManager::create):
(WebCore::InjectedScriptManager::InjectedScriptManager):
(WebCore::InjectedScriptManager::~InjectedScriptManager):
(WebCore::InjectedScriptManager::disconnect):
(WebCore::InjectedScriptManager::injectedScriptHost):
(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptForObjectId):
(WebCore::InjectedScriptManager::discardInjectedScripts):
(WebCore::InjectedScriptManager::releaseObjectGroup):
(WebCore::InjectedScriptManager::injectedScriptSource):
(WebCore::InjectedScriptManager::injectScript):
* inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::inspectedPageDestroyed):
(WebCore::InspectorAgent::focusNode):
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
(WebCore::InspectorAgent::createFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::domContentLoadedEventFired):
* inspector/InspectorAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
(WebCore::InspectorConsoleAgent::addInspectedNode):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::pushNodeToFrontend):
(WebCore::InspectorDOMAgent::resolveNode):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::create):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::create):
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::evaluateOn):
(WebCore::InspectorRuntimeAgent::getProperties):
(WebCore::InspectorRuntimeAgent::setPropertyValue):
(WebCore::InspectorRuntimeAgent::releaseObject):
(WebCore::InspectorRuntimeAgent::releaseObjectGroup):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
(WebInspector.ElementsPanel):
2011-03-11 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Change the way group id for CSS objects is calculated
https://bugs.webkit.org/show_bug.cgi?id=56117
Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
as they should not be reachable in JavaScript.
Covered by existing layout tests. Fact of absence of retention is not trivial to prove.
* bindings/v8/V8GCController.cpp:
(WebCore::calculateGroupId):
(WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
2011-03-11 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: hover over elements in Elements panel does not highlight nodes
https://bugs.webkit.org/show_bug.cgi?id=56121
In DOM trees with a comment and/or doctype preceding the HTML tag, the tree container right boundary
is 16px apart from the OL right boundary, and we miss the relevant LI by 4px. The fix is to compensate
for these 16px when computing the test point coordinates.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
2011-03-11 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Roll out r80837.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
(WebCore::InjectedScriptHost::discardInjectedScript):
(WebCore::InjectedScriptHost::injectedScriptFor):
(WebCore::InjectedScriptHost::canAccessInspectedWindow):
* bindings/js/JSInjectedScriptManager.cpp: Removed.
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):
(WebCore::InjectedScriptHost::createInjectedScript):
(WebCore::InjectedScriptHost::discardInjectedScript):
(WebCore::InjectedScriptHost::injectedScriptFor):
(WebCore::InjectedScriptHost::canAccessInspectedWindow):
* bindings/v8/custom/V8InjectedScriptManager.cpp: Removed.
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
* inspector/ConsoleMessage.h:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::canAccessInspectedWindow):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::~InjectedScriptHost):
(WebCore::InjectedScriptHost::inspectImpl):
(WebCore::InjectedScriptHost::clearConsoleMessages):
(WebCore::InjectedScriptHost::databaseIdImpl):
(WebCore::InjectedScriptHost::storageIdImpl):
(WebCore::InjectedScriptHost::injectedScriptForId):
(WebCore::InjectedScriptHost::injectedScriptForObjectId):
(WebCore::InjectedScriptHost::injectedScriptForMainFrame):
(WebCore::InjectedScriptHost::discardInjectedScripts):
(WebCore::InjectedScriptHost::releaseObjectGroup):
(WebCore::InjectedScriptHost::frontend):
(WebCore::InjectedScriptHost::injectedScriptSource):
(WebCore::InjectedScriptHost::injectScript):
* inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::create):
(WebCore::InjectedScriptHost::inspectorAgent):
(WebCore::InjectedScriptHost::disconnectController):
* inspector/InjectedScriptManager.cpp: Removed.
* inspector/InjectedScriptManager.h: Removed.
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::inspectedPageDestroyed):
(WebCore::InspectorAgent::focusNode):
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
(WebCore::InspectorAgent::createFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::domContentLoadedEventFired):
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::injectedScriptHost):
* inspector/InspectorBrowserDebuggerAgent.cpp:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::addInspectedNode):
(WebCore::InspectorDOMAgent::pushNodeToFrontend):
(WebCore::InspectorDOMAgent::resolveNode):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::create):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::evaluateOn):
(WebCore::InspectorRuntimeAgent::getProperties):
(WebCore::InspectorRuntimeAgent::setPropertyValue):
(WebCore::InspectorRuntimeAgent::releaseObject):
(WebCore::InspectorRuntimeAgent::releaseObjectGroup):
* inspector/InspectorRuntimeAgent.h:
(WebCore::InspectorRuntimeAgent::create):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
(WebInspector.ElementsPanel):
2011-03-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173
Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
* bindings/js/JSInjectedScriptManager.cpp: Added.
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
* inspector/ConsoleMessage.h:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::canAccessInspectedWindow):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::create):
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::~InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
(WebCore::InjectedScriptHost::inspectImpl):
(WebCore::InjectedScriptHost::clearConsoleMessages):
(WebCore::InjectedScriptHost::databaseIdImpl):
(WebCore::InjectedScriptHost::storageIdImpl):
* inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::init):
(WebCore::InjectedScriptHost::setFrontend):
(WebCore::InjectedScriptHost::clearFrontend):
* inspector/InjectedScriptManager.cpp: Added.
(WebCore::InjectedScriptManager::create):
(WebCore::InjectedScriptManager::InjectedScriptManager):
(WebCore::InjectedScriptManager::~InjectedScriptManager):
(WebCore::InjectedScriptManager::disconnect):
(WebCore::InjectedScriptManager::injectedScriptHost):
(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptForObjectId):
(WebCore::InjectedScriptManager::discardInjectedScripts):
(WebCore::InjectedScriptManager::releaseObjectGroup):
(WebCore::InjectedScriptManager::injectedScriptSource):
(WebCore::InjectedScriptManager::injectScript):
* inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::inspectedPageDestroyed):
(WebCore::InspectorAgent::focusNode):
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
(WebCore::InspectorAgent::createFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::domContentLoadedEventFired):
* inspector/InspectorAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
(WebCore::InspectorConsoleAgent::addInspectedNode):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::pushNodeToFrontend):
(WebCore::InspectorDOMAgent::resolveNode):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::create):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::create):
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::evaluateOn):
(WebCore::InspectorRuntimeAgent::getProperties):
(WebCore::InspectorRuntimeAgent::setPropertyValue):
(WebCore::InspectorRuntimeAgent::releaseObject):
(WebCore::InspectorRuntimeAgent::releaseObjectGroup):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
(WebInspector.ElementsPanel):
2011-03-09 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Make IDBBackingStore abstract
https://bugs.webkit.org/show_bug.cgi?id=56013
Make IDBBackingStore abstract to allow for multiple implementations.
Move the SQLite implementation to IDBSQLiteBackingStore.
No new tests: refactoring only.
* WebCore.gypi:
* storage/IDBBackingStore.h:
(WebCore::IDBBackingStore::~IDBBackingStore):
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore):
(WebCore::IDBSQLiteBackingStore::~IDBSQLiteBackingStore):
(WebCore::runCommands):
(WebCore::createTables):
(WebCore::createMetaDataTable):
(WebCore::getDatabaseSchemaVersion):
(WebCore::migrateDatabase):
(WebCore::IDBSQLiteBackingStore::open):
(WebCore::IDBSQLiteBackingStore::extractIDBDatabaseMetaData):
(WebCore::IDBSQLiteBackingStore::setIDBDatabaseMetaData):
(WebCore::IDBSQLiteBackingStore::getObjectStores):
(WebCore::IDBSQLiteBackingStore::createObjectStore):
(WebCore::doDelete):
(WebCore::IDBSQLiteBackingStore::deleteObjectStore):
(WebCore::whereSyntaxForKey):
(WebCore::bindKeyToQuery):
(WebCore::lowerCursorWhereFragment):
(WebCore::upperCursorWhereFragment):
(WebCore::IDBSQLiteBackingStore::getObjectStoreRecord):
(WebCore::bindKeyToQueryWithNulls):
(WebCore::IDBSQLiteBackingStore::putObjectStoreRecord):
(WebCore::IDBSQLiteBackingStore::clearObjectStore):
(WebCore::IDBSQLiteBackingStore::deleteObjectStoreRecord):
(WebCore::IDBSQLiteBackingStore::nextAutoIncrementNumber):
(WebCore::IDBSQLiteBackingStore::keyExistsInObjectStore):
(WebCore::IDBSQLiteBackingStore::forEachObjectStoreRecord):
(WebCore::IDBSQLiteBackingStore::getIndexes):
(WebCore::IDBSQLiteBackingStore::createIndex):
(WebCore::IDBSQLiteBackingStore::deleteIndex):
(WebCore::IDBSQLiteBackingStore::putIndexDataForRecord):
(WebCore::IDBSQLiteBackingStore::deleteIndexDataForRecord):
(WebCore::IDBSQLiteBackingStore::getObjectViaIndex):
(WebCore::keyFromQuery):
(WebCore::IDBSQLiteBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBSQLiteBackingStore::keyExistsInIndex):
(WebCore::IDBSQLiteBackingStore::openObjectStoreCursor):
(WebCore::IDBSQLiteBackingStore::openIndexKeyCursor):
(WebCore::IDBSQLiteBackingStore::openIndexCursor):
(WebCore::IDBSQLiteBackingStore::createTransaction):
* storage/IDBSQLiteBackingStore.h: Added.
2011-03-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed build error fix.
[EFL] Fix build break when SHARED_CORE is ON
https://bugs.webkit.org/show_bug.cgi?id=56155
* platform/efl/ContextMenuEfl.cpp:
(WebCore::ContextMenu::ContextMenu):
* platform/efl/ContextMenuItemEfl.cpp:
(WebCore::ContextMenuItem::nativeMenuItem):
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
2011-03-11 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: resource load cancellation is reported to console as an error
https://bugs.webkit.org/show_bug.cgi?id=55764
- mark interruptionForPolicyChangeError as cancellation
- do not log resource cancelation as an error
- always push resource to front-end before console message, so front-end can use resource info while formatting message.
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::didFailLoading):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::stopLoadingForPolicyChange):
2011-03-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Get rid of has/add/removeStyleClass() methods on Element.prototype - Step 1
https://bugs.webkit.org/show_bug.cgi?id=56096
No new tests, as this is a refactoring.
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane):
* inspector/front-end/DetailedHeapshotView.js:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.BaseStorageTreeElement):
(WebInspector.BaseStorageTreeElement.prototype.onattach):
(WebInspector.StorageCategoryTreeElement):
(WebInspector.FrameTreeElement):
(WebInspector.FrameResourceTreeElement):
(WebInspector.DatabaseTreeElement):
(WebInspector.DatabaseTableTreeElement):
(WebInspector.DOMStorageTreeElement):
(WebInspector.CookieTreeElement):
(WebInspector.ApplicationCacheTreeElement):
(WebInspector.ResourceRevisionTreeElement):
* inspector/front-end/utilities.js:
(Element.prototype.removeStyleClass):
(Element.prototype.addStyleClass):
(Element.prototype.hasStyleClass):
2011-03-11 Brian Salomon <bsalomon@google.com>
Reviewed by Kenneth Russell.
Adds GrContext flush call to PlatformContextSkia destructor.
Calls GrContext flush with int parameter instead of bool due to skia
revision.
No new tests needed.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::publishToPlatformLayer):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::~PlatformContextSkia):
(WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2011-03-10 Chris Guillory <chris.guillory@google.com>
Reviewed by James Robinson.
Fix for Coverity discovered NO_EFFECT (self-assign) defect.
https://bugs.webkit.org/show_bug.cgi?id=54143
* platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::setMaxTextureSize):
2011-03-10 Emil A Eklund <eae@chromium.org>
Reviewed by Alexey Proskuryakov.
The web colours palevioletred and mediumpurple are incorrect
https://bugs.webkit.org/show_bug.cgi?id=46658
Changed value for the palevioletred and mediumpurple colors to match
the css3 specification.
Test: fast/css/named-colors.html
* inspector/front-end/Color.js:
* platform/ColorData.gperf:
2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed build fix.
[WML] Fix build error
https://bugs.webkit.org/show_bug.cgi?id=56078
* wml/WMLInputElement.cpp:
(WebCore::WMLInputElement::defaultEventHandler):
2011-03-10 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Darin Adler.
Fix navigation menus on a bunch of sites in WebKit.
https://bugs.webkit.org/show_bug.cgi?id=52535
WebKit doesn't support position:relative for several table elements and
overwrites the style internally when position:relative is encountered.
Unfortunately position:relative affects the choice of nodes returned by
offsetParent.
This CL adds a bit to RenderStyle to track whether position:relative was
overwritten. The value is then consulted in offsetParent which makes us
match FF/IE.
Tests: fast/block/positioning/offsetLeft-relative-iframe.html
fast/block/positioning/offsetLeft-relative-td.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::isOriginallyRelPositioned):
(WebCore::RenderObject::offsetParent):
* rendering/RenderObject.h:
* rendering/style/RenderStyle.h: Add a bit to track the original value of position:relative.
(WebCore::InheritedFlags::positionWasRelative):
(WebCore::InheritedFlags::setPositionWasRelative):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
2011-03-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
REGRESSION (r66428/r71892): Crash after assertion failure (!m_reachedTerminalState) in ResourceLoader::didCancel()
https://bugs.webkit.org/show_bug.cgi?id=51357
Previously, we would try to print from a callstack that didn't want a
nested event loop, leading to re-entrancy problems. In this patch, we
complete the print call asynchronously, giving us a clean stack on
which to run the nested event loop.
Test: printing/print-close-crash.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::print):
(WebCore::DOMWindow::printTimerFired):
* page/DOMWindow.h:
2011-03-11 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Ryosuke Niwa.
Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/
https://bugs.webkit.org/show_bug.cgi?id=55570
Add a virtual function toInputElement() to Node that has a default
implementation of returning 0.
For HTMLInputElement and WMLInputElement (which derive from InputElement)
override this to return the object.
Change all calling sites of the old toInputElement to use the new member
function. This also allows us to save some casts.
No new tests. (refactoring)
* WebCore.exp.in:
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isPasswordField):
(WebCore::AccessibilityRenderObject::isIndeterminate):
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityRenderObject::isChecked):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* dom/CheckedRadioButtons.cpp:
(WebCore::CheckedRadioButtons::removeButton):
* dom/InputElement.cpp:
* dom/InputElement.h:
* dom/Node.cpp:
(WebCore::Node::toInputElement):
* dom/Node.h:
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::toInputElement):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::inputElement):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isChecked):
(WebCore::RenderTheme::isIndeterminate):
* wml/WMLInputElement.h:
(WebCore::WMLInputElement::toInputElement):
2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] New mediaControl css file for EFL
https://bugs.webkit.org/show_bug.cgi?id=55460
Add new mediaControl css file for html5 video UI.
* CMakeLists.txt:
* CMakeListsEfl.txt:
* css/mediaControlsEfl.css: Added.
(audio):
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(video:-webkit-full-page-media::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
(audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::extraMediaControlsStyleSheet):
2011-03-10 Emil A Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
style.display affecting the initial selectedIndex value of a <select> when its multiple attribute is set programatically
https://bugs.webkit.org/show_bug.cgi?id=53860
Preserve selection when changing between multi-select and single-select
for <select> boxes even if it has not yet been rendered.
Test: fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setMultiple):
2011-03-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
update comment to reference new DOM Core spec
https://bugs.webkit.org/show_bug.cgi?id=56079
I'm excising all instances of WRONG_DOCUMENT_ERR from WebKit.
This is the only one that's actually specified to fire
in the latest DOM Core spec.
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
2011-03-10 Rik Cabanier <cabanier@gmail.com>
Reviewed by Tony Gentilcore.
Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::convertToLength):
(WebCore::convertToIntLength):
(WebCore::convertToFloatLength):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::createTransformOperations):
* platform/Length.h:
(WebCore::Length::Length):
(WebCore::Length::operator==):
(WebCore::Length::operator!=):
(WebCore::Length::rawValue):
(WebCore::Length::type):
(WebCore::Length::quirk):
(WebCore::Length::setValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::isZero):
(WebCore::Length::blend):
(WebCore::Length::getIntValue):
(WebCore::Length::getFloatValue):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80800.
http://trac.webkit.org/changeset/80800
https://bugs.webkit.org/show_bug.cgi?id=56163
Caused hundreds of tests to crash on Windows 7 (Requested by
rniwa on #webkit).
* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):
* page/FocusController.cpp:
(WebCore::FocusController::setActive):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
* page/FrameView.h:
* page/Page.cpp:
* page/Page.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* rendering/RenderDataGrid.cpp:
(WebCore::RenderDataGrid::RenderDataGrid):
(WebCore::RenderDataGrid::~RenderDataGrid):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):
2011-03-10 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Dimitri Glazkov.
NULL pointer crash when using :empty and :first-line pseudoclass selectors together
https://bugs.webkit.org/show_bug.cgi?id=53316
:empty is calculated for each element during parsing, but then not
recalculated after any child elements are attached. Force style
re-calculation on elements which have :empty in their style when
their children are changed.
Test: fast/css/empty-first-line-crash.html
* dom/Element.cpp:
(WebCore::checkForEmptyStyleChange): Pull out empty style checking
logic from checkForSiblingStyleChanges().
(WebCore::checkForSiblingStyleChanges): Use new checkForEmptyStyleChanges()
method.
(WebCore::Element::childrenChanged): Call checkForEmptyStyleChanges() when
called with changedByParser = true.
2011-03-10 Emil A Eklund <eae@chromium.org>
Unreviewed build fix.
Fix Leopard Release build broken by r80797.
* html/CollectionCache.h:
2011-03-10 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/8944558> Overlay scrollers in overflow areas need to
send notifications appropriate times (showing up, resizing)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=56067
The general strategy here is to add a HashSet of ScrollableAreas to the page that
can be accessed when necessary to send notifications to all ScrollableAreas.
Find layers for relevant node and if the layers are in the Page's ScrollableArea
set, then send the relevant notification.
* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):
When the page is set active or not active, iterate through the Page's
ScrollableAreas to send hide/show notifications.
* page/FocusController.cpp:
(WebCore::FocusController::setActive):
When a FrameView is created, add it to the ScrollableArea set. When it's
destroyed, remove it.
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
Iterate through the Page's ScrollableAreas to send the paint notification.
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
* page/FrameView.h:
Add the new ScrollableArea set.
* page/Page.cpp:
(WebCore::Page::addScrollableArea):
(WebCore::Page::removeScrollableArea):
(WebCore::Page::pageContainsScrollableArea):
* page/Page.h:
(WebCore::Page::scrollableAreaSet):
notifyPageThatContentAreaWillPaint() is a dummy function implemented in FrameView.
* platform/ScrollView.cpp:
(WebCore::ScrollView::notifyPageThatContentAreaWillPaint):
Call notifyPageThatContentAreaWillPaint() instead of calling
contentAreaWillPaint() just for the ScrollView.
(WebCore::ScrollView::paint):
* platform/ScrollView.h:
Add/remove ScrollableAreas to the set.
* rendering/RenderDataGrid.cpp:
(WebCore::RenderDataGrid::RenderDataGrid):
(WebCore::RenderDataGrid::~RenderDataGrid):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
Should have implemented this ScrollableArea-interface function a while ago.
(WebCore::RenderLayer::currentMousePosition):
* rendering/RenderLayer.h:
2011-03-10 takano takumi <takano@apple.com>
Reviewed by David Hyatt.
Crash in RenderCombineText::combineText when running fast/text/international/text-combine-parser-test.html on Windows with full page heap enabled
https://bugs.webkit.org/show_bug.cgi?id=55069
No new tests. If the test above runs without crash, the fix should be okay.
* dom/Node.cpp:
(WebCore::Node::diff):
- Changed to return Detach when textCombine style was changed.
* rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
(WebCore::RenderCombineText::setTextInternal):
(WebCore::RenderCombineText::width):
(WebCore::RenderCombineText::adjustTextOrigin):
(WebCore::RenderCombineText::charactersToRender):
(WebCore::RenderCombineText::combineText):
- Added assertions to ensure the passed object is RenderCombineText.
* rendering/RenderCombineText.h:
(WebCore::RenderCombineText::isCombineText):
- Added to distinguish plain RenderText and RenderCombineText.
(WebCore::toRenderCombineText):
- Added assertions to ensure the passed object is RenderCombineText.
* rendering/RenderObject.h:
(WebCore::RenderObject::isCombineText):
- Added to distinguish plain RenderText and RenderCombineText.
2011-03-10 Emil A Eklund <eae@chromium.org>
Reviewed by Darin Adler.
Collection cache not reset when moving base node between documents
https://bugs.webkit.org/show_bug.cgi?id=55446
Fix bug where HTMLCollection::resetCollectionInfo does not reset the
cache when the base node is moved to a different document by making sure
that the DOMVersion is updated and that it's unique across documents.
Tests: fast/dom/HTMLFormElement/invalid-form-field.html
fast/dom/HTMLFormElement/move-option-between-documents.html
fast/dom/collection-nameditem-move-between-documents.html
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Document::incDOMTreeVersion):
(WebCore::Document::domTreeVersion):
* dom/Node.cpp:
(WebCore::Node::setDocumentRecursively):
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::resetFormOwner):
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::resetCollectionInfo):
* xml/XPathResult.h:
2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed build fix.
[EFL] Fix build break when CROSS_PLATFORM_CONTEXT_MENUS is disabled.
https://bugs.webkit.org/show_bug.cgi?id=56005
There are build breaks when CROSS_PLATFORM_CONTEXT_MENUS is disabled.
* platform/efl/ContextMenuEfl.cpp:
(WebCore::ContextMenu::ContextMenu):
* platform/efl/ContextMenuItemEfl.cpp:
2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
startOfBlock and endOfBlock may return a position inside hr
https://bugs.webkit.org/show_bug.cgi?id=56025
Replaced calls to enclosingBlockFlowElement in startOfBlock and endOfBlock by
calls to enclosingBlock. Added EditingBoundaryCrossingRule to the argument lists
of startOfBlock, endOfBlock, and enclosingBlock. Also replaced the last boolean
argument variable of enclosingNodeOfType by EditingBoundaryCrossingRule.
Also replaced calls to enclosingBlockFlowElement in inSameBlock by calls to
enclosingBlock to be consitent with startOfBlock and endOfBlock.
This patch also replaced calls to deprecatedNode in startOfBlock, endOfBlock,
and inSameBlock by calls to containerNode because the enclosing block of a position
should never be before or after the position.
No tests are added because this change only affects WebCore internally.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::initializePositionData): Calls enclosingNodeOfType.
Pass CanCrossEditingBoundary instead of false.
* editing/htmlediting.cpp:
(WebCore::unsplittableElementForPosition): Ditto.
(WebCore::enclosingBlock): Takes EditingBoundaryCrossingRule and passes it to
enclosingNodeOfType.
(WebCore::enclosingNodeOfType): Takes EditingBoundaryCrossingRule instead of boolean.
Fixed a bug that it stops walking the tree when it reached the root editable node
even when the editing boundary crossing rule is CanCrossEditingBoundary.
* editing/htmlediting.h: Prototype changes.
* editing/visible_units.cpp:
(WebCore::startOfBlock): Calls enclosingBlock instead of enclosingBlockFlowElement.
Also added an early exit when there's no enclosing block.
(WebCore::endOfBlock): Ditto. The early exist in this case prevents crash in
lastPositionInNode.
(WebCore::inSameBlock): Calls enclosingBlock instead of enclosingBlockFlowElement.
(WebCore::isStartOfBlock): Calls startOfBlock with CanCrossEditingBoundary because
we don't care where the start of block is when we're comparing against the given position.
(WebCore::isEndOfBlock): Ditto.
* editing/visible_units.h:
2011-03-10 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
Backspace deletes all non-BMP symbols at once, and then some
https://bugs.webkit.org/show_bug.cgi?id=55971
<rdar://problem/8725312>
Test: platform/mac/editing/input/insert-delete-smp-symbol.html
* rendering/RenderText.cpp:
(WebCore::isMark): This matches what Core Foundation does for all characters that I tested.
(WebCore::RenderText::previousOffsetForBackwardDeletion): Changed to use isMark().
2011-03-10 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Error in StyleElement::process with large nodesets
https://bugs.webkit.org/show_bug.cgi?id=56150
Test: none due to excessive runtime and CRASH() vs. real crash.
* dom/StyleElement.cpp:
(WebCore::StyleElement::process): Handle large node sets better.
2011-03-10 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=47151
Percentage heights should skip anonymous containing blocks when computing the used value.
Added fast/block/basic/percentage-height-inside-anonymous-block.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
2011-03-10 Nat Duca <nduca@chromium.org>
Reviewed by James Robinson.
[chromium] Make updateAndDrawLayers argumentless.
https://bugs.webkit.org/show_bug.cgi?id=55985
Made the TilePainters and viewport parameters for
LayerRendererChromium member variables instead of arguments on
updateAndDrawLayers. In a future change, this will allows us to
draw the layer tree without the WebView's assistance.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::verticalScrollbarRect):
(WebCore::LayerRendererChromium::horizontalScrollbarRect):
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
(WebCore::LayerRendererChromium::updateRootLayerContents):
(WebCore::LayerRendererChromium::updateRootLayerScrollbars):
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::setViewport):
(WebCore::LayerRendererChromium::updateAndDrawLayers):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::setRootLayer):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::viewportSize):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
2011-01-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Implement spin buttons for GTK+ 2.x
https://bugs.webkit.org/show_bug.cgi?id=53098
Implement spin buttons for GTK+ 2.x. This allows proper render and functioning
for input type=number. The implementation is based on the one in gtkspinbutton.c
from the GTK+ sources.
* platform/gtk/RenderThemeGtk.h: Added new members and getters.
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::platformInit): Initialize spin button widget.
(WebCore::RenderThemeGtk::adjustRepaintRect): We need to draw outside the
spin button area to have proper rendering. There doesn't seem to be any other
clean way of having spin buttons that are the size of the text input frame.
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle): Added implementation.
(WebCore::RenderThemeGtk::paintInnerSpinButton): Ditto.
(WebCore::RenderThemeGtk::gtkSpinButton): Added.
2011-03-10 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
InsertUnorderedList over a non-editable region and multiple lines enters an infinite loop
https://bugs.webkit.org/show_bug.cgi?id=53409
Fixing broken handling of mixed-editability content for InsertListCommand. Previously, if the selection
spanned non-contenteditable regions, it would get stuck endlessly iterating the same region as the algorithm
didn't skip the editable boundary.
Test: editing/execCommand/insert-list-with-noneditable-content.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cleanupAfterDeletion): Changed signature to take the destination
position for the active editing command. Without this, there are cases when the destination happens
to be a placeholder, and we remove it.
(WebCore::CompositeEditCommand::moveParagraphs):
* editing/CompositeEditCommand.h:
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply): Added logic to the paragraph iteration loop to handle pockets of
non-editable content in an editable context. Previously, this could cause an infinite loop.
* editing/visible_units.cpp:
(WebCore::startOfParagraph): Added a mode of operation where we'll jump across non-editable
content in the same paragraph to reach the actual editable paragraph start.
(WebCore::endOfParagraph): Ditto.
(WebCore::startOfNextParagraph): Now uses the aforementioned non-editable content skipping mode of
endOfParagraph.
2011-03-10 Berend-Jan Wever <skylined@chromium.org>
Reviewed by Darin Adler.
Calling focus() on an area element not in a document should not cause a NULL ptr crash
https://bugs.webkit.org/show_bug.cgi?id=54877
Test: fast/dom/HTMLAreaElement/area-islink-focus-null-ptr-crash.html
* dom/Element.cpp:
(WebCore::Element::focus): Check element is in the document before allowing focus
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::imageElement): Check element has a parent before checking if its parent is a map
2011-03-10 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
[Chromium] Fix default single selection select's popup background on chromium/linux
https://bugs.webkit.org/show_bug.cgi?id=56023
Test: fast/html/select-dropdown-consistent-background-color.html
* css/themeChromiumLinux.css:
2011-03-10 Kris Jordan <krisjordan@gmail.com>
Reviewed by Alexey Proskuryakov.
Improve default Accept header to give preference to HTML over XML.
https://bugs.webkit.org/show_bug.cgi?id=27267
* loader/FrameLoader.cpp:Changed default accept header to match
FireFox' as per bug 27267.
2011-03-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] [Webkit2] There are no scrollbars visible in the MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=56125
No new tests. This functionality will be tested once we have TestRunner
implementation for WebKit2 with pixel dumping support.
* GNUmakefile.am: Add a new define with tracks whether or not we are using
our specialized GTK+ ScrollView.
* platform/ScrollView.cpp: Only use the GTK+-specific ScrollView if we are compiling
WebKit1.
(WebCore::ScrollView::wheelEvent):
* platform/gtk/ScrollViewGtk.cpp: Ditto.
2011-03-10 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Assertion fails by validating a form twice very quickly
https://bugs.webkit.org/show_bug.cgi?id=56069
If the interactive validation is invoked when a form control is in
needsLayout() state, an assertion in isFocusable() fails. To avoid it,
Add a call to updateLayoutIgnorePendingStylesheets() before isFocusable().
Test: fast/forms/interactive-validation-assertion-by-validate-twice.html
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
Calls updateLayoutIgnorePendingStylesheets().
2011-03-10 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin.
https://bugs.webkit.org/show_bug.cgi?id=47143
Static distance computation is wrong when an ancestor is also positioned. We need to go up the container()
chain (after initially starting with the parent()) when doing this computation, so that we properly skip
intermediate boxes between two positioned blocks.
Added fast/block/positioning/static-distance-with-positioned-ancestor.html.
* rendering/RenderBox.cpp:
(WebCore::computeInlineStaticDistance):
(WebCore::computeBlockStaticDistance):
2011-03-10 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Make tiled compositor data structure more efficient.
https://bugs.webkit.org/show_bug.cgi?id=54133
Previously, the compositor had a sparse 2D array of tiles for the
whole page, most of which were null. The tiles were implicitly
located based on their position in the array. This was inefficient
when the page grew (e.g. infinite scrolling) and caused some bugs
(e.g. width * height > MAX_INT). This change modifies tiles to have
explicit positions so they can be stored in a hash map.
Tests: LayoutTests/compositing/
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::reset):
(WebCore::LayerTilerChromium::createTile):
(WebCore::LayerTilerChromium::invalidateTiles):
(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::tileAt):
(WebCore::LayerTilerChromium::tileContentRect):
(WebCore::LayerTilerChromium::tileLayerRect):
(WebCore::LayerTilerChromium::invalidateRect):
(WebCore::LayerTilerChromium::invalidateEntireLayer):
(WebCore::LayerTilerChromium::update):
(WebCore::LayerTilerChromium::updateFromPixels):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::growLayerToContain):
* platform/graphics/chromium/LayerTilerChromium.h:
(WebCore::LayerTilerChromium::Tile::Tile):
(WebCore::LayerTilerChromium::Tile::i):
(WebCore::LayerTilerChromium::Tile::j):
(WebCore::LayerTilerChromium::Tile::moveTo):
(WebCore::LayerTilerChromium::TileMapKeyTraits::emptyValue):
(WebCore::LayerTilerChromium::TileMapKeyTraits::constructDeletedValue):
(WebCore::LayerTilerChromium::TileMapKeyTraits::isDeletedValue):
2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed build fix for r80752; Negated the boolean logic.
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::next):
(WebCore::VisiblePosition::previous):
2011-03-10 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
Make the same change to xheight on Windows for CG.
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit):
2011-03-10 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=47147
Fix for repaint issues when the root element is a table and needs to paint a background that
covers the entire canvas. Remove paintRootBoxDecorations and replace with paintRootBoxFillLayers,
so that it can be called only for fill layer painting. Make tables and normal boxes both
call this new method. Fix the dirty check at the start of RenderTable paint to not happen if
the table is the root of the document (this same check exists in RenderBlock painting already).
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxFillLayers):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintBoxDecorationsWithSize):
* rendering/RenderBox.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paint):
(WebCore::RenderTable::paintBoxDecorations):
2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80749.
http://trac.webkit.org/changeset/80749
https://bugs.webkit.org/show_bug.cgi?id=56143
"Caused at least 3 media tests to be flaky" (Requested by
tonyg-cr on #webkit).
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::canTakeNextToken):
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLParserScheduler.cpp:
* html/parser/HTMLParserScheduler.h:
(WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
* page/FrameView.h:
2011-03-10 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Regression: Content not drawn when scrolling horizontally in an RTL page
https://bugs.webkit.org/show_bug.cgi?id=55077
* platform/ScrollView.cpp:
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::calculateOverhangAreasForPainting):
Take the scroll origin into account when calculating overhang.
* platform/ScrollView.h:
* rendering/RenderLayer.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollOrigin):
Move identical scroll origin member from ScrollView and RenderLayer
to shared base ScrollableArea. This is also needed so that the animator
can access it.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::pinnedInDirection):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Account for a scroll origin when doing calculating scroll offsets.
2011-03-09 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Plumb through settings for accelerated drawing for canvas
https://bugs.webkit.org/show_bug.cgi?id=56039
No new tests. Doesn't affect behavior, just adding a switch to toggle canvas backends.
* WebCore.exp.in:
* html/HTMLCanvasElement.cpp:
* html/canvas/CanvasRenderingContext2D.cpp:
* page/Settings.cpp:
* page/Settings.h:
2011-03-10 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=47157
CSS2.1 test suite failures because the ex unit is broken with the Ahem font.
Remove the code that tries to also include the maxX of the glyph bounds for the
'x' glyph, since it just causes the x-height to be way too large in cases where the 'x' glyph extends
below the baseline.
Remove the Apple Symbol hack for ex units, since the person who added that was confused by another
issue, namely that CGFontGetXHeight wasn't being properly multiplied by the pointSize. That's why
the value was too small. Patched the code to just multiply by pointSize and took out the hack.
Fix causes many tests in the css2.1 directory to progress, so no new tests required. Many other
layout tests change because the xHeight for Lucida Grande gets smaller by a little bit, and radio
buttons use ex horizontal margins by default.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
VisiblePosition's next and previous should take an enum instead of a boolean
https://bugs.webkit.org/show_bug.cgi?id=56135
Changed the argument type of VisiblePosition::next and VisiblePosition::previous
from bool to EditingBoundaryCrossingRule. Also got rid of StayInEditableContent enum
in VisibleSelection and replaced it by EditingBoundaryCrossingRule because the enum
was only used in VisiblePosition::isAll and subsequently in SelectionController::isAll
to call VisiblePosition::next and VisiblePosition::previous.
* WebCore.exp.in:
* dom/Position.cpp:
(WebCore::Position::trailingWhitespacePosition):
* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
(WebCore::InsertListCommand::listifyParagraph):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::shouldMergeStart):
(WebCore::ReplaceSelectionCommand::shouldMergeEnd):
(WebCore::ReplaceSelectionCommand::doApply):
* editing/SelectionController.cpp:
(WebCore::SelectionController::modifyExtendingRight):
(WebCore::SelectionController::modifyExtendingForward):
(WebCore::SelectionController::modifyMovingForward):
(WebCore::SelectionController::modifyExtendingLeft):
(WebCore::SelectionController::modifyExtendingBackward):
(WebCore::SelectionController::modifyMovingBackward):
* editing/SelectionController.h:
(WebCore::SelectionController::isAll):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::next):
(WebCore::VisiblePosition::previous):
* editing/VisiblePosition.h:
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::isAll):
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
* editing/VisibleSelection.h:
* editing/htmlediting.cpp:
(WebCore::selectionForParagraphIteration):
* editing/visible_units.cpp:
(WebCore::startOfNextParagraph):
2011-03-10 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Gentilcore.
Remove CRASH() calls added to track down bug 53045
https://bugs.webkit.org/show_bug.cgi?id=56137
Remove CRASH() calls added by r76575 and re-label ones added by r80155
and r80269 as being associated with bug 56124 (which may still be
happening).
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
* css/CSSSelector.h:
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::deleteSelectors):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):
* loader/cache/CachedResource.h:
2011-03-10 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Let the parser yield for layout before running scripts
https://bugs.webkit.org/show_bug.cgi?id=54355
Prior to this patch, the parser would yield to perform a layout/paint before running a
script only if the script or a stylesheet blocking the script is not loaded yet. Since we
don't preload scan into the body while parsing the head, typically we'll block on a script
early in the body that causes us to yield to do the first paint within a reasonable time.
However, I'm planning to change the PreloadScanner to scan into the body from the head.
That significantly improves overall load time, but would hurt first paint time because
fewer scripts would be blocked during parsing and thus wouldn't yield.
This change causes us to yield before running scripts if we haven't painted yet (regardless
of whether or not the script is loaded). In addition to allowing the above mentioned
PreloadScanner change to be implemented without regressing first paint time, this also
improves first paint time by itself.
I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
signifcant change in page load time.
Within the pages tested, 33 had no statistically significant change in time to first paint,
12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point.
(WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused
means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does
the right thing whether we are just before a token or waiting for a script. Now that we may
yield before a token or before a script, this may be called while paused.
* html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
* page/FrameView.h:
(WebCore::FrameView::hasEverPainted): Added.
2011-03-10 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Some Gtk code uses defined(USE_FREETYPE) instead of just USE(FREETYPE)
https://bugs.webkit.org/show_bug.cgi?id=55996
Use the macre USE instead of defined fro WTF_USE_FREETYPE and
WTF_USE_PANGO.
* GNUmakefile.am:
* platform/graphics/cairo/OwnPtrCairo.cpp:
* platform/graphics/cairo/OwnPtrCairo.h:
* platform/graphics/cairo/RefPtrCairo.cpp:
* platform/graphics/cairo/RefPtrCairo.h:
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::setPangoAttributes):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
2011-03-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Rolled back in 80277 and 80280 with event handler layout test failures fixed.
https://bugs.webkit.org/show_bug.cgi?id=55653
The failures were caused by a last minute typo: assigning to currentEvent
instead of m_currentEvent.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.h:
* bindings/js/JSWorkerContextBase.cpp:
2011-03-10 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=56129, vertical text broken on Lion and Leopard.
Add Snow Leopard ifdefs for the scaling by point size and then the division by unitsPerEm to the
translationsTransform applied to the results from CTFontGetVerticalTranslationsForGlyphs, since
this is done already on Lion and Leopard.
* platform/graphics/mac/FontMac.mm:
(WebCore::showGlyphsWithAdvances):
2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80701.
http://trac.webkit.org/changeset/80701
https://bugs.webkit.org/show_bug.cgi?id=56126
fast/dom/Geolocation/window-close-crash.html fails on Snow
Leopard release builds (Requested by mihaip on #webkit).
* page/DOMWindow.cpp:
* page/DOMWindow.h:
* page/Frame.cpp:
(WebCore::Frame::pageDestroyed):
(WebCore::Frame::transferChildFrameToNewDocument):
* page/Geolocation.cpp:
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
* page/Geolocation.h:
* page/GeolocationController.cpp:
(WebCore::GeolocationController::~GeolocationController):
* page/Navigator.cpp:
* page/Navigator.h:
* platform/mock/GeolocationClientMock.cpp:
* platform/mock/GeolocationClientMock.h:
2011-03-10 Pratik Solanki <psolanki@apple.com>
Reviewed by Alexey Proskuryakov.
ASSERT_NOT_REACHED triggered in WebCore::mapHTTPPipeliningPriorityToResourceLoadPriority
https://bugs.webkit.org/show_bug.cgi?id=56075
Map priority value 3, which means no priority, to ResourceLoadPriorityUnresolved.
* platform/network/cf/ResourceRequestCFNet.h:
(WebCore::mapHTTPPipeliningPriorityToResourceLoadPriority):
(WebCore::mapResourceLoadPriorityToHTTPPipeliningPriority):
2011-03-10 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Substitute live-edit mode activation by double-click
https://bugs.webkit.org/show_bug.cgi?id=56084
Also fixed a regression: console was not opening/closing on ESC key press because tabIndex="0" attribute was preserved for a readOnly viewer.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype._startEditing):
(WebInspector.SourceFrame.prototype._registerShortcuts):
(WebInspector.SourceFrame.prototype._handleKeyDown):
(WebInspector.SourceFrame.prototype._handleSave):
(WebInspector.SourceFrame.prototype._handleRevertEditing):
(WebInspector.SourceFrame.prototype._doubleClick):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.prototype.get text):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.get readOnly):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.set readOnly):
(WebInspector.TextEditorMainPanel.prototype.get readOnly):
2011-03-10 Greg Simon <gregsimon@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Need new graphic icon for garbage collect button.
https://bugs.webkit.org/show_bug.cgi?id=55794
No new tests: gc tests are flaky due to non-determinisic
behavior of collection APIs (more notes in bug)
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectGarbage):
* bindings/js/ScriptProfiler.h:
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectGarbage):
* bindings/v8/ScriptProfiler.h:
* inspector/Inspector.idl:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::collectGarbage):
* inspector/InspectorProfilerAgent.h:
* inspector/front-end/Images/garbageCollectButtonGlyph.png: Added.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._garbageCollectButtonClicked):
* inspector/front-end/inspector.css:
(.garbage-collect-status-bar-item .glyph):
2011-03-10 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: better names for HAR export commands
https://bugs.webkit.org/show_bug.cgi?id=56097
Rename Export to HAR to Copy entry/network log as HAR
Expose Copy as HAR unconditionally, remove related settings entry.
* English.lproj/localizedStrings.js:
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._contextMenu):
* inspector/front-end/Settings.js:
2011-03-10 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636
Fix a typo in features.pri that turns on this feature on mobile
devices by default.
* features.pri:
2011-03-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Invalid expected parameter list in CSSAgent.setSelectorText() callback (CSSStyleModel.js)
https://bugs.webkit.org/show_bug.cgi?id=56092
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
2011-03-10 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rolling out r80478 and its follow ups for breaking
inspector and engadget.com.
https://bugs.webkit.org/show_bug.cgi?id=49401
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::performTask):
(WebCore::Document::postTask):
* dom/Document.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setDefersLoading):
* manual-tests/database-callback-deferred.html: Removed.
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Kenneth Rohde Christiansen.
Tiled backing store's delegated scroll request uses incorrect convention
https://bugs.webkit.org/show_bug.cgi?id=56011
Use a point instead of delta, when relaying the scroll request from
ScrollView::setScrollPosition.
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::delegatedScrollRequested):
* page/Chrome.cpp:
(WebCore::Chrome::delegatedScrollRequested):
* page/Chrome.h:
* page/ChromeClient.h:
* platform/HostWindow.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::setScrollPosition):
2011-03-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: brush up DOM agent API.
https://bugs.webkit.org/show_bug.cgi?id=56093
* inspector/Inspector.idl:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::childNodes):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::outerHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.hasAttributes):
(WebInspector.DOMNode.prototype.nodeType):
(WebInspector.DOMNode.prototype.nodeName):
(WebInspector.DOMNode.prototype.setNodeName):
(WebInspector.DOMNode.prototype.localName):
(WebInspector.DOMNode.prototype.nodeValue):
(WebInspector.DOMNode.prototype.setNodeValue):
(WebInspector.DOMNode.prototype.setAttribute):
(WebInspector.DOMNode.prototype.attributes):
(WebInspector.DOMNode.prototype.removeAttribute):
(WebInspector.DOMNode.prototype.childNodes.mycallback):
(WebInspector.DOMNode.prototype.childNodes):
(WebInspector.DOMNode.prototype.outerHTML):
(WebInspector.DOMNode.prototype.setOuterHTML):
(WebInspector.DOMNode.prototype.removeNode):
(WebInspector.DOMNode.prototype.copyNode):
(WebInspector.DOMNode.prototype.path):
(WebInspector.DOMNode.prototype._setAttributesPayload):
(WebInspector.DOMNode.prototype._addAttribute):
(WebInspector.DOMAgent.prototype._characterDataModified):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.decorateNodeLabel):
(WebInspector.ElementsPanel.prototype.handleCopyEvent):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.findTreeElement):
(WebInspector.ElementsTreeElement):
(WebInspector.ElementsTreeElement.prototype.updateChildren):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
(WebInspector.ElementsTreeElement.prototype._startEditingTarget):
(WebInspector.ElementsTreeElement.prototype._startEditing):
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._attributeHTML):
():
* inspector/front-end/EventListenersSidebarPane.js:
():
* inspector/front-end/MetricsSidebarPane.js:
* inspector/front-end/StylesSidebarPane.js:
* inspector/front-end/utilities.js:
2011-03-09 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [STYLES] Editing a property value adds a word for any property value that uses a paren
https://bugs.webkit.org/show_bug.cgi?id=56002
* inspector/front-end/StylesSidebarPane.js: Introduce an additional check.
2011-03-09 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: use DebuggerPresentation instead of DebuggerModel in source frame delegate.
https://bugs.webkit.org/show_bug.cgi?id=56034
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._sourceLocationToActualLocation):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
(WebInspector.SourceFrame.prototype._contextMenu):
(WebInspector.SourceFrame.prototype._mouseDown):
(WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
2011-03-09 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: elements dom tree - word wrap toggle
https://bugs.webkit.org/show_bug.cgi?id=44311
A "Word Wrap" option is now shown in a context menu for the entire DOM tree content area
and persisted into application settings.
* English.lproj/localizedStrings.js:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._contextMenuEventFired):
(WebInspector.ElementsPanel.prototype._contextMenuEventFired.toggleWordWrap):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
(WebInspector.ElementsTreeElement.prototype.onreveal):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/inspector.css:
(#elements-content.nowrap):
(#elements-content > ol):
2011-03-09 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: re-implement breakpoints sidebar pane based on debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=55823
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didLoadSnippet):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.removeBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._createBreakpointItemId):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.reset):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._revealHiddenBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
(WebInspector.DebuggerPresentationModel.prototype.reset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._breakpointAdded):
(WebInspector.ScriptsPanel.prototype._breakpointRemoved):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._clearInterface):
2011-03-10 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Highlighter refactoring
https://bugs.webkit.org/show_bug.cgi?id=56015
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter):
(WebInspector.TextEditorHighlighter.prototype.set mimeType):
(WebInspector.TextEditorHighlighter.prototype.highlight):
(WebInspector.TextEditorHighlighter.prototype.updateHighlight):
(WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
(WebInspector.TextEditorHighlighter.prototype._highlightLines):
(WebInspector.TextEditorHighlighter.prototype._selectHighlightState):
(WebInspector.TextEditorHighlighter.prototype._clearHighlightState):
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype._buildChunks):
(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
2011-03-05 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move breakpoint column adjustment to debugger model.
https://bugs.webkit.org/show_bug.cgi?id=55821
Test: inspector/debugger/debug-inlined-scripts.html
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
* inspector/front-end/SourceFrameContent.js:
(WebInspector.SourceFrameContent.prototype.sourceFrameLineNumberToActualLocation):
2011-01-21 John Knottenbelt <jknotten@chromium.org>
Reviewed by Dmitry Titov.
Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877
On Page destruction, any outstanding Geolocation permission
requests should be cancelled, because the Geolocation can only
access the client indirectly via m_frame->page().
Page destruction is signalled by a call to the
Frame::pageDestroyed() method. This explictly calls
DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.
Geolocation::reset() detaches from the GeolocationController,
cancels requests, watches and single shots, and sets the
permission state back to Unknown.
Frame::pageDestroyed() is also called by FrameLoader even though
the page is not destroyed. We should still cancel permission
requests, because the GeolocationClient will become inaccessible
to the Geolocation object after this call.
Frame::transferChildFrameToNewDocument also indirectly calls
Geolocation::reset when the frame is reparented between
pages. Ideally we would like the Geolocation's activities to
continue after reparenting, see bug
https://bugs.webkit.org/show_bug.cgi?id=55577
Since GeolocationController is owned by Page, and all Geolocation
objects will now unsubscribe from the GeolocationController on
pageDetached(), we no longer need to call stopUpdating() from the
GeolocationController's destructor. Instead we can simply assert
that there should be no no observers. See related bug
https://bugs.webkit.org/show_bug.cgi?id=52216 .
Introduced new method 'numberOfPendingPermissionRequests' on
GeolocationClientMock to count the number of outstanding pending
permission requests. This provides a reusable implementation for
client-based implementations of the LayoutTestController's
numberOfPendingGeolocationPermissionRequests method.
Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::resetGeolocation):
* page/DOMWindow.h:
* page/Frame.cpp:
(WebCore::Frame::pageDestroyed):
(WebCore::Frame::transferChildFrameToNewDocument):
* page/Geolocation.cpp:
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::page):
(WebCore::Geolocation::reset):
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
* page/Geolocation.h:
* page/GeolocationController.cpp:
(WebCore::GeolocationController::~GeolocationController):
* page/Navigator.cpp:
(WebCore::Navigator::resetGeolocation):
* page/Navigator.h:
* platform/mock/GeolocationClientMock.cpp:
(WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
* platform/mock/GeolocationClientMock.h:
2011-03-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
Able to move nodes across documents
https://bugs.webkit.org/show_bug.cgi?id=19524
Makes cross-document appendChild, insertBefore, Range.insertNode and Range.surroundContents work.
This matches Gecko and the new Dom Core spec. There are a number of Range methods where we don't
match Gecko or the spec that will need to be updated in a following patch.
Test: fast/dom/move-nodes-across-documents.html
* dom/Element.cpp:
(WebCore::Element::removeAttributeNode):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setNamedItem):
* dom/Node.cpp:
(WebCore::Node::setDocumentRecursively):
(WebCore::checkAcceptChild):
(WebCore::Node::checkReplaceChild):
* dom/Range.cpp:
(WebCore::Range::insertNode):
(WebCore::Range::surroundContents):
2011-03-09 Antti Koivisto <antti@apple.com>
Not reviewed.
Reverting crash catching code, the bug being hunted was fixed by
http://trac.webkit.org/changeset/80686
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::load):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::requestPreload):
* loader/cache/CachedResourceLoader.h:
2011-03-09 Peter Kasting <pkasting@google.com>
Unreviewed, build fix.
* StringsNotToBeLocalized.txt: Add function names I forgot.
* platform/win/SystemInfo.cpp: #if out some uncalled functions on WinCE,
since they don't compile anyway. Use ZeroMemory() instead of "= {0}"
since Qt is stupid and (sometimes?!) warns about it.
(WebCore::windowsVersion):
(WebCore::processorArchitecture):
2011-03-09 Peter Kasting <pkasting@google.com>
Reviewed by Ryosuke Niwa.
Add UA string tags for Windows 64.
https://bugs.webkit.org/show_bug.cgi?id=55226
* StringsNotToBeLocalized.txt:
* platform/win/SystemInfo.cpp:
(WebCore::osVersionForUAString):
(WebCore::isWOW64):
(WebCore::processorArchitecture):
(WebCore::architectureTokenForUAString):
(WebCore::windowsVersionForUAString):
2011-03-09 Peter Kasting <pkasting@google.com>
Unreviewed, attempted build fix.
* WebCore.pri: Try to update include path for Qt Windows build.
2011-03-09 Peter Kasting <pkasting@google.com>
Unreviewed, build fix.
* platform/win/SystemInfo.cpp:
(WebCore::windowsVersionForUAString): Fix const conversion warning on Qt.
2011-03-09 Peter Kasting <pkasting@google.com>
Reviewed by Mihai Parparita.
Unify Windows version checks.
https://bugs.webkit.org/show_bug.cgi?id=55979
* GNUmakefile.am: Fix spaces -> tabs.
* StringsNotToBeLocalized.txt:
* WebCore.pro: Add SystemInfo.* to Qt build.
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
(WebCore::ScrollbarThemeChromiumWin::getThemeState):
(WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
* platform/win/CursorWin.cpp:
(WebCore::createSharedCursor):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
* platform/win/SystemInfo.cpp: Add full-fledged version check and UA string helper function.
(WebCore::windowsVersion):
(WebCore::windowsVersionForUAString):
* platform/win/SystemInfo.h: Add full-fledged version check and UA string helper function.
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::getNonClientMetrics):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::getThemeData):
(WebCore::RenderThemeWin::paintMenuList):
(WebCore::RenderThemeWin::paintMenuListButton):
2011-03-09 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Gentilcore.
REGRESSION (r74807): memory corruption after CachedResourceLoader refactoring
https://bugs.webkit.org/show_bug.cgi?id=53045
Copy the URL out of the CachedResource that is being revalidated, so
that we can still use it (in m_validatedURLs) after removing the
resource from the memory cache, which may delete it.
No new tests, since I was not able to trigger this locally (in a layout
test or otherwise).
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::revalidateResource):
2011-03-09 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
VO reporting incorrect list count for http://www.macworld.com/news.html
https://bugs.webkit.org/show_bug.cgi?id=56064
<li> tags should not be ignored, because they provide valuable information
to screen readers.
Test: platform/mac/accessibility/list-items-ignored.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2011-03-09 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
<rdar://problem/8733254> Float disappears after incremental layout
Fixed the original bug and a copule more issues noticed while doing so.
Tests: fast/dynamic/dirty-float-in-clean-line.html
fast/dynamic/float-at-line-break.html
fast/dynamic/float-from-empty-line.html
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): If findNextLineBreak() returned an empty line,
update the line break info of the last line with the new line break position. This is tested
by float-from-empty-line.html.
(WebCore::RenderBlock::checkFloatsInCleanLine): Factored out code from determineStartPosition()
into this new function.
(WebCore::RenderBlock::determineStartPosition): Call checkFloatsInCleanLine().
(WebCore::RenderBlock::determineEndPosition): When iterating over lines, check clean lines with
floats, as they may yet become dirty because of the floats. This is tested by
dirty-float-in-clean-line.html.
(WebCore::RenderBlock::findNextLineBreak): If a float fits on the line, and the current line
break is at the float, advance it to after the float. Otherwise, if the line gets dirty and the
next one does not, the float will not make it into any line. This is tested by
float-at-line-break.html.
2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
selectionStart reports wrong caret position when the last characters are newlines
https://bugs.webkit.org/show_bug.cgi?id=56061
The bug was caused by SelectionController::setSelection's not calling
notifyRendererOfSelectionChange when old selection was equal to new selection.
Because InsertLineBreakCommand inserts a text node with a single LF before the caret,
this condition holds after the command is executed. However, the values of
selectionStart and selectionEnd still need to be updated in this case because
the offsets counted from the beginning of textarea have been increased by 1.
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection): Call notifyRendererOfSelectionChange
when m_selection = s.
* manual-tests/selection-start-after-inserting-line-break-in-textarea.html: Added.
2011-03-09 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
Bad cast in HTMLTreeBuilder::processStartTag
https://bugs.webkit.org/show_bug.cgi?id=55955
Test: fast/parser/self-closing-foreign-content.html
When the parser encounters an svg or mathml root element, it places the
insertion mode into InForeignContentMode. However, if the root element
is self-closing (e.g. <svg />) then the element is never placed on the
open elements stack. This leaves the parser in an inconsistent state
where it is in InForeignContentMode but no foreign content is in the
open element stack.
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody): If a self-closing
foreign element is inserted into the tree, do not set the insertion
mode to InForeignContentMode.
2011-03-09 Gavin Barraclough <barraclough@apple.com>
Qt build fix.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
2011-03-09 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
REGRESSION (r80320): Assertion failure when processing mis-nested foreign content.
https://bugs.webkit.org/show_bug.cgi?id=55982
Test: fast/parser/fragment-foreign-content-misnested.html
It is a parse error to encounter certain start tags while the parser's
insertion mode is InForeignContentMode (e.g. <br>). In these cases, we
are to pop open elements off the HTMLElementStack until a foreign
content scope marker is encountered. Before the change in r80320 to not
insert a fake HTML element during fragment parsing, said fake HTML
element counted as a foreign content scope marker.
With r80320, no fake HTML element is inserted and the stack is popped
until empty in cases where no other element claims to be a foreign
content scope marker. Fix this by treating the DocumentFragment as a
foreign content scope marker.
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isForeignContentScopeMarker): Take a
ContainerNode* instead of a Element*.
(WebCore::HTMLElementStack::popUntilForeignContentScopeMarker): Pass
topNode() to isForeignContentScopeMarker() instead of top().
2011-03-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
Bug 56041 - RexExp constructor should only accept flags "gim"
We also should be passing the flags around as a bitfield rather than a string,
and should not have redundant, incompatible code for converting the string to a bitfield!
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readTerminal):
- Need to parse flags string back to enum.
2011-03-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium]: Regression - Explicitly copy compositing properties from LayerChromium to CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=56021
Initializes the m_doubleSided flag of LayerChromiums to the default
value of true so the back sides of layers without
backface-visibility:hidden are rendered.
Test: compositing/backface-visibility.html
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
2011-03-09 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/9110316> REGRESSION: 'ex' unit broken for vertical text
Fall back to the verticalRightOrientation data when obtaining the x-height for vertically oriented
text. That way we use the same metrics as for horizontal.
This fixes regressions in fast/lists and fast/overflow vertical text tests.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):
2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document
https://bugs.webkit.org/show_bug.cgi?id=56004
The crash was caused by the false assumption that rootEditableElement() or documentElement()
always return non-null pointer. Fixed the bug by adding an early exit.
Test: editing/selection/extend-by-line-in-empty-document.html
* editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
2011-03-09 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: it should be possible to copy stack trace from call stack sidebar pane.
https://bugs.webkit.org/show_bug.cgi?id=56024
* English.lproj/localizedStrings.js:
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype._contextMenu):
2011-03-09 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Patch FontPlatformDataLinux to properly initialize and copy orientation/text-orientation in all
places. Make sure text-orientation is specified in the lookups/creation in FontCustomPlatformData
and FontCache.
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/chromium/FontPlatformDataLinux.h:
(WebCore::FontPlatformData::FontPlatformData):
2011-03-09 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JavaNPObject should not use JNI directly
https://bugs.webkit.org/show_bug.cgi?id=56009
We move the JNI code to access a Java object's fields into
a new JavaInstance::getField() method.
No new tests, refactoring only.
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::getField):
* bridge/jni/v8/JavaInstanceV8.h:
* bridge/jni/v8/JavaNPObjectV8.cpp:
(JSC::Bindings::JavaNPObjectGetProperty):
2011-03-09 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
NPAPI - jvalue conversion should not be in JavaInstance
https://bugs.webkit.org/show_bug.cgi?id=55967
No new tests, refactoring only.
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::invokeMethod):
* bridge/jni/v8/JavaInstanceV8.h:
* bridge/jni/v8/JavaNPObjectV8.cpp:
(JSC::Bindings::JavaNPObjectInvoke):
2011-03-09 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
Use the Cookie Storage from the Private Browsing Storage Session directly
https://bugs.webkit.org/show_bug.cgi?id=55986
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/network/mac/CookieStorageMac.mm:
(WebCore::setCookieStoragePrivateBrowsingEnabled):
Just copy the cookie storage from the private browsing storage session.
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::setCookieStoragePrivateBrowsingEnabled):
Ditto.
2011-03-09 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Fixed a crash in InspectorInstrumentation::didReceiveResponse() when loader is null (broken in r80639)
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
2011-03-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: pass explicit agent references to InspectorBackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=55820
* inspector/CodeGeneratorInspector.pm:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::dispatchMessageFromFrontend):
2011-03-09 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: resource errors are not reported before front-end is opened
https://bugs.webkit.org/show_bug.cgi?id=55939
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didReceiveResourceResponse):
(WebCore::InspectorInstrumentation::didFailLoading):
2011-03-08 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Add BackingStoreType parameter to IDBFactoryBackendInterface::open
https://bugs.webkit.org/show_bug.cgi?id=55948
Add a parameter that allows for selection of alternative backing store
implementations.
No new tests: no new functionality.
* storage/IDBFactory.cpp:
(WebCore::IDBFactory::open):
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBFactoryBackendInterface.h:
2011-03-08 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Factor out JNI method call to be used by both JSC and V8
https://bugs.webkit.org/show_bug.cgi?id=55966
No new tests, refactoring only.
* bridge/jni/JNIUtility.cpp:
(JSC::Bindings::callJNIMethod):
* bridge/jni/JNIUtility.h:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::invokeMethod):
2011-03-09 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Regression in handling DOMNodeInserted/DOMNodeRemoved events
https://bugs.webkit.org/show_bug.cgi?id=55818
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
2011-03-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Web Inspector: we don't need to transfer objectId and hasChildren for primitive values.
https://bugs.webkit.org/show_bug.cgi?id=55998
* inspector/InjectedScriptSource.js:
2011-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: watch expressions should show string values in quotes.
https://bugs.webkit.org/show_bug.cgi?id=55846
* inspector/InjectedScriptSource.js:
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.update):
* inspector/front-end/RemoteObject.js:
(WebInspector.LocalJSONObject.prototype.get description):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update):
* inspector/front-end/inspector.css:
(.console-formatted-string, .console-formatted-regexp):
2011-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: "length" getter is invoked upon console object formatting.
https://bugs.webkit.org/show_bug.cgi?id=55220
* inspector/InjectedScriptSource.js:
2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove groupName from objectId.
https://bugs.webkit.org/show_bug.cgi?id=55825
* inspector/InjectedScriptSource.js:
2011-03-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
https://bugs.webkit.org/show_bug.cgi?id=55077.
Inside ScrollView::calculateOverhangAreasForPainting(), when scroll position
is negative, should include the position value into overhang rectangle's
starting position.
Tests: fast/dom/scroll-reveal-left-overflow.html
fast/dom/scroll-reveal-top-overflow.html
* platform/ScrollView.cpp:
(WebCore::ScrollView::calculateOverhangAreasForPainting):
2011-03-08 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Add templatized CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
https://bugs.webkit.org/show_bug.cgi?id=55351
By using some template magic CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
can be called on an array A without the caller explicitly specifying the size of A.
No functionality was changed. So no new tests.
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::getPropertyValue): Modified to call templatized variants of
CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}().
(WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Renamed second argument from "number" to "size"
to better reflect its purpose - to be the size of the passed array.
(WebCore::CSSMutableStyleDeclaration::getShorthandValue): Ditto.
(WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
(WebCore::CSSMutableStyleDeclaration::cssText): Modified to call templatized variant of CSSMutableStyleDeclaration::getShorthandValue().
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::getShorthandValue): Added templatized function that can determine
the size of a passed array. Changed type of second argument to size_t since it represents the size of
an array.
(WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
(WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Ditto.
2011-03-08 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
REGRESSION: Copied content loses formatting on paste to external apps.
https://bugs.webkit.org/show_bug.cgi?id=47615
<rdar://problem/9001214>
This is a resubmission of a patch that was landed a while ago then rolled
back because of a build failure on SnowLeopard and Leopard on the 32-bit builds.
This patch adds a way for WebKit2 to create NSAttributedStrings from
a DOM range without using the AppKit api initWithDOMRange that internally
needs to access the WebView. The NSAttributedString is needed to create
RTF formats in the pasteboard.
This is to be considered a first step, since in the future we want to have
an implementation based on the TextIterator.
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/HTMLConverter.h: Added.
* platform/mac/HTMLConverter.mm: Added.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection):
2011-03-08 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Explicitly copy compositing properties from LayerChromium to CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=55900
This adds an explicit step to synchronize properties from
LayerChromiums to their corresponding CCLayerImpls.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBounds):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::bounds):
(WebCore::LayerChromium::doubleSided):
(WebCore::LayerChromium::setDoubleSided):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::updateFromLayer):
(WebCore::CCLayerImpl::descendantsDrawsContent):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::anchorPoint):
(WebCore::CCLayerImpl::anchorPointZ):
(WebCore::CCLayerImpl::masksToBounds):
(WebCore::CCLayerImpl::opacity):
(WebCore::CCLayerImpl::position):
(WebCore::CCLayerImpl::preserves3D):
(WebCore::CCLayerImpl::sublayerTransform):
(WebCore::CCLayerImpl::transform):
2011-03-08 James Robinson <jamesr@chromium.org>
Chromium compile fix.
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformInit):
2011-03-08 Peter Kasting <pkasting@google.com>
Reviewed by James Robinson.
Unify Windows version checks, part 1.
https://bugs.webkit.org/show_bug.cgi?id=55979
Make everyone (I hope) pull in SystemInfo.cpp. Eliminate the
now-unnecessary WindowsVersion.cpp from Chromium.
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
(WebCore::ScrollbarThemeChromiumWin::getThemeState):
(WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
* platform/chromium/WindowsVersion.cpp: Removed.
* platform/chromium/WindowsVersion.h: Removed.
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::getNonClientMetrics):
2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
Chromium Linux build fix attempt after r80582.
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
(WebCore::GlyphPage::fill):
2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
Mac build fix attempt for r80582.
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::disableLigatures):
2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Remove calls to deprecatedEditingOffset in SelectionController and VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=54937
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection): Calls anchorNode() instead of deprecatedNode() to obtain
the document. Also restrained the lifetime of document variable.
(WebCore::removingNodeRemovesPosition): Compare the node with anchorNode() instead of deprecatedNode()
to determine whether or not position becomes null after removing a node.
(WebCore::SelectionController::directionOfEnclosingBlock): The enclosing block is always a container
so call containerNode() instead of deprecatedNode().
(WebCore::SelectionController::debugRenderer): Call containerNode() and computeOffsetInContainer()
instead of deprecatedNode() and deprecatedEditingOffset() respectively.
(WebCore::SelectionController::isInPasswordField): Look for the shadow root from containerNode()
instead of deprecatedNode to determine whether or not selection inside a password field. Also assert
that the specified position is not before or after the shadow root as it violates our assumption.
* editing/VisibleSelection.cpp:
(WebCore::makeSearchRange): Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
and deprecatedEditingOffset() respectively because start is always parent anchored and therefore
guaranteed to be an offset inside an anchor node.
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Call containerNode()
instead of deprecatedNode() to look for the lowest editable ancestor because position before or after
an editable element isn't editable.
* page/DOMSelection.cpp: Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
and deprecatedEditingOffset() respectively in the following functions because they are exposed to
DOM, which doesn't have before/after concept.
(WebCore::DOMSelection::anchorNode):
(WebCore::DOMSelection::anchorOffset):
(WebCore::DOMSelection::focusNode):
(WebCore::DOMSelection::focusOffset):
(WebCore::DOMSelection::baseNode):
(WebCore::DOMSelection::baseOffset):
(WebCore::DOMSelection::extentNode):
(WebCore::DOMSelection::extentOffset):
2011-03-08 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Correct uninitialized variable in PolicyCallback found while
running WebKit in BoundsChecker.
https://bugs.webkit.org/show_bug.cgi?id=45199.
* loader/PolicyCallback.cpp:
(WebCore::PolicyCallback::PolicyCallback): Initialize
m_argument.
2011-03-08 Brent Fulgham <bfulgham@webkit.org>
More build bustage fix.
* platform/graphics/win/cairo/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation): Duplicate accessor
in WinCairo-local header. This is such a mess!
2011-03-08 David Hyatt <hyatt@apple.com>
Fix build bustage. Hide orientation setting behind a setter and stub it out in all
FontPlatformData classes. (This class really needs to move to a common header with ifdefs.)
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::verticalRightOrientationFontData):
* platform/graphics/cg/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/chromium/FontPlatformDataChromiumWin.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/chromium/FontPlatformDataLinux.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/cocoa/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/freetype/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/wince/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
* platform/graphics/wx/FontPlatformData.h:
(WebCore::FontPlatformData::setOrientation):
2011-03-08 Joe Wild <joseph.wild@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] Missing SVG variables
https://bugs.webkit.org/show_bug.cgi?id=32941
Basically, this patch just modifies features.pri to the Qt build to
pass on the ENABLE_SVG_* flags to the IDL binding generator.
Also I had remove global-construtors.html from the skip list and
updated the associated expected results files.
* features.pri:
* page/DOMWindow.idl:
2011-03-08 Alok priyadarshi <alokp@chromium.org>
Reviewed by Dimitri Glazkov.
Plugins needs a way to trigger style recalc
https://bugs.webkit.org/show_bug.cgi?id=55242
No test needed. A simple get function is added.
* platform/graphics/chromium/PluginLayerChromium.h:
(WebCore::PluginLayerChromium::getTextureId):
2011-03-08 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=48540, support the text-orientation CSS property.
This patch adds support for two values of the text-orientation property (the ones that actually matter): vertical-right and upright.
The TextOrientation is part of the FontDescription and used to look up fonts (similar to FontOrientation).
Orientation of non-CJK characters is done using fallback font data of the appropriate orientation type, e.g., verticalRightOrientation and
uprightOrientation fallback font data. Vertical right is just implemented as a normal horizontal font. Upright is implemented as a
vertically oriented font that rotates all glyphs.
The main complication implementing text-orientation is that fonts have "baked-in" vertical glyphs for letters that are hardcoded to
a vertical right facing. This means that you can use those special vertical glyphs for vertical-right orientation without having to
fall back, but then for upright orientation you have to ignore them and still fall back. As you can see from the test case, this doesn't
work very well, but hopefully it won't be all that common. Limitations of CoreText prevent this case from rendering properly in either the
simple or complex code paths, although the simple code path at least gets close.
Added fast/blockflow/text-orientation-basic.html
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextOrientation):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::platformDataFromCustomData):
* loader/cache/CachedFont.h:
* platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::computeHash):
(WebCore::FontCache::getCachedFontPlatformData):
* platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::textOrientation):
(WebCore::FontDescription::setTextOrientation):
(WebCore::FontDescription::operator==):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataForCharacter):
(WebCore::offsetToMiddleOfGlyph):
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::hasVerticalGlyphs):
(WebCore::SimpleFontData::isTextOrientationFallback):
* platform/graphics/cairo/FontCustomPlatformData.h:
* platform/graphics/cocoa/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::textOrientation):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
* platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/haiku/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/haiku/FontCustomPlatformData.h:
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/mac/FontCustomPlatformData.h:
* platform/graphics/mac/FontMac.mm:
(WebCore::showGlyphsWithAdvances):
(WebCore::Font::drawGlyphs):
* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::shouldUseCoreText):
(WebCore::GlyphPage::fill):
* platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::SimpleFontData::getCFStringAttributes):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/pango/FontCustomPlatformDataPango.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/qt/FontCustomPlatformData.h:
* platform/graphics/qt/FontCustomPlatformDataQt.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/skia/FontCustomPlatformData.h:
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/win/FontCustomPlatformData.h:
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/win/FontCustomPlatformDataCairo.h:
* platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/wince/FontCustomPlatformData.h:
* platform/text/TextOrientation.h: Added.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::requiresIdeographicBaseline):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::initialTextOrientation):
2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
addInlineStyleIfNeeded should take EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55950
Deployed EditingStyle in addInlineStyleIfNeeded, StyleChange::StyleChange, and StyleChange::init.
Also extracted EditingStyle::styleIsPresentInComputedStyleOfNode from removeStyleFromRunBeforeApplyingStyle.
* editing/ApplyStyleCommand.cpp:
(WebCore::StyleChange::StyleChange): Takes EditingStyle instead of CSSStyleDeclaration.
(WebCore::StyleChange::init): Ditto.
(WebCore::ApplyStyleCommand::applyBlockStyle): Instantiates StyleChange.
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Calls addInlineStyleIfNeeded.
(WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls styleIsPresentInComputedStyleOfNode.
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls EditingStyle::mergeInlineStyleOfElement
instead of manually merging styles.
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Calls addInlineStyleIfNeeded.
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Takes EditingStyle instead of CSSMutableStyleDeclaration.
* editing/ApplyStyleCommand.h:
* editing/CompositeEditCommand.h:
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode): Extracted from removeStyleFromRunBeforeApplyingStyle.
* editing/EditingStyle.h:
2011-03-08 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
Crash on big blur radius with canvas
https://bugs.webkit.org/show_bug.cgi?id=55951
Move the clamping code out of an if branch, so that it happens in the
canvas case as well.
Test: fast/canvas/shadow-huge-blur.html
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
2011-03-08 Chris Fleizach <cfleizach@apple.com>
Reviewed by Sam Weinig.
WK2: Cannot set focus on an element when focus is outside of WKView
https://bugs.webkit.org/show_bug.cgi?id=55281
In WK2, focus cannot be set from the WebProcess side because there's no platformWidget().
Instead, the focus/unfocus messages need to be sent to the UIProcess side.
* platform/mac/WidgetMac.mm:
(WebCore::Widget::setFocus):
2011-03-08 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Overflow: scroll areas should not paint white in scroll corner if the
scrollbars are overlay.
<rdar://problem/9082871>
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintScrollCorner):
Don't paint the scroll corner white if we have overlay scrollbars.
2011-03-08 Chris Marrin <cmarrin@apple.com>
Reviewed by Darin Adler.
The first time animations are committed they have a bad start time
https://bugs.webkit.org/show_bug.cgi?id=55947
Do a check for a returned lastCommitTime of <=0 and replace it
with the mediaTime.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
2011-03-08 James Kozianski <koz@chromium.org>
Reviewed by David Levin.
Expose isValidProtocol() in KURL.h.
https://bugs.webkit.org/show_bug.cgi?id=54594
This is needed to validate protocols used in calls to
navigator.registerProtocolHandler().
* platform/KURL.cpp:
* platform/KURL.h:
* platform/KURLGoogle.cpp:
(WebCore::isValidProtocol):
2011-03-08 Adam Roben <aroben@apple.com>
Set svn:mime-type to text/css for all Inspector CSS files
This will cause them to be served with the correct MIME type from svn.webkit.org's web
interface.
Rubber-stamped by Tim Hatcher.
* inspector/front-end/audits.css: Added property svn:mime-type.
* inspector/front-end/goToLineDialog.css: Added property svn:mime-type.
* inspector/front-end/heapProfiler.css: Added property svn:mime-type.
* inspector/front-end/helpScreen.css: Added property svn:mime-type.
* inspector/front-end/inspector.css: Added property svn:mime-type.
* inspector/front-end/inspectorSyntaxHighlight.css: Added property svn:mime-type.
* inspector/front-end/networkPanel.css: Added property svn:mime-type.
* inspector/front-end/popover.css: Added property svn:mime-type.
* inspector/front-end/textViewer.css: Added property svn:mime-type.
2011-03-08 Andrei Popescu <andreip@google.com>
Reviewed by Steve Block.
IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=55938
The IndexedDatabase specification changed and IDBIndex objects are no
longer created asynchronously. We therefore no longer need this method.
No new tests, just cleanup.
* storage/IDBCallbacks.h:
* storage/IDBRequest.cpp:
* storage/IDBRequest.h:
2011-03-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80551.
http://trac.webkit.org/changeset/80551
https://bugs.webkit.org/show_bug.cgi?id=55933
It broke 285 tests on Qt bot (Requested by Ossy on #webkit).
* WebCore.pro:
* platform/SharedBuffer.cpp:
* platform/SharedBuffer.h:
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::supportsBufferedData):
(WebCore::ResourceHandle::bufferedData):
* platform/qt/QtByteBlock.cpp: Removed.
* platform/qt/QtByteBlock.h: Removed.
* platform/qt/SharedBufferQt.cpp:
2011-03-08 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
RenderObject: Pass complex type arguments as const-references.
* WebCore.exp.in:
* rendering/RenderObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawBoxSideFromPath):
(WebCore::RenderObject::drawArcForBoxSide):
(WebCore::RenderObject::localToAbsolute):
(WebCore::RenderObject::absoluteToLocal):
2011-03-08 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
Path: Make measurement functions const
https://bugs.webkit.org/show_bug.cgi?id=55914
* platform/graphics/Path.cpp:
(WebCore::Path::length):
(WebCore::Path::pointAtLength):
(WebCore::Path::normalAngleAtLength):
* platform/graphics/Path.h:
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::strokeBoundingRect):
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::strokeBoundingRect):
* platform/graphics/openvg/PathOpenVG.cpp:
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::length):
(WebCore::Path::pointAtLength):
(WebCore::Path::normalAngleAtLength):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::length):
(WebCore::Path::pointAtLength):
(WebCore::Path::normalAngleAtLength):
* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::strokeBoundingRect):
* platform/graphics/wince/PathWinCE.cpp:
(WebCore::Path::strokeBoundingRect):
* platform/graphics/wx/PathWx.cpp:
(WebCore::Path::strokeBoundingRect):
2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Do not set juntion sides on scrollbar stepper buttons
https://bugs.webkit.org/show_bug.cgi?id=55868
Fixes rendering of steppers for themes using rounded stepper
buttons on scrollbars like Adwaita.
* platform/gtk/ScrollbarThemeGtk3.cpp:
(WebCore::ScrollbarThemeGtk::paintButton):
2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Use doubles instead of integers for coordinates when rendering arrows
https://bugs.webkit.org/show_bug.cgi?id=55866
To prevent off-by-one rounding errors.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::paintMenuList):
* platform/gtk/ScrollbarThemeGtk3.cpp:
(WebCore::ScrollbarThemeGtk::paintButton):
2011-03-08 Markus Goetz <guruz@guruz.de>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use the QNetworkAccessManager zerocopy feature
https://bugs.webkit.org/show_bug.cgi?id=50082
The feature will be introduced in Qt 4.8.
This patch is backwards compatible with Qt 4.7.
* WebCore.pro:
* platform/SharedBuffer.cpp:
* platform/SharedBuffer.h:
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::bufferedData):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::downloadProgress):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::supportsBufferedData):
(WebCore::ResourceHandle::bufferedData):
* platform/qt/SharedBufferQt.cpp:
(WebCore::SharedBuffer::wrapQtByteBlock):
(WebCore::SharedBuffer::hasPlatformData):
(WebCore::SharedBuffer::platformData):
(WebCore::SharedBuffer::platformDataSize):
(WebCore::SharedBuffer::maybeTransferPlatformData):
(WebCore::SharedBuffer::clearPlatformData):
2011-03-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix compilation warnings after r80429
https://bugs.webkit.org/show_bug.cgi?id=55864
* platform/gtk/WidgetGtk.cpp:
2011-03-08 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK build fix after r80536
* GNUmakefile.am:
2011-03-08 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Martin Robinson.
[Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
https://bugs.webkit.org/show_bug.cgi?id=55878
Multiply the quality parameter by 100 to put it in the range [0, 100] as needed
when saving GdkPixbuf to a buffer.
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Unreviewed.
Final build fix for r80536.
* DerivedSources.make:
2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
[EFL] Adjust functions of WebCore's efl port to WebKit coding style
https://bugs.webkit.org/show_bug.cgi?id=55924
Adjust webkit style to PlatformKeyboardEventEfl, PlatformMouseEventEfl and WidgetEfl files.
* platform/efl/PlatformKeyboardEventEfl.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
* platform/efl/PlatformMouseEventEfl.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
* platform/efl/WidgetEfl.cpp:
(WebCore::Widget::frameRectsChanged):
(WebCore::Widget::setEvasObject):
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Unreviewed.
More build fixes for r80536.
* CMakeLists.txt:
* platform/chromium/ClipboardChromium.cpp:
* platform/chromium/ClipboardChromium.h:
2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
https://bugs.webkit.org/show_bug.cgi?id=55917
Adjust webkit style to ScrollbarEfl files.
* platform/efl/ScrollbarEfl.cpp:
(scrollbarEflEdjeMessage):
(ScrollbarEfl::setParent):
(ScrollbarEfl::updateThumbPositionAndProportion):
(ScrollbarEfl::frameRectsChanged):
(ScrollbarEfl::paint):
* platform/efl/ScrollbarEfl.h:
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Unreviewed.
Build fix for Chromium after r80536.
* platform/chromium/DataTransferItemChromium.cpp:
* platform/chromium/DataTransferItemsChromium.cpp:
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Unreviewed.
More build fixes for r80536.
* CMakeLists.txt:
* platform/chromium/ClipboardChromium.cpp:
* platform/chromium/ClipboardChromium.h:
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115
This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
basic functionality on the Chromium port. With the exception of DataTransferItem::getAsFile,
all functionality on the DataTransferItems collection has been implemented.
This change does not actually hook up DataTransferItems to reflect the actual contents of a
drop/paste operation or to allow mutation of data in a copy/drag start yet. That will be
enabled via several followup patches.
Test: editing/pasteboard/data-transfer-items.html
* Android.mk:
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
* bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
* dom/Clipboard.h:
(WebCore::Clipboard::policy):
* dom/Clipboard.idl:
* dom/DataTransferItem.cpp: Added.
* dom/DataTransferItem.h: Added.
(WebCore::DataTransferItem::~DataTransferItem):
* dom/DataTransferItem.idl: Added.
* dom/DataTransferItems.h: Added.
(WebCore::DataTransferItems::~DataTransferItems):
* dom/DataTransferItems.idl: Added.
* dom/StringCallback.cpp: Added.
(WebCore::StringCallback::scheduleCallback):
* dom/StringCallback.h: Added.
(WebCore::StringCallback::~StringCallback):
* dom/StringCallback.idl: Added.
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::items):
* platform/chromium/ClipboardChromium.h:
* platform/chromium/DataTransferItemChromium.cpp: Added.
(WebCore::DataTransferItemChromium::create):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::kind):
(WebCore::DataTransferItemChromium::type):
(WebCore::DataTransferItemChromium::getAsString):
* platform/chromium/DataTransferItemChromium.h: Added.
* platform/chromium/DataTransferItemsChromium.cpp: Added.
(WebCore::DataTransferItemsChromium::create):
(WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
(WebCore::DataTransferItemsChromium::length):
(WebCore::DataTransferItemsChromium::item):
(WebCore::DataTransferItemsChromium::deleteItem):
(WebCore::DataTransferItemsChromium::clear):
(WebCore::DataTransferItemsChromium::add):
* platform/chromium/DataTransferItemsChromium.h: Added.
2011-03-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902
Deployed EditingStyle in selectionHasStyle and selectionStartHasStyle.
This allowed us to move triStateOfStyle from Editor.cpp to EditingStyle.cpp.
Also changed the argument lists of selectionHasStyle and selectionStartHasStyle
to take a property id and a value instead of a CSSMutableStyleDeclaration to cleanup
call sites of these two functions.
* WebCore.exp.in: Updated the signature of selectionHasStyle. No longer exports
selectionStartHasStyle because it's not called anywhere outside of WebCore.
* WebCore.order: Ditto.
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::EditingStyle): Added a new constructor that takes a property id
and a property value.
(WebCore::EditingStyle::triStateOfStyle): Moved from Editor.cpp.
* editing/EditingStyle.h:
(WebCore::EditingStyle::create): Added.
* editing/Editor.cpp:
(WebCore::Editor::selectionStartHasStyle): Takes a property id and a value instead of
a CSSStyleDeclaration.
(WebCore::Editor::selectionHasStyle): Ditto.
* editing/Editor.h: Updated the signatures of selectionStartHasStyle and selectionHasStyle.
* editing/EditorCommand.cpp:
(WebCore::executeToggleStyle): Calls selectionStartHasStyle and selectionHasStyle.
(WebCore::stateStyle): Ditto.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
2011-03-07 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
https://bugs.webkit.org/show_bug.cgi?id=55898
<rdar://problem/9095839> REGRESSION: Mail hangs with a certain large mail message when
linkifying e-mail addresses in in -[DOMCharacterData setData:]
Changes render tree of fast/text/large-text-composed-char.html, but not image results.
* dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData):
Changed parserAppendData() to accept a maximum length, and moved code from Text::createWithLengthLimit().
* dom/CharacterData.h: Moved a constant for maximum length from Text.h.
* dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
* dom/Text.h:
This function was unused in ToT. Moved code around to share with CharacterData.
* html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode):
Chnaged to split large text nodes while parsing again.
2011-03-07 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Adam Barth.
Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour
https://bugs.webkit.org/show_bug.cgi?id=54522
Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required.
No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.
* platform/image-encoders/JPEGImageEncoder.cpp:
(WebCore::jpegEmptyOutputBuffer):
2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>
Reviewed by Eric Seidel.
Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHKernElement
https://bugs.webkit.org/show_bug.cgi?id=55896
Test: svg/dom/vkern-element-crash.html
* svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::insertedIntoDocument):
* svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::insertedIntoDocument):
2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80514.
http://trac.webkit.org/changeset/80514
https://bugs.webkit.org/show_bug.cgi?id=55915
Caused assertion failures (Requested by ukai on #webkit).
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::paintSkBitmap):
2011-03-07 Cosmin Truta <ctruta@chromium.org>
Reviewed by Adam Barth.
SVG <image> referenced by <use> is displayed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=55750
The result of sourceURI must use the URL of the enclosing document as base.
Otherwise, the base may sometimes be empty, and, as a consequence,
the intermediate KURL object may be invalid.
Test: svg/custom/use-image-in-g.svg
* svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::sourceURI):
2011-03-07 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
Shadow is not shown when using strokeRect with a gradient strokeStyle
https://bugs.webkit.org/show_bug.cgi?id=52509
This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
We need to draw the gradient clipped to the stroke on a CGLayer first,
and then draw the layer on the GraphicsContext.
Tests: fast/canvas/canvas-strokeRect-gradient-shadow.html
svg/css/rect-gradient-stroke-shadow.svg
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::strokeRect):
2011-03-07 Justin Novosad <junov@chromium.org>
Reviewed by Kenneth Russell.
Fix for blurs behind bitmap images in Chromium, and boosting
shadow blur quality
Bug URLs:
https://bugs.webkit.org/show_bug.cgi?id=55410
https://bugs.webkit.org/show_bug.cgi?id=55506
No new tests. Covered by existing layout tests.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow): Turn on high quality shadows and fix shadow color
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::paintSkBitmap): Propagate the draw looper from context to painter
2011-03-07 Andreas Kling <kling@webkit.org>
Unreviewed Mac build fix after r80508.
* WebCore.exp.in:
2011-03-07 Enrica Casucci <enrica@apple.com>
Unreviewed build fix.
Rolling back http://trac.webkit.org/changeset/80497 due to the
32-bit build failures.
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/HTMLConverter.h: Removed.
* platform/mac/HTMLConverter.mm: Removed.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection):
2011-03-07 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
FrameView::setBaseBackgroundColor: Pass Color argument as const-reference.
* page/FrameView.cpp:
(WebCore::FrameView::setBaseBackgroundColor):
* page/FrameView.h:
2011-03-07 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
https://bugs.webkit.org/show_bug.cgi?id=55894
The m_frame can disappear out from under us, and there's no point in
checking whether the load is complete in a non-existant frame.
Test: fast/parser/document-write-into-initial-document.html
* dom/Document.cpp:
(WebCore::Document::explicitClose):
2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80500.
http://trac.webkit.org/changeset/80500
https://bugs.webkit.org/show_bug.cgi?id=55908
Caused mysterious GYP error (Requested by abarth on #webkit).
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
2011-03-07 Adam Barth <abarth@webkit.org>
Fix Chromium Mac build. This header should only be included when the
feature is enabled.
* platform/cf/RunLoopTimerCF.cpp:
2011-03-07 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add WML files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55905
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
2011-03-07 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Add missing include to #define Skia parameter
https://bugs.webkit.org/show_bug.cgi?id=55885
* platform/graphics/chromium/ShaderChromium.h:
2011-03-07 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
https://bugs.webkit.org/show_bug.cgi?id=55706
* WebCore.exp.in:
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::rootObjectForFrame):
* accessibility/AXObjectCache.h:
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::isAttachment):
(WebCore::AccessibilityScrollView::widgetForAttachmentView):
* accessibility/AccessibilityScrollView.h:
(WebCore::AccessibilityScrollView::firstChild):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
2011-03-07 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
REGRESSION: Copied content loses formatting on paste to external apps.
https://bugs.webkit.org/show_bug.cgi?id=47615
<rdar://problem/9001214>
This is a resubmission of a patch that was landed a while ago then rolled
back because of a build failure on SnowLeopard and Leopard.
This patch adds a way for WebKit2 to create NSAttributedStrings from
a DOM range without using the AppKit api initWithDOMRange that internally
needs to access the WebView. The NSAttributedString is needed to create
RTF formats in the pasteboard.
This is to be considered a first step, since in the future we want to have
an implementation based on the TextIterator.
* WebCore.xcodeproj/project.pbxproj: Added new file.
* platform/mac/HTMLConverter.h: Added.
* platform/mac/HTMLConverter.mm: Added.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
class for WebKit2 to create the NSAttributedString from the DOM range.
2011-03-07 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add some missing platform files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55897
There are a bunch more, but this is a start.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
2011-03-07 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=55879
No new tests, refactoring only.
* Android.v8bindings.mk:
* WebCore.gypi:
* bridge/jni/v8/JavaClassV8.cpp:
* bridge/jni/v8/JavaClassV8.h:
* bridge/jni/v8/JavaFieldV8.cpp: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.cpp.
(JavaField::JavaField):
* bridge/jni/v8/JavaFieldV8.h: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
(JSC::Bindings::JavaField::name):
(JSC::Bindings::JavaField::type):
(JSC::Bindings::JavaField::getJNIType):
* bridge/jni/v8/JavaInstanceV8.cpp:
* bridge/jni/v8/JavaNPObjectV8.cpp:
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792
This is a preliminary patch to support event.dataTransfer.items. This
adds plumbing to support retrieving the types in a paste event. It also
moves the check for files in a drag/paste up to ClipboardChromium, since
internal code needs to be able to differentiate between actual files in
a drag and someone that simply decided to use "Files" as a custom type
string.
Test: editing/pasteboard/onpaste-text-html-types.html
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::containsFilenames):
* platform/chromium/ChromiumDataObject.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
* platform/chromium/ClipboardMimeTypes.cpp:
* platform/chromium/ClipboardMimeTypes.h:
2011-03-07 Takayoshi Kochi <kochi@chromium.org>
Reviewed by Tony Chang.
[chromium] Use preferred locale information when choosing fallback
font using fontconfig on Linux platform.
http://bugs.webkit.org/show_bug.cgi?id=55453
No new tests, as it depends on ICU and locale setting, so it will be
covered by Chromium side.
* platform/chromium/PlatformBridge.h:
* platform/graphics/chromium/FontCacheLinux.cpp:
2011-03-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add gobject, cpp, and objc bindings to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55892
These are also excluded from the Chromium build but needed for various
other ports.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>
Reviewed by Dimitri Glazkov.
Node::checkAddChild and Node::checkReplaceChild shouldn't change the owner document of a node
https://bugs.webkit.org/show_bug.cgi?id=55803
Test: fast/dom/dom-method-document-change.html
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
* dom/Node.cpp:
(WebCore::Node::checkReplaceChild):
(WebCore::Node::checkAddChild):
* dom/Node.h:
2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80484.
http://trac.webkit.org/changeset/80484
https://bugs.webkit.org/show_bug.cgi?id=55891
requires Chromium DEPS roll (Requested by dcheng on #webkit).
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
* platform/chromium/ChromiumDataObject.h:
(WebCore::ChromiumDataObject::containsFilenames):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
* platform/chromium/ClipboardMimeTypes.cpp:
* platform/chromium/ClipboardMimeTypes.h:
2011-03-07 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add missing bindings/js files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55888
These files are excluded from the Chromium build but needed for the Mac
build.
* WebCore.gypi:
2011-03-07 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792
This is a preliminary patch to support event.dataTransfer.items. This
adds plumbing to support retrieving the types in a paste event. It also
moves the check for files in a drag/paste up to ClipboardChromium, since
internal code needs to be able to differentiate between actual files in
a drag and someone that simply decided to use "Files" as a custom type
string.
Test: editing/pasteboard/onpaste-text-html-types.html
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::containsFilenames):
* platform/chromium/ChromiumDataObject.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
* platform/chromium/ClipboardMimeTypes.cpp:
* platform/chromium/ClipboardMimeTypes.h:
2011-03-07 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707
Correct and improve the error messages for viewport parsing.
Tests: fast/viewport/viewport-warnings-1.html
fast/viewport/viewport-warnings-2.html
fast/viewport/viewport-warnings-3.html
fast/viewport/viewport-warnings-4.html
fast/viewport/viewport-warnings-5.html
fast/viewport/viewport-warnings-6.html
* dom/ViewportArguments.cpp:
(WebCore::numericPrefix):
(WebCore::findSizeValue): remove incorrect device-width / height tips.
(WebCore::setViewportFeature): report a warning for an unrecognized key.
(WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
(WebCore::viewportErrorMessageLevel): classify an unrecognized key is an error.
* dom/ViewportArguments.h: removed no longer used warnings.
2011-03-07 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Separate the update and draw portions of LayerRendererChromium's drawLayers function
https://bugs.webkit.org/show_bug.cgi?id=54047
This splits up LayerRendererChromium::drawLayers() into two phases,
one that updates layers and one that actually draws them. Most of the
patch is moving the bodies of drawLayers() and updateLayersRecursive()
into smaller helper functions.
The main entry point is renamed updateAndDrawLayers(), but otherwise
has the same signature as drawLayers() did. Internally it does the
following:
1.) Updates the root layer's contents
2.) Updates the root layer's scrollbars
3.) Updates the RenderSurface tree and the contents of all child
layers
4.) Draws the root layer and root layer scrollbars
5.) Draws all child layers using the previously updated
CCLayerImpl/RenderSurface data.
A few things still need to be done after this patch to complete the separation
of the update and draw step, but they can happen in later patches:
*) The root layer and root layer scrollbars contents should be
uploaded to textures at draw time, not update time.
*) The RenderSurface tree should be updated at draw time, not update
time.
Covered by the compositing/ tests.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::updateRootLayerContents):
(WebCore::LayerRendererChromium::updateRootLayerScrollbars):
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::updateAndDrawLayers):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::updateContentsRecursive):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::visibleRectSize):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::drawSurface):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.h:
2011-03-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Sort WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55887
These files should be in order. This is preparation for adding in the
missing files.
* WebCore.gypi:
2011-03-07 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed buildfix after r80478.
* dom/Document.cpp: Add suggested parentheses to make GCC happy.
(WebCore::Document::didReceiveTask):
2011-03-07 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
Schedule them with timer when page loading is resumed. The tasks will be performed
in the original order. This fixes the problem that database callbacks could be missed
when page loading was deferred.
https://bugs.webkit.org/show_bug.cgi?id=49401
Manual test added: manual-tests/database-callback-deferred.html.
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::didReceiveTask):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):
(WebCore::Document::willDeferLoading):
(WebCore::Document::didResumeLoading):
* dom/Document.h:
* manual-tests/database-callback-deferred.html: Added.
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2011-03-07 Antti Koivisto <antti@apple.com>
Reviewed by Sam Weinig.
Use HashMaps for caching primitive values
https://bugs.webkit.org/show_bug.cgi?id=55873
Most documents use only small subset of cacheable primitive values. By replacing
fixed size cache arrays with HashMaps we can reduce the constant memory usage while also
expanding the range of cacheable values.
* css/CSSPrimitiveValueCache.cpp:
(WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
(WebCore::CSSPrimitiveValueCache::createIdentifierValue):
(WebCore::CSSPrimitiveValueCache::createColorValue):
(WebCore::CSSPrimitiveValueCache::createValue):
* css/CSSPrimitiveValueCache.h:
2011-03-07 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=55881
No new tests, refactoring only.
* Android.jscbindings.mk:
* GNUmakefile.am:
* WebCore.xcodeproj/project.pbxproj:
* bridge/jni/jsc/JNIBridgeJSC.cpp: Removed.
* bridge/jni/jsc/JNIBridgeJSC.h: Removed.
* bridge/jni/jsc/JNIUtilityPrivate.cpp:
* bridge/jni/jsc/JavaClassJSC.cpp:
* bridge/jni/jsc/JavaClassJSC.h:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
2011-03-07 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
https://bugs.webkit.org/show_bug.cgi?id=55827
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForResponse):
* loader/FrameLoaderClient.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse):
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkContentPolicy):
* loader/PolicyChecker.h:
Rename FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.
2011-03-07 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Add API to enumerate/delete files downloaded for <audio> and <video>
https://bugs.webkit.org/show_bug.cgi?id=55267
<rdar://problem/9049280>
No new tests, this is just more plumbing.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::getSitesInMediaCache): Make static, call MediaPlayer static method.
(WebCore::HTMLMediaElement::clearMediaCache): Ditto.
(WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayerFactory::MediaPlayerFactory): Add new media engine factory functions.
(WebCore::addMediaEngine): Ditto.
(WebCore::MediaPlayer::getSitesInMediaCache): Call static method on all installed media engines.
(WebCore::MediaPlayer::clearMediaCache): Ditto.
(WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
* platform/graphics/MediaPlayer.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): Update for MediaEngineRegistrar change.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Ditto.
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivatePhonon::registerMediaEngine): Ditto.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::registerMediaEngine): Ditto.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine): Ditto.
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::registerMediaEngine): Ditto.
2011-03-07 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Split JNIBridge.cpp/h into JavaString.h and JavaMethod.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=55774
No new tests, refactoring only.
* Android.jscbindings.mk:
* Android.v8bindings.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bridge/jni/JavaMethod.cpp:
(JavaMethod::JavaMethod):
(JavaMethod::~JavaMethod):
(appendClassName):
(JavaMethod::signature):
(JavaMethod::JNIReturnType):
(JavaMethod::methodID):
* bridge/jni/JavaMethod.h:
(JSC::Bindings::JavaMethod::name):
(JSC::Bindings::JavaMethod::returnType):
(JSC::Bindings::JavaMethod::parameterAt):
(JSC::Bindings::JavaMethod::numParameters):
(JSC::Bindings::JavaMethod::isStatic):
* bridge/jni/JavaString.h:
(JSC::Bindings::JavaString::JavaString):
(JSC::Bindings::JavaString::utf8):
(JSC::Bindings::JavaString::length):
(JSC::Bindings::JavaString::impl):
* bridge/jni/jni_jsobject.mm:
* bridge/jni/jsc/JNIBridgeJSC.h:
* bridge/jni/v8/JNIBridgeV8.h:
* bridge/jni/v8/JavaClassV8.cpp:
* bridge/jni/v8/JavaClassV8.h:
* bridge/jni/v8/JavaInstanceV8.cpp:
2011-03-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Add source to IDBCursor, objectStore to IDBIndex, and remove storeName
https://bugs.webkit.org/show_bug.cgi?id=55812
This brings us in line with what's in the spec:
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::create):
(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::source):
* storage/IDBCursor.h:
* storage/IDBCursor.idl:
* storage/IDBCursorWithValue.cpp:
(WebCore::IDBCursorWithValue::create):
(WebCore::IDBCursorWithValue::IDBCursorWithValue):
* storage/IDBCursorWithValue.h:
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::IDBIndex):
* storage/IDBIndex.h:
(WebCore::IDBIndex::create):
(WebCore::IDBIndex::objectStore):
* storage/IDBIndex.idl:
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
2011-03-07 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
AX: kAXCellForColumnAndRowParameterizedAttribute doesn't work ARIA grids with colspans
https://bugs.webkit.org/show_bug.cgi?id=55735
The ARIA grid implementation needed to verify the row/column range of a cell instead of
assuming a 1-1 mapping between children and row/column.
Test: platform/mac/accessibility/aria-table-with-colspan-cells.html
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
2011-03-07 Andrei Popescu <andreip@google.com>
Reviewed by Steve Block.
IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
IDBObjectStore objects used to be created asynchronously, so we needed
this method to be invoked, with the new object store as the parameter,
whenever the creation succeeded. The spec has changed so that IDBObjectStore
objects are created synchronously, so this method is no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=55777
No new tests, just refactoring.
* storage/IDBCallbacks.h:
* storage/IDBRequest.cpp:
* storage/IDBRequest.h:
2011-03-04 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JavaParameter should be removed
https://bugs.webkit.org/show_bug.cgi?id=55772
No new tests, refactoring only.
* bridge/jni/JNIBridge.cpp:
(JavaMethod::JavaMethod):
(JavaMethod::~JavaMethod):
(JavaMethod::signature):
* bridge/jni/JNIBridge.h:
(JSC::Bindings::JavaMethod::parameterAt):
(JSC::Bindings::JavaMethod::numParameters):
* bridge/jni/JNIUtility.h:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
* bridge/jni/v8/JNIUtilityPrivate.cpp:
(JSC::Bindings::convertNPVariantToJValue):
* bridge/jni/v8/JNIUtilityPrivate.h:
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::invokeMethod):
2011-03-07 Antti Koivisto <antti@apple.com>
Reviewed by Oliver Hunt.
REGRESSION (r79574): fast/dom/global-constructors.html failing on Windows 7 Release (Tests) bots
https://bugs.webkit.org/show_bug.cgi?id=55166
<rdar://problem/9050430>
Make CSS primitive value cache per-document.
Test: http/tests/security/cross-origin-css-primitive.html
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImage):
(WebCore::zoomAdjustedPixelValue):
(WebCore::zoomAdjustedNumberValue):
(WebCore::zoomAdjustedPixelValueForLength):
(WebCore::valueForReflection):
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
(WebCore::getBorderRadiusCornerValue):
(WebCore::computedTransform):
(WebCore::getDelayValue):
(WebCore::getDurationValue):
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::valueForFamily):
(WebCore::renderTextDecorationFlagsToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::fillSizeToCSSValue):
(WebCore::contentToCSSValue):
(WebCore::counterToCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::parseWCSSInputProperty):
(WebCore::parseBackgroundClip):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionXY):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationDelay):
(WebCore::CSSParser::parseAnimationDirection):
(WebCore::CSSParser::parseAnimationDuration):
(WebCore::CSSParser::parseAnimationFillMode):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseAnimationPlayState):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):
(WebCore::CSSParser::parseFontStyle):
(WebCore::CSSParser::parseFontVariant):
(WebCore::CSSParser::parseFontWeight):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitStyle):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::commitNumber):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseCounter):
(WebCore::parseDeprecatedGradientPoint):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseGradientColorStops):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parseTextEmphasisStyle):
* css/CSSParser.h:
(WebCore::CSSParser::primitiveValueCache):
* css/CSSPrimitiveValue.cpp:
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::createIdentifier):
(WebCore::CSSPrimitiveValue::createColor):
(WebCore::CSSPrimitiveValue::create):
* css/CSSPrimitiveValueCache.cpp: Added.
(WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
(WebCore::CSSPrimitiveValueCache::~CSSPrimitiveValueCache):
(WebCore::CSSPrimitiveValueCache::createIdentifierValue):
(WebCore::CSSPrimitiveValueCache::createColorValue):
(WebCore::CSSPrimitiveValueCache::createValue):
* css/CSSPrimitiveValueCache.h: Added.
(WebCore::CSSPrimitiveValueCache::create):
(WebCore::CSSPrimitiveValueCache::createValue):
* dom/Document.cpp:
(WebCore::Document::cssPrimitiveValueCache):
* dom/Document.h:
2011-03-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Filter sources in WebCore GYP build for Mac
https://bugs.webkit.org/show_bug.cgi?id=55857
This patch removes a large number of files that do not build as part of
the Mac build. I'm not fully sold on this method of
including/excluding files, but it's the "gyp way" so we should probably
try it first.
This patch also sets xcode_list_excluded_files to 0, which removes the
excluded files from the Xcode project file, which is necessary in order
to prevent the header map feature from including the wrong header file.
* gyp/WebCore.gyp:
2011-03-07 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed EFL build fix.
[EFL] Build break on Debug build.
https://bugs.webkit.org/show_bug.cgi?id=55858
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
2011-03-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add webcore_derived_source_files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55856
This is the list of files generated by the Mac port. It's possible
other ports generate a different list of files.
* WebCore.gypi:
* gyp/WebCore.gyp:
2011-03-06 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kent Tamura.
Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
https://bugs.webkit.org/show_bug.cgi?id=55839
http://crbug.com/73866
http://crbug.com/62527
We also need style change for m_innerSpinButton not only for m_outerSpinBuggon when styleDidChange() is called.
Test: fast/forms/input-appearance-spinbutton-visibility.html
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::styleDidChange):
2011-03-06 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kent Tamura.
[Chromium] Autocomplete suggestion extends out of window (and onto second monitor)
https://bugs.webkit.org/show_bug.cgi?id=54795
Implement width clip logic according to browser screen width and popup window width. This fix is enough for Win and Mac, but there is a problem in Linux. Because WebScreenInfoFactory::screenInfo() can get only merged screen size, not the screen size where the browser exists.
Test: manual-tests/popup-width-restriction-within-screen.html
* manual-tests/popup-width-restriction-within-screen.html: Added.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect): Implement the width clip logic according to screen width.
2011-03-06 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
Add SHA-1 for new WebSocket protocol
https://bugs.webkit.org/show_bug.cgi?id=55039
* ForwardingHeaders/wtf/SHA1.h: Added.
2011-03-06 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto.
QuickTime based media engines should respect private browsing mode
https://bugs.webkit.org/show_bug.cgi?id=55848
No new tests, it is only possible to test this by manually deleting and monitoring the
the Quicktime caches.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Add logging.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::MediaPlayer): Initialize m_privateBrowsing.
(WebCore::MediaPlayer::loadWithNextMediaEngine): Set privacy mode on new media engine.
(WebCore::MediaPlayer::setPrivateBrowsingMode): Stash setting in m_privateBrowsing.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_privateBrowsing.
(WebCore::MediaPlayerPrivateQTKit::createQTMovie): Pass private browsing attribute when
creating new movie.
(WebCore::MediaPlayerPrivateQTKit::setPrivateBrowsingMode): New, store privacy setting in
m_privateBrowsing and set movie attribute.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
Initialize m_privateBrowsing.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPrivateBrowsingMode): New, store
privacy setting in m_privateBrowsing and call QTMovie.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
* platform/graphics/win/QTMovie.cpp:
(QTMoviePrivate::QTMoviePrivate): Initialize m_privateBrowsing.
(QTMovie::load):Pass private browsing property when creating new movie.
(QTMovie::setPrivateBrowsingMode): New, store privacy setting in m_privateBrowsing and
set movie property.
* platform/graphics/win/QTMovie.h:
2011-03-06 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
style.borderSpacing always returns empty string
https://bugs.webkit.org/show_bug.cgi?id=54816
Teach CSSMutableStyleDeclaration::getPropertyValue() how to reconstitute
the value for border-spacing from the value of the WebKit internal CSS
property -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.
The CSS property border-spacing describes the horizontal and vertical border
spacing for an HTML Table element. Notice, WebKit internally represents the value
of this property as two properties: -webkit-border-horizontal-spacing and
-webkit-border-vertical-spacing, for the horizontal and vertical border spacing,
respectively. And WebKit doesn't know to reconstitute these internal properties.
Therefore style.borderSpacing always returns the empty string.
Test: fast/css/table-border-spacing.html
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::getPropertyValue):
(WebCore::CSSMutableStyleDeclaration::borderSpacingValue): Added.
* css/CSSMutableStyleDeclaration.h:
2011-03-06 Dan Bernstein <mitz@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/9093327> Implement -hyphenate-limit-{before,after}
https://bugs.webkit.org/show_bug.cgi?id=55850
Tests: fast/css/parsing-hyphenate-limit.html
fast/text/hyphenate-limit-before-after.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::computedProperties) Updated this array with the new properties and some old properties
that it was missing.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
CSSPropertyWebkitHyphenateLimit{Before,After}.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-limit-{before,after}, allowing
'auto' and non-negative integers.
* css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-{before,after}.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Handle CSSPropertyWebkitHyphenateLimit{Before,After}.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::tryHyphenating): Added minimum prefix and suffix length parameters and checks to only
allow hyphenation if the prefix and the suffix are sufficiently long.
(WebCore::RenderBlock::findNextLineBreak): Pass the limits to tryHyphenating().
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff): A difference in hyphenation limits is a layout difference.
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hyphenationLimitBefore): Added.
(WebCore::InheritedFlags::hyphenationLimitAfter): Added.
(WebCore::InheritedFlags::setHyphenationLimitBefore): Added.
(WebCore::InheritedFlags::setHyphenationLimitAfter): Added.
(WebCore::InheritedFlags::initialHyphenationLimitBefore): Added. Returns -1, which is the
representation of 'auto'.
(WebCore::InheritedFlags::initialHyphenationLimitAfter): Ditto.
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize hyphenation limits.
(WebCore::StyleRareInheritedData::operator==): Compare hyphenation limits.
* rendering/style/StyleRareInheritedData.h:
2011-03-06 Jessie Berlin <jberlin@apple.com>
Reviewed by Sam Weinig.
WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.
When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.
* WebCore.exp.in:
Add the new WKSI functions.
* platform/mac/WebCoreSystemInterface.h:
Ditto.
* platform/mac/WebCoreSystemInterface.mm:
Ditto.
* platform/mac/CookieJar.mm:
(WebCore::cookies):
If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Storage, call into WKSI.
Otherwise, behave the same as before.
(WebCore::cookieRequestHeaderFieldValue):
Ditto.
(WebCore::setCookies):
Ditto.
(WebCore::cookiesEnabled):
Ditto
(WebCore::getRawCookies):
Ditto.
(WebCore::deleteCookie):
Ditto.
* platform/network/CookieStorage.h:
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::privateBrowsingCookieStorage):
Keep track of the Private Browsing Cookie Storage in a locally defined static inside a
function instead of at the global scope.
(WebCore::currentCookieStorage):
Use privateBrowsingCookieStorage.
(WebCore::setCurrentCookieStorage):
Ditto.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
wkCreatePrivateInMemoryHTTPCookieStorage.
* platform/network/mac/CookieStorageMac.mm:
(WebCore::privateBrowsingCookieStorage):
Keep track of the Private Browsing Cookie Storage.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieStorage().
Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::shouldRelaxThirdPartyCookiePolicy):
Refactor the logic to determine whether or not to relax the third party cookie policy here.
If USE(CFURLSTORAGESESSIONS), then get the information from the privateBrowsingCookieStorage.
(WebCore::ResourceHandle::createNSURLConnection):
Use shouldRelaxThirdPartyCookiePolicy.
(WebCore::ResourceHandle::loadResourceSynchronously):
Ditto.
2011-03-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80428.
http://trac.webkit.org/changeset/80428
https://bugs.webkit.org/show_bug.cgi?id=55833
Broke SnowLeopard (Requested by xan_ on #webkit).
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::handlePostReadFile):
2011-03-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Windowless plugins override the view cursor
https://bugs.webkit.org/show_bug.cgi?id=55531
manual test: manual-tests/plugins/windowless.html
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::initXEvent): Instead of setting the window for windowless
plugin events, set the window value to none. This method is also used to send
focus in / focus out events to windowed plugins, but this is not one of the plugin
types where the window parameter matters. This matches what Mozilla does. Also
pass in the display of the widget itself, not the default display.
(WebCore::PluginView::handleMouseEvent): When the cursor leaves the plugin area,
reset the cursor.
(WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the
widget the top-level window explicitly. This matches Mozilla.
2011-03-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] http/tests/plugins/post-url-file.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=55826
Correct the implementation of handlePostReadFile which uses GIO APIs and
actually resizes the buffer to fit the entire size of the file data. This
was likely leading to memory corruption until now.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::handlePostReadFile): Fix this method.
2011-03-05 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=55824
Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilesPanel.prototype.handleShortcut):
(WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint.hideHint):
(WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint):
(WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
(WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):
2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636
Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
* WebCore.pri:
* features.pri:
2011-03-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: adding null check to prevent inspector tests from failing.
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
(WebInspector.TextEditorMainChunk.prototype.get offsetTop):
2011-03-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium rebaseline, flaky test fix.
* inspector/front-end/BreakpointManager.js:
(WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
(WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
(WebInspector.DOMBreakpointView.prototype._format.formatters.s):
(WebInspector.DOMBreakpointView.prototype._format.append):
(WebInspector.DOMBreakpointView.prototype._format):
2011-03-04 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [chromium] pause when script is running is broken.
https://bugs.webkit.org/show_bug.cgi?id=55762
* inspector/CodeGeneratorInspector.pm:
2011-03-05 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add Derived Sources to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55813
Adding the derived source action to the GYP file required tweaking
DerivedSources.make. I'm not sure how DerivedSources.make worked
before beause these paths were incorrectly based.
* DerivedSources.make:
* gyp/generate-derived-sources.sh: Added.
* gyp/WebCore.gyp:
2011-03-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: fix layout tests flakiness.
https://bugs.webkit.org/show_bug.cgi?id=55816
- Order of issuing of evaluateForTestInFrontend was not guaranteed on the backend side (InspectorAgent side)
- Order of dispatching using timeouts was guaranteed via queueing. Source of all kinds of pains on SnowLeopard Release (inspector.js)
* inspector/CodeGeneratorInspector.pm:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::populateScriptObjects):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
(WebCore::InspectorAgent::issueEvaluateForTestCommands):
* inspector/InspectorAgent.h:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.FormattedRecord):
* inspector/front-end/inspector.js:
(WebInspector.dispatch):
2011-03-05 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
WebCore GYP build should generate fewer than 10,000 compile errors per file
https://bugs.webkit.org/show_bug.cgi?id=55810
This patch adds some missing include paths. We need to figure out how
to handle separate include paths per port. It's clear that
ForwardingHeaders are only useful for Mac, but it's less clear how to
handle the others.
* WebCore.gypi:
* gyp/WebCore.gyp:
2011-03-05 Dan Bernstein <mitz@apple.com>
Reviewed by Cameron Zwarich.
<rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill() more robust
https://bugs.webkit.org/show_bug.cgi?id=55817
* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
a CGFont obtained from Core Text for the primary font. This CGFont may be different from
the CGFont stored in the FontPlatformData.
2011-03-05 Ilya Sherman <isherman@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::setValue() should schedule change event when the element is focused.
Refactored tracking of "changed since last change event" state from renderer to DOM.In service of https://code.google.com/p/chromium/issues
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53160
Test: fast/forms/onchange-change-type.html
Test: fast/forms/onchange-setvalueforuser.html
* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* dom/Element.h:
(WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added.
(WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEvent): Added.
(WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent): Added.
(WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag.
(WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also set the "changed since last change event" flag.
* html/HTMLFormControlElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType): Also clear the "changed since last change event" flag.
(WebCore::HTMLInputElement::setValue):
For a focused text field, dispatch an input event, but delay the change event until the field loses focus.
(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::stepUpFromRenderer):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::subtreeHasChanged):
* rendering/RenderTextControl.h:
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::subtreeHasChanged):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::subtreeHasChanged):
* wml/WMLInputElement.cpp:
(WebCore::WMLInputElement::WMLInputElement):
(WebCore::WMLInputElement::defaultEventHandler):
* wml/WMLInputElement.h:
(WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): Added.
(WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): Added.
2011-03-04 Xianzhu Wang <wangxianzhu@google.com>
Reviewed by Adam Barth.
Remove fake request loading of SVGImage to avoid MainResourceLoader
leak. The frame->init() already ensures initialization of the
document loader.
https://bugs.webkit.org/show_bug.cgi?id=55017
Test: fast/images/svg-image-leak-loader.html
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
2011-03-04 Mike Reed <reed@google.com>
Reviewed by Mihai Parparita.
[Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
https://bugs.webkit.org/show_bug.cgi?id=49477
* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::addArc):
2011-03-04 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
https://bugs.webkit.org/show_bug.cgi?id=55717
<rdar://problem/9018127>
manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in-iframe.html
Previously, the bounding box passed into EditorClient::showCorrectionPanel() is in the frame's
coordinate. This is incorrect when the correction occurs in an iframe. This patch added code
to convert the bounding box to window coordinate using ScrollView::contentToWindow().
* dom/Range.cpp:
(WebCore::Range::getBoundingClientRect):
(WebCore::Range::boundingRect):
* dom/Range.h:
* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::correctionPanelTimerFired):
(WebCore::Editor::windowRectForRange):
* editing/Editor.h:
* manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
* manual-tests/autocorrection/document-for-iframe-test.html: Added.
2011-03-04 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Those checking in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited() should be done with VisiblePosition::isNull().
https://bugs.webkit.org/show_bug.cgi?id=55731
No new tests. There's no behavioral change.
This patch improved clarity and readability of Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited().
* editing/Editor.cpp:
(WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
2011-03-04 John Bauman <jbauman@chromium.org>
Reviewed by Kenneth Russell.
[chromium] premultipliedAlpha WebGL context attribute is ignored.
https://bugs.webkit.org/show_bug.cgi?id=55411
Update compositor to set the blending of each layer correctly.
Test: compositing/webgl/webgl-nonpremultiplied-blend.html
* platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::CanvasLayerChromium):
(WebCore::CanvasLayerChromium::draw):
* platform/graphics/chromium/CanvasLayerChromium.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::draw):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::setContext):
2011-03-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebCore GYP build should link with the correct frameworks
https://bugs.webkit.org/show_bug.cgi?id=55804
* gyp/WebCore.gyp:
2011-03-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebCore GYP build should Check For Inappropriate Files in Framework
https://bugs.webkit.org/show_bug.cgi?id=55806
* gyp/WebCore.gyp:
2011-03-04 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
Add skeletal WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=55802
This doesn't yet build, but the basic structure is there.
* WebCore.gypi: Added headers and include directories variables.
* gyp/WebCore.gyp: Added.
2011-03-04 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Remove unneeded round-trips through ../Source in the Chromium GYP build
https://bugs.webkit.org/show_bug.cgi?id=55795
This is just cleanup work, but it was bugging me.
* WebCore.gyp/WebCore.gyp:
2011-03-04 Mike Reed <reed@google.com>
Reviewed by James Robinson.
Option to use skia's native text drawing APIs when drawing text
on Windows, rather than from outlines using drawPath(). This will
only have a significant effect when the skia-gpu backend is enabled.
https://bugs.webkit.org/show_bug.cgi?id=55609
No new tests. This is disabled by default. When enabled, it will draw
essentially the same, but with slightly different antialiased edges, due
to differences between the current scanconverter and GDI's font scaler.
When enabled, we will have to recalibrate layouttest image results.
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::skiaDrawText):
(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):
2011-03-04 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Fix texture stride issues on large content and image layers.
https://bugs.webkit.org/show_bug.cgi?id=55679
This was an error caused during the refactoring in r80081.
Tests: LayoutTests/compositing/tiling/huge-layer-img.html
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::updateTexture):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateTextureIfNeeded):
2011-03-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80379.
http://trac.webkit.org/changeset/80379
https://bugs.webkit.org/show_bug.cgi?id=55799
"Breaks leopard compile (implicit conversion)" (Requested by
tonyg-cr on #webkit).
* css/CSSStyleSelector.cpp:
(WebCore::convertToLength):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::createTransformOperations):
* platform/Length.h:
(WebCore::Length::Length):
(WebCore::Length::operator==):
(WebCore::Length::operator!=):
(WebCore::Length::rawValue):
(WebCore::Length::type):
(WebCore::Length::quirk):
(WebCore::Length::setValue):
(WebCore::Length::setRawValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::isZero):
(WebCore::Length::blend):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
2011-03-04 Jessie Berlin <jberlin@apple.com>
Reviewed by Darin Adler.
WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.
Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out because the code was
contained within guards that made USE(CFURLSTORAGESESSIONS) always be true.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::makeFinalRequest):
(WebCore::ResourceHandle::willSendRequest):
* platform/network/cf/ResourceRequestCFNet.cpp:
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::willSendRequest):
* platform/network/mac/ResourceRequestMac.mm:
2011-03-04 Yuqiang Xian <yuqiang.xian@intel.com>
Reviewed by Darin Adler.
improve layout performance by reducing the traversal time of the floating objects
https://bugs.webkit.org/show_bug.cgi?id=55440
We observered large overhead on traversing the floating objects list
in logicalLeftOffsetForLine() and logicalRightOffsetForLine() especially
when the list becomes enormous, for example in the default 30x30 maze test
from http://ie.microsoft.com/testdrive/Performance/MazeSolver/Default.html
there're >3700 floating objects. When placing a new floating object the
entire list (from begin to end) is traversed for multiple times.
There's a low hanging fruit to reduce the chances to do the traversal
which is especially applicable in logicalLeftOffsetForLine and logicalRightOffsetForLine.
As the two routines either cares about FloatLeft objects or FloatRight objects only,
if we know there's no corresponding type floating objects in the list
we can avoid the traversal actually. One thing we could do is to record
the number of FloatLeft objects and the number of FloatRight objects and
add a check before doing the traversal. This can reduce the time by 45%
to resolve the 30x30 Maze measured on N470 Netbook MeeGo using latest
Chromium browser 11 (from 503s to 269s).
No new tests, relying on existing layout tests.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::containsFloat):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
(WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::containsFloats):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::hasLeftObjects):
(WebCore::RenderBlock::FloatingObjects::hasRightObjects):
(WebCore::RenderBlock::FloatingObjects::set):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):
2011-03-04 Rik Cabanier <cabanier@gmail.com>
Reviewed by David Hyatt.
Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::convertToLength):
(WebCore::convertToIntLength):
(WebCore::convertToFloatLength):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::createTransformOperations):
* platform/Length.h:
(WebCore::Length::Length):
(WebCore::Length::operator==):
(WebCore::Length::operator!=):
(WebCore::Length::rawValue):
(WebCore::Length::type):
(WebCore::Length::quirk):
(WebCore::Length::setValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::isZero):
(WebCore::Length::blend):
(WebCore::Length::getIntValue):
(WebCore::Length::getFloatValue):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
2011-03-04 Steve Falkenburg <sfalken@apple.com>
Reviewed by Jon Honeycutt.
Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784
We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.
* WebCore.vcproj/QTMovieWin.rc: Removed.
* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/QTMovieWinPostBuild.cmd: Stamp version with VersionStamper.
* WebCore.vcproj/QTMovieWinPreBuild.cmd: Don't run auto-version.sh. We don't use autoversion.h in this project.
* WebCore.vcproj/WebCoreMediaQT.vsprops: Remove unnecessary include paths for resource files.
2011-03-04 Cosmin Truta <ctruta@chromium.org>
Reviewed by Adam Barth.
Clarify comment about potential memory leak in SVGImage
https://bugs.webkit.org/show_bug.cgi?id=55362
No functionality change. No new tests.
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
2011-03-04 Jessie Berlin <jberlin@apple.com>
Reviewed by Maciej Stachowiak.
WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.
When Private Browsing is enabled, get the cached url response from the cache associated with
the Private Browsing Storage Session.
* WebCore.exp.in:
Export the symbol for ResourceHandle::privateBrowsingStorageSession.
2011-03-04 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JSC and V8 versions of Java bridge should share JobjectWrapper
https://bugs.webkit.org/show_bug.cgi?id=55763
No new tests, refactoring only.
* Android.jscbindings.mk:
* Android.v8bindings.mk:
* WebCore.gypi:
* WebCore.order:
* WebCore.xcodeproj/project.pbxproj:
* bridge/jni/JobjectWrapper.cpp:
(JobjectWrapper::JobjectWrapper):
(JobjectWrapper::~JobjectWrapper):
* bridge/jni/JobjectWrapper.h:
(JSC::Bindings::JobjectWrapper::instance):
(JSC::Bindings::JobjectWrapper::setInstance):
(JSC::Bindings::JobjectWrapper::ref):
(JSC::Bindings::JobjectWrapper::deref):
* bridge/jni/jsc/JNIBridgeJSC.cpp:
(JavaField::JavaField):
(JavaArray::JavaArray):
* bridge/jni/jsc/JNIBridgeJSC.h:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::JavaInstance):
* bridge/jni/jsc/JavaInstanceJSC.h:
2011-03-04 Patrick Gansterer <paroga@webkit.org>
Reviewed by Nikolas Zimmermann.
Move shared code into SVGStyledTransformableElement::svgAttributeChanged
https://bugs.webkit.org/show_bug.cgi?id=55771
All sub classes of SVGStyledTransformableElement request a relayout
the same way. So move that code into the common base class.
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::svgAttributeChanged):
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::svgAttributeChanged):
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
* svg/SVGGElement.cpp:
(WebCore::SVGGElement::svgAttributeChanged):
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::svgAttributeChanged):
* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::svgAttributeChanged):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::svgAttributeChanged):
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::svgAttributeChanged):
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::svgAttributeChanged):
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::svgAttributeChanged):
* svg/SVGStyledTransformableElement.h:
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged):
2011-03-03 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Get rid of IsContentFiltered flags since they're not used anymore
https://bugs.webkit.org/show_bug.cgi?id=55748
* platform/network/chromium/ResourceResponse.cpp:
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
* platform/network/chromium/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
2011-03-03 Timothy Hatcher <timothy@apple.com>
Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
Reviewed by Darin Adler.
* WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
2011-03-04 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract all code that depends on source mapping from SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=55464
Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class
to encapsulate source mapping aspects from SourceFrame.
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.createResourceView):
(WebInspector.SourceFrameDelegateForResourcesPanel):
(WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
(WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
(WebInspector.SourceFrame.prototype._contextMenu):
(WebInspector.SourceFrame.prototype._mouseDown):
(WebInspector.SourceFrame.prototype._mouseMove):
(WebInspector.SourceFrame.prototype._hidePopup):
(WebInspector.SourceFrame.prototype._mouseHover):
(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
(WebInspector.SourceFrame.prototype._showPopup):
(WebInspector.SourceFrame.prototype._doubleClick):
(WebInspector.SourceFrame.prototype._didEditLine):
(WebInspector.SourceFrameDelegate):
(WebInspector.SourceFrameDelegate.prototype.requestContent):
(WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
(WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.continueToLine):
(WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegate.prototype.editScriptSource):
(WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
(WebInspector.SourceFrameDelegate.prototype.evaluate):
(WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
2011-03-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources.
https://bugs.webkit.org/show_bug.cgi?id=55686
- Use internal ids for resources in extension server.
- Log errors in inspector tests.
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype.resetResources):
(WebInspector.ExtensionServer.prototype._notifyResourceFinished):
(WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._resourceId):
(WebInspector.ExtensionServer.prototype._resourceById):
* inspector/front-end/HAREntry.js:
(WebInspector.HARLog):
(WebInspector.HARLog.prototype._convertResource):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._reset):
2011-03-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: exceptions when building context menu in network panel
https://bugs.webkit.org/show_bug.cgi?id=55678
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.dataGridNodeFromNode):
(WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._contextMenu):
2011-03-04 Ilya Sherman <isherman@chromium.org>
Reviewed by James Robinson.
Override paintScrollCorner() for FramelessScrollView to forego any custom scrollbar corner rendering.
This was previously done in ScrollbarThemeChromium, but we also need this on the Mac when the ScrollView
is a FramelessScrollView -- which is mostly just for Autofill.
In service of http://crbug.com/73772 (crash)
https://bugs.webkit.org/show_bug.cgi?id=55557
No tests added because this fix is Chromium-specific and the code is currently untestable from within WebKit.
In particular, DRT crashes when trying to render a FramelessScrollView.
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::paintScrollCorner): Body moved to static function defaultPaintScrollCorner().
(WebCore::ScrollbarTheme::defaultPaintScrollCorner): Added.
* platform/chromium/FramelessScrollView.cpp:
(WebCore::FramelessScrollView::paintContents):
(WebCore::FramelessScrollView::paintScrollCorner): Fix implementation moved to here from ScrollbarThemeChromium
* platform/chromium/FramelessScrollView.h:
* platform/chromium/ScrollbarThemeChromium.cpp:
* platform/chromium/ScrollbarThemeChromium.h:
2011-03-04 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=55770
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::didCommitLoad):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::~InspectorCSSAgent):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didCommitLoad):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::~InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
(WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
(WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
* inspector/InspectorProfilerAgent.h:
* inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorCSSAgent):
(WebCore::InstrumentingAgents::setInspectorCSSAgent):
(WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
(WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
(WebCore::InstrumentingAgents::inspectorDatabaseAgent):
(WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
(WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
(WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
(WebCore::InstrumentingAgents::inspectorDebuggerAgent):
(WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
(WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
(WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
(WebCore::InstrumentingAgents::inspectorProfilerAgent):
(WebCore::InstrumentingAgents::setInspectorProfilerAgent):
2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
https://bugs.webkit.org/show_bug.cgi?id=55773
* inspector/CodeGeneratorInspector.pm:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::releaseObjectGroup):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::releaseObjectGroup):
* inspector/InjectedScriptHost.h:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.idl:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::releaseObjectGroup):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
(WebInspector.ConsoleView.prototype.completions):
* inspector/front-end/PropertiesSidebarPane.js:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._hidePopup):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update):
2011-03-02 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Gutter height should be 100% when few lines are displayed
https://bugs.webkit.org/show_bug.cgi?id=55574
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._startEditing):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._syncScroll):
(WebInspector.TextEditorGutterPanel.prototype._expandChunks):
(WebInspector.TextEditorGutterPanel.prototype.textChanged):
(WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
* inspector/front-end/textViewer.css:
(.text-editor-lines):
(.text-editor-contents .inner-container):
(.webkit-line-number):
2011-03-04 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Do bisect to find visible chunks
https://bugs.webkit.org/show_bug.cgi?id=55685
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
(WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
(WebInspector.TextEditorMainChunk.prototype.get offsetTop):
2011-03-04 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] DOMNodeRemoved events are missing
https://bugs.webkit.org/show_bug.cgi?id=55769
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
(WebInspector.TextEditorMainChunk):
(WebInspector.TextEditorMainChunk.prototype._createRow):
2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Remove unnecessary domain and success flags from the response messages.
https://bugs.webkit.org/show_bug.cgi?id=55768
We have domain property in the response messages but it is not used because we dispatch
the responses on the callback associated with seq.
If we have property 'errors' in the response then success eq false and true in the other case.
* inspector/CodeGeneratorInspector.pm:
2011-03-04 Christian Dywan <christian@lanedo.com>
Reviewed by Gustavo Noronha Silva.
Enable Copy Image Address context menu item in the Gtk port
https://bugs.webkit.org/show_bug.cgi?id=55136
* page/ContextMenuController.cpp:
* platform/ContextMenuItem.h:
* platform/LocalizationStrategy.h:
* platform/LocalizedStrings.cpp:
* platform/LocalizedStrings.h:
* platform/gtk/ContextMenuItemGtk.cpp:
* platform/gtk/LocalizedStringsGtk.cpp:
2011-03-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement getCompletions via evaluate.
https://bugs.webkit.org/show_bug.cgi?id=55759
* inspector/InjectedScript.cpp:
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
* inspector/Inspector.idl:
* inspector/InspectorDebuggerAgent.cpp:
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions.evaluated):
(WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
(WebInspector.ConsoleView.prototype.completions):
(WebInspector.ConsoleView.prototype._reportCompletions):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._showPopup):
(WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
2011-03-04 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
V8 version of JavaString should obtain string from JNI in UTF-16 encoding
https://bugs.webkit.org/show_bug.cgi?id=55566
We obtain the string from JNI in UTF-16 encoding and convert
to UTF-8 using our own routines as required. This matches the
behaviour of the JSC version of JavaString.
No new tests, no change in behaviour.
* bridge/jni/v8/JavaStringV8.h:
(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::utf8):
(JSC::Bindings::JavaStringImpl::impl):
2011-03-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not push document into front-end, make it request one.
https://bugs.webkit.org/show_bug.cgi?id=55664
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
* inspector/InspectorAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::setDocument):
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::boundNodeId):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
(WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
(WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMDocument):
(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype.requestDocument):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
(WebInspector.DOMAgent.prototype._attributesUpdated):
(WebInspector.DOMAgent.prototype._characterDataModified):
(WebInspector.DOMAgent.prototype._documentUpdated):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
(WebInspector.DOMAgent.prototype._setChildNodes):
(WebInspector.DOMAgent.prototype._childNodeInserted):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMDispatcher.prototype.documentUpdated):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.show):
(WebInspector.ElementsPanel.prototype.setDocument):
* inspector/front-end/MetricsSidebarPane.js:
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.pushNodeToFrontend):
2011-03-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: summary bar may overlap content of the network item view
https://bugs.webkit.org/show_bug.cgi?id=55656
- drop custom summary bar placement logic, do it with CSS instead.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.resize):
(WebInspector.NetworkPanel.prototype._createSummaryBar):
(WebInspector.NetworkPanel.prototype._updateSummaryBar):
(WebInspector.NetworkPanel.prototype._updateFilter):
(WebInspector.NetworkPanel.prototype.show):
(WebInspector.NetworkPanel.prototype.refresh):
(WebInspector.NetworkPanel.prototype._reset):
(WebInspector.NetworkPanel.prototype._setLargerResources):
(WebInspector.NetworkPanel.prototype._updateOffscreenRows):
* inspector/front-end/networkPanel.css:
(.network-sidebar .data-grid td):
(.network-sidebar tr.filler td):
(.network-summary-bar):
(.network-sidebar .data-grid .network-summary-bar td):
(.network-summary-bar img):
2011-03-04 James Su <suzhe@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] keycode is always 0 when using non-Latin keyboard layout.
https://bugs.webkit.org/show_bug.cgi?id=54939
Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.
No intended functionality change.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
2011-03-04 Patrick Gansterer <paroga@webkit.org>
Unreviewed EFL build fix for r80324.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
2011-03-04 Patrick Gansterer <paroga@webkit.org>
Unreviewed EFL build fix for r80324.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
2011-03-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: AppCache agent should have same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=55673
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::createFrontendLifetimeAgents):
(WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::setFrontend):
(WebCore::InspectorApplicationCacheAgent::clearFrontend):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::networkStateChangedImpl):
(WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
* inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
(WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
2011-03-03 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Cleanup from https://bugs.webkit.org/show_bug.cgi?id=55427.
Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
on all platforms, and stub the functions on platforms that don't implement them.
Add startObservingCookieChanges and stopObservingCookieChanges to TemporaryLinkStubs
for platforms that don't implement them.
* platform/android/TemporaryLinkStubs.cpp:
* platform/brew/TemporaryLinkStubs.cpp:
* platform/chromium/TemporaryLinkStubs.cpp:
* platform/efl/TemporaryLinkStubs.cpp:
* platform/gtk/TemporaryLinkStubs.cpp:
* platform/haiku/TemporaryLinkStubs.cpp:
* platform/qt/TemporaryLinkStubsQt.cpp:
* platform/win/TemporaryLinkStubs.cpp:
2011-03-03 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Refactor createRendererIfNeeded to avoid premature nextRenderer calculation
https://bugs.webkit.org/show_bug.cgi?id=55720
There are two thing going on here:
1. Delaying nextRenderer calculation until we actually use it,
previously we would always compute nextRenderer (expensive!)
even if no renderer insertion was to occur.
2. Fix fullscreen elements to be inserted into the right place
in the rendering tree. Previously they would always be the last
child in their parent's list, even if that wasn't the right place.
I don't know of any way to trigger the fullscreen bug,
but I tested this with peacekeeper and saw no performance change.
Peacekeeper's domJQueryBasics is now possibly as much as 2% faster
but I don't really trust the stability of peacekeeper to begin with.
This paves the way for further improvement in our nextRenderer calculation.
* dom/Node.cpp:
(WebCore::Node::attach):
(WebCore::Node::previousRenderer):
(WebCore::Node::nextRenderer):
(WebCore::Node::createRendererAndStyle):
(WebCore::wrapWithRenderFullScreen):
(WebCore::Node::createRendererIfNeeded):
* dom/Node.h:
2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
https://bugs.webkit.org/show_bug.cgi?id=55554
* platform/Length.cpp:
(WebCore::newLengthArray): Pass nullptr instead of 0.
2011-03-03 Nat Duca <nduca@chromium.org>
Reviewed by James Robinson.
[chromium] Create a LayerChromium layerTreeAsText. Add HUD to
LayerRendererChromium that draws compositor FPS and, optionally,
the layer tree.
https://bugs.webkit.org/show_bug.cgi?id=54710
* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(WebCore::Canvas2DLayerChromium::drawsContent):
* platform/graphics/chromium/CanvasLayerChromium.h:
(WebCore::CanvasLayerChromium::layerTypeAsString):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::writeIndent):
(WebCore::ContentLayerChromium::dumpLayerProperties):
* platform/graphics/chromium/ContentLayerChromium.h:
(WebCore::ContentLayerChromium::drawsContent):
(WebCore::ContentLayerChromium::layerTypeAsString):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setName):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.h:
(WebCore::ImageLayerChromium::drawsContent):
(WebCore::ImageLayerChromium::layerTypeAsString):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setName):
(WebCore::LayerChromium::layerTreeAsText):
(WebCore::writeIndent):
(WebCore::LayerChromium::dumpLayer):
(WebCore::LayerChromium::dumpLayerProperties):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::name):
(WebCore::LayerChromium::drawsContent):
(WebCore::LayerChromium::debugID):
(WebCore::LayerChromium::layerTypeAsString):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::present):
(WebCore::LayerRendererChromium::layerTreeAsText):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::getHeadsUpDisplay):
(WebCore::LayerRendererChromium::rootVisibleRect):
* platform/graphics/chromium/PluginLayerChromium.h:
(WebCore::PluginLayerChromium::drawsContent):
(WebCore::PluginLayerChromium::layerTypeAsString):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::name):
(WebCore::writeIndent):
(WebCore::RenderSurfaceChromium::dumpSurface):
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/VideoLayerChromium.h:
(WebCore::VideoLayerChromium::drawsContent):
(WebCore::VideoLayerChromium::layerTypeAsString):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebCore::WebGLLayerChromium::drawsContent):
(WebCore::WebGLLayerChromium::layerTypeAsString):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: Added.
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::onPresent):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h: Added.
(WebCore::CCHeadsUpDisplay::setShowFPSCounter):
(WebCore::CCHeadsUpDisplay::showFPSCounter):
(WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::writeIndent):
(WebCore::CCLayerImpl::dumpLayerProperties):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::debugID):
(WebCore::CCLayerImpl::setName):
(WebCore::CCLayerImpl::name):
2011-03-02 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
crash in adoptNode with mutation events
https://bugs.webkit.org/show_bug.cgi?id=50046
If the DOM is modified during the removeChild call in adoptNode,
then the setDocument call that follows can leave the DOM in an
inconsistent state.
* dom/Document.cpp:
(WebCore::Document::adoptNode):
2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Add audio tag tests to the media controls manual test suite.
https://bugs.webkit.org/show_bug.cgi?id=55722
* manual-tests/media-controls.html: Added 4 audio tests.
2011-03-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
[EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style
https://bugs.webkit.org/show_bug.cgi?id=54392
Functions of RenderThemeEfl.cpp adhere efl coding style instead of WebKit coding style.
WebCore's functions should adhere WebKit coding style.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::cacheThemePartReset):
(WebCore::RenderThemeEfl::cacheThemePartResizeAndReset):
(WebCore::RenderThemeEfl::cacheThemePartGet):
(WebCore::RenderThemeEfl::cacheThemePartFlush):
(WebCore::RenderThemeEfl::applyEdjeStateFromForm):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::renderThemeEflColorClassSelectionActive):
(WebCore::renderThemeEflColorClassSelectionInactive):
(WebCore::renderThemeEflColorClassFocusRing):
(WebCore::renderThemeEflColorClassButtonText):
(WebCore::renderThemeEflColorClassComboText):
(WebCore::renderThemeEflColorClassEntryText):
(WebCore::renderThemeEflColorClassSearchText):
(WebCore::RenderThemeEfl::applyPartDescription):
(WebCore::RenderThemeEfl::applyPartDescriptions):
(WebCore::RenderThemeEfl::controlSupportsTints):
(WebCore::RenderThemeEfl::baselinePosition):
(WebCore::RenderThemeEfl::paintSliderTrack):
(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbStyle):
(WebCore::RenderThemeEfl::paintSliderThumb):
(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::paintCheckbox):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::paintRadio):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::paintButton):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::paintMenuList):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::paintTextField):
(WebCore::RenderThemeEfl::adjustTextAreaStyle):
(WebCore::RenderThemeEfl::paintTextArea):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeEfl::paintSearchFieldDecoration):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeEfl::paintSearchFieldResultsButton):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeEfl::paintSearchFieldCancelButton):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
(WebCore::RenderThemeEfl::paintSearchField):
(WebCore::RenderThemeEfl::adjustProgressBarStyle):
(WebCore::RenderThemeEfl::paintProgressBar):
(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
(WebCore::RenderThemeEfl::paintMediaMuteButton):
(WebCore::RenderThemeEfl::paintMediaPlayButton):
(WebCore::RenderThemeEfl::paintMediaSeekBackButton):
(WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
(WebCore::RenderThemeEfl::paintMediaSliderTrack):
(WebCore::RenderThemeEfl::paintMediaSliderThumb):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeEfl::paintMediaCurrentTime):
2011-03-03 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
Assertion failure in toElement(WebCore::Node*)
https://bugs.webkit.org/show_bug.cgi?id=55697
Test: fast/parser/fragment-foreign-content.html
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): The current
element in the HTMLElementStack might be a DocumentFragment if a
fragment is being parsed who's first node is foreign content.
2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[QT] Implement mock client-based geolocation for layout testing
https://bugs.webkit.org/show_bug.cgi?id=54334
Implements client() to GeolocationController to re-use geolocationClientMock class
for layout testing purpose.
* page/GeolocationController.h:
(WebCore::GeolocationController::client):
2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Stop calling deprecatedNode and deprecatedEditingOffset in InsertTextCommand
https://bugs.webkit.org/show_bug.cgi?id=55352
Stopped calling deprecatedNode and deprecatedEditingOffset in the following functions:
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::positionOutsideTabSpan): Takes care of all types of positions and
no longer calls deprecated functions.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::positionInsideTextNode): Ditto; renamed from prepareForTextInsertion.
Check if the text node inside a tab span before checking if the container node is a text node
because the position before or after a text node can still be inside a tab span.
(WebCore::InsertTextCommand::input): No longer calls deprecated functions.
* editing/InsertTextCommand.h:
* editing/ModifySelectionListLevel.cpp:
(WebCore::getStartEndListChildren): Call anchorNode() instead of deprecatedNode() because the start
or the end of selection could be an immediate child of a list node (e.g. br inside ul)
2011-03-03 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Move last bits of SQL into IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=55668
After this, all SQL code for IndexedDB is in IDBBackingStore.cpp.
No new tests: refactoring only.
* storage/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::createTransaction):
* storage/IDBBackingStore.h:
* storage/IDBCursorBackendImpl.h:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::backingStore):
* storage/IDBDatabaseBackendImpl.h:
* storage/IDBIndexBackendImpl.h:
* storage/IDBKey.h:
* storage/IDBObjectStoreBackendImpl.h:
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
* storage/IDBTransactionBackendImpl.h:
* storage/IDBTransactionBackendInterface.h:
* storage/IDBTransactionCoordinator.cpp:
2011-03-03 Adam Klein <adamk@chromium.org>
Reviewed by David Levin.
[fileapi] Tighten up ResolveURICallbacks
https://bugs.webkit.org/show_bug.cgi?id=55638
Two changes:
- Retry only on TYPE_MISMATCH_ERR now that Chromium
properly sets that error code.
- Call DirectoryEntry instead of DOMFileSystem methods.
No change in behavior, so no new tests.
* fileapi/FileSystemCallbacks.cpp:
(WebCore::ResolveURICallbacks::didOpenFileSystem):
2011-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Get rid of Page::globalHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=55738
The m_globalHistoryItem is only used by Mac and Windows WebKit1.
Instead of having WebCore updating this member variable, just call out
to a FrameLoaderClient member function and let WebKit keep it up to date.
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem):
(WebCore::EmptyFrameLoaderClient::updateGlobalHistoryItemForPage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::updateGlobalHistoryItemForPage):
* loader/HistoryController.cpp:
(WebCore::HistoryController::goToItem):
(WebCore::HistoryController::updateForStandardLoad):
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
* page/Page.cpp:
* page/Page.h:
2011-03-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Cursor.continue with a key param should test less than, not equal to
https://bugs.webkit.org/show_bug.cgi?id=55640
If you supply a param to cursor.continue, we sould guarantee that
the item we continue to is greater than or equal to the parameter.
Right now, we only test equality.
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-continue
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-iterating-a-cursor
Test: storage/indexeddb/cursor-continue.html
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
* storage/IDBKey.cpp:
(WebCore::IDBKey::isLessThan):
(WebCore::IDBKey::isEqual):
* storage/IDBKey.h:
2011-03-03 Brent Fulgham <bfulgham@webkit.org>
Build fix. Need win/cURL DownloadBundle stub.
* platform/network/curl/DownloadBundle.h: Added.
2011-03-03 Geoffrey Garen <ggaren@apple.com>
Rolled out 80277 and 80280 because they caused event handler layout test
failures.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.h:
* bindings/js/JSWorkerContextBase.cpp:
2011-03-03 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=55721
Global IconDatabase should be returned by reference, not as a pointer
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::reset):
(WebCore::HistoryItem::icon):
(WebCore::HistoryItem::setURLString):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::startIconLoader):
(WebCore::FrameLoader::commitIconURLToIconDatabase):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* loader/icon/IconDatabase.cpp:
(WebCore::iconDatabase):
* loader/icon/IconDatabase.h:
* loader/icon/IconDatabaseNone.cpp:
(WebCore::iconDatabase):
* loader/icon/wince/IconDatabaseWinCE.cpp:
(WebCore::iconDatabase):
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::finishLoading):
2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Martin Robinson.
Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder
https://bugs.webkit.org/show_bug.cgi?id=52742
Use firstPositionInOrBeforeNode to instantiate appropriate position.
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusInDocumentOrder):
2011-03-03 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
When displaying the missing plug-in sheet, pass the 'pluginspage'
attribute to the UI process.
https://bugs.webkit.org/show_bug.cgi?id=55553
* WebCore.exp.in: Export __ZN7WebCore9HTMLNames15pluginspageAttrE.
* html/HTMLAttributeNames.in: Add 'pluginspage' as a known content
attribute.
2011-03-03 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435
Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
* WebCore.exp.in:
Support using WKCopyRequestWithStorageSession in WebCore.
* platform/mac/WebCoreSystemInterface.h:
Ditto.
* platform/mac/WebCoreSystemInterface.mm:
Ditto.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::makeFinalRequest):
If Private Browsing is enabled, set the Private Browsing Storage Session on the request.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
* platform/network/cf/ResourceRequest.h:
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::setStorageSession):
Call through to WKSI.
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::setStorageSession):
Ditto.
2011-03-03 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
REGRESSION: Accelerated transitions are jumpy
https://bugs.webkit.org/show_bug.cgi?id=55022
Changed the way default TimingFunction is stored according to Adam Roben's
suggestion.
* platform/animation/TimingFunction.h:
(WebCore::CubicBezierTimingFunction::defaultTimingFunction):
2011-03-03 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
Rename -webkit-hyphenate-locale to -webkit-locale
https://bugs.webkit.org/show_bug.cgi?id=55709
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::cssPropertyID):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::locale):
(WebCore::InheritedFlags::setLocale):
(WebCore::InheritedFlags::initialLocale):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
2011-03-03 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fixes. Use Font::textMetrics to get ascent value, and add missing include.
* platform/wx/DragDataWx.cpp:
* platform/wx/wxcode/win/non-kerned-drawing.cpp:
(WebCore::drawTextWithSpacing):
2011-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
JSVariableObject needs to use WriteBarrier for symboltable property storage
https://bugs.webkit.org/show_bug.cgi?id=55698
Update to pass JSGlobalData for the symbol table write used
to set the document property.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::updateDocument):
2011-03-03 Alexey Proskuryakov <ap@apple.com>
More build fixing. Move WebCoreKeyboardUIMode.h to a cross-platform location.
* WebCore.xcodeproj/project.pbxproj:
* page/WebCoreKeyboardUIMode.h: Copied from WebCore/page/mac/WebCoreKeyboardUIMode.h.
* page/mac/WebCoreKeyboardUIMode.h: Removed.
2011-03-03 Alexey Proskuryakov <ap@apple.com>
Build fix. Should include WebCoreKeyboardUIMode.h on all platforms now.
* page/ChromeClient.h:
2011-03-02 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
https://bugs.webkit.org/show_bug.cgi?id=55633
<rdar://problem/8963023>
* loader/EmptyClients.h: (WebCore::EmptyChromeClient::keyboardUIMode):
* page/ChromeClient.h:
* page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks):
Merged tabsToLinks() and keyboardUIMode(). The latter returned a superset of information
returned by former.
2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
Fix Win compile break, caused by r80276.
* rendering/RenderThemeWin.h: Changed signature of volumeSliderOffsetFromMuteButton
to match RenderTheme.h.
2011-03-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Moved all variable object storage inline -- upping the object size limit to 1K
https://bugs.webkit.org/show_bug.cgi?id=55653
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.h:
* bindings/js/JSWorkerContextBase.cpp: Removed out-of-line storage. Changed d-> to m_.
2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
https://bugs.webkit.org/show_bug.cgi?id=55099
Cleanup, no behavior change.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::updateVolumeSliderContainer): Changed to pass RenderBox
instead of Node.
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Changed
to use RenderBox as argument.
* rendering/RenderMediaControls.h: Ditto.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): Ditto.
* rendering/RenderTheme.h: Ditto.
* rendering/RenderThemeChromiumMac.h: Ditto.
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton): Ditto.
* rendering/RenderThemeMac.h: Ditto.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Ditto.
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Ditto.
2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
When building with DEFINES+=USE_GSTREAMER=1 we don't want to define ENABLE_QT_MULTIMEDIA to 1.
Also add the new files added after https://bugs.webkit.org/show_bug.cgi?id=54870 to support GRefPtr
for GstElement.
* WebCore.pro:
* features.pri:
2011-03-03 Anders Carlsson <andersca@apple.com>
Try to fix the Windows build again.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
Add another CRASH() for CSSSelector double frees
https://bugs.webkit.org/show_bug.cgi?id=55693
To help track down bug 53045, add a CRASH call when the the array and/or
CSSSelector member in CSSSelectorList is disposed of more than once.
Just a check, no new tests necessary.
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::deleteSelectors):
2011-03-03 Anders Carlsson <andersca@apple.com>
Yet another attempt at fixing the Windows build.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
* platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
2011-03-02 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
REGRESSION: Accelerated transitions are jumpy
https://bugs.webkit.org/show_bug.cgi?id=55022
Got rid of default TimingFunction values from PlatformCAAnimation*. A TimingFunction
is now always passed in. The TimingFunction class now has a static method to get
a default object which has the 'ease' values in it. I now assert in both Mac and
Win implementations if a null TimingFunction pointer is seen.
* platform/animation/TimingFunction.h:
(WebCore::CubicBezierTimingFunction::create):
(WebCore::CubicBezierTimingFunction::defaultTimingFunction):
(WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(toCAMediaTimingFunction):
* platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(toCACFTimingFunction):
2011-03-03 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix clang compile after r80220
https://bugs.webkit.org/show_bug.cgi?id=55692
* storage/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
2011-03-03 Anders Carlsson <andersca@apple.com>
Attempt to fix the Windows build.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
2011-03-02 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Rest of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>
Add functions to be exported.
* WebCore.exp.in:
2011-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Improve WebCore build time by ~5%
https://bugs.webkit.org/show_bug.cgi?id=55688
Forward declare the CATransform3D and CGAffineTransform structs instead of including
large chunks of QuartzCore and Core Graphics.
On an 8 core Mac Pro, this sped up building WebCore by about 5%.
* platform/graphics/ca/GraphicsLayerCA.cpp:
* platform/graphics/ca/TransformationMatrixCA.cpp:
* platform/graphics/transforms/TransformationMatrix.h:
2011-03-03 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Adjusted call to a method renamed in r80102.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._startEditing):
2011-03-03 Timothy Hatcher <timothy@apple.com>
Use APIEntryShim instead of JSLock in SerializedScriptValue to allow it to be used
by contexts not created by WebCore.
https://webkit.org/b/55642
Reviewed by Oliver Hunt.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create): Use APIEntryShim instead of JSLock.
(WebCore::SerializedScriptValue::deserialize): Ditto.
2011-03-03 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
WebCore should check for "Upgrade" and "Connection" header fields in WebSockets handshake
https://bugs.webkit.org/show_bug.cgi?id=55498
<rdar://problem/8752706>
Tests: http/tests/websocket/tests/handshake-fail-by-no-connection-header.html
http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html
* websockets/WebSocketHandshake.h: Removed unused and meaningless setters for response
header fields. Removed separate member variables for those, as they were duplicating data
available in response, and there is no reason to squeeze microsecods here.
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::reset): There are no longer member variables for header field
values to reset here.
(WebCore::WebSocketHandshake::readServerHandshake): Removed a call for processHeaders().
(WebCore::WebSocketHandshake::serverWebSocketOrigin): Changed to get the value from response.
(WebCore::WebSocketHandshake::serverWebSocketLocation): Ditto.
(WebCore::WebSocketHandshake::serverWebSocketProtocol): Ditto.
(WebCore::WebSocketHandshake::serverSetCookie): Ditto.
(WebCore::WebSocketHandshake::serverSetCookie2): Ditto.
(WebCore::WebSocketHandshake::serverUpgrade): Added.
(WebCore::WebSocketHandshake::serverConnection): Added.
(WebCore::WebSocketHandshake::checkResponseHeaders): Added checks for Upgrade and Connection
header field presence and values.
2011-03-03 Helder Correia <helder@sencha.com>
Reviewed by Andreas Kling.
[Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
https://bugs.webkit.org/show_bug.cgi?id=55651
When relying on ContextShadow and using a gradient stroke for a path,
the alpha of the shadow is incorrect.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::strokePath):
2011-03-03 Martin Robinson <mrobinson@igalia.com>
XHTMLMP build broken after r78342
https://bugs.webkit.org/show_bug.cgi?id=55286
Fix XHTMLMP build now that the DocumentWriter is a member of DocumentLoader
instead of FrameLoader.
No new tests. This is a build fix.
* dom/Document.cpp:
(WebCore::Document::isXHTMLMPDocument):
2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
Tweak MediaControlMuteButtonElement class hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=55614
This allows the mute button on the panel to have event handlers that are
different from the mute button in the volume slider.
No change in behavior, covered by existing tests.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::createMuteButton): Changed to use MediaControlPanelMuteButtonElement.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlMuteButtonElement::updateDisplayType):
(WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): Added.
(WebCore::MediaControlPanelMuteButtonElement::create): Added.
(WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Moved.
* rendering/MediaControlElements.h: Added defs.
2011-03-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Resource agent should have same lifetime as Inspector agent
https://bugs.webkit.org/show_bug.cgi?id=55461
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::inspectedPageDestroyed): disconnectFrontend is called before the agent is destroyed
to clear frontend reference in all agents.
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::resourceAgent):
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
(WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
(WebCore::InspectorInstrumentation::retrieveResourceAgent):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::setFrontend):
(WebCore::InspectorResourceAgent::clearFrontend):
(WebCore::InspectorResourceAgent::restore):
(WebCore::InspectorResourceAgent::~InspectorResourceAgent):
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
* inspector/InspectorResourceAgent.h:
(WebCore::InspectorResourceAgent::create):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::restore):
* inspector/InspectorTimelineAgent.h:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype.frontendReused):
* inspector/front-end/inspector.js:
(WebInspector.frontendReused):
2011-03-03 Andras Becsi <abecsi@webkit.org>
Reviewed by Andreas Kling.
CSS RGBA fast-path color parsing should clamp of out-of-range alpha values
https://bugs.webkit.org/show_bug.cgi?id=55661
Test case originally written by Andreas Kling <andreas.kling@nokia.com>
Test: fast/canvas/rgba-parsing.html
* css/CSSParser.cpp:
(WebCore::isValidDouble): Check whether the given string is a valid double.
(WebCore::parseAlphaValue): Out-of-range alpha values should be clamped to the (0.0, 1.0) range.
2011-03-03 David Holloway <dhollowa@chromium.org>
Reviewed by Dimitri Glazkov.
Changes HTMLTextFormControlElement::placeholderShouldBeVisible to account
for non-empty suggestion text. The visibility of the placeholder text
now turned off when suggestion text is set.
https://bugs.webkit.org/show_bug.cgi?id=55245
No new tests because, by design, the suggestion text is not accessible
through the DOM.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
* html/HTMLFormControlElement.h:
(WebCore::HTMLTextFormControlElement::isEmptySuggestedValue):
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::isEmptySuggestedValue):
2011-03-03 Andy Estes <aestes@apple.com>
Reviewed by Eric Seidel.
HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
https://bugs.webkit.org/show_bug.cgi?id=48719
Instead of pushing a fake HTMLHtmlElement onto the open element stack
during fragment parsing only to later remove it and reparent its
children to the DocumentFragment, push the DocumentFragment directly
onto the open element stack as the root node. This requires refactoring
HTMLElementStack to hold ContainerNode pointers rather than Element
pointers, which has implications for HTMLConstructionSite and
HTMLTreeBuilder as well.
With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
is ~14%. However, if you discount the 'domDynamicCreationCreateElement'
test, ToT is now ~4% faster than Safari 5.0.3. This indicates that the
regression no longer lies in fragment parsing.
No new tests. No change in behavior.
* dom/Element.h:
(WebCore::Node::hasLocalName):
* dom/Node.h:
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLNames::hasImpliedEndTag):
(WebCore::HTMLConstructionSite::HTMLConstructionSite):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::attachToCurrent):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
(WebCore::HTMLConstructionSite::generateImpliedEndTags):
(WebCore::HTMLConstructionSite::findFosterSite):
(WebCore::HTMLConstructionSite::shouldFosterParent):
* html/parser/HTMLConstructionSite.h:
(WebCore::HTMLConstructionSite::currentNode):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isNumberedHeaderElement):
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isListItemScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
(WebCore::HTMLNames::isTableBodyScopeMarker):
(WebCore::HTMLNames::isTableRowScopeMarker):
(WebCore::HTMLNames::isButtonScopeMarker):
(WebCore::HTMLNames::isSelectScopeMarker):
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::HTMLElementStack):
(WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
(WebCore::HTMLElementStack::popAll):
(WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
(WebCore::HTMLElementStack::popUntil):
(WebCore::HTMLElementStack::popUntilPopped):
(WebCore::HTMLElementStack::popUntilTableScopeMarker):
(WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
(WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::find):
(WebCore::HTMLElementStack::topmost):
(WebCore::HTMLElementStack::contains):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
(WebCore::HTMLElementStack::htmlElement):
(WebCore::HTMLElementStack::rootNode):
(WebCore::HTMLElementStack::pushCommon):
* html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::ElementRecord::element):
(WebCore::HTMLElementStack::ElementRecord::node):
(WebCore::HTMLElementStack::topNode):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::finished):
* html/parser/HTMLTreeBuilder.h:
2011-03-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inspector protocol should allow different domains to have methods with same name
https://bugs.webkit.org/show_bug.cgi?id=55558
* inspector/CodeGeneratorInspector.pm: each command is now identified by domain + command-name(was command-name only).
2011-03-02 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make selected call frame debugger presentation model property.
https://bugs.webkit.org/show_bug.cgi?id=55582
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
(WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.getCompletionsOnCallFrame):
(WebInspector.ScriptsPanel.prototype._debuggerResumed):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
2011-03-03 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
On Mac OS X, spelling suggestion panel stops showing up after change set 80121
https://bugs.webkit.org/show_bug.cgi?id=55628
Removed a call to stopCorrectionPanelTimer() to fix a regression introduced by changeset 80121.
* editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
* manual-tests/autocorrection/autocorrection-contraction.html:
2011-03-03 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: rename "sourceName" to "sourceFileId" in ScriptsPanel.js.
https://bugs.webkit.org/show_bug.cgi?id=55569
sourceFileId better reflects the intention to have unique identifier for each source that is shown in scripts panel.
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/ScriptsPanel.js:
2011-03-03 Steve Block <steveblock@google.com>
Reviewed by David Levin.
JavaString API should be implementable by both JSC and V8
https://bugs.webkit.org/show_bug.cgi?id=55567
Remove JavaString's UString operator and replace it with a
script-engine-independent impl() method, which returns a
StringImpl and can be implemented with both JSC and V8.
No new tests, refactoring only.
* bridge/jni/JNIBridge.h:
(JSC::Bindings::JavaString::impl):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
* bridge/jni/jsc/JNIBridgeJSC.cpp:
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):
* bridge/jni/jsc/JavaClassJSC.cpp:
(JavaClass::JavaClass):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
* bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::impl):
* bridge/jni/v8/JavaStringV8.h:
(JSC::Bindings::JavaStringImpl::impl):
2011-03-03 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Adam Roben.
REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=55602
Delete the FloatingObject referenced by m_floatingObjects when clearing the floats.
The DeprecatedPtrList was deleting the objects automatically due to its autoDelete behavior. The
objects need to be deleted manually with ListHashSet.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloats):
2011-03-03 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Move SQL code, especially for cursors, to IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=55376
Move SQL code from IDBKey, IDBKeyRange, IDBIndexBackendImpl,
IDBObjectStoreBackendImpl, and especially IDBCursorBackendImpl.
No new functionality, so no new tests.
* storage/IDBBackingStore.cpp:
(WebCore::lowerCursorWhereFragment):
(WebCore::upperCursorWhereFragment):
(WebCore::IDBBackingStore::deleteObjectStoreRecord):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBBackingStore::getObjectViaIndex):
(WebCore::keyFromQuery):
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStore::keyExistsInIndex):
(WebCore::CursorImplCommon::CursorImplCommon::continueInternal):
(WebCore::CursorImplCommon::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::CursorImplCommon::ObjectStoreCursorImpl::objectStoreDataId):
(WebCore::CursorImplCommon::ObjectStoreCursorImpl::key):
(WebCore::CursorImplCommon::ObjectStoreCursorImpl::value):
(WebCore::CursorImplCommon::ObjectStoreCursorImpl::continueFunction):
(WebCore::IDBBackingStore::openObjectStoreCursor):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
(WebCore::ObjectStoreCursorImpl::currentRowExists):
(WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl):
(WebCore::IndexKeyCursorImpl::indexDataId):
(WebCore::IndexKeyCursorImpl::key):
(WebCore::IndexKeyCursorImpl::primaryKey):
(WebCore::IndexKeyCursorImpl::continueFunction):
(WebCore::IDBBackingStore::openIndexKeyCursor):
(WebCore::IndexKeyCursorImpl::loadCurrentRow):
(WebCore::IndexKeyCursorImpl::currentRowExists):
(WebCore::IndexCursorImpl::IndexCursorImpl):
(WebCore::IndexCursorImpl::indexDataId):
(WebCore::IndexCursorImpl::key):
(WebCore::IndexCursorImpl::primaryKey):
(WebCore::IndexCursorImpl::value):
(WebCore::IndexCursorImpl::continueFunction):
(WebCore::IDBBackingStore::openIndexCursor):
(WebCore::IndexCursorImpl::loadCurrentRow):
(WebCore::IndexCursorImpl::currentRowExists):
* storage/IDBBackingStore.h:
(WebCore::IDBBackingStore::Cursor::~Cursor):
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::key):
(WebCore::IDBCursorBackendImpl::value):
(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
(WebCore::IDBCursorBackendImpl::deleteFunction):
* storage/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):
* storage/IDBIndexBackendImpl.h:
* storage/IDBKey.cpp:
(WebCore::IDBKey::isEqual):
* storage/IDBKey.h:
* storage/IDBKeyRange.cpp:
* storage/IDBKeyRange.h:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
* storage/IDBObjectStoreBackendImpl.h:
2011-03-03 Peter Kasting <pkasting@google.com>
Reviewed by James Robinson.
Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567
* StringsNotToBeLocalized.txt:
2011-03-03 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146
Emit the selection-changed signals when the menu list value has changed
Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::getListObject): New, return the right list object for
menu lists and list boxes.
(WebCore::notifyChildrenSelectionChange): Support menu lists.
(WebCore::AXObjectCache::postPlatformNotification): Call function
notifyChildrenSelectionChange for AXMenuListValueChanged.
2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55338
Include wtf/Forward.h instead of wtf/text/String.h
* editing/EditingStyle.h:
2011-03-03 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed trivial fix after r80169.
[Qt][WK2] Memory exhausted when building qtwebkit2 on linux
https://bugs.webkit.org/show_bug.cgi?id=55484
* WebCore.pro: Typo fix. We have to use linux-g++* instead of linux-g++.
2011-03-02 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Refactoring] Make ScheduledEvent on FrameView abstract out to ScheduleAction
https://bugs.webkit.org/show_bug.cgi?id=54440
- Extracted FrameActionScheduler from FrameView
- Extracted FrameAction abstract class from ScheduledEvent,
which has fire() virtual method.
- Renamed ScheduledEvent EventFrameAction
With this change, Any action can be hooked up to the end of the layout.
No new tests. No behavioral change.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/FrameActionScheduler.cpp: Added.
(WebCore::EventFrameAction::EventFrameAction):
(WebCore::EventFrameAction::fire):
(WebCore::FrameActionScheduler::FrameActionScheduler):
(WebCore::FrameActionScheduler::~FrameActionScheduler):
(WebCore::FrameActionScheduler::isEmpty):
(WebCore::FrameActionScheduler::clear):
(WebCore::FrameActionScheduler::pause):
(WebCore::FrameActionScheduler::resume):
(WebCore::FrameActionScheduler::dispatch):
(WebCore::FrameActionScheduler::scheduleAction):
(WebCore::FrameActionScheduler::scheduleEvent):
* page/FrameActionScheduler.h: Added.
(WebCore::FrameAction::FrameAction):
(WebCore::FrameAction::~FrameAction):
(WebCore::FrameActionScheduler::isScheduled):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleEvent):
(WebCore::FrameView::pauseScheduledEvents):
(WebCore::FrameView::resumeScheduledEvents):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateOverflowStatus):
* page/FrameView.h:
2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80201.
http://trac.webkit.org/changeset/80201
https://bugs.webkit.org/show_bug.cgi?id=55648
"caused tests to crash on several bots" (Requested by rniwa on
#webkit).
* dom/Element.h:
(WebCore::Node::hasTagName):
* dom/Node.h:
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLNames::hasImpliedEndTag):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::attachToCurrent):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
(WebCore::HTMLConstructionSite::generateImpliedEndTags):
(WebCore::HTMLConstructionSite::findFosterSite):
(WebCore::HTMLConstructionSite::shouldFosterParent):
* html/parser/HTMLConstructionSite.h:
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isNumberedHeaderElement):
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isListItemScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
(WebCore::HTMLNames::isTableBodyScopeMarker):
(WebCore::HTMLNames::isTableRowScopeMarker):
(WebCore::HTMLNames::isButtonScopeMarker):
(WebCore::HTMLNames::isSelectScopeMarker):
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::HTMLElementStack):
(WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
(WebCore::HTMLElementStack::popAll):
(WebCore::HTMLElementStack::popUntilTableScopeMarker):
(WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
(WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
(WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::find):
(WebCore::HTMLElementStack::topmost):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
(WebCore::HTMLElementStack::htmlElement):
(WebCore::HTMLElementStack::bodyElement):
(WebCore::HTMLElementStack::pushCommon):
* html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::ElementRecord::element):
(WebCore::HTMLElementStack::top):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::finished):
* html/parser/HTMLTreeBuilder.h:
2011-03-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: break down InspectorFrontend into domain-specific classes
https://bugs.webkit.org/show_bug.cgi?id=55584
* inspector/CodeGeneratorInspector.pm: InspectorFrontend now contains nested classes for
all domains that have event notifications.
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::updateRepeatCountInConsole):
* inspector/ConsoleMessage.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::inspectImpl):
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::inspectedPageDestroyed):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::populateScriptObjects):
(WebCore::InspectorAgent::pushDataCollectedOffline):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::domContentLoadedEventFired):
(WebCore::InspectorAgent::loadEventFired):
(WebCore::InspectorAgent::postWorkerNotificationToFrontend):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
(WebCore::InspectorAgent::showPanel):
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::setFrontend):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::show):
(WebCore::InspectorController::close):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setFrontend):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::bind):
* inspector/InspectorDOMStorageResource.h:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::FrontendProvider::frontend):
(WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider):
(WebCore::InspectorDatabaseAgent::setFrontend):
* inspector/InspectorDatabaseResource.cpp:
(WebCore::InspectorDatabaseResource::bind):
* inspector/InspectorDatabaseResource.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setFrontend):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorProfilerAgent.cpp:
* inspector/InspectorProfilerAgent.h:
(WebCore::InspectorProfilerAgent::setFrontend):
(WebCore::InspectorProfilerAgent::clearFrontend):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::setFrontend):
* inspector/InspectorTimelineAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMDispatcher.prototype.inspectElementRequested):
(WebInspector.DOMDispatcher.prototype.addNodesToSearchResult):
* inspector/front-end/inspector.js:
2011-03-02 Kent Tamura <tkent@chromium.org>
Unreviewed, a trivial regression fix.
Fix LocalizedNumberICU regression by r80198 and r80199.
https://bugs.webkit.org/show_bug.cgi?id=55629
* platform/text/LocalizedNumberICU.cpp:
We should use U_SUCCESS().
(WebCore::createFormatterForCurrentLocale):
(WebCore::parseLocalizedNumber):
2011-03-02 Dan Bernstein <mitz@apple.com>
Let Xcode know that Localizable.strings is UTF-16-encoded.
* WebCore.xcodeproj/project.pbxproj:
2011-03-02 Andy Estes <aestes@apple.com>
Reviewed by Eric Seidel.
HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
https://bugs.webkit.org/show_bug.cgi?id=48719
Instead of pushing a fake HTMLHtmlElement onto the open element stack
during fragment parsing only to later remove it and reparent its
children to the DocumentFragment, push the DocumentFragment directly
onto the open element stack as the root node. This requires refactoring
HTMLElementStack to hold ContainerNode pointers rather than Element
pointers, which has implications for HTMLConstructionSite and
HTMLTreeBuilder as well.
With this patch, the regression in Peacekeeper due to the introduction
of the HTML5 fragment parsing algorithm is ~14%. The regression from
Safari 5.0.3 is ~24%.
No new tests. No change in behavior.
* dom/Element.h:
(WebCore::Node::hasLocalName):
* dom/Node.h:
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLNames::hasImpliedEndTag):
(WebCore::HTMLConstructionSite::HTMLConstructionSite):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::attachToCurrent):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
(WebCore::HTMLConstructionSite::generateImpliedEndTags):
(WebCore::HTMLConstructionSite::findFosterSite):
(WebCore::HTMLConstructionSite::shouldFosterParent):
* html/parser/HTMLConstructionSite.h:
(WebCore::HTMLConstructionSite::currentNode):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isNumberedHeaderElement):
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isListItemScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
(WebCore::HTMLNames::isTableBodyScopeMarker):
(WebCore::HTMLNames::isTableRowScopeMarker):
(WebCore::HTMLNames::isButtonScopeMarker):
(WebCore::HTMLNames::isSelectScopeMarker):
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::HTMLElementStack):
(WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
(WebCore::HTMLElementStack::popAll):
(WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
(WebCore::HTMLElementStack::popUntil):
(WebCore::HTMLElementStack::popUntilPopped):
(WebCore::HTMLElementStack::popUntilTableScopeMarker):
(WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
(WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::find):
(WebCore::HTMLElementStack::topmost):
(WebCore::HTMLElementStack::contains):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
(WebCore::HTMLElementStack::htmlElement):
(WebCore::HTMLElementStack::rootNode):
(WebCore::HTMLElementStack::pushCommon):
* html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::ElementRecord::element):
(WebCore::HTMLElementStack::ElementRecord::node):
(WebCore::HTMLElementStack::topNode):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::finished):
* html/parser/HTMLTreeBuilder.h:
2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80188.
http://trac.webkit.org/changeset/80188
https://bugs.webkit.org/show_bug.cgi?id=55647
Broke the WebKit API tests. (Requested by xenon on #webkit).
* WebCore.exp.in:
2011-03-02 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix.
* platform/text/LocalizedNumberICU.cpp:
(WebCore::createFormatterForCurrentLocale): Fix a typo.
2011-03-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Caching number formatter instances in LocalizedNumber* implementations
https://bugs.webkit.org/show_bug.cgi?id=55629
No new tests. This change doesn't change existing behavior, and is
covered by existing tests.
* platform/text/LocalizedNumberICU.cpp:
(WebCore::createFormatterForCurrentLocale):
(WebCore::numberFormatter): Introduce a function to return a static
instance of NumberFormat.
(WebCore::parseLocalizedNumber): Use numberFormatter().
(WebCore::formatLocalizedNumber): Use numberFormatter().
* platform/text/mac/LocalizedNumberMac.mm:
(WebCore::createFormatterForCurrentLocale):
(WebCore::numberFormatter): Introduce a function to return a static
instance of NSNumberFormatter.
(WebCore::parseLocalizedNumber): Use numberFormatter().
(WebCore::formatLocalizedNumber): Use numberFormatter().
2011-03-02 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
deprecatedEditingOffset should actually return the expected deprecated value for "after" positions
https://bugs.webkit.org/show_bug.cgi?id=54986
Calls to deprecatedEditingOffset needs to return the expected value for new Before/After positions
until we can update all the call sites to consider the new position types.
No tests. This is intended to simplify the transition to new Positions, not to change behavior.
* dom/Position.cpp:
(WebCore::Position::deprecatedEditingOffset):
(WebCore::Position::offsetForPositionAfterAnchor): Added to do the right thing while ensuring
inline-speed for most calls to deprecatedEditingOffset.
* dom/Position.h:
2011-03-02 Timothy Hatcher <timothy@apple.com>
Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
Reviewed by Darin Adler.
* WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
2011-03-02 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Manually revert ChromiumDataObject changes.
https://bugs.webkit.org/show_bug.cgi?id=55627
No new tests since no functionality should change.
* WebCore.gypi:
* editing/chromium/EditorChromium.cpp:
(WebCore::Editor::newGeneralClipboard):
* page/chromium/EventHandlerChromium.cpp:
(WebCore::EventHandler::createDraggingClipboard):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::clearData):
(WebCore::ChromiumDataObject::clearAll):
(WebCore::ChromiumDataObject::clearAllExceptFiles):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::setData):
(WebCore::ChromiumDataObject::ChromiumDataObject):
* platform/chromium/ChromiumDataObject.h:
(WebCore::ChromiumDataObject::create):
(WebCore::ChromiumDataObject::copy):
(WebCore::ChromiumDataObject::urlTitle):
(WebCore::ChromiumDataObject::setUrlTitle):
(WebCore::ChromiumDataObject::htmlBaseUrl):
(WebCore::ChromiumDataObject::setHtmlBaseUrl):
(WebCore::ChromiumDataObject::containsFilenames):
(WebCore::ChromiumDataObject::filenames):
(WebCore::ChromiumDataObject::setFilenames):
(WebCore::ChromiumDataObject::fileExtension):
(WebCore::ChromiumDataObject::setFileExtension):
(WebCore::ChromiumDataObject::fileContentFilename):
(WebCore::ChromiumDataObject::setFileContentFilename):
(WebCore::ChromiumDataObject::fileContent):
(WebCore::ChromiumDataObject::setFileContent):
* platform/chromium/ClipboardChromium.cpp:
* platform/chromium/ClipboardChromium.h:
2011-03-02 David Grogan <dgrogan@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: fire versionchange events when calling setVersion
https://bugs.webkit.org/show_bug.cgi?id=55095
* dom/EventNames.h:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::onVersionChange):
(WebCore::IDBDatabase::open):
(WebCore::IDBDatabase::enqueueEvent):
(WebCore::IDBDatabase::dispatchEvent):
* storage/IDBDatabase.h:
(WebCore::IDBDatabase::dispatchEvent):
* storage/IDBDatabase.idl:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::databaseCallbacks):
(WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::PendingSetVersionCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::open):
(WebCore::IDBDatabaseBackendImpl::close):
* storage/IDBDatabaseBackendImpl.h:
* storage/IDBDatabaseBackendInterface.h:
* storage/IDBDatabaseCallbacks.h: Copied from Source/WebCore/storage/IDBVersionChangeEvent.cpp.
(WebCore::IDBDatabaseCallbacks::~IDBDatabaseCallbacks):
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
* storage/IDBVersionChangeEvent.cpp:
(WebCore::IDBVersionChangeEvent::create):
(WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
* storage/IDBVersionChangeEvent.h:
* storage/IDBVersionChangeRequest.cpp:
(WebCore::IDBVersionChangeRequest::onBlocked):
2011-03-02 Alexey Proskuryakov <ap@apple.com>
Fix assertion failures on Gtk bot.
* page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks): Removed an overzealous
assertion. We can get here with non-Tab key events when spatial navigation is enabled.
2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80139.
http://trac.webkit.org/changeset/80139
https://bugs.webkit.org/show_bug.cgi?id=55620
failing and crashing tests on Snow Leopard bot (Requested by
mihaip1 on #webkit).
* page/DOMWindow.cpp:
* page/DOMWindow.h:
* page/Frame.cpp:
(WebCore::Frame::pageDestroyed):
(WebCore::Frame::transferChildFrameToNewDocument):
* page/Frame.h:
(WebCore::Frame::detachFromPage):
* page/Geolocation.cpp:
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
* page/Geolocation.h:
* page/GeolocationController.cpp:
(WebCore::GeolocationController::~GeolocationController):
* page/Navigator.cpp:
* page/Navigator.h:
* platform/mock/GeolocationClientMock.cpp:
* platform/mock/GeolocationClientMock.h:
2011-03-02 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435
Add the ability to create a Private Browsing Storage Session.
* WebCore.exp.in:
Export the symbol for ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase.
* page/Settings.cpp:
(WebCore::Settings::setPrivateBrowsingEnabled):
Propagate the private browsing state to the ResourceHandle.
* platform/mac/WebCoreSystemInterface.h:
Add the function declaration for wkCreatePrivateStorageSession.
* platform/mac/WebCoreSystemInterface.mm:
* platform/network/ResourceHandle.cpp:
(WebCore::privateStorageSession):
Since the same Private Browsing Storage Session will need to be accessed throughout the loading
code and will need to be used by all web pages and page groups, make it a global static.
(WebCore::privateBrowsingStorageSessionIdentifierBase):
Ditto, since the identifier is needed to create the Private Browsing Storage Session.
(WebCore::ResourceHandle::setPrivateBrowsingEnabled):
If enabled, create and store the Private Browsing Storage Session.
(WebCore::ResourceHandle::privateBrowsingStorageSession):
(WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase):
* platform/network/ResourceHandle.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
The call to wkCreatePrivateStorageSession needs to be in a file including the correct
version of WKSI.
(WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
Return the bundle identifier.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
The call to wkCreatePrivateStorageSession needs to be in a file importing the correct
version of WKSI.
(WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
Return the bundle identifier.
2011-03-02 Daniel Cheng <dcheng@chromium.org>
Revert frame-specific WebClipboard changes
https://bugs.webkit.org/show_bug.cgi?id=55617
This code is no longer needed since we've decided to use the original
approach to copy/paste drag/drop handling in ClipboardChromium.
No new tests because no functionality changes.
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::createReadable):
* platform/chromium/ChromiumDataObject.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::create):
* platform/chromium/PlatformBridge.h:
* platform/chromium/ReadableDataObject.cpp:
(WebCore::ReadableDataObject::create):
(WebCore::ReadableDataObject::ReadableDataObject):
(WebCore::ReadableDataObject::getData):
(WebCore::ReadableDataObject::urlTitle):
(WebCore::ReadableDataObject::htmlBaseUrl):
(WebCore::ReadableDataObject::filenames):
(WebCore::ReadableDataObject::ensureTypeCacheInitialized):
* platform/chromium/ReadableDataObject.h:
2011-03-02 Tony Chang <tony@chromium.org>
Unreviewed, rolling chromium DEPS to r76362.
https://bugs.webkit.org/show_bug.cgi?id=55564
* WebCore.gyp/WebCore.gyp: Switch to libjpeg_turbo to match chromium
2011-03-02 Alexey Proskuryakov <ap@apple.com>
Build fix.
* page/ChromeClient.h: (WebCore::ChromeClient::keyboardUIMode): I didn't mean to commit these
changes yet.
2011-03-02 Alexey Proskuryakov <ap@apple.com>
Reviewed by John Sullivan.
Clean up WebCore tabsToLinks code a little
https://bugs.webkit.org/show_bug.cgi?id=55606
No change in behavior, so no tests.
* html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isKeyboardFocusable):
This is the only caller of tabsToAllControls(). Renamed this function to tabsToAllFormControls().
* page/EventHandler.cpp:
(WebCore::EventHandler::isKeyboardOptionTab): Moved from platform specific files. This
function cannot be file static, because EventHandlerMac.mm uses it.
(WebCore::eventInvertsTabsToLinksClientCallResult): Merged implementations from platform
specific files. We can just as well have #if here. Renamed for clarity.
(WebCore::EventHandler::tabsToLinks): Rewrote in a way that makes it clearer how "invert"
works.
* page/EventHandler.h: We no longer need invertSenseOfTabsToLinks() here, it's only used
in EventHandler.cpp.
* page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::tabsToAllFormControls):
* page/brew/EventHandlerBrew.cpp: (WebCore::EventHandler::tabsToAllFormControls):
* page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::tabsToAllFormControls):
* page/efl/EventHandlerEfl.cpp: (WebCore::EventHandler::tabsToAllFormControls):
* page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::tabsToAllFormControls):
* page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::tabsToAllFormControls):
* page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToAllFormControls):
* page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::tabsToAllFormControls):
* page/win/EventHandlerWin.cpp: (WebCore::EventHandler::tabsToAllFormControls):
* page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::tabsToAllFormControls):
Updating all port files.
2011-02-28 Jeremy Orlow <jorlow@chromium.org>
Reviewed by James Robinson.
Split IDBCursor.value into IDBCursor.primaryKey and IDBCursor.value
https://bugs.webkit.org/show_bug.cgi?id=55443
Implement http://www.w3.org/Bugs/Public/show_bug.cgi?id=11948
The idea is to have an IDBCursor and an IDBCursorWithValue interface which
inherits from the former. index.openKeyCursor will return the former and
index/objectStore.openCursor will return the latter. We'll add a primaryKey
attribute to IDBCursor. It will always be the key of the associated object
store entry. For index.openCursor cursors, the key attribute will be the key
of the index. For objectStore.openCursors, it'll be the same as the
primaryKey. The value will be the value of the objectStore entry.
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserializeAndSetProperty):
* bindings/v8/SerializedScriptValue.h:
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* storage/IDBAny.cpp:
(WebCore::IDBAny::idbCursorWithValue):
(WebCore::IDBAny::set):
* storage/IDBAny.h:
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::create):
(WebCore::IDBCursor::primaryKey):
(WebCore::IDBCursor::value):
* storage/IDBCursor.h:
* storage/IDBCursor.idl:
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::primaryKey):
(WebCore::IDBCursorBackendImpl::value):
(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::currentRowExists):
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
(WebCore::IDBCursorBackendImpl::deleteFunction):
(WebCore::IDBCursorBackendImpl::loadCurrentRow):
* storage/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
* storage/IDBCursorBackendInterface.h:
* storage/IDBCursorWithValue.cpp: Copied from Source/WebCore/storage/IDBCursor.idl.
(WebCore::IDBCursorWithValue::create):
(WebCore::IDBCursorWithValue::IDBCursorWithValue):
(WebCore::IDBCursorWithValue::~IDBCursorWithValue):
* storage/IDBCursorWithValue.h: Copied from Source/WebCore/storage/IDBCursorBackendInterface.h.
* storage/IDBCursorWithValue.idl: Copied from Source/WebCore/storage/IDBCursor.idl.
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
* storage/IDBIndexBackendImpl.h:
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::openCursor):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::setCursorType):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBRequest.h:
2011-03-02 Aravind Akella <aravind.akella@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt][WK2] Memory exhausted when building qtwebkit2 on linux
https://bugs.webkit.org/show_bug.cgi?id=55484
Using AllInOne files to avoid memory exhaustion for debug
builds on 32 bit linux machines.
No new tests. Fixing a build issue.
* WebCore.pro:
2011-03-02 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* features.pri:
2011-03-02 Dimitri Glazkov <dglazkov@chromium.org>
Update location of media-file.js, which was moved in r79630.
* manual-tests/media-controls.html: Updated location.
2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80156.
http://trac.webkit.org/changeset/80156
https://bugs.webkit.org/show_bug.cgi?id=55604
"Broke SL compile" (Requested by tonyg-cr on #webkit).
* bridge/jni/JNIBridge.h:
(JSC::Bindings::JavaString::operator UString):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
* bridge/jni/jsc/JavaClassJSC.cpp:
(JavaClass::JavaClass):
* bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::uString):
* bridge/jni/v8/JavaStringV8.h:
2011-03-02 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JavaString API should be implementable by both JSC and V8
https://bugs.webkit.org/show_bug.cgi?id=55567
Remove JavaString's UString operator and replace it with a
script-engine-independent impl() method, which returns a
StringImpl and can be implemented with both JSC and V8.
No new tests, refactoring only.
* bridge/jni/JNIBridge.h:
(JSC::Bindings::JavaString::impl):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
* bridge/jni/jsc/JavaClassJSC.cpp:
(JavaClass::JavaClass):
* bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::impl):
* bridge/jni/v8/JavaStringV8.h:
(JSC::Bindings::JavaStringImpl::impl):
2011-03-02 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
Add CRASH() for CSSSelector double frees
https://bugs.webkit.org/show_bug.cgi?id=55596
To help track down bug 53045, add a CRASH call when the CSSSelector
destructor is invoked more than once.
Just a check, no new tests necessary.
* css/CSSSelector.h:
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
2011-03-02 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt <hyatt@apple.com>
content property doesn't support quotes
https://bugs.webkit.org/show_bug.cgi?id=6503
Added full support for quotes as defined by CSS 2.1.
Tests: fast/css/content/content-quotes-01.html
fast/css/content/content-quotes-02.html
fast/css/content/content-quotes-03.html
fast/css/content/content-quotes-04.html
fast/css/content/content-quotes-05.html
fast/css/content/content-quotes-06.html
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseQuotes):
* css/CSSParser.h:
Added needed stylesheet parsing support for quotes,
(no-)open-quote and (no-)close-quote
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Handled setting of the new quotes RenderStyle property and added
handling of quotes for the content property.
* css/html.css:
(q:before):
(q:after):
replaced the '"' workaround with open/close-quote
* rendering/RenderBlockLineLayout.cpp:
(WebCore::dirtyLineBoxesForRenderer):
Made RenderQuote behave like RenderCounter.
Needed to ensure that the Quote text is calculated before layout,
just as it is for RenderCounter.
* rendering/RenderObject.h:
(WebCore::RenderObject::isQuote):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Handled updating of quote depth when renderers are added and removed
from the tree.
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
Added support for Quote content.
* rendering/RenderQuote.cpp: Added.
(WebCore::adjustDepth):
(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::renderName):
(WebCore::RenderQuote::placeQuote):
(WebCore::LanguageData::operator<):
(WebCore::defaultLanguageQuotes):
(WebCore::quotesMap):
(WebCore::quotesForLanguage):
(WebCore::defaultQuotes):
(WebCore::RenderQuote::originalText):
(WebCore::RenderQuote::computePreferredLogicalWidths):
(WebCore::RenderQuote::rendererSubtreeAttached):
(WebCore::RenderQuote::rendererRemovedFromTree):
(WebCore::RenderQuote::styleDidChange):
* rendering/RenderQuote.h: Added.
(WebCore::RenderQuote::isQuote):
(WebCore::toRenderQuote):
* rendering/RenderingAllInOne.cpp:
Included RenderQuote.cpp
* rendering/style/StyleAllInOne.cpp:
Included QuotesData.cpp
* rendering/style/ContentData.cpp:
(WebCore::ContentData::dataEquivalent):
Checked for quotetype identity.
(WebCore::ContentData::deleteContent):
Accounted for the new QUOTE_TYPE.
* rendering/style/ContentData.h:
(WebCore::ContentData::isQuote):
(WebCore::ContentData::quote):
(WebCore::ContentData::setQuote):
* rendering/style/QuotesData.cpp: Added.
(WebCore::QuotesData::create):
(WebCore::QuotesData::operator==):
(WebCore::QuotesData::~QuotesData):
* rendering/style/QuotesData.h: Added.
(WebCore::QuotesData::data):
(WebCore::QuotesData::operator delete):
(WebCore::QuotesData::QuotesData):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setContent):
(WebCore::RenderStyle::setQuotes):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::quotes):
(WebCore::InheritedFlags::setQuotes):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleAllInOne.cpp:
Added QuotesData.cpp to the included files list.
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::operator==):
Included quotes in equality check.
* rendering/style/StyleRareInheritedData.h:
Added quotes
2011-03-02 Antti Koivisto <antti@apple.com>
Reviewed by Dave Hyatt.
Selector usage flags should not be set by the CSS parser
https://bugs.webkit.org/show_bug.cgi?id=55573
Currently flags like Document::usesSiblingRules() are set directly by the CSS parser. This is wrong as
we may parse stylesheets that are not actually used for document rendering. This is especially bad when
the page uses querySelectorAll(). As a result we may end up in various performance penalty boxes
triggered by complex selectors for no good reason.
- Use the selector traversal in style selector constructor to figure out which flags
are actually needed for the currently active style sheets.
- Remove the selector flag related code from the CSS parser/grammar.
- Remove the usesDescendantRules flag completely. We have descendant rules in the default
style sheet, every document uses them.
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::updateSpecifiersWithElementName):
* css/CSSStyleSelector.cpp:
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::Features::Features):
(WebCore::CSSStyleSelector::Features::~Features):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::collectFeaturesFromSelector):
(WebCore::collectFeaturesFromList):
(WebCore::RuleSet::collectFeatures):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::usesSiblingRules):
(WebCore::CSSStyleSelector::usesFirstLineRules):
(WebCore::CSSStyleSelector::usesBeforeAfterRules):
(WebCore::CSSStyleSelector::usesLinkRules):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):
* dom/Document.h:
(WebCore::Document::usesSiblingRules):
(WebCore::Document::setUsesSiblingRules):
(WebCore::Document::usesFirstLineRules):
(WebCore::Document::usesBeforeAfterRules):
(WebCore::Document::setUsesBeforeAfterRules):
* dom/Element.cpp:
(WebCore::Element::recalcStyle):
2011-03-02 Brian Weinstein <bweinstein@apple.com>
Fix fallout from a last minute renaming.
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):
2011-03-01 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>
Add functions on CookieStorage that allow listening for changes in cookies. When
the cookies are changed, they call through to CookiesStrategy::notifyCookiesChanged.
No change in behavior requiring tests.
* platform/CookiesStrategy.h: Added.
(WebCore::CookiesStrategy::~CookiesStrategy):
* platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::cookiesStrategy):
(WebCore::PlatformStrategies::PlatformStrategies):
* platform/network/CookieStorage.h: Add new function declarations.
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::notifyCookiesChangedOnMainThread): Call through to CookiesStrategy::notifyCookiesChanged.
(WebCore::notifyCookiesChanged): Call notifyCookiesChangedOnMainThread on the main thread.
(WebCore::beginObservingCookieChanges): Set up cookie observers on the loader run loop.
(WebCore::finishObservingCookieChanges): Remove our cookie observers from the loader run loop.
* platform/network/mac/CookieStorageMac.mm:
(-[CookieStorageObjCAdapter notifyCookiesChangedOnMainThread]): Call through to CookiesStrategy::notifyCookiesChanged.
(-[CookieStorageObjCAdapter cookiesChangedNotificationHandler:]): Call notifyCookiesChangedOnMainThread on
the main thread.
(-[CookieStorageObjCAdapter registerForCookieChangeNotifications]): Set up the observer for cookie change notifications.
(-[CookieStorageObjCAdapter unregisterForCookieChangeNotifications]): Remove the observer for cookie change notifications.
(WebCore::beginObservingCookieChanges): Create our CookieStorageObjCAdapter, and call registerForCookieChangeNotifications.
(WebCore::finishObservingCookieChanges): Call unregisterForCookieChangeNotifications.
Add new file.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj: Set role on files we need to include in WebKit to private.
2011-03-02 Sergey Glazunov <serg.glazunov@gmail.com>
Reviewed by Dimitri Glazkov.
A WebKitCSSKeyframesRule object should set itself as the parent for inserted rules
https://bugs.webkit.org/show_bug.cgi?id=55488
Test: fast/css/css-keyframe-parent.html
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::append):
2011-03-02 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add support for external protocol handlers
https://bugs.webkit.org/show_bug.cgi?id=55473
Do not unconditionally create and replace the SoupRequester of the
SoupSession if there is already one. No new tests needed as we
just allow clients to create their our SoupRequesters.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ensureSessionIsInitialized):
2011-03-02 John Knottenbelt <jknotten@chromium.org>
Reviewed by jknotten@chromium.org.
Fix build-breakage when GEOLOCATION not enabled.
https://bugs.webkit.org/show_bug.cgi?id=55586
Geolocation::reset needs to be defined if ENABLE(GEOLOCATION)
is not true.
* page/Geolocation.cpp:
(WebCore::Geolocation::reset):
2011-03-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: remove InjectedScriptHost -> DOMAgent dependency.
https://bugs.webkit.org/show_bug.cgi?id=55575
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::inspectedNode):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::inspectedNodeCallback):
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluateOn):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapNode):
(WebCore::InjectedScript::inspectNode):
(WebCore::InjectedScript::nodeAsScriptValue):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::addInspectedNode):
(WebCore::InjectedScriptHost::clearInspectedNodes):
(WebCore::InjectedScriptHost::copyText):
(WebCore::InjectedScriptHost::inspectedNode):
* inspector/InjectedScriptHost.h:
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
* inspector/Inspector.idl:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::addInspectedNode):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::injectedScriptForNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluateOn):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
* inspector/front-end/PropertiesSidebarPane.js:
(WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
(WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
(WebInspector.PropertiesSidebarPane.prototype.update.fillSection):
(WebInspector.PropertiesSidebarPane.prototype.update):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.resolveNode):
(WebInspector.RemoteObject.prototype.pushNodeToFrontend):
(WebInspector.RemoteObject.prototype.evaluate):
2011-01-21 John Knottenbelt <jknotten@chromium.org>
Reviewed by Dmitry Titov.
Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877
On Page destruction, any outstanding Geolocation permission
requests should be cancelled, because the Geolocation can only
access the client indirectly via m_frame->page().
Additionally, if the Frame is reparented to another page, the
Geolocation should cancel watches, single-shots and requests on
the old page.
Page destruction is signalled by a call to the
Frame::pageDestroyed() method. This calls Frame::detachFromPage,
where we extend the call chain to Geolocation::detachFromPage()
where we call Geolocation::reset() which detaches from the
GeolocationController, cancels requests, watches and single shots,
and sets the permission state back to Unknown.
We also now call detachFromPage when the frame reparented in
Frame::transferChildFrameToNewDocument.
Frame::pageDestroyed() is also called by FrameLoader even though
the page is not destroyed. We should still cancel permission
requests, because the GeolocationClient will become inaccessible
to the Geolocation object after this call.
Since GeolocationController is owned by Page, and all Geolocation
objects will now unsubscribe from the GeolocationController on
pageDetached(), we no longer need to call stopUpdating() from the
GeolocationController's destructor. Instead we can simply assert
that there should be no no observers. See related bug
https://bugs.webkit.org/show_bug.cgi?id=52216 .
Introduced new method 'numberOfPendingPermissionRequests' on
GeolocationClientMock to count the number of outstanding pending
permission requests. This provides a reusable implementation for
client-based implementations of the LayoutTestController's
numberOfPendingGeolocationPermissionRequests method.
Tests: fast/dom/Geolocation/iframe-reparent.html
fast/dom/Geolocation/page-reload-cancel-permission-requests.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::resetGeolocationPermissions):
* page/DOMWindow.h:
* page/Frame.cpp:
(WebCore::Frame::detachFromPage):
(WebCore::Frame::pageDestroyed):
(WebCore::Frame::transferChildFrameToNewDocument):
* page/Frame.h:
* page/Geolocation.cpp:
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::page):
(WebCore::Geolocation::reset):
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
* page/Geolocation.h:
* page/GeolocationController.cpp:
(WebCore::GeolocationController::~GeolocationController):
* page/Navigator.cpp:
(WebCore::Navigator::resetGeolocationPermissions):
* page/Navigator.h:
* platform/mock/GeolocationClientMock.cpp:
(WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
* platform/mock/GeolocationClientMock.h:
2011-03-02 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Landing detailed heap snapshots, part 4.
https://bugs.webkit.org/show_bug.cgi?id=55563
This part adds implementations for data grids used to display
different heap snapshots projections. We are almost done.
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* bindings/v8/ScriptHeapSnapshot.cpp:
(WebCore::ScriptHeapSnapshot::getExactRetainedSize):
* bindings/v8/ScriptHeapSnapshot.h:
* inspector/Inspector.idl:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
* inspector/InspectorProfilerAgent.h:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
(WebInspector.HeapSnapshotDominatorObjectNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
(MixInSnapshotNodeFunctions):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotRetainingPathsList):
(WebInspector.DetailedHeapshotView.profileCallback):
(WebInspector.DetailedHeapshotView):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotEdge.prototype.get isInvisible):
(WebInspector.HeapSnapshotEdge.prototype.toString):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes):
(WebInspector.HeapSnapshot.prototype._markInvisibleEdges):
(WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):
* inspector/front-end/Images/helpButtonGlyph.png: Added.
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.reset):
* inspector/front-end/Popover.js:
(WebInspector.Popover):
(WebInspector.Popover.prototype.show):
(WebInspector.Popover.prototype.hide):
(WebInspector.Popover.prototype.get visible):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype.getProfile):
* inspector/front-end/heapProfiler.css:
* inspector/front-end/inspector.js:
(WebInspector.resetFocusElement):
2011-03-02 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/55534> Clean up macros in Extensions3DOpenGL.cpp
Reviewed by Darin Adler.
Change "#if GL_APPLE_vertex_array_object" macros to check that
GL_APPLE_vertex_array_object is both defined and non-zero.
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES): Remove
empty #else clause.
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES): Add early
return check. Remove #else clause that would never have
compiled (since array is not a WTF::String).
2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Assertion failure after removing a selection in keydown handler
https://bugs.webkit.org/show_bug.cgi?id=51389
The bug was caused by textWillBeReplaced's not always updating selection, and
shouldRemovePositionAfterAdoptingTextReplacement's not moving the end offset when it's
at the end of replaced data.
Fixed the bug by always updating selection in textWillBeReplaced and fixing the condition
to move the offset in shouldRemovePositionAfterAdoptingTextReplacement. Also added a call
to setSelection instead of directly modifying m_selection to notify all the clients.
Namely, the call to EditorClient::respondToChangedSelection is required for
setting-input-value-cancel-ime-composition.html.
Note that we must update layout before calling setSelection because setSelection calls
setFocusedNodeIfNeeded and it requires layout to be up-to-date. Without this call, tests
such as fast/forms/input-appearance-maxlength.html hits an assertion in Node::isFocusable.
Test: editing/input/setting-input-value-cancel-ime-composition.html
* editing/SelectionController.cpp:
(WebCore::shouldRemovePositionAfterAdoptingTextReplacement): When replacing text, the offset
of the selection end must be updated even if it was at the end of the replaced text.
e.g. removing "world" from "hello world] WebKit" should result in "hello ] WebKit" not
"hello WebK[it". Note we don't move the offset if no text is removed because appending
"world" to "hello ]" should result in "hello ]world" not "hello world]".
(WebCore::SelectionController::textWillBeReplaced): Calls setSelection to update
the selection instead of modifying m_selection directly.
2011-03-02 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: highlighted line does not span horizonally in scripts panel while debugging.
https://bugs.webkit.org/show_bug.cgi?id=54675
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._syncScroll):
(WebInspector.TextEditorChunkedPanel.prototype._buildChunks):
(WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
(WebInspector.TextEditorGutterPanel):
(WebInspector.TextEditorGutterPanel.prototype._expandChunks):
(WebInspector.TextEditorGutterPanel.prototype.textChanged):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.set readOnly):
(WebInspector.TextEditorMainPanel.prototype._getSelection):
(WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
(WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
* inspector/front-end/textViewer.css:
(.inner-container):
2011-03-02 Oleg Romashin <romaxa@gmail.com>
Reviewed by Andreas Kling.
Fixing inspector compilation with JAVASCRIPT_DEBUGGER disabled
https://bugs.webkit.org/show_bug.cgi?id=55477
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::populateScriptObjects):
2011-03-02 Kent Tamura <tkent@chromium.org>
Unreviewed, a trivial fix for r80096.
REGRESSION (r80096): [Chromium] fast/forms/input-number-unacceptable-style.html failure
https://bugs.webkit.org/show_bug.cgi?id=55562
* platform/text/LocalizedNumberICU.cpp:
(WebCore::parseLocalizedNumber): Check the ParsePosition after NumberFormat::parse()
to reject strings with a valid number + extra letters.
2011-03-02 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JObjectWrapper should be moved to its own file
https://bugs.webkit.org/show_bug.cgi?id=55384
No new tests, refactoring only.
* Android.v8bindings.mk:
* WebCore.gypi:
* bridge/jni/v8/JNIBridgeV8.cpp:
(JavaField::JavaField):
* bridge/jni/v8/JNIBridgeV8.h:
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::JavaInstance):
* bridge/jni/v8/JavaInstanceV8.h:
* bridge/jni/v8/JobjectWrapper.cpp: Copied from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
(JobjectWrapper::JobjectWrapper):
(JobjectWrapper::~JobjectWrapper):
* bridge/jni/v8/JobjectWrapper.h: Copied from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
(JSC::Bindings::JobjectWrapper::instance):
(JSC::Bindings::JobjectWrapper::setInstance):
(JSC::Bindings::JobjectWrapper::ref):
(JSC::Bindings::JobjectWrapper::deref):
2011-02-25 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: factor search logic out of inspector.js
https://bugs.webkit.org/show_bug.cgi?id=54965
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.searchCanceled):
(WebInspector.ElementsPanel.prototype.switchToAndFocus):
(WebInspector.ElementsPanel.prototype._updateMatchesCount):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.searchCanceled):
(WebInspector.Panel.prototype.performSearch.updateMatchesCount):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.searchCanceled):
(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
* inspector/front-end/SearchController.js: Added.
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.updateSearchMatchesCount):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.cancelSearch):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
(WebInspector.SearchController.prototype.activePanelChanged):
(WebInspector.SearchController.prototype._updateSearchMatchesCount):
(WebInspector.SearchController.prototype._focusSearchField):
(WebInspector.SearchController.prototype._onSearchFieldManualFocus):
(WebInspector.SearchController.prototype._onKeyDown):
(WebInspector.SearchController.prototype._onSearch):
(WebInspector.SearchController.prototype._performSearch):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.set currentPanel):
(WebInspector.set attached):
(WebInspector.doLoadedDone):
(WebInspector.documentKeyDown):
2011-03-02 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
FEMorphologyElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=55462
When the FEMorphologyElement receives an update message but the given value remains the same we don't need
to relayout the filter.
No new tests are needed because this modification is covered by the dynamic update tests of FEMorphology.
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::setMorphologyOperator):
(WebCore::FEMorphology::setRadiusX):
(WebCore::FEMorphology::setRadiusY):
* platform/graphics/filters/FEMorphology.h:
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):
(WebCore::SVGFEMorphologyElement::svgAttributeChanged):
* svg/SVGFEMorphologyElement.h:
2011-03-01 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Assertion fails when a form validation bubble appears
https://bugs.webkit.org/show_bug.cgi?id=55550
Test: fast/forms/interactive-validation-attach-assertion.html
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
Just remove unnecessary attach().
2011-03-01 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Support localized numbers in <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=42484
This change adds support of localized numbers in <input type=number>.
This affects only the UI, and not HTMLInputElement::value.
- Remove the keyboard input restriction feature because it is hard to
retrieve characters usable for localized numbers in ICU.
- Separate convertFromVisibleValue() from sanitizeValue().
sanitizeValue() is used for not only converting a renderer value to a
DOM value.
- Implement LocalizedNumber functions for ICU and NSNumberFormatter.
It is used only in Chromium for now.
Test: manual-tests/input-number-localization.html
* WebCore.gypi: Use LocalizedNumberICU.cpp.
* WebCore.xcodeproj/project.pbxproj:
Add LocalizedNumberMac.mm and remove LocalizedNumberNone.cpp.
* dom/InputElement.h: Introduce convertFromVisibleValue().
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::convertFromVisibleValue):
* html/HTMLInputElement.h:
* html/InputType.cpp:
(WebCore::InputType::convertFromVisibleValue):
* html/InputType.h:
* html/NumberInputType.cpp: Remove isHTMLNumberCharacter(),
isNumberCharacter(), and handleBeforeTextInsertedEvent() because we
remove the keyboard input restriction feature for type=number.
(WebCore::NumberInputType::convertFromVisibleValue):
(WebCore::NumberInputType::sanitizeValue):
* html/NumberInputType.h:
* manual-tests/input-number-localization.html: Add a manual test because
the behavior depends on the current locale.
* platform/text/LocalizedNumber.h: Remove isLocalizedNumberCharacter().
* platform/text/LocalizedNumberICU.cpp:
Implement LocalizedNumber functions with ICU NumberFormat.
(WebCore::createFormatterForCurrentLocale):
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
* platform/text/LocalizedNumberNone.cpp: Remove isLocalizedNumberCharacter().
* platform/text/mac/LocalizedNumberMac.mm:
Implement LocalizedNumber functions with NSNumberFormatter.
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::subtreeHasChanged):
* wml/WMLInputElement.h:
(WebCore::WMLInputElement::convertFromVisibleValue):
Implemented as a function doing nothing.
2011-03-01 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r78383): Failure to connect on websocketstest.com
https://bugs.webkit.org/show_bug.cgi?id=54811
After r78383, KURL::setPort() no longer appends ":port" part
if that port is the default port for URL scheme. This broke
SocketStreamHandleCFNet, whose code was based on an assumption
that KURL::setPort() always inserts ":port" part.
To fix this, KURL::port() call is removed from SocketStreamHandle
and the port number is calculated on-the-fly.
Unfortunately it is impossible to write a test; this bug only
affects WebSockets connecting to the default port (port 80
for ws, port 443 for wss), while we use different ports to test
WebSockets in LayoutTests.
* platform/network/cf/SocketStreamHandle.h:
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::createStreams):
(WebCore::SocketStreamHandle::port):
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547
"Broke the Win debug build?" (Requested by dcheng on #webkit).
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* features.pri:
2011-02-25 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Abstract "pixels with a graphics context" into its own class
https://bugs.webkit.org/show_bug.cgi?id=55259
This creates new PlatformCanvas/PlatformImage classes which wrap
all of the #ifdef Skia/Cg warts from the compositor. All classes
(LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
modified to use these abstractions.
Tests: LayoutTests/compositing
* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::updateContentsIfDirty):
(WebCore::ContentLayerChromium::resizeUploadBuffer):
(WebCore::ContentLayerChromium::updateTextureIfNeeded):
(WebCore::ContentLayerChromium::updateTexture):
(WebCore::ContentLayerChromium::draw):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContentsIfDirty):
(WebCore::ImageLayerChromium::updateTextureIfNeeded):
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::update):
(WebCore::LayerTilerChromium::updateFromPixels):
* platform/graphics/chromium/LayerTilerChromium.h:
* platform/graphics/chromium/PlatformCanvas.cpp: Added.
(WebCore::PlatformCanvas::PlatformCanvas):
(WebCore::PlatformCanvas::~PlatformCanvas):
(WebCore::PlatformCanvas::resize):
(WebCore::PlatformCanvas::AutoLocker::AutoLocker):
(WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
(WebCore::PlatformCanvas::Painter::Painter):
(WebCore::PlatformCanvas::Painter::~Painter):
* platform/graphics/chromium/PlatformCanvas.h: Added.
(WebCore::PlatformCanvas::AutoLocker::pixels):
(WebCore::PlatformCanvas::Painter::context):
(WebCore::PlatformCanvas::size):
* platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp.
(WebCore::PlatformImage::PlatformImage):
(WebCore::PlatformImage::updateFromImage):
* platform/graphics/chromium/PlatformImage.h: Added.
(WebCore::PlatformImage::pixels):
(WebCore::PlatformImage::size):
2011-03-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* features.pri:
2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
(WebCore::numericPrefix):
(WebCore::findSizeValue):
(WebCore::setViewportFeature):
(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessageLevel):
* dom/ViewportArguments.h:
2011-03-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by James Robinson.
IDBKeyRange.bound() should not use the optional options object
https://bugs.webkit.org/show_bug.cgi?id=55419
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#range-concept
Added some code to existing tests to cover these cases.
* storage/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::bound):
* storage/IDBKeyRange.h:
* storage/IDBKeyRange.idl:
2011-03-01 Dan Bernstein <mitz@apple.com>
Build fix.
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
2011-03-01 Kent Tamura <tkent@chromium.org>
Unreviewed. Apply sort-Xcode-project-file.
* WebCore.xcodeproj/project.pbxproj:
2011-03-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by James Robinson.
V8 code generator doesn't properly support a single SerializedScriptValue attribute
https://bugs.webkit.org/show_bug.cgi?id=55530
This is tested by the bindings tests changes.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp: Added.
(WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterfacePrivate::WebDOMTestSerializedScriptValueInterfacePrivate):
(WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterface):
(WebDOMTestSerializedScriptValueInterface::operator=):
(WebDOMTestSerializedScriptValueInterface::impl):
(WebDOMTestSerializedScriptValueInterface::~WebDOMTestSerializedScriptValueInterface):
(WebDOMTestSerializedScriptValueInterface::value):
(toWebCore):
(toWebKit):
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: Added.
(WebKit::kit):
(webkit_dom_test_serialized_script_value_interface_get_value):
(WebKit::core):
(webkit_dom_test_serialized_script_value_interface_finalize):
(webkit_dom_test_serialized_script_value_interface_set_property):
(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_constructed):
(webkit_dom_test_serialized_script_value_interface_class_init):
(webkit_dom_test_serialized_script_value_interface_init):
(WebKit::wrapTestSerializedScriptValueInterface):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h: Added.
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
(WebCore::JSTestInterface::JSTestInterface):
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::JSTestObjConstructor):
(WebCore::JSTestObj::JSTestObj):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Added.
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::self):
(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterface::createPrototype):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):
(WebCore::jsTestSerializedScriptValueInterfaceValue):
(WebCore::jsTestSerializedScriptValueInterfaceConstructor):
(WebCore::JSTestSerializedScriptValueInterface::getConstructor):
(WebCore::toJS):
(WebCore::toTestSerializedScriptValueInterface):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Copied from Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h.
(WebCore::JSTestSerializedScriptValueInterface::createStructure):
(WebCore::JSTestSerializedScriptValueInterface::impl):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h: Added.
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm: Added.
(-[DOMTestSerializedScriptValueInterface dealloc]):
(-[DOMTestSerializedScriptValueInterface finalize]):
(-[DOMTestSerializedScriptValueInterface value]):
(core):
(kit):
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h: Added.
* bindings/scripts/test/TestSerializedScriptValueInterface.idl: Added.
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Copied from Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp.
(WebCore::TestSerializedScriptValueInterfaceInternal::V8_USE):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
(WebCore::V8TestSerializedScriptValueInterface::derefObject):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Added.
(WebCore::V8TestSerializedScriptValueInterface::toNative):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):
2011-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Joseph Pecoraro.
Misaligned memory access in CloneDeserializer on all ARM arch.
https://bugs.webkit.org/show_bug.cgi?id=48742
Push platforms that need aligned memory access down the
endian independent serialization and deserialization
paths.
* bindings/js/SerializedScriptValue.cpp:
2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707
Correct and improve the error messages for viewport
parsing. Clarify the difference between incorrect
keys, values, and when to use the device-width or
device-height constants.
* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes): suggest using keywords if fixed input matches device width or height.
(WebCore::numericPrefix):
(WebCore::findSizeValue): remove incorrect warnings about fixed numbers because we don't know the device width or height.
(WebCore::setViewportFeature): report a warning for an unrecognized key.
(WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
(WebCore::viewportErrorMessageLevel):
* dom/ViewportArguments.h:
2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
WebKit does not merge text decorations in the typing style and the selected element properly
https://bugs.webkit.org/show_bug.cgi?id=55349
The bug was caused by EditingStyle::mergeTypingStyle's not properly merging text decoration property.
Fixed the bug by extracting a function from ApplyStyleCommand::pushDownInlineStyleAroundNode and
calling it in pushDownInlineStyleAroundNode and in mergeTypingStyle.
Test: editing/execCommand/merge-text-decoration-with-typing-style.html
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Takes EditingStyle*;
calls mergeInlineStyleOfElement.
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls applyInlineStyleToPushDown.
(WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
* editing/ApplyStyleCommand.h:
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::mergeTypingStyle): Added; calls mergeStyle.
(WebCore::EditingStyle::mergeInlineStyleOfElement): Ditto.
(WebCore::EditingStyle::mergeStyle): Extracted from applyInlineStyleToPushDown.
* editing/EditingStyle.h:
2011-03-01 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919
Changing VisiblePosition completely away from legacy positions.
No new tests since this is functionaly equivalent.
* WebCore.exp.in: Removing the legacy VisiblePosition constructor and
adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions
outside of WebCore, they should be parent anchored.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::visiblePositionForTextMarkerData):
* accessibility/AccessibilityObject.cpp:
(WebCore::startOfStyleRange):
(WebCore::endOfStyleRange):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForIndex):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(objectAndOffsetUnignored):
* dom/Position.cpp:
(WebCore::Position::document): Added this inline function to avoid the necessity
of calling anchorNode to assure a document from a Position.
(WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor
(WebCore::Position::downstream): ditto
* dom/Range.cpp:
(WebCore::Range::editingStartPosition):
* editing/Editor.cpp:
(WebCore::Editor::canDeleteRange):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
* editing/SelectionController.cpp:
(WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
(WebCore::SelectionController::setSelectedRange):
* editing/TextIterator.cpp:
(WebCore::TextIterator::shouldRepresentNodeOffsetZero):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed):
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
(WebCore::VisiblePosition::canonicalPosition):
(WebCore::VisiblePosition::characterAfter):
(WebCore::VisiblePosition::localCaretRect):
(WebCore::makeRange):
(WebCore::startVisiblePosition):
(WebCore::endVisiblePosition):
(WebCore::setStart):
(WebCore::setEnd):
(WebCore::isFirstVisiblePositionInNode):
(WebCore::isLastVisiblePositionInNode):
* editing/VisiblePosition.h:
(WebCore::VisiblePosition::VisiblePosition):
* editing/htmlediting.cpp:
(WebCore::firstInSpecialElement):
(WebCore::lastInSpecialElement):
(WebCore::visiblePositionBeforeNode):
(WebCore::visiblePositionAfterNode):
* editing/visible_units.cpp:
(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
(WebCore::endOfBlock):
(WebCore::startOfDocument):
(WebCore::endOfDocument):
(WebCore::logicalStartPositionForLine):
(WebCore::logicalEndPositionForLine):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::collapse):
(WebCore::DOMSelection::setBaseAndExtent):
(WebCore::DOMSelection::setPosition):
(WebCore::DOMSelection::extend):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createVisiblePosition):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::visiblePositionForIndex):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::selectSubString):
2011-03-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
https://bugs.webkit.org/show_bug.cgi?id=54785
This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
the right thing and continue to do the right thing. It also modifies EventQueue
so that we can cancel an event. To do this efficiently, the vector is now a
ListHashSet.
Cancelling the event is harder/messier, but the most deterministic thing to do.
To the user, the work isn't done until we fire the onsuccess/onerror handler.
So the event (which does fire that) needs to be cancelable.
transaction-abort.html tests this.
* dom/EventQueue.cpp:
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::cancelEvent):
(WebCore::EventQueue::pendingEventTimerFired):
(WebCore::EventQueue::dispatchEvent):
* dom/EventQueue.h:
* dom/ExceptionCode.cpp:
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::deleteFunction):
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::close):
* storage/IDBDatabaseException.h:
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::openCursor):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::~IDBRequest):
(WebCore::IDBRequest::readyState):
(WebCore::IDBRequest::markEarlyDeath):
(WebCore::IDBRequest::source):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):
* storage/IDBRequest.h:
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::registerRequest):
(WebCore::IDBTransaction::unregisterRequest):
(WebCore::IDBTransaction::onAbort):
* storage/IDBTransaction.h:
2011-03-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Mihai Parparita.
EventQueue needs to be ref counted
https://bugs.webkit.org/show_bug.cgi?id=55512
EventQueue needs to be ref counted because it's possible for its instance
to be deleted while it's dispatching events. This is the reason why
https://bugs.webkit.org/show_bug.cgi?id=54785 had to be reverted.
No change of behavior, so no tests.
* dom/Document.h:
* dom/EventQueue.cpp:
(WebCore::EventQueue::create):
* dom/EventQueue.h:
2011-03-01 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
No shadow when stroking a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=55436
This happens in CG and is related to bug 52509, this time to be fixed
in GraphicsContext::strokePath(). The gradient needs to be drawn
clipped to the stroke on a CGLayer first, then the layer drawn on the
GraphicsContext.
Tests: fast/canvas/canvas-strokePath-gradient-shadow.html
svg/css/path-gradient-stroke-shadow.svg
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::strokePath):
2011-03-01 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
Fix Font::spaceWidth() to be a float instead of an int.
* platform/graphics/Font.h:
(WebCore::Font::spaceWidth):
2011-02-28 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Chromium gypi file should include Java bridge files from WebCore/bridge
https://bugs.webkit.org/show_bug.cgi?id=55387
No new tests, no code changes.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
2011-03-01 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
[Web Timing] Handle the case where no responseEnd time is available.
https://bugs.webkit.org/show_bug.cgi?id=55444
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader): Initialize to 0.
(WebCore::MainResourceLoader::didFinishLoading): Fall back to current time if no other time is available.
2011-03-01 Patrick Gansterer <paroga@webkit.org>
Unreviewed, adding missing change for r80034.
Add a handler class for Win32 HANDLE
https://bugs.webkit.org/show_bug.cgi?id=55334
* platform/win/Win32Handle.h: Added missing WTF_MAKE_NONCOPYABLE macro.
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80037.
http://trac.webkit.org/changeset/80037
https://bugs.webkit.org/show_bug.cgi?id=55508
broke compile on SL (Requested by tonyg-cr on #webkit).
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSParser.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/html.css:
(q:before):
(q:after):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::dirtyLineBoxesForRenderer):
* rendering/RenderObject.h:
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
* rendering/RenderQuote.cpp: Removed.
* rendering/RenderQuote.h: Removed.
* rendering/RenderingAllInOne.cpp:
* rendering/style/ContentData.cpp:
(WebCore::ContentData::dataEquivalent):
(WebCore::ContentData::deleteContent):
* rendering/style/ContentData.h:
* rendering/style/QuotesData.cpp: Removed.
* rendering/style/QuotesData.h: Removed.
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleAllInOne.cpp:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
2011-03-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Paint outline for tables.
https://bugs.webkit.org/show_bug.cgi?id=55474
Test: fast/table/table-and-parts-outline.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80028.
http://trac.webkit.org/changeset/80028
https://bugs.webkit.org/show_bug.cgi?id=55502
'caused crashes; rolling out while investigating' (Requested
by jorlow on #webkit).
* dom/EventQueue.cpp:
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::pendingEventTimerFired):
(WebCore::EventQueue::dispatchEvent):
* dom/EventQueue.h:
* dom/ExceptionCode.cpp:
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::deleteFunction):
* storage/IDBDatabaseException.h:
* storage/IDBDatabaseException.idl:
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::openCursor):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::~IDBRequest):
(WebCore::IDBRequest::readyState):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):
(WebCore::IDBRequest::source):
* storage/IDBRequest.h:
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
* storage/IDBTransaction.h:
2011-03-01 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt <hyatt@apple.com>
content property doesn't support quotes
https://bugs.webkit.org/show_bug.cgi?id=6503
Added full support for quotes as defined by CSS 2.1.
Tests: fast/css/content/content-quotes-01.html
fast/css/content/content-quotes-02.html
fast/css/content/content-quotes-03.html
fast/css/content/content-quotes-04.html
fast/css/content/content-quotes-05.html
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseQuotes):
* css/CSSParser.h:
Added needed stylesheet parsing support for quotes,
(no-)open-quote and (no-)close-quote
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Handled setting of the new quotes RenderStyle property and added
handling of quotes for the content property.
* css/html.css:
(q:before):
(q:after):
replaced the '"' workaround with open/close-quote
* rendering/RenderBlockLineLayout.cpp:
(WebCore::dirtyLineBoxesForRenderer):
Made RenderQuote behave like RenderCounter.
Needed to ensure that the Quote text is calculated before layout,
just as it is for RenderCounter.
* rendering/RenderObject.h:
(WebCore::RenderObject::isQuote):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Handled updating of quote depth when renderers are added and removed
from the tree.
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
* rendering/RenderQuote.cpp: Added.
(WebCore::adjustDepth):
(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::renderName):
(WebCore::RenderQuote::placeQuote):
(WebCore::RenderQuote::originalText):
(WebCore::RenderQuote::computePreferredLogicalWidths):
(WebCore::RenderQuote::rendererSubtreeAttached):
(WebCore::RenderQuote::rendererRemovedFromTree):
(WebCore::RenderQuote::styleDidChange):
* rendering/RenderQuote.h: Added.
(WebCore::RenderQuote::isQuote):
(WebCore::toRenderQuote):
* rendering/RenderingAllInOne.cpp:
Included RenderQuote.cpp
* rendering/style/StyleAllInOne.cpp:
Included QuotesData.cpp
* rendering/style/ContentData.cpp:
(WebCore::ContentData::dataEquivalent):
Checked for quotetype identity.
(WebCore::ContentData::deleteContent):
Accounted for the new QUOTE_TYPE.
* rendering/style/ContentData.h:
(WebCore::ContentData::isQuote):
(WebCore::ContentData::quote):
(WebCore::ContentData::setQuote):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setContent):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::quotes):
(WebCore::InheritedFlags::setQuotes):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::operator==):
Included quotes in equality check.
* rendering/style/StyleRareInheritedData.h:
Added quotes
2011-03-01 Michael Nordman <michaeln@google.com>
Reviewed by Alexey Proskuryakov.
Alter the relative priorities of network vs fallback namespaces in the appcache.
If a resource url is in an appcache's network namespace and fallback namespace, the network
namespace wins (with the exception of the special '*' network namespace which does not take
priority over the fallback namespace.
https://bugs.webkit.org/show_bug.cgi?id=49292
Test: http/tests/appcache/online-fallback-layering.html
* loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::isURLInOnlineWhitelist):
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache):
(WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource):
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
2011-03-01 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
Add a handler class for Win32 HANDLE
https://bugs.webkit.org/show_bug.cgi?id=55334
This class will call CloseHandle in the destructor for valid handles.
* platform/win/Win32Handle.h: Added.
2011-03-01 Eric Carlson <eric.carlson@apple.com>
Reviewed by Chris Marrin.
<audio> and <video> should respect private browsing mode
https://bugs.webkit.org/show_bug.cgi?id=55287
<rdar://problem/9057699>
No new tests, this is just the plumbing.
* dom/Document.cpp:
(WebCore::Document::privateBrowsingStateDidChange): New.
(WebCore::Document::registerForPrivateBrowsingStateChangedCallbacks): Ditto.
(WebCore::Document::unregisterForPrivateBrowsingStateChangedCallbacks): Ditto.
* dom/Document.h:
* dom/Element.h:
(WebCore::Element::privateBrowsingStateDidChange): New.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Register for privacy mode changes.
(WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister for privacy mode changes.
(WebCore::HTMLMediaElement::loadResource): Tell player current privacy mode.
(WebCore::HTMLMediaElement::privateBrowsingStateDidChange): New, call through to MediaPlayer.
* html/HTMLMediaElement.h:
* page/Page.cpp:
(WebCore::Page::privateBrowsingStateChanged): Call document()->privateBrowsingStateDidChange.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::setPrivateBrowsingMode): New, call through to media engine.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode): Declare new interface.
2011-03-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
https://bugs.webkit.org/show_bug.cgi?id=54785
This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
the right thing and continue to do the right thing. It also modifies EventQueue
so that we can cancel an event. To do this efficiently, the vector is now a
ListHashSet.
Canelling the event is harder/messier, but the most deterministic thing to do.
To the user, the work isn't done until we fire the onsuccess/onerror handler.
So the event (which does fire that) needs to be cancelable.
transaction-abort.html tests this.
* dom/EventQueue.cpp:
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::cancelEvent):
(WebCore::EventQueue::pendingEventTimerFired):
(WebCore::EventQueue::dispatchEvent):
* dom/EventQueue.h:
* dom/ExceptionCode.cpp:
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::deleteFunction):
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::close):
* storage/IDBDatabaseException.h:
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::openCursor):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::~IDBRequest):
(WebCore::IDBRequest::readyState):
(WebCore::IDBRequest::markEarlyDeath):
(WebCore::IDBRequest::source):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):
* storage/IDBRequest.h:
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::registerRequest):
(WebCore::IDBTransaction::unregisterRequest):
(WebCore::IDBTransaction::onAbort):
* storage/IDBTransaction.h:
2011-03-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Only IndexedDB's error event should be cancelable
https://bugs.webkit.org/show_bug.cgi?id=55413
* storage/IDBRequest.cpp:
(WebCore::createSuccessEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
2011-03-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Remove CorrectionIndicator markers sooner.
https://bugs.webkit.org/show_bug.cgi?id=54893
<rdar://problem/8997524>
Test: platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html
This patch changes the autocorrection behavior on Mac OS X. We want to remove CorrectionIndicator
marker after any editing command if the command:
1. is not a SpellingCorrectionCommand itself.
2. is not the command that triggers the autocorrection.
This is achieved by adding shouldRetainAutocorrectionIndicator() function to EditCommand. This function returns
false for all commands derived from EditCommand, except SpellingCorrectionCommand and TypingCommand. This function
always returns true for SpellingCorrectionCommand. For TypingCommand, the return value is determined by member
variable m_shouldRetainAutocorrectionIndicator, which can be modified by passing option into the TypingCommand's
public functions.
To avoid constantly searching marker list, we use variable DocumentMarkerController::m_absentMarkerTypeCache
to cache whether there is any marker of a particular type.
This patch also fixes two minor existing bugs.
1. We used to show reversion panel for word with CorrectionIndicator marker. This is incorrect because
CorrectionIndicator marker can be removed from corrected words. Since all autocorrected words have Replacement
marker unless the whole word is deleted, the correct behavior is to show reversion panel for word with Replacement
marker, since all autocorrected words have such marker. However, since we don't want to show the reversion panel
if an autocorrected word has been edited, we also check to see if the Replacement marker's description is null.
This works as following:
When we apply an autocorrection, we add Replacement marker to corrected word, and store original word
as the marker's description. If the user edited the corrected word afterward, we set description to null.
So when we decide whether to show a reversion panel, we not only check for the existence of Replacement
marker, but also check if description is null.
2. Fixed an assertion violation in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited(), which would
occur when deleting the first character in an editable area.
* dom/DocumentMarker.h: Added m_possiblyExistingMarkerTypes to allow quickly checking whether a marker type is
completely in from the document.
* dom/DocumentMarkerController.cpp: Most of the functions listed here are optimized for early return by checking
the return value of possiblyHasMarkers() at beginning.
(WebCore::DocumentMarkerController::possiblyHasMarkers):
(WebCore::DocumentMarkerController::DocumentMarkerController):
(WebCore::DocumentMarkerController::detach):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::copyMarkers):
(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::shiftMarkers):
(WebCore::DocumentMarkerController::setMarkersActive):
(WebCore::DocumentMarkerController::hasMarkers):
(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
* dom/DocumentMarkerController.h:
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply):
(WebCore::EditCommand::shouldRetainAutocorrectionIndicator):
(WebCore::EditCommand::setShouldRetainAutocorrectionIndicator):
* editing/EditCommand.h:
* editing/Editor.cpp:
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
(WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
* editing/Editor.h:
* editing/EditorCommand.cpp:
(WebCore::executeInsertLineBreak):
(WebCore::executeInsertParagraph):
(WebCore::executeInsertText):
* editing/SpellingCorrectionCommand.cpp:
(WebCore::SpellingCorrectionCommand::shouldRetainAutocorrectionIndicator):
* editing/SpellingCorrectionCommand.h:
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
(WebCore::TypingCommand::insertParagraphSeparator):
* editing/TypingCommand.h:
(WebCore::TypingCommand::create):
(WebCore::TypingCommand::shouldRetainAutocorrectionIndicator):
(WebCore::TypingCommand::setShouldRetainAutocorrectionIndicator):
* manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html:
2011-03-01 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
FEDisplacementMapElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=55454
When the FEDisplacementMapElement receives an update message but the given value remains the same we don't need
to relayout the filter.
No new tests are needed because this modification is covered by the dynamic update tests of FEDisplacementMap.
* platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::setXChannelSelector):
(WebCore::FEDisplacementMap::setYChannelSelector):
(WebCore::FEDisplacementMap::setScale):
* platform/graphics/filters/FEDisplacementMap.h:
* svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute):
(WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
* svg/SVGFEDisplacementMapElement.h:
2011-03-01 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/8902714> Expand ruby text when it is shorter than the ruby base
https://bugs.webkit.org/show_bug.cgi?id=55487
* css/html.css:
(ruby > rt): Changed the default text-align value to -webkit-auto to signal
the default expansion behavior.
* rendering/RenderBlock.h:
(WebCore::RenderRubyText::textAlignmentForLine): Made protected.
(WebCore::RenderBlock::adjustInlineDirectionLineBounds): Made protected.
* rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::textAlignmentForLine): Added. If text-align is
-webkit-auto, returns JUSTIFY to allow expansion.
(WebCore::RenderRubyText::adjustInlineDirectionLineBounds): Added. If
text-align is -webkit-auto, insets the line such that the inset on each side
is the half the inter-ideograph expansion, or one ruby character wide,
whichever is smaller.
* rendering/RenderRubyText.h:
2011-03-01 Sam Weinig <sam@webkit.org>
Reviewed by Timothy Hatcher.
WebKit2 needs to be made localizable
https://bugs.webkit.org/show_bug.cgi?id=55483
* English.lproj/Localizable.strings: Copied from Source/WebKit/English.lproj/Localizable.strings.
* WebCore.xcodeproj/project.pbxproj:
Move Localizable.strings to WebCore.
* WebCore.exp.in:
Add export for localizedString function.
* platform/LocalizedStrings.h:
* platform/mac/LocalizedStringsMac.mm: Added.
Add function to get localized version of a string from the WebCore bundle.
2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
All Console Messages should be passed to ChromeClients.
https://bugs.webkit.org/show_bug.cgi?id=54926
Do not filter the message type here, allow clients
to filter and deal with the different message types.
* page/Console.cpp:
(WebCore::Console::addMessage):
2011-02-23 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Viewport parsing no longer accepts "1.0;" value as valid.
https://bugs.webkit.org/show_bug.cgi?id=53705
When parsing numeric values, the "css-viewport" spec says
to use the number prefix, and the non numeric part of the
string can be ignored. This matches our behavior before
r67376. The change was that checking the error out condition
of String::toFloat doesn't necessarily mean that there
was a non-numeric prefix. This patch checks if there was
or wasn't a non-numeric prefix.
There is a console warning in any case where a numeric
value is not parsed cleanly. There is an error warning
when it is not a number at all, and a tip warning when
it has been truncated.
Error messages are slightly improved to provide more
context, both the key and value, when an error happens.
Test: fast/viewport/viewport-129.html
* dom/ViewportArguments.cpp:
(WebCore::numericPrefix):
(WebCore::findSizeValue):
(WebCore::findScaleValue):
(WebCore::findUserScalableValue):
(WebCore::findTargetDensityDPIValue):
(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessageLevel):
(WebCore::reportViewportWarning):
* dom/ViewportArguments.h:
2011-03-01 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: InjectedScript.setPropertyValue doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=55475
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::setPropertyValue):
2011-03-01 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Remove unused JavaString::uchars()
https://bugs.webkit.org/show_bug.cgi?id=55465
No new tests, removing dead code only.
* bridge/jni/JNIBridge.h:
* bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::utf8):
* bridge/jni/v8/JavaStringV8.h:
2011-03-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Extremely slow DOM search in GMail
https://bugs.webkit.org/show_bug.cgi?id=55456
The solution comprises three major parts:
- avoid multiple invocations of highlightSearchResults(), one per each nodeIds chunk.
- cache highlighted node's innerHTML so that no extra _nodeTitleInfo() calls will be needed.
- replace hand-written Text nodes iteration with a snapshot-based ".//text()" XPathResult.
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.searchCanceled):
(WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.highlightSearchResults):
(WebInspector.ElementsTreeElement.prototype.updateTitle):
():
* inspector/front-end/utilities.js:
():
2011-03-01 Adam Roben <aroben@apple.com>
Fix multiple-definition linker warnings introduced by r79978 on Windows
* rendering/RenderingAllInOne.cpp: Removed TextControlInnerElements.cpp, as it is now being
compiled separately.
2011-03-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Clean up the project files and move common options to WebKit.pri.
No new tests needed.
* WebCore.pri: Move common options to WebKit.pri.
* WebCore.pro: Ditto.
2011-03-01 Steve Block <steveblock@google.com>
Reviewed by Pavel Feldman.
JNI code in Java bridge is not correctly guarded
https://bugs.webkit.org/show_bug.cgi?id=55459
No new tests, build fix only.
* bridge/jni/v8/JNIBridgeV8.cpp:
* bridge/jni/v8/JNIBridgeV8.h:
* bridge/jni/v8/JNIUtilityPrivate.cpp:
* bridge/jni/v8/JNIUtilityPrivate.h:
* bridge/jni/v8/JavaClassV8.cpp:
* bridge/jni/v8/JavaClassV8.h:
* bridge/jni/v8/JavaInstanceV8.cpp:
* bridge/jni/v8/JavaInstanceV8.h:
* bridge/jni/v8/JavaNPObjectV8.cpp:
* bridge/jni/v8/JavaNPObjectV8.h:
2011-03-01 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Bridge.h should not include BridgeJSC.h
https://bugs.webkit.org/show_bug.cgi?id=55212
Instead, BridgeJSC.h should include Bridge.h and code should include
BridgeJSC.h as appropriate.
This prevents ports that use V8 from having to include JSC-specific
files, even if the contents of those files are guarded.
No new tests, cleanup only.
* bindings/js/JSPluginElementFunctions.cpp:
* bindings/js/ScriptControllerBrew.cpp:
* bindings/js/ScriptControllerGtk.cpp:
* bindings/js/ScriptControllerHaiku.cpp:
* bindings/js/ScriptControllerQt.cpp:
* bindings/js/ScriptControllerMac.mm:
* bindings/js/ScriptControllerWin.cpp:
* bindings/js/ScriptControllerWx.cpp:
* bindings/js/ScriptInstance.h:
* bindings/objc/WebScriptObject.mm:
* bridge/Bridge.h:
* bridge/c/c_class.h:
* bridge/c/c_instance.h:
* bridge/c/c_runtime.h:
* bridge/jni/jsc/JNIBridgeJSC.h:
* bridge/jni/jsc/JavaInstanceJSC.h:
* bridge/jsc/BridgeJSC.h:
* bridge/objc/objc_runtime.h:
* bridge/qt/qt_class.h:
* bridge/qt/qt_instance.h:
* bridge/qt/qt_pixmapruntime.h:
* bridge/qt/qt_runtime.h:
* bridge/runtime_array.h:
* bridge/runtime_method.h:
* bridge/runtime_object.h:
* bridge/runtime_root.cpp:
* bridge/testbindings.cpp:
* bridge/testbindings.mm:
* bridge/testqtbindings.cpp:
* page/win/FrameWin.cpp:
* platform/graphics/wince/MediaPlayerProxy.cpp:
* plugins/PluginView.cpp:
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/mac/PluginViewMac.mm:
* plugins/qt/PluginViewQt.cpp:
* plugins/symbian/PluginViewSymbian.cpp:
* plugins/win/PluginViewWin.cpp:
2011-03-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Antti Koivisto.
SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
https://bugs.webkit.org/show_bug.cgi?id=54800
Wrong handling of currentColor on inherit
https://bugs.webkit.org/show_bug.cgi?id=38102
Stop storing RefPtr<SVGPaint> objects in the SVGRenderStyle for fill/stroke. These are the last
two objects that held references to CSSValues, they're all gone now, aligning better with RenderStyle.
It's also dangerous, as a SVGPaint object can be shared by multiple SVGRenderStyles (MappedAttribute will
once create a CSSStyleDeclaration for fill="red" and reuse it where possible), and it was easy to
accidently mutate the object, affecting multiple styles. Instead store a Color, an URI and a paint
type in SVGRenderStyle, enough to create a SVGPaint object, if needed (eg for computed styles).
<g color="green"><rect fill="currentColor"/> already worked fine in trunk, but
<g fill="currentColor" color="green"><rect color="red"/> procuded a red rectangle.
In order to fix to bug we have to resolve all currentColor values for SVGPaint objects, in SVGCSSStyleSelector,
as it's already done for SVGColor objects (stop-color, flood-color, etc.) instead of in RenderSVGResource::fill/strokePaintingResource,
when trying to use the paint server. The correct "color" value that should be used from the RenderStyle, is directly
available in CSSStyleSelector: in applyProperty m_style->color() gives the desired value. In CSSStyleSelector it's handled
exactly this way for non-SVG currentColor properties. Also fix computed styles, which did not resolve currentColor for SVGPaint/SVGColor.
A previous patch implemented the SVGPaint/SVGColor API. SVG demands these CSSValues to be mutable. Introduce
CSSMutableValue, which extends CSSValue by a Node pointer, and let SVGPaint/SVGColor inherit from it.
Mutating a SVGPaint/SVGColor object now takes immediate effect, which is reflected in the inline style / computed style.
(Note that getPresentationAttribute() already takes care of removing the CSSValue from the mapped attribute cache, so that it's no longer shared.)
Add several new tests covering the patch.
Tests: svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
svg/animations/animate-color-fill-currentColor.html
svg/custom/SVGPaint-mutate-attribute.svg
svg/custom/SVGPaint-mutate-inline-style.svg
* GNUMakefile.am: Add CSSMutableValue.h
* WebCore.gypi: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* css/CSSMutableStyleDeclaration.cpp: Reset the Node pointer in all CSSMutableValues belonging to this style declaration.
(WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
* css/CSSMutableStyleDeclaration.h: Add destructor.
* css/CSSMutableValue.h: Added.
(WebCore::CSSMutableValue::CSSMutableValue):
(WebCore::CSSMutableValue::~CSSMutableValue):
(WebCore::CSSMutableValue::isMutableValue):
(WebCore::CSSMutableValue::node):
(WebCore::CSSMutableValue::setNode):
(WebCore::CSSMutableValue::setNeedsStyleRecalc):
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::getPropertyCSSValue): Set the Node object of a CSSMutableValue to the Node, this style declaration belongs to.
* css/CSSValue.h:
(WebCore::CSSValue::isMutableValue): Return false, default.
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::adjustSVGPaintForCurrentColor): Add helper function, resolving currentColor values for SVGPaint objects.
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Use currentColorOrValidColor/adjustSVGPaintForCurrentColor to resolve SVGColor/SVGPaint values.
* css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty): Store fill/stroke uri, color, paint type seperated in SVGRenderStyle, don't store the full SVGPaint object anymore.
* rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::diff): Adapt to SVGPaint changes.
* rendering/style/SVGRenderStyle.h: Ditto.
(WebCore::SVGRenderStyle::initialFillOpacity):
(WebCore::SVGRenderStyle::initialFillPaintType):
(WebCore::SVGRenderStyle::initialFillPaintColor):
(WebCore::SVGRenderStyle::initialFillPaintUri):
(WebCore::SVGRenderStyle::initialStrokeOpacity):
(WebCore::SVGRenderStyle::initialStrokePaintType):
(WebCore::SVGRenderStyle::initialStrokePaintColor):
(WebCore::SVGRenderStyle::initialStrokePaintUri):
(WebCore::SVGRenderStyle::initialStrokeMiterLimit):
(WebCore::SVGRenderStyle::initialStopOpacity):
(WebCore::SVGRenderStyle::initialFloodOpacity):
(WebCore::SVGRenderStyle::setFillPaint):
(WebCore::SVGRenderStyle::setStrokePaint):
(WebCore::SVGRenderStyle::fillPaintType):
(WebCore::SVGRenderStyle::fillPaintColor):
(WebCore::SVGRenderStyle::fillPaintUri):
(WebCore::SVGRenderStyle::strokePaintType):
(WebCore::SVGRenderStyle::strokePaintColor):
(WebCore::SVGRenderStyle::strokePaintUri):
(WebCore::SVGRenderStyle::hasStroke):
(WebCore::SVGRenderStyle::hasFill):
* rendering/style/SVGRenderStyleDefs.cpp: Ditto.
(WebCore::StyleFillData::StyleFillData):
(WebCore::StyleFillData::operator==):
(WebCore::StyleStrokeData::StyleStrokeData):
(WebCore::StyleStrokeData::operator==):
* rendering/style/SVGRenderStyleDefs.h: Ditto.
* rendering/svg/RenderSVGResource.cpp: Ditto.
(WebCore::requestPaintingResource):
* rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
* rendering/svg/SVGResources.cpp: Ditto.
(WebCore::paintingResourceFromSVGPaint):
(WebCore::SVGResources::buildCachedResources):
* svg/SVGColor.cpp: Call setNeedsStyleRecalc() after mutating the object.
(WebCore::SVGColor::setRGBColor):
(WebCore::SVGColor::setRGBColorICCColor):
(WebCore::SVGColor::setColor):
* svg/SVGColor.h:
* svg/SVGPaint.cpp: Ditto.
(WebCore::SVGPaint::setUri):
(WebCore::SVGPaint::setPaint):
* svg/SVGPaint.h:
2011-03-01 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Handle decorated lines in the editor
https://bugs.webkit.org/show_bug.cgi?id=55373
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._startEditing):
(WebInspector.SourceFrame.prototype._endEditing):
(WebInspector.SourceFrame.prototype._createTextViewer):
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorGutterPanel.prototype.textChanged):
(WebInspector.TextEditorGutterChunk.prototype.addDecoration):
(WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
(WebInspector.TextEditorMainPanel.prototype.set readOnly):
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
(WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified):
(WebInspector.TextEditorMainPanel.prototype._markDirtyLines):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._removeDecorationsInRange):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
(WebInspector.TextEditorMainChunk.prototype.addDecoration):
(WebInspector.TextEditorMainChunk.prototype.removeDecoration):
(WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):
(WebInspector.TextEditorMainChunk.prototype.get decorated):
2011-03-01 Philippe Normand <pnormand@igalia.com>
Unreviewed GTK build fix after r79978
* GNUmakefile.am:
2011-03-01 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt] Fix minimal build.
No new tests needed.
* WebCore.pri: Is included in WebKit2.pro, so XP_UNIX can remain here.
2011-03-01 anthony taranto <anthony.taranto@gmail.com>
Return undefined value from ScriptController::evaluate(), allowing the
caller to distinguish between an error and an undefined return value.
https://bugs.webkit.org/show_bug.cgi?id=51528
* bindings/v8/ScriptController.cpp:
2011-03-01 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 54853 - Move TextControlInnerElements from WebCore/rendering to WebCore/html/shadow
https://bugs.webkit.org/show_bug.cgi?id=54853
Moving the files from rendering to html/shadow, with the exception of
the class RenderTextControlInnerBlock, which I moved to RenderTextControlSingleLine
(this place is not ideal, but only a temporary state during the larger refactoring
for <input>).
No new tests. (refactoring)
* Android.mk:
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/shadow/TextControlInnerElements.cpp: Copied from Source/WebCore/rendering/TextControlInnerElements.cpp.
* html/shadow/TextControlInnerElements.h: Copied from Source/WebCore/rendering/TextControlInnerElements.h.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlInnerBlock::positionForPoint):
* rendering/RenderTextControlSingleLine.h:
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
* rendering/TextControlInnerElements.cpp: Removed.
* rendering/TextControlInnerElements.h: Removed.
2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55338
Deployed EditingStyle in applyInlineStyleToPushDown and removeInlineStyleFromElement.
Also added a convenience function EditingStyle::setProperty, which lazily instantiates
new CSSMutableStyleDeclaration for m_mutableStyle.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle*.
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Ditto.
(WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls the above three functions.
(WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownInlineStyleAroundNode.
* editing/ApplyStyleCommand.h:
* editing/EditingStyle.cpp:
(WebCore::HTMLElementEquivalent::addToStyle): Takes EditingStyle*; calls EditingStyle::setProperty.
(WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
(WebCore::EditingStyle::setProperty): Added. This member function lazily instantiates
new CSSMutableStyleDeclaration for m_mutableStyle.
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Takes EditingStyle*.
(WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Ditto.
(WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Ditto.
* editing/EditingStyle.h: Added HTMLElementEquivalent and HTMLAttributeEquivalent as friends.
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Ditto.
* editing/InsertTextCommand.cpp: Removed unnecessary includes.
* editing/RemoveCSSPropertyCommand.h: Ditto.
2011-02-28 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium rebuilds XMLViewer after noop. Fixed gyp file.
* WebCore.gyp/WebCore.gyp:
2011-02-28 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
KURL should expose a referrer property.
https://bugs.webkit.org/show_bug.cgi?id=55415
No change in functionality so no new tests.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setOutgoingReferrer): Refactor to put the majority
of functionality in KURL::strippedForUseAsReferrer() so that this code can
be more easily reused.
* platform/KURL.cpp:
(WebCore::KURL::strippedForUseAsReferrer): Converts the url to a string
which is suitable for use as a referrer.
* platform/KURL.h:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Frame::isContentEditable is currently based on two things: Editor::clientIsEditable and
Document::inDesignMode. In fact, it should only rely on Document::inDesignMode. As a result,
Editor::clientIsEditable and its client-side implementation can be removed.
* WebCore.exp.in:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isReadOnly):
* editing/Editor.cpp:
* editing/Editor.h:
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelectionFromNone):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::isContentEditable):
(WebCore::HTMLElement::isContentRichlyEditable):
* page/DragController.cpp:
(WebCore::DragController::operationForLoad):
* page/EditorClient.h:
* page/Frame.cpp:
* page/Frame.h:
2011-02-28 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Number type input cannot be set to empty string if it has an initial value
https://bugs.webkit.org/show_bug.cgi?id=53744
We need to distinguish null strings and empty strings for
InputElementData::value. So InputType::sanitizeValue() also needs to
take care of it.
* dom/InputElement.h: Add a comment to InputElementData::value and
setValue about null strings.
* html/InputType.h: Add a comment to sanitizeValue about null strings.
* html/NumberInputType.cpp:
(WebCore::NumberInputType::sanitizeValue): Returns a null string if the
proposed value is a null string. Returning an empty string if the
proposed value is not a number.
2011-02-28 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Number type input should not handle mouse wheel events if it has no focus.
https://bugs.webkit.org/show_bug.cgi?id=53638
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleWheelEventForSpinButton): Check focused().
2011-02-28 Noel Gordon <noel.gordon@gmail.com>
Reviewed by James Robinson.
[chromium] GradientSkia: use the common Gradient stop sorting methods.
https://bugs.webkit.org/show_bug.cgi?id=54625
Remove a FIXME: call the Gradient.cpp stop storting routines, no need
to duplicate that code herein.
No change in behavior, so no new tests.
* platform/graphics/skia/GradientSkia.cpp:
(WebCore::Gradient::platformGradient):
2011-02-28 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JNI code should include <jni.h> on non-OSX platforms.
https://bugs.webkit.org/show_bug.cgi?id=55219
On Mac we need to include <JavaVM/jni.h> as this is a framework
include. We include jni.h through JNIUtility.h to minimize the
number of ifdefs.
No new tests, build fix only.
* WebCore.xcodeproj/project.pbxproj
* bridge/jni/JNIUtility.h:
* bridge/jni/jni_jsobject.h:
* bridge/jni/jsc/JNIBridgeJSC.h:
* bridge/jni/jsc/JavaInstanceJSC.h:
* bridge/jni/v8/JavaInstanceV8.h:
2011-02-28 Nebojsa Sabovic <neb@chromium.org>
Reviewed by James Robinson.
[chromium] Pepper plugins render upside down
https://bugs.webkit.org/show_bug.cgi?id=55101
No layout tests for pepper plugins (yet).
* platform/graphics/chromium/PluginLayerChromium.h:
2011-02-28 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Follow HTML5 spec for document.open() a little more closely
https://bugs.webkit.org/show_bug.cgi?id=55392
See: 3.5.1.4 at http://www.whatwg.org/specs/web-apps/current-work/#dom-document-open.
The second return check matches the spec. The first return check (isExecutingScript())
was left in place because without it, fast/tokenizer/write-external-script-open.html
would fail. It also possible there is a spec bug because FF4 crashes on that test and
IE9 prints "FAILURE." The isLoadingMainResource() check was removed because the main
resource is always loading while parser->isParsing().
Test: fast/parser/double-write-from-closed-iframe.html
* dom/Document.cpp:
(WebCore::Document::open):
2011-02-28 Avi Drissman <avi@google.com>
Reviewed by James Robinson.
WebCursorInfo needs to match enums in platform/Cursor.h
https://bugs.webkit.org/show_bug.cgi?id=55094
* platform/chromium/CursorChromium.cpp:
(WebCore::grabCursor):
(WebCore::grabbingCursor):
* platform/chromium/PlatformCursor.h:
2011-02-28 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
[Mac] Make "Change back to …" contextual menu item work with new autocorrection.
https://bugs.webkit.org/show_bug.cgi?id=55396
<rdar://problem/8836093>
The change in InlineTextBox.cpp fixes a bug, where the rectangle of Replacement marker isn't
calculated. We need this to do hit test when deciding whether to show "Change back to ..." on
contextual menu.
The change in Editor.cpp is for notifying spellchecker about the reversion whenever "Change
back to ..." is clicked.
* editing/Editor.cpp:
(WebCore::Editor::changeBackToReplacedString):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDocumentMarkers):
2011-02-28 Victoria Kirst <vrk@google.com>
Reviewed by Kenneth Russell.
[chromium] Fall back to texSubImage2D when mapTexSubImage2D fails in VideoLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=55269
Mesa does not support mapTexSubImage2D, so this change lets
GPU-accelerated video work with DRT layout tests.
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateTexture):
2011-02-28 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text. Change staticX and staticY
to be staticInlinePosition and staticBlockPosition. Patch all of the computations involving these variables to be writing
mode aware. Mixed writing modes are not yet supported.
Added new tests in fast/block/positioning/auto.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::layoutPositionedObjects):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::startOffsetForLine):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendRunsForObject):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeBlockStaticDistance):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderAndPaddingLogicalLeft):
(WebCore::RenderBoxModelObject::borderAndPaddingStart):
(WebCore::RenderBoxModelObject::borderLogicalLeft):
(WebCore::RenderBoxModelObject::borderLogicalRight):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::relativePositionedInlineOffset):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::staticInlinePosition):
(WebCore::RenderLayer::staticBlockPosition):
(WebCore::RenderLayer::setStaticInlinePosition):
(WebCore::RenderLayer::setStaticBlockPosition):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hasAutoLeftAndRight):
(WebCore::InheritedFlags::hasAutoTopAndBottom):
(WebCore::InheritedFlags::hasStaticInlinePosition):
(WebCore::InheritedFlags::hasStaticBlockPosition):
2011-02-28 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Anders Carlsson.
[Qt][WK2] Plugin initialization
https://bugs.webkit.org/show_bug.cgi?id=48127
No function change so no new tests.
* WebCore.pri: Lift the definition of the XP_UNIX macro
from WebCore.pri to WebKit.pri to apply it to WebKit2 as well.
2011-02-28 Dean Jackson <dino@apple.com>
Reviewed by Eric Carlson.
https://bugs.webkit.org/show_bug.cgi?id=55239
Allow webkitEnterFullScreen to be called from outside
a user gesture, but only when the correct restrictions
have been lifted in WebCore. Add a new restriction type
for this situation. Meanwhile, expose the current
restrictions externally from HTMLMediaElement, so that
clients can easily set restrictions on their port.
No new tests. This doesn't change existing behavior. Some
WebKit clients may lift the restriction.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
- ensure restrictions initialize with fullscreen restricted
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::requireUserGestureForLoad):
(WebCore::HTMLMediaElement::requireUserGestureForRateChange):
(WebCore::HTMLMediaElement::requireUserGestureForFullScreen):
(WebCore::HTMLMediaElement::setBehaviorRestrictions):
- new methods to expose the current restrictions
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitEnterFullscreen):
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78789.
http://trac.webkit.org/changeset/78789
https://bugs.webkit.org/show_bug.cgi?id=55409
Incorrect canvas fallback implementation (Requested by
inferno-sec on #webkit).
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::canHaveChildren):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(atkRole):
* accessibility/mac/AccessibilityObjectWrapper.mm:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isFocusable):
* rendering/RenderHTMLCanvas.cpp:
* rendering/RenderHTMLCanvas.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaint):
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79425.
http://trac.webkit.org/changeset/79425
https://bugs.webkit.org/show_bug.cgi?id=55406
Incorrect canvas fallback implementation. (Requested by
inferno-sec on #webkit).
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::nodeAtPoint):
2011-02-28 Adam Klein <adamk@chromium.org>
Reviewed by Adam Barth.
[fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
https://bugs.webkit.org/show_bug.cgi?id=54774
See http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods
for the spec implemented by this patch.
Test: fast/filesystem/resolve-uri.html
* fileapi/DOMFileSystemBase.cpp:
(WebCore::DOMFileSystemBase::crackFileSystemURL):
* fileapi/DOMFileSystemBase.h:
Added constants for "temporary" and "persistent".
* fileapi/EntryBase.cpp:
Replace hardcoded strings with aforementioned constants.
* fileapi/FileSystemCallbacks.cpp:
(WebCore::ResolveURICallbacks::create):
(WebCore::ResolveURICallbacks::ResolveURICallbacks):
(WebCore::ResolveURICallbacks::didOpenFileSystem):
Chains a call of openFileSystem to calls to getDirectory/getFile.
* fileapi/FileSystemCallbacks.h:
* fileapi/LocalFileSystem.cpp:
(WebCore::LocalFileSystem::readFileSystem):
* fileapi/LocalFileSystem.h:
Remove size argument from readFileSystem()
* page/DOMWindow.cpp:
(WebCore::DOMWindow::resolveLocalFileSystemURI):
* page/DOMWindow.h:
* page/DOMWindow.idl:
2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Oliver Hunt.
Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtConnectionObject::execute):
2011-02-25 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Remove some duplicate code from KURLGoogle.cpp
https://bugs.webkit.org/show_bug.cgi?id=55266
No change in functionality so no new tests.
* WebCore.gyp/WebCore.gyp: Make KURL.cpp get built by Chromium.
* platform/KURL.cpp:
Simply moved #include's and some code that was identical (i.e.
had been copied) to KURLGoogle.cpp outside of ifdef !USE(GOOGLEURL)
to reduce duplication.
* platform/KURLGoogle.cpp:
Removed the duplicate code.
2011-02-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make ScopeChainNode GC allocated
https://bugs.webkit.org/show_bug.cgi?id=55283
Update WebCore to deal with the absence of the ScopeChain
class.
* ForwardingHeaders/runtime/ScopeChain.h: Added.
* bindings/js/JSHTMLElementCustom.cpp:
(WebCore::JSHTMLElement::pushEventHandlerScope):
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::scopeChain):
(WebCore::JSJavaScriptCallFrame::scopeType):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
* bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::evaluate):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::pushEventHandlerScope):
* bindings/js/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::scopeChain):
* bindings/js/JavaScriptCallFrame.h:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/c/c_class.cpp:
* bridge/c/c_runtime.cpp:
* bridge/jni/JNIBridge.cpp:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtConnectionObject::execute):
* plugins/PluginViewNone.cpp:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Adele Peterson.
REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
https://bugs.webkit.org/show_bug.cgi?id=55323
Draw focus ring on selected items only if spatial navigation is enabled.
Test: fast/forms/select-listbox-multiple-no-focusring.html
* rendering/RenderBlock.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects):
2011-02-28 Abhishek Arya <inferno@chromium.org>
Reviewed by Anders Carlsson.
We can cancel the plugin load and fail with error before m_manualStream
got a chance to initialize in PluginView::didReceiveResponse. This can
happen when we run pending document onload events during plugin load that
remove the frame from underneath. So, change the assert into a null check.
https://bugs.webkit.org/show_bug.cgi?id=55307
* plugins/PluginView.cpp:
(WebCore::PluginView::didFail):
2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Alexey Proskuryakov.
Build fix for Intel ICC Compiler.
https://bugs.webkit.org/show_bug.cgi?id=55221
The virtual inheritance seems to confuse ICC.
Anything that links with webkit has an undefined reference otherwise.
* svg/SVGTransformable.cpp:
(WebCore::SVGTransformable::~SVGTransformable):
* svg/SVGTransformable.h:
2011-02-28 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[Gtk] Resource size is incorrectly reported to WebCore
https://bugs.webkit.org/show_bug.cgi?id=53228
When calling didReceiveData we are sending an invalid value for
lengthReceived. Sometimes we were even passing a boolean value instead of the
expected integer. We should pass the size of the received data instead of the
total amount of data received.
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::gotChunkCallback):
(WebCore::sendRequestCallback):
(WebCore::readCallback):
2011-02-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Dan Bernstein.
Cleanup the include guard form an Objective-C files
https://bugs.webkit.org/show_bug.cgi?id=55379
Normally Objective-C files do not need include guard.
r76916 introduced an include guard in EmptyProtocolDefinitions.h.
The guard is no longer needed after r76991.
No new tests as there is no new functionality.
* platform/mac/EmptyProtocolDefinitions.h:
2011-02-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] no resources in scripts panel because debugger is enabled too early.
https://bugs.webkit.org/show_bug.cgi?id=55389
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::populateScriptObjects):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setFrontend):
(WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
* inspector/InspectorDebuggerAgent.h:
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79877.
http://trac.webkit.org/changeset/79877
https://bugs.webkit.org/show_bug.cgi?id=55388
Breaks chromium build (Requested by antonm_ on #webkit).
* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::updateContentsIfDirty):
(WebCore::ContentLayerChromium::resizeUploadBufferForImage):
(WebCore::ContentLayerChromium::resizeUploadBuffer):
(WebCore::SkBitmapConditionalAutoLockerPixels::SkBitmapConditionalAutoLockerPixels):
(WebCore::SkBitmapConditionalAutoLockerPixels::~SkBitmapConditionalAutoLockerPixels):
(WebCore::SkBitmapConditionalAutoLockerPixels::lockPixels):
(WebCore::ContentLayerChromium::updateTextureIfNeeded):
(WebCore::ContentLayerChromium::draw):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContentsIfDirty):
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::update):
* platform/graphics/chromium/LayerTilerChromium.h:
* platform/graphics/chromium/PlatformCanvas.cpp: Removed.
* platform/graphics/chromium/PlatformCanvas.h: Removed.
* platform/graphics/chromium/PlatformImage.cpp: Removed.
* platform/graphics/chromium/PlatformImage.h: Removed.
2011-02-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add live edit test.
https://bugs.webkit.org/show_bug.cgi?id=55360
Test: inspector/debugger/live-edit.html
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._doubleClick):
(WebInspector.SourceFrame.prototype._didEditLine):
2011-02-28 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Follow up to r79858, removing optimistic assertion that fails on debug bot.
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
2011-02-25 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Abstract "pixels with a graphics context" into its own class
https://bugs.webkit.org/show_bug.cgi?id=55259
This creates new PlatformCanvas/PlatformImage classes which wrap
all of the #ifdef Skia/Cg warts from the compositor. All classes
(LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
modified to use these abstractions.
Tests: LayoutTests/compositing
* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::updateContentsIfDirty):
(WebCore::ContentLayerChromium::resizeUploadBuffer):
(WebCore::ContentLayerChromium::updateTextureIfNeeded):
(WebCore::ContentLayerChromium::updateTexture):
(WebCore::ContentLayerChromium::draw):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContentsIfDirty):
(WebCore::ImageLayerChromium::updateTextureIfNeeded):
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::update):
(WebCore::LayerTilerChromium::updateFromPixels):
* platform/graphics/chromium/LayerTilerChromium.h:
* platform/graphics/chromium/PlatformCanvas.cpp: Added.
(WebCore::PlatformCanvas::PlatformCanvas):
(WebCore::PlatformCanvas::~PlatformCanvas):
(WebCore::PlatformCanvas::resize):
(WebCore::PlatformCanvas::AutoLocker::AutoLocker):
(WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
(WebCore::PlatformCanvas::Painter::Painter):
(WebCore::PlatformCanvas::Painter::~Painter):
* platform/graphics/chromium/PlatformCanvas.h: Added.
(WebCore::PlatformCanvas::AutoLocker::pixels):
(WebCore::PlatformCanvas::Painter::context):
(WebCore::PlatformCanvas::size):
* platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp.
(WebCore::PlatformImage::PlatformImage):
(WebCore::PlatformImage::updateFromImage):
* platform/graphics/chromium/PlatformImage.h: Added.
(WebCore::PlatformImage::pixels):
(WebCore::PlatformImage::size):
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79784.
http://trac.webkit.org/changeset/79784
https://bugs.webkit.org/show_bug.cgi?id=55386
This change causes lots of assertion failures in Debug builds
(Requested by aroben on #webkit).
* css/CSSStyleSelector.cpp:
(WebCore::convertToLength):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::createTransformOperations):
* platform/Length.h:
(WebCore::Length::Length):
(WebCore::Length::operator==):
(WebCore::Length::operator!=):
(WebCore::Length::rawValue):
(WebCore::Length::type):
(WebCore::Length::quirk):
(WebCore::Length::setValue):
(WebCore::Length::setRawValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::isZero):
(WebCore::Length::blend):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
2011-02-28 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Use Frame::ownerElement() directly where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=55385
Don't take the roundabout way through frame->document->ownerElement
which just checks that the document->frame is non-null.
No new test, refactoring only.
* editing/SelectionController.cpp:
(WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchLoadEvent):
* page/EventHandler.cpp:
(WebCore::EventHandler::scrollRecursively):
(WebCore::EventHandler::logicalScrollRecursively):
* page/FrameView.cpp:
(WebCore::FrameView::init):
(WebCore::FrameView::layout):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::paintContents):
2011-02-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] source frame is recreated for each inlined script in document.
https://bugs.webkit.org/show_bug.cgi?id=55377
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
(WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
2011-02-28 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix for !ENABLE(SVG_ANIMATION) after r79569.
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):
2011-02-28 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
Optimize parameter transmissions in FEConvolveMatrix.
https://bugs.webkit.org/show_bug.cgi?id=55381
Parameter transmission via reference is more efficient than with copy. So they are substituted.
No new tests are needed since this is a refactoring.
* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::setKernelSize):
(WebCore::FEConvolveMatrix::setTargetOffset):
(WebCore::FEConvolveMatrix::setKernelUnitLength):
* platform/graphics/filters/FEConvolveMatrix.h:
2011-02-28 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium tests failures due to r79858.
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::inspectedPageDestroyed):
2011-02-28 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
XML without style should render as syntax-highlighted source.
https://bugs.webkit.org/show_bug.cgi?id=13807
XML tree view mode implemented. If XML does not have any style
information, it is rendered as highlighted source with collapsable
elements.
Tests: fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog.xml
fast/encoding/dumpAsText/utf-16-no-bom.xml
http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
http/tests/xmlviewer/dumpAsText/frames.html
http/tests/xmlviewer/dumpAsText/mathml.xml
http/tests/xmlviewer/dumpAsText/svg.xml
http/tests/xmlviewer/dumpAsText/wml.xml
http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
http/tests/xmlviewer/dumpAsText/xlink.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
http/tests/xmlviewer/dumpAsText/xmlviewer.xml
http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
http/tests/xmlviewer/dumpAsText/xul.xml
svg/hixie/error/dumpAsText/004.xml
svg/hixie/error/dumpAsText/005.xml
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchUARules):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::createElement):
* dom/Document.h:
(WebCore::Document::usesViewSourceStyles):
(WebCore::Document::setUsesViewSourceStyles):
(WebCore::Document::sawElementsInKnownNamespaces):
* dom/XMLDocumentParser.h:
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::initializeParserContext):
(WebCore::XMLDocumentParser::doEnd):
* dom/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::initializeParserContext):
(WebCore::XMLDocumentParser::parseProcessingInstruction):
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
* xml/XMLTreeViewer.cpp: Added.
(WebCore::XMLTreeViewer::XMLTreeViewer):
(WebCore::XMLTreeViewer::hasNoStyleInformation):
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
* xml/XMLTreeViewer.h: Added.
(WebCore::XMLTreeViewer::~XMLTreeViewer):
* xml/XMLViewer.xsl: Added.
* xml/XSLStyleSheet.h:
(WebCore::XSLStyleSheet::createForXMLTreeViewer):
2011-02-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: debugger agents should have same livetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=55369
DOM and JS debugger agents are now created in InspectorAgent's constructor and owned
by the agent. Debugger state is cleared on frontend disconnect.
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::populateScriptObjects):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::showScriptsPanel):
* inspector/InspectorAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::create):
(WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::debuggerWasEnabled):
(WebCore::InspectorBrowserDebuggerAgent::debuggerWasDisabled):
(WebCore::InspectorBrowserDebuggerAgent::disable):
(WebCore::InspectorBrowserDebuggerAgent::setFrontend):
(WebCore::InspectorBrowserDebuggerAgent::clearFrontend):
(WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
(WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
(WebCore::InspectorBrowserDebuggerAgent::clear):
* inspector/InspectorBrowserDebuggerAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::debuggerEnabled):
(WebCore::InspectorController::showAndEnableDebugger):
(WebCore::InspectorController::disableDebugger):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::create):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::startUserInitiatedDebugging):
(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::enabled):
(WebCore::InspectorDebuggerAgent::restore):
(WebCore::InspectorDebuggerAgent::setFrontend):
(WebCore::InspectorDebuggerAgent::clearFrontend):
(WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint):
(WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::clear):
* inspector/InspectorDebuggerAgent.h:
(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::Listener::~Listener):
(WebCore::InspectorDebuggerAgent::setListener):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.disableDebugger):
2011-02-28 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
FECompositeElement changes doesn't require relayout.
https://bugs.webkit.org/show_bug.cgi?id=55367
When the FECompositeElement receives an update message but the given value remains the same we don't need
to relayout the filter.
No new tests are needed because this modification is covered by the dynamic update tests of FEComposite.
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::setOperation):
(WebCore::FEComposite::setK1):
(WebCore::FEComposite::setK2):
(WebCore::FEComposite::setK3):
(WebCore::FEComposite::setK4):
* platform/graphics/filters/FEComposite.h:
* svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::setFilterEffectAttribute):
(WebCore::SVGFECompositeElement::svgAttributeChanged):
* svg/SVGFECompositeElement.h:
2011-02-28 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
FrameLoader: Reorder early-returns in checkCompleted()
https://bugs.webkit.org/show_bug.cgi?id=55366
Check allChildrenAreComplete() last, since it's the most expensive.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):
2011-02-28 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Range::processContents needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=51006
Refactored Range::processContents. Extracted childOfCommonRootBeforeOffset from processContents
which is used to find processStart and processEnd respectively. In the case of processStart,
we use the next sibling of the node returned by childOfCommonRootBeforeOffset when m_start is not
the common root because copying m_start's ancestors will result in processing too much contents.
Also extracted processNodes and deleteCharacterData from processContents and processContentsBetweenOffsets.
In addition, lengthOfContentsInNode was modified to return the correct length instead of
numeric_limits<unsigned>::max() because the convention that processContentsBetweenOffsets automatically
corrects the length when endOffset is numeric_limits<unsigned>::max() seemed more confusing than
having two switch statements that need to be consistent.
Historically, lengthOfContentsInNode was introduced in r78413 as a build fix because unsigned const
LengthOfContentsInNode added in r78409 violated WebKit C++ rules and caused build failures on Mac and
other ports.
* dom/Range.cpp:
(WebCore::childOfCommonRootBeforeOffset): Extracted from processContents.
(WebCore::lengthOfContentsInNode): Added.
(WebCore::Range::processContents): Calls childOfCommonRootBeforeOffset, lengthOfContentsInNode,
and processNodes.
(WebCore::deleteCharacterData): Added.
(WebCore::Range::processContentsBetweenOffsets): Calls deleteCharacterData and processNodes.
(WebCore::Range::processNodes): Extracted from processContents and processContentsBetweenOffsets.
(WebCore::Range::processAncestorsAndTheirSiblings):
* dom/Range.h:
2011-02-28 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Test harness change follow up.
Consider missing localized string a warning, not an error in the front-end.
* inspector/front-end/inspector.js:
(WebInspector.UIString):
2011-02-28 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
getJNIEnv() passes wrong type to AttachCurrentThread() for JNIEnv argument on Android
https://bugs.webkit.org/show_bug.cgi?id=55218
AttachCurrentThread() in Android's JVM takes a JINEnv**
argument.
No new tests, build fix only.
* bridge/jni/JNIUtility.cpp:
(JSC::Bindings::getJNIEnv):
2011-02-28 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
FETurbulenceElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=55141
When the FETurbulenceElement receives an update message but the given value remains the same we don't need
to relayout the filter.
Besides fix a typo in FETurbulence and change the paramterer type of FETurbulence::setNumOctaves from bool
to int according to the spec.
No new tests are needed because this modification is covered by the dynamic update tests of FETurbulence.
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::FETurbulence):
(WebCore::FETurbulence::create):
(WebCore::FETurbulence::type):
(WebCore::FETurbulence::setType):
(WebCore::FETurbulence::setBaseFrequencyY):
(WebCore::FETurbulence::setBaseFrequencyX):
(WebCore::FETurbulence::setSeed):
(WebCore::FETurbulence::setNumOctaves):
(WebCore::FETurbulence::setStitchTiles):
(WebCore::operator<<):
* platform/graphics/filters/FETurbulence.h:
* svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::setFilterEffectAttribute):
(WebCore::SVGFETurbulenceElement::svgAttributeChanged):
(WebCore::SVGFETurbulenceElement::build):
* svg/SVGFETurbulenceElement.h:
2011-02-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: InspectorAgent calls offsetWidth in the middle of painting
https://bugs.webkit.org/show_bug.cgi?id=54597
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::drawElementTitle):
2011-02-28 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 55355 - TextIterator should not be a friend of RenderTextControl
https://bugs.webkit.org/show_bug.cgi?id=55355
Remove need for 'friend' clause by making innerTextElement() public.
No new tests. (simple refactoring)
* rendering/RenderTextControl.h:
2011-02-27 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecWinCE
https://bugs.webkit.org/show_bug.cgi?id=55317
This functions are obsolete, since r78499 added TextCodecUTF8.
Also remove the "fast path" for UTF-8 data, because we now have a separate TextCodec.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps):
* platform/text/wince/TextCodecWinCE.cpp:
* platform/text/wince/TextCodecWinCE.h:
2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Sam Weinig.
Use OwnPtr to handle the memory of RenderBlock::m_floatingObjects and RenderBlock::m_positionedObjects
https://bugs.webkit.org/show_bug.cgi?id=55327
Refactor RenderBlock to use OwnPtr for m_floatingObjects and m_positionedObjects so we do not have
to release the memory manually.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::positionedObjects):
2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
Eliminate DeprecatedPtrList
https://bugs.webkit.org/show_bug.cgi?id=17425
Remove the implementation of DeprecatedPtrList and all its references
from the build systems.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.order:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/DeprecatedPtrList.h: Removed.
* platform/DeprecatedPtrListImpl.cpp: Removed.
* platform/DeprecatedPtrListImpl.h: Removed.
2011-02-27 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use WTF ref counting for FontPlatformDataPrivate
https://bugs.webkit.org/show_bug.cgi?id=55303
Make FontPlatformDataPrivate a RefCounted<FPDP>.
Incidentally fixes an uninitialized member bug in FontPlatformData().
* platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::size):
(WebCore::FontPlatformData::family):
(WebCore::FontPlatformData::bold):
(WebCore::FontPlatformData::italic):
(WebCore::FontPlatformData::smallCaps):
(WebCore::FontPlatformData::pixelSize):
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::toQFontWeight):
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::hash):
2011-02-27 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Darin Adler.
Eliminate DeprecatedPtrList from RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=54972
Refactor RenderBlock to get rid of the DeprecatedPtrList.
The floating objects are stored in a ListHashSet.
Refactoring covered by existing test.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::containsFloat):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObjectHashFunctions::hash):
(WebCore::RenderBlock::FloatingObjectHashFunctions::equal):
(WebCore::RenderBlock::FloatingObjectHashTranslator::hash):
(WebCore::RenderBlock::FloatingObjectHashTranslator::equal):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):
2011-02-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
<input value="type=submit"> throws a warning (“HTML parse error”)
https://bugs.webkit.org/show_bug.cgi?id=55120
This patch removes parse error messages from the HTML parser. These
messages are displayed at the wrong times, aren't tested, and aren't
helpful. We'll try again with some more informative messages and
better testing.
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::parseError):
2011-02-26 Patrick Gansterer <paroga@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecBrew
https://bugs.webkit.org/show_bug.cgi?id=55309
This functions are obsolete, since r78499 added TextCodecUTF8.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps):
* platform/text/brew/TextCodecBrew.cpp:
* platform/text/brew/TextCodecBrew.h:
2011-02-26 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
Delay firing of mutation events while setting attribute values
https://bugs.webkit.org/show_bug.cgi?id=55199
Test: fast/dom/attribute-change-on-mutate.html
* dom/Attr.cpp:
(WebCore::Attr::setValue):
2011-02-26 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Andreas Kling.
[Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
https://bugs.webkit.org/show_bug.cgi?id=55252
Need to invoke a callback function to notify the HTMLMediaElement
when MediaPlayerPrivateQt's playback state gets changed.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ignore the playback state change for pre-roll
(WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement
(WebCore::MediaPlayerPrivateQt::stateChanged):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
2011-02-25 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
When plugin document parser finishes parsing, it runs the raw
document's parser finish functions which call the pending document
onload events that removes the frame from underneath. So, we protect
frame (and hence frameloader) in DocumentLoader::commitLoad.
https://bugs.webkit.org/show_bug.cgi?id=55289
Test: fast/frames/iframe-plugin-load-remove-document-crash.html
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitLoad):
2011-02-26 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rolling out 79799 and 79804 for breaking xml tests on mac.
2011-02-26 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: follow up to r79799. Fixing WinCE+Efl, mute new tests on Qt.
https://bugs.webkit.org/show_bug.cgi?id=55302
* CMakeLists.txt:
2011-02-25 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
XML without style should render as syntax-highlighted source.
https://bugs.webkit.org/show_bug.cgi?id=13807
XML tree view mode implemented. If XML does not have any style
information, it is rendered as highlighted source with collapsable
elements.
Tests: http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
http/tests/xmlviewer/dumpAsText/frames.html
http/tests/xmlviewer/dumpAsText/mathml.xml
http/tests/xmlviewer/dumpAsText/svg.xml
http/tests/xmlviewer/dumpAsText/wml.xml
http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
http/tests/xmlviewer/dumpAsText/xlink.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
http/tests/xmlviewer/dumpAsText/xmlviewer.xml
http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
http/tests/xmlviewer/dumpAsText/xul.xml
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchUARules):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::createElement):
* dom/Document.h:
(WebCore::Document::usesViewSourceStyles):
(WebCore::Document::setUsesViewSourceStyles):
(WebCore::Document::sawElementsInKnownNamespaces):
* dom/XMLDocumentParser.h:
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::initializeParserContext):
(WebCore::XMLDocumentParser::doEnd):
* dom/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::initializeParserContext):
(WebCore::XMLDocumentParser::parseProcessingInstruction):
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
* xml/XMLTreeViewer.cpp: Added.
(WebCore::XMLTreeViewer::XMLTreeViewer):
(WebCore::XMLTreeViewer::hasNoStyleInformation):
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
* xml/XMLTreeViewer.h: Added.
(WebCore::XMLTreeViewer::~XMLTreeViewer):
* xml/XMLViewer.xsl: Added.
* xml/XSLStyleSheet.h:
(WebCore::XSLStyleSheet::createFromString):
2011-02-26 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable usage of synchronous HTTP feature in Qt
https://bugs.webkit.org/show_bug.cgi?id=37191
Currently, we spin an event loop when doing synchronous calls to
wait for completion. This patch uses synchronous requests in Qt,
if available, and spins the event loop as a fallback solution.
Based on work by Simon Hausmann and Peter Hartmann.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::setReplyFinished):
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):
2011-02-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
REGRESSION(r79398): Webkit crash on dojo theme tester page
https://bugs.webkit.org/show_bug.cgi?id=55290
The bug was caused by selectionStartCSSPropertyValue's not considering the possibility
of selectionStartStyle() returning a null pointer. Fixed it by adding a null check.
Test: editing/execCommand/value-without-selection-crash.html
* editing/Editor.cpp:
(WebCore::Editor::selectionStartCSSPropertyValue):
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
No new tests. (no code affected, just exporting a method for DumpRenderTree use)
* WebCore.exp.in:
2011-02-26 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
On Mac, need to remove misspell underline in Editor::learnSpelling().
https://bugs.webkit.org/show_bug.cgi?id=55251
This change makes sure that the misspelling markers are removed after the word is learned.
* editing/Editor.cpp:
(WebCore::Editor::learnSpelling):
2011-02-26 Rik Cabanier <cabanier@adobe.com>
Reviewed by David Hyatt.
Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699
Transitions now return matrices in floating point. 2 of the transition tests were failing
because they expected integer values.
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::convertToLength):
(WebCore::convertToIntLength):
(WebCore::convertToFloatLength):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::createTransformOperations):
* platform/Length.h:
(WebCore::Length::Length):
(WebCore::Length::operator==):
(WebCore::Length::operator!=):
(WebCore::Length::rawValue):
(WebCore::Length::type):
(WebCore::Length::quirk):
(WebCore::Length::setValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::isZero):
(WebCore::Length::blend):
(WebCore::Length::getIntValue):
(WebCore::Length::getFloatValue):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
2011-02-26 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement
https://bugs.webkit.org/show_bug.cgi?id=55204
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
- Using an inlineCapacity of 10 for now. We may want to tweak it later.
- This removes yet another malloc from code which removes nodes (which is rather common).
2011-02-26 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
HashSet<T>::end() creation is expensive and should be avoided
https://bugs.webkit.org/show_bug.cgi?id=55205
In the common case, m_ranges is an empty set. When that's
the case, we spend all our time in skipEmptyBuckets, walking
the hash storage skipping over empty buckets.
This looks to be at least a 5% speedup on (my local version of) peacekeeper's domDynamicCreationCreateElement.
Before:
avg 383.6666666666667
median 386
stdev 7.152311203768722
min 360
max 391
After:
avg 366.3333333333333
median 366
stdev 2.712112747574399
min 362
max 377
* dom/Document.cpp:
(WebCore::Document::nodeChildrenChanged):
(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore::Document::nodeWillBeRemoved):
(WebCore::Document::textInserted):
(WebCore::Document::textRemoved):
(WebCore::Document::textNodesMerged):
(WebCore::Document::textNodeSplit):
2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295
"broke Chromium builds" (Requested by rniwa on #webkit).
* WebCore.exp.in:
2011-02-26 Adam Klein <adamk@chromium.org>
Reviewed by Adam Barth.
[fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
https://bugs.webkit.org/show_bug.cgi?id=54585
In order to move toURI to EntryBase, it needed access to
SecurityOrigin. Most of the changes below were to pass a
ScriptExecutionContext to DOMFileSystemBase to enable this.
Test: fast/filesystem/workers/file-entry-to-uri-sync.html
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* fileapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::DOMFileSystem):
* fileapi/DOMFileSystemBase.cpp:
(WebCore::DOMFileSystemBase::DOMFileSystemBase):
(WebCore::DOMFileSystemBase::securityOrigin):
* fileapi/DOMFileSystemBase.h:
(WebCore::DOMFileSystemBase::create):
* fileapi/DOMFileSystemSync.cpp:
(WebCore::DOMFileSystemSync::create):
(WebCore::DOMFileSystemSync::DOMFileSystemSync):
* fileapi/DOMFileSystemSync.h:
(WebCore::DOMFileSystemSync::create):
* fileapi/Entry.cpp:
* fileapi/Entry.h:
* fileapi/EntryBase.cpp: Added.
(WebCore::EntryBase::EntryBase):
(WebCore::EntryBase::~EntryBase):
(WebCore::EntryBase::toURI):
* fileapi/EntryBase.h:
* fileapi/EntrySync.idl:
2011-02-26 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Ojan Vafai.
typing enter in the input element should not fire textInput
https://bugs.webkit.org/show_bug.cgi?id=54152
Stop textInput event propagation in HTMLInputElement::preDispatchEventHandler if the event target should submit implicitly.
Test: fast/forms/textinput-not-fired-on-enter-in-input.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::preDispatchEventHandler): Check m_inputType->shouldSubmitImplicitly for textInputEvents and stop propagation if true.
2011-02-26 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
[Web Timing] loadEvent timing should refer to first load event if there are many
https://bugs.webkit.org/show_bug.cgi?id=55201
Test: fast/dom/webtiming-document-open.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchLoadEvent):
2011-02-26 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Fix isLayoutTimerActive for ports that set a minimumLayoutDelay
https://bugs.webkit.org/show_bug.cgi?id=54810
No new tests because no new functionality.
* dom/Document.cpp:
(WebCore::Document::isLayoutTimerActive): Moved from HTMLParserScheduler per FIXME. Compare
minimumLayoutDelay() to m_extraLayoutDelay instead of 0. This spirit of this comparison was
broken by r52919. The effect would be that ports that set an extra layout delay can't yield
between tokens. Note: can't be const because minimumLayoutDelay sets a member.
* dom/Document.h:
* html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
(WebCore::HTMLParserScheduler::checkForYieldBeforeScript):
2011-02-26 David Dorwin <ddorwin@chromium.org>
Reviewed by Darin Fisher.
Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.
fullscreen javascript bindings not implemented for v8
https://bugs.webkit.org/show_bug.cgi?id=44797
Tested by the existing fullscreen Layout Tests.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
2011-02-26 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Prevent parser yields from triggering early dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=55187
DRT's dumpAsText() takes a snapshot when DocumentLoader::isLoadingInAPISense()
indicates the page is done. isLoadingInAPISense depends on
HTMLDocumentParser::isProcessingData(), which just checks if the parser is in an
insert() or append().
This means that if the parser is pumping in a resumeParsingAfterScriptExecution() or
resumeParsingAfterYield(), isLoadingInAPISense() may not be blocked. This patch
fixes that by repurposing m_writeNestingLevel as m_pumpSessionNestingLevel and
incrementing it in pumpTokenizer().
When I locally cause the parser to yield after every token, a lot of tests fail
because DRT snapshots too early. This patch fixes those tests, however I'm having
trouble writing a test case that reliably reproduces the problem without this patch
and passes with it (without changing yield constants). This is because it requires
4,096 tokens in a single pump session to yield and (len('<b>' * 4096 = 12k, which
doesn't always happen).
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::~HTMLDocumentParser):
(WebCore::HTMLDocumentParser::processingData):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
* html/parser/HTMLDocumentParser.h:
(WebCore::HTMLDocumentParser::inPumpSession):
(WebCore::HTMLDocumentParser::shouldDelayEnd):
* html/parser/HTMLParserScheduler.h:
(WebCore::PumpSession::PumpSession):
* html/parser/NestingLevelIncrementer.h:
2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=48781
Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
should paint the default broken image when an image fails to load or decode. The method also passes the
URL of the failed image.
Test: fast/images/support-broken-image-delegate.html
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::shouldPaintBrokenImage):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
(WebCore::CachedImage::image):
(WebCore::CachedImage::checkShouldPaintBrokenImage):
(WebCore::CachedImage::error):
* loader/cache/CachedImage.h:
2011-02-26 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Database: Data race: should only touch the transaction queue inside the
lock.
https://bugs.webkit.org/show_bug.cgi?id=55031
* storage/Database.cpp:
(WebCore::Database::changeVersion): only touch queue inside lock.
(WebCore::Database::runTransaction): only touch queue inside lock.
2011-02-26 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Eric Carlson.
Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callback
https://bugs.webkit.org/show_bug.cgi?id=55147
When HTMLMediaElement::mediaPlayerVolumeChanged() gets callback,
a volumechangeEvent event should be fired if the volume gets changed.
Test: media/event-attributes.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setMuted): Remove updateVolume() since it does nothing when m_player is 0.
(WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): Fire a volumechangeEvent when the volume is changed.
2011-02-26 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
disableRangeMutation quirk for mail slows down peacekeeper domDynamicCreationCreateElement
https://bugs.webkit.org/show_bug.cgi?id=55127
Before:
avg 513.4
median 515
stdev 7.234638899074368
min 490
max 528
After:
avg 508.15
median 510
stdev 6.966168243733426
min 485
max 515
Yes, the stdev is a bit high to actually support my conclusions. But looking
at the profile, this change makes a lot of sense. I'll up the iterations
for future testing.
* dom/Document.cpp:
(WebCore::disableRangeMutation):
- This check should only be compiled in if we're planning to run on Tiger or Leopard.
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
No new tests. (no code affected, just exporting a method for DumpRenderTree use)
* WebCore.exp.in:
2011-02-26 Chang Shu <chang.shu@nokia.com>
Reviewed by Antonio Gomes.
Based on patch by Carlos Garcia Campos <cgarcia@igalia.com>.
Spatial Navigation: Add support for <select> element in multiple selection mode
https://bugs.webkit.org/show_bug.cgi?id=49261
When spatial navigation is enabled, use space key to toggle select
items. And the up and down keys should not affect selection but just
navigate through items, which is indicated visually by a focus ring.
New Test: fast/spatial-navigation/snav-single-select-list.html
Enhanced Test: fast/spatial-navigation/snav-multiple-select.html
* dom/SelectElement.cpp:
(WebCore::SelectElement::listBoxDefaultEventHandler):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects):
* rendering/RenderListBox.h:
2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Qt build fix; included CSSValueList.h in EditingStyle.cpp.
* editing/EditingStyle.cpp:
2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Move HTMLEquivalent and its subclasses to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55207
Moved HTMLEquivalent and its subclasses from ApplyStyleCommand to EditingStyle,
and renamed HTMLEquivalent, HTMLEquivalentValueList, HTMLAttributeEquivalent,
and HTMLEquivalentFontSizeAttribute to HTMLElementEquivalent, HTMLTextDecorationEquivalent,
HTMLAttributeEquivalent, and HTMLFontSizeEquivalent respectively.
Also extracted the logic to determine which element and attribute are removed
as conflictsWithImplicitStyleOfElement, conflictsWithImplicitStyleOfAttributes,
and extractConflictingImplicitStyleOfAttributes.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
* editing/ApplyStyleCommand.h:
* editing/EditingStyle.cpp:
(WebCore::HTMLElementEquivalent::create): Moved from ApplyStyleCommand.cpp.
(WebCore::HTMLElementEquivalent::~HTMLElementEquivalent): Ditto.
(WebCore::HTMLElementEquivalent::matches): Ditto.
(WebCore::HTMLElementEquivalent::hasAttribute): Ditto.
(WebCore::HTMLElementEquivalent::propertyExistsInStyle): Ditto.
(WebCore::HTMLElementEquivalent::HTMLElementEquivalent): Ditto.
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle): Ditto.
(WebCore::HTMLElementEquivalent::addToStyle): Ditto.
(WebCore::HTMLTextDecorationEquivalent::create): Ditto.
(WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Ditto.
(WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Ditto.
(WebCore::HTMLAttributeEquivalent::create): Ditto.
(WebCore::HTMLAttributeEquivalent::matches): Ditto.
(WebCore::HTMLAttributeEquivalent::hasAttribute): Ditto.
(WebCore::HTMLAttributeEquivalent::attributeName): Ditto.
(WebCore::HTMLAttributeEquivalent::HTMLAttributeEquivalent): Ditto.
(WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle): Ditto.
(WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue): Ditto.
(WebCore::HTMLFontSizeEquivalent::create): Ditto.
(WebCore::HTMLFontSizeEquivalent::HTMLFontSizeEquivalent): Ditto.
(WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue): Ditto.
(WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Added.
(WebCore::htmlAttributeEquivalents): Added.
(WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes): Added.
(WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Added.
* editing/EditingStyle.h:
2011-02-25 Chris Fleizach <cfleizach@apple.com>
Reviewed by Anders Carlsson.
AX: Add Xcode entries back to the navigator list for Accessibility cpp files
https://bugs.webkit.org/show_bug.cgi?id=55280
* WebCore.xcodeproj/project.pbxproj:
2011-02-25 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
WebSocket uses insecure random numbers
https://bugs.webkit.org/show_bug.cgi?id=54714
* websockets/WebSocketHandshake.cpp:
(WebCore::randomNumberLessThan):
(WebCore::generateSecWebSocketKey):
(WebCore::generateKey3):
2011-02-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Add API to enumerate/delete files downloaded for <audio> and <video>
https://bugs.webkit.org/show_bug.cgi?id=55267
Add review changes missed in r79737.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::clearMediaCacheForSite): Pass string by reference.
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
2011-02-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Add API to enumerate/delete files downloaded for <audio> and <video>
https://bugs.webkit.org/show_bug.cgi?id=55267
<rdar://problem/9049280>
No new tests, this is just the plumbing.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::getSitesInMediaCache): New, call through to MediaPlayer.
(WebCore::HTMLMediaElement::clearMediaCache): Ditto.
(WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::getSitesInMediaCache): New, call through to media engine.
(WebCore::MediaPlayer::clearMediaCache): Ditto.
(WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::getSitesInMediaCache): Declare new interface.
(WebCore::MediaPlayerPrivateInterface::clearMediaCache): Ditto.
(WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
2011-02-25 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Don't add inline continuation outline to the containing block's
continuationOutlineTable list if it is not enclosed by an anonymous block.
https://bugs.webkit.org/show_bug.cgi?id=54690
We currently don't reconnect inline continuations after a child removal.
As a result, those merged inlines do not get seperated and hence not get enclosed
by anonymous blocks. In this case, it is better to bail out and paint it ourself.
Test: fast/table/table-continuation-outline-paint-crash.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintsContinuationOutline): helper function to tell
if this containing block has the continuation flow in its continuations list.
* rendering/RenderBlock.h: helper function definition.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::destroy): debug only code that asserts if we leave
behind a continuation in the containing block's continuation list when it is
getting destroyed.
2011-02-25 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=55265, remove the unused "Static" type
from Length.
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* platform/Length.h:
(WebCore::Length::isFixed):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):
* rendering/RenderObject.h:
(WebCore::RenderObject::markContainingBlocksForLayout):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hasStaticX):
(WebCore::InheritedFlags::hasStaticY):
2011-02-25 Brian Weinstein <bweinstein@apple.com>
Windows build fix.
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::getHostnamesWithCookies): Add a const_cast.
(WebCore::deleteCookiesForHostname): Ditto.
2011-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Empty Elements panel after closing and reopening Inspector
https://bugs.webkit.org/show_bug.cgi?id=55248
Fixing regression real quick. Test to follow.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::reset):
2011-02-25 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: added missing handle scope into V8InjectedScriptHostCustom.
https://bugs.webkit.org/show_bug.cgi?id=55256
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::nodeAsScriptValue):
(WebCore::V8InjectedScriptHost::currentCallFrameCallback):
2011-02-25 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
Make positioned objects work with all possible crazy combinations of mixed writing modes. Added new helper
functions that flip around the padding box of the containing block and then add in the appropriate border
side to ensure that the offset of the positioned object is actually correctly placed in the containing block's
local coordinate space.
Added two new tests of both replaced and non-replaced positioned elements in mixed writing mode environments.
* rendering/RenderBox.cpp:
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
2011-02-25 Brian Weinstein <bweinstein@apple.com>
Reviewed by Brady Eidson and looked over by Jessie Berlin.
WebKit2: Need a way to manage cookies from the web process
https://bugs.webkit.org/show_bug.cgi?id=55086
Implement the functions needed to manage cookies in CookieJar (getHostnamesWithCookies,
deleteCookiesWithHostname, and deleteAllCookies) for Mac and CFNetwork (stub out the rest),
and call them from WebKit2's WebCookieManager.
No change in behavior needing tests.
* WebCore.exp.in: Added needed functions to export.
* platform/CookieJar.h:
* platform/mac/CookieJar.mm:
(WebCore::getHostnamesWithCookies): Gets all hostnames with cookies from NSHTTPCookieStorage.
(WebCore::deleteCookiesForHostname): Deletes all cookies with a given hostname from
NSHTTPCookieStorage.
(WebCore::deleteAllCookies): Deletes all cookies from NSHTTPCookieStorage.
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::getHostnamesWithCookies): Implement using CFNetwork cookie APIs.
(WebCore::deleteCookiesForHostname): Ditto.
(WebCore::deleteAllCookies): Ditto.
* platform/efl/CookieJarEfl.cpp: Added stub functions.
* platform/haiku/CookieJarHaiku.cpp: Ditto.
* platform/network/android/CookieJarAndroid.cpp: Ditto.
* platform/network/chromium/CookieJarChromium.cpp: Ditto.
* platform/network/curl/CookieJarCurl.cpp: Ditto.
* platform/network/soup/CookieJarSoup.cpp: Ditto.
* platform/network/win/CookieJarWin.cpp: Ditto.
* platform/qt/CookieJarQt.cpp: Ditto.
2011-02-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
'load' and 'error' events fired for @poster
https://bugs.webkit.org/show_bug.cgi?id=54908
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::dispatchLoadEvent): Don't fire events when being used
by a video element.
2011-02-25 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
Patch computePositionedLogicalHeightReplaced to be writing-mode aware.
Added six new tests in fast/replaced.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
2011-02-25 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix.
* platform/text/brew/TextBreakIteratorBrew.cpp:
(WebCore::acquireLineBreakIterator):
* platform/text/wince/TextBreakIteratorWinCE.cpp:
(WebCore::acquireLineBreakIterator):
2011-02-25 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Simon Fraser.
Update the clip layer size whenever the root layer's size and position
is updated. This only affects the accelerated compositing path.
https://bugs.webkit.org/show_bug.cgi?id=55103
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
Test: platform/chromium/compositing/layout-width-change.html
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
2011-02-25 Ned Holbrook <nholbrook@apple.com>
Reviewed by Dan Bernstein.
Minimize calls to ubrk_setText()
https://bugs.webkit.org/show_bug.cgi?id=54912
<rdar://problem/9032774>
Avoid calling ubrk_setText() once per call to isBreakable() by using a LazyLineBreakIterator, which defers
break iterator creation until needed. This requires replacing the global line break iterator primitive with a
version that can be nested, since in some cases two iterators may need to be outstanding. In particular,
layoutInlineChildren() may indirectly call computePreferredLogicalWidths() and each may need an iterator.
In a test with a paragraph of Japanese text, this reduced the number of ubrk_setText() calls from 164 to 1.
* platform/text/TextBreakIterator.h: Add LazyLineBreakIterator.
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::~LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::string):
(WebCore::LazyLineBreakIterator::length):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
* platform/text/TextBreakIteratorICU.cpp: Replace lineBreakIterator() primitive with acquireLineBreakIterator()/releaseLineBreakIterator().
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* platform/text/brew/TextBreakIteratorBrew.cpp: Ditto.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* platform/text/gtk/TextBreakIteratorGtk.cpp: Ditto.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* platform/text/qt/TextBreakIteratorQt.cpp: Ditto.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* platform/text/wince/TextBreakIteratorWinCE.cpp: Ditto.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Pass a mapping of RenderText to LazyLineBreakIterator from one call of findNextLineBreak() to the next.
(WebCore::RenderBlock::findNextLineBreak): Use said mapping, resetting LazyLineBreakIterator for any newly-encountered RenderText.
* rendering/RenderText.cpp: Use a local LazyLineBreakIterator.
(WebCore::RenderText::computePreferredLogicalWidths):
* rendering/break_lines.cpp: Accept LazyLineBreakIterator rather than UniChar buffer.
(WebCore::nextBreakablePosition):
* rendering/break_lines.h: Accept LazyLineBreakIterator rather than UniChar buffer.
(WebCore::isBreakable):
2011-02-25 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
Patch computePositionedLogicalWidthReplaced to be writing-mode aware. Not testable yet, since the height function overwrites the values
in a vertical text environment.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
2011-02-25 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
When trying to find which lines to dirty for a changed child, make sure
that we do test if the adjacent next linebox contains that changed child
and if yes, dirty it. This can happen in cases when we have a word break
between text nodes.
https://bugs.webkit.org/show_bug.cgi?id=55206
Test: fast/text/word-break-next-linebox-not-dirty-crash-main.html
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
2011-02-25 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Add basic layout tests for the highlighter
https://bugs.webkit.org/show_bug.cgi?id=54751
Test: inspector/editor/highlighter-basics.html
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter.prototype.highlight):
2011-02-24 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Huge fonts in font preview
https://bugs.webkit.org/show_bug.cgi?id=55143
* inspector/front-end/FontView.js:
(WebInspector.FontView.prototype._createContentIfNeeded):
(WebInspector.FontView.prototype.show):
(WebInspector.FontView.prototype.resize):
(WebInspector.FontView.prototype._measureElement):
(WebInspector.FontView.prototype.updateFontPreviewSize):
2011-02-25 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Implement SVGColor/SVGPaint API
https://bugs.webkit.org/show_bug.cgi?id=55119
SVGColor::cssText() shouldn't return #RRGGBBAA colors
https://bugs.webkit.org/show_bug.cgi?id=48120
Rewrite SVGColor/SVGPaint to actually implement their desired setPaint/setColor/setURI APIs.
SVGPaint is a CSSValue, and its setPaint() function allows to switch to an arbitary paint type.
That means, unlike all other CSSValues, SVGColor/SVGPaint are mutable. That means changes to
their CSSValues should be reflected in the elements style as well as in the computed style.
This patch doesn't yet implement that, the stubbed-out method valueChanged() is what
needs to be implemented. For now you can grab a SVGColor/SVGPaint object through getCSSPropertyValue
and manipulate it, in every possible way (SVPaint.uri/paintType/colorType/color attributes are all sync'ed).
Switch to strict JS bindings (RequiresAllArguments=Raise, StrictTypeChecking) for both objects.
Enable proper serialization of colors through Color::serialized(), affects some testcases (#FF.. -> #ff..)
Add extensive tests of all SVGColor/SVGPaint API, currently shows some FAIL messages, as element style
<-> computed style is not live, after mutating SVGColor/SVGPaint. That will be implemented in a follow-up patch.
Tests: svg/dom/SVGColor.html
svg/dom/SVGPaint.html
* bindings/scripts/CodeGenerator.pm: Remove obsolete handling of "SVGPaintType", take ushort for paintType, as specified in the SVG 1.1 IDLs.
* bindings/scripts/CodeGeneratorJS.pm: Ditto.
* bindings/scripts/CodeGeneratorObjC.pm: Ditto.
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
* css/SVGCSSParser.cpp: Adapt to SVGPaint/SVGColor create() naming convention changes.
(WebCore::CSSParser::parseSVGValue):
(WebCore::CSSParser::parseSVGPaint):
(WebCore::CSSParser::parseSVGColor):
* svg/SVGColor.cpp: Rewrite to fully implement the SVGColor API, merge all constructors into one, use more descriptable create() naming convention.
(WebCore::valueChanged): Stub implementation, will land in a follow-up patch.
(WebCore::SVGColor::SVGColor):
(WebCore::SVGColor::setRGBColor):
(WebCore::SVGColor::colorFromRGBColorString):
(WebCore::SVGColor::setRGBColorICCColor):
(WebCore::SVGColor::setColor):
(WebCore::SVGColor::cssText):
* svg/SVGColor.h:
(WebCore::SVGColor::createFromString):
(WebCore::SVGColor::createFromColor):
(WebCore::SVGColor::color):
(WebCore::SVGColor::colorType):
(WebCore::SVGColor::~SVGColor):
(WebCore::SVGColor::setColor):
(WebCore::SVGColor::setColorType):
* svg/SVGColor.idl: Enable strict type checking.
* svg/SVGPaint.cpp: Rewrite to fully implement the SVGPaint API, merge all constructors into one, use more descriptable create() naming convention.
(WebCore::valueChanged): Stub implementation, will land in a follow-up patch.
(WebCore::colorTypeForPaintType):
(WebCore::SVGPaint::SVGPaint):
(WebCore::SVGPaint::setUri):
(WebCore::SVGPaint::defaultFill):
(WebCore::SVGPaint::defaultStroke):
(WebCore::SVGPaint::setPaint):
(WebCore::SVGPaint::cssText):
(WebCore::SVGPaint::matchesTargetURI):
* svg/SVGPaint.h:
(WebCore::SVGPaint::createUnknown):
(WebCore::SVGPaint::createNone):
(WebCore::SVGPaint::createCurrentColor):
(WebCore::SVGPaint::createColor):
(WebCore::SVGPaint::createURI):
(WebCore::SVGPaint::createURIAndColor):
(WebCore::SVGPaint::paintType):
(WebCore::SVGPaint::uri):
(WebCore::SVGPaint::create):
(WebCore::SVGPaint::isSVGPaint):
* svg/SVGPaint.idl: Enable strict type checking.
2011-02-25 Renata Hodovan <reni@webkit.org>
Reviewed by Nikolas Zimmermann.
FESpecularLightingElement changes doesn't require relayout.
https://bugs.webkit.org/show_bug.cgi?id=54451
When the FESpecularLightingElement receives an update message but the given value remains the same we don't need
to relayout the filter. Otherwise, the light source requests a repaint on the specular lighting filter.
Besides add ASSERTs to DiffuseLightElement::setFilterEffectAttribute as well to avoid lightSources being null.
No new tests are needed to check the repaint because it is covered by the dynamic update tests of FESpecularLighting.
We only test what happens if we remove the light source of specularLight.
Test: svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html
* platform/graphics/filters/FESpecularLighting.cpp:
(WebCore::FESpecularLighting::setSurfaceScale):
(WebCore::FESpecularLighting::setSpecularConstant):
(WebCore::FESpecularLighting::setSpecularExponent):
(WebCore::FESpecularLighting::setKernelUnitLengthX):
(WebCore::FESpecularLighting::setKernelUnitLengthY):
* platform/graphics/filters/FESpecularLighting.h:
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
(WebCore::SVGFEDiffuseLightingElement::lightElementAttributeChanged):
(WebCore::SVGFEDiffuseLightingElement::build):
* svg/SVGFEDiffuseLightingElement.h:
* svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::findLightElement):
(WebCore::SVGFELightElement::findLight):
(WebCore::SVGFELightElement::svgAttributeChanged):
* svg/SVGFELightElement.h:
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
(WebCore::SVGFESpecularLightingElement::svgAttributeChanged):
(WebCore::SVGFESpecularLightingElement::lightElementAttributeChanged):
(WebCore::SVGFESpecularLightingElement::build):
* svg/SVGFESpecularLightingElement.h:
2011-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Andreas Kling.
[Qt] Revert the support for QNAM affined to a different thread.
https://bugs.webkit.org/show_bug.cgi?id=55149
Qt 4.8 will have QNAM use its own thread internally by default,
no need to keep this complexity in WebKit.
This mainly reverts:
http://trac.webkit.org/changeset/73710
http://trac.webkit.org/changeset/73712
* WebCore.pro:
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::commitLoad):
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::setLoadMode):
(WebCore::QNetworkReplyHandler::abort):
(WebCore::QNetworkReplyHandler::release):
(WebCore::ignoreHttpError):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::sendQueuedItems):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyHandler::reply):
* platform/network/qt/QtNAMThreadSafeProxy.cpp: Removed.
* platform/network/qt/QtNAMThreadSafeProxy.h: Removed.
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::willLoadFromCache):
* platform/qt/CookieJarQt.cpp:
(WebCore::cookieJar):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
2011-02-25 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
FEBlendElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=55138
When the FEBlendElement receives an update message but the given value remains the same we don't need
to relayout the filter.
No new tests are needed because this modificiation is covered by the dynamic update tests of FEBlend.
* platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::setBlendMode):
* platform/graphics/filters/FEBlend.h:
* svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::setFilterEffectAttribute):
(WebCore::SVGFEBlendElement::svgAttributeChanged):
(WebCore::SVGFEBlendElement::synchronizeProperty):
* svg/SVGFEBlendElement.h:
2011-02-24 Daniel Bates <dbates@rim.com>
Reviewed by Antonio Gomes.
Clean up: Extract table height adjustment for <caption> into common function
https://bugs.webkit.org/show_bug.cgi?id=54936
We use similar logic for adjusting the height of a table with respect
to a top- and bottom-positioned <caption>. Instead, we should extract
the common code into a shared function.
No functionality changed. So no new tests.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::adjustLogicalHeightForCaption): Added.
(WebCore::RenderTable::layout): Extracted common code to adjust table height
with respect to the <caption> into RenderTable::adjustLogicalHeightForCaption().
* rendering/RenderTable.h:
2011-02-24 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Move draw time properties out of *LayerChromium to CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=55013
This adds a new type (tentatively named CCLayerImpl) responsible for drawing/compositing layers.
Currently LayerChromiums know about their CCLayerImpls and CCLayerImpls rely on the LayerChromium
tree for structure. In theory updates are a LayerChromium-only concept and draw is a CCLayerImpl-only
concept, but this patch doesn't go all there yet in the interest of keeping the patch small-ish.
RenderSurfaces are a CCLayerImpl-only concepts and no longer have any direct LayerChromium dependencies.
Note: I've put CCLayerImpl into a new 'cc' directory under platform/graphics/chromium/ and intentionally
not added it to the include path. We plan to add more compositor implementation details to this directory
and we want to keep accidental dependencies on these files to a minimum.
See https://bugs.webkit.org/show_bug.cgi?id=54047 for the big picture.
Refactor only, compositing/ tests cover these codepaths.
* WebCore.gypi:
* platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::draw):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::requiresClippedUpdateRect):
(WebCore::ContentLayerChromium::updateContentsIfDirty):
(WebCore::ContentLayerChromium::draw):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::cleanupResources):
(WebCore::LayerChromium::setLayerRenderer):
(WebCore::LayerChromium::setBounds):
(WebCore::LayerChromium::setFrame):
(WebCore::LayerChromium::setNeedsDisplay):
(WebCore::LayerChromium::setBorderColor):
(WebCore::LayerChromium::borderColor):
(WebCore::LayerChromium::setBorderWidth):
(WebCore::LayerChromium::borderWidth):
(WebCore::LayerChromium::layerRenderer):
(WebCore::LayerChromium::setDoubleSided):
(WebCore::LayerChromium::bounds):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::maskDrawLayer):
(WebCore::LayerChromium::ccLayerImpl):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::compareLayerZ):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updateLayersRecursive):
(WebCore::LayerRendererChromium::setCompositeOffscreen):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::draw):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
(WebCore::RenderSurfaceChromium::drawSurface):
(WebCore::RenderSurfaceChromium::draw):
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::drawYUV):
(WebCore::VideoLayerChromium::drawRGBA):
* platform/graphics/chromium/cc/CCLayerImpl.cpp: Added.
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
(WebCore::CCLayerImpl::superlayer):
(WebCore::CCLayerImpl::maskLayer):
(WebCore::CCLayerImpl::replicaLayer):
(WebCore::CCLayerImpl::setLayerRenderer):
(WebCore::CCLayerImpl::createRenderSurface):
(WebCore::CCLayerImpl::updateContentsIfDirty):
(WebCore::CCLayerImpl::drawsContent):
(WebCore::CCLayerImpl::draw):
(WebCore::CCLayerImpl::unreserveContentsTexture):
(WebCore::CCLayerImpl::bindContentsTexture):
(WebCore::CCLayerImpl::cleanupResources):
(WebCore::CCLayerImpl::getDrawRect):
(WebCore::CCLayerImpl::drawDebugBorder):
* platform/graphics/chromium/cc/CCLayerImpl.h: Added.
(WebCore::CCLayerImpl::create):
(WebCore::CCLayerImpl::setDebugBorderColor):
(WebCore::CCLayerImpl::debugBorderColor):
(WebCore::CCLayerImpl::setDebugBorderWidth):
(WebCore::CCLayerImpl::debugBorderWidth):
(WebCore::CCLayerImpl::layerRenderer):
(WebCore::CCLayerImpl::renderSurface):
(WebCore::CCLayerImpl::clearRenderSurface):
(WebCore::CCLayerImpl::drawDepth):
(WebCore::CCLayerImpl::setDrawDepth):
(WebCore::CCLayerImpl::drawOpacity):
(WebCore::CCLayerImpl::setDrawOpacity):
(WebCore::CCLayerImpl::scissorRect):
(WebCore::CCLayerImpl::setScissorRect):
(WebCore::CCLayerImpl::targetRenderSurface):
(WebCore::CCLayerImpl::setTargetRenderSurface):
(WebCore::CCLayerImpl::doubleSided):
(WebCore::CCLayerImpl::setDoubleSided):
(WebCore::CCLayerImpl::bounds):
(WebCore::CCLayerImpl::setBounds):
(WebCore::CCLayerImpl::drawTransform):
(WebCore::CCLayerImpl::setDrawTransform):
(WebCore::CCLayerImpl::drawableContentRect):
(WebCore::CCLayerImpl::setDrawableContentRect):
2011-02-24 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
REGRESSION (r79629): Non-expanding ruby base is start-aligned rather than centered
https://bugs.webkit.org/show_bug.cgi?id=55197
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust the line boundaries even
if there are no expansion opportunities. This allows RenderRubyBase to center itself.
2011-02-24 Darin Adler <darin@apple.com>
Reviewed by Alexey Proskuryakov.
REGRESSION (r79466): http/tests/incremental/slow-utf8-html.pl flaky due to incorrect assertions
https://bugs.webkit.org/show_bug.cgi?id=55135
* platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::decode): Removed incorrect assertions.
2011-02-24 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Image-based cursors do not work
https://bugs.webkit.org/show_bug.cgi?id=55184
* WebCore.exp.in: Exported new entry points now used by WebKit2.
2011-02-24 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
ImageBuffer::clip creates an image of the incorrect context in IOSurface case
https://bugs.webkit.org/show_bug.cgi?id=55170
Test: fast/canvas/2d.fillText.gradient.html
* platform/graphics/cg/ImageBufferCG.cpp: Clipping against ImageBuffer's context
instead of ourself (the passed in context).
2011-02-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
RenderBoxModelObject::paintBoxShadow should bail earlier
https://bugs.webkit.org/show_bug.cgi?id=55186
Make paintBoxShadow() bail early if there is no shadow, and make
callers consistent in not checking for box-shadow before calling it.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBoxDecorations):
2011-02-24 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Add a USE() macro to control use of the built-in UTF8 codec
https://bugs.webkit.org/show_bug.cgi?id=55189
Guards the built in UTF8 codec registration with USE(BUILTIN_UTF8_CODEC). ICU is used if the USE() is not set.
* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerEncodingNames):
* platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps):
2011-02-24 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
<rdar://problem/8902740> Expand ruby base when it is shorter than the ruby text
https://bugs.webkit.org/show_bug.cgi?id=55183
Test: fast/ruby/base-shorter-than-text.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::availableLogicalWidthForLine):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::adjustInlineDirectionLineBounds): Added. The base clase implementation does nothing.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::textAlignmentForLine): Added. Implements the logic that changes "justify" to "auto" for
the last line or a line that ends with a hard break.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Use textAlignmentForLine(), compute the available
width more efficiently, and call adjustInlineDirectionLineBounds() for justified lines.
* rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::rubyRun): Added.
(WebCore::RenderRubyBase::textAlignmentForLine): Added. Alwyas returns "justify".
(WebCore::RenderRubyBase::adjustInlineDirectionLineBounds): Added. Insets the line such that the inset is
half the width of a single intra-line expansion.
* rendering/RenderRubyBase.h:
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::addChild):
2011-02-24 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r79604.
http://trac.webkit.org/changeset/79604
https://bugs.webkit.org/show_bug.cgi?id=55017
Causes assertions to fail on some SVG tests
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
2011-02-24 Oliver Hunt <oliver@apple.com>
Build fix
* bindings/js/JSBindingsAllInOne.cpp:
2011-02-24 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
Rework the logical height computation for positioned elements to work in terms of before and after. That way the offset is determined from
the correct container side in flipped block writing modes (e.g., vertical-rl).
Patch locationOffsetIncludingFlipping to use the containing block to flip so that it will behave correctly with absolute/fixed positioned
elements.
Patch offsetFromContainer to use the flipped location offset for absolute/fixed positioned elements so that localToAbsolute works properly.
Added twelve tests in fast/block/positioning/vertical-rl and fast/block/positioning/vertical-lr.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::locationOffsetIncludingFlipping):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::logicalTop):
(WebCore::InheritedFlags::logicalBottom):
2011-02-23 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make WeakGCMap use new handle infrastructure
https://bugs.webkit.org/show_bug.cgi?id=55100
Update to new WeakGCMap APIs, this requires threading global
data to a few functions that did not need it in the past, but
also gets rid of a large number of destructors, as well as the
forgetDOMNode, etc APIs.
We can also drop the JSDebugWrapperSet as its only purpose was
to ensure that we retained correct semantics in the old WeakGCMap,
but happilly these semantics are now guaranteed by the map itself.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.cpp:
(WebCore::hasCachedDOMObjectWrapperUnchecked):
(WebCore::cacheDOMObjectWrapper):
(WebCore::hasCachedDOMNodeWrapperUnchecked):
(WebCore::cacheDOMNodeWrapper):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::takeWrappers):
(WebCore::updateDOMNodeDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):
(WebCore::stringWrapperDestroyed):
(WebCore::jsStringSlowCase):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWrapper.cpp:
(WebCore::DOMObject::~DOMObject):
* bindings/js/JSDebugWrapperSet.cpp: Removed.
* bindings/js/JSDebugWrapperSet.h: Removed.
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
* bridge/jsc/BridgeJSC.h:
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::~RuntimeObject):
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
(JSC::Bindings::RootObject::removeRuntimeObject):
* bridge/runtime_root.h:
2011-02-24 James Robinson <jamesr@chromium.org>
Fix chromium compile.
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::toStringCallback):
2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r79607.
http://trac.webkit.org/changeset/79607
https://bugs.webkit.org/show_bug.cgi?id=55157
Broke Chromium layout tests.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::updateVolumeSliderContainer):
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton):
* rendering/RenderMediaControls.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
* rendering/RenderTheme.h:
* rendering/RenderThemeChromiumMac.h:
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):
* rendering/RenderThemeWin.h:
2011-02-24 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fix the clang -Woverloaded-virtual build.
JSLocation has a toString function which conflicts with the virtual JSObject::toString member function.
Fix this by renaming the implementation function from JSLocation::toString to JSLocation::toStringFunction.
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::toStringFunction):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::toStringFunctionCallback):
* page/Location.idl:
2011-02-24 Anders Carlsson <andersca@apple.com>
Fix clang build.
* bindings/objc/WebScriptObject.mm:
(-[WebUndefined release]):
Release should be "oneway void".
(-[WebUndefined retainCount]):
Return NSUIntegerMax instead of UINT_MAX.
2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Simplify RenderTheme::volumeSliderOffsetFromMuteButton, unduplicate code.
https://bugs.webkit.org/show_bug.cgi?id=55157
Refactoring, no functional changes. Covered by existing tests.
RenderTheme::volumeSliderOffsetFromMuteButton has the same duplicated
logic for all platforms. This patch:
a) moves the common logic of determining absolute positioning to a
platform-agnostic place;
b) simplifies the method to return constant offset.
* html/shadow/MediaControls.cpp:
(WebCore::volumeSliderOffset): Added new helper function,
capturing common logic of finding the absolute position of the volume slider.
(WebCore::MediaControls::updateVolumeSliderContainer): Changed to use the
new helper.
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::volumeSliderOffsetRelativeToMuteButton): Simplified.
* rendering/RenderMediaControls.h: Ditto.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::volumeSliderOffsetRelativeToMuteButton): Ditto.
* rendering/RenderTheme.h: Ditto.
* rendering/RenderThemeChromiumMac.h: Ditto.
* rendering/RenderThemeChromiumMac.mm: Ditto.
(WebCore::RenderThemeChromiumMac::volumeSliderOffsetRelativeToMuteButton): Ditto.
* rendering/RenderThemeMac.h: Ditto.
* rendering/RenderThemeMac.mm: Ditto.
(WebCore::RenderThemeMac::volumeSliderOffsetRelativeToMuteButton): Ditto.
* rendering/RenderThemeWin.cpp: Ditto.
(WebCore::RenderThemeWin::volumeSliderOffsetRelativeToMuteButton): Ditto.
* rendering/RenderThemeWin.h: Ditto.
2011-02-24 Tom Sepez <tsepez@chromium.org>
Reviewed by Darin Fisher.
Make frameview resized event dispatch async so that it occurs
after layout has completed.
https://bugs.webkit.org/show_bug.cgi?id=54467
Test: fast/replaced/frame-removed-during-resize-smaller.html
* page/EventHandler.cpp:
(WebCore::EventHandler::sendResizeEvent):
2011-02-24 Xianzhu Wang <wangxianzhu@google.com>
Reviewed by Adam Barth.
Use loader->init() instead of loader->load() to avoid complex fake
request loading and cleanup logic, and also avoid ResourceLoader leaks.
https://bugs.webkit.org/show_bug.cgi?id=55017
Test: svg/misc/SVGImage-leak-ResourceLoader.html
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
Chromium Mac build fix after r79591.
* WebCore.gypi: Added RenderMediaControls to WebCore.gypi.
2011-02-24 Misha Tyutyunik <michael.tyutyunik@nokia.com>
Reviewed by Andreas Kling.
[Qt] Dont use QPixmapCache if QPixmapCache::cacheLimit() is too small
(2048Kb for now).
https://bugs.webkit.org/show_bug.cgi?id=54887
No new tests required.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::allowAcceleratedCompositingCache):
(WebCore::GraphicsLayerQtImpl::drawLayerContent):
(WebCore::GraphicsLayerQtImpl::paint):
(WebCore::GraphicsLayerQtImpl::flushChanges):
2011-02-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Nikolas Zimmermann.
[CAIRO] Support ImageBuffers clip operation on all Cairo ports
https://bugs.webkit.org/show_bug.cgi?id=23526
Add support for ImageBuffer clipping on Cairo by emulating them with image
masks. Since masking is immediate on Cairo, we must store the mask surfaces
on a stack and apply them during restorePlatformState.
* platform/graphics/GraphicsContext.h: Add pushImageMask.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::savePlatformState): Push an empty mask onto the
stack, so we can keep track of when to actually apply the image mask.
(WebCore::GraphicsContext::restorePlatformState): When we are ready to apply
an image mask, use cairo_mask_surface to mask the group that we pushed onto
our surface.
(WebCore::GraphicsContext::pushImageMask): Added. This method will push a surface
onto the image mask stack and push a group onto the Cairo state, so that the masking
only affects what we paint after this point.
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Added a class to keep
track of image masking information after calls to pushImageMask.
(WebCore::ImageMaskInformation::update): Added
(WebCore::ImageMaskInformation::valid): Added
(WebCore::ImageMaskInformation::maskSurface): Added
(WebCore::ImageMaskInformation::maskRect): Added
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::clip): Call GraphicsContext::pushImageMask.
2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
Add RenderMediaControls to Mac build, unduplicate one method.
https://bugs.webkit.org/show_bug.cgi?id=55152
Refactoring, no functional changes.
* WebCore.xcodeproj/project.pbxproj: Added RenderMediaControls to project,
ran sort-XCode-project-file.
* rendering/RenderMediaControls.cpp: Moved ENABLE(VIDEO) and PLATFORM(WIN)
defines to allow building on Mac.
* rendering/RenderMediaControls.h: Ditto.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Replaced guts
with a call to RenderMediaControls function.
2011-02-24 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r79584.
http://trac.webkit.org/changeset/79584
https://bugs.webkit.org/show_bug.cgi?id=44797
[chromium] Patch does not compile if ENABLE_FULLSCREEN_API is
not set
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
Do not cache the default cairo font options using a static
variable. It fixes a memory leak reported by valgrind.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::getDefaultFontOptions):
(WebCore::FontPlatformData::initializeWithFontFace):
2011-02-24 Andrew Wilson <atwilson@chromium.org>
Unreviewed, rolling out r79570.
http://trac.webkit.org/changeset/79570
https://bugs.webkit.org/show_bug.cgi?id=54874
Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated
* WebCore.exp.in:
2011-02-24 David Dorwin <ddorwin@chromium.org>
Reviewed by Eric Seidel.
Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.
fullscreen javascript bindings not implemented for v8
https://bugs.webkit.org/show_bug.cgi?id=44797
Tested by the existing fullscreen Layout Tests.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
2011-02-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move querySelectorAll from CSS agent to DOM agent where it belongs.
https://bugs.webkit.org/show_bug.cgi?id=55131
Test: inspector/elements/dom-agent-query-selector.html
* inspector/Inspector.idl:
* inspector/InspectorCSSAgent.cpp:
* inspector/InspectorCSSAgent.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::nodeToSelectOn):
(WebCore::InspectorDOMAgent::querySelector):
(WebCore::InspectorDOMAgent::querySelectorAll):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
2011-02-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fragment parsing does not need to use HTMLSourceTracker
https://bugs.webkit.org/show_bug.cgi?id=55011
Any performance gains from this patch are likely
the result of working around:
https://bugs.webkit.org/show_bug.cgi?id=55005
(Which suggests that fixing bug 55005 will speed
up normal HTML parsing substantially.)
Assuming I ran the numbers correct, here is the
change from PerformanceTests/Parser/tiny-innerHTML:
Before patch:
avg 5586.1
median 5594
stdev 41.295157101045135
min 5425
max 5633
After Patch:
avg 2603.9
median 2609.5
stdev 32.500615378789355
min 2475
max 2649
Removing just the HTMLSourceTracker calls brought our
score from 5500 to 5200, removing the XSSFilter as well
brought it to 2600 on my machine.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLDocumentParser.h:
2011-02-24 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement WebEventFactory, WebErrors classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48510
Exported static functions for GTK, we need them to create events
in WebKit2.
* platform/PlatformKeyboardEvent.h:
* platform/gtk/KeyEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::keyIdentifierForGdkKeyCode):
(WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode):
(WebCore::PlatformKeyboardEvent::singleCharacterString):
2011-02-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Remove the GFile GOwnPtr specialization
https://bugs.webkit.org/show_bug.cgi?id=55154
Convert uses of GOwnPtr<GFile> to GRefPtr<GFile>.
No new tests. This should not change behavior.
* plugins/gtk/PluginPackageGtk.cpp: Fix include order and remove unnecessary include.
(WebCore::PluginPackage::load): Use GRefPtr for GFile instead of GOwnPtr.
2011-02-24 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Rename PLATFORM(SKIA) to USE(SKIA)
https://bugs.webkit.org/show_bug.cgi?id=55090
* config.h: Removed second define of PLATFORM(SKIA).
* html/HTMLCanvasElement.cpp:
* platform/graphics/FloatPoint.h:
* platform/graphics/FloatRect.h:
* platform/graphics/Gradient.cpp:
* platform/graphics/Gradient.h:
* platform/graphics/GraphicsContext.cpp:
* platform/graphics/GraphicsContext.h:
* platform/graphics/ImageSource.h:
* platform/graphics/IntPoint.h:
* platform/graphics/IntRect.h:
* platform/graphics/Path.h:
* platform/graphics/Pattern.cpp:
* platform/graphics/Pattern.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/GLES2Canvas.cpp:
* platform/graphics/chromium/ImageLayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/LayerTilerChromium.cpp:
* platform/graphics/chromium/ShaderChromium.h:
* platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
* platform/graphics/transforms/AffineTransform.h:
* platform/graphics/transforms/TransformationMatrix.h:
* platform/image-decoders/ImageDecoder.cpp:
* platform/image-decoders/ImageDecoder.h:
* rendering/svg/RenderSVGResourceSolidColor.cpp:
2011-02-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up to 79566. USE_PARAM not declared
https://bugs.webkit.org/show_bug.cgi?id=55155
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::currentCallFrame):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::currentCallFrameCallback):
2011-02-24 Emil A Eklund <eae@chromium.org>
Reviewed by Simon Fraser.
Add support for missing properties to getComputedStyle
https://bugs.webkit.org/show_bug.cgi?id=23668
Implement getComputedStyle for the content, counter and outline-offset
properties.
Test: fast/css/getComputedStyle/computed-style-properties.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::contentToCSSValue):
(WebCore::counterToCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText):
* css/CSSPrimitiveValue.h:
2011-02-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
SegmentedString does not need an m_composite member
https://bugs.webkit.org/show_bug.cgi?id=55083
Storing m_composite as distinct from m_substrings.isEmpty()
was just error prone and eventually going to get us in trouble.
I also cleaned up some of the style in SegementedString.*
since this file long predates check-webkit-style.
* platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::length):
(WebCore::SegmentedString::setExcludeLineNumbers):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::toString):
* platform/text/SegmentedString.h:
(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::appendTo):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::isComposite):
2011-02-24 David Kilzer <ddkilzer@apple.com>
BUILD FIX: Add missing include for UnusedParam.h
Not reviewed.
* platform/mac/FileSystemMac.mm: Add include. It should have
originally been added with r76614.
2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Alexey Proskuryakov.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
No new tests. (no code affected, just exporting a method for DumpRenderTree use)
* WebCore.exp.in:
2011-02-24 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
Removing a SVG animation target during animation crashes WebKit
https://bugs.webkit.org/show_bug.cgi?id=12065
SVGAnimations with IRI references via 'xlink:href' are slow
https://bugs.webkit.org/show_bug.cgi?id=49437
Store reference to target element for SVG animation elements. This is important if the
target gets referenced via 'xlink:href'. At the moment we would call getElementById() multiple
times on every animation step. A very expensive operation. This will be avoided with this patch.
On the other hand, we need to be sure that the target element is always valid. The reference is
reset, if the target was removed from document or its destructor was called. A HashMap in
SVGDocumentExtensions stores all mappings from target element to all current animation elements.
Tests: svg/custom/animate-target-id-changed.svg
svg/custom/animate-target-removed-from-document.svg
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
(WebCore::SVGDocumentExtensions::addAnimationElementToTarget): New animation gets applied to target.
(WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget): Animation stoped, remove it from HashMap.
(WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget): Target no longer in document, reset all
references in SVG animation elements.
* svg/SVGDocumentExtensions.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::removedFromDocument):
(WebCore::SVGElement::attributeChanged):
* svg/SVGElement.h:
* svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::removedFromDocument):
* svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::removedFromDocument):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::SVGSMILElement):
(WebCore::SVGSMILElement::removedFromDocument):
(WebCore::SVGSMILElement::eventBaseFor):
(WebCore::SVGSMILElement::targetElement):
* svg/animation/SVGSMILElement.h:
(WebCore::SVGSMILElement::resetTargetElement):
2011-02-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel.
REGRESSION: Accelerated transitions are jumpy
https://bugs.webkit.org/show_bug.cgi?id=55022
When an accelerated transition used the default timing function,
a typo in toCAMediaTimingFunction() resulting in the incorrect
timing function being used.
Test: transitions/default-timing-function.html
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(toCAMediaTimingFunction):
2011-02-24 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove bogus optimizations in TextBreakIteratorQt
https://bugs.webkit.org/show_bug.cgi?id=55139
Let QTextBoundaryFinder hold a deep copy of the string data it's
operating on, and don't use the same working buffer for all iterators.
* platform/text/qt/TextBreakIteratorQt.cpp:
(WebCore::TextBreakIterator::TextBreakIterator):
(WebCore::setUpIterator):
2011-02-24 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Bug in the highlighter
https://bugs.webkit.org/show_bug.cgi?id=54876
Tests: inspector/editor/highlighter-long-line.html
inspector/editor/highlighter-paste-in-comment.html
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter):
(WebInspector.TextEditorHighlighter.prototype.set highlightChunkLimit):
(WebInspector.TextEditorHighlighter.prototype.updateHighlight):
(WebInspector.TextEditorHighlighter.prototype._highlightLines):
2011-02-24 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
[Web Timing] Zero out navigationStart and unloadEvent on cross-origin redirect
https://bugs.webkit.org/show_bug.cgi?id=55068
Test: http/tests/misc/webtiming-origins.html
* page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::navigationStart): Zero out on cross origin redirect.
(WebCore::PerformanceTiming::unloadEventStart): Ditto.
(WebCore::PerformanceTiming::unloadEventEnd): Ditto.
2011-02-24 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add code to WebKit Chromium to allow access to NetworkStateNotifier
https://bugs.webkit.org/show_bug.cgi?id=54516
Give Chromium's NetworkStateNotifier the ability to change the value
of m_isOnLine, rather than making it always true.
No new tests, not sure how to test this. No other LayoutTests seem
to exercise navigator.onLine.
* WebCore.gypi:
* platform/network/NetworkStateNotifier.cpp:
(WebCore::NetworkStateNotifier::setOnLine): Moved and renamed from NetworkStateNotifierAndroid.
* platform/network/NetworkStateNotifier.h:
(WebCore::NetworkStateNotifier::networkStateChange): Forward to setOnLine.
* platform/network/android/NetworkStateNotifierAndroid.cpp: Removed.
* platform/network/chromium/NetworkStateNotifierChromium.cpp: Removed.
* platform/network/chromium/NetworkStateNotifierPrivate.h: Removed.
2011-02-24 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Eric Seidel.
Support building WebKit with Python 3
https://bugs.webkit.org/show_bug.cgi?id=55038
Add support for Python 3 without breaking support for Python 2.
Main issues:
-print is a function in Python 3
-list.sort() no longer have the cmp parameter
-string.uppercase and string.lowercase have been removed
* html/parser/create-html-entity-table:
2011-02-24 Chris Fleizach <cfleizach@apple.com>
Reviewed by Eric Seidel.
AX: WebKit should expose MathML at least as well as it exposes ARIA role="math"
https://bugs.webkit.org/show_bug.cgi?id=55049
Make <math> elements behave as ARIA math roles and use MathML::alttext as a
possible accessible label.
Test: platform/mac/accessibility/math-alttext.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* mathml/mathattrs.in:
2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: adjust protocol message format according to spec.
https://bugs.webkit.org/show_bug.cgi?id=55140
* inspector/CodeGeneratorInspector.pm:
2011-02-24 Adam Roben <aroben@apple.com>
Windows Production build fix
* platform/network/cf/AuthenticationCF.cpp: Add an extra #include as a workaround for
<rdar://problem/9042114>.
2011-02-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: refactor inspect() workflow so that it did not push dom nodes.
https://bugs.webkit.org/show_bug.cgi?id=55057
Test: inspector/console/command-line-api-inspect.html
I am working on getting rid of DOM agent pushes - everything should happen upon
front-end request. This patch changes the way we handle inspect() command line
api: instead of pushing nodes, we are telling front-end that inspect(object) has
been requested. It is then up to front-end to request dom nodes and focus them in
the tree. I also made inspect() work in a generic manner, using same routines for
nodes, databases, storages and potentially new elements.
As a side-effect, we don't do console.log from within inspect() anymore, but dump
inspected value as inspect's result.
Also, I added individual object release method and made object groups optional.
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::scriptValueAsNode):
(WebCore::InjectedScriptHost::nodeAsScriptValue):
(WebCore::JSInjectedScriptHost::inspect):
(WebCore::JSInjectedScriptHost::databaseId):
(WebCore::JSInjectedScriptHost::storageId):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::scriptValueAsNode):
(WebCore::InjectedScriptHost::nodeAsScriptValue):
(WebCore::V8InjectedScriptHost::inspectCallback):
(WebCore::V8InjectedScriptHost::databaseIdCallback):
(WebCore::V8InjectedScriptHost::storageIdCallback):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::nodeForObjectId):
(WebCore::InjectedScript::releaseObject):
(WebCore::InjectedScript::wrapForConsole):
(WebCore::InjectedScript::inspectNode):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::inspectImpl):
(WebCore::InjectedScriptHost::databaseIdImpl):
(WebCore::InjectedScriptHost::storageIdImpl):
* inspector/InjectedScriptHost.h:
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::focusNode):
* inspector/InspectorDOMAgent.cpp:
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDOMStorageResource.cpp:
* inspector/InspectorDOMStorageResource.h:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::databaseId):
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDatabaseResource.cpp:
* inspector/InspectorDatabaseResource.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::releaseObject):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.evaluateInTargetWindow):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
* inspector/front-end/DOMStorage.js:
* inspector/front-end/Database.js:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
* inspector/front-end/inspector.js:
(WebInspector.inspect):
2011-02-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: refactor "script or resource" mess in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=54961
- Use sourceName instead of scriptOrResource
- Replace two huge functions _addScriptToFilesMenu and _showScriptOrResource that are
calling each other recursively with small one-purpose non-recursive functions
Test: inspector/debugger/scripts-panel.html
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
(WebInspector.ScriptsPanel.prototype._addScript):
(WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourceFrameIfNeeded):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype.canShowSourceLine):
(WebInspector.ScriptsPanel.prototype.showSourceLine):
(WebInspector.ScriptsPanel.prototype._showSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName):
(WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
(WebInspector.ScriptsPanel.prototype._addItemToBackForwardList):
(WebInspector.ScriptsPanel.prototype._sourceNameForScript):
(WebInspector.ScriptsPanel.prototype._scriptForSourceName):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.ScriptsPanel.prototype._filesSelectChanged):
(WebInspector.ScriptsPanel.prototype._goBack):
(WebInspector.ScriptsPanel.prototype._goForward):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.setExecutionLine):
2011-02-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fragment parsing does not need to use HTMLSourceTracker
https://bugs.webkit.org/show_bug.cgi?id=55011
Any performance gains from this patch are likely
the result of working around:
https://bugs.webkit.org/show_bug.cgi?id=55005
(Which suggests that fixing bug 55005 will speed
up normal HTML parsing substantially.)
Assuming I ran the numbers correct, here is the
change from PerformanceTests/Parser/tiny-innerHTML:
Before patch:
avg 5586.1
median 5594
stdev 41.295157101045135
min 5425
max 5633
After Patch:
avg 2603.9
median 2609.5
stdev 32.500615378789355
min 2475
max 2649
Removing just the HTMLSourceTracker calls brought our
score from 5500 to 5200, removing the XSSFilter as well
brought it to 2600 on my machine.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLDocumentParser.h:
2011-02-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] MinGW build fails to link
https://bugs.webkit.org/show_bug.cgi?id=55050
Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries
No new tests needed.
* WebCore.pri:
2011-02-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP's script-src should block JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=54787
Blocking JavaScript URLs required some re-architecting of the lifetime
of the ContentSecurityPolicy object. We now manage the lifetime the
same way we manage the lifetime of the SecurityOrigin object. In
particular, when SecurityOrigin inherits into an about:blank iframe, we
inherit the CSP object as well. (This is covered by the test added in
this patch.) In the future, we might consider making
ContentSecurityPolicy a component of SecurityOrigin instead of a
component of Document.
I noted the trickiness in
http://www.w3.org/Security/wiki/Content_Security_Policies so that we'll
make sure it gets defined properly in the spec.
Test: http/tests/security/contentSecurityPolicy/javascript-url.html
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
* dom/Document.h:
(WebCore::Document::contentSecurityPolicy):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
* page/ContentSecurityPolicy.h:
(WebCore::ContentSecurityPolicy::create):
2011-02-21 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] GRefPtr support for GstElement
https://bugs.webkit.org/show_bug.cgi?id=54870
* CMakeListsEfl.txt:
* GNUmakefile.am:
* platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Added.
(WTF::GstElement):
* platform/graphics/gstreamer/GRefPtrGStreamer.h: Added.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcQuery):
2011-02-24 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Share code between elementFromPoint and caretRangeFromPoint in Document.
https://bugs.webkit.org/show_bug.cgi?id=54610
Eliminate duplicate code by moving shared logic from elementFromPoint and
caretRangeFromPoint into helper function.
* dom/Document.cpp:
(WebCore::nodeFromPoint):
(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):
2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::removeAttribute):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::cachedResources):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
2011-02-24 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Eric Seidel.
[gtk] Failing collinear arcTo canvas tests
https://bugs.webkit.org/show_bug.cgi?id=54658
Check for collinearity of the three points that affect how arcTo call
results. This behavior is in accordance with the HTML standard.
No new tests added as this is already covered by at least two tests.
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::areaOfTriangleFormedByPoints):
(WebCore::Path::addArcTo):
2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: There is a validator of the protocol message format.
It has two parts. InspectorBackendStub.js is the frontend part.
InspectorBackendDispatcher.cpp is the backend part.
Both parts are checking protocol message format and report the error if
the message has not enough fields or the types of fields do not match with
Inspector.idl specification. These validators are generated automatically.
In addition, we have a number of places at the backend where we check the
function arguments and do nothing if the arguments are invalid
from the business logic point of view.
This patch bring us an ability to report a custom error from such function to the frontend.
https://bugs.webkit.org/show_bug.cgi?id=54971
* inspector/CodeGeneratorInspector.pm:
* inspector/InjectedScriptHost.cpp:
* inspector/InspectorAgent.cpp:
* inspector/InspectorAgent.h:
* inspector/InspectorApplicationCacheAgent.cpp:
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
* inspector/InspectorBrowserDebuggerAgent.h:
* inspector/InspectorCSSAgent.cpp:
* inspector/InspectorCSSAgent.h:
* inspector/InspectorConsoleAgent.cpp:
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
* inspector/InspectorDOMAgent.cpp:
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMStorageAgent.cpp:
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.cpp:
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorProfilerAgent.cpp:
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorResourceAgent.cpp:
* inspector/InspectorResourceAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
* inspector/InspectorRuntimeAgent.h:
* inspector/InspectorTimelineAgent.cpp:
* inspector/InspectorTimelineAgent.h:
2011-02-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Crash when deleting inside a blockquote with a large offset
https://bugs.webkit.org/show_bug.cgi?id=55098
The bug was caused by inconsistency in lineBreakExistsAtPosition and breakOutOfEmptyMailBlockquotedParagraph.
While lineBreakExistsAtPosition was checking that a line break exists at the downstream of the given position,
breakOutOfEmptyMailBlockquotedParagraph wasn't using the downstream for caretPos. Fixed the bug by using
the downstream position to instantiate caretPos.
Co-author: Abhishek Arya <inferno@chromium.org>.
Test: editing/deleting/delete-blockquote-large-offsets.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
2011-02-24 Robert Kroeger <rjkroege@chromium.org>
Reviewed by Darin Fisher.
Added timestamps to PlatformTouchEvent etc.
PlatformTouchEvent doesn't have a timestamp and so
eventSender.leapForward cannot be used for touchevent based tests.
This change adds a timestamp to PlatformTouchEvent and initializes
it in a reasonable manner on Android and Qt platforms.
[chromium] [WebCore] [android] Touch events are missing time stamps
https://bugs.webkit.org/show_bug.cgi?id=53510
* platform/PlatformTouchEvent.h:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
(WebCore::PlatformTouchEvent::timestamp):
* platform/android/PlatformTouchEventAndroid.cpp:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
* platform/qt/PlatformTouchEventQt.cpp:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
2011-02-24 Renata Hodovan <reni@webkit.org>
Unreviewed GTK, Snow Leopard build fix for r79474.
* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::setKernelUnitLength):
* platform/graphics/filters/FEConvolveMatrix.h:
2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
Use IntRect instead of a pointer to a GtkAllocation struct to avoid
unnecessary memory allocations.
* plugins/PluginView.h:
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::plugAddedCallback):
2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix the build with GTK+ 3.
* plugins/PluginView.h:
2011-02-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Refactor HTMLEquivalent into a hierachy of classes
https://bugs.webkit.org/show_bug.cgi?id=55025
Converted HTMLEquivalent into a class. Some logic in removeImplicitlyStyledElement is
extracted as member functions of HTMLEquivalent and its subclasses.
* editing/ApplyStyleCommand.cpp:
(WebCore::HTMLEquivalent::create): Added.
(WebCore::HTMLEquivalent::~HTMLEquivalent): Added.
(WebCore::HTMLEquivalent::matches): Returns true if the element is an equivalent, meaning that
the element's implicit style affects the property of this equivalence.
(WebCore::HTMLEquivalent::hasAttribute): Returns true if this equivalence requires attributes;
e.g. color, size, dir.
(WebCore::HTMLEquivalent::propertyExistsInStyle): Returns true if the property of this equivalence
exists in the specified style. e.g. if this equivalence is for size attribute and font-size property,
this function returns true if the specified style has font-size property set.
(WebCore::HTMLEquivalent::HTMLEquivalent): Added.
(WebCore::HTMLEquivalent::valueIsPresentInStyle): Returns true if the specified style has the
implicit style of the specified element of this equivalence.
(WebCore::HTMLEquivalent::addToStyle): Adds the implicit style of the element of this equivalence
to the specified mutable style.
(WebCore::HTMLEquivalentValueList::create): Added.
(WebCore::HTMLEquivalentValueList::HTMLEquivalentValueList): Added.
(WebCore::HTMLEquivalentValueList::valueIsPresentInStyle): Added.
(WebCore::HTMLEquivalentAttribute::create): Added.
(WebCore::HTMLEquivalentAttribute::matches): Added.
(WebCore::HTMLEquivalentAttribute::hasAttribute): Added.
(WebCore::HTMLEquivalentAttribute::attributeName): Added.
(WebCore::HTMLEquivalentAttribute::HTMLEquivalentAttribute): Added.
(WebCore::HTMLEquivalentAttribute::valueIsPresentInStyle): Added.
(WebCore::HTMLEquivalentAttribute::addToStyle): Added.
(WebCore::HTMLEquivalentAttribute::attributeValueAsCSSValue): Added.
(WebCore::HTMLEquivalentFontSizeAttribute::create): Added.
(WebCore::HTMLEquivalentFontSizeAttribute::HTMLEquivalentFontSizeAttribute): Added.
(WebCore::HTMLEquivalentFontSizeAttribute::attributeValueAsCSSValue): Added.
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Uses new classes.
2011-02-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79510.
http://trac.webkit.org/changeset/79510
https://bugs.webkit.org/show_bug.cgi?id=55114
It made ~200 tests crash on Qt bot (Requested by Ossy_ on
#webkit).
* platform/text/TextBreakIterator.h:
* platform/text/TextBreakIteratorICU.cpp:
(WebCore::lineBreakIterator):
* platform/text/qt/TextBreakIteratorQt.cpp:
(WebCore::lineBreakIterator):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::findNextLineBreak):
* rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths):
* rendering/break_lines.cpp:
(WebCore::nextBreakablePosition):
* rendering/break_lines.h:
(WebCore::isBreakable):
2011-02-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Used svn merge -r79502:79501 to roll out r79502 because it broke the
SnowLeopard and Leopard builds.
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/HTMLConverter.h: Removed.
* platform/mac/HTMLConverter.mm: Removed.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection):
2011-02-23 Beth Dakin <bdakin@apple.com>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/9002157> Garbage in the bottom right corner of the window
when scrolling
When there is both a horizontal and a vertical scrollbar, it is necessary to
include the space between them in the invalidation.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
2011-02-23 Ned Holbrook <nholbrook@apple.com>
Reviewed by Dan Bernstein.
Minimize calls to ubrk_setText()
https://bugs.webkit.org/show_bug.cgi?id=54912
<rdar://problem/9032774>
Avoid calling ubrk_setText() once per call to isBreakable() by using a LazyLineBreakIterator, which defers
break iterator creation until needed. This requires replacing the global line break iterator primitive with a
version that can be nested, since in some cases two iterators may need to be outstanding. In particular,
layoutInlineChildren() may indirectly call computePreferredLogicalWidths() and each may need an iterator.
In a test with a paragraph of Japanese text, this reduced the number of ubrk_setText() calls from 164 to 1.
* platform/text/TextBreakIterator.h: Add LazyLineBreakIterator.
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::~LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::string):
(WebCore::LazyLineBreakIterator::length):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
* platform/text/TextBreakIteratorICU.cpp: Replace lineBreakIterator() primitive with acquireLineBreakIterator()/releaseLineBreakIterator().
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* platform/text/qt/TextBreakIteratorQt.cpp: Ditto TextBreakIteratorICU.cpp.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Pass a mapping of RenderText to LazyLineBreakIterator from one call of findNextLineBreak() to the next.
(WebCore::RenderBlock::findNextLineBreak): Use said mapping, resetting LazyLineBreakIterator for any newly-encountered RenderText.
* rendering/RenderText.cpp: Use a local LazyLineBreakIterator.
(WebCore::RenderText::computePreferredLogicalWidths):
* rendering/break_lines.cpp: Accept LazyLineBreakIterator rather than TextBreakIterator.
(WebCore::nextBreakablePosition):
* rendering/break_lines.h: Accept LazyLineBreakIterator rather than TextBreakIterator.
(WebCore::isBreakable):
2011-02-23 Anders Carlsson <andersca@apple.com>
Fix build.
* platform/mac/HTMLConverter.h:
2011-02-17 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
REGRESSION: Copied content loses formatting on paste to external apps.
https://bugs.webkit.org/show_bug.cgi?id=47615
<rdar://problem/9001214>
This patch adds a way for WebKit2 to create NSAttributedStrings from
a DOM range without using the AppKit api initWithDOMRange that internally
needs to access the WebView. The NSAttributedString is needed to create
RTF formats in the pasteboard.
This is to be considered a first step, since in the future we want to have
an implementation based on the TextIterator.
* WebCore.xcodeproj/project.pbxproj: Added new file.
* platform/mac/HTMLConverter.h: Added.
* platform/mac/HTMLConverter.mm: Added.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
class for WebKit2 to create the NSAttributedString from the DOM range.
2011-02-23 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
Patch computePositionedLogicalHeightUsing to be writing-mode-aware.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
* rendering/RenderBox.h:
2011-02-23 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Flash item placed on wrong location right after load
https://bugs.webkit.org/show_bug.cgi?id=37769
If a plugin is GtkSocket based, do not set the widget allocation until the
window is actually embedded in the parent. When the window is embedded, use
any pending allocation for the call to gtk_widget_size_allocate. This bug
seems to only appear with Flash movies loaded as the src of an iframe.
* manual-tests/plugins/windowed-in-iframe.html: Added.
* plugins/PluginView.h: Add a few new members to track window embedding state.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::setNPWindowIfNeeded): If this is a GtkSocket-based plugin
wait until the plug-added signal fires to set the widget allocation.
(WebCore::PluginView::plugAddedCallback): Updated to be a static method, so that
we can access private members. If there is a pending allocation, call gtk_widget_size_allocate
with it.
(WebCore::PluginView::platformStart): Update the plugin state, so that we do not
call gtk_widget_size_allocate if the window isn't embedded.
2011-02-18 Enrica Casucci <enrica@apple.com>
Reviewed by Adam Roben.
Mac OS X Services are not available for selected text in WebKit2 windows.
https://bugs.webkit.org/show_bug.cgi?id=54777
<rdar://problem/8666428>
The changes to WebCore for this bug are limited to exposing a new
entry point in the Editor class to write to the pasteboard and
changes to the Pasteboard class to write the selection with
a given set of pasteboard types. The majority of the work
is done in WebKit2.
* WebCore.exp.in:
* editing/Editor.h:
* editing/mac/EditorMac.mm: Added entrypoint to write the
selection to the pasteboard.
(WebCore::Editor::writeSelectionToPasteboard):
* platform/Pasteboard.h:
* platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::writeRange):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection):
2011-02-23 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
Patch computePositionedLogicalHeight to be writing-mode-aware. Functions it calls have not been
patched yet, so still not testable in a vertical text environment.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalHeight):
2011-02-23 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
Patch computePositionedLogicalWidthUsing to be writing-mode-aware. Still not testable in a vertical text
environment, since height computations will overwrite all values computed here until they are patched as well.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
* rendering/RenderBox.h:
2011-02-23 Renata Hodovan <reni@webkit.org>
Reviewed by Nikolas Zimmermann.
FEColorMatrixElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=54880
When the FEColorMatrixElement receives an update message but the given value remains the same we don't need
to relayout the filter.
No new tests are needed because this modificiation is covered by the dynamic update tests of FEColorMatrix.
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::setType):
(WebCore::FEColorMatrix::setValues):
* platform/graphics/filters/FEColorMatrix.h:
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::setFilterEffectAttribute):
(WebCore::SVGFEColorMatrixElement::svgAttributeChanged):
* svg/SVGFEColorMatrixElement.h:
2011-02-23 James Robinson <jamesr@chromium.org>
REGRESSION(79466): fast/parser/test-unicode-characters-in-attribute-name.html fails
Reverts TextCodecUTF16.cpp back to pre-79466 state. The crash fix in 79466 was for UTF-8 only, it also caused the UTF16 path to fail.
* platform/text/TextCodecUTF16.cpp:
(WebCore::newStreamingTextDecoderUTF16LE):
(WebCore::newStreamingTextDecoderUTF16BE):
(WebCore::TextCodecUTF16::decode):
(WebCore::TextCodecUTF16::encode):
2011-02-23 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
Patch computePositionedLogicalWidth to be writing-mode-aware. Functions it calls have not been
patched yet, so still not testable in a vertical text environment.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth):
2011-02-23 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r79428.
http://trac.webkit.org/changeset/79428
https://bugs.webkit.org/show_bug.cgi?id=54714
Does not work in the Chromium sandbox
* websockets/WebSocketHandshake.cpp:
(WebCore::generateSecWebSocketKey):
(WebCore::generateKey3):
2011-02-23 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
Add logical accessors for the left()/right()/top()/bottom() properties on the RenderStyle.
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::logicalLeft):
(WebCore::InheritedFlags::logicalRight):
(WebCore::InheritedFlags::logicalTop):
(WebCore::InheritedFlags::logicalBottom):
2011-02-23 Darin Adler <darin@apple.com>
Reviewed by Alexey Proskuryakov.
Fix crash seen in one of the regression tests.
* platform/text/TextCodecUTF16.cpp:
(WebCore::TextCodecUTF16::decode): Handle case where we did not decode any new data,
we were not told to flush, and we had a buffered byte. The assertion here was incorrect,
and the correct thing to do is nothing.
2011-02-23 Sergey Glazunov <serg.glazunov@gmail.com>
Reviewed by James Robinson.
SVGCursorElement::removeClient() should verify that its argument is connected with
the proper cursor element.
https://bugs.webkit.org/show_bug.cgi?id=54979
Test: svg/css/multiple-cursors-crash.html
* svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::removeClient):
2011-02-23 Renata Hodovan <reni@webkit.org>
Reviewed by Darin Adler.
FEConvolveMatrixElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=55067
When the FEConvolveMatrixElement receives an update message but the
given value remains the same we don't need to relayout the filter.
No new tests are needed because this modificiation is covered by the
dynamic update tests of FEConvolveMatrix.
* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::setDivisor):
(WebCore::FEConvolveMatrix::setBias):
(WebCore::FEConvolveMatrix::setTargetOffset):
(WebCore::FEConvolveMatrix::edgeMode):
(WebCore::FEConvolveMatrix::setEdgeMode):
(WebCore::FEConvolveMatrix::setPreserveAlpha):
* platform/graphics/filters/FEConvolveMatrix.h:
* svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::setFilterEffectAttribute):
(WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
* svg/SVGFEConvolveMatrixElement.h:
2011-02-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Rolled back in r79367 with SnowLeopard Release bot crash fixed.
https://bugs.webkit.org/show_bug.cgi?id=54999
* ForwardingHeaders/wtf/DoublyLinkedList.h: Added.
2011-02-23 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Add more thorough manual test coverage for media controls
https://bugs.webkit.org/show_bug.cgi?id=55006
* manual-tests/media-controls.html: Added.
2011-02-23 Darin Adler <darin@apple.com>
Fix build.
* platform/text/TextCodecUTF16.cpp:
(WebCore::TextCodecUTF16::decode): Removed stray unused local variable.
2011-02-23 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Setting shadow host should also attach and set inDocument, just like
appending/inserting a child.
https://bugs.webkit.org/show_bug.cgi?id=55065
No new tests, because functionality is not yet used.
* dom/Element.cpp:
(WebCore::Element::setShadowRoot): Add attaching and setting inDocument
for the shadow DOM subtree, like the host.
2011-02-23 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler and Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
- Add clientLogicalWidth and clientLogicalHeight that call the correct clientWidth or clientHeight based off
writing-mode.
- Patch clientLogicalBottom to use clientLogicalHeight.
- Convert containingBlockWidthForPositioned and containingBlockHeightForPositioned to be logical and to make use of
clientLogicalHeight/Width. Also make them able to handle perpendicular writing mode containining blocks.
- Refine containingBlockLogicalHeightForPositioned to match containingBlockLogicalWidthForPositioned more closely.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
* rendering/RenderBox.h:
(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):
(WebCore::RenderBox::clientLogicalBottom):
2011-02-23 Darin Adler <darin@apple.com>
Reviewed by Alexey Proskuryakov.
REGRESSION (new UTF-8 decoder): Reproducible crash on alltommac.se
https://bugs.webkit.org/show_bug.cgi?id=54862
Correct handling of end of buffer partial sequence in UTF-8 and UTF-16 decoders when flushing with zero length
https://bugs.webkit.org/show_bug.cgi?id=54444
No new tests at this time. I will add some tests later, but since multiple
people are hitting this I wanted to get it in as quickly as possible.
* platform/text/TextCodecUTF16.cpp:
(WebCore::TextCodecUTF16::decode): Tweaked coding style quite a bit.
Removed special case for zero length now that main code handles it
correctly. Used words instead of abbreviations for local variable names.
Added error handling for a trailing byte.
* platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::consumePartialSequenceByte): Added. Helper function
to make the handleError and handlePartialSequence functions clearer.
(WebCore::TextCodecUTF8::handleError): Added. Helper function to make the
handlePartialSequence clearer.
(WebCore::TextCodecUTF8::handlePartialSequence): Added. Factored out code for
the partial sequence case. Making this a separate function probably helps make
the fast case a little faster. This new version handles more cases correctly,
which is what fixes the crashes we were seeing. In particular, it no longer
assumes that the partial sequence is truly partial, because there are cases
where we end up handling complete sequences here, such as when a complete
sequence is inside a malformed partial sequence.
(WebCore::TextCodecUTF8::decode): Removed partial sequence code and made this
call handlePartialSequence instead. Could be streamlined if we double checked
that passing a reference to "destination" and "source" doesn't harm code
generation too much, so perhaps someone can do that research on a few compilers
later and clean this up. Removed special case for zero length now that the
main code handles that correctly.
* platform/text/TextCodecUTF8.h: Added declarations for new functions.
Made partial sequence buffer large enough to hold a whole sequence so we can
use it to complete and decode a sequence in place.
2011-02-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Make clear float lineboxes resilient against overflows.
https://bugs.webkit.org/show_bug.cgi?id=54995
We try to dirty everthing in block range if we have a negative
logical bottom, or if our logical bottom is less than our logical
top, or if our logical top is equal to INT_MAX. Plus, we also dirty
a linebox if its block logical height is less than zero.
Tests: fast/overflow/overflow-height-float-not-removed-crash2.html
fast/overflow/overflow-height-float-not-removed-crash3.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::markLinesDirtyInBlockRange):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection): remove the hack
added in r69735. we don't need this anymore since we are making the
underlying float dirty logic resilient.
2011-02-22 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Per-page minimum DOMTimer interval broken for repeating timers
https://bugs.webkit.org/show_bug.cgi?id=55014
When the minimum timer interval is adjusted, if the timer is
repeating, cause its repeat interval to be set to its original
timeout clamped to the new minimum interval.
Tests: fast/dom/timer-increase-min-interval-repeating.html
fast/dom/timer-increase-then-decrease-min-interval-repeating.html
* page/DOMTimer.cpp:
(WebCore::DOMTimer::adjustMinimumTimerInterval):
2011-02-23 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
Fix two issues seen in WebKit2 views on Mac:
- <rdar://problem/8867831> WebKit2: Insertion points in form fields no longer blink
- <rdar://problem/8950362> REGRESSION (WebKit2): Cannot deselect text
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler): Initialize m_activationEventNumber
to -1. Since WebKit2 doesn�t support non-activating clicks yet (<http://webkit.org/b/55053>
<rdar://problem/9042197>) and doesn�t send event numbers, all events were considered to be
window-activating events. This in turn prevented them from clearing the selection and resuming
caret blinking on mouse up.
2011-02-23 Jacob Dinu <dinu.jacob@nokia.com>
Reviewed by Pavel Feldman.
Web Inspector: Linking error for some InspectorController symbols
https://bugs.webkit.org/show_bug.cgi?id=54953
Moved out hideHighlight definition from under JAVASCRIPT_DEBUGGER flag
* inspector/InspectorController.cpp:
(WebCore::InspectorController::hideHighlight):
(WebCore::InspectorController::resume):
2011-02-23 Hans Wennborg <hans@chromium.org>
IndexedDB: Move some SQL code into IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=54889
The idea is to gather all the SQL logic into IDBBackingStore.
No new functionality, so no new tests.
* storage/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore):
(WebCore::runCommands):
(WebCore::createTables):
(WebCore::createMetaDataTable):
(WebCore::getDatabaseSchemaVersion):
(WebCore::migrateDatabase):
(WebCore::IDBBackingStore::open):
(WebCore::IDBBackingStore::extractIDBDatabaseMetaData):
(WebCore::IDBBackingStore::setIDBDatabaseMetaData):
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::IDBBackingStore::createObjectStore):
(WebCore::doDelete):
(WebCore::IDBBackingStore::deleteObjectStore):
(WebCore::whereSyntaxForKey):
(WebCore::bindKeyToQuery):
(WebCore::IDBBackingStore::getObjectStoreRecord):
(WebCore::bindKeyToQueryWithNulls):
(WebCore::IDBBackingStore::putObjectStoreRecord):
(WebCore::IDBBackingStore::deleteIndexDataForRecord):
(WebCore::IDBBackingStore::putIndexDataForRecord):
(WebCore::IDBBackingStore::createIndex):
(WebCore::IDBBackingStore::deleteIndex):
(WebCore::IDBBackingStore::clearObjectStore):
* storage/IDBBackingStore.h:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
(WebCore::IDBFactoryBackendImpl::addIDBBackingStore):
(WebCore::IDBFactoryBackendImpl::removeIDBBackingStore):
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore::populateIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
2011-02-23 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix the Symbian build after r79334
https://bugs.webkit.org/show_bug.cgi?id=55044
No new tests as there is no new functionality.
* WebCore.pri: Reorder symbian blocks to make sure that
system-sqlite is set before it is tested.
Copy the rules from JavaScriptCore.pri for defineTest().
2011-02-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Alexey Proskuryakov.
Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=54992
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readHTTPHeaders):
2011-02-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Move platform dependent files out of main CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=53891
Apple Windows port does not use the image decoders,
so move them into the platform specific CMake files.
* CMakeLists.txt:
* CMakeListsEfl.txt:
* CMakeListsWinCE.txt:
2011-02-21 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Jittering when animating a rotated image
https://bugs.webkit.org/show_bug.cgi?id=50775
Since Skia does not seem to suffer from pixel cracks when scaling to
non-integral sizes the way CG does, no-op roundToDevicePixels on the
Skia implementation.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):
2011-02-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[WINCE] Get rid of TemporaryLinkStubs.cpp
https://bugs.webkit.org/show_bug.cgi?id=54825
* CMakeListsWinCE.txt:
* platform/network/win/CookieStorageWin.cpp: Copied from platform/wince/TemporaryLinkStubs.cpp.
* platform/wince/TemporaryLinkStubs.cpp: Removed.
2011-02-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Rename PLATFORM(CF) to USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=53540
* WebCore.gyp/WebCore.gyp:
* editing/SmartReplace.cpp:
* editing/SmartReplaceICU.cpp:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse):
(WebCore::MainResourceLoader::didReceiveData):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::didFail):
* loader/archive/ArchiveFactory.cpp:
(WebCore::archiveMIMETypes):
* platform/FileSystem.h:
* platform/KURL.h:
* platform/KURLGoogle.cpp:
* platform/RunLoopTimer.h:
* platform/SharedBuffer.cpp:
* platform/SharedBuffer.h:
* platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
* platform/network/ResourceHandle.h:
* platform/network/ResourceRequestBase.h:
* platform/network/curl/ResourceHandleCurl.cpp:
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::certificatePath):
* platform/text/cf/StringCF.cpp:
* platform/text/cf/StringImplCF.cpp:
* platform/win/BString.cpp:
* platform/win/BString.h:
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getWebLocData):
(WebCore::getURL):
(WebCore::getClipboardData):
* platform/win/ClipboardWin.cpp:
(WebCore::writeFileToDataObject):
* platform/win/SearchPopupMenuWin.cpp:
(WebCore::SearchPopupMenuWin::enabled):
(WebCore::SearchPopupMenuWin::saveRecentSearches):
(WebCore::SearchPopupMenuWin::loadRecentSearches):
2011-02-23 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ojan Vafai.
Moving or selecting backwards by words jumps to start of contenteditable region if contenteditable=false span is encountered
https://bugs.webkit.org/show_bug.cgi?id=51001
Test: editing/selection/extend-backward-by-word-over-non-editable.html
Revert some previous changes (the TextIteratorEndsAtEditingBoundary text iteration behaviour) which caused this
bug in the first place, and fix SimplifiedBackwardsTextIterator's iteration range check as an alternative fix.
The original bug was that double-clicking on an inline editable span at the start of a paragraph would clear the
selection (webkit.org/b/36360). This was caused by upstream/downstream VisbiblePosition complications. To fix,
refuse to iterate beyond the start node (rather than refusing to iterate across editable boundaries, which
causes this bug).
To see why this is correct, and to make it clearer that is indeed what is happening, the text iterator code has
been slightly restructured to express the invariant that the iterator will never advance past the start node.
* editing/TextIterator.cpp:
(WebCore::TextIterator::TextIterator): Remove references to TextIterationEndsAtEditing boundary.
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Remove m_pastStartNode as the
mechanism for iteration range checking, and use a flag m_havePassedStartNode instead.
(WebCore::SimplifiedBackwardsTextIterator::advance): Clean up, use advanceRespectingRange and
m_havePassedStartNode for iteration range checking rather than m_pastStartNode.
(WebCore::SimplifiedBackwardsTextIterator::advanceRespectingRange): The new way of modifying m_node
which updates m_havePassedStartNode and refuses to continue when it becomes true.
* editing/TextIterator.h: Remove TextIteratorEndsAtEditingBoundary, update for new/removed prototypes and
member variables.
* editing/visible_units.cpp:
(WebCore::previousBoundary): Remove references to TextIteratorEndsAtEditingBoundary.
2011-02-23 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
WebSocket uses insecure random numbers
https://bugs.webkit.org/show_bug.cgi?id=54714
* websockets/WebSocketHandshake.cpp:
(WebCore::randomNumberLessThan):
(WebCore::generateSecWebSocketKey):
(WebCore::generateKey3):
2011-02-21 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Rename IDBSQLiteDatabase to IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=54864
No new functionality, so no new tests.
* GNUmakefile.am:
* WebCore.gypi:
* storage/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore):
(WebCore::IDBBackingStore::~IDBBackingStore):
* storage/IDBBackingStore.h:
(WebCore::IDBBackingStore::create):
(WebCore::IDBBackingStore::db):
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::currentRowExists):
(WebCore::IDBCursorBackendImpl::database):
* storage/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::sqliteDatabase):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):
* storage/IDBDatabaseBackendImpl.h:
(WebCore::IDBDatabaseBackendImpl::create):
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::removeIDBBackingStore):
(WebCore::openSQLiteDatabase):
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::sqliteDatabase):
* storage/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::create):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::sqliteDatabase):
* storage/IDBObjectStoreBackendImpl.h:
(WebCore::IDBObjectStoreBackendImpl::create):
2011-02-23 Dominic Mazzoni <dmazzoni@google.com>
Reviewed by Kenneth Russell.
Add a hit test handler for canvas elements that handles clicks on the canvas but ignores children.
https://bugs.webkit.org/show_bug.cgi?id=54697
New test to prevent this from regressing in the future: canvas/canvas-mouse-events.html
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::nodeAtPoint):
2011-02-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Remove obsolete focusRingColor functions
https://bugs.webkit.org/show_bug.cgi?id=54824
* CMakeListsWinCE.txt:
* platform/graphics/haiku/ColorHaiku.cpp:
* platform/graphics/wince/ColorWinCE.cpp: Removed.
2011-02-22 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
On Mac OS X, English contractions are marked misspelled with certain user preference setting.
https://bugs.webkit.org/show_bug.cgi?id=54975
manual test: manual-tests/autocorrection/spellcheck-on-contraction-when-autocorrection-is-off.html
Without this patch, we check for contraction only when autocorrection or other type of auto-
substituation is on. And we failed to check for contraction if only spellchecking is turned on.
This patch implements the desired behavior, checking for contraction when either correction/substitution,
or spellchecking, is on.
* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
* manual-tests/autocorrection/spellcheck-on-contraction-when-autocorrection-is-off.html: Added.
2011-02-22 Charlie Reis <creis@chromium.org>
Reviewed by Darin Fisher.
Remove DatabasePolicy from FrameLoaderTypes
https://bugs.webkit.org/show_bug.cgi?id=54968
The DatabasePolicy enum is no longer needed now that we avoid stopping
loaders on same-document navigations.
Existing test: storage/hash-change-with-xhr.html
* WebCore.exp.in:
* loader/DocumentLoader.cpp:
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
* loader/FrameLoader.h:
* loader/FrameLoaderTypes.h:
* workers/WorkerThread.cpp:
2011-02-22 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QWebView ignores a palette set with QWebView::setPalette()
https://bugs.webkit.org/show_bug.cgi?id=31742
Use custom QWebView palette if the view provides one.
Modified version of a patch made by Fabrizio Machado.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformFocusRingColor):
2011-02-22 Brian Salomon <bsalomon@google.com>
Reviewed by Kenneth Russell.
Don't disable accelerated canvas when using the skia gpu backend.
No new tests are required.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
2011-02-22 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] <select>s on http://www.ryanair.com render wrong
https://bugs.webkit.org/show_bug.cgi?id=29647
Reducing padding in <select> elements to improve its rendering and introducing a
rendering adjustment specific to QMacStyle.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::setPopupPadding):
(WebCore::RenderThemeQt::paintMenuList):
2011-02-22 Andreas Kling <kling@webkit.org>
Reviewed by Dan Bernstein.
FontCache: Make cTargetInactiveFontData an int instead of float.
https://bugs.webkit.org/show_bug.cgi?id=54963
* platform/graphics/FontCache.cpp:
2011-02-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Make Editor::selectionComputedStyle return EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=54933
Renamed selectionComputedStyle to selectionStartStyle and changed the return type to EditingStyle.
It also no longer takes a boolean shouldUseFixedFontDefaultSize.
Also added EditingStyle::mergeTypingStyle which replaced old editingStyleIncludingTypingStyle. This function
doesn't extract inheritable properties prior to merge because this turned out be a bug, which was revealed
by an existing layout test only after the code was shared with selectionStartStyle.
No tests are added since this is a refactoring.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs): Calls EditingStyle::create and EditingStyle::mergeTypingStyle.
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
* editing/EditingStyle.cpp: Removed editingStyleIncludingTypingStyle.
(WebCore::EditingStyle::mergeTypingStyle): Added.
* editing/EditingStyle.h:
(WebCore::EditingStyle::shouldUseFixedDefaultFontSize): Added.
* editing/Editor.cpp:
(WebCore::Editor::selectionStartHasStyle): Calls selectionStartStyle.
(WebCore::Editor::selectionHasStyle): Ditto.
(WebCore::Editor::selectionStartCSSPropertyValue): Ditto.
(WebCore::Editor::selectionStartStyle): Renamed from selectionComputedStyle; returns EditingStyle.
* editing/Editor.h:
* editing/EditorCommand.cpp:
(WebCore::executeToggleStyleInList): Calls selectionStartStyle.
* editing/InsertLineBreakCommand.cpp:
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Calls EditingStyle::create and
EditingStyle::mergeTypingStyle.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Ditto.
2011-02-22 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] painting of windowed plugins faulty on certain scroll events
https://bugs.webkit.org/show_bug.cgi?id=52735
Invalidate the pluginview's relative rect rather then the frameRect(). This is because QWebFrame::renderRelativeCoords()
imitates ScrollView and adds the scroll offset back on to the rect we damage here (making the co-ordinates absolute
to the frame again) before passing it to FrameView.
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
Minimal build broken
https://bugs.webkit.org/show_bug.cgi?id=54743
Moved the code of setInspectorExtensionAPI and
dispatchMessageFromFrontend out of #if
ENABLE(JAVASCRIPT_DEBUGGER) to fix link error of the minimal build.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setInspectorExtensionAPI):
(WebCore::InspectorController::dispatchMessageFromFrontend):
2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79367.
http://trac.webkit.org/changeset/79367
https://bugs.webkit.org/show_bug.cgi?id=55012
all layout tests are crashing on Snow Leopard (Requested by
rniwa on #webkit).
* ForwardingHeaders/wtf/DoublyLinkedList.h: Removed.
2011-02-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Deploy EditingStyle in removeInlineStyleFromElement and removeCSSStyle
https://bugs.webkit.org/show_bug.cgi?id=54944
Deployed EditingStyle in removeInlineStyleFromElement and removeCSSStyle.
Also extracted EditingStyle::conflictsWithInlineStyleOfElement from ApplyStyleCommand::removeCSSStyle,
which returns true iff the specified element has inline style that conflicts or matches the editing style.
It also appends conflicting property IDs to the vector of property IDs if one is specified.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle): Calls removeCSSStyle.
(WebCore::ApplyStyleCommand::applyInlineStyle): Calls shouldSplitTextElement.
(WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls removeInlineStyleFromElement.
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
(WebCore::ApplyStyleCommand::removeCSSStyle): Ditto; extracted the logic to decide properties to remove as
conflictsWithInlineStyleOfElement.
(WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Calls shouldRemoveInlineStyleFromElement.
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls removeInlineStyleFromElement.
(WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
(WebCore::ApplyStyleCommand::shouldSplitTextElement): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
* editing/ApplyStyleCommand.h:
(WebCore::ApplyStyleCommand::shouldRemoveInlineStyleFromElement): Ditto.
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Extracted from ApplyStyleCommand::removeCSSStyle.
* editing/EditingStyle.h:
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Added.
2011-02-22 Chang Shu <cshu@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] editing/deleting/5408255.html fails
https://bugs.webkit.org/show_bug.cgi?id=54964
Move WebCore resource file to QtWebKit since they are referred in WebKit.
* WebCore.pro:
2011-02-22 Brady Eidson <beidson@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.
Implement these to be used by WK2 API:
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::getOriginsWithCache):
(WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):
2011-02-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
https://bugs.webkit.org/show_bug.cgi?id=54999
New WTF header.
* ForwardingHeaders/wtf/DoublyLinkedList.h: Copied from ForwardingHeaders/wtf/FixedArray.h.
2011-02-22 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=54991
Scrollbar::nativeTheme()->usesOverlayScrollbars() should not be consulted for CSS
Scrollbars
-and corresponding-
<rdar://problem/9034318>
Instead of consulting the theme directly, callers should ask the Scrollbar or
ScrollableArea if the scrollbars are overlay or not.
* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
(WebCore::ScrollableArea::hasOverlayScrollbars):
* platform/ScrollableArea.h:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::isOverlayScrollbar):
* platform/Scrollbar.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::verticalScrollbarWidth):
* rendering/RenderScrollbar.h:
(WebCore::RenderScrollbar::isOverlayScrollbar):
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Move inspector's resource files into the final build step to fix the layout test regression.
No new tests needed.
* WebCore.pro: Move inspector's resource files into QtWebKit.pro.
2011-02-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/frames/iframe-scale-applied-twice.html fails after r79167
https://bugs.webkit.org/show_bug.cgi?id=54990
No new tests. This will cause fast/events/scroll-after-click-on-tab-index.html
to start passing again.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::visibleContentRect): Update this method to match the original
in the parent class.
2011-01-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
https://bugs.webkit.org/show_bug.cgi?id=49177
* platform/ScrollView.cpp: Remove the GTK+ guards around the implementation
of platformAddChild and platformRemoveChild. This code can be shared.
* platform/gtk/MainFrameScrollbarGtk.cpp:
(MainFrameScrollbarGtk::attachAdjustment): Prevent re-attaching an already attached
adjustment. Connect the adjustment value-changed signal handler after resetting the
adjustment. This prevents the rest from stomping on pre-existing WebCore values.
(MainFrameScrollbarGtk::gtkValueChanged): If the scrollbar is no longer attached to
a scrollview do not listing for value changes. These scrollbars are defunct.
* platform/gtk/ScrollViewGtk.cpp: Remove duplicated empty methods.
2011-02-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: refactor InjectedScript : InspectorDOMAgent interaction.
https://bugs.webkit.org/show_bug.cgi?id=54954
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::toNode):
(WebCore::JSInjectedScriptHost::inspect):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::toNode):
(WebCore::V8InjectedScriptHost::inspectCallback):
* inspector/CodeGeneratorInspector.pm:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::nodeForObjectId):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::inspect):
* inspector/InjectedScriptHost.h:
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::focusNode):
* inspector/InspectorAgent.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::inspect):
(WebCore::InspectorDOMAgent::pushNodeToFrontend):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.evaluateInTargetWindow):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNodes):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):
(WebInspector.DOMDispatcher.prototype.inspectElementRequested):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.pushNodeToFrontend):
2011-02-22 Brady Eidson <beidson@apple.com>
Reviewed by Anders Carlsson.
Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.
Stub these out for now:
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::getOriginsWithCache):
(WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):
(WebCore::ApplicationCacheStorage::deleteAllEntries): Moved implementation here from WebKit/Mac
* loader/appcache/ApplicationCacheStorage.h:
Export the new symbols:
* WebCore.exp.in:
2011-02-22 Anders Carlsson <andersca@apple.com>
Fix debug build.
* WebCore.exp.in:
2011-02-22 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Anders Carlsson.
notImplemented() should behave identical in WebCore and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54449
No functional change so no new tests.
* WebCore.xcodeproj/project.pbxproj: Add NotImplemented.h as private header
to be able to use it in WebKit2.
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
Rubber-stamped by Csaba Osztrogonác.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
The patch landed in r79320 didn't contain the cleanup
which was already addressed in the last attachment.
No new tests needed.
* WebCore.pri: Add common LIB and CONFIG options.
* WebCore.pro: Add accidentally moved sections.
2011-02-22 Philippe Normand <pnormand@igalia.com>
Unreviewed, rolling out r79321.
http://trac.webkit.org/changeset/79321
https://bugs.webkit.org/show_bug.cgi?id=53146
Regresses fast/forms/listbox-typeahead-cyrillic.html and fast
/spatial-navigation/snav-single-select.html on GTK
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::notifyChildrenSelectionChange):
(WebCore::AXObjectCache::postPlatformNotification):
2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Inspector.IDL change. rename attribute notify -> event.
https://bugs.webkit.org/show_bug.cgi?id=54958
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
2011-02-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Timeline agent should have same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54951
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::domContentLoadedEventFired):
(WebCore::InspectorAgent::loadEventFired):
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::startTimelineProfiler):
(WebCore::InspectorController::stopTimelineProfiler):
(WebCore::InspectorController::timelineProfilerEnabled):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::retrieveTimelineAgent):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::setFrontend):
(WebCore::InspectorTimelineAgent::clearFrontend):
(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::startTimelineProfiler):
(WebCore::InspectorTimelineAgent::stopTimelineProfiler):
(WebCore::InspectorTimelineAgent::timelineProfilerStarted):
(WebCore::InspectorTimelineAgent::didCommitLoad):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::clearRecordStack):
* inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::create):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: flakyness of inspector tests.
https://bugs.webkit.org/show_bug.cgi?id=54729
As far as we have the protocol with sequence numbers we can simplify test harness support
and drop out chomium specific methods.
* inspector/CodeGeneratorInspector.pm:
* inspector/front-end/TestController.js:
(WebInspector.TestController):
(WebInspector.TestController.prototype.notifyDone):
(WebInspector.TestController.prototype.runAfterPendingDispatches):
(WebInspector.TestController.prototype._evaluateForTestInFrontend):
* inspector/front-end/inspector.js:
(WebInspector.dispatch):
2011-02-22 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146
Emit the selection-changed signals when the menu list value has changed
Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::getListObject): New, return the right list object for
menu lists and list boxes.
(WebCore::notifyChildrenSelectionChange): Support menu lists.
(WebCore::AXObjectCache::postPlatformNotification): Call function
notifyChildrenSelectionChange for AXMenuListValueChanged.
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
No new tests needed.
* WebCore.pri: Add needed rules for handling the static library.
* WebCore.pro: Reorganize API and linker options to QtWebKit.pro.
2011-02-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] navigation does not work when inspector is opened.
https://bugs.webkit.org/show_bug.cgi?id=54947
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::loadFromCookie):
* inspector/InspectorState.h:
2011-02-15 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays
https://bugs.webkit.org/show_bug.cgi?id=46142
Push a LayoutStateMaintainer in RenderMedia::layout() before calling layout() on the
container elements. This is necessary because, during layout(), the child renderers
query the current LayoutState to determine where they will be repainting. If a new
LayoutState is not pushed here, child renderers will attempt to repaint relative to
their grandparent's origin instead of their parents', and repaint operations will fail.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
2011-02-22 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Cleaning: remove a overzealous check for the pointer "files" from Chrome::setToolTip()
https://bugs.webkit.org/show_bug.cgi?id=54952
Remove the unnecessary condition from the if(), HTMLInputElement::files() always return
a valid reference for the input type FileInputType.
* page/Chrome.cpp:
(WebCore::Chrome::setToolTip):
2011-02-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract source mapping from SourceFrame to DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=54645
This is needed to map one script to several source files.
Test: inspector/debugger/source-frame.html
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/DebuggerPresentationModel.js: Added.
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceName):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
(WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation):
(WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._breakpointAdded):
(WebInspector.ScriptsPanel.prototype._breakpointRemoved):
(WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
(WebInspector.ScriptsPanel.prototype._sourceFrameForScript):
(WebInspector.ScriptsPanel.prototype._addSourceFrame):
(WebInspector.ScriptsPanel.prototype._removeSourceFrame):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
(WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.SourceFrameContentProviderForScript.prototype._buildSource):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.get loaded):
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype._setTextViewerDecorations):
(WebInspector.SourceFrame.prototype.setExecutionLine):
(WebInspector.SourceFrame.prototype.clearExecutionLine):
(WebInspector.SourceFrame.prototype.addBreakpoint):
(WebInspector.SourceFrame.prototype.removeBreakpoint):
(WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
(WebInspector.SourceFrame.prototype._findBreakpoint.filter):
(WebInspector.SourceFrame.prototype._findBreakpoint):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-02-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit
https://bugs.webkit.org/show_bug.cgi?id=54671
- factored toolbar handling out of inspector.js
- added toolbar dropdown
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreatePanel):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.get toolbarItem):
* inspector/front-end/Toolbar.js: Added.
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.resize):
(WebInspector.Toolbar.prototype.addPanel):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDragEnd):
(WebInspector.Toolbar.prototype._toolbarDrag):
(WebInspector.Toolbar.prototype._onClose):
(WebInspector.Toolbar.prototype._setDropdownVisible):
(WebInspector.Toolbar.prototype._toggleDropdown):
(WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown):
(WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.createPanelToolbarItem):
(WebInspector.ToolbarDropdown):
(WebInspector.ToolbarDropdown.prototype.show):
(WebInspector.ToolbarDropdown.prototype.hide):
(WebInspector.ToolbarDropdown.prototype.get visible):
(WebInspector.ToolbarDropdown.prototype._populate):
(WebInspector.ToolbarDropdown.prototype._onKeyDown):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(#toolbar):
(.toolbar-item):
(.toolbar-item.toggleable):
(.toolbar-item.toggleable.toggled-on):
(#toolbar-dropdown .toolbar-icon):
(#toolbar-dropdown .toolbar-label):
(#toolbar-controls):
(#toolbar-dropdown-arrow):
(body.attached #toolbar-dropdown-arrow):
(#toolbar-dropdown-arrow.dropdown-visible):
(#toolbar-dropdown-arrow:hover):
(#toolbar-dropdown-arrow:active):
(#toolbar-dropdown):
(body.detached.platform-mac-snowleopard #toolbar-dropdown):
(#toolbar-dropdown .scrollable-content):
(#toolbar-dropdown .toolbar-item):
(#toolbar-dropdown .toolbar-item.toggleable.toggled-on):
(#toolbar-dropdown .toolbar-item:hover):
(#toolbar-dropdown .toolbar-item.toggleable.toggled-on:hover):
(#toolbar-dropdown .toolbar-item:active .toolbar-icon):
(.scrollable-content):
(.scrollable-content::-webkit-scrollbar):
(.scrollable-content::-webkit-resizer):
(.scrollable-content::-webkit-scrollbar-thumb:vertical):
(.scrollable-content::-webkit-scrollbar-thumb:vertical:active):
(.scrollable-content::-webkit-scrollbar-track:vertical):
(.toolbar-search-item):
(#search):
(body.attached #search):
(#search-results-matches):
(#close-button-left, #close-button-right):
(.close-left):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.set attached):
(WebInspector.addPanel):
(WebInspector.windowResize):
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Added new headers and removed references to deleted files.
* GNUmakefile.am:
2011-02-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: make DOM storage and Database agents have the same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54891
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::createFrontendLifetimeAgents):
(WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::instrumentingAgents):
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::setFrontend):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::selectDOMStorage):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
(WebCore::InspectorDOMStorageAgent::clearResources):
* inspector/InspectorDOMStorageAgent.h:
(WebCore::InspectorDOMStorageAgent::create):
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::clearResources):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::setFrontend):
(WebCore::InspectorDatabaseAgent::clearFrontend):
(WebCore::InspectorDatabaseAgent::databaseForId):
(WebCore::InspectorDatabaseAgent::selectDatabase):
* inspector/InspectorDatabaseAgent.h:
(WebCore::InspectorDatabaseAgent::create):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
(WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
2011-02-22 Steve Lacey <sjl@chromium.org>
Reviewed by Darin Fisher.
Rename new media statistics apis to better names
https://bugs.webkit.org/show_bug.cgi?id=54784
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitAudioDecodedByteCount):
(WebCore::HTMLMediaElement::webkitVideoDecodedByteCount):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitDecodedFrameCount):
(WebCore::HTMLVideoElement::webkitDroppedFrameCount):
* html/HTMLVideoElement.h:
* html/HTMLVideoElement.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::decodedFrameCount):
(WebCore::MediaPlayer::droppedFrameCount):
(WebCore::MediaPlayer::audioDecodedByteCount):
(WebCore::MediaPlayer::videoDecodedByteCount):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::decodedFrameCount):
(WebCore::MediaPlayerPrivateInterface::droppedFrameCount):
(WebCore::MediaPlayerPrivateInterface::audioDecodedByteCount):
(WebCore::MediaPlayerPrivateInterface::videoDecodedByteCount):
2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 54435 - Simplify CSSStyleSelector::canShareStyleWithElement
https://bugs.webkit.org/show_bug.cgi?id=54435
Changed the function to a series of early-exit 'if's,
removed most temporary variables.
No new tests. (refactoring)
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54923
Rename PopupContainer::show() to showInRect(), to make it obvious it's
not an override of ScrollView::show().
No intended functionality change.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::showInRect):
(WebCore::PopupMenuChromium::show):
* platform/chromium/PopupMenuChromium.h:
2011-02-21 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Antti Koivisto.
Improve the local{SharedStyle,CousinList} algorithm
https://bugs.webkit.org/show_bug.cgi?id=45507
This change improves the algorithm to find shared styles: the old
algorithm would stop the search after the first cousin, even if
the search threshold is not met. As such, the algorithm would
systematically miss sharings across second cousins and beyond.
The new algorithm continues the search, as long as threshold is
not met. It also separates the threshold for sibling/cousins
search, from that on the levels of search, which is easier to
optimize.
The new algorithm finds up to 30% more sharings on some sites
(e.g. amazon.com and rakuten.co.jp) with no noticeable slowdown.
No new test, refactoring only.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::locateSharedStyle):
While changing the algorithm, cleaned up the style of those 2 methods
(use early return, renamed some variables).
* css/CSSStyleSelector.h:
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
RenderTableCell::baselinePosition() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54922
RenderTableCell::baselinePosition() has the same name as a virtual
method in superclass RenderBlock. Rename the subclass method to make
it clear it's not an attempted override.
No intended functionality change.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::cellBaselinePosition):
* rendering/RenderTableCell.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
2011-02-21 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
start/end of selection for RTL
https://bugs.webkit.org/show_bug.cgi?id=54724
On mac, the selection should always grow when extending by a boundary granularity (line/paragraph/document).
This is achieved by extending from the start for the "left" direction (e.g. pressing left arrow key), or
extending from the end when for the "right" direction (e.g. pressing right arrow key).
However, this has a bug for RTL text, which should actually extend from the *end* when extending left (since
direction is obviously reversed) and likewise extend from the start when extending right.
* editing/SelectionController.cpp:
(WebCore::SelectionController::modify):
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
ImageDocument::imageChanged() confuses clang's -Woverride-virtual
https://bugs.webkit.org/show_bug.cgi?id=54924
Rename ImageDocument::imageChanged() to imageUpdated() to make clear
that it's not an override of CachedResourceClient::imageChanged().
* html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::appendBytes):
(WebCore::ImageDocumentParser::finish):
(WebCore::ImageDocument::imageUpdated):
* html/ImageDocument.h:
2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 54934 - Sort the WebCore project file(s)
https://bugs.webkit.org/show_bug.cgi?id=54934
No new tests. (no code affected)
* GNUmakefile.am:
* WebCore.xcodeproj/project.pbxproj:
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
canAccommodateEllipsis() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54909
Rename the overload in RootInlineBox to lineCanAccomodateEllipsis() to
unconfuse clang. No intended functionality change.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkLinesForTextOverflow):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyLineClamp):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineCanAccommodateEllipsis):
* rendering/RootInlineBox.h:
2011-02-21 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Fix for for https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows
Test: updated fast/forms/placeholder-position.html and tested manually
Consider padding and margin for the results and cancel buttons. This is important for the Windows
theme which uses padding to correctly position those buttons. This change fixes the placeholder
position, and also better aligns the results popup list with the actual text you type.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Kent Tamura.
GIFImageDecoder::setSize() tries to override the superclass method but fails
https://bugs.webkit.org/show_bug.cgi?id=54305
The superclass uses unsigned instead of int for its parameters, so
GIFImageDecoder::setSize() was an overload, not an override.
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::setSize):
* platform/image-decoders/gif/GIFImageDecoder.h:
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Deploy EditingStyle more in ApplyStyleCommand and do some cleanup
https://bugs.webkit.org/show_bug.cgi?id=54528
* editing/ApplyStyleCommand.cpp:
(WebCore::StyleChange::init): Allows style to be a null pointer.
(WebCore::ApplyStyleCommand::applyInlineStyle): Overrides the value of text-decoration property by that of
-webkit-text-decorations-in-effect and remove the latter property when present. This allows removeImplicitlyStyledElement
to ignore -webkit-text-decorations-in-effect. Also uses the return value of EditingStyle::textDirection to determine
whether or not we need to apply unicode-bidi / direction instead of directly checking the value of unicode-bidi property.
(WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Ditto.
(WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Ditto.
(WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
(WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Ditto.
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Ditto.
(WebCore::ApplyStyleCommand::removeInlineStyle): Ditto; no longer collapse text decoration properties because
ApplyStyleCommand::applyInlineStyle already does it.
* editing/ApplyStyleCommand.h:
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::textDirection): Exits early when m_mutableStyle is null.
(WebCore::EditingStyle::collapseTextDecorationProperties): Extracted from ApplyStyleCommand::removeInlineStyle.
* editing/EditingStyle.h:
2011-02-21 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler and Alexey Proskuryakov.
<http://webkit.org/b/54919> / <rdar://problem/7689300> WebCore should retrieve unclamped frame delays from ImageIO
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameDurationAtIndex): Look for the unclamped frame delay in the
frame properties dictionary and use that if it exists. If it does not exist in the
dictionary then fall back to using the clamped frame delay.
2011-02-21 James Kozianski <koz@chromium.org>
Reviewed by Kent Tamura.
Causes elements to be unfocusable after tabindex property is removed.
https://bugs.webkit.org/show_bug.cgi?id=54727
Test: fast/html/tabindex-removal.html
* dom/Node.cpp:
(WebCore::Node::clearTabIndexExplicitly):
* dom/Node.h:
* dom/NodeRareData.h:
(WebCore::NodeRareData::clearTabIndexExplicitly):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
2011-02-21 Alexey Proskuryakov <ap@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/8995483> Remove stubs of unneeded NSURLAuthenticationChallengeSender methods
* platform/network/mac/AuthenticationMac.mm: Remove the stubs that are no longer needed.
2011-02-21 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Overhang areas need to be invalidated on scroll
<rdar://problem/9032194>
https://bugs.webkit.org/show_bug.cgi?id=54917
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
We need to explicitly invalidate the overhang areas when we scroll the contents
of a ScrollView, since they could contain arbitrary content that cannot be blitted.
2011-02-21 Lucas Forschler <lforschler@apple.com>
Reviewed by Stephanie Lewis.
Fix the Leopard Debug build by incorporating the RenderSVGAllInOne.cpp
No new tests required.
* WebCore.xcodeproj/project.pbxproj:
2011-02-21 Pratik Solanki <psolanki@apple.com>
Reviewed by Darin Adler.
Remove global initializer in CookieStorageCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54905
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):
2011-02-18 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: Media document videos play only sound, no video (affects trailers.apple.com)
https://bugs.webkit.org/show_bug.cgi?id=54771
Now that video is accelerated, we no longer need to special case
video playing within a media document.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
(WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering):
2011-02-21 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Roben.
REGRESSION (WebKit2): HTTP requests time out after 60 seconds
https://bugs.webkit.org/show_bug.cgi?id=54755
<rdar://problem/9006592>
No new tests - it won't be great to have a test that runs for a minute.
It's now possible to set a default timeout to be used at ResourceRequest creation. If one
hasn't been set, ResourceRequest will behave as before (use NSURLRequest default on Mac,
or use INT_MAX on other platforms).
* WebCore.exp.in:
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::defaultTimeoutInterval): Get the ResourceRequest notion of
default timeout interval (may be 0 if using NSURLRequest default).
(WebCore::ResourceRequestBase::setDefaultTimeoutInterval): Set the static member variable.
(WebCore::ResourceRequestBase::updatePlatformRequest): Added an assertion that resource
request is updated. Plaform code often calls updateResourceRequest() indirectly from this
function, and that must obviously be a no-op.
(WebCore::ResourceRequestBase::updateResourceRequest): Added an assertion in the opposite
direction.
* platform/network/ResourceRequestBase.h: Changed "unspecifiedTimeoutInterval" to
"defaultTimeoutInterval". It has been used as default by most platforms anyway.
(WebCore::ResourceRequestBase::ResourceRequestBase):
* platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):
Now zero is the magic value, not INT_MAX. We'll use NSURLRequest default if neither
setTimeoutInterval() nor setDefaultTimeoutInterval() has been called.
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
https://bugs.webkit.org/show_bug.cgi?id=54895
Correct the GTK+ clipboard implementation to know that "text" is an alias
for "text/html" data. This corrects the failing test.
* platform/gtk/ClipboardGtk.cpp:
(WebCore::dataObjectTypeFromHTMLClipboardType): Accept "text" as well as "Text".
(WebCore::ClipboardGtk::types): Advertise "text" as well as "Text".
2011-02-21 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
ProcessingInstruction should provide a way to know if it is of CSS type.
https://bugs.webkit.org/show_bug.cgi?id=54868
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::ProcessingInstruction):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::setCSSStyleSheet):
* dom/ProcessingInstruction.h:
(WebCore::ProcessingInstruction::isCSS):
2011-02-21 Simon Fraser <simon.fraser@apple.com>
Put JSDOMImplementationCustom.cpp where it belongs in the project.
* WebCore.xcodeproj/project.pbxproj:
2011-02-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 54894 - Make inheritance structure described by ClassInfo match C++ class hierarchy.
The ClassInfo objects describe an inheritance hierarchy, with each ClassInfo instance
containing a pointer to its parent class. These links should reflect the inheritance
hierarchy of C++ classes below JSObject. For the large part it does, but in some cases
entries in the C++ hierarchy are skipped over. This presently likely doesn't matter,
since intervening C++ classes may not have ClassInfo - but would be a potential bug
were ClassInfo were to be added.
* bindings/js/JSAudioConstructor.cpp:
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSImageConstructor.cpp:
* bindings/js/JSOptionConstructor.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/objc/objc_runtime.mm:
* bridge/runtime_object.cpp:
2011-02-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: navigation does not work after reopening frontend.
https://bugs.webkit.org/show_bug.cgi?id=54879
Test: http/tests/inspector-enabled/open-close-open.html
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::setFrontend):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::unmute):
* inspector/InspectorState.h:
2011-02-21 Adam Roben <aroben@apple.com>
Protect the PluginView when evaluating javascript: URLs
Fixes <http://webkit.org/b/54884> <rdar://problem/9030864>
plugins/get-url-with-javascript-destroying-plugin.html crashing on Windows since it was
added
Reviewed by Sam Weinig.
* plugins/PluginView.cpp:
(WebCore::PluginView::performRequest): Protect the PluginView, not just its parent frame,
when evaluating javascript: URLs.
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Fix GTK+ build after r79223.
* GNUmakefile.am: Add file missing from the source list.
2011-02-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: audits should not warn about gzip compression for 304s
https://bugs.webkit.org/show_bug.cgi?id=54343
Do not run compression-related audits on 304 resources.
Drive-by: handle multi-encoding resources (Content-Encoding: sdhc,gzip) correctly.
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.GzipRule.prototype._isCompressed):
2011-02-08 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth and Alexey Proskuryakov.
Propagate security origin of parent document into HTML documents created with DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=53611
This restores invariant that JS wrappers residing in the same JS context should come
from the same security origin.
Absence of regressions is covered by the current tests. Different security origin of
DOMImplementation is difficult to check with layout tests as DOMImplementation
resides in the same JS context as parent document and therefore there are no security origin checks.
This is observable however in C++.
* Android.jscbindings.mk:
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/v8/V8GCController.cpp:
(WebCore::NodeGrouperVisitor::visitDOMWrapper):
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::DOMImplementation):
(WebCore::DOMImplementation::createDocument):
* dom/DOMImplementation.h:
(WebCore::DOMImplementation::create):
(WebCore::DOMImplementation::documentDestroyed):
(WebCore::DOMImplementation::parentDocument):
* dom/DOMImplementation.idl:
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::implementation):
* dom/Document.h:
2011-02-21 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Optimize editing updates in gutter panel
https://bugs.webkit.org/show_bug.cgi?id=54866
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.set startEditingListener):
(WebInspector.TextViewer.prototype.set endEditingListener):
(WebInspector.TextViewer.prototype.endUpdates):
(WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
(WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
(WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
(WebInspector.TextEditorGutterPanel.prototype._expandChunks):
(WebInspector.TextEditorGutterPanel.prototype.textChanged):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
2011-02-21 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Audits] Image dimensions in inline style not checked
https://bugs.webkit.org/show_bug.cgi?id=54738
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
2011-02-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: create and destroy DOM agent along with InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54875
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InstrumentingAgents.h: Added. Agents that want to instrument WebCore should register themselve
on this object.
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::~InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
(WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
(WebCore::InstrumentingAgents::inspectorConsoleAgent):
(WebCore::InstrumentingAgents::setInspectorConsoleAgent):
(WebCore::InstrumentingAgents::inspectorDOMAgent):
(WebCore::InstrumentingAgents::setInspectorDOMAgent):
(WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
(WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
(WebCore::InstrumentingAgents::inspectorDatabaseAgent):
(WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
(WebCore::InstrumentingAgents::inspectorDebuggerAgent):
(WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
(WebCore::InstrumentingAgents::inspectorProfilerAgent):
(WebCore::InstrumentingAgents::setInspectorProfilerAgent):
(WebCore::InstrumentingAgents::inspectorResourceAgent):
(WebCore::InstrumentingAgents::setInspectorResourceAgent):
(WebCore::InstrumentingAgents::inspectorRuntimeAgent):
(WebCore::InstrumentingAgents::setInspectorRuntimeAgent):
(WebCore::InstrumentingAgents::inspectorStorageAgent):
(WebCore::InstrumentingAgents::setInspectorStorageAgent):
(WebCore::InstrumentingAgents::inspectorTimelineAgent):
(WebCore::InstrumentingAgents::setInspectorTimelineAgent):
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::createFrontendLifetimeAgents):
(WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::domContentLoadedEventFired):
(WebCore::InspectorAgent::loadEventFired):
* inspector/InspectorAgent.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::~InspectorCSSAgent):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
(WebCore::InspectorConsoleAgent::clearFrontend):
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorDOMAgent.cpp: DOM agent now lives even when the front-end is not attached.
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::setFrontend): Add DOM agent to the set of active agents when the front-end
is attached.
(WebCore::InspectorDOMAgent::clearFrontend):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
2011-02-21 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Andreas Kling.
[Qt][V8]REGRESSION(r79157): Fix build
https://bugs.webkit.org/show_bug.cgi?id=54871
* bridge/npruntime_internal.h: Add one more undef because of evil X11 macro.
2011-02-16 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Mihai Parparita.
[V8] SerializedScriptValue: fix JS exception handling.
https://bugs.webkit.org/show_bug.cgi?id=54555
Added checks for exceptions and empty handles:
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::Serializer::Serializer):
(WebCore::Serializer::serialize):
(WebCore::Serializer::checkException):
(WebCore::Serializer::reportFailure):
(WebCore::Serializer::ArrayState::advance):
(WebCore::Serializer::AbstractObjectState::AbstractObjectState):
(WebCore::Serializer::AbstractObjectState::advance):
(WebCore::Serializer::push):
(WebCore::Serializer::handleError):
(WebCore::Serializer::newObjectState):
(WebCore::Serializer::doSerialize):
(WebCore::SerializedScriptValue::SerializedScriptValue):
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Add selectionchange event
https://bugs.webkit.org/show_bug.cgi?id=45712
Added the support for asynchronous selectionchange event, which is fired whenever selection is changed.
This event is not cancelable and does not bubble. An event listener can be attached to a document by
body element's onselectionchange attribute or via document's onselectionchange property.
Note that WebKit's implementation fires the event asynchronously whereas Internet Explorer's implementation
fires it synchronously. This implies that a script that modify selection (e.g. via selection's addRange)
will not observe the event before the control returns to JavaScript.
See also: http://msdn.microsoft.com/en-us/library/ms536968(VS.85).aspx
Tests: fast/events/selectionchange-iframe.html
fast/events/selectionchange-user-initiated.html
* dom/Document.cpp:
(WebCore::Document::enqueueDocumentEvent): Added.
* dom/Document.h: Added selectionchange event listener.
* dom/Document.idl: Added onselectionchagne attribute.
* dom/EventNames.h: Added selectionchange
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection): Fires selectionchange event.
* html/HTMLAttributeNames.in: Added onselectionchange.
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseMappedAttribute): Handles onselectionchange attribute.
2011-02-21 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: protocol error messages are dumping incorrectly in Layout tests.
https://bugs.webkit.org/show_bug.cgi?id=54859
* inspector/CodeGeneratorInspector.pm:
2011-02-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: generate protocol documentation based on IDL.
https://bugs.webkit.org/show_bug.cgi?id=54822
* inspector/CodeGeneratorInspector.pm:
2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
Reviewed by Martin Robinson.
[GStreamer] Add URI queries support in webkitwebsrc
https://bugs.webkit.org/show_bug.cgi?id=54627
This allow replying to URI queries from downstream elements
with the uri currently set in the source element.
No new tests, this feature is dedicated to internal GStreamer use,
such as the upcoming HTTP Live Streaming element.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcQuery):
2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
Reviewed by Martin Robinson.
[GStreamer] Add 'location' property in webkitwebsrc
https://bugs.webkit.org/show_bug.cgi?id=54628
No new tests, this feature is dedicated to internal GStreamer use,
such as the upcoming HTTP Live Streaming element.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_class_init):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
Done the rename. All calls to node() are replaced by calls to deprecatedNode() except when
calls were of the form node()->document() and node()->inDocument() in which case they were
replaced by anchorNode()->document() and anchorNode()->inDocument() respectively.
* WebCore.exp.in: Added Position::containerNode.
The rest abbreviated for simplicity. Please see svn log.
2011-02-20 Gavin Barraclough <barraclough@apple.com>
Build fix (remove includes).
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSHistoryCustom.cpp:
* bindings/js/JSLocationCustom.cpp:
2011-02-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=54839
Remove PrototypeFunction, NativeFunctionWrapper, and GlobalEvalFunction.
Historically, Native functions used to be represented by PrototypeFunctions, however
since introducing call optimizations to the JIT this has used JSFunctions for host
calls too. At the point this change was made, the interpreter continued to use
PrototypeFunctions, however since fallback from the JIT to interpreter was introduced
the interpreter has had to be able to run using host functions represented using
JSFunctions - leading to an unnecessary and redundant divergence in behaviour between
interpreter only builds, and situations where the JIT has fallen back to interpreting.
NativeFunctionWrapper only existed to select between PrototypeFunction and JSFunction
for wrappers for host functions, and as such can also be removed.
GlobalEvalFunction is a redundant wrapper that happens to be derived from
PrototypeFunction. It existed to hold a reference to the global object - but since all
functions how derive from JSObjectWithGlobalObject, this no longer requires an
additional class to provide this functionality.
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSHistoryCustom.cpp:
* bindings/js/JSLocationCustom.cpp:
Removed use of redundant classes.
2011-02-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79169.
http://trac.webkit.org/changeset/79169
https://bugs.webkit.org/show_bug.cgi?id=54846
Made unexpected results for tests without CJK characters
(Requested by tkent on #webkit).
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
* platform/graphics/chromium/FontPlatformDataChromiumWin.h:
(WebCore::FontPlatformData::orientation):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
2011-02-20 Chun-Lung Huang <alvincl.huang@gmail.com>
Reviewed by Kent Tamura.
On Chromium Windows, glyphs in vertical text tests are rotated 90
degrees clockwise. https://bugs.webkit.org/show_bug.cgi?id=51450
This platform dependent patch makes Chromium Windows show the
vertical writing text correctly. Job was done by adding a prefix '@'
in front of the font family name (Windows Only). No new tests added.
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
* platform/graphics/chromium/FontPlatformDataChromiumWin.h:
(WebCore::FontPlatformData::orientation):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
2011-02-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dirk Schulze.
REGRESSION (r73369-r73405): transform animation interpolates incorrectly
https://bugs.webkit.org/show_bug.cgi?id=54793
After the refactoring in r73380, the ending state for some types of
accelerated animations was computed incorrectly, because the TransformationMatrix
wasn't reset to identity before the ending value transformations were applied.
Fix by cleaning up the code to use explicit, separate values for
starting and ending values. Only matrix-type animations had this
issue, but cleaned up other clauses similarly.
Test: animations/3d/matrix-transform-type-animation.html
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
2011-02-20 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9028929> REGRESSION (r75897): Scaling applied twice to an iframe with a transformed ancestor
Test: fast/frames/iframe-scale-applied-twice.html
* page/FrameView.cpp:
(WebCore::FrameView::create): Set the initial bounds of the view to match the
frame size.
* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect): Based on bounds, not frame size.
(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::setFrameRect): Moved code that really handles bounds size
change to setBoundsSize().
(WebCore::ScrollView::setBoundsSize): Added.
(WebCore::ScrollView::setInitialBoundsSize): Added. Sets the bounds size but does
not update anything.
(WebCore::ScrollView::frameRectsChanged): Based on bounds, not frame size.
(WebCore::ScrollView::scrollbarCornerPresent): Ditto.
* platform/ScrollView.h:
(WebCore::ScrollView::boundsSize): Added this getter.
* platform/Widget.h:
(WebCore::Widget::resize): Set the bounds size to the frame size.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint): Fixed an error in the indirect drawing code
path where the buffer rect was resized to capture only the damaged part, but was
still drawn in the original location.
2011-02-20 Alexey Proskuryakov <ap@apple.com>
Reviewed by Eric Seidel.
Tighten up access permissions by using libxslt API
https://bugs.webkit.org/show_bug.cgi?id=52688
<rdar://problem/8909191>
* xml/XSLTProcessorLibxslt.cpp: (WebCore::XSLTProcessor::transformToString): We are only
interested in a string result, so let libxslt know about that.
2011-02-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79104.
http://trac.webkit.org/changeset/79104
https://bugs.webkit.org/show_bug.cgi?id=54835
Might have caused flaky canaries (Requested by tonyg-cr on
#webkit).
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::canTakeNextToken):
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLParserScheduler.cpp:
(WebCore::isLayoutTimerActive):
* html/parser/HTMLParserScheduler.h:
(WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
* page/FrameView.h:
2011-02-20 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG animation - analyze attribute type for animation
https://bugs.webkit.org/show_bug.cgi?id=54542
Analyze animated attribute type to determine the kind of animation. Removed enum PropertyType and replace it
with AnimatedAttributeType instead. More cleanup of the animation code.
Added missing fillAttributeToPropertyTypeMap() for SVGGElement.
Use QualifiedName instead of AtomicStrings for attribute names. This makes it easier to handle animated attributes
from a different namespace like xlink:href. The rest of the SVG code is using QualifiedNames as well.
No change of functionality on the animation code. The changes for the <g>-element affect animateTransform. Sadly
animateTransform is not supported by our SVG animation test script at the moment. Can still be tested manually
with the W3C test suite in trunk.
The change on SVGUseElement gets covered by animate-elem-39-t.svg
Test: svg/animations/animate-dynamic-update-attributeName.html
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::hasValidAttributeType):
(WebCore::SVGAnimateElement::determineAnimatedAttributeType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::inheritsFromProperty):
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):
(WebCore::SVGAnimateElement::calculateDistance):
* svg/SVGAnimateElement.h:
* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
(WebCore::parsePoint):
(WebCore::SVGAnimateMotionElement::resetToBaseValue):
(WebCore::SVGAnimateMotionElement::calculateAnimatedValue):
(WebCore::SVGAnimateMotionElement::calculateDistance):
* svg/SVGAnimateMotionElement.h:
* svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::hasValidAttributeType):
(WebCore::SVGAnimateTransformElement::determineAnimatedAttributeType):
(WebCore::SVGAnimateTransformElement::resetToBaseValue):
(WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
(WebCore::SVGAnimateTransformElement::calculateFromAndByValues):
(WebCore::SVGAnimateTransformElement::applyResultsToTarget):
(WebCore::SVGAnimateTransformElement::calculateDistance):
* svg/SVGAnimateTransformElement.h:
* svg/SVGAnimationElement.cpp:
(WebCore::parseKeyTimes):
(WebCore::parseKeySplines):
(WebCore::SVGAnimationElement::isTargetAttributeCSSProperty):
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
(WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced):
(WebCore::solveEpsilon):
(WebCore::SVGAnimationElement::calculatePercentFromKeyPoints):
(WebCore::SVGAnimationElement::currentValuesFromKeyPoints):
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
(WebCore::SVGAnimationElement::startedActiveInterval):
* svg/SVGAnimationElement.h:
* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
* svg/SVGGElement.cpp:
(WebCore::SVGGElement::attributeToPropertyTypeMap):
(WebCore::SVGGElement::fillAttributeToPropertyTypeMap): Added to fill the animated attribute map for this element.
* svg/SVGGElement.h:
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::fillAttributeToPropertyTypeMap): Changed attribute type to AnimatedString for xlink:href.
* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::baseValueFor):
(WebCore::SMILTimeContainer::updateAnimations):
* svg/animation/SMILTimeContainer.h:
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::SVGSMILElement):
(WebCore::constructQualifiedName): Create a QualifiedName from a attribute name.
(WebCore::SVGSMILElement::insertedIntoDocument): Update local varaible of attribute name.
(WebCore::SVGSMILElement::removedFromDocument): Ditto.
(WebCore::SVGSMILElement::attributeChanged): Ditto.
* svg/animation/SVGSMILElement.h:
(WebCore::SVGSMILElement::attributeName):
2011-02-20 David Kilzer <ddkilzer@apple.com>
BUILD FIX: Add missing UNUSED_PARAM() when !ENABLE(FULLSCREEN_API)
Not reviewed.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen):
2011-02-20 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement PlatformKeyboardEvent::getCurrentModifierState()
https://bugs.webkit.org/show_bug.cgi?id=52880
* platform/gtk/KeyEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):
2011-02-19 Andreas Kling <kling@webkit.org>
Reviewed by Oliver Hunt.
DragController should use Color::serialized() when passing colors to CSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=54545
* page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
2011-02-19 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add phase in addition to momentumPhase to platform wheel events
Part of <rdar://problem/8945362>
Rename existing phase to momentumPhase.
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::momentumPhase):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
* platform/mac/WheelEventMac.mm:
(WebCore::momentumPhaseForEvent):
(WebCore::phaseForEvent):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
2011-02-19 Gavin Barraclough <barraclough@apple.com>
Qt build fix.
* bridge/runtime_method.h:
(JSC::RuntimeMethod::createStructure):
2011-02-19 Gavin Barraclough <barraclough@apple.com>
Qt build fix.
* bridge/qt/qt_instance.cpp:
* bridge/qt/qt_pixmapruntime.cpp:
2011-02-19 Gavin Barraclough <barraclough@apple.com>
Qt build fix.
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getMethod):
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapInstance::getMethod):
2011-02-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 54786 - Devirtualize JSCell::classInfo()
Instead of making a virtual function call, add a pointer to the ClassInfo
onto Structure.
This removes a virtual function call, and paves the way towards removing all
the createStructure methods, and StructureFlags/AnonymousSlotCount properties
(these should be able to move onto ClassInfo).
Calls to Structure::create must now pass a pointer to the ClassInfo for the
structure. All objects now have a ClassInfo pointer, non-object cell types
still do not.
Changes are most mechanical, involving three steps:
* Remove virtual classInfo() methods.
* Add &s_info parameter to calls to Structure::create.
* Rename ClassInfo static members on classes from 'info' to 's_info',
for consistency.
* WebCore.exp.in:
* bindings/js/JSAudioConstructor.cpp:
* bindings/js/JSAudioConstructor.h:
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowShell.cpp:
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSGeolocationCustom.cpp:
* bindings/js/JSImageConstructor.cpp:
* bindings/js/JSImageConstructor.h:
* bindings/js/JSImageDataCustom.cpp:
* bindings/js/JSOptionConstructor.cpp:
* bindings/js/JSOptionConstructor.h:
* bindings/js/JSWorkerContextBase.cpp:
* bindings/js/JSWorkerContextBase.h:
* bindings/js/SerializedScriptValue.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/c/CRuntimeObject.cpp:
* bridge/c/CRuntimeObject.h:
* bridge/c/c_instance.cpp:
* bridge/jni/jsc/JNIUtilityPrivate.cpp:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
* bridge/jni/jsc/JavaRuntimeObject.cpp:
* bridge/jni/jsc/JavaRuntimeObject.h:
* bridge/jsc/BridgeJSC.cpp:
* bridge/objc/ObjCRuntimeObject.h:
* bridge/objc/ObjCRuntimeObject.mm:
* bridge/objc/objc_instance.mm:
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
* bridge/runtime_array.cpp:
* bridge/runtime_array.h:
* bridge/runtime_method.cpp:
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
* bridge/runtime_object.h:
2011-02-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Martin Robinson.
[cairo][canvas] Drawing from/into float rectangles with width or height in range 0 to 1 fails
https://bugs.webkit.org/show_bug.cgi?id=54491
When width or height in float rectangle are in range (0, 0.5) or (-0.5, 0)
and would round to 0, alter the behaviour to ensure that width or height are
at least 1 pixel in size in these cases.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):
2011-02-19 Dan Bernstein <mitz@apple.com>
LLVM Compiler build fix.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::blurLayerImage): Eliminated a file static that generated
a global initializer since the compiler does not evaluate sqrtf at compile time.
2011-02-19 Brian Ryner <bryner@chromium.org>
Reviewed by Adam Barth.
Replace the #include of DocumentLoader.h in Document.h with a
forward declaration, and add a missing #include now that this
transitive include is gone.
https://bugs.webkit.org/show_bug.cgi?id=50489
No new tests required.
* bindings/ScriptControllerBase.cpp:
* dom/Document.h:
2011-02-19 Patrick Gansterer <paroga@webkit.org>
Reviewed by Antonio Gomes.
[EFL] Remove WebCore::currentTime()
https://bugs.webkit.org/show_bug.cgi?id=53886
There is no declaration for it and we use WTF::currentTime() everywhere.
* platform/efl/SystemTimeEfl.cpp:
2011-02-19 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
Move KeygenWinCE from wince into win directory
https://bugs.webkit.org/show_bug.cgi?id=54804
Move this file into the win directory, since it can be used on all windows platforms.
* CMakeListsWinCE.txt:
* platform/win/SSLKeyGeneratorWin.cpp: Renamed from platform/wince/KeygenWinCE.cpp.
2011-02-19 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
Make FileChooserWin.cpp more portable and use it on WinCE
https://bugs.webkit.org/show_bug.cgi?id=54803
* CMakeListsWinCE.txt:
* platform/win/FileChooserWin.cpp:
(WebCore::FileChooser::basenameForWidth):
* platform/wince/FileChooserWinCE.cpp: Removed.
2011-02-19 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Make ScriptElement match the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=54676
This implements the "prepare a script" section of the HTML5 spec in ScriptElement::prepareScript().
http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#prepare-a-script
There are a couple of things missing from the spec that would be new functionality. These will be added later.
- Support for async=false
- Empty src attribute should dispatch an error.
There are a couple of slight behavioral changes to match the spec.
- An XHTML script that is loaded then copied will not fire load on the copy.
- If onbeforeload moves the script to a different document, then it will not try to execute again because wasAlreadyStarted is true.
The parsers were updated to use the new API, but not rewritten to look like the spec. That will be done separately.
Test: All existing tests.
* dom/ScriptElement.cpp: Rewritten to match HTML5 spec.
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::insertedIntoDocument): Logic moved to prepareScript.
(WebCore::ScriptElement::childrenChanged): Logic moved to prepareScript.
(WebCore::ScriptElement::handleSourceAttribute): Logic moved to prepareScript.
(WebCore::isLegacySupportedJavaScriptLanguage): Added to support old script types in layout tests.
(WebCore::ScriptElement::isScriptTypeSupported): Derived from old shouldExecuteAsJavaScript().
(WebCore::ScriptElement::prepareScript): START HERE. Main change. Should read exactly like HTML5's "prepare a script." Legacy type support needed for layout tests using XML parser.
(WebCore::ScriptElement::requestScript): Most logic moved to prepareScript. Check security settings here.
(WebCore::ScriptElement::executeScript): Combined evaluateScript() and executeScript() from old code. Logic moved to prepareScript.
(WebCore::ScriptElement::stopLoadRequest): Ignore parser executed scripts.
(WebCore::ScriptElement::execute): Renamed executeScript.
(WebCore::ScriptElement::notifyFinished): We should only listen for non-parser executed scripts.
(WebCore::ScriptElement::ignoresLoadRequest): New variable names.
(WebCore::ScriptElement::childrenAreCommentsOrEmptyText): Added for HTML5 compliance.
(WebCore::ScriptElement::scriptCharset): Use HTML5 variables.
* dom/ScriptElement.h:
(WebCore::ScriptElement::willBeParserExecuted): Added.
(WebCore::ScriptElement::readyToBeParserExecuted): Added.
(WebCore::ScriptElement::willExecuteWhenDocumentFinishedParsing): Added.
(WebCore::ScriptElement::cachedScript): prepareScript() is the only place that should load scripts. This accessor lets the parsers listen for when loads finish.
(WebCore::ScriptElement::isParserInserted): Added.
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::endElementNs): Should behave the same. Offloads much of its work to prepareScript().
* dom/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseEndElement): Identical to libxml2 changes.
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::insertedIntoDocument): No longer needs url.
(WebCore::HTMLScriptElement::hasSourceAttribute): Added.
* html/HTMLScriptElement.h:
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::requestPendingScript): Requesting scripts offloaded to ScriptElement.
(WebCore::HTMLScriptRunner::runScript): Should behave the same. Offloads much of its work to prepareScript().
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::svgAttributeChanged): New ScriptElement function names.
(WebCore::SVGScriptElement::insertedIntoDocument): No longer needs url.
(WebCore::SVGScriptElement::finishParsingChildren): ScriptElement::finishParsingChildren is gone.
(WebCore::SVGScriptElement::hasSourceAttribute): Added.
(WebCore::SVGScriptElement::dispatchLoadEvent): New ScriptElement function names.
* svg/SVGScriptElement.h:
2011-02-19 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by James Robinson.
Split webcore_rendering off webcore_remaining to reduce its size for WPO builds
https://bugs.webkit.org/show_bug.cgi?id=54789
* WebCore.gyp/WebCore.gyp:
2011-02-19 Bill Budge <bbudge@chromium.org>
Reviewed by David Levin.
ThreadableLoaderClient needs willSendRequest method
https://bugs.webkit.org/show_bug.cgi?id=54688
No new tests. Exposes no new functionality
* WebCore.gypi:
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::willSendRequest):
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
* loader/DocumentThreadableLoaderClient.h: Added.
(WebCore::DocumentThreadableLoaderClient::isDocumentThreadableLoaderClient):
(WebCore::DocumentThreadableLoaderClient::willSendRequest):
* loader/ThreadableLoaderClient.h:
(WebCore::ThreadableLoaderClient::isDocumentThreadableLoaderClient):
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Avoid stopping all loaders in goToItem for same document navigations
or pseudo-back-forward URLs. Make HistoryController::goToItem private
to force callers to go through Page::goToItem. Also add a callback to
FrameLoaderClient to let clients decide whether to stop loading first.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
* loader/EmptyClients.h:
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/HistoryController.cpp:
* loader/HistoryController.h:
* page/Page.cpp:
2011-02-19 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Fix xssAuditor/iframe-injection.html
https://bugs.webkit.org/show_bug.cgi?id=54591
We should block the iframe src attribute. Although this technically
can't be used to run script, it's a pretty easy vector for stealing
passwords.
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::filterTokenInitial):
(WebCore::XSSFilter::filterIframeToken):
* html/parser/XSSFilter.h:
2011-02-18 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Let the parser yield for layout before running scripts
https://bugs.webkit.org/show_bug.cgi?id=54355
Prior to this patch, the parser would yield to perform a layout/paint before running a
script only if the script or a stylesheet blocking the script is not loaded yet. Since we
don't preload scan into the body while parsing the head, typically we'll block on a script
early in the body that causes us to yield to do the first paint within a reasonable time.
However, I'm planning to change the PreloadScanner to scan into the body from the head.
That significantly improves overall load time, but would hurt first paint time because
fewer scripts would be blocked during parsing and thus wouldn't yield.
This change causes us to yield before running scripts if we haven't painted yet (regardless
of whether or not the script is loaded). In addition to allowing the above mentioned
PreloadScanner change to be implemented without regressing first paint time, this also
improves first paint time by itself.
I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
signifcant change in page load time.
Within the pages tested, 33 had no statistically significant change in time to first paint,
12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point.
(WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused
means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does
the right thing whether we are just before a token or waiting for a script. Now that we may
yield before a token or before a script, this may be called while paused.
* html/parser/HTMLParserScheduler.cpp:
(WebCore::isLayoutTimerActive): Added a FIXME because r52919 changed minimumLayoutDelay()
to return m_extraLayoutDelay instead of 0 as a minimum. So checking !minimumLayoutDelay()
no longer works. The fix is to change it to check minimumLayoutDelay() ==
m_extraLayoutDelay. But this is all the more reason to move this method onto Document. I'll
do this in a follow up.
(WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
* page/FrameView.h:
(WebCore::FrameView::hasEverPainted): Added.
2011-02-18 Dawit Alemayehu <adawit@kde.org>
Reviewed by Andreas Kling.
[Qt] Button Element is rendered w/ text off-center.
https://bugs.webkit.org/show_bug.cgi?id=53373
Test: LayoutTests/fast/forms/button-white-space.html
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustButtonStyle):
2011-02-18 Jonathan Backer <backer@chromium.org>
Reviewed by Eric Seidel.
[chromium] Fix leak of texture IDs in compositor.
https://bugs.webkit.org/show_bug.cgi?id=54750
No new tests. It is extremely unlikely that this leak would have
any user visible impact because only a few bytes of space are wasted
(we're leaking texture IDs, not actual textures) and the space of
texture IDs is large (32 bits).
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::requestTexture):
2011-02-18 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Tor Arne Vestbø.
Always display the media controls when requiresFullscreenForVideoPlayback() is true
https://bugs.webkit.org/show_bug.cgi?id=54308
For video element, it should have controls when
Chrome::requiresFullscreenForVideoPlayback() is true.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::controls):
2011-02-18 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Use nearest-neighbor filtering for root layer.
https://bugs.webkit.org/show_bug.cgi?id=54409
https://bugs.webkit.org/show_bug.cgi?id=54509
This setting creates more consistent images for LayoutTests and
prevents small floating point errors in texture coordinates from
creating off-by-one pixel color differences.
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::update):
2011-02-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
[EFL] Fix coding style errors in RenderThemeEfl.h
https://bugs.webkit.org/show_bug.cgi?id=54693
Fix style errors in RenderThemeEfl.h
* platform/efl/RenderThemeEfl.h:
2011-02-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] The localized vendor name for Qt SIS packages should be "Nokia"
https://bugs.webkit.org/show_bug.cgi?id=54742
This change was applied in the Qt repository (qt/src/3rdparty/webkit),
so we should do the same here in QtWebKit.
Patch by Eckhart Koppen <eckhart.koppen@nokia.com>
a8a84f1667966acfa093c4be0b7d4b0900ddd3d9:
The previously used name "Nokia, Qt" was not usable for Nokia
Content Signing, which only allows "Nokia" as the visible vendor
name. The unique vendor ID remains as "Nokia, Qt"
* WebCore.pro:
2011-02-18 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] REGRESSION(r67516) : on www.gmail.com a strange rendering issue appears on the
menu bar due to flash.
https://bugs.webkit.org/show_bug.cgi?id=54741
Only show plugins with a valid size. We then don't involve X11 if there is
nothing to see anyway.
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::platformStart):
2011-02-18 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kent Tamura.
[EFL] Remove GDK dependency.
https://bugs.webkit.org/show_bug.cgi?id=53978
Remove GLIB_SUPPORT macro in GDK related code.
Regardless of GLIB_SUPPORT, getDefaultFontOptions() will works same way.
* CMakeListsEfl.txt:
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::getDefaultFontOptions):
2011-02-18 Noel Gordon <noel.gordon@gmail.com>
Reviewed by James Robinson.
[Chromium] Add elliptical gradient support to GradientSkia
https://bugs.webkit.org/show_bug.cgi?id=51841
Covered by existing tests, these need new rebaselines once this patch
lands for chrome linux, win32
fast/gradients/css3-color-stop-units.html
fast/gradients/css3-color-stops.html
fast/gradients/css3-linear-angle-gradients.html
fast/gradients/css3-radial-gradients.html
fast/gradients/css3-radial-gradients2.html
fast/gradients/css3-radial-gradients3.html
fast/gradients/css3-repeating-radial-gradients.html
* platform/graphics/skia/GradientSkia.cpp:
(WebCore::Gradient::platformGradient):
2011-02-18 James Robinson <jamesr@chromium.org>
Fix typo in boundary test in ASSERT() - test is for an inclusive range, not exclusive.
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::updateTextureIfNeeded):
2011-02-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Tiled backing store area is too big.
Error in area calculcation causes size of backing store
up to 6 times bigger than viewport with default multipliers.
https://bugs.webkit.org/show_bug.cgi?id=54587
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):
2011-02-18 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for <rdar://problem/9018729> Horizontal scroller doesn't
appear when loading a page with a Horizontal scrollbar from
the back/forward cache.
This patch adds a new bool member variable to FrameView to
keep track of whether we are loading a page from the back/
forward cache. If we are, don't suppress scrollbars on
first layout.
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
* page/FrameView.h:
(WebCore::FrameView::setIsRestoringFromBackForward):
(WebCore::FrameView::isRestoringFromBackForward):
2011-02-18 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r78846.
* platform/graphics/wince/FontWinCE.cpp:
(WebCore::TextRunComponent::TextRunComponent):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForTextChecking):
(WebCore::GraphicsContext::drawText):
* platform/wince/FileChooserWinCE.cpp:
(WebCore::FileChooser::basenameForWidth):
2011-02-18 Emil A Eklund <eae@chromium.org>
Reviewed by Darin Adler.
Crash in EventHandler::sendContextMenuEventForKey
https://bugs.webkit.org/show_bug.cgi?id=54495
Test: fast/events/menu-keydown-on-hidden-element.html
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEventForKey): Add null check.
2011-02-15 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Clean up shader code from LayerChromium classes
https://bugs.webkit.org/show_bug.cgi?id=54484
This is a refactoring and there should be no change in functionality.
All shader code is pulled out into classes in ShaderChromium.
The SharedValues classes are now turned into ProgramBinding, one per
shader program. These contain shader classes that know about what
variables they can bind.
* WebCore.gypi:
* platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::draw):
* platform/graphics/chromium/CanvasLayerChromium.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::draw):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/GeometryBinding.cpp: Added.
(WebCore::GeometryBinding::GeometryBinding):
(WebCore::GeometryBinding::~GeometryBinding):
(WebCore::GeometryBinding::prepareForDraw):
* platform/graphics/chromium/GeometryBinding.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.
(WebCore::GeometryBinding::initialized):
(WebCore::GeometryBinding::context):
(WebCore::GeometryBinding::quadVerticesVbo):
(WebCore::GeometryBinding::quadElementsVbo):
(WebCore::GeometryBinding::positionAttribLocation):
(WebCore::GeometryBinding::texCoordAttribLocation):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::drawDebugBorder):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::sharedGeometry):
(WebCore::LayerRendererChromium::borderProgram):
(WebCore::LayerRendererChromium::contentLayerProgram):
(WebCore::LayerRendererChromium::canvasLayerProgram):
(WebCore::LayerRendererChromium::videoLayerRGBAProgram):
(WebCore::LayerRendererChromium::videoLayerYUVProgram):
(WebCore::LayerRendererChromium::pluginLayerProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::tilerProgram):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::drawTexturedQuad):
* platform/graphics/chromium/LayerTilerChromium.h:
* platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::draw):
* platform/graphics/chromium/PluginLayerChromium.h:
* platform/graphics/chromium/ProgramBinding.cpp: Added.
(WebCore::ProgramBindingBase::ProgramBindingBase):
(WebCore::ProgramBindingBase::~ProgramBindingBase):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::loadShader):
(WebCore::ProgramBindingBase::createShaderProgram):
* platform/graphics/chromium/ProgramBinding.h: Added.
(WebCore::ProgramBindingBase::program):
(WebCore::ProgramBindingBase::initialized):
(WebCore::ProgramBinding::ProgramBinding):
(WebCore::ProgramBinding::vertexShader):
(WebCore::ProgramBinding::fragmentShader):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::drawSurface):
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/ShaderChromium.cpp: Added.
(WebCore::VertexShaderPosTex::VertexShaderPosTex):
(WebCore::VertexShaderPosTex::init):
(WebCore::VertexShaderPosTex::getShaderString):
(WebCore::VertexShaderPosTexYUVStretch::VertexShaderPosTexYUVStretch):
(WebCore::VertexShaderPosTexYUVStretch::init):
(WebCore::VertexShaderPosTexYUVStretch::getShaderString):
(WebCore::VertexShaderPos::VertexShaderPos):
(WebCore::VertexShaderPos::init):
(WebCore::VertexShaderPos::getShaderString):
(WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::VertexShaderPosTexTransform::getShaderString):
(WebCore::FragmentTexAlphaBinding::FragmentTexAlphaBinding):
(WebCore::FragmentTexAlphaBinding::init):
(WebCore::FragmentShaderRGBATexFlipAlpha::getShaderString):
(WebCore::FragmentShaderRGBATexAlpha::getShaderString):
(WebCore::FragmentShaderBGRATexAlpha::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMask::FragmentShaderRGBATexAlphaMask):
(WebCore::FragmentShaderRGBATexAlphaMask::init):
(WebCore::FragmentShaderRGBATexAlphaMask::getShaderString):
(WebCore::FragmentShaderYUVVideo::FragmentShaderYUVVideo):
(WebCore::FragmentShaderYUVVideo::init):
(WebCore::FragmentShaderYUVVideo::getShaderString):
(WebCore::FragmentShaderColor::FragmentShaderColor):
(WebCore::FragmentShaderColor::init):
(WebCore::FragmentShaderColor::getShaderString):
* platform/graphics/chromium/ShaderChromium.h: Added.
(WebCore::VertexShaderPosTex::matrixLocation):
(WebCore::VertexShaderPosTexYUVStretch::matrixLocation):
(WebCore::VertexShaderPosTexYUVStretch::yWidthScaleFactorLocation):
(WebCore::VertexShaderPosTexYUVStretch::uvWidthScaleFactorLocation):
(WebCore::VertexShaderPos::matrixLocation):
(WebCore::VertexShaderPosTexTransform::matrixLocation):
(WebCore::VertexShaderPosTexTransform::texTransformLocation):
(WebCore::FragmentTexAlphaBinding::alphaLocation):
(WebCore::FragmentTexAlphaBinding::samplerLocation):
(WebCore::FragmentShaderRGBATexAlphaMask::alphaLocation):
(WebCore::FragmentShaderRGBATexAlphaMask::samplerLocation):
(WebCore::FragmentShaderRGBATexAlphaMask::maskSamplerLocation):
(WebCore::FragmentShaderYUVVideo::yTextureLocation):
(WebCore::FragmentShaderYUVVideo::uTextureLocation):
(WebCore::FragmentShaderYUVVideo::vTextureLocation):
(WebCore::FragmentShaderYUVVideo::alphaLocation):
(WebCore::FragmentShaderYUVVideo::ccMatrixLocation):
(WebCore::FragmentShaderYUVVideo::signAdjLocation):
(WebCore::FragmentShaderColor::colorLocation):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::draw):
(WebCore::VideoLayerChromium::drawYUV):
(WebCore::VideoLayerChromium::drawRGBA):
* platform/graphics/chromium/VideoLayerChromium.h:
2011-02-18 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Update texture for ContentLayerChromiums in draw() call instead of updateContents..() call
https://bugs.webkit.org/show_bug.cgi?id=54315
This defers all operations on the compositor's GL context until the
draw() call which is a prerequisite for moving the draw() off-thread.
Also cleans up the update cycle a bit - there were some unused local
variables and whatnot.
One consequence of this change is that the upload buffer is retained
across updates now instead of allocated by each paint. This is
necessary so that the full layer contents can be uploaded if the
texture manager evicts the layer's backing texture. This costs more
persistent memory but avoids lots of allocator churn on updates.
Another nonobvious detail is that I have to update the texture for
ContentLayerChromiums in bindContentsTexture() because mask layers
never draw(), they are instead bound to the secondary texture unit.
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::requiresClippedUpdateRect):
(WebCore::ContentLayerChromium::updateContentsIfDirty):
(WebCore::ContentLayerChromium::resizeUploadBufferForImage):
(WebCore::ContentLayerChromium::resizeUploadBuffer):
(WebCore::SkBitmapConditionalAutoLockerPixels::SkBitmapConditionalAutoLockerPixels):
(WebCore::SkBitmapConditionalAutoLockerPixels::~SkBitmapConditionalAutoLockerPixels):
(WebCore::SkBitmapConditionalAutoLockerPixels::lockPixels):
(WebCore::ContentLayerChromium::updateTextureIfNeeded):
(WebCore::ContentLayerChromium::draw):
(WebCore::ContentLayerChromium::unreserveContentsTexture):
(WebCore::ContentLayerChromium::bindContentsTexture):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContentsIfDirty):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBounds):
* platform/graphics/chromium/LayerChromium.h:
2011-02-18 Kenneth Russell <kbr@google.com>
Unreviewed, Chromium build fix on certain Linux platforms.
* platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
2011-02-18 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement client based geolocation for qtport
https://bugs.webkit.org/show_bug.cgi?id=42629
Implements client based geolocation for qtwebkit. Removed old code related to non-client based geolocation
No tests as yet. This will be raised as different bug as new mock client implementation need to be done.
* WebCore.pro:
* features.pri:
* platform/qt/GeolocationServiceQt.cpp: Removed.
* platform/qt/GeolocationServiceQt.h: Removed.
2011-02-18 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Dave Hyatt.
Add support for dir=auto
https://bugs.webkit.org/show_bug.cgi?id=50916
When an element has dir attribute with value "auto", call defaultWritingMode
to find its directionality.
Added a flag SelfOrAncestorHasDirAutoFlag, and added hooks in the DOM to set
and check this flag. This flag is set on every node between an element with
dir=auto attribute and its first text node. Changes in the DOM between those
elements will trigger re-evaluating the directionality, but changes not
between those element do not need to be concerned.
The DOM hooks were added to childrenChanged, and to parseMappedAttribute.
The directionality is evaluated when children are added, and cleared when they are
removed. Directionality flag is also cleared on a child that is no longer determining
the directionality due to a sibling being added before that child.
Added 2 static CSSMutableStyleDeclarations to be used for elements with dir=auto.
We cannot used the mapped declaration, because it can take only one value.
Tests: fast/dom/HTMLElement/attr-dir-auto-change-before-text-node.html
fast/dom/HTMLElement/attr-dir-auto-change-child-node.html
fast/dom/HTMLElement/attr-dir-auto-change-text.html
fast/dom/HTMLElement/attr-dir-auto-children.html
fast/dom/HTMLElement/attr-dir-auto-remove-add-children.html
fast/dom/HTMLElement/attr-dir-auto.html
fast/dom/HTMLElement/attr-dir-value-change.html
* css/CSSStyleSelector.cpp:
(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
* dom/Node.h:
(WebCore::Node::selfOrAncestorHasDirAutoAttribute):
(WebCore::Node::setSelfOrAncestorHasDirAutoAttribute):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::mapToEntry):
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::childrenChanged):
(WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
(WebCore::HTMLElement::directionality):
(WebCore::HTMLElement::dirAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
(WebCore::HTMLElement::calculateAndAdjustDirectionality):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):
* html/HTMLElement.h:
2011-02-18 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antonio Gomes.
Navigating downwards / upwards does not focus on the links spread across more than one line.
https://bugs.webkit.org/show_bug.cgi?id=54639
When 2 anchor elements span more than one line each, and one ends on the same line that the
second starts on, the rects reported by their renderers are overlapping. When handling
2 overlapping nodes, check for this case, and don't assume that one of the nodes is on a higher layer.
Test: fast/spatial-navigation/snav-two-elements-one-line.html
* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
* page/SpatialNavigation.cpp:
(WebCore::areElementsOnSameLine):
(WebCore::distanceDataForNode):
* page/SpatialNavigation.h:
2011-02-18 Ben Vanik <benvanik@google.com>
Reviewed by Kenneth Russell.
Bug 53940: Implement the OES_vertex_array_object WebGL extension
https://bugs.webkit.org/show_bug.cgi?id=53940
Initial implementation of the OES_vertex_array_object extension adding the OESVertexArrayObject
extension container and WebGLVertexArrayObjectOES VAO object. The extension is plumbed through
the Extensions3D interface and implemented in the Extensions3DOpenGL (WebKit/OSX) version when
it is available.
Two big changes touching code outside of the extension files:
* Moved the typedefs at the top of GraphicsContext3D.h to GraphicsTypes3D.h (modeled after
GraphicsTypes.h). They are not namespaced as they weren't before.
* To make the code cleaner/clearer all vertex attribute state has been moved to the
WebGLVertexArrayObjectOES type (struct VertexAttribState) except for values which are still
on the WebGLRenderingContext. A default VAO is now used to store the existing attribute
states for when no other VAO is used. Code in WebGLRenderingContext dealing with buffers and
vertex attributes now defers to or stores values in the bound array object.
Tested against the WebGL conformance suite and the new
oes-vertex-array-object test:
https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/oes-vertex-array-object.html
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp: Modified property svn:ignore.
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* html/canvas/OESVertexArrayObject.cpp: Added.
(WebCore::OESVertexArrayObject::OESVertexArrayObject):
(WebCore::OESVertexArrayObject::~OESVertexArrayObject):
(WebCore::OESVertexArrayObject::getName):
(WebCore::OESVertexArrayObject::create):
(WebCore::OESVertexArrayObject::createVertexArrayOES):
(WebCore::OESVertexArrayObject::deleteVertexArrayOES):
(WebCore::OESVertexArrayObject::isVertexArrayOES):
(WebCore::OESVertexArrayObject::bindVertexArrayOES):
* html/canvas/OESVertexArrayObject.h: Added.
* html/canvas/OESVertexArrayObject.idl: Added.
* html/canvas/WebGLExtension.h:
* html/canvas/WebGLGetInfo.cpp:
(WebCore::WebGLGetInfo::WebGLGetInfo):
(WebCore::WebGLGetInfo::getWebGLVertexArrayObjectOES):
* html/canvas/WebGLGetInfo.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::bindBuffer):
(WebCore::WebGLRenderingContext::deleteBuffer):
(WebCore::WebGLRenderingContext::disableVertexAttribArray):
(WebCore::WebGLRenderingContext::validateElementArraySize):
(WebCore::WebGLRenderingContext::validateIndexArrayConservative):
(WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContext::validateRenderingState):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::enableVertexAttribArray):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::getVertexAttrib):
(WebCore::WebGLRenderingContext::vertexAttribPointer):
(WebCore::WebGLRenderingContext::validateBufferDataParameters):
(WebCore::WebGLRenderingContext::vertexAttribfImpl):
(WebCore::WebGLRenderingContext::vertexAttribfvImpl):
(WebCore::WebGLRenderingContext::initVertexAttrib0):
(WebCore::WebGLRenderingContext::simulateVertexAttrib0):
(WebCore::WebGLRenderingContext::restoreStatesAfterVertexAttrib0Simulation):
(WebCore::WebGLRenderingContext::getNumberOfExtensions):
(WebCore::WebGLRenderingContext::getExtensionNumber):
* html/canvas/WebGLRenderingContext.h:
(WebCore::WebGLRenderingContext::getMaxVertexAttribs):
(WebCore::WebGLRenderingContext::setBoundVertexArrayObject):
(WebCore::WebGLRenderingContext::VertexAttribValue::VertexAttribValue):
* html/canvas/WebGLVertexArrayObjectOES.cpp: Added.
(WebCore::WebGLVertexArrayObjectOES::create):
(WebCore::WebGLVertexArrayObjectOES::WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):
* html/canvas/WebGLVertexArrayObjectOES.h: Added.
(WebCore::WebGLVertexArrayObjectOES::~WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::VertexAttribState::VertexAttribState):
(WebCore::WebGLVertexArrayObjectOES::isDefaultObject):
(WebCore::WebGLVertexArrayObjectOES::hasEverBeenBound):
(WebCore::WebGLVertexArrayObjectOES::setHasEverBeenBound):
(WebCore::WebGLVertexArrayObjectOES::getElementArrayBuffer):
(WebCore::WebGLVertexArrayObjectOES::setElementArrayBuffer):
(WebCore::WebGLVertexArrayObjectOES::getVertexAttribState):
(WebCore::WebGLVertexArrayObjectOES::isVertexArray):
* html/canvas/WebGLVertexArrayObjectOES.idl: Added.
* platform/graphics/Extensions3D.h:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/GraphicsTypes3D.h: Added.
* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supports):
(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
* platform/graphics/opengl/Extensions3DOpenGL.h:
* platform/graphics/qt/Extensions3DQt.cpp:
(WebCore::Extensions3DQt::createVertexArrayOES):
(WebCore::Extensions3DQt::deleteVertexArrayOES):
(WebCore::Extensions3DQt::isVertexArrayOES):
(WebCore::Extensions3DQt::bindVertexArrayOES):
* platform/graphics/qt/Extensions3DQt.h:
2011-02-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: reflect changes to styles when they happen outside inspector.
https://bugs.webkit.org/show_bug.cgi?id=44620
Notify InspectorInstrumentation of inline style changes from CSSMutableStyleDeclaration
whenever the style change does not come from a direct "style" attribute modification.
The performance regression occurs only with the Web Inspector opened, when inline styles
are modified through setting style.cssText or style.<styleAttribute>: according to the Web Inspector protocol,
an attribute change requires that all attributes for the node in question be pushed into the frontend.
Test: inspector/styles/styles-update-from-js.html
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
* inspector/InspectorDOMAgent.cpp:
(WebCore::RevalidateStyleAttributeTask::reset):
(WebCore::RevalidateStyleAttributeTask::RevalidateStyleAttributeTask):
(WebCore::RevalidateStyleAttributeTask::scheduleFor):
(WebCore::RevalidateStyleAttributeTask::onTimer):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::didInvalidateStyleAttr):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didInvalidateStyleAttr):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
(WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady):
(WebCore::InspectorStyleSheetForInlineStyle::elementStyleText):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._attributesUpdated):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
(WebInspector.StylesSidebarPane.prototype.addBlankSection):
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.BlankStylePropertiesSection):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
2011-02-16 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Refactor pumpTokenizer loop
https://bugs.webkit.org/show_bug.cgi?id=54574
1. This makes pumpTokenizer() safe to call when waiting for a script or when about to get
the next token, although ASSERTs still enforce that we aren't waiting for a script. This
enables resumeParsingAfterYield() to call pumpTokenizer with no modifications even if we
yield before running a script rather than before taking a token (see bug 54355).
2. This also picks up the refCount >= 1 assert when stopped.
Tested PerformanceTests/Parser to verify no regression. If anything it got faster.
Before:
avg 985.05
median 985.5
stdev 3.007906248539007
min 980
max 990
After:
avg 980.05
median 981
stdev 3.122098653149833
min 974
max 985
No new tests because no new functionality.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::canTakeNextToken): Added.
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLDocumentParser.h:
2011-02-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79003.
http://trac.webkit.org/changeset/79003
https://bugs.webkit.org/show_bug.cgi?id=54753
It broke tests on GTK bots (Requested by Ossy on #webkit).
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::lastChildConsideringContinuation):
* dom/Node.cpp:
(WebCore::Node::removeEventListener):
* html/DateComponents.cpp:
(WebCore::DateComponents::parseTime):
2011-02-18 Csaba Osztrogonác <ossy@webkit.org>
Rubber-stamped by Andreas Kling.
Warning fix. Use ASSERT_UNUSED() instead of ASSERT().
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::lastChildConsideringContinuation):
* dom/Node.cpp:
(WebCore::Node::removeEventListener):
* html/DateComponents.cpp:
(WebCore::DateComponents::parseTime):
2011-02-18 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Optimize editing updates in main panel
https://bugs.webkit.org/show_bug.cgi?id=54661
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
(WebInspector.TextViewer.prototype._textChanged):
(WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
(WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
(WebInspector.TextViewer.prototype._syncDecorationsForLine):
(WebInspector.TextEditorChunkedPanel.prototype.textChanged):
(WebInspector.TextEditorChunkedPanel.prototype._scroll):
(WebInspector.TextEditorChunkedPanel.prototype.chunkForLine):
(WebInspector.TextEditorChunkedPanel.prototype._totalHeight):
(WebInspector.TextEditorGutterPanel.prototype._expandChunks):
(WebInspector.TextEditorGutterChunk):
(WebInspector.TextEditorGutterChunk.prototype.addDecoration):
(WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._expandChunks):
(WebInspector.TextEditorMainPanel.prototype._highlightDataReady):
(WebInspector.TextEditorMainPanel.prototype._markSkippedPaintLines):
(WebInspector.TextEditorMainPanel.prototype._paintSkippedLines):
(WebInspector.TextEditorMainPanel.prototype._paintLines):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._positionToSelection):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
(WebInspector.TextEditorMainChunk):
(WebInspector.TextEditorMainChunk.prototype.get startLine):
(WebInspector.TextEditorMainChunk.prototype.set startLine):
(WebInspector.TextEditorMainChunk.prototype.getExpandedLineRow):
(WebInspector.TextEditorMainChunk.prototype.updateCollapsedLineRow):
2011-02-18 Steve Block <steveblock@google.com>
Reviewed by Andreas Kling
Memory allocation error in convertV8ObjectToNPVariant() for strings
https://bugs.webkit.org/show_bug.cgi?id=54737
Include the termination character in the length when allocating memory
and copying the string. This fixes a crashing bug on Android.
This should be tested by the java/ tests on Chromium, but these
tests are currently skipped.
* bindings/v8/V8NPUtils.cpp:
(WebCore::convertV8ObjectToNPVariant):
2011-02-18 Philippe Normand <pnormand@igalia.com>
Unreviewed, rolling out r78979.
http://trac.webkit.org/changeset/78979
https://bugs.webkit.org/show_bug.cgi?id=53146
causes multiple crashes on GTK
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::notifyChildrenSelectionChange):
(WebCore::AXObjectCache::postPlatformNotification):
2011-02-18 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] minimal build unrecognized options
https://bugs.webkit.org/show_bug.cgi?id=50890
* GNUmakefile.am: new feature defines for optional features build.
2011-02-17 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Populate indexes created for object stores with data
https://bugs.webkit.org/show_bug.cgi?id=54669
Make sure that indices for object stores that already hold data get
populated.
* storage/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::hasValidId):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::populateIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
2011-02-18 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146
Emit the selection-changed signals when the menu list value has changed
Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::getListObject): New, return the right list object for
menu lists and list boxes.
(WebCore::notifyChildrenSelectionChange): Support menu lists.
(WebCore::AXObjectCache::postPlatformNotification): Call function
notifyChildrenSelectionChange for AXMenuListValueChanged.
2011-02-18 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] atk_text_get_selection/atk_text_set_selection fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53453
Ensure that atk_text_{get|set}_selection() work with list items.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_text_get_text): Properly handle list item
markers when returning the text for an object for a given interval
specified through the startOffset and endOffset parameters.
(getSelectionOffsetsForObject): Bear in mind list item markers
when returning the offsets for a selection over a list item.
(webkit_accessible_text_set_selection): Adjust offsets if needed
for list items with item markers. Ensure that it returns TRUE only
when everything went fine setting the text selection.
2011-02-18 Antti Koivisto <antti@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=54728
checkSelector*Value functions used in fastCheckSelector fail to inline
Wrap the functions used as template arguments to classes.
* css/CSSStyleSelector.cpp:
(WebCore::fastCheckSingleSelector):
(WebCore::ClassCheck::checkValue):
(WebCore::IdCheck::checkValue):
(WebCore::TagCheck::checkValue):
(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):
2011-02-17 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
Composited iframe content is missing from snapshots in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54696
We need to propagate the 'flattening' paint behavior flag
down to subviews while painting. WebKit1 does this via
code in WebFrameView, but this is a more general fix
that works in WebKit2 as well.
Made a utility method, parentFrameView(), which I changed
some other methods to use as well.
* page/FrameView.cpp:
(WebCore::FrameView::isEnclosedInCompositingLayer):
(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
(WebCore::FrameView::isOverlappedIncludingAncestors):
(WebCore::FrameView::parentFrameView):
(WebCore::FrameView::paintContents):
* page/FrameView.h:
2011-02-17 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/8898595> Pages that use fixed positioning display poorly when scaled
* html/HTMLBodyElement.cpp:
(WebCore::adjustForZoom): Account for page scale.
(WebCore::HTMLBodyElement::setScrollLeft): Ditto.
(WebCore::HTMLBodyElement::setScrollTop): Ditto.
* page/FrameView.cpp:
(WebCore::FrameView::scrollXForFixedPosition): Moved from ScrollView here and changed to
account for page scale: when the page is scaled, the “viewport” with respect to which fixed
objects are positioned is scaled as well. Since it’s now bigger than the real viewport (that is,
the frame view), we move it around in proportion to the document scroll, so that when the document
is fully scrolled to the bottom-right, the bottom right of the scaled viewport is visible.
(WebCore::FrameView::scrollYForFixedPosition): Ditto.
(WebCore::FrameView::scrollOffsetForFixedPosition): Moved from ScrollView here.
* page/FrameView.h:
* platform/ScrollView.cpp: Moved functions to FrameView.
* platform/ScrollView.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateRepaintRectsAfterScroll): Account for the RenderView being transformed.
(WebCore::RenderLayer::calculateClipRects): Used scrollOffsetForFixedPosition().
(WebCore::RenderLayer::backgroundClipRect): Ditto.
2011-02-17 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Add support for GPU accelerated path rendering
https://bugs.webkit.org/show_bug.cgi?id=44729
Incorporates the Loop and Blinn path rendering algorithm as an
option to the GPU-accelerated canvas code, currently only compiled
in to the Chromium port. Currently it's toggled by changing a
hardcoded constant in
SharedGraphicsContext3D::useLoopBlinnForPathRendering() and is
disabled by default. This mechanism can be improved once we've
gained more confidence in the implementation. There are some known
bugs that need to be fixed first.
No new tests; ran some 2D Canvas tests manually with the new flag
both enabled and disabled.
* WebCore.gypi:
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::GLES2Canvas):
(WebCore::GLES2Canvas::fillPath):
* platform/graphics/chromium/GLES2Canvas.h:
* platform/graphics/gpu/LoopBlinnClassifier.h:
* platform/graphics/gpu/LoopBlinnLocalTriangulator.h:
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::create):
(WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
(WebCore::SharedGraphicsContext3D::createBuffer):
(WebCore::SharedGraphicsContext3D::bindBuffer):
(WebCore::SharedGraphicsContext3D::bufferData):
(WebCore::SharedGraphicsContext3D::bufferSubData):
(WebCore::SharedGraphicsContext3D::useLoopBlinnForPathRendering):
(WebCore::SharedGraphicsContext3D::useLoopBlinnInteriorProgram):
(WebCore::SharedGraphicsContext3D::useLoopBlinnExteriorProgram):
* platform/graphics/gpu/SharedGraphicsContext3D.h:
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::fillPath):
2011-02-16 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
Layout Test fast/canvas/setWidthResetAfterForcedRender.html fails on
accelerated 2D canvas w/compositor enabled.
https://bugs.webkit.org/show_bug.cgi?id=54561
When resetting the CanvasRenderingContext2D, we also need to send a
contentChanged() to the relevant RenderLayer. This is similar to what
is done in didDraw().
Covered by fast/canvas/setWidthResetAfterForcedRender.html, but note
that this test will still fail pixel tests because the compositor
is not compatible with repaint tests (the green square is now white,
but the half-transparent grey repaint rect does not appear).
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::reset):
2011-02-17 Sergey Glazunov <serg.glazunov@gmail.com>
Reviewed by Kenneth Russell.
Null out the WEBKIT_lose_context WebGL extension's context pointer when
the WebGL rendering context is removed.
https://bugs.webkit.org/show_bug.cgi?id=54679
Test: fast/canvas/webgl/context-destroyed-crash.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
* html/canvas/WebKitLoseContext.cpp:
(WebCore::WebKitLoseContext::loseContext): Add null-check for m_context.
* html/canvas/WebKitLoseContext.h:
(WebCore::WebKitLoseContext::contextDestroyed):
2011-02-17 Kenneth Russell <kbr@google.com>
Reviewed by Chris Marrin.
Construction of Uint8Array from JS Array (and possibly others) incorrectly clamps values
https://bugs.webkit.org/show_bug.cgi?id=52768
Removed incorrect clamping code from IntegralTypedArrayBase. Fixed
code which casts from incoming double to the destination type.
Changed the JSC bindings to use this code, rather than a copy of
the casting code and a different constructor, in order to reuse
the fix.
* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::constructArrayBufferView):
* html/canvas/Int32Array.h:
(WebCore::Int32Array::set):
* html/canvas/Int8Array.h:
(WebCore::Int8Array::set):
* html/canvas/IntegralTypedArrayBase.h:
(WebCore::IntegralTypedArrayBase::set):
* html/canvas/Uint16Array.h:
(WebCore::Uint16Array::set):
* html/canvas/Uint32Array.h:
(WebCore::Uint32Array::set):
* html/canvas/Uint8Array.h:
(WebCore::Uint8Array::set):
2011-02-17 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Knob proportion not quite right during rubber-band.
<rdar://problem/9015201>
Change knob proportion algorithm to treat overhang as making the view smaller,
rather than document bigger.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
2011-02-16 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Andreas Kling.
Summary: HTML5 <details> and <summary>: HTMLSummaryElement
https://bugs.webkit.org/show_bug.cgi?id=54584
Adding class HTMLSummaryElement to build systems. This class will be used in
the implementation of new HTML5 tag <summary>.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLElementsAllInOne.cpp:
* html/HTMLSummaryElement.cpp: Added.
(WebCore::HTMLSummaryElement::create):
(WebCore::HTMLSummaryElement::HTMLSummaryElement):
* html/HTMLSummaryElement.h: Added.
* html/HTMLTagNames.in:
2011-02-17 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Throwing in an IndexedDB error or success event should lead to the transaction aborting
https://bugs.webkit.org/show_bug.cgi?id=54249
When an exception is thrown but not handled within an IDBRequests success/error event,
we should abort the transaction.
Test: storage/indexeddb/exception-in-event-aborts.html
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
* dom/EventTarget.cpp:
(WebCore::EventTarget::uncaughtExceptionInEventHandler):
* dom/EventTarget.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):
* storage/IDBRequest.h:
2011-02-17 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
WebKit2: Support Dictionary popup
<rdar://problem/7660670>
Add some necessary exports.
* WebCore.exp.in:
2011-02-17 W. James MacLean <wjmaclean@chromium.org>
Reviewed by James Robinson.
[chromium] Add command-line flag to enable composite to offscreen texture.
https://bugs.webkit.org/show_bug.cgi?id=52311
Add plumbing to allow command-line switch to enable offscreen compositing. Function
LayerRendererChromium::copyOffscreenTextureToDisplay used for now to mimic
normal renderer operation.
Existing functionality not changed; offscreen compositing will be tested via GPU test framework.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::setRootLayer):
(WebCore::LayerRendererChromium::setCompositeOffscreen):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::setScissorToRect):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::isCompositingOffscreen):
2011-02-17 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fixes after recent changes.
* dom/ScriptedAnimationController.h:
* platform/graphics/wx/FontWx.cpp:
(WebCore::Font::drawComplexText):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForTextChecking):
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::setFrameRect):
2011-02-16 Brian Weinstein <bweinstein@apple.com>
Reviewed by Brady Eidson.
WebKit2: Need a way to manage the WebCore Cache
https://bugs.webkit.org/show_bug.cgi?id=54501
Add a way to get a set of all of the origins that have entries in the
WebCore memory cache, and a method to remove all resources from the memory
cache from a given security origin.
No change in behavior.
* WebCore.exp.in: Add functions that need to be exported.
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeResourcesWithOrigin):
(WebCore::MemoryCache::getOriginsWithCache):
* loader/cache/MemoryCache.h:
2011-02-16 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=54244
Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
been changed as well.
In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
still have a precise floating point position.
Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
be rounding justification spacing in their font code.
Many layout test results change on Mac, since rounding hacks were used there and are now gone.
* WebCore.exp.in:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* platform/chromium/FileChooserChromium.cpp:
(WebCore::FileChooser::basenameForWidth):
* platform/graphics/Font.cpp:
(WebCore::Font::width):
* platform/graphics/Font.h:
(WebCore::Font::spaceWidth):
(WebCore::Font::tabWidth):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawText):
(WebCore::GraphicsContext::drawEmphasisMarks):
(WebCore::GraphicsContext::drawBidiText):
(WebCore::GraphicsContext::drawHighlightForText):
* platform/graphics/GraphicsContext.h:
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::platformGlyphInit):
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::spaceWidth):
* platform/graphics/StringTruncator.cpp:
(WebCore::stringWidth):
(WebCore::truncateString):
(WebCore::StringTruncator::centerTruncate):
(WebCore::StringTruncator::rightTruncate):
(WebCore::StringTruncator::width):
* platform/graphics/StringTruncator.h:
* platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
(WebCore::TextRun::xPos):
(WebCore::TextRun::expansion):
(WebCore::TextRun::directionalOverride):
(WebCore::TextRun::disableSpacing):
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advance):
* platform/graphics/WidthIterator.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForTextChecking):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLineForText):
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::advance):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
* platform/graphics/mac/ComplexTextController.h:
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawLineForTextChecking):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForTextChecking):
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformGlyphInit):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking):
(WebCore::GraphicsContext::drawLineForText):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking):
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem):
* platform/gtk/FileChooserGtk.cpp:
(WebCore::FileChooser::basenameForWidth):
* platform/mac/DragImageMac.mm:
(WebCore::widthWithFont):
(WebCore::drawAtPoint):
* platform/mac/FileChooserMac.mm:
(WebCore::FileChooser::basenameForWidth):
* platform/win/DragImageWin.cpp:
(WebCore::createDragImageForLink):
* platform/win/FileChooserWin.cpp:
(WebCore::FileChooser::basenameForWidth):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
* platform/win/WebCoreTextRenderer.cpp:
(WebCore::WebCoreTextFloatWidth):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
* rendering/HitTestResult.h:
* rendering/InlineBox.cpp:
(WebCore::InlineBox::adjustPosition):
(WebCore::InlineBox::placeEllipsisBox):
(WebCore::InlineBox::locationIncludingFlipping):
(WebCore::InlineBox::flipForWritingMode):
* rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::adjustLineDirectionPosition):
(WebCore::InlineBox::adjustBlockDirectionPosition):
(WebCore::InlineBox::setX):
(WebCore::InlineBox::x):
(WebCore::InlineBox::setY):
(WebCore::InlineBox::y):
(WebCore::InlineBox::width):
(WebCore::InlineBox::height):
(WebCore::InlineBox::logicalLeft):
(WebCore::InlineBox::logicalRight):
(WebCore::InlineBox::setLogicalLeft):
(WebCore::InlineBox::pixelSnappedLogicalLeft):
(WebCore::InlineBox::pixelSnappedLogicalRight):
(WebCore::InlineBox::setLogicalWidth):
(WebCore::InlineBox::logicalWidth):
(WebCore::InlineBox::verticalAlign):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::roundedFrameRect):
(WebCore::InlineFlowBox::adjustPosition):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::verticalPositionForBox):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverflow):
(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::placeEllipsisBox):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::maxYLayoutOverflow):
(WebCore::InlineFlowBox::maxXLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::maxYVisualOverflow):
(WebCore::InlineFlowBox::maxXVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::paintDocumentMarkers):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::textPos):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::setExpansion):
* rendering/RenderBR.h:
(WebCore::RenderBR::width):
* rendering/RenderBlock.cpp:
(WebCore::stripTrailingSpace):
(WebCore::updatePreferredWidth):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::addFocusRingRects):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::fitBelowFloats):
(WebCore::textWidth):
(WebCore::tryHyphenating):
(WebCore::RenderBlock::findNextLineBreak):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::flipForWritingMode):
* rendering/RenderBox.h:
* rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::width):
(WebCore::RenderCombineText::adjustTextOrigin):
(WebCore::RenderCombineText::combineText):
* rendering/RenderCombineText.h:
(WebCore::RenderCombineText::combinedTextWidth):
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::computePreferredLogicalWidths):
* rendering/RenderCounter.h:
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
* rendering/RenderImage.cpp:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::minLogicalWidth):
(WebCore::RenderText::maxLogicalWidth):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::firstRunOrigin):
(WebCore::RenderText::firstRunX):
(WebCore::RenderText::firstRunY):
(WebCore::RenderText::width):
(WebCore::RenderText::linesBoundingBox):
* rendering/RenderText.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::getAvgCharWidth):
(WebCore::RenderTextControl::paintPlaceholder):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeTextRun):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::placeEllipsisBox):
(WebCore::RootInlineBox::adjustPosition):
(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
(WebCore::RootInlineBox::paddedLayoutOverflowRect):
* rendering/RootInlineBox.h:
* rendering/VerticalPositionCache.h:
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::offsetForPosition):
(WebCore::SVGInlineTextBox::positionForOffset):
(WebCore::SVGInlineTextBox::constructTextRun):
* rendering/svg/SVGInlineTextBox.h:
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeRenderSVGTextBox):
* rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::SVGTextMetrics):
(WebCore::constructTextRun):
* svg/SVGFont.cpp:
(WebCore::floatWidthMissingGlyphCallback):
(WebCore::Font::drawTextUsingSVGFont):
2011-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
'ex' coordinates fail, when SVGFont doesn't provide an explicit xHeight attribute
https://bugs.webkit.org/show_bug.cgi?id=54672
Measure the xHeight from the 'x' glyph of a SVGFont, if the font itself doesn't explicitely specify an x-height attribute.
Fixes the modern version of SVG 1.1 2nd Edition coords-units-03-b.svg.
Test: svg/W3C-SVG-1.1-SE/coords-units-03-b.svg
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Adam Roben.
HTML5 <details> and <summary>: localized text
https://bugs.webkit.org/show_bug.cgi?id=54260
The method defaultDetailsSummaryText was added to LocalizationStrategy class and to
platform/LocalizedStrings. It is used to provide the default label to be used by a
<details> tag that has no <summary> child.
* platform/LocalizationStrategy.h:
* platform/LocalizedStrings.cpp:
(WebCore::fileButtonNoFileSelectedLabel):
(WebCore::defaultDetailsSummaryText):
* platform/LocalizedStrings.h:
* platform/android/LocalizedStringsAndroid.cpp:
(WebCore::defaultDetailsSummaryText):
* platform/brew/LocalizedStringsBrew.cpp:
(WebCore::defaultDetailsSummaryText):
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::defaultDetailsSummaryText):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::defaultDetailsSummaryText):
* platform/haiku/LocalizedStringsHaiku.cpp:
(WebCore::defaultDetailsSummaryText):
* platform/wx/LocalizedStringsWx.cpp:
(WebCore::defaultDetailsSummaryText):
2011-02-17 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Laszlo Gombos.
Updated include paths for phonon.
[Qt] WebKit patches required to work with a modularized version of Qt
https://bugs.webkit.org/show_bug.cgi?id=53916
Build fix. No tests.
* WebCore.pro:
2011-02-17 Hui Huang <hui.2.huang@nokia.com>
Reviewed by Laszlo Gombos.
The URL of HTML5 Video Element is percent encoded at websites such as youtube.
It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
the HTTP GET request for the video to be rejected by the service provider.
https://bugs.webkit.org/show_bug.cgi?id=53973.
The bug is fixed by constructing QUrl from the encoded URL.
New test function tst_QWebPage::loadHtml5Video() is added in
Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::commitLoad):
2011-02-17 Andreas Kling <kling@webkit.org>
Reviewed by Antti Koivisto.
[Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
https://bugs.webkit.org/show_bug.cgi?id=49216
CachedResourceRequest::didFail() will protect the CachedResourceLoader's
document() while it runs, but if we're being called from the Document destructor,
the protecting RefPtr<Document> will cause a double-delete instead.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::~CachedResourceLoader): Clear the m_document
pointer so CachedResourceRequest::didFail() won't try to protect it.
(WebCore::CachedResourceLoader::frame): Add null-check for m_document.
2011-02-17 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Add updateHighlight method to the highlighter
https://bugs.webkit.org/show_bug.cgi?id=54448
* inspector/front-end/SourceTokenizer.js:
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter.prototype.set mimeType):
(WebInspector.TextEditorHighlighter.prototype.reset):
(WebInspector.TextEditorHighlighter.prototype.updateHighlight):
(WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
(WebInspector.TextEditorHighlighter.prototype._highlightLines):
2011-02-16 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: show all inlined scripts from single document in the same source frame.
https://bugs.webkit.org/show_bug.cgi?id=54544
Currently when debugging synchronously executed inlined scripts each script is shown in it's own source frame ("example.html:24").
We should show such scripts in the same source frame "example.html" with <script></script> framing.
Test: inspector/debugger/debug-inlined-scripts.html
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
(WebInspector.ScriptsPanel.prototype._addScript):
(WebInspector.ScriptsPanel.prototype._resourceForURL):
(WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
(WebInspector.ScriptsPanel.prototype.addConsoleMessage):
(WebInspector.ScriptsPanel.prototype.clearConsoleMessages):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
(WebInspector.ScriptsPanel.prototype._sourceFrameForScript):
(WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
(WebInspector.ScriptsPanel.prototype._showScriptOrResource):
(WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu.optionCompare):
(WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
(WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
(WebInspector.SourceFrameContentProviderForScript.prototype._buildSource):
2011-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
svg/batik/paints/patternRegions-positioned-objects.svg fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=44484
Pattern of pattern defined with objectBoundingBox does not render correctly
https://bugs.webkit.org/show_bug.cgi?id=53463
Fix <pattern> + patternContentUnits="objectBoundingBox" support.
We were incorrrectly translating the tile image transform, by the target objects bbox.x()/y().
RenderSVGResourceMask/Clipper don't have this error.
Fix nesting <patterns> in objectBoundingBox mode, propagate the tileImageTransform as new user-space
when drawing the pattern children. <mask> + <clipPath> don't have the problem.
Test: svg/custom/nested-pattern-boundingBoxModeContent.svg
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildTileImageTransform):
(WebCore::RenderSVGResourcePattern::createTileImage):
2011-02-17 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed.
[Qt][V8] Buildfix after r78752.
* CodeGenerators.pri: Add missing IDL files.
2011-02-17 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
RTL lineboundary left/right is reversed when cursor is at start of RTL container
https://bugs.webkit.org/show_bug.cgi?id=54534
Test: editing/selection/extend-left-right-by-lineboundary.html
Add missing cases for extending left/right by lineboundary.
* editing/SelectionController.cpp:
(WebCore::SelectionController::modifyExtendingRight):
(WebCore::SelectionController::modifyExtendingLeft):
2011-02-16 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] libsoup critical warnings
https://bugs.webkit.org/show_bug.cgi?id=54557
Avoid pausing a soup message for already downloaded resources.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::platformSetDefersLoading):
2011-02-16 Brian Ryner <bryner@chromium.org>
Reviewed by Darin Fisher.
Split the socket address field into separate IP address and port fields.
This will make the field less error-prone to parse, for example when
dealing with IPv6 literals.
https://bugs.webkit.org/show_bug.cgi?id=54607
No new tests required.
* platform/network/chromium/ResourceResponse.cpp:
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
* platform/network/chromium/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::remoteIPAddress):
(WebCore::ResourceResponse::setRemoteIPAddress):
(WebCore::ResourceResponse::remotePort):
(WebCore::ResourceResponse::setRemotePort):
2011-02-16 Dominic Mazzoni <dmazzoni@google.com>
Reviewed by Chris Fleizach.
Add support for canvas fallback content.
https://bugs.webkit.org/show_bug.cgi?id=50126
Test: accessibility/canvas-fallback-content.html
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::canHaveChildren):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(atkRole):
* accessibility/mac/AccessibilityObjectWrapper.mm:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isFocusable):
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::recursiveSetNoNeedsLayout):
(WebCore::RenderHTMLCanvas::layout):
(WebCore::RenderHTMLCanvas::nodeAtPoint):
* rendering/RenderHTMLCanvas.h:
(WebCore::RenderHTMLCanvas::children):
(WebCore::RenderHTMLCanvas::canHaveChildren):
(WebCore::RenderHTMLCanvas::virtualChildren):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaint):
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
2011-02-16 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Allow acceleratesDrawing for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54511
Plumb through preference for accelerated drawing.
When accelerated drawing is enabled, set a flag on new GraphicsLayers.
Not testable via Layout Tests
* WebCore.exp.in:
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setAcceleratedDrawingEnabled):
* page/Settings.h:
(WebCore::Settings::acceleratedDrawingEnabled):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
2011-02-16 Victoria Kirst <vrk@google.com>
Reviewed by Kenneth Russell.
[chromium] Fix green pixels at edge of certain GPU-accelerated videos
https://bugs.webkit.org/show_bug.cgi?id=54559
Adds logic to properly resize the range of YUV textures to only
select legitimate values.
* platform/graphics/chromium/VideoFrameChromium.h:
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::SharedValues::SharedValues):
(WebCore::VideoLayerChromium::allocateTexturesIfNeeded):
(WebCore::VideoLayerChromium::drawYUV):
* platform/graphics/chromium/VideoLayerChromium.h:
(WebCore::VideoLayerChromium::SharedValues::yWidthScaleFactorLocation):
(WebCore::VideoLayerChromium::SharedValues::uvWidthScaleFactorLocation):
2011-02-16 Bill Budge <bbudge@chromium.org>
Reviewed by David Levin.
Need didReceiveCachedMetadata, and finishTime for didFinishLoading exposed in ThreadableLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=54313
No tests needed, exposes no new functionality
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::didFinishLoading):
* fileapi/FileReaderLoader.h:
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::setDefersLoading):
(WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::loadRequest):
* loader/DocumentThreadableLoader.h:
* loader/ThreadableLoaderClient.h:
(WebCore::ThreadableLoaderClient::didReceiveData):
(WebCore::ThreadableLoaderClient::didReceiveCachedMetadata):
(WebCore::ThreadableLoaderClient::didFinishLoading):
* loader/ThreadableLoaderClientWrapper.h:
(WebCore::ThreadableLoaderClientWrapper::didReceiveData):
(WebCore::ThreadableLoaderClientWrapper::didReceiveCachedMetadata):
(WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
* loader/WorkerThreadableLoader.cpp:
(WebCore::workerContextDidReceiveCachedMetadata):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveCachedMetadata):
(WebCore::workerContextDidFinishLoading):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
* loader/WorkerThreadableLoader.h:
* notifications/Notification.cpp:
(WebCore::Notification::didFinishLoading):
* notifications/Notification.h:
* page/EventSource.cpp:
(WebCore::EventSource::didFinishLoading):
* page/EventSource.h:
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::didFinishLoading):
* workers/WorkerScriptLoader.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didFinishLoading):
* xml/XMLHttpRequest.h:
2011-02-16 Jeremy Orlow <jorlow@chromium.org>
Fix uninitialized memory error.
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::close):
2011-02-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix xssAuditor/form-action.html
https://bugs.webkit.org/show_bug.cgi?id=54590
We should block form actions. Although this technically can't be used
to run script, it's a pretty easy vector for stealing passwords.
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::filterTokenInitial):
(WebCore::XSSFilter::filterFormToken):
* html/parser/XSSFilter.h:
2011-02-16 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
Remove the early bail added in r75823 since we can run into anonymous
blocks when traversing the parents chain for clearing floats.
https://bugs.webkit.org/show_bug.cgi?id=54601
removeFloatingOrPositionedChildFromBlockLists tries to find the topmost
parent containing "this" block and then tries to remove it from its floats
list and mark all descendants blocks for layout. I added a bailout condition
in r75823 because we thought that if one of the parent render block does not
contain "this" float, then it is safe to assume that none of the grand parents
will have it. This is a wrong assumption since anonymous blocks do not have
float objects and we need to go higher in the chain to find the top most parent
containing this float. Instead of breaking out of the loop, it is ok to keep
traversing the chain till we find that parent. Otherwise, we will leave deleted
floats in the grand parents floats list.
Test: fast/block/float/floats-not-cleared-from-grand-parents.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
2011-02-16 Andreas Kling <kling@webkit.org>
Reviewed by Ryosuke Niwa.
Editing styles should not emit #RRGGBBAA colors
https://bugs.webkit.org/show_bug.cgi?id=54540
* editing/ApplyStyleCommand.cpp:
(WebCore::StyleChange::extractTextStyles): Use Color::serialized()
instead of Color::nameForRenderTreeAsText().
2011-02-16 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Improve showTree of Range, Position, and VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=54536
Enhanced showTree of Range, Position, and VisiblePosition.
* dom/Position.cpp:
(WebCore::Position::showAnchorTypeAndOffset): Added; dumps "legacy" if the position
is a legacy position and also dumps anchor type.
(WebCore::Position::showTreeForThis): Calls showAnchorTypeAndOffset.
* dom/Position.h:
* dom/Range.cpp:
(showTree): No longer calls deprecatedEditingOffset.
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::debugPosition): No longer included in release build.
Calls Position::showAnchorTypeAndOffset instead of manually calling deprecatedEditingOffset.
* editing/VisiblePosition.h:
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::debugPosition): Ditto.
(WebCore::VisibleSelection::showTreeForThis): Ditto.
* editing/VisibleSelection.h:
* page/EventHandler.cpp:
2011-02-16 David Grogan <dgrogan@chromium.org>
Reviewed by Jeremy Orlow.
fix compile error introduced in 78752
https://bugs.webkit.org/show_bug.cgi?id=54604
* storage/IDBRequest.h:
2011-02-16 Jeremy Orlow <jorlow@chromium.org>
Back out IndexedDB change thats no longer necessary
https://bugs.webkit.org/show_bug.cgi?id=54603
Backing out 78645 as it turns out that it's not necessary.
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBFactoryBackendInterface.h:
2011-02-16 Brian Salomon <bsalomon@google.com>
Reviewed by James Robinson.
Skia's gpu backed just needs the correct context bound before drawing. It will bind the correct FBO itself and doing so externally confuses it unless resetContext is called.
No new tests required.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::syncSoftwareCanvas):
2011-02-16 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
Use non-asserting pack function for decoding images, since webgl may want
a non-premultiplied version of the image.
https://bugs.webkit.org/show_bug.cgi?id=54023
No new tests.
fast/canvas/webgl/gl-teximage.html
fast/canvas/webgl/tex-image-with-format-and-type.html
fast/canvas/webgl/texture-transparent-pixels-initialized.html
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::setRGBA):
2011-02-16 David Grogan <dgrogan@chromium.org>
Reviewed by Jeremy Orlow.
indexeddb: make setVersion fire blocked event if other connections are open
https://bugs.webkit.org/show_bug.cgi?id=53728
Tests: storage/indexeddb/set_version_blocked.html
storage/indexeddb/set_version_queue.html
* WebCore.gypi:
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
* dom/Event.cpp:
(WebCore::Event::isIDBVersionChangeEvent):
* dom/Event.h:
* dom/EventNames.h:
* dom/EventTarget.cpp:
(WebCore::EventTarget::toIDBVersionChangeRequest):
* dom/EventTarget.h:
* storage/IDBCallbacks.h:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::close):
* storage/IDBDatabase.h:
* storage/IDBDatabase.idl:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::version):
(WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::callbacks):
(WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::PendingSetVersionCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::open):
(WebCore::IDBDatabaseBackendImpl::close):
* storage/IDBDatabaseBackendImpl.h:
* storage/IDBDatabaseBackendInterface.h:
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::onBlocked):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::source):
* storage/IDBRequest.h:
* storage/IDBVersionChangeEvent.cpp: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
(WebCore::IDBVersionChangeEvent::create):
(WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
(WebCore::IDBVersionChangeEvent::~IDBVersionChangeEvent):
(WebCore::IDBVersionChangeEvent::version):
* storage/IDBVersionChangeEvent.h: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
(WebCore::IDBVersionChangeEvent::isIDBVersionChangeEvent):
* storage/IDBVersionChangeEvent.idl: Added.
* storage/IDBVersionChangeRequest.cpp: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
(WebCore::IDBVersionChangeRequest::create):
(WebCore::IDBVersionChangeRequest::IDBVersionChangeRequest):
(WebCore::IDBVersionChangeRequest::~IDBVersionChangeRequest):
(WebCore::IDBVersionChangeRequest::onBlocked):
* storage/IDBVersionChangeRequest.h: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
* storage/IDBVersionChangeRequest.idl: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
2011-02-16 Robin Cao <robin.cao@torchmobile.com.cn>
Reviewed by James Robinson.
PlatformContextSkia::applyAntiAliasedClipPaths does not work for paths which have evenOdd property
https://bugs.webkit.org/show_bug.cgi?id=54336
We need to take fill type of paths into account when drawing them.
No new tests, covered by svg/W3C-SVG-1.1/masking-path-05-f.svg.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::applyAntiAliasedClipPaths):
2011-02-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION (r61234): washingtonpost.com top bar looks wrong, doesn't animate
https://bugs.webkit.org/show_bug.cgi?id=53717
Test: http/tests/local/absolute-url-strip-whitespace.html
This was theoretically tested already in fast/url, however the
tests were disabled due to lack of any clean way to test absolute
url parsing in JavaScript. I added a test which mimics the sites
behavior using our local http server. There seems to be no other
way to test this at the moment.
* platform/KURL.cpp:
(WebCore::shouldTrimFromURL):
- Any char 0-20 should be removed (matches google-url and other browsers).
(WebCore::KURL::init):
2011-02-16 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
Traverse the next sibling tree to find the text fragment for a first letter.
https://bugs.webkit.org/show_bug.cgi?id=54568
We cannot assume that the next sibling to the first letter will a text fragment
since there can be intermediatary Apple-style-span inline elements wrapping the
text fragment. So, we traverse the next sibling tree to find it.
Test: fast/css/first-letter-text-fragment-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
2011-02-16 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] r78718 introduced some assertion failures in some HTTP tests
https://bugs.webkit.org/show_bug.cgi?id=54592
No new tests. This fix is covered by tests that are currently failing.
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateFromSoupMessage): Instead of setting the existing
headers and then selectively removing ones that do not exist in the updated soup
message, just remove all headers from the map first.
2011-02-16 Jian Li <jianli@chromium.org>
Reviewed by Kenneth Russell.
[V8] DataView constructor can be applied as a regular method
https://bugs.webkit.org/show_bug.cgi?id=54563
Tested by adding a new test case to fast/canvas/webgl/data-view-test.html.
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallback):
== Rolled over to ChangeLog-2011-02-16 ==
|