1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2887
2888
|
2011-06-02 Andreas Kling <kling@webkit.org>
Unreviewed build fix.
To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
https://bugs.webkit.org/show_bug.cgi?id=59345
KURL and QUrl disagree whether certain URLs are valid or not. The regression here
was caused by the fact that now KURL accepts "http:/example.com" (note only one
slash) and our test case used a strange edge case that's transformed into a
"one-slash" URL that now KURL can handle.
QtWebKit approach in this case is to do a best effort and accept the QUrl if KURL
can understand it. So I've updated the test to use a more meaningful example and
show that an invalid URL gets converted to a valid URL if possible.
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::setUrlToInvalid):
2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Tor Arne Vestbø.
[Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals
https://bugs.webkit.org/show_bug.cgi?id=61739
The skipped test was imported from Qt source repository, and used private headers
to peek in the QML Grid element. This patch changes the QML used to expose the
information we want to test: number of pages opened and the first page opened.
* tests/qdeclarativewebview/resources/newwindows.html:
Added <body> tags. We have no reason to not use them in the test.
* tests/qdeclarativewebview/resources/newwindows.qml:
Moved the timer out of the page component, used anchors for setting webview size,
changed the way we count pages opened. Also changed coding style a bit.
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::multipleWindows):
We now look for properties with the information we want in the rootItem: pagesOpened and
firstPageOpened.
2011-05-31 Rafael Brandao <rafael.lobo@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::render() failing
https://bugs.webkit.org/show_bug.cgi?id=60893
The test was expecting the frame contents to be already loaded
before rendering it into a QPicture. Renamed the test to fit
its real purpose more accordingly.
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::renderGeometry):
2011-05-30 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Fix unnecessary wait in API autotest tst_QWebFrame::scrollbarsOff
https://bugs.webkit.org/show_bug.cgi?id=61711
The loadFinished() signal was emitted directly inside the call for setHtml, so
the test was waiting the loadFinished() signal with a big timeout. Change this by
a very small timeout and a verification with signal spy.
In practice, setHtml() will either directly call loadFinished() or queue it to
the next event loop run, and test will work for both situations.
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::scrollbarsOff):
2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] tst_QWebElement::style() fails because QWebElement::InlineStyle doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=60372
* tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail.
(tst_QWebElement::style):
2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
https://bugs.webkit.org/show_bug.cgi?id=61042
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Mark failing test cases as expected fails.
(tst_QDeclarativeWebView::basicProperties):
(tst_QDeclarativeWebView::historyNav):
2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Fix tst_QWebPage::testOptionalJSObjects() autotest
https://bugs.webkit.org/show_bug.cgi?id=61045
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::testOptionalJSObjects): Mark failing test cases as expected fails.
2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Benjamin Poulain.
[Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
https://bugs.webkit.org/show_bug.cgi?id=59345
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::setUrlToInvalid): Mark failing test cases as expected fails.
2011-05-10 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
Reviewed by Csaba Osztrogonác.
[Qt] tst_QWebPage creates temporary files in the current working dir
https://bugs.webkit.org/show_bug.cgi?id=60497
tst_QWebPage was using QDir::currentPath when creating temporary dirs
and leaving them after the test was run. I basically borrowed the fix
from tst_QDeclarativeWebView.
* tests/qwebpage/tst_qwebpage.cpp:
(removeRecursive):
(tst_QWebPage::tmpDirPath):
(tst_QWebPage::cleanupFiles):
(tst_QWebPage::database):
(tst_QWebPage::multiplePageGroupsAndLocalStorage):
2011-05-27 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Csaba Osztrogonác.
[Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
https://bugs.webkit.org/show_bug.cgi?id=61044
Make sure to set the active window on the application too.
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::setPalette):
2011-05-23 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Andreas Kling.
[Qt] When opening a combo-box the popup renders badly.
https://bugs.webkit.org/show_bug.cgi?id=61288
Removing combobox palette changes from QtFallbackWebPopup::show() because they
are causing rendering problems for some styles.
The changes in palette are not needed because the background and foreground
colors are already set by QStandardItem::setBackground() and QStandardItem::setForeground()
in method QtFallbackWebPopup::populate().
* WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::show):
2011-05-23 Joe Wild <joseph.wild@nokia.com>
Reviewed by Andreas Kling.
[Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
https://bugs.webkit.org/show_bug.cgi?id=61200
* symbian/eabi/QtWebKitu.def:
2011-05-22 Hui Huang <hui.2.huang@nokia.com>, Yi Shen <yi.4.shen@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Upstream Symbian platform plugin with html5 video player.
* symbian/platformplugin/HTML5VideoPlugin.cpp: Added.
(HTML5FullScreenVideoHandler::HTML5FullScreenVideoHandler):
(HTML5FullScreenVideoHandler::enterFullScreen):
(HTML5FullScreenVideoHandler::exitFullScreen):
(HTML5FullScreenVideoHandler::onPlayerError):
(HTML5FullScreenVideoHandler::onPlayerStateChanged):
(HTML5FullScreenVideoHandler::onMediaStatusChanged):
(HTML5VideoPlugin::supportsExtension):
(HTML5VideoPlugin::createExtension):
* symbian/platformplugin/HTML5VideoPlugin.h: Added.
(HTML5FullScreenVideoHandler::requiresFullScreenForVideoPlayback):
(HTML5FullScreenVideoHandler::isFullScreen):
(HTML5FullScreenVideoHandler::updateScreenRect):
* symbian/platformplugin/HTML5VideoWidget.cpp: Added.
(HTML5VideoWidget::HTML5VideoWidget):
(HTML5VideoWidget::setDuration):
(HTML5VideoWidget::mousePressEvent):
(HTML5VideoWidget::onPlayerStopped):
(HTML5VideoWidget::onPlayerError):
(HTML5VideoWidget::onEndOfMedia):
(HTML5VideoWidget::onBufferingMedia):
(HTML5VideoWidget::onBufferedMedia):
(HTML5VideoWidget::onControlClicked):
(HTML5VideoWidget::onPositionChanged):
(HTML5VideoWidget::onSliderMoved):
(HTML5VideoWidget::onCloseClicked):
(HTML5VideoWidget::showFullScreen):
(HTML5VideoWidget::setVolume):
* symbian/platformplugin/HTML5VideoWidget.h: Added.
* symbian/platformplugin/OverlayWidget.cpp: Added.
(OverlayWidget::OverlayWidget):
(OverlayWidget::~OverlayWidget):
(OverlayWidget::setDuration):
(OverlayWidget::setPosition):
(OverlayWidget::setVolume):
(OverlayWidget::mousePressEvent):
(OverlayWidget::onPlayerStopped):
(OverlayWidget::onPlayerError):
(OverlayWidget::onEndOfMedia):
(OverlayWidget::onBufferingMedia):
(OverlayWidget::onBufferedMedia):
(OverlayWidget::timeToString):
(OverlayWidget::applyStyleSheet):
(OverlayWidget::onControlClicked):
(OverlayWidget::onSliderMoved):
(OverlayWidget::onSoundClicked):
(OverlayWidget::onCloseClicked):
(OverlayWidget::onVolumeSliderReleased):
(OverlayWidget::onVolumeSliderMoved):
(OverlayWidget::onTimerTimeout):
(OverlayWidget::showFullScreen):
* symbian/platformplugin/OverlayWidget.h: Added.
* symbian/platformplugin/PlayerButton.cpp: Added.
(PlayerButton::PlayerButton):
(PlayerButton::event):
* symbian/platformplugin/PlayerButton.h: Added.
* symbian/platformplugin/PlayerLabel.cpp: Added.
(PlayerLabel::PlayerLabel):
(PlayerLabel::onPlayerError):
(PlayerLabel::startBufferingAnimation):
(PlayerLabel::stopBufferingAnimation):
(PlayerLabel::onAnimationTimeout):
* symbian/platformplugin/PlayerLabel.h: Added.
* symbian/platformplugin/WebPlugin.cpp:
(WebPlugin::createExtension):
* symbian/platformplugin/images: Added.
* symbian/platformplugin/images/button_cannotplay.png: Added.
* symbian/platformplugin/images/button_close.png: Added.
* symbian/platformplugin/images/button_pause.png: Added.
* symbian/platformplugin/images/button_play.png: Added.
* symbian/platformplugin/images/button_sound_off.png: Added.
* symbian/platformplugin/images/button_sound_on.png: Added.
* symbian/platformplugin/images/loading_buffering_1.png: Added.
* symbian/platformplugin/images/loading_buffering_2.png: Added.
* symbian/platformplugin/images/loading_buffering_3.png: Added.
* symbian/platformplugin/images/loading_buffering_4.png: Added.
* symbian/platformplugin/platformplugin.pro:
* symbian/platformplugin/platformplugin.qrc: Added.
* symbian/platformplugin/qss: Added.
* symbian/platformplugin/qss/OverlayWidget.qss: Added.
2011-05-18 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Andreas Kling.
[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
https://bugs.webkit.org/show_bug.cgi?id=33179
Remove the implementation of the handleInputMethodKeydown, which introduces
a regression(r82243) on Linux. Also, add more Api tests for the EnterKey event.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleInputMethodKeydown): Remove implementation.
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods): Add more tests.
2011-05-17 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Simplify syntax in test code to make prepare-ChangeLog less confused
https://bugs.webkit.org/show_bug.cgi?id=60978
Backslash to escape newlines was confusing both prepare-ChangeLog and the
QtCreator highlight system.
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::evalJSV):
Remove usage of backslash to escape newlines in string literal.
2011-05-16 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView.
https://bugs.webkit.org/show_bug.cgi?id=60892
Don't set the ItemClipsChildrenToShape flag for the root platform layer,
since that is now the overflow controls layer. The clip layer, which was
previously the root platform layer, already gets the flag by way of
the GraphicsLayer mask-to-bounds flag.
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
2011-05-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by nobody, build fix.
[Qt] Fix build on MSVC.
qobject_cast<> requires the class to be exported on MSVC,
removing it since the code that needs it is commented out for
the same reason.
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::elementAreaAt):
2011-05-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by nobody, build fix.
[Qt] Fix build on MSVC by only enabling tst_MIMESniffing on linux.
* tests/tests.pro:
2011-05-05 Prasanth Ullattil <prasanth.ullattil@nokia.com>
Reviewed by Simon Hausmann.
Install correct header files for webkit.
Since WebKit is no longer inside Qt, we can remove the detection for
that.
[Qt] Install targets are not working correctly for modularized Qt and QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=57621
* QtWebKit.pro:
2011-05-05 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
https://bugs.webkit.org/show_bug.cgi?id=60224
We should use nullptr rather than 0. nullptr will be added in the new C++ standard
but WebKit already has a nullptr class if there is no c++0x support.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::addUserStyleSheet):
2011-05-04 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902
* WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::webView):
2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed warning fix.
The variable is just unused.
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods):
2011-05-04 Tao Bai <michaelbai@chromium.org>
Reviewed by David Kilzer.
Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143
Respect the interface change in FrameLoaderClient.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
* WebCoreSupport/FrameLoaderClientQt.h:
2011-03-31 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Qt WebKit updates view on HTTP 204 response
https://bugs.webkit.org/show_bug.cgi?id=42529
Ignoring http responses which have status code equal to 204 (No Content)
or 205 (Reset Content).
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] Fix signals emitted in FakeReply used in autotests
https://bugs.webkit.org/show_bug.cgi?id=60049
The signals emitted for each case of FakeReply were swapped (error case
emitting metaDataChanged() and redirect case emitting error()). Emitting
readyRead() is not necessary.
* tests/qwebframe/tst_qwebframe.cpp:
(FakeReply::FakeReply):
Choose the different continue function for each case of FakeReply. This removes
the need of the if-statement in timeout() and let us replace timeout() with two
simpler functions.
(FakeReply::continueRedirect):
(FakeReply::continueError):
Continuation cases, emitting the minimal set of signals needed for each case.
2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Dimitri Glazkov.
Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::shadowRoot): Added #include for ShadowRoot.h.
2011-05-03 Keith Kyzivat <keith.kyzivat@nokia.com>
Reviewed by Andreas Kling.
[Qt] QtDeclarative Webview element has a fixed white background
https://bugs.webkit.org/show_bug.cgi?id=40918
QProperty REVISION feature is not present in certain Qt Trunk clones.
These builds report their version as 4.8.0, and therefore break on the
prior #if QT_VERSION >= 0x040704. The proper fix is to check based on
the existance of Q_REVISION.
* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):
* declarative/qdeclarativewebview.cpp:
* declarative/qdeclarativewebview_p.h:
2011-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Prune some unnecessary #includes
https://bugs.webkit.org/show_bug.cgi?id=59895
Start getting rid of unnecessary #includes and forward declares.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2011-04-29 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Adam Barth.
Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
ENABLE(QT_BEARER) -> USE(QT_BEARER)
* Api/qwebsettings.cpp:
2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
* Api/qwebpage.cpp:
2011-04-28 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
https://bugs.webkit.org/show_bug.cgi?id=59704
* WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::show):
* WebCoreSupport/QtFallbackWebPopup.h:
2011-04-27 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Upstream Symbian platform plugin.
* QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
* symbian/platformplugin: Added.
* symbian/platformplugin/WebPlugin.cpp: Added.
(ItemListDelegate::ItemListDelegate):
(ItemListDelegate::paint):
(Popup::Popup):
(Popup::resizeEvent):
(Popup::populateList):
(Popup::onItemSelected):
(Popup::updateSelectionsBeforeDialogClosing):
(Popup::updateAndClose):
(WebPopup::WebPopup):
(WebPopup::~WebPopup):
(WebPopup::createSingleSelectionPopup):
(WebPopup::createMultipleSelectionPopup):
(WebPopup::createPopup):
(WebPopup::show):
(WebPopup::hide):
(WebPopup::popupClosed):
(WebPopup::itemClicked):
(SingleSelectionPopup::SingleSelectionPopup):
(MultipleSelectionPopup::MultipleSelectionPopup):
(WebNotificationPresenter::showNotification):
(WebPlugin::supportsExtension):
(WebPlugin::createExtension):
* symbian/platformplugin/WebPlugin.h: Added.
(Popup::preSelectedIndices):
(Popup::listWidget):
(WebNotificationPresenter::WebNotificationPresenter):
(WebNotificationPresenter::~WebNotificationPresenter):
* symbian/platformplugin/platformplugin.pro: Added.
* symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
(QWebSelectData::~QWebSelectData):
(QWebSelectMethod::~QWebSelectMethod):
(QWebNotificationData::~QWebNotificationData):
(QWebNotificationPresenter::QWebNotificationPresenter):
(QWebNotificationPresenter::~QWebNotificationPresenter):
(QWebTouchModifier::~QWebTouchModifier):
(QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
(QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
(QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
2011-04-26 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt][Symbian] Fix Api test failure -- tst_QWebFrame::setHtmlWithBaseURL
https://bugs.webkit.org/show_bug.cgi?id=56946
Deployed the missing resource for Symbian platform.
* tests/qwebframe/qwebframe.pro:
2011-04-26 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Andreas Kling.
[Qt] Build fix: QtDeclarative Webview element has a fixed white background
https://bugs.webkit.org/show_bug.cgi?id=40918
Macro Q_REVISION and associated qdeclarativeitem.h signals are not available in 4.7.3 headers in Nokia Qt SDK.
* declarative/plugin.cpp: Bump up required version to 4.7.4+
(WebKitQmlPlugin::registerTypes):
* declarative/qdeclarativewebview.cpp: ditto
* declarative/qdeclarativewebview_p.h: ditto
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: ditto
2011-04-26 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
[Qt] Implement LayoutTestController::setAutofilled
https://bugs.webkit.org/show_bug.cgi?id=59439
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setAutofilled):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84627.
http://trac.webkit.org/changeset/84627
https://bugs.webkit.org/show_bug.cgi?id=59271
It broke Symbian build (Requested by Ossy on #webkit).
* QtWebKit.pro:
* symbian/platformplugin/WebPlugin.cpp: Removed.
* symbian/platformplugin/WebPlugin.h: Removed.
* symbian/platformplugin/platformplugin.pro: Removed.
* symbian/platformplugin/qwebkitplatformplugin.h: Removed.
2011-04-22 Sam Weinig <sam@webkit.org>
Fix qt build.
* Api/qwebelement.cpp:
(setupScriptContext):
2011-04-22 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Upstream Symbian platform plugin.
* QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
* symbian/platformplugin: Added.
* symbian/platformplugin/WebPlugin.cpp: Added.
(ItemListDelegate::ItemListDelegate):
(ItemListDelegate::paint):
(Popup::Popup):
(Popup::resizeEvent):
(Popup::populateList):
(Popup::onItemSelected):
(Popup::updateSelectionsBeforeDialogClosing):
(Popup::updateAndClose):
(WebPopup::WebPopup):
(WebPopup::~WebPopup):
(WebPopup::createSingleSelectionPopup):
(WebPopup::createMultipleSelectionPopup):
(WebPopup::createPopup):
(WebPopup::show):
(WebPopup::hide):
(WebPopup::popupClosed):
(WebPopup::itemClicked):
(SingleSelectionPopup::SingleSelectionPopup):
(MultipleSelectionPopup::MultipleSelectionPopup):
(WebNotificationPresenter::showNotification):
(WebPlugin::supportsExtension):
(WebPlugin::createExtension):
* symbian/platformplugin/WebPlugin.h: Added.
(Popup::preSelectedIndices):
(Popup::listWidget):
(WebNotificationPresenter::WebNotificationPresenter):
(WebNotificationPresenter::~WebNotificationPresenter):
* symbian/platformplugin/platformplugin.pro: Added.
* symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
(QWebSelectData::~QWebSelectData):
(QWebSelectMethod::~QWebSelectMethod):
(QWebNotificationData::~QWebNotificationData):
(QWebNotificationPresenter::QWebNotificationPresenter):
(QWebNotificationPresenter::~QWebNotificationPresenter):
(QWebTouchModifier::~QWebTouchModifier):
(QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
(QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
(QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::canCopyCut):
(WebCore::EditorClientQt::canPaste):
* WebCoreSupport/EditorClientQt.h:
2011-04-21 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Fix the style issue for Api/qwebkitplatformplugin.h
https://bugs.webkit.org/show_bug.cgi?id=59097
Fix the style issues for Api/qwebkitplatformplugin.h found by the webkit-check-style.
* Api/qwebkitplatformplugin.h:
2011-04-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Csaba Osztrogonác.
[Qt] REGRESSION(84057): It made 4 API tests fail
https://bugs.webkit.org/show_bug.cgi?id=58848
After MIME sniffing support was added, some autotests are failing because
the sniffer doesn't recognize our HTML pages.
This fixes tst_QWebPage::backActionUpdate(), tst_QWebPage::errorPageExtensionInFrameset()
and tst_QWebFrame::horizontalScrollAfterBack().
* tests/qwebframe/resources/testiframe.html:
* tests/qwebframe/resources/testiframe2.html:
Remove spurious </html> in beginning of the document.
* tests/qwebpage/resources/framedindex.html:
* tests/qwebpage/resources/index.html:
Add <html> (and </html>) tags, <frameset> is not recognized by the sniffer as a
possible starting tag for HTML document.
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::errorPageExtensionInFrameset):
Verify if we do have a main frame and the main frame has the children frames we
expect. This will avoid crashing if for some reason children frames are not
loaded.
2011-04-20 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
layoutTestController can create and destroy shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=59058
Support for new methods in Qt DRT.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::ensureShadowRoot):
(DumpRenderTreeSupportQt::removeShadowRoot):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-04-20 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Cleanup includepath adjustment for generated files
https://bugs.webkit.org/show_bug.cgi?id=58869
* QtWebKit.pro: Revert the hacky fix in r84174. Remove
unnecessary logic.
2011-04-19 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Andreas Kling.
[Qt][Symbian] Fix Api test failure -- tst_QWebView::setPalette()
https://bugs.webkit.org/show_bug.cgi?id=57254
Skip test for setPalette() which doesn't work
when WTF_USE_QT_MOBILE_THEME is defined.
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
* tests/qwebview/tst_qwebview.cpp:
* tests/tests.pri:
2011-04-19 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache
https://bugs.webkit.org/show_bug.cgi?id=58044
Fixing this test by disabling the scrollbars on the graphics view
since QtWebKit handles scrolling and scrollbar automatically and correctly.
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::widgetsRenderingThroughCache):
2011-04-19 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] X11: Text selection is causing oncopy event to be called
https://bugs.webkit.org/show_bug.cgi?id=58656
Always when text is selected the oncopy event is fired, this behavior does
not exist in Firefox or Chrome. Now, when selecting a text, QtWebKit
is making multi part-copies (with rich text metadata), the multi-part
data can be obtained by data transfer items interface when supported by QtWebKit.
Also, copies to the clipboard of a selected image, is not supported by Chrome and
Firefox and was removed from QtWebKit.
* Api/qwebpage.cpp:
(QWebPagePrivate::handleClipboard):
2011-04-18 Csaba Osztrogonác <ossy@webkit.org>
[Qt][WK2] Unreviewed buildfix after r84174.
* QtWebKit.pro: Missing includepath added.
2011-04-18 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Fix Api test failure -- tst_QWebFrame::inputFieldFocus
https://bugs.webkit.org/show_bug.cgi?id=57546
Disable the fullscreen VKB when testing inputFieldFocus().
* tests/qwebframe/tst_qwebframe.cpp:
2011-04-18 Andreas Kling <kling@webkit.org>
[Qt] DRT: Unreviewed test fix after r84168.
Dump the original request KURL for blocked access attempts.
Turns out converting it to a QUrl lower-cases the hostname.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
2011-04-18 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix Api tests for QWebPage on Symbian
https://bugs.webkit.org/show_bug.cgi?id=56924
Ignores the style attribute that selectedHtml() returns.
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::cursorMovements):
(tst_QWebPage::textSelection):
(tst_QWebPage::findText):
2011-04-18 Andreas Kling <kling@webkit.org>
Reviewed by Adam Barth.
REGRESSION (r84010): [Qt] DRT: Unbreak redirection of http:/ URLs.
https://bugs.webkit.org/show_bug.cgi?id=58779
KURL::host() doesn't return the host part of [broken] http:/ URLs, so use
QUrl instead to match the behavior of other ports.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
2011-04-18 Dominic Cooney <dominicc@chromium.org>
Reviewed by Andreas Kling.
Add layoutTestController.shadowRoot to Qt DRT.
https://bugs.webkit.org/show_bug.cgi?id=58759
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::shadowRoot): Added.
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-04-16 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Autotest got missed in the handover of the QML WebView element
https://bugs.webkit.org/show_bug.cgi?id=41449
Importing WebView QML element test cases from Qt repository. I did some
style modifications and simplifications in the original code but hopefully
without changing the behavior.
Tests that do not pass are marked with QEXPECT_FAIL or QSKIP. The two major
issues currently are:
- pixelCache() test checked the usage of pixel cache by using a subclass of
QDeclarativeWebView. We can't do that right now because this class is not
exported. We may need a Q_AUTOTEST_EXPORT thing for QtWebKit if we want
this kind of test.
- elementAtArea() test uses a function that is not exported. But in this case
I think we should test it's user, the public method "heuristicZoom".
* tests/qdeclarativewebview/resources/basic.html: Added.
* tests/qdeclarativewebview/resources/basic.png: Added.
* tests/qdeclarativewebview/resources/basic.qml: Added.
* tests/qdeclarativewebview/resources/elements.html: Added.
* tests/qdeclarativewebview/resources/elements.qml: Added.
* tests/qdeclarativewebview/resources/forward.html: Added.
* tests/qdeclarativewebview/resources/forward.png: Added.
* tests/qdeclarativewebview/resources/javaScript.html: Added.
* tests/qdeclarativewebview/resources/javaScript.qml: Added.
* tests/qdeclarativewebview/resources/loadError.qml: Added.
* tests/qdeclarativewebview/resources/newwindows.html: Added.
* tests/qdeclarativewebview/resources/newwindows.qml: Added.
* tests/qdeclarativewebview/resources/propertychanges.qml: Added.
* tests/qdeclarativewebview/resources/sethtml.qml: Added.
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::tmpDir):
(strippedHtml):
(fileContents):
(removeRecursive):
(tst_QDeclarativeWebView::cleanupTestCase):
(tst_QDeclarativeWebView::basicProperties):
(tst_QDeclarativeWebView::elementAreaAt):
(tst_QDeclarativeWebView::historyNav):
(callEvaluateJavaScript):
(tst_QDeclarativeWebView::javaScript):
(tst_QDeclarativeWebView::loadError):
(tst_QDeclarativeWebView::multipleWindows):
(tst_QDeclarativeWebView::newWindowComponent):
(tst_QDeclarativeWebView::newWindowParent):
(tst_QDeclarativeWebView::pressGrabTime):
(tst_QDeclarativeWebView::renderingEnabled):
(tst_QDeclarativeWebView::setHtml):
(tst_QDeclarativeWebView::settings):
(tst_QDeclarativeWebView::checkNoErrors):
* tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
2011-04-08 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QWebPage MIME type handling inconsistency with other web browsers
https://bugs.webkit.org/show_bug.cgi?id=46968
Implementing mime type sniffing based on
http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createNetworkingContext):
* WebCoreSupport/FrameNetworkingContextQt.cpp:
(WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
(WebCore::FrameNetworkingContextQt::create):
(WebCore::FrameNetworkingContextQt::MIMESniffingEnabled):
* WebCoreSupport/FrameNetworkingContextQt.h:
* tests/MIMESniffing/MIMESniffing.pro: Added.
* tests/MIMESniffing/TestData.h: Added.
* tests/MIMESniffing/resources.qrc: Added.
* tests/MIMESniffing/resources/application_atom+xml: Added.
* tests/MIMESniffing/resources/application_ogg: Added.
* tests/MIMESniffing/resources/application_pdf: Added.
* tests/MIMESniffing/resources/application_postscript: Added.
* tests/MIMESniffing/resources/application_rdf+xml: Added.
* tests/MIMESniffing/resources/application_rss+xml: Added.
* tests/MIMESniffing/resources/application_x-gzip: Added.
* tests/MIMESniffing/resources/application_x-rar-compressed: Added.
* tests/MIMESniffing/resources/application_zip: Added.
* tests/MIMESniffing/resources/audio_x-wave: Added.
* tests/MIMESniffing/resources/image_bmp: Added.
* tests/MIMESniffing/resources/image_gif: Added.
* tests/MIMESniffing/resources/image_jpeg: Added.
* tests/MIMESniffing/resources/image_png: Added.
* tests/MIMESniffing/resources/image_vnd.microsoft.icon: Added.
* tests/MIMESniffing/resources/image_webp: Added.
* tests/MIMESniffing/resources/text_html: Added.
* tests/MIMESniffing/resources/text_xml: Added.
* tests/MIMESniffing/resources/video_webm: Added.
* tests/MIMESniffing/tst_MIMESniffing.cpp: Added.
(tst_MIMESniffing::tst_MIMESniffing):
(errorText):
(tst_MIMESniffing::testCase1):
* tests/tests.pro:
2011-04-15 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] DRT: Block access to external URLs.
Implement the "Blocked access to external URL" behavior for Qt's DRT,
based on what other ports are doing.
Fixes <http://webkit.org/b/57306> and <http://webkit.org/b/58523>.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
2011-01-26 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Reviewed by Antonio Gomes.
[Qt] Web Inspector does not highlight elements
https://bugs.webkit.org/show_bug.cgi?id=35125
Adjust Web inspector to highlight elements on the page when the mouse
hovers the element on DOM inspector.
* Api/qwebframe.cpp:
(QWebFramePrivate::renderRelativeCoords):
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::highlight):
(WebCore::InspectorClientQt::hideHighlight):
2011-04-12 George Guo <George.Guo@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] On Symbian got "Update Error" when installing QtWebkit.sis
http://bugs.webkit.org/show_bug.cgi?id=58141
If QtWebKit is already in Symbian ROM, we need package to be
both SA and RU type
* QtWebKit.pro:
2011-04-12 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
https://bugs.webkit.org/show_bug.cgi?id=58251
Fix an issue with slot names after http://trac.webkit.org/changeset/83512.
* Api/qwebframe.cpp:
(QWebFrame::QWebFrame):
2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
https://bugs.webkit.org/show_bug.cgi?id=58251
Qt coding conventions states that private slots should be located in private implementation of
the class. This allows us to rename/delete the slots in the future without breaking anything.
No new tests added, just a simple refactoring.
* Api/qwebframe.cpp:
(QWebFramePrivate::_q_orientationChanged):
* Api/qwebframe.h:
* Api/qwebframe_p.h:
2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Sub-Frame content is not updated when scrolling in certain circumstances
https://bugs.webkit.org/show_bug.cgi?id=50373
Make sure that we invalidate the backing store when using TILED_BACKING_STORE
and the page contains sub frames. This bug appears only when frame flattening is
disabled and scrollable subframes.
Original patch from Thomas Thrainer.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::invalidateWindow):
2011-04-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] HTML5 Drag and Drop demos not working
https://bugs.webkit.org/show_bug.cgi?id=56486
Handling the drop with JavaScript was not working with Qt because if the action is ignored
in response to DragEnter, no further events are sent to the view.
Drag and drop is defined and used differently by webpages. The drag move events are determining
what action should take place. To adopt this behavior for Qt, we always accept drag enter events
on the widget.
* Api/qwebpage.cpp:
(QWebPagePrivate::dragEnterEvent):
2011-04-11 Andras Becsi <abecsi@webkit.org>
Reviewed by Andreas Kling.
[Qt] REGRESSION(83122): tst_QWebElement::style() fails
https://bugs.webkit.org/show_bug.cgi?id=58032
According to the documentation of QWebElement the styleProperty method should
not respect style inheritance and other CSS rules for the InlineStyle enum.
r83122 fixed this behaviour.
* tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::style): Fix the expected color for QWebElement::InlineStyle.
2011-04-11 Andreas Kling <andreas.kling@nokia.com>
Build fix after r83436.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
2011-04-11 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Benjamin Poulain.
[Qt] dumpResourceResponseMIMETypes shouldn't strip URL query string.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): Use KURL::lastPathComponent()
for the dumpResourceResponseMIMETypes display string instead of QFileInfo::fileName().
This is in line with the Mac port.
2011-04-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83295.
http://trac.webkit.org/changeset/83295
https://bugs.webkit.org/show_bug.cgi?id=58144
Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleInputMethodKeydown):
2011-04-08 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Antonio Gomes.
[Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
https://bugs.webkit.org/show_bug.cgi?id=57472
Avoid to insert new line for both keydown event & keypress event.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleInputMethodKeydown):
2011-04-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] QWebFrame::setUrl works only from second time if url fragment is present
https://bugs.webkit.org/show_bug.cgi?id=32723
When clearing the frame, instead of using the URL passed to QWebFrame::setUrl(),
use an invalid URL (the begin() without arguments). Clearing the document
with the same URL was causing problems when we had a fragment because it assume that
only scrolling was enough and did not loaded the document again.
When setUrl() is called but fails, url() is expected to return the requested value. The
begin(url) guaranteed that before. This patch adds a member to track the URL, which is
updated when the URL changes and also when setUrl() is called.
KURL was used for the member so that when setUrl() is called, and then url() is checked
before the page gets loaded, we perform the same conversion that will be performed by a
successful load, e.g. add trailing '/' to an address. This behavior is checked by
tst_QWebFrame::requestedUrl() test.
For the record: the second QWebPage::setUrl() worked because the load was considered a
FrameLoadTypeSame, and because of that, was not fit for just scrolling, a reload was
needed. See FrameLoader::shouldScrollToAnchor() for details on this classification.
* Api/qwebframe.cpp:
(QWebFramePrivate::emitUrlChanged): update our URL member and emit the signal.
(clearCoreFrame):
(isCoreFrameClear):
(QWebFrame::setUrl):
(QWebFrame::url):
(QWebFrame::baseUrl): look in the document for the baseURL since its contents can change
the baseURL, e.g. by using the <base> tag.
* Api/qwebframe_p.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::setUrlWithFragment): unskip test.
2011-04-07 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Build fix when using Phonon as a backend for the multimedia support.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::~ChromeClientQt):
* WebCoreSupport/ChromeClientQt.h:
2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
https://bugs.webkit.org/show_bug.cgi?id=56086
Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
from the LayoutTestController.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-04-06 Anders Bakken <agbakken@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] FrameLoaderClientQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40254
* WebCoreSupport/FrameLoaderClientQt.cpp:
(drtDescriptionSuitableForTestResult):
(WebCore::FrameLoaderClientQt::hasWebView):
(WebCore::FrameLoaderClientQt::setCopiesOnScroll):
(WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
(WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
(WebCore::FrameLoaderClientQt::cancelPolicyCheck):
(WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientQt::postProgressStartedNotification):
(WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
(WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
(WebCore::FrameLoaderClientQt::willChangeTitle):
(WebCore::FrameLoaderClientQt::didChangeTitle):
(WebCore::FrameLoaderClientQt::finishedLoading):
(WebCore::FrameLoaderClientQt::frameLoadCompleted):
(WebCore::FrameLoaderClientQt::provisionalLoadStarted):
(WebCore::FrameLoaderClientQt::didFinishLoad):
(WebCore::FrameLoaderClientQt::setTitle):
(WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
(WebCore::FrameLoaderClientQt::updateGlobalHistory):
(WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
(WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem):
(WebCore::FrameLoaderClientQt::committedLoad):
(WebCore::FrameLoaderClientQt::download):
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
(WebCore::FrameLoaderClientQt::shouldUseCredentialStorage):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientQt::createFrame):
(WebCore::FrameLoaderClientQt::objectContentType):
(WebCore::FrameLoaderClientQt::createPlugin):
2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
https://bugs.webkit.org/show_bug.cgi?id=57974
We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
No new tests needed, just a config flag rename.
* Api/qwebkitplatformplugin.h:
* WebCoreSupport/ChromeClientQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::mediaContentUrlByElementId):
* WebCoreSupport/FullScreenVideoQt.cpp:
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
(WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
(WebCore::FullScreenVideoQt::isValid):
* WebCoreSupport/FullScreenVideoQt.h:
* WebCoreSupport/QtPlatformPlugin.cpp:
* WebCoreSupport/QtPlatformPlugin.h:
* examples/platformplugin/WebPlugin.cpp:
(WebPlugin::supportsExtension):
(WebPlugin::createExtension):
* examples/platformplugin/WebPlugin.h:
* examples/platformplugin/platformplugin.pro:
* examples/platformplugin/qwebkitplatformplugin.h:
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::loadHtml5Video):
* tests/tests.pri:
2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Implement fullscreen playback for the GStreamer backend.
https://bugs.webkit.org/show_bug.cgi?id=56826
Implement support for fullscreen playback when building the
Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
The implementation is done in FullScreenVideoQt alongside with
the Qt Multimedia support.
No new tests because layout tests cover it. They are not yet activated
but will be any time soon.
* QtWebKit.pro:
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::~ChromeClientQt):
(WebCore::ChromeClientQt::enterFullscreenForNode):
(WebCore::ChromeClientQt::exitFullscreenForNode):
* WebCoreSupport/ChromeClientQt.h:
* WebCoreSupport/FullScreenVideoQt.cpp:
(WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler):
(WebCore::GStreamerFullScreenVideoHandler::setVideoElement):
(WebCore::GStreamerFullScreenVideoHandler::enterFullScreen):
(WebCore::GStreamerFullScreenVideoHandler::windowClosed):
(WebCore::GStreamerFullScreenVideoHandler::exitFullScreen):
(WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
(WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
(WebCore::FullScreenVideoQt::isValid):
* WebCoreSupport/FullScreenVideoQt.h:
(WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):
2011-04-06 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Improve tests for QWebFrame::url() and related methods
https://bugs.webkit.org/show_bug.cgi?id=57865
* tests/qwebframe/tst_qwebframe.cpp:
(FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test.
(tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl()
that fails and a load() that fails (for a different URL).
(tst_QWebFrame::setUrlWithFragment_data):
(tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
the URL in the frame before the test starts.
(tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
the same URL as argument.
(extractBaseUrl):
(tst_QWebFrame::setUrlThenLoads_data):
(tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
sequence of set and loads. Those tests are interesting because the properties
react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
is used or after the load() is committed and baseUrl() is similar to url() but also depends
on the contents of the page when it loads.
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
* WebCoreSupport/EditorClientQt.h:
(WebCore::EditorClientQt::requestCheckingOfString):
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
setContentEditable with true/false/inherit string is not working properly
https://bugs.webkit.org/show_bug.cgi?id=52058
Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
as rendererIsEditable is for WebCore internal use.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleKeyboardEvent):
2011-04-01 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Benjamin Poulain.
Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into
Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords.
Tiled painting still causes synchronous layout when
accelerated compositing and texture mapper are enabled
https://bugs.webkit.org/show_bug.cgi?id=56929
* Api/qwebframe.cpp:
(QWebFramePrivate::renderFromTiledBackingStore):
(QWebFramePrivate::renderRelativeCoords):
(QWebFramePrivate::renderFrameWidgets):
* Api/qwebframe_p.h:
2011-04-01 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Benjamin Poulain.
[Qt] DragClientQt.h has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40425
* WebCoreSupport/DragClientQt.h:
2011-03-31 Marius Storm-Olsen <marius.storm-olsen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
https://bugs.webkit.org/show_bug.cgi?id=57017
Build fix. No new tests.
* QtWebKit.pro:
2011-03-31 Evan Martin <evan@chromium.org>
Another build fix.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::updateGlobalHistory):
2011-03-31 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Benjamin Poulain.
[Qt] ChromeClientQt.h has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40239
* WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::scrollbarsModeDidChange):
(WebCore::ChromeClientQt::needTouchEvents):
(WebCore::ChromeClientQt::formStateDidChange):
(WebCore::ChromeClientQt::scrollRectIntoView):
(WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
(WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
2011-03-31 Evan Martin <evan@chromium.org>
Build fix from previous change.
* Api/qwebframe.cpp:
(QWebFrame::title):
2011-03-31 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
<title> should support dir attribute
https://bugs.webkit.org/show_bug.cgi?id=50961
Update to new FrameLoaderClient interface.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
(WebCore::FrameLoaderClientQt::setTitle):
* WebCoreSupport/FrameLoaderClientQt.h:
2011-03-30 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes
https://bugs.webkit.org/show_bug.cgi?id=57020
Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints().
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::focusInputTypes):
2011-03-30 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Fix LoadHTMLStringItem::invoke() after r75966
Add DRT support for loading an alternate HTML string
for error pages. This allows Qt to unskip
http/tests/navigation/go-back-to-error-page.html.
https://bugs.webkit.org/show_bug.cgi?id=52614
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setAlternateHtml):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-03-29 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed build fix for build-webkit -minimal.
Breakage introduced by http://trac.webkit.org/changeset/82238.
The minimal option has no support for shortcuts.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleInputMethodKeydown):
2011-03-29 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
https://bugs.webkit.org/show_bug.cgi?id=33179
Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleInputMethodKeydown):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods):
2011-03-29 Andreas Kling <kling@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Fix documentation for QWebPage::repaintRequested()
This signal is always emitted when the page is dirtied, so remove
reference to old behavior where we would only emit the signal for
headless QWebPages.
* Api/qwebpage.cpp:
2011-03-28 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Pass QString() instead of String() when emitting titleChanged() for new loads.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
2011-03-28 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
https://bugs.webkit.org/show_bug.cgi?id=52629
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of
QWebPage::repaintRequested() use a Qt::QueuedConnection.
* tests/qwebpage/tst_qwebpage.cpp:
(RepaintRequestedRenderer::RepaintRequestedRenderer):
(RepaintRequestedRenderer::onRepaintRequested):
(tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling
QWebFrame::render() in a slot connected to to QWebPage::repaintRequested()
doesn't cause recursive signal emissions.
2011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087
* QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
* tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
since they are applications, not libraries.
2011-03-28 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] QtWebKit does not link with --3d-canvas using MinGW
https://bugs.webkit.org/show_bug.cgi?id=57225
* QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
2011-03-28 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Andreas Kling.
REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
https://bugs.webkit.org/show_bug.cgi?id=57183
Windows buildfix after r82065.
* Api/DerivedSources.pro: Readding escaping on Windows platforms.
2011-03-27 Andreas Kling <kling@webkit.org>
Fix build warning about IconDatabaseClient.h (wrong path.)
* QtWebKit.pro:
2011-03-27 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Support for CSS color and background-color properties on select element's dropdown list
https://bugs.webkit.org/show_bug.cgi?id=51627
Extend the QWebSelectData interface with background and foreground colors
for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
getters in RenderMenuList.
* Api/qwebkitplatformplugin.h:
* WebCoreSupport/PopupMenuQt.cpp:
(SelectData::backgroundColor):
(SelectData::foregroundColor):
(SelectData::itemBackgroundColor):
(SelectData::itemForegroundColor):
* WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::show):
(WebCore::QtFallbackWebPopup::populate):
2011-03-27 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Andreas Kling.
[Qt][Symbian] Fix Api test failure -- microFocusCoordinates
https://bugs.webkit.org/show_bug.cgi?id=57108
Since the canvas is not self-closing tag, we need to add '</canvas>'.
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::microFocusCoordinates):
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::microFocusCoordinates):
2011-03-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
https://bugs.webkit.org/show_bug.cgi?id=57143
Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
define WTF_USE_TEXTURE_MAPPER=1.
* QtWebKit.pro:
2011-03-27 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
https://bugs.webkit.org/show_bug.cgi?id=57183
The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
which was due to the outputting code previously being wrapped in eval().
* Api/DerivedSources.pro:
2011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087
Use explicit conversion for string to avoid depending on the default codec
installed by the user code.
* Api/qwebkitversion.cpp:
(qWebKitVersion):
* Api/qwebpage.cpp:
(QWebPagePrivate::dynamicPropertyChangeEvent):
(QWebPage::javaScriptConsoleMessage):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(convertToPropertyName):
(DumpRenderTreeSupportQt::setEditingBehavior):
(DumpRenderTreeSupportQt::plainText):
* WebCoreSupport/EditorClientQt.cpp:
(dumpRange):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(drtDescriptionSuitableForTestResult):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::openInspectorFrontend):
* WebCoreSupport/InspectorServerQt.cpp:
(WebCore::parseWebSocketChallengeNumber):
(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
2011-03-26 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
https://bugs.webkit.org/show_bug.cgi?id=57157
Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
is always emitted when appropriate.
* QtWebKit.pro: Add new files.
* WebCoreSupport/IconDatabaseClientQt.h: Added.
* WebCoreSupport/IconDatabaseClientQt.cpp: Added.
(WebCore::IconDatabaseClientQt::instance):
(WebCore::IconDatabaseClientQt::IconDatabaseClientQt):
(WebCore::IconDatabaseClientQt::~IconDatabaseClientQt):
(WebCore::IconDatabaseClientQt::performImport):
(WebCore::IconDatabaseClientQt::didRemoveAllIcons):
(WebCore::IconDatabaseClientQt::didImportIconURLForPageURL):
(WebCore::IconDatabaseClientQt::didImportIconDataForPageURL):
(WebCore::IconDatabaseClientQt::didChangeIconForPageURL):
(WebCore::IconDatabaseClientQt::didFinishURLImport):
* WebCoreSupport/FrameLoaderClientQt.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::registerForIconNotification):
(WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected
to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the
QWebFrame::iconChanged() signal when the IconDatabases finishes loading
a cached favicon for the frame's URL.
* Api/qwebsettings.cpp:
(QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is
instantiated. An IconDatabaseClient has to be registered before the IconDatabase
spawns its reader thread.
2011-03-25 Andy Estes <aestes@apple.com>
Reviewed by Adele Peterson.
REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016
Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::objectContentType):
* WebCoreSupport/FrameLoaderClientQt.h:
2011-03-25 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
rename Node::isContentEditable and all call sites to rendererIsEditable
https://bugs.webkit.org/show_bug.cgi?id=54290
This is part of the effort to separate JS API HTMLElement isContentEditable from
internal Node::rendererIsEditable.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleKeyboardEvent):
2011-03-25 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] The keyboard shortcuts during fullscreen playback do not work.
https://bugs.webkit.org/show_bug.cgi?id=57095
We need to explicitely set the focus on the widget in order to receive the keyboard events.
* WebCoreSupport/FullScreenVideoWidget.cpp:
(WebCore::FullScreenVideoWidget::show):
2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071
broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::objectContentType):
* WebCoreSupport/FrameLoaderClientQt.h:
2011-03-24 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016
Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::objectContentType):
* WebCoreSupport/FrameLoaderClientQt.h:
2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
https://bugs.webkit.org/show_bug.cgi?id=40884
Add tests and benchmarks for the software fallback of WebGL.
* tests/benchmarks/webgl/10000_triangles.html: Added.
* tests/benchmarks/webgl/tst_webgl.cpp: Added.
(GraphicsView::GraphicsView):
(GraphicsView::resizeEvent):
(tst_WebGlPerformance::init):
(tst_WebGlPerformance::cleanup):
(tst_WebGlPerformance::benchSoftwareFallbackRgb16):
(tst_WebGlPerformance::benchSoftwareFallbackRgb32):
(tst_WebGlPerformance::benchSoftwareFallbackArgb32):
(tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
(tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
* tests/benchmarks/webgl/tst_webgl.qrc: Added.
* tests/benchmarks/webgl/webgl.pro: Added.
* tests/qgraphicswebview/qgraphicswebview.pro:
* tests/qgraphicswebview/resources/pointing_right.html: Added.
* tests/qgraphicswebview/resources/pointing_up.html: Added.
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(compareImagesFuzzyPixelCount):
(GraphicsView::GraphicsView):
(tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
(tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
(tst_QGraphicsWebView::compareCanvasToImage):
* tests/qgraphicswebview/tst_qgraphicswebview.qrc:
* tests/tests.pro:
2011-03-24 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Benjamin Poulain.
Avoided ASCII-cast warnings for WebKit.
Normally they won't be enabled anyway, but if you build webkit from
within the Qt mother repository it will pick up Qt's default build
settings, which do enable it. We need to disable them because
warnings are treated as errors and there are way too many of them in
the WebKit code.
[Qt] Avoid ASCII-cast warnings for WebKit.
https://bugs.webkit.org/show_bug.cgi?id=57016
* QtWebKit.pro:
2011-03-24 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
https://bugs.webkit.org/show_bug.cgi?id=29595
Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
prepending the current directory.
By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
will end up loading "about:blank", but keeping it as a requested URL.
This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
is filled for the loaded URLs as well, we can use it in every case.
Three new autotests were added, to better cover the expected behavior of setting
the QUrl() in a QWebFrame.
* Api/qwebframe.cpp:
(ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
(QWebFrame::requestedUrl): always use m_lastRequestedUrl.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
anymore, since we always rely on it even for loaded frames.
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
the reduction of the bug report.
(tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
(tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.
2011-03-23 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Change IconDatabase opening to allow for arbitrary filenames
https://bugs.webkit.org/show_bug.cgi?id=56977
* Api/qwebsettings.cpp:
(QWebSettings::setIconDatabasePath):
2011-03-23 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Andreas Kling.
[Qt] QtWebKit rendering problem when maximizing and doing a back
https://bugs.webkit.org/show_bug.cgi?id=56669
Added an auto test.
Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::rendering):
2011-03-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
https://bugs.webkit.org/show_bug.cgi?id=56843
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::openInspectorFrontend):
2011-03-22 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by Benjamin Poulain.
[Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
https://bugs.webkit.org/show_bug.cgi?id=54138
* tests/qwebpage/tst_qwebpage.cpp:
(webGLScreenshotWithoutView):
(tst_QWebPage::acceleratedWebGLScreenshotWithoutView):
(tst_QWebPage::unacceleratedWebGLScreenshotWithoutView):
Render a QWebPage (with and without accelerated compositing)
with a WebGL context that has no owning view. Shouldn't crash.
2011-03-21 Chang Shu <cshu@webkit.org>
Reviewed by Alexey Proskuryakov.
REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665
r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.
* Api/qwebpage.cpp:
(QWebPage::setContentEditable):
(QWebPage::isContentEditable):
2011-03-19 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Remove support for Qt 4.6
https://bugs.webkit.org/show_bug.cgi?id=56712
* Api/qwebframe.cpp:
(QWebFrame::load):
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
* Api/qwebsettings.cpp:
(QWebSettings::QWebSettings):
* WebCoreSupport/GeolocationClientQt.cpp:
(WebCore::GeolocationClientQt::positionUpdated):
2011-03-19 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
https://bugs.webkit.org/show_bug.cgi?id=56711
Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
ownership of the reply is transferred to the receiving slot.
* Api/qwebpage.cpp:
2011-03-17 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=56425
More groundwork for WebKit2 IconDatabase
Update already-used function names:
* Api/qwebhistory.cpp:
(QWebHistoryItem::icon):
* Api/qwebsettings.cpp:
(QWebSettings::iconForUrl):
2011-03-18 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] console.log not being exposed to QmlViewer
https://bugs.webkit.org/show_bug.cgi?id=56536
The documentation is bogus the feature does not exist.
* declarative/qdeclarativewebview.cpp:
2011-03-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QML WebView emits iconChanged() when the page title changes
https://bugs.webkit.org/show_bug.cgi?id=56570
* declarative/qdeclarativewebview.cpp:
(QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
signal to the view's iconChanged signal.
2011-03-17 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] Videos look ugly when using QGraphicsWebView.
https://bugs.webkit.org/show_bug.cgi?id=56580
We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
in addition of what could be set on the painter. In order to not break the rendering of all the items in the
scene we set back the painter to its original state when QGraphicsWebView is rendered.
* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
(QGraphicsWebView::paint):
(QGraphicsWebView::renderHints):
(QGraphicsWebView::setRenderHints):
(QGraphicsWebView::setRenderHint):
* Api/qgraphicswebview.h:
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::renderHints):
2011-03-16 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Viewport no longer allows an auto value for "user-scalable"
https://bugs.webkit.org/show_bug.cgi?id=55416
Make the default value for userScalable be true.
* Api/qwebpage.cpp:
(QWebPage::viewportAttributesForSize):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.
2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Darin Adler.
Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
info into the headers rather than in export symbol definition files, but disable it on
all platforms initially so we can deal with port build issues one port at a time.
https://bugs.webkit.org/show_bug.cgi?id=27551
* WebCoreSupport/GeolocationClientQt.cpp:
* WebCoreSupport/PopupMenuQt.cpp:
2011-03-14 Brady Eidson <beidson@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=56320
Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
* Api/qwebhistory.cpp:
(QWebHistoryItem::icon): Use IconDatabase directly.
2011-03-11 Brady Eidson <beidson@apple.com>
Reviewed by attempt at build fix!
https://bugs.webkit.org/show_bug.cgi?id=56216
Fix the Qt build following the same pattern of the patch.
* Api/qwebsettings.cpp:
(QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
2011-03-11 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Ariya Hidayat.
[Qt] Entering fullscreen and leaving it may hide the cursor of the application.
https://bugs.webkit.org/show_bug.cgi?id=56181
We need to stop the auto hide cursor timer when closing the widget otherwise the timer
might get fired and therefore hide the cursor even when the fullscreen widget is closed.
* WebCoreSupport/FullScreenVideoWidget.cpp:
(WebCore::FullScreenVideoWidget::closeEvent):
2011-03-10 David Boddie <david.boddie@nokia.com>
Reviewed by Andreas Kling.
Fixed a qdoc warning and terminology (WebKit instead of Webkit).
https://bugs.webkit.org/show_bug.cgi?id=55756
* Api/qwebhistoryinterface.cpp:
2011-03-10 Andreas Kling <kling@webkit.org>
Unreviewed build fix after r80774.
QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451
* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):
* declarative/qdeclarativewebview.cpp:
* declarative/qdeclarativewebview_p.h:
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
2011-03-10 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QtDeclarative Webview element has a fixed white background
https://bugs.webkit.org/show_bug.cgi?id=40918
Implement a way to change the background color of the WebView QML element.
This feature is activated for QtWebKit 1.1 version of the plugin.
* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):
* declarative/qdeclarativewebview.cpp:
(QDeclarativeWebView::backgroundColor):
(QDeclarativeWebView::setBackgroundColor):
* declarative/qdeclarativewebview_p.h:
* tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::backgroundColor):
* tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
2011-03-10 Stanislav Paltis <Stanislav.Paltis@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
https://bugs.webkit.org/show_bug.cgi?id=55945
Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to
set interval used to trigger when decoded data in dead list of object cache will
be purged from object cache.
* Api/qwebpage.cpp:
(QWebPagePrivate::dynamicPropertyChangeEvent):
2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Antonio Gomes.
Simplify how QWebFrame::requestedUrl() is obtained
https://bugs.webkit.org/show_bug.cgi?id=55842
When a load starts, store the requested URL until we know that it'll be
available for us in the document loader -- after load finished.
The existing auto tests cover the three different code paths in
requestedUrl() and the new code passes the autotests. In each of those
cases, we looked for the information in a different place, but in all
of them, dispatchDidStartProvisionalLoad was called.
This simplification will be useful to fix bug 32723. The way requestedUrl()
is implementent, we can't use it as a fallback for url() when the setUrl()
was called with an invalid URL.
* Api/qwebframe.cpp:
(QWebFrame::requestedUrl):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
* WebCoreSupport/FrameLoaderClientQt.h:
(WebCore::FrameLoaderClientQt::lastRequestedUrl):
2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Kenneth Rohde Christiansen.
Tiled backing store's delegated scroll request uses incorrect convention
https://bugs.webkit.org/show_bug.cgi?id=56011
Adapt internal API to match the change from delta to point on the
WebCore side, and convert the point to a delta for the public API.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::delegatedScrollRequested):
* WebCoreSupport/ChromeClientQt.h:
2011-03-09 Peter Kasting <pkasting@google.com>
Reviewed by Mihai Parparita.
Unify Windows version checks.
https://bugs.webkit.org/show_bug.cgi?id=55979
* Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):
2011-03-07 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
https://bugs.webkit.org/show_bug.cgi?id=55827
Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
* WebCoreSupport/FrameLoaderClientQt.h:
2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636
Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
* Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):
2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[QT] Implement mock client-based geolocation for layout testing
https://bugs.webkit.org/show_bug.cgi?id=54334
Implement layout testing for Client-Based geolocation. If drt_run is set
then create mock geolocationClient and update the same with controller.
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::mockGeolocationReset):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/GeolocationClientQt.cpp:
(WebCore::GeolocationClientQt::GeolocationClientQt):
* WebCoreSupport/GeolocationClientQt.h:
2011-03-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QWebFrame::setUrl works only from second time if url fragment is present
https://bugs.webkit.org/show_bug.cgi?id=32723
Create an auto-test for Qt based on the bug description.
* tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
2011-03-03 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=55721
Global IconDatabase should be returned by reference, not as a pointer
* Api/qwebsettings.cpp:
(QWebSettings::setIconDatabasePath):
(QWebSettings::iconDatabasePath):
(QWebSettings::clearIconDatabase):
(QWebSettings::iconForUrl):
2011-03-03 Alexey Proskuryakov <ap@apple.com>
Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
via ChromeClient.h
* WebCoreSupport/ChromeClientQt.h:
2011-03-02 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
https://bugs.webkit.org/show_bug.cgi?id=55633
<rdar://problem/8963023>
* WebCoreSupport/ChromeClientQt.cpp (WebCore::ChromeClientQt::keyboardUIMode):
* WebCoreSupport/ChromeClientQt.h:
Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
this platform doesn't observe or have full keyboard access state.
2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
https://bugs.webkit.org/show_bug.cgi?id=55568
We should use updateMicroFocus() from QGraphicsItem rather than the implementation
in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
in QGraphicsItem.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::setPage):
* Api/qgraphicswebview.h:
2011-03-03 Peter Kasting <pkasting@google.com>
Reviewed by James Robinson.
Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567
* Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):
2011-03-01 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>
Add stubs for CookiesStrategy on Qt WebKit1.
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createCookiesStrategy):
(WebPlatformStrategies::notifyCookiesChanged):
* WebCoreSupport/WebPlatformStrategies.h:
2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
* Api/qwebpage.cpp:
(QWebPage::viewportAttributesForSize):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText):
2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707
* Api/qwebpage.cpp:
(QWebPage::viewportAttributesForSize): pass a Document into computeViewportAttributes for warnings to be reported to.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText): pass a Document into computeViewportAttributes for warnings to be reported to.
2011-03-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Clean up the project files and move common options to WebKit.pri.
* QtWebKit.pro: Move common options to WebKit.pri.
2011-03-01 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Simon Hausmann.
[Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
https://bugs.webkit.org/show_bug.cgi?id=55319
The test case required internet connection to be able to connect to
google.com. Added new html file which refers to local html file.
* tests/qwebpage/resources/content.html: Added.
* tests/qwebpage/resources/frame_c.html: Added.
* tests/qwebpage/resources/framedindex.html: Added.
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::backActionUpdate):
* tests/qwebpage/tst_qwebpage.qrc:
2011-02-25 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Bridge.h should not include BridgeJSC.h
https://bugs.webkit.org/show_bug.cgi?id=55212
Include BridgeJSC.h directly instead.
* Api/qwebframe.cpp:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
(QWebPage::setContentEditable):
(QWebPage::isContentEditable):
* Api/qwebpage_p.h:
* WebCoreSupport/EditorClientQt.cpp:
* WebCoreSupport/EditorClientQt.h:
2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Oliver Hunt.
Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
* Api/qwebelement.cpp:
(QWebElement::evaluateJavaScript):
2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt]tst_QDeclarativeWebView - 8 test cases fail
https://bugs.webkit.org/show_bug.cgi?id=55214
Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
I also refactored the tests so we don't use the network but instead a local html file.
QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.
* tests/qdeclarativewebview/resources/sample.html: Added.
* tests/qdeclarativewebview/resources/webviewtest.qml:
* tests/qdeclarativewebview/resources/webviewtestdefault.qml:
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::preferredWidthTest):
(tst_QDeclarativeWebView::preferredHeightTest):
(tst_QDeclarativeWebView::preferredWidthDefaultTest):
(tst_QDeclarativeWebView::preferredHeightDefaultTest):
* tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
2011-02-28 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Andreas Kling.
[Qt] Add clipped version of QWebElement::render method.
Allows faster rendering of web element part.
https://bugs.webkit.org/show_bug.cgi?id=50311
* Api/qwebelement.cpp:
(QWebElement::render):
* Api/qwebelement.h:
* tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::render):
2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Andreas Kling.
Added full webkit module profile and a syncqt profile.
This is for modularized Qt.
[Qt] WebKit patches required to work with a modularized version of Qt
https://bugs.webkit.org/show_bug.cgi?id=53916
* qt_webkit_version.pri:
2011-02-27 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Antonio Gomes.
[Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
https://bugs.webkit.org/show_bug.cgi?id=53917
Adding test case to check the scenario to avoid regressions in the
future.
* tests/qwebframe/tst_qwebframe.cpp:
2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
https://bugs.webkit.org/show_bug.cgi?id=55322
Documentation update, add a reference to the QtWebKit bridge page.
* Api/qwebframe.cpp:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to DumpRenderTreeSupportQT.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::clearOpener):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Make it possible to test the targetdensity-dpi support
https://bugs.webkit.org/show_bug.cgi?id=55142
Test the viewport meta tag feature targetdensity-dpi by
adding extra arguments to dumpConfigurationForViewport
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295
"broke Chromium builds" (Requested by rniwa on #webkit).
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to DumpRenderTreeSupportQT.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::clearOpener):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-25 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Make the WebKit2 build system less confusing for non-Qt developers
https://bugs.webkit.org/show_bug.cgi?id=55213
* QtWebKit.pro: Move the WebKit2 API into a project include file
in the WebKit2 directory and include the pri file here.
2011-02-25 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed build fix for Intel ICC and MSVC.
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::setPalette):
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::setPalette):
2011-02-25 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=31742
Discovered while looking at 31742. When we set a palette on the
QGraphicsWebView we need to propagate it to the page like QWebView.
I have added the same tests as QWebView to be sure to catch potential
regressions as well as two extras QVERIFY to check the palette propagation.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::event):
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::setPalette_data):
(tst_QGraphicsWebView::setPalette):
2011-02-25 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed buildfix after r79672.
[Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.
* tests/tests.pri:
* tests/tests.pro:
2011-02-25 Gopal Raghavan <gopal.1.raghavan@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QML WebView inside a Flickable shows checkers pattern at startup
https://bugs.webkit.org/show_bug.cgi?id=50222.
This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.
* declarative/qdeclarativewebview.cpp:
(QDeclarativeWebView::init):
* tests/qdeclarativewebview: Added.
* tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
* tests/qdeclarativewebview/resources: Added.
* tests/qdeclarativewebview/resources/webviewtest.qml: Added.
* tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added.
(tst_QDeclarativeWebView::initTestCase):
(tst_QDeclarativeWebView::cleanupTestCase):
(tst_QDeclarativeWebView::init):
(tst_QDeclarativeWebView::cleanup):
(tst_QDeclarativeWebView::preferredWidthTest):
(tst_QDeclarativeWebView::preferredHeightTest):
(tst_QDeclarativeWebView::preferredWidthDefaultTest):
(tst_QDeclarativeWebView::preferredHeightDefaultTest):
(tst_QDeclarativeWebView::checkNoErrors):
* tests/tests.pri:
* tests/tests.pro:
2011-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Andreas Kling.
[Qt] Revert the support for QNAM affined to a different thread.
https://bugs.webkit.org/show_bug.cgi?id=55149
Qt 4.8 will have QNAM use its own thread internally by default,
no need to keep this complexity in WebKit.
This mainly reverts:
http://trac.webkit.org/changeset/73710
http://trac.webkit.org/changeset/73712
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::download):
* tests/qwebpage/tst_qwebpage.cpp:
2011-02-24 Sam Weinig <sam@webkit.org>
Try to fix the Qt build.
* QtWebKit.pro:
2011-02-24 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
Drop the "U; " encryption level from the User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54566
* Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):
2011-02-24 Andrew Wilson <atwilson@chromium.org>
Unreviewed, rolling out r79570.
http://trac.webkit.org/changeset/79570
https://bugs.webkit.org/show_bug.cgi?id=54874
Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Alexey Proskuryakov.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to DumpRenderTreeSupportQT.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::clearOpener):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-24 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebView::setPalette(activeFG) fails
https://bugs.webkit.org/show_bug.cgi?id=55029
This time it should be the proper fix. The window needs to be shown before we
call activateWindow() otherwise there is no active windows for the application.
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::setPalette):
2011-02-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] MinGW build fails to link
https://bugs.webkit.org/show_bug.cgi?id=55050
Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries
* QtWebKit.pro: prepend libraries in the correct order
2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Ariya Hidayat.
[Qt] tst_QWebView::setPalette(activeFG) fails
https://bugs.webkit.org/show_bug.cgi?id=55029
Attempt to make the test more robust. By investigating with the bot virtual machine
I discovered that the activation can take some time. In this patch we make sure that
the active window we want to have is the same as the QApplication.
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::setPalette):
2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Dan Bernstein.
[Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
http://trac.webkit.org/changeset/79167 refactored the way the bound size of
the frame is handled. A new API setBoundsSize was added, we need to call it
in addition to setFrameRect. I could call setBoundSize after setFrameRect but
I thought It would be more elegant to use the resize method.
* Api/qwebpage.cpp:
(QWebPage::setViewportSize):
2011-02-22 Fabrizio Machado <fabrizio.machado@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
https://bugs.webkit.org/show_bug.cgi?id=54976
Test not needed.
* WebCoreSupport/InspectorClientQt.cpp:
2011-02-22 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QWebView ignores a palette set with QWebView::setPalette()
https://bugs.webkit.org/show_bug.cgi?id=31742
Test case to check that the palette sets on the QWebView is taken
into account.
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::setPalette_data):
(tst_QWebView::setPalette):
2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Alexey Proskuryakov.
Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560
* Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):
* tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange
test.
2011-02-22 Chang Shu <cshu@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] editing/deleting/5408255.html fails
https://bugs.webkit.org/show_bug.cgi?id=54964
Move WebCore resource file to QtWebKit since they are referred in WebKit.
* QtWebKit.pro:
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Move inspector's resource files into the final build step to fix the layout test regression.
* QtWebKit.pro: Add inspector's reaource files.
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
Rubber-stamped by Csaba Osztrogonác.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
The patch landed in r79320 didn't contain the cleanup
which was already addressed in the last attachment.
* QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
* QtWebKit.pro: Added.
Project file for the final build step.
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
Replaced the call to node() by a call to containerNode() because the returned node is
used to determine whether or not the selected contents are editable and such a check
must be done against the container node.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleKeyboardEvent):
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Add a FrameLoaderClient callback for whether to stop loading before goToItem.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
* WebCoreSupport/FrameLoaderClientQt.h:
2011-02-18 Fabrizio Machado <fabrizio.machado@nokia.com>
Reviewed by Eric Seidel.
Remove reduntant checks.
https://bugs.webkit.org/show_bug.cgi?id=54764
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::toPage):
2011-02-18 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed.
[Qt] Buildfix for platforms with geolocation disabled.
* Api/qwebpage.cpp: Add the missing guard.
2011-02-18 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement client based geolocation for qtport
https://bugs.webkit.org/show_bug.cgi?id=42629
Implements client based geolocation for qtwebkit.
New client based geolocation contains permission API's as well,
so removed the implementation from ChromeClientQt.cpp.
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
* WebCoreSupport/ChromeClientQt.cpp:
* WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
(WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
* WebCoreSupport/GeolocationClientQt.cpp: Added.
(WebCore::GeolocationClientQt::GeolocationClientQt):
(WebCore::GeolocationClientQt::~GeolocationClientQt):
(WebCore::GeolocationClientQt::geolocationDestroyed):
(WebCore::GeolocationClientQt::positionUpdated):
(WebCore::GeolocationClientQt::startUpdating):
(WebCore::GeolocationClientQt::stopUpdating):
(WebCore::GeolocationClientQt::setEnableHighAccuracy):
(WebCore::GeolocationClientQt::requestPermission):
(WebCore::GeolocationClientQt::cancelPermissionRequest):
* WebCoreSupport/GeolocationClientQt.h: Added.
(WebCore::GeolocationClientQt::lastPosition):
2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Adam Roben.
HTML5 <details> and <summary>: localized text
https://bugs.webkit.org/show_bug.cgi?id=54260
The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
provide the default label to be used by a <details> tag that has no <summary> child.
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::defaultDetailsSummaryText):
* WebCoreSupport/WebPlatformStrategies.h:
2011-02-17 Hui Huang <hui.2.huang@nokia.com>
Reviewed by Laszlo Gombos.
The URL of HTML5 Video Element is percent encoded at websites such as youtube.
It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
the HTTP GET request for the video to be rejected by the service provider.
https://bugs.webkit.org/show_bug.cgi?id=53973.
The bug is fixed by constructing QUrl from the encoded URL in
MediaPlayerPrivateQt::commitLoad.
New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with
HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId
is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt.
A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test
is skipped if Qt Multimedia is not available.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::mediaContentUrlByElementId):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::loadHtml5Video):
* tests/tests.pri:
2011-02-17 Andreas Kling <kling@webkit.org>
Reviewed by Antti Koivisto.
[Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
https://bugs.webkit.org/show_bug.cgi?id=49216
* tests/qwebframe/tst_qwebframe.cpp:
== Rolled over to ChangeLog-2011-02-16 ==
|
