1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2887
2888
2889
2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906
2907
2908
2909
2910
2911
2912
2913
2914
2915
2916
2917
2918
2919
2920
2921
2922
2923
2924
2925
2926
2927
2928
2929
2930
2931
2932
2933
2934
2935
2936
2937
2938
2939
2940
2941
2942
2943
2944
2945
2946
2947
2948
2949
2950
2951
2952
2953
2954
2955
2956
2957
2958
2959
2960
2961
2962
2963
2964
2965
2966
2967
2968
2969
2970
2971
2972
2973
2974
2975
2976
2977
2978
2979
2980
2981
2982
2983
2984
2985
2986
2987
2988
2989
2990
2991
2992
2993
2994
2995
2996
2997
2998
2999
3000
3001
3002
3003
3004
3005
3006
3007
3008
3009
3010
3011
3012
3013
3014
3015
3016
3017
3018
3019
3020
3021
3022
3023
3024
3025
3026
3027
3028
3029
3030
3031
3032
3033
3034
3035
3036
3037
3038
3039
3040
3041
3042
3043
3044
3045
3046
3047
3048
3049
3050
3051
3052
3053
3054
3055
3056
3057
3058
3059
3060
3061
3062
3063
3064
3065
3066
3067
3068
3069
3070
3071
3072
3073
3074
3075
3076
3077
3078
3079
3080
3081
3082
3083
3084
3085
3086
3087
3088
3089
3090
3091
3092
3093
3094
3095
3096
3097
3098
3099
3100
3101
3102
3103
3104
3105
3106
3107
3108
3109
3110
3111
3112
3113
3114
3115
3116
3117
3118
3119
3120
3121
3122
3123
3124
3125
3126
3127
3128
3129
3130
3131
3132
3133
3134
3135
3136
3137
3138
3139
3140
3141
3142
3143
3144
3145
3146
3147
3148
3149
3150
3151
3152
3153
3154
3155
3156
3157
3158
3159
3160
3161
3162
3163
3164
3165
3166
3167
3168
3169
3170
3171
3172
3173
3174
3175
3176
3177
3178
3179
3180
3181
3182
3183
3184
3185
3186
3187
3188
3189
3190
3191
3192
3193
3194
3195
3196
3197
3198
3199
3200
3201
3202
3203
3204
3205
3206
3207
3208
3209
3210
3211
3212
3213
3214
3215
3216
3217
3218
3219
3220
3221
3222
3223
3224
3225
3226
3227
3228
3229
3230
3231
3232
3233
3234
3235
3236
3237
3238
3239
3240
3241
3242
3243
3244
3245
3246
3247
3248
3249
3250
3251
3252
3253
3254
3255
3256
3257
3258
3259
3260
3261
3262
3263
3264
3265
3266
3267
3268
3269
3270
3271
3272
3273
3274
3275
3276
3277
3278
3279
3280
3281
3282
3283
3284
3285
3286
3287
3288
3289
3290
3291
3292
3293
3294
3295
3296
3297
3298
3299
3300
3301
3302
3303
3304
3305
3306
3307
3308
3309
3310
3311
3312
3313
3314
3315
3316
3317
3318
3319
3320
3321
3322
3323
3324
3325
3326
3327
3328
3329
3330
3331
3332
3333
3334
3335
3336
3337
3338
3339
3340
3341
3342
3343
3344
3345
3346
3347
3348
3349
3350
3351
3352
3353
3354
3355
3356
3357
3358
3359
3360
3361
3362
3363
3364
3365
3366
3367
3368
3369
3370
3371
3372
3373
3374
3375
3376
3377
3378
3379
3380
3381
3382
3383
3384
3385
3386
3387
3388
3389
3390
3391
3392
3393
3394
3395
3396
3397
3398
3399
3400
3401
3402
3403
3404
3405
3406
3407
3408
3409
3410
3411
3412
3413
3414
3415
3416
3417
3418
3419
3420
3421
3422
3423
3424
3425
3426
3427
3428
3429
3430
3431
3432
3433
3434
3435
3436
3437
3438
3439
3440
3441
3442
3443
3444
3445
3446
3447
3448
3449
3450
3451
3452
3453
3454
3455
3456
3457
3458
3459
3460
3461
3462
3463
3464
3465
3466
3467
3468
3469
3470
3471
3472
3473
3474
3475
3476
3477
3478
3479
3480
3481
3482
3483
3484
3485
3486
3487
3488
3489
3490
3491
3492
3493
3494
3495
3496
3497
3498
3499
3500
3501
3502
3503
3504
3505
3506
3507
3508
3509
3510
3511
3512
3513
3514
3515
3516
3517
3518
3519
3520
3521
3522
3523
3524
3525
3526
3527
3528
3529
3530
3531
3532
3533
3534
3535
3536
3537
3538
3539
3540
3541
3542
3543
3544
3545
3546
3547
3548
3549
3550
3551
3552
3553
3554
3555
3556
3557
3558
3559
3560
3561
3562
3563
3564
3565
3566
3567
3568
3569
3570
3571
3572
3573
3574
3575
3576
3577
3578
3579
3580
3581
3582
3583
3584
3585
3586
3587
3588
3589
3590
3591
3592
3593
3594
3595
3596
3597
3598
3599
3600
3601
3602
3603
3604
3605
3606
3607
3608
3609
3610
3611
3612
3613
3614
3615
3616
3617
3618
3619
3620
3621
3622
3623
3624
3625
3626
3627
3628
3629
3630
3631
3632
3633
3634
3635
3636
3637
3638
3639
3640
3641
3642
3643
3644
3645
3646
3647
3648
3649
3650
3651
3652
3653
3654
3655
3656
3657
3658
3659
3660
3661
3662
3663
3664
3665
3666
3667
3668
3669
3670
3671
3672
3673
3674
3675
3676
3677
3678
3679
3680
3681
3682
3683
3684
3685
3686
3687
3688
3689
3690
3691
3692
3693
3694
3695
3696
3697
3698
3699
3700
3701
3702
3703
3704
3705
3706
3707
3708
3709
3710
3711
3712
3713
3714
3715
3716
3717
3718
3719
3720
3721
3722
3723
3724
3725
3726
3727
3728
3729
3730
3731
3732
3733
3734
3735
3736
3737
3738
3739
3740
3741
3742
3743
3744
3745
3746
3747
3748
3749
3750
3751
3752
3753
3754
3755
3756
3757
3758
3759
3760
3761
3762
3763
3764
3765
3766
3767
3768
3769
3770
3771
3772
3773
3774
3775
3776
3777
3778
3779
3780
3781
3782
3783
3784
3785
3786
3787
3788
3789
3790
3791
3792
3793
3794
3795
3796
3797
3798
3799
3800
3801
3802
3803
3804
3805
3806
3807
3808
3809
3810
3811
3812
3813
3814
3815
3816
3817
3818
3819
3820
3821
3822
3823
3824
3825
3826
3827
3828
3829
3830
3831
3832
3833
3834
3835
3836
3837
3838
3839
3840
3841
3842
3843
3844
3845
3846
3847
3848
3849
3850
3851
3852
3853
3854
3855
3856
3857
3858
3859
3860
3861
3862
3863
3864
3865
3866
3867
3868
3869
3870
3871
3872
3873
3874
3875
3876
3877
3878
3879
3880
3881
3882
3883
3884
3885
3886
3887
3888
3889
3890
3891
3892
3893
3894
3895
3896
3897
3898
3899
3900
3901
3902
3903
3904
3905
3906
3907
3908
3909
3910
3911
3912
3913
3914
3915
3916
3917
3918
3919
3920
3921
3922
3923
3924
3925
3926
3927
3928
3929
3930
3931
3932
3933
3934
3935
3936
3937
3938
3939
3940
3941
3942
3943
3944
3945
3946
3947
3948
3949
3950
3951
3952
3953
3954
3955
3956
3957
3958
3959
3960
3961
3962
3963
3964
3965
3966
3967
3968
3969
3970
3971
3972
3973
3974
3975
3976
3977
3978
3979
3980
3981
3982
3983
3984
3985
3986
3987
3988
3989
3990
3991
3992
3993
3994
3995
3996
3997
3998
3999
4000
4001
4002
4003
4004
4005
4006
4007
4008
4009
4010
4011
4012
4013
4014
4015
4016
4017
4018
4019
4020
4021
4022
4023
4024
4025
4026
4027
4028
4029
4030
4031
4032
4033
4034
4035
4036
4037
4038
4039
4040
4041
4042
4043
4044
4045
4046
4047
4048
4049
4050
4051
4052
4053
4054
4055
4056
4057
4058
4059
4060
4061
4062
4063
4064
4065
4066
4067
4068
4069
4070
4071
4072
4073
4074
4075
4076
4077
4078
4079
4080
4081
4082
4083
4084
4085
4086
4087
4088
4089
4090
4091
4092
4093
4094
4095
4096
4097
4098
4099
4100
4101
4102
4103
4104
4105
4106
4107
4108
4109
4110
4111
4112
4113
4114
4115
4116
4117
4118
4119
4120
4121
4122
4123
4124
4125
4126
4127
4128
4129
4130
4131
4132
4133
4134
4135
4136
4137
4138
4139
4140
4141
4142
4143
4144
4145
4146
4147
4148
4149
4150
4151
4152
4153
4154
4155
4156
4157
4158
4159
4160
4161
4162
4163
4164
4165
4166
4167
4168
4169
4170
4171
4172
4173
4174
4175
4176
4177
4178
4179
4180
4181
4182
4183
4184
4185
4186
4187
4188
4189
4190
4191
4192
4193
4194
4195
4196
4197
4198
4199
4200
4201
4202
4203
4204
4205
4206
4207
4208
4209
4210
4211
4212
4213
4214
4215
4216
4217
4218
4219
4220
4221
4222
4223
4224
4225
4226
4227
4228
4229
4230
4231
4232
4233
4234
4235
4236
4237
4238
4239
4240
4241
4242
4243
4244
4245
4246
4247
4248
4249
4250
4251
4252
4253
4254
4255
4256
4257
4258
4259
4260
4261
4262
4263
4264
4265
4266
4267
4268
4269
4270
4271
4272
4273
4274
4275
4276
4277
4278
4279
4280
4281
4282
4283
4284
4285
4286
4287
4288
4289
4290
4291
4292
4293
4294
4295
4296
4297
4298
4299
4300
4301
4302
4303
4304
4305
4306
4307
4308
4309
4310
4311
4312
4313
4314
4315
4316
4317
4318
4319
4320
4321
4322
4323
4324
4325
4326
4327
4328
4329
4330
4331
4332
4333
4334
4335
4336
4337
4338
4339
4340
4341
4342
4343
4344
4345
4346
4347
4348
4349
4350
4351
4352
4353
4354
4355
4356
4357
4358
4359
4360
4361
4362
4363
4364
4365
4366
4367
4368
4369
4370
4371
4372
4373
4374
4375
4376
4377
4378
4379
4380
4381
4382
4383
4384
4385
4386
4387
4388
4389
4390
4391
4392
4393
4394
4395
4396
4397
4398
4399
4400
4401
4402
4403
4404
4405
4406
4407
4408
4409
4410
4411
4412
4413
4414
4415
4416
4417
4418
4419
4420
4421
4422
4423
4424
4425
4426
4427
4428
4429
4430
4431
4432
4433
4434
4435
4436
4437
4438
4439
4440
4441
4442
4443
4444
4445
4446
4447
4448
4449
4450
4451
4452
4453
4454
4455
4456
4457
4458
4459
4460
4461
4462
4463
4464
4465
4466
4467
4468
4469
4470
4471
4472
4473
4474
4475
4476
4477
4478
4479
4480
4481
4482
4483
4484
4485
4486
4487
4488
4489
4490
4491
4492
4493
4494
4495
4496
4497
4498
4499
4500
4501
4502
4503
4504
4505
4506
4507
4508
4509
4510
4511
4512
4513
4514
4515
4516
4517
4518
4519
4520
4521
4522
4523
4524
4525
4526
4527
4528
4529
4530
4531
4532
4533
4534
4535
4536
4537
4538
4539
4540
4541
4542
4543
4544
4545
4546
4547
4548
4549
4550
4551
4552
4553
4554
4555
4556
4557
4558
4559
4560
4561
4562
4563
4564
4565
4566
4567
4568
4569
4570
4571
4572
4573
4574
4575
4576
4577
4578
4579
4580
4581
4582
4583
4584
4585
4586
4587
4588
4589
4590
4591
4592
4593
4594
4595
4596
4597
4598
4599
4600
4601
4602
4603
4604
4605
4606
4607
4608
4609
4610
4611
4612
4613
4614
4615
4616
4617
4618
4619
4620
4621
4622
4623
4624
4625
4626
4627
4628
4629
4630
4631
4632
4633
4634
4635
4636
4637
4638
4639
4640
4641
4642
4643
4644
4645
4646
4647
4648
4649
4650
4651
4652
4653
4654
4655
4656
4657
4658
4659
4660
4661
4662
4663
4664
4665
4666
4667
4668
4669
4670
4671
4672
4673
4674
4675
4676
4677
4678
4679
4680
4681
4682
4683
4684
4685
4686
4687
4688
4689
4690
4691
4692
4693
4694
4695
4696
4697
4698
4699
4700
4701
4702
4703
4704
4705
4706
4707
4708
4709
4710
4711
4712
4713
4714
4715
4716
4717
4718
4719
4720
4721
4722
4723
4724
4725
4726
4727
4728
4729
4730
4731
4732
4733
4734
4735
4736
4737
4738
4739
4740
4741
4742
4743
4744
4745
4746
4747
4748
4749
4750
4751
4752
4753
4754
4755
4756
4757
4758
4759
4760
4761
4762
4763
4764
4765
4766
4767
4768
4769
4770
4771
4772
4773
4774
4775
4776
4777
4778
4779
4780
4781
4782
4783
4784
4785
4786
4787
4788
4789
4790
4791
4792
4793
4794
4795
4796
4797
4798
4799
4800
4801
4802
4803
4804
4805
4806
4807
4808
4809
4810
4811
4812
4813
4814
4815
4816
4817
4818
4819
4820
4821
4822
4823
4824
4825
4826
4827
4828
4829
4830
4831
4832
4833
4834
4835
4836
4837
4838
4839
4840
4841
4842
4843
4844
4845
4846
4847
4848
4849
4850
4851
4852
4853
4854
4855
4856
4857
4858
4859
4860
4861
4862
4863
4864
4865
4866
4867
4868
4869
4870
4871
4872
4873
4874
4875
4876
4877
4878
4879
4880
4881
4882
4883
4884
4885
4886
4887
4888
4889
4890
4891
4892
4893
4894
4895
4896
4897
4898
4899
4900
4901
4902
4903
4904
4905
4906
4907
4908
4909
4910
4911
4912
4913
4914
4915
4916
4917
4918
4919
4920
4921
4922
4923
4924
4925
4926
4927
4928
4929
4930
4931
4932
4933
4934
4935
4936
4937
4938
4939
4940
4941
4942
4943
4944
4945
4946
4947
4948
4949
4950
4951
4952
4953
4954
4955
4956
4957
4958
4959
4960
4961
4962
4963
4964
4965
4966
4967
4968
4969
4970
4971
4972
4973
4974
4975
4976
4977
4978
4979
4980
4981
4982
4983
4984
4985
4986
4987
4988
4989
4990
4991
4992
4993
4994
4995
4996
4997
4998
4999
5000
5001
5002
5003
5004
5005
5006
5007
5008
5009
5010
5011
5012
5013
5014
5015
5016
5017
5018
5019
5020
5021
5022
5023
5024
5025
5026
5027
5028
5029
5030
5031
5032
5033
5034
5035
5036
5037
5038
5039
5040
5041
5042
5043
5044
5045
5046
5047
5048
5049
5050
5051
5052
5053
5054
5055
5056
5057
5058
5059
5060
5061
5062
5063
5064
5065
5066
5067
5068
5069
5070
5071
5072
5073
5074
5075
5076
5077
5078
5079
5080
5081
5082
5083
5084
5085
5086
5087
5088
5089
5090
5091
5092
5093
5094
5095
5096
5097
5098
5099
5100
5101
5102
5103
5104
5105
5106
5107
5108
5109
5110
5111
5112
5113
5114
5115
5116
5117
5118
5119
5120
5121
5122
5123
5124
5125
5126
5127
5128
5129
5130
5131
5132
5133
5134
5135
5136
5137
5138
5139
5140
5141
5142
5143
5144
5145
5146
5147
5148
5149
5150
5151
5152
5153
5154
5155
5156
5157
5158
5159
5160
5161
5162
5163
5164
5165
5166
5167
5168
5169
5170
5171
5172
5173
5174
5175
5176
5177
5178
5179
5180
5181
5182
5183
5184
5185
5186
5187
5188
5189
5190
5191
5192
5193
5194
5195
5196
5197
5198
5199
5200
5201
5202
5203
5204
5205
5206
5207
5208
5209
5210
5211
5212
5213
5214
5215
5216
5217
5218
5219
5220
5221
5222
5223
5224
5225
5226
5227
5228
5229
5230
5231
5232
5233
5234
5235
5236
5237
5238
5239
5240
5241
5242
5243
5244
5245
5246
5247
5248
5249
5250
5251
5252
5253
5254
5255
5256
5257
5258
5259
5260
5261
5262
5263
5264
5265
5266
5267
5268
5269
5270
5271
5272
5273
5274
5275
5276
5277
5278
5279
5280
5281
5282
5283
5284
5285
5286
5287
5288
5289
5290
5291
5292
5293
5294
5295
5296
5297
5298
5299
5300
5301
5302
5303
5304
5305
5306
5307
5308
5309
5310
5311
5312
5313
5314
5315
5316
5317
5318
5319
5320
5321
5322
5323
5324
5325
5326
5327
5328
5329
5330
5331
5332
5333
5334
5335
5336
5337
5338
5339
5340
5341
5342
5343
5344
5345
5346
5347
5348
5349
5350
5351
5352
5353
5354
5355
5356
5357
5358
5359
5360
5361
5362
5363
5364
5365
5366
5367
5368
5369
5370
5371
5372
5373
5374
5375
5376
5377
5378
5379
5380
5381
5382
5383
5384
5385
5386
5387
5388
5389
5390
5391
5392
5393
5394
5395
5396
5397
5398
5399
5400
5401
5402
5403
5404
5405
5406
5407
5408
5409
5410
5411
5412
5413
5414
5415
5416
5417
5418
5419
5420
5421
5422
5423
5424
5425
5426
5427
5428
5429
5430
5431
5432
5433
5434
5435
5436
5437
5438
5439
5440
5441
5442
5443
5444
5445
5446
5447
5448
5449
5450
5451
5452
5453
5454
5455
5456
5457
5458
5459
5460
5461
5462
5463
5464
5465
5466
5467
5468
5469
5470
5471
5472
5473
5474
5475
5476
5477
5478
5479
5480
5481
5482
5483
5484
5485
5486
5487
5488
5489
5490
5491
5492
5493
5494
5495
5496
5497
5498
5499
5500
5501
5502
5503
5504
5505
5506
5507
5508
5509
5510
5511
5512
5513
5514
5515
5516
5517
5518
5519
5520
5521
5522
5523
5524
5525
5526
5527
5528
5529
5530
5531
5532
5533
5534
5535
5536
5537
5538
5539
5540
5541
5542
5543
5544
5545
5546
5547
5548
5549
5550
5551
5552
5553
5554
5555
5556
5557
5558
5559
5560
5561
5562
5563
5564
5565
5566
5567
5568
5569
5570
5571
5572
5573
5574
5575
5576
5577
5578
5579
5580
5581
5582
5583
5584
5585
5586
5587
5588
5589
5590
5591
5592
5593
5594
5595
5596
5597
5598
5599
5600
5601
5602
5603
5604
5605
5606
5607
5608
5609
5610
5611
5612
5613
5614
5615
5616
5617
5618
5619
5620
5621
5622
5623
5624
5625
5626
5627
5628
5629
5630
5631
5632
5633
5634
5635
5636
5637
5638
5639
5640
5641
5642
5643
5644
5645
5646
5647
5648
5649
5650
5651
5652
5653
5654
5655
5656
5657
5658
5659
5660
5661
5662
5663
5664
5665
5666
5667
5668
5669
5670
5671
5672
5673
5674
5675
5676
5677
5678
5679
5680
5681
5682
5683
5684
5685
5686
5687
5688
5689
5690
5691
5692
5693
5694
5695
5696
5697
5698
5699
5700
5701
5702
5703
5704
5705
5706
5707
5708
5709
5710
5711
5712
5713
5714
5715
5716
5717
5718
5719
5720
5721
5722
5723
5724
5725
5726
5727
5728
5729
5730
5731
5732
5733
5734
5735
5736
5737
5738
5739
5740
5741
5742
5743
5744
5745
5746
5747
5748
5749
5750
5751
5752
5753
5754
5755
5756
5757
5758
5759
5760
5761
5762
5763
5764
5765
5766
5767
5768
5769
5770
5771
5772
5773
5774
5775
5776
5777
5778
5779
5780
5781
5782
5783
5784
5785
5786
5787
5788
5789
5790
5791
5792
5793
5794
5795
5796
5797
5798
5799
5800
5801
5802
5803
5804
5805
5806
5807
5808
5809
5810
5811
5812
5813
5814
5815
5816
5817
5818
5819
5820
5821
5822
5823
5824
5825
5826
5827
5828
5829
5830
5831
5832
5833
5834
5835
5836
5837
5838
5839
5840
5841
5842
5843
5844
5845
5846
5847
5848
5849
5850
5851
5852
5853
5854
5855
5856
5857
5858
5859
5860
5861
5862
5863
5864
5865
5866
5867
5868
5869
5870
5871
5872
5873
5874
5875
5876
5877
5878
5879
5880
5881
5882
5883
5884
5885
5886
5887
5888
5889
5890
5891
5892
5893
5894
5895
5896
5897
5898
5899
5900
5901
5902
5903
5904
5905
5906
5907
5908
5909
5910
5911
5912
5913
5914
5915
5916
5917
5918
5919
5920
5921
5922
5923
5924
5925
5926
5927
5928
5929
5930
5931
5932
5933
5934
5935
5936
5937
5938
5939
5940
5941
5942
5943
5944
5945
5946
5947
5948
5949
5950
5951
5952
5953
5954
5955
5956
5957
5958
5959
5960
5961
5962
5963
5964
5965
5966
5967
5968
5969
5970
5971
5972
5973
5974
5975
5976
5977
5978
5979
5980
5981
5982
5983
5984
5985
5986
5987
5988
5989
5990
5991
5992
5993
5994
5995
5996
5997
5998
5999
6000
6001
6002
6003
6004
6005
6006
6007
6008
6009
6010
6011
6012
6013
6014
6015
6016
6017
6018
6019
6020
6021
6022
6023
6024
6025
6026
6027
6028
6029
6030
6031
6032
6033
6034
6035
6036
6037
6038
6039
6040
6041
6042
6043
6044
6045
6046
6047
6048
6049
6050
6051
6052
6053
6054
6055
6056
6057
6058
6059
6060
6061
6062
6063
6064
6065
6066
6067
6068
6069
6070
6071
6072
6073
6074
6075
6076
6077
6078
6079
6080
6081
6082
6083
6084
6085
6086
6087
6088
6089
6090
6091
6092
6093
6094
6095
6096
6097
6098
6099
6100
6101
6102
6103
6104
6105
6106
6107
6108
6109
6110
6111
6112
6113
6114
6115
6116
6117
6118
6119
6120
6121
6122
6123
6124
6125
6126
6127
6128
6129
6130
6131
6132
6133
6134
6135
6136
6137
6138
6139
6140
6141
6142
6143
6144
6145
6146
6147
6148
6149
6150
6151
6152
6153
6154
6155
6156
6157
6158
6159
6160
6161
6162
6163
6164
6165
6166
6167
6168
6169
6170
6171
6172
6173
6174
6175
6176
6177
6178
6179
6180
6181
6182
6183
6184
6185
6186
6187
6188
6189
6190
6191
6192
6193
6194
6195
6196
6197
6198
6199
6200
6201
6202
6203
6204
6205
6206
6207
6208
6209
6210
6211
6212
6213
6214
6215
6216
6217
6218
6219
6220
6221
6222
6223
6224
6225
6226
6227
6228
6229
6230
6231
6232
6233
6234
6235
6236
6237
6238
6239
6240
6241
6242
6243
6244
6245
6246
6247
6248
6249
6250
6251
6252
6253
6254
6255
6256
6257
6258
6259
6260
6261
6262
6263
6264
6265
6266
6267
6268
6269
6270
6271
6272
6273
6274
6275
6276
6277
6278
6279
6280
6281
6282
6283
6284
6285
6286
6287
6288
6289
6290
6291
6292
6293
6294
6295
6296
6297
6298
6299
6300
6301
6302
6303
6304
6305
6306
6307
6308
6309
6310
6311
6312
6313
6314
6315
6316
6317
6318
6319
6320
6321
6322
6323
6324
6325
6326
6327
6328
6329
6330
6331
6332
6333
6334
6335
6336
6337
6338
6339
6340
6341
6342
6343
6344
6345
6346
6347
6348
6349
6350
6351
6352
6353
6354
6355
6356
6357
6358
6359
6360
6361
6362
6363
6364
6365
6366
6367
6368
6369
6370
6371
6372
6373
6374
6375
6376
6377
6378
6379
6380
6381
6382
6383
6384
6385
6386
6387
6388
6389
6390
6391
6392
6393
6394
6395
6396
6397
6398
6399
6400
6401
6402
6403
6404
6405
6406
6407
6408
6409
6410
6411
6412
6413
6414
6415
6416
6417
6418
6419
6420
6421
6422
6423
6424
6425
6426
6427
6428
6429
6430
6431
6432
6433
6434
6435
6436
6437
6438
6439
6440
6441
6442
6443
6444
6445
6446
6447
6448
6449
6450
6451
6452
6453
6454
6455
6456
6457
6458
6459
6460
6461
6462
6463
6464
6465
6466
6467
6468
6469
6470
6471
6472
6473
6474
6475
6476
6477
6478
6479
6480
6481
6482
6483
6484
6485
6486
6487
6488
6489
6490
6491
6492
6493
6494
6495
6496
6497
6498
6499
6500
6501
6502
6503
6504
6505
6506
6507
6508
6509
6510
6511
6512
6513
6514
6515
6516
6517
6518
6519
6520
6521
6522
6523
6524
6525
6526
6527
6528
6529
6530
6531
6532
6533
6534
6535
6536
6537
6538
6539
6540
6541
6542
6543
6544
6545
6546
6547
6548
6549
6550
6551
6552
6553
6554
6555
6556
6557
6558
6559
6560
6561
6562
6563
6564
6565
6566
6567
6568
6569
6570
6571
6572
6573
6574
6575
6576
6577
6578
6579
6580
6581
6582
6583
6584
6585
6586
6587
6588
6589
6590
6591
6592
6593
6594
6595
6596
6597
6598
6599
6600
6601
6602
6603
6604
6605
6606
6607
6608
6609
6610
6611
6612
6613
6614
6615
6616
6617
6618
6619
6620
6621
6622
6623
6624
6625
6626
6627
6628
6629
6630
6631
6632
6633
6634
6635
6636
6637
6638
6639
6640
6641
6642
6643
6644
6645
6646
6647
6648
6649
6650
6651
6652
6653
6654
6655
6656
6657
6658
6659
6660
6661
6662
6663
6664
6665
6666
6667
6668
6669
6670
6671
6672
6673
6674
6675
6676
6677
6678
6679
6680
6681
6682
6683
6684
6685
6686
6687
6688
6689
6690
6691
6692
6693
6694
6695
6696
6697
6698
6699
6700
6701
6702
6703
6704
6705
6706
6707
6708
6709
6710
6711
6712
6713
6714
6715
6716
6717
6718
6719
6720
6721
6722
6723
6724
6725
6726
6727
6728
6729
6730
6731
6732
6733
6734
6735
6736
6737
6738
6739
6740
6741
6742
6743
6744
6745
6746
6747
6748
6749
6750
6751
6752
6753
6754
6755
6756
6757
6758
6759
6760
6761
6762
6763
6764
6765
6766
6767
6768
6769
6770
6771
6772
6773
6774
6775
6776
6777
6778
6779
6780
6781
6782
6783
6784
6785
6786
6787
6788
6789
6790
6791
6792
6793
6794
6795
6796
6797
6798
6799
6800
6801
6802
6803
6804
6805
6806
6807
6808
6809
6810
6811
6812
6813
6814
6815
6816
6817
6818
6819
6820
6821
6822
6823
6824
6825
6826
6827
6828
6829
6830
6831
6832
6833
6834
6835
6836
6837
6838
6839
6840
6841
6842
6843
6844
6845
6846
6847
6848
6849
6850
6851
6852
6853
6854
6855
6856
6857
6858
6859
6860
6861
6862
6863
6864
6865
6866
6867
6868
6869
6870
6871
6872
6873
6874
6875
6876
6877
6878
6879
6880
6881
6882
6883
6884
6885
6886
6887
6888
6889
6890
6891
6892
6893
6894
6895
6896
6897
6898
6899
6900
6901
6902
6903
6904
6905
6906
6907
6908
6909
6910
6911
6912
6913
6914
6915
6916
6917
6918
6919
6920
6921
6922
6923
6924
6925
6926
6927
6928
6929
6930
6931
6932
6933
6934
6935
6936
6937
6938
6939
6940
6941
6942
6943
6944
6945
6946
6947
6948
6949
6950
6951
6952
6953
6954
6955
6956
6957
6958
6959
6960
6961
6962
6963
6964
6965
6966
6967
6968
6969
6970
6971
6972
6973
6974
6975
6976
6977
6978
6979
6980
6981
6982
6983
6984
6985
6986
6987
6988
6989
6990
6991
6992
6993
6994
6995
6996
6997
6998
6999
7000
7001
7002
7003
7004
7005
7006
7007
7008
7009
7010
7011
7012
7013
7014
7015
7016
7017
7018
7019
7020
7021
7022
7023
7024
7025
7026
7027
7028
7029
7030
7031
7032
7033
7034
7035
7036
7037
7038
7039
7040
7041
7042
7043
7044
7045
7046
7047
7048
7049
7050
7051
7052
7053
7054
7055
7056
7057
7058
7059
7060
7061
7062
7063
7064
7065
7066
7067
7068
7069
7070
7071
7072
7073
7074
7075
7076
7077
7078
7079
7080
7081
7082
7083
7084
7085
7086
7087
7088
7089
7090
7091
7092
7093
7094
7095
7096
7097
7098
7099
7100
7101
7102
7103
7104
7105
7106
7107
7108
7109
7110
7111
7112
7113
7114
7115
7116
7117
7118
7119
7120
7121
7122
7123
7124
7125
7126
7127
7128
7129
7130
7131
7132
7133
7134
7135
7136
7137
7138
7139
7140
7141
7142
7143
7144
7145
7146
7147
7148
7149
7150
7151
7152
7153
7154
7155
7156
7157
7158
7159
7160
7161
7162
7163
7164
7165
7166
7167
7168
7169
7170
7171
7172
7173
7174
7175
7176
7177
7178
7179
7180
7181
7182
7183
7184
7185
7186
7187
7188
7189
7190
7191
7192
7193
7194
7195
7196
7197
7198
7199
7200
7201
7202
7203
7204
7205
7206
7207
7208
7209
7210
7211
7212
7213
7214
7215
7216
7217
7218
7219
7220
7221
7222
7223
7224
7225
7226
7227
7228
7229
7230
7231
7232
7233
7234
7235
7236
7237
7238
7239
7240
7241
7242
7243
7244
7245
7246
7247
7248
7249
7250
7251
7252
7253
7254
7255
7256
7257
7258
7259
7260
7261
7262
7263
7264
7265
7266
7267
7268
7269
7270
7271
7272
7273
7274
7275
7276
7277
7278
7279
7280
7281
7282
7283
7284
7285
7286
7287
7288
7289
7290
7291
7292
7293
7294
7295
7296
7297
7298
7299
7300
7301
7302
7303
7304
7305
7306
7307
7308
7309
7310
7311
7312
7313
7314
7315
7316
7317
7318
7319
7320
7321
7322
7323
7324
7325
7326
7327
7328
7329
7330
7331
7332
7333
7334
7335
7336
7337
7338
7339
7340
7341
7342
7343
7344
7345
7346
7347
7348
7349
7350
7351
7352
7353
7354
7355
7356
7357
7358
7359
7360
7361
7362
7363
7364
7365
7366
7367
7368
7369
7370
7371
7372
7373
7374
7375
7376
7377
7378
7379
7380
7381
7382
7383
7384
7385
7386
7387
7388
7389
7390
7391
7392
7393
7394
7395
7396
7397
7398
7399
7400
7401
7402
7403
7404
7405
7406
7407
7408
7409
7410
7411
7412
7413
7414
7415
7416
7417
7418
7419
7420
7421
7422
7423
7424
7425
7426
7427
7428
7429
7430
7431
7432
7433
7434
7435
7436
7437
7438
7439
7440
7441
7442
7443
7444
7445
7446
7447
7448
7449
7450
7451
7452
7453
7454
7455
7456
7457
7458
7459
7460
7461
7462
7463
7464
7465
7466
7467
7468
7469
7470
7471
7472
7473
7474
7475
7476
7477
7478
7479
7480
7481
7482
7483
7484
7485
7486
7487
7488
7489
7490
7491
7492
7493
7494
7495
7496
7497
7498
7499
7500
7501
7502
7503
7504
7505
7506
7507
7508
7509
7510
7511
7512
7513
7514
7515
7516
7517
7518
7519
7520
7521
7522
7523
7524
7525
7526
7527
7528
7529
7530
7531
7532
7533
7534
7535
7536
7537
7538
7539
7540
7541
7542
7543
7544
7545
7546
7547
7548
7549
7550
7551
7552
7553
7554
7555
7556
7557
7558
7559
7560
7561
7562
7563
7564
7565
7566
7567
7568
7569
7570
7571
7572
7573
7574
7575
7576
7577
7578
7579
7580
7581
7582
7583
7584
7585
7586
7587
7588
7589
7590
7591
7592
7593
7594
7595
7596
7597
7598
7599
7600
7601
7602
7603
7604
7605
7606
7607
7608
7609
7610
7611
7612
7613
7614
7615
7616
7617
7618
7619
7620
7621
7622
7623
7624
7625
7626
7627
7628
7629
7630
7631
7632
7633
7634
7635
7636
7637
7638
7639
7640
7641
7642
7643
7644
7645
7646
7647
7648
7649
7650
7651
7652
7653
7654
7655
7656
7657
7658
7659
7660
7661
7662
7663
7664
7665
7666
7667
7668
7669
7670
7671
7672
7673
7674
7675
7676
7677
7678
7679
7680
7681
7682
7683
7684
7685
7686
7687
7688
7689
7690
7691
7692
7693
7694
7695
7696
7697
7698
7699
7700
7701
7702
7703
7704
7705
7706
7707
7708
7709
7710
7711
7712
7713
7714
7715
7716
7717
7718
7719
7720
7721
7722
7723
7724
7725
7726
7727
7728
7729
7730
7731
7732
7733
7734
7735
7736
7737
7738
7739
7740
7741
7742
7743
7744
7745
7746
7747
7748
7749
7750
7751
7752
7753
7754
7755
7756
7757
7758
7759
7760
7761
7762
7763
7764
7765
7766
7767
7768
7769
7770
7771
7772
7773
7774
7775
7776
7777
7778
7779
7780
7781
7782
7783
7784
7785
7786
7787
7788
7789
7790
7791
7792
7793
7794
7795
7796
7797
7798
7799
7800
7801
7802
7803
7804
7805
7806
7807
7808
7809
7810
7811
7812
7813
7814
7815
7816
7817
7818
7819
7820
7821
7822
7823
7824
7825
7826
7827
7828
7829
7830
7831
7832
7833
7834
7835
7836
7837
7838
7839
7840
7841
7842
7843
7844
7845
7846
7847
7848
7849
7850
7851
7852
7853
7854
7855
7856
7857
7858
7859
7860
7861
7862
7863
7864
7865
7866
7867
7868
7869
7870
7871
7872
7873
7874
7875
7876
7877
7878
7879
7880
7881
7882
7883
7884
7885
7886
7887
7888
7889
7890
7891
7892
7893
7894
7895
7896
7897
7898
7899
7900
7901
7902
7903
7904
7905
7906
7907
7908
7909
7910
7911
7912
7913
7914
7915
7916
7917
7918
7919
7920
7921
7922
7923
7924
7925
7926
7927
7928
7929
7930
7931
7932
7933
7934
7935
7936
7937
7938
7939
7940
7941
7942
7943
7944
7945
7946
7947
7948
7949
7950
7951
7952
7953
7954
7955
7956
7957
7958
7959
7960
7961
7962
7963
7964
7965
7966
7967
7968
7969
7970
7971
7972
7973
7974
7975
7976
7977
7978
7979
7980
7981
7982
7983
7984
7985
7986
7987
7988
7989
7990
7991
7992
7993
7994
7995
7996
7997
7998
7999
8000
8001
8002
8003
8004
8005
8006
8007
8008
8009
8010
8011
8012
8013
8014
8015
8016
8017
8018
8019
8020
8021
8022
8023
8024
8025
8026
8027
8028
8029
8030
8031
8032
8033
8034
8035
8036
8037
8038
8039
8040
8041
8042
8043
8044
8045
8046
8047
8048
8049
8050
8051
8052
8053
8054
8055
8056
8057
8058
8059
8060
8061
8062
8063
8064
8065
8066
8067
8068
8069
8070
8071
8072
8073
8074
8075
8076
8077
8078
8079
8080
8081
8082
8083
8084
8085
8086
8087
8088
8089
8090
8091
8092
8093
8094
8095
8096
8097
8098
8099
8100
8101
8102
8103
8104
8105
8106
8107
8108
8109
8110
8111
8112
8113
8114
8115
8116
8117
8118
8119
8120
8121
8122
8123
8124
8125
8126
8127
8128
8129
8130
8131
8132
8133
8134
8135
8136
8137
8138
8139
8140
8141
8142
8143
8144
8145
8146
8147
8148
8149
8150
8151
8152
8153
8154
8155
8156
8157
8158
8159
8160
8161
8162
8163
8164
8165
8166
8167
8168
8169
8170
8171
8172
8173
8174
8175
8176
8177
8178
8179
8180
8181
8182
8183
8184
8185
8186
8187
8188
8189
8190
8191
8192
8193
8194
8195
8196
8197
8198
8199
8200
8201
8202
8203
8204
8205
8206
8207
8208
8209
8210
8211
8212
8213
8214
8215
8216
8217
8218
8219
8220
8221
8222
8223
8224
8225
8226
8227
8228
8229
8230
8231
8232
8233
8234
8235
8236
8237
8238
8239
8240
8241
8242
8243
8244
8245
8246
8247
8248
8249
8250
8251
8252
8253
8254
8255
8256
8257
8258
8259
8260
8261
8262
8263
8264
8265
8266
8267
8268
8269
8270
8271
8272
8273
8274
8275
8276
8277
8278
8279
8280
8281
8282
8283
8284
8285
8286
8287
8288
8289
8290
8291
8292
8293
8294
8295
8296
8297
8298
8299
8300
8301
8302
8303
8304
8305
8306
8307
8308
8309
8310
8311
8312
8313
8314
8315
8316
8317
8318
8319
8320
8321
8322
8323
8324
8325
8326
8327
8328
8329
8330
8331
8332
8333
8334
8335
8336
8337
8338
8339
8340
8341
8342
8343
8344
8345
8346
8347
8348
8349
8350
8351
8352
8353
8354
8355
8356
8357
8358
8359
8360
8361
8362
8363
8364
8365
8366
8367
8368
8369
8370
8371
8372
8373
8374
8375
8376
8377
8378
8379
8380
8381
8382
8383
8384
8385
8386
8387
8388
8389
8390
8391
8392
8393
8394
8395
8396
8397
8398
8399
8400
8401
8402
8403
8404
8405
8406
8407
8408
8409
8410
8411
8412
8413
8414
8415
8416
8417
8418
8419
8420
8421
8422
8423
8424
8425
8426
8427
8428
8429
8430
8431
8432
8433
8434
8435
8436
8437
8438
8439
8440
8441
8442
8443
8444
8445
8446
8447
8448
8449
8450
8451
8452
8453
8454
8455
8456
8457
8458
8459
8460
8461
8462
8463
8464
8465
8466
8467
8468
8469
8470
8471
8472
8473
8474
8475
8476
8477
8478
8479
8480
8481
8482
8483
8484
8485
8486
8487
8488
8489
8490
8491
8492
8493
8494
8495
8496
8497
8498
8499
8500
8501
8502
8503
8504
8505
8506
8507
8508
8509
8510
8511
8512
8513
8514
8515
8516
8517
8518
8519
8520
8521
8522
8523
8524
8525
8526
8527
8528
8529
8530
8531
8532
8533
8534
8535
8536
8537
8538
8539
8540
8541
8542
8543
8544
8545
8546
8547
8548
8549
8550
8551
8552
8553
8554
8555
8556
8557
8558
8559
8560
8561
8562
8563
8564
8565
8566
8567
8568
8569
8570
8571
8572
8573
8574
8575
8576
8577
8578
8579
8580
8581
8582
8583
8584
8585
8586
8587
8588
8589
8590
8591
8592
8593
8594
8595
8596
8597
8598
8599
8600
8601
8602
8603
8604
8605
8606
8607
8608
8609
8610
8611
8612
8613
8614
8615
8616
8617
8618
8619
8620
8621
8622
8623
8624
8625
8626
8627
8628
8629
8630
8631
8632
8633
8634
8635
8636
8637
8638
8639
8640
8641
8642
8643
8644
8645
8646
8647
8648
8649
8650
8651
8652
8653
8654
8655
8656
8657
8658
8659
8660
8661
8662
8663
8664
8665
8666
8667
8668
8669
8670
8671
8672
8673
8674
8675
8676
8677
8678
8679
8680
8681
8682
8683
8684
8685
8686
8687
8688
8689
8690
8691
8692
8693
8694
8695
8696
8697
8698
8699
8700
8701
8702
8703
8704
8705
8706
8707
8708
8709
8710
8711
8712
8713
8714
8715
8716
8717
8718
8719
8720
8721
8722
8723
8724
8725
8726
8727
8728
8729
8730
8731
8732
8733
8734
8735
8736
8737
8738
8739
8740
8741
8742
8743
8744
8745
8746
8747
8748
8749
8750
8751
8752
8753
8754
8755
8756
8757
8758
8759
8760
8761
8762
8763
8764
8765
8766
8767
8768
8769
8770
8771
8772
8773
8774
8775
8776
8777
8778
8779
8780
8781
8782
8783
8784
8785
8786
8787
8788
8789
8790
8791
8792
8793
8794
8795
8796
8797
8798
8799
8800
8801
8802
8803
8804
8805
8806
8807
8808
8809
8810
8811
8812
8813
8814
8815
8816
8817
8818
8819
8820
8821
8822
8823
8824
8825
8826
8827
8828
8829
8830
8831
8832
8833
8834
8835
8836
8837
8838
8839
8840
8841
8842
8843
8844
8845
8846
8847
8848
8849
8850
8851
8852
8853
8854
8855
8856
8857
8858
8859
8860
8861
8862
8863
8864
8865
8866
8867
8868
8869
8870
8871
8872
8873
8874
8875
8876
8877
8878
8879
8880
8881
8882
8883
8884
8885
8886
8887
8888
8889
8890
8891
8892
8893
8894
8895
8896
8897
8898
8899
8900
8901
8902
8903
8904
8905
8906
8907
8908
8909
8910
8911
8912
8913
8914
8915
8916
8917
8918
8919
8920
8921
8922
8923
8924
8925
8926
8927
8928
8929
8930
8931
8932
8933
8934
8935
8936
8937
8938
8939
8940
8941
8942
8943
8944
8945
8946
8947
8948
8949
8950
8951
8952
8953
8954
8955
8956
8957
8958
8959
8960
8961
8962
8963
8964
8965
8966
8967
8968
8969
8970
8971
8972
8973
8974
8975
8976
8977
8978
8979
8980
8981
8982
8983
8984
8985
8986
8987
8988
8989
8990
8991
8992
8993
8994
8995
8996
8997
8998
8999
9000
9001
9002
9003
9004
9005
9006
9007
9008
9009
9010
9011
9012
9013
9014
9015
9016
9017
9018
9019
9020
9021
9022
9023
9024
9025
9026
9027
9028
9029
9030
9031
9032
9033
9034
9035
9036
9037
9038
9039
9040
9041
9042
9043
9044
9045
9046
9047
9048
9049
9050
9051
9052
9053
9054
9055
9056
9057
9058
9059
9060
9061
9062
9063
9064
9065
9066
9067
9068
9069
9070
9071
9072
9073
9074
9075
9076
9077
9078
9079
9080
9081
9082
9083
9084
9085
9086
9087
9088
9089
9090
9091
9092
9093
9094
9095
9096
9097
9098
9099
9100
9101
9102
9103
9104
9105
9106
9107
9108
9109
9110
9111
9112
9113
9114
9115
9116
9117
9118
9119
9120
9121
9122
9123
9124
9125
9126
9127
9128
9129
9130
9131
9132
9133
9134
9135
9136
9137
9138
9139
9140
9141
9142
9143
9144
9145
9146
9147
9148
9149
9150
9151
9152
9153
9154
9155
9156
9157
9158
9159
9160
9161
9162
9163
9164
9165
9166
9167
9168
9169
9170
9171
9172
9173
9174
9175
9176
9177
9178
9179
9180
9181
9182
9183
9184
9185
9186
9187
9188
9189
9190
9191
9192
9193
9194
9195
9196
9197
9198
9199
9200
9201
9202
9203
9204
9205
9206
9207
9208
9209
9210
9211
9212
9213
9214
9215
9216
9217
9218
9219
9220
9221
9222
9223
9224
9225
9226
9227
9228
9229
9230
9231
9232
9233
9234
9235
9236
9237
9238
9239
9240
9241
9242
9243
9244
9245
9246
9247
9248
9249
9250
9251
9252
9253
9254
9255
9256
9257
9258
9259
9260
9261
9262
9263
9264
9265
9266
9267
9268
9269
9270
9271
9272
9273
9274
9275
9276
9277
9278
9279
9280
9281
9282
9283
9284
9285
9286
9287
9288
9289
9290
9291
9292
9293
9294
9295
9296
9297
9298
9299
9300
9301
9302
9303
9304
9305
9306
9307
9308
9309
9310
9311
9312
9313
9314
9315
9316
9317
9318
9319
9320
9321
9322
9323
9324
9325
9326
9327
9328
9329
9330
9331
9332
9333
9334
9335
9336
9337
9338
9339
9340
9341
9342
9343
9344
9345
9346
9347
9348
9349
9350
9351
9352
9353
9354
9355
9356
9357
9358
9359
9360
9361
9362
9363
9364
9365
9366
9367
9368
9369
9370
9371
9372
9373
9374
9375
9376
9377
9378
9379
9380
9381
9382
9383
9384
9385
9386
9387
9388
9389
9390
9391
9392
9393
9394
9395
9396
9397
9398
9399
9400
9401
9402
9403
9404
9405
9406
9407
9408
9409
9410
9411
9412
9413
9414
9415
9416
9417
9418
9419
9420
9421
9422
9423
9424
9425
9426
9427
9428
9429
9430
9431
9432
9433
9434
9435
9436
9437
9438
9439
9440
9441
9442
9443
9444
9445
9446
9447
9448
9449
9450
9451
9452
9453
9454
9455
9456
9457
9458
9459
9460
9461
9462
9463
9464
9465
9466
9467
9468
9469
9470
9471
9472
9473
9474
9475
9476
9477
9478
9479
9480
9481
9482
9483
9484
9485
9486
9487
9488
9489
9490
9491
9492
9493
9494
9495
9496
9497
9498
9499
9500
9501
9502
9503
9504
9505
9506
9507
9508
9509
9510
9511
9512
9513
9514
9515
9516
9517
9518
9519
9520
9521
9522
9523
9524
9525
9526
9527
9528
9529
9530
9531
9532
9533
9534
9535
9536
9537
9538
9539
9540
9541
9542
9543
9544
9545
9546
9547
9548
9549
9550
9551
9552
9553
9554
9555
9556
9557
9558
9559
9560
9561
9562
9563
9564
9565
9566
9567
9568
9569
9570
9571
9572
9573
9574
9575
9576
9577
9578
9579
9580
9581
9582
9583
9584
9585
9586
9587
9588
9589
9590
9591
9592
9593
9594
9595
9596
9597
9598
9599
9600
9601
9602
9603
9604
9605
9606
9607
9608
9609
9610
9611
9612
9613
9614
9615
9616
9617
9618
9619
9620
9621
9622
9623
9624
9625
9626
9627
9628
9629
9630
9631
9632
9633
9634
9635
9636
9637
9638
9639
9640
9641
9642
9643
9644
9645
9646
9647
9648
9649
9650
9651
9652
9653
9654
9655
9656
9657
9658
9659
9660
9661
9662
9663
9664
9665
9666
9667
9668
9669
9670
9671
9672
9673
9674
9675
9676
9677
9678
9679
9680
9681
9682
9683
9684
9685
9686
9687
9688
9689
9690
9691
9692
9693
9694
9695
9696
9697
9698
9699
9700
9701
9702
9703
9704
9705
9706
9707
9708
9709
9710
9711
9712
9713
9714
9715
9716
9717
9718
9719
9720
9721
9722
9723
9724
9725
9726
9727
9728
9729
9730
9731
9732
9733
9734
9735
9736
9737
9738
9739
9740
9741
9742
9743
9744
9745
9746
9747
9748
9749
9750
9751
9752
9753
9754
9755
9756
9757
9758
9759
9760
9761
9762
9763
9764
9765
9766
9767
9768
9769
9770
9771
9772
9773
9774
9775
9776
9777
9778
9779
9780
9781
9782
9783
9784
9785
9786
9787
9788
9789
9790
9791
9792
9793
9794
9795
9796
9797
9798
9799
9800
9801
9802
9803
9804
9805
9806
9807
9808
9809
9810
9811
9812
9813
9814
9815
9816
9817
9818
9819
9820
9821
9822
9823
9824
9825
9826
9827
9828
9829
9830
9831
9832
9833
9834
9835
9836
9837
9838
9839
9840
9841
9842
9843
9844
9845
9846
9847
9848
9849
9850
9851
9852
9853
9854
9855
9856
9857
9858
9859
9860
9861
9862
9863
9864
9865
9866
9867
9868
9869
9870
9871
9872
9873
9874
9875
9876
9877
9878
9879
9880
9881
9882
9883
9884
9885
9886
9887
9888
9889
9890
9891
9892
9893
9894
9895
9896
9897
9898
9899
9900
9901
9902
9903
9904
9905
9906
9907
9908
9909
9910
9911
9912
9913
9914
9915
9916
9917
9918
9919
9920
9921
9922
9923
9924
9925
9926
9927
9928
9929
9930
9931
9932
9933
9934
9935
9936
9937
9938
9939
9940
9941
9942
9943
9944
9945
9946
9947
9948
9949
9950
9951
9952
9953
9954
9955
9956
9957
9958
9959
9960
9961
9962
9963
9964
9965
9966
9967
9968
9969
9970
9971
9972
9973
9974
9975
9976
9977
9978
9979
9980
9981
9982
9983
9984
9985
9986
9987
9988
9989
9990
9991
9992
9993
9994
9995
9996
9997
9998
9999
10000
10001
10002
10003
10004
10005
10006
10007
10008
10009
10010
10011
10012
10013
10014
10015
10016
10017
10018
10019
10020
10021
10022
10023
10024
10025
10026
10027
10028
10029
10030
10031
10032
10033
10034
10035
10036
10037
10038
10039
10040
10041
10042
10043
10044
10045
10046
10047
10048
10049
10050
10051
10052
10053
10054
10055
10056
10057
10058
10059
10060
10061
10062
10063
10064
10065
10066
10067
10068
10069
10070
10071
10072
10073
10074
10075
10076
10077
10078
10079
10080
10081
10082
10083
10084
10085
10086
10087
10088
10089
10090
10091
10092
10093
10094
10095
10096
10097
10098
10099
10100
10101
10102
10103
10104
10105
10106
10107
10108
10109
10110
10111
10112
10113
10114
10115
10116
10117
10118
10119
10120
10121
10122
10123
10124
10125
10126
10127
10128
10129
10130
10131
10132
10133
10134
10135
10136
10137
10138
10139
10140
10141
10142
10143
10144
10145
10146
10147
10148
10149
10150
10151
10152
10153
10154
10155
10156
10157
10158
10159
10160
10161
10162
10163
10164
10165
10166
10167
10168
10169
10170
10171
10172
10173
10174
10175
10176
10177
10178
10179
10180
10181
10182
10183
10184
10185
10186
10187
10188
10189
10190
10191
10192
10193
10194
10195
10196
10197
10198
10199
10200
10201
10202
10203
10204
10205
10206
10207
10208
10209
10210
10211
10212
10213
10214
10215
10216
10217
10218
10219
10220
10221
10222
10223
10224
10225
10226
10227
10228
10229
10230
10231
10232
10233
10234
10235
10236
10237
10238
10239
10240
10241
10242
10243
10244
10245
10246
10247
10248
10249
10250
10251
10252
10253
10254
10255
10256
10257
10258
10259
10260
10261
10262
10263
10264
10265
10266
10267
10268
10269
10270
10271
10272
10273
10274
10275
10276
10277
10278
10279
10280
10281
10282
10283
10284
10285
10286
10287
10288
10289
10290
10291
10292
10293
10294
10295
10296
10297
10298
10299
10300
10301
10302
10303
10304
10305
10306
10307
10308
10309
10310
10311
10312
10313
10314
10315
10316
10317
10318
10319
10320
10321
10322
10323
10324
10325
10326
10327
10328
10329
10330
10331
10332
10333
10334
10335
10336
10337
10338
10339
10340
10341
10342
10343
10344
10345
10346
10347
10348
10349
10350
10351
10352
10353
10354
10355
10356
10357
10358
10359
10360
10361
10362
10363
10364
10365
10366
10367
10368
10369
10370
10371
10372
10373
10374
10375
10376
10377
10378
10379
10380
10381
10382
10383
10384
10385
10386
10387
10388
10389
10390
10391
10392
10393
10394
10395
10396
10397
10398
10399
10400
10401
10402
10403
10404
10405
10406
10407
10408
10409
10410
10411
10412
10413
10414
10415
10416
10417
10418
10419
10420
10421
10422
10423
10424
10425
10426
10427
10428
10429
10430
10431
10432
10433
10434
10435
10436
10437
10438
10439
10440
10441
10442
10443
10444
10445
10446
10447
10448
10449
10450
10451
10452
10453
10454
10455
10456
10457
10458
10459
10460
10461
10462
10463
10464
10465
10466
10467
10468
10469
10470
10471
10472
10473
10474
10475
10476
10477
10478
10479
10480
10481
10482
10483
10484
10485
10486
10487
10488
10489
10490
10491
10492
10493
10494
10495
10496
10497
10498
10499
10500
10501
10502
10503
10504
10505
10506
10507
10508
10509
10510
10511
10512
10513
10514
10515
10516
10517
10518
10519
10520
10521
10522
10523
10524
10525
10526
10527
10528
10529
10530
10531
10532
10533
10534
10535
10536
10537
10538
10539
10540
10541
10542
10543
10544
10545
10546
10547
10548
10549
10550
10551
10552
10553
10554
10555
10556
10557
10558
10559
10560
10561
10562
10563
10564
10565
10566
10567
10568
10569
10570
10571
10572
10573
10574
10575
10576
10577
10578
10579
10580
10581
10582
10583
10584
10585
10586
10587
10588
10589
10590
10591
10592
10593
10594
10595
10596
10597
10598
10599
10600
10601
10602
10603
10604
10605
10606
10607
10608
10609
10610
10611
10612
10613
10614
10615
10616
10617
10618
10619
10620
10621
10622
10623
10624
10625
10626
10627
10628
10629
10630
10631
10632
10633
10634
10635
10636
10637
10638
10639
10640
10641
10642
10643
10644
10645
10646
10647
10648
10649
10650
10651
10652
10653
10654
10655
10656
10657
10658
10659
10660
10661
10662
10663
10664
10665
10666
10667
10668
10669
10670
10671
10672
10673
10674
10675
10676
10677
10678
10679
10680
10681
10682
10683
10684
10685
10686
10687
10688
10689
10690
10691
10692
10693
10694
10695
10696
10697
10698
10699
10700
10701
10702
10703
10704
10705
10706
10707
10708
10709
10710
10711
10712
10713
10714
10715
10716
10717
10718
10719
10720
10721
10722
10723
10724
10725
10726
10727
10728
10729
10730
10731
10732
10733
10734
10735
10736
10737
10738
10739
10740
10741
10742
10743
10744
10745
10746
10747
10748
10749
10750
10751
10752
10753
10754
10755
10756
10757
10758
10759
10760
10761
10762
10763
10764
10765
10766
10767
10768
10769
10770
10771
10772
10773
10774
10775
10776
10777
10778
10779
10780
10781
10782
10783
10784
10785
10786
10787
10788
10789
10790
10791
10792
10793
10794
10795
10796
10797
10798
10799
10800
10801
10802
10803
10804
10805
10806
10807
10808
10809
10810
10811
10812
10813
10814
10815
10816
10817
10818
10819
10820
10821
10822
10823
10824
10825
10826
10827
10828
10829
10830
10831
10832
10833
10834
10835
10836
10837
10838
10839
10840
10841
10842
10843
10844
10845
10846
10847
10848
10849
10850
10851
10852
10853
10854
10855
10856
10857
10858
10859
10860
10861
10862
10863
10864
10865
10866
10867
10868
10869
10870
10871
10872
10873
10874
10875
10876
10877
10878
10879
10880
10881
10882
10883
10884
10885
10886
10887
10888
10889
10890
10891
10892
10893
10894
10895
10896
10897
10898
10899
10900
10901
10902
10903
10904
10905
10906
10907
10908
10909
10910
10911
10912
10913
10914
10915
10916
10917
10918
10919
10920
10921
10922
10923
10924
10925
10926
10927
10928
10929
10930
10931
10932
10933
10934
10935
10936
10937
10938
10939
10940
10941
10942
10943
10944
10945
10946
10947
10948
10949
10950
10951
10952
10953
10954
10955
10956
10957
10958
10959
10960
10961
10962
10963
10964
10965
10966
10967
10968
10969
10970
10971
10972
10973
10974
10975
10976
10977
10978
10979
10980
10981
10982
10983
10984
10985
10986
10987
10988
10989
10990
10991
10992
10993
10994
10995
10996
10997
10998
10999
11000
11001
11002
11003
11004
11005
11006
11007
11008
11009
11010
11011
11012
11013
11014
11015
11016
11017
11018
11019
11020
11021
11022
11023
11024
11025
11026
11027
11028
11029
11030
11031
11032
11033
11034
11035
11036
11037
11038
11039
11040
11041
11042
11043
11044
11045
11046
11047
11048
11049
11050
11051
11052
11053
11054
11055
11056
11057
11058
11059
11060
11061
11062
11063
11064
11065
11066
11067
11068
11069
11070
11071
11072
11073
11074
11075
11076
11077
11078
11079
11080
11081
11082
11083
11084
11085
11086
11087
11088
11089
11090
11091
11092
11093
11094
11095
11096
11097
11098
11099
11100
11101
11102
11103
11104
11105
11106
11107
11108
11109
11110
11111
11112
11113
11114
11115
11116
11117
11118
11119
11120
11121
11122
11123
11124
11125
11126
11127
11128
11129
11130
11131
11132
11133
11134
11135
11136
11137
11138
11139
11140
11141
11142
11143
11144
11145
11146
11147
11148
11149
11150
11151
11152
11153
11154
11155
11156
11157
11158
11159
11160
11161
11162
11163
11164
11165
11166
11167
11168
11169
11170
11171
11172
11173
11174
11175
11176
11177
11178
11179
11180
11181
11182
11183
11184
11185
11186
11187
11188
11189
11190
11191
11192
11193
11194
11195
11196
11197
11198
11199
11200
11201
11202
11203
11204
11205
11206
11207
11208
11209
11210
11211
11212
11213
11214
11215
11216
11217
11218
11219
11220
11221
11222
11223
11224
11225
11226
11227
11228
11229
11230
11231
11232
11233
11234
11235
11236
11237
11238
11239
11240
11241
11242
11243
11244
11245
11246
11247
11248
11249
11250
11251
11252
11253
11254
11255
11256
11257
11258
11259
11260
11261
11262
11263
11264
11265
11266
11267
11268
11269
11270
11271
11272
11273
11274
11275
11276
11277
11278
11279
11280
11281
11282
11283
11284
11285
11286
11287
11288
11289
11290
11291
11292
11293
11294
11295
11296
11297
11298
11299
11300
11301
11302
11303
11304
11305
11306
11307
11308
11309
11310
11311
11312
11313
11314
11315
11316
11317
11318
11319
11320
11321
11322
11323
11324
11325
11326
11327
11328
11329
11330
11331
11332
11333
11334
11335
11336
11337
11338
11339
11340
11341
11342
11343
11344
11345
11346
11347
11348
11349
11350
11351
11352
11353
11354
11355
11356
11357
11358
11359
11360
11361
11362
11363
11364
11365
11366
11367
11368
11369
11370
11371
11372
11373
11374
11375
11376
11377
11378
11379
11380
11381
11382
11383
11384
11385
11386
11387
11388
11389
11390
11391
11392
11393
11394
11395
11396
11397
11398
11399
11400
11401
11402
11403
11404
11405
11406
11407
11408
11409
11410
11411
11412
11413
11414
11415
11416
11417
11418
11419
11420
11421
11422
11423
11424
11425
11426
11427
11428
11429
11430
11431
11432
11433
11434
11435
11436
11437
11438
11439
11440
11441
11442
11443
11444
11445
11446
11447
11448
11449
11450
11451
11452
11453
11454
11455
11456
11457
11458
11459
11460
11461
11462
11463
11464
11465
11466
11467
11468
11469
11470
11471
11472
11473
11474
11475
11476
11477
11478
11479
11480
11481
11482
11483
11484
11485
11486
11487
11488
11489
11490
11491
11492
11493
11494
11495
11496
11497
11498
11499
11500
11501
11502
11503
11504
11505
11506
11507
11508
11509
11510
11511
11512
11513
11514
11515
11516
11517
11518
11519
11520
11521
11522
11523
11524
11525
11526
11527
11528
11529
11530
11531
11532
11533
11534
11535
11536
11537
11538
11539
11540
11541
11542
11543
11544
11545
11546
11547
11548
11549
11550
11551
11552
11553
11554
11555
11556
11557
11558
11559
11560
11561
11562
11563
11564
11565
11566
11567
11568
11569
11570
11571
11572
11573
11574
11575
11576
11577
11578
11579
11580
11581
11582
11583
11584
11585
11586
11587
11588
11589
11590
11591
11592
11593
11594
11595
11596
11597
11598
11599
11600
11601
11602
11603
11604
11605
11606
11607
11608
11609
11610
11611
11612
11613
11614
11615
11616
11617
11618
11619
11620
11621
11622
11623
11624
11625
11626
11627
11628
11629
11630
11631
11632
11633
11634
11635
11636
11637
11638
11639
11640
11641
11642
11643
11644
11645
11646
11647
11648
11649
11650
11651
11652
11653
11654
11655
11656
11657
11658
11659
11660
11661
11662
11663
11664
11665
11666
11667
11668
11669
11670
11671
11672
11673
11674
11675
11676
11677
11678
11679
11680
11681
11682
11683
11684
11685
11686
11687
11688
11689
11690
11691
11692
11693
11694
11695
11696
11697
11698
11699
11700
11701
11702
11703
11704
11705
11706
11707
11708
11709
11710
11711
11712
11713
11714
11715
11716
11717
11718
11719
11720
11721
11722
11723
11724
11725
11726
11727
11728
11729
11730
11731
11732
11733
11734
11735
11736
11737
11738
11739
11740
11741
11742
11743
11744
11745
11746
11747
11748
11749
11750
11751
11752
11753
11754
11755
11756
11757
11758
11759
11760
11761
11762
11763
11764
11765
11766
11767
11768
11769
11770
11771
11772
11773
11774
11775
11776
11777
11778
11779
11780
11781
11782
11783
11784
11785
11786
11787
11788
11789
11790
11791
11792
11793
11794
11795
11796
11797
11798
11799
11800
11801
11802
11803
11804
11805
11806
11807
11808
11809
11810
11811
11812
11813
11814
11815
11816
11817
11818
11819
11820
11821
11822
11823
11824
11825
11826
11827
11828
11829
11830
11831
11832
11833
11834
11835
11836
11837
11838
11839
11840
11841
11842
11843
11844
11845
11846
11847
11848
11849
11850
11851
11852
11853
11854
11855
11856
11857
11858
11859
11860
11861
11862
11863
11864
11865
11866
11867
11868
11869
11870
11871
11872
11873
11874
11875
11876
11877
11878
11879
11880
11881
11882
11883
11884
11885
11886
11887
11888
11889
11890
11891
11892
11893
11894
11895
11896
11897
11898
11899
11900
11901
11902
11903
11904
11905
11906
11907
11908
11909
11910
11911
11912
11913
11914
11915
11916
11917
11918
11919
11920
11921
11922
11923
11924
11925
11926
11927
11928
11929
11930
11931
11932
11933
11934
11935
11936
11937
11938
11939
11940
11941
11942
11943
11944
11945
11946
11947
11948
11949
11950
11951
11952
11953
11954
11955
11956
11957
11958
11959
11960
11961
11962
11963
11964
11965
11966
11967
11968
11969
11970
11971
11972
11973
11974
11975
11976
11977
11978
11979
11980
11981
11982
11983
11984
11985
11986
11987
11988
11989
11990
11991
11992
11993
11994
11995
11996
11997
11998
11999
12000
12001
12002
12003
12004
12005
12006
12007
12008
12009
12010
12011
12012
12013
12014
12015
12016
12017
12018
12019
12020
12021
12022
12023
12024
12025
12026
12027
12028
12029
12030
12031
12032
12033
12034
12035
12036
12037
12038
12039
12040
12041
12042
12043
12044
12045
12046
12047
12048
12049
12050
12051
12052
12053
12054
12055
12056
12057
12058
12059
12060
12061
12062
12063
12064
12065
12066
12067
12068
12069
12070
12071
12072
12073
12074
12075
12076
12077
12078
12079
12080
12081
12082
12083
12084
12085
12086
12087
12088
12089
12090
12091
12092
12093
12094
12095
12096
12097
12098
12099
12100
12101
12102
12103
12104
12105
12106
12107
12108
12109
12110
12111
12112
12113
12114
12115
12116
12117
12118
12119
12120
12121
12122
12123
12124
12125
12126
12127
12128
12129
12130
12131
12132
12133
12134
12135
12136
12137
12138
12139
12140
12141
12142
12143
12144
12145
12146
12147
12148
12149
12150
12151
12152
12153
12154
12155
12156
12157
12158
12159
12160
12161
12162
12163
12164
12165
12166
12167
12168
12169
12170
12171
12172
12173
12174
12175
12176
12177
12178
12179
12180
12181
12182
12183
12184
12185
12186
12187
12188
12189
12190
12191
12192
12193
12194
12195
12196
12197
12198
12199
12200
12201
12202
12203
12204
12205
12206
12207
12208
12209
12210
12211
12212
12213
12214
12215
12216
12217
12218
12219
12220
12221
12222
12223
12224
12225
12226
12227
12228
12229
12230
12231
12232
12233
12234
12235
12236
12237
12238
12239
12240
12241
12242
12243
12244
12245
12246
12247
12248
12249
12250
12251
12252
12253
12254
12255
12256
12257
12258
12259
12260
12261
12262
12263
12264
12265
12266
12267
12268
12269
12270
12271
12272
12273
12274
12275
12276
12277
12278
12279
12280
12281
12282
12283
12284
12285
12286
12287
12288
12289
12290
12291
12292
12293
12294
12295
12296
12297
12298
12299
12300
12301
12302
12303
12304
12305
12306
12307
12308
12309
12310
12311
12312
12313
12314
12315
12316
12317
12318
12319
12320
12321
12322
12323
12324
12325
12326
12327
12328
12329
12330
12331
12332
12333
12334
12335
12336
12337
12338
12339
12340
12341
12342
12343
12344
12345
12346
12347
12348
12349
12350
12351
12352
12353
12354
12355
12356
12357
12358
12359
12360
12361
12362
12363
12364
12365
12366
12367
12368
12369
12370
12371
12372
12373
12374
12375
12376
12377
12378
12379
12380
12381
12382
12383
12384
12385
12386
12387
12388
12389
12390
12391
12392
12393
12394
12395
12396
12397
12398
12399
12400
12401
12402
12403
12404
12405
12406
12407
12408
12409
12410
12411
12412
12413
12414
12415
12416
12417
12418
12419
12420
12421
12422
12423
12424
12425
12426
12427
12428
12429
12430
12431
12432
12433
12434
12435
12436
12437
12438
12439
12440
12441
12442
12443
12444
12445
12446
12447
12448
12449
12450
12451
12452
12453
12454
12455
12456
12457
12458
12459
12460
12461
12462
12463
12464
12465
12466
12467
12468
12469
12470
12471
12472
12473
12474
12475
12476
12477
12478
12479
12480
12481
12482
12483
12484
12485
12486
12487
12488
12489
12490
12491
12492
12493
12494
12495
12496
12497
12498
12499
12500
12501
12502
12503
12504
12505
12506
12507
12508
12509
12510
12511
12512
12513
12514
12515
12516
12517
12518
12519
12520
12521
12522
12523
12524
12525
12526
12527
12528
12529
12530
12531
12532
12533
12534
12535
12536
12537
12538
12539
12540
12541
12542
12543
12544
12545
12546
12547
12548
12549
12550
12551
12552
12553
12554
12555
12556
12557
12558
12559
12560
12561
12562
12563
12564
12565
12566
12567
12568
12569
12570
12571
12572
12573
12574
12575
12576
12577
12578
12579
12580
12581
12582
12583
12584
12585
12586
12587
12588
12589
12590
12591
12592
12593
12594
12595
12596
12597
12598
12599
12600
12601
12602
12603
12604
12605
12606
12607
12608
12609
12610
12611
12612
12613
12614
12615
12616
12617
12618
12619
12620
12621
12622
12623
12624
12625
12626
12627
12628
12629
12630
12631
12632
12633
12634
12635
12636
12637
12638
12639
12640
12641
12642
12643
12644
12645
12646
12647
12648
12649
12650
12651
12652
12653
12654
12655
12656
12657
12658
12659
12660
12661
12662
12663
12664
12665
12666
12667
12668
12669
12670
12671
12672
12673
12674
12675
12676
12677
12678
12679
12680
12681
12682
12683
12684
12685
12686
12687
12688
12689
12690
12691
12692
12693
12694
12695
12696
12697
12698
12699
12700
12701
12702
12703
12704
12705
12706
12707
12708
12709
12710
12711
12712
12713
12714
12715
12716
12717
12718
12719
12720
12721
12722
12723
12724
12725
12726
12727
12728
12729
12730
12731
12732
12733
12734
12735
12736
12737
12738
12739
12740
12741
12742
12743
12744
12745
12746
12747
12748
12749
12750
12751
12752
12753
12754
12755
12756
12757
12758
12759
12760
12761
12762
12763
12764
12765
12766
12767
12768
12769
12770
12771
12772
12773
12774
12775
12776
12777
12778
12779
12780
12781
12782
12783
12784
12785
12786
12787
12788
12789
12790
12791
12792
12793
12794
12795
12796
12797
12798
12799
12800
12801
12802
12803
12804
12805
12806
12807
12808
12809
12810
12811
12812
12813
12814
12815
12816
12817
12818
12819
12820
12821
12822
12823
12824
12825
12826
12827
12828
12829
12830
12831
12832
12833
12834
12835
12836
12837
12838
12839
12840
12841
12842
12843
12844
12845
12846
12847
12848
12849
12850
12851
12852
12853
12854
12855
12856
12857
12858
12859
12860
12861
12862
12863
12864
12865
12866
12867
12868
12869
12870
12871
12872
12873
12874
12875
12876
12877
12878
12879
12880
12881
12882
12883
12884
12885
12886
12887
12888
12889
12890
12891
12892
12893
12894
12895
12896
12897
12898
12899
12900
12901
12902
12903
12904
12905
12906
12907
12908
12909
12910
12911
12912
12913
12914
12915
12916
12917
12918
12919
12920
12921
12922
12923
12924
12925
12926
12927
12928
12929
12930
12931
12932
12933
12934
12935
12936
12937
12938
12939
12940
12941
12942
12943
12944
12945
12946
12947
12948
12949
12950
12951
12952
12953
12954
12955
12956
12957
12958
12959
12960
12961
12962
12963
12964
12965
12966
12967
12968
12969
12970
12971
12972
12973
12974
12975
12976
12977
12978
12979
12980
12981
12982
12983
12984
12985
12986
12987
12988
12989
12990
12991
12992
12993
12994
12995
12996
12997
12998
12999
13000
13001
13002
13003
13004
13005
13006
13007
13008
13009
13010
13011
13012
13013
13014
13015
13016
13017
13018
13019
13020
13021
13022
13023
13024
13025
13026
13027
13028
13029
13030
13031
13032
13033
13034
13035
13036
13037
13038
13039
13040
13041
13042
13043
13044
13045
13046
13047
13048
13049
13050
13051
13052
13053
13054
13055
13056
13057
13058
13059
13060
13061
13062
13063
13064
13065
13066
13067
13068
13069
13070
13071
13072
13073
13074
13075
13076
13077
13078
13079
13080
13081
13082
13083
13084
13085
13086
13087
13088
13089
13090
13091
13092
13093
13094
13095
13096
13097
13098
13099
13100
13101
13102
13103
13104
13105
13106
13107
13108
13109
13110
13111
13112
13113
13114
13115
13116
13117
13118
13119
13120
13121
13122
13123
13124
13125
13126
13127
13128
13129
13130
13131
13132
13133
13134
13135
13136
13137
13138
13139
13140
13141
13142
13143
13144
13145
13146
13147
13148
13149
13150
13151
13152
13153
13154
13155
13156
13157
13158
13159
13160
13161
13162
13163
13164
13165
13166
13167
13168
13169
13170
13171
13172
13173
13174
13175
13176
13177
13178
13179
13180
13181
13182
13183
13184
13185
13186
13187
13188
13189
13190
13191
13192
13193
13194
13195
13196
13197
13198
13199
13200
13201
13202
13203
13204
13205
13206
13207
13208
13209
13210
13211
13212
13213
13214
13215
13216
13217
13218
13219
13220
13221
13222
13223
13224
13225
13226
13227
13228
13229
13230
13231
13232
13233
13234
13235
13236
13237
13238
13239
13240
13241
13242
13243
13244
13245
13246
13247
13248
13249
13250
13251
13252
13253
13254
13255
13256
13257
13258
13259
13260
13261
13262
13263
13264
13265
13266
13267
13268
13269
13270
13271
13272
13273
13274
13275
13276
13277
13278
13279
13280
13281
13282
13283
13284
13285
13286
13287
13288
13289
13290
13291
13292
13293
13294
13295
13296
13297
13298
13299
13300
13301
13302
13303
13304
13305
13306
13307
13308
13309
13310
13311
13312
13313
13314
13315
13316
13317
13318
13319
13320
13321
13322
13323
13324
13325
13326
13327
13328
13329
13330
13331
13332
13333
13334
13335
13336
13337
13338
13339
13340
13341
13342
13343
13344
13345
13346
13347
13348
13349
13350
13351
13352
13353
13354
13355
13356
13357
13358
13359
13360
13361
13362
13363
13364
13365
13366
13367
13368
13369
13370
13371
13372
13373
13374
13375
13376
13377
13378
13379
13380
13381
13382
13383
13384
13385
13386
13387
13388
13389
13390
13391
13392
13393
13394
13395
13396
13397
13398
13399
13400
13401
13402
13403
13404
13405
13406
13407
13408
13409
13410
13411
13412
13413
13414
13415
13416
13417
13418
13419
13420
13421
13422
13423
13424
13425
13426
13427
13428
13429
13430
13431
13432
13433
13434
13435
13436
13437
13438
13439
13440
13441
13442
13443
13444
13445
13446
13447
13448
13449
13450
13451
13452
13453
13454
13455
13456
13457
13458
13459
13460
13461
13462
13463
13464
13465
13466
13467
13468
13469
13470
13471
13472
13473
13474
13475
13476
13477
13478
13479
13480
13481
13482
13483
13484
13485
13486
13487
13488
13489
13490
13491
13492
13493
13494
13495
13496
13497
13498
13499
13500
13501
13502
13503
13504
13505
13506
13507
13508
13509
13510
13511
13512
13513
13514
13515
13516
13517
13518
13519
13520
13521
13522
13523
13524
13525
13526
13527
13528
13529
13530
13531
13532
13533
13534
13535
13536
13537
13538
13539
13540
13541
13542
13543
13544
13545
13546
13547
13548
13549
13550
13551
13552
13553
13554
13555
13556
13557
13558
13559
13560
13561
13562
13563
13564
13565
13566
13567
13568
13569
13570
13571
13572
13573
13574
13575
13576
13577
13578
13579
13580
13581
13582
13583
13584
13585
13586
13587
13588
13589
13590
13591
13592
13593
13594
13595
13596
13597
13598
13599
13600
13601
13602
13603
13604
13605
13606
13607
13608
13609
13610
13611
13612
13613
13614
13615
13616
13617
13618
13619
13620
13621
13622
13623
13624
13625
13626
13627
13628
13629
13630
13631
13632
13633
13634
13635
13636
13637
13638
13639
13640
13641
13642
13643
13644
13645
13646
13647
13648
13649
13650
13651
13652
13653
13654
13655
13656
13657
13658
13659
13660
13661
13662
13663
13664
13665
13666
13667
13668
13669
13670
13671
13672
13673
13674
13675
13676
13677
13678
13679
13680
13681
13682
13683
13684
13685
13686
13687
13688
13689
13690
13691
13692
13693
13694
13695
13696
13697
13698
13699
13700
13701
13702
13703
13704
13705
13706
13707
13708
13709
13710
13711
13712
13713
13714
13715
13716
13717
13718
13719
13720
13721
13722
13723
13724
13725
13726
13727
13728
13729
13730
13731
13732
13733
13734
13735
13736
13737
13738
13739
13740
13741
13742
13743
13744
13745
13746
13747
13748
13749
13750
13751
13752
13753
13754
13755
13756
13757
13758
13759
13760
13761
13762
13763
13764
13765
13766
13767
13768
13769
13770
13771
13772
13773
13774
13775
13776
13777
13778
13779
13780
13781
13782
13783
13784
13785
13786
13787
13788
13789
13790
13791
13792
13793
13794
13795
13796
13797
13798
13799
13800
13801
13802
13803
13804
13805
13806
13807
13808
13809
13810
13811
13812
13813
13814
13815
13816
13817
13818
13819
13820
13821
13822
13823
13824
13825
13826
13827
13828
13829
13830
13831
13832
13833
13834
13835
13836
13837
13838
13839
13840
13841
13842
13843
13844
13845
13846
13847
13848
13849
13850
13851
13852
13853
13854
13855
13856
13857
13858
13859
13860
13861
13862
13863
13864
13865
13866
13867
13868
13869
13870
13871
13872
13873
13874
13875
13876
13877
13878
13879
13880
13881
13882
13883
13884
13885
13886
13887
13888
13889
13890
13891
13892
13893
13894
13895
13896
13897
13898
13899
13900
13901
13902
13903
13904
13905
13906
13907
13908
13909
13910
13911
13912
13913
13914
13915
13916
13917
13918
13919
13920
13921
13922
13923
13924
13925
13926
13927
13928
13929
13930
13931
13932
13933
13934
13935
13936
13937
13938
13939
13940
13941
13942
13943
13944
13945
13946
13947
13948
13949
13950
13951
13952
13953
13954
13955
13956
13957
13958
13959
13960
13961
13962
13963
13964
13965
13966
13967
13968
13969
13970
13971
13972
13973
13974
13975
13976
13977
13978
13979
13980
13981
13982
13983
13984
13985
13986
13987
13988
13989
13990
13991
13992
13993
13994
13995
13996
13997
13998
13999
14000
14001
14002
14003
14004
14005
14006
14007
14008
14009
14010
14011
14012
14013
14014
14015
14016
14017
14018
14019
14020
14021
14022
14023
14024
14025
14026
14027
14028
14029
14030
14031
14032
14033
14034
14035
14036
14037
14038
14039
14040
14041
14042
14043
14044
14045
14046
14047
14048
14049
14050
14051
14052
14053
14054
14055
14056
14057
14058
14059
14060
14061
14062
14063
14064
14065
14066
14067
14068
14069
14070
14071
14072
14073
14074
14075
14076
14077
14078
14079
14080
14081
14082
14083
14084
14085
14086
14087
14088
14089
14090
14091
14092
14093
14094
14095
14096
14097
14098
14099
14100
14101
14102
14103
14104
14105
14106
14107
14108
14109
14110
14111
14112
14113
14114
14115
14116
14117
14118
14119
14120
14121
14122
14123
14124
14125
14126
14127
14128
14129
14130
14131
14132
14133
14134
14135
14136
14137
14138
14139
14140
14141
14142
14143
14144
14145
14146
14147
14148
14149
14150
14151
14152
14153
14154
14155
14156
14157
14158
14159
14160
14161
14162
14163
14164
14165
14166
14167
14168
14169
14170
14171
14172
14173
14174
14175
14176
14177
14178
14179
14180
14181
14182
14183
14184
14185
14186
14187
14188
14189
14190
14191
14192
14193
14194
14195
14196
14197
14198
14199
14200
14201
14202
14203
14204
14205
14206
14207
14208
14209
14210
14211
14212
14213
14214
14215
14216
14217
14218
14219
14220
14221
14222
14223
14224
14225
14226
14227
14228
14229
14230
14231
14232
14233
14234
14235
14236
14237
14238
14239
14240
14241
14242
14243
14244
14245
14246
14247
14248
14249
14250
14251
14252
14253
14254
14255
14256
14257
14258
14259
14260
14261
14262
14263
14264
14265
14266
14267
14268
14269
14270
14271
14272
14273
14274
14275
14276
14277
14278
14279
14280
14281
14282
14283
14284
14285
14286
14287
14288
14289
14290
14291
14292
14293
14294
14295
14296
14297
14298
14299
14300
14301
14302
14303
14304
14305
14306
14307
14308
14309
14310
14311
14312
14313
14314
14315
14316
14317
14318
14319
14320
14321
14322
14323
14324
14325
14326
14327
14328
14329
14330
14331
14332
14333
14334
14335
14336
14337
14338
14339
14340
14341
14342
14343
14344
14345
14346
14347
14348
14349
14350
14351
14352
14353
14354
14355
14356
14357
14358
14359
14360
14361
14362
14363
14364
14365
14366
14367
14368
14369
14370
14371
14372
14373
14374
14375
14376
14377
14378
14379
14380
14381
14382
14383
14384
14385
14386
14387
14388
14389
14390
14391
14392
14393
14394
14395
14396
14397
14398
14399
14400
14401
14402
14403
14404
14405
14406
14407
14408
14409
14410
14411
14412
14413
14414
14415
14416
14417
14418
14419
14420
14421
14422
14423
14424
14425
14426
14427
14428
14429
14430
14431
14432
14433
14434
14435
14436
14437
14438
14439
14440
14441
14442
14443
14444
14445
14446
14447
14448
14449
14450
14451
14452
14453
14454
14455
14456
14457
14458
14459
14460
14461
14462
14463
14464
14465
14466
14467
14468
14469
14470
14471
14472
14473
14474
14475
14476
14477
14478
14479
14480
14481
14482
14483
14484
14485
14486
14487
14488
14489
14490
14491
14492
14493
14494
14495
14496
14497
14498
14499
14500
14501
14502
14503
14504
14505
14506
14507
14508
14509
14510
14511
14512
14513
14514
14515
14516
14517
14518
14519
14520
14521
14522
14523
14524
14525
14526
14527
14528
14529
14530
14531
14532
14533
14534
14535
14536
14537
14538
14539
14540
14541
14542
14543
14544
14545
14546
14547
14548
14549
14550
14551
14552
14553
14554
14555
14556
14557
14558
14559
14560
14561
14562
14563
14564
14565
14566
14567
14568
14569
14570
14571
14572
14573
14574
14575
14576
14577
14578
14579
14580
14581
14582
14583
14584
14585
14586
14587
14588
14589
14590
14591
14592
14593
14594
14595
14596
14597
14598
14599
14600
14601
14602
14603
14604
14605
14606
14607
14608
14609
14610
14611
14612
14613
14614
14615
14616
14617
14618
14619
14620
14621
14622
14623
14624
14625
14626
14627
14628
14629
14630
14631
14632
14633
14634
14635
14636
14637
14638
14639
14640
14641
14642
14643
14644
14645
14646
14647
14648
14649
14650
14651
14652
14653
14654
14655
14656
14657
14658
14659
14660
14661
14662
14663
14664
14665
14666
14667
14668
14669
14670
14671
14672
14673
14674
14675
14676
14677
14678
14679
14680
14681
14682
14683
14684
14685
14686
14687
14688
14689
14690
14691
14692
14693
14694
14695
14696
14697
14698
14699
14700
14701
14702
14703
14704
14705
14706
14707
14708
14709
14710
14711
14712
14713
14714
14715
14716
14717
14718
14719
14720
14721
14722
14723
14724
14725
14726
14727
14728
14729
14730
14731
14732
14733
14734
14735
14736
14737
14738
14739
14740
14741
14742
14743
14744
14745
14746
14747
14748
14749
14750
14751
14752
14753
14754
14755
14756
14757
14758
14759
14760
14761
14762
14763
14764
14765
14766
14767
14768
14769
14770
14771
14772
14773
14774
14775
14776
14777
14778
14779
14780
14781
14782
14783
14784
14785
14786
14787
14788
14789
14790
14791
14792
14793
14794
14795
14796
14797
14798
14799
14800
14801
14802
14803
14804
14805
14806
14807
14808
14809
14810
14811
14812
14813
14814
14815
14816
14817
14818
14819
14820
14821
14822
14823
14824
14825
14826
14827
14828
14829
14830
14831
14832
14833
14834
14835
14836
14837
14838
14839
14840
14841
14842
14843
14844
14845
14846
14847
14848
14849
14850
14851
14852
14853
14854
14855
14856
14857
14858
14859
14860
14861
14862
14863
14864
14865
14866
14867
14868
14869
14870
14871
14872
14873
14874
14875
14876
14877
14878
14879
14880
14881
14882
14883
14884
14885
14886
14887
14888
14889
14890
14891
14892
14893
14894
14895
14896
14897
14898
14899
14900
14901
14902
14903
14904
14905
14906
14907
14908
14909
14910
14911
14912
14913
14914
14915
14916
14917
14918
14919
14920
14921
14922
14923
14924
14925
14926
14927
14928
14929
14930
14931
14932
14933
14934
14935
14936
14937
14938
14939
14940
14941
14942
14943
14944
14945
14946
14947
14948
14949
14950
14951
14952
14953
14954
14955
14956
14957
14958
14959
14960
14961
14962
14963
14964
14965
14966
14967
14968
14969
14970
14971
14972
14973
14974
14975
14976
14977
14978
14979
14980
14981
14982
14983
14984
14985
14986
14987
14988
14989
14990
14991
14992
14993
14994
14995
14996
14997
14998
14999
15000
15001
15002
15003
15004
15005
15006
15007
15008
15009
15010
15011
15012
15013
15014
15015
15016
15017
15018
15019
15020
15021
15022
15023
15024
15025
15026
15027
15028
15029
15030
15031
15032
15033
15034
15035
15036
15037
15038
15039
15040
15041
15042
15043
15044
15045
15046
15047
15048
15049
15050
15051
15052
15053
15054
15055
15056
15057
15058
15059
15060
15061
15062
15063
15064
15065
15066
15067
15068
15069
15070
15071
15072
15073
15074
15075
15076
15077
15078
15079
15080
15081
15082
15083
15084
15085
15086
15087
15088
15089
15090
15091
15092
15093
15094
15095
15096
15097
15098
15099
15100
15101
15102
15103
15104
15105
15106
15107
15108
15109
15110
15111
15112
15113
15114
15115
15116
15117
15118
15119
15120
15121
15122
15123
15124
15125
15126
15127
15128
15129
15130
15131
15132
15133
15134
15135
15136
15137
15138
15139
15140
15141
15142
15143
15144
15145
15146
15147
15148
15149
15150
15151
15152
15153
15154
15155
15156
15157
15158
15159
15160
15161
15162
15163
15164
15165
15166
15167
15168
15169
15170
15171
15172
15173
15174
15175
15176
15177
15178
15179
15180
15181
15182
15183
15184
15185
15186
15187
15188
15189
15190
15191
15192
15193
15194
15195
15196
15197
15198
15199
15200
15201
15202
15203
15204
15205
15206
15207
15208
15209
15210
15211
15212
15213
15214
15215
15216
15217
15218
15219
15220
15221
15222
15223
15224
15225
15226
15227
15228
15229
15230
15231
15232
15233
15234
15235
15236
15237
15238
15239
15240
15241
15242
15243
15244
15245
15246
15247
15248
15249
15250
15251
15252
15253
15254
15255
15256
15257
15258
15259
15260
15261
15262
15263
15264
15265
15266
15267
15268
15269
15270
15271
15272
15273
15274
15275
15276
15277
15278
15279
15280
15281
15282
15283
15284
15285
15286
15287
15288
15289
15290
15291
15292
15293
15294
15295
15296
15297
15298
15299
15300
15301
15302
15303
15304
15305
15306
15307
15308
15309
15310
15311
15312
15313
15314
15315
15316
15317
15318
15319
15320
15321
15322
15323
15324
15325
15326
15327
15328
15329
15330
15331
15332
15333
15334
15335
15336
15337
15338
15339
15340
15341
15342
15343
15344
15345
15346
15347
15348
15349
15350
15351
15352
15353
15354
15355
15356
15357
15358
15359
15360
15361
15362
15363
15364
15365
15366
15367
15368
15369
15370
15371
15372
15373
15374
15375
15376
15377
15378
15379
15380
15381
15382
15383
15384
15385
15386
15387
15388
15389
15390
15391
15392
15393
15394
15395
15396
15397
15398
15399
15400
15401
15402
15403
15404
15405
15406
15407
15408
15409
15410
15411
15412
15413
15414
15415
15416
15417
15418
15419
15420
15421
15422
15423
15424
15425
15426
15427
15428
15429
15430
15431
15432
15433
15434
15435
15436
15437
15438
15439
15440
15441
15442
15443
15444
15445
15446
15447
15448
15449
15450
15451
15452
15453
15454
15455
15456
15457
15458
15459
15460
15461
15462
15463
15464
15465
15466
15467
15468
15469
15470
15471
15472
15473
15474
15475
15476
15477
15478
15479
15480
15481
15482
15483
15484
15485
15486
15487
15488
15489
15490
15491
15492
15493
15494
15495
15496
15497
15498
15499
15500
15501
15502
15503
15504
15505
15506
15507
15508
15509
15510
15511
15512
15513
15514
15515
15516
15517
15518
15519
15520
15521
15522
15523
15524
15525
15526
15527
15528
15529
15530
15531
15532
15533
15534
15535
15536
15537
15538
15539
15540
15541
15542
15543
15544
15545
15546
15547
15548
15549
15550
15551
15552
15553
15554
15555
15556
15557
15558
15559
15560
15561
15562
15563
15564
15565
15566
15567
15568
15569
15570
15571
15572
15573
15574
15575
15576
15577
15578
15579
15580
15581
15582
15583
15584
15585
15586
15587
15588
15589
15590
15591
15592
15593
15594
15595
15596
15597
15598
15599
15600
15601
15602
15603
15604
15605
15606
15607
15608
15609
15610
15611
15612
15613
15614
15615
15616
15617
15618
15619
15620
15621
15622
15623
15624
15625
15626
15627
15628
15629
15630
15631
15632
15633
15634
15635
15636
15637
15638
15639
15640
15641
15642
15643
15644
15645
15646
15647
15648
15649
15650
15651
15652
15653
15654
15655
15656
15657
15658
15659
15660
15661
15662
15663
15664
15665
15666
15667
15668
15669
15670
15671
15672
15673
15674
15675
15676
15677
15678
15679
15680
15681
15682
15683
15684
15685
15686
15687
15688
15689
15690
15691
15692
15693
15694
15695
15696
15697
15698
15699
15700
15701
15702
15703
15704
15705
15706
15707
15708
15709
15710
15711
15712
15713
15714
15715
15716
15717
15718
15719
15720
15721
15722
15723
15724
15725
15726
15727
15728
15729
15730
15731
15732
15733
15734
15735
15736
15737
15738
15739
15740
15741
15742
15743
15744
15745
15746
15747
15748
15749
15750
15751
15752
15753
15754
15755
15756
15757
15758
15759
15760
15761
15762
15763
15764
15765
15766
15767
15768
15769
15770
15771
15772
15773
15774
15775
15776
15777
15778
15779
15780
15781
15782
15783
15784
15785
15786
15787
15788
15789
15790
15791
15792
15793
15794
15795
15796
15797
15798
15799
15800
15801
15802
15803
15804
15805
15806
15807
15808
15809
15810
15811
15812
15813
15814
15815
15816
15817
15818
15819
15820
15821
15822
15823
15824
15825
15826
15827
15828
15829
15830
15831
15832
15833
15834
15835
15836
15837
15838
15839
15840
15841
15842
15843
15844
15845
15846
15847
15848
15849
15850
15851
15852
15853
15854
15855
15856
15857
15858
15859
15860
15861
15862
15863
15864
15865
15866
15867
15868
15869
15870
15871
15872
15873
15874
15875
15876
15877
15878
15879
15880
15881
15882
15883
15884
15885
15886
15887
15888
15889
15890
15891
15892
15893
15894
15895
15896
15897
15898
15899
15900
15901
15902
15903
15904
15905
15906
15907
15908
15909
15910
15911
15912
15913
15914
15915
15916
15917
15918
15919
15920
15921
15922
15923
15924
15925
15926
15927
15928
15929
15930
15931
15932
15933
15934
15935
15936
15937
15938
15939
15940
15941
15942
15943
15944
15945
15946
15947
15948
15949
15950
15951
15952
15953
15954
15955
15956
15957
15958
15959
15960
15961
15962
15963
15964
15965
15966
15967
15968
15969
15970
15971
15972
15973
15974
15975
15976
15977
15978
15979
15980
15981
15982
15983
15984
15985
15986
15987
15988
15989
15990
15991
15992
15993
15994
15995
15996
15997
15998
15999
16000
16001
16002
16003
16004
16005
16006
16007
16008
16009
16010
16011
16012
16013
16014
16015
16016
16017
16018
16019
16020
16021
16022
16023
16024
16025
16026
16027
16028
16029
16030
16031
16032
16033
16034
16035
16036
16037
16038
16039
16040
16041
16042
16043
16044
16045
16046
16047
16048
16049
16050
16051
16052
16053
16054
16055
16056
16057
16058
16059
16060
16061
16062
16063
16064
16065
16066
16067
16068
16069
16070
16071
16072
16073
16074
16075
16076
16077
16078
16079
16080
16081
16082
16083
16084
16085
16086
16087
16088
16089
16090
16091
16092
16093
16094
16095
16096
16097
16098
16099
16100
16101
16102
16103
16104
16105
16106
16107
16108
16109
16110
16111
16112
16113
16114
16115
16116
16117
16118
16119
16120
16121
16122
16123
16124
16125
16126
16127
16128
16129
16130
16131
16132
16133
16134
16135
16136
16137
16138
16139
16140
16141
16142
16143
16144
16145
16146
16147
16148
16149
16150
16151
16152
16153
16154
16155
16156
16157
16158
16159
16160
16161
16162
16163
16164
16165
16166
16167
16168
16169
16170
16171
16172
16173
16174
16175
16176
16177
16178
16179
16180
16181
16182
16183
16184
16185
16186
16187
16188
16189
16190
16191
16192
16193
16194
16195
16196
16197
16198
16199
16200
16201
16202
16203
16204
16205
16206
16207
16208
16209
16210
16211
16212
16213
16214
16215
16216
16217
16218
16219
16220
16221
16222
16223
16224
16225
16226
16227
16228
16229
16230
16231
16232
16233
16234
16235
16236
16237
16238
16239
16240
16241
16242
16243
16244
16245
16246
16247
16248
16249
16250
16251
16252
16253
16254
16255
16256
16257
16258
16259
16260
16261
16262
16263
16264
16265
16266
16267
16268
16269
16270
16271
16272
16273
16274
16275
16276
16277
16278
16279
16280
16281
16282
16283
16284
16285
16286
16287
16288
16289
16290
16291
16292
16293
16294
16295
16296
16297
16298
16299
16300
16301
16302
16303
16304
16305
16306
16307
16308
16309
16310
16311
16312
16313
16314
16315
16316
16317
16318
16319
16320
16321
16322
16323
16324
16325
16326
16327
16328
16329
16330
16331
16332
16333
16334
16335
16336
16337
16338
16339
16340
16341
16342
16343
16344
16345
16346
16347
16348
16349
16350
16351
16352
16353
16354
16355
16356
16357
16358
16359
16360
16361
16362
16363
16364
16365
16366
16367
16368
16369
16370
16371
16372
16373
16374
16375
16376
16377
16378
16379
16380
16381
16382
16383
16384
16385
16386
16387
16388
16389
16390
16391
16392
16393
16394
16395
16396
16397
16398
16399
16400
16401
16402
16403
16404
16405
16406
16407
16408
16409
16410
16411
16412
16413
16414
16415
16416
16417
16418
16419
16420
16421
16422
16423
16424
16425
16426
16427
16428
16429
16430
16431
16432
16433
16434
16435
16436
16437
16438
16439
16440
16441
16442
16443
16444
16445
16446
16447
16448
16449
16450
16451
16452
16453
16454
16455
16456
16457
16458
16459
16460
16461
16462
16463
16464
16465
16466
16467
16468
16469
16470
16471
16472
16473
16474
16475
16476
16477
16478
16479
16480
16481
16482
16483
16484
16485
16486
16487
16488
16489
16490
16491
16492
16493
16494
16495
16496
16497
16498
16499
16500
16501
16502
16503
16504
16505
16506
16507
16508
16509
16510
16511
16512
16513
16514
16515
16516
16517
16518
16519
16520
16521
16522
16523
16524
16525
16526
16527
16528
16529
16530
16531
16532
16533
16534
16535
16536
16537
16538
16539
16540
16541
16542
16543
16544
16545
16546
16547
16548
16549
16550
16551
16552
16553
16554
16555
16556
16557
16558
16559
16560
16561
16562
16563
16564
16565
16566
16567
16568
16569
16570
16571
16572
16573
16574
16575
16576
16577
16578
16579
16580
16581
16582
16583
16584
16585
16586
16587
16588
16589
16590
16591
16592
16593
16594
16595
16596
16597
16598
16599
16600
16601
16602
16603
16604
16605
16606
16607
16608
16609
16610
16611
16612
16613
16614
16615
16616
16617
16618
16619
16620
16621
16622
16623
16624
16625
16626
16627
16628
16629
16630
16631
16632
16633
16634
16635
16636
16637
16638
16639
16640
16641
16642
16643
16644
16645
16646
16647
16648
16649
16650
16651
16652
16653
16654
16655
16656
16657
16658
16659
16660
16661
16662
16663
16664
16665
16666
16667
16668
16669
16670
16671
16672
16673
16674
16675
16676
16677
16678
16679
16680
16681
16682
16683
16684
16685
16686
16687
16688
16689
16690
16691
16692
16693
16694
16695
16696
16697
16698
16699
16700
16701
16702
16703
16704
16705
16706
16707
16708
16709
16710
16711
16712
16713
16714
16715
16716
16717
16718
16719
16720
16721
16722
16723
16724
16725
16726
16727
16728
16729
16730
16731
16732
16733
16734
16735
16736
16737
16738
16739
16740
16741
16742
16743
16744
16745
16746
16747
16748
16749
16750
16751
16752
16753
16754
16755
16756
16757
16758
16759
16760
16761
16762
16763
16764
16765
16766
16767
16768
16769
16770
16771
16772
16773
16774
16775
16776
16777
16778
16779
16780
16781
16782
16783
16784
16785
16786
16787
16788
16789
16790
16791
16792
16793
16794
16795
16796
16797
16798
16799
16800
16801
16802
16803
16804
16805
16806
16807
16808
16809
16810
16811
16812
16813
16814
16815
16816
16817
16818
16819
16820
16821
16822
16823
16824
16825
16826
16827
16828
16829
16830
16831
16832
16833
16834
16835
16836
16837
16838
16839
16840
16841
16842
16843
16844
16845
16846
16847
16848
16849
16850
16851
16852
16853
16854
16855
16856
16857
16858
16859
16860
16861
16862
16863
16864
16865
16866
16867
16868
16869
16870
16871
16872
16873
16874
16875
16876
16877
16878
16879
16880
16881
16882
16883
16884
16885
16886
16887
16888
16889
16890
16891
16892
16893
16894
16895
16896
16897
16898
16899
16900
16901
16902
16903
16904
16905
16906
16907
16908
16909
16910
16911
16912
16913
16914
16915
16916
16917
16918
16919
16920
16921
16922
16923
16924
16925
16926
16927
16928
16929
16930
16931
16932
16933
16934
16935
16936
16937
16938
16939
16940
16941
16942
16943
16944
16945
16946
16947
16948
16949
16950
16951
16952
16953
16954
16955
16956
16957
16958
16959
16960
16961
16962
16963
16964
16965
16966
16967
16968
16969
16970
16971
16972
16973
16974
16975
16976
16977
16978
16979
16980
16981
16982
16983
16984
16985
16986
16987
16988
16989
16990
16991
16992
16993
16994
16995
16996
16997
16998
16999
17000
17001
17002
17003
17004
17005
17006
17007
17008
17009
17010
17011
17012
|
2011-06-27 Huang Dongsung <luxtella@company100.net>
Reviewed by Kenneth Rohde Christiansen.
TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
error.
https://bugs.webkit.org/show_bug.cgi?id=62422
REGRESSION(r77286): Remove bottomRight().
REGRESSION(r77312): Change the logic to get the bottom right point.
REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.
If the viewport width equals the contents width, especially in the mobile
device, TiledBackingStore endlessly creates and deletes the rightmost
column and bottom row of tiles.
In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
tiles infinitely.
Modified TiledDrawingAreaProxy also.
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::innerBottomRight):
(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::paint):
(WebKit::TiledDrawingAreaProxy::createTiles):
2011-06-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Build fix for building QtWebKit inside of Qt.
https://bugs.webkit.org/show_bug.cgi?id=62280
Remove CONFIG=staticlib, because it causes the configure script to add -lwebkit2
into QtWebKit.prl.
* WebKit2.pri:
2011-05-24 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
wkQTMovieResolvedURL.
2011-05-13 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
Video is blank, controller is misplaced on trailers.apple.com movie in fullscreen (with two screens)
https://bugs.webkit.org/show_bug.cgi?id=60826
Emit a notification when moving a CALayer from the WebProcess's main
layer host to a new context. This allows listeners to invalidate their
layers which may not support moving between different CAContexts (as is
the case with QTMovieLayer). In order to allow listeners to determine if they
are affected, the notification will pass the root CALayer in a userInfo
dictionary.
In WebFullScreenManagerMac, move from storing a pointer to a non-refcounted
class (GraphicsLayer) to a retainable class (PlatformLayer).
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): No need to initialize
m_fullScreenRootLayer now that it is a RetainPtr<>.
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Emit a notification
after either creating or destroying the full screen layer host.
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):
2011-05-09 Jeremy Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
https://bugs.webkit.org/show_bug.cgi?id=60496
When animating into and out of full screen, order out and back in the original webView window,
disabling animations when necessary. The beganExitFullScreenAnimation method was targeting the wrong window,
as the webView is hosted in the full screen window when we ask for it's parent window.
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController beganExitFullScreenAnimation]):
2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Module::load() should return true when g_module_open() returns a valid pointer
https://bugs.webkit.org/show_bug.cgi?id=60261
* Platform/gtk/ModuleGtk.cpp:
(WebKit::Module::load):
2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after r85808.
* Shared/NativeWebWheelEvent.h:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseScrollEvent):
2011-05-04 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::webView):
2011-05-04 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Send unhandled wheel events to parent window on Windows
https://bugs.webkit.org/show_bug.cgi?id=60220
Keep track of wheel events using NativeWebWheelEvent instead of WebWheelEvent in WebPageProxy
so we can send the native event to the parent window if WebKit doesn't handle it.
* UIProcess/API/mac/WKView.mm: Use NativeWebWheelEvent instead of WebWheelEvent.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::wheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Removed initialization of obsolete m_processingWheelEvent member variable.
(WebKit::coalesceWheelEvents): Use NativeWebWheelEvent instead of WebWheelEvent and add a note that this won't work if we ever enable MERGE_WHEEL_EVENTS.
(WebKit::WebPageProxy::handleWheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent, keep track of the current event in m_currentlyProcessedWheelEvent.
(WebKit::WebPageProxy::didReceiveEvent): Call wheelEventNotHandled() on Windows if wheel event is not handled.
(WebKit::WebPageProxy::processDidCrash): Clear out m_currentlyProcessedWheelEvent.
* UIProcess/WebPageProxy.h: Change handleWheelEvent() to take a NativeWebWheelEvent, added wheelEventNotHandled() on Windows, remove m_processingWheelEvent, add m_currentlyProcessedWheelEvent.
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::wheelEventNotHandled): Added.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::onWheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent.
2011-05-04 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Add bundle API for making a page paint as the background of another page
https://bugs.webkit.org/show_bug.cgi?id=60227
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetUnderlayPage):
Call WebPage::setUnderlayPage.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
Null out the underlay page.
(WebKit::WebPage::layoutIfNeeded):
Layout the underlay page if necessary.
(WebKit::WebPage::drawRect):
Draw the underlay page.
2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
https://bugs.webkit.org/show_bug.cgi?id=59462
* WebProcess.pro: Add Symbian OS capabilities to web process executable. Also enable
data paging flag and prevent application's icon from showing up in the application grid.
2011-05-04 Adam Roben <aroben@apple.com>
Clip and reposition windowed plugins when the UI process paints
This ensures that their geometry updates in sync with the rest of the page.
Most of this patch is just plumbing the scheduleWindowedPluginGeometryUpdate and
scheduleChildWindowGeometryUpdate calls through from NetscapePlugin all the way over to
WebView. I've tried to call out the other parts below.
Fixes <http://webkit.org/b/60210> <rdar://problem/8483441> REGRESSION (WebKit2): Windowed
plugins don't scroll at the same speed as the rest of the page
Reviewed by Darin Adler and Anders Carlsson.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::scheduleChildWindowGeometryUpdate):
Added plumbing.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::onPaintEvent): Update child windows before painting so that they will stay
in sync with the rest of the page.
(WebKit::WebView::scheduleChildWindowGeometryUpdate): Add this update information to the
set of geometries to update on the next paint.
(WebKit::setWindowRegion): Moved this helper function here from NetscapePluginWin.cpp.
(WebKit::WebView::updateChildWindowGeometries): Update the size, position, and clip rects of
all the child windows with scheduled geometry updates.
* UIProcess/win/WebView.h: Added new members to track and update child window geometries.
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformPostInitialize): Don't show the window immediately. Let the
UI process take care of it.
(WebKit::NetscapePlugin::platformGeometryDidChange): Don't update the window's position or
clip rect. Let the UI process take care of it.
* WebProcess/Plugins/PluginController.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate):
* WebProcess/Plugins/PluginView.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::scheduleChildWindowGeometryUpdate):
Added plumbing.
2011-05-04 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
WKView on Windows has no equivalent of Mac's -[WKView setDraws[Transparent]Background:]
https://bugs.webkit.org/show_bug.cgi?id=52009
<rdar://problem/8829746>
Add and implement WKViewSetDrawsTransparentBackground on windows.
* UIProcess/API/C/win/WKView.cpp:
(WKViewSetDrawsTransparentBackground):
(WKViewDrawsTransparentBackground):
Call through to the WebPageProxy object.
* UIProcess/API/C/win/WKView.h:
* UIProcess/win/WebView.cpp:
(WebKit::drawPageBackground):
Don't fill the rect with white if WebPageProxy::drawsBackground() or
WebPageProxy::drawsTransparentBackground() returns false. Because of limitations in Win32,
both drawsBackground and drawsTransparentBackground are pretty much equivalent.
(WebKit::WebView::paint):
Pass the WebPageProxy object to drawPageBackground.
2011-05-04 Tao Bai <michaelbai@chromium.org>
Reviewed by David Kilzer.
Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143
Respected the change of FrameLoaderClient.
Added WebIconURL and WebIconType responding the new IconURL and IconType.
Supported to get the multiple icon urls.
* Configurations/FeatureDefines.xcconfig:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidChangeIcons):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
2011-05-04 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Can't save a link from "Save Linked File to Download" popup menu
https://bugs.webkit.org/show_bug.cgi?id=60190
<rdar://problem/9367927>
Make sure that suggestedFilenameForResourceWithURL and resourceDataForFrame both look
in the cache if the resource can't be found in the current web page. This matches WebKit1.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::suggestedFilenameForResourceWithURL):
Call WebPage::cachedSuggestedFilenameForURL if we can't find a resource in the page.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::resourceDataForFrame):
Move code out from getResourceDataFromFrame.
(WebKit::WebPage::getResourceDataFromFrame):
Call resourceDataForFrame first and then cachedResponseDataForURL.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::platformCanHandleRequest):
(WebKit::WebPage::cachedSuggestedFilenameForURL):
(WebKit::WebPage::cachedResponseDataForURL):
Add stubs.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::cachedResponseForURL):
Add helper function.
(WebKit::WebPage::cachedSuggestedFilenameForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::cachedResponseDataForURL):
Call helper function.
* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::platformCanHandleRequest):
(WebKit::WebPage::cachedSuggestedFilenameForURL):
(WebKit::WebPage::cachedResponseDataForURL):
Add stubs.
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::cachedResponseForURL):
Add helper function.
(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::cachedSuggestedFilenameForURL):
(WebKit::WebPage::cachedResponseDataForURL):
Call helper function.
2011-05-04 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
WebKit2 flashes if entering and exiting compositing rapidly
https://bugs.webkit.org/show_bug.cgi?id=60198
If a page enters then immediately leaves compositing mode, the
DrawingAreaImpl would send a message to the UI process that it
had entered compositing even after all the layers had been torn
down. Fix this by never sending the 'enter' message if we're
waiting for the 'exit' timer to fire.
Also fix an assertion in the UI process caused by sending mismatched
'enter' and 'leave' messages by keeping track of which messages
we've sent.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon):
* WebProcess/WebPage/DrawingAreaImpl.h:
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingModePending):
2011-05-04 Jeff Miller <jeffm@apple.com>
Fix typo in svn property in r85756.
* Shared/mac/NativeWebWheelEventMac.mm: Added property svn:eol-style. Removed property snv:eol-style.
2011-05-04 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Add NativeWebWheelEvent class
https://bugs.webkit.org/show_bug.cgi?id=60182
This will be needed soon when we start notifying the UI process that a mouse wheel event wasn't handled by WebKit.
* GNUmakefile.am: Added NativeWebWheelEventGtk.cpp and NativeWebWheelEvent.h.
* Shared/NativeWebWheelEvent.h: Added.
(WebKit::NativeWebWheelEvent::nativeEvent): Added.
* Shared/gtk/NativeWebWheelEventGtk.cpp: Added.
(WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
* Shared/mac/NativeWebWheelEventMac.mm: Added.
(WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
* Shared/qt/NativeWebWheelEventQt.cpp: Added.
(WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
* Shared/win/NativeWebWheelEventWin.cpp: Added.
(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):Added.
* WebKit2.pro: Added NativeWebWheelEventQt.cpp and NativeWebWheelEvent.h.
* WebKit2.xcodeproj/project.pbxproj: Added NativeWebWheelEventMac.mm and NativeWebWheelEvent.h.
* win/WebKit2.vcproj: Added NativeWebWheelEventWin.cpp and NativeWebWheelEvent.h.
2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Anders Carlsson.
ArgumentDecoder should use aligned memory for its internal copy of data
https://bugs.webkit.org/show_bug.cgi?id=59960
Since we check for memory alignment when unpacking primitive types from the buffer,
insure alignment of the base address.
As uint64_t is the largest type we use in Argument encoder/decoder, use 8 byte alignment.
* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::~ArgumentDecoder): free m_alignedBase
(CoreIPC::roundUpToAlignment): move this up in the source file
(CoreIPC::ArgumentDecoder::initialize): m_buffer is now guaranteed sizeof(uint64_t) aligned
* Platform/CoreIPC/ArgumentDecoder.h: add m_alignedBase member which needs to be freed in d'tor
2011-05-04 Adam Roben <aroben@apple.com>
Make ShareableBitmap::makeCGImageCopy use a copy-on-write copy on Windows when possible
Fixes <http://webkit.org/b/57269> <rdar://problem/9198788> REGRESSION (r82151): Every WKView
paint now makes an extra copy of the painted bits
Reviewed by Anders Carlsson.
* Platform/SharedMemory.h:
* Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::createCopyOnWriteCopy):
Added this new function. Creates a copy-on-write copy of the first |size| bytes of the
original SharedMemory.
* Shared/ShareableBitmap.h: Added createCGImage helper function.
* Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::makeCGImageCopy): Don't compile this version of this function on
Windows; we'll provide our own implementation since CGBitmapContextCreateImage isn't smart
enough to make a copy-on-write copy on Windows.
(WebKit::ShareableBitmap::makeCGImage): Moved some code from here...
(WebKit::ShareableBitmap::createCGImage): ...to this new function.
* Shared/cg/win/ShareableBitmapCGWin.cpp: Added.
(WebKit::derefSharedMemory): This function is called when the CGDataProvider is finalized.
All we have to do is deref the SharedMemory that was backing the CGDataProvider.
(WebKit::ShareableBitmap::makeCGImageCopy): Create a copy-on-write copy of the image data
when possible. We use the copy-on-write copy to back this ShareableBitmap from here on out,
and use the original SharedMemory to back the CGImage. This should prevent future
modifications to the ShareableBitmap from affecting the CGImage. If we can't make a
copy-on-write copy, we fall back to just copying the data normally.
* win/WebKit2.vcproj: Added ShareableBitmapCGWin.cpp.
2011-05-04 Adam Roben <aroben@apple.com>
Let transparent windowless plugins draw into a graphics context with an alpha channel
Fixes <http://webkit.org/b/57647> <rdar://problem/9168462> Flash plugins with
wmode=transparent have black (instead of transparent) background in WebKit2 on Windows
I had trouble writing a test case for this, so I split that task out into
<http://webkit.org/b/60169>.
Reviewed by Sam Weinig.
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformPaint): Give the graphics context an alpha channel if this
is a transparent windowless plugin.
2011-05-03 Adam Roben <aroben@apple.com>
Remove WebPageProxy::setDrawingArea
It is unused. It also does a useless equality comparison between OwnPtrs; if they are equal,
we've already lost.
Reviewed by Anders Carlsson and Antti Koivisto.
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
Removed setDrawingArea.
(WebKit::WebPageProxy::drawingArea):
(WebKit::WebPageProxy::backForwardList):
Made these functions const while I was at it.
2011-05-03 Pratik Solanki <psolanki@apple.com>
Reviewed by Antti Koivisto.
Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836
Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one.
* WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
2011-05-02 Jer Noble <jer.noble@apple.com>
Reviewed by Adam Roben.
Implement FULLSCREEN_API on Windows, Part 3: WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59845
Implement a similar full screen mode to WebKit; Re-use the same
full screen window class used in WebKit in the new WebFullScreenController.
No animations (yet), so many of the stubs remain unimplemented.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::onKeyEvent): Handle VK_ESCAPE and cancel full screen
mode if caught.
(WebKit::WebView::fullScreenController): Lazily instantiate m_fullScreenController.
(WebKit::WebView::fullScreenClientWindow): Added accessor.
(WebKit::WebView::fullScreenClientParentWindow): Ditto.
(WebKit::WebView::fullScreenClientSetParentWindow): Ditto.
(WebKit::WebView::fullScreenClientWillEnterFullScreen): Pass through to WebFullScreenManagerProxy.
(WebKit::WebView::fullScreenClientDidEnterFullScreen): Ditto.
(WebKit::WebView::fullScreenClientWillExitFullScreen): Ditto.
(WebKit::WebView::fullScreenClientDidExitFullScreen): Ditto.
* UIProcess/win/WebView.h:
* UIProcess/win/WebFullScreenManagerProxyWin.cpp:
(WebKit::WebFullScreenManagerProxy::enterFullScreen): Pass through to
WebFullScreenController.
(WebKit::WebFullScreenManagerProxy::exitFullScreen): Ditto.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::onKeyEvent): Handle the escape key and exit
full screen mode when detected.
(WebKit::WebView::fullScreenWindowController): Added.
* UIProcess/win/WebView.h:
* WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp:
(WebKit::WebFullScreenManagerWin::~WebFullScreenManagerWin):
(WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Host the root
full screen layer if it gets detached.
* WebProcess/FullScreen/win/WebFullScreenManagerWin.h:
* win/WebKit2.vcproj:
2011-05-03 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
WK2 Icon Database should provide access to all image representations in the icon.
Expose a CFArrayRef of CGImageRefs as API for CG platforms:
* UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
(WKIconDatabaseTryCopyCGImageArrayForURL):
* UIProcess/API/C/cg/WKIconDatabaseCG.h:
2011-05-03 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
WebKit2 should treat API calls that start/stop loads as user gestures for responsiveness timer
https://bugs.webkit.org/show_bug.cgi?id=60083
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::tryClose):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::stopLoading):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
Start responsiveness timer for load start/stop and close.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::SendStopResponsivenessTimer::SendStopResponsivenessTimer):
(WebKit::SendStopResponsivenessTimer::~SendStopResponsivenessTimer):
Add simple RAII class to ensure the StopResponsivenessTimer is called.
(WebKit::WebPage::tryClose):
(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::loadData):
(WebKit::WebPage::stopLoading):
(WebKit::WebPage::reload):
(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
Sends a message back to the UIProcess to indicate the WebProcess
is still responsive.
2011-05-03 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/9250444> Enter key doesn't work in a web text field (but Return key does)
No test at this time because the WebKit2 eventSender doesn't use this code path.
* Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebKeyboardEvent): Copied the code to special-case certain
keys from the corresponding Mac WebKit1 code path.
2011-05-03 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Unreachable URL is lost when canceling load of a new page
https://bugs.webkit.org/show_bug.cgi?id=60057
<rdar://problem/9049135>
When setting the unreachable URL in the WebFrameProxy, keep track of any previous unreachable URL
so we can restore it if the page load fails.
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didFailProvisionalLoad): Restore m_unreachableURL to previous value.
(WebKit::WebFrameProxy::setUnreachableURL): Keep track of previous unreachable URL in m_lastUnreachableURL.
* UIProcess/WebFrameProxy.h: Moved setUnreachableURL() implementation to .cpp file, added m_lastUnreachableURL.
2011-05-03 Adam Roben <aroben@apple.com>
Fix most strict PassOwnPtr violations on Windows
Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
enabled
Reviewed by Anders Carlsson.
* Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::writeEventHandler): Use nullptr.
2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Dimitri Glazkov.
Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Added #include for ShadowRoot.h.
2011-05-03 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
More quarantine related sandbox denial when downloading files
<rdar://problem/9362626>
* WebProcess/com.apple.WebProcess.sb:
2011-05-02 Adam Roben <aroben@apple.com>
Take advantage of implicit conversion from nullptr_t to PassOwnPtr
Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
doesn't work, but should
Reviewed by Adam Barth.
* Platform/CoreIPC/Connection.cpp:
* UIProcess/qt/WebContextMenuProxyQt.cpp:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
* WebProcess/WebPage/DrawingArea.cpp:
2011-05-03 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Eric Seidel.
[GTK] Build webkit1 even when webkit2 is enabled
https://bugs.webkit.org/show_bug.cgi?id=59695
* GNUmakefile.am:
2011-05-02 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] White screen displays when using MiniBrowser with DrawingAreaImpl
https://bugs.webkit.org/show_bug.cgi?id=60003
When using DrawingAreaImpl, we need to properly pass the viewSize to the WebPage.
Otherwise, the dirty rect will always be empty and we will not draw.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::viewSize):
2011-05-02 Anders Carlsson <andersca@apple.com>
Fix crash that was introduced in r85515.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchSyncMessage):
If didReceiveSyncMessage returns ManualReply, the client took ownership of the reply
encoder so we must leak it to avoid a double-free.
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
The web process locks up when the plug-in process crashes
https://bugs.webkit.org/show_bug.cgi?id=59999
<rdar://problem/8889303>
Add a hash map from plug-in paths to CoreIPC connections to PluginProcessConnectionManager.
Add PluginProcessConnectionManager::pluginProcessCrashed and make it look up the corresponding
CoreIPC connection and call postConnectionDidCloseOnConnectionWorkQueue on it.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
* Platform/CoreIPC/Connection.h:
* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
(WebKit::PluginProcessConnectionManager::removePluginProcessConnection):
(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):
* WebProcess/Plugins/PluginProcessConnectionManager.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::pluginProcessCrashed):
2011-05-02 Anders Carlsson <andersca@apple.com>
Try to fix Windows build.
* Scripts/webkit2/messages.py:
* Scripts/webkit2/messages_unittest.py:
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
Dispatch the PluginProcessCrashed on the connection work queue
https://bugs.webkit.org/show_bug.cgi?id=59996
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initialize):
Add the web process as a queue client.
(WebKit::WebProcess::terminate):
Remove the web process as a queue client.
(WebKit::WebProcess::willProcessMessageOnClientRunLoop):
Try calling willProcessWebProcessMessageOnClientRunLoop.
* WebProcess/WebProcess.messages.in:
Add the DispatchOnConnectionQueue attribute to PluginProcessCrashed.
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Send a PluginProcessCrashed message to all web processes when a plug-in crashes
https://bugs.webkit.org/show_bug.cgi?id=59994
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didClose):
Iterate over all contexts and send PluginProcessCrashed to all web processes in each context.
(WebKit::PluginProcessProxy::didFinishLaunching):
Call setShouldCloseConnectionOnMachExceptions on the CoreIPC connection.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::pluginProcessCrashed):
Add empty stub.
* WebProcess/WebProcess.messages.in:
Add message.
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Plug-in not completely repainted after a crash
https://bugs.webkit.org/show_bug.cgi?id=59991
Call Widget::invalidate().
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginProcessCrashed):
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Make PluginProcessConnectionManager a member of WebProcess
https://bugs.webkit.org/show_bug.cgi?id=59989
* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
* WebProcess/Plugins/PluginProcessConnectionManager.h:
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
* WebProcess/WebProcess.h:
(WebKit::WebProcess::pluginProcessConnectionManager):
2011-05-02 Mark Rowe <mrowe@apple.com>
Reviewed by Brady Eidson.
<rdar://problem/9371289> WebKit2 can persist an invalid current back/forward item index when URLs are filtered from back/forward list
* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation): We need to update the current index to account for filtered items
for all items before the current item in the array.
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Handle DispatchOnConnectionQueue for asynchronous messages
https://bugs.webkit.org/show_bug.cgi?id=59959
If any asynchronous messages have the DispatchOnConnectionQueue attribute,
create a new willProcess{Receiver}MessageOnClientRunLoop.
* Scripts/webkit2/messages.py:
- Fix a regex bug where we would only parse attributes on synchronous messages.
- Collect messages with the dispatch_on_connection_queue flag set. We only handle
asynchronous messages currently; sync message support will be added when/if the
need arises.
* Scripts/webkit2/messages_unittest.py:
Update test.
2011-05-02 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59924
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::waitForSyncReply):
(CoreIPC::Connection::dispatchSyncMessage):
* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::Message::releaseArguments):
- The memory management for this class is very strange. I wrote a
large comment. Hopefully a kind soul will come by and fix it.
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::unload):
* UIProcess/API/mac/WKView.mm:
(-[WKView _setFindIndicator:fadeOut:]):
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::toStringVector):
* WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::stop):
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
2011-04-29 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Pages with accelerated compositing do not redraw unless scrolled
https://bugs.webkit.org/show_bug.cgi?id=59851
Added a setNeedDisplay on the non-composited content layer after
the size is changed so it paints the full size of the layer. Called
only for the areas newly exposed, if any.
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::sizeDidChange):
2011-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Need a way to handle CoreIPC messages on the connection work queue
https://bugs.webkit.org/show_bug.cgi?id=59954
Add a Connection::QueueClient abstract class. This class has a single pure virtual
member function, willProcessMessageOnClientRunLoop which should return true if the message
should be forwarded to the next Connection::QueueClient in the list or Connection::Client's
run loop for processing and false otherwise. Users of Connection can use addQueueClient to
add clients and all messages will be dispatched to the queue clients first.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::addQueueClient):
(CoreIPC::Connection::removeQueueClient):
(CoreIPC::Connection::processIncomingMessage):
* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::QueueClient::~QueueClient):
2011-05-02 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
WebKit2 thinks the web process is unresponsive when a plugin displays a context menu
https://bugs.webkit.org/show_bug.cgi?id=59124
<rdar://problem/9318600>
This is the Windows version of <https://bugs.webkit.org/show_bug.cgi?id=58943>.
Since we have no control over how long a plugin will take to handle an event, we need
to tell the UI process to stop its responsive timer when we're about to send an event
to the plugin. The downside of doing this is that if the plugin does become unresponsive,
the user won't know this immediately until they click on the web page again. At that point,
if the web process is unresponsive because of a hung plugin, the responsiveness timer will fire.
We're only doing this on Windows currently when running plugins in the web process (Anders fixed
bug 58943 in a different way when running plugins in a separate plugin process on the Mac).
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::willSendEventToPlugin): Added, not used when running plugins in a separate process.
* PluginProcess/PluginControllerProxy.h: Added willSendEventToPlugin().
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::stopResponsivenessTimer): Added.
* UIProcess/WebPageProxy.h: Added stopResponsivenessTimer().
* UIProcess/WebPageProxy.messages.in: Added StopResponsivenessTimer message.
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformPaint): Tell our controller when we're about to send an event to the plugin.
(WebKit::NetscapePlugin::platformHandleMouseEvent): Ditto.
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent): Ditto.
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): Ditto.
* WebProcess/Plugins/PluginController.h: Added willSendEventToPlugin().
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::willSendEventToPlugin): Added, tell the UI process to stop its responsiveness timer.
* WebProcess/Plugins/PluginView.h: Added willSendEventToPlugin().
2011-04-29 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej Stachowiak.
Plug-in failed to initialize message should be called when Java fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=59856
To match the WebKit1 behavior, WebKit2 should dispatch the plug-in failed
to initialize message when we can't instantiate the Java plug-in.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
2011-05-02 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Prune some #includes from DOMWindow.h
https://bugs.webkit.org/show_bug.cgi?id=59907
* WebProcess/WebPage/WebFrame.cpp:
Add now missing SecurityOrigin.h #include.
2011-04-29 Brian Weinstein <bweinstein@apple.com>
Reviewed by Dan Bernstein.
WebKit2: Crash closing tab with docked Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59914
<rdar://problem/9359672>
When a tab is closed with a docked inspector, invalidate called platformClose, which
didn't do the tear down that is needed, but is called when we close the web inspector explcitly.
One part of tear down we weren't doing is removing ourselves as a WindowMessageBrodcaster listener
on the inspected web view, and this can cause crashes.
This patch also renames platformClose to platformDidClose, to be clearer about when the function
is called.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::invalidate): Call didClose instead of platformClose.
(WebKit::WebInspectorProxy::didClose): Call platformDidClose instead of platformClose.
* UIProcess/WebInspectorProxy.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformDidClose): Renamed from platformClose.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformDidClose): Ditto.
* UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::platformDidClose): Ditto.
* UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformDidClose): Ditto.
2011-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Prune some unnecessary #includes
https://bugs.webkit.org/show_bug.cgi?id=59895
Start getting rid of unnecessary #includes and forward declares.
* WebProcess/Plugins/PluginView.cpp:
* WebProcess/WebPage/WebPage.cpp:
2011-05-01 Patrick Gansterer <paroga@webkit.org>
[WIN] Unreviewed buildfix after r85434.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::startDragDrop):
* UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
* WebProcess/WebCoreSupport/win/WebDragClientWin.cpp:
(WebKit::WebDragClient::startDrag):
* WebProcess/WebPage/win/ChunkedUpdateDrawingAreaWin.cpp:
(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
2011-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Can't open document from skydrive.com in Microsoft Word
https://bugs.webkit.org/show_bug.cgi?id=59891
<rdar://problem/9354285>
Add the AllowHalfBakedQuickDrawSupport quirk for the SharePoint plug-in.
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::determineQuirks):
2011-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Don't try to create a backing store for a 0x0 plug-in
https://bugs.webkit.org/show_bug.cgi?id=59887
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
2011-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Sandbox violation by WebProcess for DownloadAssessment.plist
https://bugs.webkit.org/show_bug.cgi?id=59879
<rdar://problem/9326041>
* WebProcess/com.apple.WebProcess.sb:
Allow reading ~/Library/Preferences/com.apple.DownloadAssessment.plist
2011-05-01 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
Remove unnecessary keychain and CoreAudio debris from WebProcess sandbox
https://bugs.webkit.org/show_bug.cgi?id=59873
These rules have been obsoleted by <rdar://problem/9301520> and
<rdar://problem/9181468>.
* WebProcess/com.apple.WebProcess.sb:
2011-05-01 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
Simplify WebProcess sandbox with homedir-relative path filters.
https://bugs.webkit.org/show_bug.cgi?id=59872
* WebProcess/com.apple.WebProcess.sb:
2011-05-01 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
On-demand VPN support for sandboxed WebProcess.
<rdar://problem/8994181>
* WebProcess/com.apple.WebProcess.sb:
2011-04-30 Ivan Krstić <ike@apple.com>
Reviewed by Sam Weinig.
Reindent WebProcess sandbox to standard scheme style
https://bugs.webkit.org/show_bug.cgi?id=59870
* WebProcess/com.apple.WebProcess.sb:
2011-04-28 Jer Noble <jer.noble@apple.com>
Reviewed by Jon Honeycutt.
Implement FULLSCREEN_API on Windows, Part 1: Stubs
https://bugs.webkit.org/show_bug.cgi?id=59778
Add Windows specific stubs for WebKit2 full screen APIs.
* UIProcess/win/WebFullScreenManagerProxyWin.cpp: Added.
(WebKit::WebFullScreenManagerProxy::enterFullScreen): Added stub.
(WebKit::WebFullScreenManagerProxy::exitFullScreen): Added stub.
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation): Added stub.
(WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation): Added stub.
(WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation): Added stub.
(WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation): Added stub.
(WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode): Added stub.
(WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode): Added stub.
(WebKit::WebFullScreenManagerProxy::getFullScreenRect): Added stub.
* WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp: Added.
(WebKit::WebFullScreenManager::create): Added. Returns a WebFullScreenManagerWin.
(WebKit::WebFullScreenManagerWin::create): Added.
(WebKit::WebFullScreenManagerWin::WebFullScreenManagerWin): Added.
(WebKit::WebFullScreenManagerWin::~WebFullScreenManagerWin): Added.
(WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Added stub.
(WebKit::WebFullScreenManagerWin::beginEnterFullScreenAnimation): Added stub.
(WebKit::WebFullScreenManagerWin::beginExitFullScreenAnimation): Added stub.
* WebProcess/FullScreen/win/WebFullScreenManagerWin.h: Added.
* win/WebKit2.vcproj: Added new classes.
2011-04-29 Alexey Proskuryakov <ap@apple.com>
Reviewed by Simon Fraser and Dan Bernstein.
WebKit2: WebPluginTypeEnabled key is ignored when enumerating plug-ins
https://bugs.webkit.org/show_bug.cgi?id=59852
<rdar://problem/9314011>
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromPropertyLists): Do what WebKit1 does (but in CF dialect). And yes,
I've seen plists with both numbers and booleans used .
2011-04-29 Beth Dakin <bdakin@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=59846
Scrolling causes rounded bottom window corners to become square
<rdar://problem/9234239>
Keep track of the m_windowBottomCornerIntersectionRect in WKView.
Invalidate the rect before scrolling. And if the rect is non-zero during a
display, mask the corners, then set the rect to zero so that only displays that
happen right after a scroll bother to do this.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::scrollView):
* UIProcess/API/mac/WKView.mm:
(-[WKView displayIfNeeded]):
(-[WKView _cacheWindowBottomCornerRect]):
* UIProcess/API/mac/WKViewInternal.h:
2011-04-29 Jia Pu <jpu@apple.com>
Reviewed by Sam Weinig.
[Mac] Scrolling WK2 window should dismiss autocorrection panel.
https://bugs.webkit.org/show_bug.cgi?id=59809
<rdar://problem/9317410>
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::pageDidScroll): Dimiss autocorrection panel in this function.
2011-04-29 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
WebKit2: Typing with Input methods still enters Roman characters in Safari search field frequently
https://bugs.webkit.org/show_bug.cgi?id=59829
<rdar://problem/9336907>
This patch regresses behavior somewhat in that inline input isn't discarded when something
happens in an inactive window. This doesn't work well in shipping Safari either.
* UIProcess/API/mac/WKView.mm:
(-[WKView _notifyInputContextAboutDiscardedComposition]): Added a method that calls
-discardMarkedText with a safety check.
(-[WKView setMarkedText:selectedRange:replacementRange:]): Use it.
(-[WKView _updateTextInputStateIncludingSecureInputState:]): Use it.
(-[WKView _resetTextInputState]): Use it.
2011-04-29 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
AX: Remote accessibility should build on snow leopard
https://bugs.webkit.org/show_bug.cgi?id=59767
* UIProcess/API/mac/WKView.mm:
(-[WKView _updateRemoteAccessibilityRegistration:]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _setAccessibilityWebProcessToken:]):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::registerUIProcessAccessibilityTokens):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
2011-04-29 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Add protection for shared memory failing to allocate
<rdar://problem/9125287>
https://bugs.webkit.org/show_bug.cgi?id=59842
* Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::create):
Add logging in shared memory failure cases.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
Guard against ShareableBitmap failing to create a shared memory
backing.
2011-04-28 Stephanie Lewis <slewis@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=59776
<rdar://problem/9287113> REGRESSION: Safari cold/warm launch time 15% to 2x regression
On the first draw the WebProcess is just going to send us blank bits anyway so don't
pause waiting for the update. Continue drawing a blank window until the WebProcess
sends us the update.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::paint):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
* UIProcess/DrawingAreaProxyImpl.h:
2011-04-29 Jon Lee <jonlee@apple.com>
Reviewed by mitzpettel.
REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs (59721)
<rdar://problem/9327332>
https://bugs.webkit.org/show_bug.cgi?id=59721
When resigning first responder status, check to see if we need to maintain an inactive
selection in the web view. If we don't, we clear the selection.
This also reverts the change made in 83814, since that was a different attempt to solve this same issue.
* UIProcess/API/C/WKPage.cpp:
(WKPageSetMaintainsInactiveSelection): Export setMaintainsInactiveSelection()
* UIProcess/API/C/WKPage.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView resignFirstResponder]): Check and see if we need to maintain the selection in the view prior to resigning.
If not, we clear the selection
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::clearSelection): Send message across process boundary
(WebKit::WebPageProxy::setMaintainsInactiveSelection): Sets variable
* UIProcess/WebPageProxy.h: New member variable to keep track of whether we need to maintain the current selection
(WebKit::WebPageProxy::maintainsInactiveSelection): Returns variable
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setFocused): Reverting code to just set the focused bit instead of also clearing the selection
(WebKit::WebPage::clearSelection):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: add new ClearSelection() message
2011-04-29 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Application cache doesn't work due to a sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=59818
<rdar://problem/9346971>
Add a sandbox extension for the application cache directory.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
Encode and decode the sandbox extension handle.
* Shared/WebProcessCreationParameters.h:
Add a applicationCacheDirectoryExtensionHandle member.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
If we have a non-empty application cache directory, create a sandbox extension
and pass it to the creation parameters.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Create and consume a sandbox extension.
* WebProcess/WebProcess.h:
Add an m_applicationCachePathExtension member variable.
2011-04-29 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
Add ENABLE macro for WebKitAnimation
https://bugs.webkit.org/show_bug.cgi?id=59729
Add new feature to toggle WebKit Animation API.
* Configurations/FeatureDefines.xcconfig:
2011-04-29 Anders Carlsson <andersca@apple.com>
Reviewed by Brian Weinstein.
Crash when closing a tab that is unresponsive
https://bugs.webkit.org/show_bug.cgi?id=59810
<rdar://problem/9329133>
Back out r84643 - there was no rationale for this change, and it's causing crashes.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
2011-04-29 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Rename page as pageProxy in WebKitWebViewBase
https://bugs.webkit.org/show_bug.cgi?id=59790
To avoid consufion between page client and page proxy. Also rename
some methods to webkitWebViewBase* for consistency.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseFinalize):
(webkitWebViewBaseExpose):
(webkitWebViewBaseDraw):
(webkitWebViewBaseSizeAllocate):
(webkitWebViewBaseFocusInEvent):
(webkitWebViewBaseFocusOutEvent):
(webkitWebViewBaseKeyPressEvent):
(webkitWebViewBaseKeyReleaseEvent):
(webkitWebViewBaseButtonPressEvent):
(webkitWebViewBaseButtonReleaseEvent):
(webkitWebViewBaseScrollEvent):
(webkitWebViewBaseMotionNotifyEvent):
(webkit_web_view_base_class_init):
(webkitWebViewBaseCreate):
(webkitWebViewBaseGetPage):
2011-04-29 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix a crash after r85214.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_init): Add line to create the page client
instance, removed by mistake in r85214.
2011-04-28 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
Remove IMAGE_RESIZER related code.
https://bugs.webkit.org/show_bug.cgi?id=59735
* Configurations/FeatureDefines.xcconfig:
2011-04-28 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Original patch by Austin Jennings.
<rdar://problem/9350288>
Update sandbox profile for extension changes
* WebProcess/com.apple.WebProcess.sb:
2011-04-28 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Right-clicking on a Flash movie in an iframe shows the browser context menu
https://bugs.webkit.org/show_bug.cgi?id=59760
<rdar://problem/9340541>
Move context menu event handling out into a separate function. Make sure to call
EventHandler::sendContextMenuEvent on the event handler belonging to the frame of the
node that was clicked, and not the main frame.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::handleContextMenuEvent):
(WebKit::handleMouseEvent):
2011-04-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678
Remove WML-related code in WebKit2.
* Configurations/FeatureDefines.xcconfig:
* WebProcess/WebPage/WebBackForwardListProxy.cpp:
* WebProcess/WebPage/WebBackForwardListProxy.h:
2011-04-28 Alexey Proskuryakov <ap@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Frequent crashes in acceptsFirstMouse
https://bugs.webkit.org/show_bug.cgi?id=59746
<rdar://problem/9281270>
The crash occurred when connection was null (and it can become null at any time).
Added checks for the proxy being valid in all sync calls that lacked such.
WebPageProxy::isValid() is not the same as WebProcessProxy::isValid(), but existing checks
looked at the former, so I used that.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::firstRectForCharacterInSelectedRange):
(WebKit::WebPageProxy::getSelectedText):
(WebKit::WebPageProxy::gestureWillBegin):
(WebKit::WebPageProxy::createSnapshotOfVisibleContent):
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::confirmCompositionWithoutDisturbingSelection):
(WebKit::WebPageProxy::insertText):
(WebKit::WebPageProxy::getMarkedRange):
(WebKit::WebPageProxy::getSelectedRange):
(WebKit::WebPageProxy::getAttributedSubstringFromRange):
(WebKit::WebPageProxy::characterIndexForPoint):
(WebKit::WebPageProxy::firstRectForCharacterRange):
(WebKit::WebPageProxy::executeKeypressCommands):
(WebKit::WebPageProxy::writeSelectionToPasteboard):
(WebKit::WebPageProxy::readSelectionFromPasteboard):
(WebKit::WebPageProxy::shouldDelayWindowOrderingForEvent):
(WebKit::WebPageProxy::acceptsFirstMouse):
2011-04-27 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
Mac side of: WebKit2: Support docked mode for Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59134
<rdar://problem/8739005>
Implement docking of the Web Inspector on Mac. This matches the Windows (WK1 and WK2) closely,
where the inspector and the inspected view are siblings.
* UIProcess/API/C/mac: Added.
* UIProcess/API/C/mac/WKInspectorMac.h: Added.
* UIProcess/API/mac/PageClientImpl.h:
(WebKit::PageClientImpl::wkView): Returns the WKView.
* UIProcess/PageClient.h:
* UIProcess/WebInspectorProxy.h: The inspected view is now a WebInspectorWKView, so we can override tag.
* UIProcess/WebPageProxy.h: Added a getter for the WKView.
* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]): Calls through to WebInspectorProxy::inspectedViewFrameDidChange.
(-[WebInspectorWKView tag]): Returns a constant defined in WKInspectorMac.h.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create a WebInspectorWKView instead of a WKView.
(WebKit::WebInspectorProxy::platformClose): Removed a FIXME that isn't needed anymore (we always detach before closing).
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Place our inspector and the inspected view next to each other, assuming the
bottom of the inspector is at the Y origin.
(WebKit::WebInspectorProxy::platformAttach): Listen for changes to the inspected view's frame, and move the inspectorView from the
detached inspector window to the superview of the inspected view (to make the inspector and inspected view siblings).
(WebKit::WebInspectorProxy::platformDetach): Stop listening for changes to the inspected view's frame, and move the inspectorView
back to the detached inspector window. We also resize the inspected view to take up the space the inspector took up before
(assuming the bottom of the inspector was at the Y origin).
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Resize the inspector's view, and call inspectedViewFrameDidChange (which
syncs the inspector and the inspected view), and call setNeedsDisplay on both views.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::wkView):
* WebKit2.xcodeproj/project.pbxproj: Add a new file.
2011-04-28 Jessie Berlin <jberlin@apple.com>
Reviewed by Darin Adler.
Crash under WKPageCreateSnapshotOfVisibleContent if there is no response from the Web Process
in the allotted time.
https://bugs.webkit.org/show_bug.cgi?id=59738
If the handle is null, don't try to create a ShareableBitmap and then a WebImage out of it.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createSnapshotOfVisibleContent):
2011-04-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] Split JSC and WebCore builds
https://bugs.webkit.org/show_bug.cgi?id=19428
Build JavaScriptCore as a libtool shared library instead of a
private convenience library.
* GNUmakefile.am: adapt to new name for javascriptcore target.
2011-04-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8773946> and https://bugs.webkit.org/show_bug.cgi?id=59614
Client certificate authentication in WebKit2
Project-file stuff:
* WebKit2.xcodeproj/project.pbxproj:
Allow WKCredentials to store certificates:
* UIProcess/Authentication/WebCredential.cpp:
(WebKit::WebCredential::WebCredential):
(WebKit::WebCredential::certificateInfo):
* UIProcess/Authentication/WebCredential.h:
(WebKit::WebCredential::create):
* UIProcess/API/C/WKCredential.cpp:
(WKCredentialCreateWithCertificateInfo):
* UIProcess/API/C/WKCredential.h:
Pass the certificate info over the wire to the WebProcess:
* UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::useCredential):
Change the WebProcess to prefer certificate info over basic credentials when responding to a challenge:
* WebProcess/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge): Stub for platforms other than Mac,
as only Mac can currently respond to challenges with certificates.
(WebKit::AuthenticationManager::useCredentialForChallenge):
* WebProcess/Authentication/AuthenticationManager.h:
* WebProcess/Authentication/AuthenticationManager.messages.in:
* WebProcess/Authentication/mac: Added.
* WebProcess/Authentication/mac/AuthenticationManager.mac.mm: Added.
(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge): Recreate the identity and certificate
chain and respond to the challenge with it.
Add a newly required #include:
* UIProcess/API/C/WKAuthenticationChallenge.cpp:
* UIProcess/Authentication/AuthenticationDecisionListener.cpp:
2011-04-28 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Click counting logic should be shared between WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59715
Use the GtkClickCounter instead of doing click counting manually. This means that
the code will now be shared between WebKit1 and WebKit2.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_init): Remove private member initialization.
(webViewButtonPressEvent): Call into GtkClickCounter.
2011-04-28 Martin Robinson <mrobinson@igalia.com>
Build fix after r85197.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webViewExpose): Use cr.get() here.
(webViewDraw): Small clean up.
2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Sam Weinig.
[GTK] Remove WKURLCreateWithURL()
https://bugs.webkit.org/show_bug.cgi?id=59691
The name is a bit confusing and there's already
WKURLCreateWithUTF8CString() in the C API.
* UIProcess/API/C/gtk/WKView.cpp:
* UIProcess/API/C/gtk/WKView.h:
2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Make WebKitWebViewBase public in the API
https://bugs.webkit.org/show_bug.cgi?id=59689
Add WebKitWebViewBasePrivate.h and move WebKitWebViewBase inernal
methods to it. Rename get_type() method, since it's part of the
public API and should follow gtk coding style.
* GNUmakefile.am: Add WebKitWebViewBasePrivate.h.
* UIProcess/API/C/gtk/WKView.cpp: Use WebKitWebViewBasePrivate.h.
* UIProcess/API/gtk/PageClientImpl.cpp: Ditto.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseFinalize):
(webkit_web_view_base_init):
(webViewSizeAllocate):
(webViewFocusInEvent):
(webViewFocusOutEvent):
(webViewKeyPressEvent):
(webViewKeyReleaseEvent):
(webkit_web_view_base_class_init):
* UIProcess/API/gtk/WebKitWebViewBase.h:
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Copied from Source/WebKit2/UIProcess/API/C/gtk/WKView.cpp.
* UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Use WebKitWebViewBasePrivate.h.
2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Move WebView to UIProcess/API/gtk
https://bugs.webkit.org/show_bug.cgi?id=59686
And rename it as PageClientImpl, since it's a page client
implementation, not a web view.
* GNUmakefile.am:
* UIProcess/API/C/gtk/WKView.cpp:
* UIProcess/API/gtk/PageClientImpl.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebView.cpp.
(WebKit::backspaceCallback):
(WebKit::selectAllCallback):
(WebKit::cutClipboardCallback):
(WebKit::copyClipboardCallback):
(WebKit::pasteClipboardCallback):
(WebKit::toggleOverwriteCallback):
(WebKit::popupMenuCallback):
(WebKit::showHelpCallback):
(WebKit::deleteFromCursorCallback):
(WebKit::moveCursorCallback):
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::~PageClientImpl):
(WebKit::PageClientImpl::getEditorCommandsForKeyEvent):
(WebKit::PageClientImpl::createDrawingAreaProxy):
(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::displayView):
(WebKit::PageClientImpl::scrollView):
(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewInWindow):
(WebKit::PageClientImpl::PageClientImpl::processDidCrash):
(WebKit::PageClientImpl::didRelaunchProcess):
(WebKit::PageClientImpl::takeFocus):
(WebKit::PageClientImpl::toolTipChanged):
(WebKit::PageClientImpl::setCursor):
(WebKit::PageClientImpl::setViewportArguments):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):
(WebKit::PageClientImpl::convertToDeviceSpace):
(WebKit::PageClientImpl::convertToUserSpace):
(WebKit::PageClientImpl::windowToScreen):
(WebKit::PageClientImpl::doneWithKeyEvent):
(WebKit::PageClientImpl::didNotHandleKeyEvent):
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::createContextMenuProxy):
(WebKit::PageClientImpl::setFindIndicator):
(WebKit::PageClientImpl::pageDidEnterAcceleratedCompositing):
(WebKit::PageClientImpl::pageDidLeaveAcceleratedCompositing):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
(WebKit::PageClientImpl::customRepresentationZoomFactor):
(WebKit::PageClientImpl::setCustomRepresentationZoomFactor):
(WebKit::PageClientImpl::pageClosed):
(WebKit::PageClientImpl::didChangeScrollbarsForMainFrame):
(WebKit::PageClientImpl::flashBackingStoreUpdates):
(WebKit::PageClientImpl::findStringInCustomRepresentation):
(WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
* UIProcess/API/gtk/PageClientImpl.h: Renamed from Source/WebKit2/UIProcess/gtk/WebView.h.
(WebKit::PageClientImpl::create):
(WebKit::PageClientImpl::addPendingEditorCommand):
(WebKit::PageClientImpl::userSpaceScaleFactor):
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseInit):
(webkitWebViewBaseCreate):
* UIProcess/API/gtk/WebKitWebViewBase.h:
* UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp:
2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Use the WebPage object in WebKitWebViewBase
https://bugs.webkit.org/show_bug.cgi?id=59683
It simplifies the implementation of the event callbacks. Remove
also all the methods from the page client that are no longer
needed.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseInit):
(webViewExpose):
(webViewDraw):
(webViewSizeAllocate):
(webViewFocusInEvent):
(webViewFocusOutEvent):
(webViewKeyPressEvent):
(webViewKeyReleaseEvent):
(webViewButtonPressEvent):
(webViewButtonReleaseEvent):
(webViewScrollEvent):
(webViewMotionNotifyEvent):
* UIProcess/API/gtk/WebKitWebViewBase.h:
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::createDrawingAreaProxy):
* UIProcess/gtk/WebView.h:
2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Create the page client in the view widget
https://bugs.webkit.org/show_bug.cgi?id=59679
* UIProcess/API/C/gtk/WKView.cpp:
(WKViewCreate): Simply create a new view widget and return it.
(WKViewGetPage): Use webkitWebViewBaseGetPage().
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseFinalize): Use finalize instead of dispose to
make sure it's called only once, and release the private struct too.
(webkitWebViewBaseInit): Create the page client.
(webkitWebViewBaseClassInit): Don't use GObject private data structure.
(webkitWebViewBaseCreate): New method to create a
WebKitWebViewBase for a given context and page group.
(webkitWebViewBaseGetWebViewInstance):
(webkitWebViewBaseGetPage):
* UIProcess/API/gtk/WebKitWebViewBase.h:
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::page): Get the page from the view widget.
(WebKit::WebView::handleFocusInEvent): Ditto.
(WebKit::WebView::handleFocusOutEvent): Ditto.
(WebKit::WebView::WebView): Page client is now created with a view widget.
(WebKit::WebView::paint): Get the page from the view widget.
(WebKit::WebView::setSize): Ditto.
(WebKit::WebView::handleKeyboardEvent): Ditto.
(WebKit::WebView::handleMouseEvent): Ditto.
(WebKit::WebView::handleWheelEvent): Ditto.
(WebKit::WebView::close): Ditto.
(WebKit::WebView::createDrawingAreaProxy): Ditto.
* UIProcess/gtk/WebView.h:
(WebKit::WebView::create): The page client will be created as
private by the view widget, so it doesn't need to be ref counted,
use PassOwnPtr instead of PassRefPtr.
2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] PlatformWebView should be the view widget
https://bugs.webkit.org/show_bug.cgi?id=59676
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseGetPage): Return the page of the view.
* UIProcess/API/gtk/WebKitWebViewBase.h:
* UIProcess/ChunkedUpdateDrawingAreaProxy.h: Map PlatformWebView
to WebKitWebViewBase instead of the page client.
* UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::page): Use the view widget
directly.
(WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): Ditto.
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore): Ditto.
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::createDrawingAreaProxy): Pass the view widget to
the DrawingAreaProxy constructor instead of the page client.
* UIProcess/gtk/WebView.h: Remove getWebViewWindow() which is no
longer needed.
2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] WKView should be a GtkWidget
https://bugs.webkit.org/show_bug.cgi?id=59603
* UIProcess/API/C/gtk/WKAPICastGtk.h: Map WKViewRef to
WebKitWebViewBase instead of WebView.
* UIProcess/API/C/gtk/WKView.h: Remove WKViewGetWindow().
* UIProcess/API/C/gtk/WKView.cpp:
(WKViewCreate): Return the view instead of the page client.
(WKViewGetPage): Use WebKitWebViewBase API to get the page client
containing the page.
2011-04-27 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
WebKit2 needs to notify the client when a plugin fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=59657
Add didFailToInitializePlugin client function and call it when a plugin
fails to initialize.
* UIProcess/API/C/WKPage.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFailToInitializePlugin):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFailToInitializePlugin):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::initializePlugin):
2011-04-27 Pratik Solanki <psolanki@apple.com>
Reviewed by Antti Koivisto.
Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836
Add PLATFORM(WIN) ifdef around shouldCacheResponse.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
2011-04-27 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Hang if a sync message handler invalidates the connection
https://bugs.webkit.org/show_bug.cgi?id=59627
If dispatching incoming messages while waiting for the sync reply caused the connection to be invalidated,
we need to return early or we'll wait forever.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::waitForSyncReply):
2011-04-27 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Move WebViewWidget to UIProcess/API/gtk
https://bugs.webkit.org/show_bug.cgi?id=59594
API files should be under the API directory. This view widget will
be used by both C and gtk high level API, so it has been renamed
to WebKitWebViewBase.
* GNUmakefile.am:
* UIProcess/API/gtk/WebKitWebViewBase.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebViewWidget.cpp.
(webkitWebViewBaseRealize):
(webkitWebViewBaseContainerAdd):
(webkitWebViewBaseDispose):
(webkitWebViewBaseInit):
(webViewExpose):
(webViewDraw):
(webViewSizeAllocate):
(webViewFocusInEvent):
(webViewFocusOutEvent):
(webViewKeyPressEvent):
(webViewKeyReleaseEvent):
(getEventTime):
(webViewButtonPressEvent):
(webViewButtonReleaseEvent):
(webViewScrollEvent):
(webViewMotionNotifyEvent):
(webkitWebViewBaseClassInit):
(webkitWebViewBaseGetType):
(webkitWebViewBaseGetWebViewInstance):
(webkitWebViewBaseSetWebViewInstance):
(webkitWebViewBaseGetIMContext):
* UIProcess/API/gtk/WebKitWebViewBase.h: Renamed from Source/WebKit2/UIProcess/gtk/WebViewWidget.h.
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::WebView):
2011-04-26 Chang Shu <cshu@webkit.org>
Reviewed by Laszlo Gombos.
WebKitTestRunner needs layoutTestController.addOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=42544
Also implemented removeOriginAccessWhitelistEntry and resetOriginAccessWhitelists.
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleAddOriginAccessWhitelistEntry):
(WKBundleRemoveOriginAccessWhitelistEntry):
(WKBundleResetOriginAccessWhitelists):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::addOriginAccessWhitelistEntry):
(WebKit::InjectedBundle::removeOriginAccessWhitelistEntry):
(WebKit::InjectedBundle::resetOriginAccessWhitelists):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-26 Dan Bernstein <mitz@apple.com>
Build fix.
* Configurations/CompilerVersion.xcconfig:
2011-04-26 Anders Carlsson <andersca@apple.com>
Fix 32-bit clang build.
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::windowCoversAnyScreen):
* UIProcess/API/mac/WKTextInputWindowController.mm:
(-[WKTextInputPanel init]):
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::flipScreenYCoordinate):
(WebKit::computeFakeWindowBoundsRect):
* WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
(-[AccessibilityWebPageObject accessibilityHitTest:]):
2011-04-26 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543
* Configurations/FeatureDefines.xcconfig:
Remove feature.
2011-04-26 Chang Shu <cshu@webkit.org>
Reviewed by Laszlo Gombos.
WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572
Remove the unnecessary code that updates preference.
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::decode):
* Shared/WebPreferencesStore.h:
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetAllowUniversalAccessFromFileURLs):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAllowUniversalAccessFromFileURLs):
(WebKit::InjectedBundle::setAllowFileAccessFromFileURLs):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-26 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
WebKit2: Docked Inspector doesn't behave well if inspected web view isn't at 0,0
https://bugs.webkit.org/show_bug.cgi?id=59554
<rdar://problem/9341188>
Use GetWindowRect and ScreenToClient to properly place our inspector and inspected
web views instead of using GetClientRect. We need to correctly handle the case where
the inspected web view isn't at 0, 0.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
2011-04-26 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
Choose the compiler based on the Xcode version for Snow Leopard debug builds.
* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Added.
2011-04-26 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed build fix.
* Platform/Region.cpp: Need to include stdio.h for printf
(at least in my Qt-Linux environment).
2011-04-26 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Turn off make built-in implicit rules for derived sources makefile
https://bugs.webkit.org/show_bug.cgi?id=59418
We don't use any of make's built-in implicit rules, turning them off
speeds up parsing of the makefile.
* WebKit2.xcodeproj/project.pbxproj:
2011-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after r84785.
* UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
2011-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after r84886
* Platform/gtk/RunLoopGtk.cpp: Include WorkItem.h
2011-04-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
WebKit2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59426
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::waitForMessage):
- Lack of OwnPtr in HashMap is sad face. This code becomes very
pretty if we could use OwnPtr in HashMap...
* Platform/RunLoop.cpp:
(RunLoop::performWork):
(RunLoop::scheduleWork):
* Platform/RunLoop.h:
* Platform/mac/WorkQueueMac.cpp:
(WorkQueue::executeWorkItem):
* WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::deliverData):
2011-04-25 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
WebKit2: Should be able to inspect Web Inspector in Debug Builds
https://bugs.webkit.org/show_bug.cgi?id=59378
* UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup): Creates an inspector page group and enables
developer extras in a debug build.
(WebKit::WebInspectorProxy::inspectorPageGroup): Calls createInspectorPageGroup.
2011-04-25 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
WebKit2: Web Inspector's style sidebar fails to display when inspecting element
https://bugs.webkit.org/show_bug.cgi?id=58071
<rdar://problem/9243093>
When creating our WebKit2 inspector views, we were creating them on both Mac and Windows
with the empty rect for their initial size. Before we sized them correctly, the inspector
was calling window.innerWidth on them, which returned 0, making the sidebar take up 0 pixels.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create the window with the initial window width
and height.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Ditto.
2011-04-25 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Windows part of - WebKit2: Support docked mode for Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59134
<rdar://problem/8739005>
Implement attaching and detaching of the Web Inspector on Windows,
and also support setAttachedWindowHeight when the user changes the height
of the docked inspector.
This patch doesn't remember whether the user prefers attached or detached, and
doesn't remember the user's preferred docked height, but that will be a separate
bug.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::attach): Set the attached flag and call platform-specific code.
(WebKit::WebInspectorProxy::detach): Ditto.
(WebKit::WebInspectorProxy::setAttachedWindowHeight): Call platform-specific code.
(WebKit::WebInspectorProxy::didClose): Set m_isVisible before calling platformClose. platformClose
calls detach if the inspector was docked, and detach needs to know whether or not the window is
visible.
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebInspectorProxy.messages.in: Add new messages.
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageClient): Add a getter for the page client.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::windowReceivedMessage): Relay WM_WINDOWPOSCHANGING messages from the inspected
web view to the WebInspectorProxy.
(WebKit::WebInspectorProxy::onWebViewWindowPosChangingEvent): Resize the inspected web view to behave well
with the docked inspector.
(WebKit::WebInspectorProxy::platformClose): If we are attached, detach before destroying.
(WebKit::WebInspectorProxy::platformAttach): Set the inspector's host window to be the inspected web view's parent
window, so the inspected web view and the inspector are siblings.
(WebKit::WebInspectorProxy::platformDetach): Set the inspector's host window to be the standalone inspector window.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Size the views.
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorClient.h:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::attachWindow): Call WebInspector::attach.
(WebKit::WebInspectorFrontendClient::closeWindow): Add a call to the InspectorController to disconnect the inspector frontend
from the inspector backend. Without this line, when we close the attached inspector, it won't re-open, because the
inspector controller still thinks there is a frontend. This matches WebKit1's behavior, although it seems like this is
something WebCore should handle.
(WebKit::WebInspectorFrontendClient::detachWindow): Call WebInspector::detach.
(WebKit::WebInspectorFrontendClient::setAttachedWindowHeight): Call WebInspector::setAttachedWindowHeight.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaImpl::sendUpdateBackingStoreState): Add an early return if the WebPageProxy's viewSize is empty.
This can be needed if the inspector takes up the whole view, and it is useful to prevent a possible synchronous message
from the UIProcess -> WebProcess to update a backing store that isn't visible in the first place.
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::attach): Send a message to the UIProcess.
(WebKit::WebInspector::detach): Ditto.
(WebKit::WebInspector::setAttachedWindowHeight): Ditto.
* WebProcess/WebPage/WebInspector.h: Remove some dead code.
2011-04-25 Brian Weinstein <bweinstein@apple.com>
Reviewed by Alice Liu.
WebKit2: Web Inspector: Support highlighting page elements
https://bugs.webkit.org/show_bug.cgi?id=59263
<rdar://problem/8767659>
Support highlighting of page elements for the inspector in WebKit2 by
having the WebInspectorClient be a PageOverlay Client and be responsible
for calling InspectorController::drawNodeHighlight.
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight): Create our overlay if it hasn't been created,
or call setNeedsDisplay if it has.
(WebKit::WebInspectorClient::hideHighlight): Uninstall the page overlay if it exists.
(WebKit::WebInspectorClient::pageOverlayDestroyed):
(WebKit::WebInspectorClient::willMoveToWebPage): If it's being destroyed (moving to a null
WebPage), clear the member variable.
(WebKit::WebInspectorClient::didMoveToWebPage):
(WebKit::WebInspectorClient::drawRect): Call InspectorController::drawNodeHighlight.
(WebKit::WebInspectorClient::mouseEvent):
* WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebKit::WebInspectorClient::WebInspectorClient): Add a new member variable.
2011-04-25 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): adding method to allow changing style
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::getDocumentBackgroundColor): refactoring to use common code for retrieving background color
2011-04-24 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9329741> Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com
https://bugs.webkit.org/show_bug.cgi?id=59299
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::invalidateContentsAndWindow): Null-check the document.
(WebKit::WebChromeClient::invalidateContentsForSlowScroll): Ditto.
2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84740.
http://trac.webkit.org/changeset/84740
https://bugs.webkit.org/show_bug.cgi?id=59290
change breaks apple internal builds and is incorrect
(Requested by smfr on #webkit).
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
2011-04-22 Jon Lee <jonlee@apple.com>
Reviewed by Beth Dakin.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): adding method to allow changing style
2011-04-22 Brian Weinstein <bweinstein@apple.com>
Reviewed by Sam Weinig.
WebKit2: Stop responsiveness timer before calling runOpenPanel
https://bugs.webkit.org/show_bug.cgi?id=59268
<rdar://problem/9327944>
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runOpenPanel): Stop the timer before calling WebUIClient::runOpenPanel,
because runOpenPanel can spin a nested run loop.
2011-04-22 Chang Shu <cshu@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
https://bugs.webkit.org/show_bug.cgi?id=42536
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetFrameFlatteningEnabled):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setFrameFlatteningEnabled):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-22 Alejandro G. Castro <alex@igalia.com> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use the libWebCore.a convenience library when compiling WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59258
* GNUmakefile.am: Remove the libWebKit2 convenience library and use the
libWebCore convenience library when compiling WebKit2. Not only does this
maintain the CPPFLAGS isolation, it prevents double-compilation of WebCore
in some cases.
2011-04-19 Jer Noble <jer.noble@apple.com>
Reviewed by Daniel Bates.
Full Screen from within an <iframe> does not cause <iframe> to resize.
https://bugs.webkit.org/show_bug.cgi?id=58638
Tests: fullscreen/full-screen-frameset-allowed.html
fullscreen/full-screen-frameset-not-allowed.html
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Cancel the background animation
if the full screen animation finishes first.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): m_fullScreenRootLayer was uninitialized.
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Brian Weinstein.
WebKit2: Implement JavaScript unresponsiveness callback
https://bugs.webkit.org/show_bug.cgi?id=59248
Add support for suspending JavaScript in response to a callback.
* UIProcess/API/C/WKPage.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::shouldInterruptJavaScript):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::shouldInterruptJavaScript):
* UIProcess/WebUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldInterruptJavaScript):
2011-04-22 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
Paint the bounding rect of the dirty region instead of individual rectangles when the region
covers at least 3/4 of its bounds.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::shouldPaintBoundsRect): Use floating point math so that the logic that was supposed to
achieve this actually works.
2011-04-22 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Crash at WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation + 79
https://bugs.webkit.org/show_bug.cgi?id=59225
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Guard against
m_fullScreenRootLayer being NULL.
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
2011-04-22 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Allow MediaPlayerPrivateAVFoundation to be disabled via a preference.
https://bugs.webkit.org/show_bug.cgi?id=59179
Add API to allow the WebCore Settings preference to be called from the UIProcess.
* Shared/WebPreferencesStore.h: Added new preference definition macro.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAVFoundationEnabled): Added.
(WKPreferencesGetAVFoundationEnabled): Added.
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Pass new preference along to WebCore
Settings.
2011-04-22 Brian Weinstein <bweinstein@apple.com>
Reviewed by Sam Weinig.
WebKit2: Stop Responsiveness Timer when WebPageProxy closes or WebProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=59210
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Stop the responsiveness timer.
(WebKit::WebPageProxy::processDidCrash): Ditto.
2011-04-21 Adam Roben <aroben@apple.com>
Give windowless plugins' context menus an owner window in the same thread as the plugin
In some cases, plugins pass the WKView's HWND to the ::TrackPopupMenu API. ::TrackPopupMenu
fails in this case because the WKView's HWND is owned by another process/thread. We work
around this by hooking the ::TrackPopupMenu API and providing our own window that's in the
same thread as the plugin instead.
I couldn't figure out how to write a test for this. :-(
Fixes <http://webkit.org/b/51063> <rdar://problem/8769281> REGRESSION (WebKit2): No context
menu appears when right-clicking on windowless Flash plugin
Reviewed by Brian Weinstein, and looked at suspiciously by Jeff Miller.
* Platform/Module.h: Added installIATHook on Windows.
* Platform/win/ModuleWin.cpp:
(WebKit::overwriteReadOnlyMemory): New helper function. Basically a wrapper around memcpy,
but uses ::VirtualProtect to allow writing to otherwise-read-only memory.
(WebKit::findFunctionPointerAddress): New helper function. The first overload iterates over
the imported modules and functions looking for the given one. If found, returns the address
of the function pointer that is used when calling that function. The second overload calls
the first, first passing it an enumerator for the image's imported modules, then passing it
an iterator for the image's delay-loaded modules.
(WebKit::Module::installIATHook): Added. Finds the address of the function pointer that's
used when code in this module calls the given function, then overwrites the function pointer
with the passed-in one. Future calls to the given function made by code in this module
should then end up calling to the passed-in function instead of the original one.
* Shared/Plugins/Netscape/NetscapePluginModule.h:
(WebKit::NetscapePluginModule::module): Added this simple getter.
* WebProcess/Plugins/Netscape/NetscapePlugin.h: Added some new Windows-only members.
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::CurrentPluginSetter::CurrentPluginSetter):
(WebKit::CurrentPluginSetter::~CurrentPluginSetter):
This RAII class sets/unsets the currentPlugin global.
(WebKit::registerPluginView): Changed to use instanceHandle() instead of the mysterious
gInstance.
(WebKit::NetscapePlugin::platformPostInitialize): For windowless plugins, hook the
::TrackPopupMenu API and create a window to be used as the owner for context menus created
by this plugin. (Also changed the ::CreateWindowExW call for windowed plugins to pass an
instance handle so that the window will be associated with WebKit.dll instead of
WebKit2WebProcess.exe. This should have no visible effect, but is more correct.)
(WebKit::NetscapePlugin::platformDestroy): For windowless plugins, destroy the context menu
owner window we created above.
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Set ourselves as the current plugin.
(WebKit::NetscapePlugin::hookedTrackPopupMenu): Added. This is the function that actually
gets called when windowless plugins call ::TrackPopupMenu. If the passed-in owner window is
owned by the current thread, we have nothing to do; ::TrackPopupMenu should work just fine.
Otherwise, we use the current plugin's context menu owner window as the context menu's
owner. We also set focus to the new owner window because otherwise weird behavior results
(e.g., it's possible to scroll the WKView while the context menu is up).
2011-04-21 Adam Roben <aroben@apple.com>
Use WebCore's do-nothing window class instead of creating our own
Fixes <http://webkit.org/b/59102> WebKit has too many dummy window classes
Reviewed by Anders Carlsson.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::createDummyWindow): Less code!
2011-04-22 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Cannot play flash with NSPluginWrapper
https://bugs.webkit.org/show_bug.cgi?id=59125
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue): Handle the case when we have been
called with a null plugin instance.
2011-04-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Sam Weinig.
[Qt][WK2] Implement DrawingAreaImpl for Qt.
https://bugs.webkit.org/show_bug.cgi?id=59171
* WebKit2.pro: Build files necessary for DrawingAreaImpl.
* DerivedSources.pro: Build message receivers for DrawingArea and DrawingAreaProxy.
* Shared/qt/LayerTreeContextQt.cpp:
(WebKit::LayerTreeContext::LayerTreeContext): Stub.
(WebKit::LayerTreeContext::~LayerTreeContext): Stub.
(WebKit::LayerTreeContext::encode): Stub.
(WebKit::LayerTreeContext::decode): Stub.
(WebKit::LayerTreeContext::isEmpty): Stub.
(WebKit::operator==): Stub.
* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::paint): Don't translate the painter to accomodate the
source rect. The rect is already adjusted at the call site.
* UIProcess/API/qt/qgraphicswkview.h: Add "Impl" to QGraphicsWKView::BackingStoreType.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::createDrawingAreaProxy): Create DrawingAreaProxyImpl if requested.
(QWKPagePrivate::paint): Call the correct paint() method for DrawingAreaProxyImpl,
since this drawing area will simple ASSERT_NOT_REACHED() in the "normal" paint().
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create): Allow creation of DrawingAreaImpl for Qt.
* UIProcess/BackingStore.h: Add Qt-specific types and backing store.
* UIProcess/qt/BackingStoreQt.cpp:
(WebKit::BackingStore::paint): Implemented.
(WebKit::BackingStore::incorporateUpdate): Implemented.
(WebKit::BackingStore::scroll): Implemented using QPixmap::scroll().
* UIProcess/DrawingAreaProxy.h: Enable drawing area message receivers for Qt.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage): Ditto.
* WebProcess/WebPage/DrawingArea.h: Ditto.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage): Ditto.
2011-04-22 Jon Honeycutt <jhoneycutt@apple.com>
WinCairo build fix. Unreviewed.
* WebProcess/Downloads/curl/DownloadCurl.cpp:
(WebKit::Download::useCredential):
Stubbed.
(WebKit::Download::continueWithoutCredential):
Stubbed.
(WebKit::Download::cancelAuthenticationChallenge):
Stubbed.
2011-04-21 Jon Honeycutt <jhoneycutt@apple.com>
Need to support authentication for downloads in WebKit2 on Windows
https://bugs.webkit.org/show_bug.cgi?id=59175
<rdar://problem/9206151>
<rdar://problem/8958280>
Reviewed by Maciej Stachowiak.
* WebProcess/Downloads/Download.cpp:
Include DownloadAuthenticationClient.h.
* WebProcess/Downloads/Download.h:
Declare a function to get or create the authentication client, a member
var to hold it, and functions that the client can call to use a
credential, continue without a credential, or cancel an auth challenge.
* WebProcess/Downloads/DownloadAuthenticationClient.cpp: Added.
(WebKit::DownloadAuthenticationClient::DownloadAuthenticationClient):
(WebKit::DownloadAuthenticationClient::receivedCredential):
Tell the Download to use the credential.
(WebKit::DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential):
Tell the Download to continue with credentials.
(WebKit::DownloadAuthenticationClient::receivedCancellation):
Tell the Download to cancel the challenge.
* WebProcess/Downloads/DownloadAuthenticationClient.h: Added.
(WebKit::DownloadAuthenticationClient::create):
Return a new DownloadAuthenticationClient.
(WebKit::DownloadAuthenticationClient::detach):
Clear the Download.
(WebKit::DownloadAuthenticationClient::refAuthenticationClient):
(WebKit::DownloadAuthenticationClient::derefAuthenticationClient):
* WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::useCredential):
Create a CFURLCredentialRef from the WebCore credential, and tell
CFNetwork to use it for the auth challenge.
(WebKit::Download::continueWithoutCredential):
Call CFURLDownloadUseCredential with a null credential.
(WebKit::Download::cancelAuthenticationChallenge):
Cancel the download, and clear m_download.
(WebKit::Download::authenticationClient):
Create if needed and return a DownloadAuthenticationClient.
(WebKit::Download::platformInvalidate):
Detach the DownloadAuthenticationClient.
(WebKit::didReceiveAuthenticationChallengeCallback):
Call Download::didReceiveAuthenticationChallenge(), passing a
WebCore::AuthenticationChallenge with our DownloadAuthenticationClient.
(WebKit::Download::receivedCredential):
Get the client from the auth challenge, and call through to it.
(WebKit::Download::receivedRequestToContinueWithoutCredential):
Ditto.
(WebKit::Download::receivedCancellation):
Ditto.
* win/WebKit2.vcproj:
Add new files to project.
2011-04-21 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
Minimize synchronous calls during loading
https://bugs.webkit.org/show_bug.cgi?id=59169
<rdar://problem/9320128> REGRESSION(r84526): WK2 windows unresponsive
* UIProcess/API/mac/WKView.mm:
(-[WKView resignFirstResponder]):
(-[WKView _resetTextInputState]):
Made _resetTextInputState deal with client side state only, letting Editor composition be
discarded more discriminately.
2011-04-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
Add a feature define to allow <details> and <summary> to be disabled
https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>
* Configurations/FeatureDefines.xcconfig:
2011-04-21 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9311103>
Remove unnecessary QTKitServer and Apple Events permissions
from the WebProcess sandbox.
* WebProcess/com.apple.WebProcess.sb:
2011-04-21 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9033535>
Mute sandbox violations when attempting to read a temporary
CFNetwork keychain.
* WebProcess/com.apple.WebProcess.sb:
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::canCopyCut):
(WebKit::WebEditorClient::canPaste):
* WebProcess/WebCoreSupport/WebEditorClient.h:
2011-04-21 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/8774116>
The WebProcess sandbox should only allow access to the
parts of the Darwin cache directory needed by the Security
framework.
* WebProcess/com.apple.WebProcess.sb:
2011-04-21 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9311053>
The WebProcess sandbox should not allow opening arbitrary
IOKit user clients. Restrict to a whitelist required for normal
WebProcess operation, including sound and accelerated graphics.
* WebProcess/com.apple.WebProcess.sb:
2011-04-21 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9311037>
The WebProcess sandbox should not allow modification of the
CoreAudio component cache.
* WebProcess/com.apple.WebProcess.sb:
2011-04-21 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9263428>
The WebProcess sandbox should only allow outbound networking
to remote destinations and local kernel controls.
* WebProcess/com.apple.WebProcess.sb:
2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82052.
http://trac.webkit.org/changeset/82052
https://bugs.webkit.org/show_bug.cgi?id=59135
New full screen api should be opt-in, not opt-out. (Requested
by jernoble on #webkit).
* Shared/WebPreferencesStore.h:
2011-04-21 Beth Dakin <bdakin@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=59048
Need to track whether overlay scrollbar is currently visible and in lower-
righthand corner
-and corresponding-
<rdar://problem/9211232>
WebPageProxy now stores an IntRect of the scroller thumb set by WebCore through
the client.
_windowResizeMouseLocationIsInVisibleScrollerThumb tests if the parameter point is
inside the cached scroller thumb rect.
* UIProcess/API/mac/WKView.mm:
(-[WKView _windowResizeMouseLocationIsInVisibleScrollerThumb:]):
Client work to cache the rect.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::notifyScrollerThumbIsVisibleInRect):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::visibleScrollerThumbRect):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::notifyScrollerThumbIsVisibleInRect):
* WebProcess/WebCoreSupport/WebChromeClient.h:
New WebSystemInterface is needed by WebCore for this.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
2011-04-21 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Emit QWKPage::urlChanged() when navigating within the same document.
https://bugs.webkit.org/show_bug.cgi?id=59044
Hook up the didSameDocumentNavigationForFrame callback to QWKPage::urlChanged().
* UIProcess/API/qt/ClientImpl.cpp:
(qt_wk_didSameDocumentNavigationForFrame):
* UIProcess/API/qt/ClientImpl.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
2011-04-20 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
WebKit2: Unconfirmed inline input session persists after reload
https://bugs.webkit.org/show_bug.cgi?id=59054
<rdar://problem/9291086>
Makes the inline input get properly confirmed or discarded when changing selection,
navigating to another page, focusing another view in the window, or after a web process
crash.
* Shared/EditorState.h: (WebKit::EditorState::EditorState):
* WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::editorState):
Added a variable that Editor sets while processing input method calls. We don't want
selection changes caused by -setMarkedText: discard the composition!
* UIProcess/PageClient.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::updateTextInputState):
(WebKit::PageClientImpl::resetTextInputState):
Extended updateSecureInputState() to potentially confirm the current inline input session.
Added resetTextInputState, which is to be called when we get out of the current web page.
* UIProcess/API/mac/WKView.mm:
(-[WKView resignFirstResponder]): Just call _resetTextInputState instead of dealing with
input state here.
(-[WKView _updateSecureInputState]): Use _isFocused to make the code simpler.
(-[WKView _updateTextInputStateIncludingSecureInputState:]): Confirm the current inline
input session if selection changed for any other reason but an input method changing the
composition. We will want to do other work here, like dismissing a dictionary pop-up,
updating a font panel etc.
(-[WKView _resetTextInputState]): Added. We don't want secure text input persist after
navigations, crashes an such, and we also don't want input methods to remember inline input
state. Relying on selection changed notifications is fragile and insufficient.
* UIProcess/API/mac/WKViewInternal.h: Added internal functions to keep the build unbroken.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame): This is the best chance we have to reset input
state for a new page. This doesn't work well for cached page loads, but WK1 is quite broken
in that case, too.
(WebKit::WebPageProxy::editorStateChanged): Moved some logic up to the client, since the
function now does much more than before.
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::confirmCompositionWithoutDisturbingSelection):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::confirmCompositionWithoutDisturbingSelection):
Added confirmCompositionWithoutDisturbingSelection(). When we confirm the composition due
to selection change, we obvisouly don't want the selection to move back.
2011-04-21 Sam Weinig <sam@webkit.org>
Reviewed by Simon Fraser.
Remove warnings from DrawingAreaImpl and related classes
https://bugs.webkit.org/show_bug.cgi?id=59120
DrawingAreaImpl is mature enough for others to adopt. Remove warnings.
* UIProcess/BackingStore.cpp:
* UIProcess/DrawingAreaProxyImpl.cpp:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/LayerTreeHost.cpp:
2011-04-21 Sam Weinig <sam@webkit.org>
Reviewed by Simon Fraser.
Deploy GraphicsContextStateSaver in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59116
* UIProcess/FindIndicator.cpp:
(WebKit::FindIndicator::draw):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::drawRect):
* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::drawRect):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawRect):
(WebKit::WebPage::drawPageOverlay):
2011-04-21 Jessie Berlin <jberlin@apple.com>
Reviewed by Sam Weinig.
WebKit2: Need a way to get a snapshot of the visible contents of a page from the UI Process.
https://bugs.webkit.org/show_bug.cgi?id=59035
Added a sync call from the UI Process to the Web Process with comments saying that it should
be removed as soon as possible.
* UIProcess/API/C/WKPage.cpp:
(WKPageVisibleContentsSnapshot):
* UIProcess/API/C/WKPagePrivate.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createSnapshotOfVisibleContent):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createSnapshotOfVisibleContent):
Ask the FrameView for the visibleContentRect, and call scaledSnapshotInDocumentCoordinates
with a scale factor of 1 (which preserves the current scaling of the page - e.g. if the
page is already zoomed then the snapshot will reflect the zoomed content).
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
2011-04-20 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
layoutTestController can create and destroy shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=59058
Support for new methods in WK2 WebKitTestRunner.
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleCopyElementEnsureShadowRoot):
(WKBundleNodeHandleRemoveShadowRoot):
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::elementShadowRoot):
(WebKit::InjectedBundleNodeHandle::elementEnsureShadowRoot):
(WebKit::InjectedBundleNodeHandle::elementRemoveShadowRoot):
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
2011-04-20 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Don't discard backing stores for hung web processes
https://bugs.webkit.org/show_bug.cgi?id=59039
<rdar://problem/9237090>
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
(WebKit::WebPageProxy::processDidBecomeUnresponsive):
(WebKit::WebPageProxy::processDidBecomeResponsive):
Call updateBackingStoreDiscardableState.
(WebKit::WebPageProxy::updateBackingStoreDiscardableState):
Never mark the backing store as discardable if the web process is hung
2011-04-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
Reproducible crash under WebPageProxy::didReceiveEvent
https://bugs.webkit.org/show_bug.cgi?id=59036
<rdar://problem/9252083>
* UIProcess/API/mac/WKView.mm:
(-[WKView _resendKeyDownEvent:]): Protect against self-destruction
when re-dispatching the event.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage): Fixed a type mismatch
I noticed while debugging.
2011-04-20 Timothy Hatcher <timothy@apple.com>
Make the Web Insepctor come to the front when a breakpoint is hit.
<https://webkit.org/b/57480> REGRESSION (WebKit2): Inspector doesn't come to the front when a breakpoint is hit in the debugger
<rdar://problem/9209472>
Reviewed by Adam Roben.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::bringToFront): Added. Call platformBringToFront.
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebInspectorProxy.messages.in: Added BringToFront.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformBringToFront): Added. Call orderFront:.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformBringToFront): Added. Call ShowWindow.
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::bringToFront): Call WebInspector::bringToFront.
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::bringToFront): Added. Send WebInspectorProxy::BringToFront message.
* WebProcess/WebPage/WebInspector.h: Added bringToFront.
2011-04-20 Chris Marrin <cmarrin@apple.com>
Reviewed by Adam Roben.
REGRESSION (WebKit2): CSS animations on pages that use accelerated compositing stop after switching tabs
https://bugs.webkit.org/show_bug.cgi?id=57868
Subclassed setRootCompositingLayer so it can call ensureAnimationsSubmitted on Win.
* WebProcess/WebPage/ca/LayerTreeHostCA.h:
Make setRootCompositingLayer protected so it can be called from subclass
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
Override setRootCompositingLayer to add call to root layer's
PlatformCALayer::ensureAnimationsSubmitted method
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:
2011-04-18 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Adopt QTKit API for listing and deleting file in its media cache.
<rdar://problem/9130029>
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Initialize new functions.
2011-04-20 Alejandro G. Castro <alex@igalia.com>
Fixed GTK+ compilation after r84206.
* GNUmakefile.am:
2011-04-20 Adam Roben <aroben@apple.com>
Remove some unnecessary VS junk related to NativeWebMouseEventWin.cpp
* win/WebKit2.vcproj:
2011-04-20 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Cleanup includepath adjustment for generated files
https://bugs.webkit.org/show_bug.cgi?id=58869
* WebKit2.pri: Add the directory of generated files to the include
path with absolute path to make it valid in the final build step.
2011-04-19 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
UI process thinks the page is unresponsive when a plug-in is showing a context menu
https://bugs.webkit.org/show_bug.cgi?id=58943
<rdar://problem/9299901>
Change the HandleMouseEvent message to have a delayed reply and make the PluginControllerProxy
respond to it immediately, before even passing the event to the plug-in. Since it doesn't matter
for mouse events whether the plug-in handled them or not we can do this.
Another solution could have been to make handleMouseEvent an asynchronous message, but that could
mess up the message ordering so this seemed like the least intrusive change.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::handleMouseEvent):
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/PluginControllerProxy.messages.in:
2011-04-19 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Terminate hung plug-in processes after 45 seconds
https://bugs.webkit.org/show_bug.cgi?id=58932
<rdar://problem/8083219>
* UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::pluginSyncMessageSendTimedOut):
Find the plug-in process proxy and terminate it.
(WebKit::PluginProcessManager::pluginProcessWithPath):
Add new helper function.
(WebKit::PluginProcessManager::getOrCreatePluginProcess):
Call pluginProcessWithPath.
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::terminate):
Terminate the process.
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::pluginSyncMessageSendTimedOut):
Call PluginProcessManager::pluginSyncMessageSendTimedOut.
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:
Add PluginSyncMessageSendTimedOut message.
* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::defaultSyncMessageTimeout):
(WebKit::PluginProcessConnection::PluginProcessConnection):
Set a sync message timeout on the plug-in process connection.
(WebKit::PluginProcessConnection::syncMessageSendTimedOut):
Send a message to the web process proxy.
2011-04-19 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adele Peterson.
WebKit2: Merge SelectionState and TextInputState
https://bugs.webkit.org/show_bug.cgi?id=58919
Combined TextInputState and EditorState in one structure, which is updated whenever we get
a chance to. There is no sense to keep possibly stale SelectionState data when we have already
requested the most recent data synchronously.
This also simplifies the code, as we don't need to pass the state around in a separate variable.
* GNUmakefile.am:
* Scripts/webkit2/messages.py:
* Shared/EditorState.h: Copied from Source/WebKit2/Shared/SelectionState.h.
(WebKit::EditorState::EditorState):
* Shared/SelectionState.h: Removed.
* Shared/mac/TextInputState.h: Removed.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::interpretKeyEvent):
* UIProcess/API/mac/WKView.mm:
(-[WKView validRequestorForSendType:returnType:]):
(-[WKView validateUserInterfaceItem:]):
(-[WKView shouldDelayWindowOrderingForEvent:]):
(-[WKView doCommandBySelector:]):
(-[WKView insertText:replacementRange:]):
(-[WKView _handleStyleKeyEquivalent:]):
(-[WKView _executeSavedKeypressCommands]):
(-[WKView inputContext]):
(-[WKView hasMarkedText]):
(-[WKView unmarkText]):
(-[WKView setMarkedText:selectedRange:replacementRange:]):
(-[WKView attributedSubstringForProposedRange:actualRange:]):
(-[WKView _interpretKeyEvent:savingCommandsTo:WebCore::]):
(-[WKView _updateSecureInputState]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::editorStateChanged):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::editorState):
(WebKit::WebPageProxy::hasSelectedRange):
(WebKit::WebPageProxy::isContentEditable):
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::insertText):
(WebKit::WebPageProxy::executeKeypressCommands):
(WebKit::WebPageProxy::writeSelectionToPasteboard):
(WebKit::WebPageProxy::readSelectionFromPasteboard):
(WebKit::WebPageProxy::interpretQueuedKeyEvent):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::compositionSelectionChanged):
(WebKit::WebView::onIMEComposition):
(WebKit::WebView::onIMEEndComposition):
(WebKit::WebView::onIMERequestCharPosition):
(WebKit::WebView::onIMERequest):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::handleEditingKeyboardEvent):
(WebKit::WebPage::setComposition):
(WebKit::WebPage::confirmComposition):
(WebKit::WebPage::insertText):
(WebKit::WebPage::executeKeypressCommands):
* win/WebKit2.vcproj:
2011-04-19 Alexey Proskuryakov <ap@apple.com>
Reviewed by Timothy Hatcher.
100% reproducible crash when right-clicking any element in Web Inspector on any page
https://bugs.webkit.org/show_bug.cgi?id=58822
Web Inspector changes selection from JavaScript, and checks in UI process are insufficient
when selection is changing asynchronously.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::writeSelectionToPasteboard): Check that there is a selection, matching WK1
and UI process side. Perhaps the check should really be in WebCore, but for now, it's a
WebKit responsibility.
(WebKit::WebPage::readSelectionFromPasteboard): Same check, for no other reason but consistency.
2011-04-19 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add syncMessageSendTimedOut CoreIPC Connection::Client member function
https://bugs.webkit.org/show_bug.cgi?id=58928
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::waitForSyncReply):
Call syncMessageSendTimedOut.
* Platform/CoreIPC/Connection.h:
Add syncMessageSendTimedOut to Connection::Client.
* PluginProcess/PluginProcess.cpp:
* PluginProcess/PluginProcess.h:
* PluginProcess/WebProcessConnection.cpp:
* PluginProcess/WebProcessConnection.h:
* UIProcess/Plugins/PluginProcessProxy.cpp:
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/WebProcessProxy.cpp:
* UIProcess/WebProcessProxy.h:
* WebProcess/Plugins/PluginProcessConnection.cpp:
* WebProcess/Plugins/PluginProcessConnection.h:
* WebProcess/WebProcess.cpp:
* WebProcess/WebProcess.h:
Add syncMessageSendTimedOut stubs.
2011-04-19 Anders Carlsson <andersca@apple.com>
Reviewed by Alexey Proskuryakov.
Replace the didFailToSendSyncMessage Connection::Client function with a flag
https://bugs.webkit.org/show_bug.cgi?id=58923
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::Connection):
Initialize m_shouldExitOnSyncMessageSendFailure to false.
(CoreIPC::Connection::setShouldExitOnSyncMessageSendFailure):
Set m_didCloseOnConnectionWorkQueueCallback.
(CoreIPC::Connection::sendSyncMessage):
Call didFailToSendSyncMessage if we fail to send the sync message for some reason.
(CoreIPC::Connection::didFailToSendSyncMessage):
if m_shouldExitOnSyncMessageSendFailure is true, exit.
* Platform/CoreIPC/Connection.h:
Remove didFailToSendSyncMessage from Connection::Client.
* PluginProcess/PluginProcess.cpp:
* PluginProcess/PluginProcess.h:
Remove didFailToSendSyncMessage.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initialize):
* WebProcess/WebProcess.h:
Remove didFailToSendSyncMessage. Call setShouldExitOnSyncMessageSendFailure on our
UI process connection.
2011-04-19 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a way to set the default sync message timeout for a CoreIPC connection
https://bugs.webkit.org/show_bug.cgi?id=58908
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::Connection):
Initialize m_defaultSyncMessageTimeout.
(CoreIPC::Connection::setDefaultSyncMessageTimeout):
Set the m_defaultSyncMessageTimeout member variable.
(CoreIPC::Connection::waitForSyncReply):
Handle the timeout being one of our two special magic values.
* Platform/CoreIPC/Connection.h:
Add a DefaultTimeout constant and change the NoTimeout constant to be -1.
2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
https://bugs.webkit.org/show_bug.cgi?id=58883
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
2011-04-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
WebKit2: Typo fix in WebPopupMenu::Type.
https://bugs.webkit.org/show_bug.cgi?id=58891
Fixed a typo, Seperator -> Separator.
Also removed m_ prefix on an argument variable name.
* Shared/WebPopupItem.h:
* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::populate):
* WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::populateItems):
2011-04-19 Jon Honeycutt <jhoneycutt@apple.com>
WKContextDownloadURLRequest() should return a WKDownloadRef
https://bugs.webkit.org/show_bug.cgi?id=58867
Part of <rdar://problem/8931717>
Reviewed by Steve Falkenburg.
* UIProcess/API/C/WKContext.cpp:
(WKContextDownloadURLRequest):
Return the result of calling WebContext::download().
* UIProcess/API/C/WKContext.h:
Updated return type of WKContextDownloadURLRequest().
* UIProcess/WebContext.cpp:
(WebKit::WebContext::download):
Return the DownloadProxy returned by createDownloadProxy().
(WebKit::WebContext::createDownloadProxy):
Return the DownloadProxy.
* UIProcess/WebContext.h:
Changed return type of download() and createDownloadProxy().
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
Call the DownloadProxy's downloadID() function to get the ID.
2011-04-18 Jia Pu <jpu@apple.com>
Reviewed by Mark Rowe.
WebKit needs to stop importing <AppKit/NSTextChecker.h>
https://bugs.webkit.org/show_bug.cgi?id=58798
<rdar://problem/9294938>
Use public header <AppKit/NSSpellChecker.h> instead.
* UIProcess/mac/CorrectionPanel.h:
* UIProcess/mac/CorrectionPanel.mm:
(correctionIndicatorType):
(WebKit::CorrectionPanel::show):
(WebKit::CorrectionPanel::dismissInternal):
(WebKit::CorrectionPanel::handleAcceptedReplacement):
* UIProcess/mac/TextCheckerMac.mm:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
2011-04-05 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: WKTR should support WebKit2 full screen APIs
https://bugs.webkit.org/show_bug.cgi?id=56318
Add a new WKBundlePage API for Full Screen events, and move some of the implementation
of WebFullScreenManager into the new InjectedBundlePageFullScreenClient class, so that
the default behavior can be overridden by a WKBundlePageFullScreenClient.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::supportsFullScreen): Moved contents into InjectedBundlePageFullScreenClient.
(WebKit::WebFullScreenManager::enterFullScreenForElement): Ditto.
(WebKit::WebFullScreenManager::exitFullScreenForElement): Ditto.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetFullScreenClient): Added.
(WKBundlePageWillEnterFullScreenForElement): Added.
(WKBundlePageDidEnterFullScreenForElement): Added.
(WKBundlePageWillExitFullScreenForElement): Added.
(WKBundlePageDidExitFullScreenForElement): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: Added.
(WebKit::InjectedBundlePageFullScreenClient::supportsFullScreen): Added.
(WebKit::InjectedBundlePageFullScreenClient::enterFullScreenForElement): Added.
(WebKit::InjectedBundlePageFullScreenClient::exitFullScreenForElement): Added.
* WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h: Added.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundleFullScreenClient): Added.
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleFullScreenClient): Added.
2011-04-18 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
Re-add a null check lost in r83081
https://bugs.webkit.org/show_bug.cgi?id=58846
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::getSelectedRange):
2011-04-18 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Clean up tool-tip/status-bar confusion.
https://bugs.webkit.org/show_bug.cgi?id=58844
Tool-tips were incorrectly hooked up to the status bar text.
Chrome::setStatusbarText() now correctly causes the QWKPage::statusBarMessage() signal.
New API:
- QWKPage::toolTipChanged(const QString& toolTip) [signal]
QGraphicsWKView will automatically listen for this and set its own toolTip().
* UIProcess/API/qt/ClientImpl.cpp:
(qt_wk_setStatusText):
* UIProcess/API/qt/ClientImpl.h:
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::QGraphicsWKView):
(QGraphicsWKViewPrivate::onToolTipChanged):
* UIProcess/API/qt/qgraphicswkview.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::toolTipChanged):
(QWKPage::QWKPage):
* UIProcess/API/qt/qwkpage.h:
2011-04-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
sandbox violation for ~/Library/Dictionaries
https://bugs.webkit.org/show_bug.cgi?id=58841
<rdar://problem/9294770>
* WebProcess/com.apple.WebProcess.sb: Add to sandbox profile.
No obvious harm from allowing this, though it's not 100% clear
why it's needed.
2011-04-18 Anders Carlsson <andersca@apple.com>
Try to fix the Windows build.
* Scripts/webkit2/messages.py:
2011-04-18 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Get rid of WebProcessProxyLegacyMessage
https://bugs.webkit.org/show_bug.cgi?id=58825
* GNUmakefile.am:
* Platform/CoreIPC/MessageID.h:
* Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h: Removed.
* UIProcess/WebProcessProxy.cpp:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebPage/WebPage.cpp:
* win/WebKit2.vcproj:
2011-04-18 Anders Carlsson <andersca@apple.com>
Fix build.
* UIProcess/Plugins/PluginInfoStore.h:
2011-04-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Use the message generator for the GetPluginProcessConnection message
https://bugs.webkit.org/show_bug.cgi?id=58815
* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessageDelayed):
Add helper functions.
* UIProcess/Plugins/PluginInfoStore.h:
Mark class noncopyable.
* UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::getPluginProcessConnection):
This now takes a delayed reply.
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::getPluginProcessConnection):
This now takes a delayed reply.
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
Call DelayedReply::send.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginProcessConnection):
This now takes a delayed reply.
(WebKit::WebProcessProxy::didReceiveSyncMessage):
No need to handle this message here.
* UIProcess/WebProcessProxy.messages.in:
Add GetPluginProcessConnection message.
* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Don't use deprecatedSendSync.
2011-04-18 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Finish implementing delayed sync replies in the CoreIPC message generator
https://bugs.webkit.org/show_bug.cgi?id=58814
Put the DelayedReply function definitions in the .cpp file and fix bugs found by
actually trying to compile the generated files.
* Scripts/webkit2/messages.py:
* Scripts/webkit2/messages_unittest.py:
2011-04-18 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Reproducible crash in Find on Page, on pages that use accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=58793
<rdar://problem/9295870>
Move the call to PageOverlay::setNeedsDisplay() back to WebPage::installPageOverlay;
it needs to be called after we've told the drawing area that a page overlay has been installed.
* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::setPage):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::installPageOverlay):
2011-04-18 Jeff Miller <jeffm@apple.com>
Reviewed by Timothy Hatcher.
WKFrameLoadState should be a uint32_t to match our API conventions
https://bugs.webkit.org/show_bug.cgi?id=58785
* UIProcess/API/C/WKFrame.h: typedef WKFrameLoadState as a uint32_t and define its values as an anonymous enum.
2011-04-18 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after 84017.
* GNUmakefile.am:
* Shared/NativeWebMouseEvent.h:
(WebKit::NativeWebMouseEvent::nativeEvent):
* Shared/gtk/NativeWebMouseEventGtk.cpp: Copied from Source/WebKit2/Shared/NativeWebMouseEvent.h.
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::handleMouseEvent):
2011-04-17 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
<rdar://problem/9268729>
Reviewed by Dan Bernstein.
This replaces support for the WebKitEnableHTTPPipelining user
default with methods on the WebCore::ResourceRequest class in
WebCore, the WebView class in WebKit1, and the WebContext class
in WebKit2. It also removes support for the
WebKitForceHTTPPipeliningPriorityHigh user default which was not
needed.
* UIProcess/API/C/WKContext.cpp:
(_WKContextSetHTTPPipeliningEnabled): Added.
* UIProcess/API/C/WKContextPrivate.h:
(_WKContextSetHTTPPipeliningEnabled): Added declaration.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setHTTPPipeliningEnabled): Added.
(WebKit::WebContext::httpPipeliningEnabled): Added.
* UIProcess/WebContext.h:
(WebKit::WebContext::setHTTPPipeliningEnabled): Added declaration.
(WebKit::WebContext::httpPipeliningEnabled): Added declaration.
2011-04-17 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Make more strings in WebKit2 localizable
https://bugs.webkit.org/show_bug.cgi?id=58757
* UIProcess/API/mac/PDFViewController.mm:
(-[WKPDFView menuForEvent:]):
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setViewportArguments):
(WebKit::PageClientImpl::registerEditCommand):
* UIProcess/WebEditCommandProxy.cpp:
(WebKit::WebEditCommandProxy::nameForEditAction):
* UIProcess/WebEditCommandProxy.h:
Use WebCore's localization macro to make more strings localizable.
2011-04-17 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Rename PLATFORM(CA) to USE(CA)
https://bugs.webkit.org/show_bug.cgi?id=58742
* WebProcess/WebPage/LayerTreeHost.cpp:
* WebProcess/WebPage/win/LayerTreeHostWin.cpp:
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
2011-04-17 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
* Shared/ShareableBitmap.h:
* Shared/WebCoreArgumentCoders.cpp:
* Shared/WebCoreArgumentCoders.h:
* Shared/WebGraphicsContext.cpp:
(WebKit::WebGraphicsContext::WebGraphicsContext):
* Shared/WebGraphicsContext.h:
* Shared/win/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::setFindIndicator):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawRectToPDF):
(WebKit::WebPage::drawPagesToPDF):
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::platformPreferencesDidChange):
* config.h:
2011-04-16 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash when NPP_Write returns -1 when writing the manual stream
https://bugs.webkit.org/show_bug.cgi?id=58735
<rdar://problem/9124993>
If NPP_Write returns -1 we must cancel the stream.
* WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::deliverDataToPlugin):
2011-04-16 Sam Weinig <sam@webkit.org>
Reviewed by Simon Fraser.
Pages in the PageCache don't have the correct visited link coloring after being restored
https://bugs.webkit.org/show_bug.cgi?id=58721
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
Mark all pages in the page cache as needing visited link style recalc
whenever visited link information changes.
2011-04-15 Daniel Bates <dbates@webkit.org>
Attempt to fix the Qt Linux Release build after changeset 84064 <http://trac.webkit.org/changeset/84064>
(https://bugs.webkit.org/show_bug.cgi?id=58686).
* UIProcess/API/qt/qwkpage_p.h: Remove takeFocus().
2011-04-15 Shishir Agrawal <shishir@chromium.org>
Reviewed by James Robinson.
Add a flag to guard Page Visibility API changes.
https://bugs.webkit.org/show_bug.cgi?id=58464
* Configurations/FeatureDefines.xcconfig:
2011-04-15 Jeff Miller <jeffm@apple.com>
Reviewed by Sam Weinig.
Add takeFocus callback to WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=58686
On Windows, we need to handle moving focus out of the web view in the client, so add a takeFocus callback to WKPageUIClient
and stop handling taking focus in the framework in WKView.mm on the Mac.
* UIProcess/API/C/WKPage.h: Added WKFocusDirection enum and takeFocus to WKPageUIClient.
* UIProcess/API/mac/PageClientImpl.h: Removed takeFocus().
* UIProcess/API/mac/PageClientImpl.mm: Removed takeFocus().
* UIProcess/API/mac/WKView.mm: Removed _takeFocus().
* UIProcess/API/mac/WKViewInternal.h: Removed _takeFocus().
* UIProcess/API/qt/ClientImpl.cpp:
(qt_wk_takeFocus): Added.
* UIProcess/API/qt/ClientImpl.h: Added qt_wk_takeFocus.
* UIProcess/API/qt/qwkpage.cpp: Remove takeFocus().
(QWKPage::QWKPage): Added takeFocus() callback.
* UIProcess/PageClient.h: Removed takeFocus().
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::takeFocus): Call m_uiClient to take focus.
* UIProcess/WebPageProxy.h: Pass FocusDirection as a uint32_t to takeFocus().
* UIProcess/WebPageProxy.messages.in: Pass FocusDirection as a uint32_t in TakeFocus message.
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::takeFocus): Added.
* UIProcess/WebUIClient.h: Added takeFocus().
* UIProcess/win/WebView.cpp: Removed takeFocus(), which was never implemented on Windows.
* UIProcess/win/WebView.h: Removed takeFocus().
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::takeFocus): Pass FocusDirection as a uint32_t in TakeFocus message.
2011-04-15 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
WebKit2: Stop using deprecated NSInputManager
https://bugs.webkit.org/show_bug.cgi?id=58709
Changed all mouse related functions to give NSInputContext a chance to handle the event,
added logging. Removed -rightMouseMoved: method, which was added by accident.
* UIProcess/API/mac/WKView.mm:
(-[WKView mouseMoved:]):
(-[WKView mouseDown:]):
(-[WKView mouseUp:]):
(-[WKView mouseDragged:]):
2011-04-15 Jon Honeycutt <jhoneycutt@apple.com>
Potential crash getting a JS wrapper.
<rdar://problem/8988741>
Reviewed by Brian Weinstein.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::jsWrapperForWorld):
Ensure that we have a valid m_coreFrame, because it can be cleared by
invalidate().
2011-04-08 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QWebPage MIME type handling inconsistency with other web browsers
https://bugs.webkit.org/show_bug.cgi?id=46968
Implementing mime type sniffing based on
http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebCore::WebFrameNetworkingContext::MIMESniffingEnabled):
* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
2011-04-15 Oliver Hunt <oliver@apple.com>
GC allocate Structure
https://bugs.webkit.org/show_bug.cgi?id=58483
Rolling r83894 r83827 r83810 r83809 r83808 back in with
a workaround for the gcc bug seen by the gtk bots
* WebProcess/Plugins/Netscape/JSNPMethod.h:
(WebKit::JSNPMethod::createStructure):
* WebProcess/Plugins/Netscape/JSNPObject.h:
(WebKit::JSNPObject::createStructure):
2011-04-15 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add API to get the bundle page overlay fade in fraction.
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(WKBundlePageOverlayFractionFadedIn):
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
2011-04-15 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Fade the find page overlay
https://bugs.webkit.org/show_bug.cgi?id=58697
* WebProcess/WebPage/FindController.cpp:
Make the color components floats.
(WebKit::overlayBackgroundColor):
(WebKit::holeShadowColor):
(WebKit::holeFillColor):
Add helper functions for returning the colors given the fraction faded in.
(WebKit::FindController::drawRect):
Use the new helper functions.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::installPageOverlay):
Start the fade animation unless we're replacing an already existing page overlay
with another.
2011-04-15 Anders Carlsson <andersca@apple.com>
Fix Windows build.
* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::fadeAnimationTimerFired):
2011-04-15 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add the ability for PageOverlays to fade in and out
https://bugs.webkit.org/show_bug.cgi?id=58694
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageUninstallPageOverlay):
WebPage::uninstallPageOverlay now takes a boolean. Default to false for now.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):
Pass false to uninstallPageOverlay.
(WebKit::FindController::hideFindUI):
Pass true to uninstallPageOverlay.
* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::PageOverlay):
Initialize new member variables.
(WebKit::PageOverlay::bounds):
Get rid of an unnecessary webPage() getter.
(WebKit::PageOverlay::setPage):
Stop the animation timer.
(WebKit::PageOverlay::startFadeInAnimation):
Update m_fractionFadedIn and call startFadeAnimation.
(WebKit::PageOverlay::startFadeOutAnimation):
Ditto.
(WebKit::PageOverlay::startFadeAnimation):
Initialize m_fadeAnimationStartTime and start the fade animation timer.
(WebKit::PageOverlay::fadeAnimationTimerFired):
Update m_fractionFadedIn and call setNeedsDisplay().
* WebProcess/WebPage/PageOverlay.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::uninstallPageOverlay):
If fadeOut is true, tell the page overlay to start the fade out animation.
When the fade animation is complete, the page overlay will uninstall itself.
2011-04-15 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Views should be made visible before painting in WM_PRINTCLIENT messages
https://bugs.webkit.org/show_bug.cgi?id=58676
<rdar://problem/9279211>
* UIProcess/win/WebView.cpp:
(WebKit::WebView::onPrintClientEvent): If our view isn't currently visible set it to visible
before painting, then reset it back to not visible after painting.
(WebKit::WebView::onShowWindowEvent): Call setIsVisible instead of duplicating logic.
(WebKit::WebView::setIsVisible): Set the m_isVisible flag and call viewStateDidChange.
* UIProcess/win/WebView.h:
2011-04-15 Jon Lee <jonlee@apple.com>
Reviewed by Anders Carlsson.
onClick does not function with <select> elements in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57904
<rdar://problem/9217757>
Reviewed by Anders Carlsson.
* Shared/NativeWebMouseEvent.h: Copied from Source/WebKit2/UIProcess/WebPopupMenuProxy.h.
(WebKit::NativeWebMouseEvent::nativeEvent):
* Shared/mac/NativeWebMouseEventMac.mm: Added.
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
* Shared/qt/NativeWebMouseEventQt.cpp: Copied from Source/WebKit2/UIProcess/WebPopupMenuProxy.h.
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
* Shared/win/NativeWebMouseEventWin.cpp: Copied from Source/WebKit2/UIProcess/WebPopupMenuProxy.h.
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
* UIProcess/API/mac/WKView.mm:
(-[WKView mouseMoved:]):
(-[WKView _mouseHandler:]): Pre-compiler mouse handler calls need to use the new NativeWebMouseEvent class
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::mouseMoveEvent):
(QWKPagePrivate::mousePressEvent):
(QWKPagePrivate::mouseReleaseEvent):
(QWKPagePrivate::mouseDoubleClickEvent):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleMouseEvent): keep track of mouse down event in order to be able to send a fake mouse up event on the select element
(WebKit::WebPageProxy::currentMouseDownEvent): for access by the popup menu proxy to dispatch the fake mouse up event
(WebKit::WebPageProxy::didReceiveEvent): clear out the cached mouse down event
(WebKit::WebPageProxy::processDidCrash): clear out the cached events since we assume that didReceiveEvent did not called prior to the crash
* UIProcess/WebPageProxy.h:
* UIProcess/WebPopupMenuProxy.h:
* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu): after notifying the popup menu client that the value changed, fake mouse up and mouse move events are posted
* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::showPopupMenu): after notifying the popup menu client that the value changed, fake mouse up and mouse move events are posted
* UIProcess/win/WebView.cpp:
(WebKit::WebView::onMouseEvent):
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
2011-04-15 Alexey Proskuryakov <ap@apple.com>
Qt build fix.
* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::selectionStateChanged): Wrap the variable
in PLATFORM(MAC), too, as it's unused on other platforms.
2011-04-15 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/9287880> and https://bugs.webkit.org/show_bug.cgi?id=58596
WK2: Past searches not remembered for <input type=search results="5" autosave="foo">
Add SaveRecentSearches and LoadRecentSearches messages:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebPageProxy.h:
Message up to the UIProcess for the save/load operations:
* WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):
* WebProcess/WebCoreSupport/WebPopupMenu.h:
(WebKit::WebPopupMenu::page):
Save the values to disk CFPreference-style:
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::autosaveKey):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
Stubbed out for non-CF platforms:
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
* UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
2011-04-14 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
WebKit2: Password field input does not switch to ASCII-compatible source
https://bugs.webkit.org/show_bug.cgi?id=58583
<rdar://problem/9059651>
The implementation is more modern than what we have in WK1. Instead of returning a null
input context (as in non-editable content), we now set page context's properties.
* UIProcess/PageClient.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::updateSecureInputState):
Forward updateSecureInputState() call from WebPageProxy to WKView.
* UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]): ASSERT that we didn't somehow leave secure input events enabled.
(-[WKView becomeFirstResponder]): Update secure event mode.
(-[WKView resignFirstResponder]): Disable secure event mode.
(-[WKView setMarkedText:selectedRange:replacementRange:]): Prevent most advanced editing
behaviors in password fields, matching NSSecureTextInputField.
(-[WKView attributedSubstringForProposedRange:actualRange:]): Disable TSM Document Access
in password fields. There is also a check in web process, but it doest't hurt to check twice.
(-[WKView _windowDidBecomeKey:]): Call _updateSecureInputState.
(-[WKView _windowDidResignKey:]): Call _updateSecureInputState.
(-[WKView _updateSecureInputState]): Update secure event mode and allowed input sources.
* UIProcess/API/mac/WKViewInternal.h: Added _updateSecureInputState.
* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::selectionStateChanged): Update secure
input state when going in or out a password field.
2011-04-14 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
REGRESSION: Rendering in <video> element appears to render quickly to catch up if it has been playing in a background tab
https://bugs.webkit.org/show_bug.cgi?id=58637
Notify AVFoundation that no one will be rendering when the view or window moves off screen.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewVisible): Return false if the view's window is not visible.
* UIProcess/API/mac/WKView.mm:
(-[WKView addWindowObserversForWindow:]): Observe orderOut and orderIn events.
(-[WKView removeWindowObservers]): Ditto.
(-[WKView _windowDidOrderOffScreen:]): Added.
(-[WKView _windowDidOrderOnScreen:]): Added.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::suspendPainting): Call LayerTreeHost::pauseRendering.
(WebKit::DrawingAreaImpl::resumePainting): Call LayerTreeHost::resumeRendering.
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::pauseRendering): Added stub.
(WebKit::LayerTreeHost::resumeRendering): Added stub.
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::pauseRendering): Added. Post a notification with our
intention to stop rendering.
(WebKit::LayerTreeHostCAMac::resumeRendering): Added. Post a notification with our
intention to start rendering.
2011-04-15 Jessie Berlin <jberlin@apple.com>
Reviewed by Sam Weinig.
WebKit2: Need a way to keep the WebProcess alive for testing purposes.
https://bugs.webkit.org/show_bug.cgi?id=58592
* UIProcess/API/C/WKContext.cpp:
(WKContextDisableProcessTermination):
(WKContextEnableProcessTermination):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
Initialize m_processTerminationEnabled to true.
(WebKit::WebContext::enableProcessTermination):
Set m_processTerminationEnabled to true, and try to terminate the web process.
(WebKit::WebContext::shouldTerminate):
If !m_processTerminationEnabled, return false.
* UIProcess/WebContext.h:
(WebKit::WebContext::disableProcessTermination):
Set m_processTerminationEnabled to false;
2011-04-15 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Need to export ViewportAttributes class
https://bugs.webkit.org/show_bug.cgi?id=58651
On Symbian, if the ViewportAttributes class is not exported we get
linking errors.
Since this is a compilation issue, no new tests added.
* UIProcess/API/qt/qwkpage.h:
2011-04-15 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Renaming TRACK feature define to VIDEO_TRACK
https://bugs.webkit.org/show_bug.cgi?id=53556
* Configurations/FeatureDefines.xcconfig:
2011-04-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Select All context menu item doesn't work in Flash
https://bugs.webkit.org/show_bug.cgi?id=58615
<rdar://problem/9225761>
In some cases, -[NSWindow isKeyWindow] will return false even if
a window is the key window, so we have to compare our window
against -[NSApplication keyWindow].
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewWindowActive):
2011-04-14 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add CFPreference based backend for WebKit2 preferences
https://bugs.webkit.org/show_bug.cgi?id=58605
* UIProcess/cf/WebPreferencesCF.cpp:
(WebKit::cfStringFromWebCoreString):
(WebKit::makeKey):
(WebKit::setStringValueIfInUserDefaults):
(WebKit::setBoolValueIfInUserDefaults):
(WebKit::setUInt32ValueIfInUserDefaults):
(WebKit::setDoubleValueIfInUserDefaults):
(WebKit::WebPreferences::platformInitializeStore):
(WebKit::WebPreferences::platformUpdateStringValueForKey):
(WebKit::WebPreferences::platformUpdateBoolValueForKey):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
(WebKit::WebPreferences::platformUpdateDoubleValueForKey):
Implement platform functions using CFPreferences API.
2011-04-14 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8665102> and https://bugs.webkit.org/show_bug.cgi?id=58595
Menu is not displayed for <input type=search results="5">
* WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
(WebKit::WebSearchPopupMenu::enabled): Return true, like all good search popup menus should.
* WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
(WebKit::WebPopupMenu::setUpPlatformData): Remember the shouldPopOver-ness.
* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode): Remember the shouldPopOver-ness.
(WebKit::PlatformPopupMenuData::decode): Remember the shouldPopOver-ness.
* Shared/PlatformPopupMenuData.h:
* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu): Use the shouldPopOver-ness to adjust display position.
2011-04-14 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Crash in NetscapePluginModule::tryGetSitesWithData when NPP_GetSitesWithData returns null
https://bugs.webkit.org/show_bug.cgi?id=58578
<rdar://problem/9275201>
It's OK for NPP_GetSitesWithData to return null.
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryGetSitesWithData):
2011-04-14 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Make creating WebPreferences lazy
https://bugs.webkit.org/show_bug.cgi?id=58570
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
(WebKit::WebPageGroup::setPreferences):
(WebKit::WebPageGroup::preferences):
* UIProcess/WebPageGroup.h:
Don't create the WebPreference object until it is requested.
2011-04-14 Pratik Solanki <psolanki@apple.com>
Reviewed by David Kilzer.
Set minimum priority for fast lane connections
https://bugs.webkit.org/show_bug.cgi?id=58353
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
2011-04-14 Anders Carlsson <andersca@apple.com>
Clang warning fixes.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/mac/TextCheckerMac.mm:
* WebProcess/Downloads/mac/DownloadMac.mm:
2011-04-14 Jessie Berlin <jberlin@apple.com>
Reviewed by Timothy Hatcher.
WebKit2: Add an option for a PageGroup to be invisible to the History Client.
https://bugs.webkit.org/show_bug.cgi?id=58547
* Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):
* Shared/WebPageGroupData.h:
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectorPageGroup):
The Web Inspector should not be visible to the History Client, because its HTML-based nature
should not be exposed through the API.
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::create):
(WebKit::WebPageGroup::WebPageGroup):
* UIProcess/WebPageGroup.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::updateGlobalHistory):
Do not send the message to the WebContent for the history client.
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
Ditto.
(WebKit::WebFrameLoaderClient::setTitle):
Ditto.
* WebProcess/WebPage/WebPageGroupProxy.h:
(WebKit::WebPageGroupProxy::isVisibleToHistoryClient):
2011-04-14 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1
https://bugs.webkit.org/show_bug.cgi?id=55719
Guard functionality related to complex text and implementations
that rely on MachPort with PLATFORM(MAC).
Based on Oleg Romashin's patch.
* PluginProcess/PluginControllerProxy.cpp:
* PluginProcess/PluginControllerProxy.messages.in:
* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::createWebProcessConnection):
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPlugin):
* Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::decode): Fix bad C++ that
does not compile with gcc-linux.
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Plugins/PluginProcessProxy.messages.in:
* WebKit2.pro: Move implementation that does not need external
visibility from WebKit2API.pri. Adding the headers as well.
* WebKit2API.pri:
* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
* WebProcess/WebPage/WebPage.cpp:
2011-04-13 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Allow setting composited backing stores for scrollbars and scroll corners
https://bugs.webkit.org/show_bug.cgi?id=57202
Update WebPopupMenuProxyWin to reflect ScrollableArea interface changes.
* UIProcess/win/WebPopupMenuProxyWin.h:
(WebKit::WebPopupMenuProxyWin::invalidateScrollCornerRect):
(WebKit::WebPopupMenuProxyWin::scrollCornerPresent):
(WebKit::WebPopupMenuProxyWin::scrollCornerRect):
2011-04-13 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION(r81880): Paste menu is disabled for many edit fields (yahoo and google search, yahoo mail msg, forms, etc)
https://bugs.webkit.org/show_bug.cgi?id=58284
<rdar://problem/9246149>
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setFocused): Check for whether we are not supposed to be focused AND whether our platform behavior dictates to clear out the selection
2011-04-13 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
Fixed a bug where WKView changed the cursor when the mouse was moving over other views.
* UIProcess/API/mac/WKView.mm:
(-[WKView mouseMoved:]): If getting this message because this view is the first responder,
ignore it unless it is inside the visible rect.
2011-04-13 Enrica Casucci <enrica@apple.com>
Reviewed by Dan Bernstein.
Should not rely on WKEditableLinkBehavior being in synch
with WebCore::EditableLinkBehavior.
https://bugs.webkit.org/show_bug.cgi?id=58473
Adding conversion routines.
* UIProcess/API/C/WKAPICast.h:
(WebKit::toAPI):
(WebKit::toEditableLinkBehavior):
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetEditableLinkBehavior):
(WKPreferencesGetEditableLinkBehavior):
2011-04-13 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
After closing the last window, re-opening my last visited website is over 2X slower
https://bugs.webkit.org/show_bug.cgi?id=58488
<rdar://problem/9233518>
Give the web process a 60 second termination timeout.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
2011-04-13 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Convert WebProcess over to using disableTermination/enableTermination
https://bugs.webkit.org/show_bug.cgi?id=58485
* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::getSitesWithData):
(WebKit::PluginProcess::clearSiteData):
Use the LocalTerminationDisabler RAII class.
* Shared/ChildProcess.h:
(WebKit::ChildProcess::LocalTerminationDisabler::LocalTerminationDisabler):
(WebKit::ChildProcess::LocalTerminationDisabler::~LocalTerminationDisabler):
Add RAII class for calling disableTermination/enableTermination.
* WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):
Use the LocalTerminationDisabler RAII class.
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):
(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
Use the LocalTerminationDisabler RAII class.
* WebProcess/Downloads/Download.cpp:
(WebKit::Download::Download):
Call disableTermination().
(WebKit::Download::~Download):
Call enableTermination().
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::downloadFinished):
Remove call to terminateIfPossible.
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):
Use the LocalTerminationDisabler RAII class.
* WebProcess/MediaCache/WebMediaCacheManager.cpp:
(WebKit::WebMediaCacheManager::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManager::clearCacheForHostname):
(WebKit::WebMediaCacheManager::clearCacheForAllHostnames):
Use the LocalTerminationDisabler RAII class.
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins):
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
(WebKit::WebResourceCacheManager::clearCacheForAllOrigins):
Use the LocalTerminationDisabler RAII class.
* WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::getDatabaseOrigins):
(WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManager::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManager::deleteAllDatabases):
(WebKit::WebDatabaseManager::setQuotaForOrigin):
Use the LocalTerminationDisabler RAII class.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage):
Call disableTermination().
(WebKit::WebProcess::removeWebPage):
Call enableTermination().
(WebKit::WebProcess::shouldTerminate):
Move logic from terminateIfPossible over here.
(WebKit::WebProcess::terminate):
Move logic from terminateIfPossible over here.
(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):
Use the LocalTerminationDisabler RAII class.
* WebProcess/WebProcess.h:
Publically inherit from ChildProcess, LocalTerminationDisabler needs to be accessible
from the WebProcess class.
2011-04-13 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Follow-up to: WebKit2 will load two copies of the same plugin, but should not
https://bugs.webkit.org/show_bug.cgi?id=49075
Use pathGetFileName instead of Win32 PathFindFileNameW.
* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::shouldUsePlugin):
2011-04-13 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
<rdar://problem/9260518>
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Initialize new WKSI functions.
2011-04-13 Steve Falkenburg <sfalken@apple.com>
Reviewed by Oliver Hunt.
WebKit2 will load two copies of the same plugin, but should not
https://bugs.webkit.org/show_bug.cgi?id=49075
<rdar://problem/8635947>
* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::shouldUsePlugin): Don't use a plug-in if we've already allowed a plug-in with the same filename.
2011-04-13 Timothy Hatcher <timothy@apple.com>
Hide the dictionary panel when navigating or crashing.
<rdar://problem/9261202>
Reviewed by Sam Weinig.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::dismissDictionaryLookupPanel): Added. Call WKHideWordDefinitionWindow.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame): Call PageClient::dismissDictionaryLookupPanel.
(WebKit::WebPageProxy::processDidCrash): Call dismissCorrectionPanel and PageClient::dismissDictionaryLookupPanel.
2011-04-13 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Add support for disabling/enabling termination to ChildProcess
https://bugs.webkit.org/show_bug.cgi?id=58476
Add ChildProcess::disableTermination and ChildProcess::enableTermination and convert
the PluginProcess class over to using them.
* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::PluginProcess):
The child process now takes a terminationTimeout argument. Get rid of the shutdown timer.
(WebKit::PluginProcess::removeWebProcessConnection):
Call enableTermination().
(WebKit::PluginProcess::shouldTerminate):
Always return true.
(WebKit::PluginProcess::createWebProcessConnection):
Call disableTermination().
(WebKit::PluginProcess::getSitesWithData):
Call disableTermination()/enableTermination().
(WebKit::PluginProcess::clearSiteData):
Ditto.
* Shared/ChildProcess.cpp:
(WebKit::ChildProcess::disableTermination):
Increment the counter and stop the timer.
(WebKit::ChildProcess::enableTermination):
Decrement the counter; if it's zero, start the timer.
(WebKit::ChildProcess::terminationTimerFired):
Call shouldTerminate(). If it returns true, call terminate().
(WebKit::ChildProcess::terminate):
Call RunLoop::quit().
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
Just initialize the termination timeout to 0 for now.
(WebKit::WebProcess::shouldTerminate):
Always return true; this isn't used yet.
* WebProcess/WebProcess.h:
2011-04-13 Enrica Casucci <enrica@apple.com>
Reviewed by Dan Bernstein.
REGRESSION: Links are clickable when a contentEditable is set to true.
https://bugs.webkit.org/show_bug.cgi?id=58473
<rdar://problem/9256793>
Added support for editable link behavior property.
* Shared/WebPreferencesStore.cpp:
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetEditableLinkBehavior):
(WKPreferencesGetEditableLinkBehavior):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
2011-04-12 Alexey Proskuryakov <ap@apple.com>
Reviewed by Oliver Hunt.
REGRESSION (WebKit2): Input methods are active in non-editable content
https://bugs.webkit.org/show_bug.cgi?id=58404
<rdar://problem/9275940>
* UIProcess/API/mac/WKView.mm:
(-[WKView insertText:]): Re-add the old variant of this function, because it's not only part
of deprecated NSTextInput protocol, but it's also part of NSResponder, and it's called when
the input context in nil.
(-[WKView inputContext]): Return nil when not in editable content.
2011-04-12 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9029193> and https://bugs.webkit.org/show_bug.cgi?id=58406
Bringing up the context menu on a link might also follow the link.
This patch adds a flag that is set just before the WebProcess tells the UIProcess to show a context menu.
As long as this flag is set, the WebProcess will ignore any other mouse events that might have queued up
by the time the UIProcess gets around to showing the menu.
After the UIProcess is done showing the menu, it messages back telling the WebProcess to clear the flag
and resume normal MouseEvent handling.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showContextMenu): No matter what internalShowContextMenu does, always notify
the WebProcess that any context menu is now hidden.
(WebKit::WebPageProxy::internalShowContextMenu):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show): Since we're telling the UIProcess to show the menu, tell the WebPage a
context menu is showing so it will stop handling mouse events.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::mouseEvent): Don't try to handle mouse events if a context menu is flagged as showing.
Add accessors to twiddle the "context menu showing" flag:
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::contextMenuShowing):
(WebKit::WebPage::contextMenuHidden):
* WebProcess/WebPage/WebPage.messages.in: Add the ContextMenuHidden message.
2011-04-12 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Quarantine related sandbox denial when downloading files
<rdar://problem/9203736>
* WebProcess/com.apple.WebProcess.sb:
2011-04-12 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Sandbox violations dragging an image to the desktop.
<rdar://problem/9261834>
* WebProcess/com.apple.WebProcess.sb:
2011-04-12 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Sandbox violations trying to access ~/Library/Keyboard Layouts and ~/Library/Input Methods
<rdar://problem/8973159>
* WebProcess/com.apple.WebProcess.sb:
2011-04-12 Enrica Casucci <enrica@apple.com>
Reviewed by Alexey Proskuryakov and Sam Weinig.
Implement non-activating clicks to allow dragging out of a background window.
https://bugs.webkit.org/show_bug.cgi?id=55053
<rdar://problem/9042197>
Added methods to WKView to support non activating click. Unfortunately both
methods require a synchronous call to the WebProcess to decide what to do.
acceptFirstMouse is called only if shouldDelayWindowOrderingForEvent returns
true. In order to minimize the number of synchronous calls, we send the request
only if our window is not the key window.
* UIProcess/API/mac/WKView.mm:
(-[WKView acceptsFirstMouse:]):
(-[WKView shouldDelayWindowOrderingForEvent:]):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::shouldDelayWindowOrderingForEvent):
(WebKit::WebPageProxy::acceptsFirstMouse):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):
2011-04-12 Alexey Proskuryakov <ap@apple.com>
Reviewed by Oliver Hunt.
Crash when serializing a null AttributedString
https://bugs.webkit.org/show_bug.cgi?id=58393
<rdar://problem/9275326>
* Shared/mac/AttributedString.mm:
(WebKit::AttributedString::encode):
(WebKit::AttributedString::decode):
Prefix the serialized value with an isNull tag.
2011-04-12 Enrica Casucci <enrica@apple.com>
Reviewed by Alexey Proskuryakov.
Infinite recursion in WebHTMLView executeSavedKeypressCommands.
https://bugs.webkit.org/show_bug.cgi?id=58382
<rdar://problem/9239370>
Execution of some editing commands could trigger a call to selectedRange that
internally calls executeSavedKeypressCommands creating an infinite recursion.
* UIProcess/API/mac/WKView.mm:
(-[WKView _executeSavedKeypressCommands]): Added flag to avoid recursion.
(-[WKView _interpretKeyEvent:withCachedTextInputState:savingCommandsTo:WebCore::]):
Added flag initialization.
2011-04-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Page tears and stutters in WebKit2 when page is > 2048 pixels wide
https://bugs.webkit.org/show_bug.cgi?id=58330
Turn off tiling for nonCompositedContentLayer to avoid tearing when
scrolling very wide (> 2048) windows.
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::initialize):
2011-04-12 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Assertion in DrawingAreaImpl::resumePainting() (m_isPaintingSuspended) when clicking a link at twitter.com
https://bugs.webkit.org/show_bug.cgi?id=58377
<rdar://problem/8976531>
Remove the assertion.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::resumePainting):
2011-04-11 Stephanie Lewis <slewis@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=58280
<rdar://problem/9252824> javascript in an inconsistent state due to serialization returning an un-handled exception
Change use of SerializedScriptValue::Create to use the same api as the rest of WebKit2. This has the benefit
of handling any exceptions so Javascript is not in an inconsistent state.
* Shared/API/c/WKSerializedScriptValue.h: fix a typo
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):
2011-04-12 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
https://bugs.webkit.org/show_bug.cgi?id=56020
Safari was always calling TranslateMessage() on key events since it has no way to know whether
WebKit handled the event without a PageUIClient (which Safari only installs on pages inside
a Safari window), which was generating a WM_CHAR message containing the tab in this case. The fix
is for Safari to never call TranslateMessage() on key events outside of a Safari window, but this
means the WebPageProxy needs to do this for unhandled key events if there is no didNotHandleKeyEvent
callback in the PageUIClient.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Call TranslateMessage() on Windows for unhandled key events that can't be handled by the PageUIClient.
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::canNotHandleKeyEvent): Added.
* UIProcess/WebUIClient.h: Added canNotHandleKeyEvent().
2011-04-12 Alice Liu <alice.liu@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=58292
Provide new setting to allow site icon loading despite disabling automatic image loading in general.
* Shared/WebPreferencesStore.h: Add macro for setting default value.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetLoadsSiteIconsIgnoringImageLoadingPreference): Added setter.
(WKPreferencesGetLoadsSiteIconsIgnoringImageLoadingPreference): Added getter.
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Add to list of WebCore settings that get propagated to WebKit preferences.
2011-04-12 Jessie Berlin <jberlin@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Spelling and Grammar Checking: Make sure to remove the markings from the document
when spelling and/or grammar checking is disabled.
https://bugs.webkit.org/show_bug.cgi?id=58350
* UIProcess/API/mac/WKView.mm:
(-[WKView toggleContinuousSpellChecking:]):
Move the call to unmark the errors to the WebProcess.
(-[WKView setGrammarCheckingEnabled:]):
Ditto.
(-[WKView toggleGrammarChecking:]):
Ditto.
* UIProcess/WebPageProxy.cpp:
Remove unused functions.
* UIProcess/WebPageProxy.h:
Ditto.
* WebProcess/WebPage/WebPage.messages.in:
Ditto.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setTextCheckerState):
If grammar or spelling checking is disabled, unmark all the pages.
Doing it here allows makes it possible to unmark all pages in a cross-platform way that is
triggered both by selecting the the context menu items and by any other methods of updating
the enabled / disabled state.
2011-04-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Cisco Meeting Center will not download or launch from Safari
https://bugs.webkit.org/show_bug.cgi?id=58366
<rdar://problem/8987139>
It's OK if a plug-in has less (or more) MIME type descriptions than actual MIME types.
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromCarbonResources):
2011-04-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Call PluginControllerProxy::platformGeometryDidChange before Plugin::geometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=58361
Since Plugin::geometryDidChange ends up calling plug-in code it can resize the plug-in which causes
platformGeometryDidChange to be called with the wrong rect.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange):
Call platformGeometryDidChange.
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::platformGeometryDidChange):
Remove the parameters to platformGeometryDidChange and just use m_frameRect instead.
2011-04-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Move three Mac specific functions to PluginControllerProxyMac.mm.
2011-04-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Cache the window and plug-in element NPObjects
https://bugs.webkit.org/show_bug.cgi?id=58355
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::~PluginControllerProxy):
(WebKit::PluginControllerProxy::windowScriptNPObject):
(WebKit::PluginControllerProxy::pluginElementNPObject):
* PluginProcess/PluginControllerProxy.h:
2011-04-12 Alejandro G. Castro <alex@igalia.com>
Fixed GTK compilation after r83454.
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::findStringInCustomRepresentation):
(WebKit::WebView::countStringMatchesInCustomRepresentation):
* UIProcess/gtk/WebView.h:
2011-04-11 Daniel Bates <dbates@webkit.org>
Attempt to fix the Qt Linux Release build after changeset 83550 <http://trac.webkit.org/changeset/83550>
(https://bugs.webkit.org/show_bug.cgi?id=54159).
* WebKit2API.pri: Append UIProcess/API/C/WKResourceCacheManager.cpp to the list WEBKIT2_API_SOURCES.
2011-04-11 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Move focus management out of WebKit via the UIClient
<rdar://problem/8784068>
https://bugs.webkit.org/show_bug.cgi?id=58278
* UIProcess/API/C/WKPage.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFocus):
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::focus):
(WebKit::WebUIClient::unfocus):
* UIProcess/WebUIClient.h:
* UIProcess/gtk/WebView.cpp:
* UIProcess/gtk/WebView.h:
* UIProcess/win/WebView.h:
Remove PageClient::setFocus() in favor of WebUIClient::focus and WebUIClient::unfocus.
2011-04-11 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
WebKit2: Cannot use Ctrl-Delete as a custom keyboard shortcut
https://bugs.webkit.org/show_bug.cgi?id=58265
<rdar://problem/9221468>
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::keyEvent): Added a comment explaining that doing work after DOM event
dispatch isn't great.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performNonEditingBehaviorForSelector): Added a comment explaining how this
might be moved down to WebCore.
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): This is now empty, since both Space
and Backspace behaviors are implemented in WebCore.
2011-04-11 Anders Carlsson <andersca@apple.com>
Try to fix the Windows build.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
2011-04-11 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r83081): Esc key no longer removes current Kotoeri text operation
https://bugs.webkit.org/show_bug.cgi?id=58274
<rdar://problem/9263683>
* WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getMarkedRange): Wrap the returned
temporary in RefPtr.
2011-04-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Remove m_urlAtProcessExit from WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=58275
Get rid of m_urlAtProcessExit and replace some zeros with nullptrs.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidCrash):
* UIProcess/WebPageProxy.h:
2011-04-11 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Remove the WebContext member variable from WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=58271
<rdar://problem/9148125>
* UIProcess/API/C/WKPage.cpp:
(WKPageGetContext):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::process):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::canShowMIMEType):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::didFirstLayoutForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
(WebKit::WebPageProxy::didDisplayInsecureContentForFrame):
(WebKit::WebPageProxy::didRunInsecureContentForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::unableToImplementPolicy):
(WebKit::WebPageProxy::willSubmitForm):
(WebKit::WebPageProxy::mouseDidMoveOverElement):
(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::contextMenuItemSelected):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
2011-04-11 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Ignore context change callbacks when not on the main thread
https://bugs.webkit.org/show_bug.cgi?id=58256
<rdar://problem/9266090>
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::contextDidChangeCallback): Do nothing when not called
on the main thread. This should only happen when no changes have actually
been committed to the context, eg. when a video frame has been added to an image
queue, so return without triggering animations etc.
2011-04-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
First step towards simplifying WebPageProxy/WebProcessProxy/WebContext ownership
https://bugs.webkit.org/show_bug.cgi?id=58266
<rdar://problem/9148125>
With this patch, the WKView holds a strong reference to a WebPageProxy. The
WebPageProxy in turn holds a strong reference to its WebProcessProxy. Finally,
The WebProcessProxy holds a strong reference to its WebContext.
The WebContext holds a strong reference to the running WebProcessProxy which results
in a reference cycle that's broken when the web process exits.
The reason for is to avoid crashes where WebPageProxy::process() returns null if the web process
has crashed but has not yet been relaunched.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::disconnectProcess):
Add comment.
(WebKit::WebContext::createWebPage):
Return a PassRefPtr.
(WebKit::WebContext::relaunchProcessIfNecessary):
Change this to return a WebPageProxy.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
This now takes a PassRefPtr<WebProcessProxy>.
(WebKit::WebPageProxy::WebPageProxy):
Ditto.
(WebKit::WebPageProxy::~WebPageProxy):
Call close() if necessary.
(WebKit::WebPageProxy::reattachToWebProcess):
Replace the current process with the new process.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::create):
Take a PassRefPtr<WebContext>.
(WebKit::WebProcessProxy::WebProcessProxy):
Ditto.
(WebKit::WebProcessProxy::webPage):
Remove .get() now that the page map uses weak references.
(WebKit::WebProcessProxy::createWebPage):
This now returns the created web page proxy.
2011-04-11 Adam Roben <aroben@apple.com>
Dispatch sent messages to windows owned by the web process when waiting a sync CoreIPC reply
On Windows, windowed plugins' HWNDs are created as children of the WKView's window. This
creates a cross-process window hierarchy, which in turn attaches the input states of the UI
process's and web process's main threads (as if ::AttachThreadInput has been called). Having
the input states attached means that changes to the input state (e.g., changing the focus
window) can result in synchronous window messages being sent between the processes. This can
result in deadlocks if the UI process changes the input state while handling a synchronous
CoreIPC message from the web process. Since the web process isn't running its message loop
while waiting for the reply, it never processes the messages Windows is sending it from the
UI process.
The solution taken in this patch is to continue to dispatch sent (not posted) messages to
windows created by the web process while waiting for a sync CoreIPC reply. Someday we can
hopefully reduce the number of cases in which the UI process modifies the thread's input
state while handling a synchronous message; see the bug for details.
Fixes <http://webkit.org/b/58239> <rdar://problem/8769302> REGRESSION (WebKit2): Deadlock
clicking Flash plugin
Reviewed by Anders Carlsson.
* Platform/CoreIPC/BinarySemaphore.h:
(CoreIPC::BinarySemaphore::event): Added. Simple getter to expose the underlying event
HANDLE.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SyncMessageState::waitWhileDispatchingSentMessages): New Windows-only
function that is used instead of wait() so that sent messages will continue to be
dispatched.
(CoreIPC::Connection::waitForSyncReply): Use waitWhileDispatchingSentMessages instead of
wait on Windows. Our Client gives us the set of windows that need to have windows delivered
to them.
* Platform/CoreIPC/Connection.h: Added new
windowsToReceiveSentMessagesWhileWaitingForSyncReply function to Client.
* Platform/RunLoop.h: Added new dispatchSentMessagesUntil function to be used while waiting
for a sync CoreIPC reply.
* Platform/win/RunLoopWin.cpp:
(RunLoop::dispatchSentMessagesUntil): Added. If we have no windows to dispatch messages to,
then just wait on the semaphore. Otherwise spin a ::MsgWaitForMultipleObjectsEx loop to
detect when the semaphore is signaled, the timeout elapses, or sent messages are available,
and handle each case appropriately.
* UIProcess/WebProcessProxy.h: Added new CoreIPC::Connection::Client function.
* UIProcess/win/WebProcessProxyWin.cpp: Added.
(WebKit::WebProcessProxy::windowsToReceiveSentMessagesWhileWaitingForSyncReply): Just return
an empty Vector. The web process never modifies the thread's input state while responding to
a synchronous message, so we don't have anything to worry about here.
* WebProcess/WebProcess.h: Added new CoreIPC::Connection::Client function.
* WebProcess/win/WebProcessWin.cpp:
(WebKit::addWindowToVectorIfOwnedByCurrentThread): New helper function to be called by
::EnumThreadWindows/::EnumChildWindows. Does what it says.
(WebKit::WebProcess::windowsToReceiveSentMessagesWhileWaitingForSyncReply): Added. Returns
all top-level windows created by this thread, descendants of those windows created by this
thread, and descendants of WKViews' windows created by this thread.
* win/WebKit2.vcproj: Added WebProcessProxyWin.cpp.
2011-04-11 Jessie Berlin <jberlin@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862
Part 7: Implement getGuessesForWord, learnWord, and ignoreWord.
* UIProcess/API/C/win/WKTextChecker.cpp:
(WKTextCheckerChangeSpellingToWord):
* UIProcess/API/C/win/WKTextChecker.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::changeSpellingToWord):
Make this function const since it does not modify the WebPageProxy and making it const
allows WebTextChecker::changeSpellingToWord to take a const WebPageProxy.
(WebKit::WebPageProxy::learnWord):
* UIProcess/WebPageProxy.h:
* UIProcess/TextChecker.h:
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::getGuessesForWord):
Ask the TextCheckerClient for the guesses.
(WebKit::TextChecker::learnWord):
Tell the TextCheckerClient.
(WebKit::TextChecker::ignoreWord):
Ditto.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::learnWord):
Add an unused param that is necessary for Windows.
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::learnWord):
Ditto.
* UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::learnWord):
Ditto.
* UIProcess/win/WebTextChecker.cpp:
(WebKit::WebTextChecker::changeSpellingToWord):
Tell the page.
* UIProcess/win/WebTextChecker.h:
* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::guessesForWord):
(WebKit::WebTextCheckerClient::learnWord):
(WebKit::WebTextCheckerClient::ignoreWord):
* UIProcess/win/WebTextCheckerClient.h:
2011-04-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Remove unused WebProcessProxy functions
https://bugs.webkit.org/show_bug.cgi?id=58262
* UIProcess/WebProcessProxy.cpp:
* UIProcess/WebProcessProxy.h:
2011-04-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash in WebPageProxy::countStringMatches
https://bugs.webkit.org/show_bug.cgi?id=58255
<rdar://problem/9243837>
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::countStringMatches):
Return early if the page is not valid.
2011-04-11 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKit2: links don’t update to look visited
<rdar://problem/8806254>
https://bugs.webkit.org/show_bug.cgi?id=58252
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
* WebProcess/WebProcess.h:
Remove use of vestigial sharedPageGroup and instead iterate set of
page groups in use by the process.
2011-04-11 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
WebKit2: Windows 7 Gestures Window Bounce shouldn't require a sync message
https://bugs.webkit.org/show_bug.cgi?id=58167
<rdar://problem/9259813>
Instead of making GestureDidScroll sync, have WebPageWin call from WebProcess ->
UIProcess when the gesture causes the page to scroll to the beginning or the
end of the document.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::gestureDidScroll): Not a sync message anymore.
(WebKit::WebPageProxy::setGestureScrollingLimitReached): Tell the page client that the gesture
scrolling limnit was reached.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: Add a new message.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Initialize new variable.
(WebKit::WebView::onGesture): Use the state of the member variable, not the response from
the sync message.
* UIProcess/win/WebView.h:
(WebKit::WebView::setGestureScrollingLimitReached):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::scrollbarAtTopOfBottomOrDocument): Returns whether or not the scrollbar is at the
top or bottom of the document.
(WebKit::WebPage::gestureDidScroll): Track whether or not we started at the beginning
or end of the document, and whether or not we ended at the beginning or end of the document,
and send a message if the value changed.
2011-04-04 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
WK2: PDF: Find in page
https://bugs.webkit.org/show_bug.cgi?id=57765
Support searching text within PDF documents. Find requests must be routed from the
WebPageProxy, through the PageClient, and to the WKView, where they can be passed to
the PDFViewController.
* UIProcess/API/mac/PDFViewController.h:
* UIProcess/API/mac/PDFViewController.mm:
(_PDFSelectionsAreEqual): Copied from WebPDFView.
(-[WKPDFView _nextMatchFor:direction:caseSensitive:wrap:fromSelection:startInSelection:]): Copied from WebPDFView.
(-[WKPDFView _countMatches:caseSensitive:]): Added.
(WebKit::PDFViewController::findString): Added.
(WebKit::PDFViewController::countStringMatches): Added.
* UIProcess/PageClient.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::findStringInCustomRepresentation): Added.
(WebKit::PageClientImpl::countStringMatchesInCustomRepresentation): Added.
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _findStringInCustomRepresentation:withFindOptions:maxMatchCount:]): Added.
(-[WKView _countStringMatchesInCustomRepresentation:withFindOptions:maxMatchCount:]): Added.
* UIProcess/WebPageProxy.h: Moved a number of find-related functions from private: to public: so
they could be called from PDFViewController.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findString): Added.
(WebKit::WebPageProxy::countStringMatches): Added.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::findStringInCustomRepresentation): Added stub.
(WebKit::WebView::countStringMatchesInCustomRepresentation): Ditto.
* UIProcess/win/WebView.h:
* UIProcess/API/qt/qwkpage_p.h:
(QWKPagePrivate::findStringInCustomRepresentation): Added stub.
(QWKPagePrivate::countStringMatchesInCustomRepresentation): Added stub.
2011-04-11 Jessie Berlin <jberlin@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862
Part 6: Update the Spelling UI with the spelling and grammar mistakes.
* UIProcess/API/C/win/WKAPICastWin.h:
(WebKit::toAPI):
Make it possible to go from a WebCore::GrammarDetail to a WebGrammarDetail.
* UIProcess/API/C/win/WKGrammarDetail.cpp:
(WKGrammarDetailCreate):
(WKGrammarDetailGetLocation):
(WKGrammarDetailGetLength):
(WKGrammarDetailCopyGuesses):
(WKGrammarDetailCopyUserDescription):
* UIProcess/API/C/win/WKGrammarDetail.h:
* UIProcess/API/C/win/WKTextChecker.cpp:
(WKTextCheckerCheckSpelling):
Tell the WebTextChecker.
* UIProcess/API/C/win/WKTextChecker.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
If the show/hide spelling UI is selected and the spelling UI is not showing, make sure to
advance to the next misspelling (in this case, the first).
This behavior matches that in WebCore and WKView.mm.
(WebKit::WebPageProxy::advanceToNextMisspelling):
Make this function const since it does not modify the WebPageProxy and making it const
allows WebTextChecker::checkSpelling to take a const WebPageProxy.
(WebKit::WebPageProxy::spellDocumentTag):
(WebKit::WebPageProxy::updateSpellingUIWithMisspelledWord):
(WebKit::WebPageProxy::updateSpellingUIWithGrammarString):
* UIProcess/WebPageProxy.h:
* UIProcess/TextChecker.h:
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::uniqueSpellDocumentTag):
Tell the TextCheckerClient which WebPageProxy this tag is for.
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
Tell the TextCheckerClient.
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
Ditto.
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::uniqueSpellDocumentTag):
Add the new argument that is unused by this port.
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
Ditto.
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
Ditto.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::uniqueSpellDocumentTag):
Ditto.
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
Ditto.
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
Ditto.
* UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::uniqueSpellDocumentTag):
Ditto.
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
Ditto.
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
Ditto.
* UIProcess/win/WebGrammarDetail.cpp:
(WebKit::WebGrammarDetail::create):
(WebKit::WebGrammarDetail::WebGrammarDetail):
(WebKit::WebGrammarDetail::guesses):
* UIProcess/win/WebGrammarDetail.h:
(WebKit::WebGrammarDetail::location):
(WebKit::WebGrammarDetail::length):
(WebKit::WebGrammarDetail::userDescription):
* UIProcess/win/WebTextChecker.cpp:
(WebKit::WebTextChecker::checkSpelling):
Tell the page to advance to the next misspelling. This matches the WK1 WebView.cpp logic.
* UIProcess/win/WebTextChecker.h:
* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::uniqueSpellDocumentTag):
(WebKit::WebTextCheckerClient::toggleSpellingUIIsShowing):
(WebKit::WebTextCheckerClient::updateSpellingUIWithMisspelledWord):
(WebKit::WebTextCheckerClient::updateSpellingUIWithGrammarString):
* UIProcess/win/WebTextCheckerClient.h:
2011-04-10 Maciej Stachowiak <mjs@apple.com>
Not reviewed.
Remove extra inadvertantly commiteed changes from last change.
* WebProcess/com.apple.WebProcess.sb:
2011-04-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
REGRESSION: WebProcess spews sandboxing violations for outbound network traffic
https://bugs.webkit.org/show_bug.cgi?id=58215
<rdar://problem/9251695>
* WebProcess/com.apple.WebProcess.sb: Restore some previously removed rules.
2011-04-10 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Eric Seidel.
Require no undefined symbols during compilation.
[Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
https://bugs.webkit.org/show_bug.cgi?id=54896
Add -Wl,--no-undefined to catch missing symbols early.
* WebProcess.pro:
2011-04-09 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Try recommitting some things svn left out of my last commit.
* WebProcess/Plugins/Netscape/NPJSObject.h:
2011-04-09 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Try recommitting some things svn left out of my last commit.
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::evaluate):
2011-04-08 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
https://bugs.webkit.org/show_bug.cgi?id=58175
<rdar://problem/9060555>
The problem is that command handling should be different for events that come as keyDown:
and those that come as performKeyEquivalent:. WebKit1 only tries custom "key bindings"
when handling a keyDown:, letting a performKeyEquivalent: run through the whole responder
chain first.
This would be very difficult to implement in WebKit2 because of how it re-sends the same
event after web process handling. Luckily, we can both fix the bug and make the behavior
more robust by not hardcoding key combinations.
* WebProcess/WebPage/WebPage.h: Edit performNonEditingBehaviorForSelector.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::executeKeypressCommandsInternal): When executing commands, also try
executing editor commands in their non-editing meaning, which is usually scrolling.
(WebKit::WebPage::performNonEditingBehaviorForSelector): Naive implementation with a chain
of ifs, which is hopefully ok performance-wise for a dozen check.
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): Only kept two commands here that I
couldn't easily move.
2011-04-08 Jessie Berlin <jberlin@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Show the substitutions panel on Mac and make sure the menu items titles are
updated correctly.
https://bugs.webkit.org/show_bug.cgi?id=58179
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]):
The title of the context menu item should be opposite of whether or not the spelling panel
is visible.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
If the "Show/Hide" Substitutions item is selected, call toggleSubstitutionsPanelIsShowing.
(WebKit::WebPageProxy::substitutionsPanelIsShowing):
Ask the TextChecker.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/TextChecker.h:
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::substitutionsPanelIsShowing):
As the shared NSSpellChecker if the substitutionsPanel is visible.
(WebKit::TextChecker::toggleSubstitutionsPanelIsShowing):
Order the substitutionsPanel out or front (copied from WKView.mm).
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::substitutionsPanelIsShowing):
Send a sync message to the UI process to find out.
It needs to be sync because the editor code relies on the value returned.
2011-04-08 Dan Bernstein <mitz@apple.com>
Reviewed by Adele Peterson.
Fixed a bug where right-to-left frames incorrectly reported that they were pinned to the left
when they were actually not.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeScrollOffsetForMainFrame): Do not assume that the minimum scroll offset
is zero, because it is not.
2011-04-08 Anders Carlsson <andersca@apple.com>
Fix the Windows build.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::Drop):
2011-04-08 Jessie Berlin <jberlin@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862
Part 5: Implement the code show and hide the Spelling UI via the context menu item (both
Windows and Mac).
* UIProcess/API/C/win/WKTextChecker.h:
Add the new WKTextCheckerClient funtions.
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]):
The title of the context menu item should be opposite of whether or not the spelling panel
is visible.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
If the "Show/Hide Spelling and Grammar" item is selected, call toggleSpellingUIIsShowing.
(WebKit::WebPageProxy::spellingUIIsShowing):
Call through to TextChecker.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/TextChecker.h:
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::spellingUIIsShowing):
Call the TextCheckerClient.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::spellingUIIsShowing):
Ask the shared NSSpellChecker if the spellingPanel is visible.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Order the spellingPanel out or front (copied from WKView.mm).
* UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::spellingUIIsShowing):
Call notImplemented.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::spellingUIIsShowing):
Ditto.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.
* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::spellingUIIsShowing):
Call the client.
(WebKit::WebTextCheckerClient::toggleSpellingUIIsShowing):
Ditto.
* UIProcess/win/WebTextCheckerClient.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::spellingUIIsShowing):
Send a sync message to the UI process to find out.
It needs to be sync because the Editor code relies on the value returned.
2011-04-08 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Sandboxing doesn't work if a local file is dropped on the content area
https://bugs.webkit.org/show_bug.cgi?id=58177
<rdar://problem/9019253>
When performing a drag and the dragging pasteboard contains a local file, create a
sandbox extension and pass it along. If we end up loading the file, the sandbox extension
tracker will consume the extension.
* UIProcess/API/mac/WKView.mm:
(maybeCreateSandboxExtensionFromPasteboard):
Add helper function.
(-[WKView performDragOperation:]):
Create a sandbox extension handle and pass it to performDrag.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
Pass an empty sandbox extension handle to performDragControllerAction.
(WebKit::WebPageProxy::performDrag):
Pass the sandbox extension handle along to performDragControllerAction.
(WebKit::WebPageProxy::performDragControllerAction):
Send along the sandbox extension handle.
* WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::willPerformDragDestinationAction):
If the destination action is a load action, call WebPage::willPerformLoadDragDestinationAction.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
Create a sandbox extension.
(WebKit::WebPage::willPerformLoadDragDestinationAction):
If we have a sandbox extension, pass it along to the sandbox extension tracker.
(WebKit::WebPage::SandboxExtensionTracker::willPerformLoadDragDestinationAction):
Call setPendingProvisionalSandboxExtension.
(WebKit::WebPage::SandboxExtensionTracker::beginLoad):
Call setPendingProvisionalSandboxExtension.
(WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension):
Factor code from beginLoad out into a separate function.
* WebProcess/WebPage/WebPage.messages.in:
PerformDragControllerAction now takes a sandbox extension handle.
2011-04-08 Alice Liu <alice.liu@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=58151
Crash after closing a Webview, in WebKit!WebCore::WindowMessageBroadcaster::SubclassedWndProc
* UIProcess/win/WebView.cpp:
(WebKit::WebView::close):
Resolve a difference between old WebKit WebView and WebKit2 WebView by destroying and clearing
out WebKit2 WebView's HWND when closing. Not doing so was causing the WebView to remain in the
list of WindowMessageBroadcaster listeners, and after closing the WebView, WindowMessageBroadcaster
would message a dead WebView and crash.
2011-04-08 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Make the drag operations be different functions
https://bugs.webkit.org/show_bug.cgi?id=58169
Since we want performDrag to take a sandbox extension, separate the four
drag operations out into different functions. No functionality change.
* UIProcess/API/mac/WKView.mm:
(-[WKView draggingEntered:]):
(-[WKView draggingUpdated:]):
(-[WKView draggingExited:]):
(-[WKView performDragOperation:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDrag):
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::DragEnter):
(WebKit::WebView::DragOver):
(WebKit::WebView::DragLeave):
(WebKit::WebView::Drop):
2011-04-08 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Parse 'DispatchOnConnectionQueue' in messages.in files
https://bugs.webkit.org/show_bug.cgi?id=58168
Handle parsing multiple, space-separated attributes in .messages.in files. Keep track of
'DispatchOnConnectionQueue' and rename 'delayed' to 'Delayed'.
* Scripts/webkit2/messages.py:
* Scripts/webkit2/messages_unittest.py:
2011-04-08 Alpha Lam <hclam@chromium.org>
Unreviewed, rolling out r83335.
http://trac.webkit.org/changeset/83335
https://bugs.webkit.org/show_bug.cgi?id=53556
GTK and QT bots are broken
* Configurations/FeatureDefines.xcconfig:
2011-04-07 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Setup ENABLE(TRACK) feature define
https://bugs.webkit.org/show_bug.cgi?id=53556
* Configurations/FeatureDefines.xcconfig:
2011-04-07 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Alder.
REGRESSION (WebKit2): AppKit thinks that web views don't support DocumentAccess
https://bugs.webkit.org/show_bug.cgi?id=58102
<rdar://problem/9223246>
* UIProcess/API/mac/WKView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView doCommandBySelector:]):
(-[WKView insertText:replacementRange:]):
(-[WKView validAttributesForMarkedText]):
(-[WKView setMarkedText:selectedRange:replacementRange:]):
(-[WKView attributedSubstringForProposedRange:actualRange:]):
(-[WKView firstRectForCharacterRange:actualRange:]):
Switch to NSTextInputClient, opting out of optimizations and optional features for now.
2011-04-08 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Martin Robinson.
[Qt][WK2][Symbian] Remove use of stack arrays with variable size
https://bugs.webkit.org/show_bug.cgi?id=57877
For better compiler portability, use new/delete for arrays when size
isn't known at compile time. Also fix one compiler warning about bitshift
operations on signed integer
* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::sendOutgoingMessage):
2011-04-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix the WebKit2 build for older versions of GTK+
https://bugs.webkit.org/show_bug.cgi?id=58095
* UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Include the GtkVersioning.h header.
2011-04-07 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[WK2][Qt][GTK] Introduce common use flag for the shared UNIX domain socket IPC implementation
https://bugs.webkit.org/show_bug.cgi?id=58030
Replace "PLATFORM(QT) || PLATFORM(GTK)" conditions in IPC code with
USE(UNIX_DOMAIN_SOCKETS).
* Platform/CoreIPC/Attachment.h:
* Platform/CoreIPC/Connection.h:
* Platform/SharedMemory.h:
2011-04-07 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Clicks not recognized on http://www.nibblestutorials.net/ which uses Silverlight
https://bugs.webkit.org/show_bug.cgi?id=58108
<rdar://problem/9167611>
Change platformHandleMouseEvent to return true, which means that the plug-in has handled the
event. Some plug-ins (like Silverlight) will return false from NPP_HandleEvent even though the
event has been handled. In this case it lead to a very subtle bug where the plug-in element would
lose focus right after a mouse down even had been sent.
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformHandleMouseEvent):
2011-04-07 Adam Roben <aroben@apple.com>
Pass NPP_SetWindow a null window handle during plugin destruction on non-Mac platforms
This matches WebKit1.
Fixes <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
plugin
Reviewed by Anders Carlsson.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::destroy): Null out our NPWindow's window handle and pass it to
NPP_SetWindow (unless we're on Mac).
2011-04-08 Jamie Cooley <james.cooley@nokia.com>
Reviewed by Benjamin Poulain.
[Qt][WK2] Make sure qwkhistory.h is copied into includes/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57945
* UIProcess/API/qt/WKView.h:
* UIProcess/API/qt/qwkhistory.h:
2011-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Do not destroy WorkQueue event sources unless they have been cancelled
https://bugs.webkit.org/show_bug.cgi?id=57611
* Platform/WorkQueue.h:
* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::EventSource): Remove unused member
m_dispatchSource.
(WorkQueue::EventSource::executeEventSource): Make it return void
instead of boolean since we are always ignoring the return value.
(WorkQueue::EventSource::performWork): Return FALSE from the
callback only when the source has been cancelled (condition = 0)
to make sure it's destroyed when the even source handler is
unregistered.
(WorkQueue::registerEventSourceHandler): Use GRefPtr for the
source, to avoid leaking it.
(WorkQueue::scheduleWorkOnSource): Receive the source callback as
parameter so that it can be used by scheduleWorkOnTermination() too.
(WorkQueue::scheduleWork):
(WorkQueue::scheduleWorkAfterDelay):
(WorkQueue::scheduleWorkOnTermination): Use
scheduleWorkOnSource().
2011-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Close connection when web process finishes
https://bugs.webkit.org/show_bug.cgi?id=57540
* Platform/CoreIPC/Connection.h:
* Platform/CoreIPC/unix/ConnectionUnix.cpp:
* Platform/PlatformProcessIdentifier.h: Use GPid as process
identifier.
* Platform/WorkQueue.h:
* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::EventSource): Add cancellable parameter.
(WorkQueue::EventSource::cancel): New method to cancel the source.
(WorkQueue::EventSource::performWorkOnTermination): New method to
execute a work item called when child process has finished.
(WorkQueue::registerEventSourceHandler): Create a GCancellable for
the socket source.
(WorkQueue::unregisterEventSourceHandler): Cancel the source
instead of destroying it, this will cause the source to trigger
with condition = 0, which makes the callback return FALSE and the
source is destroyed.
(WorkQueue::scheduleWorkOnSource): Pass NULL as cancellable for
idle and timeout sources.
(WorkQueue::scheduleWorkOnTermination): Create a child watch
source to monitor the child process.
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess): Use GPid instead of int
as process identifier.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didFinishLaunching): Call
WorkQueue::scheduleWorkOnTermination() for GTK platform too when
web process has been launched.
2011-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement scheduleWorkAfterDelay() in WorkQueueGtk
https://bugs.webkit.org/show_bug.cgi?id=57434
* Platform/WorkQueue.h:
* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::executeEventSource): This new method
contains the common code to execute a work item.
(WorkQueue::EventSource::performWorkOnce): Use
executeEventSource() to execute the work item.
(WorkQueue::EventSource::performWork): Use executeEventSource() to
execute the work item.
(WorkQueue::registerEventSourceHandler): Use a GSocket instead of
a GIOChannel since the API is newer and allows us to pass a
cancellable object to be able to cancel the source.
(WorkQueue::scheduleWorkOnSource): This new method contains the
common code to attach a source to a context. It doesn't use a lock
anymore, since g_source_attach() uses its own mutex internally.
(WorkQueue::scheduleWork): Use an idle source instead of a timeout
one, changing the priority to G_PRIORITY_DEFAULT.
(WorkQueue::scheduleWorkAfterDelay): Implement it using a timeout
source with the given delay.
2011-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Use glib API instead of fork + execl in ProcessLauncherGtk
https://bugs.webkit.org/show_bug.cgi?id=57234
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::childSetupFunction): close the socket and use prctl()
when platform is Linux to kill the child process when the parent
finishes.
(WebKit::ProcessLauncher::launchProcess): Use g_spawn_async() to
launch the web process.
2011-04-07 Geoffrey Garen <ggaren@apple.com>
Some Handle<T> cleanup
https://bugs.webkit.org/show_bug.cgi?id=58109
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::NPJSObject): Updated for new null constructor.
2011-04-07 Jessie Berlin <jberlin@apple.com>
Max build fix.
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::checkSpellingOfString):
Do not risk an overflow.
(WebKit::WebEditorClient::checkGrammarOfString):
Ditto.
2011-04-07 Jessie Berlin <jberlin@apple.com>
Reviewed by Brian Weinstein.
WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862
Part 4: Implement checkGrammarOfString.
* Scripts/webkit2/messages.py:
The generated files should include TextCheckerClient.h for WebCore::GrammarDetail.
* Shared/API/c/win/WKBaseWin.h:
* Shared/APIObject.h:
* UIProcess/API/C/win/WKAPICastWin.h:
* UIProcess/API/C/win/WKGrammarDetail.cpp: Added.
(WKGrammarDetailGetTypeID):
(WKGrammarDetailCreate):
* UIProcess/API/C/win/WKGrammarDetail.h: Added.
* UIProcess/API/C/win/WKTextChecker.h:
Add the checkGrammarOfString WKTextCheckerClient function.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::checkGrammarOfString):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/TextChecker.h:
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::checkGrammarOfString):
Call the TextCheckerClient.
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::checkSpellingOfString):
Add a comment about this not being used on Mac.
(WebKit::TextChecker::checkGrammarOfString):
Ditto, and call notImplemented.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::checkGrammarOfString):
Call notImplemented.
* UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::checkGrammarOfString):
Ditto.
* UIProcess/win/WebGrammarDetail.cpp: Added.
(WebKit::WebGrammarDetail::create):
(WebKit::WebGrammarDetail::WebGrammarDetail):
Initialize the underlying WebCore::GrammarDetail.
* UIProcess/win/WebGrammarDetail.h: Added.
(WebKit::WebGrammarDetail::grammarDetail):
(WebKit::WebGrammarDetail::type):
* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::checkGrammarOfString):
Populate the Vector of WebCore::GrammarDetails with the WebGrammarDetails.
* UIProcess/win/WebTextCheckerClient.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::checkSpellingOfString):
Use WTF::notFound as the initial value for resultLocation.
(WebKit::WebEditorClient::checkGrammarOfString):
Send a sync message to the UI Process (similar to checkSpellingOfString and checkTextOfParagraph).
* win/WebKit2.vcproj:
Add WKGrammarDetail.h/.cpp and WebGrammarDetail.h/.cpp.
* win/WebKit2Generated.make:
Copy over WKGrammarDetail.h.
2011-04-07 Enrica Casucci <enrica@apple.com>
Reviewed by Oliver Hunt.
REGRESSION(WebKit2): execCommand('undo') doesn't work (Windows).
https://bugs.webkit.org/show_bug.cgi?id=58056
<rdar://problem/8862023>
Adding support for execCommand('undo') and execCommand('redo')
in WebKit2 for Windows.
* UIProcess/API/C/win/WKView.h:
* UIProcess/win/WebUndoClient.cpp:
(WebKit::WebUndoClient::canUndoRedo):
(WebKit::WebUndoClient::executeUndoRedo):
* UIProcess/win/WebUndoClient.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):
2011-04-07 Andrew Scherkus <scherkus@chromium.org>
Revert ENABLE_TRACK patch due to compile failures.
* Configurations/FeatureDefines.xcconfig:
2011-04-07 Martin Robinson <mrobinson@igalia.com>
Fix the WebKit2 GTK+ build for older versions of GTK+.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Include the GtkVersioning.h header.
2011-04-07 Amruth Raj <amruthraj@motorola.com> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Kenneth Rohde Christiansen.
[GTK] Implement SharedMemory for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49791
Share the SharedMemory, Attachment and Connection implementations with the Qt port.
Both implementation are, in fact, general Unix implementations using standard Unix
domain sockets and sendmsg / recvmsg. This should reduce the amount of duplicated code
greatly and lay the groundwork for GTK+/Qt implementations for other operating systems.
* GNUmakefile.am: Replaced GTK+ versions of files with the Unix ones.
* Platform/CoreIPC/ArgumentDecoder.cpp: Extended Qt #ifdefs to include GTK.
(CoreIPC::ArgumentDecoder::~ArgumentDecoder):
* Platform/CoreIPC/ArgumentEncoder.cpp: Ditto.
(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
* Platform/CoreIPC/Attachment.h: Ditto.
* Platform/CoreIPC/Connection.h: Combined the GTK+ and Qt sections.
* Platform/CoreIPC/unix/AttachmentUnix.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/qt/AttachmentQt.cpp.
* Platform/CoreIPC/unix/ConnectionUnix.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/qt/ConnectionQt.cpp.
* Platform/unix/SharedMemoryUnix.cpp: Renamed from Source/WebKit2/Platform/qt/SharedMemoryQt.cpp.
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM instead of SOCK_STREAM to match Qt.
* WebKit2.pro: Updated source list to reflect file renaming.
2011-04-07 Alexey Proskuryakov <ap@apple.com>
Reviewed by Brian Weinstein.
REGRESSION (r83081): Use of deallocated memory in WebEditorClient::respondToChangedSelection()
https://bugs.webkit.org/show_bug.cgi?id=58082
* WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::respondToChangedSelection):
Now that the Range is used outside the full expression where it's created, it needs to be
protected with RefPtr.
2011-04-07 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/9251566> WebBackForwardList::createCFDictionaryRepresentation's current item index
doesn't account for items removed by filter callback.
* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Update the current item index
when we omit an item due to the filter callback.
2011-04-07 Alexey Proskuryakov <ap@apple.com>
Reviewed by Anders Carlsson.
REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
https://bugs.webkit.org/show_bug.cgi?id=58066
<rdar://problem/8965302>
* Scripts/webkit2/messages.py:
* Shared/mac/AttributedString.h: Added.
* Shared/mac/AttributedString.mm: Added.
(WebKit::AttributedString::encode):
(WebKit::AttributedString::decode):
Added an class that wraps NSAttributedString. As far as I can tell, one can't pass a CF
or NS object to another process without wrapping it in a C++ one.
* Shared/mac/ArgumentCodersMac.h: Added.
* Shared/mac/ArgumentCodersMac.mm: Added.
Added coders for Foundation objects, similar to ArgumentCodersCF. There are two reasons why
these are needed:
1) Even though most Foundation objects are toll free bridged with CF, CFGetTypeID() doesn't
work properly for them (I've been just getting 1).
2) NSColor isn't toll free bridged to CF.
This adds just the types necessary for editing NSAttributedString (and I don't yet know what
happens with attachments).
* UIProcess/API/mac/WKView.mm: (-[WKView attributedSubstringFromRange:]):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::getAttributedSubstringFromRange):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
Boilerplate code for making a sync call to web process.
* WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getAttributedSubstringFromRange):
Ported from WebHTMLView.
2011-04-07 Jeff Miller <jeffm@apple.com>
Mac build fix.
* Shared/WebString.h:
(WebKit::WebString::getCharacters): Add explict cast when using std::min().
2011-04-07 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
https://bugs.webkit.org/show_bug.cgi?id=58058
WKStringGetCharactersPtr() exposes the internal implementation of WKString, so change this to WKStringGetCharacters(), which makes a UTF-16 copy.
* Shared/API/c/WKString.cpp:
(WKStringGetCharacters): Added, replaces WKStringGetCharactersPtr().
* Shared/API/c/WKString.h: Replaced WKStringGetCharactersPtr() with WKStringGetCharacters().
* Shared/WebString.h:
(WebKit::WebString::getCharacters): Added.
2011-04-07 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
WebKit2: Support window bounce when panning.
https://bugs.webkit.org/show_bug.cgi?id=58065
<rdar://problem/9244367>
Make gestureDidScroll synchronous, as once we scroll, we need to know
whether or not we are at the beginning or end of the scrollable document.
If we are at either end of the scrollable document, we call the Windows 7
API to bounce the window to give an indication that you are past an end
of the document.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::gestureDidScroll): Pass a boolean for the reply, and return it.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Inititalize a new variable.
(WebKit::WebView::onGesture): Once we send the message to scroll, check if have gone to
an end of the document, and if we have, bounce the window.
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: GestureDidScroll is now sync.
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::gestureDidScroll): When we are done scrolling, check if we have a vertical
scrollbar and if we are at the beginning or the end of the scrollable document.
2011-04-07 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.isPageBoxVisible
https://bugs.webkit.org/show_bug.cgi?id=42695
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleIsPageBoxVisible):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::isPageBoxVisible):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-07 Enrica Casucci <enrica@apple.com>
Reviewed by Oliver Hunt.
REGRESSION(WebKit2): execCommand('undo') doesn't work (Mac).
https://bugs.webkit.org/show_bug.cgi?id=58055
<rdar://problem/8862023>
Adding support for execCommand('undo') and execCommand('redo')
in WebKit2 for Mac.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::canUndoRedo): Added interaction with undomanager.
(WebKit::PageClientImpl::executeUndoRedo): Added interaction with undomanager.
Added new empty PageClient methods for other platforms.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::canUndoRedo):
(QWKPagePrivate::executeUndoRedo):
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/PageClient.h:
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):
* UIProcess/gtk/WebView.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):
* UIProcess/win/WebView.h:
* UIProcess/WebEditCommandProxy.cpp:
(WebKit::WebEditCommandProxy::unapply): Added flag to allow dispatching
of asychronous messages while waiting for a sync message reply.
(WebKit::WebEditCommandProxy::reapply): Same as above.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canUndoRedo):
(WebKit::WebPageProxy::executeUndoRedo):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebEditorClient.cpp: Added missing implementation.
(WebKit::WebEditorClient::canUndo):
(WebKit::WebEditorClient::canRedo):
(WebKit::WebEditorClient::undo):
(WebKit::WebEditorClient::redo):
2011-04-07 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9250368> and https://bugs.webkit.org/show_bug.cgi?id=58062
* UIProcess/API/C/WKIconDatabase.cpp:
(WKIconDatabaseClose):
* UIProcess/API/C/WKIconDatabase.h:
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::close):
* UIProcess/WebIconDatabase.h:
2011-04-07 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862
Part 3: Implement checkSpellingOfString
In WebCore, checkTextOfParagraph is only defined and used on platforms where
WTF_USE_UNIFIED_TEXT_CHECKING is defined (which right now is only non-Leopard and non-Tiger
Mac builds).
On other platforms, checkSpellingOfString and checkGrammarOfString (coming in a separate
patch in an attempt to keep things easier to review) are used.
* UIProcess/API/C/win/WKTextChecker.h:
* UIProcess/TextChecker.h:
Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add
checkSpellingOfString.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::checkTextOfParagraph):
Surround this by #if USE(UNIFIED_TEXT_CHECKING).
(WebKit::WebPageProxy::checkSpellingOfString):
Call through to the client.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add
checkSpellingOfString.
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::checkSpellingOfString):
Call through to the WebTextCheckerClient.
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::checkTextOfParagraph):
Surround this by #if USE(UNIFIED_TEXT_CHECKING) for clarity.
(WebKit::TextChecker::checkSpellingOfString):
Add a call to notImplemented.
* UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::checkSpellingOfString):
Ditto, and remove the implementation for checkTextOfParagraph.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::checkSpellingOfString):
Ditto.
* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::checkSpellingOfString):
* UIProcess/win/WebTextCheckerClient.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::checkSpellingOfString):
Send a sync message to the UI Process (similar to the sync message used for
checkTextOfParagraph).
2011-04-07 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][WK2][Symbian] Temporary build fix until native Symbian IPC is done. Implement fake socketpair() as it's not available.
https://bugs.webkit.org/show_bug.cgi?id=57877
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::socketpair): socketpair() which returns -1
2011-04-07 Michael Saboff <msaboff@apple.com>
Reviewed by Maciej Stachowiak.
WebKit2: Memory leak in decodeResourceError
https://bugs.webkit.org/show_bug.cgi?id=58004
Release the local NSError after it is used to create a ResourceError
object assigned to the reference argument.
* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::decodeResourceError):
2011-04-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Remove temporary WebProcess sandbox rules that are unnecessary now that plugins are in their own process
https://bugs.webkit.org/show_bug.cgi?id=58023
* WebProcess/com.apple.WebProcess.sb:
2011-04-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Remove some no longer needed WebProcess sandbox allowances
https://bugs.webkit.org/show_bug.cgi?id=58015
<rdar://problem/9232592>
* WebProcess/com.apple.WebProcess.sb: Remove no-longer needed extra network
and launching privileges, since the bugs that required them are fixed.
2011-04-06 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=57984
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundlePageSizeAndMarginsInPixels):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::pageSizeAndMarginsInPixels):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-06 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Benjamin Poulain.
[Qt][WK2][Symbian] Remove use of stack arrays with variable size
https://bugs.webkit.org/show_bug.cgi?id=57877
For better compiler portability, use new/delete for arrays when size
isn't known at compile time. Also fix one compiler warning about bitshift
operations on signed integers.
* Platform/CoreIPC/qt/ConnectionQt.cpp:
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::sendOutgoingMessage):
2011-04-06 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
WebKit2: Support Windows 7 Gestures
https://bugs.webkit.org/show_bug.cgi?id=49824
<rdar://problem/8689728>
Port code from WebKit1 -> WebKit2 to handle Windows 7 gestures.
The UIProcess gets a WM_GESTURENOTIFY message, it sends a sync message to the WebProcess to ask
if we should allow panning. The WebProcess checks if we're in a scrollable area, and the mouse
isn't over a scrollbar.
The UIProcess then gets a WM_GESTURE message, and if it is a pan gesture, it sends a message to
the WebProcess to scroll by the amount fingers have moved since the last WM_GESTURE messeage. The
X and Y are reversed because panning up -> moving the page down, and vice versa.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::gestureWillBegin): Send a sync message to the WebProcess
to initialize the gesture. The WebProcess returns whether or not we can start a pan
gesture from where we are.
(WebKit::WebPageProxy::gestureDidScroll): Send a message to the WebProcess to scroll by
pan gesture.
(WebKit::WebPageProxy::gestureDidEnd): Send a message to the WebProcess that the gesture has ended.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::wndProc): Add WM_GESTURE and WM_GESTURENOTIFY handlers.
(WebKit::WebView::WebView): Initialize two new variables.
(WebKit::WebView::onGestureNotify): Figure out which gestures we should support based on where
the gesture is beginning.
(WebKit::WebView::onGesture): Support starting a gesture, ending a gesture, and panning.
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Add messages needed for gestures.
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::gestureWillBegin): Set the node that the gesture started on (so we
know which layer to scroll if the user pans), and determine whether or not we should allow
panning. If the page can't scroll, or the user is on a scrollbar, disallow panning.
(WebKit::WebPage::gestureDidScroll): Scroll the enclosing layer of the element the gesture
started on.
(WebKit::WebPage::gestureDidEnd): Clear the node the gesture started on.
2011-04-06 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
Add WKStringGetCharactersPtr() and WKStringGetLength() to WebKit2 C API
https://bugs.webkit.org/show_bug.cgi?id=57989
Note that WKChar, which is returned by WKStringGetCharactersPtr(), is defined the same way we define JSChar in JSStringRef.h.
* Shared/API/c/WKString.cpp:
(WKStringGetLength): Added.
(WKStringGetCharactersPtr): Added.
* Shared/API/c/WKString.h: Define WKChar and added WKStringGetLength() and WKStringGetCharactersPtr().
* Shared/WebString.h:
(WebKit::WebString::length): Added.
(WebKit::WebString::characters): Added.
2011-04-06 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
Dock stays in front of Hulu.com full screen video output
https://bugs.webkit.org/show_bug.cgi?id=57988
<rdar://problem/9216260>
Instead of using -[NSMenu setMenuBarVisible:] to toggle full screen, use
-[NSApp setPresentationOptions:]. Also, make the UI process the front most app before
setting the presentation options when exiting full screen, otherwise the dock won't
be restored correctly.
* PluginProcess/mac/PluginProcessShim.mm:
Remove some shim functions that aren't needed.
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::PluginProcessProxy):
Initialize m_preFullscreenAppPresentationOptions.
* UIProcess/Plugins/PluginProcessProxy.h:
Add m_preFullscreenAppPresentationOptions.
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::enterFullscreen):
Change the presentation options for the app.
(WebKit::PluginProcessProxy::exitFullscreen):
Restore the presentation options.
2011-04-06 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Expose the original URL of a WKBackForwardListItem.
Needed for <rdar://problem/9074651>.
* UIProcess/API/C/WKBackForwardListItem.cpp:
(WKBackForwardListItemCopyOriginalURL):
* UIProcess/API/C/WKBackForwardListItem.h:
2011-04-06 Brady Eidson <beidson@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=57973 and https://bugs.webkit.org/show_bug.cgi?id=57973
WK2 icon database should be able to get a CGImage of a specific size
* UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
(WKIconDatabaseTryGetCGImageForURL): Change this API to take a requested size, and find the first matching
CGImage in the icon.
* UIProcess/API/C/cg/WKIconDatabaseCG.h:
2011-04-06 Jessie Berlin <jberlin@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862
Part 2: Implement uniqueSpellDocumentTag and closeSpellDocumentWithTag.
* UIProcess/API/C/win/WKTextChecker.h:
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::uniqueSpellDocumentTag):
(WebKit::TextChecker::closeSpellDocumentWithTag):
* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::uniqueSpellDocumentTag):
(WebKit::WebTextCheckerClient::closeSpellDocumentWithTag):
* UIProcess/win/WebTextCheckerClient.h:
2011-04-06 Robert Sesek <rsesek@chromium.org>
Reviewed by Alexey Proskuryakov.
Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
https://bugs.webkit.org/show_bug.cgi?id=54969
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection): Moved duplicated code to WebCore
* WebProcess/WebPage/mac/WebPageMac.mm: Moved duplicated code to WebCore
(WebKit::WebPage::getMarkedRange):
(WebKit::WebPage::getSelectedRange):
(WebKit::WebPage::characterIndexForPoint):
(WebKit::WebPage::performDictionaryLookupAtLocation):
2011-04-06 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=42329
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundlePageNumberForElementById):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::pageNumberForElementById):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-05 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
REGRESSION: Drag & Drop Gmail Attachments doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=57909
<rdar://problem/9103220>
Added _hitTest method to support drag and drop when the drag types cannot be matched.
This is the case for elements that do not place content
in the drag pasteboard automatically when the drag start (i.e. dragging a DIV element).
* UIProcess/API/mac/WKView.mm:
(-[WKView _hitTest:dragTypes:]): Added.
2011-04-06 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Darin Adler.
Fix using UNUSED_PARAM introduced in r82907
https://bugs.webkit.org/show_bug.cgi?id=57940
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
2011-04-06 Jessie Berlin <jberlin@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862
Part 1: Get and set the state.
* Shared/API/c/win/WKBaseWin.h:
* Shared/APIObject.h:
* UIProcess/API/C/win/WKAPICastWin.h:
* UIProcess/API/C/win/WKTextChecker.cpp: Added.
(WKTextCheckerSetClient):
(WKTextCheckerContinuousSpellCheckingEnabledStateChanged):
(WKTextCheckerGrammarCheckingEnabledStateChanged):
* UIProcess/API/C/win/WKTextChecker.h: Added.
* UIProcess/TextChecker.h:
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::state):
Do the initalization for the state only once so that it is not necessary to call the client
every time the state is requested.
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
Call the client.
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
Update the state and tell the client.
(WebKit::TextChecker::setGrammarCheckingEnabled):
Ditto.
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
Update the state.
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
Update the state.
* UIProcess/win/WebTextChecker.cpp: Added.
(WebKit::WebTextChecker::shared):
Make the WebTextChecker available globally.
(WebKit::WebTextChecker::WebTextChecker):
(WebKit::WebTextChecker::setClient):
(WebKit::updateStateForAllWebProcesses):
(WebKit::WebTextChecker::continuousSpellCheckingEnabledStateChanged):
Tell the TextChecker that the state has changed, and then tell the
WebProcessProxies to send the new state to the WebProcesses.
(WebKit::WebTextChecker::grammarCheckingEnabledStateChanged):
Ditto.
* UIProcess/win/WebTextChecker.h: Added.
(WebKit::WebTextChecker::client):
(WebKit::WebTextChecker::type):
* UIProcess/win/WebTextCheckerClient.cpp: Added.
(WebKit::WebTextCheckerClient::continuousSpellCheckingAllowed):
(WebKit::WebTextCheckerClient::continuousSpellCheckingEnabled):
(WebKit::WebTextCheckerClient::setContinuousSpellCheckingEnabled):
(WebKit::WebTextCheckerClient::grammarCheckingEnabled):
(WebKit::WebTextCheckerClient::setGrammarCheckingEnabled):
* UIProcess/win/WebTextCheckerClient.h: Added.
* win/WebKit2.vcproj:
Add WKTextChecker.h/.cpp, WebTextChecker.h/.cpp, and WebTextCheckerClient.h/.cpp.
* win/WebKit2Generated.make:
Copy over WKTextChecker.h.
2011-04-05 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=42694
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleNumberOfPages):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::numberOfPages):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-05 Darin Adler <darin@apple.com>
Reviewed by Alexey Proskuryakov.
[Mac] WebKit2: Escape key does not stop page loads when focus is on the web page
https://bugs.webkit.org/show_bug.cgi?id=57893
<rdar://problem/9130486>
* UIProcess/API/mac/PageClientImpl.h: Added executeSavedCommandBySelector.
* UIProcess/API/mac/PageClientImpl.mm: Renamed internal Objective-C classes to use
the WebKit2 Objective-C class prefix, WK, rather than the WebKit1 Objective-C class
prefix, Web. Removed some unneeded explicit WebKit namespace prefixes.
(-[WKEditCommandObjC initWithWebEditCommandProxy:]): Removed unneeded WebKit
namespace prefix.
(-[WKEditCommandObjC command]): Ditto.
(-[WKEditorUndoTargetObjC undoEditing:]): Updated for new class name.
(-[WKEditorUndoTargetObjC redoEditing:]): Ditto.
(WebKit::PageClientImpl::PageClientImpl): Ditto.
(WebKit::PageClientImpl::registerEditCommand): Ditto.
(WebKit::PageClientImpl::executeSavedCommandBySelector): Added.
* UIProcess/API/mac/WKView.mm: Renamed internal Objective-C categories to use the
WebKit2 Objective-C prefix, WK, rather than the WebKit1 Objective-C prefix, Web,
or no prefix at all. Tweaked use of extern "C" a little.
(-[WKView doCommandBySelector:]): Tweaked the comment.
(-[WKView _executeSavedCommandBySelector:]): Added. For use when command is not handled
by WebCore.
(-[WKResponderChainSink initWithResponderChain:]): Added. Based on the
WebResponderChainSink class in WebKit1.
(-[WKResponderChainSink detach]): Added.
(-[WKResponderChainSink didReceiveUnhandledCommand]): Added.
(-[WKResponderChainSink noResponderFor:]): Added.
(-[WKResponderChainSink doCommandBySelector:]): Added.
(-[WKResponderChainSink tryToPerform:with:]): Added.
* UIProcess/API/mac/WKViewInternal.h: Added declaration of _executeSavedCommandBySelector:
method. Also removed unneeded includes.
* UIProcess/PageClient.h: Added executeSavedCommandBySelector.
* UIProcess/WebPageProxy.h: Added executeSavedCommandBySelector.
* UIProcess/WebPageProxy.messages.in: Added ExecuteSavedCommandBySelector.
* UIProcess/mac/WebFullScreenManagerProxyMac.mm: Updated includes.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::executeSavedCommandBySelector): Added.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::executeKeypressCommandsInternal): Send the synchronous
ExecuteSavedCommandBySelector message when a command is not handled by WebCore.
2011-04-05 Anders Carlsson <andersca@apple.com>
Reviewed by Alexey Proskuryakov.
Some plug-in content is displayed upside down in Unity plug-in
https://bugs.webkit.org/show_bug.cgi?id=57895
<rdar://problem/9212003>
Create the flipped geometry layer in the web process instead of the plug-in process,
which matches what we do in WebKit1.
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPostInitialize):
* WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::pluginLayer):
2011-04-05 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Assertion failure when navigating quickly between file URLs
https://bugs.webkit.org/show_bug.cgi?id=57884
<rdar://problem/9080559>
Remove bogus assertion. The pending provisional sandbox extension can be
non-null if the current provisional load fails because we're about to load a new
page that also has a sandbox extension.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):
2011-04-05 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Grant the web process access to ~/Library/Preferences/com.apple.universalaccess.plist
https://bugs.webkit.org/show_bug.cgi?id=57879
The web process needs access to the unviersal access preferences to determine if full keyboard
access is enabled. I've filed <rdar://problem/9237619> which tracks reading this preference in the UI
process and sending it over to the web process whenever it changes.
* WebProcess/com.apple.WebProcess.sb:
2011-04-05 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
Add parentheses around && within || to avoid clang warning.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
2011-04-05 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Add two more entries to the sandbox profile
https://bugs.webkit.org/show_bug.cgi?id=57875
Allow read-access to /Library/Dictionaries since WebCore::nextBreakablePosition
ends up calling into ICU which accesses the dictionary.
Allow Mach access to com.apple.networkd since it's used by CFNetwork.
* WebProcess/com.apple.WebProcess.sb:
2011-04-05 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
Invalidate callbacks if the WebPageProxy is no longer valid
https://bugs.webkit.org/show_bug.cgi?id=57873
<rdar://problem/9059717>
Audit all function calls that take callbacks and make sure to invalidate the callbacks
if the web page is no longer valid.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::getContentsAsString):
(WebKit::WebPageProxy::getSelectionOrContentsAsString):
(WebKit::WebPageProxy::getMainResourceDataOfFrame):
(WebKit::WebPageProxy::getResourceDataFromFrame):
(WebKit::WebPageProxy::getWebArchiveOfFrame):
(WebKit::WebPageProxy::forceRepaint):
(WebKit::WebPageProxy::computePagesForPrinting):
(WebKit::WebPageProxy::drawRectToPDF):
(WebKit::WebPageProxy::drawPagesToPDF):
2011-04-05 Adam Roben <aroben@apple.com>
Disable accelerated compositing on Windows machines that don't support it
This includes machines without the necessary graphics hardware, and machines without
WebKitQuartzCoreAdditions (like the Windows 7 Release (WebKit2 Tests) bots).
Fixes <http://webkit.org/b/57870> REGRESSION (r82960): Lots of tests crashing in
DrawingAreaImpl::enterAcceleratedCompositingMode on Windows 7 Release (WebKit2 Tests)
Reviewed by Anders Carlsson.
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::supportsAcceleratedCompositing): Added. On platforms other than
Windows, this always returns true.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Only enable accelerated compositing-related
preferences if the machine supports accelerated compositing.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::supportsAcceleratedCompositing): Added. Creates a view, asks it
if it can draw, and returns the result.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added supportsAcceleratedCompositing.
* WebProcess/WebPage/win/LayerTreeHostWin.cpp: Added.
(WebKit::LayerTreeHost::supportsAcceleratedCompositing): Added. Calls through to
LayerTreeHostCAWin in configurations that support that class. Otherwise just returns false.
* win/WebKit2.vcproj: Added LayerTreeHostWin.cpp. Let VS reorder some other files.
2011-04-05 Adam Roben <aroben@apple.com>
Make accelerated compositing work in WebKit2 on Windows
LayerTreeHostCAWin uses WKCACFView to render each frame to an image, then has
DrawingAreaImpl send that image over to the UI process (just like it does for
non-accelerated rendering). It's unfortunate that this requires reading every frame back
from the GPU into system memory. More efficient solutions can be explored in the future.
Fixes <http://webkit.org/b/45567>.
Reviewed by Anders Carlsson.
* DerivedSources.make: Added $(WebKit2) to the VPATH so that DerivedSources.make can be
found when used as a target dependency. Added rules to generate a HeaderDetection.h file on
Windows. If we can find WebKitQuartzCoreAdditions headers, we define HAVE_WKQCA in
HeaderDetection.h.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setLayerHostNeedsDisplay):
* WebProcess/WebPage/DrawingAreaImpl.h:
Added setLayerHostNeedsDisplay. Lets the layer host tell the DrawingAreaImpl that it has a
new frame to render. This should only be called by layer hosts that participate in
DrawingAreaImpl's display mechanism.
* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create): Only try to instantiate LayerTreeHostCAWin if we have
WebKitQuartzCoreAdditions, since it depends on that library.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Removed code that forced accelerated compositing to be
disabled on Windows.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::registerDummyWindowClass): Registers the window class we use for the dummy window.
(WebKit::createDummyWindow): Creates the dummy window we pass to WKCACFView so that D3D can
determine the display mode, etc. (The window is never shown on screen.)
(WebKit::LayerTreeHostCAWin::LayerTreeHostCAWin): Initialize new members.
(WebKit::LayerTreeHostCAWin::platformInitialize): Create our dummy window and view and
associate the two. We set ourselves as the view's context's user data so that
PlatformCALayer can get our AbstractCACFLayerTreeHost pointer as needed.
(WebKit::LayerTreeHostCAWin::invalidate): Cancel any pending flushes, tear down our view,
and destroy the dummy window if no other layer host is using it.
(WebKit::LayerTreeHostCAWin::scheduleLayerFlush): Ask LayerChangesFlusher to call us back
soon to perform the flush.
(WebKit::LayerTreeHostCAWin::participatesInDisplay): Added. Returns true, since we render
each frame to an image.
(WebKit::LayerTreeHostCAWin::needsDisplay): Added. Returns true if it's now time to
displayReturns true if it's now time to display.
(WebKit::LayerTreeHostCAWin::timeUntilNextDisplay): Added. Returns how many seconds remain
before we need to display again.
(WebKit::size): Added. Helper function to get the size of a WKCACFImage.
(WebKit::toShareableBitmap): Added. Helper function to convert a WKCACFImage to a
ShareableBitmap.
(WebKit::LayerTreeHostCAWin::display): Added. Renders the next frame to an image and stuffs
the image into the UpdateInfo struct.
(WebKit::LayerTreeHostCAWin::sizeDidChange): Added. Tells the view about the new size.
(WebKit::LayerTreeHostCAWin::forceRepaint): Added. Flushes any pending changes to the view.
(WebKit::LayerTreeHostCAWin::contextDidChangeCallback): Added. WKCACFView calls this
whenever any changes made to the view or its layer tree have been flushed. Just calls
through to contextDidChange.
(WebKit::LayerTreeHostCAWin::contextDidChange): Added. Tells layers that they've started
animating, and tells the DrawingAreaImpl that we need to display again.
(WebKit::LayerTreeHostCAWin::rootLayer): Added. Gets the root layer's PlatformCALayer.
(WebKit::LayerTreeHostCAWin::addPendingAnimatedLayer): Added. Stores the layer so that we
can tell it animations have started the next time we get a contextDidChange callback.
(WebKit::LayerTreeHostCAWin::layerTreeDidChange): Added. Schedules a flush, unless we're
already in the process of flushing. This code came from WebCore::WKCACFViewLayerTreeHost.
(WebKit::LayerTreeHostCAWin::flushPendingLayerChangesNow): Added. Performs the flush. This
code was adapted from WebCore::WKCACFViewLayerTreeHost.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Wrapped this whole header in HAVE(WKQCA),
since this class only works when WebKitQuartzCoreAdditions is available. Added a bunch of
new members.
2011-04-04 Adam Roben <aroben@apple.com>
Add a way for LayerTreeHost to participate in DrawingAreaImpl's normal display mechanism
When LayerTreeHost participates in display, it renders each frame into a bitmap.
DrawingAreaImpl sends the bitmap to the UI process in an Update message, just like in
non-accelerated compositing mode. The UI process never knows that accelerated compositing is
going on. (When LayerTreeHost does not participate in display, as on Mac, it is responsible
for getting bits from the web process to the UI process.)
No LayerTreeHost uses this mechanism (yet). This patch should cause no change in behavior.
Fixes <http://webkit.org/b/57792> LayerTreeHost needs a way to render frames to a bitmap
Reviewed by Anders Carlsson.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint): If the layer tree host participates in display,
perform a display (like in the non-accelerated case).
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers): Don't send an
EnterAcceleratedCompositing message to the UI process if the layer tree host participates in
display. In that case, the UI process doesn't even need to know we're using accelerated
compositing in the web process.
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Go through the normal display
mechanism if we have a layer tree host that participates in display.
(WebKit::DrawingAreaImpl::didUpdate): Don't ignore DidUpdate messages when we have a layer
tree host that participates in display.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): If the new layer tree host
participates in display, let the display timer continue to run and continue to expect
DidUpdate messages so that we don't interrupt the normal display mechanism. We still clear
out m_dirtyRegion, m_scrollRect, and m_scrollOffset, though, because the layer tree host is
still responsible for keeping track of those things even when it participates in display.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): If the outgoing layer tree host
was participating in display, just send another Update message instead of an
ExitAcceleratedCompositing message, since the UI process never even knew we were using
accelerated compositing.
(WebKit::DrawingAreaImpl::displayTimerFired): If we have a layer tree host that's
participating in display, ask it when it next needs to display when scheduling our timer.
(WebKit::DrawingAreaImpl::scheduleDisplay):
(WebKit::DrawingAreaImpl::display):
If we have a layer tree host that's participating in display, it will keep track of its own
dirty region, so ask it if it needs display rather than checking our own dirty region.
(WebKit::DrawingAreaImpl::display): If we have a layer tree host that's participating in
display, don't bail out. Instead, tell it to display rather than asking the page to paint.
Moved the setting of updateInfo.viewSize earlier so that it will be set even when the layer
tree host is displaying. Other changes are just due to indentation.
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::participatesInDisplay):
(WebKit::LayerTreeHost::needsDisplay):
(WebKit::LayerTreeHost::timeUntilNextDisplay):
(WebKit::LayerTreeHost::display):
Stubbed out these functions. Derived classes can override them to participate in display.
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::requestCheckingOfString):
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::checkTextOfParagraph):
2011-04-05 Alejandro G. Castro <alex@igalia.com>
Another compilation fix after r82929 horrible patch merge.
* UIProcess/WebPageProxy.messages.in:
2011-04-05 Alejandro G. Castro <alex@igalia.com>
Fix compilation error after r82929.
* WebProcess/WebPage/WebPage.h:
2011-04-05 Amruth Raj <amruthraj@motorola.com>, Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement WebPage class for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54230
Added functions to handle the generation of commands from the
keycodes.
* GNUmakefile.am:
* Scripts/webkit2/messages.py:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::getEditorCommandsForKeyEvent):
* UIProcess/gtk/WebView.cpp:
(WebKit::backspaceCallback):
(WebKit::selectAllCallback):
(WebKit::cutClipboardCallback):
(WebKit::copyClipboardCallback):
(WebKit::pasteClipboardCallback):
(WebKit::toggleOverwriteCallback):
(WebKit::popupMenuCallback):
(WebKit::showHelpCallback):
(WebKit::deleteFromCursorCallback):
(WebKit::moveCursorCallback):
(WebKit::WebView::WebView):
(WebKit::WebView::getEditorCommandsForKeyEvent):
* UIProcess/gtk/WebView.h:
(WebKit::WebView::addPendingEditorCommand):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp: Added.
(WebKit::WebEditorClient::getEditorCommandsForKeyEvent):
(WebKit::WebEditorClient::executePendingEditorCommands):
(WebKit::WebEditorClient::handleKeyboardEvent):
(WebKit::WebEditorClient::handleInputMethodKeydown):
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/gtk/WebPageGtk.cpp: Added.
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::platformPreferencesDidChange):
(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::platformCanHandleRequest):
2011-04-05 Csaba Osztrogonác <ossy@webkit.org>
Remove duplicate API from WKContext
<rdar://problem/8727879>
https://bugs.webkit.org/show_bug.cgi?id=57815
Unreviewed buildfix after r82906.
Add UNUSED_PARAM to resourceCachesToClear, because
it is only used within #if USE(CFURLCACHE) guard.
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
2011-04-04 Sam Weinig <sam@webkit.org>
Reviewed by Brian Weinstein.
Remove duplicate API from WKContext
<rdar://problem/8727879>
https://bugs.webkit.org/show_bug.cgi?id=57815
- Remove WKContextClearResourceCaches and WKContextClearApplicationCache in favor
of their more modern counterparts WKResourceCacheManagerClearCacheForAllOrigins
and WKApplicationCacheManagerDeleteAllEntries.
- Expand clearing functionality of WKResourceCacheManager by adding type of resources
to clear.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
Remove clearing bools.
* UIProcess/API/C/WKAPICast.h:
(WebKit::toResourceCachesToClear):
Update for new name of enum.
* UIProcess/API/C/WKContext.cpp:
* UIProcess/API/C/WKContext.h:
Remove WKContextClearResourceCaches and WKContextClearApplicationCache.
* UIProcess/API/C/WKResourceCacheManager.cpp:
(WKResourceCacheManagerClearCacheForOrigin):
(WKResourceCacheManagerClearCacheForAllOrigins):
* UIProcess/API/C/WKResourceCacheManager.h:
Add WKResourceCachesToClear enum and use it in the clearing functions.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::ensureWebProcess):
* UIProcess/WebContext.h:
* WebProcess/WebProcess.messages.in:
Remove clearing functions and setting of bools for clear on launch.
* UIProcess/WebFullScreenManagerProxy.cpp:
Remove unnecessary #include.
* UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):
* UIProcess/WebResourceCacheManagerProxy.h:
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
(WebKit::WebResourceCacheManager::clearCacheForAllOrigins):
* WebProcess/ResourceCache/WebResourceCacheManager.h:
* WebProcess/ResourceCache/WebResourceCacheManager.messages.in:
Add enum parameter describing what type of caches to clear.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::clearResourceCaches):
* WebProcess/WebProcess.h:
No longer need to use opaque type now that it is not a message receiver.
2011-04-04 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
Reviewed by Alexey Proskuryakov.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added initialization for
wkSetHTTPPipeliningMaximumPriority().
2011-04-04 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Send NPCocoaEventFlagsChanged events
https://bugs.webkit.org/show_bug.cgi?id=57811
<rdar://problem/9215600>
* Shared/WebEvent.h:
(WebKit::WebEvent::capsLockKey):
Add CapsLock modifier and getter.
* Shared/mac/WebEventFactory.mm:
(WebKit::modifiersForEvent):
Check for NSAlphaShiftKeyMask and set the CapsLockKey modifier.
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::modifierFlags):
Check for CapsLockKey and set NSAlphaShiftKeyMask.
(WebKit::isFlagsChangedEvent):
Return whether a given event is a Cocoa flags changed event.
(WebKit::initializeKeyboardEvent):
If this is a flags changed event, set the event type to NPCocoaEventFlagsChanged.
2011-04-04 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Don't discard the backing stores of WKViews in the key window
https://bugs.webkit.org/show_bug.cgi?id=57808
<rdar://problem/9110793>
<rdar://problem/9194284>
<rdar://problem/9222216>
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setBackingStoreIsDiscardable):
Add empty stub.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
Initialize m_isBackingStoreDiscardable to true.
(WebKit::DrawingAreaProxyImpl::setBackingStoreIsDiscardable):
Set m_isBackingStoreDiscardable and schedule or stop the discard backing store timer.
(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
Don't start the timer if m_isBackingStoreDiscardable is false.
* UIProcess/DrawingAreaProxyImpl.h:
Add m_isBackingStoreDiscardable.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
Mark the backing store as discardable if the view is hidden or if the containing window
is not active.
2011-04-04 Jade Han <jade.han@nokia.com>
Reviewed by Csaba Osztrogonác.
Symbian build fix.
https://bugs.webkit.org/show_bug.cgi?id=54977
* config.h:
2011-04-04 Brady Eidson <beidson@apple.com>
Rubberstamped by Adam Roben.
Add WKIconDatabase* headers to the WebKit2 export for Windows:
* win/WebKit2Generated.make:
2011-04-04 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Get rid of WebContext::process() in more places
https://bugs.webkit.org/show_bug.cgi?id=57787
Migrate calls to WebContext::process() over to sendToAllProcesses and
sendToAllProcessesRelaunchingThemIfNecessary.
Add FIXMEs for things that need to be fixed in order to support multiple web processes.
* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::cancel):
* UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::getSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):
* UIProcess/VisitedLinkProvider.cpp:
(WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired):
* UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
* UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::providerDidChangePosition):
(WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::getLoadDecisionForIconURL):
(WebKit::WebIconDatabase::didFinishURLImport):
* UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
* UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname):
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames):
* UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::getCacheOrigins):
(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):
2011-04-04 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51230
<rdar://problem/8780989>
<rdar://problem/9015250> REGRESSION (WebKit2): Key events not fired for modifier keys
* UIProcess/API/mac/WKView.mm:
(-[WKView flagsChanged:]): Ported from WebHTMLView.
(-[WKView _interpretKeyEvent:withCachedTextInputState:savingCommandsTo:WebCore::]):
AppKit isn't happy about attempts to interpret NSFlagsChanged, but WK2 lacked the check.
2011-04-04 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Remove unused AnalyzeWithLargeStack code from Windows build files
https://bugs.webkit.org/show_bug.cgi?id=57771
This was used for us to build with prefast automatically,
but it is out-of-date and hasn't been used for some time.
Removing completely for now.
* win/WebKitPreBuild.cmd:
2011-04-04 Anders Carlsson <andersca@apple.com>
Attempt to fix the Windows build.
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::setShouldPaintNativeControls):
2011-04-04 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Make it easier to send a message to all processes in a context
https://bugs.webkit.org/show_bug.cgi?id=57776
Add WebContext::sendToAllProcesses and WebContext::sendToAllProcessesRelaunchingThemIfNecessary
as a first step towards getting rid of WebContext::process() and getting rid of a class of crashers
where WebContext::process() is null.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::initializeHistoryClient):
(WebKit::WebContext::languageChanged):
(WebKit::WebContext::setAlwaysUsesComplexTextCodePath):
(WebKit::WebContext::registerURLSchemeAsEmptyDocument):
(WebKit::WebContext::registerURLSchemeAsSecure):
(WebKit::WebContext::setDomainRelaxationForbiddenForURLScheme):
(WebKit::WebContext::setCacheModel):
(WebKit::WebContext::setDefaultRequestTimeoutInterval):
(WebKit::WebContext::clearResourceCaches):
(WebKit::WebContext::clearApplicationCache):
(WebKit::WebContext::setEnhancedAccessibility):
(WebKit::WebContext::startMemorySampler):
Use sendToAllProcesses.
(WebKit::WebContext::stopMemorySampler):
Use sendToAllProcesses. This is a slight policy change where we now create a sandbox extension even
if there's no process around. Since this is a debugging tool it seems OK to do this.
* UIProcess/WebContext.h:
Get rid of hasValidProcess.
(WebKit::WebContext::sendToAllProcesses):
If we have a process and we can send messages to it, then do so.
(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
Relaunch the web process and send the message.
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
Use sendToAllProcesses and sendToAllProcessesRelaunchingThemIfNecessary.
2011-04-04 Adam Roben <aroben@apple.com>
Move a teensy bit of non-Mac-specific code up to LayerTreeHostCA
Fixes <http://webkit.org/b/57774> LayerTreeHostCA should know how to flip the root layer
Reviewed by Anders Carlsson.
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::initialize): Cross-platformized and moved some code here...
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::platformInitialize): ...from here.
2011-04-01 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
WK2: Reproducible crash when dragging out of or over Safari window.
https://bugs.webkit.org/show_bug.cgi?id=57654
<rdar://problem/9139755>
AppKit does not retain the owner given to the pasteboard, therefore we
need to give the ownership of the retained pointer to NSPasteboard.
Also, dragImage will release the NSFilePromiseDragSource object, therefore
we retain it before calling dragImage to be able to control its lifetime.
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage): Passing ownership
of the pointer to AppKit when providing the owner pointer to the NSPasteboard
object.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformDragEnded): Retaining the NSFilePromiseDragSource
since dragImage will release it.
2011-03-30 Jer Noble <jer.noble@apple.com>
Reviewed by Dan Bernstein.
WebKit2: No "open in preview" contextual menu item for PDFs
https://bugs.webkit.org/show_bug.cgi?id=57527
Add support for opening a PDF in the associated application from the
context menu.
* UIProcess/API/mac/PDFViewController.mm:
(_applicationInfoForMIMEType): Added, copied from WebKit/WebPDFView.mm
(-[WKPDFView _openWithFinder:]): Added.
(-[WKPDFView hitTest:]): Added, copied from WebKit/WebPDFView.mm.
(-[WKPDFView menuForEvent:]): Added, adapted from WebKit/WebPDFVie.mm.
(-[WKPDFView validateUserInterfaceItem:]): Added.
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::decode):
(WebKit::WebPreferencesStore::overrideAllowFileAccessFromFileURLsForTestRunner):
* Shared/WebPreferencesStore.h:
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetAllowFileAccessFromFileURLs):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAllowFileAccessFromFileURLs):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-04 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=57683
Flesh out WK2 Icon Database API
For now the new API will add a client interface where the WK1 version used NSNotifications.
If we decide we'd like the granularity of specific callback functions later,
they can easily be added on.
Project file nonsense:
* GNUmakefile.am:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add a WKIconDatabaseClient and some new API:
* UIProcess/API/C/WKIconDatabase.cpp:
(WKIconDatabaseSetIconDatabaseClient):
(WKIconDatabaseRemoveAllIcons):
(WKIconDatabaseCheckIntegrityBeforeOpening):
* UIProcess/API/C/WKIconDatabase.h:
* UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
(WKIconDatabaseTryGetCGImageForURL): Renamed to "try" for subtle clarification.
* UIProcess/API/C/cg/WKIconDatabaseCG.h:
Implementations for the new APIs:
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::retainIconForPageURL): Remove excessive logging.
(WebKit::WebIconDatabase::releaseIconForPageURL): Ditto.
(WebKit::WebIconDatabase::imageForPageURL):
(WebKit::WebIconDatabase::removeAllIcons):
(WebKit::WebIconDatabase::checkIntegrityBeforeOpening):
(WebKit::WebIconDatabase::initializeIconDatabaseClient):
(WebKit::WebIconDatabase::didImportIconURLForPageURL): Dispatch a client callback,
much like the WK1 API uses notifications.
(WebKit::WebIconDatabase::didImportIconDataForPageURL): Ditto.
(WebKit::WebIconDatabase::didChangeIconForPageURL): Ditto.
(WebKit::WebIconDatabase::didRemoveAllIcons): Ditto.
* UIProcess/WebIconDatabase.h:
* UIProcess/WebIconDatabaseClient.cpp: Added.
(WebKit::WebIconDatabaseClient::didChangeIconForPageURL):
(WebKit::WebIconDatabaseClient::didRemoveAllIcons):
* UIProcess/WebIconDatabaseClient.h: Added.
2011-04-04 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Main loop sources are leaked in RunLoopGtk
https://bugs.webkit.org/show_bug.cgi?id=57618
* Platform/RunLoop.h:
(RunLoop::TimerBase::isRepeating):
* Platform/gtk/RunLoopGtk.cpp:
(RunLoop::~RunLoop): Make sure main loop is currently running
before calling g_main_loop_quit(), RunLoop::stop() might have been
called.
(RunLoop::wakeUp): Use an idle source with default priority
instead of a timeout one with a 0 interval.
(RunLoop::TimerBase::clearTimerSource): New method to clear the
timer.
(RunLoop::TimerBase::destroyNotifyCallback): Destroy notify
callback called when the source is destroyed to clear the timer.
(RunLoop::TimerBase::timerFiredCallback): Use the same callback for
repeating and no repeating timers.
(RunLoop::TimerBase::start): g_source_attach() increments the
source reference counter, so use GRefPtr to make sure the source
is freed.
(RunLoop::TimerBase::stop): Use clearTimerSource().
2011-04-03 Dan Bernstein <mitz@apple.com>
Build fix.
* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h:
2011-04-03 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9227839> REGRESSION: Reproducible crash in Snow Leopard when trying to show the Dictionary panel or application
https://bugs.webkit.org/show_bug.cgi?id=57739
* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode): Do not encode the options dictionary on Snow Leopard.
(WebKit::DictionaryPopupInfo::decode): Do not decode the options dictionary on Snow Leopard.
* Shared/DictionaryPopupInfo.h: Removed the options member variable on Snow Leopard.
* Shared/Plugins/PluginQuirks.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForRange): Do not set the options member variable on
Snow Leopard.
2011-04-02 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
https://bugs.webkit.org/show_bug.cgi?id=57605
Frame::pageScaleFactor() should not affect getBoundingClientRect() or
getClientRects()
-and corresponding-
<rdar://problem/9194541>
Add DRT support for the scaleWebView SPI.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetScaleAtOrigin):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
2011-04-02 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
"Search in Spotlight" broken in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57712
Proxy spotlight searching to the UIProcess.
* UIProcess/WebPageProxy.messages.in:
Add new message. Re-organize messages to put all mac specific ones together.
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::speak):
(WebKit::WebPageProxy::searchWithSpotlight):
Moved code to trigger spotlight here. Use WTF::String -> NSString conversion function
instead of relying on the built in conversion since it doesn't always work in the UIProcess.
* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::searchWithSpotlight):
Post message to the UIProcess to do the searching.
2011-04-02 Jeff Miller <jeffm@apple.com>
Reviewed by Dan Bernstein.
WebKit2: Specify the certificate store in WKBundleSetClientCertificate()
https://bugs.webkit.org/show_bug.cgi?id=57707
Include the name of the system certificate store that the client certificate came from in WKBundleSetClientCertificate().
The PCCERT_CONTEXT for the client certificate we create from the message from the UI process doesn't contain enough information to actually use it in a request, we need to get the real certificate from the certificate store (which is typically the "MY" store).
* WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.cpp:
(WKBundleSetClientCertificate): Add certificateSystemStoreName to parameters.
* WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.h: Add certificateSystemStoreName to WKBundleSetClientCertificate() parameters.
* WebProcess/InjectedBundle/InjectedBundle.h: Add certificateSystemStoreName to setClientCertificate() parameters.
* WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
(WebKit::InjectedBundle::setClientCertificate): Read the real certificate from the certificate store.
2011-04-02 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Implement WKBundleFrameHasHorizontalScrollbar/WKBundleFrameHasVerticalScrollbar
<rdar://problem/9225772>
https://bugs.webkit.org/show_bug.cgi?id=57709
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameHasHorizontalScrollbar):
(WKBundleFrameHasVerticalScrollbar):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::hasHorizontalScrollbar):
(WebKit::WebFrame::hasVerticalScrollbar):
* WebProcess/WebPage/WebFrame.h:
2011-04-01 Jon Lee <jonlee@apple.com>
Reviewed by Darin Adler.
WebKit2: Type-to-select doesn't work in open <select> menu (53023)
https://bugs.webkit.org/show_bug.cgi?id=53023
<rdar://problem/8907678>
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: adding new setPopupMenuSelectedIndex message for windows platform
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::setPopupMenuSelectedIndex):
* UIProcess/win/WebPopupMenuProxyWin.h: moving setFocusedIndex() into public method
* WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::updateFromElement): send message back to UIProcess to update the selected element
2011-04-01 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
REGRESSION: Assertion failure when executing a complex custom key binding
https://bugs.webkit.org/show_bug.cgi?id=57681
Also completes a fix for
<rdar://problem/9063782> WebKit2: Text fields in Safari don't honor custom key bindings
* UIProcess/API/mac/WKView.mm: (-[WKView hasMarkedText]): There is no need to execute saved
commands when they can't possibly change the result.
2011-04-01 Brian Weinstein <bweinstein@apple.com>
Reviewed by Anders Carlsson.
Crash when calling WebPageProxy::setMemoryCacheClientCallsEnabled with an invalid Web Process
https://bugs.webkit.org/show_bug.cgi?id=57680
<rdar://problem/9202909>
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled): Add an isValid check before sending
the message.
2011-03-31 Jer Noble <jer.noble@apple.com>
Reviewed by Dan Bernstein.
WebKit2: Save as PDF in Safari provides Untitled as default file name
https://bugs.webkit.org/show_bug.cgi?id=57529
Set the NSPrintOperation's jobTitle to the printing frame's title.
* UIProcess/API/mac/WKView.mm:
(-[WKView printOperationWithPrintInfo:forFrame:]):
2011-04-01 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
WebKit2: Link from PDF opens in a new tab instead of in the same tab
https://bugs.webkit.org/show_bug.cgi?id=57528
Notify the WebProcess that a link has been clicked so that the normal policy
lookup can occur.
* Shared/WebEvent.cpp:
(WebKit::WebEvent::WebEvent): Initialize ivars in the default constructor.
* Shared/WebEvent.h: Add WebEvent::NoType to Type enum.
* Shared/WebMouseEvent.cpp:
(WebKit::WebMouseEvent::WebMouseEvent): Ditto.
* UIProcess/API/mac/PDFViewController.mm:
(-[WKPDFView PDFViewWillClickOnLink:withURL:]): Handle the delegate
function and override the PDFView default behavior.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Handle the new WebEvent::NoType enum.
(WebKit::WebPageProxy::linkClicked): Added. Send event through to WebPage.
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::linkClicked): Added. Call loadFrameRequest().
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Added LinkClicked.
2011-04-01 Sam Weinig <sam@webkit.org>
Reviewed by Adam "Keyword Slasher" Roben.
Remove unnecessary static keyword.
* UIProcess/API/cpp/WKRetainPtr.h:
(WebKit::adoptWK):
2011-04-01 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Add adoptWK to WKRetainPtr.h
https://bugs.webkit.org/show_bug.cgi?id=57670
* UIProcess/API/cpp/WKRetainPtr.h:
(WebKit::adoptWK):
Add shared implementation of adoptWK. Previously both WebKitTestRunner
and TestWebKitAPI had separate versions of it.
2011-04-01 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Shockwave plug-in doesn't accept mouse events
https://bugs.webkit.org/show_bug.cgi?id=57653
<rdar://problem/8483273>
Add a missing break.
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::convertPoint):
2011-04-01 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKitTestRunner needs layoutTestController.shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=57661
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleGetRenderRect):
(WKBundleNodeHandleGetElementBounds):
(WKBundleNodeHandleCopyElementShadowRoot):
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::elementShadowRoot):
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
Add accessor for the shadowRoot of an element in the bundle.
2011-04-01 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Make WebKit2 text input handling more like WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57649
We now send more sync messages from UI process to Web process for NSTextInput protocol
methods. Some of the exchanges are avoided by pre-calculating the responses before asking
UI process to interpret key events, and also with each sync message sent during
interpretation, and which could change the state.
* Platform/CoreIPC/HandleMessage.h: (CoreIPC::callMemberFunction): Added a missing
specialization for a function with 6 arguments and 2 returned values.
* Scripts/webkit2/messages.py: Added TextInputState to struct list.
* Shared/WebCoreArgumentCoders.h: Fixed a bug in CompositionUnderline encoding, which only
encoded a part of Color field, and didn't match decoder.
* Shared/mac/TextInputState.h: Added. This is state that's needed for IM machinery and that
we don't want to send sync messages for. This is similar to SelectionState, but the latter
is only updated asynchronously, and is thus less reliable.
* UIProcess/API/mac/PageClientImpl.h: We don't "intercept", we "interpret".
* UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::interpretKeyEvent): Pass
current text input state, and don't expect anything input method related in return, as input
methods are now sync.
* UIProcess/API/mac/WKView.mm:
(-[WKView doCommandBySelector:]):
(-[WKView insertText:]):
(-[WKView keyDown:]):
(-[WKView _executeSavedKeypressCommands]):
(-[WKView inputContext]):
(-[WKView selectedRange]):
(-[WKView hasMarkedText]):
(-[WKView unmarkText]):
(-[WKView setMarkedText:selectedRange:]):
(-[WKView markedRange]):
(-[WKView attributedSubstringFromRange:]):
(-[WKView characterIndexForPoint:]):
(-[WKView firstRectForCharacterRange:]):
(-[WKView _interpretKeyEvent:withCachedTextInputState:savingCommandsTo:WebCore::]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::insertText):
(WebKit::WebPageProxy::getSelectedRange):
(WebKit::WebPageProxy::executeKeypressCommands):
(WebKit::WebPageProxy::interpretQueuedKeyEvent):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::handleKeyboardEvent):
(WebKit::WebEditorClient::handleInputMethodKeydown):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::viewFrameInWindowCoordinates):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::createSelectorExceptionMap):
(WebKit::commandNameForSelectorName):
(WebKit::currentTextInputState):
(WebKit::frameForEvent):
(WebKit::WebPage::executeKeypressCommandsInternal):
(WebKit::WebPage::handleEditingKeyboardEvent):
(WebKit::WebPage::setComposition):
(WebKit::WebPage::confirmComposition):
(WebKit::WebPage::insertText):
(WebKit::WebPage::getSelectedRange):
(WebKit::convertToRange):
(WebKit::WebPage::executeKeypressCommands):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
Rewrote to be more like WebKit1.
2011-04-01 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setDatabaseQuota
https://bugs.webkit.org/show_bug.cgi?id=57568
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetDatabaseQuota):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setDatabaseQuota):
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/WebCoreSupport/WebDatabaseManager.h:
2011-04-01 Timothy Hatcher <timothy@apple.com>
Make momentum scroll event latching work in WebKit2 on Mac.
<rdar://problem/8751861>
Reviewed by Darin Adler.
* Shared/mac/WebEventFactory.mm:
(WebKit::momentumPhaseForEvent): Return a phase on older Mac system by using WKGetNSEventMomentumPhase.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.
2011-04-01 Alexey Proskuryakov <ap@apple.com>
Reviewed by Anders Carlsson.
Assertion failure (type == event.type()) after a web process crash
https://bugs.webkit.org/show_bug.cgi?id=56228
<rdar://problem/8806106>
This partially un-confuses the UI process about key processing state after a web process
crash. It may not be pefect yet - sending a KeyUp to a new process that never saw a KeyDown
seems weird.
* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::processDidCrash):
2011-04-01 Adam Roben <aroben@apple.com>
Cairo build fix
* WebProcess/WebPage/LayerTreeHost.cpp: Only pull in the LayerTreeHostCA derived classes for
PLATFORM(CA) ports.
2011-03-31 Adam Roben <aroben@apple.com>
Split LayerTreeHostCA into a base class and derived Mac and Win classes
This will make it easier to customize the Mac and Windows implementations without adding too
many #ifdefs.
Fixes <http://webkit.org/b/57606> Windows and Mac should use separate LayerTreeHost classes
Reviewed by Anders Carlsson.
* WebKit2.xcodeproj/project.pbxproj: Added LayerTreeHostCAMac.h.
* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create): Create a LayerTreeHostCAMac on Mac, and LayerTreeHostCAWin
on Windows.
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::LayerTreeHostCA): Moved some code from here...
(WebKit::LayerTreeHostCA::initialize): ...to here. This function will be called after the
constructor returns, and thus can safely call functions that are pure virtual in this class
and its base class. We now pass our LayerTreeContext to platformInitialize so that our
derived classes can initialize it.
(WebKit::LayerTreeHostCA::~LayerTreeHostCA): Removed Mac-specific code.
(WebKit::LayerTreeHostCA::invalidate):
(WebKit::LayerTreeHostCA::sizeDidChange):
(WebKit::LayerTreeHostCA::forceRepaint):
(WebKit::LayerTreeHostCA::didPerformScheduledLayerFlush):
Removed platform* calls. Derived classes can just override these functions to do what they
need.
* WebProcess/WebPage/ca/LayerTreeHostCA.h: Removed Mac-specific pieces. Made some functions
virtual so that derived classes can override them.
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h: Added.
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::create): Create and initialize a host.
(WebKit::LayerTreeHostCAMac::LayerTreeHostCAMac): Simple constructor.
(WebKit::LayerTreeHostCAMac::~LayerTreeHostCAMac): Moved code here from LayerTreeHostCA
destructor.
(WebKit::LayerTreeHostCAMac::platformInitialize): Removed direct uses of LayerTreeHostCA
data members.
(WebKit::LayerTreeHostCAMac::invalidate):
(WebKit::LayerTreeHostCAMac::sizeDidChange):
(WebKit::LayerTreeHostCAMac::forceRepaint):
(WebKit::LayerTreeHostCAMac::didPerformScheduledLayerFlush):
Renamed from platform*. Now call up to the base class.
(WebKit::LayerTreeHostCAMac::flushPendingLayerChangesRunLoopObserverCallback): Updated type.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::create): Create and initialize a host.
(WebKit::LayerTreeHostCAWin::LayerTreeHostCAWin):
(WebKit::LayerTreeHostCAWin::~LayerTreeHostCAWin):
(WebKit::LayerTreeHostCAWin::platformInitialize):
(WebKit::LayerTreeHostCAWin::scheduleLayerFlush):
Stubbed out.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added.
* win/WebKit2.vcproj: Added LayerTreeHostCAWin.h
* win/WebKit2Apple.vsprops: Added WebProcess/WebPage/ca/win to the include path.
2011-03-31 Brent Fulgham <bfulgham@webkit.org>
Unreviewed WinCairo build fix after r82632.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::visibilityDidChange):
2011-03-31 Adam Roben <aroben@apple.com>
Add SharedMemory::adopt, which can take ownership of an existing file mapping object
Fixes <http://webkit.org/b/57599> Need a way to wrap an existing file mapping object in a
SharedMemory
Reviewed by Anders Carlsson.
* Platform/SharedMemory.h: Added adopt.
* Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::create): Moved code to adopt the HANDLE from here...
(WebKit::SharedMemory::adopt): ...to here.
2011-03-31 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.clearAllDatabases
https://bugs.webkit.org/show_bug.cgi?id=42540
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleClearAllDatabases):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::clearAllDatabases):
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/WebCoreSupport/WebDatabaseManager.h:
2011-03-31 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add some more media related things to the sandbox profile.
* WebProcess/com.apple.WebProcess.sb:
2011-03-31 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Tabbed pages redraw unnecessarily when activated
https://bugs.webkit.org/show_bug.cgi?id=57589
<rdar://problem/9218258>
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::visibilityDidChange):
If we become visible and have no backing store, make sure to call backingStoreStateDidChange
so that the next time we're asked to paint we'll wait for something to paint.
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Remove now redundant call to backingStoreStateDidChange.
2011-03-31 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Sandbox violations when playing back HTML5 video on YouTube
<rdar://problem/8950692>
* WebProcess/com.apple.WebProcess.sb:
2011-03-31 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=57573
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSimulateMouseDown): Added.
(WKBundlePageSimulateMouseUp): Added.
(WKBundlePageSimulateMouseMotion): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Added above functions.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::simulateMouseDown): Added.
(WebKit::WebPage::simulateMouseUp): Added.
(WebKit::WebPage::simulateMouseMotion): Added.
* WebProcess/WebPage/WebPage.h: Added above functions.
2011-03-31 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Rename WebCore's UI_STRING to WEB_UI_STRING to not overlap with WebKit API
https://bugs.webkit.org/show_bug.cgi?id=57582
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::platformInitialize):
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformInspectedURLChanged):
* WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
2011-03-31 Adam Roben <aroben@apple.com>
Specify both FILE_MAP_READ and FILE_MAP_WRITE when creating a read-write SharedMemory object
When passed to ::MapViewOfFile, FILE_MAP_WRITE implies FILE_MAP_READ, but other file mapping
APIs don't work that way. This bug wasn't causing any problems in practice, but it would
have prevented us from creating a DIB that wraps a SharedMemory object (which I noticed
while working on another bug).
Fixes <http://webkit.org/b/57576> File mappings used by read-write SharedMemory objects
aren't correctly marked as read-write after being sent over a CoreIPC::Connection
Reviewed by Brian Weinstein.
* Platform/win/SharedMemoryWin.cpp:
(WebKit::accessRights): Specify FILE_MAP_READ in addition to FILE_MAP_WRITE for read-write
SharedMemory.
2011-03-31 Adam Roben <aroben@apple.com>
Quote the executable path we pass to ::CreateProcessW
This will ensure that spaces in the path will be interpreted correctly.
Fixes <http://webkit.org/b/57569> Web process sometimes fails to launch when there are
spaces in its path
Reviewed by Steve Falkenburg.
* UIProcess/Launcher/win/ProcessLauncherWin.cpp:
(WebKit::ProcessLauncher::launchProcess): Surround the executable path in quotes.
2011-03-31 Alexey Proskuryakov <ap@apple.com>
Patch by John Harvey, reviewed and tweaked by me.
<rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.
* UIProcess/API/mac/WKTextInputWindowController.mm:
(-[WKTextInputPanel _interpretKeyEvent:string:]):
2011-03-31 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan, Darin Adler, Dan Bernstein and Sam Weinig.
If a user doesn't have a Database/LocalStorage directory, it can't be created (sandbox violations)
https://bugs.webkit.org/show_bug.cgi?id=57561
<rdar://problem/9127411>
Ensure that any readwrite sandbox directories actually exist before entering the sandbox.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::appendReadwriteSandboxDirectory):
2011-03-31 John Sullivan <sullivan@apple.com>
Reviewed by Darin Adler and Adam Roben.
<rdar://problem/9214824> Find client not told when WKPageCountStringMatches exceeds maximum
https://bugs.webkit.org/show_bug.cgi?id=57552
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::countStringMatches):
Use the same technique as findString() to report kWKMoreThanMaximumMatchCount when appropriate.
(WebKit::FindController::findString):
Convert numeric_limits::max() to max() - 1 to avoid overflow case.
2011-03-31 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
<title> should support dir attribute
https://bugs.webkit.org/show_bug.cgi?id=50961
Update to new FrameLoaderClient interface.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::setTitle):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
2011-03-31 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Csaba Osztrogonác.
[WK2] Introduce an option for no NPAPI support
https://bugs.webkit.org/show_bug.cgi?id=55828
Stub out NPAPI support for platform and OS combinations that are
not supported yet. Ancestor patch was made by Laszlo Gombos.
* GNUmakefile.am: Add NetscapePluginModuleNone.cpp and NetscapePluginNone.cpp
to the build system.
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
Remove the sanity check because from now all combinations that
don't have an explicitly set plugin architecture fall into
the PLUGIN_ARCHITECTURE(UNSUPPORTED) category and has a stubbed
implementation.
* Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp: Added.
Stubbed implementation.
(WebKit::NetscapePluginModule::getPluginInfo):
(WebKit::NetscapePluginModule::determineQuirks):
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp: Guard with
PLUGIN_ARCHITECTURE(X11).
* WebKit2.pro: Add NetscapePluginModuleNone.cpp and NetscapePluginNone.cpp
to the build system.
* WebProcess/Plugins/Netscape/NetscapePluginNone.cpp: Added.
Stubbed implementation
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformInvalidate):
(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Guard with
PLUGIN_ARCHITECTURE(X11)
* config.h: Introduce PLUGIN_ARCHITECTURE(UNSUPPORTED) as another
option. Make platform and OS combinations that are not supported
yet fall into this. Don't use Q_WS_X11 to test the window system
for Qt because it is not defined without including <QtGlobal>.
No clue about how could it work so far.
2011-03-31 Vamshikrishna.Yellenki <vamshi@motorola.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Implement MiniBrowser for Gtk port.
https://bugs.webkit.org/show_bug.cgi?id=48512
* Shared/API/c/gtk/WKBaseGtk.h: Add the stdbool.h include.
2011-03-30 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9005982> Flash of white when a WKView with composited content moves on-screen
https://bugs.webkit.org/show_bug.cgi?id=57522
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode): Invalidate the current
backing store state, so that we get an update as soon as the page enters compositing mode
next.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Added a call to
LayerTreeHost::forceRepaint() in order to flush and synchronize the layers
before sending the update message to the UI process.
2011-03-30 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Sandbox violations if you navigate a file URL via something other than a click
<rdar://problem/9016086>
https://bugs.webkit.org/show_bug.cgi?id=57519
* WebProcess/WebPage/WebPage.cpp:
(WebKit::shouldReuseCommittedSandboxExtension):
Remove unnecessary restriction on extension reuse. Any type of file to file navigation
should be allowed.
2011-03-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Clean up the sandbox parameter code
https://bugs.webkit.org/show_bug.cgi?id=57518
* Shared/WebProcessCreationParameters.h:
Make nsURLCachePath and uiProcessBundleResourcePath Strings to match the other paths we send over.
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
nsURLCachePath and uiProcessBundleResourcePath are now Strings.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::appendSandboxParameterPathInternal):
(WebKit::appendReadwriteConfDirectory):
(WebKit::appendReadonlySandboxDirectory):
(WebKit::appendReadwriteSandboxDirectory):
(WebKit::initializeSandbox):
Make it more clear whether the directories we're adding are readonly or readwrite. No functionality change.
(WebKit::WebProcess::platformInitializeWebProcess):
nsURLCachePath is now a string.
2011-03-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Downloading a file fails due to a sandbox violation if the destination path is a symlink
https://bugs.webkit.org/show_bug.cgi?id=57517
<rdar://problem/8943865>
Make sure to resolve any symlinks in the given path when creating a sandbox extension handle.
Note that we can't use realpath or -[NSString stringByResolvingSymlinksInPath], because those calls
will fail if the pointed to file doesn't exist.
* Shared/mac/SandboxExtensionMac.mm:
(WebKit::resolveSymlinksInPath):
New function that resolves all the symlinks in the given path.
(WebKit::SandboxExtension::createHandle):
Call resolveSymlinksInPath on the resulting path.
2011-03-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Share most vsprops between Release and Production builds in releaseproduction.vsprops
https://bugs.webkit.org/show_bug.cgi?id=57508
* win/WebKit2Production.vsprops:
* win/WebKit2Release.vsprops:
* win/WebKit2ReleaseCairoCFLite.vsprops:
* win/WebKit2WebProcessProduction.vsprops:
* win/WebKit2WebProcessRelease.vsprops:
* win/WebKit2WebProcessReleaseCairoCFLite.vsprops:
2011-03-30 Ivan Krstić <ike@apple.com>
Reviewed by Oliver Hunt.
Ensure consistent, readable working directory for WebProcess before entering sandbox
<rdar://problem/8951176>
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
2011-03-30 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
WebKit2: Attempting to view css file from url causes it to download
<rdar://problem/9102611>
https://bugs.webkit.org/show_bug.cgi?id=57501
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canShowMIMEType):
Match WebKit1 by allowing any MIME type that starts with "text/"
except the ones we explicitly blacklist.
2011-03-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Update Windows production build logic for new production configurations
https://bugs.webkit.org/show_bug.cgi?id=57494
* win/WebKit2.make:
* win/WebKit2Production.vsprops:
* win/WebKit2WebProcessProduction.vsprops:
2011-03-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Rename Windows configuration Release_LTCG to Production for clarity
https://bugs.webkit.org/show_bug.cgi?id=57465
* win/WebKit2.submit.sln:
* win/WebKit2.vcproj:
* win/WebKit2Generated.vcproj:
* win/WebKit2Production.vsprops: Copied from Source/WebKit2/win/WebKit2ReleaseLTCG.vsprops.
* win/WebKit2ReleaseLTCG.vsprops: Removed.
* win/WebKit2WebProcess.vcproj:
* win/WebKit2WebProcessProduction.vsprops: Copied from Source/WebKit2/win/WebKit2WebProcessReleaseLTCG.vsprops.
* win/WebKit2WebProcessReleaseLTCG.vsprops: Removed.
2011-03-30 Jer Noble <jer.noble@apple.com>
Reviewed by Dan Bernstein.
WebKit2: WebProcess is using 89%, while viewing a PDF
https://bugs.webkit.org/show_bug.cgi?id=57471
Break a never ending display/update cycle between the UIProcess and the WebProcess
by clearing the dirty region when a page has a custom representation (like a PDF).
Also, avoid the issue where possible by not setting the dirty region in the same case.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNeedsDisplay): Bail early if mainFrameHasCustomRepresentation().
(WebKit::DrawingAreaImpl::scroll): Ditto.
(WebKit::DrawingAreaImpl::display): Both bail early and clear m_dirtyRegion if
mainFrameHasCustomRepresentation().
2011-03-30 Sam Weinig <sam@webkit.org>
Fix Snow Leopard build.
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):
2011-03-30 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKit2 contextual menu looks different than the rest of the OS
<rdar://problem/9172935>
https://bugs.webkit.org/show_bug.cgi?id=57475
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):
Use correct SPI for showing a context menu. The dummy view is also
not necessary, so remove it.
2011-03-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash when NPN_Evaluate removes the plug-in frame
https://bugs.webkit.org/show_bug.cgi?id=57474
<rdar://problem/9191396>
Get a reference to the frame since it can be nulled out if running the JavaScript code
causes the plug-in's containing frame to be removed from the frame tree.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::evaluate):
2011-03-30 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add default localization strategy that can be shared by WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57406
* Shared/WebLocalizableStrings.h: Removed.
Removed in favor of using WebCore/LocalizedStrings.h directly.
* PluginProcess/mac/PluginProcessMac.mm:
* UIProcess/API/mac/WKView.mm:
* UIProcess/mac/WebInspectorProxyMac.mm:
* WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
* WebProcess/mac/WebProcessMac.mm:
Use WebCore/LocalizedStrings.h directly.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Remove localization strategy override in favor of using new default implementation.
* GNUmakefile.am:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Remove WebLocalizableStrings.h
2011-03-30 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Assertion failure in plug-in process when calling WKPluginSiteDataManagerGetSitesWithData
https://bugs.webkit.org/show_bug.cgi?id=57468
<rdar://problem/9199089>
Call decrementLoadCount from removeWebProcessConnection instead of startShutdownTimerIfNecessary,
otherwise we'll get a load count underflow when a connection is never created.
* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::removeWebProcessConnection):
(WebKit::PluginProcess::createWebProcessConnection):
(WebKit::PluginProcess::startShutdownTimerIfNecessary):
2011-03-30 Jessie Berlin <jberlin@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Make sure to try to terminate the Web Process when any work that might require the
Web Process to be relaunched is done
https://bugs.webkit.org/show_bug.cgi?id=57462
For the ManagerProxies in the UIProcess, only return true from shouldTerminate if there are
no more callbacks waiting to be invoked.
For the the Managers in the WebProcess, call WebProcess::shared().terminateIfPossible() when
any work called for by a ManagerProxy function that called relaunchProcessIfNecessary is
finished.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::shouldTerminate):
Check with each of the ManagerProxies.
* UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::shouldTerminate):
* UIProcess/WebApplicationCacheManagerProxy.h:
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::shouldTerminate):
* UIProcess/WebCookieManagerProxy.h:
* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::shouldTerminate):
* UIProcess/WebDatabaseManagerProxy.h:
* UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::shouldTerminate):
* UIProcess/WebKeyValueStorageManagerProxy.h:
* UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::shouldTerminate):
* UIProcess/WebMediaCacheManagerProxy.h:
* UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::shouldTerminate):
* UIProcess/WebResourceCacheManagerProxy.h:
* WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):
(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):
* WebProcess/MediaCache/WebMediaCacheManager.cpp:
(WebKit::WebMediaCacheManager::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManager::clearCacheForHostname):
(WebKit::WebMediaCacheManager::clearCacheForAllHostnames):
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins):
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
(WebKit::WebResourceCacheManager::clearCacheForAllOrigins):
* WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::getDatabaseOrigins):
(WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManager::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManager::deleteAllDatabases):
(WebKit::WebDatabaseManager::setQuotaForOrigin):
2011-03-30 Adam Roben <aroben@apple.com>
Mac build fix after r82442
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange): Added a missing argument.
2011-03-29 Adam Roben <aroben@apple.com>
Add a way to specify that a ShareableBitmap has no alpha channel
Before this patch, all ShareableBitmaps had an alpha channel. With this patch, all
ShareableBitmaps *still* have an alpha channel. But now there's a way to specify you don't
want one (which will be used in the future)!
Fixes <http://webkit.org/b/57388> Need a way to specify that a ShareableBitmap has no alpha
channel
Reviewed by Anders Carlsson.
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::Handle::Handle): Moved here from the header file, and added
initialization of m_flags.
(WebKit::ShareableBitmap::Handle::encode):
(WebKit::ShareableBitmap::Handle::decode):
Encode/decode m_flags.
(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
Pass along the new Flags argument.
(WebKit::ShareableBitmap::createHandle): Store our Flags on the Handle.
(WebKit::ShareableBitmap::ShareableBitmap): Store the Flags in m_flags.
* Shared/ShareableBitmap.h: Added Flag, Flags, and m_flags, and added a Flags argument to
some create functions.
* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::encodeImage):
* Shared/WebImage.cpp:
(WebKit::WebImage::create):
Specify that we want a bitmap that supports alpha to maintain current behavior.
* Shared/cg/ShareableBitmapCG.cpp:
(WebKit::bitmapInfo): New helper function. Includes an alpha channel only if specified in
the flags.
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::makeCGImage):
Use the new helper function.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::snapshot):
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap):
* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
Specify that we want a bitmap that supports alpha to maintain current behavior.
2011-03-29 Adam Roben <aroben@apple.com>
Add ShareableBitmap::Handle
This object is used for encoding/decoding a ShareableBitmap via CoreIPC. It currently just
encapsulates a SharedMemory::Handle (which is what we were using previously) and the image's
size (which means callers no longer need to deal with the size explicitly), but in the
future could be used to store more information about the bitmap.
This should cause no behavior changes.
Fixes <http://webkit.org/b/57397> ShareableBitmap needs its own Handle type
Reviewed by Anders Carlsson.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange): No longer need to pass a size to create,
since the Handle records the size.
(WebKit::PluginControllerProxy::snapshot): No longer need the bufferSize argument, since the
Handle records the size.
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/PluginControllerProxy.messages.in:
Updated Handle types and removed unnecessary size argument to Snapshot.
* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
* Shared/PlatformPopupMenuData.h:
Changed to use ShareableBitmap::Handle and removed m_backingStoreSize, which is now stored
in the Handles.
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::Handle::encode):
(WebKit::ShareableBitmap::Handle::decode):
Simple encode/decode functions.
(WebKit::ShareableBitmap::create): Get the size from the Handle instead of as a separate
argument.
(WebKit::ShareableBitmap::createHandle): Store our size in the Handle.
* Shared/ShareableBitmap.h: Added ShareableBitmap::Handle and made some functions use it.
* Shared/UpdateInfo.h: Changed to use ShareableBitmap::Handle.
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::encodeImage):
(CoreIPC::decodeImage):
Use the size stored in the Handle instead of encoding/decoding one separately.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setDragImage):
Removed the unnecessary imageSize argument. We can get it from the image itself.
* UIProcess/BackingStore.cpp:
(WebKit::BackingStore::incorporateUpdate):
* UIProcess/FindIndicator.cpp:
(WebKit::FindIndicator::create):
No longer need to pass a size when creating a ShareableBitmap from a Handle.
* UIProcess/FindIndicator.h: Changed to use ShareableBitmap::Handle.
* UIProcess/PageClient.h: Removed unnecessary imageSize argument from setDragImage.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFindIndicator):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setDragImage):
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::snapshot):
(WebKit::PluginProxy::geometryDidChange):
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag):
Changed to use ShareableBitmap::Handle and removed now-unnecessary size arguments (since we
can get the size from the Handle).
* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData): Don't need to store the backing store size in the
data anymore; the Handles will make sure it reaches the other process.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):
Changed to use ShareableBitmap::Handle.
2011-03-30 Alejandro G. Castro <alex@igalia.com>
Fix GTK build after r81980.
* GNUmakefile.am:
2011-03-29 Beth Dakin <bdakin@apple.com>
Reviewed by Maciej Stachowiak.
Fix for https://bugs.webkit.org/show_bug.cgi?id=57408
webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
-and corresponding-
<rdar://problem/8665411>
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::userSpaceScaleFactor):
* UIProcess/API/qt/qwkpage_p.h:
(QWKPagePrivate::userSpaceScaleFactor):
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* UIProcess/gtk/WebView.h:
(WebKit::WebView::userSpaceScaleFactor):
* UIProcess/win/WebView.h:
(WebKit::WebView::userSpaceScaleFactor):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::scaleFactor):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::userSpaceScaleFactor):
2011-03-29 Brent Fulgham <bfulgham@webkit.org>
Unreviewed WinCairo build fix.
Bring DownloadCurl implementation stubs in line with current
CFNetwork API.
* WebProcess/Downloads/curl/DownloadCurl.cpp:
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
2011-03-29 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: WK2: When creating the window remote token, use what's returned from accessibility
https://bugs.webkit.org/show_bug.cgi?id=57398
This will allow a specific WKView to override what's used for the window attribute of the
HTML elements.
* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
2011-03-29 Jeff Miller <jeffm@apple.com>
Reviewed by Sam Weinig.
Make Windows-only InjectedBundle functions platform-specific
https://bugs.webkit.org/show_bug.cgi?id=57385
Added files for Windows-specific WKBundle functions.
Removed stub wrappers for InjectedBundle::setHostAllowsAnyHTTPSCertificate() and InjectedBundle::setClientCertificate() from non-Windows platforms.
* WebProcess/InjectedBundle/API/c/WKBundle.cpp: Moved WKBundleSetHostAllowsAnyHTTPSCertificate() and WKBundleSetClientCertificate() to WKBundlePrivateWin.cpp.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Moved WKBundleSetHostAllowsAnyHTTPSCertificate() and WKBundleSetClientCertificate() to WKBundlePrivateWin.h.
* WebProcess/InjectedBundle/API/c/win: Added.
* WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.cpp: Added.
(WKBundleSetHostAllowsAnyHTTPSCertificate): Moved from WKBundle.cpp.
(WKBundleSetClientCertificate): Moved from WKBundle.cpp.
* WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.h: Added.
* WebProcess/InjectedBundle/InjectedBundle.h: setHostAllowsAnyHTTPSCertificate() and setClientCertificate() are Windows-only.
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: Removed setHostAllowsAnyHTTPSCertificate() and setClientCertificate().
* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp: Removed setHostAllowsAnyHTTPSCertificate() and setClientCertificate().
* WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: Removed setHostAllowsAnyHTTPSCertificate() and setClientCertificate().
* win/WebKit2.vcproj: Added WKBundlePrivateWin.cpp and WKBundlePrivateWin.h.
* win/WebKit2Generated.make: Copy WKBundlePrivateWin.h.
2011-03-29 Anders Carlsson <andersca@apple.com>
Fix Windows build.
* WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
2011-03-29 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Downloads: Authentication support
https://bugs.webkit.org/show_bug.cgi?id=57403
<rdar://problem/8691166>
* UIProcess/API/C/WKContext.h:
Add didReceiveAuthenticationChallenge callback.
* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
Call the download client.
* UIProcess/Downloads/DownloadProxy.messages.in:
Add DidReceiveAuthenticationChallenge message.
* UIProcess/WebDownloadClient.cpp:
(WebKit::WebDownloadClient::didReceiveAuthenticationChallenge):
Call the client callback function.
* UIProcess/WebDownloadClient.h:
* WebProcess/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
Send the DidReceiveAuthenticationChallenge message to the download proxy.
(WebKit::AuthenticationManager::useCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
If the authentication client is null, call the static download member functions.
* WebProcess/Authentication/AuthenticationManager.h:
* WebProcess/Downloads/Download.cpp:
(WebKit::Download::didReceiveAuthenticationChallenge):
Call the authentication manager.
* WebProcess/Downloads/Download.h:
* WebProcess/Downloads/mac/DownloadMac.mm:
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
Call the right sender methods.
(-[WKDownloadAsDelegate download:didReceiveAuthenticationChallenge:]):
(-[WKDownloadAsDelegate downloadShouldUseCredentialStorage:]):
Call the right Download member functions.
* WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
Add stubs.
2011-03-29 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
AuthenticationChallengeProxy objects should be associated with processes, not pages
https://bugs.webkit.org/show_bug.cgi?id=57401
* UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::AuthenticationChallengeProxy):
(WebKit::AuthenticationChallengeProxy::~AuthenticationChallengeProxy):
(WebKit::AuthenticationChallengeProxy::useCredential):
(WebKit::AuthenticationChallengeProxy::cancel):
* UIProcess/Authentication/AuthenticationChallengeProxy.h:
(WebKit::AuthenticationChallengeProxy::create):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):
2011-03-29 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Use LocalizedStrings.h as a bottleneck for localized strings instead of
using UI_STRING.
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]):
Call existing localization functions instead of using UI_STRING.
(-[WKView _getTextInputState:selectionEnd:underlines:]):
Remove unnecessary WebCore:: prefix.
2011-03-29 Chang Shu <cshu@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=42692
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::decode):
(WebKit::WebPreferencesStore::overrideAllowUniversalAccessFromFileURLsForTestRunner):
* Shared/WebPreferencesStore.h:
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleOverrideAllowUniversalAccessFromFileURLsForTestRunner):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideAllowUniversalAccessFromFileURLsForTestRunner):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-03-29 Timothy Hatcher <timothy@apple.com>
Update the order of the context menu to better match AppKit on Mac.
<rdar://problem/9054893>
Reviewed by John Sullivan.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
2011-03-29 Jeff Miller <jeffm@apple.com>
Fix formatting of WebKit2.vcproj after r82283.
* win/WebKit2.vcproj:
2011-03-29 Martin Robinson <mrobinson@igalia.com>
[GTK] Build failed with ‘GDK_KEY_KP_Space’ was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=55314
Build fix for older versions of GTK+. Use the deprecated names for GDK key
defines and include GtkVersioning.h to allow building on newer versions
of GTK+.
* Shared/gtk/WebEventFactory.cpp:
(WebKit::isGdkKeyCodeFromKeyPad): Update key defines.
2011-03-29 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Use per-configuration vsprops in WebKit to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
https://bugs.webkit.org/show_bug.cgi?id=57383
Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
the IDE. To avoid this, add a separate vsprops file for each project configuration that
contains the required inherited property sheets.
* win/WebKit2.vcproj:
* win/WebKit2Debug.vsprops: Added.
* win/WebKit2DebugAll.vsprops: Added.
* win/WebKit2DebugCairoCFLite.vsprops: Added.
* win/WebKit2Release.vsprops: Added.
* win/WebKit2ReleaseCairoCFLite.vsprops: Added.
* win/WebKit2ReleaseLTCG.vsprops: Added.
* win/WebKit2WebProcess.vcproj:
* win/WebKit2WebProcessDebug.vsprops: Added.
* win/WebKit2WebProcessDebugAll.vsprops: Added.
* win/WebKit2WebProcessDebugCairoCFLite.vsprops: Added.
* win/WebKit2WebProcessRelease.vsprops: Added.
* win/WebKit2WebProcessReleaseCairoCFLite.vsprops: Added.
* win/WebKit2WebProcessReleaseLTCG.vsprops: Added.
2011-03-29 Jessie Berlin <jberlin@apple.com>
Reviewed by Anders Carlsson.
WebKit2: The WebProcess should be relaunched if necessary when WebKit2 is asked for
information about Cookies, Databases, Local Storage, etc.
https://bugs.webkit.org/show_bug.cgi?id=57374
Instead of bailing when the WebProcess is not valid, call relaunchProcessIfNecessary().
* UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::getSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):
* UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
* UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
* UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname):
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames):
* UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::getCacheOrigins):
(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):
2011-03-29 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
WebKit2: Support setting the client certificate on Windows
https://bugs.webkit.org/show_bug.cgi?id=57368
Allow setting the client certificate for a host via the injected bundle.
This requires the ability for Webkit2 Windows clients to create a WKCertificateInfo from a PCCERT_CONTEXT so they can send it to the web process.
* Shared/API/c/win/WKCertificateInfoWin.cpp:
(WKCertificateInfoCreateWithCertificate): Added.
* Shared/API/c/win/WKCertificateInfoWin.h: Added WKCertificateInfoCreateWithCertificate().
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetClientCertificate): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added WKBundleSetClientCertificate().
* WebProcess/InjectedBundle/InjectedBundle.h: Added setClientCertificate().
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
(WebKit::InjectedBundle::setClientCertificate): Added, should never be called.
* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
(WebKit::InjectedBundle::setClientCertificate): Added, should never be called.
* WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
(WebKit::InjectedBundle::setClientCertificate): Added, should never be called.
* WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
(WebKit::InjectedBundle::setClientCertificate): Added.
2011-03-29 Timothy Hatcher <timothy@apple.com>
Make WebKit2 work with update-webkit-localizable-strings.
https://webkit.org/b/57354
Reviewed by Sam Weinig.
* PluginProcess/mac/PluginProcessMac.mm: Remove UI_STRING macro. Use WebLocalizableStrings.h.
* Shared/WebLocalizableStrings.h: Added.
* UIProcess/API/mac/WKView.mm: Remove UI_STRING macro. Use WebLocalizableStrings.h.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Use UI_STRING. Remove FIXME.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Remove UI_STRING macros.
Use WebLocalizableStrings.h.
* WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
(registerErrors): Remove UI_STRING macro. Use WebLocalizableStrings.h.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Use UI_STRING. Remove FIXME.
* GNUmakefile.am: Added Shared/WebLocalizableStrings.h.
* WebKit2.pro: Ditto.
* WebKit2.xcodeproj/project.pbxproj: Ditto.
* win/WebKit2.vcproj: Ditto.
2011-03-29 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
CoreIPC::decodeResourceError() leaks a CFDataRef
https://bugs.webkit.org/show_bug.cgi?id=57366
* Shared/win/WebCoreArgumentCodersWin.cpp:
(CoreIPC::decodeResourceError): Don't leak the result of WebCore::copyCertificateToData(), since the ResourceError will retain it.
2011-03-29 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Allow the AppleConnect plug-in to use the QuickDraw drawing model
https://bugs.webkit.org/show_bug.cgi?id=57365
<rdar://problem/8712320>
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::determineQuirks):
* Shared/Plugins/PluginQuirks.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPostInitialize):
2011-03-29 Darin Adler <darin@apple.com>
Reviewed by Adam Roben.
WebKit2 bundle page needs to offer generated file hooks
https://bugs.webkit.org/show_bug.cgi?id=57279
* WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added shouldGenerateFileForUpload and
generateFileForUpload callback pointers.
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::shouldGenerateFileForUpload): Added.
(WebKit::InjectedBundlePageUIClient::generateFileForUpload): Added.
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Added functions above.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldReplaceWithGeneratedFileForUpload): Implemented by
calling the functions above.
(WebKit::WebChromeClient::generateReplacementFile): Ditto.
2011-03-29 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Assertion failure in plug-in process with clang-built 32/64-bit WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57359
Don't use __alignof when encoding and decoding scalar types.
Darwin 32-bit, double and unsigned long long are 4-byte aligned but on 64-bit they're
8-byte aligned which causes problems when doing IPC between 32-bit and 64-bit processes.
GCC is buggy and returns 8, but clang is correct and returns 4. Use sizeof instead which we know
is equal to or greater than the alignment.
* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::decodeBool):
(CoreIPC::ArgumentDecoder::decodeUInt32):
(CoreIPC::ArgumentDecoder::decodeUInt64):
(CoreIPC::ArgumentDecoder::decodeInt32):
(CoreIPC::ArgumentDecoder::decodeInt64):
(CoreIPC::ArgumentDecoder::decodeFloat):
(CoreIPC::ArgumentDecoder::decodeDouble):
* Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::encodeBool):
(CoreIPC::ArgumentEncoder::encodeUInt32):
(CoreIPC::ArgumentEncoder::encodeUInt64):
(CoreIPC::ArgumentEncoder::encodeInt32):
(CoreIPC::ArgumentEncoder::encodeInt64):
(CoreIPC::ArgumentEncoder::encodeFloat):
(CoreIPC::ArgumentEncoder::encodeDouble):
2011-03-29 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build fix after r81928.
* win/WebKit2.vcproj: Don't build CG-specific icon routines
for WinCairo port.
2011-03-29 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Reproducible crash running under libgmalloc, in -[WKView(Internal) removeTrackingRect:] --> objc_assign_ivar_non_gc
<rdar://problem/9193352>
https://bugs.webkit.org/show_bug.cgi?id=57358
-[WKView removeTrackingRect] can be called from below -[WKView dealloc] after we have
destroyed _data. So, nil out _data after releasing it and nil check it appropriately.
* UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]):
Nil out _data after releasing it.
(-[WKView removeTrackingRect:]):
Add early return for nil _data.
2011-03-29 Jeff Miller <jeffm@apple.com>
Reviewed by Jon Honeycutt.
Add WebCore::copyCertificateToData() on Windows
https://bugs.webkit.org/show_bug.cgi?id=57296
Remove duplicate code that implemented this functionality in WebCoreArgumentCodersWin.cpp and use WebCore::copyCertificateToData() instead.
* Shared/win/WebCoreArgumentCodersWin.cpp:
(CoreIPC::decodeResourceError): Use WebCore::copyCertificateToData().
2011-03-29 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed build fix (64 bit gcc).
GCC does not accept uint64_t formatted as %lli.
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::getLoadDecisionForIconURL): Add explicit cast to long long.
2011-03-28 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
WKPageGetSourceForFrame and WKPageGetContentsAsString should throw an error in case of a race with page loading
https://bugs.webkit.org/show_bug.cgi?id=57305
<rdar://problem/8738060>, <rdar://problem/8780168>
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Clear m_loadDependentStringCallbackIDs
(WebKit::WebPageProxy::getSourceForFrame): track the callback as load dependent
(WebKit::WebPageProxy::getContentsAsString): ditto
(WebKit::WebPageProxy::clearLoadDependentCallbacks): Invalidate all load dependent callbacks
(WebKit::WebPageProxy::didCommitLoadForFrame): Call clearLoadDependentCallbacks
(WebKit::WebPageProxy::didFailLoadForFrame): ditto
(WebKit::WebPageProxy::stringCallback): Remove callback from load dependent set if appropriate
(WebKit::WebPageProxy::processDidCrash): Clear m_loadDependentStringCallbackIDs
* UIProcess/WebPageProxy.h: Add m_loadDependentStringCallbackIDs hash set.
2011-03-28 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Use String instead of CString as return value of openTemporaryFile
https://bugs.webkit.org/show_bug.cgi?id=55332
* Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::initializeTempLogFile):
* WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::stop):
* WebProcess/Plugins/Netscape/NetscapePluginStream.h:
2011-03-28 Brian Weinstein <bweinstein@apple.com>
Reviewed by Jon Honeycutt.
WebKit2: Downloads started with DownloadCFNet::start never start
https://bugs.webkit.org/show_bug.cgi?id=57268
* WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::start): Call CFURLDownloadStart on the download we create.
2011-03-28 Anders Carlsson <andersca@apple.com>
Fix Windows build.
* Shared/ShareableBitmap.h:
2011-03-28 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Beep when pressing a menu key equivalent when a plug-in has focus
https://bugs.webkit.org/show_bug.cgi?id=57264
<rdar://problem/8935597>
We don't want the WKTextInputWindowController inputContext to be involved in interpretKeyEvents.
* UIProcess/API/mac/WKView.mm:
(-[WKView inputContext]):
2011-03-28 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
CGImageRefs must hold a strong reference to underlying data
https://bugs.webkit.org/show_bug.cgi?id=57263
<rdar://problem/9146179>
Make paintBitmapContext use CGBitmapContextCreateImage, which creates a copy-on-write copy
of the bitmap data. Also, add ShareableBitmap::makeCGImageCopy which does the same thing, and
ShareableBitmap::makeCGImage in the cases where we know that the ShareableBitmap data will never change.
* Platform/cg/CGUtilities.cpp:
(WebKit::paintImage):
Factor image painting code out into a separate function.
(WebKit::paintBitmapContext):
Call paintImage.
* Shared/API/c/cg/WKImageCG.cpp:
(WKImagemakeCGImage):
Use ShareableBitmap::makeCGImageCopy.
* Shared/ShareableBitmap.h:
* Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::paint):
(WebKit::ShareableBitmap::makeCGImageCopy):
(WebKit::ShareableBitmap::makeCGImage):
(WebKit::ShareableBitmap::releaseBitmapContextData):
(WebKit::ShareableBitmap::releaseDataProviderData):
Add makeCGImage and makeCGImageCopy.
* Shared/cg/WebCoreArgumentCodersCG.cpp:
(CoreIPC::createImage):
Use ShareableBitmap::makeCGImage.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setDragImage):
Use ShareableBitmap::makeCGImage and plug a CGImageRef leak.
2011-03-28 Alexey Proskuryakov <ap@apple.com>
Build fix.
* UIProcess/API/mac/WKView.mm: (-[WKView keyDown:]): It's not "event" in this function, it's
"theEvent".
2011-03-28 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=57260
Clean up text input code a little
* UIProcess/API/mac/WKView.mm:
(-[WKView doCommandBySelector:]): This NSTextInput protocol method lacked a LOG() call.
(-[WKView keyDown:]): Added (possibly useless) event protection to match performKeyEquivalent:
and also WebKit1.
* WebProcess/WebPage/mac/WebPageMac.mm: Removed an obsolete comment.
2011-03-28 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
ResourceError::certificate() should return a PCCERT_CONTEXT
https://bugs.webkit.org/show_bug.cgi?id=57262
* Shared/win/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Don't assert if no PCCERT_CONTEXT is specified.
* Shared/win/WebCoreArgumentCodersWin.cpp:
(CoreIPC::encodeResourceError): Removed unneeded code now that ResourceError::certificate() returns a PCCERT_CONTEXT.
2011-03-28 Jeff Miller <jeffm@apple.com>
Rubber-stamped by Adam Roben.
Remove unused CFErrorRef.
* Shared/win/WebCoreArgumentCodersWin.cpp:
(CoreIPC::encodeResourceError): Remove unused CFErrorRef.
2011-03-28 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
Include certificate when sending a WebCore::ResourceError to UI process on Windows
https://bugs.webkit.org/show_bug.cgi?id=57195
Add support for sending the certificate with the WebCore::ResourceError.
* Shared/win/WebCoreArgumentCodersWin.cpp:
(CoreIPC::encodeResourceError): Encode certificate data.
(CoreIPC::deallocCertContext): Added.
(CoreIPC::createCertContextDeallocator): Added.
(CoreIPC::copyCert): Added.
(CoreIPC::decodeResourceError): Decode certificate data.
2011-03-27 Andy Estes <aestes@apple.com>
Reviewed by Maciej Stachowiak.
Correctly get a plug-in's MIME type when it uses WebPluginMIMETypesFilename
https://bugs.webkit.org/show_bug.cgi?id=57205
If the plug-in's Info.plist uses WebPluginMIMETypesFilename to specify
plug-in MIME types, WebKit has to check for a property list file in
~/Library/Preferences for the MIME type dictionary.
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getMIMETypesFromPluginBundle): If the bundle's Info dictionary
has the key WebPluginMIMETypesFilename, open the property list
specified by that key's value and return the MIME type dictionary from
there. Otherwise, return the MIME type dictionary specified by the key
WebPluginMIMETypes.
(WebKit::getPluginInfoFromPropertyLists): Call
getMIMETypesFromPluginBundle().
2011-03-27 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Full Screen: disable keyboard access by default
https://bugs.webkit.org/show_bug.cgi?id=56684
Take into account whether keyboard access was requested when deciding whether full
screen mode is supported.
* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::supportsFullScreen):
* UIProcess/WebFullScreenManagerProxy.h:
* UIProcess/WebFullScreenManagerProxy.messages.in:
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::supportsFullScreen):
* WebProcess/FullScreen/WebFullScreenManager.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::supportsFullScreenForElement):
* WebProcess/WebCoreSupport/WebChromeClient.h:
2011-03-27 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Dock doesn't come back after leaving fullscreen on Hulu
https://bugs.webkit.org/show_bug.cgi?id=57189
<rdar://problem/9192413>
Port some code over from the old WebKit1 plug-in host.
* PluginProcess/mac/PluginProcessShim.mm:
(WebKit::shimShowMenuBar):
(WebKit::shimHideMenuBar):
(WebKit::shimIsMenuBarVisible):
2011-03-27 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Keep a strong reference to the connection to avoid crashes.
* Platform/CoreIPC/Connection.cpp:
2011-03-26 Jeff Miller <jeffm@apple.com>
Reviewed by Sam Weinig.
WKErrorCopyCFError() doesn't actually return a copy of the CFErrorRef
https://bugs.webkit.org/show_bug.cgi?id=57172
* Shared/API/c/cf/WKErrorCF.cpp:
(WKErrorCopyCFError): Use RetainPtr<> and leakRef() to return a real copy.
2011-03-26 Maciej Stachowiak <mjs@apple.com>
Revert inadvertently committed changes.
* WebProcess/com.apple.WebProcess.sb:
2011-03-26 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Enable the Full Screen API by default in WebKit/mac and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56956
* Shared/WebPreferencesStore.h: Default the fullScreenEnabled preference to true.
2011-03-26 Jeff Miller <jeffm@apple.com>
Reviewed by Steve Falkenburg.
Add PlatformCertificateInfo::PlatformCertificateInfo(PCCERT_CONTEXT) constructor on Windows
https://bugs.webkit.org/show_bug.cgi?id=57152
We're going to need to create a PlatformCertificateInfo with a single certificate on Windows to support client certificates.
Also, stop relying on the fact that the Win32 API CertDuplicateCertificateContext() currently returns the same PCCERT_CONTEXT that you pass to it, since that may change in the future.
* Shared/win/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Added PlatformCertificateInfo(PCCERT_CONTEXT) construtor. Use return value from CertDuplicateCertificateContext().
(WebKit::PlatformCertificateInfo::operator=): Use return value from CertDuplicateCertificateContext().
* Shared/win/PlatformCertificateInfo.h: Added PlatformCertificateInfo(PCCERT_CONTEXT) construtor.
2011-03-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Graphic corruption appeared with Silverlight contents while resizing window
https://bugs.webkit.org/show_bug.cgi?id=57167
<rdar://problem/9094052>
Pass DispatchMessageEvenWhenWaitingForSyncReply when sending GeometryDidChange messages since that will guarantee
that those messages will be handled before PaintEntirePlugin messages which prevents the PaintEntirePlugin handler from
painting into the wrong backing store.
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
2011-03-26 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Web process considered unresponsive (SPOD shown) when displaying a JavaScript alert() as a result of a click
<rdar://problem/9067557>
https://bugs.webkit.org/show_bug.cgi?id=57166
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):
Invalidate the responsiveness timer before calling out to the client.
2011-03-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
ASSERTION FAILED: m_operationInProgress == NoOperation loading nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=57165
<rdar://problem/9024311>
The assertion fired because during GC, the web process sends a synchronous NPObjectMessageReceiver::Deallocate
message to the plug-in process. Since this is a synchronous message, the web process needs to process incoming synchronous
messages. While waiting, we get an incoming PluginProxy::Evaluate message from the plug-in. This causes JavaScript to run
during GC which is very bad.
The fix for this is to add a flag on the connection that will cause synchronous messages sent by the connection (in this case the
plug-in process) to not be processed while the other side (the web process) is waiting for a synchronous reply _unless_ the connection
is actually processing a synchronous message. (The last part is to avoid deadlocks).
Since the call to NPN_Evaluate by the plug-in (that ends up sending the PluginProxy::Evaluate message) comes from a run loop timer firing,
it's OK to wait for it to be processed by the web process when it returns to the run loop.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::Connection):
Initialize m_onlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage and m_inDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount.
(CoreIPC::Connection::setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage):
Set m_onlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage.
(CoreIPC::Connection::sendMessage):
Don't add the MessageID::DispatchMessageWhenWaitingForSyncReply flag when the right flags has been set on the connection, and it's not processing a synchronous message.
(CoreIPC::Connection::dispatchMessage):
Increment and decrement m_inDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount accordingly.
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::WebProcessConnection):
Call setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage on the connection.
2011-03-26 Sam Weinig <sam@webkit.org>
Rollout r82042 (If a user doesn't have a Database/LocalStorage directory, it can't be created (sandbox violations))
-[NSString stringByResolvingSymlinksInPath] does not do what we needed for paths within /private.
This caused all SSL sites to stop working.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::appendSandboxParameterPath):
(WebKit::initializeSandbox):
2011-03-26 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
If a user doesn't have a Database/LocalStorage directory, it can't be created (sandbox violations)
<rdar://problem/9127411>
https://bugs.webkit.org/show_bug.cgi?id=57164
* WebProcess/mac/WebProcessMac.mm:
(WebKit::appendSandboxParameterPath):
(WebKit::initializeSandbox):
Use -[NSString stringByResolvingSymlinksInPath] instead of realpath to ensure we can resolve
symlinks even if the file/directory doesn't exist yet.
2011-03-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Factor processing of incoming sync replies out into processIncomingSyncReply
https://bugs.webkit.org/show_bug.cgi?id=57161
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncMessage):
Pass DispatchMessageEvenWhenWaitingForSyncReply to sendMessage.
(CoreIPC::Connection::processIncomingSyncReply):
Move code from processIncomingMessage to here.
(CoreIPC::Connection::processIncomingMessage):
Call processIncomingSyncReply.
2011-03-26 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKit2: Assert in CoreIPC::typeFromCFTypeRef() when loading a site with an invalid certificate
<rdar://problem/9188041>
https://bugs.webkit.org/show_bug.cgi?id=57159
* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::typeFromCFTypeRef):
(CoreIPC::encode):
(CoreIPC::decode):
* Shared/cf/ArgumentCodersCF.h:
Add encoding/decoding for SecCertificateRef type.
* Shared/mac/PlatformCertificateInfo.mm:
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
Use ArgumentCodersCF now that it knows how to encode/decode SecCertificateRefs.
2011-03-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Handle synchronous replies coming in out of order
https://bugs.webkit.org/show_bug.cgi?id=57158
When processing an incoming reply, don't assume that it belongs to the last sent synchronous request.
Instead, iterate over the m_pendingSyncReplies vector backwards looking for the corresponding request.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):
2011-03-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fix a possible deadlock when two synchronous messages are sent at the same time
https://bugs.webkit.org/show_bug.cgi?id=57155
Simplify code and fix a possible (although highly improbable) dead lock.
* Platform/CoreIPC/Connection.cpp:
Make SyncMessageState atomically ref counted since it can be ref()'ed from the connection queue.
Get rid of m_waitForSyncReplyCount and add m_didScheduleDispatchMessagesWork.
(CoreIPC::Connection::SyncMessageState::SyncMessageState):
Initialize m_didScheduleDispatchMessagesWork to false.
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
if m_didScheduleDispatchMessagesWork is false, schedule a call to dispatchMessageAndResetDidScheduleDispatchMessagesWork
on the client run loop.
(CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesWork):
Dispatch messages and set m_didScheduleDispatchMessagesWork back to false.
(CoreIPC::Connection::sendSyncMessage):
Remove calls to beginWaitForSyncReply and endWaitForSyncReply.
2011-03-25 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
WKPageLoadAlternateHTMLString doesn't re-spawn a dead WebProcess, but should
<rdar://problem/9191493>
https://bugs.webkit.org/show_bug.cgi?id=57134
Make all load functions respawn a dead WebProcess for consistency.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadHTMLString):
Respawn a dead WebProcess.
(WebKit::WebPageProxy::loadAlternateHTMLString):
Respawn a dead WebProcess.
(WebKit::WebPageProxy::loadPlainTextString):
Respawn a dead WebProcess.
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadAlternateHTMLString):
Since we may no longer always have a main frame when calling WKPageLoadAlternateHTMLString,
set the unreachable URL, if there is one, on provisional load.
2011-03-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
PluginView's call to invalidateContentsAndWindow() in invalidateRect() is wrong for plug-ins which paint into compositing layers
https://bugs.webkit.org/show_bug.cgi?id=57133
<rdar://problem/9029442>
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformInvalidate):
Return true under the Core Animation drawing model, since that prevents the plug-in from calling PluginController::invalidate.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::invalidateRect):
Don't call invalidateContentsAndWindow() if the plug-in has a Core Animation layer.
2011-03-25 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56425
WebKit2 IconDatabase and API
This gets a basic, usable API in place.
Enhancements can come in other bugs as they're needed.
* UIProcess/API/C/WKIconDatabase.cpp:
(WKIconDatabaseRetainIconForURL):
(WKIconDatabaseReleaseIconForURL):
(WKIconDatabaseEnableDatabaseCleanup):
* UIProcess/API/C/WKIconDatabase.h:
The first actual accessor for an "icon for a URL" is for a CGImageRef:
* UIProcess/API/C/cg: Added.
* UIProcess/API/C/cg/WKIconDatabaseCG.cpp: Added.
(WKIconDatabaseGetCGImageForURL):
* UIProcess/API/C/cg/WKIconDatabaseCG.h: Added.
Expose relevant methods to support the above API:
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::WebIconDatabase): New IconDatabases will have cleanup disabled from the start,
and require a single call to "enableDatabaseCleanup" to allow cleanup.
(WebKit::WebIconDatabase::setDatabasePath):
(WebKit::WebIconDatabase::enableDatabaseCleanup):
(WebKit::WebIconDatabase::imageForPageURL):
* UIProcess/WebIconDatabase.h:
Project file stuff:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
2011-03-25 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Add CoreIPC::encodeResourceError() and CoreIPC::decodeResourceError() for all platforms
https://bugs.webkit.org/show_bug.cgi?id=57125
Currently, these are only implemented on the Mac, but we're going to need them for Windows as well, so we might as well make them always platform-specific.
In this patch, just replicate the existing common non-Mac implementation in WebCoreArgumentCoders.h to platform-specific files.
* Shared/WebCoreArgumentCoders.h: Move non-Mac implementations of encodeResourceError() and decodeResourceError() to common files.
* Shared/gtk/WebCoreArgumentCodersGtk.cpp:
(CoreIPC::encodeResourceError): Added.
(CoreIPC::decodeResourceError): Added.
* Shared/qt/WebCoreArgumentCodersQt.cpp:
(CoreIPC::encodeResourceError): Added.
(CoreIPC::decodeResourceError): Added.
* Shared/win/WebCoreArgumentCodersWin.cpp:
(CoreIPC::encodeResourceError): Added.
(CoreIPC::decodeResourceError): Added.
2011-03-25 Andy Estes <aestes@apple.com>
Reviewed by Adele Peterson.
REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016
Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
2011-03-25 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build correction.
Add stubs for WK2 cookie handling with cURL.
* WebProcess/Cookies/curl: Added.
* WebProcess/Cookies/curl/WebCookieManagerCurl.cpp: Added.
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
* win/WebKit2.vcproj:
2011-03-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Brian Weinstein.
Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll
https://bugs.webkit.org/show_bug.cgi?id=57119
<rdar://problem/9054148>
This plug-in from Microsoft links against xpcom.dll, which is a Firefox-specific DLL
not available in WebKit. The plug-in is fairly widespread, since it was included in
a Windows Update push at one point.
* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::shouldUsePlugin): Blacklist npwpf.dll.
2011-03-25 Jessie Berlin <jberlin@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Need to be able to set and get the Cookie Storage Policy.
https://bugs.webkit.org/show_bug.cgi?id=50780
Part 2: Make it possible to set the initial policy on Windows.
In WebKit1, we read the initial policy on Windows from WebPreferences at startup.
Since that is not possible in WebKit2, make it possible to specify the initial policy
as a creation parameter to the WebProcess.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
Encode initialHTTPCookieAcceptPolicy on Windows.
(WebKit::WebProcessCreationParameters::decode):
Decode initialHTTPCookieAcceptPolicy on Windows.
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/C/win/WKContextPrivateWin.h:
* UIProcess/API/C/win/WKContextWin.cpp:
(WKContextSetInitialHTTPCookieAcceptPolicy):
Call through to WebContext.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
Give the initial policy a default of "Always".
* UIProcess/WebContext.h:
(WebKit::WebContext::setInitialHTTPCookieAcceptPolicy):
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
Set the initial policy on Windows.
* WebProcess/Cookies/WebCookieManager.h:
Make setHTTPCookieAcceptPolicy public so that it can be called from WebProcessWin.
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
Tell the WebCookieManager about the initial policy.
2011-03-25 Jessie Berlin <jberlin@apple.com>
Reviewed by Sam Weinig.
WebKit2: Need to be able to set and get the Cookie Storage Policy.
https://bugs.webkit.org/show_bug.cgi?id=50780
* Shared/HTTPCookieAcceptPolicy.h: Added.
* UIProcess/API/C/WKAPICast.h:
(WebKit::toHTTPCookieAcceptPolicy):
(WebKit::toAPI):
* UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerSetHTTPCookieAcceptPolicy):
Call through to WebCookieManagerProxy.
(WKCookieManagerGetHTTPCookieAcceptPolicy):
Ditto.
* UIProcess/API/C/WKCookieManager.h:
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::invalidate):
Invalidate the get http cookie accept policy callbacks.
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
Send a message to the Web Process with the new value.
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
Keep track of the callback and send a message to the Web Process.
(WebKit::WebCookieManagerProxy::didGetHTTPCookieAcceptPolicy):
Invoke the callback.
* UIProcess/mac/WebCookieManagerProxyMac.mm: Added.
(WebKit::WebCookieManagerProxy::persistHTTPCookieAcceptPolicy):
On Mac, also set the policy in the UI Process because the sandboxed Web Process cannot
persist the policy.
* UIProcess/WebCookieManagerProxy.h:
* UIProcess/WebCookieManagerProxy.messages.in:
* WebKit2.pri:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Common.vsprops:
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
Call platformSetHTTPCookieAcceptPolicy.
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
Send the result of platformGetHTTPCookieAcceptPolicy to the UI Process.
* WebProcess/Cookies/WebCookieManager.h:
* WebProcess/Cookies/WebCookieManager.messages.in:
* WebProcess/Cookies/cf: Added.
* WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp: Added.
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
Set the policy on both the default cookie storage and any Private Browsing cookie storage.
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
* WebProcess/Cookies/mac: Added.
* WebProcess/Cookies/mac/WebCookieManagerMac.mm: Added.
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
Set the policy on the default cookie storage and add a FIXME to set it on any Private
Browsing cookie storage.
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
* WebProcess/Cookies/gtk: Added.
* WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp: Added.
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
* WebProcess/Cookies/qt: Added.
* WebProcess/Cookies/qt/WebCookieManagerQt.cpp: Added.
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
2011-03-25 Brian Weinstein <bweinstein@apple.com>
Reviewed by Alexey Proskuryakov.
REGRESSION(r79227): CFURLCache not initialized correctly in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57109
<rdar://problem/9184590>
Check for a trailing Windows path separator, not a Unix path separator.
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
2011-03-25 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087
Use explicit conversion for string to avoid depending on the default codec
installed by the user code.
* Platform/qt/SharedMemoryQt.cpp:
(WebKit::SharedMemory::create):
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::initializeGTK):
* UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp:
(tst_QGraphicsWKView::loadEmptyPage):
(tst_QGraphicsWKView::loadEmptyUrl):
* UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp:
(tst_QWKPage::loadEmptyUrl):
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::getPluginDisplay):
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::EnvHttpProxyFactory::initializeFromEnvironment):
(WebKit::WebProcessMainQt):
2011-03-25 Brent Fulgham <bfulgham@webkit.org>
Correct project file missing $(WebKitVSPropsRedirectionDir)s
after r81924.
* win/WebKit2.vcproj: Restore lost $(WebKitVSPropsRedirectionDir)
2011-03-25 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[WK2] Consider .c files in the generate-forwarding-headers script
https://bugs.webkit.org/show_bug.cgi?id=56680
* Scripts/generate-forwarding-headers.pl:
2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071
broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
2011-03-24 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=57069
Add WKIconDatabase api to the project files, and expose accessor on WKContext.
Project file stuffs:
* GNUmakefile.am:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* Shared/API/c/WKBase.h:
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKContext.cpp:
(WKContextGetIconDatabase):
* UIProcess/API/C/WKContext.h:
* UIProcess/API/C/WKIconDatabase.cpp: Added.
(WKIconDatabaseGetTypeID):
* UIProcess/API/C/WKIconDatabase.h: Added.
* UIProcess/WebContext.h:
(WebKit::WebContext::iconDatabase):
2011-03-24 Brent Fulgham <bfulgham@webkit.org>
Build correction.
Disable the CA Layer stuff when building with Cairo.
* win/WebKit2.vcproj:
2011-03-24 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=57058
Hookup the UIProcess WebIconDatabase to a WebCore::IconDatabase as its implementation
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::WebIconDatabase):
(WebKit::WebIconDatabase::setDatabasePath): Create a new WebCore::IconDatabase and open it to this path.
(WebKit::WebIconDatabase::retainIconForPageURL): Actually retain the url, using the impl.
(WebKit::WebIconDatabase::releaseIconForPageURL): Actually release the url, using the impl.
(WebKit::WebIconDatabase::setIconURLForPageURL): Actually set the url, using the impl.
(WebKit::WebIconDatabase::setIconDataForIconURL): Actually set the data, using the impl.
(WebKit::WebIconDatabase::getLoadDecisionForIconURL): Actually ask for a load decision to call back with.
(WebKit::WebIconDatabase::performImport):
(WebKit::WebIconDatabase::didImportIconURLForPageURL):
(WebKit::WebIconDatabase::didImportIconDataForPageURL):
(WebKit::WebIconDatabase::didChangeIconForPageURL):
(WebKit::WebIconDatabase::didRemoveAllIcons):
(WebKit::WebIconDatabase::didFinishURLImport): Notify all the pending callbacks what their load decisions
are now that they're available.
* UIProcess/WebIconDatabase.h:
Add an IconDatabase logging channel:
* Platform/Logging.cpp:
(WebKit::initializeLogChannelsIfNecessary):
* Platform/Logging.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setIconDatabasePath): Pass the new path on to the WebIconDatabase, possibly
opening it.
* UIProcess/WebContext.h:
2011-03-24 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016
Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
2011-03-24 Adam Roben <aroben@apple.com>
Start compiling LayerTreeHostCA on Windows
Fixes <http://webkit.org/b/57060> WebKit2.vcproj should compile LayerTreeHostCA
Reviewed by Anders Carlsson.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp: Added.
(WebKit::LayerTreeHostCA::platformInitialize):
(WebKit::LayerTreeHostCA::scheduleLayerFlush):
(WebKit::LayerTreeHostCA::platformInvalidate):
(WebKit::LayerTreeHostCA::platformSizeDidChange):
(WebKit::LayerTreeHostCA::platformForceRepaint):
(WebKit::LayerTreeHostCA::platformDidPerformScheduledLayerFlush):
Stubbed out.
* win/WebKit2.vcproj: Added new files. Let VS reorder existing files.
* win/WebKit2Apple.vsprops: Added WebProcess\WebPage\ca to the include path.
2011-03-24 Jer Noble <jer.noble@apple.com>
Unreviewed build fix.
Remove reference to LayerTreeHostMac.h from WebFullScreenManagerMac.mm.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
2011-03-24 Adam Roben <aroben@apple.com>
Split Mac-specific parts of LayerTreeHostCA into LayerTreeHostCAMac.mm
Fixes <http://webkit.org/b/57046> LayerTreeHostMac's code should be shareable with Windows
Reviewed by Anders Carlsson.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.mm.
(WebKit::LayerTreeHostCA::LayerTreeHostCA): Moved some Mac-specific code to
LayerTreeHostCAMac.mm.
(WebKit::LayerTreeHostCA::~LayerTreeHostCA): Wrapped some Mac-specific code in
PLATFORM(MAC).
(WebKit::LayerTreeHostCA::invalidate):
(WebKit::LayerTreeHostCA::sizeDidChange):
(WebKit::LayerTreeHostCA::forceRepaint):
Moved some Mac-specific code to LayerTreeHostCAMac.mm.
(WebKit::LayerTreeHostCA::performScheduledLayerFlush): Renamed from
flushPendingLayerChangesRunLoopObserverCallback. Moved some code from here...
(WebKit::LayerTreeHostCA::didPerformScheduledLayerFlush): ...to here. Moved some
Mac-specific code to LayerTreeHostCAMac.mm.
* WebProcess/WebPage/ca/LayerTreeHostCA.h: Added new functions, wrapped some Mac-specific
declarations in PLATFORM(MAC).
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm: Added.
(WebKit::LayerTreeHostCA::platformInitialize):
(WebKit::LayerTreeHostCA::scheduleLayerFlush):
(WebKit::LayerTreeHostCA::platformInvalidate):
(WebKit::LayerTreeHostCA::platformSizeDidChange):
(WebKit::LayerTreeHostCA::platformForceRepaint):
(WebKit::LayerTreeHostCA::flushPendingLayerChangesRunLoopObserverCallback):
(WebKit::LayerTreeHostCA::platformDidPerformScheduledLayerFlush):
Code was extracted from LayerTreeHostCA.cpp.
2011-03-24 Adam Roben <aroben@apple.com>
Rename LayerTreeHostMac to LayerTreeHostCA
This is the first step toward sharing code with Windows.
Fixes <http://webkit.org/b/57051>.
Reviewed by Anders Carlsson.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
Updated for rename.
* WebProcess/WebPage/ca/LayerTreeHostCA.h: Renamed from Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h.
* WebProcess/WebPage/ca/LayerTreeHostCA.mm: Renamed from Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm.
2011-03-17 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
WebKit2: Cancelling full screen early leaves full screen window up.
https://bugs.webkit.org/show_bug.cgi?id=56589
No new tests, as WebKitTestRunner does not currently support the new Full Screen API.
Notify the UIProcess when it needs to tear down its layer hosting view, turn off
the background layer when not in accelerated rendering mode and don't swap out
the web view unnecessarily
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController beganExitFullScreenAnimation]): Check before swapping _webView.
(-[WKFullScreenWindowController enterAcceleratedCompositingMode:]): Add the _layerHostingView
to the full screen window's animationView, not its contentsView.
(-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Hide the background layer.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): If given a null rootLayer, tell
the client to exit accelerated mode.
2011-03-24 Enrica Casucci <enrica@apple.com>
Reviewed by Alexey Proskuryakov.
WebKit2:Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
https://bugs.webkit.org/show_bug.cgi?id=56975
<rdar://problem/8915066>
Adding missing entry point to support Mac OS X services in WebKit2.
* UIProcess/API/mac/WKView.mm:
(-[WKView readSelectionFromPasteboard:]): Added.
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::readSelectionFromPasteboard): Added.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Added synchronous
message.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::readSelectionFromPasteboard): Added.
2011-03-24 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Dismissed reversion suggestion is incorrectly learned.
https://bugs.webkit.org/show_bug.cgi?id=57039
CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
[NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
incorrect automatic learning.
* UIProcess/mac/CorrectionPanel.mm:
(WebKit::CorrectionPanel::dismissInternal):
2011-03-24 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
WebKit2: Add Trackpoint driver hack to support IBM trackpads
https://bugs.webkit.org/show_bug.cgi?id=49830
<rdar://problem/8705951>
Copy code from WebKit1 to WebKit2 to handle initializing fake scrollbars so
IBM machines with a trackpad send us WM_VSCROLL and WM_HSCROLL messages.
Listen for the WM_VSCROLL and WM_HSCROLL messages, and turn the values into
ScrollDirection and ScrollGranularity, and send a scroll command to the
WebProcess.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::scrollBy): Send a message to the WebProcess.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::wndProc): Add WM_VSCROLL and WM_HSCROLL message handling.
(WebKit::WebView::initialize): Call shouldInitializeTrackPointHack.
(WebKit::WebView::onHorizontalScroll): Turn wParam into a ScrollDirection and ScrollGranularity.
(WebKit::WebView::onVerticalScroll): Ditto.
(WebKit::WebView::shouldInitializeTrackPointHack): Check the registry for keys that indicate
the machine has a IBM Trackpoint driver.
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scrollBy): Call scroll method.
(WebKit::WebPage::scroll): Moved from WebPageMac and WebPageWin.
(WebKit::WebPage::logicalScroll): Ditto.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Add a new scrollBy message.
* WebProcess/WebPage/mac/WebPageMac.mm: Remove scroll and logicalScroll, they are now in WebPage.cpp.
* WebProcess/WebPage/win/WebPageWin.cpp: Ditto.
2011-03-24 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Dictionary text extraction is not correctly detecting word boundaries on bing.com
<rdar://problem/9078569>
https://bugs.webkit.org/show_bug.cgi?id=56995
* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h:
Add options dictionary.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
Add path that can pass options through.
* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::lookUpInDictionary):
Use the new performDictionaryLookupForSelection which can extract context
if supported.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::characterRangeAtPositionForPoint):
(WebKit::characterRangeAtPoint):
Split functionality out of characterRangeAtPoint and into
characterRangeAtPositionForPoint to avoid doing duplicate work
if you already have the position.
(WebKit::isPositionInRange):
(WebKit::shouldUseSelection):
Add predicate to determine if we should use the selection instead
of expanding to find the word we are over.
(WebKit::WebPage::performDictionaryLookupAtLocation):
If available, use the surrounding paragraph as context to get better extraction
and to get lexicographical information about the word. Also, clean up and use
editing APIs to make the code more concise and understandable.
(WebKit::WebPage::performDictionaryLookupForSelection):
Use similar logic as in performDictionaryLookupAtLocation to extract additional
details from a selection for use in the dictionary popup.
(WebKit::WebPage::performDictionaryLookupForRange):
Pass options to WebProcess if available.
2011-03-24 Jon Lee <jonlee@apple.com>
Reviewed by Darin Adler.
WebKit2: Tabbing from the last focused field to a non-webpage element leaves the selection in a weird state
<rdar://problem/8553962>
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setFocused): When the page loses focus, clear out any selection in the frame
2011-03-24 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Sam Weinig.
Fix a typo in the VK_LEFT case of performDefaultBehaviorForKeyEvent.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): It should be a logical or,
not a bitwise or.
2011-03-24 Jeff Miller <jeffm@apple.com>
Fix typo - USE(CF_NETWORK) should be USE(CFNETWORK).
* WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
(WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): USE(CF_NETWORK) should be USE(CFNETWORK)
2011-03-23 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Hook up new AppKit autocorrection UI with WK2.
https://bugs.webkit.org/show_bug.cgi?id=56055
<rdar://problem/8947463>
Please see WebCore/ChangeLog for detail.
The calls to AppKit are implemented in PageClientImpl. Other changes are necessary for the
plumbing work.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::showCorrectionPanel):
(WebKit::PageClientImpl::dismissCorrectionPanel):
(WebKit::PageClientImpl::dismissCorrectionPanelSoon):
(WebKit::PageClientImpl::recordAutocorrectionResponse):
* UIProcess/API/mac/WKView.mm:
(-[WKView spellCheckerDocumentTag]):
(-[WKView handleCorrectionPanelResult:]):
* UIProcess/API/mac/WKViewPrivate.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::showCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanelSoon):
(WebKit::WebPageProxy::recordAutocorrectionResponse):
(WebKit::WebPageProxy::handleCorrectionPanelResult):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/CorrectionPanel.h: Added.
(WebKit::CorrectionPanel::isShowing):
* UIProcess/mac/CorrectionPanel.mm: Added.
(correctionBubbleType):
(WebKit::CorrectionPanel::CorrectionPanel):
(WebKit::CorrectionPanel::~CorrectionPanel):
(WebKit::CorrectionPanel::show):
(WebKit::CorrectionPanel::dismiss):
(WebKit::CorrectionPanel::dismissSoon):
(WebKit::CorrectionPanel::dismissInternal):
(WebKit::CorrectionPanel::recordAutocorrectionResponse):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::showCorrectionPanel):
(WebKit::WebEditorClient::dismissCorrectionPanel):
(WebKit::WebEditorClient::dismissCorrectionPanelSoon):
(WebKit::WebEditorClient::recordAutocorrectionResponse):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::handleCorrectionPanelResult):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
2011-03-23 Brian Weinstein <bweinstein@apple.com>
Reviewed by Maciej Stachowiak.
WebKit2: Need API to manage the Media Cache
https://bugs.webkit.org/show_bug.cgi?id=56878
<rdar://problem/9082503>
Call through to HTMLMediaElement functions to manage the WebCore media cache.
* WebProcess/MediaCache/WebMediaCacheManager.cpp:
(WebKit::WebMediaCacheManager::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManager::clearCacheForHostname):
(WebKit::WebMediaCacheManager::clearCacheForAllHostnames):
2011-03-23 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Add WKBundleSetHostAllowsAnyHTTPSCertificate() for Windows
https://bugs.webkit.org/show_bug.cgi?id=56972
This is the WebKit2 equivalent to the WebKit1 API IWebMutableURLRequest::setAllowsAnyHTTPSCertificate().
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetHostAllowsAnyHTTPSCertificate): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added WKBundleSetHostAllowsAnyHTTPSCertificate().
* WebProcess/InjectedBundle/InjectedBundle.h: Added setHostAllowsAnyHTTPSCertificate().
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
(WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): Added, should never be called.
* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
(WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): Added, should never be called.
* WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
(WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): Added, should never be called.
* WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
(WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): Added.
2011-03-23 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Roll out r81593 Need WebKit2 API for creating a page with a specific main frame name
This API is not necessary.
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/API/mac/WKView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:]):
(-[WKView initWithFrame:contextRef:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createMainFrame):
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
2011-03-23 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[WK2] Handle keyboard and mouse events on X11
https://bugs.webkit.org/show_bug.cgi?id=56103
Propagate keyboard and mouse events to the plugin
as XEvent's.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::initializeXEvent):
(WebKit::xTimeStamp):
(WebKit::xKeyModifiers):
(WebKit::setCommonMouseEventFields):
(WebKit::setXMotionEventFields):
(WebKit::setXButtonEventFields):
(WebKit::setXCrossingEventFields):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::setXKeyEventFields):
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
2011-03-23 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Connection::SyncMessageState::processIncomingMessage should ignore whether the message is sync or not
https://bugs.webkit.org/show_bug.cgi?id=56954
This is so we'll eventually be able to send sync messages that aren't processed immediately if the
destination is waiting for a reply to another synchronous message.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
Only check for the DispatchMessageWhenWaitingForSyncReply flag.
(CoreIPC::Connection::sendSyncMessage):
Add both DispatchMessageWhenWaitingForSyncReply and SyncMessage to the message ID.
* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::sendSync):
(CoreIPC::Connection::deprecatedSendSync):
No need to add SyncMessage here anymore.
2011-03-23 Brian Weinstein <bweinstein@apple.com>
Qt Build Fix.
* DerivedSources.pro:
2011-03-22 Brian Weinstein <bweinstein@apple.com>
Reviewed by Darin Adler.
WebKit2: Need API to manage the Media Cache
https://bugs.webkit.org/show_bug.cgi?id=56878
<rdar://problem/9082503>
Project File Fun:
* GNUmakefile.am:
* WebKit2.pri:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Common.vsprops:
* win/WebKit2Generated.make:
Derived Sources and API fun:
* DerivedSources.make:
* DerivedSources.pro:
* Platform/CoreIPC/MessageID.h:
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* UIProcess/API/C/WKAPICast.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage): Add a case for MediaCache messages.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage): Ditto.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Initialize the WebMediaCacheManagerProxy member variable.
(WebKit::WebContext::~WebContext): Invalidate the WebMediaCacheManagerProxy.
(WebKit::WebContext::disconnectProcess): Ditto.
(WebKit::WebContext::didReceiveMessage): Add a case for MediaCache messages.
* UIProcess/WebContext.h:
(WebKit::WebContext::mediaCacheManagerProxy):
* UIProcess/API/C/WKContext.cpp:
(WKContextGetMediaCacheManager): Returns the context's WebMediaCacheManager.
* UIProcess/API/C/WKContext.h:
* UIProcess/API/C/WKMediaCacheManager.cpp: Added.
(WKMediaCacheManagerGetTypeID): Returns the WebMediaCacheManagerProxy type.
(WKMediaCacheManagerGetHostnamesWithMediaCache): Calls down to the WebMediaCacheManagerProxy.
(WKMediaCacheManagerClearCacheForHostname): Ditto.
(WKMediaCacheManagerClearCacheForAllHostnames): Ditto.
* UIProcess/API/C/WKMediaCacheManager.h: Added.
* UIProcess/WebMediaCacheManagerProxy.cpp: Added.
(WebKit::WebMediaCacheManagerProxy::create):
(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy):
(WebKit::WebMediaCacheManagerProxy::~WebMediaCacheManagerProxy):
(WebKit::WebMediaCacheManagerProxy::invalidate):
(WebKit::WebMediaCacheManagerProxy::didReceiveMessage):
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache): Call through to the WebProcess.
(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache): Process the WebProcess response,
and call the callback.
(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname): Call through to the WebProcess.
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames): Call through to the WebProcess.
* UIProcess/WebMediaCacheManagerProxy.h: Added.
(WebKit::WebMediaCacheManagerProxy::clearContext):
(WebKit::WebMediaCacheManagerProxy::type):
* UIProcess/WebMediaCacheManagerProxy.messages.in: Added.
* WebProcess/MediaCache: Added.
* WebProcess/MediaCache/WebMediaCacheManager.cpp: Added.
(WebKit::WebMediaCacheManager::shared):
(WebKit::WebMediaCacheManager::WebMediaCacheManager):
(WebKit::WebMediaCacheManager::didReceiveMessage):
(WebKit::WebMediaCacheManager::getHostnamesWithMediaCache): Added a FIXME to call through to WebCore.
(WebKit::WebMediaCacheManager::clearCacheForHostname): Ditto.
(WebKit::WebMediaCacheManager::clearCacheForAllHostnames): Ditto.
* WebProcess/MediaCache/WebMediaCacheManager.h: Added.
* WebProcess/MediaCache/WebMediaCacheManager.messages.in: Added.
2011-03-22 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Add asynchronous load decision call to WebKit2 IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=56887
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::getLoadDecisionForIconURL): In the future, get the actual load decision from the database.
For now, always message "IconLoadNo" back to the WebProcess.
* UIProcess/WebIconDatabase.h:
* UIProcess/WebIconDatabase.messages.in:
* WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::loadDecisionForIconURL): Message the UIProcess for the load decision.
(WebKit::WebIconDatabaseProxy::receivedIconLoadDecision): Callback into WebCore with the received load decision.
* WebProcess/IconDatabase/WebIconDatabaseProxy.h:
* WebProcess/IconDatabase/WebIconDatabaseProxy.messages.in:
2011-03-23 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
REGRESSION: WK2: AX: PDF in Safari no longer accessible.
https://bugs.webkit.org/show_bug.cgi?id=56849
The WKView needs to know when to return the WKPDFView and when to return
the remote web process connection.
* UIProcess/API/mac/PDFViewController.h:
(WebKit::PDFViewController::pdfView):
* UIProcess/API/mac/WKView.mm:
(-[WKView accessibilityFocusedUIElement]):
(-[WKView accessibilityHitTest:]):
(-[WKView accessibilityAttributeValue:]):
2011-03-21 Stephanie Lewis <slewis@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=56798
Wrap autorelease pools around calls that can have pathological memory growth on Membuster.
Only wrap the main runloop because some background threads are not expected to call into
objc and an autorelease pool could mask bugs.
* Platform/mac/RunLoopMac.mm:
(RunLoop::performWork):
(RunLoop::TimerBase::timerFired):
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback):
2011-03-22 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
OBJECT element with DivX source is always downloaded
https://bugs.webkit.org/show_bug.cgi?id=56879
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromPropertyLists):
Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in
specifies multiple file extensions in a single element.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::pluginSupportsExtension):
Add a new helper function.
(WebKit::WebFrameLoaderClient::objectContentType):
If we can't find the MIME for an extension, explicitly check if there's a plugin that claims to
handle the given extension.
2011-03-22 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Rename the synchronous icon database messages to be prefixed with "synchronous"
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::synchronousIconDataForPageURL):
(WebKit::WebIconDatabase::synchronousIconURLForPageURL):
(WebKit::WebIconDatabase::synchronousIconDataKnownForIconURL):
(WebKit::WebIconDatabase::synchronousLoadDecisionForIconURL):
* UIProcess/WebIconDatabase.h:
* UIProcess/WebIconDatabase.messages.in:
* WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
2011-03-22 Sam Weinig <sam@webkit.org>
Rubber-stamped by Anders Carlsson.
Loading a new tab does not dismiss Lookup
<rdar://problem/9138391>
* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
Hide the dictionary popup when moving the WKView out of a window.
2011-03-22 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Microsoft Silverlight playback shows artifacts
https://bugs.webkit.org/show_bug.cgi?id=56863
<rdar://problem/9103136>
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
If the plug-in is transparent, clear the dirty rect before painting.
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::determineQuirks):
Add the MakeTransparentIfBackgroundAttributeExists quirk for Silverlight plug-ins.
* Shared/Plugins/PluginQuirks.h:
Add MakeTransparentIfBackgroundAttributeExists quirk.
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_SetValue):
Handle NPPVpluginTransparentBool.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_isTransparent to false.
(WebKit::NetscapePlugin::setIsTransparent):
Set m_isTransparent.
(WebKit::NetscapePlugin::initialize):
If the plug-in has the MakeTransparentIfBackgroundAttributeExists quirk, make it transparent
if there's a 'background' attribute.
(WebKit::NetscapePlugin::isTransparent):
Add getter.
* WebProcess/Plugins/Plugin.h:
Add isTransparent().
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
Always copy the plug-in backing store to the plug-in proxy backing store.
(WebKit::PluginProxy::isTransparent):
Add getter that should never be called.
(WebKit::PluginProxy::update):
Always copy the plug-in backing store to the plug-in proxy backing store.
2011-03-22 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash when calling PluginProxy::evaluate on a destroyed plug-in
https://bugs.webkit.org/show_bug.cgi?id=56848
<rdar://problem/9168975>
Return early if the NPObject doesn't exist anymore.
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::evaluate):
2011-03-22 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
WebKit2: Cannot make a selection past the end of the visible page (no autoscrolling)
<rdar://problem/8823874>
https://bugs.webkit.org/show_bug.cgi?id=56847
* Shared/mac/WebEventFactory.mm:
(WebKit::currentMouseButton):
(WebKit::mouseButtonForEvent):
Add mouse button for mouseEnter/Exit events. [NSEvent buttonNumber] doesn't seem to give the right result
for these events, but getting the currentMouseButton does work.
2011-03-21 Brady Eidson <beidson@apple.com>
Fix Mac release builds after https://bugs.webkit.org/show_bug.cgi?id=56783
* Platform/mac/Logging.mac.mm:
2011-03-21 Brady Eidson <beidson@apple.com>
Reviewed by Brian Weinstein.
https://bugs.webkit.org/show_bug.cgi?id=56783
Actually hook up WebKit2 logging on Mac.
* Platform/Logging.cpp:
(WebKit::initializeLogChannel):
* Platform/Logging.h:
* Platform/mac/Logging.mac.mm: Added.
(WebKit::initializeLogChannel):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Initialize logging if necessary.
* WebKit2.xcodeproj/project.pbxproj:
2011-03-21 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
REGRESSION (r81269): WebKit2 gets into an infinite recursion after an unhandled command key
https://bugs.webkit.org/show_bug.cgi?id=56782
<rdar://problem/9151993>
* UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent):
Factored out code for resending an event and moved it to WKView.
* UIProcess/API/mac/WKView.mm:
(-[WKView performKeyEquivalent:]): Don't zero out _keyDownEventBeingResent, it's easier
to just do that in _resendKeyDownEvent:.
(-[WKView keyDown:]): Ditto.
(-[WKView _resendKeyDownEvent:]): Moved from PageClientImpl.mm. Added an assertion that we
are not already resending an event - it would be too confusing if we ever had to do that,
but looks like this never happens.
* UIProcess/API/mac/WKViewInternal.h: Exposed _resendKeyDownEvent.
2011-03-21 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
QT plug-in fails to load contextual menu
https://bugs.webkit.org/show_bug.cgi?id=56777
<rdar://problem/8979033>
Open a Carbon resource map and make it the current map when calling NP_Initialize.
* Platform/Module.cpp:
(WebKit::Module::Module):
Initialize m_bundleResourceMap to -1.
* Platform/Module.h:
Add m_bundleResourceMap.
* Platform/mac/ModuleMac.mm:
(WebKit::Module::unload):
Close the resource map.
(WebKit::Module::bundleResourceMap):
Open a resource map if necessary.
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
Get the resource map and make it current before calling NP_Initialize.
2011-03-21 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Plug-in process crashes if it fails to load a plug-in module
https://bugs.webkit.org/show_bug.cgi?id=56775
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::initialize):
If NetscapePlugin::create returns null, call removePluginControllerProxy with a null plug-in.
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::removePluginControllerProxy):
Remove an incorrect assertion. Don't invalidate the remote object map if the plug-in is null.
2011-03-21 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
QT plug-in loads controller at top of movie not bottom
https://bugs.webkit.org/show_bug.cgi?id=56764
<rdar://problem/8979037>
Create a layer with geometryFlipped set and add the plug-in layer as a sublayer,
matching WebKit1.
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPostInitialize):
2011-03-21 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKit2 needs preferences to change security knobs
https://bugs.webkit.org/show_bug.cgi?id=56762
Add preferences for WebSecurityEnabled, UniversalAccessFromFileURLsAllowed
and FileAccessFromFileURLsAllowed.
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWebSecurityEnabled):
(WKPreferencesGetWebSecurityEnabled):
(WKPreferencesSetUniversalAccessFromFileURLsAllowed):
(WKPreferencesGetUniversalAccessFromFileURLsAllowed):
(WKPreferencesSetFileAccessFromFileURLsAllowed):
(WKPreferencesGetFileAccessFromFileURLsAllowed):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
2011-03-21 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove old DrawingArea and LayerHostingView code from WKView.
* UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
(-[WKView hitTest:]):
(-[WKView WebKit::]):
2011-03-21 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Need WebKit2 API for creating a page with a specific main frame name
https://bugs.webkit.org/show_bug.cgi?id=56759
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
Add mainFrameName to creation parameters.
* UIProcess/API/mac/WKView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:]):
(-[WKView initWithFrame:contextRef:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:mainFrameName:]):
Add new initializer which takes a main frame name.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setMainFrameName):
(WebKit::WebPageProxy::creationParameters):
* UIProcess/WebPageProxy.h:
Store the main frame name for initialization/re-initialization.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createMainFrame):
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Pass the name to main frame creation.
2011-03-20 Bill Budge <bbudge@chromium.org>
Reviewed by Adam Barth.
Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714
No new tests. Exposes no new functionality.
* Platform/CoreIPC/Connection.h:
* Platform/WorkQueue.h:
* Platform/win/WorkQueueWin.cpp:
* UIProcess/Launcher/ProcessLauncher.h:
* UIProcess/Launcher/ThreadLauncher.h:
2011-03-19 Anton D'Auria <adauria@apple.com>
Reviewed by Alexey Proskuryakov.
ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
https://bugs.webkit.org/show_bug.cgi?id=56415
* WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: calling ApplicationCacheGroup::deleteCacheGroupsForOrigin
instead of ApplicationCacheStorage::deleteEntriesForOrigin.
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
2011-03-18 Sam Weinig <sam@webkit.org>
Attempt to fix the WinCairo build.
* win/WebKit2.vcproj:
2011-03-18 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Empty gray page after going back from a PDF
https://bugs.webkit.org/show_bug.cgi?id=56694
<rdar://problem/8811854>
Update m_frameHasCustomRepresentation when loading a page that's in the page cache.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2011-03-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash when sending a sync message ends up invalidating the connection
https://bugs.webkit.org/show_bug.cgi?id=56686
<rdar://problem/9048781>
Guard against a null client.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncMessage):
2011-03-18 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Benjamin Poulain.
[Qt][WK2] Need a way to debug the web process after the UI process dies
https://bugs.webkit.org/show_bug.cgi?id=56116
Allow the web process to outlive it's parent process
in debug builds if the QT_WEBKIT_KEEP_ALIVE_WEB_PROCESS
environment variable is set.
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::QtWebProcess::setupChildProcess): Used getenv
since the prctl call is already in a Linux-only block
and the implementation in this file is a candidate
for sharing across ports in the future.
2011-03-18 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
Command-period does not stop load when page has focus in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56601
* UIProcess/API/mac/WKView.mm:
(-[WKView doCommandBySelector:]): If called outside interpretKeyEvents,
call through to super.
(-[WKView insertText:]): Assert that we are inside interpretKeyEvents.
(-[WKView unmarkText]): Ditto.
(-[WKView setMarkedText:selectedRange:]): Ditto.
(-[WKView _interceptKeyEvent:]): Set a flag to indicate we are inside
interpretKeyEvents for use by the above.
2011-03-18 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=56425
More groundwork for WebKit2 IconDatabase
-Update the synchronous method names to be prefixed with "synchronous."
-Add empty implementations for the asynchronous accessors.
* WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::setEnabled):
(WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconDataKnownForIconURL):
(WebKit::WebIconDatabaseProxy::synchronousLoadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::supportsAsynchronousMode):
(WebKit::WebIconDatabaseProxy::loadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::iconDataForIconURL):
* WebProcess/IconDatabase/WebIconDatabaseProxy.h:
2011-03-18 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Fixed compilation after r80925.
* GNUmakefile.am:
* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp: Added.
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode):
(WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode):
(WebKit::WebFullScreenManagerProxy::getFullScreenRect):
* WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.cpp: Added.
(WebKit::WebFullScreenManagerGtk::WebFullScreenManagerGtk):
(WebKit::WebFullScreenManager::create):
(WebKit::WebFullScreenManagerGtk::setRootFullScreenLayer):
(WebKit::WebFullScreenManagerGtk::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerGtk::beginExitFullScreenAnimation):
* WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.h: Added.
2011-03-18 Alejandro G. Castro <alex@igalia.com>
Unreviewed, fixed compilation after r81208.
* GNUmakefile.am:
2011-03-18 John Sullivan <sullivan@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=56645
Assertion fires when hidden Find-on-Page matches are encountered in WebKit2
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
Bail out if the selection rect is empty, before trying to generate an appropriately-sized
bitmap. (Previously it was bailing out afterwards, but encountering an assertion in debug
builds along the way.)
2011-03-18 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Jon Honeycutt.
<rdar://problem/9153929> PluginProcess fails to launch due to PluginProcessShim.dylib building for 64-bit only
Fix a bogus change from r81392 that made PluginProcessShim.xcconfig import DebugRelease.xcconfig.
As its name suggests, DebugRelease.xcconfig is only applicable for the debug and release configurations.
It overrides the valid build architectures and also restricts the build to only the active architecture.
* Configurations/PluginProcessShim.xcconfig: Import BaseTarget.xcconfig instead. This is what
each target-specific .xcconfig file should import.
2011-03-17 Mark Rowe <mrowe@apple.com>
Fix the build.
* WebKit2.xcodeproj/project.pbxproj:
2011-03-17 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement PluginProcessProxy::setFullscreenWindowIsShowing
https://bugs.webkit.org/show_bug.cgi?id=56618
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::PluginProcessProxy):
Initialize m_fullscreenWindowIsShowing.
(WebKit::PluginProcessProxy::didClose):
if m_fullscreenWindowIsShowing is true, call exitFullscreen.
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::getPluginProcessSerialNumber):
Add helper function for getting a PSN for the plug-in process.
(WebKit::PluginProcessProxy::makePluginProcessTheFrontProcess):
Make the plug-in process the front process.
(WebKit::PluginProcessProxy::makeUIProcessTheFrontProcess):
Make the current process (the UI process) the front process.
(WebKit::PluginProcessProxy::setFullscreenWindowIsShowing):
Call enterFullscreen or exitFullscreen.
(WebKit::PluginProcessProxy::enterFullscreen):
Make the plug-in process the front process and hide the menu bar.
(WebKit::PluginProcessProxy::exitFullscreen):
Show the menu bar and if necessary make the UI process the front process.
(WebKit::PluginProcessProxy::endModal):
call makeUIProcessTheFrontProcess.
(WebKit::PluginProcessProxy::applicationDidBecomeActive):
Call makePluginProcessTheFrontProcess.
2011-03-17 Adam Roben <aroben@apple.com>
Make bidi text in <select> menus in WebKit2 on Windows match WebKit1
Fixes <http://webkit.org/b/56614> 3 <select> bidi tests failing on Windows 7 Release
(WebKit2 Tests)
Reviewed by Sam Weinig.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
(WebKit::WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):
On Windows, return the same values we return in WebKit1.
2011-03-17 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement PluginProcessProxy::setModalWindowIsShowing
https://bugs.webkit.org/show_bug.cgi?id=56615
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::PluginProcessProxy):
Initialize m_modalWindowIsShowing.
(WebKit::PluginProcessProxy::didClose):
If m_modalWindowIsShowing is true, we must call endModal.
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(-[WKPlaceholderModalWindow _wantsUserAttention]):
Add a WKPlaceholderModalWindow.
(WebKit::PluginProcessProxy::setModalWindowIsShowing):
Call beginModal or endModal depending on whether we're showing a modal window or not.
(WebKit::PluginProcessProxy::beginModal):
Create a fake window and start a nested run loop. Listen for NSApplicationWillBecomeActiveNotification notifications.
(WebKit::PluginProcessProxy::endModal):
Tear down the window and the run loop.
(WebKit::PluginProcessProxy::applicationDidBecomeActive):
Make sure that the plug-in process is frontmost.
2011-03-17 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
Web page shouldn't swallow alt-key combinations on Windows
https://bugs.webkit.org/show_bug.cgi?id=56612
Make Alt+Left Arrow and Alt+Right Arrow go back and forward, but make
sure any alt-key combinations bubble up to the client.
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): Make Alt+Left Arrow and Alt+Right Arrow go back and forward, ignore any other alt-key combinations.
2011-03-17 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Send SetModalWindowIsShowing and SetFullscreenWindowIsShowing messages to the UI process
https://bugs.webkit.org/show_bug.cgi?id=56610
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::FullscreenWindowTracker::FullscreenWindowTracker):
Add fullscreen window tracker class.
(WebKit::rectCoversAnyScreen):
Return whether the given rect covers any screen.
(WebKit::windowCoversAnyScreen):
Return whether the given window covers any screen.
(WebKit::FullscreenWindowTracker::windowShown):
If we're showing a fullscreen window, call PluginProcess::setFullscreenWindowIsShowing.
(WebKit::FullscreenWindowTracker::windowHidden):
If we're hiding the last fullscreen window, call PluginProcess::setFullscreenWindowIsShowing.
(WebKit::cocoaWindowShown):
(WebKit::cocoaWindowHidden):
(WebKit::carbonWindowShown):
(WebKit::carbonWindowHidden):
Call the window tracking functions.
(WebKit::setModal):
Call PluginProcess::setModalWindowIsShowing.
(WebKit::PluginProcess::setModalWindowIsShowing):
(WebKit::PluginProcess::setFullscreenWindowIsShowing):
Send CoreIPC messages.
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Plugins/PluginProcessProxy.messages.in:
Add new messages.
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::setModalWindowIsShowing):
(WebKit::PluginProcessProxy::setFullscreenWindowIsShowing):
Add stubs.
2011-03-17 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Allow passing a certificate chain as a user message
<rdar://problem/8951709>
https://bugs.webkit.org/show_bug.cgi?id=56605
* Shared/API/c/mac/WKCertificateInfoMac.h:
* Shared/API/c/mac/WKCertificateInfoMac.mm:
(WKCertificateInfoCreateWithCertficateChain):
Added. Creates a WKCertificate from a certificate chain.
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add encoding/decoding of WebCertificateInfo.
2011-03-17 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add PluginProcessShim hooks for when windows are shown and hidden
https://bugs.webkit.org/show_bug.cgi?id=56597
* Configurations/PluginProcessShim.xcconfig:
Add HEADER_SEARCH_PATHS so we can find WebKitSystemInterface.h.
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::cocoaWindowShown):
(WebKit::cocoaWindowHidden):
(WebKit::carbonWindowShown):
(WebKit::carbonWindowHidden):
(WebKit::setModal):
(WebKit::PluginProcess::initializeShim):
Add empty stubs.
* PluginProcess/mac/PluginProcessShim.h:
* PluginProcess/mac/PluginProcessShim.mm:
(WebKit::beginModal):
(WebKit::endModal):
Keep a modal count and call setModal accordingly.
(WebKit::shim_NSApplication_RunModalForWindow):
(WebKit::shimModalDialog):
(WebKit::shimAlert):
Call beginModal/endModal.
(WebKit::shimShowWindow):
(WebKit::shimHideWindow):
Call the shim functions.
(WebKit::WebKitPluginProcessShimInitialize):
Listen for notifications and call the necessary shim functions.
* WebKit2.xcodeproj/project.pbxproj:
Link the plug-in process shim with AppKit and QuartzCore and WKSI.
2011-03-17 Jeff Miller <jeffm@apple.com>
Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
*.mode*
*.pbxuser
*.perspective*
project.xcworkspace
xcuserdata
* WebKit2.xcodeproj: Modified property svn:ignore.
2011-03-17 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WKErrors need the PeerCertificateChain for certificate errors
<rdar://problem/8951784>
https://bugs.webkit.org/show_bug.cgi?id=56592
* Shared/WebCoreArgumentCoders.h:
Special case encoding/decoding of ResourceErrors for the mac.
* Shared/mac/PlatformCertificateInfo.h:
* Shared/mac/PlatformCertificateInfo.mm:
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
Add constructor that take the PeerCertificateChain as CFArrayRef.
* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::encodeResourceError):
(CoreIPC::decodeResourceError):
Add encode/decode for ResourceError using the underlying NSError
and encoding/decoding as much of the userInfo as we know how to.
Right now this includes all string values and the PeerCertificateChain.
2011-03-17 John Sullivan <sullivan@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=56574
Dealloc'ing a WKView can leave a stale reference to it in NSWindow
* UIProcess/API/mac/WKView.mm:
(-[WKView viewWillMoveToWindow:]):
Clear the outgoing window's growBoxOwner if it is this view.
2011-03-17 Anders Carlsson <andersca@apple.com>
Rubber-stamped by John Sullivan.
Rename PluginProcessShim.cpp to PluginProcessShim.mm.
* PluginProcess/mac/PluginProcessShim.cpp: Removed.
* PluginProcess/mac/PluginProcessShim.mm: Copied from PluginProcess/mac/PluginProcessShim.cpp.
* WebKit2.xcodeproj/project.pbxproj:
2011-03-17 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Invalidate all NPObjects for a plug-in when that plug-in is destroyed
https://bugs.webkit.org/show_bug.cgi?id=56511
<rdar://problem/8993491>
Before this change, we would invalidate NPObjectProxy objects and delete NPObjectMessageReceiver
objects when the last plug-in of a certain type was destroyed. Doing so caused us to hold on to memory
which we don't need, and could also lead to crashes if the NPObjectMessageReceiver would get a message and
tried to invoke it on a already deallocated NPObject.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::initialize):
If we fail to initialize, call removePluginControllerProxy instead of having WebProcessConnection do so.
(WebKit::PluginControllerProxy::destroy):
Pass the plug-in to removePluginControllerProxy.
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::removePluginControllerProxy):
Call NPRemoteObjectMap::pluginDestroyed when the plug-in has been destroyed.
(WebKit::WebProcessConnection::createPlugin):
Don't call removePluginControllerProxy if the plug-in fails to initialize. PluginControllerProxy::initialize now
takes care of doing this.
* Shared/Plugins/NPObjectMessageReceiver.cpp:
(WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
* Shared/Plugins/NPObjectMessageReceiver.h:
Remove m_shouldReleaseObjectWhenInvalidating, we now know that no NPObjects will have been deallocated
by the time the NPObjectMessageReceiver is destroyed.
(WebKit::NPObjectMessageReceiver::plugin):
Add getter.
* Shared/Plugins/NPObjectProxy.h:
(WebKit::NPObjectProxy::plugin):
Add getter.
* Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::NPRemoteObjectMap):
Remove m_isInvalidating.
(WebKit::NPRemoteObjectMap::npObjectProxyDestroyed):
Simplify code.
(WebKit::NPRemoteObjectMap::pluginDestroyed):
Rename invalidate to pluginDestroyed. Only invalidate/delete objects that belong to the given plug-in.
* Shared/Plugins/NPRemoteObjectMap.h:
Remove m_isInvalidating.
* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::removePluginProxy):
Call NPRemoteObjectMap::pluginDestroyed when the plug-in has been destroyed.
2011-03-17 Oleg Romashin <oleg.romashin@nokia.com>
Reviewed by Anders Carlsson.
Teach WebKit2 messages.py generator to ifdef headers include
which are related to ifdef-ed methods/types
https://bugs.webkit.org/show_bug.cgi?id=55658
* Scripts/webkit2/messages.py:
* Scripts/webkit2/messages_unittest.py:
2011-03-16 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Viewport no longer allows an auto value for "user-scalable"
https://bugs.webkit.org/show_bug.cgi?id=55416
Make the default value for userScalable be true.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::viewportAttributesForSize):
2011-03-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
NPObjectProxy and NPObjectMessageReceiver objects should know their Plugin object
https://bugs.webkit.org/show_bug.cgi?id=56506
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::windowScriptNPObject):
(WebKit::PluginControllerProxy::pluginElementNPObject):
(WebKit::PluginControllerProxy::evaluate):
(WebKit::PluginControllerProxy::getPluginScriptableNPObject):
* Shared/Plugins/NPObjectMessageReceiver.cpp:
(WebKit::NPObjectMessageReceiver::create):
(WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
(WebKit::NPObjectMessageReceiver::invoke):
(WebKit::NPObjectMessageReceiver::invokeDefault):
(WebKit::NPObjectMessageReceiver::getProperty):
(WebKit::NPObjectMessageReceiver::setProperty):
(WebKit::NPObjectMessageReceiver::construct):
* Shared/Plugins/NPObjectMessageReceiver.h:
* Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::create):
(WebKit::NPObjectProxy::NPObjectProxy):
(WebKit::NPObjectProxy::invalidate):
(WebKit::NPObjectProxy::initialize):
(WebKit::NPObjectProxy::invoke):
(WebKit::NPObjectProxy::invokeDefault):
(WebKit::NPObjectProxy::getProperty):
(WebKit::NPObjectProxy::setProperty):
(WebKit::NPObjectProxy::construct):
* Shared/Plugins/NPObjectProxy.h:
* Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::createNPObjectProxy):
(WebKit::NPRemoteObjectMap::registerNPObject):
(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
* Shared/Plugins/NPRemoteObjectMap.h:
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::pluginScriptableNPObject):
(WebKit::PluginProxy::getWindowScriptNPObject):
(WebKit::PluginProxy::getPluginElementNPObject):
(WebKit::PluginProxy::evaluate):
2011-03-16 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=54987 Crash beneath
WebPageProxy::viewWillStartLiveResize when resizing window after web process
crashed
-and corresponding-
<rdar://problem/9037685>
Just need simple isValid() checks here.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeUIClient):
(WebKit::WebPageProxy::viewWillStartLiveResize):
(WebKit::WebPageProxy::viewWillEndLiveResize):
2011-03-16 Damian Kaleta <dkaleta@apple.com>
Reviewed by Kevin Decker.
Add a user default that will force all plugins to opt in to non-executable data
https://bugs.webkit.org/show_bug.cgi?id=56487
<rdar://problem/9109095>
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::PluginProcessProxy):
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::pluginNeedsExecutableHeap):
2011-03-16 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
WK2: Need to propagate enhanced accessibility flag from UI -> web process
https://bugs.webkit.org/show_bug.cgi?id=56379
Support sending the enhanced accessibility flag between processes.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::setEnhancedAccessibility):
* UIProcess/WebContext.h:
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContet::platformInvalidateContext):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformInvalidateContext):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInvalidateContext):
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformInvalidateContext):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setEnhancedAccessibility):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
2011-03-15 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make Structure creation require a JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=56438
Mechanical change to make all Structure creation use a JSGlobalData&.
* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::JSNPMethod):
* WebProcess/Plugins/Netscape/JSNPMethod.h:
(WebKit::JSNPMethod::createStructure):
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::JSNPObject):
* WebProcess/Plugins/Netscape/JSNPObject.h:
(WebKit::JSNPObject::createStructure):
2011-03-16 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
WebKit2: Sometimes Command-[ opens a new tab and loads the back page in it
https://bugs.webkit.org/show_bug.cgi?id=56477
<rdar://problem/8806664>
* UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent):
Set NSApplication current event when re-dispatching a key event that returned from the web
process unhandled. That way, code that looks at current event modifiers won't be confused.
2011-03-16 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Add WebKit2 API to figure out if an input or textarea was edited
https://bugs.webkit.org/show_bug.cgi?id=56474
Expose WKBundleNodeHandleGetHTMLInputElementLastChangeWasUserEdit and
WKBundleNodeHandleGetHTMLTextAreaElementLastChangeWasUserEdit. Next time,
I will work on giving these functions longer names.
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleGetHTMLInputElementLastChangeWasUserEdit):
(WKBundleNodeHandleGetHTMLTextAreaElementLastChangeWasUserEdit):
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
2011-03-16 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=56467
IconDatabase-related crash seen in WK2 tests
* WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::setIconDataForIconURL): The IconLoader might set a null data for an icon, so handle that case.
2011-03-16 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Loading an empty URL crashes
https://bugs.webkit.org/show_bug.cgi?id=55501
A null WKURLRef is created in the API of WebKit 2 when converting a null string. The code
of WKPageLoadURL assume the WKPageRef is not null which causes crashes if it is.
This patch uses the converter toWTFString() to pass from WKPageRef to WTFString. This converter
ensure the returned string is a valid null string.
Tested through the Qt API tests.
* UIProcess/API/C/WKPage.cpp:
(WKPageLoadURL):
* UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp:
(tst_QGraphicsWKView::loadEmptyUrl):
* UIProcess/API/qt/tests/qwkpage/qwkpage.pro: Added.
* UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp: Added.
(tst_QWKPage::init):
(tst_QWKPage::cleanup):
(tst_QWKPage::loadEmptyUrl):
* UIProcess/API/qt/tests/tests.pro:
2011-03-15 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=56425
WebKit2 icon database.
Project file paperwork:
* DerivedSources.make:
* DerivedSources.pro:
* GNUmakefile.am:
* WebKit2.pri:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Common.vsprops:
* Scripts/webkit2/messages.py: Special-case capitalization for messages that start with "URL" to be lowercased
to "url" instead of "uRL".
Add messaging-related stuff:
* Platform/CoreIPC/MessageID.h:
* UIProcess/WebIconDatabase.messages.in: Added.
* WebProcess/IconDatabase/WebIconDatabaseProxy.messages.in: Added.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
Prep to make WebIconDatabase an API object:
* Shared/APIObject.h:
Add an "icon DB is enabled" flag to WebProcessCreationParameters:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
Add SPI for client apps to set the icon database path:
* UIProcess/API/C/WKContext.cpp:
(WKContextSetIconDatabasePath):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.h:
(WebKit::WebContext::setIconDatabasePath):
Hook up initialization, clearing, and messaging for the icon database:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
(WebKit::WebContext::iconDatabasePath):
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultIconDatabasePath):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultIconDatabasePath):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformDefaultIconDatabasePath):
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformDefaultIconDatabasePath):
Add the UIProcess-side IconDatabase. It will be the "actual database" as well as the API object:
* UIProcess/WebIconDatabase.cpp: Added.
(WebKit::WebIconDatabase::create):
(WebKit::WebIconDatabase::~WebIconDatabase):
(WebKit::WebIconDatabase::WebIconDatabase):
(WebKit::WebIconDatabase::invalidate):
(WebKit::WebIconDatabase::retainIconForPageURL):
(WebKit::WebIconDatabase::releaseIconForPageURL):
(WebKit::WebIconDatabase::setIconURLForPageURL):
(WebKit::WebIconDatabase::setIconDataForIconURL):
(WebKit::WebIconDatabase::iconDataForPageURL):
(WebKit::WebIconDatabase::iconURLForPageURL):
(WebKit::WebIconDatabase::iconDataKnownForIconURL):
(WebKit::WebIconDatabase::loadDecisionForIconURL):
(WebKit::WebIconDatabase::didReceiveMessage):
(WebKit::WebIconDatabase::didReceiveSyncMessage):
* UIProcess/WebIconDatabase.h: Added.
(WebKit::WebIconDatabase::clearContext):
(WebKit::WebIconDatabase::type):
Add the WebProcess-side IconDatabaseProxy. It acts as the WebCore IconDatabase and operates via messaging:
* WebProcess/IconDatabase: Added.
* WebProcess/IconDatabase/WebIconDatabaseProxy.cpp: Added.
(WebKit::WebIconDatabaseProxy::~WebIconDatabaseProxy):
(WebKit::WebIconDatabaseProxy::WebIconDatabaseProxy):
(WebKit::WebIconDatabaseProxy::isEnabled):
(WebKit::WebIconDatabaseProxy::setEnabled):
(WebKit::WebIconDatabaseProxy::iconForPageURL):
(WebKit::WebIconDatabaseProxy::retainIconForPageURL):
(WebKit::WebIconDatabaseProxy::releaseIconForPageURL):
(WebKit::WebIconDatabaseProxy::iconURLForPageURL):
(WebKit::WebIconDatabaseProxy::iconDataKnownForIconURL):
(WebKit::WebIconDatabaseProxy::loadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::setIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
(WebKit::WebIconDatabaseProxy::urlImportFinished):
(WebKit::WebIconDatabaseProxy::didReceiveMessage):
* WebProcess/IconDatabase/WebIconDatabaseProxy.h: Added.
Hook up initialization and messaging for the icon database proxy:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::didReceiveMessage):
* WebProcess/WebProcess.h:
2011-03-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKit2: False SPOD cursor when context menu is open
<rdar://problem/9029154>
https://bugs.webkit.org/show_bug.cgi?id=56433
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showContextMenu):
Update to match showPopupMenu idiomatically, and stop the responsivenessTimer
since the act of showing the context menu could spin a nested runloop.
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):
* UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::WebContextMenuProxyQt::showContextMenu):
* UIProcess/win/WebContextMenuProxyWin.cpp:
(WebKit::WebContextMenuProxyWin::showContextMenu):
Move isEmpty() check to implementations, since we don't want to show
this in any case, not just the one where we check it.
2011-03-15 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian][WK2] Fix exporting and importing the WebProcessMainQt symbol
https://bugs.webkit.org/show_bug.cgi?id=56417
Use the Q_DECL_EXPORT and Q_DECL_IMPORT macros directly to make sure
the symbol is always exported/imported.
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
* qt/MainQt.cpp:
2011-03-15 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
REGRESSION (WebKit2): keygen element doesn't work
https://bugs.webkit.org/show_bug.cgi?id=56402
<rdar://problem/9006545>
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Added strings used by keygen.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: Initialize a WebCore pointer to
a function used by keygen.
2011-03-15 Beth Dakin <bdakin@apple.com>
Reviewed by Simon Fraser.
WebKit2 part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
New WebKitystemInterface function to force the scrollbars to flash
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
2011-03-15 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Make sure that NP_Shutdown is always the last NPP function called
https://bugs.webkit.org/show_bug.cgi?id=56391
<rdar://problem/8989902>
Make sure to always increment the load count whenever a web process connection
is opened to a plug-in process, and decrement it when the last web process connection
goes away.
* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::createWebProcessConnection):
(WebKit::PluginProcess::startShutdownTimerIfNecessary):
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
* Shared/Plugins/Netscape/NetscapePluginModule.h:
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
(WebKit::NetscapePlugin::~NetscapePlugin):
2011-03-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Barth.
[GTK] [WebKit2] The UIProcess never changes the mouse cursor
https://bugs.webkit.org/show_bug.cgi?id=56333
Add an implementation for WebView::addCursor for WebKit2 GTK+. This allows
the cursor to change as the user mouses around the page. There is currently
no test infrastructure to track cursor changes.
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::setCursor): Ported implementation from WebKit1.
2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Darin Adler.
Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
info into the headers rather than in export symbol definition files, but disable it on
all platforms initially so we can deal with port build issues one port at a time.
https://bugs.webkit.org/show_bug.cgi?id=27551
* config.h:
2011-03-14 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
REGRESSION: Print preview is blank when selecting multiple pages per sheet
https://bugs.webkit.org/show_bug.cgi?id=56341
<rdar://problem/8991382>
* UIProcess/API/mac/WKPrintingView.mm: (pageDidDrawToPDF): Don't reset latest expected
callback number after receiving a different one. We only update preview after receiving
the latest expected page data (and the assumption is that AppKit will ask for pages in
natural order for N-up).
2011-03-14 Adam Roben <aroben@apple.com>
Make WKBundlePageCanHandleRequest return true for empty document URLs
Reviewed by Sam Weinig.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::canHandleRequest): Return true for any URL schemes that are handled as
empty documents, and defer to the platform for everything else.
* WebProcess/WebPage/WebPage.h: Added platformCanHandleRequest.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformCanHandleRequest):
* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformCanHandleRequest):
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::platformCanHandleRequest):
Renamed from canHandleRequest.
2011-03-14 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
CrashTracer: 60 crashes in WebProcess at com.apple.WebKit2: -[AccessibilityWebPageObject accessibilityHitTest:] + 248
https://bugs.webkit.org/show_bug.cgi?id=56336
Crash trace indicates a nil pointer access in one of these m_page->mainFrame()->coreFrame()->view()
pointers.
* WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
(-[AccessibilityWebPageObject accessibilityHitTest:]):
2011-03-14 Alice Liu <alice.liu@apple.com>
Reviewed by Sam Weinig.
Provide API for creating WKImage from CGImageRef
https://bugs.webkit.org/show_bug.cgi?id=56159
Add function for creating a WKImage from CGImage data.
* Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateFromCGImage): Added. Creates a graphics context for the bitmap-backed image and draws into it.
* Shared/API/c/cg/WKImageCG.h:
2011-03-14 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Adam Roben.
[Qt][WK2]Unbreak InjectedBundle on Qt
https://bugs.webkit.org/show_bug.cgi?id=54109
Add API's to WKURL and WKString to satisfy
WebKitTestRunner's needs.
* Shared/API/c/WKString.cpp:
(WKStringIsEqualToUTF8CStringIgnoringCase):
* Shared/API/c/WKString.h:
* Shared/API/c/WKURL.cpp:
(WKURLCopyHostName):
(WKURLCopyScheme):
* Shared/API/c/WKURL.h:
* Shared/WebString.h:
(WebKit::WebString::equalToUTF8StringIgnoringCase):
* Shared/WebURL.h: Added OwnPtr<KURL> member to be able
to lazily parse the URL and store the result.
(WebKit::WebURL::host):
(WebKit::WebURL::protocol):
(WebKit::WebURL::parseURLIfNecessary):
* win/WebKit2.def: Revert the symbol exports that were
needed to use KURL in WebKitTestRunner.
2011-03-14 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
Add WKViewSetScrollOffsetOnNextResize() to C API on Windows
https://bugs.webkit.org/show_bug.cgi?id=56340
* UIProcess/API/C/win/WKView.cpp:
(WKViewSetScrollOffsetOnNextResize): Added.
* UIProcess/API/C/win/WKView.h: Added WKViewSetScrollOffsetOnNextResize().
* UIProcess/win/WebView.cpp:
(WebKit::WebView::onSizeEvent): Apply any scroll offset when setting the drawing area size.
(WebKit::WebView::setScrollOffsetOnNextResize): Added.
* UIProcess/win/WebView.h: Added setScrollOffsetOnNextResize().
2011-03-14 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben and Gavin Barraclough.
FileSystemWin.cpp needs listDirectory() implementation
https://bugs.webkit.org/show_bug.cgi?id=56331
<rdar://problem/9126635>
Move PathWalker down into WebCore, and call the PathWalker in WebCore
(that now has a second argument, the pattern to take).
* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::pluginPathsInDirectory):
2011-03-14 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
WebKit2: No icon shown for <input type=file>
<rdar://problem/8988982>
https://bugs.webkit.org/show_bug.cgi?id=54288
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::chooseIconForFiles):
Add implementation for chooseIconForFiles which calls down to Icon::createIconForFiles.
2011-03-14 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/8762095> and https://bugs.webkit.org/show_bug.cgi?id=55172
Need WK2 API to view/manage origins with LocalStorage
Hookup the existing API stubs to the WebCore implementations:
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):
2011-03-13 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/9127270> and https://bugs.webkit.org/show_bug.cgi?id=56282
Pass the path along with creation parameters:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
Add SPI to set the path:
* UIProcess/API/C/WKContext.cpp:
(WKContextSetLocalStorageDirectory):
* UIProcess/API/C/WKContextPrivate.h:
Pass the path along in the process creation parameters:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::localStorageDirectory):
* UIProcess/WebContext.h:
(WebKit::WebContext::setLocalStorageDirectory):
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
Include the path with settings updates, because WebCore needs it set on the Settings object:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/WebProcess.h:
(WebKit::WebProcess::localStorageDirectory):
Sandboxing stuff:
* WebProcess/com.apple.WebProcess.sb:
* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
2011-03-12 Jer Noble <jer.noble@apple.com>
Reviewed by Mark Rowe.
WebKit2: Build WKFullScreenWindowController cleanly in 32-bit.
https://bugs.webkit.org/show_bug.cgi?id=56260
Include <Carbon/Carbon.h> instead of <HIToolbox/MacApplication.h>.
* UIProcess/mac/WKFullScreenWindowController.mm:
2011-03-13 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add ability to create a WKErrorRef
<rdar://problem/9115768>
https://bugs.webkit.org/show_bug.cgi?id=56279
* Shared/API/c/cf/WKErrorCF.cpp: Added.
(WKErrorCreateWithCFError):
(WKErrorCopyCFError):
* Shared/API/c/cf/WKErrorCF.h: Added.
Add new API to create a WKErrorRef from a CFErrorRef
and vice-versa.
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
Add new files.
2011-03-13 Pratik Solanki <psolanki@apple.com>
Reviewed by Brady Eidson.
Make adjustMIMETypeIfNecessary use CFNetwork directly
https://bugs.webkit.org/show_bug.cgi?id=55912
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Support for new WKSI functions.
2011-03-13 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
WebPageProxy cleanup
https://bugs.webkit.org/show_bug.cgi?id=56267
* UIProcess/WebPageProxy.cpp: Moved all Mac-only function implementations from
here to WebPageProxyMac.mm.
* UIProcess/WebPageProxy.h: Cleaned up #includes.
* UIProcess/mac/WebPageProxyMac.mm: Moved all Mac-only function implementations
here.
(WebKit::WebPageProxy::updateWindowIsVisible):
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::getMarkedRange):
(WebKit::WebPageProxy::characterIndexForPoint):
(WebKit::WebPageProxy::firstRectForCharacterRange):
(WebKit::WebPageProxy::writeSelectionToPasteboard):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::sendComplexTextInputToPlugin):
(WebKit::WebPageProxy::uppercaseWord):
(WebKit::WebPageProxy::lowercaseWord):
(WebKit::WebPageProxy::capitalizeWord):
(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::setComplexTextInputEnabled):
2011-03-13 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/8949683> WebKit2: Drag image is offset when the page is scrolled down
https://bugs.webkit.org/show_bug.cgi?id=56265
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag): Send the location in view coordinates rather than
document coordinates.
2011-03-13 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
Fix a crash when dragging.
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap): Retain the saved context.
2011-03-12 Darin Adler <darin@apple.com>
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag): Fixed typo in a comment.
2011-03-11 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Dragging image to desktop gives webloc instead of image file in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56193
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap): Added. Factored out from startDrag to
make the startDrag code clearer.
(WebKit::WebDragClient::startDrag): Streamlined code a bit.
(WebKit::cachedImage): Added. Helper for function below.
(WebKit::arrayForURLsWithTitles): Added. Helper for function below.
(WebKit::WebDragClient::declareAndWriteDragImage): Added code to handle file
promises and removed a log of uneeded code.
(-[WKPasteboardFilePromiseOwner copyDropDirectory]): Added.
(promisedDataClient): Added.
(-[WKPasteboardOwner clearImage]): Added.
(-[WKPasteboardOwner initWithImage:]): Added.
(-[WKPasteboardOwner dealloc]): Added.
(-[WKPasteboardOwner finalize]): Added.
(-[WKPasteboardOwner pasteboard:provideDataForType:]): Added.
(-[WKPasteboardOwner pasteboardChangedOwner:]): Added.
(matchesExtensionOrEquivalent): Added.
(-[WKPasteboardOwner namesOfPromisedFilesDroppedAtDestination:]): Added.
Much of the new code above came from the WebKit1 drag code.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::dragEnded): Added call to Mac-only platformDragEnded.
* WebProcess/WebPage/WebPage.h: Added Mac-only platformDragEnded and m_dragSource.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setDragSource): Added.
(WebKit::WebPage::platformDragEnded): Added.
2011-03-12 Mark Rowe <mrowe@apple.com>
Fix the 32-bit build.
This involves hacking around some HIToolbox headers that do things of dubious correctness,
and fixing the usual CGRect vs NSRect issues.
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]): NSRect is not CGRect.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
2011-03-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::url):
Get the URL from the loader, not from the document.
(WebKit::WebFrame::suggestedFilenameForResourceWithURL):
Return the correct suggested filename for the main resource.
(WebKit::WebFrame::mimeTypeForResourceWithURL):
Return the correct mime type for the main resource.
2011-03-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Should be able to download a PDF to the Downloads folder
https://bugs.webkit.org/show_bug.cgi?id=56256
* UIProcess/API/C/WKPage.h:
Add WKPageSaveDataToFileInDownloadsFolderCallback to the UI client.
* UIProcess/API/mac/PDFViewController.h:
* UIProcess/API/mac/PDFViewController.mm:
(-[WKPDFView _applyPDFPreferences]):
(-[WKPDFView _updatePreferences:]):
Use new PDFViewController::page getter.
(-[WKPDFView PDFViewSavePDFToDownloadFolder:]):
Call PDFViewController::savePDFToDownloadsFolder.
(WebKit::releaseCFData):
(WebKit::PDFViewController::savePDFToDownloadsFolder):
Create a WebData that wraps the CFData, then pass it along to
WebPageProxy::saveDataToFileInDownloadsFolder.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::saveDataToFileInDownloadsFolder):
Call WebUIClient::saveDataToFileInDownloadsFolder.
(WebKit::WebUIClient::saveDataToFileInDownloadsFolder):
* UIProcess/WebUIClient.h:
Call the UI client callback function.
2011-03-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
WebData should be able to wrap already existing data
https://bugs.webkit.org/show_bug.cgi?id=56254
* Shared/WebData.h:
(WebKit::WebData::createWithoutCopying):
(WebKit::WebData::create):
(WebKit::WebData::~WebData):
(WebKit::WebData::bytes):
(WebKit::WebData::size):
(WebKit::WebData::WebData):
(WebKit::WebData::fastFreeBytes):
2011-03-12 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
WebKit2: Initialize the WebFullScreenManagerProxy with a WKView
https://bugs.webkit.org/show_bug.cgi?id=56250
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]): Call fullScreenManager()->setView(self).
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220
* WebProcess/FullScreen/WebFullScreenManager.cpp: .
(WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
(WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
(WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
(WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
(WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
(WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
* WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
concrete subclass.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
(-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
(-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
(-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
(-[WebFullScreenManagerAnimationListener invalidate]): Added.
(WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
(WebKit::WebFullScreenManagerMac::create): Added.
(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
which will animate the full screen renderer from its initial position to its final one.
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Hook up new WKFullScreenWindowController functions to WebFullScreenManagerProxy
https://bugs.webkit.org/show_bug.cgi?id=56218
* UIProcess/WebFullScreenManagerProxy.cpp:
* UIProcess/mac/WebFullScreenManagerProxyMac.mm: Added.
(WebKit::WebFullScreenManagerProxy::enterFullScreen): Call into WKFullScreenWindowController.
(WebKit::WebFullScreenManagerProxy::exitFullScreen): Ditto.
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation): Ditto.
(WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation): Ditto.
(WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation): Ditto.
(WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation): Ditto.
(WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode): Ditto.
(WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode): Ditto.
(WebKit::WebFullScreenManagerProxy::getFullScreenRect): Ditto.
* UIProcess/API/mac/WKView.mm:
(-[WKView fullScreenWindowController]): Lazily instantiate a WKFullScreenWindowController.
* UIProcess/API/mac/WKViewInternal.h:
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Add the WKFullScreenWindowController, mostly cribbed from WebKit's WebFullScreenController.
[WebKit2] Implement a full screen window controller
https://bugs.webkit.org/show_bug.cgi?id=56210
* UIProcess/mac/WKFullScreenWindowController.h: Added.
* UIProcess/mac/WKFullScreenWindowController.mm: Added.
(-[WKFullScreenWindowController init]): Remove the _mediaEventListener.
(-[WKFullScreenWindowController dealloc]): Make sure to cancel previous async requests.
(-[WKFullScreenWindowController windowDidLoad]): Remove the Tiger protection.
(-[WKFullScreenWindowController webView]): Type change.
(-[WKFullScreenWindowController setWebView:]): Type change.
(-[WKFullScreenWindowController applicationDidResignActive:]): Case changes.
(-[WKFullScreenWindowController applicationDidChangeScreenParameters:]): Case changes.
(-[WKFullScreenWindowController enterFullScreen:]): Removed most of the animation code
which will reappear in WebFullScreenManager.
(-[WKFullScreenWindowController beganEnterFullScreenAnimation]): Added.
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Added.
(-[WKFullScreenWindowController exitFullScreen]): Ditto to enterFullScreen.
(-[WKFullScreenWindowController beganExitFullScreenAnimation]): Added.
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Added.
(-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]): Set up the
layer tree host.
(-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Tear down same.
(-[WKFullScreenWindowController getFullScreenRect:WebCore::]): Added.
(-[WKFullScreenWindowController _updateMenuAndDockForFullScreen]): Case changes.
(-[WKFullScreenWindowController _disableIdleDisplaySleep]): Ditto.
(-[WKFullScreenWindowController _enableIdleDisplaySleep]): Ditto.
(-[WKFullScreenWindowController _disableIdleSystemSleep]): Ditto.
(-[WKFullScreenWindowController _enableIdleSystemSleep]): Ditto.
(-[WKFullScreenWindowController _enableTickleTimer]): Ditto.
(-[WKFullScreenWindowController _disableTickleTimer]): Ditto.
(-[WKFullScreenWindowController _tickleTimerFired]): Ditto.
(-[WKFullScreenWindowController _updatePowerAssertions]): Use _isPlaying ivar.
(-[WKFullScreenWindowController _manager]): Added.
(-[WKFullScreenWindowController _requestExit]): Case changes.
(-[WKFullScreenWindowController _requestExitFullScreenWithAnimation:]): Ditto.
(-[WKFullScreenWindowController _swapView:with:]): Added.
(-[WKFullScreenWindowController _fullScreenWindow]): Case changes.
(-[WKFullScreenWindow initWithContentRect:styleMask:backing:defer:]): Geometry no
longer needs to be flipped.
(-[WKFullScreenWindow cancelOperation:]): Case changes.
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Create new interface stubs to support full screen mode in WebKit2.
WebKit2: Plumb new full screen animation APIs through WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=55993
* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::WebFullScreenManagerProxy): Added.
(WebKit::WebFullScreenManagerProxy::invalidate): Clear m_webView.
(WebKit::WebFullScreenManagerProxy::setWebView): Set m_webView.
(WebKit::WebFullScreenManagerProxy::beginEnterFullScreenAnimation): Added.
(WebKit::WebFullScreenManagerProxy::beginExitFullScreenAnimation): Added.
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation): Added stub.
(WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation): Added stub.
(WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation): Added stub.
(WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation): Added stub.
(WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode): Added stub.
(WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode): Added stub.
(WebKit::WebFullScreenManagerProxy::getFullScreenRect): Added stub.
* UIProcess/WebFullScreenManagerProxy.h:
* UIProcess/WebFullScreenManagerProxy.messages.in: Added new message definitions.
* UIProcess/WebPageProxy.cpp: Moved include of WebFullScreenManagerProxy.h into source file.
* UIProcess/WebPageProxy.h: Ditto.
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::element): Added.
(WebKit::WebFullScreenManager::supportsFullScreen): Send message through WebPage.
(WebKit::WebFullScreenManager::enterFullScreenForElement): Ditto.
(WebKit::WebFullScreenManager::exitFullScreenForElement): Ditto.
(WebKit::WebFullScreenManager::beganEnterFullScreenAnimation): Added..
(WebKit::WebFullScreenManager::finishedEnterFullScreenAnimation): Added.
(WebKit::WebFullScreenManager::beganExitFullScreenAnimation): Added.
(WebKit::WebFullScreenManager::finishedExitFullScreenAnimation): Added.
(WebKit::WebFullScreenManager::setRootFullScreenLayer): Added stub.
(WebKit::WebFullScreenManager::getFullScreenRect): Added.
(WebKit::WebFullScreenManager::beginEnterFullScreenAnimation): Added stub.
(WebKit::WebFullScreenManager::beginExitFullScreenAnimation): Added stub.
* WebProcess/FullScreen/WebFullScreenManager.h:
* WebProcess/FullScreen/WebFullScreenManager.messages.in: Added new message definitions.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setRootFullScreenLayer): Added.
* WebProcess/WebCoreSupport/WebChromeClient.h:
2011-03-11 Alice Liu <alice.liu@apple.com>
Reviewed by Sam Weinig.
Support encoding /decoding WebData in usermessages
https://bugs.webkit.org/show_bug.cgi?id=56158
Added encoding/decoding for APIObject::TypeData
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
2011-03-11 Alice Liu <alice.liu@apple.com>
Reviewed by Sam Weinig.
Add api for "remove" to WKMutableDictionary
https://bugs.webkit.org/show_bug.cgi?id=56157
* Shared/API/c/WKMutableDictionary.cpp:
(WKDictionaryRemoveItem): Added; call remove on MutableDictionary impl.
* Shared/API/c/WKMutableDictionary.h:
* Shared/MutableDictionary.cpp:
(WebKit::MutableDictionary::remove): Added; call remove on the underlying hashmap.
* Shared/MutableDictionary.h:
2011-03-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80899 and r80912.
http://trac.webkit.org/changeset/80899
http://trac.webkit.org/changeset/80912
https://bugs.webkit.org/show_bug.cgi?id=56236
Caused animation tests to crash on Snow Leopard WebKit2
(Requested by rniwa on #webkit).
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
(WebKit::ShareableBitmap::resize):
* Shared/ShareableBitmap.h:
(WebKit::ShareableBitmap::numBytesForSize):
(WebKit::ShareableBitmap::sizeInBytes):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::update):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::didUpdate):
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::didUpdate):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/SharedMemoryCache.cpp: Removed.
* WebProcess/WebPage/SharedMemoryCache.h: Removed.
* win/WebKit2.vcproj:
2011-03-11 Brian Weinstein <bweinstein@apple.com>
Windows build fix. Add SharedMemoryCache to the vcproj.
* win/WebKit2.vcproj:
2011-03-11 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=56222
A window remains frozen if web process crashes during printing
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setComplexTextInputEnabled):
* UIProcess/WebPageProxy.h:
Moved setAutodisplay code into WKPrintingView.
* UIProcess/API/mac/WKPrintingView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView printOperationWithPrintInfo:forFrame:]):
Keep a reference to the actual WKView, so that we can manipulate how it displays, even if
page goes away.
* UIProcess/API/mac/WKPrintingView.mm:
(-[WKPrintingView initWithFrameProxy:WebKit::view:]):
(-[WKPrintingView _setAutodisplay:]):
(-[WKPrintingView _suspendAutodisplay]):
(-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
Move setAutodisplay here.
2011-03-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a shared memory cache to the web process
https://bugs.webkit.org/show_bug.cgi?id=56232
Add a very simple shared memory cache to the web process, so that we don't have to allocate and
free memory over and over when painting.
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
(WebKit::ShareableBitmap::resize):
* Shared/ShareableBitmap.h:
(WebKit::ShareableBitmap::numBytesNeededForBitmapSize):
(WebKit::ShareableBitmap::sizeInBytes):
Rename numBytesForSize to numBytesNeededForBitmapSize.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::update):
Always send back a DidUpdate message, even if we didn't use the update info.
This is needed so that the web process knows when the UI process is done with the shared memory inside
the update info struct.
* WebKit2.xcodeproj/project.pbxproj:
Add new files.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::didUpdate):
* WebProcess/WebPage/DrawingArea.messages.in:
DidUpdate now takes a boolean.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::sharedMemoryCache):
Add shared memory cache.
(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
Return the shared memory to the cache.
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
display now takes an extra boolean.
(WebKit::DrawingAreaImpl::didUpdate):
Return the shared memory to the cache.
(WebKit::DrawingAreaImpl::display):
If useSharedMemoryCache is true, get shared memory from the cache.
* WebProcess/WebPage/SharedMemoryCache.cpp: Added.
(WebKit::SharedMemoryCache::acquireSharedMemory):
If the memory we currently hold on to is big enough, return it.
(WebKit::SharedMemoryCache::releaseSharedMemory):
If we're already holding on to shared memory, evict it if the returned
shared memory object is bigger than the one we currently hold.
(WebKit::SharedMemoryCache::clearCacheTimerFired):
Null out the shared memory object.
2011-03-11 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
Process has finished launching.
https://bugs.webkit.org/show_bug.cgi?id=56208
Only send the message if the Web Process is valid.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::clearResourceCaches):
2011-03-11 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Don't paint more than 60 times per second
https://bugs.webkit.org/show_bug.cgi?id=56206
<rdar://problem/9085989>
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
Initialize m_lastDisplayTime to 0. Change the display timer to call displayTimerFired.
(WebKit::DrawingAreaImpl::didUpdate):
Call displayTimerFired instead of display.
(WebKit::DrawingAreaImpl::displayTimerFired):
If we're asked to paint again less than 1/60th of a second after we've already painted,
defer painting.
(WebKit::DrawingAreaImpl::display):
Update m_lastDisplayTime.
2011-03-11 Mark Rowe <mrowe@apple.com>
Reviewed by Alice Liu.
<rdar://problem/9120161> WKPageRestoreFromSessionState does not set the pending API request URL.
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData): If we're navigating to a back/forward item
as part of the restoration, call setPendingAPIRequestURL. When there's a provisional URL this will
be done by our call to loadURL elsewhere in the function.
2011-03-10 Alexey Proskuryakov <ap@apple.com>
Reviewed by Jon Honeycutt.
WebKit2 UI process crashes if web process crashes while computing page rects for printing
https://bugs.webkit.org/show_bug.cgi?id=56160
<rdar://problem/9027410>
* UIProcess/API/mac/WKPrintingView.mm:
(-[WKPrintingView _suspendAutodisplay]): Added a null check for page, matching one that
we have when resuming autodisplay.
(-[WKPrintingView _delayedResumeAutodisplayTimerFired]): Added a FIXME.
(pageDidComputePageRects): Sanitize results coming from the web process (and avoid crashing
when there is a communication error, so results are all null).
(-[WKPrintingView knowsPageRange:]): If there is no page any more, we can't tell how many
pages it had.
(-[WKPrintingView rectForPage:]): Handle the case where we are neither calculating pages
nor knowing them, as it happens when the web process crashes.
2011-03-10 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Sam Weinig.
Part of <rdar://problem/8728860> WebKit2 needs to be made localizable
The presence of CFBundleDevelopmentRegion in the application's Info.plist prevents
the default localization that we set during launch from being respected.
* PluginProcess/Info.plist: Remove CFBundleDevelopmentRegion.
* WebProcess/Info.plist: Ditto.
2011-03-10 Martin Robinson <mrobinson@igalia.com>
Build for WebKit2 GTK+ after r80714.
* GNUmakefile.am: Update source list.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::x11Display): Add missing semicolon.
2011-03-10 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
REGRESSION (WebKit2): VoiceOver focus no longer follows keyboard focus
https://bugs.webkit.org/show_bug.cgi?id=55959
NSApplication has to return the focused element within the app in order
for NSAccessibilityHandleFocusChanged() to work. The default implementation
relies on keyWindow. Consequently, in WK2, the WebProcess must override that method
to return the appropriate focused element within the WebProcess, since
there is no keyWindow.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
(-[AccessibilityWebPageObject accessibilityFocusedUIElement]):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::focusedWebPage):
* WebProcess/WebProcess.h:
* WebProcess/mac/NSApplicationOverride.mm: Added.
(-[NSApplication accessibilityFocusedUIElement]):
2011-03-10 Oleg Romashin <romaxa@gmail.com>
Reviewed by Andreas Kling.
Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1, part3
Solving conflict of Qt and Xlib includes
* Shared/Plugins/NPIdentifierData.cpp:
* Shared/Plugins/NPIdentifierData.h:
* Shared/Plugins/NPObjectProxy.cpp:
* Shared/Plugins/NPVariantData.h:
2011-03-10 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
- Fix plugins in release and production builds.
* WebKit2.xcodeproj/project.pbxproj:
Make sure to base the PluginProcess target on the correct xcconfig file
in all configurations.
2011-03-09 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Plumb through settings for accelerated drawing for canvas
https://bugs.webkit.org/show_bug.cgi?id=56039
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
2011-03-10 Jessie Berlin <jberlin@apple.com>
Reviewed by Oliver Hunt and Brian Weinstein.
WebKit2: Need a way to clear only the in-memory resource caches
https://bugs.webkit.org/show_bug.cgi?id=56022
Add a parameter to WKContextClearResourceCaches to specify whether to clear all the caches
or just the memory caches.
* Shared/ResourceCachesToClear.h: Added.
* UIProcess/API/C/WKAPICast.h:
(WebKit::toResourceCachesToClear):
* UIProcess/API/C/WKContext.cpp:
(WKContextClearResourceCaches):
Add the new parameter.
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::clearResourceCaches):
Ditto.
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::clearResourceCaches):
Pass the new parameter through to the platform-specific functions.
* WebProcess/WebProcess.h:
Add the new parameter and give it a default of AllResourceCaches.
* WebProcess/WebProcess.messages.in:
Ditto.
* WebProcess/gtk/WebProcessGtk.cpp:
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformClearResourceCaches):
When told to clear only the in-memory caches, return early so as not to clear the CFNetwork
disk cache.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
* WebKit2.xcodeproj/project.pbxproj:
Add ResourceCachesToClear.h
* win/WebKit2.vcproj:
Ditto.
2011-03-10 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
WKViewRegisterEditCommandCallback should use WKViewUndoType
https://bugs.webkit.org/show_bug.cgi?id=56120
* UIProcess/API/C/win/WKView.h: Change undoOrRedo parameter in WKViewRegisterEditCommandCallback to be WKViewUndoType.
2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Kenneth Rohde Christiansen.
Tiled backing store's delegated scroll request uses incorrect convention
https://bugs.webkit.org/show_bug.cgi?id=56011
Adapt all of the internal API to match the delta to point
conversion at the WebCore side.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::pageDidRequestScroll):
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::pageDidRequestScroll):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::delegatedScrollRequested):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::pageDidRequestScroll):
* WebProcess/WebPage/WebPage.h:
2011-03-10 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[WK2] Make non-transparent windowless plugins paint on X11
https://bugs.webkit.org/show_bug.cgi?id=55660
Implement painting for non-transparent windowless X11 plugins.
The essence of the logic has been adapted from WebCore.
The implementation is stubbed for GTK and working only on Qt
but it should be really easy to finish it for GTK.
* WebKit2.pro:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue): Handle X11 specific values that are necessary.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin): Initialize the X11 specific
members that has been added.
(WebKit::NetscapePlugin::callSetWindow): Always set the x and y coordinates
of the NP_Window to 0 on X11 since we are using a backings store as the
painting area for the plugin.
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp: Removed in favour
of a common implementation for X11.
* WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: Ditto.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Added.
(WebKit::getPluginDisplay):
Platform specific static getters.
(WebKit::x11Display):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::x11Screen):
(WebKit::NetscapePlugin::platformPostInitialize): Set up the visual
settings and the colormap for the plugin.
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformInvalidate): Remained stub.
(WebKit::NetscapePlugin::platformGeometryDidChange): Create a new
pixmap that fits the geometry.
(WebKit::NetscapePlugin::platformPaint): Propagate a paint event
to the plugin, sync with it if necessary and draw the pixmap to
the screen.
(WebKit::toNP): Remained stub.
(WebKit::NetscapePlugin::platformHandleMouseEvent): Remained stub.
(WebKit::NetscapePlugin::platformHandleWheelEvent): Remained stub.
(WebKit::NetscapePlugin::platformSetFocus): Remained stub.
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent): Remained stub.
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): Remained stub.
(WebKit::NetscapePlugin::platformHandleKeyboardEvent): Remained stub.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin): Hack. Inject wmode=opaque
key-value pair to the plugin parameters to force Flash to act in
non-transparent windowless mode. Qt also doing this in WebCore.
2011-03-09 Peter Kasting <pkasting@google.com>
Reviewed by Mihai Parparita.
Unify Windows version checks.
https://bugs.webkit.org/show_bug.cgi?id=55979
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::standardUserAgent):
2011-03-09 Adele Peterson <adele@apple.com>
Reviewed by Anders Carlsson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=56068
<rdar://problem/9058245> WebKit2: Can't uncheck 'Spelling and Grammar' contextual items
* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::contextMenuItemSelected):
Add cases for ContextMenuItemTagCorrectSpellingAutomatically, ContextMenuItemTagCheckSpellingWhileTyping,
and ContextMenuItemTagCheckGrammarWithSpelling
2011-03-09 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
Frequent crashes when printing in WebPageProxy::setAutodisplay
https://bugs.webkit.org/show_bug.cgi?id=56057
<rdar://problem/9053290>
* UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
Null check the page, there is no reason for it to still exist.
2011-03-09 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build correction.
* UIProcess/DrawingAreaProxy.messages.in: Exclude the other
method using LayerTreeContext for non-accelerated composition case.
2011-03-09 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Change plugins to use their own executable on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=55991
* Configurations/PluginProcess.xcconfig: Copied from Source/WebKit2/Configurations/WebProcess.xcconfig.
* PluginProcess/Info.plist: Copied from Source/WebKit2/WebProcess/Info.plist.
Add files necessary for adding PluginProcess.app.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
Launch the PluginProcess.app when launching a plugin process.
* WebKit2.xcodeproj/project.pbxproj:
Add new executable and new files, removes some unneeded copying
and duplicate compiling of files.
* WebProcess/Info.plist:
Sorted.
2011-03-09 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
Use the Cookie Storage from the Private Browsing Storage Session directly
https://bugs.webkit.org/show_bug.cgi?id=55986
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
2011-03-09 Alejandro G. Castro <alex@igalia.com>
Fix compilation after r80596, add soup Download stubs.
* GNUmakefile.am:
* WebProcess/Downloads/soup/DownloadSoup.cpp: Added.
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):
(WebKit::Download::didDecideDestination):
(WebKit::Download::platformDidFinish):
2011-03-09 Alejandro G. Castro <alex@igalia.com>
Fix GTK+ compilation after r80619. Add WebFullScreenManager.
* GNUmakefile.am:
2011-03-08 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: Plumb through the FULLSCREEN_API Chrome client calls
https://bugs.webkit.org/show_bug.cgi?id=55273
The FULLSCREEN_API Chrome client calls need to be plumbed through from the
WebProcess to the UIProcess. To do this, WebFullScreenManager (and Proxy)
classes have been added to WebPage.
* DerivedSources.make: Added rules necessary to build DerivedSources for new .in files.
* DerivedSources.pro: Ditto.
* Platform/CoreIPC/MessageID.h: Added message types for WebFullScreenManager.
* Shared/API/c/WKBase.h: Added WKFullScreenManagerRef.
* Shared/APIObject.h: Added APIType for WebFullScreenManager.
* UIProcess/WebFullScreenManagerProxy.cpp: Added.
* UIProcess/WebFullScreenManagerProxy.h: Added.
* UIProcess/WebFullScreenManagerProxy.messages.in: Added.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Invalidate and clear m_fullScreenManager.
(WebKit::WebPageProxy::processDidCrash): Ditto.
(WebKit::WebPageProxy::didReceiveMessage): Pass messages on to WebFullScreenManagerProxy.
(WebKit::WebPageProxy::didReceiveSyncMessage): Ditto.
(WebKit::WebPageProxy::fullScreenManager): Added. Lazy instantiation of m_fullScreenManager.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebUIClient.cpp:
* UIProcess/WebUIClient.h:
* WebKit2.xcodeproj/project.pbxproj: Added references to new classes in project file.
* WebKit2.pro: Ditto.
* win/WebKit2.vcproj: Ditto.
* WebKit2.pri: Added new directories to include file path.
* win/WebKit2Common.vsprops: Ditto.
* WebProcess/FullScreen/WebFullScreenManager.cpp: Added.
* WebProcess/FullScreen/WebFullScreenManager.h: Added.
* WebProcess/FullScreen/WebFullScreenManager.messages.in: Added.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::supportsFullScreenForElement): Pass through to WebFullScreenManager.
(WebKit::WebChromeClient::enterFullScreenForElement): Ditto.
(WebKit::WebChromeClient::exitFullScreenForElement): Ditto.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close): Invalidate and clear m_fullScreenManager.
(WebKit::WebPage::fullScreenManager): Lazy instantiation of m_fullScreenManager.
(WebKit::WebPage::didReceiveMessage): Pass messages through to WebFullScreenManager.
* WebProcess/WebPage/WebPage.h:
2011-03-08 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: Plumb through the "supportsFullScreen" preference.
https://bugs.webkit.org/show_bug.cgi?id=55261
The "supportsFullScreen" preference needs to be plumbed through from
the UIProcess to the WebProcess.
* Shared/WebPreferencesStore.h: Add a new macro entry.
* UIProcess/API/C/WKPreferences.cpp: Implement preferences getter and setter.
(WKPreferencesSetFullScreenEnabled):
(WKPreferencesGetFullScreenEnabled):
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Sync the fullScreenEnabled setting through to
the settings object.
2011-03-08 Jeff Miller <jeffm@apple.com>
Reviewed by Adele Peterson.
WebKit2: Implement Windows glue for Undo/Redo
https://bugs.webkit.org/show_bug.cgi?id=55961
Expose Undo/Redo infrastructure through WKView on Windows by
adding an undo client as well as APIs to reapply and unapply
an edit command.
* UIProcess/API/C/win/WKView.cpp:
(WKViewSetViewUndoClient): Added.
(WKViewReapplyEditCommand): Added.
(WKViewUnapplyEditCommand): Added.
* UIProcess/API/C/win/WKView.h: Added WKViewUndoClient, WKViewSetViewUndoClient(), and WKViewUnapplyEditCommand().
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::isValidEditCommand): Added, used to validated an edit command from a WKView API.
* UIProcess/WebPageProxy.h: Added isValidEditCommand().
* UIProcess/win/WebUndoClient.cpp: Added, APIClient for WKViewUndoClient.
(WebKit::WebUndoClient::registerEditCommand): Added.
(WebKit::WebUndoClient::clearAllEditCommands): Added.
* UIProcess/win/WebUndoClient.h: Added, APIClient for WKViewUndoClient.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::initializeUndoClient): Added.
(WebKit::WebView::close): Clear out undo client.
(WebKit::WebView::registerEditCommand): Implemented to call through to WKViewUndoClient.
(WebKit::WebView::clearAllEditCommands): Implmented to call through to WKViewUndoClient.
(WebKit::WebView::reapplyEditCommand): Added.
(WebKit::WebView::unapplyEditCommand): Added.
* UIProcess/win/WebView.h: Added undo client support.
* win/WebKit2.vcproj: Added WebUndoClient.cpp and WebUndoClient.h.
2011-03-08 Jeff Miller <jeffm@apple.com>
Reviewed by Sam Weinig.
WebKit2: Expose WebEditCommandProxy in the C API on Windows
https://bugs.webkit.org/show_bug.cgi?id=55962
Make WebEditCommandProxy a subclass of APIObject, and define
WKEditCommandRef as the type that will be exposed through the C API.
* Shared/API/c/win/WKBaseWin.h: Add WKEditCommandRef.
* Shared/APIObject.h: Add platform-specific TypeEditCommandProxy.
* UIProcess/API/C/win/WKAPICastWin.h: Add API mapping for WKEditCommandRef.
* UIProcess/WebEditCommandProxy.h: Subclass WebEditCommandProxy from APIObject.
(WebKit::WebEditCommandProxy::type): Added.
2011-03-08 Jeff Miller <jeffm@apple.com>
Reviewed by Oliver Hunt.
WebKit2: Redo is broken
https://bugs.webkit.org/show_bug.cgi?id=55978
WebEditCommandProxy::unapply() and WebEditCommandProxy::reapply() were registering the wrong edit command when an undo or redo happens.
For example, when we unapply(), we should register a Redo command, not an Undo command.
* UIProcess/WebEditCommandProxy.cpp:
(WebKit::WebEditCommandProxy::unapply): Register a Redo command, not an Undo command.
(WebKit::WebEditCommandProxy::reapply): Register an Undo command, not a Redo command.
2011-03-08 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=55977
Refine CF/CFNet distinctions for better code sharing.
1. Rename Downloads/cf/win/DownloadCFNetWin.cpp to DownloadCFWin.cpp
since it does not use any CFNETWORK features.
2. Create new cfnet directory.
3. Move Downloads/cf/DownloadCFNet.cpp to Downloads/cfnet
4. Update project file.
* WebProcess/Downloads/cf/DownloadCFNet.cpp: Removed.
* WebProcess/Downloads/cf/win/DownloadCFNetWin.cpp: Removed.
* WebProcess/Downloads/cf/win/DownloadCFWin.cpp: Copied from WebProcess/Downloads/cf/win/DownloadCFNetWin.cpp.
* WebProcess/Downloads/cfnet: Added.
* WebProcess/Downloads/cfnet/DownloadCFNet.cpp: Copied from WebProcess/Downloads/cf/DownloadCFNet.cpp.
* win/WebKit2.vcproj:
2011-03-08 Mark Rowe <mrowe@apple.com>
Reviewed by Brady Eidson.
<http://webkit.org/b/55976> Provisional URL should be loaded when restoring session state even if there are back / forward list entries.
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData): If there's a provisional URL that we will load then restore the session state
without navigating to the current item.
* WebProcess/WebPage/WebPage.messages.in: Expose the ability to restore the session state without navigating to the current item.
2011-03-08 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=55956
WebKit2 Changes to correct WinCairo port build
* Shared/LayerTreeContext.h: Don't exclude CoreIPC declarations for non-accelerated
compositing case.
* UIProcess/DrawingAreaProxy.h: Add "stdint.h" include needed for Cairo build.
* UIProcess/DrawingAreaProxyImpl.cpp: Exclude accelerated compositing code for
WinCairo build.
(WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidUpdateBackingStoreState):
* UIProcess/DrawingAreaProxyImpl.h: Exclude declarations for code only used when
accelerated compositing is enabled.
(WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode):
* UIProcess/win/WebView.cpp: Protect CG-specific drawing code.
(WebKit::WebView::setFindIndicator):
* WebProcess/Downloads/Download.h: Allow CFLite implentation to share overwrite flag,
as well as destination and bundle paths.
* WebProcess/Downloads/curl/DownloadCurl.cpp: Remove stub (to share CFNet implementation
of file handling. This will be moved to a common area in a future patch.)
* WebProcess/WebPage/DrawingAreaImpl.cpp: Exclude accelerated-compositing paths.
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
* WebProcess/WebPage/WebPage.cpp: Protect CG-specific drawing code.
(WebKit::WebPage::drawRectToPDF):
(WebKit::WebPage::drawPagesToPDF):
* win/WebKit2.vcproj: Exclude unused LayerTreeContext from WinCairo
2011-03-08 Ivan Krstić <ike@apple.com>
Reviewed by Sam Weinig.
Re-fix: can't paste from 3rd party text editor into WebKit2 window
<rdar://problem/8978624>
* WebProcess/com.apple.WebProcess.sb:
2011-03-08 Martin Robinson <mrobinson@igalia.com>
Fix the WebKit2 compilation after r80578.
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::setFocus): Added.
* UIProcess/gtk/WebView.h:
2011-03-08 Jessie Berlin <jberlin@apple.com>
Reviewed by Anders Carlsson.
Crash in CFNetwork visiting google.com
https://bugs.webkit.org/show_bug.cgi?id=55958
* Shared/API/c/cf/WKURLResponseCF.cpp:
(WKURLResponseCopyCFURLResponse):
If the response to copy is null, return 0;
2011-03-08 John Sullivan <sullivan@apple.com>
Reverted the patch for https://bugs.webkit.org/show_bug.cgi?id=55940
The patch was insufficient, and it wasn't useful for the intended client use either.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2011-03-08 Alejandro G. Castro <alex@igalia.com>
Unreviewed, fixed GTK+ compilation after r80569.
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::windowToScreen):
* UIProcess/gtk/WebView.h:
2011-03-08 Chris Fleizach <cfleizach@apple.com>
Reviewed by Sam Weinig.
WK2: Cannot set focus on an element when focus is outside of WKView
https://bugs.webkit.org/show_bug.cgi?id=55281
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setFocus):
* UIProcess/API/qt/qwkpage_p.h:
(QWKPagePrivate::setFocus):
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFocus):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/win/WebView.h:
(WebKit::WebView::setFocus):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focus):
(WebKit::WebChromeClient::unfocus):
2011-03-08 Jeff Miller <jeffm@apple.com>
Unreviewed, fix last change so WKBaseWin.h is in alphabetical order in the project XML.
* win/WebKit2.vcproj: Move WKBaseWin.h to be in alphabetical order.
2011-03-08 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Remove Source/WebKit2/UIProcess/API/C/win/WKBaseWin.h
https://bugs.webkit.org/show_bug.cgi?id=55952
* UIProcess/API/C/win/WKBaseWin.h: Removed.
* win/WebKit2.vcproj: Refer to the Shared version of WKBaseWin.h instead of the one in UIProcess.
2011-03-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add new files to compilation after r77974
https://bugs.webkit.org/show_bug.cgi?id=54076
The commit added new code to allow passing context to policy
delegate methods, we also added dummy ResourceRequest and
ResourceResponse decoders until we implement them.
* GNUmakefile.am:
* Shared/gtk/WebCoreArgumentCodersGtk.cpp:
(CoreIPC::decodeResourceRequest):
(CoreIPC::decodeResourceResponse):
2011-03-08 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: Webkit2 not sending UAZoomFocusChanged notifications
https://bugs.webkit.org/show_bug.cgi?id=55916
Needed to implement the windowToScreen() method so that the right frame
could be calculated to send for zoom focus changes.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::windowToScreen):
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::windowToScreen):
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::windowToScreen):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::windowToScreen):
* UIProcess/win/WebView.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowToScreen):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowToScreen):
* WebProcess/WebPage/WebPage.h:
2011-03-08 John Sullivan <sullivan@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=55940
WebKit2 should support Ignore policy from injected bundle client
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Added WKBundlePagePolicyActionIgnore.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
If the injected bundle client returns WKBundlePagePolicyActionIgnore, convert it
to the loader's PolicyIgnore.
2011-03-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [Symbian] [WK2] Fix building WebKit 2 API tests
https://bugs.webkit.org/show_bug.cgi?id=55876
Make sure TESTS_SOURCE_DIR is set for Symbian the same way
as it is for WK1.
* UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp:
(tst_QGraphicsWKView::loadEmptyPage):
* UIProcess/API/qt/tests/tests.pri:
2011-03-07 Damian Kaleta <dkaleta@apple.com>
Reviewed by Anders Carlsson.
QuickTime plugin should opt in to a 32-bit non-executable heap
https://bugs.webkit.org/show_bug.cgi?id=55704
<rdar://problem/8105706>
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::pluginNeedsExecutableHeap): Decides per plugin if it should opt-in to a 32-bit non-executable heap.
By default it should opt-out.
(WebKit::PluginProcessProxy::PluginProcessProxy):
2011-03-07 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add unableToImplementPolicy callback for WebKit2 policy client
<rdar://problem/9071902>
https://bugs.webkit.org/show_bug.cgi?id=55884
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unableToImplementPolicy):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::unableToImplementPolicy):
* UIProcess/WebPolicyClient.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:
(WebKit::InjectedBundlePagePolicyClient::unableToImplementPolicy):
* WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchUnableToImplementPolicy):
Pipe unableToImplementPolicy through both the bundle and the main WebKit2 API.
2011-03-07 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
https://bugs.webkit.org/show_bug.cgi?id=55827
- Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.
- Updated both UIProcess API and bundle API to also be based on the whole response, not just the
MIMEType.
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForResponse):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForResponse):
* UIProcess/WebPolicyClient.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForResponse):
* WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
2011-03-06 Jessie Berlin <jberlin@apple.com>
Reviewed by Sam Weinig.
WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.
When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Add support for using the new WKSI functions in WebCore.
2011-03-06 Oleg Romashin <romaxa@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1, part1
Adding dummy Qt files for Plugin Process implementation,
Adding missing sources into Qt pro files
https://bugs.webkit.org/show_bug.cgi?id=55719
* DerivedSources.pro:
* PluginProcess/qt: Added.
* PluginProcess/qt/PluginControllerProxyQt.cpp: Added.
(WebKit::PluginControllerProxy::platformInitialize):
(WebKit::PluginControllerProxy::platformDestroy):
(WebKit::PluginControllerProxy::platformGeometryDidChange):
* PluginProcess/qt/PluginProcessMainQt.cpp: Added.
(WebKit::PluginProcessMain):
* PluginProcess/qt/PluginProcessQt.cpp: Added.
(WebKit::PluginProcess::platformInitialize):
* UIProcess/Plugins/qt/PluginProcessProxyQt.cpp: Added.
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
* WebKit2.pri:
* WebKit2.pro:
* WebKit2API.pri:
* WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp: Added.
(WebKit::PluginProxy::needsBackingStore):
2011-03-05 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Remove unneeded onPageClose function from DrawingArea
https://bugs.webkit.org/show_bug.cgi?id=55836
* WebProcess/WebPage/DrawingArea.h:
Remove empty function.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
Remove only called
2011-03-04 Jon Honeycutt <jhoneycutt@apple.com>
WK2 Mac build fix.
* UIProcess/API/C/WKPage.cpp:
(WKPageComputePagesForPrinting):
(WKPageBeginPrinting):
* UIProcess/API/C/WKPagePrivate.h:
2011-03-04 Jon Honeycutt <jhoneycutt@apple.com>
WK2 Mac build fix.
* UIProcess/API/C/WKPagePrivate.h:
2011-03-04 Jon Honeycutt <jhoneycutt@apple.com>
WK2 needs printing support on Windows
https://bugs.webkit.org/show_bug.cgi?id=55800
<rdar://problem/8903808>
Reviewed by Darin Adler.
* UIProcess/API/C/WKPage.cpp:
(ComputedPagesContext::ComputedPagesContext):
(computedPagesCallback):
From the Vector of WebCore::IntRects, build up a Vector of WKRects.
Call the callback, passing these rects and the scale factor.
(printInfoFromWKPrintInfo):
Return a PrintInfo structure from the WKPrintInfo.
(WKPageComputePagesForPrinting):
Call WebPageProxy::computePagesForPrinting(). Pass
computedPagesCallback as the callback function, so that we can
translate the WebCore rect type to WKRect before calling the caller's
callback function.
(WKPageBeginPrinting):
Call WebPageProxy::beginPrinting().
(WKPageDrawPagesToPDF):
Call WebPageProxy::drawPagesToPDF().
* UIProcess/API/C/WKPagePrivate.h:
Declare the WKPrintInfo type and new functions.
* UIProcess/WebPageProxy.cpp:
Compile this code on Windows.
* UIProcess/WebPageProxy.h:
Ditto.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::paint):
We're painting the window; leave printing mode.
* WebProcess/WebPage/WebPage.cpp:
Compile this code on Windows.
* WebProcess/WebPage/WebPage.h:
Ditto.
* WebProcess/WebPage/WebPage.messages.in:
Ditto.
2011-03-04 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784
<rdar://problem/9021320>
We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.
Fetch the WebKit version from a string resource instead of the version resource.
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::userVisibleWebKitVersionString): Fetch version from a string resource.
* win/WebKit2.rc: Removed version, added stringtable.
* win/WebKit2WebProcess.rc: Removed.
* win/WebKit2WebProcess.vcproj:
* win/WebKit2WebProcessPostBuild.cmd: Don't run autoversion script. It isn't used in this project.
* win/WebKit2WebProcessPreBuild.cmd: Stamp version.
* win/WebKitPostBuild.cmd: Stamp version.
2011-03-04 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Add WKPageValidateCommand()
https://bugs.webkit.org/show_bug.cgi?id=55793
On the Mac, validation of edit menu commands is handled within WebKit2 in WKView.mm.
However, on Windows we need to do this in the client, so expose this functionality
in the API via WKPageValidateCommand().
Change the Mac implementation to call WebPageProxy::validateCommand() with a callback
to match this new API, so it no longer has to go through PageClient to get notified
when a command is validated. This makes PageClient::setEditCommandState() obsolete,
so I removed the stub implementations in qt and gtk as well.
* UIProcess/API/C/WKPage.cpp:
(WKPageValidateCommand): Added.
* UIProcess/API/C/WKPage.h: Added WKPageValidateCommand().
* UIProcess/API/mac/PageClientImpl.h: Removed setEditCommandState().
* UIProcess/API/mac/PageClientImpl.mm: Removed setEditCommandState().
* UIProcess/API/mac/WKView.mm:
(validateCommandCallback): Added.
(-[WKView validateUserInterfaceItem:]): Pass callback to validateCommand().
* UIProcess/API/qt/qwkpage.cpp: Removed setEditCommandState().
* UIProcess/API/qt/qwkpage_p.h: Removed setEditCommandState().
* UIProcess/PageClient.h: Removed setEditCommandState().
* UIProcess/WebPageProxy.cpp: Removed didValidateCommand().
(WebKit::WebPageProxy::validateCommand): This now takes a callback.
(WebKit::WebPageProxy::validateCommandCallback): Added.
(WebKit::WebPageProxy::processDidCrash): Invalidate m_validateCommandCallbacks.
* UIProcess/WebPageProxy.h: Removed didValidateCommand(), validateCommand() now takes a callback.
(WebKit::ValidateCommandCallback::create): Added.
(WebKit::ValidateCommandCallback::~ValidateCommandCallback): Added.
(WebKit::ValidateCommandCallback::performCallbackWithReturnValue): Added.
(WebKit::ValidateCommandCallback::invalidate): Added.
(WebKit::ValidateCommandCallback::ValidateCommandCallback): Added.
* UIProcess/WebPageProxy.messages.in: Removed DidValidateCommand, added ValidateCommandCallback.
* UIProcess/gtk/WebView.cpp: Removed setEditCommandState().
* UIProcess/gtk/WebView.h: Removed setEditCommandState().
* UIProcess/win/WebView.cpp: Removed setEditCommandState().
* UIProcess/win/WebView.h: Removed setEditCommandState().
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::validateCommand): This now takes a callbackID.
* WebProcess/WebPage/WebPage.h: validateCommand now takes a callbackID.
* WebProcess/WebPage/WebPage.messages.in: ValidateCommand now takes a callbackID.
2011-03-04 Brian Weinstein <bweinstein@apple.com>
Reviewed by Darin Adler.
Reference-counting for WKBundlePageResourceLoadClient::willSendRequestForFrame seems unclear/wrong
https://bugs.webkit.org/show_bug.cgi?id=53919
<rdar://problem/8966020>
Adopt the result of m_client.willSendRequestForFrame (which will be leaked by the client).
* WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:
(WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame):
2011-03-04 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
WebKit2 session state should include even loads too new to be in the back/forward list
https://bugs.webkit.org/show_bug.cgi?id=55781
part of <rdar://problem/8968847>
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::sessionStateData): Save URLs that are early enough in the loading
process to not be included in the back/forward list yet: The pending API request URL and
the provisional URL.
(WebKit::WebPageProxy::restoreFromSessionStateData): Call loadURL if the back/forward
list is not restored and a URL is present. Later we can improve the way we handle the
case where we have both a back/forward list and a URL.
2011-03-04 Jessie Berlin <jberlin@apple.com>
Reviewed by Darin Adler.
WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.
Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out because the code was
contained within guards that made USE(CFURLSTORAGESESSIONS) always be true.
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
2011-03-04 Jessie Berlin <jberlin@apple.com>
Reviewed by Maciej Stachowiak.
WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.
When Private Browsing is enabled, get the cached url response from the cache associated with
the Private Browsing Storage Session.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformHasLocalDataForURL):
If Private Browsing is enabled, call into WKSI to get the response.
(WebKit::WebPage::cachedResponseMIMETypeForURL):
Ditto.
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::platformHasLocalDataForURL):
If Private Browsing is enabled, call into WKSI to get the CFURLCacheRef.
(WebKit::WebPage::cachedResponseMIMETypeForURL):
Ditto.
2011-03-04 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Move WKViewExecuteCommand() to WKPageExecuteCommand()
https://bugs.webkit.org/show_bug.cgi?id=55744
Executing a command operates on a page, so it makes more sense for it to be in WKPage.
This also makes it available on all platforms, not just Windows.
* UIProcess/API/C/WKPage.cpp:
(WKPageExecuteCommand): Added.
* UIProcess/API/C/WKPage.h: Add WKPageExecuteCommand().
* UIProcess/API/C/win/WKView.cpp: Remove WKViewExecuteCommand().
* UIProcess/API/C/win/WKView.h: Remove WKViewExecuteCommand().
2011-03-04 Dan Bernstein <mitz@apple.com>
LLVM Compiler build fix.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):
2011-03-03 Timothy Hatcher <timothy@apple.com>
Make the WKPageRunJavaScriptFunction callback take a WKSerializedScriptValueRef.
https://webkit.org/b/55623
Reviewed by Darin Adler.
* UIProcess/API/C/WKPage.cpp:
(WKPageRunJavaScriptInMainFrame): Use ScriptValueCallback.
(callRunJavaScriptBlockAndRelease): Use WKSerializedScriptValueRef.
* UIProcess/API/C/WKPage.h: Use WKSerializedScriptValueRef.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Call invalidateCallbackMap for m_scriptValueCallbacks.
(WebKit::WebPageProxy::runJavaScriptInMainFrame): Take a ScriptValueCallback.
(WebKit::WebPageProxy::scriptValueCallback): Added. Create a WebSerializedScriptValue
from the DataReference before calling the callback.
(WebKit::WebPageProxy::processDidCrash): Call invalidateCallbackMap for m_scriptValueCallbacks.
* UIProcess/WebPageProxy.h: Added ScriptValueCallback and m_scriptValueCallbacks.
* UIProcess/WebPageProxy.messages.in: Added ScriptValueCallback.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame): Create a DataReference from a WebCore::SerializedScriptValue.
And use ScriptValueCallback to send the message back.
2011-03-03 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Cleanup from https://bugs.webkit.org/show_bug.cgi?id=55427.
Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
on all platforms, and stub the functions on platforms that don't implement them.
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::stopObservingCookieChanges):
2011-03-03 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Refactor classes in GenericCallback.h
https://bugs.webkit.org/show_bug.cgi?id=55732
Since we're going to need to add additional callback classes, make a CallbackBase class that manages
the context and the callback ID. The existing callback classes (VoidCallback, GenericCallback, and
ComputedPagesCallback) now all derive from CallbackBase.
Fix bug in VoidCallback where we meant to implement the destructor, but we were implementing the default
constructor instead (we forgot the leading ~).
* UIProcess/GenericCallback.h:
(WebKit::CallbackBase::~CallbackBase):
(WebKit::CallbackBase::callbackID):
(WebKit::CallbackBase::CallbackBase):
(WebKit::CallbackBase::context):
(WebKit::CallbackBase::generateCallbackID):
(WebKit::VoidCallback::~VoidCallback):
(WebKit::VoidCallback::performCallback):
(WebKit::VoidCallback::invalidate):
(WebKit::VoidCallback::VoidCallback):
(WebKit::GenericCallback::create):
(WebKit::GenericCallback::~GenericCallback):
(WebKit::GenericCallback::performCallbackWithReturnValue):
(WebKit::GenericCallback::invalidate):
(WebKit::GenericCallback::GenericCallback):
(WebKit::ComputedPagesCallback::create):
(WebKit::ComputedPagesCallback::~ComputedPagesCallback):
(WebKit::ComputedPagesCallback::performCallbackWithReturnValue):
(WebKit::ComputedPagesCallback::invalidate):
(WebKit::ComputedPagesCallback::ComputedPagesCallback):
2011-03-03 Adam Roben <aroben@apple.com>
Don't assume the web process has had a chance to paint before the view has to paint
Fixes <http://webkit.org/b/55739> REGRESSION (r80307): Lots of tests crashing in
BackingStore::paint
Reviewed by Anders Carlsson.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::paint): Bail if the web process hasn't had a chance to paint
yet.
2011-03-03 Adam Roben <aroben@apple.com>
Throw away DrawingAreaProxyImpl's backing store after not painting for 5 seconds
The intent is to save memory for views that aren't painting.
Fixes <http://webkit.org/b/51262> <rdar://problem/8782537> WebPageProxy should delete its
backing store after not painting for a while
Reviewed by Anders Carlsson.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize our timer.
(WebKit::DrawingAreaProxyImpl::paint): Don't bail if we don't have a backing store (but do
bail if we're in accelerated compositing mode); we might have thrown it away to save memory
but now are being asked to paint by the view. The existing code in this function will handle
getting a new backing store if possible by blocking for a little while to try to receive a
DidUpdateBackingStoreState message. Added an assertion that we do have a backing store if we
don't have any outstanding UpdateBackingStoreState requests. After painting, call
discardBackingStoreSoon to update our timer.
(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon): Set the timer for 5 seconds in the
future.
(WebKit::DrawingAreaProxyImpl::discardBackingStore): Throw away the backing store, and tell
the web process we'll need a full backing store update on the next paint.
* UIProcess/DrawingAreaProxyImpl.h: Added m_discardBackingStoreTimer.
2011-03-03 Adam Roben <aroben@apple.com>
Add a way to tell the web process to perform a full backing store update on its next paint
Messages::DrawingArea::UpdateBackingStoreState now takes a boolean specifying whether the
full backing store update should happen immediately or should be deferred until the next
paint or compositing mode change occurs. The deferred update isn't used yet, but will be
used when we start throwing away backing stores to save memory.
Fixes <http://webkit.org/b/55730> UI process needs a way to tell the web process its backing
store needs a full update on the next paint
Reviewed by Anders Carlsson.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::paint): If we have an outstanding backing store state change
request, tell the web process to perform the backing store update right away, in case we
previously told it it could defer the update.
(WebKit::DrawingAreaProxyImpl::sizeDidChange): Specify that we need an immediate backing
store update.
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): We can no longer assert that we
were waiting for a DidUpdateBackingStoreState message when we receive one, as it's possible
for the web process to decide to send us this message on its own (if we asked it to do a
deferred backing store update and then it needed to paint some part of the page). Specify
that we need an immediate backing store update if the web process hasn't updated to our
latest state, as we're about to draw potentially out-of-date bits to the screen and want to
get the right bits as soon as possible. Also added a FIXME about a potential optimization.
(WebKit::DrawingAreaProxyImpl::backingStoreStateDidChange): Added a RespondImmediatelyOrNot
parameter, which is just passed through to sendUpdateBackingStoreState.
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState): Added a RespondImmediatelyOrNot
parameter that is used to specify to the web process whether to perform the full backing
store update immediately. We now only wait for a DidUpdateBackingStoreState message (and
thus suppress any more UpdateBackingStoreState messages until one is received) when we ask
the web process for an immediate response; otherwise we could end up accidentally calling
waitForAndDispatchDidUpdateBackingStoreState when the web process hasn't been told to send
us such a message.
* UIProcess/DrawingAreaProxyImpl.h: Added RespondImmediatelyOrNot.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::updateBackingStoreState): Added respondImmediately argument.
* WebProcess/WebPage/DrawingArea.messages.in: Added respondImmediately argument to
UpdateBackingStoreState message.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize new member that's used to track
whether we should send a DidUpdateBackingStoreState message instead of an Update or
compositing mode change message. This will be set to true when a deferred backing store
update is pending.
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers): If a deferred update is pending, send a
DidUpdateBackingStoreState message instead of a compositing mode change message.
(WebKit::DrawingAreaImpl::updateBackingStoreState): Added respondImmediately argument. If
we've already been told about this state ID (as can happen when the UI process decides it
needs an immediate update to a state that it previously requested a deferred update to),
don't bother updating the page's size, etc. In addition, if we've already sent a
DidUpdateBackingStoreState message for this state, we don't have to do anything at all.
Moved code to send the DidUpdateBackingStoreState message from here...
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): ...to here.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Always update our dirty region,
even if painting is suspended or we're in the process of updating the backing store state.
It causes no harm and simplifies the code. If a deferred update is pending, send a
DidUpdateBackingStoreState message instead of a compositing mode change message. Also
removed a redundant if.
(WebKit::DrawingAreaImpl::display): Added an assertion that this isn't called while updating
backing store state, as otherwise we might end up sending two DidUpdateBackingStoreState
messages. If a deferred update is pending, send a DidUpdateBackingStoreState message instead
of an Update message.
* WebProcess/WebPage/DrawingAreaImpl.h: Updated updateBackingStoreState to match the base
class. Added sendDidUpdateBackingStoreState and m_shouldSendDidUpdateBackingStoreState.
2011-03-03 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
When displaying the missing plug-in sheet, pass the 'pluginspage'
attribute to the UI process.
https://bugs.webkit.org/show_bug.cgi?id=55553
* UIProcess/API/C/WKPage.h: Add pluginsPageURL as the third argument to
missingPluginButtonClicked.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::missingPluginButtonClicked): Ditto.
* UIProcess/WebPageProxy.h: Ditto.
* UIProcess/WebPageProxy.messages.in: Ditto.
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::missingPluginButtonClicked): Ditto.
* UIProcess/WebUIClient.h: Ditto.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::missingPluginButtonClicked): Get the value of
pluginspageAttr.
2011-03-03 Alexey Proskuryakov <ap@apple.com>
Suggested by Dan Bernstein.
Move "const" around "NSString *", so that it suddenly begins to make sense.
* WebProcess/mac/FullKeyboardAccessWatcher.mm:
2011-03-03 Jeff Miller <jeffm@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Add WKViewRef API for executing edit commands
https://bugs.webkit.org/show_bug.cgi?id=49829
Added WKViewExecuteCommand() and documented some of the WebCore EditorCommand strings.
* UIProcess/API/C/win/WKView.cpp:
(WKViewExecuteCommand): Added.
* UIProcess/API/C/win/WKView.h: Added WKViewExecuteCommand() and comment block with WebCore EditorCommand strings.
2011-03-03 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435
Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Support using WKCopyRequestWithStorageSession in WebCore.
2011-03-03 Adam Roben <aroben@apple.com>
Don't try to paint outside the page's bounds
When the page is resized smaller, we would allocate a ShareableBitmap at the old, larger
size, even though we only needed to paint at the new, smaller size.
The assertion added in this patch will fire during the WebKit2/ResizeViewWhileHidden API
test if this fix gets broken in the future.
Fixes <http://webkit.org/b/55715> DrawingAreaImpl allocates more memory than necessary when
the page is resized smaller
Reviewed by Anders Carlsson.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updateBackingStoreState): Update our dirty region even if painting
is suspended (but still refrain from updating it when in accelerated compositing mode).
Rather than unite our existing dirty region with the page's new bounds, overwrite our dirty
region with the page's new bounds. This prevents us from accumulating a dirty region that is
larger than the page in the case where the page is being resized smaller.
(WebKit::DrawingAreaImpl::display): Added an assertion that we're not trying to paint
outside of the page's bounds.
2011-03-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Brady Eidson.
WebProcess is calling CFURLCacheRemoveAllCachedResponses when loading, results in origin-load for all resources
https://bugs.webkit.org/show_bug.cgi?id=55701
<rdar://problem/9074017>
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Initialize cache-clearing
flag parameters to false.
(WebKit::WebProcessCreationParameters::encode): Serialize them properly.
(WebKit::WebProcessCreationParameters::decode): And deserialize.
2011-03-03 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
https://bugs.webkit.org/show_bug.cgi?id=55633
<rdar://problem/8963023>
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/mac/FullKeyboardAccessWatcher.h: Added.
* WebProcess/mac/FullKeyboardAccessWatcher.mm: Added.
(-[FullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]):
(-[FullKeyboardAccessWatcher init]):
(+[FullKeyboardAccessWatcher fullKeyboardAccessEnabled]):
Get the current state of full keyboard access, listening for change notifications.
* WebProcess/WebProcess.h: Added fullKeyboardAccessEnabled().
* WebProcess/WebProcess.cpp: (WebKit::WebProcess::fullKeyboardAccessEnabled):
WebKit1 also doesn't implement this on platforms other than Mac.
* WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::fullKeyboardAccessEnabled):
Just ask FullKeyboardAccessWatcher.
* WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::keyboardUIMode):
* WebProcess/WebCoreSupport/WebChromeClient.h:
Added keyboardUIMode(), removed tabsToLinks().
* WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::keyboardUIMode):
* WebProcess/WebPage/WebPage.h:
Generate keyboard UI mode from tabToLinks preference and current state of FKA.
2011-03-03 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Give the Bundle's policy client the option of deciding the policy
https://bugs.webkit.org/show_bug.cgi?id=55699
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Add WKBundlePagePolicyAction enum and make it the return value of
the WKBundlePagePolicyClient functions.
* WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForMIMEType):
* WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
Pass the return value back to the caller. For unimplemented functions, return WKBundlePagePolicyActionPassThrough.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
Call the policy function early if the bundle handles it.
2011-03-02 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Rest of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>
This patch adds the communication from the WebProcess <-> UIProcess about starting/stopping
listening for cookies changing, and adds a mechanism for the WebProcess to notify the UIProcess
when the cookies have changed. The WebProcess sends a message to the UIProcess when the cookies
change, and the UIProcess passes this along to the WebCookieManagerProxyClient.
* UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerSetClient): Call through to WebCookieManagerProxy.
(WKCookieManagerStartObservingCookieChanges): Ditto.
(WKCookieManagerStopObservingCookieChanges): Ditto.
* UIProcess/API/C/WKCookieManager.h: Add new functions and a WKCookieManagerClient
which is responsible for cookiesDidChange.
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::initializeClient):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges): Send the message down to the web process.
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges): Ditto.
(WebKit::WebCookieManagerProxy::cookiesDidChange): Tell the WKCookieManagerClient the cookies were
modified.
* UIProcess/WebCookieManagerProxy.h:
* UIProcess/WebCookieManagerProxy.messages.in: Add new messages.
* UIProcess/WebCookieManagerProxyClient.cpp: Added.
(WebKit::WebCookieManagerProxyClient::cookiesDidChange): Calls through to the client saying that
cookies changed.
* UIProcess/WebCookieManagerProxyClient.h: Added.
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::startObservingCookieChanges): Call through to WebCore::startObservingCookieChanges
(on platforms that support it).
(WebKit::WebCookieManager::stopObservingCookieChanges): Ditto (for stopObservingCookieChanges).
(WebKit::WebCookieManager::dispatchDidModifyCookies): Send a message to the UI process that cookies changed.
* WebProcess/Cookies/WebCookieManager.h:
* WebProcess/Cookies/WebCookieManager.messages.in:
Add new files.
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* GNUmakefile.am:
* win/WebKit2.vcproj:
2011-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Remove CanRunBeforeUnloadConfirmPanel sync message
https://bugs.webkit.org/show_bug.cgi?id=55689
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Encode and decode canRunBeforeUnloadConfirmPanel, as well as canRunModal, which wasn't
being encoded/decoded.
* Shared/WebPageCreationParameters.h:
Add canRunBeforeUnloadConfirmPanel.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeUIClient):
Send SetCanRunBeforeUnloadConfirmPanel and SetCanRunModal messages.
(WebKit::WebPageProxy::creationParameters):
Initialize parameters.canRunBeforeUnloadConfirmPanel.
* UIProcess/WebPageProxy.messages.in:
Remove CanRunBeforeUnloadConfirmPanel message.
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::canRunBeforeUnloadConfirmPanel):
* UIProcess/WebUIClient.h:
Make canRunBeforeUnloadConfirmPanel const.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::canRunBeforeUnloadConfirmPanel):
Ask the web page instead of sending a synchronous message.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Initialize m_canRunBeforeUnloadConfirmPanel.
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::canRunBeforeUnloadConfirmPanel):
(WebKit::WebPage::setCanRunBeforeUnloadConfirmPanel):
Add getter and setter for m_canRunBeforeUnloadConfirmPanel.
(WebKit::WebPage::setCanRunModal):
Add setter for m_canRunModal.
* WebProcess/WebPage/WebPage.messages.in:
Add SetCanRunBeforeUnloadConfirmPanel and SetCanRunModal messages.
2011-03-03 Adam Roben <aroben@apple.com>
Create the CFBundleRef for WebKit.dll on Windows if needed
WebKit part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
out or crash on Windows 7 Release (WebKit2 Tests)
Reviewed by Darin Adler.
* Shared/win/WebKitBundle.cpp: Added.
(WebKit::createWebKitBundle): Returns a pre-existing bundle, if possible, otherwise creates
and returns a new bundle.
(WebKit::webKitBundle): Creates and caches a bundle, and returns it.
* Shared/win/WebKitBundle.h: Added.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::inspectorPageURL):
* WebProcess/WebPage/win/WebInspectorWin.cpp:
(WebKit::WebInspector::localizedStringsURL):
Changed to use webKitBundle() to ensure that the bundle has been created.
* win/WebKit2.vcproj: Added new files.
2011-03-03 Peter Kasting <pkasting@google.com>
Reviewed by James Robinson.
Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::standardUserAgent):
2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80188.
http://trac.webkit.org/changeset/80188
https://bugs.webkit.org/show_bug.cgi?id=55647
Broke the WebKit API tests. (Requested by xenon on #webkit).
* UIProcess/API/C/WKPage.cpp:
(WKPageRunJavaScriptInMainFrame):
(callRunJavaScriptBlockAndRelease):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::processDidCrash):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):
2011-03-02 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Rename WebKit::WebPage::validateMenuItem() to validateCommand()
https://bugs.webkit.org/show_bug.cgi?id=55636
Since this method can validate more than menu items, validateCommand() is a better name. Also rename various messages and WebKit::WebPageProxy::didValidateMenuItem() to didValidateCommand().
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]): Call validateCommand() instead of validateMenuItem().
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::validateCommand): Renamed from validateMenuItem().
(WebKit::WebPageProxy::didValidateCommand): Renamed from didValidateMenuItem().
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: Renamed DidValidateMenuItem to DidValidateCommand.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::validateCommand): Renamed from validateMenuItem().
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Renamed ValidateMenuItem to ValidateCommand.
2011-03-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
WKPageSetMemoryCacheClientCallsEnabled doesn't persist if web process crashes
https://bugs.webkit.org/show_bug.cgi?id=55635
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Encode and decode areMemoryCacheClientCallsEnabled.
* Shared/WebPageCreationParameters.h:
Add areMemoryCacheClientCallsEnabled member variable.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Initialize m_areMemoryCacheClientCallsEnabled.
(WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled):
Update m_areMemoryCacheClientCallsEnabled. Send a message if necessary.
(WebKit::WebPageProxy::creationParameters):
Set areMemoryCacheClientCallsEnabled.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Call WebPage::setMemoryCacheMessagesEnabled.
2011-03-02 Timothy Hatcher <timothy@apple.com>
Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef.
https://webkit.org/b/55623
Reviewed by Darin Adler.
* UIProcess/API/C/WKPage.cpp:
(WKPageRunJavaScriptInMainFrame): Use ScriptValueCallback.
(callRunJavaScriptBlockAndRelease): Use WKSerializedScriptValueRef.
* UIProcess/API/C/WKPage.h: Use WKSerializedScriptValueRef.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Call invalidateCallbackMap for m_scriptValueCallbacks.
(WebKit::WebPageProxy::runJavaScriptInMainFrame): Take a ScriptValueCallback.
(WebKit::WebPageProxy::scriptValueCallback): Added. Create a WebSerializedScriptValue
from the DataReference before calling the callback.
(WebKit::WebPageProxy::processDidCrash): Call invalidateCallbackMap for m_scriptValueCallbacks.
* UIProcess/WebPageProxy.h: Added ScriptValueCallback and m_scriptValueCallbacks.
* UIProcess/WebPageProxy.messages.in: Added ScriptValueCallback.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame): Create a DataReference from a WebCore::SerializedScriptValue.
And use ScriptValueCallback to send the message back.
2011-03-02 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435
Add the ability to create a Private Browsing Storage Session.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
Encode the UI Process bundle identifier.
(WebKit::WebProcessCreationParameters::decode):
Decode the UI Process bundle identifier.
* Shared/WebProcessCreationParameters.h:
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
Grab the bundle identifier and use it to set the WebProcessCreationParameter.
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
Ditto.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Support using the wkCreatePrivateStorageSession WKSI in WebCore.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Set the base for the Private Browsing Storage Session identifier to be the bundle identifier
from the UI Process so that WebKit1 would create a Private Browsing Storage Session with the
same identifier as WebKit2.
2011-03-01 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::dispatchDidModifyCookies): Add a stub with a FIXME to send a
message to the UI process.
* WebProcess/Cookies/WebCookieManager.h:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createCookiesStrategy):
(WebKit::WebPlatformStrategies::notifyCookiesChanged): Call WebCookieManager::dispatchDidModifyCookies.
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
2011-03-02 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt][WK2] generate-forwarding-headers.pl should generate paths with framework names
https://bugs.webkit.org/show_bug.cgi?id=55478
On case insensitive systems the generated forwarding headers cause build problems.
* Scripts/generate-forwarding-headers.pl: The generated header should
also contain the framework name.
2011-03-01 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Expose some selection state fields in WKPage
https://bugs.webkit.org/show_bug.cgi?id=55541
Added WKPageCanDelete(), WKPageHasSelectedRange(), and WKPageIsContentEditable() so we can enable some
Edit menu items properly on Windows when using WebKit2.
* UIProcess/API/C/WKPage.cpp:
(WKPageCanDelete): Added.
(WKPageHasSelectedRange): Added.
(WKPageIsContentEditable): Added.
* UIProcess/API/C/WKPage.h: Added new functions.
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::canDelete): Added.
(WebKit::WebPageProxy::hasSelectedRange): Added.
(WebKit::WebPageProxy::isContentEditable): Added.
2011-03-01 Mark Rowe <mrowe@apple.com>
Hide the typeinfo name symbols for std::exception and std::bad_alloc too.
* Configurations/Base.xcconfig:
2011-03-01 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Add verification scripts to WebKit2 project and fix the issues they reveal.
* Configurations/Base.xcconfig: Add linker flags to prevent C++ standard
library functions from being exported as weak externals.
* Configurations/WebKit2.xcconfig: Inherit linker flags from the project level.
* Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::separatorItem): Use DEFINE_STATIC_LOCAL.
* UIProcess/WebPageGroup.cpp:
(WebKit::webPageGroupMap): Ditto.
* WebKit2.xcodeproj/project.pbxproj: Don't copy .in files in to the framework.
Run verification scripts at the appropriate times.
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::didBeginEditing): Use DEFINE_STATIC_LOCAL.
(WebKit::WebEditorClient::respondToChangedContents): Ditto.
(WebKit::WebEditorClient::respondToChangedSelection): Ditto.
(WebKit::WebEditorClient::didEndEditing): Ditto.
* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::idToHistoryItemMap): Ditto.
(WebKit::historyItemToIDMap): Ditto.
2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::viewportAttributesForSize):
2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
Unreviewed, missed updating a call to WebCore::computeViewportAttributes
who's prototype changed.
Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707
* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::viewportAttributesForSize): pass in a value for the document argument.
2011-03-01 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
WKPluginSiteDataManagerClearAllSiteData is not working
https://bugs.webkit.org/show_bug.cgi?id=55528
<rdar://problem/9071823>
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryGetSitesWithData):
Remove version checks, checking that the function pointer is not null is enough.
(WebKit::NetscapePluginModule::tryClearSiteData):
Remove version checks, checking that the function pointer is not null is enough.
Also, correctly convert a null String to a null CString.
2011-03-01 Adam Roben <aroben@apple.com>
Incorporate a review comment I missed in r80051
* Shared/Plugins/Netscape/NetscapePluginModule.cpp: Clarified error message.
2011-03-01 Adam Roben <aroben@apple.com>
Make the PLUGIN_ARCHITECTURE() macro work with MSVC
Fixes <http://webkit.org/b/55513> <rdar://problem/9069189> REGRESSION (r79925): Lots of
plugins tests crashing in NetscapePlugin::initialize on Windows
Reviewed by Anders Carlsson.
* Shared/Plugins/Netscape/NetscapePluginModule.cpp: Added a compile-time check to make sure
PLUGIN_ARCHITECTURE() is defined for some platform.
* config.h: Removed the parentheses from the use of "defined" in the PLUGIN_ARCHITECTURE()
macro. This matches PLATFORM(), OS(), etc., and makes the macro work on Windows. Also
replaced the nonsense OS(WIN) with OS(WINDOWS).
* win/WebKit2.vcproj: Added config.h for editing convenience. Let VS do its thang.
2011-03-01 Sam Weinig <sam@webkit.org>
Reviewed by Timothy Hatcher.
WebKit2 needs to be made localizable
https://bugs.webkit.org/show_bug.cgi?id=55483
* PluginProcess/mac/PluginProcessMainMac.mm:
* WebProcess/mac/WebProcessMainMac.mm:
Set the default localization from the passed in parameter.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
Add the preferred localization as a parameter when launching processes
so that they can set their localization to match the launching app.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
Use WebCore's localizedString function on the mac, to actually localize
these strings.
(WebKit::WebPlatformStrategies::imageTitle):
Switch to using replace, instead of concatenation, to give localizers a chance
to rearrange the wording.
2011-03-01 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Anders Carlsson.
[Qt][WK2] Plugin initialization
https://bugs.webkit.org/show_bug.cgi?id=48127
Apply the quirks that are necessary for the flash plugin
to not crash on X11.
* Platform/qt/ModuleQt.cpp:
(WebKit::Module::load): Use the ResolveAllSymbols hint as we do in WebCore.
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad): Call applyX11QuirksBeforeLoad
if PLUGIN_ARCHITECTURE is X11.
* Shared/Plugins/Netscape/NetscapePluginModule.h:
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::initializeGTK): The same hack that we do in WebCore.
Call gtk_init because flash don't do it for itself.
(WebKit::NetscapePluginModule::applyX11QuirksBeforeLoad): Added for X11.
Do the hacks that we need to do before calling NP_Initialize on the
flash plugin to save it form crashing.
* Shared/Plugins/PluginQuirks.h: Use PLUGIN_ARCHITECTURE macros.
Added RequiresGTKToolKit quirk for X11.
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue): Handle the RequiresGTKToolKit quirk on X11.
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
(WebKit::NetscapePlugin::quirks): Added getter for the PluginModule's
quirks to be available in NPN_GetValue.
2011-03-01 Adam Roben <aroben@apple.com>
Convert seconds to milliseconds before calling ::SetTimer
Fixes <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
early on Windows
Reviewed by Anders Carlsson.
* Platform/win/RunLoopWin.cpp:
(RunLoop::TimerBase::start): Convert the timeout interval to milliseconds, since that's what
::SetTimer expects.
2011-03-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Clean up the project files and move common options to WebKit.pri.
* WebKit2.pro: Deduplicate options.
2011-03-01 Juha Savolainen <juha.savolainen@weego.fi>
Reviewed by Andreas Kling.
[Qt] WebKit2 needs to support font size changing and getting default font size
https://bugs.webkit.org/show_bug.cgi?id=53671
Added new enum for font size type and added methods to set and get default font sizes.
* UIProcess/API/qt/qwkpreferences.cpp:
(QWKPreferences::setFontSize): Added.
(QWKPreferences::fontSize): Added.
* UIProcess/API/qt/qwkpreferences.h:
2011-02-28 Alice Liu <alice.liu@apple.com>
Reviewed by Adam Roben and Gavin Barraclough.
https://bugs.webkit.org/show_bug.cgi?id=54898
InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle
* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultCopyNodeHandle):
Instead of .get(), call .release.leakRef() like other functions that return WKBundleNodeHandleRef.
* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
Renamed from "get" to "copy", because it leaksRef.
2011-02-28 Alice Liu <alice.liu@apple.com>
Reviewed by Gavin Barraclough.
https://bugs.webkit.org/show_bug.cgi?id=55442
Webarchives don't contain subframe content
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getWebArchiveOfFrame):
Pass the frame's document instead of just the frame, to use a different LegacyWebArchive::create function.
2011-02-28 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Add a way to test the WebKit 2 APIs
https://bugs.webkit.org/show_bug.cgi?id=55408
Add an initial test for the WebKit 2 APIs of Qt.
* UIProcess/API/qt/tests/html/basic_page.html: Added.
* UIProcess/API/qt/tests/qgraphicswkview/qgraphicswkview.pro: Added.
* UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp: Added.
(View::View):
(View::resizeEvent):
(tst_QGraphicsWKView::init):
(tst_QGraphicsWKView::cleanup):
(tst_QGraphicsWKView::loadEmptyPage):
* UIProcess/API/qt/tests/tests.pri: Added.
* UIProcess/API/qt/tests/tests.pro: Added.
* UIProcess/API/qt/tests/util.h: Added.
(waitForSignal):
2011-02-28 Anders Carlsson <andersca@apple.com>
Fix clang build.
* UIProcess/API/mac/FindIndicatorWindow.mm:
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::deprecatedUpdate):
(WebKit::ChunkedUpdateDrawingAreaProxy::didReceiveMessage):
* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::deprecatedResumePainting):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
* WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
2011-02-28 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Anders Carlsson.
Do not copy config.h into WebKit2.
* WebKit2.xcodeproj/project.pbxproj:
2011-02-28 Dan Bernstein <mitz@apple.com>
LLVM Compiler build fix.
* Scripts/webkit2/messages.py:
* UIProcess/WebPageProxy.h:
2011-02-28 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein, Sam Weinig, Alexey Proskuryakov and Darin Adler.
Open PDF in Preview doesn't work
https://bugs.webkit.org/show_bug.cgi?id=55400
<rdar://problem/8750353>
* UIProcess/API/mac/PDFViewController.mm:
(-[WKPDFView initWithFrame:PDFViewController:]):
Set the WKPDFView as the delegate of itself.
(-[WKPDFView PDFViewOpenPDFInNativeApplication:]):
Call PDFViewController::openPDFInFinder.
(WebKit::PDFViewController::PDFViewController):
Initialize m_hasWrittenPDFToDisk to false.
(WebKit::PDFViewController::openPDFInFinder):
Write the PDF to disk if needed and then open it using -[NSWorkspace openFile:].
(WebKit::temporaryPDFDirectoryPath):
Create a directory to put PDFs in.
(WebKit::PDFViewController::pathToPDFOnDisk):
Return a path to a (non-existent) file in the temporary PDF directory.
2011-02-28 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
Frequent crashes in CFURLCache code on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=55412
<rdar://problem/9063922>
CString is evil, it has two lengths which can be different - specifically, fileSystemRepresentation()
creates a string with maximum possible buffer size. A path with garbage at the end confused
CFURLCache into corrupting its data structures.
* Shared/WebProcessCreationParameters.h: Added a FIXME about merging Mac and Windows code.
This problem wouldn't have occured if we didn't use CString in the first place.
* UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess):
Added an assertion matching Windows behavior (seems likely that NSURLCache also wouldn't
have liked trailing slash).
* UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess):
Made slash removal conditional for robustness.
* WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess):
Use actual string length, not CString::length().
2011-02-28 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Anders Carlsson.
[Qt][WK2] Plugin initialization
https://bugs.webkit.org/show_bug.cgi?id=48127
Specialize the way of initializing the plugin for X11.
Introduce PLUGIN_ARCHITECTURE macros to allow code sharing
across platforms.
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
* config.h:
2011-02-28 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
WK2 Context Menus - Implement LookUpInDictionary
https://bugs.webkit.org/show_bug.cgi?id=55405
* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h:
Add type to differentiate between HotKey and ContextMenu triggered
dictionary popups. This is necessary since HotKey triggered ones want
to override the style to always be overlay.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
Only force the overlay style for HotKey triggered dictionary lookups.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::performDictionaryLookupForRange):
Factor out shared functionality into performDictionaryLookupForRange.
* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::lookUpInDictionary):
Get selected range and call newly factored out performDictionaryLookupForRange.
2011-02-28 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
PDFViewController should hold a reference to the PDF data
https://bugs.webkit.org/show_bug.cgi?id=55394
* UIProcess/API/mac/PDFViewController.h:
* UIProcess/API/mac/PDFViewController.mm:
(WebKit::PDFViewController::setPDFDocumentData):
2011-02-28 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Size of text in popup menu doesn't match size of text in <select> itself in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48234
* Shared/TextInfo.cpp: Removed.
* Shared/TextInfo.h: Removed.
Replace this with the more appropriately DictionaryPopupInfo.
* Shared/DictionaryPopupInfo.cpp: Copied from Source/WebKit2/Shared/TextInfo.cpp.
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h: Copied from Source/WebKit2/Shared/TextInfo.h.
(WebKit::DictionaryPopupInfo::DictionaryPopupInfo):
Replace individual font related fields with FontInfo.
* Shared/FontInfo.cpp: Added.
(WebKit::FontInfo::FontInfo):
(WebKit::FontInfo::encode):
(WebKit::FontInfo::decode):
* Shared/FontInfo.h: Added.
Add class to encapsulate passing a font description over the wire.
* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
* Shared/PlatformPopupMenuData.h:
Add FontInfo as extra data for the Mac.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
* UIProcess/PageClient.h:
Add scaleFactor and use it to construct a font at the right size.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebPopupMenuProxy.h:
* UIProcess/mac/WebPopupMenuProxyMac.h:
(WebKit::WebPopupMenuProxyMac::create):
* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac):
(WebKit::WebPopupMenuProxyMac::populate):
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
* UIProcess/qt/WebPopupMenuProxyQt.h:
* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::showPopupMenu):
* UIProcess/win/WebPopupMenuProxyWin.h:
* WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
(WebKit::WebPopupMenu::setUpPlatformData):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
Pass scale factor through and rename TextInfo -> DictionaryPopupInfo.
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add new files.
2011-02-28 Adam Roben <aroben@apple.com>
One more rename as a followup to r79868
Rubber-stamped by Anders Carlsson.
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
Rename stateDidChange to backingStoreStateDidChange.
2011-02-28 Adam Roben <aroben@apple.com>
Rename DrawingArea[Proxy]Impl's "state ID" concept to "backing store state ID"
Rubber-stamped (and suggested) by Anders Carlsson.
* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.messages.in:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/DrawingAreaImpl.h:
Perform the rename.
2011-02-28 Adam Roben <aroben@apple.com>
Decouple state changes from sending of UpdateState messages in DrawingAreaProxyImpl
The new DrawingAreaProxyImpl::stateDidChange function should be called whenever
DrawingAreaProxyImpl's state changes in a way that will require allocating a new backing
store. (Currently, this is just when the size changes.) This function will sometimes (but
not always, as when we're waiting for a DidUpdateState message) send an UpdateState message
to the web process. This means it's now possible for the state IDs sent in consecutive
UpdateState messages to increase by more than one, but that's OK.
This should cause no change in behavior.
Fixes <http://webkit.org/b/55382> DrawingAreaProxyImpl's state ID should be updated whenever
its state changes, not just when we send an UpdateState message
Reviewed by Anders Carlsson.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Updated for rename.
(WebKit::DrawingAreaProxyImpl::sizeDidChange): Changed to call stateDidChange.
(WebKit::DrawingAreaProxyImpl::didUpdateState): Updated for rename, and changed to call
sendUpdateState whenever our state has changed for any reason since the last UpdateState
message was sent.
(WebKit::DrawingAreaProxyImpl::stateDidChange): Added. Increments m_nextStateID and calls
through to sendUpdateState.
(WebKit::DrawingAreaProxyImpl::sendUpdateState): Updated for rename, moved incrementing of
the state ID we send to the web process from here to stateDidChange, and added an assertion.
* UIProcess/DrawingAreaProxyImpl.h: Renamed m_requestedStateID to m_nextStateID, and updated
the comment explaining its meaning.
2011-02-28 Adam Roben <aroben@apple.com>
Pass the right dirty rect to Plugin::paint
A typo in r79040 broke this. Much of this patch is just support for testing the fix.
Fixes <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
Large portions of pages with plugins paint black
Reviewed by Anders Carlsson.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint): Pass the dirty rect we calculated earlier to Plugin::paint,
rather than just passing along the dirty rect that was passed into this function. This is
the bug fix.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageForceRepaint):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
Added new SPI. Just calls through to WebPage::forceRepaintWithoutCallback.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::forceRepaintWithoutCallback): Moved code to force a repaint here...
(WebKit::WebPage::forceRepaint): ...from here.
* WebProcess/WebPage/WebPage.h: Added forceRepaintWithoutCallback.
2011-02-27 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Force dictionary popup to use overlay type
<rdar://problem/9052483>
https://bugs.webkit.org/show_bug.cgi?id=55337
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup): As this is only
used for the hot key version of the dictionary popup, force the overlay
style.
2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] QGraphicsWKView::showContextMenu() should be public
https://bugs.webkit.org/show_bug.cgi?id=55330
Move QGraphicsWKView::showContextMenu() to the public API. Add documentation
on its use.
* UIProcess/API/qt/qgraphicswkview.cpp:
* UIProcess/API/qt/qgraphicswkview.h:
2011-02-27 Alejandro G. Castro <alex@igalia.com>
Unreviewed, fixed GTK compilation after r79806.
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
* UIProcess/gtk/WebView.h:
2011-02-26 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Asynchronous response to FramePolicyListener is not finishing the load
https://bugs.webkit.org/show_bug.cgi?id=55305
<rdar://problem/9044356>
Always initialize the receivedPolicyAction reply parameter.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
2011-02-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
DidFinishLoadingDataForCustomRepresentation should pass along the suggested filename
https://bugs.webkit.org/show_bug.cgi?id=55304
* UIProcess/API/mac/PDFViewController.h:
* UIProcess/API/mac/PDFViewController.mm:
(WebKit::PDFViewController::setPDFDocumentData):
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
* UIProcess/API/mac/WKView.mm:
(-[WKView _didFinishLoadingDataForCustomRepresentationWithSuggestedFilename:dataReference:CoreIPC::]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::didFinishLoadingDataForCustomRepresentation):
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFinishLoadingDataForCustomRepresentation):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
* UIProcess/win/WebView.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::finishedLoading):
2011-02-26 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
DrawingArea should not be reference counted
https://bugs.webkit.org/show_bug.cgi?id=55284
* Shared/DrawingAreaInfo.h:
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
(WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
(WebKit::ChunkedUpdateDrawingAreaProxy::update):
(WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::type):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
* UIProcess/DrawingAreaProxyImpl.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
* UIProcess/TiledDrawingAreaProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveSyncMessage):
(WebKit::WebPageProxy::creationParameters):
* WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):
(WebKit::ChunkedUpdateDrawingArea::display):
(WebKit::ChunkedUpdateDrawingArea::setSize):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
* WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
(WebKit::DrawingArea::DrawingArea):
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::create):
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::TiledDrawingArea):
* WebProcess/WebPage/TiledDrawingArea.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawRect):
* WebProcess/WebPage/WebPage.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to WKBundleWebFramePrivate.
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameClearOpener):
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
2011-02-26 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Fix the focus in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=55288
Implement basic functionality for focus in QWKPagePrivate.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::isViewWindowActive):
(QWKPagePrivate::isViewFocused):
(QWKPagePrivate::isViewVisible):
2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295
"broke Chromium builds" (Requested by rniwa on #webkit).
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to WKBundleWebFramePrivate.
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameClearOpener):
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
2011-02-25 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Plug-in process crashes when using GuardMalloc
https://bugs.webkit.org/show_bug.cgi?id=55279
<rdar://problem/9044618>
Update m_environmentPointer after copying the environment variables.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::EnvironmentVariables::copyEnvironmentVariables):
2011-02-25 Darin Adler <darin@apple.com>
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Fixed backwards logic from last change.
2011-02-25 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Fixed performance problem in production
builds by only setting DYLD_FRAMEWORK_PATH in engineering configurations.
2011-02-25 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/8036034> WebKit2 should work even if DYLD_FRAMEWORK_PATH is not set
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::EnvironmentVariables::~EnvironmentVariables): Use fastFree, not delete, on
the strings here because they are allocated with fastMalloc, not new.
(WebKit::EnvironmentVariables::set): Use const more.
(WebKit::EnvironmentVariables::get): Ditto.
(WebKit::EnvironmentVariables::appendValue): Ditto.
(WebKit::EnvironmentVariables::valueIfVariableHasName): Ditto. Also fix mistake
where this would match if the name matched only a prefix of the environment variable's
name. We want to match the whole name, so we need to use memcmp, not strncmp.
(WebKit::EnvironmentVariables::createStringForVariable): Use const more.
(WebKit::ProcessLauncher::launchProcess): Use clearer name, frameworkExecutablePath,
for what was called bundlePath before. Append the frameworks path to DYLD_FRAMEWORK_PATH,
ensuring we can pick up other frameworks from the same directory in the web process.
Use a const_cast instead of a C-style cast.
2011-02-25 Chris Fleizach <cfleizach@apple.com>
Reviewed by Anders Carlsson.
AX: WK2: AXApplication not returning the AXFocusedUIElement within the web area
https://bugs.webkit.org/show_bug.cgi?id=55277
* UIProcess/API/mac/WKView.mm:
(-[WKView accessibilityFocusedUIElement]):
2011-02-25 Alexey Proskuryakov <ap@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=55276
WebPage::close() accesses "this" after it is destroyed.
This was making many tests crash with GuardMalloc.
* WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Access "this" before it can be
destroyed, not after.
2011-02-25 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed.
Add missing sources to WebKit2API.pri.
* WebKit2API.pri:
2011-02-25 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
A WKView without a window will cause CG errors in the console
https://bugs.webkit.org/show_bug.cgi?id=55264
<rdar://problem/9044281>
Check that the window has a valid window number before trying to get its graphics context.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::containingWindowGraphicsContext):
2011-02-25 Brian Weinstein <bweinstein@apple.com>
Reviewed by Brady Eidson and looked over by Jessie Berlin.
WebKit2: Need a way to manage cookies from the web process
https://bugs.webkit.org/show_bug.cgi?id=55086
Call through to WebCore::CookieJar in our WebCookieManager functions.
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):
2011-02-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Option-clicking on links doesn't download them due to sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=55250
<rdar://problem/9018359>
The change to make DecidePolicyForNavigationAction sync didn't handle the case when the
decided policy was "Download". Fix this by passing along the download ID back to the web process.
* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add new overload.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Initialize m_syncNavigationActionPolicyDownloadID.
(WebKit::WebPageProxy::receivedPolicyDecision):
Set m_syncNavigationActionPolicyDownloadID to the download ID.
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Return the m_syncNavigationActionPolicyDownloadID.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
Add a DownloadID reply parameter.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
Don't pass a zero download ID to didReceivePolicyDecision.
2011-02-25 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement WebContext and NativeKeyboardEvent classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48510
* GNUmakefile.am:
* Shared/NativeWebKeyboardEvent.h: Added the GTK event attribute
and constructors, in our case we need it because we use a pointer
and copy the event.
(WebKit::NativeWebKeyboardEvent::nativeEvent):
* Shared/gtk/NativeWebKeyboardEventGtk.cpp: Added.
(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent): We need
to copy the event in the constructor to avoid two references to
the same event.
* Shared/gtk/WebEventFactory.cpp: Changed the prototype of the
functions to add const, we need it for the NativeWebKeyboardEvent
constructor.
(WebKit::modifiersForEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
* UIProcess/gtk/WebContextGtk.cpp: Added. Stubbed implementation
for GTK port. Yet to implement.
(WebKit::WebContext::applicationCacheDirectory):
(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformDefaultDatabaseDirectory):
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::handleKeyboardEvent):
2011-02-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Get rid of more old accelerated compositing code
https://bugs.webkit.org/show_bug.cgi?id=55235
* Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/DrawingAreaImpl.h:
2011-02-25 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Make the WebKit2 build system less confusing for non-Qt developers
https://bugs.webkit.org/show_bug.cgi?id=55213
* WebKit2API.pri: Added.
2011-02-25 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement WebView and WebKitWebView classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48509
* GNUmakefile.am:
* UIProcess/API/C/gtk/WKView.cpp:
* UIProcess/API/C/gtk/WKView.h: Removed gdkrectangle from
constructor.
* UIProcess/gtk/WebViewWidget.cpp: Added. The GObject interface
for WebView. The GObject is the GtkWidget handle which is used by
WebView class for GTK port.
* UIProcess/gtk/WebViewWidget.h: Added. The GObject interface
declarations for GtkWidget handle for GTK port.
* UIProcess/gtk/WebView.cpp: Added. The native GtkWidget handle
for GTK port which is associated with each WKViewRef.
* UIProcess/gtk/WebView.h: Added. Class which implements the
PageClient interface. It is a wrapper over the native GtkWidget
handle associated with each WKViewRef for GTK port.
2011-02-25 Alejandro G. Castro <alex@igalia.com>
Fix GTK compilation after r79654.
* GNUmakefile.am:
2011-02-24 Brian Weinstein <bweinstein@apple.com>
Qt build fix.
* WebKit2.pri:
2011-02-24 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig and looked over by Brian Weinstein.
Part of <rdar://problem/8762095> and https://bugs.webkit.org/show_bug.cgi?id=55172
Need WebKit2 API to view/manage origins with LocalStorage.
Project file stuff:
* GNUmakefile.am:
* WebKit2.pri:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Common.vsprops:
* win/WebKit2Generated.make:
WK2 derived sources and API stuff:
* DerivedSources.make:
* DerivedSources.pro:
* Platform/CoreIPC/MessageID.h:
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* UIProcess/API/C/WKAPICast.h:
Add an KeyValueStorageManager to the context and invalidate it at the appropriate times:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::didReceiveMessage):
* UIProcess/WebContext.h:
(WebKit::WebContext::keyValueStorageManagerProxy):
Add API to get the KeyValueStorageManager for a context:
* UIProcess/API/C/WKContext.cpp:
(WKContextGetKeyValueStorageManager):
* UIProcess/API/C/WKContext.h:
Route messages to the right place:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
Add the API object, which wraps to WebKeyValueStorageManagerProxy:
* UIProcess/API/C/WKKeyValueStorageManager.cpp: Added.
(WKKeyValueStorageManagerGetTypeID):
(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerDeleteEntriesForOrigin):
(WKKeyValueStorageManagerDeleteAllEntries):
* UIProcess/API/C/WKKeyValueStorageManager.h: Added.
The UIProcess implementation of the manager to send messages to the WebProcess and pipe a callback back up to the client:
* UIProcess/WebKeyValueStorageManagerProxy.cpp: Added.
(WebKit::WebKeyValueStorageManagerProxy::create):
(WebKit::WebKeyValueStorageManagerProxy::WebKeyValueStorageManagerProxy):
(WebKit::WebKeyValueStorageManagerProxy::~WebKeyValueStorageManagerProxy):
(WebKit::WebKeyValueStorageManagerProxy::invalidate):
(WebKit::WebKeyValueStorageManagerProxy::didReceiveMessage):
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::didGetKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
* UIProcess/WebKeyValueStorageManagerProxy.h: Added.
(WebKit::WebKeyValueStorageManagerProxy::clearContext):
(WebKit::WebKeyValueStorageManagerProxy::type):
* UIProcess/WebKeyValueStorageManagerProxy.messages.in: Added.
The WebProcess implementation to response to UIProcess messages and actually do the dirty-work in WebCore:
* WebProcess/KeyValueStorage: Added.
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp: Added.
(WebKit::WebKeyValueStorageManager::shared):
(WebKit::WebKeyValueStorageManager::WebKeyValueStorageManager):
(WebKit::WebKeyValueStorageManager::didReceiveMessage):
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.h: Added.
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.messages.in: Added.
2011-02-24 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Image-based cursors do not work
https://bugs.webkit.org/show_bug.cgi?id=55184
* Shared/ShareableBitmap.h: Added releaseData function
declaration. This is only defined for CG, but we can declare
it without defining it on non-CG platforms without causing problems.
* Shared/WebCoreArgumentCoders.cpp: Added.
(CoreIPC::encodeImage): Added. For use in the Cursor argument coder.
(CoreIPC::decodeImage): Ditto.
* Shared/WebCoreArgumentCoders.h: Added code to the Cursor encoder
and decoder to handle image-based cursors, using the new encodeImage
and decodeImage functions.
* Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::releaseData): Added.
(WebKit::ShareableBitmap::createGraphicsContext): Use
CGBitmapContextCreateWithData instead of CGBitmapContextCreate,
to guarantee we outlast the CGBitmapContext we create.
(WebKit::ShareableBitmap::paint): Got rid of unnneeded local variable.
* Shared/cg/WebCoreArgumentCodersCG.cpp: Added.
(CoreIPC::createImage): Added. For use by CoreIPC::decodeImage.
* WebKit2.xcodeproj/project.pbxproj: Added WebCoreArgumentCoders.cpp
and WebCoreArgumentCodersCG.cpp.
* win/WebKit2.vcproj: Ditto.
2011-02-24 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Crash when trying to send a sync message on an invalid connection
https://bugs.webkit.org/show_bug.cgi?id=55190
<rdar://problem/9035806>
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncMessage):
Don't try to call a client function if isValid() returns false since the client
will be null in that case.
2011-02-24 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Remove the layer backed drawing area
https://bugs.webkit.org/show_bug.cgi?id=55174
* GNUmakefile.am:
* Shared/DrawingAreaInfo.h:
* UIProcess/API/mac/WKView.mm:
* UIProcess/LayerBackedDrawingAreaProxy.cpp: Removed.
* UIProcess/LayerBackedDrawingAreaProxy.h: Removed.
* UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: Removed.
* UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp: Removed.
* UIProcess/win/WebView.cpp:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
* WebProcess/WebPage/LayerBackedDrawingArea.cpp: Removed.
* WebProcess/WebPage/LayerBackedDrawingArea.h: Removed.
* WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: Removed.
* WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Removed.
* win/WebKit2.vcproj:
2011-02-24 Mike Thole <mthole@apple.com>
Reviewed by Sam Weinig.
WK2: Add ability to get document node for a WKBundleNodeHandle
https://bugs.webkit.org/post_bug.cgi
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleCopyDocument):
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::document):
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
2011-02-24 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben and looked at by Brian Weinstein.
https://bugs.webkit.org/show_bug.cgi?id=55165
Can call CF API with a null CFArray in WebResourceCacheManager
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins): cfURLCacheHostNames() can return a null CFArrayRef,
so the call to CFArrayGetCount must be null checked.
2011-02-24 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
ASSERTION FAILED: !isInAcceleratedCompositingMode() when entering accelerated compositing early
https://bugs.webkit.org/show_bug.cgi?id=55162
<rdar://problem/9048523>
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updateState):
Call setShouldNotifyAfterNextScheduledLayerFlush(false) so the web process process won't send an
EnterAcceleratedCompositingMode message.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
setShouldNotifyAfterNextScheduledLayerFlush now takes a boolean.
* WebProcess/WebPage/LayerTreeHost.h:
* WebProcess/WebPage/mac/LayerTreeHostMac.h:
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::setShouldNotifyAfterNextScheduledLayerFlush):
Make this take a boolean.
2011-02-24 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
Drop the "U; " encryption level from the User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54566
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::standardUserAgent):
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::standardUserAgent):
* UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::standardUserAgent):
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::standardUserAgent):
2011-02-24 Andrew Wilson <atwilson@chromium.org>
Unreviewed, rolling out r79570.
http://trac.webkit.org/changeset/79570
https://bugs.webkit.org/show_bug.cgi?id=54874
Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
2011-02-23 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben and looked over by Jessie Berlin.
Part of WebKit2: Need a way to manage cookies from the web process
https://bugs.webkit.org/show_bug.cgi?id=55086
This patch adds the plumbing and classes that are needed to manage cookies from the web process.
The functions that the API calls are currently stubs, but will be implemented in a follow-up patch.
Project file changes.
* DerivedSources.make:
* DerivedSources.pro:
* GNUmakefile.am:
* WebKit2.pri:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Common.vsprops:
* win/WebKit2Generated.make:
Add some needed plumbing for WebCookieManager{Proxy}.
* Platform/CoreIPC/MessageID.h:
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKContext.cpp:
(WKContextGetCookieManager): Gets the cookie manager proxy.
* UIProcess/API/C/WKContext.h:
* UIProcess/API/C/WKCookieManager.cpp: Added.
(WKCookieManagerGetTypeID):
(WKCookieManagerGetHostnamesWithCookies): Calls through to WebCookieManagerProxy.
(WKCookieManagerDeleteCookiesForHostname): Ditto.
(WKCookieManagerDeleteAllCookies): Ditto.
* UIProcess/API/C/WKCookieManager.h: Added.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage): Add a case for the cookie manager.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Initialize the cookie manager.
(WebKit::WebContext::~WebContext): Invalidate the cookie manager.
(WebKit::WebContext::disconnectProcess): Ditto.
(WebKit::WebContext::didReceiveMessage): Add a case for the cookie manager.
* UIProcess/WebContext.h:
(WebKit::WebContext::cookieManagerProxy): Returns the cookie manager.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage): Add a case for the cookie manager.
* UIProcess/WebCookieManagerProxy.cpp: Added.
(WebKit::WebCookieManagerProxy::create):
(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::~WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::invalidate):
(WebKit::WebCookieManagerProxy::didReceiveMessage):
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies): Call through to the web process to get hostnames with cookies.
(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies): Call the callback we were passed in getHostnamesWithCookies.
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname): Call through to the web process to delete cookies
for the origin.
(WebKit::WebCookieManagerProxy::deleteAllCookies): Call through to the web process to delete all cookies.
* UIProcess/WebCookieManagerProxy.h: Added.
(WebKit::WebCookieManagerProxy::clearContext):
(WebKit::WebCookieManagerProxy::type):
* UIProcess/WebCookieManagerProxy.messages.in: Added.
* WebProcess/Cookies: Added.
* WebProcess/Cookies/WebCookieManager.cpp: Added.
(WebKit::WebCookieManager::shared):
(WebKit::WebCookieManager::WebCookieManager):
(WebKit::WebCookieManager::didReceiveMessage): Call through to didReceiveWebCookieManagerMessage.
(WebKit::WebCookieManager::getHostnamesWithCookies): Build an array from a HashSet (that isn't filled yet), and
convert that HashSet to a Vector to send to the UI process.
(WebKit::WebCookieManager::deleteCookiesForHostname): Added a stub.
(WebKit::WebCookieManager::deleteAllCookies): Ditto.
* WebProcess/Cookies/WebCookieManager.h: Added.
* WebProcess/Cookies/WebCookieManager.messages.in: Added.
2011-02-24 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement WebEventFactory, WebErrors classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48510
* GNUmakefile.am:
* Shared/gtk/WebEventFactory.cpp: Added. implementation for
WebMouseEvent, WebWheelEvent, WebKeyboardEvent.
* Shared/gtk/WebEventFactory.h: Added.
* WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp: Added. Stubbed
implementation for GTK port.
2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Alexey Proskuryakov.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to WKBundleWebFramePrivate.
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameClearOpener):
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
2011-02-24 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Eric Seidel.
Support building WebKit with Python 3
https://bugs.webkit.org/show_bug.cgi?id=55038
Update the generator scripts to support Python 3.
* Scripts/generate-message-receiver.py: print is a function in Python 3, write the output to
sys.stdout to be compatible with Python 2 and 3.
* Scripts/generate-messages-header.py:
* Scripts/webkit2/messages.py: dist.iteritems does not exist in Python 3, fallback
to dict.items which is common to Python 2 and 3.
2011-02-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] MinGW build fails to link
https://bugs.webkit.org/show_bug.cgi?id=55050
Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries
* WebKit2.pri:
2011-02-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] REGRESSION(69304): WKNativeEvent.h forwarding header is always regenerated
https://bugs.webkit.org/show_bug.cgi?id=47589
In case of file name clashes only generate forwarding header for the current platform.
* Scripts/generate-forwarding-headers.pl:
2011-02-23 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Remove some of the old accelerated compositing code
https://bugs.webkit.org/show_bug.cgi?id=55084
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::exitAcceleratedCompositingMode):
* UIProcess/API/mac/WKView.mm:
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::exitAcceleratedCompositingMode):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
(WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
(WebKit::LayerBackedDrawingAreaProxy::detachCompositingContext):
* UIProcess/win/WebView.cpp:
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::enterAcceleratedCompositingMode):
(WebKit::WebPage::exitAcceleratedCompositingMode):
* WebProcess/WebPage/WebPage.h:
2011-02-23 Enrica Casucci <enrica@apple.com>
Reverting an unintentional change that was part of http://trac.webkit.org/changeset/79494.
Unreviewed.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::interceptEditingKeyboardEvent):
2011-02-18 Enrica Casucci <enrica@apple.com>
Reviewed by Adam Roben.
Mac OS X Services are not available for selected text in WebKit2 windows.
https://bugs.webkit.org/show_bug.cgi?id=54777
<rdar://problem/8666428>
This patch adds support for Mac OS X Services in WebKit2 windows.
In WKView we now call registerServicesMenuSendTypes providing the
pasteboard types supported by WebKit and we also implement the two
protocol methods required to validate the send type and write the
content to the pasteboard. Unfortunately, AppKit expects the content
to be available in the pasteboard upon return from writeSelectionToPasteboard and
this is the reason why the call to the WebProcess is synchronous.
* Shared/SelectionState.h:
(WebKit::SelectionState::SelectionState): Extended to include
isContentRichlyEditable
* Shared/mac/PasteboardTypes.h:
* Shared/mac/PasteboardTypes.mm:
(WebKit::PasteboardTypes::forSelection): Added.
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]): Added call
to registerServicesMenuSendTypes.
(-[WKView writeSelectionToPasteboard:types:]): Added.
(-[WKView validRequestorForSendType:returnType:]): Added.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::writeSelectionToPasteboard):
* UIProcess/WebPageProxy.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection): Modified to
support the new SelectionState value.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::writeSelectionToPasteboard): Added synchronous
message to write the selected content to the pasteboard.
2011-02-23 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a ShareableBitmap::create overload that takes an existing SharedMemory object
https://bugs.webkit.org/show_bug.cgi?id=55081
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::createShareable):
(WebKit::ShareableBitmap::create):
* Shared/ShareableBitmap.h:
2011-02-23 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Web Inspector toolbar looks bad in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=55076
<rdar://problem/8866258>
* UIProcess/API/mac/WKView.mm:
(-[WKView mouseDownCanMoveWindow]):
Return NO from mouseDownCanMoveWindow to prevent drags in the (now transparent) inspector WKView
from dragging the window around.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Call [WKView setDrawsBackground:NO].
2011-02-23 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove WKPageForceRepaintWithInvalidation and instead make WKPageForceRepaint
always dirty the entire page.
* Shared/ForceRepaintFlags.h: Removed.
* UIProcess/API/C/WKPage.cpp:
(WKPageForceRepaint):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::forceRepaint):
* UIProcess/WebPageProxy.h:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::forceRepaint):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* win/WebKit2.vcproj:
2011-02-23 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Race condition when creating and destroying pages quickly
https://bugs.webkit.org/show_bug.cgi?id=55061
<rdar://problem/8708435>
When the last page in a web process is closed, the web process would
previously terminate, even if the UI process had created a new page
(the CreateNewPage message just wouldn't have reached the web process yet).
Fix this by adding a ShouldTerminate message that the web process sends when it's
about to terminate. If the UI process has any pending pages, downloads etc. it will
prevent the web process from terminating. Otherwise, it will immmediately disconnect
the WebPageProxy so that creating a page after that will launch a new web process.
* UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::shouldTerminate):
* UIProcess/Plugins/WebPluginSiteDataManager.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
* UIProcess/WebContext.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::shouldTerminate):
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::terminateIfPossible):
2011-02-23 Mike Thole <mthole@apple.com>
Reviewed by Darin Adler.
WKBundleNavigationAction.h should be exposed as a public header
https://bugs.webkit.org/show_bug.cgi?id=55059
* WebKit2.xcodeproj/project.pbxproj:
Changed WKBundleNavigationAction.h from 'project' to 'public'.
2011-02-23 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Make sure Symbian binary UIDs are unique
* WebProcess.pro: Resolve the UID collision with QtTestBrowser.pro
by changing the UID.
2011-02-23 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix the Symbian build after r79334
https://bugs.webkit.org/show_bug.cgi?id=55044
* WebKit2.pri: Copy the rules from JavaScriptCore.pri for
defineTest().
Remove addWebKit2LibWholeArchive as it is no longer needed.
2011-02-23 Alejandro G. Castro <alex@igalia.com>
Unreviewed, fixed GTK WebKit2 compilation after r79366.
* GNUmakefile.am:
2011-02-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Rename PLATFORM(CF) to USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=53540
* UIProcess/WebBackForwardList.h:
* UIProcess/WebPageProxy.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::formatLocalizedString):
2011-02-23 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] [WK2] When the context menu is empty, we should still send the signal QWKPage::showContextMenu()
https://bugs.webkit.org/show_bug.cgi?id=54996
Send the signal QWKPage::showContextMenu() with an empty menu even if the content menu generated
is empty/contain only disabled elements.
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::showContextMenu):
* UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::WebContextMenuProxyQt::showContextMenu):
2011-02-22 Dan Bernstein <mitz@apple.com>
LLVM Compiler build fix.
* Scripts/webkit2/messages.py:
* WebProcess/ApplicationCache/WebApplicationCacheManager.h:
2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Alexey Proskuryakov.
Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::standardUserAgent):
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::standardUserAgent):
* UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::standardUserAgent):
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::standardUserAgent): Drop the language tag
part and fix style.
2011-02-22 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add WebKit2 API to force a repaint with an invalidation
https://bugs.webkit.org/show_bug.cgi?id=55015
* Shared/ForceRepaintFlags.h: Added.
* UIProcess/API/C/WKPage.cpp:
(WKPageForceRepaint):
(WKPageForceRepaintWithInvalidation):
* UIProcess/API/C/WKPage.h:
Add WKPageForceRepaintWithInvalidation which does the same thing WKPageForceRepaint
but also calls setNeedsDisplay on the entire bounds of the page.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::forceRepaint):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::forceRepaint):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
Pipe the flag down to the WebProcess.
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add ForceRepaintFlags.h.
2011-02-22 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/9039670>
Make sure that we set the accelerateDrawing property on the LayerTreeHosts's
non-composited content layer if the preference is set.
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::LayerTreeHostMac):
2011-02-22 Brady Eidson <beidson@apple.com>
Fix it Windows-style.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):
2011-02-22 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Rename WebProcess::shutdownIfPossible to WebProcess::terminateIfPossible
https://bugs.webkit.org/show_bug.cgi?id=55008
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::downloadFinished):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::removeWebPage):
(WebKit::WebProcess::terminateIfPossible):
(WebKit::WebProcess::getSitesWithPluginData):
* WebProcess/WebProcess.h:
* WebProcess/gtk/WebProcessGtk.cpp:
(WebKit::WebProcess::platformTerminate):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformTerminate):
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformTerminate):
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformTerminate):
2011-02-22 Brady Eidson <beidson@apple.com>
Windows build-fix attempt.
* win/WebKit2Generated.make:
2011-02-22 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed.
<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.
[Qt][WK2] Buildfix after r79364.
* DerivedSources.pro:
* WebKit2.pri:
2011-02-22 Brady Eidson <beidson@apple.com>
Reviewed by Anders Carlsson and looked over by Brian Weinstein.
<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.
I couldn't help myself - I also re-alphabetized WebResourceCacheManager in many places where
it's sorting was wrong due to a last minute name change.
Project file changes:
* GNUmakefile.am:
* win/WebKit2.vcproj:
* win/WebKit2Common.vsprops:
* win/WebKit2Generated.make:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
WK2 build-system and API paperwork:
* DerivedSources.make:
* Platform/CoreIPC/MessageID.h:
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* UIProcess/API/C/WKAPICast.h:
Add a helper to perform an ArrayCallback with a Vector of SecurityOriginDatas:
* Shared/SecurityOriginData.cpp:
(WebKit::performAPICallbackWithSecurityOriginDataVector):
* Shared/SecurityOriginData.h:
* UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::didGetCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.
Add an ApplicationCacheManagerProxy to the context and invalidate it at the appropriate times:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::processDidClose):
(WebKit::WebContext::didReceiveMessage): Route messages to the right proxy.
* UIProcess/WebContext.h:
(WebKit::WebContext::applicationCacheManagerProxy):
(WebKit::WebContext::resourceCacheManagerProxy):
Add API to get the ApplicationCacheManager for a context:
* UIProcess/API/C/WKContext.cpp:
(WKContextGetApplicationCacheManager):
(WKContextGetResourceCacheManager):
* UIProcess/API/C/WKContext.h:
Route messages to the right place:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
Add the API object, which wraps to WebApplicationCacheManagerProxy:
* UIProcess/API/C/WKApplicationCacheManager.cpp: Added.
(WKApplicationCacheManagerGetTypeID):
(WKApplicationCacheManagerGetApplicationCacheOrigins):
(WKApplicationCacheManagerDeleteEntriesForOrigin):
(WKApplicationCacheManagerDeleteAllEntries):
* UIProcess/API/C/WKApplicationCacheManager.h: Added.
The UIProcess implementation of the manager to send messages to the WebProcess and pipe a callback back up to the client:
* UIProcess/WebApplicationCacheManagerProxy.cpp: Added.
(WebKit::WebApplicationCacheManagerProxy::create):
(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::~WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::invalidate):
(WebKit::WebApplicationCacheManagerProxy::didReceiveMessage):
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::didGetApplicationCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
* UIProcess/WebApplicationCacheManagerProxy.h: Added.
(WebKit::WebApplicationCacheManagerProxy::clearContext):
(WebKit::WebApplicationCacheManagerProxy::type):
* UIProcess/WebApplicationCacheManagerProxy.messages.in: Added.
The WebProcess implementation to response to UIProcess messages and actually do the dirty-work in WebCore:
* WebProcess/ApplicationCache: Added.
* WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: Added.
(WebKit::WebApplicationCacheManager::shared):
(WebKit::WebApplicationCacheManager::WebApplicationCacheManager):
(WebKit::WebApplicationCacheManager::didReceiveMessage):
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):
* WebProcess/ApplicationCache/WebApplicationCacheManager.h: Added.
* WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in: Added.
2011-02-22 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Get rid of WebProcessManager
https://bugs.webkit.org/show_bug.cgi?id=55001
WebProcessManager had become a stupid map of WebContext > WebProcess relations,
which isn't really useful since the WebContext already knows about its process.
* Shared/WebURLRequest.cpp:
* UIProcess/API/mac/WKView.mm:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::processDidFinishLaunching):
* UIProcess/WebProcessManager.cpp: Removed.
* UIProcess/WebProcessManager.h: Removed.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didClose):
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
2011-02-22 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Get rid of WebProcessManager::getAllWebProcessContexts
https://bugs.webkit.org/show_bug.cgi?id=55000
* Shared/WebURLRequest.cpp:
(WebKit::WebURLRequest::setDefaultTimeoutInterval):
Call WebContext::allContexts instead.
* UIProcess/WebContext.cpp:
* UIProcess/WebContext.h:
Add a vector of WebContext objects. Update it when creating and destroying contexts.
* UIProcess/WebProcessManager.cpp:
* UIProcess/WebProcessManager.h:
Remove WebProcessManager::getAllWebProcessContexts.
2011-02-22 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Re-add early bail out in dispatchDecidePolicyForNavigationAction with prevents
a crash running fast/loader/empty-embed-src-attribute.html. This matches a
bail out in the default policy delegate in WebKit1.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2011-02-22 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Grammar correction from Spelling & Grammar window doesn't work
https://bugs.webkit.org/show_bug.cgi?id=54982
<rdar://problem/8940918>
* UIProcess/API/mac/WKView.mm:
(-[WKView isGrammarCheckingEnabled]):
(-[WKView setGrammarCheckingEnabled:]):
Call down to the text checker.
* UIProcess/TextChecker.h:
Add updateSpellingUIWithGrammarString.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateSpellingUIWithGrammarString):
Call TextChecker::updateSpellingUIWithGrammarString.
* UIProcess/WebPageProxy.messages.in:
Add UpdateSpellingUIWithGrammarString message.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
* UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
Add stubs.
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
Update the spelling panel.
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::updateSpellingUIWithGrammarString):
Send an UpdateSpellingUIWithGrammarString message to the UI process.
2011-02-22 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Anders Carlsson.
notImplemented() should behave identical in WebCore and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54449
Use NotImplemented.h from WebCore. Initialize logging channels.
Remove the WebKit2 concept of notImplemented().
* Platform/gtk/SharedMemoryGtk.cpp:
* Platform/gtk/WorkQueueGtk.cpp:
* Platform/qt/WorkQueueQt.cpp:
* Platform/win/WorkQueueWin.cpp:
* Shared/NotImplemented.h: Removed.
* Shared/Plugins/NPIdentifierData.cpp:
* Shared/Plugins/NPRemoteObjectMap.cpp:
* Shared/Plugins/NPVariantData.cpp:
* Shared/cairo/ShareableBitmapCairo.cpp:
* Shared/gtk/ShareableBitmapGtk.cpp:
* Shared/gtk/WebCoreArgumentCodersGtk.cpp:
* Shared/qt/WebCoreArgumentCodersQt.cpp:
* Shared/win/LayerTreeContextWin.cpp:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/API/qt/qwkpage.cpp:
* UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
* UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
* UIProcess/WebInspectorProxy.cpp:
* UIProcess/gtk/TextCheckerGtk.cpp:
* UIProcess/gtk/WebInspectorGtk.cpp:
* UIProcess/gtk/WebPreferencesGtk.cpp:
* UIProcess/qt/TextCheckerQt.cpp:
* UIProcess/qt/WebInspectorProxyQt.cpp:
* UIProcess/win/TextCheckerWin.cpp:
* UIProcess/win/WebContextMenuProxyWin.cpp:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Downloads/cf/DownloadCFNet.cpp:
* WebProcess/Downloads/curl/DownloadCurl.cpp:
* WebProcess/Downloads/mac/DownloadMac.mm:
* WebProcess/Downloads/qt/DownloadQt.cpp:
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
* WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
* WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
* WebProcess/WebCoreSupport/WebDragClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
* WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
* WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
* WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
* WebProcess/WebPage/qt/WebInspectorQt.cpp:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
* WebProcess/gtk/WebProcessGtk.cpp:
* config.h:
* win/WebKit2.vcproj:
2011-02-22 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Brady Eidson.
Invalidate the WebResourceCacheManagerProxy in WebContext::processDidClose.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::processDidClose):
2011-02-21 Adam Roben <aroben@apple.com>
Make DrawingAreaProxyImpl keep track of the most recent state ID it sent to the web process
This will be useful for sending repeated messages for the same state ID to the web process.
We don't do this currently, but will need to if we're asked to paint after we've thrown away
our backing store to save memory.
Fixes <http://webkit.org/b/54916> DrawingAreaProxyImpl should keep track of the state ID it
last sent to the web process
Reviewed by Anders Carlsson.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize m_requestedStateID, and
reordered member initialization to match the new declaration order.
(WebKit::DrawingAreaProxyImpl::didUpdateState): Added an assertion that the stateID we got
from the web process is no newer than the most recent one we requested.
(WebKit::DrawingAreaProxyImpl::sendUpdateState): Changed to increment and send
m_requestedStateID instead of a new global stateID.
* UIProcess/DrawingAreaProxyImpl.h: Added m_requestedStateID, and moved the state IDs before
other data members. Also beefed the comment explaining m_currentStateID.
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
* WebKit2.pri: Add include paths.
* WebKit2.pro: Move include paths to WebKit2.pri and move
the API source to WebKit/qt/QtWebKit.pro
2011-02-22 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] Improve the memory handling of the context menu for WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=54902
Refactor the context menu handling of Qt to make it simpler to manage memory.
WebContextMenuProxyQt uses smart pointer for all the references to menu so
there is no need to delete it explicitely.
Passing the QMenu from QWKPage to the client of the signal now uses a QSharedPointer so
the client can choose to handle the memory, but there is no leak if it does not.
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::QGraphicsWKView):
(QGraphicsWKView::showContextMenu):
* UIProcess/API/qt/qgraphicswkview.h:
* UIProcess/API/qt/qwkpage.h:
* UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):
* UIProcess/qt/WebContextMenuProxyQt.h:
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Removed reference to NotImplemented.h which was removed.
* GNUmakefile.am:
2011-02-22 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtWebProcess should be installed with 'make install'
https://bugs.webkit.org/show_bug.cgi?id=44100
Follow the standard in other project files and allow install
location to be changed with INSTALL_BINS variable.
* WebProcess.pro: Install QtWebProcess.
2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79296.
http://trac.webkit.org/changeset/79296
https://bugs.webkit.org/show_bug.cgi?id=54941
Breaks compilation on SnowLeapard Intel Release (Requested by
kbalazs_ on #webkit).
* Platform/gtk/SharedMemoryGtk.cpp:
* Platform/gtk/WorkQueueGtk.cpp:
* Platform/qt/WorkQueueQt.cpp:
* Platform/win/WorkQueueWin.cpp:
* Shared/NotImplemented.h: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
* Shared/Plugins/NPIdentifierData.cpp:
* Shared/Plugins/NPRemoteObjectMap.cpp:
* Shared/Plugins/NPVariantData.cpp:
* Shared/cairo/ShareableBitmapCairo.cpp:
* Shared/gtk/ShareableBitmapGtk.cpp:
* Shared/gtk/WebCoreArgumentCodersGtk.cpp:
* Shared/qt/WebCoreArgumentCodersQt.cpp:
* Shared/win/LayerTreeContextWin.cpp:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/API/qt/qwkpage.cpp:
* UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
* UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
* UIProcess/WebInspectorProxy.cpp:
* UIProcess/gtk/TextCheckerGtk.cpp:
* UIProcess/gtk/WebInspectorGtk.cpp:
* UIProcess/gtk/WebPreferencesGtk.cpp:
* UIProcess/qt/TextCheckerQt.cpp:
* UIProcess/qt/WebInspectorProxyQt.cpp:
* UIProcess/win/TextCheckerWin.cpp:
* UIProcess/win/WebContextMenuProxyWin.cpp:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Downloads/cf/DownloadCFNet.cpp:
* WebProcess/Downloads/curl/DownloadCurl.cpp:
* WebProcess/Downloads/mac/DownloadMac.mm:
* WebProcess/Downloads/qt/DownloadQt.cpp:
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
* WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
* WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
* WebProcess/WebCoreSupport/WebDragClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
* WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
* WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
* WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
* WebProcess/WebPage/qt/WebInspectorQt.cpp:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
* WebProcess/gtk/WebProcessGtk.cpp:
* config.h:
* win/WebKit2.vcproj:
2011-02-16 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Anders Carlsson.
notImplemented() should behave identical in WebCore and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54449
Use NotImplemented.h from WebCore. Initialize logging channels.
Remove the WebKit2 concept of notImplemented().
* Platform/gtk/SharedMemoryGtk.cpp:
* Platform/gtk/WorkQueueGtk.cpp:
* Platform/qt/WorkQueueQt.cpp:
* Platform/win/WorkQueueWin.cpp:
* Shared/NotImplemented.h: Removed.
* Shared/Plugins/NPIdentifierData.cpp:
* Shared/Plugins/NPRemoteObjectMap.cpp:
* Shared/Plugins/NPVariantData.cpp:
* Shared/cairo/ShareableBitmapCairo.cpp:
* Shared/gtk/ShareableBitmapGtk.cpp:
* Shared/gtk/WebCoreArgumentCodersGtk.cpp:
* Shared/qt/WebCoreArgumentCodersQt.cpp:
* Shared/win/LayerTreeContextWin.cpp:
* UIProcess/API/qt/qwkpage.cpp:
* UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
* UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
* UIProcess/WebInspectorProxy.cpp:
* UIProcess/gtk/TextCheckerGtk.cpp:
* UIProcess/gtk/WebInspectorGtk.cpp:
* UIProcess/gtk/WebPreferencesGtk.cpp:
* UIProcess/qt/TextCheckerQt.cpp:
* UIProcess/qt/WebInspectorProxyQt.cpp:
* UIProcess/win/TextCheckerWin.cpp:
* UIProcess/win/WebContextMenuProxyWin.cpp:
* WebKit2.pro:
* WebProcess/Downloads/cf/DownloadCFNet.cpp:
* WebProcess/Downloads/curl/DownloadCurl.cpp:
* WebProcess/Downloads/mac/DownloadMac.mm:
* WebProcess/Downloads/qt/DownloadQt.cpp:
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
* WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
* WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
* WebProcess/WebCoreSupport/WebDragClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
* WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
* WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
* WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
* WebProcess/WebPage/qt/WebInspectorQt.cpp:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
* WebProcess/gtk/WebProcessGtk.cpp:
2011-02-21 Timothy Hatcher <timothy@apple.com>
Set and update the window title for the Web Inspector in WebKit2.
https://webkit.org/b/50945
rdar://problem/8762410
Reviewed by Adam Roben.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectedURLChanged): Added. Call platformInspectedURLChanged.
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebInspectorProxy.messages.in: Added InspectedURLChanged.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.
* UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.
* UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::inspectedURLChanged): Call WebInspector::inspectedURLChanged.
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::inspectedURLChanged): Added. Send the InspectedURLChanged message.
* WebProcess/WebPage/WebInspector.h:
2011-02-21 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Can't paste from 3rd party text editor into WebKit2 window.
<rdar://problem/8978624>
* WebProcess/com.apple.WebProcess.sb:
2011-02-21 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Initialize DrawingAreaProxy::m_size
https://bugs.webkit.org/show_bug.cgi?id=54913
This was removed in r76962 since it caused flashes when switching drawing areas due to
entering and exiting composited mode, but since we no longer switch drawing areas we can
put it back.
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
2011-02-21 Adam Roben <aroben@apple.com>
Add some assertions about the state IDs we receive from the web process
Rubber-stamped by Anders Carlsson.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Assert that the state ID the web process sent us is no newer than our own state ID.
2011-02-21 Adam Roben <aroben@apple.com>
Rename DrawingArea[Proxy]Impl's "sequence number" concept to "state ID".
As explained in r79251, DrawingAreaProxyImpl has some state that, when it changes, causes
all operations performed before that state change to become invalid. Currently, this state
consists of a single piece of data: the view's size. Eventually it will encompass more data
(e.g., the backing store we're drawing into; when we start throwing away the backing store
to save memory, our state will have changed, and any operations that were intended for the
old backing store will have become invalid). r79251 effectively transformed
DrawingArea[Proxy]Impl's "sequence number," which incremented every time DrawingAreaImpl
sent DrawingAreaProxyImpl a message, to a "state ID," which only increments when the view's
size changes.
This patch is just a set of simple renames to reflect the transformation that r79251
effected. It should not introduce any changes in behavior. The renames are:
- Messages::DrawingArea::SetSize -> UpdateState
- Messages::DrawingAreaProxy::DidSetSize -> DidUpdateState
- DrawingAreaProxyImpl::m_lastDidSetSizeSequenceNumber -> m_currentStateID
- DrawingAreaProxyImpl::m_isWaitingForDidSetSize -> m_isWaitingForDidUpdateState
- DrawingAreaProxyImpl::waitForAndDispatchDidSetSize -> waitForAndDispatchDidUpdateState
- DrawingAreaImpl::m_inSetSize -> m_inUpdateState
- generateSequenceNumber -> generateStateID
- sequenceNumber -> stateID
Fixes <http://webkit.org/b/54911> DrawingArea[Proxy]Impl's "sequence number" concept should
be renamed to "state ID"
Reviewed by Anders Carlsson.
* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.messages.in:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/DrawingAreaImpl.h:
Performed the renames described above.
2011-02-21 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Roben.
REGRESSION (WebKit2): HTTP requests time out after 60 seconds
https://bugs.webkit.org/show_bug.cgi?id=54755
<rdar://problem/9006592>
* Shared/API/c/WKURLRequest.cpp:
(WKURLRequestSetDefaultTimeoutInterval):
* Shared/API/c/WKURLRequest.h:
Added an API to set a default timeout interval for requests created from URLs. The API
affects both the UI process and requests created internally by the Web process. Requests
created from NSURLRequest or CFURLRequest take timeout from those.
* Shared/WebURLRequest.cpp: (WebKit::WebURLRequest::setDefaultTimeoutInterval):
* Shared/WebURLRequest.h:
Pipe the default timeout interval from WKURLRequest down to actual implementation. Since
WebURLRequest is currently implemented with WebCore::ResourceRequest, it automatically respects
NSURLRequest default timeout interval.
* UIProcess/WebProcessManager.cpp: (WebKit::WebProcessManager::getAllWebProcessContexts):
* UIProcess/WebProcessManager.h:
Added a way to enumerate all contexts running in separate processes.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::setDefaultRequestTimeoutInterval):
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setDefaultRequestTimeoutInterval):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
Use UI process default timeout interval in separate process contexts, too.
2011-02-18 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins): Call through to cFURLCacheHostNames, and add
create SecurityOrigin's for them and add them to the set of SecurityOrigins with cache.
(WebKit::WebResourceCacheManager::clearCacheForOrigin): Call through to clear the CFURLCache for
the origin's hostname.
* WebProcess/ResourceCache/WebResourceCacheManager.h:
* WebProcess/ResourceCache/cf: Added.
* WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp: Added.
(WebKit::WebResourceCacheManager::cfURLCacheHostNames): Call through to WebKitSystemInterface.
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames): Ditto.
* win/WebKit2.vcproj: Added new file.
* WebKit2.xcodeproj/project.pbxproj: Ditto.
2011-02-21 Adam Roben <aroben@apple.com>
Move control of the sequence number from DrawingAreaImpl to DrawingAreaProxyImpl
DrawingAreaProxyImpl has some state that, when it changes, causes all operations performed
before that state change to become invalid. When painting, we need to have performed at
least one Update for the most recent state; otherwise, we'll be painting old/incorrect bits
into the view.
Currently, this state consists of a single piece of data: the view's size. Whenever the
state (i.e., size) changes, we tell the web process via the SetSize message, and the web
process lets us know that it has updated to match the new state (i.e., size) via the
DidSetSize message.
When it's time to paint, if we're waiting for the web process to update to match our current
state (i.e., size), we block for a little while hoping to receive a DidSetSize message so
that we can paint up-to-date bits into the window. This can cause us to receive messages
out-of-order; the DidSetSize message will be processed immediately, and any messages that
were sent before the DidSetSize message will be processed later. Since the messages from
before the DidSetSize message correspond to an old state (i.e., size), they are no longer
useful (e.g., they contain bits of the page that are drawn at the wrong size/location), so
we discard them.
The way we identify and discard these messages is by keeping track of a sequence number.
Currently, DrawingAreaImpl sends a monotonically-increasing sequence number to
DrawingAreaProxyImpl with every message. Whenever DrawingAreaProxyImpl receives a DidSetSize
message, it records the sequence number that came along with it. If we then later receive
any messages that have a lower sequence number, we know they correspond to an old state
(i.e., size) and can discard them.
This patch moves control of the sequence number to DrawingAreaProxyImpl.
DrawingAreaProxyImpl now sends a monotonically-increasing sequence number in the SetSize
message. DrawingAreaImpl records this sequence number when it receives the SetSize message,
and sends it back to DrawingAreaProxyImpl in every message. Otherwise the logic is the same
as before.
This should cause no changes in behavior, but will allow DrawingAreaProxyImpl to request a
full backing store update (by incrementing the sequence number) at times other than when the
view's size changes (e.g., after it has thrown away its backing store in order to save
memory).
Fixes <http://webkit.org/b/54907> DrawingAreaProxyImpl should tell DrawingAreaImpl what
sequence number to use
Reviewed by Anders Carlsson.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::generateSequenceNumber): Moved here from DrawingAreaImpl.cpp.
(WebKit::DrawingAreaProxyImpl::sendSetSize): Changed to pass a new sequence number in the
SetSize message.
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidSetSize): Added a FIXME about a
potential improvement.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setSize): Updated to match the message's new parameters.
* WebProcess/WebPage/DrawingArea.messages.in: Added a sequenceNumber parameter to SetSize.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_sequenceNumber.
(WebKit::DrawingAreaImpl::setSize): Record the new sequence number from the UI process.
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
Send m_sequenceNumber, instead of a new sequence number, back to the UI process.
* WebProcess/WebPage/DrawingAreaImpl.h: Added m_sequenceNumber, updated setSize function to
match the base class.
2011-02-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 54894 - Make inheritance structure described by ClassInfo match C++ class hierarchy.
The ClassInfo objects describe an inheritance hierarchy, with each ClassInfo instance
containing a pointer to its parent class. These links should reflect the inheritance
hierarchy of C++ classes below JSObject. For the large part it does, but in some cases
entries in the C++ hierarchy are skipped over. This presently likely doesn't matter,
since intervening C++ classes may not have ClassInfo - but would be a potential bug
were ClassInfo were to be added.
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
2011-02-21 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement WorkQueue::sheduleWorkAfterDelay
https://bugs.webkit.org/show_bug.cgi?id=54878
* Platform/qt/WorkQueueQt.cpp:
(WorkQueue::scheduleWorkAfterDelay):
2011-02-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add WebResourceCacheDataManager to the compilation after r78848
https://bugs.webkit.org/show_bug.cgi?id=54732
Added resource cache manager API to GTK+ compilation after r78848.
* GNUmakefile.am:
2011-02-20 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Crash in WebProcess at com.apple.WebCore: WebCore::Page::goToItem + 46
<rdar://problem/8942726>
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
Defend agains null HistoryItems.
2011-02-20 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej Stachowiak.
Crash when a plug-in requests a javascript: url that destroys the plug-in
https://bugs.webkit.org/show_bug.cgi?id=54837
<rdar://problem/9005475>
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::destroy):
Null out m_pluginController.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performJavaScriptURLRequest):
Don't access the frame through m_pluginElement since it will be nulled out
when the plug-in is destroyed.
2011-02-20 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fix another crash when a plug-in is destroyed when evaluating JavaScript
https://bugs.webkit.org/show_bug.cgi?id=54834
<rdar://problem/9005475>
This contains three separate fixes:
- In unprotectPluginFromDestruction we can't just destroy the plug-in once
the count reaches zero, because the plug-in might still have code executing
on the stack. To fix this we use a zero-delay timer to defer destruction
of the plug-in.
- Trying to get the NPObject for the window using NPN_GetValue would return
NPERR_NO_ERROR, even if the returned NPObject was null. Fix this to return
NPERR_GENERIC_ERROR instead.
- Protect the plug-in from destruction anytime an NPAPI call that sends a
synchronous IPC message is made.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::destroy):
(WebKit::PluginControllerProxy::unprotectPluginFromDestruction):
* PluginProcess/PluginControllerProxy.h:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::PluginDestructionProtector::PluginDestructionProtector):
(WebKit::NPN_GetValue):
(WebKit::NPN_Evaluate):
(WebKit::NPN_GetProperty):
(WebKit::NPN_SetProperty):
(WebKit::NPN_RemoveProperty):
(WebKit::NPN_HasProperty):
(WebKit::NPN_HasMethod):
(WebKit::NPN_Enumerate):
(WebKit::NPN_Construct):
(WebKit::NPN_GetValueForURL):
(WebKit::NPN_SetValueForURL):
2011-02-19 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add phase in addition to momentumPhase to platform wheel events
Part of <rdar://problem/8945362>
Rename existing phase to momentumPhase.
* Shared/WebEvent.h:
(WebKit::WebWheelEvent::momentumPhase):
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
* Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
* Shared/mac/WebEventFactory.mm:
(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
2011-02-19 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Crash when trying to take a snapshot of an uninitialized plug-in
https://bugs.webkit.org/show_bug.cgi?id=54812
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::notifyWidget):
Don't try to create a snapshot of the plug-in if it hasn't been initialized.
2011-02-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Bug 54786 - Devirtualize JSCell::classInfo()
Instead of making a virtual function call, add a pointer to the ClassInfo
onto Structure.
This removes a virtual function call, and paves the way towards removing all
the createStructure methods, and StructureFlags/AnonymousSlotCount properties
(these should be able to move onto ClassInfo).
Calls to Structure::create must now pass a pointer to the ClassInfo for the
structure. All objects now have a ClassInfo pointer, non-object cell types
still do not.
Changes are most mechanical, involving three steps:
* Remove virtual classInfo() methods.
* Add &s_info parameter to calls to Structure::create.
* Rename ClassInfo static members on classes from 'info' to 's_info',
for consistency.
* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::JSNPMethod):
* WebProcess/Plugins/Netscape/JSNPMethod.h:
(WebKit::JSNPMethod::createStructure):
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::JSNPObject):
* WebProcess/Plugins/Netscape/JSNPObject.h:
(WebKit::JSNPObject::createStructure):
2011-02-19 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Rename performLookupAtCurrentMouseLocation to performDictionaryLookupAtCurrentMouseLocation
* UIProcess/API/mac/WKView.mm:
(-[WKView performDictionaryLookupAtCurrentMouseLocation]):
* UIProcess/API/mac/WKViewPrivate.h:
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Add a FrameLoaderClient callback for whether to stop loading before goToItem.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
2011-02-18 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Real fix for <rdar://problem/9025723> CrashTracer: [USER]
1 crash in WebProcess at com.apple.WebKit2:
WebKit::WebPage::didChangeScrollOffsetForMainFrame + 31
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didChangeScrollOffset):
Add null check for the FrameView. This function can be called when the
FrameView is being torn down during a transition to a new FrameView.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeScrollOffsetForMainFrame):
Revert last attempt.
2011-02-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Hang trying to load nytimes.com with Flash installed
<rdar://problem/9018113>
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncMessage):
Call beginWaitForSyncReply() before sending the message. Otherwise, in some cases we could
have gotten back a synchronous request before calling beginWaitForSyncReply(), and then we wouldn't
process it correctly. (Which would lead to the hang).
2011-02-18 Simon Fraser <simon.fraser@apple.com>
Reviewed by Kevin Decker.
<rdar://problem/9021296> Some plug-ins are the wrong size after zooming
Use the same frame/bounds adjustment that we use for NSView-based
plugins in WebKit2, which allows plug-ins and their snapshots to
render with the correct size after scaling.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setBoundsSize):
(WebKit::PluginView::viewGeometryDidChange):
(WebKit::PluginView::clipRectInWindowCoordinates):
* WebProcess/Plugins/PluginView.h:
2011-02-18 Beth Dakin <bdakin@apple.com>
Rubber-stamped by Adele Peterson.
Fix for <rdar://problem/9025723> CrashTracer: [USER]
1 crash in WebProcess at com.apple.WebKit2:
WebKit::WebPage::didChangeScrollOffsetForMainFrame + 31
Simple null-check.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeScrollOffsetForMainFrame):
2011-02-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Tiled backing store area is too big.
Error in area calculcation causes size of backing store
up to 8 times bigger than viewport with default multipliers.
https://bugs.webkit.org/show_bug.cgi?id=54587
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::calculateKeepRect):
(WebKit::TiledDrawingAreaProxy::calculateCoverRect):
2011-02-18 John Sullivan <sullivan@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/9026169>
https://bugs.webkit.org/show_bug.cgi?id=54780
pendingAPIRequestURL isn't updated for WKPageGoToBackForwardListItem
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::goToBackForwardItem):
Update the pending API URL.
2011-02-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Accelerated content fades in when using a layer backed WKView
<rdar://problem/9021586>
* UIProcess/API/mac/WKView.mm:
(-[WKView _enterAcceleratedCompositingMode:]):
Make a new nested CATransaction and disable animations when adding the layer
hosting subview. This avoids an implicit fade animation that would otherwise occur.
2011-02-18 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Plugin snapshot location is wrong for subframes
https://bugs.webkit.org/show_bug.cgi?id=54776
Only change the CTM to the way that the plugin expects it
when painting the plugin, not when drawing the snapshot.
This fixes the snapshot location when painting flattened
frames.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint):
2011-02-18 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Implement NetscapePlugin::pluginComplexTextInputIdentifier
https://bugs.webkit.org/show_bug.cgi?id=54770
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::pluginComplexTextInputIdentifier):
2011-02-18 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Add the ability to ask the WKPage if the main frame is pinned
to the right or left hand side.
Part of <rdar://problem/9017043>.
* UIProcess/API/C/WKPage.cpp:
(WKPageIsPinnedToLeftSide):
(WKPageIsPinnedToRightSide):
* UIProcess/API/C/WKPage.h:
Add new API calls.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::didChangeScrollOffsetPinningForMainFrame):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::isPinnedToLeftSide):
(WebKit::WebPageProxy::isPinnedToRightSide):
Initialize, reset and update the pinned state.
* UIProcess/WebPageProxy.messages.in:
Add message to update the pinned state.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didChangeScrollOffset):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::didChangeScrollOffsetForMainFrame):
* WebProcess/WebPage/WebPage.h:
Cache the pinned state, and only update the UIProcess when it
changes.
2011-02-18 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Fix assertion in SharedMemory::create when trying to snapshot 0x0 plug-in
https://bugs.webkit.org/show_bug.cgi?id=54768
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::snapshot):
Don't try to create a handle from a null ShareableBitmap.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::snapshot):
Check for a zero sized plug-in before trying to create a snapshot.
2011-02-18 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
WKView flashes when entering/exiting compositing mode
https://bugs.webkit.org/show_bug.cgi?id=54695
<rdar://problem/9011554>
* UIProcess/API/mac/WKView.mm:
(-[WKView _exitAcceleratedCompositingMode]):
Remove the layer hosting view before clearing out its layer, otherwise we can get
white flashes when exiting accelerated compositing mode.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
When entering accelerated compositing mode, we want to defer sending the message
until we've actually committed the layer tree and pushed all changes over to the
UI process.
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
Tell the layer tree host to force a repaint. This will ensure that all layer tree
changes are pushed over to the UI process. When that is done, send the new layer tree
context over to the UI process.
(WebKit::DrawingAreaImpl::setRootCompositingLayer):
When exiting compositing mode in response to a didSetSize, we want to exit accelerated
compositing mode right away to avoid flashes. This is safe since we've laid out the page
already so we won't end up reentering setRootCompositingLayer.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
Tell the layer tree host to notify us when the next layer tree flush happened, so we can
let the UI process know. If we're entering accelerated compositing mode in response to a
SetSize message, the new layer tree context will be passed in the DidSetSize message.
* WebProcess/WebPage/DrawingAreaImpl.h:
Add layerHostDidFlushLayers.
* WebProcess/WebPage/LayerTreeHost.h:
Add setShouldNotifyAfterNextScheduledLayerFlush.
* WebProcess/WebPage/mac/LayerTreeHostMac.h:
Add a m_notifyAfterScheduledLayerFlush flag.
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::LayerTreeHostMac):
Initialize m_notifyAfterScheduledLayerFlush to false.
(WebKit::LayerTreeHostMac::setShouldNotifyAfterNextScheduledLayerFlush):
Set m_notifyAfterScheduledLayerFlush to true.
(WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback):
If m_notifyAfterScheduledLayerFlush is true, call DrawingAreaImpl::layerHostDidFlushLayers.
2011-02-18 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adele Peterson.
REGRESSION (WebKit2): Wrong frame printed on tivofaq.com
https://bugs.webkit.org/show_bug.cgi?id=54677
<rdar://problem/8994133>
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::area): Use visible frame bounds.
(WebKit::findLargestFrameInFrameSet): Added a comment explaining what we're up to here.
WebKit2 shouldn't be making policy decisions for the client, but it gets dangerously close
to that. We used to expose the same as WK1 API though.
2011-02-18 Balazs Kelemen <kbalazs@webkit.org>
Unreviwed.
Remove CleanupHandler since we do not use it anymore.
* Shared/qt/CleanupHandler.cpp: Removed.
* Shared/qt/CleanupHandler.h: Removed.
2011-02-18 Alejandro G. Castro <alex@igalia.com>
Fix GTK build by fixing signature of platformPaint(), required after r78956.
* WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
(WebKit::NetscapePlugin::platformPaint):
2011-02-17 Dan Bernstein <mitz@apple.com>
LLVM Compiler build fix.
* UIProcess/WebResourceCacheManagerProxy.h:
* WebProcess/ResourceCache/WebResourceCacheManager.h:
2011-02-17 Simon Fraser <simon.fraser@apple.com>
Fix Windows and Qt builds by fixing signature of platformPaint().
* WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
(WebKit::NetscapePlugin::platformPaint):
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformPaint):
2011-02-17 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
WebKit2 snapshots don't show plug-ins
https://bugs.webkit.org/show_bug.cgi?id=54716
Fix WebKit2 plug-ins to do a software paint for
snapshotting.
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::snapshot): Respond to the snapshot
message by getting a sharable bitmap from the plugin, and returning
a handle to it in the reply.
* PluginProcess/PluginControllerProxy.messages.in: Add the snapshot
message.
* Shared/Plugins/PluginQuirks.h:
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::determineQuirks): Add a quirk for the
ability to be snapshotted, which we only set for Flash at the moment.
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::snapshot): Create a shareable bitmap, and
paint into it.
(WebKit::NetscapePlugin::supportsSnapshotting): Test the quirk.
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPaint): Allow the paint to happen
if we're snapshotting, even when using the CoreAnimation drawing
model.
* WebProcess/Plugins/Plugin.h: New snapshot method.
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::snapshot): Send a sync message to the plugin process,
asking for a snapshot in a shareble bitmap.
* WebProcess/Plugins/PluginView.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint): Use the snapshot if we have one, to avoid
calling into the plugin to draw, which may run script.
(WebKit::PluginView::notifyWidget): Generate the snapshot before
a flattening paint, and throw it away after.
2011-02-17 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
WebKit2: The CFNetwork Cache should be shared between the UI Process and the Web Process on
Windows.
https://bugs.webkit.org/show_bug.cgi?id=54683
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
Make sure to remove the ending slash, as CFNetwork does not recognize the directory with
that slash.
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
Create a cache using the path, disk capacity, and memory capacity and set it as default.
2011-02-17 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Web and/or plug-in process crashes when NPN_Evaluate destroys the plug-in
https://bugs.webkit.org/show_bug.cgi?id=54686
<rdar://problem/9013384>
This patch fixes two bugs with a plug-in calling NPN_Evaluate to destroy itself:
- The PluginProxy object would be destroyed in the middle of PluginProxy::evaluate.
This would cause the web process to crash.
- The PluginControllerProxy would call NPP_Destroy while the plug-in was busy running
code. This would cause the plug-in process to crash.
To fix this, we add protectPluginFromDestruction/unprotectPluginFromDestruction to
PluginControllerProxy and use it to defer calling destroy() in the plug-in process,
and defer actually destroying the plug-in in the web process.
https://bugs.webkit.org/show_bug.cgi?id=54171 tracks adding a test for this.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::destroy):
(WebKit::PluginControllerProxy::evaluate):
(WebKit::PluginControllerProxy::protectPluginFromDestruction):
(WebKit::PluginControllerProxy::unprotectPluginFromDestruction):
* PluginProcess/PluginControllerProxy.h:
(WebKit::PluginControllerProxy::asPluginController):
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::destroyPluginControllerProxy):
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
* PluginProcess/WebProcessConnection.h:
(WebKit::WebProcessConnection::connection):
* WebProcess/Plugins/PluginController.h:
(WebKit::PluginController::PluginDestructionProtector::PluginDestructionProtector):
(WebKit::PluginController::PluginDestructionProtector::~PluginDestructionProtector):
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::evaluate):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::protectPluginFromDestruction):
(WebKit::PluginView::unprotectPluginFromDestruction):
* WebProcess/Plugins/PluginView.h:
2011-02-17 Sam Weinig <sam@webkit.org>
Build fix.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
2011-02-17 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
WebKit2: Support Dictionary popup
<rdar://problem/7660670>
* Shared/TextInfo.cpp: Added.
(WebKit::TextInfo::encode):
(WebKit::TextInfo::decode):
* Shared/TextInfo.h: Added.
(WebKit::TextInfo::TextInfo):
Add class to represent the location and style of a run of text.
* UIProcess/PageClient.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
Invoke the dictionary popup.
* UIProcess/API/mac/WKView.mm:
(-[WKView performLookupAtCurrentMouseLocation]):
Tell the WebProcess to get get the text under the mouse and cause
the dictionary popup to appear.
* UIProcess/API/mac/WKViewPrivate.h:
Add performLookupAtCurrentMouseLocation.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
Pipe messages through.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::characterRangeAtPoint): Fix to return PassRefPtr
and not potentially stale pointers.
(WebKit::WebPage::characterIndexForPoint):
Change to use a RefPtr.
(WebKit::WebPage::performDictionaryLookupAtLocation):
Add simple heuristic to get the word at the current point (or the current selection
if it is at that point) and grab the style of the word to send the UIProcess.
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add new files.
2011-02-17 Brian Weinstein <bweinstein@apple.com>
Qt build fix.
* WebKit2.pro: Update after renaming of MemoryCache to ResourceCache.
2011-02-17 Brian Weinstein <bweinstein@apple.com>
Mac build fix.
* WebKit2.xcodeproj/project.pbxproj: Use relative to group instead of absolute paths. Not everyone's home
directory is /Users/brian_weinstein.
2011-02-16 Brian Weinstein <bweinstein@apple.com>
Reviewed by Brady Eidson.
WebKit2: Need a way to manage the WebCore Cache
https://bugs.webkit.org/show_bug.cgi?id=54501
Implement a WebKit2 API to manage the WebCore memory cache. This API exposes three functions:
1) A method to get a list of all security origins that have entries in the WebCore memory cache.
2) A method to remove all entries in the WebCore memory cache from a SecurityOrigin.
3) A method to remove all entries from the WebCore memory cache.
* Platform/CoreIPC/MessageID.h: Add two new MessageClasses.
* Shared/API/c/WKBase.h:
* Shared/APIObject.h: Add a CacheManager type.
* Shared/WebSecurityOrigin.h: Typedef WKCacheManagerRef.
(WebKit::WebSecurityOrigin::createFromString): Creates a WebCore::SecurityOrigin using
SecurityOrigin::createFromString.
(WebKit::WebSecurityOrigin::toString): Calls through to SecurityOrigin::toString.
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKCacheManager.cpp: Added.
(WKCacheManagerGetTypeID): Returns the WebResourceCacheManagerProxy type.
(WKCacheManagerGetCacheOrigins): Calls through to WebResourceCacheManagerProxy::getCacheOrigins.
(callGetCacheOriginsBlockBlockAndDispose):
(WKCacheManagerGetCacheOrigins_b):
(WKCacheManagerDeleteCacheForOrigin): Calls through to WebResourceCacheManagerProxy::deleteCacheForOrigin.
(WKCacheManagerDeleteAllCache): Calls through to WebResourceCacheManagerProxy::deleteAllCache.
* UIProcess/API/C/WKCacheManager.h: Added.
* UIProcess/API/C/WKContext.cpp:
(WKContextGetCacheManager): Calls to get the WebResourceCacheManagerProxy.
* UIProcess/API/C/WKContext.h:
* UIProcess/WebResourceCacheManagerProxy.cpp: Added.
(WebKit::WebResourceCacheManagerProxy::create): Calls through to the constructor.
(WebKit::WebResourceCacheManagerProxy::WebResourceCacheManagerProxy): Initialize the m_webContext variable.
(WebKit::WebResourceCacheManagerProxy::~WebResourceCacheManagerProxy):
(WebKit::WebResourceCacheManagerProxy::invalidate): Invalidate the callback map.
(WebKit::WebResourceCacheManagerProxy::getCacheOrigins): Call through to the web process to get the cache
origins.
(WebKit::WebResourceCacheManagerProxy::didGetCacheOrigins): Call the callback.
(WebKit::WebResourceCacheManagerProxy::deleteCacheForOrigin): Call through to the web process to delete cache
for the given origin.
(WebKit::WebResourceCacheManagerProxy::deleteAllCache): Call through to the web process to delete all of the cache.
* UIProcess/WebResourceCacheManagerProxy.h: Added.
(WebKit::WebResourceCacheManagerProxy::clearContext):
(WebKit::WebResourceCacheManagerProxy::type):
* UIProcess/WebResourceCacheManagerProxy.messages.in: Added.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Initialize new member variable.
(WebKit::WebContext::~WebContext): Invalidates new member variable.
(WebKit::WebContext::didReceiveMessage): Passes cache messages to the cache manager.
* UIProcess/WebContext.h:
(WebKit::WebContext::cacheManagerProxy):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage): Add a new message class.
* WebProcess/ResourceCache/WebResourceCacheManager.cpp: Added.
(WebKit::WebResourceCacheManager::shared):
(WebKit::WebResourceCacheManager::WebResourceCacheManager):
(WebKit::WebResourceCacheManager::~WebResourceCacheManager):
(WebKit::WebResourceCacheManager::didReceiveMessage): Calls through to didReceiveWebResourceCacheManagerMessage.
(WebKit::WebResourceCacheManager::getCacheOrigins): Gets a list of origins with cache entries from the memory
cache, and puts them into a vector to send to the UI process.
(WebKit::WebResourceCacheManager::deleteCacheForOrigin): Calls through to ResourceCache to delete all cache entries
from a given origin.
(WebKit::WebResourceCacheManager::deleteAllCache):
* WebProcess/ResourceCache/WebResourceCacheManager.h: Added.
* WebProcess/ResourceCache/WebResourceCacheManager.messages.in: Added.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
(WebKit::WebProcess::clearResourceCaches): Tell the memory cache to evict its resources. This was done on WebKit1,
but not WebKit2.
* WebProcess/WebProcess.h:
* WebKit2.xcodeproj/project.pbxproj: Added new files.
* win/WebKit2.vcproj: Ditto.
* win/WebKit2Common.vsprops: Added new include directory.
* win/WebKit2Generated.make: Added new header.
2011-02-16 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=54244
Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
been changed as well.
In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
still have a precise floating point position.
Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
be rounding justification spacing in their font code.
Many layout test results change on Mac, since rounding hacks were used there and are now gone.
* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Adam Roben.
HTML5 <details> and <summary>: localized text
https://bugs.webkit.org/show_bug.cgi?id=54260
The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
provide the default label to be used by a <details> tag that has no <summary> child.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::defaultDetailsSummaryText):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
2011-02-17 Adam Roben <aroben@apple.com>
Make sure layout is up-to-date before rendering the layer tree in DrawingAreaImpl
Fixes <http://webkit.org/b/54646> <rdar://problem/9016889> Assertion failure in
FrameView::paintContents when calling WKPageForceRepaint on a page that uses accelerated
compositing
Reviewed by Anders Carlsson.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint): Lay out before we do anything else.
2011-02-17 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add WKPluginSiteDataManager.cpp compilation after r78647
https://bugs.webkit.org/show_bug.cgi?id=54564
* GNUmakefile.am: Added files to compilation.
* Shared/Plugins/Netscape/NetscapePluginModule.h: used
npruntime_internal.h in the include to avoid problems with X
types.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setAlwaysUsesComplexTextCodePath): fixed
ambiguous reference to Font caused by the X headers required by
the plugins.
2011-02-16 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Allow acceleratesDrawing for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54511
Plumb through preference for accelerated drawing.
If accelerated drawing is enabled, keep the DrawingAreaImpl in
accelerated compositing mode.
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAcceleratedDrawingEnabled):
(WKPreferencesGetAcceleratedDrawingEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
(WebKit::DrawingAreaImpl::setRootCompositingLayer):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
2011-02-16 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] White screen is displayed when tiled backing store is enabled in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=54583
Make sure to invalidate all the tiles, including the last one.
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::invalidate):
2011-02-16 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Tiles are not created for webkit2 after r77286.
https://bugs.webkit.org/show_bug.cgi?id=54577
When using the default tile size of 1024x1024, only one tile is created.
Make sure to create this tile by undoing what seems to be a typo in r77286.
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::paint):
(WebKit::TiledDrawingAreaProxy::createTiles):
== Rolled over to ChangeLog-2011-02-16 ==
|