summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAdam Gross <grossag@vmware.com>2019-11-25 16:17:04 (GMT)
committerAdam Gross <grossag@vmware.com>2019-11-25 16:17:04 (GMT)
commit14c9be3e3d923bafe6c2f9f7524b03b55cfecaf0 (patch)
tree65753f7f295e04a462391349e4ec6563073376ed
parent6b48b335179b246b0a3f7fb5ab228c0e0cc1da9f (diff)
downloadSCons-14c9be3e3d923bafe6c2f9f7524b03b55cfecaf0.zip
SCons-14c9be3e3d923bafe6c2f9f7524b03b55cfecaf0.tar.gz
SCons-14c9be3e3d923bafe6c2f9f7524b03b55cfecaf0.tar.bz2
Fix some existing flake8 validation issues in PythonTests.py
-rw-r--r--src/engine/SCons/Node/PythonTests.py12
1 files changed, 7 insertions, 5 deletions
diff --git a/src/engine/SCons/Node/PythonTests.py b/src/engine/SCons/Node/PythonTests.py
index 51345e7..e0dd885 100644
--- a/src/engine/SCons/Node/PythonTests.py
+++ b/src/engine/SCons/Node/PythonTests.py
@@ -23,14 +23,13 @@
__revision__ = "__FILE__ __REVISION__ __DATE__ __DEVELOPER__"
-import sys
import unittest
import SCons.Errors
import SCons.Node.Python
-class ValueTestCase(unittest.TestCase):
+class ValueTestCase(unittest.TestCase):
def test_Value(self):
"""Test creating a Value() object
"""
@@ -42,7 +41,7 @@ class ValueTestCase(unittest.TestCase):
assert v2.value == value2, v2.value
assert v2.value is value2, v2.value
- assert not v1 is v2
+ assert v1 is not v2
assert v1.value == v2.value
v3 = SCons.Node.Python.Value('c', 'cb')
@@ -98,28 +97,31 @@ class ValueTestCase(unittest.TestCase):
csig = v3.get_csig(None)
assert csig == 'None', csig
+
class ValueNodeInfoTestCase(unittest.TestCase):
def test___init__(self):
"""Test ValueNodeInfo initialization"""
vvv = SCons.Node.Python.Value('vvv')
ni = SCons.Node.Python.ValueNodeInfo()
+
class ValueBuildInfoTestCase(unittest.TestCase):
def test___init__(self):
"""Test ValueBuildInfo initialization"""
vvv = SCons.Node.Python.Value('vvv')
bi = SCons.Node.Python.ValueBuildInfo()
+
class ValueMemoTestCase(unittest.TestCase):
def test___init__(self):
"""Test memoization"""
value1 = SCons.Node.Python.ValueWithMemo('vvv')
value2 = SCons.Node.Python.ValueWithMemo('vvv')
- assert value1 == value2
+ assert value1 is value2
ni = SCons.Node.Python.ValueNodeInfo()
value3 = ni.str_to_node('vvv')
- assert value1 == value3
+ assert value1 is value3
if __name__ == "__main__":
unittest.main()