diff options
| author | Mats Wichmann <mats@linux.com> | 2024-07-21 16:36:01 (GMT) |
|---|---|---|
| committer | Mats Wichmann <mats@linux.com> | 2024-08-19 15:38:29 (GMT) |
| commit | 84f4364d7c1ac283c6cb19f6b3bd53a0dd42ec2d (patch) | |
| tree | 8c0a81a2c157658fc57b8c93487a2923952ef956 /RELEASE.txt | |
| parent | 876bb0691bba2e6086ac7c05caf1fb88fbb1cf43 (diff) | |
| download | SCons-84f4364d7c1ac283c6cb19f6b3bd53a0dd42ec2d.zip SCons-84f4364d7c1ac283c6cb19f6b3bd53a0dd42ec2d.tar.gz SCons-84f4364d7c1ac283c6cb19f6b3bd53a0dd42ec2d.tar.bz2 | |
Fix bug with unique adds and delete_existing
AppendUnique and PrependUnique, when called with delete_existing true, had
a small logic flaw: it might remove an existing value if the value to be
added is a scalar (string, most likely) and there was a substring match.
The code needs to do an equality test, not a membership test.
Unit tests updated and got some reformatting, plus dropped a duplicate
definition of reserved_variables.
Signed-off-by: Mats Wichmann <mats@linux.com>
Diffstat (limited to 'RELEASE.txt')
| -rw-r--r-- | RELEASE.txt | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/RELEASE.txt b/RELEASE.txt index 2efc001..296755f 100644 --- a/RELEASE.txt +++ b/RELEASE.txt @@ -46,6 +46,8 @@ FIXES to be avaiable. `BoolVariable`, `EnumVariable`, `ListVariable`, `PackageVariable` and `PathVariable` are added to `__all__`, so this form of import should now work again. +- Fix a problem with AppendUnique and PrependUnique where a value could + be erroneously removed due to a substring match. IMPROVEMENTS ------------ |