diff options
author | Mats Wichmann <mats@linux.com> | 2018-08-26 15:10:58 (GMT) |
---|---|---|
committer | Mats Wichmann <mats@linux.com> | 2018-10-03 18:44:45 (GMT) |
commit | 6bb0f67833cd198253dcf94342da7e792aaf9a55 (patch) | |
tree | 4b88fa5c963dee6cf9ba33eabaa3f53e937f8086 /src/engine/SCons/Action.py | |
parent | ab7b1758d760159db1665059f464517d039ac6a4 (diff) | |
download | SCons-6bb0f67833cd198253dcf94342da7e792aaf9a55.zip SCons-6bb0f67833cd198253dcf94342da7e792aaf9a55.tar.gz SCons-6bb0f67833cd198253dcf94342da7e792aaf9a55.tar.bz2 |
A few syntax cleanups
Suggested by PyCharm. Includes three "real" changes:
1. src/engine/SCons/Node/__init__.py has a print statement in a function
which references 'self', but there is no 'self' defined (it is not
a method in a class). Guessing it should have been 'node'.
2. src/engine/SCons/Environment.py makes a call using 'kwbd' which is not
defined, looks like a copy-paste error and should be 'bd'.
3. src/engine/SCons/Tool/JavaCommon.py splits 'file', which is not
defined, was evidently supposed to be 'fn'.
These should be double-checked.
The rest are purely syntax: whitespace, dropping trailing semicolons,
using "is" to test for None, simplifying comparisons, normalizing
docstring commenting ("always triple double quotes"), unneeded
backslashes.
Signed-off-by: Mats Wichmann <mats@linux.com>
Diffstat (limited to 'src/engine/SCons/Action.py')
-rw-r--r-- | src/engine/SCons/Action.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/engine/SCons/Action.py b/src/engine/SCons/Action.py index 9a3888b..78fb7d0 100644 --- a/src/engine/SCons/Action.py +++ b/src/engine/SCons/Action.py @@ -843,8 +843,8 @@ class CommandAction(_ActionAction): _ActionAction.__init__(self, **kw) if is_List(cmd): if [c for c in cmd if is_List(c)]: - raise TypeError("CommandAction should be given only " \ - "a single command") + raise TypeError("CommandAction should be given only " + "a single command") self.cmd_list = cmd def __str__(self): |