summaryrefslogtreecommitdiffstats
path: root/src/engine/SCons
diff options
context:
space:
mode:
authorAdam Gross <grossag@vmware.com>2020-01-15 14:35:14 (GMT)
committerAdam Gross <grossag@vmware.com>2020-01-15 14:35:14 (GMT)
commit1f0cd4eac841791d9c0f16f111e627779e566f40 (patch)
treeae1bf5d77353e754bd5c7679a13c2785f8939095 /src/engine/SCons
parent50154d0eb7afc564cb13e47c7524fcf2f6ff0450 (diff)
downloadSCons-1f0cd4eac841791d9c0f16f111e627779e566f40.zip
SCons-1f0cd4eac841791d9c0f16f111e627779e566f40.tar.gz
SCons-1f0cd4eac841791d9c0f16f111e627779e566f40.tar.bz2
Plumb through name in ValueWithMemo
Diffstat (limited to 'src/engine/SCons')
-rw-r--r--src/engine/SCons/EnvironmentTests.py4
-rw-r--r--src/engine/SCons/Node/Python.py2
-rw-r--r--src/engine/SCons/Node/PythonTests.py1
3 files changed, 6 insertions, 1 deletions
diff --git a/src/engine/SCons/EnvironmentTests.py b/src/engine/SCons/EnvironmentTests.py
index f3779c7..0cb8418 100644
--- a/src/engine/SCons/EnvironmentTests.py
+++ b/src/engine/SCons/EnvironmentTests.py
@@ -3289,6 +3289,10 @@ def generate(env):
v3 = env.Value('c', 'build-c')
assert v3.value == 'c', v3.value
+ v4 = env.Value(b'\x00\x0F', name='name')
+ assert v4.value == b'\x00\x0F', v4.value
+ assert v4.name == 'name', v4.name
+
def test_Environment_global_variable(self):
"""Test setting Environment variable to an Environment.Base subclass"""
diff --git a/src/engine/SCons/Node/Python.py b/src/engine/SCons/Node/Python.py
index 8437385..d26c185 100644
--- a/src/engine/SCons/Node/Python.py
+++ b/src/engine/SCons/Node/Python.py
@@ -200,7 +200,7 @@ def ValueWithMemo(value, built_value=None, name=None):
try:
return _memo_lookup_map[memo_lookup_key]
except KeyError:
- v = Value(value)
+ v = Value(value, built_value, name)
_memo_lookup_map[memo_lookup_key] = v
return v
diff --git a/src/engine/SCons/Node/PythonTests.py b/src/engine/SCons/Node/PythonTests.py
index 302bb59..6db07ab 100644
--- a/src/engine/SCons/Node/PythonTests.py
+++ b/src/engine/SCons/Node/PythonTests.py
@@ -67,6 +67,7 @@ class ValueTestCase(unittest.TestCase):
v3 = SCons.Node.Python.Value(b'\x00\x0F', name='name')
v3.executor = fake_executor()
v3.build()
+ assert v3.name == 'name', v3.name
assert v3.built_value == 'faked', v3.built_value
def test_read(self):