summaryrefslogtreecommitdiffstats
path: root/src/engine/SCons
diff options
context:
space:
mode:
authorAdam Gross <grossag@vmware.com>2020-01-10 15:26:46 (GMT)
committerAdam Gross <grossag@vmware.com>2020-01-10 15:26:46 (GMT)
commit589b0a4a29353df1d1fe4177eae578fc6754f7ac (patch)
treedda3cdf00d2901ca60926ef47507a3c2aa3d2dc3 /src/engine/SCons
parentd5ddf6ddf5c9a061ac0173e8887ce6e3e6bd5a30 (diff)
downloadSCons-589b0a4a29353df1d1fe4177eae578fc6754f7ac.zip
SCons-589b0a4a29353df1d1fe4177eae578fc6754f7ac.tar.gz
SCons-589b0a4a29353df1d1fe4177eae578fc6754f7ac.tar.bz2
Update and improve tests
This change integrates various review feedback, including: 1. Validates the result of Dir.get_contents() in PythonTests.py. 2. Adds a functional test for having value as a dependency.
Diffstat (limited to 'src/engine/SCons')
-rw-r--r--src/engine/SCons/Node/PythonTests.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/engine/SCons/Node/PythonTests.py b/src/engine/SCons/Node/PythonTests.py
index 45248d3..da71074 100644
--- a/src/engine/SCons/Node/PythonTests.py
+++ b/src/engine/SCons/Node/PythonTests.py
@@ -120,7 +120,8 @@ class ValueChildTestCase(unittest.TestCase):
node._func_get_contents = 2 # Pretend to be a Dir.
node.add_to_implicit([value])
contents = node.get_contents()
- assert len(contents) > 0
+ expected_contents = '%s %s\n' % (value.get_csig(), value.name)
+ assert contents == expected_contents
class ValueMemoTestCase(unittest.TestCase):