diff options
| author | Mats Wichmann <mats@linux.com> | 2019-02-14 19:42:00 (GMT) |
|---|---|---|
| committer | Mats Wichmann <mats@linux.com> | 2019-02-14 22:13:16 (GMT) |
| commit | 887f4a1b06ceed33ee6ba4c5589a32a607d6b001 (patch) | |
| tree | 48de09819749eea0e8d134386892397809122769 /test/CacheDir | |
| parent | 334e11d04bb3be2f0ed93f929548e6cdc84c3158 (diff) | |
| download | SCons-887f4a1b06ceed33ee6ba4c5589a32a607d6b001.zip SCons-887f4a1b06ceed33ee6ba4c5589a32a607d6b001.tar.gz SCons-887f4a1b06ceed33ee6ba4c5589a32a607d6b001.tar.bz2 | |
Clean up some tests: use context managers
Plenty of complaints coming from Python 3.8alpha on unclosed files.
Targeted those areas which intersect with PyPy failures - this changeset
reduces the PyPy fails by 17 on the local test environment.
So this affects both Issue #3299 and the PyPy support project.
Signed-off-by: Mats Wichmann <mats@linux.com>
Diffstat (limited to 'test/CacheDir')
| -rw-r--r-- | test/CacheDir/NoCache.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/CacheDir/NoCache.py b/test/CacheDir/NoCache.py index f0929aa..8ecfeb3 100644 --- a/test/CacheDir/NoCache.py +++ b/test/CacheDir/NoCache.py @@ -46,7 +46,8 @@ CacheDir(r'%s') g = '%s' def ActionWithUndeclaredInputs(target,source,env): - open(target[0].get_abspath(),'w').write(g) + with open(target[0].get_abspath(),'w') as f: + f.write(g) Command('foo_cached', [], ActionWithUndeclaredInputs) NoCache(Command('foo_notcached', [], ActionWithUndeclaredInputs)) |