summaryrefslogtreecommitdiffstats
path: root/test/Mkdir.py
diff options
context:
space:
mode:
authorMats Wichmann <mats@linux.com>2019-03-31 13:01:00 (GMT)
committerMats Wichmann <mats@linux.com>2019-04-25 15:37:04 (GMT)
commitf61d3bcd112285644c1a6ce253b267ef690a7e06 (patch)
tree2e489e238c11697f602cb9a7cbeb43afed088734 /test/Mkdir.py
parentb0c3385604ebc1d7d552472f1cc6d0910aafa32a (diff)
downloadSCons-f61d3bcd112285644c1a6ce253b267ef690a7e06.zip
SCons-f61d3bcd112285644c1a6ce253b267ef690a7e06.tar.gz
SCons-f61d3bcd112285644c1a6ce253b267ef690a7e06.tar.bz2
[PY 3.8] test fixes for file closings, rawstrings
On a linux host (missing some things that may be on the Travis CI setup), Py3.8a3 now shows 19 fails, 1048 pass, with 84 Warning: messages. Signed-off-by: Mats Wichmann <mats@linux.com>
Diffstat (limited to 'test/Mkdir.py')
-rw-r--r--test/Mkdir.py24
1 files changed, 12 insertions, 12 deletions
diff --git a/test/Mkdir.py b/test/Mkdir.py
index 8ace476..367c834 100644
--- a/test/Mkdir.py
+++ b/test/Mkdir.py
@@ -41,10 +41,10 @@ Execute(Mkdir('d1'))
Execute(Mkdir(Dir('#d1-Dir')))
def cat(env, source, target):
target = str(target[0])
- f = open(target, "wb")
- for src in source:
- f.write(open(str(src), "rb").read())
- f.close()
+ with open(target, "wb") as f:
+ for src in source:
+ with open(str(src), "rb") as ifp:
+ f.write(ifp.read())
Cat = Action(cat)
env = Environment()
env.Command('f2.out', 'f2.in', [Cat, Mkdir("d3")])
@@ -126,14 +126,14 @@ test.write(['work2', 'SConstruct'], """\
import os
def catdir(env, source, target):
target = str(target[0])
- outfp = open(target, "wb")
- for src in source:
- s = str(src)
- for f in sorted(os.listdir(s)):
- f = os.path.join(s, f)
- if os.path.isfile(f):
- outfp.write(open(f, "rb").read())
- outfp.close()
+ with open(target, "wb") as outfp:
+ for src in source:
+ s = str(src)
+ for f in sorted(os.listdir(s)):
+ f = os.path.join(s, f)
+ if os.path.isfile(f):
+ with open(f, "rb") as infp:
+ outfp.write(infp.read())
CatDir = Builder(action = catdir)
env = Environment(BUILDERS = {'CatDir' : CatDir})
env.Command(Dir('hello'), None, [Mkdir('$TARGET')])