summaryrefslogtreecommitdiffstats
path: root/test/TAR
diff options
context:
space:
mode:
authorMats Wichmann <mats@linux.com>2019-03-31 13:01:00 (GMT)
committerMats Wichmann <mats@linux.com>2019-04-25 15:37:04 (GMT)
commitf61d3bcd112285644c1a6ce253b267ef690a7e06 (patch)
tree2e489e238c11697f602cb9a7cbeb43afed088734 /test/TAR
parentb0c3385604ebc1d7d552472f1cc6d0910aafa32a (diff)
downloadSCons-f61d3bcd112285644c1a6ce253b267ef690a7e06.zip
SCons-f61d3bcd112285644c1a6ce253b267ef690a7e06.tar.gz
SCons-f61d3bcd112285644c1a6ce253b267ef690a7e06.tar.bz2
[PY 3.8] test fixes for file closings, rawstrings
On a linux host (missing some things that may be on the Travis CI setup), Py3.8a3 now shows 19 fails, 1048 pass, with 84 Warning: messages. Signed-off-by: Mats Wichmann <mats@linux.com>
Diffstat (limited to 'test/TAR')
-rw-r--r--test/TAR/TAR.py12
-rw-r--r--test/TAR/TARFLAGS.py14
2 files changed, 15 insertions, 11 deletions
diff --git a/test/TAR/TAR.py b/test/TAR/TAR.py
index 65e6182..159f047 100644
--- a/test/TAR/TAR.py
+++ b/test/TAR/TAR.py
@@ -42,16 +42,18 @@ import sys
opts, args = getopt.getopt(sys.argv[1:], 'cf:')
for opt, arg in opts:
if opt == '-f': out = arg
+
def process(outfile, name):
if os.path.isdir(name):
for entry in sorted(os.listdir(name)):
process(outfile, os.path.join(name, entry))
else:
- outfile.write(open(name, 'r').read())
-outfile = open(out, 'w')
-for infile in args:
- process(outfile, infile)
-outfile.close()
+ with open(name, 'r') as ifp:
+ outfile.write(ifp.read())
+
+with open(out, 'w') as ofp:
+ for infile in args:
+ process(ofp, infile)
sys.exit(0)
""")
diff --git a/test/TAR/TARFLAGS.py b/test/TAR/TARFLAGS.py
index e1eae0f..29a1866 100644
--- a/test/TAR/TARFLAGS.py
+++ b/test/TAR/TARFLAGS.py
@@ -44,17 +44,19 @@ opt_string = ''
for opt, arg in cmd_opts:
if opt == '-f': out = arg
else: opt_string = opt_string + ' ' + opt
+
def process(outfile, name):
if os.path.isdir(name):
for entry in sorted(os.listdir(name)):
process(outfile, os.path.join(name, entry))
else:
- outfile.write(open(name, 'r').read())
-outfile = open(out, 'w')
-outfile.write('options: %s\\n' % opt_string)
-for infile in args:
- process(outfile, infile)
-outfile.close()
+ with open(name, 'r') as ifp:
+ outfile.write(ifp.read())
+
+with open(out, 'w') as ofp:
+ ofp.write('options: %s\\n' % opt_string)
+ for infile in args:
+ process(ofp, infile)
sys.exit(0)
""")