summaryrefslogtreecommitdiffstats
path: root/test
diff options
context:
space:
mode:
authorMats Wichmann <mats@linux.com>2020-05-23 18:07:39 (GMT)
committerMats Wichmann <mats@linux.com>2020-05-25 15:19:42 (GMT)
commitdf7422a008be9236cf7ded05d99704a6b7ce7459 (patch)
tree61b375e5ad65b80a8c93053fed592b25fdbca41d /test
parent47b761fa3f9e24419db48393ca9d6064f7b5d21c (diff)
downloadSCons-df7422a008be9236cf7ded05d99704a6b7ce7459.zip
SCons-df7422a008be9236cf7ded05d99704a6b7ce7459.tar.gz
SCons-df7422a008be9236cf7ded05d99704a6b7ce7459.tar.bz2
Set Tasks class as abstract
needs_execut method set as an abstract method, meaning you can't instantiate Task itself, and derived classes must implement the methid. The former warning framework for this (deprecated) is disabled, and some unit tests that were not implementing needs_execute were fixed - by deriving from the AlwaysTask class. Signed-off-by: Mats Wichmann <mats@linux.com>
Diffstat (limited to 'test')
-rw-r--r--test/Removed/BuildDir/README.md2
-rw-r--r--test/Removed/CacheDir/README.md2
-rw-r--r--test/Removed/Copy-Method/README.md2
-rw-r--r--test/Removed/Old/TaskmasterNeedsExecute.py (renamed from test/Deprecated/TaskmasterNeedsExecute.py)0
-rw-r--r--test/Removed/Old/sconstest.skip0
-rw-r--r--test/Removed/README.md13
-rw-r--r--test/Removed/SourceCode/README.md2
-rw-r--r--test/Removed/SourceSignatures/README.md2
-rw-r--r--test/Removed/TargetSignatures/README.md2
9 files changed, 19 insertions, 6 deletions
diff --git a/test/Removed/BuildDir/README.md b/test/Removed/BuildDir/README.md
index c4fd879..131e67b 100644
--- a/test/Removed/BuildDir/README.md
+++ b/test/Removed/BuildDir/README.md
@@ -1,6 +1,6 @@
BuildDir/Old contains old tests which used the now removed BuildDir
function, env.BuildDir method, and build_dir argument to SConscript,
-preserved here for reference; the presence of an scontest.skip file
+preserved here for reference; the presence of an sconstest.skip file
means they are never executed.
The "new" tests verify failure using these symbols.
diff --git a/test/Removed/CacheDir/README.md b/test/Removed/CacheDir/README.md
index c5b75bf..46fcbc0 100644
--- a/test/Removed/CacheDir/README.md
+++ b/test/Removed/CacheDir/README.md
@@ -1,4 +1,4 @@
CacheDir/Old contains old tests of CacheDir which used the now removed
SourceSignatures and TargetSignatures methods, preserved here for
-reference; the presence of an scontest.skip file means they are never
+reference; the presence of an sconstest.skip file means they are never
executed.
diff --git a/test/Removed/Copy-Method/README.md b/test/Removed/Copy-Method/README.md
index 609c6e4..6352522 100644
--- a/test/Removed/Copy-Method/README.md
+++ b/test/Removed/Copy-Method/README.md
@@ -2,5 +2,5 @@ Copy-Method.py is the "new" test for env.Copy, making sure we
get an AttributeError.
The Old directory is the former tests from the deprecated state,
-preserved here for reference; the presence of an scontest.skip file
+preserved here for reference; the presence of an sconstest.skip file
means they are never executed.
diff --git a/test/Deprecated/TaskmasterNeedsExecute.py b/test/Removed/Old/TaskmasterNeedsExecute.py
index 9f7ade1..9f7ade1 100644
--- a/test/Deprecated/TaskmasterNeedsExecute.py
+++ b/test/Removed/Old/TaskmasterNeedsExecute.py
diff --git a/test/Removed/Old/sconstest.skip b/test/Removed/Old/sconstest.skip
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/test/Removed/Old/sconstest.skip
diff --git a/test/Removed/README.md b/test/Removed/README.md
new file mode 100644
index 0000000..be3f9b9
--- /dev/null
+++ b/test/Removed/README.md
@@ -0,0 +1,13 @@
+This tree contains tests for formerly deprecated behaviors
+that have since been removed.
+
+If there is a runnable test (i.e. a test that verifies a
+particular old behavior actually fails if called), it is
+here or in a subdirectory and is left selectable by the
+test framework.
+
+If there is a test that cannot be run, it will be in a
+subdirectory named Old, which will contain a sconstest.skip
+file, ensuring those test files are never loaded by the
+test framework.
+
diff --git a/test/Removed/SourceCode/README.md b/test/Removed/SourceCode/README.md
index c584dc9..61feaad 100644
--- a/test/Removed/SourceCode/README.md
+++ b/test/Removed/SourceCode/README.md
@@ -2,5 +2,5 @@ SourceCode.py is the "new" test for SourceCode making sure we
get a NameError.
The Old directory is the former tests from the deprecated state,
-preserved here for reference; the presence of an scontest.skip file
+preserved here for reference; the presence of an sconstest.skip file
means they are never executed.
diff --git a/test/Removed/SourceSignatures/README.md b/test/Removed/SourceSignatures/README.md
index 05d8d05..4714a68 100644
--- a/test/Removed/SourceSignatures/README.md
+++ b/test/Removed/SourceSignatures/README.md
@@ -2,5 +2,5 @@ SourceSignatures.py is the "new" test, only makes sure scons actually
fails in the presence of the method or setoption call.
The Old directory is the former tests from the deprecated state,
-preserved here for reference; the presence of an scontest.skip file
+preserved here for reference; the presence of an sconstest.skip file
means they are never executed.
diff --git a/test/Removed/TargetSignatures/README.md b/test/Removed/TargetSignatures/README.md
index 00a8b6b..db00b8c 100644
--- a/test/Removed/TargetSignatures/README.md
+++ b/test/Removed/TargetSignatures/README.md
@@ -2,5 +2,5 @@ TargetSignatures.py is the "new" test, only makes sure scons actually
fails in the presence of the method or setoption call.
The Old directory is the former tests from the deprecated state,
-preserved here for reference; the presence of an scontest.skip file
+preserved here for reference; the presence of an sconstest.skip file
means they are never executed.