summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/engine/SCons/Action.py2
-rw-r--r--src/engine/SCons/Tool/packaging/msi.py2
-rw-r--r--src/test_setup.py4
3 files changed, 4 insertions, 4 deletions
diff --git a/src/engine/SCons/Action.py b/src/engine/SCons/Action.py
index f97d564..fd859ad 100644
--- a/src/engine/SCons/Action.py
+++ b/src/engine/SCons/Action.py
@@ -785,7 +785,7 @@ def _subproc(scons_env, cmd, error = 'ignore', **kw):
kw[stream] = DEVNULL
else:
if sys.platform == 'win32':
- kw[stream] = msvcrt.get_osfhandle(open(os.devnull, "r+"))
+ kw[stream] = msvcrt.get_osfhandle(os.open(os.devnull, os.O_RDWR))
else:
kw[stream] = open(os.devnull, "r+")
diff --git a/src/engine/SCons/Tool/packaging/msi.py b/src/engine/SCons/Tool/packaging/msi.py
index 3a394a0..0ef18ec 100644
--- a/src/engine/SCons/Tool/packaging/msi.py
+++ b/src/engine/SCons/Tool/packaging/msi.py
@@ -447,7 +447,7 @@ def build_license_file(directory, spec):
if text!='':
f.write(text.replace('\n', '\\par '))
else:
- file.write(name+'\\par\\par')
+ f.write(name+'\\par\\par')
f.write('}')
#
diff --git a/src/test_setup.py b/src/test_setup.py
index 75e0533..09865f5 100644
--- a/src/test_setup.py
+++ b/src/test_setup.py
@@ -178,8 +178,8 @@ zip = os.path.join(cwd, 'build', 'dist', '%s.zip' % scons_version)
if os.path.isfile(zip):
try:
import zipfile
- except
- ImportError: pass
+ except ImportError:
+ pass
else:
with zipfile.ZipFile(zip, 'r') as zf: