| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
with current python packaging practices
|
| |
|
|
|
|
|
|
|
| |
FSTests updated to use the suggested way of skipping tests -
a decorator which does the check up front, rather than a
manual check inside the function. Effect: test run will
show 's' rather than '-' on skipped tests.
Signed-off-by: Mats Wichmann <mats@linux.com>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The RootDir class was returning different values for path and _path as well as
different values for abspath and _abspath. This is because the underscored
versions were being set in the RootDir constructor, while the non-underscored
versions were going through the EntryProxy wrapper, which is only coded to do
a simple append of paths.
I considered trying to fix EntryProxy to detect this case but instead went with
a simpler approach where RootDir overrides the attributes that it wants to
avoid EntryProxy calls. Right now I have this as path and abspath.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
dropping < py 3.5
|
| |
|
|
|
|
|
|
| |
These are of the kind that would not be fixed by a code reformat
(Black). These should all be trivial. They're nearly all in unit tests
(all but two), since I haven't cleaned up as many there in the past.
Signed-off-by: Mats Wichmann <mats@linux.com>
|
| |\
| |
| | |
Stop converting to list where not needed
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Python 3 returns a special object, which is iterable, rather than
a list when you ask for dictionary keys(), values(), items(). if
you then proceed to iterate over it it's being used as expected and
doesn't have to be forced to a list first. This occurs a number of
places in this form:
for k in list(something.keys()):
Also there are several places where the code loops over the result
of dict.keys() and then uses the key to index into the dictionary,
this can be replaced by:
for k, v in something.items():
Signed-off-by: Mats Wichmann <mats@linux.com>
|
| | |
| |
| |
| | |
Value()'s
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
This change integrates various review feedback, including:
1. Validates the result of Dir.get_contents() in PythonTests.py.
2. Adds a functional test for having value as a dependency.
|
| |\ \
| |/ |
|
| | |\
| | |
| | | |
Memoize Environment.Value() to improve performance
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The code I work on calls env.Value() often on the same values as part of
consolidating outside dependencies. This change improves performance of that
call by memoizing the results.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Drop unneeded parens.
Drop trailing semicolons.
Triple double-quote docstrings.
Regexes drop unneeded escapes.
Spaces around parens, braces: remove/add.
Some one-tuples get their missing closing comma.
A couple of sets use set init syntax {foo} instead of set([iter]) now.
And a fiddle in Node to reduce lookup time on md5 signature functions
(came about because of a line-too-long issue, initially)
Signed-off-by: Mats Wichmann <mats@linux.com>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
checker-suggested fixes:
Mostly, fix remaining instances of comparing none without "is"
Some trailing whitespace on lines
A couple of instances of list init followed immediately by
several appends, turned into a single list init
Some double comparisons turned into a single expression
Signed-off-by: Mats Wichmann <mats@linux.com>
|
| | |/
| |
| |
| | |
This removes many unnecessary os.stat and related FS IO calls.
|
| | | |
|
| | | |
|
| |/
|
|
|
|
|
|
|
|
|
| |
As part of consolidating outside dependencies, the code I work on takes on
Value objects as implicit dependencies. That allows us to take on a dependecy
to an entire build (e.g. our compiler) rather than 500 files from it.
This has worked fine in practice for months now, but it turns out to break
when using caching, because Node.get_contents() expects all dependencies to
have the "name" attribute. This change adds that attribute to the Value class
and a test to confirm that Node.get_contents() works now.
|
| | |
|
| | |
|
| |
|
|
| |
code
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Also some optimized logic for updating and using the dependency_map built as part of the decider. Fixed tests. Note Deciders now need a fourth argument 'repo_node' which is the repository node for the file if it's to be used. This is currently only used by md5-timestamp decider File.changed_timestamp_then_content()
|
| |
|
|
| |
Also improve exception handling message in test.subdir()
|
| | |
|
| |\
| |
| | |
[wip] Py38warns4 tests
|
| | |
| |
| |
| |
| |
| |
| | |
On a linux host (missing some things that may be on the Travis CI
setup), Py3.8a3 now shows 19 fails, 1048 pass, with 84 Warning: messages.
Signed-off-by: Mats Wichmann <mats@linux.com>
|
| | |
| |
| |
| | |
Signed-off-by: Mats Wichmann <mats@linux.com>
|
| |\ \
| | |
| | | |
Some more lint-derived cleanups
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Consistently use "not is" and "not in", many instances used
the form "not x is y" instead, which pylint objected to.
A couple of bare except clauses got a qualifier.
Files otherwise touched had trailing whitespace cleaned up as well.
These are all things that sider would complain about if a change
happened nearby, so this is pre-emptive.
Signed-off-by: Mats Wichmann <mats@linux.com>
|
| |\ \ |
|
| | |\ \
| | |/
| | |
| | | |
fix_mongo_bug_33111_multiple_targets_via_emitter_spurious_rebuilds
|
