From 733de029b72143b3028ab253a3613dac8b52fa56 Mon Sep 17 00:00:00 2001
From: Joshua Hughes <kivhift@gmail.com>
Date: Mon, 16 Jul 2012 15:35:00 -0400
Subject: Fix issue 2857.

This change fixes issue 2857 by changing Platform.win32._scons_file from a
function to a class.
---
 src/engine/SCons/Platform/win32.py | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/engine/SCons/Platform/win32.py b/src/engine/SCons/Platform/win32.py
index 98dfe45..664969a 100644
--- a/src/engine/SCons/Platform/win32.py
+++ b/src/engine/SCons/Platform/win32.py
@@ -64,13 +64,12 @@ else:
 
     _builtin_file = builtins.file
     _builtin_open = builtins.open
-    
-    def _scons_file(*args, **kw):
-        fp = _builtin_file(*args, **kw)
-        win32api.SetHandleInformation(msvcrt.get_osfhandle(fp.fileno()),
-                                      win32con.HANDLE_FLAG_INHERIT,
-                                      0)
-        return fp
+
+    class _scons_file(_builtin_file):
+        def __init__(self, *args, **kw):
+            _builtin_file.__init__(self, *args, **kw)
+            win32api.SetHandleInformation(msvcrt.get_osfhandle(self.fileno()),
+                win32con.HANDLE_FLAG_INHERIT, 0)
 
     def _scons_open(*args, **kw):
         fp = _builtin_open(*args, **kw)
-- 
cgit v0.12


From 23d33c072049d1509ab24481f157b682e4a0c967 Mon Sep 17 00:00:00 2001
From: Joshua Hughes <kivhift@gmail.com>
Date: Tue, 24 Jul 2012 10:48:33 -0400
Subject: Add test for issue-2857 fix.

The test makes sure that inheriting from file works as it should.
---
 test/Win32/file-is-type-not-func.py | 57 +++++++++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)
 create mode 100644 test/Win32/file-is-type-not-func.py

diff --git a/test/Win32/file-is-type-not-func.py b/test/Win32/file-is-type-not-func.py
new file mode 100644
index 0000000..6cce1d5
--- /dev/null
+++ b/test/Win32/file-is-type-not-func.py
@@ -0,0 +1,57 @@
+#!/usr/bin/env python
+#
+# __COPYRIGHT__
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
+# KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
+# WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+#
+
+"""
+This test verifies that file isn't redefined incorrectly as a function on
+Windows systems.  It's a built-in type and should thus be inheritable.
+"""
+
+__revision__ = "__FILE__ __REVISION__ __DATE__ __DEVELOPER__"
+
+import sys
+
+import TestSCons
+
+test = TestSCons.TestSCons()
+
+if sys.platform != 'win32':
+    test.skip_test(
+        'Skipping file-type test on non-Windows platform: %s\n' % sys.platform)
+
+test.write('SConstruct', """
+env = Environment()
+class AFile(file): pass
+""")
+
+# If file is redefined as a function, trying to inherit from it causes SCons to
+# die.
+test.run(arguments = '.')
+
+test.pass_test()
+
+# Local Variables:
+# tab-width:4
+# indent-tabs-mode:nil
+# End:
+# vim: set expandtab tabstop=4 shiftwidth=4:
-- 
cgit v0.12