From b833b65e5367aab1bf8f6f5a101f8b0923e9433c Mon Sep 17 00:00:00 2001 From: Ben Webb Date: Fri, 3 Apr 2009 17:10:22 +0000 Subject: Use SCons.Action._subproc rather than os.popen. --- src/engine/SCons/Tool/swig.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/engine/SCons/Tool/swig.py b/src/engine/SCons/Tool/swig.py index c7af701..92c93de 100644 --- a/src/engine/SCons/Tool/swig.py +++ b/src/engine/SCons/Tool/swig.py @@ -36,6 +36,7 @@ __revision__ = "__FILE__ __REVISION__ __DATE__ __DEVELOPER__" import os.path import re import string +import subprocess import SCons.Action import SCons.Defaults @@ -121,7 +122,13 @@ def _swigEmitter(target, source, env): def _get_swig_version(env): """Run the SWIG command line tool to get and return the version number""" - out = os.popen(env['SWIG'] + ' -version').read() + pipe = SCons.Action._subproc(env, [env['SWIG'], '-version'], + stdin = 'devnull', + stderr = 'devnull', + stdout = subprocess.PIPE) + if pipe.wait() != 0: return + + out = pipe.stdout.read() match = re.search(r'SWIG Version\s+(\S+)$', out, re.MULTILINE) if match: return match.group(1) -- cgit v0.12