From 04ffc9290157c8643f25404b6469b423589ee72d Mon Sep 17 00:00:00 2001 From: William Deegan Date: Tue, 26 Jan 2016 08:18:40 -0800 Subject: Minor nit fixes. Typos and better comments --- src/CHANGES.txt | 2 +- test/Batch/changed_sources_alwaysbuild.py | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/CHANGES.txt b/src/CHANGES.txt index ad88f3d..dc8a281 100644 --- a/src/CHANGES.txt +++ b/src/CHANGES.txt @@ -23,7 +23,7 @@ RELEASE VERSION/DATE TO BE FILLED IN LATER - Add better messaging when two environments have different actions for the same target (Bug #2024) - Fix issue only with MSVC and Always build where targets - marked AlwaysBuild wouldn't make it into CHANNGED_SOURCES + marked AlwaysBuild wouldn't make it into CHANGED_SOURCES and thus yield an empty compile command line. (Bug #2622) diff --git a/test/Batch/changed_sources_alwaysbuild.py b/test/Batch/changed_sources_alwaysbuild.py index 4446f2d..ba947d6 100644 --- a/test/Batch/changed_sources_alwaysbuild.py +++ b/test/Batch/changed_sources_alwaysbuild.py @@ -37,9 +37,12 @@ test.file_fixture('changed_sources_main.cpp') # always works on first run test.run() -# second run prior to fix, the file hasn't changes and so never +# On second run prior to fix the file hasn't changed and so never # makes it into CHANGED_SOURCES. -# Compile is triggered because SCons knows it needs to build it +# Compile is triggered because SCons knows it needs to build it. +# This tests that on second run the source file is in the scons +# output. Also prior to fix the compile would fail because +# it would produce a compile command line lacking a source file. test.run() test.must_contain_all_lines(test.stdout(),['changed_sources_main.cpp']) test.pass_test() -- cgit v0.12