From be3df70c02915d0c10f11c7f03fe9c1f907490a1 Mon Sep 17 00:00:00 2001 From: Gary Oberbrunner Date: Thu, 17 Jun 2010 02:32:24 +0000 Subject: Fix #2574: case sensitivity issue with Fortran module scanner. --- src/CHANGES.txt | 4 +++ src/engine/SCons/Scanner/Fortran.py | 6 ++-- test/Fortran/USE-MODULE-CASEINSENS.py | 66 +++++++++++++++++++++++++++++++++++ 3 files changed, 73 insertions(+), 3 deletions(-) create mode 100644 test/Fortran/USE-MODULE-CASEINSENS.py diff --git a/src/CHANGES.txt b/src/CHANGES.txt index 7962c57..b784d5c 100644 --- a/src/CHANGES.txt +++ b/src/CHANGES.txt @@ -7,6 +7,10 @@ RELEASE 2.1.0.alpha.yyyymmdd - NEW DATE WILL BE INSERTED HERE + From Joe Zuntz: + + - Fixed a case-sensitivity problem with Fortran modules. + From Bauke Conijn: - Added Users Guide example for auto-generated source code diff --git a/src/engine/SCons/Scanner/Fortran.py b/src/engine/SCons/Scanner/Fortran.py index 29af9aa..1b55130 100644 --- a/src/engine/SCons/Scanner/Fortran.py +++ b/src/engine/SCons/Scanner/Fortran.py @@ -89,11 +89,11 @@ class F90Scanner(SCons.Scanner.Classic): defmodules = self.cre_def.findall(node.get_text_contents()) # Remove all USE'd module names that are defined in the same file + # (case-insensitively) d = {} for m in defmodules: - d[m] = 1 - modules = [m for m in modules if m not in d] - #modules = self.undefinedModules(modules, defmodules) + d[m.lower()] = 1 + modules = [m for m in modules if m.lower() not in d] # Convert module name to a .mod filename suffix = env.subst('$FORTRANMODSUFFIX') diff --git a/test/Fortran/USE-MODULE-CASEINSENS.py b/test/Fortran/USE-MODULE-CASEINSENS.py new file mode 100644 index 0000000..79d5125 --- /dev/null +++ b/test/Fortran/USE-MODULE-CASEINSENS.py @@ -0,0 +1,66 @@ +#!/usr/bin/env python +# +# __COPYRIGHT__ +# +# Permission is hereby granted, free of charge, to any person obtaining +# a copy of this software and associated documentation files (the +# "Software"), to deal in the Software without restriction, including +# without limitation the rights to use, copy, modify, merge, publish, +# distribute, sublicense, and/or sell copies of the Software, and to +# permit persons to whom the Software is furnished to do so, subject to +# the following conditions: +# +# The above copyright notice and this permission notice shall be included +# in all copies or substantial portions of the Software. +# +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY +# KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE +# WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND +# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE +# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION +# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION +# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. +# + +__revision__ = "__FILE__ __REVISION__ __DATE__ __DEVELOPER__" + +# This test tests whether a file that defines a module "a" and +# then uses it with a different case ("A") works. Pre-2.0, this +# gave a spurious dependency cycle error. See Tigris issue #2574. + +import TestSCons + +_python_ = TestSCons._python_ +_exe = TestSCons._exe + +test = TestSCons.TestSCons() + +test.write('myfortran.py', r""" +# dummy fortran +import sys +sys.exit(0) +""") + +test.write('SConstruct', """ +env = Environment(FORTRANCOM = r'%(_python_)s myfortran.py $SOURCE $TARGET') +env.Object("mod1", "mod1.f") +""" % locals()) + +test.write('mod1.f', """\ +module a +end module a + +module b + use A +end module b +""") + +test.run(arguments = '.', stderr = None) + +test.pass_test() + +# Local Variables: +# tab-width:4 +# indent-tabs-mode:nil +# End: +# vim: set expandtab tabstop=4 shiftwidth=4: -- cgit v0.12