From 089d13cd63a502e300551df94134445a572b8baa Mon Sep 17 00:00:00 2001 From: William Deegan Date: Thu, 15 Mar 2018 13:36:51 -0700 Subject: TODO item for caching EnvironmentValue creation.. There should be only one EnvironmentValue per string.. though we may have issues dealing with non-string (lists, dictionaries,etc) --- src/engine/SCons/EnvironmentValue.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/engine/SCons/EnvironmentValue.py b/src/engine/SCons/EnvironmentValue.py index 593097a..7d82629 100644 --- a/src/engine/SCons/EnvironmentValue.py +++ b/src/engine/SCons/EnvironmentValue.py @@ -126,6 +126,7 @@ class EnvironmentValue(object): We're going to keep track of variables which feed into this values evaluation """ def __init__(self, value): + # TODO: Should cache initialziation by keeping hash all previous values, since we don't evaluate in context in the Value itself. self.value = value self.var_type = ValueTypes.UNKNOWN self._parsed = [] -- cgit v0.12