diff options
| author | Eric Snow <ericsnowcurrently@gmail.com> | 2023-03-14 16:05:54 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-14 16:05:54 (GMT) |
| commit | 1ff81c0cb67215694f084e51c4d35ae53b9f5cf9 (patch) | |
| tree | e8067aff7f52f7b17284caa3452b17a98a9ae1bc /.github | |
| parent | a703f743dbf2675948e59c44fa9d7112f7825100 (diff) | |
| download | cpython-1ff81c0cb67215694f084e51c4d35ae53b9f5cf9.zip cpython-1ff81c0cb67215694f084e51c4d35ae53b9f5cf9.tar.gz cpython-1ff81c0cb67215694f084e51c4d35ae53b9f5cf9.tar.bz2 | |
gh-81057: Add a CI Check for New Unsupported C Global Variables (gh-102506)
This will keep us from adding new unsupported (i.e. non-const) C global variables, which would break interpreter isolation.
FYI, historically it is very uncommon for new global variables to get added. Furthermore, it is rare for new code to break the c-analyzer. So the check should almost always pass unnoticed.
Note that I've removed test_check_c_globals. A test wasn't a great fit conceptually and was super slow on debug builds. A CI check is a better fit.
This also resolves gh-100237.
https://github.com/python/cpython/issues/81057
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/build.yml | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2241b0b..4e53282 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -111,6 +111,9 @@ jobs: run: make smelly - name: Check limited ABI symbols run: make check-limited-abi + - name: Check for unsupported C global variables + if: github.event_name == 'pull_request' # $GITHUB_EVENT_NAME + run: make check-c-globals build_win32: name: 'Windows (x86)' |