diff options
| author | Neal Norwitz <nnorwitz@gmail.com> | 2007-10-05 05:05:24 (GMT) |
|---|---|---|
| committer | Neal Norwitz <nnorwitz@gmail.com> | 2007-10-05 05:05:24 (GMT) |
| commit | c9f22b954fd8b35eae4adef0652d27473edfdd44 (patch) | |
| tree | cc258f95112d0318830018a3a2c83d430d8bf7bc | |
| parent | 14f848bb22e88cac0010980e34caf11d00331740 (diff) | |
| download | cpython-c9f22b954fd8b35eae4adef0652d27473edfdd44.zip cpython-c9f22b954fd8b35eae4adef0652d27473edfdd44.tar.gz cpython-c9f22b954fd8b35eae4adef0652d27473edfdd44.tar.bz2 | |
Backport 58332: Fix Coverity #159.
This code was broken if save() returned a negative number since i contained
a boolean value and then we compared i < 0 which should never be true.
| -rw-r--r-- | Modules/cPickle.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Modules/cPickle.c b/Modules/cPickle.c index dd9887b..b552a40 100644 --- a/Modules/cPickle.c +++ b/Modules/cPickle.c @@ -2249,7 +2249,7 @@ save_reduce(Picklerobject *self, PyObject *args, PyObject *ob) Py_INCREF(temp); PyTuple_SET_ITEM(newargtup, i-1, temp); } - i = save(self, newargtup, 0) < 0; + i = save(self, newargtup, 0); Py_DECREF(newargtup); if (i < 0) return -1; |