diff options
| author | Benjamin Peterson <benjamin@python.org> | 2013-01-09 15:52:01 (GMT) |
|---|---|---|
| committer | Benjamin Peterson <benjamin@python.org> | 2013-01-09 15:52:01 (GMT) |
| commit | 0c270a8bb748f09b7de6f6ce21d405e0c83be329 (patch) | |
| tree | a8b6e4c9160dd5ca34c2d7707c6530c3a7f68461 | |
| parent | 7131749959e674ae347e34efabdc6291b21cbe43 (diff) | |
| download | cpython-0c270a8bb748f09b7de6f6ce21d405e0c83be329.zip cpython-0c270a8bb748f09b7de6f6ce21d405e0c83be329.tar.gz cpython-0c270a8bb748f09b7de6f6ce21d405e0c83be329.tar.bz2 | |
correct static string clearing loop (closes #16906)
| -rw-r--r-- | Misc/NEWS | 3 | ||||
| -rw-r--r-- | Objects/unicodeobject.c | 15 |
2 files changed, 12 insertions, 6 deletions
@@ -12,6 +12,9 @@ What's New in Python 3.3.1? Core and Builtins ----------------- +- Issue #16906: Fix a logic error that prevented most static strings from being + cleared. + - Issue #11461: Fix the incremental UTF-16 decoder. Original patch by Amaury Forgeot d'Arc. diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index b4fc004..16d5929 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -1826,12 +1826,15 @@ _PyUnicode_FromId(_Py_Identifier *id) void _PyUnicode_ClearStaticStrings() { - _Py_Identifier *i; - for (i = static_strings; i; i = i->next) { - Py_DECREF(i->object); - i->object = NULL; - i->next = NULL; - } + _Py_Identifier *tmp, *s = static_strings; + while (s) { + Py_DECREF(s->object); + s->object = NULL; + tmp = s->next; + s->next = NULL; + s = tmp; + } + static_strings = NULL; } /* Internal function, doesn't check maximum character */ |