summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGregory P. Smith <greg@krypto.org>2013-11-17 22:19:32 (GMT)
committerGregory P. Smith <greg@krypto.org>2013-11-17 22:19:32 (GMT)
commit162307fa3558341b82570a42b2f023b9623df822 (patch)
tree102e850a479efe08715d76d3c2b7f5de6b04448f
parent7929a1da1a6d18894210ff82f6107e51d7566bb0 (diff)
downloadcpython-162307fa3558341b82570a42b2f023b9623df822.zip
cpython-162307fa3558341b82570a42b2f023b9623df822.tar.gz
cpython-162307fa3558341b82570a42b2f023b9623df822.tar.bz2
Fix test.support.bind_port() to not cause an error when Python was compiled
on a system with SO_REUSEPORT defined in the headers but run on a system with an OS kernel that does not support that reasonably new socket option.
-rw-r--r--Lib/test/support/__init__.py12
-rw-r--r--Misc/NEWS4
2 files changed, 13 insertions, 3 deletions
diff --git a/Lib/test/support/__init__.py b/Lib/test/support/__init__.py
index dbd7846..233b13a 100644
--- a/Lib/test/support/__init__.py
+++ b/Lib/test/support/__init__.py
@@ -570,9 +570,15 @@ def bind_port(sock, host=HOST):
raise TestFailed("tests should never set the SO_REUSEADDR " \
"socket option on TCP/IP sockets!")
if hasattr(socket, 'SO_REUSEPORT'):
- if sock.getsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT) == 1:
- raise TestFailed("tests should never set the SO_REUSEPORT " \
- "socket option on TCP/IP sockets!")
+ try:
+ if sock.getsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT) == 1:
+ raise TestFailed("tests should never set the SO_REUSEPORT " \
+ "socket option on TCP/IP sockets!")
+ except OSError:
+ # Python's socket module was compiled using modern headers
+ # thus defining SO_REUSEPORT but this process is running
+ # under an older kernel that does not support SO_REUSEPORT.
+ pass
if hasattr(socket, 'SO_EXCLUSIVEADDRUSE'):
sock.setsockopt(socket.SOL_SOCKET, socket.SO_EXCLUSIVEADDRUSE, 1)
diff --git a/Misc/NEWS b/Misc/NEWS
index c30c6bc..1ea0e47 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -13,6 +13,10 @@ Core and Builtins
Library
-------
+- Fix test.support.bind_port() to not cause an error when Python was compiled
+ on a system with SO_REUSEPORT defined in the headers but run on a system
+ with an OS kernel that does not support that reasonably new socket option.
+
- Fix compilation error under gcc of the ctypes module bundled libffi for arm.
- Issue #19523: Closed FileHandler leak which occurred when delay was set.