diff options
author | Gregory P. Smith <greg@krypto.org> | 2013-11-17 22:21:02 (GMT) |
---|---|---|
committer | Gregory P. Smith <greg@krypto.org> | 2013-11-17 22:21:02 (GMT) |
commit | b6e622d184604771088b5d2dd4f4cf0cddb2a3ae (patch) | |
tree | 98126d5e495981274e9bd8b25e5f0a1cf69967cd | |
parent | 61b976f12714fe6dbea5d9da52e2c814f4a0522a (diff) | |
parent | 162307fa3558341b82570a42b2f023b9623df822 (diff) | |
download | cpython-b6e622d184604771088b5d2dd4f4cf0cddb2a3ae.zip cpython-b6e622d184604771088b5d2dd4f4cf0cddb2a3ae.tar.gz cpython-b6e622d184604771088b5d2dd4f4cf0cddb2a3ae.tar.bz2 |
Fix test.support.bind_port() to not cause an error when Python was compiled
on a system with SO_REUSEPORT defined in the headers but run on a system
with an OS kernel that does not support that reasonably new socket option.
-rw-r--r-- | Lib/test/support/__init__.py | 12 | ||||
-rw-r--r-- | Misc/NEWS | 4 |
2 files changed, 13 insertions, 3 deletions
diff --git a/Lib/test/support/__init__.py b/Lib/test/support/__init__.py index 20a5e85..b6a430e 100644 --- a/Lib/test/support/__init__.py +++ b/Lib/test/support/__init__.py @@ -594,9 +594,15 @@ def bind_port(sock, host=HOST): raise TestFailed("tests should never set the SO_REUSEADDR " \ "socket option on TCP/IP sockets!") if hasattr(socket, 'SO_REUSEPORT'): - if sock.getsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT) == 1: - raise TestFailed("tests should never set the SO_REUSEPORT " \ - "socket option on TCP/IP sockets!") + try: + if sock.getsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT) == 1: + raise TestFailed("tests should never set the SO_REUSEPORT " \ + "socket option on TCP/IP sockets!") + except OSError: + # Python's socket module was compiled using modern headers + # thus defining SO_REUSEPORT but this process is running + # under an older kernel that does not support SO_REUSEPORT. + pass if hasattr(socket, 'SO_EXCLUSIVEADDRUSE'): sock.setsockopt(socket.SOL_SOCKET, socket.SO_EXCLUSIVEADDRUSE, 1) @@ -50,6 +50,10 @@ Core and Builtins Library ------- +- Fix test.support.bind_port() to not cause an error when Python was compiled + on a system with SO_REUSEPORT defined in the headers but run on a system + with an OS kernel that does not support that reasonably new socket option. + - Fix compilation error under gcc of the ctypes module bundled libffi for arm. - Issue #19448: Add private API to SSL module to lookup ASN.1 objects by OID, |