summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorÉric Araujo <merwok@netwok.org>2012-03-07 20:00:44 (GMT)
committerÉric Araujo <merwok@netwok.org>2012-03-07 20:00:44 (GMT)
commitec17afdfdac9aa30fc4ec8e6a5153474ab8d32f4 (patch)
tree7d4a2f9d48dfe868eb0580941b0e7f90034b49d9
parentd6a80ee2c76bbeceaa49650dc3b2455bbc655b2f (diff)
downloadcpython-ec17afdfdac9aa30fc4ec8e6a5153474ab8d32f4.zip
cpython-ec17afdfdac9aa30fc4ec8e6a5153474ab8d32f4.tar.gz
cpython-ec17afdfdac9aa30fc4ec8e6a5153474ab8d32f4.tar.bz2
Backout buggy patch for #13719
-rw-r--r--Lib/distutils/command/bdist_msi.py2
-rw-r--r--Lib/distutils/tests/test_bdist_msi.py9
-rw-r--r--Misc/NEWS2
3 files changed, 1 insertions, 12 deletions
diff --git a/Lib/distutils/command/bdist_msi.py b/Lib/distutils/command/bdist_msi.py
index 09c6a89..703f873 100644
--- a/Lib/distutils/command/bdist_msi.py
+++ b/Lib/distutils/command/bdist_msi.py
@@ -262,7 +262,7 @@ class bdist_msi (Command):
self.db.Commit()
if hasattr(self.distribution, 'dist_files'):
- tup = 'bdist_msi', self.target_version or 'any', installer_name
+ tup = 'bdist_msi', self.target_version or 'any', fullname
self.distribution.dist_files.append(tup)
if not self.keep_temp:
diff --git a/Lib/distutils/tests/test_bdist_msi.py b/Lib/distutils/tests/test_bdist_msi.py
index 82a20cf..f98b7a2 100644
--- a/Lib/distutils/tests/test_bdist_msi.py
+++ b/Lib/distutils/tests/test_bdist_msi.py
@@ -1,5 +1,4 @@
"""Tests for distutils.command.bdist_msi."""
-import os
import sys
import unittest
from test.test_support import run_unittest
@@ -17,14 +16,6 @@ class BDistMSITestCase(support.TempdirManager,
project_dir, dist = self.create_dist()
cmd = bdist_msi(dist)
cmd.ensure_finalized()
- cmd.run()
-
- bdists = os.listdir(os.path.join(project_dir, 'dist'))
- self.assertEqual(bdists, ['foo-0.1.msi'])
-
- # bug #13719: upload ignores bdist_msi files
- self.assertEqual(dist.dist_files,
- [('bdist_msi', 'any', 'dist/foo-0.1.msi')])
def test_suite():
diff --git a/Misc/NEWS b/Misc/NEWS
index 4fe056d..89b6471 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -101,8 +101,6 @@ Core and Builtins
Library
-------
-- Issue #13719: Make the distutils upload command aware of bdist_msi products.
-
- Issue #14195: An issue that caused weakref.WeakSet instances to incorrectly
return True for a WeakSet instance 'a' in both 'a < a' and 'a > a' has been
fixed.