summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFredrik Lundh <fredrik@pythonware.com>2000-08-27 19:15:31 (GMT)
committerFredrik Lundh <fredrik@pythonware.com>2000-08-27 19:15:31 (GMT)
commit2f15b25da2060ab723e0bb82a8f4f713d547b2b8 (patch)
tree09ab0cf972b91f2c24524e927960fd0d23f4bd55
parent0ae722e0a21e7fff58e94f6b62b6340761312f7e (diff)
downloadcpython-2f15b25da2060ab723e0bb82a8f4f713d547b2b8.zip
cpython-2f15b25da2060ab723e0bb82a8f4f713d547b2b8.tar.gz
cpython-2f15b25da2060ab723e0bb82a8f4f713d547b2b8.tar.bz2
implements PyOS_CheckStack for Windows and MSVC. this fixes a
couple of potential stack overflows, including bug #110615. closes patch #101238
-rw-r--r--Include/pythonrun.h14
-rw-r--r--Python/pythonrun.c29
2 files changed, 42 insertions, 1 deletions
diff --git a/Include/pythonrun.h b/Include/pythonrun.h
index c217570..0528702 100644
--- a/Include/pythonrun.h
+++ b/Include/pythonrun.h
@@ -87,8 +87,20 @@ DL_IMPORT(void) PyOS_FiniInterrupts(void);
DL_IMPORT(char *) PyOS_Readline(char *);
extern DL_IMPORT(int) (*PyOS_InputHook)(void);
extern DL_IMPORT(char) *(*PyOS_ReadlineFunctionPointer)(char *);
+
+/* Stack size, in "pointers" (so we get extra safety margins
+ on 64-bit platforms). On a 32-bit platform, this translates
+ to a 8k margin. */
+#define PYOS_STACK_MARGIN 2048
+
+#if defined(WIN32) && defined(_MSC_VER)
+/* Enable stack checking under Microsoft C */
+#define USE_STACKCHECK
+#endif
+
#ifdef USE_STACKCHECK
-int PyOS_CheckStack(void); /* Check that we aren't overflowing our stack */
+/* Check that we aren't overflowing our stack */
+DL_IMPORT(int) PyOS_CheckStack(void);
#endif
#ifdef __cplusplus
diff --git a/Python/pythonrun.c b/Python/pythonrun.c
index 8d571c3..e951ccd 100644
--- a/Python/pythonrun.c
+++ b/Python/pythonrun.c
@@ -1165,3 +1165,32 @@ Py_FdIsInteractive(FILE *fp, char *filename)
(strcmp(filename, "<stdin>") == 0) ||
(strcmp(filename, "???") == 0);
}
+
+
+#if defined(USE_STACKCHECK)
+#if defined(WIN32) && defined(_MSC_VER)
+
+/* Stack checking for Microsoft C */
+
+#include <malloc.h>
+#include <excpt.h>
+
+int
+PyOS_CheckStack()
+{
+ __try {
+ /* _alloca throws a stack overflow exception if there's
+ not enough space left on the stack */
+ _alloca(PYOS_STACK_MARGIN * sizeof(void*));
+ return 0;
+ } __except (EXCEPTION_EXECUTE_HANDLER) {
+ /* just ignore all errors */
+ }
+ return 1;
+}
+
+#endif /* WIN32 && _MSC_VER */
+
+/* Alternate implementations can be added here... */
+
+#endif /* USE_STACKCHECK */