summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTim Peters <tim.peters@gmail.com>2001-01-27 06:20:08 (GMT)
committerTim Peters <tim.peters@gmail.com>2001-01-27 06:20:08 (GMT)
commit547397c45b4c6334ac6e8ee713de012a05a4fe4a (patch)
tree4faa256c13c8df4cfc4c031de0e7ebf6b71b5715
parent40ead76ed67f345ae0c7b92072033166408535ad (diff)
downloadcpython-547397c45b4c6334ac6e8ee713de012a05a4fe4a.zip
cpython-547397c45b4c6334ac6e8ee713de012a05a4fe4a.tar.gz
cpython-547397c45b4c6334ac6e8ee713de012a05a4fe4a.tar.bz2
SF bug http://sourceforge.net/bugs/?func=detailbug&bug_id=130242&group_id=5470
SF patch http://sourceforge.net/patch/?func=detailpatch&patch_id=103453&group_id=5470 PyMember_Set of T_CHAR always raises exception. Unfortunately, this is a use of a C API function that Python itself never makes, so there's no .py test I can check in to verify this stays fixed. But the fault in the code is obvious, and Dave Cole's patch just as obviously fixes it.
-rw-r--r--Misc/ACKS1
-rw-r--r--Python/structmember.c1
2 files changed, 2 insertions, 0 deletions
diff --git a/Misc/ACKS b/Misc/ACKS
index 9568547..554203f 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -72,6 +72,7 @@ Tom Christiansen
Vadim Chugunov
Mike Clarkson
Steve Clift
+Dave Cole
Jeffery Collins
Matt Conway
Scott Cotton
diff --git a/Python/structmember.c b/Python/structmember.c
index bc1ba25..e155a6b 100644
--- a/Python/structmember.c
+++ b/Python/structmember.c
@@ -231,6 +231,7 @@ PyMember_Set(char *addr, struct memberlist *mlist, char *name, PyObject *v)
PyErr_BadArgument();
return -1;
}
+ break;
default:
PyErr_SetString(PyExc_SystemError,
"bad memberlist type");