diff options
| author | Mark Dickinson <dickinsm@gmail.com> | 2009-03-29 14:37:51 (GMT) |
|---|---|---|
| committer | Mark Dickinson <dickinsm@gmail.com> | 2009-03-29 14:37:51 (GMT) |
| commit | 2e648ecc7d7339b0a932a64c521cae8da791bfcd (patch) | |
| tree | e3fe18c1e8b6f0e1ce332502a343af8b79706568 | |
| parent | 310916212e3320b3b100ff57bbc4ce5331ca1cfe (diff) | |
| download | cpython-2e648ecc7d7339b0a932a64c521cae8da791bfcd.zip cpython-2e648ecc7d7339b0a932a64c521cae8da791bfcd.tar.gz cpython-2e648ecc7d7339b0a932a64c521cae8da791bfcd.tar.bz2 | |
Issue #532631: Replace confusing fabs(x)/1e25 >= 1e25 test
with fabs(x) >= 1e50, and fix documentation.
| -rw-r--r-- | Doc/library/stdtypes.rst | 2 | ||||
| -rw-r--r-- | Objects/stringlib/formatter.h | 2 | ||||
| -rw-r--r-- | Objects/stringobject.c | 2 | ||||
| -rw-r--r-- | Objects/unicodeobject.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/Doc/library/stdtypes.rst b/Doc/library/stdtypes.rst index f3ff505..2e54039 100644 --- a/Doc/library/stdtypes.rst +++ b/Doc/library/stdtypes.rst @@ -1409,7 +1409,7 @@ that ``'\0'`` is the end of the string. .. XXX Examples? For safety reasons, floating point precisions are clipped to 50; ``%f`` -conversions for numbers whose absolute value is over 1e25 are replaced by ``%g`` +conversions for numbers whose absolute value is over 1e50 are replaced by ``%g`` conversions. [#]_ All other errors raise exceptions. .. index:: diff --git a/Objects/stringlib/formatter.h b/Objects/stringlib/formatter.h index 2e3e5a6..86235a6 100644 --- a/Objects/stringlib/formatter.h +++ b/Objects/stringlib/formatter.h @@ -789,7 +789,7 @@ format_float_internal(PyObject *value, if (precision < 0) precision = 6; - if (type == 'f' && (fabs(x) / 1e25) >= 1e25) + if (type == 'f' && fabs(x) >= 1e50) type = 'g'; /* cast "type", because if we're in unicode we need to pass a diff --git a/Objects/stringobject.c b/Objects/stringobject.c index 8f82f4f..3b5d331 100644 --- a/Objects/stringobject.c +++ b/Objects/stringobject.c @@ -4344,7 +4344,7 @@ formatfloat(char *buf, size_t buflen, int flags, } if (prec < 0) prec = 6; - if (type == 'f' && fabs(x)/1e25 >= 1e25) + if (type == 'f' && fabs(x) >= 1e50) type = 'g'; /* Worst case length calc to ensure no buffer overrun: diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index 107ed29..4ce9bed 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -8286,7 +8286,7 @@ formatfloat(Py_UNICODE *buf, return -1; if (prec < 0) prec = 6; - if (type == 'f' && (fabs(x) / 1e25) >= 1e25) + if (type == 'f' && fabs(x) >= 1e50) type = 'g'; /* Worst case length calc to ensure no buffer overrun: |