summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrett Cannon <bcannon@gmail.com>2010-06-26 22:29:06 (GMT)
committerBrett Cannon <bcannon@gmail.com>2010-06-26 22:29:06 (GMT)
commit620c6c760dd8e596b0c630fed736f2a958b09d4a (patch)
tree6e51df663779b49646a4816cfb9dd8d675084b8e
parent1341f57c9f5502ad3cb7247f53d1bca784f296e4 (diff)
downloadcpython-620c6c760dd8e596b0c630fed736f2a958b09d4a.zip
cpython-620c6c760dd8e596b0c630fed736f2a958b09d4a.tar.gz
cpython-620c6c760dd8e596b0c630fed736f2a958b09d4a.tar.bz2
Having CFLAGS come before OPT prevents silencing certain classes of warnings
from the fact that OPT contains -Wall be default. This is annoying when compilers like clang have thorough debugging information about things that Python does extensively (e.g. -Wunused-value for unused return values caused by a macro use).
-rw-r--r--Makefile.pre.in2
-rw-r--r--Misc/NEWS2
2 files changed, 3 insertions, 1 deletions
diff --git a/Makefile.pre.in b/Makefile.pre.in
index 69a3199..2b36b87 100644
--- a/Makefile.pre.in
+++ b/Makefile.pre.in
@@ -59,7 +59,7 @@ MAKESETUP= $(srcdir)/Modules/makesetup
# Compiler options
OPT= @OPT@
BASECFLAGS= @BASECFLAGS@
-CFLAGS= $(BASECFLAGS) @CFLAGS@ $(OPT) $(EXTRA_CFLAGS)
+CFLAGS= $(BASECFLAGS) $(OPT) @CFLAGS@ $(EXTRA_CFLAGS)
# Both CPPFLAGS and LDFLAGS need to contain the shell's value for setup.py to
# be able to build extension modules using the directories specified in the
# environment variables
diff --git a/Misc/NEWS b/Misc/NEWS
index 982ef70..a9b19dc 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -1461,6 +1461,8 @@ Extension Modules
Build
-----
+- Have CFLAGS come after OPT to allow for overriding warnings flags.
+
- Issue #8854: Fix finding Visual Studio 2008 on Windows x64.
- Issue #1759169, #8864: Drop _XOPEN_SOURCE on Solaris, define it for